[00:03:01] (03PS2) 10Mooeypoo: Make sure there is a page before focusing in BookletLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187264 (https://phabricator.wikimedia.org/T87787) [00:03:22] (03CR) 10TheDJ: "So the problem here is that something like ButtonInputWidget is using ButtonElement directly and missing out on this behavior." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [00:03:26] (03CR) 10Catrope: [C: 032] Make sure there is a page before focusing in BookletLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187264 (https://phabricator.wikimedia.org/T87787) (owner: 10Mooeypoo) [00:09:18] (03Merged) 10jenkins-bot: Make sure there is a page before focusing in BookletLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187264 (https://phabricator.wikimedia.org/T87787) (owner: 10Mooeypoo) [00:12:52] (03PS8) 10Bartosz Dziewoński: Provide default margins for buttons and other widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) [00:12:54] (03PS1) 10Bartosz Dziewoński: RadioOptionWidget: Remove weird unnecessary padding [oojs/ui] - 10https://gerrit.wikimedia.org/r/187291 [00:14:07] (03CR) 10jenkins-bot: [V: 04-1] RadioOptionWidget: Remove weird unnecessary padding [oojs/ui] - 10https://gerrit.wikimedia.org/r/187291 (owner: 10Bartosz Dziewoński) [00:15:28] (03Abandoned) 10Bartosz Dziewoński: RadioOptionWidget: Remove weird unnecessary padding [oojs/ui] - 10https://gerrit.wikimedia.org/r/187291 (owner: 10Bartosz Dziewoński) [00:16:50] (03PS9) 10Bartosz Dziewoński: Provide default margins for buttons and other widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) [00:16:53] ori: I need some help dealing with osmium when you have time [00:16:58] 3OOjs-UI: Dialogs are not properly labelled - https://phabricator.wikimedia.org/T87826#1000096 (10TheDJ) 3NEW [00:17:13] (03CR) 10Bartosz Dziewoński: "This is actually mostly sensible now." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) (owner: 10Bartosz Dziewoński) [00:17:28] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#1000110 (10Ricordisamoa) @Krenair: should I abandon my patch then? [00:18:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Per inline discussion." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [00:20:51] (03PS3) 10Bartosz Dziewoński: OptionWidget: Unbreak 'pressed' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186547 [00:21:56] (03CR) 10jenkins-bot: [V: 04-1] OptionWidget: Unbreak 'pressed' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186547 (owner: 10Bartosz Dziewoński) [00:23:53] (03CR) 10Bartosz Dziewoński: "Any kind of flash/fade-out feature will continue causing the pain I mentioned in commit message. Hmm, maybe we should call the parent meth" [oojs/ui] - 10https://gerrit.wikimedia.org/r/186537 (owner: 10Bartosz Dziewoński) [00:25:37] (03CR) 10Mooeypoo: [C: 04-1] Lazy load the media search results (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 (owner: 10Mooeypoo) [00:26:35] (03CR) 10Jforrester: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/186547 (owner: 10Bartosz Dziewoński) [00:26:59] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#1000137 (10Krenair) Are you going to work on it more? I got the impression from the way you unassigned this th... [00:28:27] (03CR) 10Jforrester: "> I think that it's not really related. This can be safely merged by itself. Zeljko?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186985 (owner: 10Amire80) [00:28:49] (03CR) 10Mooeypoo: [C: 04-1] "Fine otherwise" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) (owner: 10Mooeypoo) [00:30:13] RoanKattouw: 5-10 mins at most [00:30:27] 3OOjs-UI: Textfield widget uses role=text for no reason - https://phabricator.wikimedia.org/T87830#1000139 (10TheDJ) 3NEW [00:30:33] ori: He's gone again, sorry. [00:30:39] doh [00:31:35] (03PS1) 10TheDJ: Remove superfluos role=text from TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/187298 (https://phabricator.wikimedia.org/T87830) [00:32:42] (03CR) 10Mooeypoo: "Ed says "+2"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) (owner: 10Mooeypoo) [00:33:22] 3VisualEditor-MediaWiki-Media, VisualEditor: Add an explanation about Alternative text in the media adding dialog - https://phabricator.wikimedia.org/T75731#1000149 (10TheDJ) [00:33:56] (03CR) 10jenkins-bot: [V: 04-1] Remove superfluos role=text from TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/187298 (https://phabricator.wikimedia.org/T87830) (owner: 10TheDJ) [00:34:36] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#1000160 (10Ricordisamoa) I do not plan to work on it before the discussion has an outcome (nor I have any pers... [00:34:49] (03CR) 10Bartosz Dziewoński: "role=text or role=textbox?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187298 (https://phabricator.wikimedia.org/T87830) (owner: 10TheDJ) [00:34:57] ori: Back now [00:35:02] edsanders|away: https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Map-method-set [00:35:17] edsanders|away: https://doc.wikimedia.org/mediawiki-core/master/js/source/mediawiki.html#mw-Map-method-set [00:35:21] ori: I rm -rf'ed a bunch of stuff out of frustration and the subsequent sync-common is still running [00:35:31] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Map-method-get [00:35:32] https://doc.wikimedia.org/mediawiki-core/master/js/source/mediawiki.html#mw-Map-method-get [00:36:00] ori: Nope it's still segfaulting [00:36:03] 3OOjs-UI: OOjs UI: Toolbar menus should use sub-groups with a separator (
?) between them for splitting up longer lists - https://phabricator.wikimedia.org/T73616#1000163 (10matmarex) p:5Normal>3Low a:5matmarex>3None [00:36:09] 3OOjs-UI: OOjs UI: Toolbar menus should use sub-groups with a separator (
?) between them for splitting up longer lists - https://phabricator.wikimedia.org/T73616#744905 (10matmarex) I am not working on this now and I don't see myself working on this soon, leaving it up for grabs for now. [00:36:19] (03PS2) 10TheDJ: Remove superfluos role=textbox from TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/187298 (https://phabricator.wikimedia.org/T87830) [00:37:04] (03CR) 10Bartosz Dziewoński: [C: 032] Remove superfluos role=textbox from TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/187298 (https://phabricator.wikimedia.org/T87830) (owner: 10TheDJ) [00:37:32] (03PS3) 10Jforrester: TextInputWidget: Remove superfluous role=textbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/187298 (https://phabricator.wikimedia.org/T87830) (owner: 10TheDJ) [00:37:34] (03PS4) 10Bartosz Dziewoński: TextInputWidget: Remove superfluous role=textbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/187298 (https://phabricator.wikimedia.org/T87830) (owner: 10TheDJ) [00:37:36] 3OOjs-UI: Textfield widget uses role=text for no reason - https://phabricator.wikimedia.org/T87830#1000166 (10TheDJ) [00:37:44] (03CR) 10Bartosz Dziewoński: [C: 032] TextInputWidget: Remove superfluous role=textbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/187298 (https://phabricator.wikimedia.org/T87830) (owner: 10TheDJ) [00:37:55] Krenair, if you resize a resizable via a dialog, we have to push those changes back to VE [00:37:57] that should be done by resizable [00:38:05] currently mw images do it manually [00:38:17] *back to CE [00:38:18] (03CR) 10Krinkle: "Looking at the current behaviour in master and removing the 'flash'. I'd expect it to still insert the tickmark and wait a notable fractio" [oojs/ui] - 10https://gerrit.wikimedia.org/r/186537 (owner: 10Bartosz Dziewoński) [00:38:54] (03CR) 10Krinkle: [C: 032] "Actually, no. The selected value is displayed directly after in the menu widget. There's no need for it to be prolonged inside the user in" [oojs/ui] - 10https://gerrit.wikimedia.org/r/186537 (owner: 10Bartosz Dziewoński) [00:39:00] Krenair, so with this landed we can remove this.$image.css( dimensions ); from MWBlockImageNode [00:39:16] edsanders: So, performance improvements? [00:39:29] code deduplication [00:39:40] Kk. [00:39:51] and putting shit where it should be [00:40:52] ori: OH! IT'S BACK [00:40:59] HUPing hhvm got it to stop segfaulting [00:41:04] RoanKattouw: Ha. [00:42:45] (03Merged) 10jenkins-bot: TextInputWidget: Remove superfluous role=textbox [oojs/ui] - 10https://gerrit.wikimedia.org/r/187298 (https://phabricator.wikimedia.org/T87830) (owner: 10TheDJ) [00:42:47] (03Merged) 10jenkins-bot: Remove the 'flash' feature from MenuSelectWidget and OptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/186537 (owner: 10Bartosz Dziewoński) [00:43:36] edsanders, okay, would you like to put this in your commit message? [00:44:35] (03PS3) 10Bartosz Dziewoński: MediaWiki theme: Tweak some more border-radiuses [oojs/ui] - 10https://gerrit.wikimedia.org/r/186080 (https://phabricator.wikimedia.org/T85973) [00:44:39] that's British English for "I would like you to put that in your commit message." [00:44:57] "Do it now". [00:45:15] 3OOjs-UI: Textfield widget uses role=text for no reason - https://phabricator.wikimedia.org/T87830#1000177 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3TheDJ [00:45:29] (03PS2) 10Esanders: Update scalable and view on direct attribute change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186645 [00:46:47] (03PS2) 10Krinkle: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [00:47:46] 3OOjs-UI: Textfield widget uses role=textbox for no reason - https://phabricator.wikimedia.org/T87830#1000197 (10matmarex) [00:50:12] (03PS2) 10Esanders: Provide Platform#getConfig and shortcut ve#config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187143 [00:52:34] (03CR) 10Bartosz Dziewoński: "Bump?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [00:53:34] i need a code merge party. [00:57:50] 3UI-Standardization, OOjs-UI: MediaWiki UI ComboBox design needed - https://phabricator.wikimedia.org/T87832#1000204 (10matmarex) 3NEW [00:58:14] (03CR) 10Esanders: [C: 032] Set input direction in html prop rather than css rule [oojs/ui] - 10https://gerrit.wikimedia.org/r/187052 (https://phabricator.wikimedia.org/T87637) (owner: 10Mooeypoo) [00:59:40] 3UI-Standardization, OOjs-UI: MediaWiki UI ComboBox design needed - https://phabricator.wikimedia.org/T87832#1000212 (10matmarex) [00:59:58] (03Merged) 10jenkins-bot: Set input direction in html prop rather than css rule [oojs/ui] - 10https://gerrit.wikimedia.org/r/187052 (https://phabricator.wikimedia.org/T87637) (owner: 10Mooeypoo) [01:01:18] 3UI-Standardization, OOjs-UI: MediaWiki UI ComboBox design needed - https://phabricator.wikimedia.org/T87832#1000204 (10matmarex) [01:01:27] (03PS1) 10Krinkle: Use .prop() instead of .attr() where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 [01:01:34] (03Abandoned) 10Bartosz Dziewoński: MediaWiki theme: Correctly render ComboBoxWidget's indicator as disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/186536 (owner: 10Bartosz Dziewoński) [01:02:41] (03PS2) 10Krinkle: Use .prop() instead of .attr() where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 [01:04:52] (03CR) 10jenkins-bot: [V: 04-1] Use .prop() instead of .attr() where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 (owner: 10Krinkle) [01:06:31] ryasmeen: betalabs -> Beta Cluster :) [01:07:44] greg-g: you mean in bug summary? [01:12:20] (03PS3) 10Krinkle: Use .prop() instead of .attr() where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 [01:14:32] (03CR) 10jenkins-bot: [V: 04-1] Use .prop() instead of .attr() where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 (owner: 10Krinkle) [01:17:39] (03PS4) 10Jforrester: MediaWiki theme: Tweak some more border-radii [oojs/ui] - 10https://gerrit.wikimedia.org/r/186080 (https://phabricator.wikimedia.org/T85973) (owner: 10Bartosz Dziewoński) [01:20:07] (03CR) 10Alex Monk: Use .prop() instead of .attr() where appropiate (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 (owner: 10Krinkle) [01:20:45] (03CR) 10Krinkle: Use .prop() instead of .attr() where appropiate (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 (owner: 10Krinkle) [01:21:53] (03PS8) 10Bartosz Dziewoński: MediaWiki Theme: Adjust ComboBoxWidget, DropdownWidget selected state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [01:27:44] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 (owner: 10Krinkle) [01:31:06] (03PS1) 10Krinkle: ve.ce.LinkAnnotation: Use getResolvedAttribute for href [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187313 [01:32:30] (03PS1) 10TheDJ: Add aria-pressed to ToggleButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/187315 (https://phabricator.wikimedia.org/T87696) [01:33:04] (03CR) 10Trevor Parscal: [C: 032] Introduce and use TabIndexedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/183718 (owner: 10Bartosz Dziewoński) [01:33:22] (03CR) 10Trevor Parscal: [C: 032] InputWidget: Clarify documentation of #getInputElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/187256 (https://phabricator.wikimedia.org/T87649) (owner: 10Bartosz Dziewoński) [01:33:33] (03CR) 10Trevor Parscal: [C: 032] Provide default margins for buttons and other widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) (owner: 10Bartosz Dziewoński) [01:33:45] (03CR) 10Trevor Parscal: [C: 032] OptionWidget: Unbreak 'pressed' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186547 (owner: 10Bartosz Dziewoński) [01:33:58] (03CR) 10Trevor Parscal: [C: 032] MediaWiki theme: Tweak some more border-radii [oojs/ui] - 10https://gerrit.wikimedia.org/r/186080 (https://phabricator.wikimedia.org/T85973) (owner: 10Bartosz Dziewoński) [01:34:16] (03Merged) 10jenkins-bot: Introduce and use TabIndexedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/183718 (owner: 10Bartosz Dziewoński) [01:34:41] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.LinkAnnotation: Use getResolvedAttribute for href [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187313 (owner: 10Krinkle) [01:34:58] (03PS4) 10TheDJ: Widget: Set aria-disabled too in #setDisabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) [01:35:00] (03PS13) 10Mooeypoo: Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [01:35:17] (03PS9) 10Mooeypoo: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) [01:38:06] (03Merged) 10jenkins-bot: InputWidget: Clarify documentation of #getInputElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/187256 (https://phabricator.wikimedia.org/T87649) (owner: 10Bartosz Dziewoński) [01:38:08] (03Merged) 10jenkins-bot: Provide default margins for buttons and other widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185576 (https://phabricator.wikimedia.org/T76643) (owner: 10Bartosz Dziewoński) [01:38:11] (03Merged) 10jenkins-bot: OptionWidget: Unbreak 'pressed' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186547 (owner: 10Bartosz Dziewoński) [01:38:13] (03Merged) 10jenkins-bot: MediaWiki theme: Tweak some more border-radii [oojs/ui] - 10https://gerrit.wikimedia.org/r/186080 (https://phabricator.wikimedia.org/T85973) (owner: 10Bartosz Dziewoński) [01:38:50] (03CR) 10Mooeypoo: When changing image source, use already-available API info (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) (owner: 10Mooeypoo) [01:39:12] (03PS10) 10Mooeypoo: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) [01:40:11] (03CR) 10Krinkle: "Thanks!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:44:03] (03CR) 10Amire80: "It was failing on some patches that I committed. See the first Jenkins result on https://gerrit.wikimedia.org/r/#/c/186985/ , for example." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186985 (owner: 10Amire80) [01:46:53] (03PS9) 10Bartosz Dziewoński: MediaWiki Theme: Adjust MenuOptionWidget selected state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [01:47:17] (03CR) 10Bartosz Dziewoński: "I'm sorry, I ended up rewriting the whole thing. Review please? :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [01:48:02] 3OOjs-UI: OptionWidget has icon: 'check' in default settings for all themes, but only Apex needs this - https://phabricator.wikimedia.org/T87835#1000290 (10matmarex) 3NEW a:3TrevorParscal [01:48:13] (03CR) 10Bartosz Dziewoński: "Also filed T87835." [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [01:49:30] 3OOjs-UI: MediaWiki, Apex: Provide default margins for buttons and other widgets - https://phabricator.wikimedia.org/T76643#1000298 (10Jdforrester-WMF) 5Open>3Resolved [01:49:37] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks, looks good and I assume that you tested it with an actual screen reader." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:50:01] (03CR) 10Esanders: [C: 032] Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) (owner: 10Mooeypoo) [01:50:05] 3OOjs-UI: Elements of ButtonWidget, ButtonSelectWidget etc do not have accessible attributes that indicate the disabled state - https://phabricator.wikimedia.org/T87690#1000303 (10Jdforrester-WMF) p:5Triage>3Normal [01:50:21] 3OOjs-UI: Elements of ButtonWidget, ButtonSelectWidget etc do not have accessible attributes that indicate the disabled state - https://phabricator.wikimedia.org/T87690#1000304 (10Jdforrester-WMF) 5Open>3Resolved p:5Normal>3High a:3TheDJ [01:50:29] (03CR) 10Bartosz Dziewoński: [C: 032] "(Accidentally removed my +2, again.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:52:44] (03Merged) 10jenkins-bot: Widget: Set aria-disabled too in #setDisabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/187163 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:53:42] 3OOjs-UI: OptionWidget has icon: 'check' in default settings for all themes, but only Apex needs this - https://phabricator.wikimedia.org/T87835#1000309 (10Jdforrester-WMF) p:5Triage>3Normal [01:56:01] 3VisualEditor, Math, VisualEditor-MediaWiki: VisualEditor formula insertion field must always be ltr and not rtl - https://phabricator.wikimedia.org/T87637#1000313 (10Jdforrester-WMF) p:5Triage>3Normal [01:56:31] 3OOjs-UI: OO.ui.InputWidget.prototype.getInputElement has a config parameter in its documentation, but not in its implementation (because it's only used in subclasses) - https://phabricator.wikimedia.org/T87649#1000315 (10Jdforrester-WMF) 5Open>3Resolved [01:57:03] 3VisualEditor, OOjs-UI: MediaWiki theme: Border radius used inconsistently - https://phabricator.wikimedia.org/T85973#1000319 (10Jdforrester-WMF) 5Open>3Resolved [01:57:13] 3UI-Standardization, OOjs-UI, MediaWiki-Developer-Summit-2015: "Front-end Standardization" workshop for MediaWiki Developer Summit 2015 - https://phabricator.wikimedia.org/T86072#1000321 (10Jdforrester-WMF) 5Open>3Resolved [01:57:16] (03PS14) 10Mooeypoo: Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 [01:58:09] (03PS11) 10Mooeypoo: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) [02:01:07] (03PS8) 10Mooeypoo: Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) [02:01:55] (03PS9) 10Mooeypoo: Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) [02:02:13] (03PS8) 10Bartosz Dziewoński: Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [02:02:33] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This has a metric ton of unrelated changes, I'm splitting them away." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [02:05:02] (03PS9) 10Bartosz Dziewoński: Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [02:05:04] (03PS1) 10Bartosz Dziewoński: Twiddle things [oojs/ui] - 10https://gerrit.wikimedia.org/r/187319 [02:05:53] (03CR) 10jenkins-bot: [V: 04-1] Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [02:06:28] (03CR) 10Bartosz Dziewoński: [C: 031] "Ed?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187319 (owner: 10Bartosz Dziewoński) [02:06:55] 3UI-Standardization, OOjs-UI: MediaWiki UI ComboBox design needed - https://phabricator.wikimedia.org/T87832#1000329 (10Jdforrester-WMF) p:5Triage>3Normal [02:07:55] (03CR) 10Jforrester: "Needs a better commit summary." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187319 (owner: 10Bartosz Dziewoński) [02:08:47] (03CR) 10Bartosz Dziewoński: "I blame Ed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187319 (owner: 10Bartosz Dziewoński) [02:11:36] (03PS10) 10Bartosz Dziewoński: Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [02:13:10] (03CR) 10Esanders: [C: 032] Twiddle things [oojs/ui] - 10https://gerrit.wikimedia.org/r/187319 (owner: 10Bartosz Dziewoński) [02:14:17] (03CR) 10Esanders: [C: 031] "Separation is fine, but I wrote the remaining code, so..." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [02:14:58] (03Merged) 10jenkins-bot: Twiddle things [oojs/ui] - 10https://gerrit.wikimedia.org/r/187319 (owner: 10Bartosz Dziewoński) [02:15:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "* Why does the label have to be set after everything's loaded? Maybe we should just add some code to #onElementAttach instead?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [02:16:13] (03CR) 10Bartosz Dziewoński: [C: 031] Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński) [02:16:48] (03CR) 10Esanders: "1. Because we can't measure until it's attached. Having a reliable attached is a larger issue that other people are working on. We can mig" [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [02:19:44] (03CR) 10Bartosz Dziewoński: "Is the existing code unreliable? (As in, doesn't work in some cases?) It uses a deprecated API, true, but AFAIK it works well." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [02:26:28] (03CR) 10Bartosz Dziewoński: "Doesn't merge anymore, but also… Is there a reason why we shouldn't do this on *all* tabindexable elements? Maybe we should just do this i" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [02:26:56] (03CR) 10Bartosz Dziewoński: [C: 04-1] Remove disabled buttons from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [02:36:58] (03CR) 10Bartosz Dziewoński: "(Do you want to work on this, or am I free to rework myself?)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [02:41:19] 3OOjs-UI: OOjs UI fields are not uniform height - https://phabricator.wikimedia.org/T87546#1000382 (10matmarex) * I'm not entirely convinced that this should //always// be this way (buttons can be a bit higher than text inputs perfectly fine for me, if they're aligned correctly; checkboxes and radios are differe... [02:43:38] 3OOjs-UI: OOjs UI fields are not uniform height - https://phabricator.wikimedia.org/T87546#1000383 (10Jdforrester-WMF) p:5Triage>3Normal [02:48:33] (03PS1) 10Esanders: Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 [02:50:16] (03CR) 10jenkins-bot: [V: 04-1] Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [02:50:37] (03CR) 10Mooeypoo: Allow adding a deleted parameter in the templatedata dialog (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (https://phabricator.wikimedia.org/T86916) (owner: 10Mooeypoo) [02:50:56] (03PS7) 10Mooeypoo: Allow adding a deleted parameter in the templatedata dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (https://phabricator.wikimedia.org/T86916) [02:55:45] (03CR) 10Bartosz Dziewoński: [C: 032] Allow adding a deleted parameter in the templatedata dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (https://phabricator.wikimedia.org/T86916) (owner: 10Mooeypoo) [02:56:42] (03Merged) 10jenkins-bot: Allow adding a deleted parameter in the templatedata dialog [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/182980 (https://phabricator.wikimedia.org/T86916) (owner: 10Mooeypoo) [03:01:10] (03PS1) 10Mooeypoo: Reset paramOrder widget on dialog setup [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/187322 [03:53:01] ryasmeen|Away: yeah, everywhere really :) /me is pedantic [04:02:51] (03PS1) 10TTO: Implement ChangeTagsListActive hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187323 [05:06:51] 3Parsoid, VisualEditor, VisualEditor-Performance: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1000417 (10GWicke) p:5Triage>3High [05:52:27] 3Parsoid, VisualEditor: inserted into page text - https://phabricator.wikimedia.org/T87842#1000448 (10MZMcBride) 3NEW [05:53:19] (03CR) 10Esanders: "I was unaware we were using MO. Will use it here." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [05:54:45] (03PS11) 10Esanders: Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) [05:54:47] (03CR) 10jenkins-bot: [V: 04-1] Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [05:57:47] 3Parsoid, VisualEditor: inserted into page text - https://phabricator.wikimedia.org/T87842#1000456 (10MZMcBride) There's also the unbolded "F", but that may have been user error? [06:20:28] greg-g: Understood :) [06:41:12] ryasmeen: :) [06:58:28] RoanKattouw: you have to promise to share cool findings, i'm super curious [07:01:15] I still havent' gotten to the cool part yet [07:01:21] (03PS12) 10Esanders: Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) [07:01:29] I went to dinner and only started running more numbers like half an hour ago [07:01:55] After this my next run will be with code that has the Sizzle stuff fixed though [07:01:57] So we'll see [07:03:03] OK, moment of truth, Barack Obama "before" just finished, "after" is running now [07:03:19] Results in ~3 mins [07:03:45] * ori bites fingernails. [07:11:25] So over 30 runs the median load time for Obama went from 6924ms to 6589ms [07:12:01] that's pretty big [07:12:08] At the other measurement points it was 6986 and 6709, and the mean, min and max also went down, so it seems significant [07:12:45] 335ms decrease in median, 348ms in mean [07:12:51] So yeah that's nice [07:13:04] Not spectacular but nice [07:13:24] Wait wait [07:13:28] It's bigger [07:13:43] I was comparing new Obama with old États-Unis because of how my spreadsheet is set up [07:13:49] Let me put these numbers in the correct row [07:14:16] keep in mind that osmium's CPU is considerably beefier than your average laptop, so impact in the wild could be greater, too. [07:14:25] Yeah [07:14:42] So the new time is in fact 6589ms (median n=30), but the old time was 7041ms [07:14:55] Median decreased 452ms, mean decreased 490ms [07:15:15] that's super nice [07:15:27] min decreased 556ms (makes sense that that would be higher), max decreased 365ms (makes sense that that would be lower, but still a lot) [07:16:01] is that just with the sizzle fix? no $.fn.show/hide stuff? [07:16:06] So yeah taking some (and not even quite all yet) of Paul Irish's recommendations shaved off almost half a second [07:16:26] This delta is for a combination of a few changes but it's probably mostly due to the Sizzle thrashing thing [07:16:52] * ori nods [07:17:15] Yeah the only other performance-related changes included in that delta were a few show/hide ones [07:17:33] (run git log fd6a2c0f..9f574bc96 for the full list) [07:18:54] My spreadsheet humbles me somewhat by informing me the decrease is only ~6.5% [07:20:58] I think there are more big wins coming. The optics will keep getting better, I'm enjoying working on the instrumentation. [07:22:01] (that probably sounded like I'm taking credit, which I'm not!) [07:22:25] ori, did I ask you about https://gerrit.wikimedia.org/r/#/c/130543/ ? [07:22:27] anyways, I think you should be pretty pleased with yourself for this fix :) [07:22:49] Krenair: ask me what? [07:23:31] how we should actually go about logging those request timings [07:23:56] RoanKattouw: since you're on a roll, are you up for testing the no-dom-copy-for-sanity-check patch? [07:24:25] ori: I will eventually [07:24:31] But first the things James has been asking for all day [07:24:46] Krenair: we can write it using UDP / statsd protocol to statsd.eqiad.wmnet [07:25:12] I think you can just do something like mw.track( 'timing.foo', 123 ); now but let me look that up [07:25:15] if you get the patch(es) to the point where all that's missing is /* send $measurement here */, I can help you get that done [07:25:16] I wrote support for that at some point [07:25:51] ori, so, something in Parsoid VRS? [07:25:53] oh, are we passing them to the client? [07:26:00] VRS? [07:26:05] VirtualRESTService [07:26:07] ParsoidVirtualRESTService [07:26:25] Yeah I guess that's where you should be logging it from, good point [07:26:35] Do we have a PHP API for logging to statsd? [07:28:50] well, wfIncrStats() should be rewritten to emit statsd-protocol-compliant datagrams [07:28:53] can that just be done from core? or do we need hooks etc.? [07:29:07] right now we have a stupid piece of middleware that has been reduced to rewriting the custom mw format to statsd format [07:29:22] it's dumb and wmf-specific; statsd format would be more useful [07:29:56] the spec is here: https://github.com/b/statsd_spec [07:30:10] calling it a 'protocol' is almost an exaggeration; it's a very simple set of conventions [07:30:20] would you be up for that? [07:32:56] take a look at the link, wfIncrStats(), and some related code in MW, and see what you think. [07:33:52] if this leads you too far astray from VE we could use the top-priority cart blanche to dump it on some other poor soul [07:35:56] ori, StatCounter seems to handle multiple different ways of emitting stats already [07:37:02] yes, if you follow the git-blames you'll see who made the format customizable :P [07:37:45] but that's just for counters [07:37:49] we're interested in meters here primarily [07:38:11] so it would need to be extended for reporting meter-type metrics too [07:38:11] so it needs a statsd format implementation, wmf to switch everything to it, and only then can it be used to store parsoid timings? [07:38:27] hm [07:38:37] well, if you want to cheat [07:38:49] add hooks, and then in wikimediaevents or something, just have custom udp code [07:39:08] $sock = socket_create(AF_INET, SOCK_DGRAM, SOL_UDP); [07:39:44] $msg = "parsoid.req:143|ms"; [07:40:31] socket_sendto($sock, $msg, strlen($msg), 0, 'statsd.eqiad.wmnet', 8125); [07:40:39] socket_close($sock); [07:40:45] that's it, really [07:41:07] i just think it wouldn't be a lot more work to make that more generic and improve core in the process [07:47:39] that was basically the idea I had in mind before, but without the custom udp bit [07:47:46] I'm going to go to sleep, will look into this further tomorrow [07:47:48] thanks ori [07:47:59] thank you! [07:52:09] 3Parsoid, VisualEditor: inserted into page text - https://phabricator.wikimedia.org/T87842#1000568 (10matmarex) Whatever caused that, I cannot reproduce similar behavior now. Can you? (The split bolding is a separate issue tracked as T52098, by the way.) [07:54:56] 3VisualEditor: VisualEditor: Redesign naming of canHaveChildren, ContentBranchNode, etc. - https://phabricator.wikimedia.org/T48133#1000570 (10matmarex) [08:10:25] ori: So I ran some more numbers and for whatever reason, our jQuery thing did much better on [[fr:États-Unis]], 10% reduction [08:10:32] 6924ms to 6177ms [08:10:59] wow, you can't even download Chrome using IE6 these days [08:11:23] (script errors when clicking the final download link) [08:11:46] Wow [08:12:06] that's kind of silly of them not to test, heh [08:14:29] (if you're curious why i did that, it's because people are claiming that HTTPS Wikipedia via Chrome on Windows XP gives certificate errors, and i want to see them for myself) [08:23:18] (if you're more curious, no cert errors for me!) [08:35:27] 3Parsoid, VisualEditor: Unnecessary inserted into page text (Nov 2014) - https://phabricator.wikimedia.org/T87842#1000607 (10matmarex) [08:43:38] (03PS1) 10Gerrit Patch Uploader: Move result of thumb from i18n to config [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 [08:43:42] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader) [08:45:09] (03PS1) 10Gerrit Patch Uploader: Allow a resizeable toolbar index [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187339 [08:45:12] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187339 (owner: 10Gerrit Patch Uploader) [08:46:49] urgh [08:47:15] ori: osmium mysteriously became twice as slow at 08:12 UTC [08:47:42] All my benchmarks suddenly became ~2x slower [08:48:18] RoanKattouw: taking a look [08:48:21] I was running an Obama benchmark that was consistently reporting ~7s, and it jumped up to ~28s over the course of a few runs [08:48:40] Then after that, rerunning various benchmarks for which I already have data consistently gives me numbers that are ~2x higher [08:49:46] nothing jumps out at me when looking at [08:50:06] i'll restart hhvm and chromium since i assume getting reliable numbers is more urgent than chasing this down right now [08:50:38] RoanKattouw: ok, restarted both. try now? [08:51:08] Yup looking good [08:51:09] Thanks man [08:52:50] np, i'll try to make diagnosing issues a bit easier tomorrow [08:59:32] Hello, Perhaps someone can advice me to a ACL simliar to IntraACL but that works with VisualEditor? [09:00:09] My current installation works but sometimes the ACL does not allow the parsing to work properly on ACL-adjusted pages [09:06:19] jberg83: Did you try https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid_in_private_wikis ? [09:09:06] Hi, yes i have, when i user this parameter the wiki isnt loading at all and the log gets full of php errors [09:13:16] Tried it again, and i get "failed api request" by timeout [09:13:41] on all pages, ie, wiki stops loading [09:15:59] but when comment out the cookie parameter, it works for pages without ACL [09:19:22] Oh I've seen that before [09:19:31] I know how to fix it but it's not on that documentation page for some reason [09:19:50] jberg83: Try also setting $wgSessionsInObjectCache = true; [09:24:42] who, my mistake I missed that parameter completely, will have a go at it [09:26:24] jberg83: I don't think it's in the documentation :( [09:26:38] So it's our mistake rather than your mistake :) [09:28:45] looks like its working m8, thanks a lot for the help, this saves me hours of troubleshooting :) [10:04:24] ori: Holy crap I just started running benchmarks for code from September (took a bit of effort to get that working) and it looks like that's quite a lot slower [10:04:36] Which would mean we've made good progress in Sep - Dec [15:51:09] 3VisualEditor-ContentEditable, VisualEditor: Re-render page for preview after editing a redirect page - https://phabricator.wikimedia.org/T87512#1000933 (10Jdforrester-WMF) [15:51:12] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Show something (other than a blank page) when editing a page with a redirect - https://phabricator.wikimedia.org/T63861#1000934 (10Jdforrester-WMF) [17:09:25] James_F, RoanKattouw_away: awesome work on that vbench spreadsheet [17:09:48] ori: RoanKattouw_away gets all the credit. [17:10:39] i like this model where i farm out the profiling to one party and the fixing to a second party and the analysis to a third party [17:10:50] i may retire early [17:10:56] :-) [17:12:04] have your people call my people [17:13:22] chrismcmahon: we gotta get this performance testing rig working with jenkins. it'll take some work but it'll be very handy to have it run on each gerrit change. [17:18:47] (03PS15) 10Cscott: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 [17:18:49] (03PS7) 10Cscott: WIP: Add ve.dm.Transaction.copy() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151799 [17:18:51] (03PS7) 10Cscott: WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 [17:18:53] (03PS10) 10Cscott: Add ve.dm.Transaction.newFromIntention() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 [17:18:55] (03PS13) 10Cscott: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 [17:19:07] (03PS1) 10Cscott: Add high-level transactions. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187409 [17:19:40] (03CR) 10jenkins-bot: [V: 04-1] Add high-level transactions. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187409 (owner: 10Cscott) [17:21:36] (03CR) 10jenkins-bot: [V: 04-1] WIP: Implement ve.dm.Transaction.transpose() w/ intentions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151545 (owner: 10Cscott) [17:30:43] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34137882 [17:30:43] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34138409 [17:30:43] Corruption alert: visualeditor-needcheck on enwiki: https://en.wikipedia.org/?diff=644685410 [17:36:29] 3VisualEditor, VisualEditor-MediaWiki, Beta-Cluster: On Beta Cluster, switching from VisualEditor to edit source mode intermittently loads the wikitext editor without any CSS - https://phabricator.wikimedia.org/T86624#1001047 (10greg) [18:19:44] 3Echo, MediaWiki-General-or-Unknown, VisualEditor, Release-Engineering: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1001134 (10Jdforrester-WMF) [18:25:26] (03CR) 10Esanders: [C: 032] Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 (owner: 10Mooeypoo) [18:26:45] (03CR) 10Esanders: [C: 032] When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) (owner: 10Mooeypoo) [18:27:07] (03CR) 10Esanders: [C: 032] Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) (owner: 10Mooeypoo) [18:28:59] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Be able to set an item's size in upright terms in the media edit dialog - https://phabricator.wikimedia.org/T64671#1001170 (10cscott) So the blocking status for T64666 is a little misleading here. AFAIK, Parsoid parses the 'upright' option properly, and em... [18:30:57] 3MediaWiki-ResourceLoader: Using addModuleStyles() and then addModules() for one module on one page duplicates the styles - https://phabricator.wikimedia.org/T87871#1001174 (10matmarex) 3NEW [18:33:14] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187313 (owner: 10Krinkle) [18:33:50] (03Merged) 10jenkins-bot: Lazy load the media search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185225 (owner: 10Mooeypoo) [18:34:05] (03Merged) 10jenkins-bot: When changing image source, use already-available API info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185589 (https://phabricator.wikimedia.org/T87267) (owner: 10Mooeypoo) [18:34:52] (03Merged) 10jenkins-bot: Add a layout queue to media result widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185453 (https://phabricator.wikimedia.org/T86802) (owner: 10Mooeypoo) [18:35:07] https://gerrit.wikimedia.org/r/#/c/173834/ "T48811: Fit a square peg in a round hole" [18:41:36] 3VisualEditor, OOjs-UI: MediaWiki theme: Border radius used inconsistently - https://phabricator.wikimedia.org/T85973#1001222 (10matmarex) The corners of the suggestions in in link inspector might still differ a bit, but that is a hopeless case because of how messed up ve.Target and friends are (not a OOUI bug).... [18:42:24] (03PS1) 10Esanders: Show a message when an invalid regex is inputted in F&R [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187442 [18:42:26] (03PS1) 10Esanders: Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 [18:48:03] 3VisualEditor: Add shortcuts for VisualEditor's built-in Search and Replace system to Help->Keyboard shortcuts box - https://phabricator.wikimedia.org/T87872#1001228 (10Etonkovidova) 3NEW [18:52:58] (03PS1) 10Esanders: Add find next/previous to command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187446 (https://phabricator.wikimedia.org/T87872) [18:57:27] (03CR) 10Jforrester: [C: 032] Add find next/previous to command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187446 (https://phabricator.wikimedia.org/T87872) (owner: 10Esanders) [18:58:26] 3Echo, MediaWiki-General-or-Unknown, VisualEditor, Release-Engineering: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1001283 (10Krinkle) Please provide a reduced (browser) test case that triggers this error. [18:59:17] (03PS1) 10Mooeypoo: Add help icon for FieldsetLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187447 (https://phabricator.wikimedia.org/T75731) [19:00:12] (03CR) 10Jforrester: [C: 031] Show a message when an invalid regex is inputted in F&R [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187442 (owner: 10Esanders) [19:01:29] 3VisualEditor, VisualEditor-MediaWiki, Beta-Cluster: On Beta Cluster, switching from VisualEditor to edit source mode intermittently loads the wikitext editor without any CSS - https://phabricator.wikimedia.org/T86624#1001300 (10Ryasmeen) @Krenair: This is the issue we observed yesterday , VE was loading in a ve... [19:02:35] (03PS1) 10Esanders: Bump command help height for new find next/prev commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187449 [19:04:25] 3Echo, MediaWiki-General-or-Unknown, VisualEditor, Release-Engineering: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1001309 (10Cmcmahon) Literally every browser test in every repo that I run locally produces this error in Firefox. [19:08:02] (03CR) 10Bartosz Dziewoński: [C: 04-1] "See inline." (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [19:10:42] (03Merged) 10jenkins-bot: Add find next/previous to command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187446 (https://phabricator.wikimedia.org/T87872) (owner: 10Esanders) [19:20:42] (03CR) 10Paladox: "@GOIII please review again thanks." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [19:20:45] (03CR) 10Bartosz Dziewoński: Remove disabled buttons from keyboard navigation flow (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [19:21:32] (03PS25) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [19:25:53] 3VisualEditor, VisualEditor-MediaWiki: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - https://phabricator.wikimedia.org/T72504#1001381 (10Etonkovidova) Verified in beta. [19:26:51] (03CR) 10Bartosz Dziewoński: Remove disabled buttons from keyboard navigation flow (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [19:28:26] (03PS1) 10Prtksxna: TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) [19:28:54] 3OOjs-UI: TextInputWidget (indicator)‎ has 'required' state, so should use required attribute on the native element - https://phabricator.wikimedia.org/T87707#1001405 (10Prtksxna) a:3Prtksxna [19:33:51] (03PS1) 10Prtksxna: ToggleWidget: Use aria-checked [oojs/ui] - 10https://gerrit.wikimedia.org/r/187454 (https://phabricator.wikimedia.org/T87697) [19:35:08] 3OOjs-UI: ToggleSwitchWidget requires aria-checked - https://phabricator.wikimedia.org/T87697#1001857 (10Prtksxna) a:3Prtksxna [19:35:24] 3VisualEditor: Convert VisualEditor to use extension registration - https://phabricator.wikimedia.org/T87992#1001877 (10Legoktm) [19:38:27] 3VisualEditor: Convert VisualEditor to use extension registration - https://phabricator.wikimedia.org/T87992#1001953 (10Legoktm) [19:38:43] (03PS1) 10Prtksxna: PopupButtonWidget: Set aria-haspopup to true [oojs/ui] - 10https://gerrit.wikimedia.org/r/187455 (https://phabricator.wikimedia.org/T87694) [19:41:18] 3OOjs-UI: PopupButtonWidget needs aria-haspopup - https://phabricator.wikimedia.org/T87694#1002064 (10Prtksxna) a:3Prtksxna [19:42:51] 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1002072 (10Prtksxna) @violetto Can we have a mock up for this? [19:45:19] 3VisualEditor, OOjs-UI: MediaWiki theme: Toolbar border too strong - https://phabricator.wikimedia.org/T85974#1002081 (10KHammerstein) Hey Ed, sorry I thought phab would ping this task. I've created a new task here T86693. Would appreciate your feedback there! [19:47:50] 3VisualEditor: Toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1002089 (10KHammerstein) [19:50:08] (03PS1) 10Mooeypoo: Add nowrap to ActionFieldLayout button [oojs/ui] - 10https://gerrit.wikimedia.org/r/187458 [19:52:48] 3OOjs-UI: Dialogs are not properly labelled - https://phabricator.wikimedia.org/T87826#1002105 (10Prtksxna) We'll need to give `id`s to elements to be able to use `aria-labelledby` and `aria-describedby`. Should we give them randomly generated `id`s? Is there something else that needs to be done here? [19:59:14] (03PS1) 10Mooeypoo: Use ActionFieldLayout for language and auto-choose new lang on add [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/187459 [20:01:45] (03PS2) 10Bartosz Dziewoński: Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [20:02:48] (03CR) 10jenkins-bot: [V: 04-1] Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [20:02:49] (03CR) 10Bartosz Dziewoński: "I rewrote it, then. Please let me know if this is what you wanted, and if this actually works as intended." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [20:03:11] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(-1 to hide from dashboards until TheDJ checks it out.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [20:06:07] (03PS3) 10Bartosz Dziewoński: Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [20:06:32] (03CR) 10Bartosz Dziewoński: [C: 04-1] Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [20:10:34] (03PS13) 10Esanders: Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) [20:10:36] 3VisualEditor: Adding an image into a slug makes typing impossible anywhere in the document - https://phabricator.wikimedia.org/T88009#1002193 (10Mooeypoo) 3NEW [20:12:39] (03CR) 10Esanders: Add inline labels to text widgets (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [20:12:51] (03PS2) 10Bartosz Dziewoński: ToggleButtonWidget: Set aria-pressed when changing value [oojs/ui] - 10https://gerrit.wikimedia.org/r/187315 (https://phabricator.wikimedia.org/T87696) (owner: 10TheDJ) [20:12:56] ori, are you in the office? [20:13:11] 3VisualEditor: VisualEditor: Pre-beta needs (tracker) - https://phabricator.wikimedia.org/T50426#1002210 (10Jdforrester-WMF) [20:13:11] (03CR) 10Bartosz Dziewoński: ToggleButtonWidget: Set aria-pressed when changing value (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187315 (https://phabricator.wikimedia.org/T87696) (owner: 10TheDJ) [20:13:12] 3Cite, VisualEditor-MediaWiki-Plugins: Cite: Refactor VisualEditor editing plugin for Cite back into the Cite extension - https://phabricator.wikimedia.org/T41621#1002209 (10Jdforrester-WMF) [20:13:13] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Support most common citation templates (special-case) - https://phabricator.wikimedia.org/T41600#1002212 (10Jdforrester-WMF) [20:13:14] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Warn user when saving page with s but not - https://phabricator.wikimedia.org/T47132#1002211 (10Jdforrester-WMF) [20:13:16] 3VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support references - https://phabricator.wikimedia.org/T41599#1002207 (10Jdforrester-WMF) 5Open>3declined That's covered in specific tasks. Please don't open dead tasks from two years ago with drive-by comments; it's unhelpful and doesn't get anyth... [20:40:45] (03PS3) 10Bartosz Dziewoński: ToggleButtonWidget: Set aria-pressed when changing value [oojs/ui] - 10https://gerrit.wikimedia.org/r/187315 (https://phabricator.wikimedia.org/T87696) (owner: 10TheDJ) [20:44:02] (03CR) 10Bartosz Dziewoński: [C: 032] ToggleButtonWidget: Set aria-pressed when changing value [oojs/ui] - 10https://gerrit.wikimedia.org/r/187315 (https://phabricator.wikimedia.org/T87696) (owner: 10TheDJ) [20:46:08] (03Merged) 10jenkins-bot: ToggleButtonWidget: Set aria-pressed when changing value [oojs/ui] - 10https://gerrit.wikimedia.org/r/187315 (https://phabricator.wikimedia.org/T87696) (owner: 10TheDJ) [20:46:10] 3OOjs-UI: In MediaWiki theme, some thin grey lines in dialogs do not appear in some configurations - https://phabricator.wikimedia.org/T85226#1002295 (10Etonkovidova) Checked in beta labs - Windows 7 - Opera 27 - IE 11 - FF 33 - Chrome 40 [20:46:27] Krenair: I am, hi! [20:46:41] Krenair: I'm creepily staring at the back of your head! [20:46:44] mwahaha [20:48:12] 3VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support references - https://phabricator.wikimedia.org/T41599#1002307 (10matmarex) That issue is tracked as T52896. [20:51:19] 3VisualEditor-DataModel, VisualEditor: VisualEditor: Empty references created in wikitext editor should be allowed to edit in VE - https://phabricator.wikimedia.org/T64401#1002316 (10matmarex) I just tried at http://en.wikipedia.beta.wmflabs.org/wiki/0.24595949980612886 and the reference can be edited now, but s... [20:53:54] (03PS2) 10Bartosz Dziewoński: ActionFieldLayout: Add 'nowrap' to the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/187458 (owner: 10Mooeypoo) [20:53:58] (03CR) 10Bartosz Dziewoński: [C: 032] ActionFieldLayout: Add 'nowrap' to the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/187458 (owner: 10Mooeypoo) [20:54:04] ori, and we want to maintain support for the current udp/memc system? [20:54:12] Krenair: no [20:54:17] ok, good [20:54:30] Krenair: and in fact, the format doesn't need to be customizable; it was only made customizable so we could do the current format plus statsd, but no one but the wmf uses the current format [20:56:18] (03Merged) 10jenkins-bot: ActionFieldLayout: Add 'nowrap' to the button [oojs/ui] - 10https://gerrit.wikimedia.org/r/187458 (owner: 10Mooeypoo) [20:57:05] ori, but we'll want statsd to go over udp still (just different format), and wmf config simply to statsd.eqiad.wmnet:8125? [20:57:28] (03PS2) 10Ryasmeen: [BrowserTest] Updating test for Media Settings interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 [20:58:14] 3VisualEditor, OOjs-UI: MediaWiki theme: Border radius used inconsistently - https://phabricator.wikimedia.org/T85973#1002327 (10Etonkovidova) {F32986} In betalabs - looks god enough. [21:00:55] (03PS1) 10Bartosz Dziewoński: demo: Have multiline text in multiline widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/187481 [21:04:06] 3VisualEditor-MediaWiki-Templates, VisualEditor: Insert/Template inspector should put focus on input text_field when invoked but no longer does - https://phabricator.wikimedia.org/T85484#1002337 (10Etonkovidova) Fixed/checked in beta. [21:10:14] 3MediaWiki-ResourceLoader, MediaWiki-Vagrant: Possible performance degradation in lessc - Local vagrant super slow - https://phabricator.wikimedia.org/T78733#1002347 (10dduvall) @jdlrobson, have you experienced this same issue since bumping up your VM's memory? [21:41:05] 3VisualEditor-EditingTools, VisualEditor: VsualEditor: Please add an easy way to get from a citation template to the basic (manual) reference dialog - https://phabricator.wikimedia.org/T71498#1002451 (10Jdforrester-WMF) p:5Triage>3Volunteer? [21:41:27] (03CR) 10Bartosz Dziewoński: ToggleWidget: Use aria-checked (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187454 (https://phabricator.wikimedia.org/T87697) (owner: 10Prtksxna) [21:41:46] (03CR) 10Bartosz Dziewoński: [C: 04-1] ToggleWidget: Use aria-checked [oojs/ui] - 10https://gerrit.wikimedia.org/r/187454 (https://phabricator.wikimedia.org/T87697) (owner: 10Prtksxna) [21:43:56] 3VisualEditor: Toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1002465 (10matmarex) [21:43:58] 3VisualEditor, OOjs-UI: MediaWiki theme: Toolbar popup widgets have no visible anchor - https://phabricator.wikimedia.org/T85998#1002464 (10matmarex) [21:44:01] 3VisualEditor, OOjs-UI: MediaWiki theme: Toolbar border too strong - https://phabricator.wikimedia.org/T85974#1002466 (10matmarex) [21:44:19] 3VisualEditor: Toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#974283 (10matmarex) [21:46:29] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki-Templates: [Regression] Textboxes in template editor no longer expand automatically when it's opened - https://phabricator.wikimedia.org/T85689#1002471 (10Jdforrester-WMF) a:3matmarex [21:47:57] (03CR) 10Jforrester: [C: 032] "I think (?) that this issue is the same as https://phabricator.wikimedia.org/T85689 which I'd love to see fixed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187481 (owner: 10Bartosz Dziewoński) [21:50:27] hey, ve folks -- i thought we were going to have lunch and talk about real time operational transformational synergy integration [21:51:44] (03Merged) 10jenkins-bot: demo: Have multiline text in multiline widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/187481 (owner: 10Bartosz Dziewoński) [21:57:49] 3OOjs-UI: ToggleButtonWidget should use aria-pressed to represent it's current state - https://phabricator.wikimedia.org/T87696#1002492 (10Jdforrester-WMF) p:5High>3Low [21:58:58] 3OOjs-UI: ToggleButtonWidget should use aria-pressed to represent its current state - https://phabricator.wikimedia.org/T87696#1002497 (10Jdforrester-WMF) a:3TheDJ [21:59:19] 3OOjs-UI: ToggleButtonWidget should use aria-pressed to represent its current state - https://phabricator.wikimedia.org/T87696#996874 (10Jdforrester-WMF) 5Open>3Resolved [22:04:13] Does anyone know how I can create isolated dialog? One that will be wrapped in iframe? [22:05:56] InezK: WindowManager does it, I think. [22:06:17] yeah, I wonder how do I do it just for a one dialog [22:07:23] if window.name == 'foo' isolate:true? [22:07:28] * James_F shrugs. [22:07:48] can't [22:07:59] you'd have to mak a separate manager for it [22:08:01] make* [22:08:49] boo :( [22:11:33] (03CR) 10Bartosz Dziewoński: Add inline labels to text widgets (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [22:13:45] (03CR) 10Jforrester: [C: 04-1] "Wait for merge of I77f476c in MW-core." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187323 (owner: 10TTO) [22:21:51] ori, so we're looking for something like this? https://phabricator.wikimedia.org/P241 [22:23:52] then ParsoidVRS can call out to this to record timings, StatCounter calls would go through to this instead, etc.? [22:29:54] (03CR) 10Bartosz Dziewoński: "I just debugged that and it's separate." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187481 (owner: 10Bartosz Dziewoński) [22:30:35] (03CR) 10Jforrester: "Thanks." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187481 (owner: 10Bartosz Dziewoński) [22:30:53] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki-Templates: [Regression] Textboxes in template editor no longer expand automatically when it's opened - https://phabricator.wikimedia.org/T85689#1002566 (10matmarex) This is because we call setValue() on the TextInputWidget there before we attach it, which calls adju... [22:32:35] 3OOjs-UI: Dialogs are not properly labelled in aria terms - https://phabricator.wikimedia.org/T87826#1002577 (10Jdforrester-WMF) p:5Triage>3High [22:33:28] (03PS5) 10Esanders: [WIP] Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal) [22:33:28] 3OOjs-UI: MediaWiki theme frameless disabled buttons look completely messed up - https://phabricator.wikimedia.org/T87127#1002584 (10Jdforrester-WMF) p:5Triage>3Normal [22:33:30] 3OOjs-UI: Create a text input widget that can have a label within the input area - https://phabricator.wikimedia.org/T87239#1002587 (10Jdforrester-WMF) p:5Triage>3Normal [22:33:46] edsanders: James_F: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27677 [22:34:33] 3OOjs-UI: Have a larger size of dialog than 'large' - https://phabricator.wikimedia.org/T86396#1002593 (10Etonkovidova) Checked in betalabs - Media dialog box is changed to 900px. [22:34:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal) [22:41:24] Krinkle, are you providing one? [22:42:00] Yeah [22:42:27] (03PS14) 10Trevor Parscal: Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [22:44:47] (03CR) 10Trevor Parscal: [C: 032] Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [22:44:53] InezK: Isolated window support is planned to be removed from OOjs UI in the long term [22:45:23] good cause I just found a solution how to do what I want without isolating [22:45:25] (03CR) 10Trevor Parscal: [C: 032] PopupButtonWidget: Set aria-haspopup to true [oojs/ui] - 10https://gerrit.wikimedia.org/r/187455 (https://phabricator.wikimedia.org/T87694) (owner: 10Prtksxna) [22:45:25] god damn zindexes ;) [22:46:05] (03Merged) 10jenkins-bot: Add inline labels to text widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/185956 (https://phabricator.wikimedia.org/T87239) (owner: 10Esanders) [22:46:47] (03Merged) 10jenkins-bot: PopupButtonWidget: Set aria-haspopup to true [oojs/ui] - 10https://gerrit.wikimedia.org/r/187455 (https://phabricator.wikimedia.org/T87694) (owner: 10Prtksxna) [22:47:10] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Don't try adjusting size when detached [oojs/ui] - 10https://gerrit.wikimedia.org/r/187604 (https://phabricator.wikimedia.org/T85689) [22:47:52] (03CR) 10Trevor Parscal: [C: 04-1] TextInputWidget: Add required attribute on the basis of required config (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [22:48:25] (03PS2) 10Bartosz Dziewoński: TextInputWidget: Don't try adjusting size when detached [oojs/ui] - 10https://gerrit.wikimedia.org/r/187604 (https://phabricator.wikimedia.org/T85689) [22:49:32] (03CR) 10Trevor Parscal: [C: 032] Add help icon for FieldsetLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187447 (https://phabricator.wikimedia.org/T75731) (owner: 10Mooeypoo) [22:50:49] (03Merged) 10jenkins-bot: Add help icon for FieldsetLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187447 (https://phabricator.wikimedia.org/T75731) (owner: 10Mooeypoo) [22:51:19] (03CR) 10Trevor Parscal: [C: 032] TextInputWidget: Don't try adjusting size when detached [oojs/ui] - 10https://gerrit.wikimedia.org/r/187604 (https://phabricator.wikimedia.org/T85689) (owner: 10Bartosz Dziewoński) [22:52:07] (03Merged) 10jenkins-bot: TextInputWidget: Don't try adjusting size when detached [oojs/ui] - 10https://gerrit.wikimedia.org/r/187604 (https://phabricator.wikimedia.org/T85689) (owner: 10Bartosz Dziewoński) [22:52:44] (03PS10) 10Bartosz Dziewoński: MediaWiki Theme: Adjust MenuOptionWidget selected state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [22:54:01] (03PS2) 10Prtksxna: TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) [22:54:03] (03CR) 10jenkins-bot: [V: 04-1] TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [22:54:35] (03CR) 10Prtksxna: TextInputWidget: Add required attribute on the basis of required config (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [22:54:37] (03CR) 10Trevor Parscal: [C: 032] MediaWiki Theme: Adjust MenuOptionWidget selected state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [22:55:32] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki-Templates: [Regression] Textboxes in template editor no longer expand automatically when it's opened - https://phabricator.wikimedia.org/T85689#1002634 (10matmarex) [22:55:33] 3VisualEditor, VisualEditor-EditingTools: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1002633 (10matmarex) [22:55:43] (03PS3) 10Prtksxna: TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) [22:55:45] 3VisualEditor, VisualEditor-EditingTools: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1002636 (10matmarex) a:5TrevorParscal>3matmarex My patch for T85689 might fix this. [22:56:03] (03Merged) 10jenkins-bot: MediaWiki Theme: Adjust MenuOptionWidget selected state [oojs/ui] - 10https://gerrit.wikimedia.org/r/186140 (owner: 10Prtksxna) [22:56:43] 3OOjs-UI: PopupButtonWidget needs aria-haspopup - https://phabricator.wikimedia.org/T87694#1002644 (10Prtksxna) 5Open>3Resolved [22:58:12] (03PS2) 10Prtksxna: ToggleWidget: Use aria-checked [oojs/ui] - 10https://gerrit.wikimedia.org/r/187454 (https://phabricator.wikimedia.org/T87697) [22:58:24] (03CR) 10Prtksxna: ToggleWidget: Use aria-checked (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187454 (https://phabricator.wikimedia.org/T87697) (owner: 10Prtksxna) [23:01:00] 3VisualEditor: Insert/Media inspector should appear with focus on input box and default text pre-selected - https://phabricator.wikimedia.org/T88021#1002659 (10Krenair) [23:01:04] 3VisualEditor: Insert/Media inspector should appear with focus on input box and default text pre-selected - https://phabricator.wikimedia.org/T88021#1002661 (10Cmcmahon) [23:01:39] 3VisualEditor-MediaWiki-Media, VisualEditor: Insert/Media inspector should appear with focus on input box and default text pre-selected - https://phabricator.wikimedia.org/T88021#1002664 (10Catrope) [23:01:40] WTF [23:01:44] Phabricator race condition [23:01:50] Catrope removed subscribers: Ryasmeen, Etonkovidova. [23:02:31] (03CR) 10Cmcmahon: "I'm having trouble testing this against beta labs because of https://phabricator.wikimedia.org/T86040" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 (owner: 10Ryasmeen) [23:04:04] RoanKattouw: Yeah, well-known. [23:04:37] (03PS1) 10Ryasmeen: [BrowserTest] Test for checking General Settings for media [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187610 [23:04:47] (03PS1) 10Ryasmeen: [BrowserTest] Test for checking General Settings option for Media [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187611 [23:05:19] ryasmeen: You probably meant for those two ---^^ to be combined into one commit? [23:05:48] Yeah RoanKattouw [23:05:56] I can help you do that if you like [23:06:15] yeah sure, that will be helful! [23:06:22] 3OOjs-UI: Create a text input widget that can have a label within the input area - https://phabricator.wikimedia.org/T87239#1002675 (10Jdforrester-WMF) 5Open>3Resolved [23:06:41] Did you do anything at all since submitting those commits? [23:06:43] (Answering I'm hoping for: no) [23:06:47] 3OOjs-UI: PopupButtonWidget needs aria-haspopup - https://phabricator.wikimedia.org/T87694#1002678 (10Jdforrester-WMF) [23:06:48] *Answer [23:06:59] nope [23:07:01] :) [23:07:09] Good [23:07:22] OK, run git rebase --interactive HEAD~2 [23:07:47] RoanKattouw: Are you in the meeting? [23:07:49] That will take you to an editor, with two lines that look like "pick 123abc [BrowserTest] Test for checking blah blah" [23:07:51] James_F: Yes [23:08:02] 3VisualEditor, VisualEditor-Performance: Get rid of unnecessary jQuery.html call in ve.dm.MWReferenceNode.static.toDomElements - https://phabricator.wikimedia.org/T87417#1002679 (10Krenair) 5Open>3Resolved That was merged [23:08:14] RoanKattouw: OK. Column + screen + far away == I have no idea if you're there or not. :-) [23:08:14] Edit the lower of the two lines to change "pick" to "fixup" [23:08:15] Then save and exit the editor [23:08:41] ok doing that [23:09:05] 3VisualEditor, VisualEditor-Performance: Get rid of unnecessary jQuery.html call in ve.dm.MWReferenceNode.static.toDomElements - https://phabricator.wikimedia.org/T87417#990736 (10Jdforrester-WMF) [23:10:03] RoanKattouw:yeah I see it got successfully rebased [23:10:33] Awesome [23:10:39] Now run git review [23:11:05] (03PS2) 10Ryasmeen: [BrowserTest] Test for checking General Settings for media [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187610 [23:11:30] RoanKattouw: done :) [23:11:44] ryasmeen: And abandon the "wrong" one. [23:11:53] Yes, what James said [23:12:49] 3VisualEditor-MediaWiki-Media, VisualEditor: In the VisualEditor media selector, show the name of each file so it can be identified - https://phabricator.wikimedia.org/T54459#1002687 (10Etonkovidova) Checked in betalabs. [23:12:50] Also this is like the most successful first rebase I've ever seen :D [23:13:04] Or painless, rather [23:13:08] :-) [23:13:24] okay :) [23:14:25] ryasmeen: But yeah you can now abandon https://gerrit.wikimedia.org/r/187611 [23:16:05] (03Abandoned) 10Ryasmeen: [BrowserTest] Test for checking General Settings option for Media [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187611 (owner: 10Ryasmeen) [23:16:17] yay [23:16:27] hehe thanks RoanKattouw! [23:19:16] (03PS1) 10Catrope: Don't render rowspan="1" colspan="1" for every table cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187612 (https://phabricator.wikimedia.org/T87799) [23:19:21] 3VisualEditor-ContentEditable, VisualEditor: ve.ce.TableCellNode should not add rowspan="1" / colspan="1" to every cell in the editor - https://phabricator.wikimedia.org/T87799#1002694 (10Catrope) a:3Catrope [23:20:25] (03CR) 10Jforrester: [C: 032] Don't render rowspan="1" colspan="1" for every table cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187612 (https://phabricator.wikimedia.org/T87799) (owner: 10Catrope) [23:22:05] (03Merged) 10jenkins-bot: Don't render rowspan="1" colspan="1" for every table cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187612 (https://phabricator.wikimedia.org/T87799) (owner: 10Catrope) [23:34:32] 3OOjs-UI: Disabled buttons should have the same size as non-disabled buttons (MW theme) - https://phabricator.wikimedia.org/T88025#1002718 (10Catrope) 3NEW [23:35:44] (03PS2) 10Catrope: Show a message when an invalid regex is inputted in F&R [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187442 (owner: 10Esanders) [23:36:06] 3OOjs-UI: Disabled buttons should have the same size as non-disabled buttons (MW theme) - https://phabricator.wikimedia.org/T88025#1002725 (10matmarex) [23:36:43] (03CR) 10Catrope: [C: 032] Show a message when an invalid regex is inputted in F&R [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187442 (owner: 10Esanders) [23:36:45] (03PS2) 10Catrope: Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [23:36:48] 3OOjs-UI: MediaWiki theme: Regular and disabled buttons have different height - https://phabricator.wikimedia.org/T87126#1002728 (10Jdforrester-WMF) p:5Triage>3High [23:37:03] (03PS1) 10Mooeypoo: [BREAKING CHANGE] Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) [23:37:58] (03Merged) 10jenkins-bot: Show a message when an invalid regex is inputted in F&R [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187442 (owner: 10Esanders) [23:38:33] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo) [23:44:27] (03CR) 10Catrope: [C: 04-1] "This breaks the positioning of the label." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [23:45:11] 3UI-Standardization, OOjs, OOjs-UI, Living-Style-Guide: Create a nonprocedural markup for OOJS-UI - https://phabricator.wikimedia.org/T88026#1002745 (10werdna) 3NEW a:3werdna [23:47:17] (03PS1) 10Mooeypoo: Use css class rather than jQuery show/hide [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 [23:47:43] 3VisualEditor, VisualEditor-Performance, WikiEditor: Apply Schema:Edit instrumentation to WikiEditor - https://phabricator.wikimedia.org/T88027#1002754 (10Jdforrester-WMF) 3NEW a:3Krenair [23:47:51] (03PS1) 10Mooeypoo: Use css class instead of jquery show/hide [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) [23:48:40] (03CR) 10jenkins-bot: [V: 04-1] Use css class instead of jquery show/hide [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo) [23:49:22] (03CR) 10jenkins-bot: [V: 04-1] Use css class rather than jQuery show/hide [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 (owner: 10Mooeypoo) [23:49:42] 3OOjs-UI: MediaWiki theme: Regular and disabled buttons have different height - https://phabricator.wikimedia.org/T87126#1002782 (10matmarex) a:3matmarex [23:50:28] 3UI-Standardization, OOjs-UI: OOjs UI: Be able to resurrect OOUI PHP widgets into OOjs UI widgets - https://phabricator.wikimedia.org/T74716#1002784 (10werdna) [23:51:11] (03CR) 10Catrope: [C: 04-1] Make category widget items draggable (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [23:55:21] (03PS1) 10Bartosz Dziewoński: MediaWiki theme: Unbreak disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/187621 (https://phabricator.wikimedia.org/T87126) [23:56:11] (03CR) 10Anomie: "> Wait for merge of I77f476c in MW-core." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187323 (owner: 10TTO) [23:56:49] (03CR) 10Catrope: "The DM stuff seems to be working fine, but the drag&drop stuff feels clunky. In particular, the placeholder is oddly shaped (has the width" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk) [23:57:39] (03CR) 10Catrope: [C: 032] "Does not block on merging the core change; rather, the opposite is true." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187323 (owner: 10TTO) [23:59:25] (03Merged) 10jenkins-bot: Implement ChangeTagsListActive hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187323 (owner: 10TTO)