[00:00:29] <grrrit-wm>	 (03PS2) 10Mooeypoo: [wip] Use css class instead of jquery show/hide [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) 
[00:00:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Use css class instead of jquery show/hide [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[00:00:56] <grrrit-wm>	 (03PS2) 10Mooeypoo: [wip] Use css class rather than jQuery show/hide [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 
[00:02:37] <grrrit-wm>	 (03CR) 10Jforrester: "The core change is not blocked on this cosmetic improvement, but fine." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187323 (owner: 10TTO)
[00:02:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Use css class rather than jQuery show/hide [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 (owner: 10Mooeypoo)
[00:04:38] <wikibugs>	 3MediaWiki-ResourceLoader, MediaWiki-Vagrant: Possible performance degradation in lessc - Local vagrant super slow - https://phabricator.wikimedia.org/T78733#1002822 (10Jdlrobson) yup. My vagrant is a complete mess right now. :-/ Was hoping to get some time during the dev summit to debug but didn't get the chance.
[00:08:08] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Use css class instead of jQuery .show()/hide()/toggle() (037 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[00:10:25] <grrrit-wm>	 (03CR) 10Catrope: "Also the V-1 is real, jshint found four style errors. Two of them are comments I already complained about though." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[00:20:25] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [wip] Use css class rather than jQuery show/hide (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 (owner: 10Mooeypoo)
[00:35:05] <wikibugs>	 3UI-Standardization, OOjs-UI: Radio button hover state only appears when I mouse over the bottom part of it. - https://phabricator.wikimedia.org/T88035#1002885 (10werdna) 3NEW
[00:35:46] <wikibugs>	 3Continuous-Integration, VisualEditor: Don't trigger rubocop Jenkins job for changes that only modify php or js files - https://phabricator.wikimedia.org/T75077#1002892 (10Krinkle)
[00:36:13] <wikibugs>	 3UI-Standardization, OOjs-UI: Radio button hover state only appears when I mouse over the bottom part of it. - https://phabricator.wikimedia.org/T88035#1002896 (10werdna) Also seems to appear correctly if I mouse over the top corners.
[00:37:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MediaWiki theme: Unbreak disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/187621 (https://phabricator.wikimedia.org/T87126) (owner: 10Bartosz Dziewoński)
[00:38:39] <wikibugs>	 3OOjs-UI: MediaWiki theme: Regular and disabled buttons have different height - https://phabricator.wikimedia.org/T87126#1002911 (10Jdforrester-WMF) 5Open>3Resolved
[00:39:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki theme: Unbreak disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/187621 (https://phabricator.wikimedia.org/T87126) (owner: 10Bartosz Dziewoński)
[00:40:35] <grrrit-wm>	 (03PS6) 10Esanders: Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal)
[00:41:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal)
[00:42:12] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński)
[00:43:36] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] ToggleWidget: Use aria-checked [oojs/ui] - 10https://gerrit.wikimedia.org/r/187454 (https://phabricator.wikimedia.org/T87697) (owner: 10Prtksxna)
[00:44:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change uses of LookupInputWidget to LookupElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185316 (owner: 10Bartosz Dziewoński)
[00:45:05] <grrrit-wm>	 (03PS7) 10Jforrester: Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal)
[00:45:05] <wikibugs>	 3OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1002931 (10Krinkle) 3NEW
[00:45:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: ToggleWidget: Use aria-checked [oojs/ui] - 10https://gerrit.wikimedia.org/r/187454 (https://phabricator.wikimedia.org/T87697) (owner: 10Prtksxna)
[00:48:31] <grrrit-wm>	 (03CR) 10Ricordisamoa: "What about having e.g. two Widget methods .show() and .hide() in OOjs UI that would automatically use the class instead of jQuery?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[00:48:51] <ebernhardson>	 TrevorP|Away: since you may not be familiar...this is what queries in modern ORM's look like: https://phabricator.wikimedia.org/P243
[00:49:13] <ebernhardson>	 you explicitly control the query, not the other way around
[00:49:21] <grrrit-wm>	 (03PS3) 10Mooeypoo: [wip] Use css class instead of jquery show/hide [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) 
[00:49:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Use css class instead of jquery show/hide [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[00:49:55] <wikibugs>	 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1002955 (10matmarex)
[00:53:13] <Krenair>	 ori, so we'll want this to go to $wgUDPProfilerHost and $wgUDPProfilerPort right?
[00:53:18] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 031] Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal)
[00:57:07] <grrrit-wm>	 (03PS1) 10Catrope: Followup 04d04c0f: prevent double animation of disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/187632 
[01:00:13] <grrrit-wm>	 (03PS1) 10Divec: WIP: extend nextCursorOffset to work for non-sibling offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187633 
[01:02:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: extend nextCursorOffset to work for non-sibling offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187633 (owner: 10Divec)
[01:02:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "This change causes frameless disabled buttons to completely disappear :D (white text on white background). One you fix that, you can tag t" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187632 (owner: 10Catrope)
[01:03:49] <grrrit-wm>	 (03CR) 10Catrope: [wip] Use css class instead of jquery show/hide (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[01:04:09] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Comments in PS2" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[01:14:21] <bmansurov>	 hey guys, can anyone tell me how to use the PopupTool? The documentation doesn't seem to cover it. thanks
[01:14:24] <grrrit-wm>	 (03PS8) 10Esanders: Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal)
[01:14:36] <bmansurov>	 by documentation I mean https://www.mediawiki.org/wiki/OOjs_UI
[01:16:37] <MatmaRex>	 hey bmansurov
[01:16:44] <bmansurov>	 hello
[01:16:55] <MatmaRex>	 i can't quite tell you right now, but i can tell you where we're using it in VE :D
[01:17:08] <bmansurov>	 MatmaRex: that'd be good
[01:17:32] <MatmaRex>	 we have two PopupTool subclasses in /modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js
[01:17:38] <MatmaRex>	 (we should totally split that file, btw)
[01:18:12] <MatmaRex>	 if you grep for 'notices' (*with* the apostrophes), you'll find the usages of one
[01:18:22] <mooeypoo>	 I think the ButtonPopupTool is in ooui demos
[01:18:57] <bmansurov>	 thanks guys
[01:20:06] <wikibugs>	 3OOjs-UI: ToggleSwitchWidget requires aria-checked - https://phabricator.wikimedia.org/T87697#1003032 (10Jdforrester-WMF) 5Open>3Resolved
[01:20:45] <wikibugs>	 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1003042 (10Jdforrester-WMF) p:5Triage>3Normal
[01:20:47] <wikibugs>	 3OOjs-UI: MediaWiki theme frameless disabled buttons look completely messed up - https://phabricator.wikimedia.org/T87127#1003044 (10matmarex) a:3Catrope Roan's on the case: https://gerrit.wikimedia.org/r/#/c/187632/
[01:21:26] <wikibugs>	 3UI-Standardization, OOjs-UI: Radio button hover state only appears when I mouse over the bottom part of it. - https://phabricator.wikimedia.org/T88035#1003049 (10Jdforrester-WMF) p:5Triage>3High
[01:23:46] <wikibugs>	 3VisualEditor-MediaWiki-Media, VisualEditor: Insert/Media inspector should appear with focus on input box and default text pre-selected - https://phabricator.wikimedia.org/T88021#1003058 (10Jdforrester-WMF) p:5Triage>3Normal
[01:24:22] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Convert VisualEditor to use extension registration - https://phabricator.wikimedia.org/T87992#1003063 (10Jdforrester-WMF) p:5Triage>3Low a:3Jdforrester-WMF
[01:25:57] <grrrit-wm>	 (03PS7) 10Jforrester: Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) 
[01:26:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester)
[01:26:21] <grrrit-wm>	 (03PS1) 10Mooeypoo: Adjust to ooui's show/hide css change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187634 
[01:26:25] <grrrit-wm>	 (03PS2) 10Mooeypoo: [wip] Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) 
[01:26:29] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Needs rebase (actually, re-generation)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester)
[01:27:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[01:29:40] <grrrit-wm>	 (03PS12) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) 
[01:30:05] <grrrit-wm>	 (03PS1) 10Krinkle: EventEmitter: Remove unneeded Array.prototype.slice call [oojs/core] - 10https://gerrit.wikimedia.org/r/187635 
[01:30:09] <grrrit-wm>	 (03PS3) 10Mooeypoo: Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) 
[01:30:34] <grrrit-wm>	 (03PS2) 10Krinkle: EventEmitter: Remove unneeded Array.prototype.slice call [oojs/core] - 10https://gerrit.wikimedia.org/r/187635 
[01:31:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk)
[01:31:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[01:33:43] <grrrit-wm>	 (03PS3) 10Krinkle: EventEmitter: Remove unneeded Array.prototype.slice call [oojs/core] - 10https://gerrit.wikimedia.org/r/187635 
[01:40:10] <grrrit-wm>	 (03PS4) 10Catrope: EventEmitter: Remove unneeded Array.prototype.slice call [oojs/core] - 10https://gerrit.wikimedia.org/r/187635 (owner: 10Krinkle)
[01:40:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] EventEmitter: Remove unneeded Array.prototype.slice call [oojs/core] - 10https://gerrit.wikimedia.org/r/187635 (owner: 10Krinkle)
[01:41:15] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] EventEmitter: Remove unneeded Array.prototype.slice call [oojs/core] - 10https://gerrit.wikimedia.org/r/187635 (owner: 10Krinkle)
[01:43:20] <grrrit-wm>	 (03CR) 10Ryasmeen: "1. The test passes, but running Rubocop shows following error, lets fix that:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova)
[01:43:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: EventEmitter: Remove unneeded Array.prototype.slice call [oojs/core] - 10https://gerrit.wikimedia.org/r/187635 (owner: 10Krinkle)
[01:48:43] <grrrit-wm>	 (03PS13) 10Alex Monk: Make category widget items draggable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) 
[01:54:38] <grrrit-wm>	 (03PS2) 10Catrope: Followup 04d04c0f: prevent double animation of disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/187632 
[01:57:16] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: MediaWiki theme: Fix background issues with disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/187632 (https://phabricator.wikimedia.org/T87127) (owner: 10Catrope)
[01:58:24] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] MediaWiki theme: Fix background issues with disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/187632 (https://phabricator.wikimedia.org/T87127) (owner: 10Catrope)
[01:59:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki theme: Fix background issues with disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/187632 (https://phabricator.wikimedia.org/T87127) (owner: 10Catrope)
[02:01:37] <grrrit-wm>	 (03PS2) 10Divec: WIP: Extend nextCursorOffset to work for non-sibling offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187633 
[02:06:24] <wikibugs>	 3VisualEditor: DraggableGroupElement should handle non OptionWidget items - https://phabricator.wikimedia.org/T88053#1003207 (10Mooeypoo) 3NEW a:3Mooeypoo
[02:07:49] <grrrit-wm>	 (03PS1) 10Mooeypoo: [wip] DraggableGroupElement: Allow it to accept non OptionWidget items [oojs/ui] - 10https://gerrit.wikimedia.org/r/187637 (https://phabricator.wikimedia.org/T88053) 
[02:08:57] <grrrit-wm>	 (03CR) 10Mooeypoo: "This is stuck right now due to the bug in DraggableGroupElement in Bug:T88053" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/173360 (https://bugzilla.wikimedia.org/50809) (owner: 10Alex Monk)
[03:19:38] <grrrit-wm>	 (03CR) 10TheDJ: TextInputWidget: Add required attribute on the basis of required config (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna)
[03:37:13] <grrrit-wm>	 (03CR) 10TheDJ: [C: 031] "Tested, seems to work the same as the earlier patch did." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ)
[03:38:03] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ)
[03:50:34] <wikibugs>	 3OOjs-UI: MediaWiki theme frameless disabled buttons look completely messed up - https://phabricator.wikimedia.org/T87127#1003571 (10matmarex) 5Open>3Resolved
[03:51:23] <wikibugs>	 3OOjs-UI: MediaWiki theme frameless disabled buttons look completely messed up - https://phabricator.wikimedia.org/T87127#984373 (10matmarex) Fixed thus: {F33100,size=full}  The contrast is unacceptably low, this is {T88038}.
[03:52:17] <wikibugs>	 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1002931 (10matmarex) Even worse for frameless buttons: {F33103}
[03:56:36] <wikibugs>	 3OOjs-UI: Dialogs are not properly labelled in aria terms - https://phabricator.wikimedia.org/T87826#1003599 (10TheDJ) It should probably also use a header element.  Random generated id's seem fine to me. Do we have something in place to generate random ids ?
[04:10:32] <wikibugs>	 3OOjs-UI: ToggleSwitchWidget requires the checkbox role - https://phabricator.wikimedia.org/T88079#1003651 (10TheDJ) 3NEW
[04:11:50] <wikibugs>	 3OOjs-UI: ToggleSwitchWidget requires to be TabIndexedElement - https://phabricator.wikimedia.org/T88080#1003660 (10TheDJ) 3NEW
[04:13:12] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Show something (other than a blank page) when editing a page with a redirect - https://phabricator.wikimedia.org/T63861#648967 (10Krenair) >>! In T63861#648996, @Krenair wrote: > When checking that I was right about the valid positioning of redirects, I found...
[04:36:23] <wikibugs>	 3OOjs-UI: RadioSelectWidget is not accessible - https://phabricator.wikimedia.org/T88082#1003700 (10TheDJ) 3NEW
[04:37:20] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoader: Implement support for LESS in wiki modules (user and site), supporting e.g. MediaWiki:Common.less - https://phabricator.wikimedia.org/T56864#1003707 (10Krinkle) >>! In T56864#843069, @Jdlrobson wrote: > Actually I think replacing Common.css with Common.less outright (se...
[04:51:41] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki, Beta-Cluster: On Beta Cluster, switching from VisualEditor to edit source mode intermittently loads the wikitext editor without any CSS - https://phabricator.wikimedia.org/T86624#1003708 (10Krenair) 5Open>3Resolved a:3Krenair This appears to have sorted itself out, po...
[05:07:46] <Krinkle>	 https://phabricator.wikimedia.org/T61699 -> Need Volunteer?
[05:20:16] <wikibugs>	 3OOjs-UI: MediaWiki theme frameless disabled buttons look completely messed up - https://phabricator.wikimedia.org/T87127#1003735 (10Jdforrester-WMF)
[05:21:11] <James_F>	 Krenair: https://phabricator.wikimedia.org/maniphest/query/EUrMWlnQqMcB/#R
[05:21:14] <James_F>	 (Whee.)
[05:52:00] <grrrit-wm>	 (03PS1) 10Ryasmeen: [BrowserTest] Test to check the functionality of Change Image button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 
[06:31:43] <grrrit-wm>	 (03PS3) 10Krinkle: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk)
[06:40:36] <grrrit-wm>	 (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk)
[06:42:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk)
[06:46:29] <grrrit-wm>	 (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk)
[06:51:13] <wikibugs>	 3OOjs-UI: ButtonOptionWidget should be keyboard navigable - https://phabricator.wikimedia.org/T88085#1003776 (10TheDJ) 3NEW
[06:53:07] <grrrit-wm>	 (03PS1) 10TheDJ: ButtonOptionWidget: Add the TabIndexedElement mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/187652 (https://phabricator.wikimedia.org/T88085) 
[06:56:48] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Whoops, probably my fault." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187652 (https://phabricator.wikimedia.org/T88085) (owner: 10TheDJ)
[07:00:20] <wikibugs>	 3OOjs-UI: Audit and update PHP widgets for accessibility parity with JS widgets - https://phabricator.wikimedia.org/T88086#1003792 (10matmarex) 3NEW a:3matmarex
[07:10:01] <grrrit-wm>	 (03CR) 10Mattflaschen: "I'm not going to review this in the present form, since it depends on https://gerrit.wikimedia.org/r/#/c/181786/ ." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 (owner: 10Paladox)
[07:22:55] <grrrit-wm>	 (03PS2) 10TheDJ: ButtonOptionWidget: Add the TabIndexedElement mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/187652 (https://phabricator.wikimedia.org/T88085) 
[07:28:24] <wikibugs>	 3MediaWiki-extensions-Score, VisualEditor-MediaWiki-Plugins, Multimedia: Create a VisualEditor plugin tool to add/edit musical scores (Score extension) - https://phabricator.wikimedia.org/T49528#1003822 (10Tgr) Just adding a text editor with a preview button, like e.g. [[ http://lilybin.com/ | lilybin.com ]] doe...
[08:05:21] <wikibugs>	 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1003856 (10TheDJ) 3NEW
[08:07:39] <wikibugs>	 3OOjs-UI: SelectWidget group of OptionWidget is not presenting it's state - https://phabricator.wikimedia.org/T88091#1003868 (10TheDJ) 3NEW
[08:09:27] <grrrit-wm>	 (03PS1) 10TheDJ: SelectWidget: listbox wrapper role, state on contents [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) 
[08:35:15] <wikibugs>	 3MediaWiki-extensions-ImageMap, VisualEditor-MediaWiki-Plugins, Multimedia: Create a VisualEditor plugin tool to add/edit imagemaps - https://phabricator.wikimedia.org/T45127#1003903 (10Tgr) > <imagemap>....</imagemap> is unparsed but shown as plain wikitext  Apparently at this point it is shown as an uneditable...
[11:00:55] <grrrit-wm>	 (03CR) 10Paladox: "@Mattflaschen please review this patch. This is just images needing to be reviewed it doesent include css file so these can be review and " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[11:06:03] <wikibugs>	 3VisualEditor-ContentEditable, VisualEditor: figure class="default size" inserted in a caption - https://phabricator.wikimedia.org/T88099#1004028 (10Automatik) 3NEW
[12:07:25] <wikibugs>	 3OOjs-UI: SelectWidget group of OptionWidget is not presenting its state - https://phabricator.wikimedia.org/T88091#1004071 (10Ricordisamoa)
[15:36:04] <wikibugs>	 3MediaWiki-Page-editing, MW-RFCs: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1004301 (10Fomafix)
[15:36:18] <wikibugs>	 3MediaWiki-Page-editing, MW-RFCs: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#424521 (10Fomafix)
[15:52:40] <grrrit-wm>	 (03CR) 10Cmcmahon: "Right now this test does not run correctly for me because of https://phabricator.wikimedia.org/T88021" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 (owner: 10Ryasmeen)
[15:53:35] <grrrit-wm>	 (03CR) 10Cmcmahon: "And for right now https://phabricator.wikimedia.org/T87446 is preventing any test from running in Firefox for me also" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 (owner: 10Ryasmeen)
[15:55:30] <wikibugs>	 3VisualEditor: VisualEditor doesn't work in Uzbek Wiki - https://phabricator.wikimedia.org/T88119#1004328 (10bmansurov) 3NEW
[16:25:42] <wikibugs>	 3MediaWiki-extensions-Score, VisualEditor-MediaWiki-Plugins, Multimedia: Create a VisualEditor plugin tool to add/edit musical scores (Score extension) - https://phabricator.wikimedia.org/T49528#1004357 (10Jdforrester-WMF) >>! In T49528#1003822, @Tgr wrote: > Just adding a text editor with a preview button, like...
[16:33:47] <eranroz>	 >$('.mw-tag-visualeditor').length/$('.mw-line-even,.mw-line-odd').length
[16:33:51] <eranroz>	 =0.5
[16:34:05] <eranroz>	 (reviewing annonymous RC in hewiki)
[16:34:40] <James_F>	 eranroz: … so half of all edits in hewiki are from VE?
[16:34:59] <eranroz>	 James_F: for annonymous editors. yes :)
[16:35:50] <James_F>	 eranroz: Sounds about on-par for other wikis.
[16:36:58] <James_F>	 Maybe a bit higher.
[16:37:48] <eranroz>	 so VE does a good job. thanks :)
[16:38:25] <James_F>	 eranroz: Still more work to do. But thank you. :-)
[16:38:45] <James_F>	 eranroz: Have you seen http://citoid.wmflabs.org ?
[16:41:18] <eranroz>	 James_F: very nice. I  tried citoid few months ago and it didn't work so well
[16:41:33] <eranroz>	 but now it gives a lot of info
[16:42:07] <eranroz>	 does it also work support opengraph to fetch details from any website that use it?
[16:42:29] <James_F>	 eranroz: If you use Beta Labs you can see a new option in the Cite menu: http://he.wikipedia.beta.wmflabs.org/wiki/Special:Random?veaction=edit
[16:42:36] <eranroz>	 [I think facebook use it to fetch information when you post a link]
[16:42:39] <James_F>	 I believe it falls back to that, yes.
[16:42:50] <James_F>	 Hmm. Or not?
[16:43:17] <James_F>	 Ho-hum. Need to investigate that. :-)
[16:47:08] <eranroz>	 James_F: tested it in wmflabs. citoid is awesome for scientific papers citations
[16:47:53] <James_F>	 eranroz: Cool. The next step is getting it production-ready and then getting the software shipped in VisualEditor and WikiEditor.
[16:48:50] <eranroz>	 James_F: it doesn't work well for general newpapers (BBC for example). I think opengraph may fill this gap
[16:49:10] <James_F>	 eranroz: It works OK for me… feeds into {{cite news}} as expected.
[16:49:45] <eranroz>	 James_F: autofill?
[16:49:51] <James_F>	 eranroz: Yes.
[16:52:07] <eranroz>	 James_F: It doesn't work for me (beta, en version). I'm trying Cite=>News and adding http://www.bbc.com/news/world-us-canada-31062739 - expecting it to fill the title by itself as magic :)
[16:53:35] <James_F>	 eranroz: Hmm. Very odd. It was working fine just now for a BBC link…
[16:53:41] * James_F grumbles.
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12196443
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on eswiki: https://es.wikipedia.org/?diff=79690244
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111397269
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111401661
[17:30:40] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34149266
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on simplewiki: https://simple.wikipedia.org/?diff=4999547
[17:30:41] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68251962
[17:30:42] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68255754
[17:30:42] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68255795
[17:30:43] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=138315500
[17:30:43] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=138318153
[17:30:44] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=41665653
[17:30:44] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70582846
[17:30:45] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on bgwiki: https://bg.wikipedia.org/?diff=6455384
[17:36:12] <milimetric>	 James_F: I have a decent handle on the duplicate event_action types now, and I'd like to propose a way to handle them for analysis
[17:36:24] <milimetric>	 basically, for things like "save rate"
[17:36:32] * James_F nods.
[17:37:04] <milimetric>	 so for "save rate" we deduplicate
[17:37:19] <James_F>	 Right.
[17:37:40] <milimetric>	 then for more in-depth stuff, like duplicated failures, we look at each one and try to solve any instrumentation bugs, then make a separate dashboard to monitor the bizarre cases
[17:39:29] <grrrit-wm>	 (03PS4) 10Mooeypoo: Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) 
[17:41:42] <grrrit-wm>	 (03PS2) 10Mooeypoo: Reset paramOrder widget on dialog setup [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/187322 (https://phabricator.wikimedia.org/T88126) 
[17:49:39] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Reset paramOrder widget on dialog setup [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/187322 (https://phabricator.wikimedia.org/T88126) (owner: 10Mooeypoo)
[17:50:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reset paramOrder widget on dialog setup [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/187322 (https://phabricator.wikimedia.org/T88126) (owner: 10Mooeypoo)
[17:56:53] <grrrit-wm>	 (03PS5) 10Mooeypoo: [WIP] Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) 
[17:59:03] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (f2d7711) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187704 
[18:00:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (f2d7711) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187704 (owner: 10Jforrester)
[18:16:08] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187704 (owner: 10Jforrester)
[18:22:56] <wikibugs>	 3VisualEditor, VisualEditor-Performance: Get rid of unnecessary jQuery.html call in ve.dm.MWReferenceNode.static.toDomElements - https://phabricator.wikimedia.org/T87417#1004557 (10Jdforrester-WMF)
[18:23:02] <wikibugs>	 3UI-Standardization, MediaWiki-General-or-Unknown, OOjs-UI: Initialize theme and set directionality in MediaWiki Core - https://phabricator.wikimedia.org/T85767#1004562 (10Jdforrester-WMF)
[18:23:04] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Oldid in navigation links isn't updated after saving - https://phabricator.wikimedia.org/T74461#1004563 (10Jdforrester-WMF)
[18:23:05] <wikibugs>	 3VisualEditor, VisualEditor-Performance: Batch DOM insertions in ve.dm.InternalList.convertToData - https://phabricator.wikimedia.org/T87418#1004564 (10Jdforrester-WMF)
[18:23:11] <wikibugs>	 3Wikimedia-Site-requests, VisualEditor: Please enable VisualEditor in hewiki's "Draft" namespace - https://phabricator.wikimedia.org/T87027#1004565 (10Jdforrester-WMF)
[18:23:13] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor: Make it easy to identify the file type (e.g., .png versus .svg) when adding an image - https://phabricator.wikimedia.org/T74061#1004570 (10Jdforrester-WMF)
[18:23:13] <wikibugs>	 3OOjs: OOjs: v8 warns it won't optimize oo.Factory.create or oo.EventEmitter.emit - https://phabricator.wikimedia.org/T74933#1004568 (10Jdforrester-WMF)
[18:23:15] <wikibugs>	 3OOjs-UI: InputWidgets should detect the internal .value property and the <input>'s .value property getting desynchronised and do something smart - https://phabricator.wikimedia.org/T86868#1004569 (10Jdforrester-WMF)
[18:23:16] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor: A number of VisualEditor dialogs do not cover full screen when 'full' size - https://phabricator.wikimedia.org/T76863#1004571 (10Jdforrester-WMF)
[18:23:17] <wikibugs>	 3UI-Standardization, OOjs-UI: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#1004572 (10Jdforrester-WMF)
[18:23:21] <wikibugs>	 3MediaWiki-ContentHandler, VisualEditor, VisualEditor-MediaWiki: Add support in JsonContent for non-object structures (e.g. array) - https://phabricator.wikimedia.org/T86270#1004573 (10Jdforrester-WMF)
[18:23:23] <wikibugs>	 3OOjs-UI: Create an ActionFieldLayout - https://phabricator.wikimedia.org/T76634#1004578 (10Jdforrester-WMF)
[18:23:25] <wikibugs>	 3OOjs-UI: LookupInputWidget is terrible and also sucks - https://phabricator.wikimedia.org/T86851#1004577 (10Jdforrester-WMF)
[18:28:49] <mvolz>	 James_F: false alarm
[18:28:54] <mvolz>	 translators were out of date
[18:29:15] <mvolz>	 so it looked like Zotero wasn't working but it just turned out it didn't know how to do PloS journals anymore :)
[18:29:33] <mvolz>	 on the other hand the thing you mentioned with the BBC article probably means an actual bug
[18:29:37] <mvolz>	 do you remember the url?
[18:31:01] <mvolz>	 (also, good illustration of the importance of keeping translators up to date)
[18:35:32] <wikibugs>	 3UI-Standardization, OOjs-UI: OOjs UI: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1004605 (10werdna)
[18:47:03] <grrrit-wm>	 (03PS3) 10Esanders: Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 
[18:53:15] <grrrit-wm>	 (03CR) 10Alex Monk: "I added Trevor as a reviewer, hopefully he has some ideas." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179551 (https://phabricator.wikimedia.org/T78045) (owner: 10Alex Monk)
[18:54:13] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Per inline comments. Also we discussed compressing the character ranges where they overlap. Could be TD though." [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 (owner: 10Divec)
[19:06:12] <grrrit-wm>	 (03PS6) 10Mooeypoo: Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) 
[19:13:12] <Guest74321>	 RoanKattouw_away: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/commit/e68dd9c7c1a8bf18a812964bb4ca6d54da4c07de
[19:13:42] <InezK>	 RoanKattouw_away: How did you determine it should be 41em?
[19:14:46] <RoanKattouw_away>	 InezK: Magic
[19:14:50] <RoanKattouw_away>	 ;)
[19:15:09] <RoanKattouw_away>	 InezK: Really what's going on is the fact that it doesn't work without setting that height is a bug and we've been too lazy to fix it
[19:15:39] <InezK>	 bug with setting number of columns?
[19:16:02] <InezK>	 so you set height to the minimum possible while still maintaining just two columns?
[19:43:01] <wikibugs>	 3Parsoid, VisualEditor, VisualEditor-Performance: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1004902 (10GWicke) Another run from tin:  ``` ab -H 'Accept-encoding: gzip' -n200 'http://en.wikipedia.or...
[19:46:56] <grrrit-wm>	 (03PS4) 10Esanders: Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 
[19:47:48] <wikibugs>	 3VisualEditor-DataModel, VisualEditor: class="wikitable wikitable" corrupted to class="wikitable" - https://phabricator.wikimedia.org/T88148#1004924 (10Catrope) 3NEW
[19:48:12] <grrrit-wm>	 (03CR) 10Esanders: "Working now, still blocked on an OOUI pullthrough." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders)
[19:49:17] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: Add commas at end of lines for arrays in PHP [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 
[19:49:20] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader)
[19:52:05] <grrrit-wm>	 (03PS2) 10Gerrit Patch Uploader: Add commas at end of lines for arrays in PHP [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 
[19:52:08] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader)
[20:06:13] <grrrit-wm>	 (03PS3) 10Gerrit Patch Uploader: Style code in PHP and HTML [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 
[20:06:16] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader)
[20:19:23] <grrrit-wm>	 (03PS8) 10Legoktm: Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester)
[20:21:10] <legoktm>	 ugh, that doesn't work
[20:21:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester)
[20:22:50] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester)
[20:23:10] <grrrit-wm>	 (03PS4) 10Gerrit Patch Uploader: Style code in PHP and HTML [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 
[20:23:13] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader)
[20:24:54] <grrrit-wm>	 (03PS5) 10Gerrit Patch Uploader: Style code in PHP and HTML [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 
[20:24:57] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader)
[20:28:59] <grrrit-wm>	 (03PS1) 10Esanders: Remove labelPosition check [oojs/ui] - 10https://gerrit.wikimedia.org/r/187741 
[20:31:19] <grrrit-wm>	 (03PS1) 10Krinkle: build: Move /dist/coverage to /coverage and /docs/code to /docs [unicodejs] - 10https://gerrit.wikimedia.org/r/187742 
[20:36:29] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "Pending update of Jenkins configuration. Using this as test for moving generation of jsduck from production gallium to labs slaves and usi" [unicodejs] - 10https://gerrit.wikimedia.org/r/187742 (owner: 10Krinkle)
[20:43:15] <grrrit-wm>	 (03PS2) 10Jforrester: build: Move /docs/coverage to /coverage and /docs/code to /docs [unicodejs] - 10https://gerrit.wikimedia.org/r/187742 (owner: 10Krinkle)
[20:43:22] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Eh." [unicodejs] - 10https://gerrit.wikimedia.org/r/187742 (owner: 10Krinkle)
[20:45:55] <wikibugs>	 3VisualEditor: Cite: 'Autofill from URL' shows Basic as a type for inserted citation - https://phabricator.wikimedia.org/T88152#1005014 (10Etonkovidova) 3NEW
[20:46:03] <wikibugs>	 3Echo, MediaWiki-General-or-Unknown, VisualEditor, Release-Engineering: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1005021 (10Cmcmahon) It looks like:   And I click in the editable part...
[20:54:39] <wikibugs>	 3Parsoid, VisualEditor, VisualEditor-Performance: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1005034 (10BBlack) Didn't we run into this before once and decide to wipe the varnish parsoid caches to a...
[21:03:18] <grrrit-wm>	 (03PS9) 10Legoktm: Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester)
[21:05:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester)
[21:07:19] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] make rubocop stop complaining [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187804 
[21:08:27] <InezK>	 TrevorP|Away: Did you stop animating dialogs (zooming out) when closing them?
[21:09:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] make rubocop stop complaining [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187804 (owner: 10Cmcmahon)
[21:13:05] <grrrit-wm>	 (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187804 (owner: 10Cmcmahon)
[21:17:48] <grrrit-wm>	 (03CR) 10Ryasmeen: [C: 032] [BrowserTest] make rubocop stop complaining [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187804 (owner: 10Cmcmahon)
[21:21:43] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187804 (owner: 10Cmcmahon)
[21:23:18] <RoanKattouw>	 InezK: Hmm, maybe? Let me see
[21:23:37] <RoanKattouw>	 Yeah it looks like we don't animate them any more
[21:23:42] <RoanKattouw>	 I don't know if that's intended or not
[21:24:31] <RoanKattouw>	 It affects both the apex and MW themes of OOUI
[21:25:14] <InezK>	 yeah, but seems like there is still a slight delay when you want to close a dialog
[21:25:20] <RoanKattouw>	 InezK: I can't really find out if that's intended because James and Trevor will be in a meeting for the next few hours and Bartosz is about to get on a plane home
[21:25:25] <RoanKattouw>	 Yeah
[21:25:40] <RoanKattouw>	 It looks like it's waiting for the animation to complete, but the animation isn't there? Or something
[21:25:52] <InezK>	 could be something like that
[21:26:05] <InezK>	 RoanKattouw: Should I report it, or you will take care later with Trevor when he is out?
[21:26:15] <RoanKattouw>	 Please file a bug
[21:26:16] <InezK>	 RoanKattouw: Do you still have QA on the team?
[21:26:18] <RoanKattouw>	 I'm already investigating it
[21:26:20] <RoanKattouw>	 Yes we do
[21:26:25] <RoanKattouw>	 I can ask them if they noticed it
[21:26:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] make rubocop stop complaining [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187804 (owner: 10Cmcmahon)
[21:28:24] <grrrit-wm>	 (03CR) 10Cmcmahon: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187804 (owner: 10Cmcmahon)
[21:28:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] make rubocop stop complaining [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187804 (owner: 10Cmcmahon)
[21:29:54] <wikibugs>	 3Parsoid, VisualEditor, VisualEditor-Performance: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1005107 (10GWicke) @bblack, the results show Varnish being fairly fast while retrieving the same content...
[21:30:54] <InezK>	 RoanKattouw: https://www.dropbox.com/s/0xnnz72u8qhx1em/Screenshot%202015-01-30%2013.30.45.png?dl=0
[21:31:10] <InezK>	 I think that timeout comes from this getTeardownDelay which is 250ms
[21:34:04] <RoanKattouw>	 Yeah I'm investigating now
[21:34:12] <RoanKattouw>	 I suspect my commit on November 21 may have broken it
[21:35:04] <grrrit-wm>	 (03PS11) 10Alex Monk: Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) 
[21:36:41] <RoanKattouw>	 InezK: I have a fix
[21:36:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk)
[21:36:59] <grrrit-wm>	 (03PS12) 10Alex Monk: Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) 
[21:38:09] <InezK>	 great
[21:38:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk)
[21:40:03] <grrrit-wm>	 (03PS1) 10Catrope: Fix opening/closing animation on windows [oojs/ui] - 10https://gerrit.wikimedia.org/r/187811 
[21:40:06] <RoanKattouw>	 InezK: ---^^
[21:40:36] <RoanKattouw>	 InezK: Very simple change, should be easy to backport in case you're not willing to wait for it to merge or to update to the latest version of OOUI
[21:41:20] <grrrit-wm>	 (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk)
[21:44:07] <InezK>	 Thanks
[21:54:57] <grrrit-wm>	 (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk)
[21:57:23] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Ic8c7cbf741 has been deployed. JSDuck publishing for this repo now generates it on a labs slave and uses the integration-publisher to push" [unicodejs] - 10https://gerrit.wikimedia.org/r/187742 (owner: 10Krinkle)
[21:58:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Move /docs/coverage to /coverage and /docs/code to /docs [unicodejs] - 10https://gerrit.wikimedia.org/r/187742 (owner: 10Krinkle)
[22:18:11] <wikibugs>	 3VisualEditor-ContentEditable, VisualEditor: Editing pre-formatted text creates <br> - https://phabricator.wikimedia.org/T88157#1005225 (10despens) 3NEW
[22:26:06] <InezK>	 RoanKattouw: Do you know how I can open page on mediawiki.org in VE but in MW skin, not APEX?
[22:26:28] <InezK>	 I'm running into some bug with height of foot in dialog, but need to verify
[22:31:10] <grrrit-wm>	 (03PS9) 10Esanders: Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal)
[22:31:12] <grrrit-wm>	 (03PS1) 10Esanders: Make BookletLayout inherit from MenuLayout instead of embedding a GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187824 
[22:32:12] <InezK>	 RoanKattouw: or maybe you will have some idea why this behaves so bad: http://visualeditor.inez.wikia-dev.com/wiki/InezsTest?veaction=edit&debug=true when you open any dialog (on screen height <~600px) buttons in the foot won't be visible
[22:33:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal)
[22:33:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make BookletLayout inherit from MenuLayout instead of embedding a GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187824 (owner: 10Esanders)
[22:35:41] <Krenair>	 InezK, https://www.mediawiki.org/wiki/Manual:$wgParserConf?veaction=edit shows MW skin to me
[22:35:58] <InezK>	 oh, sorry, so I guess I want APEX
[22:36:37] <Krenair>	 use the standalone demo
[22:38:53] <grrrit-wm>	 (03PS10) 10Esanders: Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal)
[22:38:56] <grrrit-wm>	 (03PS2) 10Esanders: Make BookletLayout inherit from MenuLayout instead of embedding a GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187824 
[22:41:01] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Add MenuLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/184008 (owner: 10Trevor Parscal)
[22:44:10] <InezK>	 standalone demo does not have dialog with extra actions
[22:44:14] <InezK>	 extra / other
[22:44:49] <mooeypoo>	 I think ooui demo page does?
[22:53:34] <InezK>	 mooeypoo: thanks, it does, that's helpful
[22:54:13] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] remove old hack and fix "a is undefined" bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187829 
[22:56:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] remove old hack and fix "a is undefined" bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187829 (owner: 10Cmcmahon)
[22:56:16] <grrrit-wm>	 (03PS2) 10Catrope: [BrowserTest] remove old hack and fix "a is undefined" bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187829 (https://phabricator.wikimedia.org/T87446) (owner: 10Cmcmahon)
[22:57:33] <grrrit-wm>	 (03PS1) 10Esanders: Add simpler window#updateSize API [oojs/ui] - 10https://gerrit.wikimedia.org/r/187830 
[22:58:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] remove old hack and fix "a is undefined" bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187829 (https://phabricator.wikimedia.org/T87446) (owner: 10Cmcmahon)
[22:59:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add simpler window#updateSize API [oojs/ui] - 10https://gerrit.wikimedia.org/r/187830 (owner: 10Esanders)
[22:59:33] <grrrit-wm>	 (03PS2) 10Catrope: Add simpler window#updateSize API [oojs/ui] - 10https://gerrit.wikimedia.org/r/187830 (owner: 10Esanders)
[23:06:28] <InezK>	 such a weird bug with CSS
[23:06:29] <InezK>	 ohhhhg
[23:13:26] <grrrit-wm>	 (03CR) 10Mooeypoo: [wip] Use css class rather than jQuery show/hide (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 (owner: 10Mooeypoo)
[23:13:32] <grrrit-wm>	 (03CR) 10Mooeypoo: [wip] Use css class instead of jquery show/hide (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo)
[23:15:07] <grrrit-wm>	 (03CR) 10Ryasmeen: [C: 032] [BrowserTest] remove old hack and fix "a is undefined" bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187829 (https://phabricator.wikimedia.org/T87446) (owner: 10Cmcmahon)
[23:16:06] <ryasmeen>	 chrismcmahon: ^^
[23:16:27] <chrismcmahon>	 ryasmeen: thank you. progress!
[23:16:28] <ryasmeen>	 chrismcmahon: I suppose now you can review my patches
[23:16:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] remove old hack and fix "a is undefined" bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187829 (https://phabricator.wikimedia.org/T87446) (owner: 10Cmcmahon)
[23:17:01] <chrismcmahon>	 ryasmeen: yes, thanks for your patience with all this
[23:17:18] <ryasmeen>	 no worries :)
[23:19:05] <grrrit-wm>	 (03PS3) 10Cmcmahon: [BrowserTest] Updating test for Media Settings interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 (owner: 10Ryasmeen)
[23:19:29] <grrrit-wm>	 (03PS3) 10Cmcmahon: [BrowserTest] Test for checking General Settings for media [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187610 (owner: 10Ryasmeen)
[23:19:48] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] Add basic test for table creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova)
[23:20:28] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] Test to check the functionality of Change Image button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 (owner: 10Ryasmeen)
[23:20:36] <Krenair>	 ori, about?
[23:21:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Test for checking General Settings for media [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187610 (owner: 10Ryasmeen)
[23:21:39] <chrismcmahon>	 ryasmeen: everything rebased cleanly (whew!)
[23:22:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Test to check the functionality of Change Image button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 (owner: 10Ryasmeen)
[23:23:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Add basic test for table creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova)
[23:32:09] <wikibugs>	 3Parsoid, VisualEditor, VisualEditor-Performance: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1005525 (10GWicke) From the office:  ``` ab -H 'Accept-encoding: gzip' -n200 'http://en.wikipedia.org/w/a...
[23:38:38] <Krenair>	 ok, ori is definitely not around. will email I guess
[23:42:55] <grrrit-wm>	 (03CR) 10Ryasmeen: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187610 (owner: 10Ryasmeen)
[23:47:52] <chrismcmahon>	 ryasmeen: tests are still failing for me, but for reasonable reasons. I'll pick these up early Monday at the latest, it is near the end of my day/week
[23:48:21] <ryasmeen>	 okay chrismcmahon
[23:53:29] <ryasmeen>	 chrismcmahon: so all browser tests are still failing for you? or those new ones?
[23:55:18] <chrismcmahon>	 the media tests
[23:55:34] <chrismcmahon>	 not exactly sure why ryasmeen
[23:56:05] <ryasmeen>	 are you getting time-out error?
[23:56:48] <chrismcmahon>	 ryasmeen: yes, a couple of different ones 
[23:57:12] <ryasmeen>	 yeah its because the images are loading super slowly in Betalabs'
[23:57:18] <ryasmeen>	 chrismcmahon
[23:57:33] <ryasmeen>	 I get that too intermittently
[23:57:36] <chrismcmahon>	 that sounds like an actual bug
[23:57:41] <chrismcmahon>	 performance problem
[23:57:43] <ryasmeen>	 yes reported it
[23:57:55] <chrismcmahon>	 thanks!
[23:58:02] <ryasmeen>	 but not sure if anyone working on it or not
[23:58:07] <ryasmeen>	 let me find you the one
[23:59:10] <ryasmeen>	 chrismcmahon:https://phabricator.wikimedia.org/T87676