[00:56:39] (03PS2) 10Jforrester: Follow-up 6fc57d41: Update build results with grunt [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187893 (owner: 10Esanders) [00:58:08] (03CR) 10Jforrester: [C: 032] Follow-up 6fc57d41: Update build results with grunt [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187893 (owner: 10Esanders) [01:00:08] (03CR) 10jenkins-bot: [V: 04-1] Follow-up 6fc57d41: Update build results with grunt [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187893 (owner: 10Esanders) [01:02:07] (03Merged) 10jenkins-bot: Follow-up 6fc57d41: Update build results with grunt [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187893 (owner: 10Esanders) [01:07:58] (03PS1) 10Jforrester: build: Fail in CI if there are resultant changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187939 [01:08:33] (03CR) 10Krinkle: [C: 032] build: Fail in CI if there are resultant changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187939 (owner: 10Jforrester) [01:09:36] (03Abandoned) 10Krinkle: ve.ce.LinkAnnotation: Use getResolvedAttribute for href [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187313 (owner: 10Krinkle) [01:10:23] (03Merged) 10jenkins-bot: build: Fail in CI if there are resultant changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187939 (owner: 10Jforrester) [01:11:53] (03CR) 10Trevor Parscal: [C: 032] Make BookletLayout inherit from MenuLayout instead of embedding a GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187824 (owner: 10Esanders) [01:12:53] (03PS4) 10Jforrester: Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:13:04] (03PS2) 10Jforrester: SelectWidget: listbox wrapper role, state on contents [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [01:13:15] (03Merged) 10jenkins-bot: Make BookletLayout inherit from MenuLayout instead of embedding a GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/187824 (owner: 10Esanders) [01:14:44] (03CR) 10Jforrester: Use standard border colours for progress bars (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187864 (owner: 10Esanders) [01:19:59] (03CR) 10jenkins-bot: [V: 04-1] SelectWidget: listbox wrapper role, state on contents [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [01:20:01] (03CR) 10jenkins-bot: [V: 04-1] Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:43:18] (03PS1) 10Jforrester: Tag v0.6.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/187942 [01:44:51] edsanders: https://gerrit.wikimedia.org/r/#/c/187942/ please? Assuming it actually works for you. :-) [01:52:12] 3OOjs-UI: [Regression] ButtonSelectWidget doesn't unhighlight when an item gets unselected - https://phabricator.wikimedia.org/T88232#1006602 (10Jdforrester-WMF) 3NEW [02:02:48] (03PS1) 10Esanders: Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 [02:07:27] (03CR) 10Jforrester: [C: 04-1] "Let's fix T88232 first." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187942 (owner: 10Jforrester) [02:58:53] (03PS2) 10Esanders: Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 [03:02:49] (03CR) 10jenkins-bot: [V: 04-1] Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 (owner: 10Esanders) [06:05:48] (03PS3) 10Esanders: Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 [06:05:50] (03PS1) 10Esanders: Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 [06:11:58] (03CR) 10jenkins-bot: [V: 04-1] Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 (owner: 10Esanders) [06:13:07] (03CR) 10jenkins-bot: [V: 04-1] Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders) [11:35:26] 3MediaWiki-Page-editing, Editing: Update HTML title with displaytitle on live preview - https://phabricator.wikimedia.org/T88117#1006744 (10Fomafix) An other solution to avoid an overflowing border bottom of the headers without adding `overflow:hidden` to h2 is generating the border bottom by a pseudo element wi... [12:09:00] 3OOjs-UI: ButtonSelectWidget doesn't unhighlight when an item gets unselected - https://phabricator.wikimedia.org/T88232#1006759 (10matmarex) [12:57:01] 3OOjs-UI: ButtonSelectWidget doesn't unhighlight when an item gets unselected - https://phabricator.wikimedia.org/T88232#1006767 (10matmarex) a:3matmarex [12:57:22] (03PS1) 10Bartosz Dziewoński: ButtonElement: Unbreak 'pressed' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/187953 (https://phabricator.wikimedia.org/T88232) [12:58:23] (03PS2) 10Bartosz Dziewoński: ButtonElement: Unbreak 'pressed' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/187953 (https://phabricator.wikimedia.org/T88232) [12:59:51] 3OOjs-UI: TextInputWidget autosizing no longer works on Firefox - https://phabricator.wikimedia.org/T88212#1006771 (10matmarex) p:5Triage>3Unbreak! [12:59:57] 3OOjs-UI: TextInputWidget autosizing no longer works on Firefox - https://phabricator.wikimedia.org/T88212#1006772 (10matmarex) a:3matmarex [13:24:53] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Mostly revert "Don't try adjusting size when detached" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187954 (https://phabricator.wikimedia.org/T88212) [13:52:38] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#1006785 (10matmarex) DOMNodeInsertedIntoDocument is not supported in Firefox, by the way. http://help.dottoro.com/ljfvvdnm.php#additionalEvents http://jsfiddle.net/xzwj8d7L/ [13:53:34] 3VisualEditor-EditingTools, VisualEditor: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1006787 (10matmarex) The underlying issue is that Firefox does not support the DOMNodeInsertedIntoDocumen... [13:53:42] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#655254 (10matmarex) [13:53:43] 3VisualEditor-EditingTools, VisualEditor: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1006789 (10matmarex) [13:53:51] 3VisualEditor-EditingTools, VisualEditor: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1006791 (10matmarex) a:5matmarex>3None [16:58:10] 3MediaWiki-Page-editing: Excessive quantity of edits conflict in a busy project page - https://phabricator.wikimedia.org/T86785#1006897 (10Nemo_bis) Closing per above. [16:58:26] 3MediaWiki-Page-editing: Excessive quantity of edits conflict in a busy project page - https://phabricator.wikimedia.org/T86785#1006898 (10Nemo_bis) [16:58:29] 3MediaWiki-Page-editing: Edit conflicts (tracking) - https://phabricator.wikimedia.org/T72163#1006899 (10Nemo_bis) [17:30:36] Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1485122 [17:30:36] Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1485125 [17:30:36] Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1485126 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111443253 [17:30:37] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34167164 [17:30:37] Corruption alert: visualeditor-needcheck on thwiki: https://th.wikipedia.org/?diff=5779038 [17:30:37] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68292166 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68301073 [17:30:38] Corruption alert: visualeditor-needcheck on cawiki: https://ca.wikipedia.org/?diff=14790739 [17:42:43] 3Parsoid, VisualEditor, VisualEditor-Performance: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1006968 (10GWicke) On Friday, @bblack found from varnish logs that PHP returned (at least the first byte)... [18:06:56] 3Parsoid, VisualEditor, VisualEditor-Performance: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1006972 (10GWicke) Removed comment above as more repetitions showed fast responses even for cache misses.... [20:04:42] (03CR) 10Esanders: [C: 032] ButtonElement: Unbreak 'pressed' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/187953 (https://phabricator.wikimedia.org/T88232) (owner: 10Bartosz Dziewoński) [20:05:11] (03PS4) 10Esanders: Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 [20:05:13] (03PS2) 10Esanders: Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 [20:08:36] (03Merged) 10jenkins-bot: ButtonElement: Unbreak 'pressed' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/187953 (https://phabricator.wikimedia.org/T88232) (owner: 10Bartosz Dziewoński) [20:09:29] (03CR) 10jenkins-bot: [V: 04-1] Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 (owner: 10Esanders) [20:09:58] (03CR) 10jenkins-bot: [V: 04-1] Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders) [20:28:03] 3VisualEditor-MediaWiki-Media, VisualEditor: Don't request image resizes from the API if we already have a larger image in the cache - https://phabricator.wikimedia.org/T88248#1007060 (10Esanders) 3NEW [20:29:48] (03CR) 10Esanders: "fixed" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187942 (owner: 10Jforrester) [21:10:16] (03PS1) 10Esanders: Only re-render if the images is larger than the last rendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) [21:12:07] (03CR) 10jenkins-bot: [V: 04-1] Only re-render if the images is larger than the last rendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [21:22:55] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [21:29:55] 3OOjs-UI: Create tag list / tokenizer widget - https://phabricator.wikimedia.org/T88250#1007089 (10Esanders) 3NEW [22:06:59] hello [22:14:35] hi [22:14:50] Krenair: you know, I was thinking -- we should probably use some external statsd library [22:15:07] though I'm not sure how to integrate one with core without introducing a dependency [23:48:42] (03CR) 10Ori.livneh: [C: 04-2] "For reasons I don't quite understand, this causes a performance regression to the tune of ~200ms. Let's discuss on Monday." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186100 (https://phabricator.wikimedia.org/T87161) (owner: 10Catrope) [23:49:03] RoanKattouw_away: theories on ^ most welcome