[02:04:27] * James_F considers stopping working. [02:04:34] The infamy! And on a Sunday, no less! [02:41:54] (03PS2) 10Jforrester: Tag v0.6.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/187942 [02:42:22] (03CR) 10Jforrester: [C: 031] Tag v0.6.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/187942 (owner: 10Jforrester) [03:02:11] (03CR) 10Esanders: [C: 032] Tag v0.6.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/187942 (owner: 10Jforrester) [03:03:39] (03Merged) 10jenkins-bot: Tag v0.6.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/187942 (owner: 10Jforrester) [03:08:32] James_F: are you in the office? [03:08:32] 3OOjs-UI: ButtonSelectWidget doesn't unhighlight when an item gets unselected - https://phabricator.wikimedia.org/T88232#1007248 (10Ricordisamoa) [03:10:21] the vebench results are about to get a lot less shitty [03:14:13] ori: I am. Sounds good [03:15:19] 3VisualEditor-ContentLanguage, VisualEditor, VisualEditor-InterfaceLanguage: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - https://phabricator.wikimedia.org/T35126#1007251 (10Jdforrester-WMF) [03:15:20] 3VisualEditor-MediaWiki, VisualEditor, Math: VisualEditor formula insertion field must always be ltr and not rtl - https://phabricator.wikimedia.org/T87637#1007250 (10Jdforrester-WMF) 5Open>3Resolved [03:15:32] 3VisualEditor-MediaWiki-Media, VisualEditor: Add an explanation about Alternative text in the media adding dialog - https://phabricator.wikimedia.org/T75731#1007252 (10Jdforrester-WMF) 5Open>3Resolved [03:15:48] 3VisualEditor-MediaWiki-Media, VisualEditor: In the new media dialog, clicking on the last result before more results have time to be fetched from the API causes the result list to be filled with empty rows - https://phabricator.wikimedia.org/T86802#1007254 (10Jdforrester-WMF) 5Open>3Resolved [03:26:44] 3OOjs-UI: ButtonSelectWidget doesn't unhighlight when an item gets unselected - https://phabricator.wikimedia.org/T88232#1007269 (10Jdforrester-WMF) 5Open>3Resolved [03:27:51] 3OOjs-UI: ButtonOptionWidget should be keyboard navigable - https://phabricator.wikimedia.org/T88085#1007271 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [03:29:44] (03PS1) 10Jforrester: Update OOjs UI to v0.6.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188020 [03:33:03] 3OOjs-UI: RadioSelectWidget is not accessible - https://phabricator.wikimedia.org/T88082#1007283 (10Jdforrester-WMF) p:5Triage>3High [03:33:05] 3OOjs-UI: SelectWidget group of OptionWidget is not presenting its state - https://phabricator.wikimedia.org/T88091#1007284 (10Jdforrester-WMF) p:5Triage>3High [03:33:06] 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1007285 (10Jdforrester-WMF) p:5Triage>3High [03:33:09] 3OOjs-UI: Toolbar menus don't disappear when another menu is opened on touch devices - https://phabricator.wikimedia.org/T87818#1007288 (10Jdforrester-WMF) p:5Triage>3High [03:35:32] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.6.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188020 (owner: 10Jforrester) [03:35:35] 3OOjs-UI: Add SVG+PNG distribution serving SVG images to modern browsers and PNG as a fallback, primarily for PHP OOUI support in older browsers - https://phabricator.wikimedia.org/T87501#1007294 (10Jdforrester-WMF) Is this something to do in OOjs UI or in the use of it in MW? [03:35:56] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188020 (owner: 10Jforrester) [03:36:34] 3OOjs-UI: Create tag list / tokenizer widget - https://phabricator.wikimedia.org/T88250#1007296 (10Jdforrester-WMF) p:5Triage>3Normal [03:36:57] 3OOjs-UI: Add SVG+PNG distribution serving SVG images to modern browsers and PNG as a fallback, primarily for PHP OOUI support in older browsers - https://phabricator.wikimedia.org/T87501#1007298 (10Jdforrester-WMF) p:5Triage>3High [03:38:04] 3OOjs-UI, VisualEditor: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1007300 (10Jdforrester-WMF) p:5Normal>3High [03:44:18] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 (owner: 10Esanders) [03:47:09] (03CR) 10Jforrester: [C: 032] Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 (owner: 10Esanders) [03:50:47] 3VisualEditor-MediaWiki-Media, VisualEditor-Performance, VisualEditor: Don't request image resizes from the API if we already have a larger image in the cache - https://phabricator.wikimedia.org/T88248#1007308 (10Jdforrester-WMF) a:3Esanders [03:51:08] (03CR) 10Jforrester: [C: 031] "Are there browser garbage collection issues, or should we not worry?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [03:51:30] (03CR) 10jenkins-bot: [V: 04-1] Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 (owner: 10Esanders) [03:52:06] (03CR) 10Jforrester: [C: 032] "Eurgh." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 (owner: 10Esanders) [03:53:53] (03Merged) 10jenkins-bot: Rename file drop to data transfer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187943 (owner: 10Esanders) [03:56:17] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders) [03:59:08] 3VisualEditor-MediaWiki-Media, VisualEditor-Performance, VisualEditor: Don't request image resizes from the API if we already have a larger image in the cache - https://phabricator.wikimedia.org/T88248#1007341 (10Jdforrester-WMF) p:5Triage>3Normal [04:01:12] 3Editing, Mobile-Web, VisualEditor, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1007347 (10Jdforrester-WMF) [04:01:57] 3WMF-Design, Editing, VisualEditor: Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181#1007350 (10Jdforrester-WMF) a:3KHammerstein [04:02:04] 3WMF-Design, Editing, VisualEditor: Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181#20433 (10Jdforrester-WMF) Is this really "easy"? [04:02:36] 3VisualEditor-MediaWiki, VisualEditor: Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181#1007357 (10Jdforrester-WMF) p:5Triage>3Normal [04:03:07] 3OOjs-UI: DraggableGroupElement should handle non OptionWidget items - https://phabricator.wikimedia.org/T88053#1007365 (10Jdforrester-WMF) p:5Triage>3Normal [04:03:45] 3VisualEditor: VisualEditor Q3 Domination Criteria - https://phabricator.wikimedia.org/T86867#1007369 (10Jdforrester-WMF) p:5Triage>3Normal [04:11:42] James_F: most of the profiling work RoanKattouw did last week would have to be repeated [04:11:48] I'm sure he'll be delighted to know [04:11:51] ori: I saw. :-) [04:12:12] ori: Well, hopefully he didn't rm -rf the old checkouts, so… [04:12:41] controlling for network costs really drives home how much network costs dominate [04:13:10] Yeah. :-( [04:13:29] On the plus side, improving network stuff is the main focus of our work, so… [04:14:17] for http://fr.wikipedia.org/w/index.php?title=%C3%89tats-Unis&oldid=111449635 time spent executing JS is almost exactly 10% of the total load time [04:14:29] and that's when measuring on the cluster [04:15:03] ori: FWIW, I just (a) opened that tab, and (b) clicked edit. [04:15:25] ori: (a) took (cold start) > 11 seconds. (b) took ~ 7. [04:15:37] Maybe we should later look at read network load. :-) [04:15:51] what do you mean? [04:15:56] that's just the browser cache doing its thing. [04:16:09] 11 s to get to a readable page is pretty terrible. [04:16:27] oh, i see what you're saying [04:16:38] Especially in a fast browser in a fast computer on a 100Mbps pipe. [04:17:50] 11s seems a little crazy [04:18:09] http://i.imgur.com/3Rci9T0.png [04:18:23] Hmm. Not bad. [04:18:24] i got 3.34 to full load on a crappy DSL with cache disabled [04:19:09] anyways, it's not really relevant, since we're trying to be good, not "good, considering...", or "good, if you compare..." [04:19:19] Sure. [04:19:40] In an open tab I get 2.72s with cache disabled. [04:19:50] Maybe adding a new tab is what makes it hugely slow. [04:19:59] But I'm mildly surprised it's so expensive. [04:20:00] do you have a shit-ton of extensions? :) [04:20:20] I have 5, but some of them are bigger than others. :-) [04:21:22] do you know what is the status of krenair's imageinfo batching work? [04:21:27] how far away from deployment is that? [04:21:54] It's probably going to get merged tomorrow (and so go out on Wednesday in the train). [04:22:49] cool, thanks [04:23:49] wow, it's crazy for that page [04:23:59] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [04:24:01] ? [04:24:19] the number of requests is nuts [04:24:25] Oh, yeah. :-( [04:24:44] 97! [04:24:47] api.php calls [04:24:49] Ouch. [04:24:54] well, 98 if you include the main one [04:24:59] Let's get than down to 2. :-) [04:25:01] 97 calls that shouldn't exist [04:25:06] Yeah. [04:25:44] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) (owner: 10Bartosz Dziewoński) [04:26:59] why are those calls necessary? [04:27:13] Which calls? The iinfo ones? [04:27:25] (03CR) 10jenkins-bot: [V: 04-1] Wait with showing edit notices until after the welcome dialog is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) (owner: 10Bartosz Dziewoński) [04:27:28] yeah [04:27:32] what are they doing, exactly? [04:27:47] i mean, they're getting the image title and size, but why is that necessary for the editor to load? [04:27:49] They're getting the URL and bounding box of the images on the page. [04:28:09] The first is so we can edit them; the second is so we can stop the user re-sizing the image to an invalid size. [04:28:32] You can only make images up to 100% of their size, unless they're SVGs or other "type=DRAWING" images. [04:30:10] if that's the case, then batching is the wrong approach [04:30:13] 3VisualEditor-MediaWiki, VisualEditor: Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181#1007399 (10Jaredzimmerman-WMF) [04:30:29] We need to know how big you can make the image before we can let you touch images on the page. [04:30:40] 3VisualEditor-MediaWiki, VisualEditor: Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181#20433 (10Jaredzimmerman-WMF) I didn't tag it easy, but I've removed it. [04:31:03] 3VisualEditor-MediaWiki, VisualEditor: Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181#1007401 (10Jdforrester-WMF) Thanks. [04:31:17] We could try to only ask for the images "in view" but that would get really messy. [04:31:34] Or we could not allow you to resize the image for ~0.5s after you've started interacting with it. [04:31:43] yeah, that's way better [04:31:47] i mean, i know how awful that sounds [04:31:49] Or snap back the image a second after you've made it break. [04:31:54] But it was a really terrible interface. [04:31:56] So we changed it. [04:32:04] but this single feature dominates the load time of VE [04:32:12] :-( [04:32:16] dwarfing everything else, including the fetching of the parsoid DOM [04:33:20] for that page i can fetch the parsoid DOM in 1.5s; JS adds another 500ms, so you're looking at about 2s for everything but image resizing and another 5s for image resizing [04:33:59] On the network fetch side? [04:34:03] Or the document build side? [04:34:41] I'm not sure what you're asking. I'm saying we could cut the total real-user load time of VE from 7 seconds to 2 on that page if we eliminated the imageinfo requests [04:35:34] It only takes 500ms to build the page? [04:35:49] yes [04:35:56] That's seriously impressive. [04:36:00] well, 600ms, i rounded down to make my point stronger :P [04:36:11] Sure. :-) [04:38:02] Anyway, it's 20:37, I should leave the office before I have to come back. :-) [04:38:04] * James_F waves. [04:38:13] wait, one last quick question [04:38:21] The first is so we can edit them [04:38:24] what do you mean? [04:38:38] oh, edit the URL, you mean? [04:38:45] oh, he's gone. bye! [05:10:09] 3VisualEditor, VisualEditor-Performance: LinkCache should be smarter - https://phabricator.wikimedia.org/T88259#1007406 (10ori) 3NEW [05:13:10] 3VisualEditor, VisualEditor-Performance: LinkCache should be smarter - https://phabricator.wikimedia.org/T88259#1007414 (10ori) The relevant code is in ApiVisualEditor.php, L462-484 and in ve.init.mw.LinkCache.js. [06:23:09] (03PS3) 10Esanders: Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 [06:23:11] (03PS1) 10Esanders: Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 [06:23:13] (03PS1) 10Esanders: Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 [06:24:19] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [06:25:10] (03CR) 10Esanders: "I can't see why, all we're doing is not changing the image src fewer times." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [06:26:26] (03CR) 10jenkins-bot: [V: 04-1] Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 (owner: 10Esanders) [06:26:28] (03CR) 10jenkins-bot: [V: 04-1] Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 (owner: 10Esanders) [06:26:59] (03CR) 10jenkins-bot: [V: 04-1] Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders) [06:59:16] (03PS2) 10Esanders: Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 [06:59:18] (03PS2) 10Esanders: Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 [06:59:20] (03PS4) 10Esanders: Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 [07:01:11] (03CR) 10jenkins-bot: [V: 04-1] Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders) [07:01:49] (03CR) 10jenkins-bot: [V: 04-1] Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 (owner: 10Esanders) [07:02:47] (03CR) 10jenkins-bot: [V: 04-1] Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 (owner: 10Esanders) [07:37:01] (03PS3) 10Esanders: Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 [07:37:03] (03PS3) 10Esanders: Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 [07:37:05] (03PS5) 10Esanders: Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 [09:12:34] (03PS10) 10Paladox: Replace hidesig module with a more robust implementation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/102076 (https://phabricator.wikimedia.org/T59727) (owner: 10TTO) [14:05:03] 3MediaWiki-Page-editing: Return to page after edit of section when section name occurs multiple times may point to wrong section - https://phabricator.wikimedia.org/T2111#1008203 (10Nemo_bis) p:5Volunteer?>3Normal [14:44:35] 3Echo, MediaWiki-General-or-Unknown, VisualEditor, Release-Engineering: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1008250 (10Cmcmahon) It's not exactly fixed. [14:48:18] 3Echo, MediaWiki-General-or-Unknown, VisualEditor, Release-Engineering: Get JQuery error "a is undefined" running browser tests locally for Firefox - https://phabricator.wikimedia.org/T87446#1008251 (10Cmcmahon) It's not exactly fixed. Elena discovered that by not firing an explicit javascript 'onfocus' event, t... [15:42:05] 3Editing, Mobile-Web, VisualEditor, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1008341 (10Jdlrobson) Please when adding the target ensure that the module is as lightweight as possible and... [16:17:33] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: IE11- inserting a link with a shortcut(Cmd+K) opens and closes the link inspector momentarily - https://phabricator.wikimedia.org/T75154#1008382 (10Aklapper) @Etonkovidova: Why was "Verified-in-Phase0" set here? [16:17:39] 3Editing, Mobile-Web, VisualEditor, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1008384 (10Jdforrester-WMF) >>! In T87869#1008341, @Jdlrobson wrote: > Please when adding the target ensure... [16:30:57] 3MediaWiki-Page-editing: Return to page after edit of section when section name occurs multiple times may point to wrong section - https://phabricator.wikimedia.org/T2111#1008439 (10Jdforrester-WMF) p:5Normal>3Volunteer? Please don't change the priority on tasks that have idled for over a decade. This is rar... [17:04:01] 3OOjs-UI: Add SVG+PNG distribution serving SVG images to modern browsers and PNG as a fallback, primarily for PHP OOUI support in older browsers - https://phabricator.wikimedia.org/T87501#1008492 (10matmarex) [17:04:52] 3OOjs-UI: Add SVG+PNG distribution serving SVG images to modern browsers and PNG as a fallback, primarily for PHP OOUI support in older browsers - https://phabricator.wikimedia.org/T87501#992936 (10matmarex) Both, we need changes to OOjs UI build process and then changes to the pull-through process in MediaWiki.... [17:20:40] (03CR) 10Mooeypoo: Use css class instead of jQuery .show()/hide()/toggle() (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo) [17:21:11] (03PS7) 10Mooeypoo: Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) [17:21:16] hey Krenair [17:21:20] how was your flight? [17:21:46] Hey Krenair. [17:22:06] mooeypoo: https://gerrit.wikimedia.org/r/#/c/188020/ [17:22:26] (03CR) 10Mooeypoo: [C: 032] Update OOjs UI to v0.6.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188020 (owner: 10Jforrester) [17:24:58] (03CR) 10Bartosz Dziewoński: "What is it with the persistent failures…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) (owner: 10Bartosz Dziewoński) [17:25:03] (03PS3) 10Bartosz Dziewoński: Wait with showing edit notices until after the welcome dialog is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) [17:25:32] (03CR) 10Jforrester: "> What is it with the persistent failures…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) (owner: 10Bartosz Dziewoński) [17:28:31] (03CR) 10jenkins-bot: [V: 04-1] Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo) [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111498839 [17:30:35] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34184158 [17:30:35] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34184192 [17:30:35] Corruption alert: visualeditor-needcheck on plwiki: https://pl.wikipedia.org/?diff=41694500 [17:30:36] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70636390 [17:31:15] mooeypoo: https://github.com/jquery/jquery.com/issues/88 [17:31:26] James_F: why do corruption alerts come in batches? [17:32:19] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.6.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188020 (owner: 10Jforrester) [17:33:19] ori, yeah, that's the point of the change I submitted -- it's in ooui, but there are also 2 fixes pending for ve-core and ve-mw [17:33:39] ori, is there a way to test the speed before merge and after? I am curious to see how much that change will affect things [17:34:30] ori: It's a bot that runs once every 24 hours. [17:36:42] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188020 (owner: 10Jforrester) [17:38:32] (03Merged) 10jenkins-bot: Update OOjs UI to v0.6.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188020 (owner: 10Jforrester) [17:39:50] mooeypoo: yes, i can test it for you [17:39:59] mooeypoo: (i don't think you have the requisite access rights on the test box) [17:42:33] ori, I am not sure I'll know how, either. I tried to play around with Chrome's "profile" thing but that didn't really lead me anywhere [17:56:02] 3Flow, VisualEditor, Continuous-Integration: Flow tests fails to run with VisualEditor installed - https://phabricator.wikimedia.org/T86920#1008582 (10EBernhardson) [17:56:09] hey mooeypoo [17:56:09] the flight itself was fine [17:56:09] when I got to the other side, the ePassport gate would not recognise me :< [17:56:10] and then when I got home I found that some private security at SFO had searched my checked bag, damaging the lock on the strap in the process [17:56:49] oops [17:57:07] Krenair: Fun. :-( [17:57:22] but yeah, you are usually advised not to lock your bag pre-TSA, because they most often open them [17:57:26] :\ [17:57:32] (03CR) 10Mooeypoo: [C: 04-1] "Okay, sadly, I found a bug in both LTR/RTL, and in both Chrome and Firefox:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [18:01:04] 3Flow, VisualEditor, Continuous-Integration: Flow tests fails to run with VisualEditor installed - https://phabricator.wikimedia.org/T86920#1008598 (10EBernhardson) [18:11:53] James_F, https://gerrit.wikimedia.org/r/#/c/186913/ [18:13:05] (03PS4) 10Mooeypoo: Use the new image cache in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187847 (https://phabricator.wikimedia.org/T88187) [18:15:04] (03CR) 10jenkins-bot: [V: 04-1] Use the new image cache in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187847 (https://phabricator.wikimedia.org/T88187) (owner: 10Mooeypoo) [18:15:34] mooeypoo: https://gerrit.wikimedia.org/r/#/c/187967/ [18:19:16] (03CR) 10Jforrester: [C: 04-1] "Should be rebased onto I097311e to avoid nightmares, I imagine." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [18:19:50] 3VisualEditor: Category disappeared during edit - https://phabricator.wikimedia.org/T85671#1008692 (10Whatamidoing-WMF) It happened again: https://office.wikimedia.org/w/index.php?diff=128380&oldid=128372 I don't think this has anything to do with the content of the page (which is all just plain text and links... [18:26:50] (03CR) 10Jforrester: [C: 031] Use ActionFieldLayout in the template placeholder page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186913 (owner: 10Mooeypoo) [18:28:02] (03CR) 10Jforrester: [C: 031] Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [18:31:39] 3VisualEditor: Removing extra blank line removes all blank lines - https://phabricator.wikimedia.org/T88306#1008750 (10Whatamidoing-WMF) 3NEW [18:37:47] RoanKattouw_away: https://gerrit.wikimedia.org/r/#/c/186171/ https://gerrit.wikimedia.org/r/#/c/180228/ https://gerrit.wikimedia.org/r/#/c/187143/ https://gerrit.wikimedia.org/r/#/c/186645/ https://gerrit.wikimedia.org/r/#/c/187321/ https://gerrit.wikimedia.org/r/#/c/172972/ [18:38:35] RoanKattouw_away: Oh, and https://gerrit.wikimedia.org/r/#/c/173360/ [18:41:36] edsanders|away: https://gerrit.wikimedia.org/r/#/c/186548/ https://gerrit.wikimedia.org/r/#/c/187443/ https://gerrit.wikimedia.org/r/#/c/187305/ https://gerrit.wikimedia.org/r/#/c/179002/ https://gerrit.wikimedia.org/r/#/c/185393/ https://gerrit.wikimedia.org/r/#/c/186913/ [18:43:44] (03CR) 10Esanders: "Should be fine, that commit batches info requests, not resize requests, and doesn't touch any of the same files." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [18:44:21] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [18:45:24] [10:44] Krenair [2015-02-02 09:52:48] and then when I got home I found that some private security at SFO had searched my checked bag, damaging the lock on the strap in the process [18:45:26] [10:44] mooeypoo [2015-02-02 09:54:00] but yeah, you are usually advised not to lock your bag pre-TSA, because they most often open them [18:45:35] But hold on, I saw Krenair's bag and it had a TSA lock on it [18:45:45] ... upi [18:45:57] RoanKattouw, You're assuming order in a chaotic system. [18:46:01] The lock has the red and white logo indicating that TSA has a master key for it [18:46:37] This has worked for me; I have a combination lock on my luggage but it can be opened with a key, which (theoretically at least) only TSA has [18:46:50] I believe the key here is "theoretically". [18:47:39] Their key is quantum phased; it both exists and doesn't until they see your bag, in which case it collapses the wave equation to a bolt-cutter. [18:56:21] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/187614/ https://gerrit.wikimedia.org/r/#/c/187954/ https://gerrit.wikimedia.org/r/#/c/187655/ https://gerrit.wikimedia.org/r/#/c/187274/ [18:56:25] (03CR) 10Catrope: "As discussed previously, a regression in load time is to be expected because this moves work that was previously done immediately after lo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186100 (https://phabricator.wikimedia.org/T87161) (owner: 10Catrope) [18:57:08] 3OOjs-UI: Textfield widget uses role=textbox for no reason - https://phabricator.wikimedia.org/T87830#1008908 (10Etonkovidova) Checked in beta: role="textbox" is not present anymore for oo-ui-textInputWidget element. [19:00:23] ori: I'm not sure you're right about the imageinfo api request thing. Those occur after load, don't they? [19:00:53] I could be wrong, worth checking. [19:01:40] I mean yes the fact that there are dozens of them is ridiculous [19:01:41] (03CR) 10Mooeypoo: [C: 032] "WFM" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [19:01:50] and we're fixing that [19:03:23] RoanKattouw: my bad if I incorrectly assumed it blocked load. Would need to check. I also have an additional bit of news that may frustrate you.. [19:03:49] RoanKattouw: namely, see commit message of https://gerrit.wikimedia.org/r/#/c/188023/ [19:04:09] ori: I suspected that might be going on [19:04:21] the upshot is that vbench is quite accurate now [19:04:28] (03Merged) 10jenkins-bot: Only re-render if the images is larger than the last rendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187967 (https://phabricator.wikimedia.org/T88248) (owner: 10Esanders) [19:04:29] 7s of CPU time seemed excessive [19:04:44] yes, it was dumb of me [19:05:19] ori: Also I'm talking to mooeypoo about eliminating those image requests from load altogether [19:05:43] But for that we need to put some of that data in the Parsoid output, which IIRC was agreed would happen like a year ago and then never happened [19:05:44] yeah, did you see my comment on that bug? [19:05:49] Which one? [19:06:06] * ori digs it up [19:06:22] 3VisualEditor: VisualEditor Q3 Release Criteria - https://phabricator.wikimedia.org/T86867#1008925 (10TrevorParscal) [19:06:42] RoanKattouw: https://phabricator.wikimedia.org/T75822#1007435 [19:07:36] is there a bug for adding it to the parsoid output? if so, we can escalate it with them [19:07:44] ('them' being the parsoid team) [19:07:45] Not sure [19:07:50] I'll find out in a minute [19:08:33] So, re your comment, "eliminate" yes, but "critical path" no, it was never in there [19:08:54] the reason i assumed the imageinfo requests were blocking load is that the action=visualeditor&paction=parse request was available in 1-2s in my local testing [19:09:02] and cpu time was another 600ms [19:09:14] so how does load time balloon to 6-7s? [19:09:25] Hmm, right [19:09:31] Maybe we do wait for it? [19:09:37] Now that you say that, I'm not sure [19:09:52] my suspicion is that we do, but i didn't do the legwork to confirm that definitively [19:09:57] OK [19:09:59] Could you do that? [19:10:04] sure [19:10:33] also i want to flag https://phabricator.wikimedia.org/T88259 for your attention -- i think you could probably delegate that one away but you'd know better than me who would be the best person to take that on [19:10:39] RoanKattouw, https://phabricator.wikimedia.org/T75822 [19:10:57] and ori (same link) -- I've commented [19:11:17] I mean I want to eliminate these requests regardless, but the answer to that question dramatically influences its priority and what strategy I want to takee [19:11:29] right [19:11:41] If we can get Parsoid to dump the info in the data, we don't need the API requests at all on load -- only on inserting new images. [19:11:52] If it's not blocking, then it's lower prio and we can do the data-mw thing, that'll take time to propagate in cache but Alex's ImageInfoCache (which I'll merge today) allows us to transition automatically [19:12:39] If it is blocking, I think I'll put the information in the paction=parse response instead. Available immediately and not potentially slowed down by any resistance from the Parsoid team to growing data-mw [19:13:43] ori: The LinkCache smartness bug I'll take on myself [19:14:30] ori: The problem there is that link status is tri-state, "blue", "red" and "I don't know, ask the API" [19:14:38] The third case can occur when serving oldids [19:14:53] right; in that case i think the 'links' key should simply be absent [19:15:01] pcache doesn't have link data for old revisions, so we serve the current version's link data and assume that there will be significant overlap [19:15:02] so we should differentiate between "links": [] and no links property [19:15:25] By which I mean, hope that there will be <=50 links remaining to be looked up so that we only need one request [19:16:56] 3VisualEditor: [Regression wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#1008969 (10Mooeypoo) a:3Mooeypoo This is merged, and seems to be fixed. [19:17:34] oh, i see [19:18:57] 3MediaWiki-Interface, VisualEditor-Performance, Parsoid, RESTBase, Services, MediaWiki-General-or-Unknown, VisualEditor: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#1008976 (10Jdforrester-WMF) [19:19:26] So, I do think we could make the output less verbose by formatting it like 'missing': [ names ], 'existing': [ names ] and transforming that to data[name] = { missing: false/true }; on the client [19:20:35] Also I suppose for current-revision hits we could put in something like 'existing': true indicating that every other link should be assumed to exist [19:21:37] Which would place more trust in ParserOutput than I'm really comfortable with, but it's just for presentation and the data reduction could be substantial [19:21:47] ori: Do you know how much we would save with that kind of strategy on e.g. Obama? [19:22:27] RoanKattouw: I'm still wrestling with figuring out whether imageinfo reqs block or not, because if they block, this could be the single greatest perf fix to VE like, ever [19:22:35] OK [19:22:49] Yeah, by all means go ahead with that, that's higher priority :) [19:22:52] it's a bit weird [19:22:54] https://dpaste.de/s9yz/raw [19:23:08] some requests definitely happen after ve.load [19:23:13] but some before [19:23:15] ori: Would you like help hacking the code so it doesn't issue these requests? [19:23:29] Once I merge Alex's patch in a minute here that would be trivial [19:23:40] yeah, let's apply that on osmium [19:23:49] Even now actually, I think it should be easy, let me look [19:24:17] 3VisualEditor: VisualEditor: Superscript text added by template doesn't have the same style as the surrounding text - https://phabricator.wikimedia.org/T65670#1008986 (10Jdforrester-WMF) 5Open>3stalled [19:24:18] 3VisualEditor: VisualEditor: Unclosed
and
tags caused by absent {{refend}} template cannot be repaired - https://phabricator.wikimedia.org/T62395#1008985 (10Jdforrester-WMF) 5Open>3stalled [19:24:19] 3VisualEditor: Cannot save deletion of {{clarify span}} template - https://phabricator.wikimedia.org/T73701#1008987 (10Jdforrester-WMF) 5Open>3stalled [19:24:20] 3VisualEditor: VisualEditor does not display Files, and can not access the local files - https://phabricator.wikimedia.org/T74760#1008988 (10Jdforrester-WMF) 5Open>3stalled [19:24:23] 3VisualEditor:
added when creating a level 2 heading - https://phabricator.wikimedia.org/T74246#1008990 (10Jdforrester-WMF) 5Open>3stalled [19:24:24] 3VisualEditor: VisualEditor: Cutting (removing) last sections on page, and then pasting them back in, results in increased indentation in Chrome - https://phabricator.wikimedia.org/T61849#1008992 (10Jdforrester-WMF) 5Open>3stalled [19:24:25] 3VisualEditor: Editing parameters of a multiref template within a reference is not recognised as a change to the reference - https://phabricator.wikimedia.org/T73969#1008991 (10Jdforrester-WMF) 5Open>3stalled [19:24:26] 3VisualEditor: VisualEditor: if you need to type, then you need access to the character inserter - https://phabricator.wikimedia.org/T62657#1008994 (10Jdforrester-WMF) 5Open>3stalled [19:24:28] 3VisualEditor: VisualEditor: Give the user a chance to understand if he made a mistake and to fix it - https://phabricator.wikimedia.org/T73422#1008993 (10Jdforrester-WMF) 5Open>3stalled [19:24:29] 3VisualEditor: VisualEditor: Please warn if user adds caption for a pic but then chooses an image type that won't display it? - https://phabricator.wikimedia.org/T72603#1008995 (10Jdforrester-WMF) 5Open>3stalled [19:24:30] 3VisualEditor: VisualEditor: Adding a template to a redirect did not let me save the page - https://phabricator.wikimedia.org/T72305#1008996 (10Jdforrester-WMF) 5Open>3stalled [19:24:31] 3VisualEditor-MediaWiki-Plugins, VisualEditor-EditingTools, VisualEditor: VisualEditor: Support media (tracking) - https://phabricator.wikimedia.org/T39870#1008998 (10Jdforrester-WMF) [19:24:32] 3VisualEditor: VisualEditor: Be able to search for an existing image by name - https://phabricator.wikimedia.org/T72243#1008997 (10Jdforrester-WMF) 5Open>3stalled [19:24:34] 3VisualEditor: Deleting non-contiguous blocks does not work - https://phabricator.wikimedia.org/T71737#1009001 (10Jdforrester-WMF) 5Open>3stalled [19:24:35] 3VisualEditor: VisualEditor: Make interlanguage links visible (e.g., so that you can avoid typing on the same line) - https://phabricator.wikimedia.org/T71822#1009000 (10Jdforrester-WMF) 5Open>3stalled [19:24:36] 3VisualEditor: VisualEditor: After you create a link and close the link inspector, please de-select the newly linked text - https://phabricator.wikimedia.org/T71711#1009002 (10Jdforrester-WMF) 5Open>3stalled [19:24:37] 3VisualEditor: VisualEditor: Hung while trying to save - https://phabricator.wikimedia.org/T72010#1008999 (10Jdforrester-WMF) 5Open>3stalled [19:24:38] 3VisualEditor: VisualEditor: Provide ability to deal easily with dead links - https://phabricator.wikimedia.org/T71547#1009004 (10Jdforrester-WMF) 5Open>3stalled [19:24:40] 3VisualEditor: VisualEditor: Unnecessary s inserted into articles - https://phabricator.wikimedia.org/T71494#1009005 (10Jdforrester-WMF) 5Open>3stalled [19:24:41] 3VisualEditor: VE messes up formatting of graphs in edit box - https://phabricator.wikimedia.org/T71552#1009003 (10Jdforrester-WMF) 5Open>3stalled [19:24:41] I think what might be happening is that they don't technically block, in that the load does not explicitly wait for those requests to finish, but they hog the main thread of execution [19:24:42] 3VisualEditor: Incremental edit summary needed - https://phabricator.wikimedia.org/T71393#1009007 (10Jdforrester-WMF) 5Open>3stalled [19:24:43] 3VisualEditor: Backspace to merge paragraph leads to second paragraph's deletion - https://phabricator.wikimedia.org/T71429#1009006 (10Jdforrester-WMF) 5Open>3stalled [19:24:46] 3VisualEditor: issues with CTRL-K on OSX (at least) - https://phabricator.wikimedia.org/T70181#1009009 (10Jdforrester-WMF) 5Open>3stalled [19:24:47] 3VisualEditor: VisualEditor: Sometimes pasting text into a page results in only part of the text appearing. - https://phabricator.wikimedia.org/T66760#1009011 (10Jdforrester-WMF) 5Open>3stalled [19:24:48] 3VisualEditor: VisualEditor: Easy way to reproduce a weird behavior with the link tool - https://phabricator.wikimedia.org/T70102#1009010 (10Jdforrester-WMF) 5Open>3stalled [19:24:49] 3VisualEditor: VisualEditor: Section headings look like they've been removed, but they're still present when the page is saved - https://phabricator.wikimedia.org/T69061#1009013 (10Jdforrester-WMF) 5Open>3stalled [19:24:51] 3VisualEditor: VisualEditor: Coordinates template is displaying in the wrong place - https://phabricator.wikimedia.org/T67648#1009015 (10Jdforrester-WMF) 5Open>3stalled [19:24:52] 3VisualEditor: Hypothetical generation of strange characters at the beginning of pages - https://phabricator.wikimedia.org/T67674#1009014 (10Jdforrester-WMF) 5Open>3stalled [19:24:53] 3VisualEditor: VisualEditor not opening consistently in Firefox - https://phabricator.wikimedia.org/T67365#1009012 (10Jdforrester-WMF) 5Open>3stalled [19:24:54] 3VisualEditor: VisualEditor: Strip
out of section headings - https://phabricator.wikimedia.org/T68846#1009016 (10Jdforrester-WMF) 5Open>3stalled [19:24:55] RoanKattouw: switching to PM [19:24:55] 3VisualEditor: VisualEditor: If you insert a gallery into a list, the list formatting remains visible but is removed in wikitext - https://phabricator.wikimedia.org/T67022#1009018 (10Jdforrester-WMF) 5Open>3stalled [19:24:57] 3VisualEditor: VisualEditor: Creating a new page shows footer above the article - https://phabricator.wikimedia.org/T68517#1009017 (10Jdforrester-WMF) 5Open>3stalled [19:24:58] 3VisualEditor: VisualEditor: quotation marks added via special characters tool don't work as expected - https://phabricator.wikimedia.org/T65227#1009020 (10Jdforrester-WMF) 5Open>3stalled [19:24:59] 3VisualEditor: VisualEditor: Cutting and pasting an {{essay}} template (containing shortcuts) resulted in a different template displaying - https://phabricator.wikimedia.org/T66514#1009021 (10Jdforrester-WMF) 5Open>3stalled [19:25:01] 3VisualEditor: VisualEditor: Firefox displays new lists incorrectly, if you've just pasted the text onto the page - https://phabricator.wikimedia.org/T67014#1009019 (10Jdforrester-WMF) 5Open>3stalled [19:25:02] 3VisualEditor: VisualEditor: What you put into the template editor is not what it gives back (more Babel box bugs) - https://phabricator.wikimedia.org/T64746#1009024 (10Jdforrester-WMF) 5Open>3stalled [19:25:03] 3VisualEditor: VisualEditor: "Unknown error" corrupts page upon saving, but saving again fixes the problems it created - https://phabricator.wikimedia.org/T66375#1009022 (10Jdforrester-WMF) 5Open>3stalled [19:25:04] 3VisualEditor: VisualEditor cut off last several characters of article text during two edits at pl.wp - https://phabricator.wikimedia.org/T66182#1009023 (10Jdforrester-WMF) 5Open>3stalled [19:25:05] 3VisualEditor: VE shows 'not logged in' msg. for logged-in user: Chrome on 56K connection - https://phabricator.wikimedia.org/T57756#1009027 (10Jdforrester-WMF) 5Open>3stalled [19:25:06] 3VisualEditor: When cutting and pasting list items, it is hard to achieve the intended formatting - https://phabricator.wikimedia.org/T64742#1009025 (10Jdforrester-WMF) 5Open>3stalled [19:25:07] 3VisualEditor: VisualEditor: unintended ref change resulting in a dirty diff - https://phabricator.wikimedia.org/T58520#1009026 (10Jdforrester-WMF) 5Open>3stalled [19:25:09] 3VisualEditor: VisualEditor: trouble with Template:Hlist - https://phabricator.wikimedia.org/T55340#1009028 (10Jdforrester-WMF) 5Open>3stalled [19:25:10] 3VisualEditor: VisualEditor: do not remove line break before first category when a user deletes {{DEFAULTSORT}} - https://phabricator.wikimedia.org/T58530#1009029 (10Jdforrester-WMF) 5Open>3stalled [19:25:11] 3VisualEditor: VisualEditor does not format hatnotes correctly - https://phabricator.wikimedia.org/T62516#1009030 (10Jdforrester-WMF) 5Open>3stalled [19:25:12] 3VisualEditor: VisualEditor: Removing or breaking HTML tags - https://phabricator.wikimedia.org/T62585#1009031 (10Jdforrester-WMF) 5Open>3stalled [19:25:14] 3VisualEditor: VisualEditor: Reference dialog retains style of copy/pasted contents - https://phabricator.wikimedia.org/T60689#1009032 (10Jdforrester-WMF) 5Open>3stalled [19:25:16] 3VisualEditor: Referenced footnote not displayed correctly in VE using Chrome 28 on Win 7 - https://phabricator.wikimedia.org/T54262#1009033 (10Jdforrester-WMF) 5Open>3stalled [19:25:17] 3VisualEditor: VisualEditor: Cutting (removing) last sections on page, and then pasting them back in, results in duplicated section headings - https://phabricator.wikimedia.org/T61847#1009038 (10Jdforrester-WMF) 5Open>3stalled [19:25:20] 3VisualEditor: VisualEditor: Provide a way for the user to view and edit a specific part of source, without switching entirely to wikicode - https://phabricator.wikimedia.org/T63263#1009036 (10Jdforrester-WMF) 5Open>3stalled [19:25:21] 3VisualEditor: VisualEditor: Cursor misplaced while editing. I click here, and it types over there. - https://phabricator.wikimedia.org/T60493#1009037 (10Jdforrester-WMF) 5Open>3stalled [19:25:22] 3VisualEditor: Some navbox and other templates disappear when being moved, but only if tags are present in the article and the templates are below the last visible text - https://phabricator.wikimedia.org/T58923#1009039 (10Jdforrester-WMF) 5Open>3stalled [19:25:23] 3VisualEditor: VisualEditor: Word missing from wikilink - https://phabricator.wikimedia.org/T63550#1009040 (10Jdforrester-WMF) 5Open>3stalled [19:25:25] 3VisualEditor: VisualEditor: Babel box not updated upon editing - https://phabricator.wikimedia.org/T63356#1009041 (10Jdforrester-WMF) 5Open>3stalled [19:25:26] 3VisualEditor: VisualEditor: adding section for references will suppress the Related Articles one - https://phabricator.wikimedia.org/T55699#1009042 (10Jdforrester-WMF) 5Open>3stalled [19:25:27] 3VisualEditor: VisualEditor: Template converted to span tags at Javanese Wikipedia - https://phabricator.wikimedia.org/T64411#1009043 (10Jdforrester-WMF) 5Open>3stalled [19:26:52] 3MediaWiki-Page-editing: Return to page after edit of section when section name occurs multiple times may point to wrong section - https://phabricator.wikimedia.org/T2111#1009044 (10Deskana) [19:27:23] 3MediaWiki-Page-editing: Return to page after edit of section when section name occurs multiple times may point to wrong section - https://phabricator.wikimedia.org/T2111#26424 (10Deskana) "Epic" also doesn't really apply here. It's nontrivial to solve, but it's not really an epic. [19:30:13] (03CR) 10Catrope: [C: 032] Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [19:30:27] RoanKattouw: Thanks. :-) [19:30:53] (03PS3) 10Catrope: Provide Platform#getConfig and shortcut ve#config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187143 (owner: 10Esanders) [19:31:53] (03CR) 10Catrope: [C: 032] Provide Platform#getConfig and shortcut ve#config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187143 (owner: 10Esanders) [19:32:02] (03Merged) 10jenkins-bot: Combine imageinfo requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/180228 (https://phabricator.wikimedia.org/T75822) (owner: 10Alex Monk) [19:32:48] (03PS5) 10Mooeypoo: Use the new image cache in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187847 (https://phabricator.wikimedia.org/T88187) [19:34:18] (03CR) 10Catrope: [C: 032] "Please submit a change to VE-MW to remove manual calls this is replacing" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186645 (owner: 10Esanders) [19:34:30] (03CR) 10jenkins-bot: [V: 04-1] Use the new image cache in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187847 (https://phabricator.wikimedia.org/T88187) (owner: 10Mooeypoo) [19:36:16] (03CR) 10Catrope: Handle showHandles smartness in AlignableNode (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [19:36:21] (03CR) 10Catrope: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [19:37:06] (03CR) 10jenkins-bot: [V: 04-1] Provide Platform#getConfig and shortcut ve#config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187143 (owner: 10Esanders) [19:37:07] RoanKattouw: edsanders: please come to R35 [19:37:49] (03CR) 10Catrope: [C: 032] Use the new image cache in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187847 (https://phabricator.wikimedia.org/T88187) (owner: 10Mooeypoo) [19:39:58] (03Merged) 10jenkins-bot: Use the new image cache in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187847 (https://phabricator.wikimedia.org/T88187) (owner: 10Mooeypoo) [19:41:10] (03CR) 10jenkins-bot: [V: 04-1] Update scalable and view on direct attribute change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186645 (owner: 10Esanders) [19:41:29] (03CR) 10Catrope: [C: 032] Provide Platform#getConfig and shortcut ve#config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187143 (owner: 10Esanders) [19:45:10] (03Merged) 10jenkins-bot: Provide Platform#getConfig and shortcut ve#config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187143 (owner: 10Esanders) [19:46:59] RoanKattouw: something very terrible is going on [19:47:30] 3Editing, VisualEditor, MediaWiki-Developer-Summit-2015: "Future of Editing" session at 2015 MediaWiki Developer Summit - https://phabricator.wikimedia.org/T85152#1009140 (10Jdforrester-WMF) [19:53:09] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: In Betalabs,Media search is extremely slow, some images are not appearing and the progress bar keeps on moving infinitely - https://phabricator.wikimedia.org/T71018#1009171 (10Jdforrester-WMF) [19:53:31] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: [Regression] Firefox displaying icons in odd places in dialog boxes (reference, media, template, …) - https://phabricator.wikimedia.org/T65127#1009175 (10Jdforrester-WMF) [19:53:49] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Deletion of slugs causes significant confusion (and shouldn't be possible?) - https://phabricator.wikimedia.org/T45026#1009177 (10Jdforrester-WMF) [19:54:19] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Vertical keyboard selection (shift+up/down cursor) over a node type boundary gives unexpected results in Firefox - https://phabricator.wikimedia.org/T58248#1009179 (10Jdforrester-WMF) [19:59:10] 3VisualEditor-DataModel, VisualEditor: VisualEditor: Whitespace corruption, HTML-like entities removed, and apparent DSR issues - https://phabricator.wikimedia.org/T53304#1009205 (10Jdforrester-WMF) [19:59:21] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Pawn ♙ appears after deleting the text preceding and following a link by "undo" action - https://phabricator.wikimedia.org/T63521#1009207 (10Jdforrester-WMF) [19:59:30] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: White pawn "♙" appears on Alt+Shift+F in Firefox - https://phabricator.wikimedia.org/T71810#1009209 (10Jdforrester-WMF) [20:03:07] 3MediaWiki-Core-Team, VisualEditor-MediaWiki, MediaWiki-Configuration, VisualEditor: convertExtensionToRegistration.php does not set defaults for globals, so $wgResourceModules += array(...) and similar cause fatals - https://phabricator.wikimedia.org/T86311#1009247 (10Jdforrester-WMF) [20:03:52] (03CR) 10Catrope: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [20:05:12] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#849811 (10Jdforrester-WMF) [20:22:39] 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009312 (10KHammerstein) 3NEW [20:29:58] 3VisualEditor-MediaWiki-Links, VisualEditor: Change the link inspector menu widget to show information about the target in a bigger format - https://phabricator.wikimedia.org/T76399#1009323 (10KHammerstein) [20:30:00] 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009324 (10KHammerstein) [20:33:54] 3VisualEditor, VisualEditor-Tables: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1009345 (10Martijn_Hoekstra) 3NEW [20:44:45] 3Parsoid, VisualEditor, VisualEditor-Tables: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1009369 (10matmarex) [20:56:45] (03PS4) 10Cmcmahon: [BrowserTest] Add basic test for table creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova) [21:01:24] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Add basic test for table creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova) [21:05:09] 3OOjs-UI: MediaWiki theme: Regular and disabled buttons have different height - https://phabricator.wikimedia.org/T87126#1009428 (10Etonkovidova) Checked in beta, e.g. .oo-ui-buttonElement-framed.oo-ui-widget-disabled > .oo-ui-buttonElement-button { color: #FFF; background: none repeat scroll 0% 0% #EE... [21:15:07] would it be possible to disable the qunit-karma tests? they are simply timing out for no reason: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit-karma/57/console [21:16:03] I would ask Timo about that [21:16:26] I probably already did [21:19:07] 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009456 (10KHammerstein) [21:19:28] chrismcmahon: We're already on it. [21:19:32] 3VisualEditor: [Regression wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#1009458 (10Ryasmeen) 5Open>3Resolved [21:19:38] chrismcmahon: https://gerrit.wikimedia.org/r/188024 [21:19:43] thanks James_F [21:20:13] 3VisualEditor: [Regression pre-wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#1009460 (10Jdforrester-WMF) [21:20:25] 3VisualEditor: [Regression pre-wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#998887 (10Jdforrester-WMF) [21:25:22] 3VisualEditor-MediaWiki-Links, VisualEditor: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1009480 (10KHammerstein) [21:29:02] 3VisualEditor-MediaWiki-Links, VisualEditor: External link interface for link dialogue - https://phabricator.wikimedia.org/T76398#1009532 (10KHammerstein) [21:30:28] 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009546 (10KHammerstein) [21:30:37] TrevorParscal, can you review this? should be relatively straight forward https://gerrit.wikimedia.org/r/#/c/186913/ [21:31:02] 3VisualEditor-MediaWiki-Links, VisualEditor: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#799557 (10KHammerstein) [21:31:15] 3VisualEditor-MediaWiki-Links, VisualEditor: External link interface for link dialogue - https://phabricator.wikimedia.org/T76398#1009550 (10KHammerstein) [21:32:07] 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009558 (10Esanders) Why is there a spinner? Link application is instant. [21:33:23] ori, had any more thoughts about the statsd thing? [21:34:50] 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009569 (10Jdforrester-WMF) p:5Triage>3High [21:36:08] 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009581 (10KHammerstein) True, and we still want it to feel fast. But when we first tested the prototype, users were surprised by the instant result. Some people said "Did someone else already link this?" Because we're... [21:40:25] James_F: https://www.mediawiki.org/wiki/Thread:Extension_talk:VisualEditor/Error:_Unknown_dependency:_schema.Edit [21:46:25] 3MediaWiki-ResourceLoader: Using addModuleStyles() and then addModules() for one module on one page duplicates the styles - https://phabricator.wikimedia.org/T87871#1009627 (10Aklapper) p:5Triage>3Low [21:47:06] (03CR) 10Esanders: "Not blocked, required to fix breaking change. Please review promptly." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [21:47:10] (03PS5) 10Esanders: Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 [21:49:58] (03CR) 10Jforrester: [C: 032] Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [21:53:56] (03CR) 10jenkins-bot: [V: 04-1] Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [21:54:11] 3MediaWiki-ResourceLoader: Using addModuleStyles() and then addModules() for one module on one page duplicates the styles - https://phabricator.wikimedia.org/T87871#1009639 (10Krinkle) a:3TrevorParscal [21:54:19] TrevorParscal: ^ [21:57:40] (03CR) 10Jforrester: "Ping?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) (owner: 10Alex Monk) [21:58:28] RoanKattouw_away: _joe_ installed a borked version of the hhvm package on osmium; fixing that now, which should resolve any luasandbox issues [21:58:33] 3VisualEditor-EditingTools, VisualEditor: Tools should be able to specify a label for their appearance in the context menu. - https://phabricator.wikimedia.org/T88337#1009650 (10Jdforrester-WMF) 3NEW a:3TrevorParscal [21:58:53] 3VisualEditor-MediaWiki-Media, VisualEditor: Debounce key presses in media search - https://phabricator.wikimedia.org/T88188#1009661 (10Jdforrester-WMF) p:5Triage>3Normal [21:59:10] What are story points? [21:59:23] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (https://phabricator.wikimedia.org/T76926) (owner: 10Alex Monk) [21:59:33] mvolz: Indeed. :-) [22:00:08] if that was covered in a meeting my excuse is that BT hates me. [22:00:18] mvolz: Mostly, a quick way to gauge how hard a task is; we're using 1 (an hour or two), 10 (a day or two), 100 (a week or two), or 1000 (a month or two). [22:00:41] (phone line has a physical fault and internet has been dead all day. They swear an engineer is coming by thurs) [22:00:44] mvolz: It's not particularly binding, just to give management a sense of scale. [22:00:47] okay [22:00:49] * James_F nods. [22:00:52] Sounds like BT. :-) [22:01:04] James_F: most folks label those as Fibonaccis, 1,3, 5,8 [22:01:42] (03CR) 10Alex Monk: "I think I was waiting for Trevor or Roan or someone else to look at the general idea and font size issues I ran into." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) (owner: 10Alex Monk) [22:01:45] that's silly. we should take a logarithm of these values, or something. [22:01:54] /bikeshed [22:01:55] chrismcmahon: Yes, which is ludicrous for Hard Problems which can't be split down, like many of our issues. [22:02:01] MatmaRex: Meh. [22:02:12] James_F: a useful measure I picked up at another job was 1 point = about a half day. [22:02:33] chrismcmahon: Several of our tasks take much less than that. [22:03:07] James_F: experience says that it's rare to be able to do more than 2 points per day because meetings, email, etc. [22:03:16] 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009669 (10TrevorParscal) Both James and I have talked through this with design before, and the approach we are going with is to show a notification in the link inspector that the link has been created successfully. Sho... [22:03:20] 3VisualEditor-MediaWiki-Media, VisualEditor, VisualEditor-Performance: Populate ImageInfoCache from MWMediaDialog - https://phabricator.wikimedia.org/T88187#1009670 (10Jdforrester-WMF) 5Open>3Resolved [22:03:46] 3VisualEditor-MediaWiki-Media, VisualEditor, VisualEditor-Performance: Don't request image resizes from the API if we already have a larger image in the cache - https://phabricator.wikimedia.org/T88248#1009672 (10Jdforrester-WMF) 5Open>3Resolved [22:03:57] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#1009676 (10Jdforrester-WMF) [22:04:58] (03PS1) 10Mooeypoo: Increase user-input delay in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188205 (https://phabricator.wikimedia.org/T88188) [22:06:42] (03CR) 10Jforrester: [C: 031] Increase user-input delay in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188205 (https://phabricator.wikimedia.org/T88188) (owner: 10Mooeypoo) [22:06:49] (03PS5) 10Cmcmahon: [BrowserTest] Add basic test for table creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova) [22:07:49] (03PS1) 10Jforrester: Update VE core submodule to master (8218942) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188207 [22:08:44] (03PS6) 10Cmcmahon: [BrowserTest] Add basic test for table creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova) [22:09:14] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (8218942) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188207 (owner: 10Jforrester) [22:10:12] (03PS2) 10Jforrester: Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [22:12:38] (03CR) 10jenkins-bot: [V: 04-1] Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [22:14:44] (03PS2) 10Jforrester: Update VE core submodule to master (8218942) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188207 [22:15:21] (03PS7) 10Cmcmahon: [BrowserTest] Add basic test for table creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova) [22:15:46] (03PS3) 10Jforrester: Hide extra space at the top of the single transclusion dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179551 (https://phabricator.wikimedia.org/T78045) (owner: 10Alex Monk) [22:15:57] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/179551/ in your list? [22:16:19] what list? [22:16:22] of things I'm reviewing? [22:16:24] TrevorParscal: Yeah. [22:16:26] it is now [22:16:29] Cool. [22:16:35] * James_F cracks the whip. [22:16:58] (03PS3) 10Jforrester: Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [22:17:05] (03PS1) 10Mooeypoo: Do not send search query on whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188213 [22:17:47] (03CR) 10Jforrester: [C: 031] Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [22:18:29] (03CR) 10jenkins-bot: [V: 04-1] Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [22:18:55] (03CR) 10Cmcmahon: [C: 032] "paired with Rummana" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova) [22:19:11] (03CR) 10jenkins-bot: [V: 04-1] Do not send search query on whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188213 (owner: 10Mooeypoo) [22:20:44] (03PS2) 10Mooeypoo: Do not send search query on whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188213 [22:21:17] (03CR) 10Jforrester: [C: 04-1] "Needs rebase" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [22:23:32] 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009766 (10KHammerstein) Could you provide an example or explain notification further? [22:30:46] (03PS2) 10Jforrester: build: Bump devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187841 [22:32:08] (03CR) 10Jforrester: "PS2 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187841 (owner: 10Jforrester) [22:32:46] mooeypoo: https://gerrit.wikimedia.org/r/#/c/187841/ [22:33:01] mooeypoo: https://gerrit.wikimedia.org/r/#/c/188207/ [22:34:34] (03CR) 10Mooeypoo: [C: 032] "Code looks much prettier now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187841 (owner: 10Jforrester) [22:34:39] 3VisualEditor-MediaWiki-Media, VisualEditor: Add an explanation about Alternative text in the media adding dialog - https://phabricator.wikimedia.org/T75731#1009829 (10Etonkovidova) Checked in betalabs. [22:34:59] (03PS2) 10Jforrester: test: Rebuild .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 [22:36:13] (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (8218942) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188207 (owner: 10Jforrester) [22:37:40] 3VisualEditor: Experimental: "pharsoid" minimal PHP implementation of Parsoid for VE - https://phabricator.wikimedia.org/T88347#1009846 (10brion) 3NEW a:3brion [22:37:59] 3Beta-Cluster, VisualEditor: Searching for images in VisualEditor with Firefox is painfully slow in Beta Cluster - https://phabricator.wikimedia.org/T87676#1009854 (10Cmcmahon) [22:39:06] (03Merged) 10jenkins-bot: [BrowserTest] Add basic test for table creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187166 (owner: 10Etonkovidova) [22:39:39] 3VisualEditor: Experimental: "pharsoid" minimal PHP implementation of Parsoid for VE - https://phabricator.wikimedia.org/T88347#1009866 (10Jdforrester-WMF) Oh, my eyes. Can we come up with a less-insane name? :-) [22:41:38] 3VisualEditor: Experimental: "parselet" minimal PHP implementation of Parsoid for VE - https://phabricator.wikimedia.org/T88347#1009874 (10brion) [22:41:50] 3VisualEditor: Experimental: "parselet" minimal PHP implementation of Parsoid for VE - https://phabricator.wikimedia.org/T88347#1009846 (10brion) How's "Parselet"? :) [22:41:52] 3VisualEditor: Resize a browser window with open Media settings dialog - highlighted area for an image will be off - https://phabricator.wikimedia.org/T88349#1009877 (10Etonkovidova) 3NEW [22:41:52] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [22:42:24] 3VisualEditor: Experimental: "parselet" minimal PHP implementation of Parsoid for VE - https://phabricator.wikimedia.org/T88347#1009884 (10Jdforrester-WMF) I don't actually care, but "Parselet" is cute. :-) [22:43:23] (03Merged) 10jenkins-bot: build: Bump devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187841 (owner: 10Jforrester) [22:43:26] (03Merged) 10jenkins-bot: Update VE core submodule to master (8218942) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188207 (owner: 10Jforrester) [22:43:44] 3VisualEditor: Experimental: "parselet" minimal PHP implementation of Parsoid for VE - https://phabricator.wikimedia.org/T88347#1009902 (10GWicke) @brion, afaik @tstarling already tried to port the serializer. [22:46:01] 3VisualEditor: Resize a browser window with open Media settings dialog - highlighted area for an image will be off - https://phabricator.wikimedia.org/T88349#1009907 (10Etonkovidova) The highlighted area has a noticeable delay when a browser window is resized. [22:48:20] 3Beta-Cluster, VisualEditor: Searching for images in VisualEditor with Firefox is painfully slow in Beta Cluster - https://phabricator.wikimedia.org/T87676#1009916 (10greg) >>! In T87676#1009837, @Cmcmahon wrote: > so searching media files always has been and always will be slow. (Until we setup a swift machin... [22:50:21] 3VisualEditor: VisualEditor mode for storing HTML content model directly (without Parsoid) - https://phabricator.wikimedia.org/T88353#1009930 (10brion) 3NEW [22:51:01] 3VisualEditor: Experimental: "parselet" minimal PHP implementation of Parsoid for VE - https://phabricator.wikimedia.org/T88347#1009846 (10brion) @gwicke -- I actually don't want to make a port, but a simplified markup that would explicitly break some source compat. (If that ends up being too weird then I'll aim... [22:51:02] (03CR) 10Cmcmahon: [C: 032] "Add a test not bound by performance of the Search back end." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 (owner: 10Ryasmeen) [22:51:20] (03CR) 10Cmcmahon: "Paired with Chris and Rummana" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 (owner: 10Ryasmeen) [22:53:49] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [22:54:58] 3Parsoid, VisualEditor, VisualEditor-Tables: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1009949 (10ssastry) Can you provide an example where this happens? A test page or a diff? https://en.wikipedia.org/w/index.php?title=User%3ASSastry_%28WMF%29%2F... [23:04:49] (03CR) 10jenkins-bot: [V: 04-1] Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [23:07:07] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Updating test for Media Settings interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 (owner: 10Ryasmeen) [23:13:30] 3Beta-Cluster, VisualEditor: Searching for images in VisualEditor with Firefox is painfully slow in Beta Cluster - https://phabricator.wikimedia.org/T87676#1010002 (10Cmcmahon) >>! In T87676#1009916, @greg wrote: >>>! In T87676#1009837, @Cmcmahon wrote: >> so searching media files always has been and always will... [23:14:51] 3Beta-Cluster, VisualEditor: Searching for images in VisualEditor with Firefox is painfully slow in Beta Cluster - https://phabricator.wikimedia.org/T87676#1010004 (10Jdforrester-WMF) >>! In T87676#1010002, @Cmcmahon wrote: > True, but I am still concerned (albeit in a hand-wavy non-specific way) about non-Wikip... [23:15:35] 3Beta-Cluster, VisualEditor: Searching for images in VisualEditor with Firefox is painfully slow in Beta Cluster - https://phabricator.wikimedia.org/T87676#1010005 (10Jdforrester-WMF) The timeout is 100s, and according to @Mooeypoo hasn't changed in the past year or so. The new interface uses roughly the same AP... [23:29:11] James_F: It's caused by one of our packages (grunt-css-url-embed) using a "^" style range version ("mmmagic": "^0.3.8"), and mmagic released a new version that is no longer compatibel with npm 1.x [23:29:14] (03CR) 10Trevor Parscal: [C: 032] Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo) [23:29:28] Krinkle: Eurgh. [23:29:31] and so it auto-upgraded downstream to mmagic 0.3.20 [23:29:35] Krinkle: That's… exceptionally unhelpful. [23:29:41] (03CR) 10Trevor Parscal: [C: 032] TextInputWidget: Mostly revert "Don't try adjusting size when detached" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187954 (https://phabricator.wikimedia.org/T88212) (owner: 10Bartosz Dziewoński) [23:29:52] Krinkle: Should we fork grunt-css-url-embed? [23:30:23] (03CR) 10Ryasmeen: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 (owner: 10Ryasmeen) [23:30:37] (03Merged) 10jenkins-bot: Use css class instead of jQuery .show()/hide()/toggle() [oojs/ui] - 10https://gerrit.wikimedia.org/r/187614 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo) [23:30:39] (03CR) 10Trevor Parscal: [C: 04-1] SelectWidget: listbox wrapper role, state on contents (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [23:30:54] (03Merged) 10jenkins-bot: TextInputWidget: Mostly revert "Don't try adjusting size when detached" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187954 (https://phabricator.wikimedia.org/T88212) (owner: 10Bartosz Dziewoński) [23:31:02] Krinkle: Or, at least, file an issue? [23:31:13] https://github.com/mihhail-lapushkin/grunt-css-url-embed/issues [23:38:00] (03CR) 10Trevor Parscal: [C: 032] Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [23:38:02] (03CR) 10jenkins-bot: [V: 04-1] Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [23:39:08] (03CR) 10Trevor Parscal: [C: 032] Use standard border colours for progress bars [oojs/ui] - 10https://gerrit.wikimedia.org/r/187864 (owner: 10Esanders) [23:39:46] (03CR) 10jenkins-bot: [V: 04-1] Use standard border colours for progress bars [oojs/ui] - 10https://gerrit.wikimedia.org/r/187864 (owner: 10Esanders) [23:41:11] (03PS4) 10Trevor Parscal: TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [23:41:39] (03CR) 10Trevor Parscal: [C: 031] TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [23:42:31] (03PS1) 10Esanders: Fix initialisation of window visible [oojs/ui] - 10https://gerrit.wikimedia.org/r/188237 [23:43:26] 3VisualEditor-EditingTools, VisualEditor: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1010087 (10Jdforrester-WMF) [23:43:29] 3OOjs-UI: TextInputWidget autosizing no longer works on Firefox - https://phabricator.wikimedia.org/T88212#1010084 (10Jdforrester-WMF) 5Open>3Resolved [23:45:10] (03CR) 10Trevor Parscal: [C: 032] Do not send search query on whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188213 (owner: 10Mooeypoo) [23:45:37] (03CR) 10Trevor Parscal: [C: 032] Increase user-input delay in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188205 (https://phabricator.wikimedia.org/T88188) (owner: 10Mooeypoo) [23:46:22] 3VisualEditor-MediaWiki-Media, VisualEditor: Debounce key presses more aggressively in media search - https://phabricator.wikimedia.org/T88188#1010094 (10Jdforrester-WMF) 5Open>3Resolved [23:46:32] (03CR) 10Trevor Parscal: [C: 032] Use ActionFieldLayout in the template placeholder page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186913 (owner: 10Mooeypoo) [23:46:39] 3VisualEditor-MediaWiki, Math, VisualEditor: Math's VisualEditor editor renders incorrect highlights on Math tag in MathJax mode in Chrome/Safari - https://phabricator.wikimedia.org/T87007#1010097 (10Jdforrester-WMF) 5Open>3Resolved [23:46:55] (03Merged) 10jenkins-bot: Do not send search query on whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188213 (owner: 10Mooeypoo) [23:47:23] (03Merged) 10jenkins-bot: Increase user-input delay in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188205 (https://phabricator.wikimedia.org/T88188) (owner: 10Mooeypoo) [23:47:42] (03CR) 10Trevor Parscal: [C: 032] Use css class rather than jQuery show/hide [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 (owner: 10Mooeypoo) [23:48:23] (03CR) 10Jforrester: [C: 04-2] "For wmf17." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 (owner: 10Mooeypoo) [23:48:25] (03CR) 10Trevor Parscal: [C: 031] Use css class rather than jQuery show/hide [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 (owner: 10Mooeypoo) [23:48:29] (03Merged) 10jenkins-bot: Use ActionFieldLayout in the template placeholder page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186913 (owner: 10Mooeypoo) [23:48:37] James_F: Some of our jobs are now sticked to int-slave1006 [23:48:51] which is just took offline for npm purging (again) and upgrading to npm 2.x, which is actually quite trivial as it turns out. [23:48:54] (03CR) 10Jforrester: [C: 04-2] "Waiting for wmf17." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187634 (owner: 10Mooeypoo) [23:49:01] (03CR) 10Jforrester: [C: 04-2] "Waiting for wmf17." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo) [23:49:03] that was 10 minutes ago. Now back online and seeing how it runs [23:49:11] https://integration.wikimedia.org/ci/computer/integration-slave1006/ [23:49:16] Krinkle: Thanks. [23:53:14] (03CR) 10jenkins-bot: [V: 04-1] Fix initialisation of window visible [oojs/ui] - 10https://gerrit.wikimedia.org/r/188237 (owner: 10Esanders) [23:54:15] (03CR) 10jenkins-bot: [V: 04-1] TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [23:56:24] (03CR) 10jenkins-bot: [V: 04-1] Use css class rather than jQuery show/hide [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 (owner: 10Mooeypoo) [23:57:26] Krenair: Feel like V+2ing a patch? :-) https://gerrit.wikimedia.org/r/#/c/188022/ [23:57:43] (03PS1) 10Krinkle: build: Use karma to v0.12.31 [oojs/core] - 10https://gerrit.wikimedia.org/r/188245 [23:57:45] (03PS1) 10Krinkle: build: Use karma to v0.12.31 [oojs/ui] - 10https://gerrit.wikimedia.org/r/188246 [23:58:21] (03CR) 10Jforrester: [C: 032] build: Use karma to v0.12.31 [oojs/core] - 10https://gerrit.wikimedia.org/r/188245 (owner: 10Krinkle) [23:58:33] (03CR) 10Jforrester: [C: 032] build: Use karma to v0.12.31 [oojs/ui] - 10https://gerrit.wikimedia.org/r/188246 (owner: 10Krinkle) [23:58:55] James_F: it probably won't merge due to the bug i filed the other day, though? [23:59:37] hm [23:59:40] MatmaRex: If you C2V2 the /vendor patch, the /core patch will merge fine under CI. It's just a CI race condition, not fatal. [23:59:50] yes