[00:00:35] MatmaRex: And it's a CI race condition we were already fixing before your drive-by merge. :-) [00:00:36] (03Merged) 10jenkins-bot: build: Use karma to v0.12.31 [oojs/core] - 10https://gerrit.wikimedia.org/r/188245 (owner: 10Krinkle) [00:01:42] James_F: clearly you need more communication because i had no idea about that. ;) [00:01:59] MatmaRex: Because it was agreed verbally on Friday. :-P [00:02:34] (03CR) 10jenkins-bot: [V: 04-1] build: Use karma to v0.12.31 [oojs/ui] - 10https://gerrit.wikimedia.org/r/188246 (owner: 10Krinkle) [00:02:48] Krinkle: ^^ Eurgh. [00:02:52] (03PS1) 10Krinkle: Add latest buildloader files (dirty grunt build) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188249 [00:02:52] Yeah yeah [00:02:54] (03PS1) 10Krinkle: build: Use karma to v0.12.31 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188250 [00:02:58] It's gonna be a messy mess [00:03:05] updating cache constantly [00:03:08] it's such a mess [00:05:49] (03PS2) 10Jforrester: Follow-up 8218942cb: Fix buildloader files (i18n-bot dirty grunt build) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188249 (owner: 10Krinkle) [00:05:55] (03CR) 10Jforrester: [C: 032] Follow-up 8218942cb: Fix buildloader files (i18n-bot dirty grunt build) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188249 (owner: 10Krinkle) [00:06:38] oh, MatmaRex merged them [00:06:38] ok [00:06:53] (03CR) 10Jforrester: "Broke the repo. Fixed in I178a982." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188197 (owner: 10L10n-bot) [00:07:10] Krenair: Thanks anyway. [00:08:23] (03PS2) 10Jforrester: build: Use karma to v0.12.31 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188250 (owner: 10Krinkle) [00:08:29] (03CR) 10Jforrester: [C: 032] build: Use karma to v0.12.31 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188250 (owner: 10Krinkle) [00:17:19] (03PS1) 10Esanders: Fade in window frames separately from window overlays [oojs/ui] - 10https://gerrit.wikimedia.org/r/188256 [00:17:33] James_F|Away: https://github.com/mscdex/mmmagic/issues/39 [00:20:55] (03CR) 10jenkins-bot: [V: 04-1] Follow-up 8218942cb: Fix buildloader files (i18n-bot dirty grunt build) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188249 (owner: 10Krinkle) [00:23:17] (03PS10) 10Catrope: Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester) [00:23:41] (03CR) 10jenkins-bot: [V: 04-1] build: Use karma to v0.12.31 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188250 (owner: 10Krinkle) [00:24:29] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester) [00:31:10] (03PS11) 10Legoktm: Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester) [00:34:33] (03CR) 10Jforrester: [C: 032] Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester) [00:36:54] 3VisualEditor-MediaWiki, VisualEditor: Convert VisualEditor to use extension registration - https://phabricator.wikimedia.org/T87992#1010287 (10Jdforrester-WMF) 5Open>3Resolved [00:37:51] (03Merged) 10jenkins-bot: Add extension.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183524 (https://phabricator.wikimedia.org/T87992) (owner: 10Jforrester) [00:41:28] (03CR) 10Jforrester: [C: 032] Follow-up 8218942cb: Fix buildloader files (i18n-bot dirty grunt build) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188249 (owner: 10Krinkle) [00:42:07] (03CR) 10Jforrester: [C: 032] Follow-up 8218942cb: Fix buildloader files (i18n-bot dirty grunt build) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188249 (owner: 10Krinkle) [00:43:30] (03CR) 10Trevor Parscal: [C: 032] Hide extra space at the top of the single transclusion dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179551 (https://phabricator.wikimedia.org/T78045) (owner: 10Alex Monk) [00:43:37] (03CR) 10jenkins-bot: [V: 04-1] Hide extra space at the top of the single transclusion dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179551 (https://phabricator.wikimedia.org/T78045) (owner: 10Alex Monk) [00:48:49] James_F: I'm taking integratin-slave1006 down again [00:49:22] I tried doing things live, but it's too slippery. My commands keep getting undone by random jobs firing [00:49:55] gotta type faster [00:50:17] (03PS4) 10Jforrester: Hide extra space at the top of the single transclusion dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179551 (https://phabricator.wikimedia.org/T78045) (owner: 10Alex Monk) [00:50:23] Krinkle: Fun. [00:50:41] (03CR) 10Jforrester: [C: 032] "PS4 is a manual rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179551 (https://phabricator.wikimedia.org/T78045) (owner: 10Alex Monk) [00:52:24] (03Merged) 10jenkins-bot: Hide extra space at the top of the single transclusion dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179551 (https://phabricator.wikimedia.org/T78045) (owner: 10Alex Monk) [00:53:18] (03CR) 10Jforrester: [C: 032] Use ActionFieldLayout for language and auto-choose new lang on add [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/187459 (owner: 10Mooeypoo) [00:53:27] 3VisualEditor: Link format gets applied to text typed on the same line(link continuation) - https://phabricator.wikimedia.org/T88382#1010344 (10Etonkovidova) 3NEW [00:54:10] (03CR) 10jenkins-bot: [V: 04-1] Follow-up 8218942cb: Fix buildloader files (i18n-bot dirty grunt build) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188249 (owner: 10Krinkle) [00:54:12] (03CR) 10jenkins-bot: [V: 04-1] build: Use karma to v0.12.31 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188250 (owner: 10Krinkle) [00:54:18] (03Merged) 10jenkins-bot: Use ActionFieldLayout for language and auto-choose new lang on add [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/187459 (owner: 10Mooeypoo) [00:56:03] (03PS4) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) [00:57:12] (03CR) 10Krinkle: [C: 032 V: 032] Follow-up 8218942cb: Fix buildloader files (i18n-bot dirty grunt build) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188249 (owner: 10Krinkle) [00:57:47] (03CR) 10jenkins-bot: [V: 04-1] Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [00:58:24] ori: FYI https://phabricator.wikimedia.org/T88383 [00:59:36] (03PS5) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) [00:59:50] (03PS2) 10Krinkle: build: Use karma to v0.12.31 [oojs/ui] - 10https://gerrit.wikimedia.org/r/188246 [01:00:46] (03CR) 10Jforrester: [C: 032] build: Use karma to v0.12.31 [oojs/ui] - 10https://gerrit.wikimedia.org/r/188246 (owner: 10Krinkle) [01:00:48] (03PS3) 10Mooeypoo: WIP: Extend nextCursorOffset to work for non-sibling offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187633 (owner: 10Divec) [01:01:53] (03CR) 10jenkins-bot: [V: 04-1] build: Use karma to v0.12.31 [oojs/ui] - 10https://gerrit.wikimedia.org/r/188246 (owner: 10Krinkle) [01:04:22] (03PS2) 10Catrope: Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [01:06:59] 3VisualEditor, VisualEditor-Performance: LinkCache should be smarter - https://phabricator.wikimedia.org/T88259#1010375 (10Catrope) Counter-proposal: for current revisions, let's enumerate only the red links and assume all other links are blue. This places slightly more trust in Parsoid and ParserOutput agreeing... [01:10:12] RoanKattouw: Hey. In ve.ce.MWImageNode.render method shouldn't ve.resolveUrl be used? [01:13:09] InezK: That shouldn't be necessary, see ve.ce.GeneratedContentNode#getRenderedContents [01:13:19] // Render the computed values of some attributes [01:13:21] for ( i = 0, len = ve.dm.Converter.computedAttributes.length; i < len; i++ ) { [01:13:40] (03CR) 10jenkins-bot: [V: 04-1] WIP: Extend nextCursorOffset to work for non-sibling offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187633 (owner: 10Divec) [01:19:05] (03Merged) 10jenkins-bot: build: Use karma to v0.12.31 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188250 (owner: 10Krinkle) [01:20:41] (03CR) 10jenkins-bot: [V: 04-1] Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [01:23:29] (03CR) 10Divec: "Following discussions with Moriel, it looks like the alien cursoring issues are fixed by https://gerrit.wikimedia.org/r/187889/ , which is" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [01:23:43] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor mode for storing HTML content model directly (without Parsoid) - https://phabricator.wikimedia.org/T88353#1010384 (10Jdforrester-WMF) p:5Triage>3Normal [01:26:17] (03CR) 10Divec: "With https://gerrit.wikimedia.org/r/177946, the cursor gets completely stuck when cursoring over an inline alien. This patch fixes that, s" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187889 (owner: 10Divec) [01:26:56] 3OOjs-UI: Continuous BookletLayout widgets should update the selected OutlineWidget while scrolling - https://phabricator.wikimedia.org/T88385#1010387 (10Esanders) 3NEW [01:32:03] (03CR) 10Krinkle: [C: 032] build: Use karma to v0.12.31 [oojs/ui] - 10https://gerrit.wikimedia.org/r/188246 (owner: 10Krinkle) [01:34:44] (03Merged) 10jenkins-bot: build: Use karma to v0.12.31 [oojs/ui] - 10https://gerrit.wikimedia.org/r/188246 (owner: 10Krinkle) [01:34:57] (03PS2) 10Jforrester: Use standard border colours for progress bars [oojs/ui] - 10https://gerrit.wikimedia.org/r/187864 (owner: 10Esanders) [01:36:55] (03PS5) 10Jforrester: Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:37:45] (03CR) 10Jforrester: "PS5 is a manual rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:42:23] (03CR) 10Jforrester: [C: 032] "Per Trevor." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:42:31] (03CR) 10Jforrester: [C: 032] "Per Trevor." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187864 (owner: 10Esanders) [01:43:59] 3VisualEditor, VisualEditor-Performance: ~50ms spent a.oo-ui-buttonElement-button - https://phabricator.wikimedia.org/T88386#1010399 (10ori) 3NEW [01:45:23] (03Merged) 10jenkins-bot: Remove disabled elements from keyboard navigation flow [oojs/ui] - 10https://gerrit.wikimedia.org/r/187274 (https://phabricator.wikimedia.org/T87690) (owner: 10TheDJ) [01:45:40] 3VisualEditor, VisualEditor-Performance: Lots of time spent animating CSS properties of slugs - https://phabricator.wikimedia.org/T88387#1010408 (10ori) 3NEW [01:48:10] (03Merged) 10jenkins-bot: Use standard border colours for progress bars [oojs/ui] - 10https://gerrit.wikimedia.org/r/187864 (owner: 10Esanders) [01:50:58] 3OOjs-UI: Continuous BookletLayout widgets should update the selected OutlineWidget while scrolling - https://phabricator.wikimedia.org/T88385#1010418 (10Jdforrester-WMF) p:5Triage>3Normal [01:51:43] (03PS5) 10Jforrester: TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [01:51:48] (03PS2) 10Jforrester: Fix initialisation of window visible [oojs/ui] - 10https://gerrit.wikimedia.org/r/188237 (owner: 10Esanders) [01:52:01] (03PS3) 10Jforrester: SelectWidget: listbox wrapper role, state on contents [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [01:52:32] (03PS7) 10Jforrester: TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (https://phabricator.wikimedia.org/T64174) (owner: 10Prtksxna) [01:52:38] (03PS8) 10Jforrester: MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) [01:58:38] (03CR) 10jenkins-bot: [V: 04-1] SelectWidget: listbox wrapper role, state on contents [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [02:00:27] (03CR) 10jenkins-bot: [V: 04-1] TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (https://phabricator.wikimedia.org/T64174) (owner: 10Prtksxna) [02:01:53] (03CR) 10jenkins-bot: [V: 04-1] MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [02:10:08] (03PS1) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 [02:27:48] James_F: :-(, so its' failing again [02:27:57] esparse symlink race condition [02:29:12] Krinkle: :-( [02:29:17] Krinkle: But it worked so well! [03:11:22] (03CR) 10Krinkle: "02:01:51 Running "colorizeSvg:apex" (colorizeSvg) task" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [03:31:58] (03PS1) 10Jforrester: [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 [03:32:51] (03PS2) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 [03:38:42] (03CR) 10Catrope: "FIXME: this is broken, because now hrefs are being resolved in the wrong document" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186797 (https://phabricator.wikimedia.org/T87416) (owner: 10Catrope) [03:41:02] 3VisualEditor, VisualEditor-Performance: LinkCache should be smarter - https://phabricator.wikimedia.org/T88259#1010533 (10Catrope) a:3Catrope [03:41:38] (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [03:42:32] InezK_away: Actually I think you found a bug [03:42:43] InezK_away: https://gerrit.wikimedia.org/r/#/c/186797/ is broken, I'm working on fixing it now [03:42:51] InezK_away: (Re ve.resolveUri stuff) [03:43:09] edsanders: https://gerrit.wikimedia.org/r/#/c/187811/ [04:01:15] (03CR) 10Krinkle: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [04:11:48] 3OOjs-UI: OOjs UI: Dialog height initially mis-measured in Safari 7.1 - https://phabricator.wikimedia.org/T73736#1010550 (10Prtksxna) a:5Prtksxna>3None [04:11:56] 3OOjs-UI: OOjs UI: Dialog height initially mis-measured in Safari 7.1 - https://phabricator.wikimedia.org/T73736#1010551 (10Prtksxna) 5Open>3Invalid a:3Prtksxna [04:23:07] (03PS1) 10Catrope: Followup a92661781: fix attribute resolution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188294 [04:23:54] 3VisualEditor, VisualEditor-Performance: Lots of time spent animating CSS properties of slugs - https://phabricator.wikimedia.org/T88387#1010556 (10Krinkle) a:3Krinkle @Catrope and I spent some more time debugging this and we verified that none of the slug-related elements or classes are changed throughout the... [04:25:07] (03PS1) 10Krinkle: mw.Target: Add mw-body-content class before we attach surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188295 (https://phabricator.wikimedia.org/T88387) [04:29:57] (03CR) 10Krinkle: [C: 031] Followup a92661781: fix attribute resolution [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188294 (owner: 10Catrope) [04:35:00] (03CR) 10Krinkle: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [04:35:37] (03PS1) 10Catrope: Make API module's LinkCache data transmission format more efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188297 (https://phabricator.wikimedia.org/T88259) [04:37:22] (03CR) 10jenkins-bot: [V: 04-1] Make API module's LinkCache data transmission format more efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188297 (https://phabricator.wikimedia.org/T88259) (owner: 10Catrope) [04:56:23] (03CR) 10Catrope: [C: 032] mw.Target: Add mw-body-content class before we attach surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188295 (https://phabricator.wikimedia.org/T88387) (owner: 10Krinkle) [04:58:08] (03Merged) 10jenkins-bot: mw.Target: Add mw-body-content class before we attach surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188295 (https://phabricator.wikimedia.org/T88387) (owner: 10Krinkle) [05:36:11] (03CR) 10Ori.livneh: "Nice work!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188295 (https://phabricator.wikimedia.org/T88387) (owner: 10Krinkle) [06:38:30] (03PS6) 10Esanders: Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 [06:41:48] (03PS1) 10Esanders: Fix owner doc in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188312 [06:47:06] (03PS1) 10Esanders: Fix typo in F&R teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188313 [07:05:56] (03PS3) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 [07:08:19] (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [07:18:45] 3Multimedia, MediaWiki-ResourceLoader, MediaWiki-extensions-Sentry: Create ResourceLoader hook to wrap module code - https://phabricator.wikimedia.org/T85263#1010712 (10Tgr) [07:18:46] 3Multimedia, MediaWiki-ResourceLoader, MediaWiki-extensions-Sentry: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#1010711 (10Tgr) [07:19:54] 3Multimedia, MediaWiki-ResourceLoader, MediaWiki-extensions-Sentry: Track module initialization errors in ResourceLoader - https://phabricator.wikimedia.org/T85263#1010713 (10Tgr) [07:32:43] (03PS28) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [07:33:29] (03CR) 10Divec: "Ignore my previous comment: it was a bug because I evidently can't refactor comparison function calls without reversing them." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [07:36:31] (03PS2) 10Divec: Reinstate keypress filtering for Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187884 [07:36:33] (03PS29) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 [07:36:45] (03PS2) 10Divec: WIP POC: fixup Chromium cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187889 [07:37:28] (03CR) 10Divec: "Rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187889 (owner: 10Divec) [07:37:42] (03CR) 10Divec: "Rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [07:40:41] (03CR) 10Ryasmeen: [C: 032] [BrowserTest] Updating test for Media Settings interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 (owner: 10Ryasmeen) [07:42:35] (03Merged) 10jenkins-bot: [BrowserTest] Updating test for Media Settings interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187171 (owner: 10Ryasmeen) [07:51:43] (03CR) 10Nikerabbit: "Anything that needs changing in the workflow of adding new languages or are you just going to keep fixing it every time we add new languag" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188197 (owner: 10L10n-bot) [08:18:41] (03PS1) 10Esanders: DOMNodeInsertedIntoDocument -> DOMNodeInserted [oojs/ui] - 10https://gerrit.wikimedia.org/r/188325 [08:27:37] 3Multimedia, MediaWiki-ResourceLoader, MediaWiki-extensions-Sentry: Create ResourceLoader hook to add new startup modules - https://phabricator.wikimedia.org/T85262#1010796 (10Tgr) Added mw.track calls and reimplemented the relevant part from raven.js in https://gerrit.wikimedia.org/r/188326 and children. Sentry... [08:47:48] hi [08:48:21] how we are doing with the dialog window deactivation bug? the actuall behaviour is really annoying [09:16:17] 3VisualEditor-EditingTools, VisualEditor: Various dialog windows automatically deactivates - https://phabricator.wikimedia.org/T88411#1010890 (10Juandev) 3NEW [09:17:54] (03PS2) 10Catrope: Make API module's LinkCache data transmission format more efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188297 (https://phabricator.wikimedia.org/T88259) [09:19:10] (03CR) 10Catrope: [C: 032] Reinstate keypress filtering for Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187884 (owner: 10Divec) [09:21:53] (03CR) 10Catrope: "I'm not proud of the hacky way assumeLinksExist is communicated, but I'm not sure how else to do this either." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188297 (https://phabricator.wikimedia.org/T88259) (owner: 10Catrope) [09:26:15] (03Merged) 10jenkins-bot: Reinstate keypress filtering for Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187884 (owner: 10Divec) [09:32:19] (03PS3) 10Catrope: Make API module's LinkCache data transmission format more efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188297 (https://phabricator.wikimedia.org/T88259) [09:36:48] (03CR) 10Catrope: "PS3: less hacky way of assuming existence, also works for links inside of templates" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188297 (https://phabricator.wikimedia.org/T88259) (owner: 10Catrope) [09:38:36] (03CR) 10Catrope: "@Ricordisamoa: We already have that: you can call .toggle(true) and .toggle(false) on a widget to show/hide it, and that uses the oo-ui-el" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo) [09:41:32] (03CR) 10Catrope: [C: 04-1] "@Ricordisamoa: Actually, you're right, a bunch of the calls in this commit do involve widgets. We should use .toggle() there instead; I've" (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187618 (https://phabricator.wikimedia.org/T87420) (owner: 10Mooeypoo) [09:42:03] (03CR) 10Catrope: [C: 032] Fix typo in F&R teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188313 (owner: 10Esanders) [09:42:12] (03CR) 10Catrope: [C: 032] Fix owner doc in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188312 (owner: 10Esanders) [09:42:43] (03CR) 10Catrope: [C: 04-2] Fix owner doc in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188312 (owner: 10Esanders) [09:44:18] (03CR) 10Catrope: "I realize this isn't exactly well-documented, but the targetDoc parameter to getModelFromDom() is NOT meant to be the view document. In no" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188312 (owner: 10Esanders) [09:47:21] (03CR) 10Catrope: [C: 032] Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [09:48:33] (03CR) 10Catrope: "Followed up in https://gerrit.wikimedia.org/r/#/c/188294" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186797 (https://phabricator.wikimedia.org/T87416) (owner: 10Catrope) [09:48:53] (03Merged) 10jenkins-bot: Fix typo in F&R teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188313 (owner: 10Esanders) [09:52:01] (03CR) 10Catrope: [C: 04-1] Use css class rather than jQuery show/hide (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187617 (owner: 10Mooeypoo) [09:52:27] (03CR) 10Catrope: [C: 032] Update scalable and view on direct attribute change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186645 (owner: 10Esanders) [09:54:22] (03PS3) 10Catrope: Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [09:55:27] (03CR) 10Catrope: [C: 032] Use new window#updateSize method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187838 (owner: 10Esanders) [09:56:07] (03CR) 10jenkins-bot: [V: 04-1] Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [09:56:33] (03CR) 10Ori.livneh: Make API module's LinkCache data transmission format more efficient (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188297 (https://phabricator.wikimedia.org/T88259) (owner: 10Catrope) [09:56:53] what is this, second shift? [09:56:58] i thought i was the one with insomnia [09:57:04] (03CR) 10Catrope: [C: 04-1] Fix initialisation of window visible (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/188237 (owner: 10Esanders) [09:57:06] (03Merged) 10jenkins-bot: Use text input's setLabel functionality in find dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187443 (owner: 10Esanders) [09:57:08] (03Merged) 10jenkins-bot: Update scalable and view on direct attribute change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/186645 (owner: 10Esanders) [09:57:13] (03Merged) 10jenkins-bot: Use new window#updateSize method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187838 (owner: 10Esanders) [09:58:52] (03CR) 10Catrope: [C: 04-1] Fade in window frames separately from window overlays (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/188256 (owner: 10Esanders) [10:00:04] (03CR) 10Catrope: SelectWidget: listbox wrapper role, state on contents (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [10:01:13] (03CR) 10Catrope: "This is failing with errors like "../../../ui/styles/images/resize-nw-se.svg not found on disk" and I have no idea why." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [10:04:44] (03CR) 10Catrope: [C: 032] Use .prop() instead of .attr() where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 (owner: 10Krinkle) [10:08:26] (03Merged) 10jenkins-bot: Use .prop() instead of .attr() where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187305 (owner: 10Krinkle) [10:35:42] 3VisualEditor: Hypothetical generation of strange characters at the beginning of pages - https://phabricator.wikimedia.org/T67674#1011043 (10Qgil) 5stalled>3Resolved a:3Qgil While ca.wiki got plenty of strange characters during several weeks, that happened month ago, and the strange characters haven't been... [12:44:14] 3WikiEditor: WikiEditor should sort the pages of characters alphabetically (by their labels) - https://phabricator.wikimedia.org/T88418#1011174 (10He7d3r) 3NEW [12:48:16] Why was this ^ reported here instead of e.g. on #wikimedia-dev? (It is not about VisualEditor) [12:51:28] Helder: because technically we're not the VisualEditor team, but the Editing team, and we supposedly support all of the editing thingies, including WikiEditor. not common knowledge, seemingly even within the team. ;) [12:51:50] good to know :-) [12:52:00] (and i guess it was decided that renaming/splitting this channel would be pointless, which was a good decision because it would) [13:13:20] (03CR) 10Nemo bis: "It would be useful to state source of the data. Also, https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 (owner: 10Anishvisa) [14:55:04] (03PS6) 10Gerrit Patch Uploader: Style code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 [14:55:07] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [15:05:32] (03PS7) 10Gerrit Patch Uploader: Style code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 [15:05:35] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [15:22:54] 3MediaWiki-Page-editing: Separate edit summaries when adding comments to a page - https://phabricator.wikimedia.org/T10341#1011576 (10Perhelion) [15:22:55] 3MediaWiki-Page-editing: Heading-field (section=new) uses same name/id as edit summary (action=edit) - https://phabricator.wikimedia.org/T28312#1011577 (10Perhelion) [15:37:20] (03CR) 10Jforrester: "> Anything that needs changing in the workflow of adding new languages or are you just going to keep fixing it every time we add new langu" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188197 (owner: 10L10n-bot) [15:39:47] 3MediaWiki-Page-editing: Separate edit summaries when adding comments to a page - https://phabricator.wikimedia.org/T10341#1011588 (10He7d3r) [16:27:29] (03PS2) 10Jforrester: [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 [16:32:53] 3VisualEditor, VisualEditor-Performance: Lots of time spent animating CSS properties of slugs - https://phabricator.wikimedia.org/T88387#1011695 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [16:46:47] (03PS3) 10Jforrester: [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 [17:04:03] (03PS3) 10Divec: Word character class regex [unicodejs] - 10https://gerrit.wikimedia.org/r/185103 [17:30:35] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13669526 [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111501527 [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111507578 [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111514551 [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111522362 [17:30:36] Corruption alert: visualeditor-needcheck on euwiki: https://eu.wikipedia.org/?diff=4761313 [17:30:36] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=138447235 [17:30:37] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=138449217 [17:30:37] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=138449444 [17:30:38] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7939061 [17:30:38] Corruption alert: visualeditor-needcheck on dawiki: https://da.wikipedia.org/?diff=7939065 [17:57:55] 3VisualEditor-MediaWiki, VisualEditor: Documented default value of format parameter for action=visualeditor does not match result - https://phabricator.wikimedia.org/T87582#1011980 (10Jdforrester-WMF) p:5Triage>3Volunteer? a:3Jdforrester-WMF [18:12:54] hi James_F I'm not sure if this is of interest or not, but a heads up in case: https://phabricator.wikimedia.org/T88448 [18:13:17] chrismcmahon: Oh dear. [18:13:28] chrismcmahon: That's a Collaboration team issue, but I vaguely care. [18:18:21] 3WMF-Design, UI-Standardization, OOjs-UI: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1012026 (10kaldari) 3NEW a:3Prtksxna [18:21:59] 3VisualEditor-ContentEditable, VisualEditor: [Regression wmf4] Link continuation is broken - https://phabricator.wikimedia.org/T74108#1012044 (10Jdforrester-WMF) [18:22:00] 3VisualEditor: Link format gets applied to text typed on the same line(link continuation) - https://phabricator.wikimedia.org/T88382#1012043 (10Jdforrester-WMF) [18:25:18] (03PS1) 10Jforrester: Update VE core submodule to master (c9b90ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188401 [18:25:20] (03PS1) 10Jforrester: ApiVisualEditor: Default format is jsonfm not json, so note this [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188402 (https://phabricator.wikimedia.org/T87582) [18:26:25] (03PS4) 10Jforrester: Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [18:27:01] (03CR) 10Esanders: Fix initialisation of window visible (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/188237 (owner: 10Esanders) [18:28:26] 3WMF-Design, UI-Standardization, OOjs-UI: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1012062 (10Jdforrester-WMF) [18:28:27] 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1012063 (10Jdforrester-WMF) [18:29:21] 3WMF-Design, UI-Standardization, OOjs-UI: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1012066 (10Jdforrester-WMF) p:5Triage>3Normal [18:29:37] (03CR) 10Esanders: Fade in window frames separately from window overlays (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/188256 (owner: 10Esanders) [18:30:56] (03CR) 10jenkins-bot: [V: 04-1] Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [18:36:49] (03CR) 10Jforrester: "Krinkle: Yes, that's the blocker to this patch. The format used in images.json currently only supports:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [18:37:15] (03CR) 10Alex Monk: [C: 032] ApiVisualEditor: Default format is jsonfm not json, so note this [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188402 (https://phabricator.wikimedia.org/T87582) (owner: 10Jforrester) [18:38:16] edsanders: Did you see that https://gerrit.wikimedia.org/r/#/c/187144/ failed after the pull-through? [18:38:52] edsanders: Also, can I grab code review on https://gerrit.wikimedia.org/r/#/c/179002/ and https://gerrit.wikimedia.org/r/#/c/185393/ [18:39:13] And https://gerrit.wikimedia.org/r/#/c/188401/ is a core pull-through. [18:39:22] Hey MartyH. [18:40:35] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/179002/3 [18:40:48] edsanders: Oh, yes, sorry, you said. [18:42:14] (03CR) 10Esanders: [C: 032] Wait with showing edit notices until after the welcome dialog is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) (owner: 10Bartosz Dziewoński) [18:44:03] (03Merged) 10jenkins-bot: Wait with showing edit notices until after the welcome dialog is closed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/185393 (https://phabricator.wikimedia.org/T86987) (owner: 10Bartosz Dziewoński) [18:44:26] 3VisualEditor-MediaWiki, VisualEditor: Closing welcome dialog also hides important edit notices - https://phabricator.wikimedia.org/T86987#1012136 (10Jdforrester-WMF) 5Open>3Resolved [18:55:32] (03PS2) 10Esanders: Fix owner doc in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188312 [19:02:01] (03CR) 10Catrope: [C: 032] Fix owner doc in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188312 (owner: 10Esanders) [19:04:36] ori: I'm not frequently insomnic, only sometimes, and last night was apparently one of those times that I couldn't sleep until 3 :( [19:04:46] (03Merged) 10jenkins-bot: Fix owner doc in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188312 (owner: 10Esanders) [19:10:22] RoanKattouw: something kind of amazing is happening: as I discover various VE features, I get excited to try them out "in the wild", and I make more edits :P [19:10:46] haha [19:11:16] * ori created https://en.wikipedia.org/wiki/Starshel_(newspaper) the other night [19:13:52] 3WikiEditor, Language-Engineering: Toolbar buttons misrendering in wikitext editor in Arabic Wikipedia when user language set to LTR language - https://phabricator.wikimedia.org/T88463#1012283 (10kaldari) {F36486} [19:14:29] 3WikiEditor, Language-Engineering: Toolbar buttons misrendering in wikitext editor in Arabic Wikipedia when user language set to LTR language - https://phabricator.wikimedia.org/T88463#1012288 (10kaldari) Interestingly the bug doesn't seem to occur on the Hebrew Wikipedia. [19:14:59] 3WikiEditor, Language-Engineering: Toolbar buttons misrendering in wikitext editor in Arabic Wikipedia when user language set to LTR language - https://phabricator.wikimedia.org/T88463#1012289 (10kaldari) [19:15:48] (03CR) 10Krinkle: [C: 04-1] TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (https://phabricator.wikimedia.org/T64174) (owner: 10Prtksxna) [19:16:05] 3VisualEditor-MediaWiki, Beta-Cluster, VisualEditor: On Beta Cluster, switching from VisualEditor to edit source mode intermittently loads the wikitext editor without any CSS - https://phabricator.wikimedia.org/T86624#1012293 (10Ryasmeen) I found this error again today while saving edit on a newly created page {... [19:17:04] ori: Hah nice [19:17:19] (03CR) 10Krinkle: "MutationObserver is not universally available in browsers OOjs UI supports. This needs to one of 1) become part of a feature test for blac" [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (https://phabricator.wikimedia.org/T64174) (owner: 10Prtksxna) [19:18:07] ori: So Timo and I found the cause of the slug animation thing, it was because .mw-body-content is applied to the .ve-ce-surface wrapper *after* everything is built, and Vector has .mw-body-content { font-size: 0.8em; } so this caused everything to be rendered with one font size, then rerendered with another [19:18:34] yep, i saw the patch. good sleuthing. [19:18:52] The slugs have a margin and font-size expressed in ems, so adding that class changes what an em means, and the margin and font-size properties are transitioned so there you go [19:19:06] Apart from avoiding the transition, it's probably also good to not flow all the text twice at different font sizes [19:19:19] (03CR) 10Nemo bis: "Hi, thanks for your pach! Do you need help fixing the jenkins error? You are very close, there is only a small error:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [19:19:27] yeah, i'm excited to see what impact that has [19:20:43] Yeah I'll have to do some more vbenching later [19:24:43] TrevorP|Away: Can you review https://gerrit.wikimedia.org/r/#/c/179002/3 ? [19:26:03] (03PS4) 10Esanders: Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 [19:28:30] (03CR) 10jenkins-bot: [V: 04-1] Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [19:32:51] (03PS4) 10Catrope: Make API module's LinkCache data transmission format more efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188297 (https://phabricator.wikimedia.org/T88259) [19:39:11] Krenair: Want to +2 https://gerrit.wikimedia.org/r/#/c/188401/ too so that https://gerrit.wikimedia.org/r/#/c/188402/ merges? :-) [19:41:38] (03PS3) 10Jforrester: test: Rebuild .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 [19:42:07] 3WikiEditor, Language-Engineering: Toolbar buttons misrendering in wikitext editor in Arabic Wikipedia when user language set to LTR language - https://phabricator.wikimedia.org/T88463#1012380 (10kaldari) Confirmed in Firefox and Chrome. [19:42:11] James_F, looking [19:43:27] (03PS4) 10Jforrester: test: Rebuild .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 [19:43:28] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (c9b90ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188401 (owner: 10Jforrester) [19:43:37] chrismcmahon: Can I grab a +2 on https://gerrit.wikimedia.org/r/#/c/187084/? [19:43:50] chrismcmahon: (No-one else will touch .rb stuff. ;-)) [19:43:57] Thanks Krenair. [19:44:41] (03CR) 10Cmcmahon: [C: 032] test: Rebuild .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 (owner: 10Jforrester) [19:44:47] chrismcmahon: Thanks. [19:44:55] sure James_F [19:45:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (c9b90ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188401 (owner: 10Jforrester) [19:45:38] (03Merged) 10jenkins-bot: ApiVisualEditor: Default format is jsonfm not json, so note this [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188402 (https://phabricator.wikimedia.org/T87582) (owner: 10Jforrester) [19:46:30] (03Merged) 10jenkins-bot: test: Rebuild .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187084 (owner: 10Jforrester) [19:46:43] ryasmeen: Have you seen "Uncaught TypeError: Cannot read property 'layout' of undefined" when opening a template? [19:47:29] James_F: yeah just saw that [19:47:42] edsanders: You broke BookletLayout, it looks like. :-( [19:48:14] OO.ui.BookletLayout.prototype.toggleOutline tries to do `this.gridLayout.layout(show ? [1, 2] : [0, 1], [1])` which fails because .layout doesn't ist? [19:48:17] +ex [19:48:54] also adding table is broken James_F [19:49:03] Fun. [19:49:20] Uncaught Error: Offset could not be translated to a DOM element [19:49:36] Hmm. Works for me. [19:50:16] In contentful paragraph, blank one, slug and heading. [19:51:53] 3VisualEditor-ContentLanguage, VisualEditor-ContentEditable, VisualEditor: Non-local text changes cause CE updates that close IME candidate window - https://phabricator.wikimedia.org/T76056#1012398 (10Jdforrester-WMF) [19:52:08] 3VisualEditor: VisualEditor: Rewrite converter to be bottom-up - https://phabricator.wikimedia.org/T53501#1012399 (10Jdforrester-WMF) [19:52:52] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should go to veaction=edit not action=edit - https://phabricator.wikimedia.org/T55441#1012402 (10Jdforrester-WMF) [19:54:58] 3OOjs-UI, VisualEditor: BookletLayout dies on open - https://phabricator.wikimedia.org/T88471#1012422 (10Jdforrester-WMF) 3NEW a:3Esanders [19:56:04] 3VisualEditor-EditingTools, VisualEditor: Various dialog windows gain and then lose the focus after opening - https://phabricator.wikimedia.org/T88411#1012432 (10Jdforrester-WMF) [19:57:16] 3VisualEditor-EditingTools, VisualEditor: Various dialog windows gain and then lose the focus after opening - https://phabricator.wikimedia.org/T88411#1010890 (10Jdforrester-WMF) The template dialog was fixed in {T85484}. In what other dialogs are you finding this issue? [19:57:51] 3VisualEditor-EditingTools, VisualEditor: Various dialog windows gain and then lose the focus after opening - https://phabricator.wikimedia.org/T88411#1012448 (10Jdforrester-WMF) p:5Triage>3Normal [19:58:21] 3OOjs-UI, VisualEditor, VisualEditor-Performance: ~50ms spent a.oo-ui-buttonElement-button - https://phabricator.wikimedia.org/T88386#1012452 (10Jdforrester-WMF) p:5Triage>3High [19:58:58] (03PS5) 10Esanders: Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 [19:59:24] edsanders: Eww. But if it works, it works… [19:59:41] ve-mw/tests/ve.test.utils.js is one big set of hacks anywawy. [19:59:47] James_F, ideally we wouldn't load the SA platform, but RL [19:59:54] edsanders: Yeah. [20:00:37] (03CR) 10jenkins-bot: [V: 04-1] Migrate to ve.config (except in init where it doesn't exist) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders) [20:00:58] Apparently it doesn't work. [20:01:29] The npm one is just a trivial jscs failure. [20:02:38] 3VisualEditor: VisualEditor doesn't work in Uzbek Wiki (production hiccup?) - https://phabricator.wikimedia.org/T88119#1012467 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [20:03:09] (03CR) 10Jforrester: [C: 031] Make API module's LinkCache data transmission format more efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188297 (https://phabricator.wikimedia.org/T88259) (owner: 10Catrope) [20:08:50] (03PS3) 10Ryasmeen: [BrowserTest] Test to check the functionality of Change Image button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 [20:08:54] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Test to check the functionality of Change Image button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 (owner: 10Ryasmeen) [20:10:12] (03CR) 10Ryasmeen: [C: 032] [BrowserTest] Test to check the functionality of Change Image button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 (owner: 10Ryasmeen) [20:10:15] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Test to check the functionality of Change Image button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 (owner: 10Ryasmeen) [20:10:34] (03PS4) 10Jforrester: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [20:12:33] (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [20:15:33] (03CR) 10Jforrester: "PS4 is a manual rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [20:18:20] (03PS5) 10Jforrester: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [20:19:01] (03CR) 10Jforrester: "PS5 pulls the tool out to its own group at the end of the toolbar." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [20:20:00] (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [20:21:04] (03PS6) 10Jforrester: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [20:21:49] (03CR) 10Jforrester: [C: 031] "PS6 fixes the JSDuck failure." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [20:24:44] RoanKattouw, have been looking through how VE does edit event logging, it seems to rely on storing things like timestamp of the user's last editing events and a session ID thing [20:25:11] Krenair: Yeah that sounds right [20:25:17] I guess for WikiEditor this would have to go into localStorage or cookies or something, since it would need to persist across pages? [20:25:21] (03PS3) 10Paladox: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [20:25:27] Oh crap, hm [20:25:27] (03CR) 10jenkins-bot: [V: 04-1] Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [20:27:13] I suspect some of the VE code would be useful in both VE and WikiEditor, but I don't think there's a good place to share it between them.. [20:29:06] One problem is that right now, on Firefox, localStorage is basically always full [20:29:07] Krenair: WikimediaEvents? [20:29:11] *cough* ori Krinkle *cough* [20:29:14] RoanKattouw: Yeah. :-( [20:29:41] (03CR) 10Esanders: [C: 04-1] DOMNodeInsertedIntoDocument -> DOMNodeInserted [oojs/ui] - 10https://gerrit.wikimedia.org/r/188325 (owner: 10Esanders) [20:34:11] 3VisualEditor: [Regression pre-wmf16]: Firefox only: Tables - When a cell is highlighted, a thick border line displayed in the middle - https://phabricator.wikimedia.org/T88474#1012574 (10Etonkovidova) 3NEW [20:43:30] mooeypoo: https://commons.wikimedia.org/wiki/File:Crinoid.jpg [20:44:05] RoanKattouw, ori, Krinkle: so... what should I do? [20:44:13] Hmmmm [20:44:26] I'm not sure yet [20:46:09] Krenair: But... how many of these events occur client side vs server side? [20:46:21] I guess init/ready are client-side [20:46:26] But save* is server-side? [20:46:57] saveAttempt, saveSuccess, saveFailure? [20:47:15] Krenair, RoanKattouw: Can you just share it from page to page with adding it to the POST payload? [20:47:20] Probably [20:47:32] Yeah I guess that could work [20:47:40] Insert a hidden form elemenet [20:47:58] Yeah. [20:48:09] :( [20:48:31] that sort of sucks, but ok [20:48:42] Less bad than adding a cookie. [20:48:45] true [20:51:42] (03PS1) 10Ricordisamoa: Support 'min', 'max' and 'step' in TextInputWidget constructor [oojs/ui] - 10https://gerrit.wikimedia.org/r/188425 [20:54:24] (03CR) 10Ricordisamoa: Support 'min', 'max' and 'step' in TextInputWidget constructor (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/188425 (owner: 10Ricordisamoa) [20:55:45] (03CR) 10Ricordisamoa: [C: 04-1] "The new attributes should be documented." [oojs/ui] - 10https://gerrit.wikimedia.org/r/188425 (owner: 10Ricordisamoa) [21:03:44] 3VisualEditor-MediaWiki, VisualEditor: Documented default value of format parameter for action=visualeditor does not match result - https://phabricator.wikimedia.org/T87582#1012647 (10Jdforrester-WMF) 5Open>3Resolved [21:50:42] ryasmeen|Away: are we meeting today or are we caught up from yesterday? [21:53:41] (03PS4) 10Cmcmahon: [BrowserTest] Test for checking General Settings for media [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187610 (owner: 10Ryasmeen) [21:55:59] 3Parsoid, VisualEditor-ContentLanguage, VisualEditor: {{int:..}} usages should render in user language instead of content language - https://phabricator.wikimedia.org/T72215#1012912 (10ssastry) [22:08:51] (03CR) 10Ricordisamoa: "Are there plans to remove the old ones?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [22:11:48] (03CR) 10Jforrester: "> Are there plans to remove the old ones?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [22:20:30] 3VisualEditor: Some navbox and other templates disappear when being moved, but only if tags are present in the article and the templates are below the last visible text - https://phabricator.wikimedia.org/T58923#1013003 (10neilpquinn) I checked all the affected articles listed by @Whatamidoing-WMF, and the... [22:28:35] James_F|Away: eww. https://www.mediawiki.org/w/index.php?title=Mobile_web/Team/Dev_sessions&diff=1392969&oldid=1392962 [22:30:17] user error? [22:30:50] that happens if you click the 'New page' suggestion rather than the (preferred) 'External link' option... [22:31:42] oh, there is a space at the beginning. that may break the external link detection [22:49:31] 3Parsoid, VisualEditor, VisualEditor-Tables: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1013104 (10Martijn_Hoekstra) How odd. https://en.wikipedia.org/w/index.php?title=User%3AMartijn_Hoekstra%2FInfobox_statistical_analyses&diff=645145408&oldid=6451... [23:01:03] 3VisualEditor: Some navbox and other templates disappear when being moved, but only if tags are present in the article and the templates are below the last visible text - https://phabricator.wikimedia.org/T58923#1013128 (10Jdforrester-WMF) 5stalled>3Resolved a:3Jdforrester-WMF OK, in that case now ma... [23:01:25] 3Parsoid, VisualEditor, VisualEditor-Tables: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1013133 (10Martijn_Hoekstra) my edit went from empty to - maybe that makes a difference? [23:16:51] chrismcmahon: Oh! I think we cancelled it yesterday? [23:18:56] ryasmeen: I wasn't sure. No problem [23:20:42] (03CR) 10Ryasmeen: [C: 032] [BrowserTest] Test for checking General Settings for media [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187610 (owner: 10Ryasmeen) [23:22:59] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Test for checking General Settings for media [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187610 (owner: 10Ryasmeen) [23:25:13] (03CR) 10Ryasmeen: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187610 (owner: 10Ryasmeen) [23:25:37] (03Abandoned) 10Esanders: DOMNodeInsertedIntoDocument -> DOMNodeInserted [oojs/ui] - 10https://gerrit.wikimedia.org/r/188325 (owner: 10Esanders) [23:42:42] (03Restored) 10Jagori79: WIP: [BrowserTest] Rework long external link code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [23:45:22] (03CR) 10Jagori79: "Hi," (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [23:55:18] (03PS1) 10Esanders: Use CSS overriding trick to support RTL in menu layouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/188487