[00:03:02] 3OOjs-UI: Audit all methods and add @private and @protected where appropriate - https://phabricator.wikimedia.org/T88628#1016456 (10TrevorParscal) 3NEW a:3matmarex [00:04:23] 3OOjs-UI: Document public properties - https://phabricator.wikimedia.org/T88629#1016465 (10TrevorParscal) 3NEW a:3matmarex [00:06:57] >>> a = [1,2,3,4,5,6]; b = a.splice(3); [a,b]; [00:06:57] RoanKattouw: (object) [[1, 2, 3], [4, 5, 6]] [00:07:45] (03Merged) 10jenkins-bot: extension.json: Add "VisualEditorPluginModules" to "config" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188700 (owner: 10Legoktm) [00:07:47] (03PS1) 10Alex Monk: Unbind watch event handler in VPT when necessary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188706 [00:08:14] Whoops, I meant: [00:08:40] >>> wholeArray = [1,2,3,4,5,6,7,8,9,10]; sub = wholeArray.splice(0,3); [sub,wholeArray]; [00:08:40] RoanKattouw: (object) [[1, 2, 3], [4, 5, 6, 7, 8, 9, 10]] [00:08:43] mooeypoo: --^^ [00:09:06] (03CR) 10Catrope: [C: 032] Fade in window frames separately from window overlays [oojs/ui] - 10https://gerrit.wikimedia.org/r/188256 (owner: 10Esanders) [00:09:18] (03CR) 10Alex Monk: "I0f0af71c" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/182336 (https://phabricator.wikimedia.org/T78694) (owner: 10Alex Monk) [00:10:31] (03Merged) 10jenkins-bot: Fade in window frames separately from window overlays [oojs/ui] - 10https://gerrit.wikimedia.org/r/188256 (owner: 10Esanders) [00:10:36] (03CR) 10Catrope: [C: 032] Fix initialisation of window visible [oojs/ui] - 10https://gerrit.wikimedia.org/r/188237 (owner: 10Esanders) [00:11:00] 3OOjs-UI: OOUI: It's unclear which class members (properties) are public/private/internal - https://phabricator.wikimedia.org/T74578#1016486 (10matmarex) [00:11:01] 3OOjs-UI: Document public properties - https://phabricator.wikimedia.org/T88629#1016487 (10matmarex) [00:13:11] (03Merged) 10jenkins-bot: Fix initialisation of window visible [oojs/ui] - 10https://gerrit.wikimedia.org/r/188237 (owner: 10Esanders) [00:14:32] 3MediaWiki-ContentHandler, VisualEditor: Cite options are missing in test2 for VE now - https://phabricator.wikimedia.org/T87054#1016495 (10Krenair) [00:24:21] 3WikiEditor, Language-Engineering: Toolbar buttons misrendering in wikitext editor in Arabic Wikipedia when user language set to LTR language - https://phabricator.wikimedia.org/T88463#1016553 (10Aklapper) [00:33:10] RoanKattouw: Your equivalent of http://localhost:8080/w/extensions/VisualEditor/lib/ve/test-coverage/visualeditor/Chrome%2040.0.2214%20(Mac%20OS%20X%2010.10.1)/src/ui/commands/index.html [00:35:07] (03PS2) 10Jforrester: Update VE core submodule to master (55e3589) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188616 [00:35:21] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (55e3589) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188616 (owner: 10Jforrester) [00:35:25] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/188614/ [00:35:39] (03CR) 10Catrope: [C: 032] MWTransclusionDialog: Add a little margin to the addTemplateFieldset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188614 (owner: 10Jforrester) [00:35:43] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/188706/ [00:36:31] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/179002/ is +1'ed from Ed, waiting for you "to check the promises". [00:37:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (55e3589) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188616 (owner: 10Jforrester) [00:37:54] 3Parsoid, VisualEditor, VisualEditor-Performance: Thoughts on element IDs, sections, incremental parsing and fast section editing - https://phabricator.wikimedia.org/T87556#1016616 (10Jdforrester-WMF) p:5Triage>3Normal [00:38:27] RoanKattouw: And after all that, can you give some indication on https://phabricator.wikimedia.org/T87161 as to the likely disposition? [00:38:30] 3VisualEditor: [[Linkhttps://en.wikipedia.org/wiki/Link|Link]] is always wrong - https://phabricator.wikimedia.org/T88502#1016625 (10Whatamidoing-WMF) Since there's no difference in how VisualEditor makes internal and external links, suggesting that the user make an external link is going to be confusing. How a... [00:38:42] (03CR) 10jenkins-bot: [V: 04-1] MWTransclusionDialog: Add a little margin to the addTemplateFieldset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188614 (owner: 10Jforrester) [00:39:06] 3VisualEditor: [[Linkhttps://en.wikipedia.org/wiki/Link|Link]] is always wrong - https://phabricator.wikimedia.org/T88502#1016628 (10Jdforrester-WMF) If so, can we just merge into {T76398}? [00:40:04] (03CR) 10Jforrester: [C: 032] "C'mon." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188614 (owner: 10Jforrester) [00:40:35] James_F: Sorry for a potentially duh question but what is the difference between the VisualEditor/VisualEditor repo and mediawiki/extensions/VisualEditor? I'm guessing the first is the submod in lib/ve [00:41:19] Negative24: Yes [00:41:33] Negative24: VisualEditor/VisualEditor is "VisualEditor core", a generic HTML editor. mediawiki/extensions/VisualEditor is "VisualEditor-MediaWiki", an extension for MediaWiki that integrates VisualEditor core and extends it. [00:42:16] RoanKattouw James_F: Thanks and sorry for bothering you. I'm having a bit of VE dissecting fun [00:42:16] (03Merged) 10jenkins-bot: MWTransclusionDialog: Add a little margin to the addTemplateFieldset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188614 (owner: 10Jforrester) [00:43:05] Seems a bit self-explanatory now that I look at it :) [00:43:08] (03CR) 10Catrope: [C: 04-1] Unbind watch event handler in VPT when necessary (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188706 (owner: 10Alex Monk) [00:53:58] (03PS1) 10Jforrester: build: Bump various devDependencies to latest [unicodejs] - 10https://gerrit.wikimedia.org/r/188716 [00:55:26] (03PS1) 10Jforrester: Tag v0.1.3 [unicodejs] - 10https://gerrit.wikimedia.org/r/188717 [00:55:47] (03CR) 10jenkins-bot: [V: 04-1] build: Bump various devDependencies to latest [unicodejs] - 10https://gerrit.wikimedia.org/r/188716 (owner: 10Jforrester) [00:56:08] (03CR) 10Jforrester: "recheck" [unicodejs] - 10https://gerrit.wikimedia.org/r/188716 (owner: 10Jforrester) [01:02:35] 3VisualEditor: API design and documentation - https://phabricator.wikimedia.org/T40855#1016725 (10Jdforrester-WMF) [01:02:36] 3VisualEditor, VisualEditor-Performance: Explore performance gains from progressive (JIT?) de-alienation of content types in VisualEditor - https://phabricator.wikimedia.org/T76544#1016724 (10Jdforrester-WMF) [01:02:49] 3VisualEditor: API design and documentation - https://phabricator.wikimedia.org/T40855#1016726 (10Jdforrester-WMF) p:5High>3Normal [01:06:43] 3VisualEditor, VisualEditor-MediaWiki-References: [Regression wmf13] Creating a citation without filling in a required field throws "Cannot read property 'createElement' of null" - https://phabricator.wikimedia.org/T78626#1016742 (10Jdforrester-WMF) 5Open>3Resolved [01:06:46] RoanKattouw, re https://gerrit.wikimedia.org/r/#/c/188706/1/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js - it certainly seems to work [01:07:08] because of the bindHandlers call in ve.init.mw.ViewPageTarget.prototype.activate, probably? [01:11:14] 3VisualEditor: Random bad stuff happening in VisualEditor after double-click on line end - https://phabricator.wikimedia.org/T88612#1016766 (10awight) [01:13:32] Krenair: Well passing undefined as a function to bind and then unbinding a function that was never bound probably doesn't actually have disastrous consequences I suppose [01:13:47] But I felt like maybe we shouldn't be doing that [01:16:28] (03PS2) 10Alex Monk: Unbind watch event handler in VPT when necessary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188706 [01:23:42] (03PS1) 10Mooeypoo: [wip] Refactor MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 [01:24:04] (03PS2) 10Mooeypoo: [wip] Refactor MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 [01:26:21] (03CR) 10jenkins-bot: [V: 04-1] [wip] Refactor MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 (owner: 10Mooeypoo) [01:27:12] 3VisualEditor: VisualEditor table editor would be improved by right-click support - https://phabricator.wikimedia.org/T88645#1016834 (10awight) 3NEW [01:27:44] 3VisualEditor: Random bad stuff happening in VisualEditor after double-click on line end - https://phabricator.wikimedia.org/T88612#1016841 (10Catrope) I saw Adam reproduce this on his machine. This is specific to Firefox, which behaves differently from Chrome. In Chrome, when you double-click at the end of the... [01:47:51] (03PS3) 10Mooeypoo: [wip] Refactor MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 [01:48:05] (03CR) 10Catrope: [C: 04-1] "Code looks fine, but I discovered that arrow keys in table cells are now broken, see inline comment." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [01:50:02] (03CR) 10jenkins-bot: [V: 04-1] [wip] Refactor MWMediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 (owner: 10Mooeypoo) [02:07:01] (03CR) 10Catrope: [C: 032] Unbind watch event handler in VPT when necessary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188706 (owner: 10Alex Monk) [02:08:50] (03CR) 10Catrope: "The table arrow key breakage also seems to involve CE and DM getting out of sync once you type, at least when I right-arrow out of a table" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec) [02:09:18] (03Merged) 10jenkins-bot: Unbind watch event handler in VPT when necessary [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188706 (owner: 10Alex Monk) [02:09:20] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/188716/ and its child. [02:10:41] (03CR) 10Catrope: [C: 032] build: Bump various devDependencies to latest [unicodejs] - 10https://gerrit.wikimedia.org/r/188716 (owner: 10Jforrester) [02:10:57] (03CR) 10Catrope: [C: 032] Tag v0.1.3 [unicodejs] - 10https://gerrit.wikimedia.org/r/188717 (owner: 10Jforrester) [02:11:20] (03Merged) 10jenkins-bot: build: Bump various devDependencies to latest [unicodejs] - 10https://gerrit.wikimedia.org/r/188716 (owner: 10Jforrester) [02:11:26] (03Merged) 10jenkins-bot: Tag v0.1.3 [unicodejs] - 10https://gerrit.wikimedia.org/r/188717 (owner: 10Jforrester) [02:13:28] (03PS1) 10Jforrester: Update UnicodeJS to v0.1.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188729 [02:15:06] RoanKattouw: ^^^ [02:15:13] (03CR) 10jenkins-bot: [V: 04-1] Update UnicodeJS to v0.1.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188729 (owner: 10Jforrester) [02:21:08] (03PS2) 10Jforrester: Update UnicodeJS to v0.1.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188729 [02:25:19] (03CR) 10Catrope: [C: 032] Update UnicodeJS to v0.1.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188729 (owner: 10Jforrester) [02:27:00] (03Merged) 10jenkins-bot: Update UnicodeJS to v0.1.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188729 (owner: 10Jforrester) [02:29:34] (03PS1) 10Krinkle: mw.ViewPageTarget: Use CSS instead of JS for DOM hiding/muting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188733 [02:30:25] (03CR) 10Jforrester: [C: 04-1] "What task does this fix?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188733 (owner: 10Krinkle) [02:31:52] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Use CSS instead of JS for DOM hiding/muting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188733 (owner: 10Krinkle) [02:49:13] (03CR) 10Ori.livneh: "Awesome. You have two names for the active state -- both "ve-active" and "ve-activated" -- is that intentional? Also, is it possible to tr" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188733 (owner: 10Krinkle) [02:52:20] (03PS2) 10Krinkle: mw.ViewPageTarget: Use CSS instead of JS for DOM hiding/muting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188733 (https://phabricator.wikimedia.org/T88590) [02:53:17] what's the difference between "active" and "activated"? [02:54:00] ori: This is explained in the commit [02:54:05] ori: see see file [02:54:19] active means editor has finished loading and is currently active [02:54:34] activated means it has been activated (by the user) and is either activating or active [02:54:40] active is new and sanely named [02:54:47] activated is pre-existing and illnamed [02:55:21] (03PS3) 10Krinkle: mw.ViewPageTarget: Use CSS instead of JS for DOM hiding/muting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188733 (https://phabricator.wikimedia.org/T88590) [02:58:43] (03CR) 10Krinkle: "@ori: ve-active is added once the editor has finished loading and is ready for user input, ve-activated is added immediately when the edit" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188733 (https://phabricator.wikimedia.org/T88590) (owner: 10Krinkle) [03:21:05] (03PS1) 10Catrope: Allow access to DM document during model->DOM conversion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188736 [03:21:07] (03PS1) 10Catrope: Pass original document in model->DOM tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188737 [03:24:35] (03PS4) 10Krinkle: mw.ViewPageTarget: Use CSS instead of JS for DOM hiding/muting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188733 (https://phabricator.wikimedia.org/T88590) [03:24:39] (03CR) 10Krinkle: mw.ViewPageTarget: Use CSS instead of JS for DOM hiding/muting (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188733 (https://phabricator.wikimedia.org/T88590) (owner: 10Krinkle) [03:32:41] (03PS1) 10Catrope: Remove InternalList#getItemHtmlQueue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188738 [03:32:43] (03PS1) 10Catrope: Add lookup-by-ID feature to InternalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188739 [03:33:16] (03PS2) 10Catrope: Remove InternalList#getItemHtmlQueue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188738 [03:33:18] (03PS2) 10Catrope: Add lookup-by-ID feature to InternalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188739 [03:35:01] (03CR) 10jenkins-bot: [V: 04-1] Remove InternalList#getItemHtmlQueue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188738 (owner: 10Catrope) [03:36:19] (03CR) 10jenkins-bot: [V: 04-1] Add lookup-by-ID feature to InternalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188739 (owner: 10Catrope) [03:52:16] (03Abandoned) 10Catrope: Add lookup-by-ID feature to InternalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188739 (owner: 10Catrope) [03:52:37] (03Abandoned) 10Catrope: Remove InternalList#getItemHtmlQueue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188738 (owner: 10Catrope) [04:10:02] (03PS1) 10Catrope: Support specifying reference contents with data-mw.body.id [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188741 (https://phabricator.wikimedia.org/T88650) [04:11:41] (03CR) 10jenkins-bot: [V: 04-1] Support specifying reference contents with data-mw.body.id [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188741 (https://phabricator.wikimedia.org/T88650) (owner: 10Catrope) [04:22:47] (03PS2) 10Catrope: Allow access to DM document during model->DOM conversion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188736 (https://phabricator.wikimedia.org/T88650) [04:22:56] (03PS2) 10Catrope: Pass original document in model->DOM tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188737 [04:23:05] (03PS3) 10Catrope: Pass original document in model->DOM tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188737 (https://phabricator.wikimedia.org/T88650) [09:02:48] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Remove extra empty lines to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186985 (owner: 10Amire80) [09:04:02] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187099 (owner: 10Amire80) [09:05:35] (03Merged) 10jenkins-bot: [BrowserTest] Remove extra empty lines to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186985 (owner: 10Amire80) [09:05:38] (03Merged) 10jenkins-bot: [BrowserTest] Simplify the Selenium selector for the Save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186906 (owner: 10Amire80) [09:06:07] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187100 (owner: 10Amire80) [09:06:12] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186937 (owner: 10Amire80) [09:06:16] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 (owner: 10Amire80) [09:09:05] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Shorten lines for clarity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186925 (owner: 10Amire80) [09:10:32] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Consistent names for variables that refer to down-arrow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186926 (owner: 10Amire80) [09:10:55] (03Merged) 10jenkins-bot: [BrowserTest] Shorten lines for clarity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186925 (owner: 10Amire80) [09:12:27] (03Merged) 10jenkins-bot: [BrowserTest] Consistent names for variables that refer to down-arrow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186926 (owner: 10Amire80) [09:13:30] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Show the complete insert pull-down in screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186927 (owner: 10Amire80) [09:15:08] (03Merged) 10jenkins-bot: [BrowserTest] Show the complete insert pull-down in screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186927 (owner: 10Amire80) [09:16:02] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Restore the indentation list screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186935 (owner: 10Amire80) [09:17:37] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Shorten all capture_screenshot lines [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186936 (owner: 10Amire80) [09:17:57] (03Merged) 10jenkins-bot: [BrowserTest] Restore the indentation list screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186935 (owner: 10Amire80) [09:19:25] (03Merged) 10jenkins-bot: [BrowserTest] Shorten all capture_screenshot lines [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186936 (owner: 10Amire80) [09:25:51] (03PS2) 10Amire80: [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 [09:27:29] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 (owner: 10Amire80) [09:31:04] (03PS3) 10Amire80: [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 [09:32:20] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 (owner: 10Amire80) [09:36:04] (03PS4) 10Amire80: [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 [10:15:24] 3VisualEditor: language screenshots scenarios cannot run because ve-ce-branchNode element is not found - https://phabricator.wikimedia.org/T88663#1017468 (10Amire80) 3NEW a:3Amire80 [10:16:10] (03PS1) 10Amire80: [BrowserTest] Click the editable area with .when_present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188778 (https://phabricator.wikimedia.org/T88663) [10:18:00] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Click the editable area with .when_present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188778 (https://phabricator.wikimedia.org/T88663) (owner: 10Amire80) [10:19:00] (03PS5) 10Amire80: [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 [10:19:52] (03Merged) 10jenkins-bot: [BrowserTest] Click the editable area with .when_present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188778 (https://phabricator.wikimedia.org/T88663) (owner: 10Amire80) [10:21:57] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 (owner: 10Amire80) [10:22:29] 3VisualEditor: language screenshots scenarios cannot run because ve-ce-branchNode element is not found - https://phabricator.wikimedia.org/T88663#1017494 (10Amire80) 5Open>3Resolved [10:23:01] (03PS5) 10Zfilipin: [BrowserTest] WIP: Restore the formula screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186937 (owner: 10Amire80) [10:23:46] (03Merged) 10jenkins-bot: [BrowserTest] Restore page settings language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 (owner: 10Amire80) [10:26:05] 3VisualEditor, MediaWiki-Vagrant: Vagrant VE role localsettings conflicts with VisualEditor's user option defaults - https://phabricator.wikimedia.org/T88665#1017497 (10brion) 3NEW [10:28:38] (03PS6) 10Amire80: [BrowserTest] Restore the formula screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186937 [10:29:57] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Restore the formula screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186937 (owner: 10Amire80) [10:31:42] (03Merged) 10jenkins-bot: [BrowserTest] Restore the formula screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186937 (owner: 10Amire80) [10:32:22] (03PS2) 10Zfilipin: [BrowserTest] Rename iframe to window_frame [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187099 (owner: 10Amire80) [10:33:14] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Rename iframe to window_frame [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187099 (owner: 10Amire80) [10:34:06] (03PS2) 10Zfilipin: [BrowserTest] Refactor offset_element and browser_zoom [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187100 (owner: 10Amire80) [10:34:52] (03Merged) 10jenkins-bot: [BrowserTest] Rename iframe to window_frame [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187099 (owner: 10Amire80) [10:40:38] (03PS3) 10Amire80: [BrowserTest] Refactor offset_element and browser_zoom [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187100 [10:41:17] 3VisualEditor, MediaWiki-Vagrant: VisualEditor on Vagrant gives "Error: Unknown dependency: schema.Edit" in JS console - https://phabricator.wikimedia.org/T88667#1017520 (10brion) 3NEW [10:43:04] 3VisualEditor, MediaWiki-Vagrant: VisualEditor on Vagrant gives "Error: Unknown dependency: schema.Edit" in JS console - https://phabricator.wikimedia.org/T88667#1017530 (10brion) [10:45:06] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Refactor offset_element and browser_zoom [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187100 (owner: 10Amire80) [10:47:10] (03Merged) 10jenkins-bot: [BrowserTest] Refactor offset_element and browser_zoom [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187100 (owner: 10Amire80) [10:58:49] 3WikiEditor, Language-Engineering: Toolbar buttons misrendering in wikitext editor in Arabic Wikipedia when user language set to LTR language - https://phabricator.wikimedia.org/T88463#1017545 (10Schnark) This doesn't happen at ar.wikibooks, so I guess that ar.wikipedia broke this in [[https://ar.wikipedia.org/w... [11:37:36] i'm coming with a bunch of questions :) [11:37:49] 1. http://www.mediawiki.org/wiki/VisualEditor latest status info is from november - any new status coming ? [11:38:28] 2. at the bottom of http://www.mediawiki.org/wiki/VisualEditor/Portal there's "on the help desk, or in the IRC help channel" link to http://www.mediawiki.org/wiki/VisualEditor/Portal/New_users - the latter is not very useful... [11:39:28] 3. which mw version[s] will work with latest visualeditor ? [11:42:17] hi Richlv [11:43:14] latest visualeditor probably needs latest (master) version of mediawiki, since we're often forced to add things to mediawiki that we need [11:44:33] development definitely hasn't stopped in november, not sure where the news are - James_F|Away will be the best person to anwer this, when he's online (in ~4-5 hours) [11:45:25] Richlv: here's a piece of news from this week :) https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#VisualEditor_News_2015.E2.80.94.231 [11:48:12] MatmaRex, thanks. so 24.1 will not work, right ? [11:50:08] Richlv: honestly, i'm not sure. we never test that. we do have VE versions for each major mediawiki release, though, if you prefer the convenience of having a "stabler" version of mediawiki [11:51:00] https://www.mediawiki.org/wiki/Special:ExtensionDistributor/VisualEditor [12:17:39] (03PS4) 10Bartosz Dziewoński: Replace 104px by 102px for width of thumbnail div [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [12:17:53] (03PS5) 10Bartosz Dziewoński: Replace 104px by 102px for width of thumbnail div [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [12:17:59] (03CR) 10Bartosz Dziewoński: [C: 031] Replace 104px by 102px for width of thumbnail div [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [12:25:08] (03CR) 10Bartosz Dziewoński: [C: 032] Use sprite as button icon where possible [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186177 (owner: 10Gerrit Patch Uploader) [12:25:13] (03Merged) 10jenkins-bot: Use sprite as button icon where possible [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186177 (owner: 10Gerrit Patch Uploader) [12:27:46] (03PS1) 10Amire80: [BrowserTest] Update the definition of formula_image element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188795 [12:30:25] (03PS2) 10Bartosz Dziewoński: Use "obj.hasOwnProperty( prop )" instead of "prop in obj" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184619 (https://phabricator.wikimedia.org/T86643) (owner: 10Gerrit Patch Uploader) [12:31:51] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [12:34:12] (03PS3) 10Bartosz Dziewoński: Use "obj.hasOwnProperty( prop )" instead of "prop in obj" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184619 (https://phabricator.wikimedia.org/T86643) (owner: 10Gerrit Patch Uploader) [12:34:45] (03CR) 10Bartosz Dziewoński: [C: 032] Use "obj.hasOwnProperty( prop )" instead of "prop in obj" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184619 (https://phabricator.wikimedia.org/T86643) (owner: 10Gerrit Patch Uploader) [12:35:34] 3WikiEditor: WikiEditor interprets names of predefined Object prototype methods as valid language names - https://phabricator.wikimedia.org/T86643#1017726 (10matmarex) [12:35:35] 3WikiEditor: WikiEditor interprets names of predefined Object prototype methods as valid language names - https://phabricator.wikimedia.org/T86643#973273 (10matmarex) [12:37:38] (03Merged) 10jenkins-bot: Use "obj.hasOwnProperty( prop )" instead of "prop in obj" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184619 (https://phabricator.wikimedia.org/T86643) (owner: 10Gerrit Patch Uploader) [12:39:24] 3WikiEditor: WikiEditor interprets names of predefined Object prototype methods as valid language names - https://phabricator.wikimedia.org/T86643#1017748 (10matmarex) 5Open>3Resolved Not a security issue, thankfully. [12:41:31] (03CR) 10Bartosz Dziewoński: [C: 032] Allow a resizeable toolbar index [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187339 (owner: 10Gerrit Patch Uploader) [12:44:04] (03Merged) 10jenkins-bot: Allow a resizeable toolbar index [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187339 (owner: 10Gerrit Patch Uploader) [12:44:35] 3MediaWiki-Page-editing: page moves leave an un-undoable revision - https://phabricator.wikimedia.org/T88680#1017772 (10Martijn_Hoekstra) [12:47:44] 3MediaWiki-Page-editing: page moves leave an un-undoable revision - https://phabricator.wikimedia.org/T88680#1017774 (10Martijn_Hoekstra) 5Open>3Invalid a:3Martijn_Hoekstra Duplicate to T6433 I don't know how to mark duplicates. [12:49:23] 3MediaWiki-Page-editing: page moves leave an un-undoable revision - https://phabricator.wikimedia.org/T88680#1017786 (10PleaseStand) [12:52:52] 3MediaWiki-Page-editing: page moves leave an un-undoable revision - https://phabricator.wikimedia.org/T88680#1017807 (10PleaseStand) >>! In T88680#1017774, @Martijn_Hoekstra wrote: > Duplicate to T6433 I don't know how to mark duplicates. Use "Merge Duplicates In" on the other task. [13:00:47] MatmaRex, yeah, but i guess those are less useful to test & report issues for [13:02:13] yeah, probably :( [13:08:25] 3OOjs-UI: [Suggestion for improvement] The difference between the background colors for disabled button and selected button is not much visibly apparent now - https://phabricator.wikimedia.org/T88592#1017834 (10matmarex) [13:08:26] 3WMF-Design, UI-Standardization, OOjs-UI: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1017833 (10matmarex) [13:21:05] 3VisualEditor: VisualEditor: Google Chrome's auto-translate of the contentEditable surface is very confusing for users - https://phabricator.wikimedia.org/T59124#1017852 (10NicoV) According to Drongou, this "google problem" would also explain that in the following edit, snowmen were added by VE to the text. I do... [14:14:05] (03PS6) 10Gerrit Patch Uploader: Support fallback languages for icons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) [14:14:08] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) (owner: 10Gerrit Patch Uploader) [16:20:26] MatmaRex: Is T88592 not just a duplicate of T88038? [16:21:37] James_F: it's somewhat different, but perhaps close enough. [16:21:58] i've been meaning to file a bug about overuse of shades of grey myself [16:22:00] 3OOjs-UI: [Suggestion for improvement] The difference between the background colors for disabled button and selected button is not much visibly apparent now - https://phabricator.wikimedia.org/T88592#1018158 (10Jdforrester-WMF) [16:22:02] 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1018159 (10Jdforrester-WMF) [16:22:29] 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1002931 (10Jdforrester-WMF) I've merged in {T88592} because they're covering the same issue in different terms. [16:23:24] 3VisualEditor: VisualEditor table editor would be improved by right-click support - https://phabricator.wikimedia.org/T88645#1018167 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF We purposefully don't use contextual menus, as we're a mobile-parity editor. [16:24:40] i mean, look at this - http://i.imgur.com/b3ByAmM.png - and tell me what is the state of every button [16:25:02] 3VisualEditor, MediaWiki-Vagrant: VisualEditor on Vagrant gives "Error: Unknown dependency: schema.Edit" in JS console - https://phabricator.wikimedia.org/T88667#1018174 (10Jdforrester-WMF) You need to load WikimediaEvents if you've got EventLogging installed for VisualEditor to work. [16:25:45] Active unselected; inactive; active selected; active hoverred. [16:25:48] ;-) [16:47:46] (03PS26) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [16:48:55] 3VisualEditor, VisualEditor-Tables: Be able to re-order the columns or rows of a table by dragging to to another position - https://phabricator.wikimedia.org/T88694#1018205 (10Jdforrester-WMF) 3NEW [16:49:22] (03PS1) 10Bartosz Dziewoński: Deprecate GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/188826 [16:49:53] hi James_F [16:49:57] Hey. [16:50:16] just been working on the wikieditor instrumentation again [16:50:23] Right. [16:50:35] done saveAttempt, abort... think I've just got the saveSuccess/saveFailure left to do [16:51:27] Still not 100% happy about the session ID being in the URL :/ [16:51:49] Can we do it as POST rather than GET? [16:52:07] what, clicking the edit link? [16:52:13] Yeah. [16:52:15] ew. [16:52:22] It's what JS is for. ;-) [16:53:04] it probably assumes posts are saves, etc. [16:53:08] (03CR) 10Bartosz Dziewoński: SelectWidget: listbox wrapper role, state on contents (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [16:53:20] Fun. [16:53:26] I haven't checked that though [16:53:55] The other issue is that if you start two edit sessions from the same page opening it in a new tab, the edit session ID should differ. [16:54:02] Which is minor, but… [16:54:43] sigh [16:56:06] (03PS4) 10Bartosz Dziewoński: SelectWidget: 'listbox' wrapper role, 'aria-selected' state on contents [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [16:56:26] (03CR) 10Bartosz Dziewoński: [C: 032] "Tweaked code style only." [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [16:58:34] (03Merged) 10jenkins-bot: SelectWidget: 'listbox' wrapper role, 'aria-selected' state on contents [oojs/ui] - 10https://gerrit.wikimedia.org/r/187655 (https://phabricator.wikimedia.org/T88091) (owner: 10TheDJ) [17:00:22] James_F|Away, I'm not sure we have a hook for the result of a save attempt [17:00:33] (03CR) 10Bartosz Dziewoński: "Maybe we should have a TextInputWidget subclass for handling numeric inputs, with fancy step buttons and such?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/188425 (owner: 10Ricordisamoa) [17:02:08] 3OOjs-UI: ToggleSwitchWidget requires to be TabIndexedElement - https://phabricator.wikimedia.org/T88080#1018249 (10matmarex) a:3matmarex [17:02:21] (03PS1) 10Bartosz Dziewoński: ToggleSwitchWidget: Add TabIndexedElement mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/188828 (https://phabricator.wikimedia.org/T88080) [17:08:01] 3OOjs-UI: RadioSelectWidget is not accessible - https://phabricator.wikimedia.org/T88082#1018279 (10matmarex) a:3matmarex [17:08:05] (03PS1) 10Bartosz Dziewoński: RadioOptionWidget: Make it a