[00:03:04] 3VisualEditor: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1021988 (10Ryasmeen) 3NEW [00:03:29] Eloquence: ^^ [00:04:22] 3VisualEditor: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1021997 (10Ryasmeen) [00:08:39] (03CR) 10Bartosz Dziewoński: "Caused T88867." [oojs/ui] - 10https://gerrit.wikimedia.org/r/179598 (owner: 10Esanders) [00:11:29] 3VisualEditor: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1022009 (10matmarex) This is how T85844 was fixed. [00:15:45] (03CR) 10Trevor Parscal: [C: 04-1] Refactor MWMediaSearchWidget to use a queue and providers (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [00:24:18] mooeypoo, why do we have ve.ce.MWBlockImageNode.static.cssClasses = { [00:24:18] default: { [00:24:18] left: 'mw-halign-left', [00:24:18] right: 'mw-halign-right', [00:24:19] center: 'mw-halign-center', [00:24:21] none: 'mw-halign-none' [00:24:23] }, [00:24:25] none: { [00:24:27] left: 'mw-halign-left', [00:24:29] right: 'mw-halign-right', [00:24:31] center: 'mw-halign-center', [00:24:33] none: 'mw-halign-none' [00:24:35] } [00:24:37] }; ? [00:25:03] if they're always the same, why not just list once? [00:25:07] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#1022067 (10Prtksxna) @TrevorParscal you had some thoughts you wanted to share on this. Looking at the review on the patch it seems that using `MutationObserver` isn't an option at all. [00:29:30] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#1022078 (10Esanders) Our thoughts were to provide a central API through OO.ui.Element by which it emitted attach and detach events. In the case of MutationObserver that would've use... [00:36:28] edsanders, mooey|away: Maybe they were different once? [00:37:00] (03CR) 10Catrope: "I believe so. He didn't change when the window is made visible (the .toggle( true ) call)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 (owner: 10Trevor Parscal) [00:38:05] 3VisualEditor: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1022093 (10Esanders) Yes - this was the only way to fix the scrolling bug. [00:38:12] (03PS1) 10Cmcmahon: [BrowserTest] WIP make cite test pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189142 [00:43:20] (03PS1) 10Catrope: Use css class instead of jquery show/hide [extensions/VisualEditor] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189144 (https://phabricator.wikimedia.org/T87420) [00:44:35] (03CR) 10Mooeypoo: Refactor MWMediaSearchWidget to use a queue and providers (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [00:46:11] (03PS17) 10Mooeypoo: Refactor MWMediaSearchWidget to use a queue and providers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 (https://phabricator.wikimedia.org/T78161) [00:47:22] 3VisualEditor: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1022112 (10Catrope) We could probably improve the timing of things: right now there seems to be a 250ms delay between the scrollbar going away and the p... [00:48:03] RoanKattouw, edsanders|away they were different once upon a time. [00:58:57] (03Abandoned) 10Prtksxna: TextInputWidget: Use MutationObserver instead of DOMNodeInsertedIntoDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (https://phabricator.wikimedia.org/T64174) (owner: 10Prtksxna) [00:59:58] ryasmeen: Both fixes now scheduled to be deployed to wmf16 on Monday at 4pm https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20150210T0000 [01:00:24] cool, Thanks RoanKattouw! [01:01:02] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#1022155 (10Prtksxna) [01:01:34] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#655254 (10Prtksxna) Thanks for the clarification @Esanders! I've abandoned the patch. [01:08:03] (03PS8) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [01:12:29] 3WikiEditor: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1022200 (10brion) 3NEW a:3brion [01:13:53] (03CR) 10Trevor Parscal: [C: 032] Refactor MWMediaSearchWidget to use a queue and providers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [01:14:41] (03CR) 10Paladox: "@Mattflaschen please could you rebase this because i have tryed it seveal times but keeps deleting the changes and adds the changes from g" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 (owner: 10Paladox) [01:15:27] (03PS1) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189151 [01:15:40] (03Merged) 10jenkins-bot: Refactor MWMediaSearchWidget to use a queue and providers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [01:15:44] (03Abandoned) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189151 (owner: 10Paladox) [01:16:08] (03CR) 10Paladox: "It seems it wants to auto merge." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 (owner: 10Paladox) [01:17:21] (03PS9) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [01:18:02] (03PS10) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [01:19:27] (03PS9) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 (https://phabricator.wikimedia.org/T37342) [01:25:23] (03PS11) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [01:27:45] (03PS12) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [01:27:48] (03PS1) 10Paladox: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189155 [01:27:51] (03PS1) 10Paladox: Merge branch 'master' into HEAD [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189156 [01:27:54] (03CR) 10jenkins-bot: [V: 04-1] Merge branch 'master' into HEAD [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189156 (owner: 10Paladox) [01:28:05] (03Abandoned) 10Paladox: Merge branch 'master' into HEAD [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189156 (owner: 10Paladox) [01:30:41] (03PS13) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [01:31:24] (03PS14) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [01:32:19] (03Abandoned) 10Paladox: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189155 (owner: 10Paladox) [01:34:53] 3VisualEditor: Media Settings - Infinite loop when an image is inserted - https://phabricator.wikimedia.org/T88764#1022267 (10Etonkovidova) Betalabs looks good. Testing notes: - check for a search with many search results, e.g. 'lilac', 'cow' - check for a search with few results - 'After Cornelis Cornelisz. va... [01:35:59] mooeypoo: https://phabricator.wikimedia.org/T88764 looks good :) [01:38:16] etonkovidova, yay [01:38:29] etonkovidova, you can also test "eu referendum jdforrester" for 1 result [01:38:45] will do [01:39:33] or "theresnowayanyonenamedafilethisname" for no results. [01:39:43] ;) [01:43:03] 3VisualEditor-MediaWiki, VisualEditor: Handle api data.error values and reduce getProp() defensive - https://phabricator.wikimedia.org/T88878#1022268 (10Krinkle) 3NEW [01:43:13] 3VisualEditor-MediaWiki, VisualEditor: Handle api data.error values and reduce getProp() defense - https://phabricator.wikimedia.org/T88878#1022277 (10Krinkle) [01:43:40] RoanKattouw_away: ^ [01:47:23] 3VisualEditor-MediaWiki-References, VisualEditor, VisualEditor-MediaWiki: [Regression pre-wmf14] While trying to open Re-use Reference dialog immediately after inserting a citation (not basic reference), throws the TypeError: Cannot read property 'length' of null and the newly added citation does not appear in the... [01:48:24] 3MediaWiki-ResourceLoader: ResourceLoader's mw.templates Map is full of empty objects - https://phabricator.wikimedia.org/T88879#1022282 (10Spage) 3NEW [02:01:28] 3MediaWiki-ResourceLoader: ResourceLoader's mw.templates Map is full of empty objects - https://phabricator.wikimedia.org/T88879#1022306 (10Spage) (gerritbot didn't update the task as I would expect) My patch is https://gerrit.wikimedia.org/r/189158 [02:09:07] 3VisualEditor: [Regression pre-wmf17]The default search term is not getting highlighted when you open the media search dialog - https://phabricator.wikimedia.org/T88881#1022316 (10Ryasmeen) 3NEW a:3Catrope [02:09:21] 3VisualEditor: [Regression pre-wmf17]The default search term is not getting highlighted when you open the media search dialog - https://phabricator.wikimedia.org/T88881#1022324 (10Ryasmeen) p:5Triage>3Normal [02:09:34] RoanKattouw: ^^ [02:09:51] 3WikiEditor: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1022326 (10brion) Tracked the workaround code down to these bugs reported against IE 8 back years ago: * https://phabricator.wikimedia.org/T25485 * https://phabricator.wikimedia.org/T25061 However I ca... [02:10:01] (03PS1) 10Catrope: MWMediaDialog: Focus the right thing on ready, depending on the panel shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189160 (https://phabricator.wikimedia.org/T88881) [02:11:24] (03CR) 10Catrope: "Caused https://phabricator.wikimedia.org/T88881 , see inline comment" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188725 (https://phabricator.wikimedia.org/T78161) (owner: 10Mooeypoo) [02:12:14] (03PS2) 10Catrope: MWMediaDialog: Focus the right thing on ready, depending on the panel shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189160 (https://phabricator.wikimedia.org/T88881) [02:18:46] (03PS1) 10Brion VIBBER: Skip an old IE 8 bug workaround in WikiEditor on IE 11/Spartan [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189162 (https://phabricator.wikimedia.org/T88875) [02:19:45] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: ve-ce-focusableNode-dropMarker is displayed as a horizontal line when Gallery is dragged-drop to Media Caption - https://phabricator.wikimedia.org/T75528#1022342 (10Etonkovidova) Those thin lines are visible only in VE - they are not preserved upon savin... [02:20:02] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: ve-ce-focusableNode-dropMarker is displayed as a horizontal line when Gallery is dragged-drop to Media Caption - https://phabricator.wikimedia.org/T75528#1022343 (10Etonkovidova) p:5Triage>3Low [02:23:16] 3VisualEditor-EditingTools, VisualEditor: Cite inspector does not disappear upon clicking Insert, prevents page save - https://phabricator.wikimedia.org/T75748#1022346 (10Etonkovidova) The issue is not reproducible anymore. [02:23:30] 3VisualEditor-EditingTools, VisualEditor: Cite inspector does not disappear upon clicking Insert, prevents page save - https://phabricator.wikimedia.org/T75748#1022347 (10Etonkovidova) 5Open>3Resolved [02:28:08] Krinkle: https://gerrit.wikimedia.org/r/189160 [02:31:09] 3VisualEditor-EditingTools, VisualEditor: small race condition in Links inspector - https://phabricator.wikimedia.org/T75421#1022365 (10Etonkovidova) Re-checked in betalabs - there is no noticeable delay in displaying "External link/New page" overlay(some performance improvements were made). [02:31:24] 3VisualEditor-EditingTools, VisualEditor: small race condition in Links inspector - https://phabricator.wikimedia.org/T75421#1022366 (10Etonkovidova) 5Open>3Resolved [02:31:31] (03CR) 10Krinkle: [C: 031] "We could additionally use profile().versionBase or versionNumber. That's a general coding practice for $.client usage in general. It shoul" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189162 (https://phabricator.wikimedia.org/T88875) (owner: 10Brion VIBBER) [02:40:48] (03CR) 10Krinkle: [C: 032] MWMediaDialog: Focus the right thing on ready, depending on the panel shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189160 (https://phabricator.wikimedia.org/T88881) (owner: 10Catrope) [02:42:26] (03Merged) 10jenkins-bot: MWMediaDialog: Focus the right thing on ready, depending on the panel shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189160 (https://phabricator.wikimedia.org/T88881) (owner: 10Catrope) [06:28:26] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Remove window isolation [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 [06:28:37] (03PS3) 10Trevor Parscal: Liberation from the oppressive this.$ regime [oojs/ui] - 10https://gerrit.wikimedia.org/r/188957 [12:03:20] 3VisualEditor: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1022519 (10Esanders) Probably. The redraw is debounced so continuous resizing can work, but in this case we could trigger an instant redraw. And probabl... [14:07:46] (03PS1) 10Mvolz: Bug fixes: fix status response codes [services/citoid] - 10https://gerrit.wikimedia.org/r/189201 (https://phabricator.wikimedia.org/T88884) [14:24:47] (03PS2) 10Mvolz: Bug fixes: fix status response codes [services/citoid] - 10https://gerrit.wikimedia.org/r/189201 (https://phabricator.wikimedia.org/T88884) [14:59:53] 3Wikimedia-Site-requests, Wikimedia-Extension-setup, VisualEditor: Enable VisualEditor in namespaces 4 (Viquipèdia) and 102 (Viquiprojecte) of cawiki - https://phabricator.wikimedia.org/T88896#1022623 (10Gerardduenas) 3NEW [15:06:16] 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1022631 (10matmarex) [15:08:47] 3VisualEditor: VisualEditor: Ctrl-v of text into a pre-formatted area ends up with
added to each line - https://phabricator.wikimedia.org/T75433#1022632 (10Etonkovidova) There are several issue with copy/paste into pre-formatted area - e.g.https://phabricator.wikimedia.org/T74456. Prioritizing for now as low. [15:08:56] 3VisualEditor: VisualEditor: Ctrl-v of text into a pre-formatted area ends up with
added to each line - https://phabricator.wikimedia.org/T75433#1022633 (10Etonkovidova) p:5Triage>3Low [15:09:10] 3VisualEditor-ContentEditable, VisualEditor: Visual Editor: wmf5 - cannot paste text with new lines into preformatted area - https://phabricator.wikimedia.org/T74456#1022635 (10Etonkovidova) p:5Triage>3Low [15:16:20] 3OOjs-UI: PopupButtonWidget cannot be activated by keyboard - https://phabricator.wikimedia.org/T87693#1022639 (10matmarex) [15:16:21] 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1022640 (10matmarex) [15:16:31] 3OOjs-UI: PopupButtonWidget cannot be activated by keyboard - https://phabricator.wikimedia.org/T87693#996856 (10matmarex) [15:16:32] 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1003856 (10matmarex) [15:17:13] 3Wikimedia-Site-requests, Wikimedia-Extension-setup, VisualEditor: Enable VisualEditor in namespaces 4 (Viquipèdia) and 102 (Viquiprojecte) of cawiki - https://phabricator.wikimedia.org/T88896#1022651 (10Glaisher) Already enabled in ns 102. Could you provide a link to the community discussion about this? [15:17:34] 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1022653 (10matmarex) a:3matmarex [15:17:38] 3Wikimedia-Site-requests, VisualEditor: Enable VisualEditor in namespaces 4 (Viquipèdia) and 102 (Viquiprojecte) of cawiki - https://phabricator.wikimedia.org/T88896#1022654 (10Glaisher) [15:21:08] (03PS1) 10Mvolz: Bug T88897 Fix: Add popPending to error case [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88887) [15:27:15] (03CR) 10Glaisher: Bug T88897 Fix: Add popPending to error case (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88887) (owner: 10Mvolz) [15:27:45] (03PS2) 10Glaisher: Fix: Add popPending to error case [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) (owner: 10Mvolz) [15:30:39] (03PS1) 10Mvolz: Fix for bug T87869: Add mobile to targets [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189208 (https://phabricator.wikimedia.org/T87869) [15:35:14] (03CR) 10Mvolz: "Whoops! Sorry about that :). Thanks for fixing." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) (owner: 10Mvolz) [15:36:16] 3Wikimedia-Site-requests, VisualEditor: Enable VisualEditor in namespaces 4 (Viquipèdia) and 102 (Viquiprojecte) of cawiki - https://phabricator.wikimedia.org/T88896#1022692 (10Gerardduenas) Community pettition / consensus: https://ca.wikipedia.org/wiki/Viquip%C3%A8dia:La_taverna#Activaci.C3.B3_del_visualeditor_... [15:36:26] 3MediaWiki-Page-editing, MediaWiki-extensions-CharInsert: Charinsert gadget - https://phabricator.wikimedia.org/T88887#1022693 (10He7d3r) [15:41:06] So apparently even if you own a project, you still have to watch it in order to get email notifications for new tasks. [15:41:07] Oops [15:41:17] I swear I wasn't ignoring the mounting number of bugs. [15:42:15] 3Wikimedia-Site-requests, VisualEditor: Enable VisualEditor in namespaces 4 (Project) and 12 (Help) - https://phabricator.wikimedia.org/T88896#1022697 (10Gerardduenas) [15:43:32] 3Wikimedia-Site-requests, VisualEditor: Enable VisualEditor in namespaces 4 (Project) and 12 (Help) - https://phabricator.wikimedia.org/T88896#1022623 (10Gerardduenas) @Glaisher: There you have the community petition. They also asked the activation in ns 12 (help). thanks! [15:44:19] 3Wikimedia-Site-requests, VisualEditor: Enable VisualEditor in namespaces 4 (Project) - https://phabricator.wikimedia.org/T88896#1022701 (10Gerardduenas) [15:59:06] 3Wikimedia-Site-requests, VisualEditor: Enable VisualEditor in Project namespace (ns 4) at cawiki - https://phabricator.wikimedia.org/T88896#1022718 (10Glaisher) [16:18:30] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1022732 (10He7d3r) [16:20:01] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1022450 (10He7d3r) I have the gadget enabled, however the code from https://en.wikisource.org/wiki/MediaWiki:Gadget-charinsert.js doesn't seems to be loa... [16:20:38] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1022735 (10Ineuw) Testing by disabling all gadgets, and then re-enabling them one by one is a good idea and will do so immediately. It certainly is withi... [16:35:00] (03PS1) 10Mvolz: Fix: anchor PMC and PMCIDs to beginning of string [services/citoid] - 10https://gerrit.wikimedia.org/r/189217 (https://phabricator.wikimedia.org/T88898) [16:39:11] mvolz, hey [16:45:02] ahh chaos [16:45:21] i'm now getting weird ve errors with cite news and cite journal but not with cite web [16:45:26] also hi [16:45:27] :) [17:07:09] 3TemplateData: Add parameter for namespace of wiki-page-name type - https://phabricator.wikimedia.org/T88900#1022768 (10eranroz) 3NEW [17:12:35] James_F|Away: Are you on Sentry yet? There's a VE error! [17:22:33] (03CR) 10Mvolz: [C: 032] Bug fixes: fix status response codes [services/citoid] - 10https://gerrit.wikimedia.org/r/189201 (https://phabricator.wikimedia.org/T88884) (owner: 10Mvolz) [17:22:42] (03Merged) 10jenkins-bot: Bug fixes: fix status response codes [services/citoid] - 10https://gerrit.wikimedia.org/r/189201 (https://phabricator.wikimedia.org/T88884) (owner: 10Mvolz) [17:23:00] (03CR) 10Mvolz: [C: 032] Fix: anchor PMC and PMCIDs to beginning of string [services/citoid] - 10https://gerrit.wikimedia.org/r/189217 (https://phabricator.wikimedia.org/T88898) (owner: 10Mvolz) [17:23:09] (03Merged) 10jenkins-bot: Fix: anchor PMC and PMCIDs to beginning of string [services/citoid] - 10https://gerrit.wikimedia.org/r/189217 (https://phabricator.wikimedia.org/T88898) (owner: 10Mvolz) [17:30:37] Corruption alert: visualeditor-needcheck on lawiki: https://la.wikipedia.org/?diff=2834412 [17:30:37] Corruption alert: visualeditor-needcheck on hewiki: https://he.wikipedia.org/?diff=16522199 [17:30:37] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68435969 [17:30:37] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70737168 [17:31:34] 3MediaWiki-Page-editing: Links in autogenerated summary in page histories may point to wrong section or to nowhere - https://phabricator.wikimedia.org/T4831#1022811 (10Tacsipacsi) [17:36:52] 3MediaWiki-Page-editing: Section edit conflict expands edit box to entire article - https://phabricator.wikimedia.org/T6745#1022825 (10Tacsipacsi) [17:38:18] 3MediaWiki-Page-editing: Automatical merge of conflicting non-section edits to unintersecting sets of sections - https://phabricator.wikimedia.org/T2980#36693 (10Tacsipacsi) [17:53:11] edsanders: two trivial things for you to review. also i think the extension is broken on master. [17:53:32] edsanders: also extension is broken for me on master, notsure if it is for you or not [17:54:03] mvolz, sure - are you working on the new citation workflow? [17:54:09] nooope [17:54:11] old one [17:54:17] it has bugs. [17:54:43] (03CR) 10Esanders: [C: 04-1] Fix for bug T87869: Add mobile to targets (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189208 (https://phabricator.wikimedia.org/T87869) (owner: 10Mvolz) [17:57:08] (03PS2) 10Mvolz: Fix for bug T87869: Add mobile to targets [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189208 (https://phabricator.wikimedia.org/T87869) [17:58:10] (03CR) 10Esanders: [C: 04-1] Fix: Add popPending to error case (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) (owner: 10Mvolz) [17:58:20] mvolz, have you seen the designs? [18:00:15] edsanders: [18:00:21] yup, it's on my agenda [18:00:28] just catching up on a lot of bugs this weekend [18:00:43] apparently you have to watch a project to get notified of them [18:00:59] so bugs were accumulating in my project and i wasn't getting notified :/ [18:01:25] ah - yeah [18:02:39] well it's a fairly sizeable piece of work so let me know if you need any help [18:03:09] (03CR) 10Esanders: [C: 032] Fix for bug T87869: Add mobile to targets [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189208 (https://phabricator.wikimedia.org/T87869) (owner: 10Mvolz) [18:03:25] (03Merged) 10jenkins-bot: Fix for bug T87869: Add mobile to targets [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189208 (https://phabricator.wikimedia.org/T87869) (owner: 10Mvolz) [18:05:05] (03PS5) 10Esanders: Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 [18:05:07] (03PS1) 10Esanders: Fix center alignment of alignable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189229 [18:05:09] (03PS1) 10Esanders: Mix alignable into block images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189230 [18:05:11] (03PS1) 10Esanders: Make CSS classes in alignable configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189231 [18:05:40] edsanders: what's the time lapse for things getting updated on beta? how continuous is it? [18:06:19] 3Citoid, Mobile-Web, VisualEditor, Editing: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1022880 (10Mvolz) Mobile has been added as target but it has not been tested on a mobile device. [18:06:34] I think Beta is instant [18:06:37] at least for VE [18:06:58] (03CR) 10jenkins-bot: [V: 04-1] Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [18:07:00] (03CR) 10jenkins-bot: [V: 04-1] Mix alignable into block images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189230 (owner: 10Esanders) [18:08:45] http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version [18:08:48] (03CR) 10jenkins-bot: [V: 04-1] Make CSS classes in alignable configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189231 (owner: 10Esanders) [18:10:17] (03CR) 10Mvolz: Fix: Add popPending to error case (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) (owner: 10Mvolz) [18:24:34] (03PS2) 10Esanders: Mix alignable into block images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189230 [18:24:36] (03PS2) 10Esanders: Make CSS classes in alignable configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189231 [18:24:38] (03PS6) 10Esanders: Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 [18:31:16] (03PS3) 10Bartosz Dziewoński: ToggleSwitchWidget: Accessibility improvements [oojs/ui] - 10https://gerrit.wikimedia.org/r/188828 (https://phabricator.wikimedia.org/T88079) [18:31:18] (03PS1) 10Bartosz Dziewoński: Refactor clickability of buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) [18:40:23] edsanders: verify my wild ideas. should we have a PressableElement mixin in OOUI, that would capture all the weird ways one can press a button (mouse click, keyboard 'enter' keypress, etc.), and emit a unified 'action' event? i just wrote https://gerrit.wikimedia.org/r/#/c/189236/ and we duplicate this a lot [18:42:13] (03CR) 10Esanders: Fix: Add popPending to error case (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) (owner: 10Mvolz) [18:48:09] MatmaRex, where do we duplicate it? [18:50:46] edsanders: clickable things that are not buttons. ToggleSwitchWidget most glaringly, but also DropdownWidget, OptionWidgets [18:51:03] or rather, SelectWidget and OptionWidget do not currently duplicate it, but should. they don't handle keyboard at all [18:51:09] do they always handle click events in the same way [18:51:22] e.g. drag out [18:51:24] they don't, but they should [18:51:28] nope [18:51:40] try the ButtonSelectWidget and ButtonGroupWidget in deom [19:01:53] (03PS2) 10Bartosz Dziewoński: MWCategoryItemWidget: Update CSS for OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189117 [19:04:50] (03PS3) 10Bartosz Dziewoński: MWCategoryItemWidget: Update CSS for OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189117 [19:47:33] (03PS1) 10Bartosz Dziewoński: MediaWiki theme: Consistent toggle button 'active' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/189238 [19:59:04] 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1022938 (10matmarex) 3NEW [19:59:58] 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1003856 (10matmarex) * ToggleButtonWidget and ButtonGroupWidget are fixed by https://gerrit.wikimedia.org/r/189236. * DropdownWidget is T87705. * ButtonSelectWidget is T88906. [20:00:10] 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1022938 (10matmarex) [20:00:12] 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1022951 (10matmarex) [20:03:56] 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1022963 (10matmarex) [20:03:57] 3OOjs-UI: ButtonWidget icon only has no visual focused state, thought it can be focused - https://phabricator.wikimedia.org/T87691#1022962 (10matmarex) [20:06:06] (03PS6) 10Bartosz Dziewoński: TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [20:11:56] (03PS7) 10Bartosz Dziewoński: TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [20:12:09] (03CR) 10Bartosz Dziewoński: [C: 032] TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [20:15:03] (03Merged) 10jenkins-bot: TextInputWidget: Add required attribute on the basis of required config [oojs/ui] - 10https://gerrit.wikimedia.org/r/187452 (https://phabricator.wikimedia.org/T87707) (owner: 10Prtksxna) [20:31:06] 3OOjs-UI: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari - https://phabricator.wikimedia.org/T69156#1022986 (10matmarex) Patch was reverted, so what's the status of this? We need to do the same again, but without `:focusable`? I looked at the source code and `:focusable` can be reasonably app... [20:39:28] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1022994 (10Ineuw) Disabling all gadgets and just re-enabling the Charinsert has no effect. [20:42:41] 3OOjs-UI: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari - https://phabricator.wikimedia.org/T69156#1023002 (10Esanders) Can we do it using observe and fixup, e.g. listen to focusin on the body, and if the event originates form outside the dialog, move it back inside the dialog. [21:03:03] 3OOjs-UI: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari - https://phabricator.wikimedia.org/T69156#1023021 (10matmarex) The reverted patch did, in fact, do something like that. But we still need to find the place inside the dialog where we want to move the focus, and it used `:focusable` for t... [21:11:44] 3OOjs-UI: TextInputWidget (indicator)‎ has 'required' state, so should use required attribute on the native element - https://phabricator.wikimedia.org/T87707#1023027 (10matmarex) 5Open>3Resolved [21:24:18] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1023031 (10GOIII) Take a few days off and everything goes to pieces... undid this addition and the CharInsert bar is back... https://en.wikisource.org/... [21:24:42] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1023033 (10matmarex) The gadget works for me. @Ineuw, when you're viewing a page where the gadget doesn't load, can you open your browser's JavaScript c... [21:32:57] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1023034 (10Ineuw) matmarex, the solution by George Orwell III was to remove the "Jan 23 Krinkle toolbar bit addition and dependency changes" and the Char... [21:34:23] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1023035 (10He7d3r) >>! In T88887#1023031, @GOIII wrote: > Take a few days off and everything goes to pieces... > > undid this addition and the CharInser... [21:36:58] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1023040 (10GOIII) Oh well. I didn't see the en.WS rem'd lines in the Wikipedia application of CharInsert so he'll have to address it without breaking it... [21:40:45] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1023042 (10He7d3r) @GOIII: ext.gadget.charinsert-core does not depend on any code from the small module [[https://github.com/wikimedia/mediawiki/blob/mas... [21:48:54] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1023062 (10GOIII) >>! In T88887#1023042, @He7d3r wrote: > @GOIII: ext.gadget.charinsert-core does not depend on any code from the small module [[https://... [22:03:44] (03PS15) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [22:04:20] (03PS1) 10Paladox: Merge branch 'master' into HEAD [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189289 [22:04:48] (03Abandoned) 10Paladox: Merge branch 'master' into HEAD [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189289 (owner: 10Paladox) [22:12:32] (03PS16) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [22:17:06] 3VisualEditor-Tables, VisualEditor-EditingTools, VisualEditor: VisualEditor: Table with some template-generated rows appears with additional jumbled empty table cells – enwiki's {{Singlechart}} template - https://phabricator.wikimedia.org/T70306#1023082 (10matmarex) Another example: https://en.wikipedia.org/wiki... [22:18:23] 3VisualEditor-Tables, VisualEditor-EditingTools, VisualEditor: VisualEditor: Table with some template-generated rows appears with additional jumbled empty table cells – enwiki's {{Singlechart}} template - https://phabricator.wikimedia.org/T70306#1023084 (10matmarex) [22:18:50] 3VisualEditor-Tables, VisualEditor-EditingTools, VisualEditor: Table with some template-generated rows appears with additional jumbled empty table cells - https://phabricator.wikimedia.org/T70306#1023085 (10matmarex) [22:20:05] (03PS17) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [22:20:40] (03PS18) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [23:05:35] 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1023151 (10violetto) Can we have them behave the same as text fields, buttons during focus states like https://phabricator.wikimedia.org/M33 [23:05:37] 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1023152 (10violetto) Can we have them behave the same as text fields, buttons during focus states like https://phabricator.wikimedia.org/M33 [23:47:52] (03PS1) 10Bartosz Dziewoński: DropdownInputWidget: Fix undefined variable in PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/189293 [23:48:13] (03PS2) 10Bartosz Dziewoński: DropdownInputWidget: Fix undefined variable in PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/189293 [23:55:37] (03PS1) 10Esanders: Add table styles for block images and move to init.sa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189295