[00:07:41] <wikibugs>	 3MediaWiki-ResourceLoader, MediaWiki-Page-editing: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1023960 (10He7d3r)
[00:09:30] <wikibugs>	 3MediaWiki-ResourceLoader, MediaWiki-Page-editing: ResourceLoader does not load the module for the Charinsert gadget - https://phabricator.wikimedia.org/T88887#1022450 (10He7d3r)
[00:19:03] <grrrit-wm>	 (03PS28) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) 
[01:02:54] <grrrit-wm>	 (03PS25) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 
[01:08:30] <grrrit-wm>	 (03PS9) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 
[02:27:39] <wikibugs>	 3MediaWiki-Page-editing: Heading-field (section=new) uses same name/id as edit summary (action=edit) - https://phabricator.wikimedia.org/T28312#1024020 (10Perhelion) I figured out now, there is no problem here with JavaScript. You can simply check  ```  $("#wpMinoredit").length  ``` to proof the new section summ...
[09:43:05] <wikibugs>	 3MediaWiki-ContentHandler, MediaWiki-Database, MediaWiki-Page-editing: MediaWiki allows saving an identical revision on top of another (due to content model?) - https://phabricator.wikimedia.org/T87152#1024342 (10Nemo_bis) @Merl said on #wikimedia-tech: > my bot is doing some nulledits because of from langlink t...
[10:49:15] <wikibugs>	 3UI-Standardization, OOjs-UI: ToggleSwitchWidget has no visual representation for focused state - https://phabricator.wikimedia.org/T88973#1024496 (10TheDJ) 3NEW
[10:53:23] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] ToggleSwitchWidget: Accessibility improvements [oojs/ui] - 10https://gerrit.wikimedia.org/r/188828 (https://phabricator.wikimedia.org/T88079) (owner: 10Bartosz Dziewoński)
[10:54:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: ToggleSwitchWidget: Accessibility improvements [oojs/ui] - 10https://gerrit.wikimedia.org/r/188828 (https://phabricator.wikimedia.org/T88079) (owner: 10Bartosz Dziewoński)
[10:55:33] <wikibugs>	 3OOjs-UI: ToggleSwitchWidget requires the checkbox role - https://phabricator.wikimedia.org/T88079#1024535 (10TheDJ) 5Open>3Resolved
[10:55:52] <wikibugs>	 3OOjs-UI: ToggleSwitchWidget requires to be TabIndexedElement - https://phabricator.wikimedia.org/T88080#1024536 (10TheDJ) 5Open>3Resolved
[10:59:42] <wikibugs>	 3OOjs-UI: label text of ButtonWidget (primary) is not visible when pressed - https://phabricator.wikimedia.org/T88975#1024548 (10TheDJ) 3NEW
[11:00:04] <wikibugs>	 3MediaWiki-Page-editing: mw.toolbar.insertTags should be independent from mediawiki.toolbar module - https://phabricator.wikimedia.org/T88976#1024555 (10Schnark) 3NEW
[11:04:44] <grrrit-wm>	 (03CR) 10TheDJ: "Looking a lot better with this. Indeed some things are not yet fixed, but the behavior is a lot better." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) (owner: 10Bartosz Dziewoński)
[11:07:57] <wikibugs>	 3OOjs-UI: label text of ButtonWidget (primary) is not visible when pressed - https://phabricator.wikimedia.org/T88975#1024575 (10Ricordisamoa)
[11:08:00] <wikibugs>	 3OOjs-UI: Primary buttons change text colour when pressed - https://phabricator.wikimedia.org/T88948#1024576 (10Ricordisamoa)
[11:08:54] <wikibugs>	 3OOjs-UI: label text of ButtonWidget (primary) is not visible when pressed - https://phabricator.wikimedia.org/T88975#1024548 (10Ricordisamoa)
[11:11:38] <wikibugs>	 3OOjs-UI: TextInputWidget (autosize)‎ contains two textareas - https://phabricator.wikimedia.org/T88977#1024587 (10TheDJ) 3NEW
[11:14:19] <wikibugs>	 3MediaWiki-Page-editing: Links in autogenerated summary in page histories may point to wrong section or to nowhere - https://phabricator.wikimedia.org/T4831#1024610 (10Perhelion) I would link (as good workaround fallback) to the very bottom #footer, because this auto summaries are always talkpages (and you know...
[11:17:36] <wikibugs>	 3OOjs-UI: Enforce labels for all interactive controls - https://phabricator.wikimedia.org/T88979#1024615 (10TheDJ) 3NEW
[11:39:11] <grrrit-wm>	 (03PS2) 10Esanders: Fix text input auto-height calculation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189341 
[11:39:14] <grrrit-wm>	 (03CR) 10Esanders: Fix text input auto-height calculation (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/189341 (owner: 10Esanders)
[11:40:37] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Track originalHtml in internalItems [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189120 (https://phabricator.wikimedia.org/T88650) (owner: 10Catrope)
[11:42:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Track originalHtml in internalItems [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189120 (https://phabricator.wikimedia.org/T88650) (owner: 10Catrope)
[11:55:16] <grrrit-wm>	 (03PS1) 10Esanders: Switch back to VE when changing language in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189463 
[11:57:18] <grrrit-wm>	 (03PS2) 10Esanders: Switch back to VE when changing language in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189463 
[12:05:11] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] PHP demo: Resynchronize with JS demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/189337 (owner: 10Bartosz Dziewoński)
[12:05:57] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Stop treating ApexTheme class unfairly and make it proper [oojs/ui] - 10https://gerrit.wikimedia.org/r/189344 (owner: 10Bartosz Dziewoński)
[12:06:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: PHP demo: Resynchronize with JS demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/189337 (owner: 10Bartosz Dziewoński)
[12:07:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop treating ApexTheme class unfairly and make it proper [oojs/ui] - 10https://gerrit.wikimedia.org/r/189344 (owner: 10Bartosz Dziewoński)
[12:08:26] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] PHP demo: Add Vector/Raster and MediaWiki/Apex controls [oojs/ui] - 10https://gerrit.wikimedia.org/r/189345 (owner: 10Bartosz Dziewoński)
[12:09:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: PHP demo: Add Vector/Raster and MediaWiki/Apex controls [oojs/ui] - 10https://gerrit.wikimedia.org/r/189345 (owner: 10Bartosz Dziewoński)
[12:12:49] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] [WIP] Add horizontal alignment test to demo (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński)
[12:13:55] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] MediaWiki theme: Fix non-clickability of radios and checkboxes [oojs/ui] - 10https://gerrit.wikimedia.org/r/189361 (https://phabricator.wikimedia.org/T88035) (owner: 10Bartosz Dziewoński)
[12:28:10] <grrrit-wm>	 (03PS3) 10Esanders: Switch back to VE when changing language in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189463 
[12:48:06] <grrrit-wm>	 (03PS1) 10Esanders: Only replace selection when we know it has changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189472 (https://phabricator.wikimedia.org/T87419) 
[13:22:40] <grrrit-wm>	 (03CR) 10Prtksxna: "^ Whitespace issues ^" (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/189238 (owner: 10Bartosz Dziewoński)
[13:25:43] <grrrit-wm>	 (03CR) 10Prtksxna: "Submitting a follow up patch." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189238 (owner: 10Bartosz Dziewoński)
[13:26:01] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: MediaWiki theme: Consistent toggle button 'active' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/189238 
[13:26:14] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: MediaWiki theme: Consistent toggle button 'active' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/189238 
[13:26:26] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Some renaming would be helpful, indeed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189238 (owner: 10Bartosz Dziewoński)
[13:33:03] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] tests: Just echo the autoload error message, don't trigger_error() [oojs/ui] - 10https://gerrit.wikimedia.org/r/189343 (owner: 10Bartosz Dziewoński)
[13:35:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: tests: Just echo the autoload error message, don't trigger_error() [oojs/ui] - 10https://gerrit.wikimedia.org/r/189343 (owner: 10Bartosz Dziewoński)
[13:36:42] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] MediaWiki theme: Consistent toggle button 'active' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/189238 (owner: 10Bartosz Dziewoński)
[13:36:53] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Fix text input auto-height calculation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189341 (owner: 10Esanders)
[13:37:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki theme: Consistent toggle button 'active' state [oojs/ui] - 10https://gerrit.wikimedia.org/r/189238 (owner: 10Bartosz Dziewoński)
[13:38:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix text input auto-height calculation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189341 (owner: 10Esanders)
[14:01:01] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: RadioOptionWidget: Make it a <label/> [oojs/ui] - 10https://gerrit.wikimedia.org/r/188830 (https://phabricator.wikimedia.org/T88082) 
[14:06:08] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) 
[14:06:10] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 
[14:06:26] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-2] [BREAKING CHANGE] Remove deprecated GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 (owner: 10Bartosz Dziewoński)
[14:07:18] <wikibugs>	 3OOjs-UI: Primary buttons change text colour when pressed - https://phabricator.wikimedia.org/T88948#1024768 (10matmarex) p:5Triage>3Normal
[14:20:48] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: FieldsetLayout: Tweak positioning of help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/189480 
[14:38:56] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Templates: Insert/Template inspector should put focus on input text_field when invoked but no longer does - https://phabricator.wikimedia.org/T85484#1024816 (10Nnemo) On Firefox 35 Mac, I am editing Wikipedia with the Visual Editor.  By habit, I type "{{cit". This brings a d...
[14:39:06] <wikibugs>	 3OOjs-UI: Enforce labels for all interactive controls - https://phabricator.wikimedia.org/T88979#1024818 (10Prtksxna) Do you mean adding an `aria-label` for buttons that don't have any text? I am guessing by (i) you mean - {F38539}
[14:39:15] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: MediaWiki theme: Correct flagged primary button color when pressed [oojs/ui] - 10https://gerrit.wikimedia.org/r/189484 (https://phabricator.wikimedia.org/T88948) 
[14:39:40] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: MediaWiki theme: Correct flagged primary button text color when pressed [oojs/ui] - 10https://gerrit.wikimedia.org/r/189484 (https://phabricator.wikimedia.org/T88948) 
[14:42:22] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: FieldsetLayout: Tweak positioning of help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/189480 
[14:46:04] <wikibugs>	 3OOjs-UI: TextInputWidget (autosize)‎ contains two textareas - https://phabricator.wikimedia.org/T88977#1024828 (10Prtksxna) The widget should have two `<textarea>` elements only when its configured to autosize.
[14:46:15] <grrrit-wm>	 (03PS1) 10Prtksxna: TextInputWidget: Use aria-hidden for extra autosize textarea [oojs/ui] - 10https://gerrit.wikimedia.org/r/189485 (https://phabricator.wikimedia.org/T88977) 
[14:49:03] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Refactor clickability of buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) 
[14:49:13] <prtksxna>	 MatmaRex: Is there a reference for the hierarchy of mixins in the theme?
[14:49:25] <MatmaRex>	 hierarchy of mixins?
[14:50:15] <prtksxna>	 I remember TrevorP|Away saying that some of them inherit stuff, I might be wrong.
[14:51:49] <MatmaRex>	 i think that the mixin hierarchy is flat, but some "depend on" others possibly?
[14:51:51] <wikibugs>	 3OOjs-UI: Enforce labels for all interactive controls - https://phabricator.wikimedia.org/T88979#1024833 (10TheDJ) I mean label as the concept, not the technical way in which it is represented.   ``` title=, <label> <button>content</button>, aria-label  ``` Can all be good solutions, but there should be //a// la...
[15:09:54] <wikibugs>	 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1024850 (10matmarex)
[15:09:55] <wikibugs>	 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1024851 (10matmarex)
[15:09:58] <wikibugs>	 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1022938 (10matmarex)
[15:09:59] <wikibugs>	 3OOjs-UI: DropdownWidget and ComboBoxWidget dropdown arrow is not keyboard accessible - https://phabricator.wikimedia.org/T87705#1024852 (10matmarex)
[15:10:02] <wikibugs>	 3OOjs-UI: DropdownWidget and ComboBoxWidget dropdown arrow is not keyboard accessible - https://phabricator.wikimedia.org/T87705#996988 (10matmarex)
[15:10:03] <wikibugs>	 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1022938 (10matmarex)
[15:10:04] <wikibugs>	 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1003856 (10matmarex)
[15:10:27] <grrrit-wm>	 (03PS1) 10Mvolz: Change license from GNU to MIT & add LICENSE.txt [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189490 
[15:12:09] <grrrit-wm>	 (03PS2) 10Mvolz: Change license from GNU to MIT & add LICENSE.txt [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189490 
[15:30:44] <wikibugs>	 3VisualEditor: The Visual Editor scrolls erratically when the user is typing or erasing on Safari iOS - https://phabricator.wikimedia.org/T88983#1024778 (10Aklapper) [Please associate projects when creating tasks.]
[15:30:52] <wikibugs>	 3VisualEditor: The Visual Editor scrolls erratically when the user is typing or erasing on Safari iOS - https://phabricator.wikimedia.org/T88983#1024898 (10Aklapper)
[15:53:27] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/189499 
[15:57:57] <wikibugs>	 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1024967 (10matmarex) (Correction, MenuSelectWidget implements keyboardy stuff, SelectWidget does not. I think this behavior be moved there.)
[15:58:03] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] RadioOptionWidget: Make it a <label/> [oojs/ui] - 10https://gerrit.wikimedia.org/r/188830 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński)
[15:59:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: RadioOptionWidget: Make it a <label/> [oojs/ui] - 10https://gerrit.wikimedia.org/r/188830 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński)
[16:00:05] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "I need opinions on the following (quoting commit message) before this is merged. Might want to redo stuff." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) (owner: 10Bartosz Dziewoński)
[16:00:41] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] MediaWiki theme: Correct flagged primary button text color when pressed [oojs/ui] - 10https://gerrit.wikimedia.org/r/189484 (https://phabricator.wikimedia.org/T88948) (owner: 10Bartosz Dziewoński)
[16:01:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki theme: Correct flagged primary button text color when pressed [oojs/ui] - 10https://gerrit.wikimedia.org/r/189484 (https://phabricator.wikimedia.org/T88948) (owner: 10Bartosz Dziewoński)
[16:02:45] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Change license from GNU to MIT & add LICENSE.txt [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189490 (owner: 10Mvolz)
[16:04:19] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] TextInputWidget: Use aria-hidden for extra autosize textarea [oojs/ui] - 10https://gerrit.wikimedia.org/r/189485 (https://phabricator.wikimedia.org/T88977) (owner: 10Prtksxna)
[16:04:57] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] MediaWiki theme: Use distribution's image type for backgrounds [oojs/ui] - 10https://gerrit.wikimedia.org/r/189359 (owner: 10Bartosz Dziewoński)
[16:05:15] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] {Checkbox,Radio}InputWidget: Add missing configuration initialization [oojs/ui] - 10https://gerrit.wikimedia.org/r/189358 (owner: 10Bartosz Dziewoński)
[16:05:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: TextInputWidget: Use aria-hidden for extra autosize textarea [oojs/ui] - 10https://gerrit.wikimedia.org/r/189485 (https://phabricator.wikimedia.org/T88977) (owner: 10Prtksxna)
[16:05:47] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Delete unused src/themes/apex/{raster,vector}.less [oojs/ui] - 10https://gerrit.wikimedia.org/r/189357 (owner: 10Bartosz Dziewoński)
[16:06:52] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] FieldsetLayout: Tweak positioning of help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/189480 (owner: 10Bartosz Dziewoński)
[16:06:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Delete unused src/themes/apex/{raster,vector}.less [oojs/ui] - 10https://gerrit.wikimedia.org/r/189357 (owner: 10Bartosz Dziewoński)
[16:07:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: {Checkbox,Radio}InputWidget: Add missing configuration initialization [oojs/ui] - 10https://gerrit.wikimedia.org/r/189358 (owner: 10Bartosz Dziewoński)
[16:08:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change license from GNU to MIT & add LICENSE.txt [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189490 (owner: 10Mvolz)
[16:08:20] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] DropdownInputWidget: Fix undefined variable in PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/189293 (owner: 10Bartosz Dziewoński)
[16:08:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki theme: Use distribution's image type for backgrounds [oojs/ui] - 10https://gerrit.wikimedia.org/r/189359 (owner: 10Bartosz Dziewoński)
[16:09:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki theme: Fix non-clickability of radios and checkboxes [oojs/ui] - 10https://gerrit.wikimedia.org/r/189361 (https://phabricator.wikimedia.org/T88035) (owner: 10Bartosz Dziewoński)
[16:09:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: FieldsetLayout: Tweak positioning of help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/189480 (owner: 10Bartosz Dziewoński)
[16:09:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: DropdownInputWidget: Fix undefined variable in PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/189293 (owner: 10Bartosz Dziewoński)
[16:10:01] <mvolz>	 edsanders: can we talk https://gerrit.wikimedia.org/r/#q,I8959e09a5fc26fc1322944ed9d1d6878551e2333,n,z ?
[16:10:21] <edsanders>	 yes
[16:10:27] <mvolz>	 so.. have you tested it?
[16:10:34] <mvolz>	 because i agree it makes no sense whatsoever
[16:10:42] <mvolz>	 but that bug happens in chromium and firefox
[16:10:46] <mvolz>	 and that line fixes it
[16:10:54] <mvolz>	 i don't know why but it does
[16:10:59] <edsanders>	 Is your failing case just entering a broken URL?
[16:11:24] <mvolz>	 my failing case is when I don't have citoid running locally
[16:11:43] <mvolz>	 so if i forget to start it, or restart it, it actually happens to me a lot
[16:11:46] <mvolz>	 and is annoying
[16:11:58] <mvolz>	 and if we don't have 100% uptime will be annoying to users too
[16:12:07] <mvolz>	 I agree not elegant but i don't have a better idea :)
[16:12:09] <mvolz>	 any ideas?
[16:12:26] <wikibugs>	 3OOjs-UI: TextInputWidget (autosize)‎ contains two textareas - https://phabricator.wikimedia.org/T88977#1025043 (10Prtksxna) 5Open>3Resolved a:3Prtksxna
[16:12:29] <mvolz>	 It doesn't make sense to me, I was thinking, maybe some weird js or jquery implementation
[16:12:37] <mvolz>	 but i just tested in moz and same thing
[16:12:39] <mvolz>	 i can't explain it
[16:13:25] <edsanders>	 having a look
[16:16:24] <edsanders>	 so if you put debug points on fail and always you'll see that always never runs
[16:17:02] <edsanders>	 if you look at the docs for jQuery the options parameters are success/fail/complete
[16:17:12] <edsanders>	 whereas if you are using promises they are done/fail/always
[16:17:27] <edsanders>	 or rather .done()/.fail()/.always()
[16:18:03] <mvolz>	 well that makes sense :)#
[16:18:30] <edsanders>	 we prefer promises, so I'd convert to those
[16:19:02] <edsanders>	 so $.ajax().done( function(){} ).fail( function(){} ).always( function(){} );
[16:19:05] <James_F>	 Heya all.
[16:23:02] <mvolz>	 James_F: heya
[16:23:12] <wikibugs>	 3VisualEditor, Mobile-Web, Citoid: Citoid extension should target Mobile as well as desktop (otherwise it blocks VisualEditor loading in MobileFrontend) - https://phabricator.wikimedia.org/T87869#1025115 (10Jdforrester-WMF) 5Open>3Resolved a:3Mvolz
[16:23:32] <mvolz>	 I am very confused about the production case of citoid; you closed the task, but it's still not running? or services is doing that instead of operations now?
[16:24:24] <James_F>	 mvolz: Do you mean the "get the damn box to be IP-routable" ticket?
[16:24:38] <mvolz>	 no, the general "expose citoid publically" ticket
[16:24:46] <James_F>	 mvolz: Because that was done by Ops two weeks ago.
[16:24:49] <James_F>	 Yeah, that was that ticket.
[16:25:06] <James_F>	 The "get it working in production" issue is https://phabricator.wikimedia.org/T62768 surely?
[16:25:13] <James_F>	 It's exposed.
[16:25:30] <James_F>	 Go to http://citoid.wikimedia.org/ and sigh that Zotero has fallen over and won't get back up.
[16:29:20] <mvolz>	 Hmm. internal server error. You shouldn't get that even if Zotero isn't running
[16:29:40] <mvolz>	 at least it's supposed to handle things gracefully
[16:30:20] <James_F>	 That would also be good. :-)
[16:30:44] <James_F>	 https://phabricator.wikimedia.org/T76308
[16:30:59] <James_F>	 "Yup, that error means Zotero is not running.”
[16:32:59] <mvolz>	 If it's internal server error though there are bigger problems. On localhost I test without zotero running pretty frequently... I'd like to see logs on the production server- who do I bug? 
[16:33:21] <James_F>	 mvolz: gwicke and RoanKattouw_away
[16:38:52] <grrrit-wm>	 (03PS1) 10Krinkle: ve.utils: Apply whitelist in setDomAttributes() attribute removal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189507 
[16:39:02] <grrrit-wm>	 (03PS1) 10Krinkle: ve.utils: Cover insertIntoArray with unit test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189508 
[16:39:03] <grrrit-wm>	 (03PS1) 10Krinkle: ve.utils: Clean up escapeHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189509 
[16:46:32] <wikibugs>	 3OOjs-UI: ToggleSwitchWidget requires to be TabIndexedElement - https://phabricator.wikimedia.org/T88080#1025176 (10Jdforrester-WMF)
[16:46:57] <wikibugs>	 3OOjs-UI: ToggleSwitchWidget requires the checkbox role - https://phabricator.wikimedia.org/T88079#1025178 (10Jdforrester-WMF)
[16:51:37] <wikibugs>	 3OOjs-UI: TextInputWidget (indicator)‎ has 'required' state, so should use required attribute on the native element - https://phabricator.wikimedia.org/T87707#1025188 (10Jdforrester-WMF)
[16:51:39] <wikibugs>	 3OOjs-UI: TextInputWidget (autosize)‎ contains two textareas - https://phabricator.wikimedia.org/T88977#1025187 (10Jdforrester-WMF)
[16:52:15] <wikibugs>	 3OOjs-UI: TextInputWidget (autosize)‎ contains two textareas - https://phabricator.wikimedia.org/T88977#1025190 (10Jdforrester-WMF) p:5Triage>3Normal
[16:52:32] <mvolz>	 probably won't make kit today, have a meeting with gabriel but we had to schedule a half hour later due to ops meeting and it now overlaps with kit :)
[16:56:46] <James_F>	 mvolz: Ah well. :-)
[17:00:43] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] update Cite test to pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189514 
[17:01:51] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189514 (owner: 10Cmcmahon)
[17:03:04] <grrrit-wm>	 (03Abandoned) 10Cmcmahon: [BrowserTest] WIP make cite test pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189142 (owner: 10Cmcmahon)
[17:04:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] update Cite test to pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189514 (owner: 10Cmcmahon)
[17:13:48] <grrrit-wm>	 (03PS3) 10Mvolz: Fix: Switch to promise-based citoid requests [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) 
[17:17:14] <grrrit-wm>	 (03PS4) 10Mvolz: Fix: Switch to promise-based citoid requests [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) 
[17:24:15] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] Make media tests pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189516 
[17:25:05] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189516 (owner: 10Cmcmahon)
[17:26:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] Make media tests pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189516 (owner: 10Cmcmahon)
[17:30:35] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on viwiki: https://vi.wikipedia.org/?diff=20480914
[17:30:35] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on viwiki: https://vi.wikipedia.org/?diff=20480918
[17:30:35] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68472600
[17:30:35] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68473177
[17:33:49] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Fix: Switch to promise-based citoid requests (035 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) (owner: 10Mvolz)
[17:36:47] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] make References test pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189518 
[17:40:21] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189518 (owner: 10Cmcmahon)
[17:41:52] <grrrit-wm>	 (03CR) 10Cmcmahon: "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189518 (owner: 10Cmcmahon)
[17:42:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] make References test pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189518 (owner: 10Cmcmahon)
[17:45:32] <wikibugs>	 3VisualEditor: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1025346 (10Esanders) Actually we do a 50ms debounce on window resize only, so that is not the problem here. The problem is we remove the scrollbar and t...
[17:47:30] <grrrit-wm>	 (03PS1) 10Esanders: Emit position event before window transition, not after [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189521 (https://phabricator.wikimedia.org/T88867) 
[17:49:16] <grrrit-wm>	 (03PS10) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 (https://phabricator.wikimedia.org/T37342) 
[17:49:53] <grrrit-wm>	 (03CR) 10Paladox: "@Mattflaschen please review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox)
[18:00:16] <grrrit-wm>	 (03PS5) 10Esanders: Fix: Switch to promise-based citoid requests [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) (owner: 10Mvolz)
[18:00:56] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Fix: Switch to promise-based citoid requests [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) (owner: 10Mvolz)
[18:01:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix: Switch to promise-based citoid requests [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189207 (https://phabricator.wikimedia.org/T88897) (owner: 10Mvolz)
[18:01:13] <wikibugs>	 3VisualEditor: VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1025364 (10Cmcmahon) 3NEW
[18:03:55] <grrrit-wm>	 (03PS1) 10Esanders: Whitespace fixes [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189523 
[18:06:17] <wikibugs>	 3VisualEditor: Links don't get created fast enough - https://phabricator.wikimedia.org/T89010#1025395 (10Whatamidoing-WMF) 3NEW
[18:28:45] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression] Media Settings - Infinite loop when an image is inserted - https://phabricator.wikimedia.org/T88764#1025450 (10Jdforrester-WMF)
[18:30:44] <wikibugs>	 3VisualEditor: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1025456 (10Gilles) 3NEW
[18:33:01] <wikibugs>	 3VisualEditor: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1025464 (10matmarex) Already fixed by Ed in https://gerrit.wikimedia.org/r/#/c/189341/ (c0f146c1b328252dca0b3d42cce492fc6374befc).  I didn't realize this is already live, we'll probably want to backpo...
[18:33:06] <MatmaRex>	 James_F: bah. ^
[18:33:33] <MatmaRex>	 we broke textarea autosizing in last OOUI release, it seems.
[18:35:01] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Fixed T89015." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189341 (owner: 10Esanders)
[18:35:54] <mvolz>	 James_F: status update on citoid in production, services and I met and have an Action Plan now. 
[18:38:40] <grrrit-wm>	 (03CR) 10Mvolz: [C: 032] "Thanks Ed!" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189523 (owner: 10Esanders)
[18:38:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Whitespace fixes [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189523 (owner: 10Esanders)
[18:42:15] <RoanKattouw>	 mvolz: Did you see Alexandros's response on Phabricator an hour ago?
[18:45:14] <grrrit-wm>	 (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Remove window isolation [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 
[18:45:38] <grrrit-wm>	 (03PS6) 10Trevor Parscal: [BREAKING CHANGE] Remove window isolation [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 
[18:45:39] <wikibugs>	 3VisualEditor: Media Settings: images displayed with uneven heights - https://phabricator.wikimedia.org/T88765#1025503 (10Etonkovidova) {F38605}
[18:45:58] <grrrit-wm>	 (03CR) 10Trevor Parscal: [BREAKING CHANGE] Remove window isolation (037 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 (owner: 10Trevor Parscal)
[18:47:49] <ori>	 RoanKattouw: do you have / can you install kcachegrind on your machine?
[18:48:57] <grrrit-wm>	 (03PS1) 10Catrope: Add attribute transformation for color attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189529 
[18:49:04] <RoanKattouw>	 ori: I don't have it, I could install it
[18:49:11] <RoanKattouw>	 ori: Is this for the internal V8 trace stuff?
[18:49:39] <ori>	 yeah, i have the data, and the visualizations produced by qcachegrind are very useful
[18:49:46] <RoanKattouw>	 Cool
[18:49:53] <RoanKattouw>	 qcachegrind being the Qt frontend?
[18:49:58] <grrrit-wm>	 (03PS4) 10Esanders: Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 
[18:50:00] <grrrit-wm>	 (03PS4) 10Esanders: Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 
[18:50:02] <ori>	 yeah, i think they're the same ubuntu package
[18:50:02] <grrrit-wm>	 (03PS6) 10Esanders: Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 
[18:50:35] <RoanKattouw>	 Holy crap that has a lot of dependencies
[18:50:53] <RoanKattouw>	 Oh it's because kcachegrind depends on like all of KDE
[18:51:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 (owner: 10Esanders)
[18:51:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders)
[18:52:26] <ori>	 RoanKattouw: callgrind file: http://cl.ly/0R362410281d/download/callgrind.ve
[18:52:56] <RoanKattouw>	 Thanks
[18:53:15] <RoanKattouw>	 I've downloaded that, and now I'll install the 111 packages (not kidding) needed for kcachegrind
[18:53:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 (owner: 10Esanders)
[18:56:57] <edsanders>	 getAsFile is synchronous and getAsString is asynchronous, because of course... *sigh* http://www.w3.org/TR/2011/WD-html5-20110113/dnd.html#the-datatransferitem-interface
[19:05:28] <RoanKattouw>	 ori: OK I've loaded the file into kcachegrind but I have no idea how to use it. Maybe you can show me once you're in the office?
[19:07:28] <wikibugs>	 3WikiEditor: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1025594 (10brion) Hmmmmm perhaps (that does sound more like what I remember), but I couldn't repro those bugs either, even on IE 8/Win7.
[19:08:03] <ori>	 RoanKattouw: nod will be there in 30
[19:08:03] <wikibugs>	 3VisualEditor, Beta-Cluster: Searching for images in VisualEditor with Firefox is painfully slow in Beta Cluster - https://phabricator.wikimedia.org/T87676#1025597 (10Ryasmeen) This seems to get resolved with https://gerrit.wikimedia.org/r/188725. I am closing it for now,re-open if anyone experiences this issue.
[19:08:28] <wikibugs>	 3VisualEditor, Beta-Cluster: Searching for images in VisualEditor with Firefox is painfully slow in Beta Cluster - https://phabricator.wikimedia.org/T87676#1025598 (10Ryasmeen) 5Open>3Resolved
[19:09:13] <RoanKattouw>	 ori: Also vbench is completely broken
[19:09:27] <RoanKattouw>	 It just throws a bunch of cryptic Python exception crap and exits
[19:09:51] <RoanKattouw>	 vbench --latency --display 1200x768*2 "http://fr.wikipedia.org/wiki/Geganii"
[19:10:13] <RoanKattouw>	 [07:08:53] Unhandled error in Deferred:
[19:10:19] <RoanKattouw>	 Followed by a bunch of stuff I don't understand
[19:10:24] <mvolz>	 RoanKattouw: yeah, saw the response now :)
[19:10:54] <RoanKattouw>	 Hmm seems to be the latency parameter
[19:11:57] <ori>	 RoanKattouw: pastebin the exception?
[19:12:39] <RoanKattouw>	 ori http://pastebin.com/cdJwa4eM
[19:12:50] <RoanKattouw>	 Does the --latency parameter take a value, or something?
[19:12:54] <ori>	 no
[19:13:08] <RoanKattouw>	 So if I don't pass --latency, this doesn't happen, instead it just hangs
[19:13:21] <RoanKattouw>	 [07:13:13] Loading http://fr.wikipedia.org/wiki/Geganii...
[19:13:23] <RoanKattouw>	 and then nothing
[19:14:06] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] update Gem version of mediawiki_selenium [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188834 
[19:14:19] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188834 (owner: 10Cmcmahon)
[19:14:30] <ori>	 RoanKattouw: is it auth again? did something clobber your hack to make authentication not required?
[19:14:56] <wikibugs>	 3VisualEditor: VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1025624 (10Krenair) I think something might be wrong on the backend here:  http://en.wikipedia.beta.wmflabs.org/w/api.php?format=json&uselang=en&action=opensearch&sear...
[19:14:57] <RoanKattouw>	 ori: https://fr.wikipedia.org/wiki/Geganii is editable for anons
[19:14:58] <ori>	 RoanKattouw: the url it is on is "http://en.wikipedia.org/wiki/Barack_Obama?veaction=edit", which is strange -- if you are enabling VE via the injected JS, shouldn't that be #veaction=edit (not (?veaction=edit)?
[19:15:20] <RoanKattouw>	 No ?veaction=edit is correct, we use pushState
[19:15:25] <ori>	 hm, let me restart chromium
[19:15:28] <RoanKattouw>	 But Barack Obama is not correct
[19:15:33] <ori>	 try now?
[19:15:45] <RoanKattouw>	 Trying again
[19:15:49] <RoanKattouw>	 Is it at an frwiki URL now?
[19:15:51] <RoanKattouw>	 Oh yes
[19:15:53] <RoanKattouw>	 I'm getting numbers
[19:15:55] <RoanKattouw>	 Excellent
[19:16:03] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Make CSS classes in alignable configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189231 (owner: 10Esanders)
[19:16:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] update Gem version of mediawiki_selenium [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188834 (owner: 10Cmcmahon)
[19:16:13] <RoanKattouw>	 Although passing --latency still throws an AlreadyCalledError as before
[19:17:17] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (83a526a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189534 
[19:18:53] <ori>	 RoanKattouw: sigh. http://blogs.fluidinfo.com/terry/2010/08/14/twisteds-deferred-class-chaindeferred-method-is-too-simplistic/ . i'll fix
[19:19:18] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Squash into parent?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189463 (owner: 10Esanders)
[19:19:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (83a526a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189534 (owner: 10Jforrester)
[19:21:38] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/187321/ https://gerrit.wikimedia.org/r/#/c/189229/ https://gerrit.wikimedia.org/r/#/c/189230/ https://gerrit.wikimedia.org/r/#/c/189231/ and https://gerrit.wikimedia.org/r/#/c/187951/ (needs jsduck tweakage, coming).
[19:22:30] <James_F>	 RoanKattouw: And https://gerrit.wikimedia.org/r/#/c/189534/ looks like the MWExample tests need changing?
[19:22:59] <grrrit-wm>	 (03CR) 10Jforrester: "We should add npm to this repo to do this finding for us…" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189523 (owner: 10Esanders)
[19:25:05] <ori>	 RoanKattouw: try --latency again?
[19:27:57] <RoanKattouw>	 James_F: Yes, https://gerrit.wikimedia.org/r/189121
[19:28:02] <RoanKattouw>	 needs to be squashed in
[19:30:19] <grrrit-wm>	 (03PS2) 10Jforrester: Update VE core submodule to master (83a526a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189121 (https://phabricator.wikimedia.org/T88650) (owner: 10Catrope)
[19:33:09] <Krenair>	 RoanKattouw, I am running into something really weird with https://phabricator.wikimedia.org/T89007#1025624
[19:34:00] <RoanKattouw>	 Krenair: What happens in prod?
[19:34:12] <RoanKattouw>	 If you're going to tell me that beta is broken I will be shocked, I tell you, shocked!
[19:34:29] <Krenair>	 prod is reasonable like my local wiki
[19:34:48] <Krenair>	 I ran the request via new ApiMain( new FauxRequest( array( ... ) ) ); and got back the expected result :|
[19:35:15] <RoanKattouw>	 OK
[19:35:18] <RoanKattouw>	 Could you file a bug against beta?
[19:35:27] <RoanKattouw>	 I don't know what's wrong here, but whatever it is, it should be fixed
[19:35:33] <RoanKattouw>	 (sigh I'm so tired of beta always being broken)
[19:36:21] <Krenair>	 paste coming up
[19:37:28] <Krenair>	 RoanKattouw, https://phabricator.wikimedia.org/P274
[19:38:32] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Templates: [Regression wmf14] Safari - 'Add template' is greyed out - https://phabricator.wikimedia.org/T86038#1025676 (10Etonkovidova) Not an issue anymore - closing.  Checked Safari (6.2.2, 7.0.3, 7.1.2, 8.02) - betalabs - test2 - production
[19:38:48] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Templates: [Regression wmf14] Safari - 'Add template' is greyed out - https://phabricator.wikimedia.org/T86038#1025677 (10Etonkovidova) 5Open>3Resolved
[19:39:02] <grrrit-wm>	 (03PS4) 10Trevor Parscal: Liberation from the oppressive this.$ regime [oojs/ui] - 10https://gerrit.wikimedia.org/r/188957 
[19:39:31] <Krenair>	 was about to try an internal request to the app server but going to dinner now
[19:40:57] <TrevorParscal>	 RoanKattouw: fyi, https://gerrit.wikimedia.org/r/#/c/188951 and it's follow up https://gerrit.wikimedia.org/r/#/c/188957 are ready for re-review
[19:41:12] <TrevorParscal>	 no rush, you're just holding up the party in the streets
[19:44:06] <ori>	 it's okay, the children can do without christmas this year
[19:44:12] <wikibugs>	 3WikiEditor: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1025694 (10Aklapper)
[19:50:16] <wikibugs>	 3VisualEditor: Copy-paste bug:  Using the keyboard command to copy ref-containing text acts like Delete key instead - https://phabricator.wikimedia.org/T89025#1025705 (10Whatamidoing-WMF) 3NEW
[19:51:45] <MatmaRex>	 whee~ https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/widgets.php
[19:53:50] <RoanKattouw>	 ori: Ahm, why does vbench write all of its output to stderr?
[19:53:53] <RoanKattouw>	 and none of it to stdout
[19:54:05] <RoanKattouw>	 I can 2>&1 my way out of this, but ...
[19:54:38] <Krenair>	 back, I got the same result from deployment-mediawiki0[12]
[19:55:57] <grrrit-wm>	 (03CR) 10Trevor Parscal: "It could be interesting to extract this set of behaviors to a PressableElement or ClickableElement? Or ActionableElement maybe?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) (owner: 10Bartosz Dziewoński)
[20:00:14] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: TabIndexedElement: Actually allow tabIndex of -1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/189541 
[20:00:31] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Alright." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) (owner: 10Bartosz Dziewoński)
[20:00:50] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Refactor clickability of buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) 
[20:09:18] <wikibugs>	 3VisualEditor: VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1025758 (10Krenair) {P274}
[20:14:29] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Refactor clickability of buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) 
[20:14:42] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: Refactor clickability of buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) 
[20:22:05] <wikibugs>	 3VisualEditor: Linking to a URL produced an internal link (redlink) to the URL - https://phabricator.wikimedia.org/T89013#1025809 (10Aklapper)
[20:35:52] <wikibugs>	 3VisualEditor: Copy-paste bug:  Using Firefox's "Open menu" to copy causes  - https://phabricator.wikimedia.org/T89031#1025878 (10Whatamidoing-WMF) 3NEW
[20:49:34] <Krenair>	 RoanKattouw, please see the link I posted in the hangout
[20:49:49] <wikibugs>	 3OOjs-UI: DropdownWidget and ComboBoxWidget dropdown arrow is not keyboard accessible - https://phabricator.wikimedia.org/T87705#1025928 (10matmarex)
[20:50:01] <grrrit-wm>	 (03CR) 10Catrope: [BREAKING CHANGE] Remove window isolation (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 (owner: 10Trevor Parscal)
[20:50:37] <RoanKattouw>	 TrevorParscal: OK, window isolation looks fine, but I'd like the constructor to have a comment explaining why it's not calling toggle(), that's what other classes doing the same thing do
[20:50:54] <TrevorParscal>	 ok, will gladly add documentation for that
[20:51:15] <TrevorParscal>	 after I audit use to be 100% sure we need it
[20:52:01] <wikibugs>	 3VisualEditor, CirrusSearch, VisualEditor-EditingTools, MediaWiki-Search: [Regression] Redirects no longer indexed in search suggesions - https://phabricator.wikimedia.org/T88621#1025946 (10Krinkle)
[20:52:28] <RoanKattouw>	 Krenair: Not entirely sure but I think "proper interpretation" might mean "correct interpretation according to the API's crazy conventions where presence of the parameter, with any value, means true"
[20:52:38] <RoanKattouw>	 So &bot= means true and &bot=0 and &bot=false also mean true
[20:52:42] <RoanKattouw>	 (Welcome to the API :( )
[20:52:48] <RoanKattouw>	 Right
[20:53:10] <RoanKattouw>	 TrevorParscal: I forget where, maybe it's Widget or Context or whatever, but some other class somewhere is already doing the same and has a comment that you could copy
[20:53:20] <wikibugs>	 3VisualEditor, OOjs-UI: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1025953 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders
[20:53:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (83a526a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189121 (https://phabricator.wikimedia.org/T88650) (owner: 10Catrope)
[20:54:17] <grrrit-wm>	 (03Abandoned) 10Jforrester: Update VE core submodule to master (83a526a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189534 (owner: 10Jforrester)
[20:54:51] <grrrit-wm>	 (03PS3) 10Jforrester: Support specifying reference contents with data-mw.body.id [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188741 (https://phabricator.wikimedia.org/T88650) (owner: 10Catrope)
[20:55:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (83a526a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189121 (https://phabricator.wikimedia.org/T88650) (owner: 10Catrope)
[20:58:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Could you rearrange the code so it's more obvious in which order things happen?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189521 (https://phabricator.wikimedia.org/T88867) (owner: 10Esanders)
[20:59:00] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix center alignment of alignable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189229 (owner: 10Esanders)
[21:00:34] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Mix alignable into block images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189230 (owner: 10Esanders)
[21:01:03] <milimetric>	 RoanKattouw: I'm trying to tie in your deployments as annotations on a timeseries, how could I find "when and what version of VE was deployed"
[21:01:15] <RoanKattouw>	 hah
[21:01:34] <RoanKattouw>	 That might be a bit complex if you want to take into account every SWAT deployment
[21:01:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix center alignment of alignable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189229 (owner: 10Esanders)
[21:01:51] <RoanKattouw>	 Generally speaking, we ride the deployment train
[21:02:05] <RoanKattouw>	 But we often do follow-up cherry-picks to that
[21:02:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Mix alignable into block images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189230 (owner: 10Esanders)
[21:02:28] <milimetric>	 and do you have any sort of "tag like this" policy when deploying?
[21:02:29] <RoanKattouw>	 You could look at the history of the deployment schedule wiki page, or at the git log of the extensions/VisualEditor submodule in the wmf/1.25wmf* branches
[21:02:56] <RoanKattouw>	 The latter is almost certainly one entry per deployment
[21:03:07] <milimetric>	 ah, ok, great, thx
[21:04:54] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Make CSS classes in alignable configurable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189231 (owner: 10Esanders)
[21:05:22] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders)
[21:28:07] <TrevorParscal>	 RoanKattouw: so, both of the cases where I found initially hidden stuff done by manually setting the class and visible property (PopupWidget and MenuSelectWidget) also have no documentation about why they are doing it
[21:28:23] <TrevorParscal>	 so, I'm ok with adding it, but there is no precedence I can find in OOjs UI for this
[21:28:31] <TrevorParscal>	 contrary to your vivid imagination :)
[21:30:21] <RoanKattouw>	 Ugh there is a case like that for sure, let me find it
[21:32:12] <RoanKattouw>	 TrevorParscal: ve.ui.Context
[21:32:16] <RoanKattouw>	 To be fair, it was only pulled through less than an hour ago
[21:33:47] <TrevorParscal>	 lol
[21:34:03] <wikibugs>	 3OOjs-UI: OOjs UI: Tab character in dropdown boxes should pick the current selection (like Enter does) - https://phabricator.wikimedia.org/T53229#1026071 (10matmarex)
[21:36:28] <grrrit-wm>	 (03PS7) 10Trevor Parscal: [BREAKING CHANGE] Remove window isolation [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 
[21:38:14] <RoanKattouw>	 TrevorParscal: OK so you're going to need update commits for VE here
[21:38:20] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression pre-wmf17] The default search term is not getting highlighted when you open the media search dialog - https://phabricator.wikimedia.org/T88881#1026077 (10Jdforrester-WMF) 5Open>3Resolved
[21:38:27] <RoanKattouw>	 Because there is code in VE doing stuff like if ( this.loading.state() === 'resolved' )
[21:39:36] <grrrit-wm>	 (03PS5) 10Trevor Parscal: Liberation from the oppressive this.$ regime [oojs/ui] - 10https://gerrit.wikimedia.org/r/188957 
[21:40:03] <TrevorParscal>	 RoanKattouw: sure
[21:40:13] <TrevorParscal>	 I'll have a look
[21:40:14] <wikibugs>	 3VisualEditor: Media Settings: images displayed with uneven heights - https://phabricator.wikimedia.org/T88765#1026086 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF Yes, this is by design. The alternative is ugly.
[21:40:29] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] "Looks fine, works fine, but needs update commits in VE." [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 (owner: 10Trevor Parscal)
[21:40:54] <wikibugs>	 3VisualEditor, Parsoid: Flag invalid wikitext to the editor's attention in VisualEditor - https://phabricator.wikimedia.org/T89041#1026092 (10Whatamidoing-WMF) 3NEW
[21:42:58] <TrevorParscal>	 RoanKattouw: so, only in vemw is there any use of it
[21:43:30] <TrevorParscal>	 and, basically it's just a codepath i can kill, I think, it's in ve.ui.MWTemplateDialog line 231
[21:43:42] <TrevorParscal>	 can you look quickly?
[21:43:49] <TrevorParscal>	 this code changed a lot since I last worked on it
[21:44:14] <wikibugs>	 3VisualEditor, VisualEditor-CopyPaste: Using Firefox's "Open menu" to copy a paragraph and a reference together causes selected content to be deleted (not cut) instead - https://phabricator.wikimedia.org/T89031#1026115 (10Jdforrester-WMF)
[21:44:38] <TrevorParscal>	 my understanding is that this is to prevent the insert and save buttons from being clickable while the dialog is still loading, but since we no longer have a loading stage this is not needed
[21:46:25] <wikibugs>	 3VisualEditor: Copy-paste bug:  Using the keyboard command to copy ref-containing text acts like Delete key instead - https://phabricator.wikimedia.org/T89025#1026124 (10Jdforrester-WMF)
[21:46:26] <wikibugs>	 3VisualEditor, VisualEditor-CopyPaste: Using Firefox's "Open menu" to copy a paragraph and a reference together causes selected content to be deleted (not cut) instead - https://phabricator.wikimedia.org/T89031#1026123 (10Jdforrester-WMF)
[21:47:03] <wikibugs>	 3VisualEditor, VisualEditor-CopyPaste: In Firefox, using keyboard shortcuts or the "Open menu" to copy a paragraph and a reference together causes selected content to be deleted (not cut) instead - https://phabricator.wikimedia.org/T89025#1026125 (10Jdforrester-WMF)
[21:48:45] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Stop waiting for removed loading promise to finish [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 
[21:49:19] <grrrit-wm>	 (03PS2) 10Trevor Parscal: [DO NOT MERGE] Stop waiting for removed loading promise to finish [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 
[21:49:49] <TrevorParscal>	 RoanKattouw: that should do it
[21:50:01] <TrevorParscal>	 the breaking changes otherwise don't appear to affect anyone
[21:50:14] <TrevorParscal>	 but, as we pull through I'm sure we can verify that
[21:51:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE] Stop waiting for removed loading promise to finish [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal)
[21:51:16] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Reconsider or document decision to disallow context menus in VisualEditor - https://phabricator.wikimedia.org/T88930#1026133 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF We have "context menus" – that's what comes up when you click a link. We have "con...
[21:51:39] <James_F>	 TrevorParscal: When you get a moment, review/thoughts on https://gerrit.wikimedia.org/r/#/c/188289/ would be appreciated.
[21:51:59] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-EditingTools, Citoid: Citoid's autofill citation dialog in VisualEditor remembers the previous URL, and it's shouldn't - https://phabricator.wikimedia.org/T89043#1026136 (10Whatamidoing-WMF) 3NEW
[21:52:05] <TrevorParscal>	 James_F: looking now
[21:52:08] <James_F>	 TrevorParscal: (We're going to need a bigger boat^W^W^Hn icon pack system, but otherwise it's good to go, maybe?)
[21:52:54] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Reconsider or document decision to disallow context menus in VisualEditor - https://phabricator.wikimedia.org/T88930#1026144 (10awight) What about long-tap on pho-tablets?
[21:53:24] <wikibugs>	 3VisualEditor, Parsoid: Flag invalid wikitext to the editor's attention in VisualEditor - https://phabricator.wikimedia.org/T89041#1026147 (10Jdforrester-WMF) This is fundamentally impossible for VisualEditor to do, because it doesn't know wikitext.  There's already the parsing failure project with Parsoid suppo...
[21:54:01] <TrevorParscal>	 I think the plan was actually to add them to MediaWiki core and use the ResourceLoaderImageModule system
[21:54:17] <TrevorParscal>	 and break them into smaller groups, like groups of less than 15
[21:54:18] <James_F>	 TrevorParscal: No no no. They're part of the theme.
[21:54:22] <TrevorParscal>	 hmm
[21:54:28] <James_F>	 TrevorParscal: Yes, that's what I meant by "icon packs"/
[21:54:41] <TrevorParscal>	 but RLImageModule can generate OOjs UI compatible icons
[21:54:46] <James_F>	 TrevorParscal: The theme is in MW-core. We need to hook up … yeah.
[21:54:49] <TrevorParscal>	 that's what it's there for
[21:55:10] <James_F>	 Which is why we don't need to import .PNGs to the MW-core repo.
[21:55:19] <James_F>	 We'd just bring in the SVGs and it'd make the magic happen.
[21:55:29] <James_F>	 (Removing part of the OOjs UI build process.)
[21:55:32] <TrevorParscal>	 yeah, so we don't have to block on moving the OOjs UI mw theme to core, but yeah, these icons are meant to be in core as a supplement to OOjs UI
[21:55:39] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Remove window isolation [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 (owner: 10Trevor Parscal)
[21:55:43] <James_F>	 Are they?
[21:55:56] <James_F>	 I think that feels like a mistaken direction…
[21:55:58] <TrevorParscal>	 i don't think we need to have them checked into OOjs UI, is what I am suggesting
[21:56:17] <TrevorParscal>	 and we actually want to move the mw specific stuff out of OOjs UI
[21:56:27] <James_F>	 "We"?
[21:56:46] <TrevorParscal>	 yes, the people who work on this crap
[21:56:53] <TrevorParscal>	 we = me, bartosz, you
[21:56:58] <TrevorParscal>	 etc.
[21:56:59] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-EditingTools, Citoid: After Citoid fills in the data, please leave the citation open for review - https://phabricator.wikimedia.org/T89045#1026157 (10Whatamidoing-WMF) 3NEW
[21:57:09] * MatmaRex reads log
[21:57:11] <James_F>	 "We"'ve discussed this before, and we didn't have consensus on this.
[21:57:48] <James_F>	 Krenair: Did you take https://phabricator.wikimedia.org/T89007 to anyone in RelEng?
[21:57:57] <TrevorParscal>	 well, I feel like we have, but I'm happy to revisit the decision
[21:58:00] <James_F>	 Krenair: Or was it just the comments on Phabricator? I can escalate.
[21:58:08] <TrevorParscal>	 maybe things have changed, or I just don't remember correctly
[21:58:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove window isolation [oojs/ui] - 10https://gerrit.wikimedia.org/r/188951 (owner: 10Trevor Parscal)
[21:58:27] <James_F>	 TrevorParscal: I think splitting the theme between repos won't be a great plan.
[21:58:30] <TrevorParscal>	 but I remember we were looking to move the mw theme to mw core, and the complexity of the current theme build process was keeping that back
[21:58:34] <Krenair>	 James_F, I spoke to Chad
[21:58:46] <Krenair>	 Search on beta is broken
[21:58:51] <James_F>	 Krenair: Aha.
[21:58:58] <TrevorParscal>	 the split between repos is a fair point, could make extra work and complexity, I'll think about this
[21:59:03] <Krenair>	 I have no idea why I can get results on deployment-bastion but not from the app servers
[21:59:09] <MatmaRex>	 eh, i think we should keep the "master" icons on oojs/ui repo for now
[21:59:30] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "This isn't a bad commit, I just want to talk through where these should go a little more before we land it." [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester)
[21:59:45] <MatmaRex>	 and maybe add a RLImageModule-based module in mediawiki/core that would provide just them, separately from oojs-ui module
[21:59:54] <MatmaRex>	 or just enhance oojs-ui module to use RLImageModule
[22:00:03] <James_F>	 TrevorParscal: I thought we said that keeping the theme in one place was important. I just assumed we meant from that that the repo was oojs-ui.
[22:00:19] <MatmaRex>	 when we move out the theme, we'll move out the icons too.
[22:00:44] <James_F>	 MatmaRex: Yeah, that's what I was thinking. So the use of oojs-ui-styles.editing and oojs-ui-styles.user and oojs-ui-styles.reading and whatever are all using RLImageModule to generate PNGs if needed.
[22:00:44] <TrevorParscal>	 I think it's important that we are able to allow OOjs UI themes to be built and maintained in separate repositories
[22:00:55] <MatmaRex>	 (moving out the theme right now would be disruptive for us; i keep fixing identical issues in both existing themes, i'd prefer not to have to do this in two commits)
[22:01:03] <TrevorParscal>	 I'm ok moving the icons when we move the theme
[22:01:04] <James_F>	 TrevorParscal: Important, sure, but urgent?
[22:01:07] * James_F nods.
[22:01:21] <TrevorParscal>	 but, it's still my opinion that the theme and it's icons should eventually be moved out
[22:01:43] <TrevorParscal>	 and no, not urgent, just trying to look at this carefully so we aren't taking steps backwards
[22:01:59] <James_F>	 Sure.
[22:02:09] <James_F>	 Splitting into packs, however, is a blocker for release.
[22:02:26] <James_F>	 Do you have thoughts about what constitutes a pack? Themes you've already got in mind?
[22:03:32] <wikibugs>	 3VisualEditor: Selecting huge chunks of text with Shift + arrow up/down is broken or works inconsistently - https://phabricator.wikimedia.org/T75512#1026172 (10Etonkovidova) On https://de.wikipedia.org/w/index.php?title=Arbeitsrecht_(Deutschland)&action=edit, it's not possible to highlight several paragraph with...
[22:03:52] <wikibugs>	 3VisualEditor: Selecting huge chunks of text with Shift + arrow up/down is broken or works inconsistently - https://phabricator.wikimedia.org/T75512#1026173 (10Etonkovidova) p:5Triage>3Normal
[22:06:39] <wikibugs>	 3VisualEditor, Beta-Cluster: Search on the Beta Cluster is broken, and thus VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1026183 (10Jdforrester-WMF)
[22:07:46] <wikibugs>	 3VisualEditor, Beta-Cluster: Search on the Beta Cluster is broken, and thus VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1025364 (10Jdforrester-WMF) Not sure where (if?) the wider Beta Cluster issue is being tracked.
[22:08:39] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-EditingTools, Citoid: Citoid's autofill citation dialog in VisualEditor remembers the previous URL, and it's shouldn't - https://phabricator.wikimedia.org/T89043#1026191 (10Mvolz) Are you using the user script? This has been fixed in the extension.
[22:08:50] <TrevorParscal>	 James_F: unfortunately, I asked the design team to specify the packs, and they dropped the ball... I mean they also dropped the mic, so that was helpful.
[22:11:23] <wikibugs>	 3VisualEditor, Beta-Cluster: Search on the Beta Cluster is broken, and thus VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1026205 (10Krenair) Apparently @Chad was working on fixing search on beta all day. I don't know why it was...
[22:15:58] <wikibugs>	 3VisualEditor, OOjs-UI: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1026216 (10Jdforrester-WMF) a:3Esanders
[22:17:28] <James_F>	 TrevorParscal: :-)
[22:17:40] <James_F>	 TrevorParscal: Happy to just carve them up according to my personal tastes…
[22:17:55] <TrevorParscal>	 yeah
[22:18:00] <James_F>	 OK.
[22:18:01] <TrevorParscal>	 we will just have to make some calls here I guess
[22:18:16] <TrevorParscal>	 thanks for working on this by the way
[22:18:24] <James_F>	 Also, where there are clashing VE icons, we should switch over, I guess – should the VE ones be moved into OOjs UI as the Apex icons?
[22:18:52] <TrevorParscal>	 hmm
[22:18:56] <TrevorParscal>	 not sure
[22:19:21] <TrevorParscal>	 layered software gets complicated when you are trying to optimize for sending resources over the wire
[22:20:33] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Selecting huge chunks of text with Shift + arrow up/down is broken or works inconsistently - https://phabricator.wikimedia.org/T75512#1026231 (10Jdforrester-WMF)
[22:20:57] <James_F>	 Indeed.
[22:21:09] <James_F>	 OK, for now I'll ignore the VE use cases and just carve up.
[22:23:33] <TrevorParscal>	 cool
[22:24:00] <James_F>	 (Not sure /how/, but meh.)
[22:24:28] <James_F>	 MatmaRex: Don't suppose you want to carve up 188289 into icon packs? :-)
[22:25:25] <Guest38194>	 TrevorParscal: What BookletLayout got replaced with?
[22:25:36] <James_F>	 InezK: MenuLayout.
[22:26:22] <InezK>	 hn, interesting
[22:26:27] <InezK>	 thanks, I will check it out
[22:26:37] <MatmaRex>	 James_F: not really ;) no opinions here about how to divide them, either
[22:26:59] <James_F>	 MatmaRex: icons.js in demos, for one, needs to read the available icons from the theme and show them.
[22:27:37] <TrevorParscal>	 InezK: it's mostly the same thing, it just now has a fixed-width menu instead of a proportional one (well you can use any CSS property you want really, but unlike grid layout which forced proportional on you, it can use ems or % or px or whatever)
[22:28:06] <James_F>	 MatmaRex: And I don't know how to do that.
[22:28:09] <InezK>	 oh, ok
[22:28:15] <James_F>	 MatmaRex: I rely on clever people like you. :-)
[22:29:23] <MatmaRex>	 James_F: well, but it doesn't do that now, does it?
[22:29:37] <MatmaRex>	 it's a hardcoded list
[22:29:58] <TrevorParscal>	 it used to scan through CSSDOM and pluck out classes that looked like icons
[22:30:06] <TrevorParscal>	 I guess that was flawed somehow
[22:30:23] <MatmaRex>	 we could make the list of icons available somewhere in JS, based on the json file, but our build process already sucks badly enough
[22:31:39] <James_F>	 MatmaRex: It's a hardcoded list which *isn't the same between themes* after this patch.
[22:32:04] <James_F>	 The images.json file is already a list of icons available. :-)
[22:32:36] <TrevorParscal>	 yeah, we already have all this stuff in data
[22:33:02] <TrevorParscal>	 but, someone needs to come up with a better way to build all this crap, and consider people building themes outside of OOjs UI core
[22:33:09] <James_F>	 Indeed.
[22:33:22] <James_F>	 But that's not an urgent thing to work on this quarter.
[22:33:27] <TrevorParscal>	 agreed
[22:33:41] <TrevorParscal>	 it's tech debt for now
[22:33:45] <wikibugs>	 3OOjs-UI: OOjs UI: Tab character in dropdown boxes should pick the current selection (like Enter does) - https://phabricator.wikimedia.org/T53229#1026275 (10matmarex) There are two separate cases where we use similar dropdown menus: as suggestions for text input (like in the original example of this task) and as...
[22:34:10] <MatmaRex>	 James_F: hmm. that kind of sucks, then
[22:34:22] <MatmaRex>	 if some icons are now unavailable on some themes
[22:35:06] <MatmaRex>	 can't we import the new additions into apex? (or does that offend your sense of aesthetics? i haven't looked at the new icons much)
[22:39:43] <James_F>	 MatmaRex: They aren't in keeping with the former theme, and a bunch of them don't have equivalents.
[22:45:57] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor:[Regression wmf7] Invalid characters as gallery caption, creates an empty node. - https://phabricator.wikimedia.org/T75230#1026337 (10Etonkovidova) p:5Triage>3Low
[22:48:24] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Typing after double-click at line end in Firefox brings CE out of sync with DM - https://phabricator.wikimedia.org/T88612#1026343 (10Jdforrester-WMF) 5Open>3Resolved
[22:48:29] <ori>	 RoanKattouw: I asked _joe_ to accelerate the access request for you. Additionally, vbench when vbench detects that stdout is not a tty (if you run it with >foo.log, for instance), it will write uncolored output to stdout, and colorized output to stderr.
[22:48:58] <ori>	 RoanKattouw: so, in other words, running "vbench --foo-args http://foo-url/ > my_log.log" gets you both console output (on stderr) and file output.
[22:50:26] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-EditingTools, Citoid: After Citoid fills in the data, please leave the citation open for review - https://phabricator.wikimedia.org/T89045#1026354 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF No, that's not the direction we're going –...
[22:50:48] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-EditingTools, Citoid: Citoid's autofill citation dialog in VisualEditor remembers the previous URL, and it's shouldn't - https://phabricator.wikimedia.org/T89043#1026358 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Indeed.
[22:52:03] <wikibugs>	 3VisualEditor, CirrusSearch, MediaWiki-Search, VisualEditor-MediaWiki-Links: [Regression] Redirects no longer indexed in search suggesions - https://phabricator.wikimedia.org/T88621#1026366 (10Jdforrester-WMF) p:5Triage>3Normal
[22:52:59] <wikibugs>	 3VisualEditor: Linking to a URL produced an internal link (redlink) to the URL - https://phabricator.wikimedia.org/T89013#1026374 (10Jdforrester-WMF) Looks like you put a space in the box first…
[22:53:26] <RoanKattouw>	 ori: Awesome
[22:54:00] <wikibugs>	 3VisualEditor: Links don't get created fast enough - https://phabricator.wikimedia.org/T89010#1026377 (10Jdforrester-WMF) p:5Triage>3Low It'll be a hell of a lot slower once {T76398} lands…
[22:54:57] <grrrit-wm>	 (03PS26) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 
[22:55:04] <grrrit-wm>	 (03PS11) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 (https://phabricator.wikimedia.org/T37342) 
[22:55:29] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor:[Regression wmf7] Inserting media, while Gallery inspector is open, makes the cursor active in the main editor - https://phabricator.wikimedia.org/T75226#1026389 (10Etonkovidova) 5Open>3Resolved p:5Triage>3Low
[22:56:02] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor:[Regression wmf7] Inserting media, while Gallery inspector is open, makes the cursor active in the main editor - https://phabricator.wikimedia.org/T75226#751172 (10Etonkovidova) Checked in betalabs and production.
[22:56:41] <grrrit-wm>	 (03PS29) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) 
[22:57:09] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Adjust the context menu to be able to display richer data for tools that want it - https://phabricator.wikimedia.org/T89054#1026403 (10Jdforrester-WMF) 3NEW a:3TrevorParscal
[22:57:30] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Tools should be able to specify a label for their appearance in the context menu. - https://phabricator.wikimedia.org/T88337#1026413 (10Jdforrester-WMF)
[22:57:32] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Adjust the context menu to be able to display richer data for tools that want it - https://phabricator.wikimedia.org/T89054#1026412 (10Jdforrester-WMF)
[22:58:16] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Adjust the context menu to be able to display richer data for tools that want it - https://phabricator.wikimedia.org/T89054#1026403 (10Jdforrester-WMF)
[22:58:18] <wikibugs>	 3VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1026416 (10Jdforrester-WMF)
[22:58:22] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: TabIndexedElement: Actually allow tabIndex of -1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/189541 
[22:58:24] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: [BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/189499 
[22:58:26] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: MenuSelectWidget: Codify current behavior of Tab closing the menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/189608 
[22:58:28] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: DropdownWidget, ComboBoxWidget: Make keyboard-accessible [oojs/ui] - 10https://gerrit.wikimedia.org/r/189609 (https://phabricator.wikimedia.org/T87705) 
[22:58:53] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: Adjust the context menu to be able to display richer data for tools that want it - https://phabricator.wikimedia.org/T89054#1026403 (10Jdforrester-WMF)
[22:58:54] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#1026424 (10Jdforrester-WMF)
[22:59:19] <wikibugs>	 3OOjs-UI: DropdownWidget and ComboBoxWidget dropdown arrow is not keyboard accessible - https://phabricator.wikimedia.org/T87705#1026430 (10matmarex) Vaguely related: T53229.
[23:02:59] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-EditingTools, Citoid: After Citoid fills in the data, please leave the citation open for review - https://phabricator.wikimedia.org/T89045#1026451 (10Mvolz) I think this is reasonable if we're putting the current extension up for production without th...
[23:03:46] <grrrit-wm>	 (03PS1) 10Ryasmeen: [BrowserTest][WIP] Fix Cite and Media test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189610 
[23:03:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest][WIP] Fix Cite and Media test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189610 (owner: 10Ryasmeen)
[23:05:39] <grrrit-wm>	 (03PS3) 10Esanders: Make CSS classes in alignable configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189231 
[23:05:41] <grrrit-wm>	 (03PS7) 10Esanders: Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 
[23:07:14] <grrrit-wm>	 (03CR) 10Esanders: "If you really want, can't be bothered though." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189463 (owner: 10Esanders)
[23:12:34] <grrrit-wm>	 (03PS2) 10Esanders: Emit position event before window transition, not after [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189521 (https://phabricator.wikimedia.org/T88867) 
[23:21:11] <grrrit-wm>	 (03CR) 10Catrope: "That's not what I really meant. Now you still have:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189521 (https://phabricator.wikimedia.org/T88867) (owner: 10Esanders)
[23:21:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Emit position event before window transition, not after [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189521 (https://phabricator.wikimedia.org/T88867) (owner: 10Esanders)
[23:23:04] <grrrit-wm>	 (03PS5) 10Esanders: Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 
[23:23:06] <grrrit-wm>	 (03PS5) 10Esanders: Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 
[23:23:08] <grrrit-wm>	 (03PS7) 10Esanders: Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 
[23:25:21] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Refactor clickability of buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) (owner: 10Bartosz Dziewoński)
[23:26:00] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: VisualEditor:[Regression]Add text and a space before language annotation, then delete space, text looses language style - https://phabricator.wikimedia.org/T75218#1026545 (10Etonkovidova) The issue was checked - does not exist anymore.
[23:26:02] <RoanKattouw>	 ori: So I think I just found a way to make DOM->data conversion about twice as fast
[23:26:16] * ori runs over
[23:26:18] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: VisualEditor:[Regression]Add text and a space before language annotation, then delete space, text looses language style - https://phabricator.wikimedia.org/T75218#1026549 (10Etonkovidova) 5Open>3Resolved
[23:26:22] <TrevorParscal>	 is there a reason we are holding off on https://gerrit.wikimedia.org/r/#/c/188957/ ?
[23:26:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor clickability of buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189236 (https://phabricator.wikimedia.org/T88090) (owner: 10Bartosz Dziewoński)
[23:26:42] <TrevorParscal>	 it's going to need to be rebased more and more...
[23:28:19] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: MenuSelectWidget: Codify current behavior of Tab closing the menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/189608 
[23:30:05] <grrrit-wm>	 (03PS6) 10Trevor Parscal: Liberation from the oppressive this.$ regime [oojs/ui] - 10https://gerrit.wikimedia.org/r/188957 
[23:30:28] <TrevorParscal>	 I just rebased, verifying it still covers ever use of .$
[23:30:54] <grrrit-wm>	 (03PS2) 10Jforrester: demo: Switch mode back to VE when changing page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189339 (owner: 10Esanders)
[23:31:01] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] demo: Switch mode back to VE when changing page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189339 (owner: 10Esanders)
[23:31:07] <grrrit-wm>	 (03PS4) 10Jforrester: Switch back to VE when changing language in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189463 (owner: 10Esanders)
[23:31:26] <grrrit-wm>	 (03PS5) 10Jforrester: demo: Switch mode back to VE when changing language [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189463 (owner: 10Esanders)
[23:31:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] demo: Switch mode back to VE when changing language [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189463 (owner: 10Esanders)
[23:32:02] <wikibugs>	 3VisualEditor: VisualEditor is not available from the diff page - https://phabricator.wikimedia.org/T89060#1026575 (10Whatamidoing-WMF) 3NEW
[23:32:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: demo: Switch mode back to VE when changing page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189339 (owner: 10Esanders)
[23:34:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: demo: Switch mode back to VE when changing language [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189463 (owner: 10Esanders)
[23:39:28] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Let's do this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[23:41:20] <wikibugs>	 3VisualEditor: On a line with language annotation  - cursor position displayed incorrectly - https://phabricator.wikimedia.org/T89061#1026630 (10Etonkovidova)
[23:41:40] <James_F>	 RoanKattouw, edsanders: Want to +2 https://gerrit.wikimedia.org/r/#/c/177946/ ? :-)
[23:42:13] <RoanKattouw>	 James_F: Per David's request I'm reviewing what he did there for table selections and focusable nodes
[23:43:04] <grrrit-wm>	 (03CR) 10Esanders: "But the scroll bars aren't hidden until the synchronous part of openWindow happens..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189521 (https://phabricator.wikimedia.org/T88867) (owner: 10Esanders)
[23:43:26] <grrrit-wm>	 (03PS1) 10Ryasmeen: [BrowserTest] Fix only Media Test The media test was passing against garbage wikitext markup match. Fixed the steps so that it fails when it should. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189623 
[23:43:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "Ugh... alright fine" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189521 (https://phabricator.wikimedia.org/T88867) (owner: 10Esanders)
[23:44:08] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Looks fine, minor comment typo" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[23:46:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Emit position event before window transition, not after [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189521 (https://phabricator.wikimedia.org/T88867) (owner: 10Esanders)
[23:48:14] <grrrit-wm>	 (03CR) 10Ryasmeen: [C: 032] [BrowserTest][WIP] Fix Cite and Media test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189610 (owner: 10Ryasmeen)
[23:49:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest][WIP] Fix Cite and Media test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189610 (owner: 10Ryasmeen)
[23:50:22] <wikibugs>	 3VisualEditor: Linking to a URL produced an internal link (redlink) to the URL - https://phabricator.wikimedia.org/T89013#1026651 (10Whatamidoing-WMF) [[ ]] is not a valid wikitext link, and both [[ Example]] and [[Example ]] render the same as [[Example]], so you'll never need to add either a leading or trailin...
[23:50:31] <ragesoss>	 triage meeting, wooo!
[23:50:57] <ragesoss>	 switch-to-default push, wooo!
[23:52:19] <grrrit-wm>	 (03PS31) 10Divec: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 
[23:53:31] <grrrit-wm>	 (03Abandoned) 10Ryasmeen: [BrowserTest][WIP] Fix Cite and Media test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189610 (owner: 10Ryasmeen)
[23:53:48] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[23:54:05] <mooeypoo>	 Are we using a different version of qunit in VE-core than in mw ?
[23:54:25] <grrrit-wm>	 (03CR) 10Ryasmeen: [C: 032] [BrowserTest] Fix only Media Test The media test was passing against garbage wikitext markup match. Fixed the steps so that it fails when it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189623 (owner: 10Ryasmeen)
[23:55:19] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use css class instead of jquery show/hide [extensions/VisualEditor] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189144 (https://phabricator.wikimedia.org/T87420) (owner: 10Catrope)
[23:55:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Native leftarrow and rightarrow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177946 (owner: 10Divec)
[23:56:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] Fix only Media Test The media test was passing against garbage wikitext markup match. Fixed the steps so that it fails when it should. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189623 (owner: 10Ryasmeen)
[23:56:53] <wikibugs>	 3VisualEditor, VisualEditor-EditingTools: VisualEditor:[Regression wmf7] Uncaught TypeError: Cannot read property 'nodeType' of undefined ,on deleting the content in the Gallery inspector and clicking done - https://phabricator.wikimedia.org/T75224#1026657 (10Etonkovidova) 5Open>3Resolved p:5Triage>3Low
[23:56:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use css class instead of jquery show/hide [extensions/VisualEditor] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189144 (https://phabricator.wikimedia.org/T87420) (owner: 10Catrope)
[23:59:10] <mooeypoo>	 Krinkle, you around?