[00:00:17] Krinkle, I've been reading on async tests in qunit and I followed the new method, where you define a variable as assert.asynch() and call it at the end of the test. When I run the test in MW it passes. When I grunt, it fails the test, telling me "undefined is not a function" pointing to assert.async() -- are we using the same version of qunit in ve-core than we have in mw? [00:00:38] Krinkle, and for reference, i've been following this http://api.qunitjs.com/async/ [00:00:55] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: [regression] Inserting new internal link inserts text, but doesn't linkify it, if you complete the dialog before page title suggestions appear - https://phabricator.wikimedia.org/T75195#1026675 (10Etonkovidova) 5Open>3Resolved [00:10:02] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/189231/2..3/src/dm/ve.dm.AlignableNode.js +2? [00:10:44] (03CR) 10Catrope: [C: 032] Make CSS classes in alignable configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189231 (owner: 10Esanders) [00:12:22] (03Merged) 10jenkins-bot: Make CSS classes in alignable configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189231 (owner: 10Esanders) [00:12:28] (03Merged) 10jenkins-bot: Handle showHandles smartness in AlignableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187321 (owner: 10Esanders) [00:14:41] (03PS1) 10Mooeypoo: [WIP] Generalize ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [00:15:20] (03PS1) 10Mooeypoo: [WIP] Generalize ResourceQueue and ResourceProvider and supply tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [00:15:25] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Generalize ResourceQueue and ResourceProvider and supply tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [00:15:30] (03PS2) 10Mooeypoo: [WIP] Generalize ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [00:17:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Generalize ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [00:17:23] (03PS2) 10Mooeypoo: [WIP] Generalize ResourceQueue and ResourceProvider and supply tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [00:17:55] James_F: https://etherpad.wikimedia.org/p/dchanPlate2015 [00:18:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Generalize ResourceQueue and ResourceProvider and supply tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [00:19:15] 3VisualEditor, OOjs-UI: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1026700 (10Jdforrester-WMF) 5Open>3Resolved [00:19:25] 3VisualEditor, VisualEditor-EditingTools: VisualEditor:Unlimited cascade of references appear if an image with reference gets added as reference - https://phabricator.wikimedia.org/T59573#1026704 (10Etonkovidova) 5Open>3Resolved [00:20:55] mooeypoo: Which repo is this in? [00:21:01] mooeypoo: Yeah, ensure qunit js up to date :) [00:21:09] How? npm install? [00:21:30] However it is loaded, depends on the repo [00:21:36] unless it's mediawiki core, it'll be in package.json [00:21:38] for karma-qunit [00:21:40] qunitjs [00:21:51] Krinkle, ve-core [00:22:14] mooeypoo: Yeah, upgrade to 1.17 there and try again [00:22:25] qunitjs: 1.15.0 [00:22:42] I just ran npm install in lib/ve and I still get the same failure when I run grunt :( [00:23:07] mooeypoo: Did you set qunitjs: 1.17.1 in ve/package.json? [00:23:16] assert.async is new in 1.16 [00:23:30] Krinkle: Thank you for that. [00:23:43] Krinkle: "assert.async is new in 1.16" not documented. Great job. :-) [00:23:54] https://github.com/jquery/qunit/blob/1.17.1/History.md#1160--2014-12-03 [00:23:55] ish [00:24:29] the api site for qunitjs.com doesn't have the @since like api.jquery.com has. Don't know why. I'll let jquery-content team know [00:24:38] It's maintained separately now [00:24:48] * James_F nods. [00:24:49] Thanks. [00:24:50] Krinkle, \o/ it passes now! [00:25:15] ): [00:25:16] :) [00:28:07] https://github.com/jquery/api.qunitjs.com/issues/98 [00:29:27] (03PS3) 10Mooeypoo: [WIP] Generalize ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [00:30:19] (03PS2) 10Bartosz Dziewoński: DropdownWidget, ComboBoxWidget: Make keyboard-accessible [oojs/ui] - 10https://gerrit.wikimedia.org/r/189609 (https://phabricator.wikimedia.org/T87705) [00:31:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Generalize ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [00:32:16] (03PS30) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [00:37:16] James_F: Chrome is now 40.x in labs I see. [00:52:50] Krinkle: Yeah. [00:53:12] Krinkle: Can I get a +2 (or a -1) on https://gerrit.wikimedia.org/r/#/c/189637/ for core? [00:57:27] 3VisualEditor: VisualEditor: receiving a 'not logged in' warning on a page that shows that a user is logged in - https://phabricator.wikimedia.org/T75250#1026759 (10Etonkovidova) Since I do not have a way to manipulate session timeouts, we need to wait for timeout to occur naturally... 1. Open VE and wait for a... [01:00:52] 3VisualEditor, Wikimedia-Site-requests: Enable VisualEditor in Project namespace (ns 4) at cawiki - https://phabricator.wikimedia.org/T88896#1026764 (10Jdforrester-WMF) p:5Triage>3Normal a:3Glaisher [01:03:03] https://github.com/h5bp/Front-end-Developer-Interview-Questions [01:03:10] hmm, so we killed isolation, right? [01:03:19] Nice Google/jQuery effort side-project going on there at html5boilerplate :D [01:03:24] James_F: OK [01:04:11] Krinkle: Thanks. [01:06:21] (03CR) 10Catrope: [C: 032] Liberation from the oppressive this.$ regime [oojs/ui] - 10https://gerrit.wikimedia.org/r/188957 (owner: 10Trevor Parscal) [01:06:40] 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-EditingTools, Citoid: After Citoid fills in the data, please leave the citation open for review - https://phabricator.wikimedia.org/T89045#1026780 (10John_Broughton) At the moment, Citoid's building a citation from a URL is **wrong** at least 75% of t... [01:07:36] (03PS7) 10Catrope: Remove usage of this.$ and config.$ [oojs/ui] - 10https://gerrit.wikimedia.org/r/188957 (owner: 10Trevor Parscal) [01:07:53] (03CR) 10Catrope: "Changed commit title because James made me" [oojs/ui] - 10https://gerrit.wikimedia.org/r/188957 (owner: 10Trevor Parscal) [01:08:01] (03PS4) 10Mooeypoo: [WIP] Generalize ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [01:08:07] (03CR) 10Catrope: [C: 032] Remove usage of this.$ and config.$ [oojs/ui] - 10https://gerrit.wikimedia.org/r/188957 (owner: 10Trevor Parscal) [01:08:28] (03PS3) 10Mooeypoo: [WIP] Generalize ResourceQueue and ResourceProvider and supply tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [01:09:23] (03Merged) 10jenkins-bot: Remove usage of this.$ and config.$ [oojs/ui] - 10https://gerrit.wikimedia.org/r/188957 (owner: 10Trevor Parscal) [01:10:19] (03CR) 10Jforrester: [C: 031] Add attribute transformation for color attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189529 (owner: 10Catrope) [01:10:24] (03PS1) 10Bartosz Dziewoński: MenuSelectWidget: Remove dead code [oojs/ui] - 10https://gerrit.wikimedia.org/r/189644 [01:10:28] (03CR) 10jenkins-bot: [V: 04-1] MenuSelectWidget: Remove dead code [oojs/ui] - 10https://gerrit.wikimedia.org/r/189644 (owner: 10Bartosz Dziewoński) [01:10:51] James_F: killjoy [01:10:56] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Generalize ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [01:11:00] (03CR) 10Jforrester: [C: 031] ve.utils: Apply whitelist in setDomAttributes() attribute removal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189507 (owner: 10Krinkle) [01:11:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Generalize ResourceQueue and ResourceProvider and supply tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [01:12:30] (03CR) 10Jforrester: [C: 031] ve.utils: Cover insertIntoArray with unit test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189508 (owner: 10Krinkle) [01:12:43] (03PS2) 10Bartosz Dziewoński: MenuSelectWidget: Remove dead code [oojs/ui] - 10https://gerrit.wikimedia.org/r/189644 [01:12:53] (03CR) 10Jforrester: [C: 031] ve.utils: Clean up escapeHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189509 (owner: 10Krinkle) [01:12:57] I see OptionWidget does not take "data" as a param anymor ;/ [01:18:06] InezK: it's now a config option [01:23:08] 3RESTBase, MediaWiki-General-or-Unknown, VisualEditor: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1026800 (10GWicke) [01:25:01] 3RESTBase, MediaWiki-General-or-Unknown, VisualEditor, Services: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1026793 (10GWicke) [01:25:17] 3RESTBase, MediaWiki-General-or-Unknown, VisualEditor, Services: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1026806 (10GWicke) p:5Triage>3Normal [01:26:02] 3VisualEditor, Wikimedia-Site-requests: Enable VisualEditor in Project namespace (ns 4) at cawiki - https://phabricator.wikimedia.org/T88896#1026810 (10Jdforrester-WMF) 5Open>3Resolved Now done. [01:26:51] 3RESTBase, MediaWiki-General-or-Unknown, VisualEditor, Services: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1026815 (10Jdforrester-WMF) [01:27:18] InezK: also, note that in making it a config option we lifted the "must be unique" requirement as well [01:27:54] 3VisualEditor, Wikimedia-Site-requests: Enable VisualEditor in Project namespace (ns 4) at cawiki - https://phabricator.wikimedia.org/T88896#1026821 (10Jdforrester-WMF) [01:29:22] o hi TrevorParscal [01:29:27] hey [01:29:40] TrevorParscal: is it just me, or is TextInputMenuSelectWidget entirely superfluous now that we dropped isolation? [01:29:54] hmm [01:29:58] This menu is specially designed to be positioned beneath the text input widget. Even if the input [01:29:58] is in a different frame, the menu's position is automatically calculated and maintained when the [01:29:58] menu is toggled or the window is resized. [01:30:04] the $overlay stuff is still useful [01:30:20] but some of the crazy stuff, the iframe offset calculation [01:30:28] we can continue writing patches that simplify that stuff now [01:31:15] just don't mistake the need for $overlay support with the need for iframe support [01:31:33] but, the code you are talking about removing, it's really dead code anyway [01:32:53] the selectwidget hierarchy has been bugging me for a long time, and now i took a better look at it [01:33:08] (i'm cleaning up accessibility issues) [01:51:09] MatmaRex: Didn't I already factor out a bunch of the cross-frame position measurement logic into a static function in OO.ui.Element? [01:51:32] TrevorParscal: Which reminds me, OO.ui.Element.static.* might have some cross-frame remnants [01:51:58] it does [01:52:03] and we can start pulling those out as well [01:52:15] I just wanted to get us free from the .$ dictator first [01:52:31] we can always clean up the rubble left from years of war on our own time [01:53:48] RoanKattouw: yes [01:54:47] (03PS5) 10Mooeypoo: [WIP] Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [01:54:54] TrevorParscal: Can we build houses on the rubble and have jocks live in them? :P [01:55:33] (03PS1) 10Jforrester: build: Bump various devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/189649 [01:55:42] Given that my house was literally built on sand, I don't know that I can comment further [01:56:02] haha [01:56:16] Hey it wasn't built on earthquake rubble with open garages [01:56:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [01:56:41] "soft story" is what they called it [01:57:22] http://hompisano.com/wp-content/uploads/2011/01/Untitled-1.jpg ---> http://www.air-worldwide.com/uploadedImages/Publications_Pages/Publication_Item_Pages/AIR_Currents/Fig6_SoftStory.jpg [02:00:10] (03PS3) 10Bartosz Dziewoński: DropdownWidget, ComboBoxWidget: Make keyboard-accessible [oojs/ui] - 10https://gerrit.wikimedia.org/r/189609 (https://phabricator.wikimedia.org/T87705) [02:00:12] (03PS3) 10Bartosz Dziewoński: MenuSelectWidget: Codify current behavior of Tab closing the menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/189608 [02:00:14] (03PS3) 10Bartosz Dziewoński: TabIndexedElement: Actually allow tabIndex of -1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/189541 [02:00:24] (03PS3) 10Bartosz Dziewoński: [BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/189499 [02:01:05] (03PS4) 10Mooeypoo: [WIP] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [02:01:20] (03PS6) 10Mooeypoo: [WIP] Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [02:02:40] 3OOjs-UI: DropdownWidget and ComboBoxWidget dropdown arrow is not keyboard accessible - https://phabricator.wikimedia.org/T87705#1026899 (10matmarex) a:3matmarex [02:02:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [02:03:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [02:03:08] 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1026900 (10matmarex) a:3matmarex [02:03:23] 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1022938 (10matmarex) [02:03:24] 3OOjs-UI: Most button types do not support keyboard triggering - https://phabricator.wikimedia.org/T88090#1026901 (10matmarex) 5Open>3Resolved [02:03:53] 3UI-Standardization, OOjs-UI: Radio button hover state only appears when I mouse over the bottom part of it. - https://phabricator.wikimedia.org/T88035#1026906 (10matmarex) 5Open>3Resolved [02:04:16] (03Abandoned) 10Bartosz Dziewoński: [wip] CheckboxInputWidget: Apply hover event properly [oojs/ui] - 10https://gerrit.wikimedia.org/r/189125 (https://phabricator.wikimedia.org/T88035) (owner: 10Mooeypoo) [02:05:21] 3OOjs-UI: RadioSelectWidget is not accessible - https://phabricator.wikimedia.org/T88082#1026911 (10matmarex) [02:05:22] 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1026910 (10matmarex) [02:05:37] (03PS1) 10Jforrester: build: Bump various devDependencies [oojs/ui] - 10https://gerrit.wikimedia.org/r/189650 [02:05:39] (03PS1) 10Jforrester: History: Fix date typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/189651 [02:07:06] 3OOjs-UI: RadioSelectWidget is not accessible - https://phabricator.wikimedia.org/T88082#1003700 (10matmarex) [02:07:12] 3OOjs-UI: RadioSelectWidget is not accessible - https://phabricator.wikimedia.org/T88082#1003700 (10matmarex) So this helps somewhat, but the widget is actually completely busted – toggling the state of radios using the keyboard doesn't update other options in the same select, so you just always end up with all... [02:09:11] (03PS2) 10Bartosz Dziewoński: History: Fix date typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/189651 (owner: 10Jforrester) [02:09:18] (03CR) 10Bartosz Dziewoński: [C: 032] History: Fix date typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/189651 (owner: 10Jforrester) [02:10:30] (03Merged) 10jenkins-bot: History: Fix date typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/189651 (owner: 10Jforrester) [02:14:33] MatmaRex: That was intentionally stacked to make you merge the parent. :-P [02:15:03] maybe tomorrow [02:15:25] * James_F glares. [02:15:31] maaaaaybe. [02:15:59] hey, i don't wanna break CI more than it is already broken [02:16:11] :D [02:16:24] This is for /fixing/ CI, though, and you know it. [02:16:43] lies and half-truths. [02:16:48] night! ~ [02:28:58] 3RESTBase, MediaWiki-General-or-Unknown, VisualEditor, Services: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1026943 (10GWicke) [02:30:25] (03CR) 10Krinkle: [WIP] Create ResourceProvider and ResourceQueue and add tests (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [02:30:56] James_F: Hm.. So, npm/grunt/karma for non-mw involving repos seems pretty stable, right? [02:31:09] Krinkle: Yes. [02:31:09] oojs-ui and VE for example. Wheraes they too use Chrome [02:31:38] The regression we found due to socket.io and node_modules purging was mwcore/mwext specific, but that's been solved. [02:33:13] (03CR) 10Krinkle: [C: 032] build: Bump various devDependencies [oojs/ui] - 10https://gerrit.wikimedia.org/r/189650 (owner: 10Jforrester) [02:33:30] Hmm. [02:33:34] (03CR) 10Krinkle: [C: 032] build: Bump various devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/189649 (owner: 10Jforrester) [02:34:02] The Disconnect thing.. could be a lot of things, but I don't yet have a theory for something that would make it specific to mw env [02:34:21] (03Merged) 10jenkins-bot: build: Bump various devDependencies [oojs/ui] - 10https://gerrit.wikimedia.org/r/189650 (owner: 10Jforrester) [02:34:31] * James_F nods. [02:34:39] The disconnect happens in non-MW environments. [02:34:41] other than Apache and MediaWiki being used instead of a static file server, which is a proxy for a lot of possible causes [02:34:46] Thought it might be posioning? [02:35:14] The last 5 failures in mwcore-karma and mwext-ve-karma didn't run concurrent with other karma builds on the same host [02:35:26] (including ve-core and oojs are karma builds) [02:35:27] Hmm. [02:35:54] It seems to often stop after 142 tests [02:36:00] Yeah. [02:36:03] (03Merged) 10jenkins-bot: build: Bump various devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/189649 (owner: 10Jforrester) [02:36:07] Could be an issue exposed in the mediawiki core qunit tests [02:36:13] Is there something special about our 143rd test? [02:36:20] The 142/143th test is quite tricky indeed [02:36:28] jqueryMsg.test involving load.php/api.php requests [02:36:37] Hmm. [02:36:43] Seems sane that that could be an issue. [02:38:42] Though I wrote that hack. It works locally in Chrome/Fireofx. And has run under phantomjs on Jenkins for over a year fine. I suspect it may be caused by the move to labs and the inherent increased contrast/saturation of errors due to that being slower [02:38:47] Perhaps a timeout. [02:38:56] (the jqueryMsg.test hack that is) [02:41:29] (03PS5) 10Mooeypoo: [WIP] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [02:42:11] (03PS6) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [02:42:31] (03PS7) 10Mooeypoo: Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [02:43:44] (03CR) 10jenkins-bot: [V: 04-1] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [02:43:44] 3VisualEditor, Flow, §Collaboration-Team, WikiEditor: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1026966 (10Quiddity) >>! In T78346#1017880, @He7d3r wrote: > I miss my custom buttons in the edit toolbar. > See also: > * {T23692} I installed 3 of your scri... [02:45:14] (03CR) 10jenkins-bot: [V: 04-1] Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [02:49:41] (03PS7) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [02:49:54] (03PS8) 10Mooeypoo: Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [02:50:51] (03CR) 10jenkins-bot: [V: 04-1] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [02:52:22] (03CR) 10jenkins-bot: [V: 04-1] Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [02:52:48] 3VisualEditor: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T89072#1026973 (10KHammerstein) 3NEW [02:55:43] (03PS1) 10Jforrester: build: Bump various devDependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189656 [02:55:45] (03PS1) 10Jforrester: IMETests: Group them with CE tests again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189657 [02:58:34] 3OOjs-UI: Remove weird display measurement logic in ListToolGroup - https://phabricator.wikimedia.org/T89073#1026981 (10Catrope) 3NEW a:3matmarex [02:58:48] 3VisualEditor: Create a guided tour for VisualEditor using Getting Started tooltips - https://phabricator.wikimedia.org/T89074#1026989 (10KHammerstein) 3NEW [02:58:50] 3OOjs-UI: Remove weird display measurement logic in ListToolGroup - https://phabricator.wikimedia.org/T89073#1026998 (10Catrope) [02:59:07] 3VisualEditor: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T89072#1026973 (10KHammerstein) [03:00:03] 3VisualEditor, Continuous-Integration: Investigate Chrome disconnect failures when running MediaWiki tests on labs slaves - https://phabricator.wikimedia.org/T89075#1027004 (10Krinkle) 3NEW a:3Krinkle [03:59:33] 3WikiEditor: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1027042 (10GOIII) You shouldn't be able to re-pro either of them as well as the other two in today's terms - they've all (finally) been resolved as far as I know (& have personally tested for as well).... [04:13:42] 3WikiEditor: Patch Watch - existing gerrit patches that aren't associated with any specific task - https://phabricator.wikimedia.org/T86708#1027061 (10GOIII) [06:44:34] (03PS1) 10Ori.livneh: Fix V8 deopt for ve.ce.BranchNode.onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189683 [06:47:20] RoanKattouw_away: did you file a bug for OO.ui.ListToolGroup.populate? [07:04:25] 3VisualEditor, VisualEditor-Performance, OOjs-UI: OO.ui.Element.static.reconsiderScrollbars reflow is too expensive - https://phabricator.wikimedia.org/T89082#1027149 (10ori) 3NEW a:3matmarex [07:05:19] 3VisualEditor, VisualEditor-Performance, OOjs-UI: OO.ui.Element.static.reconsiderScrollbars reflow is too expensive - https://phabricator.wikimedia.org/T89082#1027158 (10ori) [07:06:07] Krinkle: maybe you have some ideas ^ [07:06:26] ori: I'm looking at onSplice, wondering why those are variadic arguments at all [07:06:56] ori: is onSplice hot part of code? [07:07:06] yes, very [07:07:13] cool [07:09:07] http://i.imgur.com/8fHntin.png -- though you can't really tell from this view (self is only 1.4ms) but if you keep drilling down you get to onSplice again, since it calls itself (not directly) [07:09:46] Yeah [07:14:45] Hm.. converting to an array is non-trivial since it's mixed with native calls to Array#splice plus 2 additional arguments in front [07:15:27] (03PS2) 10Krinkle: Fix V8 deopt for ve.ce.BranchNode#onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189683 (owner: 10Ori.livneh) [07:15:34] (03CR) 10Krinkle: [C: 031] Fix V8 deopt for ve.ce.BranchNode#onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189683 (owner: 10Ori.livneh) [07:15:46] .static-member #instance-member [07:16:46] 3VisualEditor, VisualEditor-Performance, OOjs-UI: OO.ui.Element.static.reconsiderScrollbars reflow is too expensive - https://phabricator.wikimedia.org/T89082#1027167 (10Krinkle) [07:17:12] ori: I'm not familiar with that bug at the moment. Will look into it tomorrow. [07:18:38] cool. i'm out too, good night. [08:03:23] 3OOjs-UI: RadioSelectWidget is not accessible - https://phabricator.wikimedia.org/T88082#1027227 (10TheDJ) The input don't share a name attribute, so they don't belong together in the HTML sense, thus are not mutual exclusive in their behavior. [09:36:16] (03CR) 10Krinkle: "There seems to a suspicious overlap between setTabIndex and setDisabled." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189541 (owner: 10Bartosz Dziewoński) [09:38:37] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Update the definition of formula_image element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188795 (owner: 10Amire80) [09:41:32] (03Merged) 10jenkins-bot: [BrowserTest] Update the definition of formula_image element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188795 (owner: 10Amire80) [10:24:13] 3VisualEditor, VisualEditor-CopyPaste: Copy cuts out templates - https://phabricator.wikimedia.org/T89099#1027455 (10Sunpriat) 3NEW [10:25:25] 3VisualEditor, VisualEditor-CopyPaste: Copy cuts out templates - https://phabricator.wikimedia.org/T89099#1027466 (10Sunpriat) [10:38:10] 3VisualEditor: template and comments - https://phabricator.wikimedia.org/T89101#1027488 (10Sunpriat) 3NEW [10:47:57] 3VisualEditor: invisible templates in the visual editor - https://phabricator.wikimedia.org/T89105#1027542 (10Sunpriat) 3NEW [10:50:29] (03PS1) 10Esanders: Use ve.ui.AlignWidget in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189712 [10:59:26] 3VisualEditor, VisualEditor-ContentLanguage, VisualEditor-ContentEditable: interface to support extensions that provide on-screen keyboards for Visual Editor - https://phabricator.wikimedia.org/T86479#1027598 (10Ilya) Hi, VirtualKeyboard demo is up and running, you can check it by the link above. As long as VE... [11:03:16] 3VisualEditor: inserting characters « » - https://phabricator.wikimedia.org/T89109#1027607 (10Sunpriat) 3NEW [11:07:46] 3VisualEditor: in the Help text on the button in two lines - https://phabricator.wikimedia.org/T89112#1027643 (10Sunpriat) 3NEW [11:08:43] 3VisualEditor, Flow, §Collaboration-Team, WikiEditor: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1027651 (10He7d3r) On talk pages, I believe these are the custom buttons I use the most: > test > test > 3VisualEditor: ":" and bold vs ";" - https://phabricator.wikimedia.org/T89115#1027692 (10Sunpriat) [11:32:51] (03CR) 10Esanders: MenuSelectWidget: Remove dead code (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/189644 (owner: 10Bartosz Dziewoński) [11:35:51] (03CR) 10Esanders: "also why >= -1 at all. any negative value is valid." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189541 (owner: 10Bartosz Dziewoński) [12:15:31] 3VisualEditor: narrow field of the row parameter - https://phabricator.wikimedia.org/T89119#1027759 (10Sunpriat) 3NEW [12:27:16] 3VisualEditor: allow edit templates inside parameters of other templates - https://phabricator.wikimedia.org/T89121#1027783 (10Sunpriat) [12:38:59] 3VisualEditor, VisualEditor-EditingTools: inserting characters « » - https://phabricator.wikimedia.org/T89109#1027793 (10Aklapper) [12:39:16] 3VisualEditor, VisualEditor-EditingTools: Characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1027796 (10Aklapper) [12:39:42] 3VisualEditor, VisualEditor-EditingTools: Characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1027607 (10Aklapper) Which browser is this about and on which wiki site is this on? Both that info is always welcome. Thanks! [12:56:32] 3VisualEditor, VisualEditor-EditingTools: Characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1027813 (10Sunpriat) ubuntu, firefox 35.0.1 - two lines (chromium "40.0.2214.94 Ubuntu 14.10 (64-bit)" - ok) [13:16:52] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1027841 (10Aklapper) The last two comments here are pretty hard to read. Ordered list of steps would be welcome. :) Also, when answering via email it would be great if you could remove any unneeded quotes and [[ https://en.wikipe... [13:19:48] 3VisualEditor: invisible templates in the visual editor - https://phabricator.wikimedia.org/T89105#1027844 (10Sunpriat) [13:23:38] 3VisualEditor, Possible-Tech-Projects: Visual translation: Integration of page translation with VisualEditor - https://phabricator.wikimedia.org/T89125#1027847 (10NiharikaKohli) 3NEW [13:26:09] 3VisualEditor, VisualEditor-EditingTools: Characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1027853 (10Aklapper) So this only happens in Firefox and not in Chrome? Clear sentences welcome, not sure how to interpret your " - ok" above... [13:45:15] 3VisualEditor, VisualEditor-EditingTools: Characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1027894 (10Sunpriat) chromium 40.0.2214.94 without and with log in ruwiki {F38999} enwiki (I do not see characters « ») {F39001} if change language in ewiki (?setla... [13:59:56] 3VisualEditor, VisualEditor-EditingTools: Characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1027938 (10Sunpriat) https://translatewiki.net/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert/ru « » with space @Aklapper Can I add additiona... [14:12:11] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1027958 (10Susann_Schweden) When '''I''' do it, right now, a second ago, it does not work! It is NOT inserted in the editing box. The cursor just dissappears from it´s place and nothing else happens. (When I do the same action as... [14:14:22] 3VisualEditor, Possible-Tech-Projects: Visual translation: Integration of page translation with VisualEditor - https://phabricator.wikimedia.org/T89125#1027967 (10Qgil) [14:14:25] 3MediaWiki-extensions-Translate, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#1027968 (10Qgil) [14:14:42] 3MediaWiki-extensions-Translate, Possible-Tech-Projects, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#578193 (10Qgil) [14:16:13] (03PS3) 10Bartosz Dziewoński: MenuSelectWidget: Remove dead code [oojs/ui] - 10https://gerrit.wikimedia.org/r/189644 [14:31:44] (03PS2) 10Esanders: Add table styles for block images and move to init.sa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189295 [14:35:20] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1028020 (10Susann_Schweden) when I move the cursor over the Ä because I want to select it for insert, it says: javascript:void() in the lefthand down corner of my screen Den tisdag, 10 februari 2015 15:12 skrev Susann_Schw... [14:38:16] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#1028027 (10marcoil) [14:42:34] (03PS3) 10Esanders: Add table styles for block images and move to init.sa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189295 [14:59:28] 3VisualEditor, VisualEditor-Performance, Parsoid: Add original dimensions information from the API to data-mw - https://phabricator.wikimedia.org/T64881#1028078 (10marcoil) [15:00:00] 3VisualEditor, Parsoid, VisualEditor-Tables: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1028081 (10marcoil) [15:00:40] 3VisualEditor, Parsoid, VisualEditor-Tables: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#1028085 (10marcoil) [15:01:07] 3VisualEditor-MediaWiki, VisualEditor, Parsoid: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#1028086 (10marcoil) [15:05:17] 3VisualEditor, VisualEditor-Performance, Parsoid: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1028094 (10marcoil) p:5High>3Normal [15:08:31] 3VisualEditor, VisualEditor-Performance, Parsoid: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1028100 (10marcoil) p:5Normal>3High [15:10:53] 3VisualEditor, VisualEditor-Performance, Parsoid: Measure how often Parsoid cache misses happen, and what load performance is like in this case - https://phabricator.wikimedia.org/T86733#1028104 (10marcoil) [15:29:54] (03PS1) 10Esanders: Avoid jQuery in ve.dm.BlockImageNode.static.toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189736 [15:29:56] (03PS1) 10Esanders: Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 [15:32:30] (03PS1) 10Amire80: Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 [15:32:50] (03PS2) 10Amire80: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 [15:33:11] (03CR) 10jenkins-bot: [V: 04-1] Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [15:34:12] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1028144 (10Aklapper) Please do NOT full-quote my entire previous comment when replying to emails. It makes this task very hard to read. Please do remove unneeded quotes from emails. If you think that there is a problem with JavaS... [15:36:32] 3VisualEditor: language screenshots fail with a JavaScript error - https://phabricator.wikimedia.org/T89139#1028150 (10Amire80) 3NEW [15:48:48] Hello all. Will the triage meeting tomorrow be held here, in #wikimedia-office, somewhere else...? [15:50:12] valhallasw`cloud: The meeting will be on WebEx; there will be an IRC back-channel but most of the meeting attendants won't be on IRC. [15:50:56] valhallasw`cloud: The joining instructions will be posted to https://www.mediawiki.org/wiki/Talk:VisualEditor/Portal once final. [15:51:50] James_F: ok; no WebEx account is required, I assume? [15:52:06] valhallasw`cloud: No, and you can also call in with a phone if you really want. :-) [15:53:06] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1028207 (10Susann_Schweden) sorry, I did not notice that I sent all of it again :( It is the very first time I am engaged in this kind of kommunication. To javascript: I have javascript.enabled true ( in about:config) . I started... [15:56:05] James_F: I've added a note to https://www.mediawiki.org/w/index.php?title=Talk%3AVisualEditor%2FPortal&diff=1404781&oldid=787744 [15:56:20] valhallasw`cloud: Gah. Edit conflict. :-P [15:56:30] sorry :D [15:56:39] No worries. I wasn't ready to save yet anyway. [16:02:25] 3VisualEditor: Copy/pasting deletes references, can't save - https://phabricator.wikimedia.org/T89146#1028218 (10Elitre) 3NEW [16:10:24] (03PS4) 10Bartosz Dziewoński: TabIndexedElement: Actually allow tabIndex of -1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/189541 [16:12:03] (03PS1) 10Amire80: [BrowserTest] Removing all rules from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189744 [16:12:39] 3VisualEditor, VisualEditor-EditingTools: Characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1028238 (10Aklapper) > Can I add additional characters Please bring up support requests on a better suited talk page (e.g. [[ https://www.mediawiki.org/wiki/Help_t... [16:15:03] (03Abandoned) 10Amire80: [BrowserTest] Removing all rules from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189744 (owner: 10Amire80) [16:34:16] 3VisualEditor: language screenshots fail with a JavaScript error - https://phabricator.wikimedia.org/T89139#1028275 (10zeljkofilipin) Looks like Firefox 35 does not work with Selenium: https://code.google.com/p/selenium/issues/detail?id=8390 Please downgrade to Firefox 34 or use Chrome. [16:37:04] 3OOjs-UI: Remove weird display measurement logic in ListToolGroup - https://phabricator.wikimedia.org/T89073#1028286 (10matmarex) p:5Triage>3Normal [16:38:35] So how to get "WebEx" to join the triage meeting tomorrow (whatever that is)? [16:39:54] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1028287 (10Susann_Schweden) "Use of "wgAction" is deprecated. Use mw.config instead." load.php:154 console.trace(): load.php:154 mw.log load.php:1 "... [16:40:33] 3OOjs-UI: Remove weird display measurement logic in ListToolGroup - https://phabricator.wikimedia.org/T89073#1026981 (10matmarex) > The comment seems to suggest the whole thing is a workaround for a bug in jQuery `.show()`/`.hide()`, so maybe we don't even need it at all? Yep. [16:41:12] (03PS1) 10Bartosz Dziewoński: ListToolGroup: Remove hack for jQuery's .show()/.hide() [oojs/ui] - 10https://gerrit.wikimedia.org/r/189751 (https://phabricator.wikimedia.org/T89073) [16:41:55] 3VisualEditor: language screenshots fail with a JavaScript error - https://phabricator.wikimedia.org/T89139#1028303 (10Amire80) Yes, but I have Firefox 33. [16:42:19] (03CR) 10Zfilipin: [C: 04-1] "You have forgot to delete spec folder from this repo. :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [16:48:45] andre__: cisco's videoconferencing thing. I assume there's just an url you click, just like with G+ [16:49:10] 3VisualEditor: language screenshots fail with a JavaScript error - https://phabricator.wikimedia.org/T89139#1028319 (10zeljkofilipin) Does it work in Chrome? [16:49:11] yeah... well okay then. was wondering if it needs some client side installation [16:53:23] 3VisualEditor, VisualEditor-Performance, OOjs-UI: OO.ui.Element.static.reconsiderScrollbars reflow is too expensive - https://phabricator.wikimedia.org/T89082#1028325 (10matmarex) Well… we could go and fix the Chrome bug. Or we could stop using the workaround and live with phantom scrollbars. Or just use `overfl... [17:02:01] (03PS1) 10Bartosz Dziewoński: PopupWidget: Set $clippable only once, correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/189755 (https://phabricator.wikimedia.org/T89082) [17:15:17] (03CR) 10Vikassy: [C: 04-1] "You can also remove 'rspec' from Gemfile after removing spec folder" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [17:24:11] (03CR) 10Zfilipin: "Welcome back Vikas! :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [17:30:40] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34273847 [17:30:40] Corruption alert: visualeditor-needcheck on bgwiki: https://bg.wikipedia.org/?diff=6482287 [17:36:48] 3VisualEditor, VisualEditor-EditingTools: Pasting text with a line that starts with : (colon) / ; (semi-colon) turns it bold/indented (but button status does not reflect that) - https://phabricator.wikimedia.org/T89115#1028437 (10Aklapper) [17:38:52] (03PS1) 10Amire80: [BrowserTest] Remove most exceptions from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189760 [17:44:25] (03PS3) 10Amire80: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 [17:53:08] (03PS1) 10Mvolz: Fix: Position dialog after other citation tools [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189762 (https://phabricator.wikimedia.org/T87822) [17:56:55] 3VisualEditor, VisualEditor-MediaWiki-References, Citoid: "Autofill from URL" option changes its position in the menu for newly created page - https://phabricator.wikimedia.org/T87822#1028483 (10Mvolz) So, this was basically a race condition between whether the cite tools being created in init.mw.Target.js happe... [17:58:33] (03CR) 10Jforrester: [C: 031] Fix: Position dialog after other citation tools [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189762 (https://phabricator.wikimedia.org/T87822) (owner: 10Mvolz) [18:04:38] (03PS4) 10Bartosz Dziewoński: MenuSelectWidget: Remove dead code [oojs/ui] - 10https://gerrit.wikimedia.org/r/189644 [18:04:40] (03PS4) 10Bartosz Dziewoński: DropdownWidget, ComboBoxWidget: Make keyboard-accessible [oojs/ui] - 10https://gerrit.wikimedia.org/r/189609 (https://phabricator.wikimedia.org/T87705) [18:04:42] (03PS4) 10Bartosz Dziewoński: MenuSelectWidget: Codify current behavior of Tab closing the menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/189608 [18:04:44] (03PS5) 10Bartosz Dziewoński: TabIndexedElement: Actually allow tabIndex of -1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/189541 [18:04:46] (03PS1) 10Bartosz Dziewoński: PopupElement: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189765 [18:04:48] (03PS1) 10Bartosz Dziewoński: TextInputMenuSelectWidget: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189766 [18:06:56] 3VisualEditor, VisualEditor-ContentLanguage, VisualEditor-ContentEditable: interface to support extensions that provide on-screen keyboards for Visual Editor - https://phabricator.wikimedia.org/T86479#1028518 (10Nemo_bis) >>! In T86479#1027598, @Ilya wrote: > * Language list > * User profile settings > * Languag... [18:14:13] ori: osmium seems to be broken in an interesting way now, it's not executing PHP any more [18:14:26] catrope@osmium:~$ curl -H "Host: en.wikipedia.org" http://localhost/wiki/Barack_Obama | less [18:14:33] header( 'Content-Type: text/html; charset=utf-8' ); [18:14:36] etc [18:15:31] ori: Also, yes I filed that ListToolGroup thing: https://phabricator.wikimedia.org/T89073 [18:15:55] (03CR) 10Catrope: [C: 032] ListToolGroup: Remove hack for jQuery's .show()/.hide() [oojs/ui] - 10https://gerrit.wikimedia.org/r/189751 (https://phabricator.wikimedia.org/T89073) (owner: 10Bartosz Dziewoński) [18:16:08] ...and that's Bartosz commit that fixes it :) [18:16:15] ~ [18:16:51] (03PS2) 10Catrope: PopupWidget: Set $clippable only once, correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/189755 (https://phabricator.wikimedia.org/T89082) (owner: 10Bartosz Dziewoński) [18:17:30] (03CR) 10Catrope: [C: 032] PopupWidget: Set $clippable only once, correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/189755 (https://phabricator.wikimedia.org/T89082) (owner: 10Bartosz Dziewoński) [18:17:40] 3VisualEditor, VisualEditor-MediaWiki-References, Citoid: Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-selected - https://phabricator.wikimedia.org/T88152#1028566 (10Mvolz) Trevor; at KIT they said you were changing how this was done soon? [18:17:56] (03Merged) 10jenkins-bot: ListToolGroup: Remove hack for jQuery's .show()/.hide() [oojs/ui] - 10https://gerrit.wikimedia.org/r/189751 (https://phabricator.wikimedia.org/T89073) (owner: 10Bartosz Dziewoński) [18:18:14] mooeypoo: https://gerrit.wikimedia.org/r/#/c/189656/ [18:18:46] (03Merged) 10jenkins-bot: PopupWidget: Set $clippable only once, correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/189755 (https://phabricator.wikimedia.org/T89082) (owner: 10Bartosz Dziewoński) [18:20:06] (03CR) 10Mooeypoo: [C: 032] build: Bump various devDependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189656 (owner: 10Jforrester) [18:21:57] (03Merged) 10jenkins-bot: build: Bump various devDependencies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189656 (owner: 10Jforrester) [18:22:17] RoanKattouw: Please review: https://gerrit.wikimedia.org/r/#/c/189295/ https://gerrit.wikimedia.org/r/#/c/189736/ https://gerrit.wikimedia.org/r/#/c/189737/ in VE-core; https://gerrit.wikimedia.org/r/#/c/189712/ in VE-MW. [18:22:30] (03PS9) 10Jforrester: Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [18:23:46] RoanKattouw, what does "Unstaged changes" error in jenkins' mwext-VisualEditor-npm test mean? It's on categories.json and eg-iframe.html -- is it because the two files I added there are actually being added in the other commit (so they don't exist yet) ? [18:23:53] edsanders: Please review: https://gerrit.wikimedia.org/r/#/c/189507/ https://gerrit.wikimedia.org/r/#/c/189508/ https://gerrit.wikimedia.org/r/#/c/189509/ https://gerrit.wikimedia.org/r/#/c/189529/ https://gerrit.wikimedia.org/r/#/c/189627/ in VE-core; https://gerrit.wikimedia.org/r/#/c/186548/ https://gerrit.wikimedia.org/r/#/c/188741/ in VE-MW. [18:24:50] mooeypoo: It means that you have made changes that, when grunt runs, cause grunt to modify those files [18:24:54] RoanKattouw: I'm helping mooeypoo, don't worry. [18:24:58] James_F, https://gerrit.wikimedia.org/r/#/c/189628/7 [18:24:59] So you should run grunt locally, then commit the resulting modifications [18:27:06] (03CR) 10Catrope: "Let's benchmark this one once osmium is no longer broken" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189683 (owner: 10Ori.livneh) [18:27:10] RoanKattouw: It's a pull-through commit, it's unfixable. [18:27:24] ugh [18:27:33] TrevorParscal: give me a reason not to stab you for GroupWidget. [18:27:41] ha ha ha [18:27:44] RoanKattouw: It'll work fine as soon as the thing it's pulling through is merged. :-) [18:27:58] any particular gripe? [18:28:39] TrevorParscal: yeah, it is a mixin that inherits from a mixin; so when it is mixed into things, the parent mixin has to be mixed in separately [18:28:50] RoanKattouw: Is that "Let's benchmark this one once osmium is no longer broken [and not merge it until then]" or "Let's benchmark this one once osmium is no longer broken [but merge it now]"? [18:29:01] TrevorParscal: also, you just told me yesterday that mixins should provide unified APIs rather than just unified behaviors ;) [18:29:02] James_F: and not merge it until then [18:29:07] James_F: Want me to -1/-2 for that? [18:29:14] also, i would just fold it into GroupElement, really [18:29:26] RoanKattouw: Ideally, yeah. So others don't spend time. [18:29:30] k [18:29:37] (03CR) 10Catrope: [C: 04-1] Fix V8 deopt for ve.ce.BranchNode#onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189683 (owner: 10Ori.livneh) [18:29:47] so.. GroupWidget... [18:30:17] (i'm trying to understand SelectWidget and subclasses right now) [18:30:21] the only reason for this akwardness is to make disabled propagate [18:30:37] (03PS1) 10Catrope: [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 [18:30:39] because OO.ui.Element doesn't have a concept of disabled [18:30:45] 3VisualEditor, VisualEditor-Performance, OOjs-UI: OO.ui.Element.static.reconsiderScrollbars reflow is too expensive - https://phabricator.wikimedia.org/T89082#1028607 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [18:31:06] that doesn't stop us from calling setDisabled in Elements (mixins) [18:31:21] or at least hasn't stopped me… i did that in TabIndexedElement [18:31:37] 3OOjs-UI: Remove weird display measurement logic in ListToolGroup - https://phabricator.wikimedia.org/T89073#1028611 (10Jdforrester-WMF) 5Open>3Resolved [18:31:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 (owner: 10Catrope) [18:31:56] so we have to mixin GroupWidget and ItemWidget to add the "I track my children's state" to the group and the "my state is based on multiple factors" to the items behavior [18:32:23] so... I agree that this sucks [18:33:33] this is where my current modeling of the problem using OO hits the wall I guess [18:33:38] I'm very open to ideas [18:33:50] i wish it were simpler [18:33:53] (03CR) 10Esanders: [C: 032] TabIndexedElement: Actually allow tabIndex of -1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/189541 (owner: 10Bartosz Dziewoński) [18:34:16] edsanders: OOjs UI isn't getting a new version before tomorrow; focussing on VE would be helpful. :-) [18:35:11] (03Merged) 10jenkins-bot: TabIndexedElement: Actually allow tabIndex of -1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/189541 (owner: 10Bartosz Dziewoński) [18:35:27] (03PS1) 10Mvolz: Clean-up unnessecary calls of dialog.popPending() [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189773 [18:35:52] TrevorParscal: okay… we only want to make disabledness state inheritable, right? if parent disabled, then children disabled. and not the other way, if all children disabled, then parent disabled (although tools do that, we don't need it in general case?) [18:36:31] (03CR) 10Jforrester: [C: 032] TextInputMenuSelectWidget: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189766 (owner: 10Bartosz Dziewoński) [18:36:43] (03CR) 10Esanders: [C: 032] ve.utils: Clean up escapeHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189509 (owner: 10Krinkle) [18:36:46] (03CR) 10Jforrester: [C: 032] PopupElement: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189765 (owner: 10Bartosz Dziewoński) [18:36:52] 3VisualEditor, VisualEditor-Tables: VisualEditor: disable bold formatting button in toolbar when editing a header cell - https://phabricator.wikimedia.org/T89155#1028614 (10Inkowik) 3NEW [18:37:10] (03PS2) 10Bartosz Dziewoński: TextInputMenuSelectWidget: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189766 [18:37:15] (03PS2) 10Bartosz Dziewoński: PopupElement: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189765 [18:37:29] James_F: again, please? ^ [18:37:35] Meh. [18:37:42] (03PS2) 10Mvolz: Clean-up unnessecary calls of dialog.popPending() [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189773 [18:37:46] (03CR) 10Esanders: [C: 032] Fix: Position dialog after other citation tools [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189762 (https://phabricator.wikimedia.org/T87822) (owner: 10Mvolz) [18:37:54] MatmaRex: Rebases? [18:38:02] cherry-pick to master [18:38:06] So, yes. [18:38:08] * James_F sighs. [18:38:08] (03CR) 10Esanders: [C: 032] Add attribute transformation for color attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189529 (owner: 10Catrope) [18:38:12] Unnecessary. [18:38:13] (03Merged) 10jenkins-bot: Fix: Position dialog after other citation tools [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189762 (https://phabricator.wikimedia.org/T87822) (owner: 10Mvolz) [18:38:18] (03CR) 10Jforrester: [C: 032] PopupElement: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189765 (owner: 10Bartosz Dziewoński) [18:38:34] (03CR) 10Jforrester: [C: 032] TextInputMenuSelectWidget: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189766 (owner: 10Bartosz Dziewoński) [18:38:46] James_F: they depend on a stack of non-trivial changes, and that stack is already too long and going to get longer. [18:38:50] depended* [18:39:17] MatmaRex: None of them are going out soon, you understand. Next cut of OOjs UI is tomorrow/Thursday. There's no need to rush. [18:39:37] (03Merged) 10jenkins-bot: PopupElement: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189765 (owner: 10Bartosz Dziewoński) [18:39:49] (03Merged) 10jenkins-bot: TextInputMenuSelectWidget: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/189766 (owner: 10Bartosz Dziewoński) [18:39:55] sure. it is bugging me, though. [18:40:06] (03CR) 10Esanders: [C: 04-1] ve.utils: Cover insertIntoArray with unit test (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189508 (owner: 10Krinkle) [18:40:07] i heard you need us to be happy. ;) [18:40:42] (03Merged) 10jenkins-bot: Add attribute transformation for color attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189529 (owner: 10Catrope) [18:41:10] (03CR) 10Esanders: [C: 031] "I think this is Roan's code" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189507 (owner: 10Krinkle) [18:41:20] (03PS3) 10Mvolz: Clean-up unnessecary calls of dialog.popPending() [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189773 [18:41:38] RoanKattouw: Ed wants you to review https://gerrit.wikimedia.org/r/189507 too. [18:42:30] TrevorParscal: i'm not going to do it right now, but i'm fairly sure we could kill both ItemWidget and GroupWidget and just implement bidirectional disabledness mirroring in GroupElement. [18:42:36] 3VisualEditor, VisualEditor-MediaWiki-References, Citoid: "Autofill from URL" option changes its position in the menu for newly created page - https://phabricator.wikimedia.org/T87822#1028636 (10Jdforrester-WMF) 5Open>3Resolved a:3Mvolz [18:42:58] RoanKattouw: nice. MatmaRex's fix should shave ~90ms [18:43:02] TrevorParscal: would we ever want to mix anything into a non-Widget, anyway? (do we do that?) [18:43:32] ori: I'm looking at that now [18:43:45] Reflows have a tendency to be a game of whack-a-mole though [18:44:03] If there was other code also causing a reflow, it may previously have hitched a free ride on the reflow we just eliminated [18:44:12] MatmaRex: maybe not? [18:44:36] I guess we do for Layouts, but the delineation between Layout and Widget is possibly unnessecary [18:45:15] hmm [18:45:52] 3VisualEditor, VisualEditor-Tables: VisualEditor: disable bold formatting button in toolbar when editing a header cell - https://phabricator.wikimedia.org/T89155#1028644 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF > Disable the toolbar button for bold text when editing a header (th) cell of a ta... [18:46:01] ori: Also I don't know if you did anyhthing but osmium is unbroken now [18:46:03] anyway, something to think about. [18:46:07] RoanKattouw: yes, i just unbroke it [18:46:17] Cool [18:46:17] RoanKattouw: do you mind if i remove the luasandbox hack? that should be fixed now too [18:46:26] OK [18:46:30] But if it breaks again I'll put it back [18:46:36] what was the luasandbox hack? [18:46:56] ori: BTW I have a hack that I'll show you once I come in that lets you run Obama locally [18:47:03] \o/ [18:47:18] Krenair: had to disable it because for some reason requests on osmium were getting handled by mod_php and not hhvm [18:47:21] Krenair: We disabled LuaSandbox on osmium because it broke for mysterious reasons [18:47:25] oooh [18:48:15] we had some fun with luasandbox on silver (wikitech) yesterday [18:48:37] which was also running normal php [18:49:06] the luasandbox extension wasn't getting loaded [18:50:48] see https://gerrit.wikimedia.org/r/#/c/189774/1 [18:52:21] https://gerrit.wikimedia.org/r/#/c/113069/ haha [18:53:58] (03PS1) 10Catrope: [WIP] Don't animate the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189776 [18:54:08] ori: Strawman commit for benchmarking ---^^ [18:54:15] I think that might save almost a second of CPU time [18:54:29] Today I will write an osmium script that does comparative benchmarks for a Gerrit change [18:54:36] RoanKattouw: check out http://people.wikimedia.org/~ori/devtools/front_end/inspector.html btw [18:54:39] RoanKattouw: Neat. And come in? ;-) [18:54:52] Yes, and I have a meeting in 35 so I need to go in in a minute [18:54:56] so, I'm thinking we are going to end up having a registry for annotation/node preview widgets [18:55:17] instead of baking all this into the nodes or tools [18:55:27] ori: That URL refers to resources which 404 [18:55:39] TrevorParscal: Yes please [18:55:39] chrome or ff? [18:55:44] ori: Chrome [18:55:51] that way, there's a default implementation (show a tool icon) and an extra implementation (show some information based on the model) [18:55:51] ah, it still works tho [18:56:04] James_F: just FYI, that's where this ship is sailing [18:56:06] TrevorParscal: Also let's have them be real things, rather than ContextItemWidgets that take random bits of information from theoretically unrelated classes [18:56:19] ori: No it also throws JS errors [18:56:23] i think they will take models [18:56:24] TrevorParscal: can the process for adding or removing things from the registry involve a tool called reged32? [18:56:30] *regedt32 [18:56:40] lol [18:56:40] Uncaught TypeError: Cannot read property 'frame' of undefined ResourceTreeModel.js:125 [18:56:44] TrevorParscal: OK. As long as it's sane code that does the job, I don't particularly have an opinion. [18:57:12] ori: So... what does it do? Inspector into osmium or something? [18:57:27] nah it's the dev tools interface except as a page [18:57:35] it wfm for some reason [18:59:55] James_F: do you need me for the triage mtng? [19:00:09] ori: No. [19:00:12] thanks [19:00:19] (03CR) 10Esanders: ""ResourceProvider" is a very generic name for something that provides 'setQuery' as a method." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [19:03:03] edsanders, "SearchResultProvider" ? "APIsearcher"? [19:04:38] Is the ResourceQueue and queue? [19:05:15] *a queue [19:05:29] edsanders, it is [19:05:45] edsanders, it stores results from the providers and hands them off first come first serve [19:06:12] SearchResultsProvider & SearchResultsQueue [19:06:26] although.... [19:06:40] do we have to have setQuery? [19:06:52] yes [19:07:03] because when the query changes, you have to abort the requests and start anew [19:07:13] and the provder also stores "offset" [19:07:15] if the input was more generic, you could remove 'Search' [19:07:21] so new query means offset = 0 [19:07:42] but the query doesn't have to be a string [19:07:53] it can be generic input parameters to an API [19:08:04] hm [19:08:10] there's another setting for that [19:08:13] but hm [19:08:19] e.g. if you request "my uploads" [19:08:42] hmm [19:10:04] which I'd like to actually provide soon [19:10:14] and that will search multiple providers [19:10:19] Hmmm [19:10:24] edsanders, okay, there's a ve-core class (which you're looking at) and an ve-mw one, which is in the other fix. The ve-mw one queries mw API directly and works strictly with media/images so it's very specific. [19:10:49] sure, but even that has more parameters than just q= [19:10:55] When I tried to generalize it and supply tests, I was trying to make the ve-core one as general as possible, but you're making a good point about the query. [19:11:43] Okay, so the query should be some key/value object that gets sent to the api [19:13:27] yeah - params [19:13:33] * mooeypoo nods [19:14:20] edsanders, I added that to the settings in 'getResults' but you're right, it makes more sense to change the way the query is stored [19:15:18] yes - if any param changes the results change (excluding pagination) [19:15:31] * mooeypoo nods [19:16:47] edsanders, should I still rename the files in this case? [19:16:55] RemoteResourceProvider or something? [19:17:36] "ResultsProvider" ? "APIFetcherExtraordinaire" ? [19:17:58] APIResultsProvider, APIResultsQueue I think [19:18:43] the combination of params, http requests and pagination means you're dealing with an API probably [19:19:24] edsanders, yeah, though I was kinda hoping to make it also work locally, but I guess we will have to use the API for that too [19:19:35] like, for ve-core, something to go over local files [19:19:46] but we'll have to figure that out with a local sort of API anyways [19:19:57] (and future-future thing) [19:20:12] true, although you can have an API without http [19:20:48] Indeed [19:21:04] (03PS8) 10Mvolz: [WIP] Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 [19:22:10] edsanders, okay, I'll work on it now [19:23:01] edsanders, wait, if we also want it to work locally, then maybe "apiurl" shouldn't be a parameter in the constructor. Maybe it should be a config option [19:27:43] (03PS9) 10Mvolz: [WIP] Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) [19:34:40] TrevorParscal: Ping re. meeting. [19:42:48] edsanders, hm, I'm running into a conceptual issue. Each provider should have the data params sent to the API; if anything changes (except offset) the provider "resets" itself. But what do I do on the queue's side? When I assumed the query is string, I just told the queue to change the queries for all providers. This time, however, the providers may have different parameters that need changing. Should I start storing the providers w [19:42:48] ith keyed object to change each one individually on each call? Doesn't that defy the point? :\ not sure how to approach this. [19:43:52] why do the providers have different params? [19:44:09] edsanders, they could... if we're querying different APIs [19:44:18] right now in MW they don't, since it's all MW api [19:44:45] But if we're generalizing, should I not prepare for the idea that each provider will reach a different API ? [19:44:52] you'll need to distinguish between user provided params and fixed params [19:44:58] actually that would make things much messier with the responses too [19:46:03] if you had provides with different parameter signatures [19:46:14] you'd need the queue to map user inputs to those params [19:46:33] I think I'm going to have to assume all providers are to the same type of API with the same response structure too. If we have different APIs, we'll have to use multiple queues. [19:46:42] we'll have to do that to separate how to handle the different responses anyways [19:47:34] they'll have to be similar if they are powered by the same user inputs [19:47:34] 3VisualEditor, VisualEditor-EditingTools: Permit sorting of categories via drag-and-drop - https://phabricator.wikimedia.org/T52809#1028807 (10Etonkovidova) Checked in betalabs. [19:47:59] edsanders, yeah. If the APIs are completely different we will hve to use different queues anyways [19:48:24] that would have to happen so we can analyze the responses we're getting. MW api sends a different structure response than, say, Flickr or something. [19:49:02] So these can't really be grouped together anyways. Every queue will hve to be 1 type API. And then I don't really have to consider the parameters, I'm just sending them "on" to the providers [19:50:58] (03CR) 10Catrope: [C: 032] Avoid jQuery in ve.dm.BlockImageNode.static.toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189736 (owner: 10Esanders) [19:53:40] 3OOjs-UI: Primary buttons change text colour when pressed - https://phabricator.wikimedia.org/T88948#1028826 (10matmarex) 5Open>3Resolved [19:53:49] 3VisualEditor: VisualEditor: receiving a 'not logged in' warning on a page that shows that a user is logged in - https://phabricator.wikimedia.org/T75250#1028830 (10Etonkovidova) Re-checked after my user rights were changed to authorized. The captcha does not appear anymore and the edits are saved. However, th... [19:55:27] 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression] Media Settings - Infinite loop when an image is inserted - https://phabricator.wikimedia.org/T88764#1028833 (10Jdforrester-WMF) [19:56:33] 3VisualEditor, VisualEditor-EditingTools, VisualEditor-Performance: On VisualEditor load, async pre-load all the TemplateData for the page to make editing templates speedier - https://phabricator.wikimedia.org/T66772#1028837 (10Krenair) a:5Krenair>3Catrope [19:57:18] (03CR) 10Catrope: [C: 032] Add table styles for block images and move to init.sa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189295 (owner: 10Esanders) [19:58:20] 3VisualEditor-MediaWiki, VisualEditor, Beta-Cluster: On Beta Cluster, switching from VisualEditor to edit source mode intermittently loads the wikitext editor without any CSS - https://phabricator.wikimedia.org/T86624#1028839 (10Ryasmeen) 5Resolved>3Open [19:59:14] (03Merged) 10jenkins-bot: Add table styles for block images and move to init.sa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189295 (owner: 10Esanders) [19:59:16] (03CR) 10jenkins-bot: [V: 04-1] Avoid jQuery in ve.dm.BlockImageNode.static.toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189736 (owner: 10Esanders) [20:03:55] 3VisualEditor, VisualEditor-Performance, MediaWiki-Core-Team: Parsoid performance analysis - https://phabricator.wikimedia.org/T85870#1028846 (10Jdforrester-WMF) [20:03:57] (03PS2) 10Catrope: Avoid jQuery in ve.dm.BlockImageNode.static.toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189736 (owner: 10Esanders) [20:04:31] 3VisualEditor, VisualEditor-EditingTools: Tools should be able to specify a label for their appearance in the context menu. - https://phabricator.wikimedia.org/T88337#1028847 (10Jdforrester-WMF) [20:04:53] (03CR) 10Catrope: [C: 032] Avoid jQuery in ve.dm.BlockImageNode.static.toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189736 (owner: 10Esanders) [20:05:01] (03PS2) 10Catrope: Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [20:07:13] ori: Hmm, so vbench needs a way to deal with Chrome chrashing [20:07:22] ori: Right now that's unrecoverable and I need to restart vbench, restarting the run [20:07:34] Obama triggers this quite often [20:08:09] that may be so, but i think we should stop using obama [20:08:17] (03CR) 10jenkins-bot: [V: 04-1] Avoid jQuery in ve.dm.BlockImageNode.static.toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189736 (owner: 10Esanders) [20:08:29] OK, why? [20:08:44] it is difficult to reproduce without depending on production (i.e., without either using production directly or hacking one's local dev environment to use production), and it is on the extreme end of complexity [20:09:02] i'd like to have a testing rig with no external dependencies [20:09:25] (03CR) 10jenkins-bot: [V: 04-1] Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [20:09:46] Right [20:09:58] we're also not disciplined about using oldid=nnn rather than just the article name so we're not even being consistent [20:10:16] Riiiight [20:10:19] (03PS10) 10Mooeypoo: [wip] Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [20:10:22] That's an excellent point, I hadn't even considered that [20:10:34] (03PS8) 10Mooeypoo: [wip] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [20:10:38] Yeah we should have some static HTML test pages [20:11:05] (03PS9) 10Mooeypoo: [wip] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [20:12:01] (03CR) 10jenkins-bot: [V: 04-1] [wip] Create ResourceProvider and ResourceQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [20:12:13] (03CR) 10jenkins-bot: [V: 04-1] [wip] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [20:12:26] ehhhh I keep getting BlockImageNode errors in my patch [20:12:47] 3VisualEditor, VisualEditor-CopyPaste: Using keyboard shortcuts (in multiple browsers) or the "Open menu" (in Firefox only) to copy a paragraph and a reference together causes selected content to be deleted (not cut) instead - https://phabricator.wikimedia.org/T89025#1028860 (10Whatamidoing-WMF) [20:13:07] Or I guess we should at least use oldids [20:13:21] RoanKattouw: so my next priority is fixing metrics from real users. I can either work on the test environment after that, or you can do that. Either would be OK with me. [20:13:53] RoanKattouw, edsanders I can't load VE with my provider/queue patch, I'm getting "Cannot read property prototype of undefined" related to ve.dm.BlockImageNode and ve.ce.BlockImageNode with alignable node [20:13:58] ori: I'll work on it, as soon as Bureaucracy Has Been Served (TM) [20:14:05] I updated my repos. I rebased my 2 patches. [20:16:38] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/189507/1 [20:17:03] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189736 (owner: 10Esanders) [20:17:22] (03CR) 10Catrope: [C: 032] ve.utils: Apply whitelist in setDomAttributes() attribute removal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189507 (owner: 10Krinkle) [20:17:42] RoanKattouw: why -1 on https://gerrit.wikimedia.org/r/#/c/189683/ ? [20:17:58] ori: Short answer: James made mee [20:18:04] ori: Because his comment is a blocker for merging. [20:18:16] Long answer: so someone else doesn't merge it before I've run the numbers on it [20:18:25] we merged several other patches expected to impact perf [20:18:36] well, MatmaRex's, at least. [20:18:52] Yeah but those we knew would be positive [20:19:11] I mistrust V8 optimization warnings (especially this category) and want to see evidence that this actually makes things faster [20:19:40] James_F: sorry my computer died [20:19:48] TrevorParscal: No worries. [20:19:55] and then booting it back up took ages because I had to wait for it to charge enough and all that [20:19:56] ugh [20:20:11] my approach has been to apply the ones that (a) result in measurable improvement, *or* (b) require some trivial rewriting that does not make the code less idiomatic [20:20:42] (03Merged) 10jenkins-bot: ve.utils: Apply whitelist in setDomAttributes() attribute removal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189507 (owner: 10Krinkle) [20:25:04] 3VisualEditor: Odd result: Subst'd template, or converted to HTML, or ??? - https://phabricator.wikimedia.org/T89163#1028864 (10Whatamidoing-WMF) 3NEW [20:29:09] Krinkle|detached: Ping when you're back. The main thing you're on the hook for is https://phabricator.wikimedia.org/T52513 – can you carve it up into a series of smaller tasks underneath it, please? [20:30:18] 3VisualEditor-MediaWiki, VisualEditor, Beta-Cluster: On Beta Cluster, switching from VisualEditor to edit source mode intermittently loads the wikitext editor without any CSS - https://phabricator.wikimedia.org/T86624#1028884 (10hashar) p:5Triage>3Normal [20:31:24] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Set up mass round-trip testing infrastructure on real content - https://phabricator.wikimedia.org/T52513#1028889 (10Jdforrester-WMF) [20:31:28] 3RESTBase, VisualEditor, VisualEditor-Performance, Flow, Parsoid: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#1028890 (10Jdforrester-WMF) [20:31:44] 3VisualEditor, VisualEditor-Performance, Parsoid: Add original dimensions information from the API to data-mw - https://phabricator.wikimedia.org/T64881#1028896 (10Jdforrester-WMF) [20:31:54] 3VisualEditor, VisualEditor-Performance, MediaWiki-Core-Team: Parsoid performance analysis - https://phabricator.wikimedia.org/T85870#1028906 (10Jdforrester-WMF) [20:32:02] 3VisualEditor-MediaWiki, VisualEditor, Parsoid: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#1028908 (10Jdforrester-WMF) [20:32:08] 3VisualEditor, Parsoid, VisualEditor-Tables: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1028910 (10Jdforrester-WMF) [20:32:18] 3VisualEditor, Parsoid, VisualEditor-Tables: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#1028913 (10Jdforrester-WMF) [20:32:22] 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression] Media Settings - Infinite loop when an image is inserted - https://phabricator.wikimedia.org/T88764#1028914 (10Jdforrester-WMF) [20:32:29] 3VisualEditor: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T89072#1028915 (10Jdforrester-WMF) [20:34:36] 3VisualEditor, VisualEditor-EditingTools: Tools should be able to specify a label for their appearance in the context menu - https://phabricator.wikimedia.org/T88337#1028917 (10Jdforrester-WMF) [20:36:50] 3VisualEditor-MediaWiki, VisualEditor: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#1028930 (10Jdforrester-WMF) a:5Jdforrester-WMF>3None [20:38:37] 3VisualEditor, VisualEditor-Performance, VisualEditor-Initialisation: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#1028937 (10Jdforrester-WMF) [20:38:44] 3VisualEditor, VisualEditor-Performance, OOjs-UI: ~50ms spent a.oo-ui-buttonElement-button - https://phabricator.wikimedia.org/T88386#1028938 (10Jdforrester-WMF) [20:38:48] 3VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki: VE page save time at 75th percentile up 70% from February - https://phabricator.wikimedia.org/T66171#1028939 (10Jdforrester-WMF) [20:38:52] 3VisualEditor, VisualEditor-Performance: Show the VisualEditor toolbar/editor chrome immediately after the user clicks "edit", rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#1028940 (10Jdforrester-WMF) [20:38:56] 3VisualEditor, VisualEditor-Performance, Parsoid: Batch API requests - https://phabricator.wikimedia.org/T45888#1028941 (10Jdforrester-WMF) [20:38:59] 3VisualEditor, VisualEditor-Performance, Parsoid: Measure how often Parsoid cache misses happen, and what load performance is like in this case - https://phabricator.wikimedia.org/T86733#1028942 (10Jdforrester-WMF) [20:39:05] 3VisualEditor, VisualEditor-Performance, Parsoid: Thoughts on element IDs, sections, incremental parsing and fast section editing - https://phabricator.wikimedia.org/T87556#1028943 (10Jdforrester-WMF) [20:39:08] 3VisualEditor, VisualEditor-Performance, VisualEditor-DataModel: Reduce VisualEditor's memory usage - https://phabricator.wikimedia.org/T55825#1028944 (10Jdforrester-WMF) [20:40:26] 3Utilities-UnicodeJS, VisualEditor: Wordbreak detection is faulty for selection starting just down-page of a single character - https://phabricator.wikimedia.org/T78202#1028947 (10Jdforrester-WMF) [20:40:30] 3VisualEditor, VisualEditor-EditingTools: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1028948 (10Jdforrester-WMF) [20:41:06] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Set up mass round-trip testing infrastructure on real content - https://phabricator.wikimedia.org/T52513#1028949 (10Krenair) [20:44:53] 3VisualEditor-MediaWiki, VisualEditor, OOjs-UI: [Regression wmf16] Cannot open category popup widget - https://phabricator.wikimedia.org/T88736#1028956 (10Jdforrester-WMF) 5Open>3Resolved Works for me – master, Beta Cluster and MediaWiki.org. [20:45:03] 3VisualEditor-MediaWiki, VisualEditor, OOjs-UI: [Regression wmf16] Cannot open category popup widget - https://phabricator.wikimedia.org/T88736#1028965 (10Jdforrester-WMF) [20:46:02] James_F, what's going on in https://phabricator.wikimedia.org/T52513#1028949 ? :/ [20:46:03] "changed Story Points from 160 to 00." wut [20:46:04] how is this different to "removed Story Points." [20:47:41] dependency [20:48:04] it's really a QA infrastructure thing [20:48:24] https://phabricator.wikimedia.org/sprint/board/1015/ is also broken in a couple of ways [20:48:49] Points: bz50513 [20:49:06] NaN totals [20:49:29] 3VisualEditor, VisualEditor-CopyPaste: Using keyboard shortcuts (in multiple browsers) or the "Open menu" (in Firefox only) to copy a paragraph and a reference together causes selected content to be deleted (not cut) instead - https://phabricator.wikimedia.org/T89025#1028980 (10Jdforrester-WMF) [20:49:40] yeah, the points have to be done manually [20:50:10] isn't the bz50513 thing just the Reference field? [20:50:14] 3VisualEditor, VisualEditor-DataModel: class="wikitable wikitable" corrupted to class="wikitable" - https://phabricator.wikimedia.org/T88148#1028982 (10Jdforrester-WMF) a:3Esanders [20:50:14] not story points field [20:51:01] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - https://phabricator.wikimedia.org/T70537#1028986 (10Jdforrester-WMF) [20:51:04] 3VisualEditor, VisualEditor-ContentEditable: Deleting from an empty paragraph to the end of an inline node throws an exception - https://phabricator.wikimedia.org/T72375#1028988 (10Jdforrester-WMF) [20:51:08] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Deleting from a paragraph-terminating node to a paragraph-terminating node (?) is throwing "Unbalanced set of replace operations found" - https://phabricator.wikimedia.org/T74579#1028989 (10Jdforrester-WMF) [20:51:12] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check when the changed word in the only item in the paragraph causes endless insertions in Firefox - https://phabricator.wikimedia.org/T74929#1028991 (10Jdforrester-WMF) [20:52:24] 3VisualEditor, VisualEditor-Performance, VisualEditor-ContentEditable: Draw VisualEditor's non-CE block highlights using SVG polygons - https://phabricator.wikimedia.org/T53202#1028995 (10Jdforrester-WMF) a:5Esanders>3None [20:52:51] 3VisualEditor: VisualEditor: Actually run tests for MWHeadingNode / MWPreformattedNode - https://phabricator.wikimedia.org/T74398#1028998 (10Jdforrester-WMF) [21:01:11] Krenair: Welcome to Phabricator. [21:02:33] I don't think this is built into phabricator. isn't it a custom application? [21:04:01] 3VisualEditor: VisualEditor: Actually run tests for MWHeadingNode / MWPreformattedNode - https://phabricator.wikimedia.org/T74398#1029026 (10Jdforrester-WMF) [21:04:04] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check when the changed word in the only item in the paragraph causes endless insertions in Firefox - https://phabricator.wikimedia.org/T74929#1029027 (10Jdforrester-WMF) [21:04:06] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Deleting from a paragraph-terminating node to a paragraph-terminating node (?) is throwing "Unbalanced set of replace operations found" - https://phabricator.wikimedia.org/T74579#1029028 (10Jdforrester-WMF) [21:04:09] 3VisualEditor, VisualEditor-ContentEditable: Deleting from an empty paragraph to the end of an inline node throws an exception - https://phabricator.wikimedia.org/T72375#1029029 (10Jdforrester-WMF) [21:04:14] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - https://phabricator.wikimedia.org/T70537#1029030 (10Jdforrester-WMF) [21:04:18] 3VisualEditor, VisualEditor-CopyPaste: Using keyboard shortcuts (in multiple browsers) or the "Open menu" (in Firefox only) to copy a paragraph and a reference together causes selected content to be deleted (not cut) instead - https://phabricator.wikimedia.org/T89025#1029031 (10Jdforrester-WMF) [21:04:22] 3VisualEditor, VisualEditor-EditingTools: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1029032 (10Jdforrester-WMF) [21:04:30] 3Utilities-UnicodeJS, VisualEditor: Wordbreak detection is faulty for selection starting just down-page of a single character - https://phabricator.wikimedia.org/T78202#1029033 (10Jdforrester-WMF) [21:04:37] 3VisualEditor, VisualEditor-Performance, VisualEditor-DataModel: Reduce VisualEditor's memory usage - https://phabricator.wikimedia.org/T55825#1029034 (10Jdforrester-WMF) [21:04:44] 3VisualEditor, VisualEditor-Performance, Parsoid: Thoughts on element IDs, sections, incremental parsing and fast section editing - https://phabricator.wikimedia.org/T87556#1029035 (10Jdforrester-WMF) [21:04:47] 3VisualEditor, VisualEditor-Performance, Parsoid: Measure how often Parsoid cache misses happen, and what load performance is like in this case - https://phabricator.wikimedia.org/T86733#1029036 (10Jdforrester-WMF) [21:04:53] 3VisualEditor, VisualEditor-Performance, Parsoid: Batch API requests - https://phabricator.wikimedia.org/T45888#1029037 (10Jdforrester-WMF) [21:04:58] 3VisualEditor, VisualEditor-Performance: Show the VisualEditor toolbar/editor chrome immediately after the user clicks "edit", rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#1029038 (10Jdforrester-WMF) [21:05:57] 3VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki: Log Parsoid server-side save performance - https://phabricator.wikimedia.org/T66171#1029039 (10Jdforrester-WMF) [21:06:34] 3VisualEditor, VisualEditor-Performance, OOjs-UI: ~50ms spent a.oo-ui-buttonElement-button - https://phabricator.wikimedia.org/T88386#1029042 (10Jdforrester-WMF) [21:06:44] 3VisualEditor, VisualEditor-Performance, VisualEditor-Initialisation: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#1029044 (10Jdforrester-WMF) [21:08:34] It's Phabricator-Sprint or something. A plug-in. [21:08:47] Still it's poor that custom fields can over-write each other. [21:30:55] 3MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#1029169 (10Ijon) Happened to me too. A thought occurs: could this be related to the repeated reports during the massive fundraiser in December of dismissed banners coming back? (i.e. becau... [21:41:21] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Set up mass round-trip testing infrastructure on real content - https://phabricator.wikimedia.org/T52513#1029204 (10Jdforrester-WMF) [21:41:29] 3VisualEditor-MediaWiki, VisualEditor: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#1029206 (10Jdforrester-WMF) [21:41:41] 3VisualEditor, VisualEditor-DataModel: class="wikitable wikitable" corrupted to class="wikitable" - https://phabricator.wikimedia.org/T88148#1029207 (10Jdforrester-WMF) [21:42:11] * James_F fixes tickets Krenair broke. :-) [21:53:42] (03PS1) 10Chad: Remove obvious function-level profiling [extensions/Cite] - 10https://gerrit.wikimedia.org/r/189833 [21:53:51] 3VisualEditor: Chrome(browser bug): when screen is resized - oo-ui-popupWidget-popup element displayed without upper border - https://phabricator.wikimedia.org/T89172#1029226 (10Etonkovidova) 3NEW [21:57:01] 3OOjs-UI: DraggableGroupElement should handle non-OptionWidget items - https://phabricator.wikimedia.org/T88053#1029235 (10Jdforrester-WMF) 5Open>3Resolved [21:57:33] 3OOjs-UI: DraggableGroupElement should handle non-OptionWidget items - https://phabricator.wikimedia.org/T88053#1003207 (10Jdforrester-WMF) [22:04:04] (03PS3) 10Esanders: Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 [22:04:07] (03CR) 10jenkins-bot: [V: 04-1] Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [22:04:52] 3UI-Standardization, OOjs-UI: ToggleSwitchWidget has no visual representation for focused state - https://phabricator.wikimedia.org/T88973#1029256 (10TheDJ) @violetto I think there is no set Design for this widget at all right now correct ? I would like to point out another concern I have with the states. The cu... [22:18:16] (03PS4) 10Vikassy: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [22:22:06] (03PS5) 10Vikassy: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [22:24:05] (03PS6) 10Vikassy: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [22:25:29] (03CR) 10Krinkle: ve.utils: Cover insertIntoArray with unit test (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189508 (owner: 10Krinkle) [22:25:57] (03CR) 10Vikassy: "This should be tested/merged after merging this pull request: https://github.com/amire80/screenshot/pull/1/files" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [22:29:51] (03CR) 10Legoktm: [C: 032] Remove obvious function-level profiling [extensions/Cite] - 10https://gerrit.wikimedia.org/r/189833 (owner: 10Chad) [22:30:02] James_F, mooeypoo: does https://phabricator.wikimedia.org/T88764 need to be swat deployed? [22:30:12] well, the patch for that anyway [22:30:20] James_F: OK. I'll make https://phabricator.wikimedia.org/T52513 actionable [22:30:53] James_F: There's still a tail from Karma though. And pending that outcome, it can affect how we do the round-trip testing. [22:32:24] (03Merged) 10jenkins-bot: Remove obvious function-level profiling [extensions/Cite] - 10https://gerrit.wikimedia.org/r/189833 (owner: 10Chad) [22:43:18] (03CR) 10Amire80: [BrowserTest] Move screenshot taking functionality to a gem (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [22:44:40] (03PS10) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [22:44:55] (03CR) 10Dduvall: "Looks right, though I haven't tested it end-to-end. See my comment about specifying the version of your screenshot gem." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [22:46:01] (03CR) 10jenkins-bot: [V: 04-1] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [22:48:04] (03PS1) 10Cmcmahon: [BrowserTest] Bring references test up to date. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189855 [22:49:28] (03CR) 10Trevor Parscal: [C: 032] Use ve.ui.AlignWidget in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189712 (owner: 10Esanders) [22:51:11] (03Merged) 10jenkins-bot: Use ve.ui.AlignWidget in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189712 (owner: 10Esanders) [22:51:24] (03CR) 10Trevor Parscal: [C: 031] "gtg, waiting for pull through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188869 (owner: 10Mooeypoo) [22:55:09] (03PS11) 10Mooeypoo: Create APIResultsProvider and APIResultsQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [22:56:19] (03CR) 10Trevor Parscal: [C: 031] "I want Krinkle to review this because he is more familiar with the mw.Api class." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [22:58:00] (03PS11) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [22:58:33] (03PS2) 10Cmcmahon: [BrowserTest] Bring references test up to date. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189855 [22:58:35] urgh. [22:58:51] I found that if I break the token I get "Your edit has been rejected because your client mangled the punctuation characters in the edit token. The edit has been rejected to prevent corruption of the page text. This sometimes happens when you are using a buggy web-based anonymous proxy service." [22:59:04] and my hook isn't called... [22:59:32] (03CR) 10Ryasmeen: [C: 032] [BrowserTest] Bring references test up to date. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189855 (owner: 10Cmcmahon) [23:00:02] (03CR) 10Trevor Parscal: [C: 031] Template dialog: Disable 'Apply changes' until a change is made (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (https://phabricator.wikimedia.org/T76926) (owner: 10Alex Monk) [23:00:37] (03CR) 10jenkins-bot: [V: 04-1] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [23:01:07] (03CR) 10Esanders: [C: 032] Avoid jQuery in ve.dm.BlockImageNode.static.toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189736 (owner: 10Esanders) [23:01:09] (03Merged) 10jenkins-bot: [BrowserTest] Bring references test up to date. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189855 (owner: 10Cmcmahon) [23:02:15] Krinkle: Thanks. [23:02:17] Krinkle: Yeah, understood. [23:02:19] Krenair: Huh, I thought T88764 was SWATed last night? [23:02:53] (03Merged) 10jenkins-bot: Avoid jQuery in ve.dm.BlockImageNode.static.toDataElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189736 (owner: 10Esanders) [23:03:39] (03CR) 10Jforrester: Template dialog: Disable 'Apply changes' until a change is made (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (https://phabricator.wikimedia.org/T76926) (owner: 10Alex Monk) [23:04:09] James_F, I don't think so... VE change deployed last night was https://gerrit.wikimedia.org/r/#/c/189144/ according to the calendar [23:05:05] Krenair: Ah. In that case, yes, please cherry-pick etc. [23:05:39] And yeah, it works. [23:05:50] 3VisualEditor-MediaWiki, VisualEditor, OOjs-UI: [Regression wmf16] Cannot open category popup widget - https://phabricator.wikimedia.org/T88736#1029355 (10Jdforrester-WMF) [23:07:08] Krenair: You need to pick both https://gerrit.wikimedia.org/r/#/c/188725/ and https://gerrit.wikimedia.org/r/#/c/189160/ on top of it. [23:07:17] James_F, am looking at the Edit Schema again, why does action.saveFailure.type not just take an EditPage constant? [23:07:32] 3VisualEditor, Continuous-Integration: Investigate Chrome disconnect failures when running MediaWiki tests on labs slaves - https://phabricator.wikimedia.org/T89075#1029357 (10Krinkle) Comparing the log artefacts of a successful and failed build, I believe this is caused by T89180. While pretty much all builds... [23:07:34] Krenair: You're asking why JS doesn't use PHP constants? [23:07:59] (03PS12) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [23:08:08] Thought you (or someone else) said this was a really generic schema >_> [23:08:13] 3VisualEditor, Continuous-Integration: Investigate Chrome disconnect failures when running MediaWiki tests on labs slaves - https://phabricator.wikimedia.org/T89075#1029360 (10Krinkle) [23:08:14] Krenair: Oh, why we re-invented? [23:08:27] Krenair: It's generic for /systems/. It was designed for client-side execution of EL. [23:08:27] some things like AS_CONFLICT_DETECTED and AS_ARTICLE_WAS_DELETED will be ok [23:08:53] It doesn't look like I'll be able to catch bad token errors with my hook [23:08:57] userNewUser? wat? [23:09:29] (03CR) 10jenkins-bot: [V: 04-1] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [23:09:29] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/186171/ is something Ed and I talked about and I like - are you still against this? [23:09:43] TrevorParscal: Do you remember if recently (<2 months) you were experiencing some problems with oojs-ui dialogs when resizing browser windows or scrolling the page? [23:10:18] InezK: if we did, that may have been before we switched away from using iframes [23:10:28] so, it's unlikely the still have the same issues [23:10:33] yeah, I have this problem now, and it is without iframes [23:10:44] or perhaps it is BECAUSE of that change [23:10:51] that was the notable change, in any event [23:11:00] :) [23:11:05] extension* - :( [23:11:14] what's the resize and scroll issue exactly? [23:11:15] btw. now, after this change: https://gerrit.wikimedia.org/r/#/c/187811/ do you get dialogs to close/open with animation? [23:11:18] responseEmpty... probably not relevant [23:11:30] TrevorParscal: Try insert media dialog here: http://muppet.inez.wikia-dev.com/wiki/InezsTest?veaction=edit&debug=true [23:11:37] and search for something, e.g. "kermit" [23:12:15] (03PS1) 10Alex Monk: Refactor MWMediaSearchWidget to use a queue and providers [extensions/VisualEditor] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189861 (https://phabricator.wikimedia.org/T78161) [23:12:28] however you can see there that we applied small change - move buttons back to the foot and added X in the head [23:12:29] TrevorParscal: I suggested that https://gerrit.wikimedia.org/r/#/c/179002/ should go today; thoughts? [23:13:56] InezK: so, the issue is? [23:14:10] let me record a video [23:14:37] James_F: when is the ooui pull through to vemw happening? [23:14:51] TrevorParscal: Wednesday evening/Thursday. [23:14:52] (03PS4) 10Esanders: Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 [23:15:05] James_F: ok, this is fine to go then [23:15:09] TrevorParscal: There's a cut tomorrow morning; pushing it out today means a week of user happinness. :-) [23:15:16] (03CR) 10Trevor Parscal: [C: 032] "Promises look fine to me." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (https://phabricator.wikimedia.org/T76926) (owner: 10Alex Monk) [23:15:34] 3UI-Standardization, OOjs-UI: ToggleSwitchWidget has no visual representation for focused state - https://phabricator.wikimedia.org/T88973#1029374 (10Prtksxna) [23:16:00] (03PS1) 10Jforrester: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 [23:16:19] (03CR) 10Alex Monk: [C: 032] Refactor MWMediaSearchWidget to use a queue and providers [extensions/VisualEditor] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189861 (https://phabricator.wikimedia.org/T78161) (owner: 10Alex Monk) [23:16:20] TrevorParscal: https://www.dropbox.com/s/qxn365eg37xqtt2/dialogs%20problem.mov?dl=0 [23:16:41] TrevorParscal: Can I steal a +2 on https://gerrit.wikimedia.org/r/#/c/189864/ too? :_) [23:17:03] (03Merged) 10jenkins-bot: Template dialog: Disable 'Apply changes' until a change is made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (https://phabricator.wikimedia.org/T76926) (owner: 10Alex Monk) [23:17:05] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [23:17:10] Thanks! [23:17:19] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [23:18:02] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#1029389 (10Jdforrester-WMF) [23:18:03] 3VisualEditor, VisualEditor-MediaWiki-Templates: The transclusion dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76926#1029387 (10Jdforrester-WMF) 5Open>3Resolved [23:18:14] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#610243 (10Jdforrester-WMF) [23:18:15] 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki-References: The citation dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76927#1029390 (10Jdforrester-WMF) 5Open>3Resolved [23:18:43] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#1029394 (10Jdforrester-WMF) 5Open>3Resolved [23:18:50] (03Merged) 10jenkins-bot: Refactor MWMediaSearchWidget to use a queue and providers [extensions/VisualEditor] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189861 (https://phabricator.wikimedia.org/T78161) (owner: 10Alex Monk) [23:19:16] (03PS1) 10Alex Monk: MWMediaDialog: Focus the right thing on ready, depending on the panel shown [extensions/VisualEditor] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189866 (https://phabricator.wikimedia.org/T88881) [23:19:32] InezK: I can't reproduce [23:19:32] Whoops. [23:19:36] (03CR) 10Alex Monk: [C: 032] MWMediaDialog: Focus the right thing on ready, depending on the panel shown [extensions/VisualEditor] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189866 (https://phabricator.wikimedia.org/T88881) (owner: 10Alex Monk) [23:19:37] ? [23:19:52] "(CR) jenkins-bot: [V: -1] Update VE core submodule to master (c6dee65)" [23:19:59] It passed locally. [23:21:02] James_F, just needs those two for wmf16 right? [23:21:27] Krenair: Yes. [23:21:33] 3VisualEditor: Test batchSplice polyfill - https://phabricator.wikimedia.org/T89182#1029406 (10Esanders) 3NEW a:3Krinkle [23:21:43] (03CR) 10Esanders: [C: 031] ve.utils: Cover insertIntoArray with unit test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189508 (owner: 10Krinkle) [23:21:52] (03Merged) 10jenkins-bot: MWMediaDialog: Focus the right thing on ready, depending on the panel shown [extensions/VisualEditor] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/189866 (https://phabricator.wikimedia.org/T88881) (owner: 10Alex Monk) [23:22:13] 23:17:34 TypeError: 'undefined' is not an object (evaluating 'originFn.prototype') TypeError: 'undefined' is not an object (evaluating 'originFn.prototype') [23:22:22] Looks like a OO.inheritClass is using a class that doesn't exist [23:22:27] Ah. [23:22:31] ( https://gerrit.wikimedia.org/r/#/c/189864/ ) [23:22:50] Yeah, except we don't have any new code here. It's just a dumb pull-through. Was there a breaking change? [23:22:59] I'm pretty sure yeah [23:23:09] Unmarked. Cool. :-( [23:23:39] edsanders: Could you deal with https://gerrit.wikimedia.org/r/#/c/189864/ so it passes? Sorry. :-( OTOH, it's probably your code, or stuff you merged. ;-) [23:24:13] James_F, on the submodule update part of the submodule update :\ [23:24:20] I think it may be this one: https://gerrit.wikimedia.org/r/#/c/189230/2/src/ce/nodes/ve.ce.BlockImageNode.js [23:24:29] That's the only added class call [23:24:41] Oooh, yeah, that'd probably do it. [23:24:42] as in, "git submodule update --init --recursive" [23:24:52] Krenair: It's /so/ fast, isn't it? :-( [23:24:52] 3VisualEditor, VisualEditor-Performance, MediaWiki-Core-Team: Parsoid performance analysis - https://phabricator.wikimedia.org/T85870#1029418 (10tstarling) 5Open>3Resolved [23:25:31] 3VisualEditor, VisualEditor-Performance, Parsoid: Batch Parsoid's API requests - https://phabricator.wikimedia.org/T45888#1029420 (10Jdforrester-WMF) [23:28:52] I think [ce/dm] AlignableNode is missing from ve.php [23:29:37] James_F, it was missed off a while ago but we got away with it because it wasn't used until now [23:30:58] 3Flow, VisualEditor, §Collaboration-Team: Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1029451 (10DannyH) [23:31:25] Yeah. [23:31:27] Adding now. [23:31:39] (03PS2) 10Jforrester: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 [23:31:50] I was temporarily trying to update extension.json as well, but it'll take too long. [23:33:39] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [23:39:59] (03PS3) 10Jforrester: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 [23:41:16] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [23:41:20] * James_F sighs. [23:44:45] James_F, fyi - https://gerrit.wikimedia.org/r/#/c/189867/1 [23:44:53] Krenair: Thanks, have +1'ed. [23:45:03] I added it to the calendar [23:45:33] Yeah. I'm going to be in a meeting, however. [23:45:55] I'll claim it then [23:46:48] Ta. [23:49:32] (03PS4) 10Catrope: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [23:50:40] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [23:53:24] (03PS5) 10Jforrester: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 [23:54:37] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [23:57:47] 3VisualEditor, Beta-Cluster: Search on the Beta Cluster is broken, and thus VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1029535 (10Ryasmeen) I can now see the template suggestions now.Therefore, closing the bug [23:57:55] 3VisualEditor, Beta-Cluster: Search on the Beta Cluster is broken, and thus VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1029537 (10Ryasmeen) 5Open>3Resolved [23:58:38] ryasmeen: Thanks! :-) [23:58:53] ryasmeen: Do you want to do this week's release notes? [23:59:12] James_F: okay, I can do it. [23:59:30] ryasmeen: Awesome. If you get lost/too busy, don't worry, happy to help. [23:59:51] James_F: We need to include in that page by tomorrow right?