[00:00:25] (03PS6) 10Esanders: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:00:44] 3TemplateData: Can't edit "aliases" with TemplateData editor tool - https://phabricator.wikimedia.org/T88141#1029543 (10Mooeypoo) I can't manage to replicate this; if I delete the aliases in the editor, they vanish from the string. Does this still happen with the new version of the TemplateData d... [00:01:19] (03PS7) 10Esanders: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:02:32] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:03:26] RoanKattouw, edsanders: This is going well. :-) [00:03:35] it helps when you get the path right [00:03:58] you had a dm for a ce, and a /nodes/ that isn't there - also AlignableNode.css is no ore [00:04:04] *more [00:04:22] (03PS8) 10Esanders: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:04:28] this version ran locally [00:04:36] edsanders: Yeah, RoanKattouw was fixing. [00:05:35] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:05:37] RoanKattouw, node mixins aren't in /nodes, but their CSS files are. Should be made consistent later [00:05:46] wah [00:08:24] 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression pre-wmf17] The default search term is not getting highlighted when you open the media search dialog - https://phabricator.wikimedia.org/T88881#1029557 (10Ryasmeen) Verified the fix in Betalabs [00:08:44] 3VisualEditor: Odd result: Subst'd template, or converted to HTML, or ??? - https://phabricator.wikimedia.org/T89163#1029559 (10Whatamidoing-WMF) This is probably related to T86401 except that I can't see any reason in this edit for cutting and pasting. [00:09:03] test pass locally... [00:09:05] edsanders: Oh, you brought back the extension.json changes which are breaking. Remove them and it might work. [00:09:20] Or I can. [00:09:37] really - I downloaded your latest patchset... [00:09:55] (03PS9) 10Jforrester: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 [00:10:27] https://gerrit.wikimedia.org/r/#/c/189864/5..9/VisualEditor.php [00:11:16] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:11:41] Still 00:10:21 TypeError: 'undefined' is not an object (evaluating 'originFn.prototype') TypeError: 'undefined' is not an object (evaluating 'originFn.prototype') [00:15:38] 3VisualEditor: [Regression wmf-16] Including a template in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1029574 (10Ryasmeen) 3NEW [00:15:50] edsanders: Lovely... [00:15:59] edsanders: Also Alignable doesn't even have a CSS file any more [00:16:10] But that pull-through was still trying to list one [00:16:18] 3VisualEditor: [Regression wmf-16] Including a template in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1029582 (10Ryasmeen) [00:17:13] 3VisualEditor: Test batchSplice polyfill - https://phabricator.wikimedia.org/T89182#1029589 (10Jdforrester-WMF) p:5Triage>3Low [00:19:28] 3VisualEditor, Beta-Cluster: Search on the Beta Cluster is broken, and thus VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1029601 (10Krenair) a:3Chad [00:20:14] edsanders, btw, with regards to the APIResultsProvider/Queue -- I've renamed the ve-core ones but left the ve-mw as it is, because when I renamed them it was really hard to see the changes in each file. The renaming will be in a separate commit for those later. [00:21:16] (03PS10) 10Catrope: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:21:19] TrevorParscal: on days you WFH, do you mind if i use your display? [00:21:50] PLEASE DO! [00:21:53] it's sad [00:22:25] 3VisualEditor-MediaWiki, VisualEditor, Beta-Cluster: On Beta Cluster, switching from VisualEditor to edit source mode intermittently loads the wikitext editor without any CSS - https://phabricator.wikimedia.org/T86624#1029605 (10Ryasmeen) This happened consistently for me for last few days, when I save my first... [00:22:27] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:22:35] RoanKattouw: … [00:22:38] * James_F sighs. [00:22:47] legoktm: halp? [00:22:51] legoktm: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/13687/console [00:23:00] * legoktm looks [00:23:17] James_F: I confirmed that the VisualEditor.php changes worked; but I think the job might be looking at extension.json instead [00:23:25] yes, the job reads extension.json [00:23:30] But then editing that causes ExtensionRegistry to explode [00:23:53] I'll try making a minimal change to extension.json [00:24:03] * James_F nods. [00:24:30] (03PS11) 10Catrope: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:24:51] RoanKattouw: is the json file valid JSON? [00:25:03] it looks like json_decode( $json, /* $assoc = */ true ) is returning null [00:25:16] where $json = file_get_contents( $path ); [00:25:36] Hmm [00:25:38] Maybe it wasn't [00:25:44] It seems to be passing now that I've made a smaller change [00:26:02] Error while parsing /home/km/projects/vagrant/mediawiki/extensions/VisualEditor/extension.json: [00:26:02] Expecting property name: line 1529 column 2 (char 57169) [00:26:07] (that's patchset 10) [00:26:25] Thanks [00:26:30] Where did you get that error mesasge? [00:26:56] Oh I see, there's a trailing comma there [00:26:58] How did that get there [00:27:12] RoanKattouw: I use https://github.com/legoktm/jsonchecker (there's a bug somewhere about integrating it with jenkins...) :) [00:27:13] Oh I see that in the diff now [00:27:16] Aaah OK [00:27:32] it was designed to check for duplicate keys, but it also does syntax checking [00:29:16] in the future we will have a job that just validates extension.json files checking for their syntax and adherence to the schema, tracked as the second part to https://phabricator.wikimedia.org/T86359 [00:30:04] (03PS12) 10Catrope: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:30:10] but for now we should probably throw exceptions on invalid JSON? [00:30:17] legoktm: That would be nice [00:30:25] Something less cryptic than that error we got there [00:30:39] 3VisualEditor: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T89072#1029616 (10Jdforrester-WMF) p:5Triage>3High [00:30:42] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:30:51] 3VisualEditor-MediaWiki, VisualEditor: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T89072#1026973 (10Jdforrester-WMF) [00:30:54] James_F: This ---^^ is passing now [00:31:02] 3VisualEditor: [Regression wmf-16] Including a template/comment/table/gallery/math node in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1029618 (10Ryasmeen) [00:31:04] James_F: It turns out you don't know how to place commas, and neither do I [00:31:25] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:31:46] :| [00:32:07] WHAT THE [00:33:37] 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression] Media Settings - Infinite loop when an image is inserted - https://phabricator.wikimedia.org/T88764#1029627 (10Krenair) Deployed fix to 1.25wmf16 sites (i.e., not Wikipedias). [00:33:44] RoanKattouw: ext.visualEditor.viewPageTarget.init needs to keep the localBasePath and remoteExtPath because it has a custom "class" [00:34:06] Oooh [00:34:17] Does it need to have that? [00:34:21] Wait that trick only works for RLFileModule? [00:34:25] Then I'll just revert to PS11 [00:34:27] I can't be bothered [00:34:28] yeah....should it not? [00:34:49] (03PS13) 10Catrope: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:35:26] Well, InitModule is a subclass of ResourceLoaderFileModule [00:35:35] Actually, I think you might have written it, legoktm [00:35:37] ? [00:35:45] I think I did :P [00:35:50] Yup [00:35:51] RoanKattouw: BTW, apparently someone upgraded Phabricator-Sprint since our meeting this morning – https://phabricator.wikimedia.org/sprint/board/1015/ now looks rather different. [00:36:01] the ExtensionProcessor doesn't have any way of knowing that though... [00:36:24] should we just always add the default parameters and leave it up to the RLModule to use them if it wants to? [00:36:33] James_F: Oh they have gravatars now [00:36:40] legoktm: Yeah that seems sane [00:36:59] RoanKattouw: Yeah. [00:37:12] RoanKattouw: And visible points scores. [00:37:29] legoktm: If someone creates an RLModule with incompatible uses of localBasePath and remoteExtPath, they deserve the resulting breakage [00:37:38] heh :P [00:39:35] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:39:44] * James_F grins. [00:40:46] 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression] Media Settings - Infinite loop when an image is inserted - https://phabricator.wikimedia.org/T88764#1029646 (10Etonkovidova) Checked the fix in beta and in test2. [00:41:04] 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression] Media Settings - Infinite loop when an image is inserted - https://phabricator.wikimedia.org/T88764#1029647 (10Etonkovidova) [00:41:11] (03Merged) 10jenkins-bot: Update VE core submodule to master (c6dee65) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189864 (owner: 10Jforrester) [00:43:04] (03CR) 10Mattflaschen: [C: 04-1] "Looks mostly good; see inline." (0329 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [00:48:09] Krinkle|detached: Can you look at https://gerrit.wikimedia.org/r/#/c/186548/ (Ed wants you to +2). [00:50:11] RoanKattouw_away: And Trevor and Ed want you to +2 https://gerrit.wikimedia.org/r/#/c/186171/ and roll-over on your objections. :-) [00:51:05] edsanders: One last thing for the week and I think it's a wrap – https://gerrit.wikimedia.org/r/#/c/188741/ [00:51:23] James_F: I never objected on that change, Timo did [00:51:53] RoanKattouw: Oh, hmm. I swear TrevorP|Away asked you to +2. [00:51:58] * James_F re-reads scrollback. [00:52:00] That [00:52:02] 's fine [00:52:30] 3TemplateData: Can't edit "aliases" with TemplateData editor tool - https://phabricator.wikimedia.org/T88141#1029650 (10Jdforrester-WMF) 5Open>3stalled [00:53:06] (03CR) 10Catrope: [C: 032] Fix DOM structure on setup/teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 (owner: 10Esanders) [00:53:10] (03CR) 10jenkins-bot: [V: 04-1] Fix DOM structure on setup/teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 (owner: 10Esanders) [00:53:15] Ha. [00:53:21] Will fix [00:53:57] Thanks. :-) [00:59:33] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Pressing backspace or delete in IE11 makes the page jump around - https://phabricator.wikimedia.org/T89196#1029656 (10TTO) 3NEW [00:59:53] (03PS4) 10Catrope: Fix DOM structure on setup/teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 (owner: 10Esanders) [01:00:15] (03CR) 10Catrope: [C: 032] Fix DOM structure on setup/teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 (owner: 10Esanders) [01:00:17] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Pressing backspace or delete in IE11 makes the page jump around - https://phabricator.wikimedia.org/T89196#1029664 (10TTO) [01:00:18] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - https://phabricator.wikimedia.org/T52085#1029663 (10TTO) [01:01:57] (03Merged) 10jenkins-bot: Fix DOM structure on setup/teardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186171 (owner: 10Esanders) [01:03:56] (03CR) 10Catrope: [C: 032] Clean-up unnessecary calls of dialog.popPending() [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189773 (owner: 10Mvolz) [01:04:07] (03Merged) 10jenkins-bot: Clean-up unnessecary calls of dialog.popPending() [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/189773 (owner: 10Mvolz) [01:05:48] 3VisualEditor, VisualEditor-MediaWiki-Mobile: VisualEditor Mobile: [Regression pre-wmf10] Dependency on jquery.uls.data not met for mobile so VE does not appear, spins forever - https://phabricator.wikimedia.org/T68594#1029666 (10bmansurov) 5Open>3Resolved The error goes away after enabling the 'uls' role in... [01:20:09] (03CR) 10Krinkle: "Thx. On it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [01:27:09] RoanKattouw, James_F: https://gerrit.wikimedia.org/r/#/q/owner:%22Legoktm+%253Clegoktm.wikipedia%2540gmail.com%253E%22+status:open+topic:registration,n,z [01:35:06] (03PS13) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [01:35:17] (03PS12) 10Mooeypoo: Create APIResultsProvider and APIResultsQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [01:37:09] (03CR) 10jenkins-bot: [V: 04-1] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [01:44:45] (03PS13) 10Mooeypoo: Create APIResultsProvider and APIResultsQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [03:04:41] TrevorP|Away: Do you know why checking for duplicates based on hashes got removed from OO.ui.SelectWidget.prototype.addItems ? [03:06:44] I think I found it: https://github.com/wikimedia/oojs-ui/commit/649a6c6f420d2ad897819b42ab9cd619f12ae77f#diff-84351ce5fc1cd154bd37dd9fe3d15422 [04:51:05] InezK_away: it was a confusing API that nobody really needed - why? do you need that functionality? You can still get an item from data, which does hash based comparison [04:56:23] Why does onLoadError also emit loadError. It makes sense after 10 seconds, but it's still weird. [05:45:47] 3VisualEditor, VisualEditor-EditingTools: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1029938 (10John_Broughton) Those who noticed the contextual help on the meta (page settings) menu - I'm not one of them - apparently didn't think it wa... [06:35:10] (03CR) 10Krinkle: [C: 04-1] Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [06:35:56] (03PS6) 10Krinkle: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [06:36:00] (03CR) 10jenkins-bot: [V: 04-1] Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [07:18:36] (03CR) 10Fomafix: [C: 04-1] Convert .css to .less (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [07:48:23] 3TemplateData: Can't edit "aliases" with TemplateData editor tool - https://phabricator.wikimedia.org/T88141#1030101 (10Nnvu) Yes, I still have this issue. For example, [[https://it.wikipedia.org/wiki/Template:Opera/TemplateData|here]] I can't delete alias "titolo" from parameter "titoloitaliano". [09:28:52] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1030205 (10Susann_Schweden) [[https://de.wiktionary.org/wiki/Spezial:Einstellungen#mw-prefsection-editing]] now I marked the box ' Bearbeiten-Werkzeugleiste anzeigen' and now insert char works again. [09:49:13] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1030288 (10Formatierer) If you select under "Einstellungen" / "Bearbeiten" only "Erweiterte Bearbeiten-Werkzeugleiste aktivieren" and not "Bearbeiten-Werkzeugleiste anzeigen" then the global function insertTags() is undefined as c... [10:41:31] 3VisualEditor, VisualEditor-EditingTools: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1030483 (10Krenair) >>! In T53798#1029938, @John_Broughton wrote: > * The content of contextual help should be similar to templates: visible to everyon... [11:45:43] (03CR) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [12:11:24] MatmaRex: -selected is -active? [12:11:55] MatmaRex: .oo-ui-selectWidget-depressed &.oo-ui-optionWidget-selected. [12:12:05] MatmaRex: And -depressed is -pressed? [12:12:36] or it is unpress [12:12:39] depressed = not pressed [12:12:49] Right [12:13:17] -selected should probably have the same styles as -active, not sure right now [12:13:48] (when it is a button, of course) [12:15:12] When colors have semantic names its easier to spot places that are doing funny things. [12:21:44] (03PS1) 10Prtksxna: MediaWiki Theme: Rename @active to @pressed in button mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/189939 [12:21:46] (03PS1) 10Prtksxna: MediaWiki Theme: Rename active-* classes to pressed-* [oojs/ui] - 10https://gerrit.wikimedia.org/r/189940 [12:21:48] (03PS1) 10Prtksxna: MediaWiki Theme: Rename @highlight to @active [oojs/ui] - 10https://gerrit.wikimedia.org/r/189941 [12:23:29] (03CR) 10Prtksxna: "Esanders, did you fix the color issue?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/183482 (owner: 10Prtksxna) [12:28:19] (03PS1) 10Prtksxna: MediaWiki theme: Use distribution's image type and path for background [oojs/ui] - 10https://gerrit.wikimedia.org/r/189943 [12:34:04] MatmaRex: T88483, we can't change the color of the icon through CSS right? Would it be appropriate to change the URL for JS in this case? [12:38:05] (03CR) 10Bartosz Dziewoński: "Yes, was filed as T88948 and fixed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/183482 (owner: 10Prtksxna) [12:38:57] prtksxna: yes, see the MediaWikiTheme class in JS (and PHP) [12:39:15] it has logic for using white icons on primary buttons now [12:40:33] (03PS2) 10Bartosz Dziewoński: MediaWiki theme: Use distribution's image type and path for background [oojs/ui] - 10https://gerrit.wikimedia.org/r/189943 (owner: 10Prtksxna) [12:42:46] MatmaRex: Cool [12:44:00] (03CR) 10Bartosz Dziewoński: "Hmm, Apex theme has the same problem." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189943 (owner: 10Prtksxna) [12:44:26] MatmaRex: A separate patch ^ [12:45:05] MatmaRex: Oh, the same place, I'll append [12:46:28] (03PS3) 10Prtksxna: MediaWiki theme: Use distribution's image type and path for background [oojs/ui] - 10https://gerrit.wikimedia.org/r/189943 [12:47:09] (03PS4) 10Prtksxna: tools.less: Use distribution's image type and path for background [oojs/ui] - 10https://gerrit.wikimedia.org/r/189943 [12:54:12] (03PS1) 10Prtksxna: MediaWiki Theme: Use white icons for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) [12:54:14] (03PS1) 10Prtksxna: MediaWiki Theme: Fix background color for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189946 (https://phabricator.wikimedia.org/T88483) [12:56:44] 3UI-Standardization, WMF-Design, OOjs-UI: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1030719 (10Prtksxna) > disabled buttons - The disabled buttons in OOJS UI are difficult to read. They should probably adopt mediawiki-ui's disabled style. This is `#CCC` in... [13:23:38] (03CR) 10Prtksxna: [C: 04-1] "This makes the icons in frameless buttons disappear." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna) [13:28:19] 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1030823 (10Prtksxna) According to M37 frameless buttons should be `#CCC` which looks better. According to T88483 the background for disabled buttons should be `#DDD` which again... [13:29:21] (03CR) 10Esanders: [C: 032] tools.less: Use distribution's image type and path for background [oojs/ui] - 10https://gerrit.wikimedia.org/r/189943 (owner: 10Prtksxna) [13:30:00] (03CR) 10Esanders: [C: 032] MediaWiki Theme: Rename @active to @pressed in button mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/189939 (owner: 10Prtksxna) [13:30:12] (03PS1) 10Prtksxna: MediaWiki Theme: Use darker color for frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189947 (https://phabricator.wikimedia.org/T88622) [13:30:37] (03Merged) 10jenkins-bot: tools.less: Use distribution's image type and path for background [oojs/ui] - 10https://gerrit.wikimedia.org/r/189943 (owner: 10Prtksxna) [13:31:39] (03Merged) 10jenkins-bot: MediaWiki Theme: Rename @active to @pressed in button mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/189939 (owner: 10Prtksxna) [13:37:57] (03PS1) 10Prtksxna: MediaWiki Theme: Add focus state for frameless button [oojs/ui] - 10https://gerrit.wikimedia.org/r/189949 (https://phabricator.wikimedia.org/T87692) [13:38:18] 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1030867 (10Prtksxna) a:3Prtksxna [13:39:07] (03PS2) 10Prtksxna: MediaWiki Theme: Use white icons for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) [13:39:10] (03PS2) 10Prtksxna: MediaWiki Theme: Fix background color for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189946 (https://phabricator.wikimedia.org/T88483) [13:39:12] (03PS2) 10Prtksxna: MediaWiki Theme: Use darker color for frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189947 (https://phabricator.wikimedia.org/T88622) [13:46:24] 3MediaWiki-extensions-Translate, Possible-Tech-Projects, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#1030924 (10Qgil) Wikimedia will [[ https://phabricator.wikimedia.org/T921... [13:46:38] (03PS5) 10Bartosz Dziewoński: MenuSelectWidget: Remove dead code [oojs/ui] - 10https://gerrit.wikimedia.org/r/189644 [13:46:40] (03PS5) 10Bartosz Dziewoński: DropdownWidget, ComboBoxWidget: Make keyboard-accessible [oojs/ui] - 10https://gerrit.wikimedia.org/r/189609 (https://phabricator.wikimedia.org/T87705) [13:46:42] (03PS5) 10Bartosz Dziewoński: MenuSelectWidget: Codify current behavior of Tab closing the menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/189608 [13:46:44] (03PS1) 10Bartosz Dziewoński: MenuSelectWidget: Don't clobber other events when unbinding [oojs/ui] - 10https://gerrit.wikimedia.org/r/189950 [13:54:17] (03CR) 10Ricordisamoa: "I don't think #images.json# and .#images.json were ever supposed to be committed, am I wrong?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189947 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna) [14:02:06] (03PS3) 10Prtksxna: MediaWiki Theme: Use white icons for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) [14:02:08] (03PS3) 10Prtksxna: MediaWiki Theme: Use darker color for frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189947 (https://phabricator.wikimedia.org/T88622) [14:20:25] 3UI-Standardization, OOjs-UI: Apply consistent animation and timings to controls and transitions (tracking) - https://phabricator.wikimedia.org/T78371#1031001 (10Prtksxna) In #oojs-ui only radios and checkboxes have a transition time of `0.2s`. All other elements are at `0.1s`. But, if you see the elements chang... [14:41:00] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1031048 (10Aklapper) 5stalled>3Invalid a:3Aklapper So this looks like the problem: ```"Loading de-transliteration" load.php:96 "de-transliteration loaded" load.php:96 ReferenceError: insertTags is not defined index.php:1 Syn... [15:15:24] 3OOjs-UI: PopupButtonWidget menu is not keyboard traversable/closeable - https://phabricator.wikimedia.org/T87695#1031204 (10matmarex) Is this still a problem after the recent button pressability refactor? [15:33:14] Morning. [15:36:58] (03PS1) 10Esanders: Use node type constants in ve.ce.getDomHash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189967 [15:40:52] 3UI-Standardization, OOjs-UI: ToggleSwitchWidget has no visual representation for focused state - https://phabricator.wikimedia.org/T88973#1031253 (10matmarex) ToggleSwitch was created by @TrevorParscal for Apex theme and very quickly adapted for MediaWiki theme when it was being added. It looks a lot more sensi... [15:42:04] morning James_F [15:45:07] (03PS1) 10Esanders: Ignore block slugs in ve.ce.getHash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189969 [15:45:59] Is https://gerrit.wikimedia.org/r/#/c/189939/ a breaking change? Renaming things… [15:47:55] (03PS2) 10Esanders: Ignore block slugs in ve.ce.getHash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189969 [15:48:05] edsanders? [15:48:30] no [15:48:41] renames a less variable [15:48:49] Oh, not the class name? OK. [15:51:46] huh, ToggleSwitchWidgetOnOff used to look sexy. [15:52:05] ToggleSwitchWidget* http://i.imgur.com/p7Wnqil.png [15:52:25] MatmaRex: Yeah. Trevor removed the labels because he didn't like them. :-( [15:52:47] MatmaRex: Maybe created LabelledToggleSwitchWidget to bring back the coolness? ;-) [15:53:53] James_F: i'm contemplating bringing back the coolness of the toggle being actually draggable [15:54:03] Eh. [15:54:08] Draggable toggle == slider. [15:54:22] A slider with two sticky positions, but a slider. [15:54:28] well, yes [15:54:34] Might as well go the whole hog and provide a SliderWidget. [15:54:55] we're just calling it a SwitchWidget rather than Slider, but it's the same thing [15:55:02] But there's no real use case for it, and we've got a lot of work to do on Q3 stuff. [15:55:12] and things that look like this are actually draggable in every UI i've seen [15:55:25] good thing this just requires reverting some old changes! [15:55:35] "Just". :-) [16:15:36] 3UI-Standardization, OOjs-UI: ToggleSwitchWidget has no visual representation for focused state - https://phabricator.wikimedia.org/T88973#1031402 (10Ricordisamoa) >>! In T88973#1031253, @matmarex wrote: > ToggleSwitch was created by @TrevorParscal for Apex theme and very quickly adapted for MediaWiki theme when... [16:32:10] (03PS1) 10Bartosz Dziewoński: Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) [16:32:12] (03PS1) 10Bartosz Dziewoński: OptionWidgets: Make better use of 'scrollIntoViewOnSelect' [oojs/ui] - 10https://gerrit.wikimedia.org/r/189989 [16:33:24] (03CR) 10jenkins-bot: [V: 04-1] Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [16:33:32] (03CR) 10jenkins-bot: [V: 04-1] OptionWidgets: Make better use of 'scrollIntoViewOnSelect' [oojs/ui] - 10https://gerrit.wikimedia.org/r/189989 (owner: 10Bartosz Dziewoński) [16:34:03] (03PS2) 10Bartosz Dziewoński: OptionWidgets: Make better use of 'scrollIntoViewOnSelect' [oojs/ui] - 10https://gerrit.wikimedia.org/r/189989 [16:35:57] (03PS2) 10Bartosz Dziewoński: Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) [16:38:37] (03PS10) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [16:47:17] (03CR) 10Paladox: Convert .css to .less (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [16:49:24] (03CR) 10Paladox: Convert .css to .less (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [16:51:31] (03CR) 10Jforrester: "Breaking change?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189940 (owner: 10Prtksxna) [16:55:15] (03PS2) 10Bartosz Dziewoński: MediaWiki Theme: Rename active-* variables to pressed-* [oojs/ui] - 10https://gerrit.wikimedia.org/r/189940 (owner: 10Prtksxna) [16:55:43] (03CR) 10Bartosz Dziewoński: "Not breaking, this is all private and unavailable outside." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189940 (owner: 10Prtksxna) [16:56:05] Yay confusion. :-) [17:01:24] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Pressing backspace or delete in IE11 makes the page jump around - https://phabricator.wikimedia.org/T89196#1031470 (10matmarex) [17:01:25] 3VisualEditor, VisualEditor-ContentEditable: Pressing "Backspace" or creating a heading causes the page to abruptly scroll up on Internet Explorer 11 - https://phabricator.wikimedia.org/T73119#1031471 (10matmarex) [17:01:27] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - https://phabricator.wikimedia.org/T52085#1031469 (10matmarex) [17:01:36] (03CR) 10Paladox: Convert .css to .less (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [17:01:40] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Pressing backspace or delete in IE11 makes the page jump around - https://phabricator.wikimedia.org/T89196#1029656 (10matmarex) [17:02:15] 3VisualEditor, VisualEditor-ContentEditable: Pressing Backspace/Delete or creating a heading causes the page to abruptly scroll up on Internet Explorer 11 - https://phabricator.wikimedia.org/T73119#1031486 (10matmarex) [17:06:53] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Test whether paste binding needs "beforepaste" for MSIE compatibility - https://phabricator.wikimedia.org/T67714#1031499 (10Jdforrester-WMF) [17:06:54] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Some dialogs are showing with transparent backgrounds in IE11 - https://phabricator.wikimedia.org/T74643#1031498 (10Jdforrester-WMF) [17:06:56] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Save dialog throws "Uncaught TypeError: Cannot read get getModel of undefined" (IE9) - https://phabricator.wikimedia.org/T64334#1031500 (10Jdforrester-WMF) [17:06:58] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Inspectors close immediately in IE - https://phabricator.wikimedia.org/T71503#1031501 (10Jdforrester-WMF) [17:07:00] 3VisualEditor: VisualEditor: isMsie doesn't catch MSIE 11+ - https://phabricator.wikimedia.org/T68096#1031502 (10Jdforrester-WMF) [17:07:01] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Editing of headings is broken in IE10 - https://phabricator.wikimedia.org/T52088#1031503 (10Jdforrester-WMF) [17:07:02] 3VisualEditor: VisualEditor: Impossible to review or save changes in IE10 - https://phabricator.wikimedia.org/T52086#1031504 (10Jdforrester-WMF) [17:07:18] 3VisualEditor: VisualEditor: isMsie doesn't catch MSIE 11+ - https://phabricator.wikimedia.org/T68096#684850 (10Jdforrester-WMF) [17:07:19] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Inspectors close immediately in IE - https://phabricator.wikimedia.org/T71503#749914 (10Jdforrester-WMF) [17:07:20] 3VisualEditor: VisualEditor: Impossible to review or save changes in IE10 - https://phabricator.wikimedia.org/T52086#563545 (10Jdforrester-WMF) [17:07:21] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Test whether paste binding needs "beforepaste" for MSIE compatibility - https://phabricator.wikimedia.org/T67714#702169 (10Jdforrester-WMF) [17:07:23] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Save dialog throws "Uncaught TypeError: Cannot read get getModel of undefined" (IE9) - https://phabricator.wikimedia.org/T64334#676022 (10Jdforrester-WMF) [17:07:24] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Some dialogs are showing with transparent backgrounds in IE11 - https://phabricator.wikimedia.org/T74643#772970 (10Jdforrester-WMF) [17:07:25] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Editing of headings is broken in IE10 - https://phabricator.wikimedia.org/T52088#563770 (10Jdforrester-WMF) [17:07:27] 3VisualEditor, VisualEditor-ContentEditable: Pressing Backspace/Delete or creating a heading causes the page to abruptly scroll up on Internet Explorer 11 - https://phabricator.wikimedia.org/T73119#1031513 (10Jdforrester-WMF) [17:07:28] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Save page dialog's edit summary text box is black in Internet Explorer 11 - https://phabricator.wikimedia.org/T74917#1031514 (10Jdforrester-WMF) [17:07:29] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: IE9 doesn't load new page when when re-editing a page modified in another browser - https://phabricator.wikimedia.org/T65048#1031516 (10Jdforrester-WMF) [17:07:30] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Console shows "Permission denied" on IE9 when VE is first initiated - https://phabricator.wikimedia.org/T65039#1031515 (10Jdforrester-WMF) [17:07:31] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Can't create new paragraph by hitting return in IE9(?) - https://phabricator.wikimedia.org/T65038#1031518 (10Jdforrester-WMF) [17:07:33] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: VE crash mid-edit in IE9 - https://phabricator.wikimedia.org/T51464#1031517 (10Jdforrester-WMF) [17:07:34] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Check whether we work in IE11 fine, and if so, add to the whitelist - https://phabricator.wikimedia.org/T52874#1031521 (10Jdforrester-WMF) [17:07:35] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Work around Internet Explorer's caching of Parsoid responses - https://phabricator.wikimedia.org/T74480#1031519 (10Jdforrester-WMF) [17:07:37] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: IE9/10 incompatibilities with saving process - https://phabricator.wikimedia.org/T51187#1031520 (10Jdforrester-WMF) [17:07:38] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Transclusion editor broken in IE10 (stack overflow) - https://phabricator.wikimedia.org/T52044#1031523 (10Jdforrester-WMF) [17:07:39] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Broken appearance when window is too small in Internet Explorer - https://phabricator.wikimedia.org/T65778#1031522 (10Jdforrester-WMF) [17:07:40] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Right-click in IE10 causes deletion of the selected content - https://phabricator.wikimedia.org/T52045#1031524 (10Jdforrester-WMF) [17:07:41] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Fatal "SCRIPT16389: Unspecified error" error in IE9 - https://phabricator.wikimedia.org/T65697#1031526 (10Jdforrester-WMF) [17:07:43] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Icons render weirdly in IE10 - https://phabricator.wikimedia.org/T65749#1031525 (10Jdforrester-WMF) [17:07:44] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Context menu appears in the wrong place in IE10 when zoomed in - https://phabricator.wikimedia.org/T43233#1031527 (10Jdforrester-WMF) [17:07:45] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: IE9 skips header line in table - https://phabricator.wikimedia.org/T65046#1031528 (10Jdforrester-WMF) [17:07:48] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - https://phabricator.wikimedia.org/T52085#1031505 (10Jdforrester-WMF) [17:08:03] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Browser blacklist issues (tracking) - https://phabricator.wikimedia.org/T52781#1031534 (10Jdforrester-WMF) [17:08:04] 3VisualEditor, VisualEditor-Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - https://phabricator.wikimedia.org/T52085#1031531 (10Jdforrester-WMF) 5Open>3Invalid a:3Jdforrester-WMF Now replaced by https://phabricator.wikimedia.org/maniphest/query/V25BI8.HgRPz/#R instead. [17:09:09] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Blanking the page does not remove meta-data (categories, defaultsort keys, etc.) - https://phabricator.wikimedia.org/T63858#1031537 (10Jdforrester-WMF) p:5Triage>3Low [17:11:13] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - https://phabricator.wikimedia.org/T51806#1031547 (10matmarex) [17:11:14] 3VisualEditor: invisible templates in the visual editor - https://phabricator.wikimedia.org/T89105#1031546 (10matmarex) [17:12:02] 3VisualEditor, VisualEditor-EditingTools: Context menu can appear offscreen if the selected item starts offscreen (e.g. a long transclusion) - https://phabricator.wikimedia.org/T51922#1031551 (10Jdforrester-WMF) [17:12:10] 3VisualEditor, VisualEditor-ContentEditable: Template edit link to low - https://phabricator.wikimedia.org/T71968#1031553 (10Jdforrester-WMF) [17:12:12] 3VisualEditor, VisualEditor-EditingTools: Context menu can appear offscreen if the selected item starts offscreen (e.g. a long transclusion) - https://phabricator.wikimedia.org/T51922#540839 (10Jdforrester-WMF) [17:12:40] 3VisualEditor: VisualEditor: Be able to search for an existing image by name - https://phabricator.wikimedia.org/T72243#1031557 (10Jdforrester-WMF) p:5Triage>3Volunteer? [17:12:58] 3OOjs-UI: OOjs UI: In certain situations involving StackLayouts, removing items scrolls the focus up to the top - https://phabricator.wikimedia.org/T64420#1031560 (10matmarex) [17:12:59] 3VisualEditor-MediaWiki, VisualEditor: In extended transclusion dialog, clicking the up/down arrow button-icons to move transclusions causes highlight to jump around - https://phabricator.wikimedia.org/T75694#1031559 (10matmarex) [17:13:00] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: [Regression] In Transclusion (multi-template) dialog, moving a template past a content block then focuses the content block, not the selected template - https://phabricator.wikimedia.org/T72849#1031561 (10matmarex) [17:13:24] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: {{lowercasetitle}} is not reflected in Display title in Advanced page settings - https://phabricator.wikimedia.org/T72880#1031562 (10Jdforrester-WMF) [17:13:27] 3VisualEditor: allow edit templates inside parameters of other templates - https://phabricator.wikimedia.org/T89121#1031565 (10matmarex) [17:13:30] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#1031566 (10matmarex) [17:14:16] 3VisualEditor, VisualEditor-EditingTools: Selecting correct image format isn't possible - https://phabricator.wikimedia.org/T72785#1031568 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF We now show the image's format and its full name. [17:14:48] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: "Uncaught TypeError: Cannot read property 'getSurface' of null" when applying a heading format on citation - https://phabricator.wikimedia.org/T72888#1031571 (10Jdforrester-WMF) p:5Triage>3Normal [17:15:53] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: CAPTCHA that appears when saving is hard to find - https://phabricator.wikimedia.org/T72266#1031573 (10Jdforrester-WMF) p:5Triage>3Normal [17:16:45] 3VisualEditor: VisualEditor: Adding a template to a redirect did not let me save the page - https://phabricator.wikimedia.org/T72305#1031583 (10Jdforrester-WMF) 5stalled>3Resolved a:3Jdforrester-WMF Sounds like the editor had crashed by the time you added the template… Can't reproduce now, however. :-( [17:17:43] 3VisualEditor, VisualEditor-DataModel, VisualEditor-ContentEditable: Support deleting non-contiguous selections - https://phabricator.wikimedia.org/T71737#1031591 (10Jdforrester-WMF) p:5Triage>3Volunteer? [17:18:24] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: The custom tab does not get enabled after making an image of type "Frame" to full size - https://phabricator.wikimedia.org/T71794#1031605 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Correct MediaWiki behaviour. [17:19:39] 3VisualEditor, VisualEditor-MediaWiki-Media: Please warn if user adds caption for a pic but then chooses an image type that won't display it - https://phabricator.wikimedia.org/T72603#1031608 (10Jdforrester-WMF) p:5Triage>3Low [17:20:26] 3VisualEditor: VisualEditor: After you create a link and close the link inspector, please de-select the newly linked text - https://phabricator.wikimedia.org/T71711#1031612 (10Jdforrester-WMF) 5stalled>3declined a:3Jdforrester-WMF We've intentionally chosen this behaviour after a huge amount of user and p... [17:21:05] 3VisualEditor: narrow field of the row parameter - https://phabricator.wikimedia.org/T89119#1031615 (10matmarex) [17:21:06] 3VisualEditor, OOjs-UI: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1031616 (10matmarex) [17:21:17] 3VisualEditor: VisualEditor/WikiEditor: Consistent terminology - https://phabricator.wikimedia.org/T72439#1031618 (10Jdforrester-WMF) p:5Triage>3Low [17:21:20] 3VisualEditor: narrow field of the row parameter - https://phabricator.wikimedia.org/T89119#1027759 (10matmarex) Sorry, this is a recent regression :( [17:21:26] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor/WikiEditor: Consistent terminology - https://phabricator.wikimedia.org/T72439#759818 (10Jdforrester-WMF) [17:21:32] James_F: https://phabricator.wikimedia.org/T89015 realllly could use a backport. [17:22:20] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: Allow seeing all template parameters at once - https://phabricator.wikimedia.org/T71734#1031622 (10Jdforrester-WMF) p:5Triage>3Volunteer? How would this work? How does VisualEditor know that you wanted a field specified and left blank, vs. haven't set it? [17:22:53] 3VisualEditor, VisualEditor-MediaWiki-Templates: Allow setting all template parameters at once without having to pick which ones to enter - https://phabricator.wikimedia.org/T71734#1031624 (10Jdforrester-WMF) [17:23:30] MatmaRex: Good luck. Manually-created cherry-picks of OOjs UI and inserting into mediawiki/vendor? [17:23:43] MatmaRex: In other words: don't screw up in OOjs UI, it's hard. [17:23:55] James_F: no need for vendor changes [17:24:05] MatmaRex: Err. Yes there are. Do you want it to go live? [17:24:10] and we just did such a backport like, yesterday? [17:24:12] MatmaRex: Production uses /vendor. [17:24:20] not for JS code… [17:24:26] Oh, this is JS-only? [17:24:32] That's certainly a lot easier. :_) [17:27:21] 3OOjs-UI: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari - https://phabricator.wikimedia.org/T69156#1031656 (10matmarex) [17:27:24] 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-EditingTools: Navigating via Tab between fields in TransclusionCitation boxes switches to the Find/Replace fields in the background - https://phabricator.wikimedia.org/T84919#1031655 (10matmarex) [17:27:25] 3VisualEditor, VisualEditor-EditingTools: VisualEditor:The reflist of the page disappears after adding a reflist to an image - https://phabricator.wikimedia.org/T59277#1031657 (10Jdforrester-WMF) [17:27:28] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Parsoid's render of {{reflist}} has no context, so no references appear; similarly, edited templates inside structures, look odd on edit - https://phabricator.wikimedia.org/T53146#1031658 (10Jdforrester-WMF) [17:28:12] 3VisualEditor: VisualEditor: VisualEditor should strip returns from the end of template parameters - https://phabricator.wikimedia.org/T63049#1031661 (10matmarex) This is now being done for named parameters per T52439, which do not preserve whitespace. However, it must not be done for positional parameters (lik... [17:28:55] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-MediaWiki-References: Regression pre-wmf16 :Re-Use option stays active even after deleting the citation. - https://phabricator.wikimedia.org/T87106#1031664 (10Jdforrester-WMF) [17:28:57] 3VisualEditor, VisualEditor-DataModel: VisualEditor: When adding a reference, and a reference in a caption, in the same edit, then the ref in the caption is changed to the ref from the text - https://phabricator.wikimedia.org/T60322#1031665 (10Jdforrester-WMF) [17:29:11] 3VisualEditor, VisualEditor-DataModel: VisualEditor: When adding a reference, and a reference in a caption, in the same edit, then the ref in the caption is changed to the ref from the text - https://phabricator.wikimedia.org/T60322#646558 (10Jdforrester-WMF) {T87106} isn't quite a duplicate of the outcome, but... [17:29:26] 3VisualEditor, VisualEditor-MediaWiki-Templates: VisualEditor should enforce TemplateData's 'type': 'line' for template parameters (no multiline input) - https://phabricator.wikimedia.org/T63049#1031672 (10matmarex) [17:29:47] 3VisualEditor: Exact match is not always first in VisualEditor link widget autocomplete - https://phabricator.wikimedia.org/T87731#1031676 (10Jdforrester-WMF) [17:29:50] 3VisualEditor, VisualEditor-MediaWiki-Links: If there is a page with the exact name, it should appear first in the link auto-complete list - https://phabricator.wikimedia.org/T71780#1031677 (10Jdforrester-WMF) [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111745507 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111745554 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111745669 [17:30:37] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34284857 [17:30:38] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34285269 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68514369 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68514450 [17:30:39] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68518078 [17:31:05] 3VisualEditor: VisualEditor: Section headings look like they've been removed, but they're still present when the page is saved - https://phabricator.wikimedia.org/T69061#1031683 (10Jdforrester-WMF) 5stalled>3Resolved a:3Jdforrester-WMF Can't reproduce. Hopefully this is properly gone now. Wish we could co... [17:31:53] 3TemplateData: Can't edit "aliases" with TemplateData editor tool - https://phabricator.wikimedia.org/T88141#1031686 (10Mooeypoo) Got it. Thank you for reporting, I'm looking at a solution now. [17:31:57] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: The link inspector appears over the toolbar while trying to add it inside an image for the first time - https://phabricator.wikimedia.org/T70355#1031687 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Resolved months ago. [17:32:02] 3TemplateData: Can't edit "aliases" with TemplateData editor tool - https://phabricator.wikimedia.org/T88141#1031690 (10Mooeypoo) a:3Mooeypoo [17:32:34] 3VisualEditor, VisualEditor-Tables: Allow keyboard arrows to move between cells in a table - https://phabricator.wikimedia.org/T84851#1031693 (10Jdforrester-WMF) p:5Triage>3Volunteer? [17:33:15] 3VisualEditor, VisualEditor-MediaWiki-Templates: VisualEditor should enforce TemplateData's 'type': 'line' for template parameters (no multiline input) - https://phabricator.wikimedia.org/T63049#1031699 (10matmarex) `modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js` actually has `// TODO: Use spec.type` :) (shoul... [17:34:47] 3VisualEditor, VisualEditor-Tables, VisualEditor-ContentEditable: Allow wikiformat in tables - https://phabricator.wikimedia.org/T84850#1031708 (10Jdforrester-WMF) 5Open>3Invalid a:3Jdforrester-WMF [17:36:25] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Moving the cursor with keyboard over a footnote number goes back and forth - https://phabricator.wikimedia.org/T74137#1031717 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Works for me now. Wish we could confirm when we'd fixed this. :-( [17:37:36] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: The comment icon is repeatedly selected and deselected with the keyboard - https://phabricator.wikimedia.org/T73550#1031722 (10Jdforrester-WMF) This should have been resolved with the switch to native cursoring that goes out in wmf17. Please say if not. [17:37:43] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: The comment icon is repeatedly selected and deselected with the keyboard - https://phabricator.wikimedia.org/T73550#1031725 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [17:38:02] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: The comment icon is repeatedly selected and deselected with the keyboard - https://phabricator.wikimedia.org/T73550#768996 (10Jdforrester-WMF) p:5Triage>3High a:5Jdforrester-WMF>3dchan [17:39:24] 3VisualEditor, VisualEditor-MediaWiki-Templates: VisualEditor should enforce TemplateData's 'type': 'line' for template parameters (no multiline input) - https://phabricator.wikimedia.org/T63049#1031739 (10Jdforrester-WMF) [17:39:27] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Transclusion dialog should validate template parameter values using TemplateData information - https://phabricator.wikimedia.org/T54651#1031738 (10Jdforrester-WMF) [17:39:39] 3VisualEditor, VisualEditor-MediaWiki-Templates: VisualEditor should enforce TemplateData's 'type': 'line' for template parameters (no multiline input) - https://phabricator.wikimedia.org/T63049#1031740 (10Jdforrester-WMF) p:5Triage>3Normal [17:40:06] James_F, do we have a schedule for the deployment of TemplateData extension to production wikis? A bug I'm looking at is because the code is old in production; it's fixed for a while in master. [17:40:54] "Please test that you can successfully use WebEx in advance of the meeting" on https://www.mediawiki.org/w/index.php?title=Talk:VisualEditor/Portal feels ironic, because the "Join" button on the link is greyed out until the meeting starts. [17:42:01] andre__: WebEx has dozens of help pages to test out, though. [17:42:16] andre__: Localised help that is better than anything we can write. [17:42:28] in that case, linking to those test pages from that sentence would be cool [17:42:43] It would be if they had a static URL, yes. :-) [17:42:53] gnarf [17:42:57] Indeed. [17:43:41] 3MediaWiki-Vagrant, VisualEditor, MediaWiki-Configuration: Vagrant VE role localsettings conflicts with VisualEditor's user option defaults - https://phabricator.wikimedia.org/T88665#1031751 (10Jdforrester-WMF) a:3Legoktm [17:43:48] 3MediaWiki-Vagrant, VisualEditor, MediaWiki-Configuration: Vagrant VE role localsettings conflicts with VisualEditor's user option defaults - https://phabricator.wikimedia.org/T88665#1017497 (10Jdforrester-WMF) p:5Triage>3Normal [17:43:49] 3TemplateData: Can't edit "aliases" with TemplateData editor tool - https://phabricator.wikimedia.org/T88141#1031755 (10Mooeypoo) I looked into this. This bug was fixed in master by this fix https://gerrit.wikimedia.org/r/#/c/182980/ This has not yet been deployed but should go into Wikipedia today, and that bu... [17:44:07] 3VisualEditor: Create test plan for VE on mobile evaluation for new users - https://phabricator.wikimedia.org/T88756#1031756 (10Jdforrester-WMF) p:5Triage>3Normal [17:45:38] 3VisualEditor, VisualEditor-MediaWiki-Links: Remove whitespace from user-inputted links - https://phabricator.wikimedia.org/T89013#1031758 (10Jdforrester-WMF) p:5Triage>3Normal [17:49:09] 3VisualEditor, VisualEditor-EditingTools: Pasting text with a line that starts with : (colon) / ; (semi-colon) turns it bold/indented (but button status does not reflect that) - https://phabricator.wikimedia.org/T89115#1031772 (10Jdforrester-WMF) 5Open>3stalled I can't reproduce. Was the text you were copyin... [17:49:30] 3VisualEditor-MediaWiki, VisualEditor: Create a guided tour for VisualEditor using Getting Started tooltips - https://phabricator.wikimedia.org/T89074#1031774 (10Jdforrester-WMF) p:5Triage>3High [17:51:34] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor is not the editor linked from the diff page - https://phabricator.wikimedia.org/T89060#1031781 (10Jdforrester-WMF) p:5Triage>3Normal [17:52:22] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor is not the editor linked from the diff page - https://phabricator.wikimedia.org/T89060#1026575 (10Jdforrester-WMF) Related to {T55441} [17:53:51] 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression] Media Settings - Infinite loop when an image is inserted - https://phabricator.wikimedia.org/T88764#1031802 (10Jdforrester-WMF) 5Open>3Resolved [17:56:06] 3TemplateData: Can't edit "aliases" with TemplateData editor tool - https://phabricator.wikimedia.org/T88141#1031808 (10Nnvu) Understood. I'll let you know tomorrow if it has been fixed correctly. [18:03:30] 3VisualEditor-MediaWiki, VisualEditor, VisualEditor-ContentEditable: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - https://phabricator.wikimedia.org/T53423#1031831 (10Aklapper) This task has #VE-deploy-2014-10-02 but is still open. Should this be retargetted? [18:06:24] 3VisualEditor-MediaWiki, VisualEditor: Create a guided tour for VisualEditor using Getting Started tooltips - https://phabricator.wikimedia.org/T89074#1031850 (10Elitre) https://phabricator.wikimedia.org/T52601 was related. [18:08:19] RoanKattouw_away: James_F|Away: for backporting: https://gerrit.wikimedia.org/r/#/c/189341/ [18:10:29] (03PS11) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [18:16:46] (03PS12) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [18:19:31] (03CR) 10Paladox: "@Mattflaschen please review again with the new patch." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [18:26:31] (03PS1) 10Esanders: Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 [18:28:19] (03CR) 10jenkins-bot: [V: 04-1] Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (owner: 10Esanders) [18:48:33] 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki-References: The citation dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76927#1032005 (10Etonkovidova) [18:51:13] 3VisualEditor: Media Settings "Uploaded by..." not consistently accurate - https://phabricator.wikimedia.org/T88835#1032018 (10Mooeypoo) Okay, we need to figure out what to do with the labling of the information we're receiving from the API. From the info we're getting from the api, here's what's relevant to... [18:52:28] 3VisualEditor, VisualEditor-CopyPaste: Ctrl+C copying of text with template removes text in FF - https://phabricator.wikimedia.org/T86921#1032019 (10Whatamidoing-WMF) [18:52:34] 3VisualEditor: Media Settings "Uploaded by..." not consistently accurate - https://phabricator.wikimedia.org/T88835#1032021 (10Jdforrester-WMF) Maybe add "Uploader" from `imageinfo iiprop user` with the current label, and add "Artist" as the label for the existing field? [18:52:57] 3VisualEditor, VisualEditor-EditingTools: Pasting text with a line that starts with : (colon) / ; (semi-colon) turns it bold/indented (but button status does not reflect that) - https://phabricator.wikimedia.org/T89115#1032023 (10Sunpriat) 1) this text is already in the article -> when you open the article in th... [18:53:09] Seriously, I don't see how any volunteer will ever join a triage meeting if there's no previous testing available. [18:53:12] would http://www.webex.com/test-meeting.html work? [18:53:35] looks like I need to enter a name and email address for no reason? [18:53:36] 3VisualEditor, VisualEditor-Tables, VisualEditor-ContentEditable: An image inserted to table cell, break the table - https://phabricator.wikimedia.org/T86501#1032025 (10Whatamidoing-WMF) [18:53:41] andre__: Indeed. :-( [18:53:42] 3VisualEditor: Media Settings "Uploaded by..." not consistently accurate - https://phabricator.wikimedia.org/T88835#1032027 (10Mooeypoo) a:3Mooeypoo [18:53:43] looks like I need to install a Java plugin for a browser? sigh [18:53:47] And that too. [18:54:04] that's all... very time-consuming if it was 70min later than it is now [18:54:07] RoanKattouw: can you share the spreadsheet you're using to record the impact perf-related changes? [18:54:10] *impact of [18:54:13] andre__: you can also call by phone, allegedly. [18:54:23] * andre__ installs Java crapware [18:54:34] giving new meaning to "phoning it in" [18:54:37] MatmaRex, yeah, but that's even scarier :) [18:54:55] andre__: on the plus side, your phone already has java [18:54:56] 3VisualEditor, VisualEditor-Tables, VisualEditor-ContentEditable: VisualEditor: Tab/Shift-Tab behaviour in other contexts (and tables) - https://phabricator.wikimedia.org/T72665#1032028 (10Whatamidoing-WMF) [18:54:59] andre__: Don't use the phone unless you really, /really/ have to. The quality is abysmal. [18:55:12] I don't use phones in general anyway. :) [18:55:19] ori: s [18:55:21] ori: Sure. [18:55:30] James_F, what was the VE event logging thing you mentioned? [18:55:33] FYI I've just changed my script to also track medians [18:55:43] And I'm gonna be maintaining a separate sheet with median values [18:56:10] Because while min sounds like a good metric in theory, my confidence in its practicality is decreasing [18:56:11] Krenair: onBeforeUnload handler for Aborts. [18:56:24] RoanKattouw: why? [18:56:37] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Up/down keys in table move left/right instead - https://phabricator.wikimedia.org/T67589#1032030 (10Whatamidoing-WMF) [18:56:42] ori: Also it's already shared with you, it's called vbench (there are multiple sheets, see tab bar at the bottom) [18:56:59] The data seems quite variable [18:57:17] In any case, I'm now tracking both [18:57:20] So we'll see [18:57:55] 3VisualEditor: Category disappeared during edit - https://phabricator.wikimedia.org/T85671#1032033 (10Whatamidoing-WMF) [18:58:31] 3MediaWiki-Page-editing: insert strings - https://phabricator.wikimedia.org/T88941#1032034 (10Formatierer) No this is not specific to german wiktionary. You can reproduce the same behavior on the englisch wiktionary. 1. Select 'Preferences' 2. In tab 'Editing': 2a: disable 'Show the edit toolbar (requires JavaSc... [18:58:41] 3VisualEditor-MediaWiki, VisualEditor: Random removal of categories - https://phabricator.wikimedia.org/T76998#1032039 (10Whatamidoing-WMF) This might be the same problem as T85671. [18:59:15] 3VisualEditor, VisualEditor-DataModel: VisualEditor: [Regression] VE corruption issue(?) moving pre-existing categories to the middle of the page - https://phabricator.wikimedia.org/T74048#1032041 (10Whatamidoing-WMF) [19:00:03] 3VisualEditor-MediaWiki, VisualEditor: Random removal of categories when using Safari - https://phabricator.wikimedia.org/T76998#1032042 (10Jdforrester-WMF) [19:00:22] 3VisualEditor: Category disappeared during edit - https://phabricator.wikimedia.org/T85671#1032044 (10Jdforrester-WMF) [19:00:23] 3VisualEditor-MediaWiki, VisualEditor: Random removal of categories when using Safari - https://phabricator.wikimedia.org/T76998#824453 (10Jdforrester-WMF) [19:00:43] 3VisualEditor-MediaWiki, VisualEditor: Random removal of categories when using Safari - https://phabricator.wikimedia.org/T76998#824453 (10Jdforrester-WMF) [19:06:38] hey RoanKattouw / TrevorP|Away etc, how do I make VE compatible with a new skin? [19:06:58] werdna: Is the skin based on Vector? [19:07:04] Not at all [19:07:12] werdna: Oh. In that case, umm, good luck. [19:07:32] VisualEditor assumes you're using lots of things that are Vector-style-skin-specific, apparently. [19:07:49] Why? [19:08:17] (Things like the DOM structure of the page and the names of various classes; fundamental things to the VisualEditor integration.) [19:08:35] Living Style Guide [19:08:46] A few things in ViewPageTarget do, yeah [19:08:48] (03PS2) 10Esanders: Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 [19:08:48] Oh, you're making a skin for that? [19:08:51] But not too much code, all in all [19:09:01] It shouldn't be that hard… Can't I just tell it where the edit button is and where the page content is? [19:09:03] RoanKattouw: Except if he wants to run off the train/master… [19:09:16] werdna: Yeah we should really have more generic support for that probably [19:09:30] It's priority #2000 (approximately), though. [19:09:32] werdna: Right now the IDs of such things are "standardized" between skins, or there are only two possible values [19:09:53] well, I can change the IDs and stuff, that's no problem [19:09:55] Most of the relevant code is in ve.init.mw.ViewPageTarget.js and ve.init.mw.ViewPageTarget.init.js [19:10:17] Searching for ID selectors (like $( '# ) should be a good start I suppose [19:10:28] I knew about those, but I'm not actually getting a VE edit tab at all at the moment [19:10:31] and I can't figure out why [19:10:48] $wgVisualEditorSupportedSkins doesn't seem to ever be used at all [19:11:11] I wrote those all down at some point. [19:11:15] Hmm [19:11:19] 3VisualEditor: [Regression wmf-16] Including a template/comment/table/gallery/math node in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1032062 (10Ryasmeen) It also happened when I tried to add Page Title at the beginning of this page in test2 https://test2.wikipedi... [19:11:26] werdna: It's used in init init and Beta Features, I thought? [19:11:54] No he's right [19:11:57] It's totally unused now [19:12:02] Whoops. [19:12:05] Yeah... [19:12:09] Don't know what happened there [19:13:09] any idea why the VE Edit tab wouldn't appear? [19:13:22] is there something that removes it for certain namespaces or so? [19:13:38] Yes that too [19:13:42] eh [19:13:47] it is used all right [19:13:52] grep for VisualEditorSupportedSkins, without the wg [19:13:53] (03CR) 10Esanders: [C: 032] MediaWiki Theme: Use darker color for frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189947 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna) [19:14:03] it's using the new fancy config stuff [19:14:08] werdna: $.inArray( mw.config.get( 'skin' ), conf.skins ) !== -1 && [19:14:10] Oh yeah, I see [19:14:10] aha [19:14:30] Damn modern technology :P [19:14:30] that's a problem, if you now can't grep for config variable names to find where they're used [19:14:42] You can, you just have to remove wg from it [19:14:43] you can, if you remember to drop the wg [19:14:54] yeah, but that's still a problem [19:15:03] i keep forgetting to, personally, but we'll all re-learn at some point ;) [19:15:04] IMO [19:15:22] yeah, but it's not about re-learning, it's about being accessible and useful for someone new to the project who doesn't know that [19:15:25] anyway, I'll look at it tomorrow [19:15:30] gotta go for a walk with the gf now :) [19:16:00] werdna: Tell legoktm. :-) [19:16:58] werdna: https://www.mediawiki.org/w/index.php?title=Manual%3AWg_variable&diff=1123407&oldid=693249 [19:17:06] (03PS1) 10Mooeypoo: Display image uploader and artist correctly in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190031 (https://phabricator.wikimedia.org/T88835) [19:19:05] It's used in init, innit (got pinged by betafeatures) [19:20:48] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Up/down keys in table move left/right instead - https://phabricator.wikimedia.org/T67589#1032086 (10Etonkovidova) The up/down keys move the highlight(focus) to the cell in the above/below row. When a cell is clicked in(a focus is on the content) - o... [19:22:08] 3VisualEditor: Media Settings "Uploaded by..." not consistently accurate - https://phabricator.wikimedia.org/T88835#1032090 (10Tgr) Artist is the author, Credit is the source. Changing them to reasonable names is T71914. Both are parsed fromm templates (almost all extmetadata fields are) and as a result can c... [19:24:20] (03CR) 10Jforrester: [C: 031] Display image uploader and artist correctly in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190031 (https://phabricator.wikimedia.org/T88835) (owner: 10Mooeypoo) [19:24:55] 3VisualEditor: Page bump when editing a section in VE - https://phabricator.wikimedia.org/T88613#1032102 (10Aklapper) Which browser(s) was this tested with? Such info is generally welcome for VE bugs :) [19:31:15] 3VisualEditor: Page bump when editing a section in VE - https://phabricator.wikimedia.org/T88613#1032142 (10Aklapper) Ah yeah, confirming with Firefox 35. Duplicate of T55217 and/or T52206? Also see T87556. [19:32:04] (03CR) 10Trevor Parscal: [C: 04-1] "I swear we used this somewhere, but I can't find it in OOjs UI, VE, VEMW, or any MW extensions I know to be using OOjs UI." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189499 (owner: 10Bartosz Dziewoński) [19:32:33] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: When editing a section, don't wait for loading to be complete before scrolling to the section - https://phabricator.wikimedia.org/T55217#587355 (10Aklapper) Should this be closed in favor of T52206? Also see T87556. [19:32:48] (03CR) 10Trevor Parscal: [C: 032] MediaWiki Theme: Rename active-* variables to pressed-* [oojs/ui] - 10https://gerrit.wikimedia.org/r/189940 (owner: 10Prtksxna) [19:33:15] 3VisualEditor-MediaWiki, VisualEditor: VisualEditor: When editing a section, don't wait for loading to be complete before scrolling to the section - https://phabricator.wikimedia.org/T55217#1032151 (10Aklapper) [19:34:02] (03Merged) 10jenkins-bot: MediaWiki Theme: Rename active-* variables to pressed-* [oojs/ui] - 10https://gerrit.wikimedia.org/r/189940 (owner: 10Prtksxna) [19:34:53] 3VisualEditor, VisualEditor-Performance, Parsoid: Thoughts on element IDs, sections, incremental parsing and fast section editing - https://phabricator.wikimedia.org/T87556#1032158 (10Aklapper) [19:34:55] (03CR) 10Bartosz Dziewoński: "It is used in ComboBoxWidget, but I'm killing that usage in https://gerrit.wikimedia.org/r/#/c/189609/." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189499 (owner: 10Bartosz Dziewoński) [19:38:10] (03CR) 10Trevor Parscal: [C: 04-1] "We need to not auto-scroll when the highlight is a response to hovering, only when it's a response to keyboard input. Otherwise the mouse " [oojs/ui] - 10https://gerrit.wikimedia.org/r/189989 (owner: 10Bartosz Dziewoński) [19:39:10] edsanders: CR on https://gerrit.wikimedia.org/r/#/c/188741/ would be nice to close the Q3 blocker ;-) [19:39:20] RoanKattouw: it's a bit silly that we wait for the init event to start the profiler when we're the ones that start ve [19:40:07] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Deletion across a header caused it to remain without WS, leading Parsoid to output "====" - https://phabricator.wikimedia.org/T52100#1032180 (10Aklapper) [19:40:33] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Copying and pasting results in new blank section heading: "== ==" - https://phabricator.wikimedia.org/T57769#640860 (10Aklapper) [19:40:38] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Cutting (removing) last section on the page leaves blank section heading == == - https://phabricator.wikimedia.org/T61647#601596 (10Aklapper) [19:42:12] (03CR) 10Trevor Parscal: [C: 032] Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [19:43:49] (03CR) 10Trevor Parscal: [C: 032] MenuSelectWidget: Don't clobber other events when unbinding [oojs/ui] - 10https://gerrit.wikimedia.org/r/189950 (owner: 10Bartosz Dziewoński) [19:43:49] 3VisualEditor: Page bump when editing a section in VE - https://phabricator.wikimedia.org/T88613#1032214 (10awight) Oops! Linux, FF 34.0.5 [19:43:59] ori: Yeah that's true, we don't need to do that [19:45:05] (03Merged) 10jenkins-bot: MenuSelectWidget: Don't clobber other events when unbinding [oojs/ui] - 10https://gerrit.wikimedia.org/r/189950 (owner: 10Bartosz Dziewoński) [19:52:47] 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1032280 (10Jdforrester-WMF) [19:52:50] 3OOjs-UI: RadioSelectWidget is not accessible - https://phabricator.wikimedia.org/T88082#1032278 (10Jdforrester-WMF) 5Open>3Resolved [19:57:29] 3VisualEditor: Long Help text (e.g. in Russian) creates linebreak between "question mark" Icon and text - https://phabricator.wikimedia.org/T89112#1032310 (10Aklapper) p:5Triage>3Volunteer? [19:58:30] TrevorParscal, MatmaRex: is there an easy way to add "rel=nofollow" to a buttonwidget? [19:59:58] cscott: not built-in, apparently. but you can just do widget.$element.attr( 'rel', 'nofollow' ) in JS or $widget->setAttributes( array( 'rel' => 'nofollow' ) ) [20:00:25] …in PHP [20:00:38] i think $widget->button->setAttributes(), maybe. [20:00:45] ? [20:00:54] oh right, it has to be on the [20:00:55] right [20:10:21] 3VisualEditor, Parsoid, Parsoid-Nowiki: VisualEditor: Adding nowiki tags in unrelated edit - https://phabricator.wikimedia.org/T70511#1032353 (10RobLa-WMF) [20:11:13] (03CR) 10Fomafix: [C: 04-1] Convert .css to .less (033 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [20:16:20] (03CR) 10Esanders: [C: 032] Support specifying reference contents with data-mw.body.id [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188741 (https://phabricator.wikimedia.org/T88650) (owner: 10Catrope) [20:18:12] (03Merged) 10jenkins-bot: Support specifying reference contents with data-mw.body.id [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/188741 (https://phabricator.wikimedia.org/T88650) (owner: 10Catrope) [20:19:34] 3VisualEditor, MediaWiki-extensions-Graph: Graph editing in Visual Editor - https://phabricator.wikimedia.org/T89287#1032390 (10Yurik) 3NEW [20:20:47] 3VisualEditor, MediaWiki-extensions-Graph, Possible-Tech-Projects: Graph editing in Visual Editor - https://phabricator.wikimedia.org/T89287#1032398 (10Yurik) [20:23:32] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - https://phabricator.wikimedia.org/T70537#1032413 (10Eloquence) Needs investigation of criticality. [20:25:45] (03CR) 10Paladox: Convert .css to .less (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [20:25:52] 3VisualEditor, VisualEditor-DataModel: class="wikitable wikitable" corrupted to class="wikitable" - https://phabricator.wikimedia.org/T88148#1032418 (10MZMcBride) What's with the ``s? I'm less concerned about the extra wikitable class going away. [20:27:20] 3VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki: Log Parsoid server-side save performance - https://phabricator.wikimedia.org/T66171#1032427 (10ssastry) WIP here https://gerrit.wikimedia.org/r/#/c/186219/ [20:28:08] 3VisualEditor, VisualEditor-Performance, VisualEditor-DataModel: Reduce VisualEditor's memory usage - https://phabricator.wikimedia.org/T55825#1032434 (10Aklapper) >>! In T55825#558826, @brion wrote: > Feel free to move this to 'general' and we'll hang some mobile-specific bugs off it that are more directly acti... [20:28:23] 3VisualEditor, VisualEditor-Performance, VisualEditor-DataModel: Reduce VisualEditor's memory usage - https://phabricator.wikimedia.org/T55825#1032438 (10Jdforrester-WMF) [20:32:28] 3VisualEditor, VisualEditor-DataModel: class="wikitable wikitable" corrupted to class="wikitable" - https://phabricator.wikimedia.org/T88148#1032453 (10cscott) @MZMcBride the are required if you want the contents of the table cell to be `-`. Note that there are existing cells with of the same... [20:32:50] (03CR) 10Bartosz Dziewoński: "Hold on, I accidentally removed some code related to scrolling, I think. Also, would love TheDJ's review before we do this (although it de" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [20:34:18] 3VisualEditor, VisualEditor-EditingTools: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1032465 (10Jdforrester-WMF) a:5Jdforrester-WMF>3TrevorParscal [20:36:47] (03PS3) 10Bartosz Dziewoński: Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) [20:37:08] (03CR) 10Bartosz Dziewoński: "Bah, true. Let's drop that part then." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189989 (owner: 10Bartosz Dziewoński) [20:37:35] 3VisualEditor, VisualEditor-DataModel, VisualEditor-MediaWiki-References: Support data-mw.body.id for reference contents - https://phabricator.wikimedia.org/T88650#1032474 (10Aklapper) [20:40:15] (03PS3) 10Bartosz Dziewoński: Make better use of 'scrollIntoViewOnSelect' in OptionWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189989 [20:40:17] 3VisualEditor, VisualEditor-Performance: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#1032486 (10Aklapper) [20:40:32] James_F|Away: I should have figured :p [20:44:31] 3VisualEditor, VisualEditor-MediaWiki-Links: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1032500 (10Aklapper) [20:47:13] 3VisualEditor-MediaWiki, VisualEditor: Create a guided tour for VisualEditor using Getting Started tooltips - https://phabricator.wikimedia.org/T89074#1032511 (10Eloquence) We are not accepting this as a critical issue right now, but we will consider having a pre-release stage of development that focuses on UX p... [20:48:31] 3VisualEditor, VisualEditor-EditingTools: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1032516 (10Aklapper) Could you attach a screenshot of that area (plus browser info)? And what is the need to distinguish them if they are all disabled anyway? :) [20:53:14] 3MediaWiki-Vagrant, VisualEditor, MediaWiki-Configuration: Vagrant VE role localsettings conflicts with VisualEditor's user option defaults - https://phabricator.wikimedia.org/T88665#1032527 (10Legoktm) This is because we do: ``` } elseif ( is_array( $GLOBALS[$key] ) && is_array( $val ) ) { $GLOBALS[$key... [20:55:21] TrevorParscal: framed vs frameless button is something that is going to stay? or going to be unified? [20:58:43] 3VisualEditor, VisualEditor-EditingTools: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1032537 (10Elitre) No screenshot needed, https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#widgets-mediawiki-vector-ltr will do. If there's no need for me to dist... [21:01:56] 3VisualEditor, VisualEditor-CopyPaste: Ctrl+C copying of text with template removes text in FF - https://phabricator.wikimedia.org/T86921#1032539 (10Jdforrester-WMF) [21:06:02] (03PS1) 10Cscott: Better handle non-string parameters to ButtonWidget setHref/setTarget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190044 [21:06:04] (03PS1) 10Cscott: Add "nofollow" option to ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190045 [21:11:18] 3VisualEditor, VisualEditor-DataModel, VisualEditor-MediaWiki-References: Support data-mw.body.id for reference contents - https://phabricator.wikimedia.org/T88650#1032554 (10Jdforrester-WMF) 5Open>3Resolved [21:16:40] (03CR) 10Trevor Parscal: [C: 031] "Would love a sign off from TheDJ, but lgtm." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [21:18:32] (03CR) 10Trevor Parscal: [C: 032] Add "nofollow" option to ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190045 (owner: 10Cscott) [21:18:47] where are James_F|Away and RoanKattouw_away? [21:19:12] I just finished eating lunch [21:19:18] James just left to have lunch with his sister [21:19:30] 3MediaWiki-Page-editing: mw.toolbar.insertTags should be independent from mediawiki.toolbar module - https://phabricator.wikimedia.org/T88976#1032567 (10Aklapper) p:5Triage>3Normal [21:19:41] oh right, it's lunch time in SF [21:19:49] (03CR) 10Trevor Parscal: [C: 032] Better handle non-string parameters to ButtonWidget setHref/setTarget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190044 (owner: 10Cscott) [21:20:01] RoanKattouw, do we have a task for this onBeforeUnload abort handler? [21:20:12] 3Flow, VisualEditor, §Collaboration-Team-Sprint-Q-2015-02-25: Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1032572 (10DannyH) [21:20:15] ...maybe? [21:20:17] I don't know [21:20:32] I can explain to you what it's about though, if you like [21:20:58] I think the task was to log onBeforeUnload calls as abort actions against the Edit schema [21:21:04] is that it? [21:21:05] Yeah pretty much [21:21:06] (03Merged) 10jenkins-bot: Better handle non-string parameters to ButtonWidget setHref/setTarget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190044 (owner: 10Cscott) [21:21:12] (03Merged) 10jenkins-bot: Add "nofollow" option to ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190045 (owner: 10Cscott) [21:21:14] (03CR) 10Trevor Parscal: [C: 032] Make better use of 'scrollIntoViewOnSelect' in OptionWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189989 (owner: 10Bartosz Dziewoński) [21:21:21] It probably won't work straight up though, due to various issues [21:21:25] 3VisualEditor, VisualEditor-EditingTools: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1032591 (10matmarex) The button is T88038. [21:21:31] Like, right now there's a 2-second aggregation delay IIRC [21:21:38] what issues do you have in mind? [21:22:07] (03CR) 10Trevor Parscal: [C: 032] MenuSelectWidget: Remove dead code [oojs/ui] - 10https://gerrit.wikimedia.org/r/189644 (owner: 10Bartosz Dziewoński) [21:22:31] (03Merged) 10jenkins-bot: Make better use of 'scrollIntoViewOnSelect' in OptionWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189989 (owner: 10Bartosz Dziewoński) [21:22:53] 3VisualEditor, VisualEditor-EditingTools: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1032605 (10John_Broughton) The relevant documentation about messages (i18n system) appears to include * https://www.mediawiki.org/wiki/Help:System_mes... [21:23:32] (03PS13) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [21:24:22] 3VisualEditor, Beta-Cluster: Search on the Beta Cluster is broken, and thus VE no longer shows suggestion list for Templates upon typing into Add template selector - https://phabricator.wikimedia.org/T89007#1032610 (10Chad) >>! In T89007#1029535, @Ryasmeen wrote: > I can now see the template suggestions now.Ther... [21:25:41] (03CR) 10Trevor Parscal: [C: 04-1] "Isn't this adding a frame to a frameless button? There's gotta be a better way to do this." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189949 (https://phabricator.wikimedia.org/T87692) (owner: 10Prtksxna) [21:26:26] (03CR) 10Trevor Parscal: [C: 032] MenuSelectWidget: Codify current behavior of Tab closing the menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/189608 (owner: 10Bartosz Dziewoński) [21:27:48] (03Merged) 10jenkins-bot: MenuSelectWidget: Codify current behavior of Tab closing the menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/189608 (owner: 10Bartosz Dziewoński) [21:27:54] 3VisualEditor, VisualEditor-EditingTools: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1032630 (10Krenair) They are definitely in the i18n system, for example https://meta.wikimedia.org/wiki/MediaWiki:Visualeditor-dialog-meta-categories-d... [21:28:49] 3VisualEditor, VisualEditor-MediaWiki-Templates: Template followed by comment: No comment icon shown; text inserted between template and comment, no way to insert text after comment - https://phabricator.wikimedia.org/T89101#1032635 (10Aklapper) p:5Triage>3Volunteer? [21:29:45] (03CR) 10Trevor Parscal: [C: 032] DropdownWidget, ComboBoxWidget: Make keyboard-accessible [oojs/ui] - 10https://gerrit.wikimedia.org/r/189609 (https://phabricator.wikimedia.org/T87705) (owner: 10Bartosz Dziewoński) [21:30:06] (03PS2) 10Trevor Parscal: MediaWiki Theme: Rename @highlight to @active [oojs/ui] - 10https://gerrit.wikimedia.org/r/189941 (owner: 10Prtksxna) [21:30:16] okay now I'm completely baffled [21:30:23] (03CR) 10Trevor Parscal: [C: 032] MediaWiki Theme: Rename @highlight to @active [oojs/ui] - 10https://gerrit.wikimedia.org/r/189941 (owner: 10Prtksxna) [21:30:43] I tried adding the skin to $wgVisualEditorSupportedSkins [21:30:46] and it doesn't change [21:30:50] (03CR) 10Trevor Parscal: [C: 032] MediaWiki Theme: Fix background color for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189946 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna) [21:30:54] I even tried putting die( var_dump( $wgVisualEditorSupportedSkins ) ); in VisualEditor.php [21:31:01] Oh [21:31:03] is this related to the "extension registry"? [21:31:06] Yes [21:31:09] (03Merged) 10jenkins-bot: DropdownWidget, ComboBoxWidget: Make keyboard-accessible [oojs/ui] - 10https://gerrit.wikimedia.org/r/189609 (https://phabricator.wikimedia.org/T87705) (owner: 10Bartosz Dziewoński) [21:31:11] :@ [21:31:12] (03Merged) 10jenkins-bot: MenuSelectWidget: Remove dead code [oojs/ui] - 10https://gerrit.wikimedia.org/r/189644 (owner: 10Bartosz Dziewoński) [21:31:13] Edit extension.json [21:31:21] Welcome to the brave new world of JSON-based config [21:31:41] And the associated transition confusion [21:31:44] * RoanKattouw blames legoktm [21:31:51] werdna: got the requires in correct order? [21:32:16] 3UI-Standardization, OOjs-UI: OOjs UI: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1032653 (10cscott) My suggested answers (based on what would be helpful for https://gerrit.wikimedia.org/r/187141): * Resurrect via an API like `querySelector`. That is, I should be able to... [21:32:28] It is really really infuriating when people make non-obvious changes like this and I have to spend hours figuring out how the "new system" works [21:32:47] werdna: are you using vagrant? it uses extension.json now instead of PHP entry points [21:32:48] see: grepping for $wgX no longer works because we need a "config object" [21:32:53] legoktm: yes, I got that now. [21:33:11] ok, I'm behind on sending out my email to wikitech-l about that, I'll make sure to get to that today [21:33:22] (03Merged) 10jenkins-bot: MediaWiki Theme: Rename @highlight to @active [oojs/ui] - 10https://gerrit.wikimedia.org/r/189941 (owner: 10Prtksxna) [21:33:24] (03Merged) 10jenkins-bot: MediaWiki Theme: Fix background color for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189946 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna) [21:33:26] (03CR) 10jenkins-bot: [V: 04-1] MediaWiki Theme: Use darker color for frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189947 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna) [21:33:27] I don't read wikitech-l, and I shouldn't have to [21:33:42] so then how do you expect to find out when stuff changes? [21:33:58] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check when the changed word in the only item in the paragraph causes endless insertions in Firefox - https://phabricator.wikimedia.org/T74929#1032662 (10Aklapper) [21:34:11] I expect the changes to be obvious and as noninvasive as possible. [21:34:11] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check when the changed word in the only item in the paragraph causes endless insertions in Firefox - https://phabricator.wikimedia.org/T74929#775586 (10Aklapper) [21:34:27] and justified by technical need. [21:34:28] so "just don't make breaking changes"? [21:34:41] think really hard before you do [21:34:59] 3Flow, VisualEditor, §Collaboration-Team-Sprint-Q-2015-02-25: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1032665 (10DannyH) [21:35:02] and especially don't make people maintain extension configuration in two places at once [21:35:13] this was discussed in an RfC for about 3 months, and then up for CR for another month, so I think we did the "think really hard" part [21:35:40] Don't Repeat Yourself is a cardinal rule of good software design. If I want to change a default config option, I should not need to edit extension.json *and* the extension setup file. [21:35:59] it's a temporary measure while we convert all extensions over. [21:36:17] Right, so the time when everything is *most* confusing is the time when the system is new and nobody knows how it works. [21:36:18] Excellent. [21:37:07] there are docs at https://www.mediawiki.org/wiki/Manual:Extension_registration, if something isn't explained there, please let me know and I can improve it [21:37:55] Anyway, I don't know how I would have managed this particular change. I'm just infuriated that so many things change underneath me and I spend ages trying to figure out what's going on. [21:38:09] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check when the changed word in the only item in the paragraph causes endless insertions in Firefox - https://phabricator.wikimedia.org/T74929#1032681 (10Aklapper) Cannot reproduce on https://cs.wikipedia.org/wiki/Wi... [21:38:24] I think the most useful thing to do would be to find a way to signpost in the config-related code that HEY, CONFIG MIGHT COME FROM SOMEWHERE ELSE [21:38:28] or in extension setup files [21:38:53] I mean, if an extension uses extension.json, you should have compatibility code, not a second method of setting it up [21:39:07] like what we did with ExtensionName.i18n.php [21:39:15] eh [21:39:25] reading wikitech helps in not getting the rug pulled from under oneself [21:39:26] there it was obvious that something had changed [21:39:37] wikitech is very low signal to noise. I don't think it's a good use of my time. [21:40:07] your choice, but it's *the* place where technical innovations get announced [21:40:11] (in fairness, I should say it *was* very low signal to noise when I last read it four years ago) [21:40:23] werdna: so, I asked whether we should do that on wikitech-l (https://lists.wikimedia.org/pipermail/wikitech-l/2015-January/080008.html) and the two responses I got were that we should just maintain both in parallel. [21:40:37] if it was up to me, all wmf software engineers would be forcefully subscribed to it… [21:41:07] Let's be thankful it isn't. [21:41:22] I don't think reading XX emails per day is a good way to make people aware of large breaking changes. [21:41:55] I'm sure we could have another low-traffic mailing list for major architectural changes [21:42:26] we already have several [21:42:35] (private, alas) [21:42:40] i'd murder them all if it was up to me, too [21:43:43] I'm not on any of them, which is odd because I've been writing MediaWiki code for nearly ten years. [21:44:20] yeah, they're private and you took a break from wmf, i think? [21:44:28] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check tool causing repeated automatic deletion in Chrome - https://phabricator.wikimedia.org/T65462#1032696 (10Aklapper) Could not reproduce the problem on https://cs.wikipedia.org/wiki/Wikipedista:Malyacko/Sandbox?... [21:44:32] only mor ereasons why they shouldn't be private, or preferably exist at all [21:44:42] (i'm talking about engineering list mostly) [21:44:51] I'm on that list [21:45:01] I didn't see anything about extension registration there. [21:45:11] I think there might have been something for the i18n migration [21:45:46] sounds like a good thing to me, means it was discussed publicly on wikitech [21:45:48] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check tool causing repeated automatic deletion in Chrome - https://phabricator.wikimedia.org/T65462#1032702 (10Aklapper) [21:46:40] (03PS4) 10Trevor Parscal: MediaWiki Theme: Use darker color for frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189947 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna) [21:46:48] (03CR) 10Trevor Parscal: [C: 032] MediaWiki Theme: Use darker color for frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189947 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna) [21:47:00] well, very good provided you believe that reading 20 emails per day is something that's a good use of time. [21:47:24] relatedly, is "VisualEditorSupportedSkins" a configuration setting (sysadmins should be setting in LocalSettings.php) or a registration setting that other skins should be adding to? [21:47:28] (I checked, that's how many there are) [21:47:54] 3VisualEditor, VisualEditor-EditingTools: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1032704 (10Quiddity) [21:48:01] (03Merged) 10jenkins-bot: MediaWiki Theme: Use darker color for frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189947 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna) [21:48:04] i don't read the shit threads, and you shouldn't either [21:48:32] (03CR) 10Trevor Parscal: [C: 032] Display image uploader and artist correctly in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190031 (https://phabricator.wikimedia.org/T88835) (owner: 10Mooeypoo) [21:48:36] (by the way, i go through probably a few hundred emails per day) [21:49:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] MediaWiki Theme: Use white icons for disabled buttons (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna) [21:50:19] (03Merged) 10jenkins-bot: Display image uploader and artist correctly in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190031 (https://phabricator.wikimedia.org/T88835) (owner: 10Mooeypoo) [21:50:21] That's very admirable, but I don't think it is the most efficient way to make sure engineers are aware that, say, editing a configuration option in ExtensionName.php, which has been the way to change a setting default for 11 years, suddenly no longer works. [21:50:33] edsanders: https://gerrit.wikimedia.org/r/#/c/190022/ [21:50:43] um, this doesn't work yet - maybe mark it [WIP] ? [21:51:09] what's broken? [21:51:11] hmm. it worked after hard refresh [21:51:12] sorry [21:51:14] false alarm [21:51:46] werdna: i don't understand why you believe wmf engineers should be catered to specifically [21:52:03] it's your duty to have an idea of what's going on in the mediawiki world [21:52:04] I don't know where you got that from my argument [21:52:12] wikitech is the channel where these updates get sent [21:52:16] edsanders: this still seems to be odd to me [21:52:24] if you dislike wikitech, that's your problem, sorry [21:53:03] that's what people who care read, and where people who care send their announcements [21:53:15] That's not a very constructive way to deal with a process that's failing. [21:53:45] I don't think we'll get any value out of continuing this discussion, though. [21:53:48] TrevorParscal, how so? [21:54:44] edsanders: i guess it's a combination of the way it looks and the way it behaves, maybe even just that they are different from previous situation [21:55:04] but, also I think the mouse-only approach is a regression, no? [21:55:07] it's a significant change [21:55:25] yeah, and a lot of my gut reaction is to that alone [21:55:51] 3VisualEditor, VisualEditor-EditingTools: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1032743 (10Quiddity) [21:58:02] Krenair: i love new code with a comment above it saying: "// TODO: This is probably the wrong way to do this." lol! [21:58:14] https://gerrit.wikimedia.org/r/#/c/149117/8/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js,unified [22:06:07] 3VisualEditor, VisualEditor-ContentEditable: Visual Editor: editing links for images will silently fail if it is performed from link inspector - https://phabricator.wikimedia.org/T74769#1032769 (10Etonkovidova) Closing as non-reproducible anymore. [22:06:19] 3VisualEditor, VisualEditor-ContentEditable: Visual Editor: editing links for images will silently fail if it is performed from link inspector - https://phabricator.wikimedia.org/T74769#1032770 (10Etonkovidova) 5Open>3Resolved [22:07:19] TrevorParscal, if you make it keyboard accessible via up/down it becomes far too easy to do accidentally [22:07:28] which is the cause of all the confusion [22:08:10] as a future fix we can logically detect them moving into a slug and highlight the button [22:08:14] then they can press enter [22:10:08] 3VisualEditor, VisualEditor-EditingTools: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#1032780 (10Quiddity) I've added a screenshot to the description, and clarified the other separate bug. I agree that the disabled editing tools are probably too low in con... [22:12:12] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Inserted images overlap preformatted text box - https://phabricator.wikimedia.org/T74411#1032782 (10Etonkovidova) p:5Triage>3Volunteer? [22:16:22] 3VisualEditor: VisualEditor: Can't delete text... which is actually not there - https://phabricator.wikimedia.org/T75216#1032805 (10Etonkovidova) Could not reproduce. Sometime when a user session has been open for long and/or editing has taken long time(many edits) - UI becomes somewhat irresponsive. However, n... [22:16:45] 3VisualEditor: VisualEditor: Can't delete text... which is actually not there - https://phabricator.wikimedia.org/T75216#1032807 (10Etonkovidova) 5Open>3Resolved [22:17:32] (03PS1) 10Kmenger: Added documentation to ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190107 [22:18:38] (03CR) 10jenkins-bot: [V: 04-1] Added documentation to ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190107 (owner: 10Kmenger) [22:26:20] (03PS2) 10Kmenger: Added documentation to ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190107 [22:27:19] 3VisualEditor, VisualEditor-EditingTools: copying formatted text from one VE edit session to another removes spaced before linked text - https://phabricator.wikimedia.org/T73968#1032850 (10Etonkovidova) Not reproducible anymore. [22:27:28] 3VisualEditor, VisualEditor-EditingTools: copying formatted text from one VE edit session to another removes spaced before linked text - https://phabricator.wikimedia.org/T73968#1032852 (10Etonkovidova) 5Open>3Resolved [22:35:33] 3VisualEditor, VisualEditor-MediaWiki-Media: Media Settings "Uploaded by..." not consistently accurate - https://phabricator.wikimedia.org/T88835#1032871 (10Jdforrester-WMF) 5Open>3Resolved [22:35:44] 3VisualEditor, VisualEditor-EditingTools: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1032876 (10Jdforrester-WMF) p:5Low>3High [22:35:57] 3VisualEditor, VisualEditor-EditingTools: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#564744 (10Jdforrester-WMF) p:5High>3Low [22:37:04] 3UI-Standardization, OOjs-UI: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1032878 (10Jdforrester-WMF) 5Open>3Resolved [22:38:43] 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1032882 (10Jdforrester-WMF) [22:38:46] 3OOjs-UI: DropdownWidget and ComboBoxWidget dropdown arrow is not keyboard accessible - https://phabricator.wikimedia.org/T87705#1032880 (10Jdforrester-WMF) 5Open>3Resolved [22:39:42] (03PS4) 10Bartosz Dziewoński: Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) [22:39:50] (03CR) 10Bartosz Dziewoński: "(Rebased.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [22:40:15] 3UI-Standardization, OOjs-UI: Disabled button color not right - https://phabricator.wikimedia.org/T88483#1032887 (10Jdforrester-WMF) 5Open>3Resolved [22:40:34] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Breaks left/right arrow keys in LookupElement/ComboBoxWidgets' textboxes. Needs more though." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [22:45:31] (03CR) 10Jforrester: Added documentation to ButtonWidget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190107 (owner: 10Kmenger) [22:47:22] (03PS5) 10Jforrester: Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [22:50:29] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check tool causing repeated automatic deletion in Chrome - https://phabricator.wikimedia.org/T65462#1032903 (10Jdforrester-WMF) [22:51:38] 3VisualEditor, VisualEditor-MediaWiki-Templates: Insert/Template inspector should put focus on input text_field when invoked but no longer does - https://phabricator.wikimedia.org/T85484#1032905 (10Jdforrester-WMF) [22:51:39] 3VisualEditor, VisualEditor-EditingTools: Various dialog windows gain and then lose the focus after opening - https://phabricator.wikimedia.org/T88411#1032904 (10Jdforrester-WMF) [22:52:16] 3VisualEditor, VisualEditor-MediaWiki-References, Citoid: Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-selected - https://phabricator.wikimedia.org/T88152#1032908 (10Jdforrester-WMF) [22:52:47] 3VisualEditor, MediaWiki-extensions-Graph, Possible-Tech-Projects: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1032909 (10Jdforrester-WMF) p:5Triage>3Normal [22:56:16] 3VisualEditor, VisualEditor-ContentEditable: Unable to add a video as media - https://phabricator.wikimedia.org/T88925#1032916 (10Jdforrester-WMF) It works for me on enwiki under wmf16 and mediawikiwiki under wmf17. Search bug? [22:57:14] 3VisualEditor, VisualEditor-ContentEditable: Unable to add a video as media - https://phabricator.wikimedia.org/T88925#1032921 (10Jdforrester-WMF) 5Open>3stalled It works for me on enwiki under wmf16 and mediawikiwiki under wmf17. Search bug? [23:00:16] (03PS3) 10Trevor Parscal: ButtonWidget: Add documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190107 (owner: 10Kmenger) [23:00:34] (03CR) 10Trevor Parscal: [C: 032] ButtonWidget: Add documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190107 (owner: 10Kmenger) [23:01:47] (03Merged) 10jenkins-bot: ButtonWidget: Add documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190107 (owner: 10Kmenger) [23:03:12] (03CR) 10Paladox: "@Fomafix and @Mattflaschen please review and merge." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [23:04:05] 3UI-Standardization, OOjs-UI: OOjs UI: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1032941 (10Krinkle) @cscott: That sounds pretty good. Two points though: * Using HTML ids is messy and unnecessary. Our widgets have pretty good classes (we can add an additional one if need... [23:04:53] 3VisualEditor, VisualEditor-ContentEditable: Pressing Backspace/Delete or creating a heading causes the page to abruptly scroll up on Internet Explorer 11 - https://phabricator.wikimedia.org/T73119#1032943 (10TTO) [23:10:15] 3UI-Standardization, OOjs-UI: OOjs UI: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1032946 (10cscott) @Krinkel: I still need to be able to name a specific object created on the PHP side. IDs are the right thing for that. For example, in https://gerrit.wikimedia.org/r/1871... [23:11:07] (03PS1) 10Jforrester: Tag v0.7.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/190110 [23:17:58] (03PS1) 10Mooeypoo: Defend against empty file pages in media dialog search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190111 [23:18:57] (03CR) 10TheDJ: "i can look at this on friday." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [23:23:07] 3VisualEditor: Media Settings: search is not terminated- input box keeps displaying waiting animation - https://phabricator.wikimedia.org/T89303#1032970 (10Etonkovidova) 3NEW a:3Mooeypoo [23:23:33] Krinkle: hey, jsduck doesn't seem to be inheriting @protected when you use @inheritdoc on a subclass's overridden method [23:23:39] (03PS2) 10Mooeypoo: Defend against empty file pages in media dialog search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190111 (https://phabricator.wikimedia.org/T89303) [23:23:39] TrevorParscal: https://gerrit.wikimedia.org/r/190110 [23:23:49] TrevorParscal: What is @protected? [23:24:01] event handlers, for instance [23:24:26] Only public properties are inherited, private properties aren't inherited anyway. @protected doesn't exist. [23:24:50] I know they aren't /actually/ protected, but the problem we have is the documentation doesn't let the consumer of OOjs UI know the difference between "use this" and "don't use this unless you are a subclass" and "don't use this outside this class" so we want to start using @protected and @private [23:25:14] https://github.com/senchalabs/jsduck/wiki/@protected [23:25:19] @protected does exist [23:25:40] obviously I don't care about @private inheriting, you are right about that [23:25:47] TrevorParscal: Sure, but jsduck doesn't dictate our coding conventions. We map ours to theirs. [23:26:14] well, I think JSDuck has a bug [23:26:15] TrevorParscal: Let me check inherits [23:26:17] Yeah [23:26:18] cool thanks man [23:28:08] TrevorParscal: this is on a method, right? Not a class. [23:28:14] yes [23:29:03] TrevorParscal: Which version of jsduck? Is this from local or from Jenkins? [23:29:25] The v5.0.0 code on github appears to do try and copy protected visibility if present [23:29:38] v5.3.4 [23:29:45] brb, standup - Krinkle: thank you for helping me! Kirsten is working on code docs now, that's why this has come up [23:31:26] TrevorParscal: Can you link me to code where you ran into this on gerrit? I'll file a bug. [23:40:33] RoanKattouw, so what action.abort.type should we be logging for this? [23:40:40] James_F, ^ [23:42:54] Krenair: Depends on what the state of the editor is when the unload occurs [23:43:33] Krinkle: there will be in a minute [23:43:43] kirstenMA is whipping one up [23:44:11] TrevorParscal: Ah, she's running jsduck locally? [23:45:50] preinit vs... ? [23:49:31] Krenair: preinit, nochange, abandon, abandonMidsave are the relevant ones [23:50:18] (03PS1) 10Kmenger: ButtonElement: add protected to protected eventhandling methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190114 [23:50:49] (03PS2) 10Trevor Parscal: ButtonElement: add protected to protected eventhandling methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190114 (owner: 10Kmenger) [23:51:03] (03PS3) 10Trevor Parscal: ButtonElement: add protected to event handlers [oojs/ui] - 10https://gerrit.wikimedia.org/r/190114 (owner: 10Kmenger) [23:52:12] Krinkle: https://gerrit.wikimedia.org/r/#/c/190114 [23:52:13] (03PS14) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [23:52:22] she was running jsduck using the "jsduck" command [23:52:40] RoanKattouw: https://gerrit.wikimedia.org/r/190110 [23:55:01] (03CR) 10jenkins-bot: [V: 04-1] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [23:57:38] 3VisualEditor, VisualEditor-DataModel: VisualEditor: [Regression] VE corruption issue(?) moving pre-existing categories to the middle of the page - https://phabricator.wikimedia.org/T74048#1033012 (10Jdforrester-WMF) [23:57:44] 3VisualEditor-MediaWiki, VisualEditor: Random removal of categories when using Safari - https://phabricator.wikimedia.org/T76998#1033014 (10Jdforrester-WMF) [23:58:07] Krinkle: so yeah, locally [23:58:16] Roan setup her environment, looks standard to me [23:58:18] TrevorParscal: k, repro. [23:58:23] filing now [23:58:26] cool [23:58:30] thank you very much! [23:58:56] 3VisualEditor, Parsoid, VisualEditor-Tables: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#1033016 (10Jdforrester-WMF) [23:59:33] (03PS1) 10Catrope: Make @example work [oojs/ui] - 10https://gerrit.wikimedia.org/r/190116 [23:59:42] Krinkle: ---^^