[00:00:10] (03PS2) 10Jforrester: docs: Make @example documentation tag work [oojs/ui] - 10https://gerrit.wikimedia.org/r/190116 (owner: 10Catrope) [00:00:36] (03CR) 10Trevor Parscal: [C: 032] ButtonElement: add protected to event handlers [oojs/ui] - 10https://gerrit.wikimedia.org/r/190114 (owner: 10Kmenger) [00:01:11] TrevorParscal: Actually, private methods are inherited. [00:01:26] :D [00:02:04] (03CR) 10Trevor Parscal: [C: 032] Tag v0.7.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/190110 (owner: 10Jforrester) [00:03:17] (03Merged) 10jenkins-bot: Tag v0.7.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/190110 (owner: 10Jforrester) [00:03:44] (03CR) 10Catrope: [C: 032] ButtonElement: add protected to event handlers [oojs/ui] - 10https://gerrit.wikimedia.org/r/190114 (owner: 10Kmenger) [00:03:46] https://github.com/senchalabs/jsduck/issues/603 [00:03:50] Thanks Timo. [00:04:59] (03Merged) 10jenkins-bot: ButtonElement: add protected to event handlers [oojs/ui] - 10https://gerrit.wikimedia.org/r/190114 (owner: 10Kmenger) [00:09:45] (03PS1) 10Jforrester: Update OOjs UI to v0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190121 [00:10:43] TrevorParscal: Please +2 https://gerrit.wikimedia.org/r/#/c/190121/ and https://gerrit.wikimedia.org/r/#/c/190119/ [00:13:16] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190121 (owner: 10Jforrester) [00:13:19] RoanKattouw: ping when you have am in [00:13:38] ori: Doing SWAT now, sorry [00:13:39] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190121 (owner: 10Jforrester) [00:13:44] np [00:13:44] Will ping you once don [00:13:48] RoanKattouw: want me to help? [00:13:54] the current code for handling these events does not allow VPT to see whether we already logged saveAttempt/init [00:17:00] Krenair: Doesn't ve.init.mw.trackSubscriber.js keep track of which events have already been fired or something? [00:17:12] I forget how all this stuff works currently, I feel like I should remember since I wrote all of it [00:17:20] :-) [00:17:29] yeah, internally [00:19:06] So maybe if VPT just did an mw.track() without that knowledge, trackSubscriber can add that data? [00:19:23] Or a ve.track() or I forget what's being used there [00:19:32] Pretty sure it's ve.track() [00:20:15] but we don't know the action type at this point [00:20:49] We know it's an abort, right? [00:21:00] I guess we could log a mwedit.abort with some custom data that causes it to go and look this up :/ [00:21:03] We just don't know the abort type [00:21:21] Well maybe just fire an abort with no type [00:21:33] And trackSubscriber can take that to mean "I should look it up and populate the type field" [00:22:42] 3MediaWiki-Page-editing: mw.toolbar.insertTags should be independent from mediawiki.toolbar module - https://phabricator.wikimedia.org/T88976#1033069 (10He7d3r) [00:26:06] 3VisualEditor, OOjs-UI: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1033094 (10Jdforrester-WMF) p:5Triage>3Unbreak! [00:26:46] 3MediaWiki-Page-editing: mw.toolbar.insertTags should be independent from mediawiki.toolbar module - https://phabricator.wikimedia.org/T88976#1033101 (10He7d3r) [00:27:06] 3OOjs-UI: ToggleSwitchWidget requires to be TabIndexedElement - https://phabricator.wikimedia.org/T88080#1033103 (10Jdforrester-WMF) [00:28:12] RoanKattouw, something like this? https://gist.github.com/Krenair/45240fd145cde986ca2b [00:28:19] 3OOjs-UI: DropdownWidget and ComboBoxWidget dropdown arrow is not keyboard accessible - https://phabricator.wikimedia.org/T87705#1033107 (10Jdforrester-WMF) [00:28:20] 3UI-Standardization, OOjs-UI: Disabled button color not right - https://phabricator.wikimedia.org/T88483#1033106 (10Jdforrester-WMF) [00:28:21] 3OOjs-UI: ToggleSwitchWidget requires to be TabIndexedElement - https://phabricator.wikimedia.org/T88080#1003660 (10Jdforrester-WMF) [00:28:22] 3VisualEditor, OOjs-UI: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1033105 (10Jdforrester-WMF) [00:28:25] 3OOjs-UI: DraggableGroupElement should handle non-OptionWidget items - https://phabricator.wikimedia.org/T88053#1033110 (10Jdforrester-WMF) [00:28:26] 3OOjs-UI: RadioSelectWidget is not accessible - https://phabricator.wikimedia.org/T88082#1033109 (10Jdforrester-WMF) [00:28:28] 3UI-Standardization, OOjs-UI: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1033108 (10Jdforrester-WMF) [00:28:29] 3OOjs-UI: Remove weird display measurement logic in ListToolGroup - https://phabricator.wikimedia.org/T89073#1033111 (10Jdforrester-WMF) [00:28:30] 3VisualEditor, VisualEditor-Performance, OOjs-UI: OO.ui.Element.static.reconsiderScrollbars reflow is too expensive - https://phabricator.wikimedia.org/T89082#1033112 (10Jdforrester-WMF) [00:28:31] 3OOjs-UI: TextInputWidget (indicator)‎ has 'required' state, so should use required attribute on the native element - https://phabricator.wikimedia.org/T87707#1033115 (10Jdforrester-WMF) [00:28:33] 3VisualEditor, OOjs-UI: [Regression] Opening an image or template resizes the CE making the highlight transition appear wiggly - https://phabricator.wikimedia.org/T88867#1033113 (10Jdforrester-WMF) [00:28:34] 3OOjs-UI: ToggleSwitchWidget requires the checkbox role - https://phabricator.wikimedia.org/T88079#1033116 (10Jdforrester-WMF) [00:28:35] 3OOjs-UI: TextInputWidget (autosize)‎ contains two textareas - https://phabricator.wikimedia.org/T88977#1033114 (10Jdforrester-WMF) [00:29:45] 3VisualEditor: [Regression wmf-17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1033117 (10Etonkovidova) 3NEW [00:33:20] 3MediaWiki-Page-editing: Create a clean interface to plug in (other/any) editor frontends - https://phabricator.wikimedia.org/T28918#1033135 (10He7d3r) [00:36:25] (03PS2) 10Jforrester: Update OOjs UI to v0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190121 [00:37:16] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190121 (owner: 10Jforrester) [00:38:13] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190121 (owner: 10Jforrester) [00:42:09] (03PS3) 10Jforrester: Update OOjs UI to v0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190121 [00:44:43] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190121 (owner: 10Jforrester) [00:45:32] 3MediaWiki-Page-editing: mw.toolbar.insertTags should be independent from mediawiki.toolbar module - https://phabricator.wikimedia.org/T88976#1033170 (10Krinkle) What is your use case for this? [00:45:33] (03PS3) 10Jforrester: [DO NOT MERGE] Stop waiting for removed loading promise to finish [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal) [00:45:42] (03CR) 10Jforrester: "PS3 is a rebase. Pull-through coming." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal) [00:49:35] (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE] Stop waiting for removed loading promise to finish [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal) [00:49:46] (03Merged) 10jenkins-bot: Update OOjs UI to v0.7.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190121 (owner: 10Jforrester) [00:52:07] (03PS4) 10Jforrester: Update VE core submodule to master (9240a51) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal) [00:53:05] RoanKattouw: Can we grab a +2 from you on https://gerrit.wikimedia.org/r/#/c/189593/ please? [00:53:22] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (9240a51) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal) [00:53:38] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (9240a51) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal) [00:54:10] 3VisualEditor-MediaWiki, VisualEditor: Three editing labels - https://phabricator.wikimedia.org/T72230#1033182 (10Aklapper) [00:54:43] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1033185 (10Aklapper) p:5Triage>3Volunteer? [00:54:48] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (9240a51) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal) [00:55:06] (03Merged) 10jenkins-bot: Update VE core submodule to master (9240a51) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal) [00:55:21] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#739831 (10Aklapper) My question "Which problem do you try to solve?" is still unanswered though... [00:56:23] RoanKattouw: https://phabricator.wikimedia.org/T87161 – declined? [00:58:15] 3VisualEditor: VisualEditor: Give the user a chance to understand if he made a mistake and to fix it - https://phabricator.wikimedia.org/T73422#1033192 (10Aklapper) >>! In T73422#754038, @Elitre wrote: > I'll file a bug against Parsoid, thanks. Any ticket ID handy? [01:00:54] 3VisualEditor: Forward delete key does crazy things - https://phabricator.wikimedia.org/T74690#1033208 (10Aklapper) 5Open>3declined a:3Aklapper Cannot reproduce the problem either with the given link (on Firefox 35) plus the initial report is too vague ("other bad stuff") plus this report misses any browse... [01:02:53] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Shift-Delete keyboard "cut" shortcut doesn't work - https://phabricator.wikimedia.org/T35080#1033213 (10Aklapper) >>! In T35080#363626, @John_Broughton wrote: > As pointed out, shift-delete on the Mac does NOT behave the same as in Windows - shift-delete... [01:04:13] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Shift-Delete keyboard "cut" shortcut doesn't work - https://phabricator.wikimedia.org/T35080#1033219 (10Jdforrester-WMF) p:5Normal>3Volunteer? [01:06:04] 3VisualEditor: VisualEditor: trouble with Template:Hlist - https://phabricator.wikimedia.org/T55340#1033224 (10Aklapper) p:5Triage>3Low [01:11:31] (03PS1) 10Kmenger: Widget: add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190136 [01:12:53] 3MediaWiki-Page-editing: mw.toolbar.insertTags should be independent from mediawiki.toolbar module - https://phabricator.wikimedia.org/T88976#1033247 (10Aklapper) >>! In T88976#1033170, @Krinkle wrote: > What is your use case for this? See {T88922} [01:24:24] 3MediaWiki-Page-editing: mw.toolbar.insertTags should be independent from mediawiki.toolbar module - https://phabricator.wikimedia.org/T88976#1033313 (10Krinkle) >>! In T88976#1033247, @Aklapper wrote: >>>! In T88976#1033170, @Krinkle wrote: >> What is your use case for this? > > See {T88922} That seems unrela... [01:26:20] RoanKattouw, around? [01:33:01] 3VisualEditor: Forward delete key does crazy things - https://phabricator.wikimedia.org/T74690#1033337 (10awight) I think this was a duplicate of T88612. Thanks for taking a look! [01:37:46] Krenair: Sorry I was supposed to look at your pastebin thing [01:37:52] Talking to Ori, will look in a minute [01:37:54] ok [01:41:09] 3VisualEditor: text duplicated when following an image - https://phabricator.wikimedia.org/T55643#1033357 (10Aklapper) 5Open>3declined a:3Aklapper Cannot reproduce the problem either with the given links and Firefox 35... Assuming that this has magically fixed itself. Hence closing this ticket as DECLINED... [01:42:06] @docs [01:44:02] Krenair: Yeah that pastebin looks good t me [01:44:19] I'm very sorry it took me over an hour to take a one-minute look at it :( [01:44:45] Krenair: As for mechanism, I believe that would be 'navigate' in this case [01:45:26] Krenair: I'm also not totally confident the beforeunload handler is bound at the right time for these purposes, it might be bound too late [01:46:39] actually I think this code will be called in a load of cases we don't want to log as aborts [01:47:15] or... no, maybe not in VE [01:47:32] to do this in WE though... :( [01:47:58] speaking of WE I still need a way to deal with DoEditSectionLink [01:48:35] Oh yeah that's the other thing [01:48:47] The user might receive a warning and decide not to unload [01:49:05] So perhaps you should do this in a handler for onUnload rather than onBeforeUnload [01:49:31] and implement all of the logic to bind/unbind onBeforeUnload again :( [01:50:57] Well yeah :( [01:51:02] But at least in VE that's already wrapped in a function [01:51:11] I wrote code for this once, to bind an unload handler [01:51:25] I think I ended up throwing it away, but it wasn't too hard to repurpose the bindHandlers() stuff fo rtha [01:58:07] RoanKattouw: https://github.com/AndrewBelt/WiTeX [02:03:36] (03PS1) 10Divec: Preserve nodes better during IME tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190141 [02:03:58] (03PS7) 10Divec: Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 [02:05:38] (03CR) 10jenkins-bot: [V: 04-1] Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [02:12:59] (03PS8) 10Divec: Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 [02:14:00] RoanKattouw, this is terrible. [02:14:48] :( [02:21:17] RoanKattouw, https://gist.github.com/Krenair/45240fd145cde986ca2b ? untested [02:23:33] Oh, ugh, right [02:23:37] This is because my thing never got merged [02:23:45] * RoanKattouw glares in the general direction of Krinkle and edsanders|away [02:24:02] https://gerrit.wikimedia.org/r/#/c/177107/ [02:24:13] Oh it looks like I should glare at myself instead [02:24:27] Timo said it broke bfcache for him, and I said it worked for me last I checked but I'd investigate, and I never did [02:24:47] :) [02:25:34] :) [02:29:00] (03PS9) 10Divec: Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 [02:42:40] (03PS2) 10Divec: Preserve nodes better during IME tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190141 [02:42:55] (03PS10) 10Divec: Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 [02:43:25] (03CR) 10Divec: "Rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [02:43:36] (03CR) 10Divec: "Rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190141 (owner: 10Divec) [02:45:44] (03CR) 10Divec: "Ignore my earlier claim that this fixes the cursor getting stuck at an inline alien. I was being stupid." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187889 (owner: 10Divec) [02:51:53] (03PS1) 10Alex Monk: Send abort event on unload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190144 [02:52:04] RoanKattouw, ^ [02:53:59] RoanKattouw, I don't know if there will be issues there involving multiple sessions of VE and lastEventWithAction... [02:55:44] Oh, hah, good point [02:56:00] Yeah that's probably an issue ;S [02:56:09] lastEventWithAction isn't a foolproof system [02:56:32] I guess you could theoretically derive that information by checking what occurred more recently than the most recent abort event, but ugh [02:56:52] Everything about this is horrible. [02:58:48] Yeah :( [02:59:01] Instrumentation code tends to be that way in my experience [02:59:07] I mean maybe I'm just bad at writing it [03:00:17] Krenair: So yeah I think we probably need a version of lastEventWithAction that's cleared on abort. Or maybe just make it be cleared on abort if nothing is trying to use it across aborts (I can't imagine what would) [03:10:03] (03CR) 10Catrope: [C: 04-1] "This probably isn't the end of this story, since there's a 2-second aggregation delay in WikimediaEvents somewhere that will probably prev" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190144 (owner: 10Alex Monk) [03:13:32] RoanKattouw, sigh, yes, that would misclassify [03:13:52] pass in edited: this.edited and have trackSubscriber sort it out? [03:15:48] Hrmph, right, trackSubscriber doesn't have access to that state [03:16:23] well, ve.init.target.edited :) [03:16:32] hah [03:16:39] Does it access ve.init.target.* anywhere yet? [03:16:55] Meh only in one place and for a static property [03:17:00] integration: ve.init.target && ve.init.target.constructor.static.integrationType || 'page', [03:17:28] Well alternatively you could do something like { type: this.edited ? 'unknown-edited' : 'unknown' } or whatever and have trackSubscriber map that [03:29:53] (03PS2) 10Alex Monk: Send abort event on unload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190144 [03:31:30] (03CR) 10jenkins-bot: [V: 04-1] Send abort event on unload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190144 (owner: 10Alex Monk) [03:38:46] RoanKattouw, you say there's some sort of delay here... [03:39:47] In WMEvents I think [03:39:48] Lemme see [03:41:27] I have eventlogging-devserver running in terminal and it doesn't instantly show the events I make in VE [03:44:52] Krenair: extensions/WikimediaEvents/modules/ext.wikimediaEvents.ve.js line 28: [03:44:57] timer = setTimeout( dispatch, 2000 ); [03:45:14] Oh wait that's the TimingData thing [03:46:05] Hmm, ext.eventLogging.subscriber.js is what actually tracks this data and it doesn't look to have a delay [03:46:16] Krenair: Are abort events from you just randomly closing the tab making it into eventlogging-devserver? [03:47:37] If they do, you're probably fine [03:47:45] Because I was wrong about the delay thing, that was in a different code path [03:48:37] No, but I just opened it back up and did not get an init event either. [03:49:16] it doesn't log anything at the moment [04:06:12] 3VisualEditor, Flow, §Collaboration-Team, WikiEditor: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1033515 (10GOIII) >>! In T78346#1026966, @Quiddity wrote: > ... > Separately, I know there is some amount of local customization of the WikiEditor Toolbar butt... [04:27:09] 3VisualEditor, VisualEditor-DataModel: class="wikitable wikitable" corrupted to class="wikitable" - https://phabricator.wikimedia.org/T88148#1033521 (10MZMcBride) Yeah, I saw that there were other similar cells. I misread `-` as ``. My bad. From quick testing, it seems `!-` cre... [04:43:09] (03PS3) 10Alex Monk: Send abort event on unload [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190144 [05:07:51] Oh, there is a pretty big problem with focusable node on the production right now. [05:08:05] I'm not sure if it's still a problem in master as well. [05:12:14] Krenair: Feel like reviewing an async bugfix? [05:12:53] 3VisualEditor, VisualEditor-Performance, Parsoid: Thoughts on element IDs, sections, incremental parsing and fast section editing - https://phabricator.wikimedia.org/T87556#1033532 (10tstarling) Tim by email: > Why is it necessary to ensure that template output is balanced? If a template starts out as a single D... [05:57:58] 3RESTBase, VisualEditor-Performance, VisualEditor, Parsoid: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1033544 (10GWicke) [07:15:18] (03CR) 10Fomafix: Convert .css to .less (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [07:15:31] (03CR) 10Krinkle: "Confirmed that it works as expected, when e.g. adding this to Widget.js class description:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190116 (owner: 10Catrope) [07:15:50] (03CR) 10Fomafix: [C: 04-1] "Does not work. Still syntax errors." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [07:20:33] (03CR) 10Krinkle: [C: 04-1] "Should oojs-ui-mediawiki.js be loaded? It overloads OO.ui.theme, while stylesheet remains set to apex." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190116 (owner: 10Catrope) [07:30:16] (03PS14) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [07:31:06] (03CR) 10Paladox: "@Fomafix and @Mattflaschen please review and merge." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [07:31:49] (03CR) 10Paladox: "I removed 0 0 no-repeat should that be added to background position and background repeat." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [08:18:39] (03CR) 10Fomafix: [C: 04-1] "Still does not work." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [08:22:50] 3MediaWiki-Page-editing: mw.toolbar.insertTags should be independent from mediawiki.toolbar module - https://phabricator.wikimedia.org/T88976#1033652 (10Schnark) The various gadgets to insert special characters are the use case for this. Currently they have to declare a dependency on `mediawiki.toolbar`, which w... [08:25:05] (03CR) 10Paladox: "Hi ok what should i do to fix the problem." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [08:46:18] (03CR) 10Fomafix: "Even your first version does not work. Start again from master." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [08:46:44] 3TemplateData: Can't edit "aliases" with TemplateData editor tool - https://phabricator.wikimedia.org/T88141#1033669 (10Nnvu) Yes, now it works. Thanks for help. [08:58:38] (03CR) 10Paladox: "Hi what do you mean start again I did start again from master for this patch and where is the problem and how can I fix it. And this works" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [09:10:51] (03CR) 10Fomafix: "Sorry. You made to much changes at once. Start again from master and make only small changes, or else it will not be reviewable." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [09:13:57] (03CR) 10Paladox: "Do you mean the amount of patches I made. Should it like patch 1 or 2 not 14." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [09:14:41] (03CR) 10Paladox: "And what do you mean by small changes" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [09:34:27] (03PS1) 10Gerrit Patch Uploader: Rework color definition in CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 [09:34:30] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 (owner: 10Gerrit Patch Uploader) [10:08:06] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1033724 (10Horcrux92) The problem is that we cannot turn the label "Edit" in "Vidual edit" without changing the same label for who has got VE off. For u... [10:15:13] (03PS2) 10Gerrit Patch Uploader: Rework color definition in CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 [10:15:16] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 (owner: 10Gerrit Patch Uploader) [10:34:01] (03CR) 10Bartosz Dziewoński: "I think it's fine to prioritize accessibility over prettiness in this case, since most users (who do not use keyboard to navigate) probabl" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189949 (https://phabricator.wikimedia.org/T87692) (owner: 10Prtksxna) [10:50:13] 3VisualEditor: language screenshots fail with a JavaScript error - https://phabricator.wikimedia.org/T89139#1033796 (10Amire80) 5Open>3Invalid a:3Amire80 PEBKAC, forgot to run Parsoid. [11:00:21] (03PS7) 10Amire80: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 [11:01:30] (03CR) 10Amire80: "Reverted to my latest version. We'll go with proper namespace for the Screenshot module for now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [11:10:47] 3VisualEditor, MediaWiki-extensions-InputBox: Allow option to default editor - https://phabricator.wikimedia.org/T89341#1033823 (10Ainali) 3NEW [11:11:02] 3VisualEditor, MediaWiki-extensions-InputBox: Allow option to chose editor - https://phabricator.wikimedia.org/T89341#1033830 (10Ainali) [11:16:25] (03CR) 10Esanders: [C: 04-1] "Doesn't work with indicators. We should an indicated frameless to the demo." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189949 (https://phabricator.wikimedia.org/T87692) (owner: 10Prtksxna) [11:24:38] (03PS1) 10Zfilipin: WIP a test commit, please ignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190185 [11:25:08] (03Abandoned) 10Zfilipin: WIP a test commit, please ignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190185 (owner: 10Zfilipin) [11:48:18] 3VisualEditor, MediaWiki-extensions-Graph, Possible-Tech-Projects: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1033908 (10Qgil) Are there mentors available for this GSoC / Outreachy round? [12:17:41] 3VisualEditor, VisualEditor-Performance, VisualEditor-DataModel: Reduce VisualEditor's memory usage - https://phabricator.wikimedia.org/T55825#1033975 (10Aklapper) More specific criteria and numbers are welcome / required here. Also, should the "Epic" tag be added here? [12:23:16] 3VisualEditor, VisualEditor-CopyPaste: Copy cuts out templates - https://phabricator.wikimedia.org/T89099#1033985 (10Aklapper) Thanks for taking the time to report this! The steps are not entirely clear to me (and the Sandbox content seem to have changed in the meantime?). An ordered list of steps, plus a sect... [12:24:04] 3VisualEditor, VisualEditor-CopyPaste: Ctrl+C (copying) cuts out (removes) templates instead of copying - https://phabricator.wikimedia.org/T89099#1033994 (10Aklapper) [12:28:42] 3TemplateData: Can't edit "aliases" with TemplateData editor tool - https://phabricator.wikimedia.org/T88141#1033997 (10Aklapper) 5stalled>3Resolved Closing as resolved per last comment [12:30:37] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1034001 (10Aklapper) >>! In T72230#1033724, @Horcrux92 wrote: > The problem is that we cannot turn the label "Edit" in "Vidual edit" without changing the... [12:41:09] (03CR) 10Zfilipin: [C: 04-1] "Looks good to me in general. We have tested the code at Amir's machine. The only thing that is left is a minor thing in the Gemfile, see i" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [12:41:50] 3VisualEditor, MediaWiki-extensions-InputBox: Option to choose editor (traditional vs VisualEditor) in InputBox extension - https://phabricator.wikimedia.org/T89341#1034018 (10Aklapper) p:5Triage>3Low [12:44:31] Krinkle|detached, I think I went to bed before you sent your message [12:51:23] 3VisualEditor, VisualEditor-CopyPaste: Ctrl+C (copying) cuts out (removes) templates instead of copying - https://phabricator.wikimedia.org/T89099#1034020 (10Sunpriat) Recently there was some fix? Today I can not repeat it, but I could do it for a few days before writing this report. The problem disappeared, top... [13:25:49] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1034061 (10Horcrux92) Because "edit" is ambiguous. Why the basic "edit" should be the VE-mode? We discussed it a lot (as can you see in the page that I... [13:48:40] (03PS3) 10Esanders: Ignore block slugs in ve.ce.getHash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189969 [13:48:42] (03PS3) 10Esanders: Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 [13:48:44] (03PS2) 10Esanders: Use node type constants in ve.ce.getDomHash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189967 [13:51:46] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Image repositioning is not working correctly when the image is inside a bock slug - https://phabricator.wikimedia.org/T65781#1034097 (10Esanders) 5Open>3Invalid a:3Esanders We don't slug after lists any more, and it looks like in this case you were in... [13:53:29] 3VisualEditor-MediaWiki, VisualEditor: Template inside
  • creates an extra bullet with inline slug - https://phabricator.wikimedia.org/T60335#1034104 (10Esanders) The template below it is a block template (which it probably shouldn't be) which requires a slug before it. [13:56:22] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Incorrect highlight while trying to add reference in a slug - https://phabricator.wikimedia.org/T72065#1034113 (10Esanders) Breaks even worse at the moment. [13:57:45] 3VisualEditor: Adding an image into a slug makes typing impossible anywhere in the document - https://phabricator.wikimedia.org/T88009#1034115 (10Esanders) Inserting into an empty slug is broken in other ways now. [13:59:20] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Incorrect highlight while trying to add reference in a slug - https://phabricator.wikimedia.org/T72065#1034118 (10Esanders) 5Open>3Resolved a:3Esanders That bug is T89192, this particular issue was fixed with staging. [13:59:44] 3VisualEditor: Adding an image into a slug makes typing impossible anywhere in the document - https://phabricator.wikimedia.org/T88009#1034123 (10Esanders) 5Open>3Resolved a:3Esanders See T89192, this particular issue was probably fixed. [14:03:09] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Cannot go to the next line of an article after inserting a special character in a block slug and "TypeError: Inserted data is trying to close the root node (at index 0)" appears - https://phabricator.wikimedia.org/T67873#1034153 (10Esanders) 5Open>3Re... [14:05:26] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Changing the format of a block slug between a list and a block template breaks badly - https://phabricator.wikimedia.org/T64475#1034160 (10Esanders) 5Open>3Resolved Appears to be fixed [14:08:26] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor multilingual input / i18n issues (tracking) - https://phabricator.wikimedia.org/T35077#1034169 (10Esanders) [14:08:27] 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1034170 (10Esanders) [14:08:30] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: IME input into an empty slug causes characters to overwrite one another - https://phabricator.wikimedia.org/T47240#1034166 (10Esanders) 5Open>3Resolved a:3Esanders I suspect this is no longer broken. Please re-test. [14:10:30] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Add a block slug at the end of pages - https://phabricator.wikimedia.org/T52353#1034172 (10Esanders) 5Open>3declined a:3Esanders We don't insert slugs if the user can create a new line by pressing enter. If the document ends in a template or other... [14:12:08] 3VisualEditor, VisualEditor-MediaWiki-References, VisualEditor-CopyPaste: Copy/pasting deletes references, can't save - https://phabricator.wikimedia.org/T89146#1034175 (10Aklapper) [14:18:11] 3VisualEditor: Make slugs keyboard accessible again - https://phabricator.wikimedia.org/T89352#1034190 (10Esanders) 3NEW [14:19:05] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Cursor navigation loops in block slugs at the start/end of the document - https://phabricator.wikimedia.org/T64066#1034197 (10Esanders) [14:23:36] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Down-arrow in a slug with a
    in it puts cursor inside slug rather than moving down or right in Firefox - https://phabricator.wikimedia.org/T58068#1034205 (10Esanders) 5Open>3Resolved a:3Esanders There are no slugs after lists anymore either. [14:29:18] hmm, where in the VE code does it hide the existing text? [14:29:28] It isn't happening on my skin [14:30:46] probably VPT [14:31:06] (modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js) [14:31:25] couldn't find it there [14:31:32] going to set an attribute modify breakpoint and see [14:34:55] Is it not that mw.hook( 'wikipage.content' ).fire( $editableContent.empty().append( $content ) ); line in ViewPageTarget#replacePageContent? [14:38:03] smartypants :) [14:38:07] let me check that but it sounds right [14:38:18] I was looking for .hide, .fadeOut or .slideUp [14:59:47] (03CR) 10Amire80: [BrowserTest] Move screenshot taking functionality to a gem (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [15:00:21] (03CR) 10Amire80: "(Waiting for merging https://github.com/amire80/screenshot/pulls .)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [15:00:44] werdna, I saw your wikitech-l thread earlier [15:00:51] It sounds like a breaking change in Vagrant to me [15:00:53] (03CR) 10Amire80: "More precisely, https://github.com/amire80/screenshot/pull/2 ." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [15:01:02] Krenair: well, kind of both I guess [15:02:14] also, lol, petr [15:02:55] well core can now pull config from another place [15:03:04] yeah, I hate JSON too [15:03:15] if you configure it to use the new extension loading mechanism [15:03:18] not really a breaking change [15:31:36] 3VisualEditor, VisualEditor-DataModel: class="wikitable wikitable" corrupted to class="wikitable" - https://phabricator.wikimedia.org/T88148#1034321 (10cscott) I agree that serializing as "| -" might be more 'natural'. It's possible we could hack that into Parsoid as a special case. That's a separate bug/featu... [15:54:14] (03PS4) 10Esanders: Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) [16:10:36] 3VisualEditor: Make slugs keyboard accessible again - https://phabricator.wikimedia.org/T89352#1034408 (10Aklapper) [16:18:14] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1034429 (10Aklapper) >>! In T72230#1034061, @Horcrux92 wrote: > Because "edit" is ambiguous. If that's ambiguous then why request three labels, instead... [16:20:24] 3VisualEditor, VisualEditor-CopyPaste: Ctrl+C (copying) cuts out (removes) templates instead of copying - https://phabricator.wikimedia.org/T89099#1034431 (10Aklapper) 5Open>3declined a:3Aklapper Great it works for you now! Closing this ticket, but [[ https://www.mediawiki.org/wiki/Bug_management/Bug_repor... [16:32:28] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1034458 (10Horcrux92) >>! In T72230#1034429, @Aklapper wrote: >>>! In T72230#1034061, @Horcrux92 wrote: >> Because "edit" is ambiguous. > > If that's am... [16:38:11] 3MediaWiki-jQuery-Tablesorter, WikiEditor: Table dialog doesn't show example for sortable table - https://phabricator.wikimedia.org/T33604#1034527 (10Aklapper) [16:38:13] 3MediaWiki-ResourceLoader, MediaWiki-jQuery-Tablesorter: Load tablesorter only if there's a sortable table in the page - https://phabricator.wikimedia.org/T30946#1034531 (10Aklapper) [16:59:40] (03CR) 10Esanders: [C: 032] Defend against empty file pages in media dialog search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190111 (https://phabricator.wikimedia.org/T89303) (owner: 10Mooeypoo) [17:01:25] (03Merged) 10jenkins-bot: Defend against empty file pages in media dialog search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190111 (https://phabricator.wikimedia.org/T89303) (owner: 10Mooeypoo) [17:22:10] on mediawiki.org, I clicked "edit" in visual editor and it's just sitting there hanging. Anyone want to jump into a hangout and debug or do you all know about this already? [17:22:26] the little loader bar on top right is going back and forth [17:23:15] I'll leave the window open for when James_F|Away or others can look at it ^ [17:23:38] It loads for me... [17:24:01] what page milimetric? [17:24:11] Krenair: I reloaded the page and it worked fine [17:24:16] http://www.mediawiki.org/w/index.php?title=Analytics/Onboarding&veaction=edit&vesection=19 [17:24:31] but the page that's hanging is still hanging [17:24:39] and i didn't do anything special, just clicked edit [17:24:51] so I figured maybe it was a hard to reproduce thing and someone would want to jump in and look [17:27:40] what page is hanging? [17:28:20] ah, you duplicated the tab and refreshed and it was fine [17:28:20] is there anything in the JS console? [17:30:39] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70810437 [17:38:03] 3UI-Standardization, OOjs-UI: OOjs UI: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1034671 (10cscott) I've got a rough implementation for this. I'll push it to gerrit by the end of the day. [17:48:05] 3VisualEditor: Make slugs keyboard accessible again - https://phabricator.wikimedia.org/T89352#1034682 (10Esanders) [17:48:06] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Up and down cursor keys don't let you cursor from a focusable node into a slug - https://phabricator.wikimedia.org/T64542#1034681 (10Esanders) [17:49:34] (03PS1) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 [17:50:45] (03Abandoned) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [17:54:05] (03PS1) 10Cmcmahon: [BrowserTest] Cite message no longer in iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190242 [17:56:50] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190242 (owner: 10Cmcmahon) [18:00:17] (03Merged) 10jenkins-bot: [BrowserTest] Cite message no longer in iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190242 (owner: 10Cmcmahon) [18:20:18] (03PS3) 10Catrope: docs: Make @example documentation tag work [oojs/ui] - 10https://gerrit.wikimedia.org/r/190116 [18:20:18] (03CR) 10Catrope: "Re mediawiki theme: good catch, removed in PS3." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190116 (owner: 10Catrope) [18:20:18] (03PS1) 10Cmcmahon: [BrowserTest] Update transclusion test for better locator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190247 [18:26:58] (03PS2) 10Cmcmahon: [BrowserTest] Update transclusion test for better locator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190247 [18:28:01] (03PS3) 10Cmcmahon: [BrowserTest] Update transclusion test for better locator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190247 [18:29:53] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Node action icon (e.g. for template) appearing in wrong location - https://phabricator.wikimedia.org/T53548#1034742 (10Elitre) 5Resolved>3Open I think this is still happening. See for example https://fr.wikipedia.org/w/index.php?title=Parox%C3%A9tine... [18:30:07] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Update transclusion test for better locator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190247 (owner: 10Cmcmahon) [18:35:02] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190247 (owner: 10Cmcmahon) [18:36:40] (03Merged) 10jenkins-bot: [BrowserTest] Update transclusion test for better locator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190247 (owner: 10Cmcmahon) [18:47:06] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1034779 (10Aklapper) Sorry but I'm getting lost here (plus I don't know implementation details as I'm not a developer). Could you please edit the task... [18:50:27] (03CR) 10Paladox: "I have found the problem and I am testing to make sure it works properly before uploading the patch in the link above which should be some" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [18:50:54] 3VisualEditor: [Regression wmf-16] Including a template/comment/table/gallery/math node in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1034786 (10Ryasmeen) a:3Esanders [18:52:53] (03PS1) 10Cmcmahon: [BrowserTest] Remove unused steps and locators [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190255 [18:54:05] (03PS2) 10Cmcmahon: [BrowserTest] Remove unused steps and locators [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190255 [18:55:06] (03CR) 10Cmcmahon: [C: 032] "maintenance, no change to function" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190255 (owner: 10Cmcmahon) [18:55:32] RoanKattouw and everyone, congratulations on removing the last iframe [18:56:05] haha thanks [18:56:13] chrismcmahon: Which iframe did we remove exactly? [18:56:14] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1034799 (10Horcrux92) >>! In T72230#1034779, @Aklapper wrote: > Sorry but I'm getting lost here (plus I don't know implementation details as I'm not a de... [18:56:24] I ask because I thought we'd already gotten rid of all of them [18:56:29] That's why we removed support for it in ooui [18:56:46] (03Merged) 10jenkins-bot: [BrowserTest] Remove unused steps and locators [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190255 (owner: 10Cmcmahon) [18:56:49] (03CR) 10Catrope: [C: 032] Preserve nodes better during IME tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190141 (owner: 10Divec) [18:58:40] (03Merged) 10jenkins-bot: Preserve nodes better during IME tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190141 (owner: 10Divec) [19:00:05] (03CR) 10Catrope: [C: 032] Use node type constants in ve.ce.getDomHash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189967 (owner: 10Esanders) [19:01:49] (03Merged) 10jenkins-bot: Use node type constants in ve.ce.getDomHash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189967 (owner: 10Esanders) [19:02:15] (03CR) 10Fomafix: [C: 04-1] Convert .css to .less (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 (owner: 10Paladox) [19:04:35] RoanKattouw: all of the iframes! OOjs UI 0.7.0 announcement [19:08:13] man i cannot reproduce this old wikieditor+IE8 bug [19:08:29] (by disabling the IE 8 workarounds) [19:12:34] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1034842 (10Aklapper) It was difficult to understand because I assumed you want to potentially display three labels. Initial description wasn't entirely c... [19:13:47] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1034844 (10Aklapper) [19:17:53] 3VisualEditor, Quality-Assurance: Update language_screenshot test - https://phabricator.wikimedia.org/T89370#1034845 (10Amire80) [19:21:16] (03CR) 10Catrope: [C: 032] Ignore block slugs in ve.ce.getHash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189969 (owner: 10Esanders) [19:21:35] (03PS5) 10Catrope: Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) (owner: 10Esanders) [19:22:36] (03PS2) 10Brion VIBBER: Skip an old IE 8 bug workaround in WikiEditor on IE 11/Spartan [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189162 (https://phabricator.wikimedia.org/T88875) [19:23:14] 3WikiEditor: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1034869 (10brion) Patchset updated, and one of the other version checks also clarified to explicitly test for '10 and below' rather than 'msie and also some other random bits'. [19:24:26] (03Merged) 10jenkins-bot: Ignore block slugs in ve.ce.getHash [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189969 (owner: 10Esanders) [19:47:42] 3VisualEditor-MediaWiki, VisualEditor: Provide three editing labels ("Edit", "Edit source" and "Edit beta") on it.wp - https://phabricator.wikimedia.org/T72230#1034950 (10Horcrux92) >>! In T72230#1034842, @Aklapper wrote: > It was difficult to understand because I assumed you want to potentially display three la... [19:58:00] 3VisualEditor: Odd result: Subst'd template, or converted to HTML, or ??? - https://phabricator.wikimedia.org/T89163#1034983 (10Etonkovidova) The page https://en.wikipedia.org/w/index.php?title=Lysergic_acid_diethylamide&diff=644418282&oldid=644415096 has three instances of //**Citation needed**// The first //... [19:58:42] 3VisualEditor: Odd result: Subst'd template, or converted to HTML, or ??? - https://phabricator.wikimedia.org/T89163#1034985 (10Etonkovidova) p:5Triage>3Normal [20:02:54] edsanders|away: So what is data-ve-no-generated-contents="true" all about? [20:04:03] edsanders|away: Would it be reasonable to only output that for copy-paste? [20:11:43] 3OOjs-UI: ButtonSelectWidget doesn't unhighlight when an item gets unselected - https://phabricator.wikimedia.org/T88232#1035017 (10Ryasmeen) Verified the fix in test2 and en.wiki [20:12:08] 3OOjs-UI: ButtonSelectWidget doesn't unhighlight when an item gets unselected - https://phabricator.wikimedia.org/T88232#1035018 (10Ryasmeen) [20:12:54] 3VisualEditor, OOjs-UI: BookletLayout dies on open - https://phabricator.wikimedia.org/T88471#1035021 (10Ryasmeen) [20:17:08] 3VisualEditor: [Regression pre-wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#1035026 (10Ryasmeen) Verified in test2 and production [20:17:28] 3VisualEditor: [Regression pre-wmf16] Cannot close citation dialog getting error:TypeError: Cannot read property '$element' of null - https://phabricator.wikimedia.org/T87787#1035027 (10Ryasmeen) [20:19:39] 3VisualEditor, VisualEditor-InterfaceLanguage, OOjs-UI: [Regression pre-wmf16] Media Settings dialog is broken - https://phabricator.wikimedia.org/T88503#1035028 (10Ryasmeen) Verified in test2 and en.wiki [20:19:56] 3VisualEditor, OOjs-UI, VisualEditor-InterfaceLanguage: [Regression pre-wmf16] Media Settings dialog is broken - https://phabricator.wikimedia.org/T88503#1035029 (10Ryasmeen) [20:20:51] 3VisualEditor: Find-and-replace dialog has ugly grey border on betalabs - https://phabricator.wikimedia.org/T87125#1035030 (10Ryasmeen) [20:21:56] 3VisualEditor, OOjs-UI, VisualEditor-MediaWiki: [Regression wmf16] Cannot open category popup widget - https://phabricator.wikimedia.org/T88736#1035040 (10Ryasmeen) [20:31:09] RoanKattouw, I wonder if DoEditSectionLink should pass around an array which both VE and WE could use [20:31:19] What & where is DoEditSectionLink? [20:31:35] hook in core [20:31:39] used by VE [20:31:50] I want to use it in WE to override section edit links to carry a session id [20:32:27] Skin::doEditSectionLink makes HTML and passes around a reference to the string through the hook [20:33:04] VisualEditorHooks::onDoEditSectionLink duplicates bits of code from there to make new HTML [20:34:36] 3VisualEditor: Options/Advanced settings/Display title no longer appears in diff view - https://phabricator.wikimedia.org/T89383#1035060 (10Cmcmahon) 3NEW [20:35:54] 3VisualEditor: Options/Advanced settings/Display title no longer appears in diff view - https://phabricator.wikimedia.org/T89383#1035073 (10Cmcmahon) [20:38:14] Krenair: Right, so you're proposing redesigning the hook interface as one that passes around an array instead of a string? [20:38:24] yes [20:38:41] Would that include like associative arrays of attributes or something? [20:38:56] * RoanKattouw wonders if it should be an array of OOUI\Elements or something [20:42:21] array( array( 'link' => '...&action=edit§ion=n', 'text' => 'edit' ) ) [20:43:14] array( array( 'link' => '...&action=edit§ion=n', 'text' => 'edit source' ), array( 'link' => '...&veaction=edit&vesection=1', 'text' => 'edit' ) ) [20:43:26] Oh, OK yeah [20:43:28] array( array( 'link' => '...&action=edit§ion=n&editingStatsId=hash', 'text' => 'edit source' ), array( 'link' => '...&veaction=edit&vesection=1', 'text' => 'edit' ) ) [20:43:30] (lunch) [20:43:30] etc. [20:43:32] ok [20:43:36] That seems sensible [20:43:46] But changing hook APIs in general is hairy :( [20:43:49] more sensible than raw html >_> [20:44:54] we wouldn't have to modify the existing hook exactly [20:45:15] Oh, you'll provide b/c? [20:45:26] ...how would you do that exactly? [20:45:33] well we'll set up the initial core edit section link in the array [20:45:36] run the hook [20:45:45] generate html based on the new array [20:45:52] then pass it into the old hook [20:45:58] Oooh haha right [20:46:00] Clever [20:47:08] (03CR) 10TheDJ: "OutlineSelectWidget: This is not present in the demo page ?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [20:47:11] (actually leaving now) [20:47:14] :) [20:48:27] (03CR) 10Bartosz Dziewoński: "OutlineSelectWidget is used in the "Outlined booklet dialog" in Dialogs demo." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [21:01:44] (03PS2) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 [21:02:55] (03CR) 10Paladox: "@Fomafix and @Mattflaschen please review and merge." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 (owner: 10Paladox) [21:07:42] (03CR) 10Fomafix: [C: 04-1] "untestet." (033 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 (owner: 10Paladox) [21:10:22] (03PS27) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [21:29:54] RoanKattouw: I forgot to follow up on my bug report from this morning [21:30:11] I clicked "Edit' and it just sat there grayed out with the top right loader thing sweeping [21:30:24] I just looked in my console and it said this: [21:30:25] http://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&mo…Cmediawiki.skinning.content.parsoid&skin=vector&version=20150212T164650Z&* Failed to load resource: the server responded with a status of 403 (HTTP method not allowed.) [21:31:09] milimetric: That's a server-side infrastructure issue it sounds like [21:31:13] I've seen that a few times [21:31:19] Maybe there's a bad Varnish server in the pool [21:31:29] ok, and nothing you need to look at in the client that should've handled it better? [21:31:35] (I still have it up) [21:31:58] We probably should handle loading failures better, yes [21:32:14] There may or may not be a task for that already [21:32:22] want me to file it in phab? [21:32:29] Yes please [21:32:32] k, np [21:34:08] (03PS28) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [21:34:38] 3VisualEditor: Clicking Edit results in HTTP 403 result - https://phabricator.wikimedia.org/T89395#1035257 (10Milimetric) 3NEW [21:35:36] 3VisualEditor: Clicking Edit results in HTTP 403 result - https://phabricator.wikimedia.org/T89395#1035270 (10Milimetric) Oh, the article I was looking at: http://www.mediawiki.org/w/index.php?title=Analytics/Onboarding&veaction=edit&vesection=19 [21:36:12] 3VisualEditor, VisualEditor-Initialisation: ResourceLoader failures should be handled better - https://phabricator.wikimedia.org/T89395#1035273 (10Catrope) [21:36:58] 3VisualEditor, VisualEditor-Initialisation: ResourceLoader failures should be handled better - https://phabricator.wikimedia.org/T89395#1035257 (10Catrope) The 403 isn't VE's fault (probably a bad Varnish server or something else weird happening in our infrastructure), but VE should handle this kind of failure m... [21:37:46] (03CR) 10Paladox: "Hi I have fixed the chrome bug in here or chrome has fixed it. The image now correctly zoom in." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 (owner: 10Paladox) [21:39:36] 3VisualEditor, VisualEditor-MediaWiki-Media: Increase the spacing between Media Title and description as much as it is between the description and meta-data - https://phabricator.wikimedia.org/T87451#1035305 (10Ryasmeen) [21:41:31] 3OOjs-UI: Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget - https://phabricator.wikimedia.org/T89399#1035314 (10matmarex) 3NEW [21:41:48] (03CR) 10Bartosz Dziewoński: "I filed T89399 about replacing this." [oojs/ui] - 10https://gerrit.wikimedia.org/r/176681 (https://phabricator.wikimedia.org/T64174) (owner: 10Prtksxna) [21:42:28] 3VisualEditor, VisualEditor-EditingTools: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1035329 (10matmarex) [21:42:29] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#1035324 (10matmarex) 5Open>3declined a:3matmarex So, this look pretty declined to me, then. I filed T89399 about replacing the current approach with something that would actua... [21:42:53] 3OOjs-UI: Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#1035332 (10matmarex) [21:42:54] 3OOjs-UI: Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget - https://phabricator.wikimedia.org/T89399#1035314 (10matmarex) [21:42:56] 3VisualEditor, VisualEditor-EditingTools: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#676797 (10matmarex) [21:46:01] 3OOjs-UI: Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget - https://phabricator.wikimedia.org/T89399#1035353 (10Krinkle) `emit( 'attach' )` seems pretty sensible. We can even have it propagate using either jQuery or the EventEmitter on OO.ui.Element objects. I'm not sur... [21:50:28] 3OOjs-UI: Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget - https://phabricator.wikimedia.org/T89399#1035371 (10matmarex) But the problem is, how do we detect nodes being attached/detached in browsers that support neither DOMNodeInsertedIntoDocument or MutationObserver?... [21:55:22] 3UI-Standardization, OOjs-UI: Disabled button color not right - https://phabricator.wikimedia.org/T88483#1035394 (10violetto) 5Resolved>3Open {F40493} The icon on disabled buttons are still not white, reopening this task. [21:58:45] 3VisualEditor: [Regression pre-wmf17] Cannot open any page with VE in Betalabs , "TypeError: Cannot read property 'setDisabled' of null" appears in the console - https://phabricator.wikimedia.org/T88831#1035399 (10Ryasmeen) [22:01:31] 3VisualEditor, VisualEditor-MediaWiki-Media: [Regression pre-wmf17] The default search term is not getting highlighted when you open the media search dialog - https://phabricator.wikimedia.org/T88881#1035401 (10Ryasmeen) [22:04:21] (03CR) 10Paladox: "Never mind not fixed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 (owner: 10Paladox) [22:10:18] RoanKattouw: i needz ur halp [22:10:33] got time for some measurements? [22:15:00] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1035426 (10Paladox) Hi I have reported the bug at webkit for svg not being able to zoom out correctly on chrome. The bug is at https://bugs.webkit.org/show_bug.cgi?id=141535 [22:26:04] (03CR) 10Paladox: "What I mean by testing is by the bar showing where before it woulden so I think I fixed it there." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 (owner: 10Paladox) [22:29:42] (03PS3) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 [22:29:42] 3VisualEditor, VisualEditor-CopyPaste: Cutting and pasting a paragraph causes (only) the last inline template to be replaced by HTML - https://phabricator.wikimedia.org/T86401#1035461 (10Etonkovidova) Seems to be the same as T89163: Odd result: Subst'd template, or converted to HTML, or ???. [22:30:14] 3VisualEditor, VisualEditor-CopyPaste: Cutting and pasting a paragraph causes (only) the last inline template to be replaced by HTML - https://phabricator.wikimedia.org/T86401#1035463 (10Etonkovidova) p:5Triage>3Normal [22:30:26] (03CR) 10Paladox: "@Fomafix and @Mattflaschen please review and merge." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 (owner: 10Paladox) [22:32:01] (03PS4) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 [22:35:19] (03PS5) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 [22:36:49] (03PS1) 10Cscott: Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 [22:36:51] (03PS1) 10Cscott: Allow tabIndex to be null [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 [22:36:53] (03PS1) 10Cscott: Use $.isArray instead of Array.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 [22:36:56] (03PS1) 10Cscott: WIP: infusion of PHP widgets with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [22:36:57] (03PS1) 10Cscott: WIP: Implement OO.ui.infuse [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 [22:37:43] (03CR) 10jenkins-bot: [V: 04-1] WIP: Implement OO.ui.infuse [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (owner: 10Cscott) [22:38:17] (03CR) 10jenkins-bot: [V: 04-1] WIP: infusion of PHP widgets with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [22:40:29] (03PS29) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [22:41:17] (03CR) 10Catrope: [C: 04-1] Use $.isArray instead of Array.isArray (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [22:50:14] 3UI-Standardization, WMF-Design, OOjs-UI: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1035507 (10violetto) If it's not #DDD in mw.ui, we should change it @Prtksxna. I can't recall if it was a recent change, I just realized it wasn't #DDD a while ago. [22:51:54] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1035514 (10Qgil) [22:56:16] 3UI-Standardization, OOjs-UI: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1035531 (10violetto) 5Resolved>3Open I'm reopening this task because it isn't resolved yet. As far as I can tell, only the disabled button is resolved like descri... [22:56:19] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1035533 (10Paladox) The patch is ready to be merged with the svg and then we can merge the file that includes the svg line in css later. [23:05:51] 3VisualEditor, VisualEditor-EditingTools: Permit sorting of categories via drag-and-drop - https://phabricator.wikimedia.org/T52809#1035551 (10Etonkovidova) [23:10:42] 3VisualEditor, VisualEditor-MediaWiki-Templates: The transclusion dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76926#1035572 (10Etonkovidova) [23:14:57] 3VisualEditor: Absolutely positioned template in upper rightmost corner gets drawn through body text - https://phabricator.wikimedia.org/T89410#1035583 (10FrankGeerlings) 3NEW [23:18:49] 3VisualEditor: Absolutely positioned template in upper rightmost corner gets drawn through body text - https://phabricator.wikimedia.org/T89410#1035598 (10matmarex) [23:22:27] 3VisualEditor, VisualEditor-MediaWiki-Templates: Absolutely positioned template in upper rightmost corner gets drawn through body text - https://phabricator.wikimedia.org/T89410#1035617 (10Aklapper) [23:24:57] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: Dialogs should disable "Apply changes" until a change is present - https://phabricator.wikimedia.org/T57976#1035619 (10Etonkovidova) [23:31:48] Anyone remember when/where problem of getting "☀" inserted when pasting content got fixed? [23:35:04] 3VisualEditor: Cite backlinks turn from alpha to numeric - https://phabricator.wikimedia.org/T89413#1035637 (10FrankGeerlings) 3NEW [23:37:33] InezK: edsanders|away should [23:44:51] RoanKattouw, re:data-ve-no-generated-contents, yes [23:46:23] edsanders: OK good [23:46:35] I've been adding it to test cases everywhere but then I can make a separate change to strip it out later [23:46:40] we have converter.isForClipboard() a few lines above, which was added later [23:46:43] Yeah [23:46:49] We use that for another data-ve-thing [23:47:02] we use it for stripping the rendering [23:47:24] and for converting comment notes to actually-copyable spans [23:47:50] I'm very close to getting my tests passing after making my DM changes and changing the test runner [23:48:05] Once those last 3 tests pass, I get to figure out how to split this up into logical chunks :D [23:48:45] edsanders: do you remember when/where problem of getting "☀" inserted when pasting content got fixed? [23:49:00] hmm, fairly recent [23:49:22] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - https://phabricator.wikimedia.org/T70537#1035683 (10Ryasmeen) I managed to reproduce it consistently by following these st... [23:50:11] InezK, https://phabricator.wikimedia.org/T76916 [23:51:10] thanks!