[00:00:44] 3VisualEditor, VisualEditor-ContentEditable: Text that was added to a slug immediately vanishes when the cursor is placed in another slug - https://phabricator.wikimedia.org/T85948#1035714 (10Etonkovidova) [00:09:26] 3OOjs-UI: MediaWiki theme: Regular and disabled buttons have different height - https://phabricator.wikimedia.org/T87126#1035727 (10Etonkovidova) [00:13:02] 3VisualEditor, VisualEditor-MediaWiki-Media: Show media search results more pleasingly, with meta-data details available - https://phabricator.wikimedia.org/T78161#1035729 (10Etonkovidova) [00:15:11] (03PS2) 10Cscott: Serialize PHP widget state. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [00:15:13] (03PS2) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [00:16:31] (03CR) 10jenkins-bot: [V: 04-1] Serialize PHP widget state. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [00:16:33] (03CR) 10jenkins-bot: [V: 04-1] Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [00:19:11] 3OOjs-UI: Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget - https://phabricator.wikimedia.org/T89399#1035738 (10Esanders) I've come to the conclusion that detecting attach/detach IE9/10 is pretty much impossible. However, the event we're really interested in is typicall... [00:21:46] RoanKattouw, Krinkle: do you know why there is still an expensive animation / isHidden / recalc style on init? http://d.pr/i/18yda [00:24:34] 3VisualEditor, VisualEditor-Performance: ~200ms spent on CSSStyleDeclaration.getPropertyValue() due to jQuery hide()/show() - https://phabricator.wikimedia.org/T87160#1035744 (10ori) 5Resolved>3Open Still seeing this: {F40531} (On osmium's Barack Obama, all repos on HEAD) [00:24:40] 3OOjs-UI, UI-Standardization: Shadow at the bottom of buttons, dropdown menus is intentionally vertically mis-aligned by a pixel or two in the MediaWiki theme - https://phabricator.wikimedia.org/T78083#1035746 (10Etonkovidova) [00:26:34] ori: Is that even with my toolbar animation commit? [00:26:46] ori: I'm guessing transformPage() also animates its hiding of things [00:27:01] ori: Shall I amend my WIP toolbar animation commit to remove that animation too? [00:27:11] RoanKattouw: has that been merged? If so, then yes: I updated to origin/master a few minutes ago [00:27:14] RoanKattouw: yes please [00:27:16] No it has not [00:27:23] Oh, let me try with that patch. [00:27:24] Since it's WIP :P [00:27:31] Oh, right. [00:27:37] Ahm, actually [00:27:40] My working copy is dirty [00:27:45] Can I come over and help you update the patch? [00:27:57] sure [00:30:19] 3OOjs-UI: Textfield widget uses role=textbox for no reason - https://phabricator.wikimedia.org/T87830#1035749 (10Etonkovidova) [00:32:43] Krinkle: WTF is up with the ve-hide CSS class? It seems to be unused [00:32:52] Oooh wait I see [00:32:54] It's used as a selector [00:33:14] OK that's slightly confusing but clever [00:34:13] RoanKattouw: Merge on https://gerrit.wikimedia.org/r/#/c/190173/ ? [00:34:28] RoanKattouw: Interesting. I guess that predates oo-ui-hidden? [00:34:55] No, it's not styled against at all [00:35:09] Instead it's used to remember what was hidden by transformPage(), so that restorePage() can show those things [00:35:12] It's pretty clever actually [00:35:41] But ack-grep --css ve-hide came up blank, and I had to read the JS uses three times before I realized what was happening [00:35:45] I was just being slow :) [00:35:59] RoanKattouw: Ah, I see. [00:36:11] RoanKattouw: There was a similar thing in VPT, but I removed it [00:36:33] That is in VPT [00:36:35] I can confirm that it works [00:36:39] Yeah, but I mean another one [00:37:11] RoanKattouw: I think we can make that one ride the same train as the others I refactored, but it was weird for some reason so I left it as-is for the time being [00:37:18] Right [00:37:25] In other news: sigh, browsers [00:37:30] specifically, I wanted my commit to be implementation only and not affect when things hide. [00:37:32] * RoanKattouw is filing a Firefox bug [00:37:37] Krinkle: is there anything we can do about http://d.pr/i/21fU ? [00:37:47] in my commit you'll see the inconsistency we had more clearly. [00:37:50] That's for another commit [00:38:10] ori: back in a few minutes. juggling Dutch paperworks and dinner. [00:38:22] paperwork :) [00:38:26] (moving to UK etc. backlash of paper work) [00:39:34] Krinkle: Oh yeah, that's right, enjoy filing your taxes on dead trees [00:40:06] ori: I was looking at that too, and I'm not sure [00:40:26] There's a similarly expensive reflow in ClippableElement for clipping the edit notices popup [00:40:56] But as you might be able to tell, the method is called calculateOffset(), and it's because we need to know where the toolbar is [00:41:03] That one (the toolbar one) we might be able to lazy-compute [00:41:15] But at some point we're gonna have to know where it is, for floating purposes [00:41:27] I'll file a task so we don't forget [00:41:31] Please do [00:42:22] (03PS1) 10Cscott: Use $.isArray if it is available. [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 [00:43:03] (03CR) 10jenkins-bot: [V: 04-1] Use $.isArray if it is available. [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 (owner: 10Cscott) [00:43:46] 3VisualEditor, VisualEditor-Performance: Layout / recalculate style in ve.ui.Toolbar.calculateOffset - https://phabricator.wikimedia.org/T89419#1035761 (10ori) 3NEW [00:45:13] (03PS2) 10Cscott: Use $.isArray if it is available. [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 [00:45:48] (03CR) 10jenkins-bot: [V: 04-1] Use $.isArray if it is available. [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 (owner: 10Cscott) [00:46:56] (03PS2) 10Cscott: Use $.isArray instead of Array.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 [00:46:58] (03PS3) 10Cscott: Serialize PHP widget state. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [00:47:00] (03PS3) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [00:47:31] 3VisualEditor, VisualEditor-Performance: Recalculate style in ve.ui.Surface.initialize - https://phabricator.wikimedia.org/T89421#1035776 (10ori) 3NEW [00:48:13] (03CR) 10jenkins-bot: [V: 04-1] Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [00:48:28] (03PS1) 10Bartosz Dziewoński: docparser: Add support for 'protected' methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190395 [00:48:30] (03PS1) 10Bartosz Dziewoński: testsuitegenerator: Only test every pair of config options rather than every triple [oojs/ui] - 10https://gerrit.wikimedia.org/r/190396 [00:48:32] (03PS1) 10Bartosz Dziewoński: Update PHP widgets for accessibility-related changes in JS widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/190397 (https://phabricator.wikimedia.org/T88086) [00:49:45] (03CR) 10jenkins-bot: [V: 04-1] docparser: Add support for 'protected' methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190395 (owner: 10Bartosz Dziewoński) [00:50:13] (03CR) 10jenkins-bot: [V: 04-1] testsuitegenerator: Only test every pair of config options rather than every triple [oojs/ui] - 10https://gerrit.wikimedia.org/r/190396 (owner: 10Bartosz Dziewoński) [00:50:25] (03PS3) 10Cscott: Use $.isArray if it is available. [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 [00:50:59] (03CR) 10jenkins-bot: [V: 04-1] Use $.isArray if it is available. [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 (owner: 10Cscott) [00:51:27] (03CR) 10Bartosz Dziewoński: "(Conflicts with https://gerrit.wikimedia.org/r/190397, I'd resolve but I'm off to sleep.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [00:51:51] (03CR) 10Bartosz Dziewoński: "(Conflicts with https://gerrit.wikimedia.org/r/#/c/190365/ , I'd resolve but I'm off to sleep.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190397 (https://phabricator.wikimedia.org/T88086) (owner: 10Bartosz Dziewoński) [00:52:12] (03PS2) 10Bartosz Dziewoński: Update PHP widgets for accessibility-related changes in JS widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/190397 (https://phabricator.wikimedia.org/T88086) [00:52:51] 3VisualEditor, VisualEditor-Performance, OOjs-UI: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1035798 (10ori) 3NEW a:3matmarex [00:59:18] (03PS1) 10Mooeypoo: Refactor MWMediaResultWidget to resize better [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 [01:00:20] 3VisualEditor, VisualEditor-EditingTools: Add some more keyboard shortcuts for VisualEditor's built-in Search and Replace system - https://phabricator.wikimedia.org/T87113#1035814 (10Etonkovidova) [01:00:55] 3VisualEditor, VisualEditor-EditingTools: Add shortcuts for VisualEditor's built-in Search and Replace system to Help->Keyboard shortcuts box - https://phabricator.wikimedia.org/T87872#1035816 (10Etonkovidova) [01:01:09] (03CR) 10jenkins-bot: [V: 04-1] Refactor MWMediaResultWidget to resize better [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 (owner: 10Mooeypoo) [01:03:53] 3VisualEditor-MediaWiki, VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - https://phabricator.wikimedia.org/T72504#1035825 (10Etonkovidova) [01:06:17] 3OOjs-UI: In MediaWiki theme, some thin grey lines in dialogs do not appear in some configurations - https://phabricator.wikimedia.org/T85226#1035831 (10Etonkovidova) [01:07:22] (03PS2) 10Mooeypoo: Refactor MWMediaResultWidget to resize better [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 [01:09:16] 3VisualEditor, OOjs-UI: MediaWiki theme: Border radius used inconsistently - https://phabricator.wikimedia.org/T85973#1035839 (10Etonkovidova) [01:10:55] 3VisualEditor, VisualEditor-MediaWiki-Templates: Insert/Template inspector should put focus on input text_field when invoked but no longer does - https://phabricator.wikimedia.org/T85484#1035840 (10Etonkovidova) [01:14:20] 3VisualEditor, VisualEditor-EditingTools: A number of VisualEditor dialogs do not cover full screen when 'full' size - https://phabricator.wikimedia.org/T76863#1035849 (10Etonkovidova) [01:15:01] 3VisualEditor, VisualEditor-MediaWiki-Media: Make the media dialog bigger when searching for media to insert - https://phabricator.wikimedia.org/T86397#1035850 (10Etonkovidova) [01:16:27] 3VisualEditor, VisualEditor-EditingTools: Make it easy to identify the file type (e.g., .png versus .svg) when adding an image - https://phabricator.wikimedia.org/T74061#1035852 (10Etonkovidova) [01:17:01] 3OOjs-UI: Have a larger size of dialog than 'large' - https://phabricator.wikimedia.org/T86396#1035853 (10Etonkovidova) [01:17:38] 3VisualEditor, VisualEditor-MediaWiki-Media: In the VisualEditor media selector, show the name of each file so it can be identified - https://phabricator.wikimedia.org/T54459#1035854 (10Etonkovidova) [01:20:10] 3VisualEditor, VisualEditor-MediaWiki-Media: Show media search results more pleasingly, with meta-data details available - https://phabricator.wikimedia.org/T78161#1035859 (10Etonkovidova) [01:21:09] (03CR) 10Krinkle: [C: 04-1] "This might make sense for OOjs UI but is redundant for OOjs. As shown in the readme, it requires the environment to provide these methods." [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 (owner: 10Cscott) [01:25:28] (03CR) 10Krinkle: [C: 04-1] "I have to ask, did you observe this as a problem in old IE or is it theoretical? OOjs UI depends on OOjs which requires ES5 methods. A shi" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [01:43:26] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - https://phabricator.wikimedia.org/T70537#1035914 (10Catrope) This happens because of a bug in Firefox: https://bugzilla.mo... [01:56:47] RoanKattouw: Can you explain TabIndexedElement from a high level? [01:56:59] Ask MatmaRex or thedj [01:57:02] I had nothing to do with it [01:57:13] specifically setTabIndexedElement and setTabIndex. [01:57:25] It seems a bit convoluted. [01:59:34] 3VisualEditor, VisualEditor-EditingTools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - https://phabricator.wikimedia.org/T70537#1035925 (10Catrope) Incidentally, this is like the only case ever where getting `... [02:01:46] Krinkle: Is this about the pattern where those setters are called from the constructor? [02:01:54] That's more of a Trevor thing IIRC [02:07:49] RoanKattouw: more that there's two methods that somewhat overlap intention wise. It's a bit confusing. [02:07:55] I'm slowly grasping now though [02:08:09] Oh [02:08:22] setTabIndex sets the tabindex, setTabIndexedElement sets which element is affected by the mixin [02:08:24] AIUI [02:08:41] 2466 assertions of 2466 passed, 0 failed. [02:08:43] SWEET [02:08:49] I'm outta here [02:08:54] Have a good night [02:10:21] (03CR) 10Krinkle: Allow tabIndex to be null (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [02:14:43] 3VisualEditor, OOjs-UI: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1035952 (10Etonkovidova) Checked - betalabs, test2, production - looks fine everywhere. [02:33:20] (03CR) 10Cscott: Allow tabIndex to be null (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [02:34:50] (03CR) 10Cscott: "Well, I was trying to make things consistent. The current codebase is a mix of $.isArray and Array.isArray. $.isArray seemed better, sin" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [02:49:22] (03PS4) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [02:50:37] (03CR) 10Krinkle: "Ah, I see. Yeah, we standardised on Array.isArray for projects that require ES5 methods. Looks like a few creeped back in. Thanks!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [02:50:42] (03CR) 10jenkins-bot: [V: 04-1] Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [02:53:29] (03PS2) 10Cscott: Allow tabIndex to be null [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 [02:54:29] (03CR) 10Cscott: "Fixed the conflict: rebased the other patch on top of this one." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190397 (https://phabricator.wikimedia.org/T88086) (owner: 10Bartosz Dziewoński) [02:54:56] (03CR) 10Cscott: "Rebased on top of MatmaRex's patch." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [03:01:18] (03CR) 10Krinkle: Allow tabIndex to be null (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [03:03:07] (03CR) 10Krinkle: "Would be nice to have our JS/PHP match test suite assert this." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190397 (https://phabricator.wikimedia.org/T88086) (owner: 10Bartosz Dziewoński) [03:03:21] (03PS3) 10Cscott: Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 [03:03:23] (03PS2) 10Cscott: Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 [03:06:37] (03PS4) 10Cscott: Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 [03:06:39] (03PS3) 10Cscott: Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 [03:06:41] (03PS3) 10Cscott: Allow tabIndex to be null [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 [03:07:01] (03CR) 10Cscott: Allow tabIndex to be null (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [03:16:05] (03PS4) 10Cscott: Serialize PHP widget state. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [03:16:07] (03PS5) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [03:17:59] (03CR) 10Cscott: "Well, it reduces the ES5 footprint by one method and allows a smaller ES5 shim to be used (when jQuery is also being loaded)." [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 (owner: 10Cscott) [03:21:08] 3UI-Standardization, OOjs-UI: OOjs UI: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1036007 (10cscott) Tomorrow I'll try to update my patch to the Collection extension ( https://gerrit.wikimedia.org/r/187141 ) to use this, to demonstrate a practical use. [04:41:09] 3UI-Standardization, OOjs-UI: ToggleSwitchWidget has no visual representation for focused state - https://phabricator.wikimedia.org/T88973#1036044 (10violetto) I'm looking into this and I see the point about the "on" state looking disabled. We have the same problem with ButtonSelectWidget when there are only 2 b... [04:45:33] (03CR) 10Krinkle: "ES5 isn't a plugin, it's native. That should always be preferred, not jQuery. Needless indirection. The browsers needing a polyfill get sm" [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 (owner: 10Cscott) [04:47:20] (03CR) 10Krinkle: "If anything, we could look into creating a jQuery-optimised es5-shim that would re-use its code where possible and make itself smaller tha" [oojs/core] - 10https://gerrit.wikimedia.org/r/190394 (owner: 10Cscott) [05:21:48] 3UI-Standardization, OOjs-UI: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1036065 (10Prtksxna) Yup, the task isn't resolved. Left comments on M37. //Sorry about the confusion!// [05:26:02] 3UI-Standardization, OOjs-UI: Disabled button color not right - https://phabricator.wikimedia.org/T88483#1036067 (10Prtksxna) [07:58:03] 3OOjs-UI: TextInputLabel is visible when not in use - https://phabricator.wikimedia.org/T89431#1036120 (10TrevorParscal) 3NEW a:3Esanders [08:18:48] 3VisualEditor, VisualEditor-MediaWiki-Templates: Absolutely positioned template in upper rightmost corner gets drawn through body text - https://phabricator.wikimedia.org/T89410#1036169 (10TheDJ) This is because the Dutch wiki uses JS to reposition the element dynamically (into a spot where VE will not hide it l... [08:19:53] (03PS1) 10Krinkle: Move svgMaxSize and namespacesWithSubpages to site config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190421 (https://phabricator.wikimedia.org/T89434) [08:20:33] (03PS2) 10Krinkle: Move svgMaxSize and namespacesWithSubpages to site config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190421 (https://phabricator.wikimedia.org/T89434) [08:58:41] 3VisualEditor-MediaWiki, VisualEditor: Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1036214 (10Krinkle) 3NEW [09:03:34] 3UI-Standardization, OOjs-UI: ToggleSwitchWidget has no visual representation for focused state - https://phabricator.wikimedia.org/T88973#1036228 (10Ricordisamoa) @violetto What would you think of using colors to strengthen the "on" state? [10:03:34] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#1036311 (10Ricordisamoa) Some on-wiki feedback by Atlasowa: https://meta.wikimedia.org/wiki/Special:Diff/11245144/11247870 [10:09:27] 3VisualEditor, VisualEditor-MediaWiki-Templates: Absolutely positioned template in upper rightmost corner gets drawn through body text - https://phabricator.wikimedia.org/T89410#1036313 (10Aklapper) Thanks TheDJ. Wondering if that means this is an underlying on-wiki code problem that VE should not care about. Or... [10:09:55] 3VisualEditor, VisualEditor-MediaWiki-Templates: Absolutely positioned template in upper rightmost corner gets drawn through body text (due to custom JS on nl.wp) - https://phabricator.wikimedia.org/T89410#1036314 (10Aklapper) p:5Triage>3Volunteer? [10:44:33] hmm, I'm getting a weird bug in VE on a different skin where the editable content is appended *after* the actual content [10:44:50] any thoughts? [12:03:53] (03PS1) 10Esanders: Hide TextInputWidget mixin components when unused [oojs/ui] - 10https://gerrit.wikimedia.org/r/190434 (https://phabricator.wikimedia.org/T89431) [12:03:55] (03PS1) 10Esanders: Use margins for moving TextInputWidget label [oojs/ui] - 10https://gerrit.wikimedia.org/r/190435 [12:03:57] (03PS1) 10Esanders: [BREAKING CHANGE] Rename setPosition to setLabelPosition [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 [12:37:05] 3VisualEditor: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1036450 (10Elitre) [12:43:57] anybody OOJS-UI-savvy around? [12:43:59] * werdna looks at edsanders [12:44:09] ish [12:44:09] I'm trying to figure out how I might get a list of "top-level" widgets [12:44:34] i.e. including ButtonWidget and MenuSelectWidget but not MenuOptionWidget [12:45:35] hm [12:46:42] I don't think anything in the code would tell them apart [12:46:58] mmmh [12:47:04] maybe I should take a different tack then [12:47:12] e.g. sometimes ButtonWidget isn't top level, when part of a ButtonGroupWidget [12:47:12] I want some way of guaranteeing that my OOUI "smoke test" has all widgets in it [12:47:24] but maybe I'm better off not distinguishing the two [12:47:30] and just saying each widget has to be shown once [12:48:02] next question: can I filter out the "abstract" types? [12:48:04] our demo pages have most of the widgets in, you'd have to go through all the widgets and work out if they can be sensibly used in isolation [12:49:38] if something is actually abstract it will be marked as @abstract [12:50:03] while we recommend subclassing certain things, like OptionWidget, it isn't required for it to work [12:54:12] hmm [12:54:31] maybe I should mark something as used if a subclass is used [12:54:35] that might be a way of sidestepping [12:56:50] 3VisualEditor, VisualEditor-ContentLanguage, VisualEditor-ContentEditable: interface to support extensions that provide on-screen keyboards for Visual Editor - https://phabricator.wikimedia.org/T86479#1036562 (10Ilya) >>! In T86479#1028518, @Nemo_bis wrote: > For these it's crucial to reuse jequery.uls and not i... [13:05:35] (03CR) 10Krinkle: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189508 (owner: 10Krinkle) [13:05:47] (03CR) 10jenkins-bot: [V: 04-1] ve.utils: Cover insertIntoArray with unit test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189508 (owner: 10Krinkle) [13:48:55] I would like to add VisualEditor into a stand-alone project. I have read http://www.mediawiki.org/wiki/VisualEditor/Setup#mediawiki-visualeditor [13:49:39] What are the steps I need to take? Is the source code of VE available? [13:53:39] Ok I just found some better information, will add it to the former page. https://www.mediawiki.org/wiki/Extension:VisualEditor [13:57:28] however, information is rare if VE can be used for non-mediawiki environments. Eg providing only wiki markup as input [13:58:11] 3VisualEditor, VisualEditor-ContentLanguage, VisualEditor-ContentEditable: interface to support extensions that provide on-screen keyboards for Visual Editor - https://phabricator.wikimedia.org/T86479#1036609 (10Jrf) We are hoping to find (or help create) an externally defined **interface** on VE, so that we can... [15:10:36] (03PS2) 10Krinkle: ve.utils: Cover insertIntoArray with unit test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189508 [15:12:45] (03PS6) 10Esanders: Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) [15:15:44] (03PS1) 10Esanders: Add vector specific rules for slug animation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190461 [15:17:54] 3VisualEditor, VisualEditor-EditingTools: Cite: unexpected behavior attempting multiple citations (e.g. first Website, then Book) - https://phabricator.wikimedia.org/T71483#1036721 (10Aklapper) p:5Triage>3Low [15:18:12] (03PS2) 10Bartosz Dziewoński: TextInputWidget: Hide mixin components when unused [oojs/ui] - 10https://gerrit.wikimedia.org/r/190434 (https://phabricator.wikimedia.org/T89431) (owner: 10Esanders) [15:18:18] (03CR) 10Bartosz Dziewoński: [C: 032] TextInputWidget: Hide mixin components when unused [oojs/ui] - 10https://gerrit.wikimedia.org/r/190434 (https://phabricator.wikimedia.org/T89431) (owner: 10Esanders) [15:18:56] 3VisualEditor, VisualEditor-MediaWiki-Links: Cite backlinks turn from alpha to numeric - https://phabricator.wikimedia.org/T89413#1036724 (10Aklapper) p:5Triage>3Low [15:19:02] (03PS2) 10Krinkle: ve.utils: Clean up escapeHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189509 [15:19:37] (03Merged) 10jenkins-bot: TextInputWidget: Hide mixin components when unused [oojs/ui] - 10https://gerrit.wikimedia.org/r/190434 (https://phabricator.wikimedia.org/T89431) (owner: 10Esanders) [16:30:19] 3VisualEditor, VisualEditor-MediaWiki-Templates: Absolutely positioned template in upper rightmost corner gets drawn through body text (due to custom JS on nl.wp) - https://phabricator.wikimedia.org/T89410#1036832 (10FrankGeerlings) Thanks for looking into this. It sounds like this means there is something Dutch... [16:36:53] MatmaRex: Feel like reviewing a MediaViewer patch that fixes its use of OOjs UI after the breaking change? https://gerrit.wikimedia.org/r/#/c/190433/ [16:38:30] sure [16:38:32] uh-oh [16:39:14] ? [16:42:26] that's nasty [16:42:44] and was not caused by a breaking change, but by abusing private implementation details [16:42:47] i am reviewing :) [16:43:08] by the way… this code in DropdownWidget looks like it could be four lines shorter. [16:43:09] if ( this.menu.isVisible() ) { [16:43:09] this.menu.toggle( false ); [16:43:10] } else { [16:43:10] this.menu.toggle( true ); [16:43:10] } [16:48:20] Oh dear. :-) [16:57:33] Did wikibugs die? [16:57:36] (i submitted a patch for it, grrrit-wm is down) [16:57:49] hm [16:57:59] MatmaRex: You broke lolrit?! ;-) [16:58:38] never touched the thing [16:58:56] by the way, loading VE in debug mode make it extremely messed up. [16:59:19] http://en.wikipedia.beta.wmflabs.org/wiki/0.24595949980612886?veaction=edit&debug=1 = http://i.imgur.com/xN4Caab.png [17:02:01] Hmm. [17:02:36] I think I fixed it. [17:02:37] Hopefully. [17:02:49] Though I had to kick it twice. [17:03:34] MatmaRex: More to the point, why is the VE edit tab missing when you use ?debug=true. [17:03:56] oh yes, that also. [17:04:19] personally, the noodly popup bothers me more. [17:04:35] Timo's answer would be to never use debug mode. ;-) [17:07:55] Krenair: Is https://gerrit.wikimedia.org/r/#/c/189049/ (your MW-core patch to support Schema:Edit for WE) just waiting for code review or is there more to do? [17:08:23] code review I think, for this patch [17:08:43] Right. [17:09:30] But I'll probably have another patch [17:09:30] for core [17:09:46] OK. [17:09:56] Every time I work around an issue I find another :( [17:10:14] * James_F nods. :-( [17:11:28] MatmaRex: Also, http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?debug=true&veaction=edit spins forever for me but no VE loads… [17:11:45] MatmaRex: (At least, nothing's loaded in 10 minutes.) [17:13:55] James_F: someone reported that some load.php URLs are 500 or 403 or something on beta a few days ago [17:14:06] and VE doesn't handle module loading failures [17:14:11] Aha. [17:14:23] Yeah, looking I got a 503 for ve.dm.MWHeadingNode.js [17:14:26] That'd explain. [17:14:40] James_F: https://phabricator.wikimedia.org/T89395 [17:15:43] ugh, so much stuff is broken in debug mode for me [17:15:52] the More/Fewer in tool groups doesn't work either [17:16:00] clearly something is amiss here [17:16:34] MatmaRex: … that works for me. [17:16:52] MatmaRex: And the Alert window looks normal-sized. [17:17:10] yeah, something is loading in the wrong order for me, apparently? [17:17:17] meh [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111797651 [17:30:35] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111800124 [17:30:35] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34302789 [17:30:35] Corruption alert: visualeditor-needcheck on mswiki: https://ms.wikipedia.org/?diff=3547116 [17:57:19] fuckkkkkkkkkkkkkkkkkkkkkkkkkkkkk [17:58:00] ori: / [17:58:11] that's 300kb of javascript on barack obama for the media player http://i.imgur.com/5jx7QRq.png [17:58:30] Oh, yeah, TimedMediaHandler is a seriously huge piece of code. [17:58:47] * James_F makes this marktraceur's problem and goes to the stand-up. [17:59:00] Wat [17:59:03] Oh. [17:59:05] why can't we have an RFC to undeploy *that* [17:59:05] Oh no. [17:59:26] ori: I'm on board, let's do it [17:59:41] Wait, jquery UI is HOW BIG? [17:59:43] WHAT THE HELL [18:00:15] something's wrong, right? [18:00:16] it grew [18:00:28] I mean, embedplayer is shit too, but I'm not sure how we can change that...it's mostly Kaltura's problem I think [18:00:35] I dunno if it grew [18:00:39] Maybe git log can tell us. [18:01:28] jQuery UI was updated a few months ago [18:01:40] new versions of things usually have more code than old versions [18:01:51] :D [18:02:06] MatmaRex: You and your logic [18:03:34] MatmaRex: what would you call 20ms? [18:04:25] ori: a short delay noticeable when ran in a tight loop :P [18:25:06] marktraceur: We could switch to something else that's more performant, maybe? [18:25:17] Maybe. [18:25:51] But switching from jQuery UI to OOjs UI might be less effort for the same general pay-off. [18:26:30] (Given that every page payload will soon[*] involve the OOjs UI styling module.) [18:27:14] TrevorP|Away: https://gerrit.wikimedia.org/r/#/c/190022/ in VE-core; https://gerrit.wikimedia.org/r/#/c/190461/ in VE-MW. [18:29:23] James_F++ [18:29:45] edsanders: CR on https://gerrit.wikimedia.org/r/#/c/189657/ https://gerrit.wikimedia.org/r/#/c/189627/ https://gerrit.wikimedia.org/r/#/c/190421/ [18:30:50] ori: If not seen: http://www.rdanderson.com/stargate/entries/ori.htm [18:31:07] or http://ori.scs.stanford.edu/ [18:43:31] cscott: ship it [18:48:55] 3VisualEditor: [Regression wmf17] Insert->Special Character: the 'symbols' label is not capitalized - https://phabricator.wikimedia.org/T89464#1037215 (10Aklapper) > It's in production only Which exact site is "production"? I can reproduce on en.wp in English. I cannot reproduce on de.wp in English (via &uselan... [18:50:08] (03CR) 10Esanders: [C: 04-1] Create APIResultsProvider and APIResultsQueue and add tests (0320 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [18:50:40] 3VisualEditor: [Regression wmf17] Insert->Special Character: the 'symbols' label is not capitalized - https://phabricator.wikimedia.org/T89464#1037223 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF The labels are set manually at https://en.wikipedia.org/wiki/MediaWiki:Visualeditor-specialcharinspec... [18:56:30] (03PS1) 10Jforrester: Update VE core submodule to master (3a53aad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190495 [18:58:24] ori: :-) [19:01:26] ori: The professor supervising ori.scs.stanford.edu was also my supervisor when I was at Stanford :) [19:01:37] 3MediaWiki-General-or-Unknown, Services, RESTBase, VisualEditor: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1037282 (10GWicke) [19:01:41] 3VisualEditor-MediaWiki-Templates, VisualEditor: Absolutely positioned template in upper rightmost corner gets drawn through body text (due to custom JS on nl.wp) - https://phabricator.wikimedia.org/T89410#1037286 (10FrankGeerlings) Thanks, @matmarex! I'll look into that. [19:04:31] [11:00] James_F [2015-02-13 09:00:07] MatmaRex: More to the point, why is the VE edit tab missing when you use ?debug=true. [19:04:39] It's because delivery of user preferences is broken in debug mode [19:04:59] Because the default prefs end up being delivered *after* the user prefs, overwriting them; or something [19:05:13] i think debug mode would be so much more useful if we changed it to be exactly like non-debug mode except no minification [19:05:25] how long has that been broken? [19:05:40] concatenation isn't really a problem; separating the modules into discrete requests makes debug mode *less* useful because strange race conditions crop up [19:06:14] if the code isn't minified, scrolling up to the nearest 'mw.loader.implement(' call to figure out which module you're in isn't really hard [19:07:03] ori: i agree with you [19:07:09] ori: error messages from concatenated code are a lot less useful than from non-concatenated, and we use that to help non-technical people report actionable bugs [19:07:17] backtraces* [19:10:23] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Using browser native interactive spell-check when the changed word in the only item in the paragraph causes endless insertions in Firefox - https://phabricator.wikimedia.org/T74929#1037349 (10Etonkovidova) Re-checcked (Mac FF 34.0.5) - production - test... [19:10:39] 3VisualEditor-MediaWiki, VisualEditor: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1037351 (10Etonkovidova) [19:11:20] (03PS3) 10Mooeypoo: Refactor MWMediaResultWidget to resize better [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 [19:13:22] James_F, so where is this parsoid displaytitle bug? [19:18:30] MatmaRex: how's it going? [19:19:21] alright, i guess [19:19:45] gotta jump into RL and build code again, eh [19:30:05] Krenair: isn't that the bug I fixed? [19:30:17] maybe? [19:30:23] I don't know which bug you fixed [19:41:49] (03PS1) 10Kmenger: ButtonElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190499 [19:43:02] (03CR) 10Mooeypoo: Create APIResultsProvider and APIResultsQueue and add tests (0317 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [19:48:32] (03PS14) 10Mooeypoo: Create APIResultsProvider and APIResultsQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [19:49:03] (03PS15) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [19:50:13] (03CR) 10jenkins-bot: [V: 04-1] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [19:52:20] (03CR) 10jenkins-bot: [V: 04-1] Create APIResultsProvider and APIResultsQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [19:53:10] TrevorParscal: https://gerrit.wikimedia.org/r/190116 [19:53:48] (03CR) 10Trevor Parscal: [C: 032] docs: Make @example documentation tag work [oojs/ui] - 10https://gerrit.wikimedia.org/r/190116 (owner: 10Catrope) [19:55:37] (03Merged) 10jenkins-bot: docs: Make @example documentation tag work [oojs/ui] - 10https://gerrit.wikimedia.org/r/190116 (owner: 10Catrope) [20:01:02] (03PS16) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [20:02:45] (03PS17) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 [20:04:24] 3VisualEditor: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1037474 (10matmarex) Looks like a missing RL module with the styles. [20:05:16] (03PS5) 10Cscott: Serialize PHP widget state. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [20:05:18] (03PS6) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [20:05:59] Krenair: https://phabricator.wikimedia.org/T51075 [20:06:09] (03CR) 10jenkins-bot: [V: 04-1] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [20:06:34] Krenair: looks like it was merged after the wednesday deploy window, so won't go live until monday [20:06:39] (03PS15) 10Mooeypoo: Create APIResultsProvider and APIResultsQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 [20:07:01] (03PS2) 10Bartosz Dziewoński: [WIP] Add horizontal alignment test to demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) [20:07:30] cscott, okay, chrismcmalunch found https://phabricator.wikimedia.org/T89383 in beta [20:08:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add horizontal alignment test to demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński) [20:08:29] Krenair: oh, that looks different [20:08:40] Krenair: Not bug, https://gerrit.wikimedia.org/r/#/c/189994/ – code. [20:10:01] cscott, so setting displaytitle in VE right now duplicates... a lot of stuff :| [20:10:48] and doesn't add actual displaytitle syntax [20:10:49] I suspect this counts as a corruption bug [20:11:05] could somebody merge https://gerrit.wikimedia.org/r/#/c/190397/ for me? super simple stuff [20:11:24] (03PS3) 10Ori.livneh: Update PHP widgets for accessibility-related changes in JS widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/190397 (https://phabricator.wikimedia.org/T88086) (owner: 10Bartosz Dziewoński) [20:11:29] (03CR) 10Ori.livneh: [C: 032] Update PHP widgets for accessibility-related changes in JS widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/190397 (https://phabricator.wikimedia.org/T88086) (owner: 10Bartosz Dziewoński) [20:12:44] (03Merged) 10jenkins-bot: Update PHP widgets for accessibility-related changes in JS widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/190397 (https://phabricator.wikimedia.org/T88086) (owner: 10Bartosz Dziewoński) [20:12:57] yay, moving the train along [20:20:36] 3VisualEditor-MediaWiki, VisualEditor: [Regression pre-wmf18] Options/Advanced settings/Display title no longer appears in diff view - https://phabricator.wikimedia.org/T89383#1037543 (10Jdforrester-WMF) [20:21:44] James_F, is seems worse than just "no longer appears in diff view" [20:21:50] what happens when you try this? [20:22:12] (03CR) 10Bartosz Dziewoński: [C: 04-1] Allow tabIndex to be null (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [20:22:18] Krenair: I've not had time to try it. Tell chrismcmalunch to fix the task title, not me. :-) [20:22:28] cscott: i feel a bit bad nitpicking on mostly case differences, but i trust you'll forgive me. [20:23:02] (03CR) 10Bartosz Dziewoński: Allow tabIndex to be null (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [20:23:46] cscott: speaking of which, your nofollow patch is also inconsistent :( is it nofollow or noFollow? [20:26:16] Krenair: shout if I can help with something [20:26:37] it seems worse than just "no longer appears in diff view" [20:26:46] what do you get instead of the displaytitle syntax? [20:27:05] 3OOjs-UI: Audit and update PHP widgets for accessibility parity with JS widgets - https://phabricator.wikimedia.org/T88086#1037573 (10Jdforrester-WMF) 5Open>3Resolved [20:27:57] MatmaRex: not my fault, there's a camel-case convention for properties but an all-lowercase convention for attribute names. [20:28:36] MatmaRex: i am at the mercy of the inconsistencies between W3C and the WMF style guide. [20:28:40] cscott: yes, OOUI has been consistently going with camel case so far [20:29:03] (the only exception i know is 'autofocus' in TextInputWidget, but there the in-browser DOM property is also all lowercase) [20:29:53] cscott: regardless of which way we do it, the configuration option and the method should use the same casing, IMO [20:30:17] MatmaRex: sure. it probably wouldn't hurt to camel case everything but the attribute. [20:30:26] +1 to that. [20:30:48] setAutoFocus ? [20:31:04] on the otherhand, autofocus is a single word. [20:31:23] hmph, there's also autosize and multiline there, both lowercase [20:31:37] i blame trevor. [20:35:46] https://en.wikipedia.org/wiki/Autofocus vs https://en.wikipedia.org/wiki/Auto_Focus [20:36:16] cscott: Auto-focus, however, is two words. ;-) [20:36:51] cscott: If it's clearly one word, why do we call it "AF" in the photography business? [20:37:55] James_F: that reminds me. is OOUI written in british or american english? :D [20:38:03] MatmaRex: British! Ish. [20:38:12] MatmaRex: ;-) [20:38:28] recently i noticed we say 'focusing' and 'focused' in a few places. should probably remedy that, eh? [20:38:39] Eh. I don't care. [20:41:37] (…enough). [20:43:50] (03PS5) 10Cscott: Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 [20:43:52] (03PS6) 10Cscott: Serialize PHP widget state. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [20:43:54] (03PS4) 10Cscott: Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 [20:43:56] (03PS4) 10Cscott: Allow tabIndex property to be null [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 [20:43:58] (03PS7) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [20:44:23] (03CR) 10Bartosz Dziewoński: Various fixes to the PHP implementation (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 (owner: 10Cscott) [20:44:29] (03CR) 10Jforrester: [C: 032] Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [20:44:49] (03CR) 10Bartosz Dziewoński: [C: 04-1] Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 (owner: 10Cscott) [20:45:39] (03CR) 10Jforrester: [C: 04-1] Serialize PHP widget state. (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [20:46:02] 3UI-Standardization, OOjs-UI: OOjs UI: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1037607 (10Jdforrester-WMF) a:5TrevorParscal>3cscott [20:46:06] (03CR) 10Bartosz Dziewoński: [C: 032] Allow tabIndex property to be null [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [20:47:16] (03CR) 10Cscott: [C: 04-2] "Hold the train!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [20:47:44] MatmaRex: just noticed your comments re the commit message. if i stopped jenkins in time, i'll fix that. [20:47:44] cscott: Three seconds before it was too late. :-) [20:47:48] (03CR) 10Bartosz Dziewoński: "See comments on PS3 LabelWidget.php. Also, please keep JS and PHP demos in sync (we recently started doing this). Thanks for the cleanup!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 (owner: 10Cscott) [20:48:02] oh, heh [20:48:11] i forgot about that myself already [20:52:02] 3OOjs-UI: LookupElement gets clipped inside ProcessDialog - https://phabricator.wikimedia.org/T89494#1037622 (10Ricordisamoa) 3NEW [20:56:30] (03PS6) 10Cscott: Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 [20:56:32] (03PS7) 10Cscott: Serialize PHP widget state. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [20:56:34] (03PS5) 10Cscott: Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 [20:56:36] (03PS5) 10Cscott: TabIndexedElement: Allow tabIndex property to be null [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 [20:56:38] (03PS8) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [20:57:35] (03CR) 10Cscott: "Ok, all good now." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [20:57:54] (03CR) 10Cscott: "Fixed LabelWidget, updated JS demo." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 (owner: 10Cscott) [20:59:07] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1037649 (10Jdforrester-WMF) 3NEW [21:00:45] chrismcmahon, hello? [21:00:59] hi Krenair [21:01:04] it seems worse than just "no longer appears in diff view" [21:01:04] what do you get instead of the displaytitle syntax? [21:01:38] Krenair: honestly, I didn't track down the consequences of that data failure to appear [21:06:24] (03PS8) 10Cscott: Serialize PHP widget state. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [21:06:26] (03PS9) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [21:07:33] (03CR) 10jenkins-bot: [V: 04-1] Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [21:08:55] (03PS10) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [21:10:56] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1037700 (10TheDJ) although a worthy goal to use oojs-ui, i'd say cleanup TMH itself first :) [21:12:44] (03PS1) 10Cscott: ButtonWidget: rename nofollow property to noFollow [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 [21:14:14] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1037705 (10Jdforrester-WMF) >>! In T89496#1037700, @TheDJ wrote: > although a worthy goal to use oojs-ui, i'd say cleanup TMH itself first :) From IRC, select... [21:16:23] (03CR) 10Jforrester: [C: 04-1] "This is a breaking change, unfortunately, and needs to be tagged as such. :-(" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [21:17:16] James_F: what's the proper way to flag/tag a breaking change? [21:17:27] James_F: I looked at History.md, but it looked automatically-generated to me. [21:17:50] cscott: [BREAKING CHANGE] must be pre-pended to the commit title. [21:17:56] is that all? [21:18:02] Yup. [21:18:07] well, that's easy enough [21:18:11] However, you could make this non-breaking by suppporting both. [21:18:18] And that way we'd be more inclined to merge and release it. [21:18:42] James_F: talk to MatmaRex about that, this is his idea. ;-p [21:19:42] no opinion [21:20:14] cscott: Supporting both nofollow and noFollow would be trivial. We could make nofollow as @deprecated and deal with removing it later if we felt so inclined. [21:21:14] it's just a bunch of bloat for a feature no one other than i have ever used (yet) [21:21:41] and i've only used it in an unmerged patch sitting on gerrit. not 'for real' [21:23:25] cscott: It went out in a release, however. We're a semVer repo. [21:23:25] (03PS2) 10Cscott: [BREAKING CHANGE] ButtonWidget: rename nofollow property to noFollow [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 [21:23:27] (03PS1) 10Cscott: ButtonWidget: backward compatibility for old nofollow property. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190551 [21:24:53] if we're going to break our semver, then we should maybe rename the other properties MatmaRex was cranky about at the same time. [21:25:09] (03CR) 10GOIII: "Q: In patch #2, doesn't the workaround beginning around line 487 make the workaround beginning around line 321 redundant?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189162 (https://phabricator.wikimedia.org/T88875) (owner: 10Brion VIBBER) [21:25:38] Or we could, well, /not/ break the versioning system. :-) [21:28:31] it doesn't seem like jsduck lets you deprecate individual function parameters [21:32:27] 3WikiEditor: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1037713 (10GOIII) Referring to Patch Set 2: * Doesn't the workaround beginning around line 487 make the workaround beginning around line 321 redundant? * ...and shouldn't they be modified to follow the... [21:33:24] cscott: That's entirely plausible, now you say it. [21:34:21] RoanKattouw, hey [21:34:55] (03PS3) 10Cscott: ButtonWidget: rename nofollow property to noFollow [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 [21:35:10] well, ^^ there's the backward-compatible version. i guess that didn't hurt too much. [21:35:20] Hey Krenair [21:35:47] (03Abandoned) 10Cscott: ButtonWidget: backward compatibility for old nofollow property. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190551 (owner: 10Cscott) [21:35:56] RoanKattouw, I mentioned https://phabricator.wikimedia.org/T89383 earlier and it seems like a bit more than just "Display title no longer appears in diff view" [21:36:14] I tried setting a display title on beta and part of the page was duplicated in the diff [21:36:43] Looking [21:36:46] But that sounds very bad [21:36:50] indeed. [21:37:49] 3VisualEditor-MediaWiki, VisualEditor: [Regression pre-wmf18] Options/Advanced settings/Display title no longer appears in diff view - https://phabricator.wikimedia.org/T89383#1037744 (10Krenair) it seems like a bit more than just "Display title no longer appears in diff view" I tried setting... [21:39:41] 3Parsoid, VisualEditor, RESTBase, VisualEditor-Performance: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1037756 (10Jdforrester-WMF) [21:39:47] 3Parsoid, VisualEditor-Performance, VisualEditor: Add original dimensions information from the API to data-mw - https://phabricator.wikimedia.org/T64881#1037761 (10Jdforrester-WMF) [21:39:47] 3Parsoid, VisualEditor-Performance, VisualEditor, RESTBase: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1037760 (10Jdforrester-WMF) [21:39:48] 3Parsoid, VisualEditor-Performance, VisualEditor: Batch Parsoid's API requests - https://phabricator.wikimedia.org/T45888#1037759 (10Jdforrester-WMF) [21:39:56] 3Parsoid, VisualEditor-Performance, VisualEditor: Measure how often Parsoid cache misses happen, and what load performance is like in this case - https://phabricator.wikimedia.org/T86733#1037758 (10Jdforrester-WMF) [21:39:57] 3Parsoid, VisualEditor-Performance, VisualEditor: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1037765 (10Jdforrester-WMF) [21:39:58] 3Parsoid, VisualEditor-Tables, VisualEditor: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#1037764 (10Jdforrester-WMF) [21:39:59] 3Parsoid, VisualEditor-Performance, VisualEditor: Thoughts on element IDs, sections, incremental parsing and fast section editing - https://phabricator.wikimedia.org/T87556#1037762 (10Jdforrester-WMF) [21:40:04] 3Parsoid, VisualEditor-Tables, VisualEditor: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1037770 (10Jdforrester-WMF) [21:40:07] 3Parsoid, VisualEditor, VisualEditor-MediaWiki: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#1037771 (10Jdforrester-WMF) [21:40:12] 3Parsoid, Flow, VisualEditor, RESTBase, VisualEditor-Performance: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#1037776 (10Jdforrester-WMF) [21:41:59] Krenair: I've confirmed that all VE does is add the displaytitle meta tag [21:42:52] can you reproduce the behaviour I saw? [21:45:45] (03PS2) 10Bartosz Dziewoński: docparser: Add support for 'protected' methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190395 [21:45:47] (03PS2) 10Bartosz Dziewoński: testsuitegenerator: Only test every pair of config options rather than every triple [oojs/ui] - 10https://gerrit.wikimedia.org/r/190396 [21:45:49] (03PS1) 10Bartosz Dziewoński: Pass RuboCop, customize settings [oojs/ui] - 10https://gerrit.wikimedia.org/r/190564 [21:46:06] James_F: feel like merging these? ^ [21:47:02] (03CR) 10jenkins-bot: [V: 04-1] testsuitegenerator: Only test every pair of config options rather than every triple [oojs/ui] - 10https://gerrit.wikimedia.org/r/190396 (owner: 10Bartosz Dziewoński) [21:47:04] (03CR) 10jenkins-bot: [V: 04-1] Pass RuboCop, customize settings [oojs/ui] - 10https://gerrit.wikimedia.org/r/190564 (owner: 10Bartosz Dziewoński) [21:47:27] (03CR) 10jenkins-bot: [V: 04-1] docparser: Add support for 'protected' methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190395 (owner: 10Bartosz Dziewoński) [21:47:33] whut [21:49:05] (03PS3) 10Bartosz Dziewoński: docparser: Add support for 'protected' methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190395 [21:49:07] (03PS3) 10Bartosz Dziewoński: testsuitegenerator: Only test every pair of config options rather than every triple [oojs/ui] - 10https://gerrit.wikimedia.org/r/190396 [21:49:09] (03PS2) 10Bartosz Dziewoński: Pass RuboCop, customize settings [oojs/ui] - 10https://gerrit.wikimedia.org/r/190564 [21:50:52] James_F: I think VisualEditor is incorrectly enabled on labs [21:51:05] Runnig through ve init mw init .js step by step shows things are going as they should [21:51:23] The Edit tab missing isn't debug mode specific. If it is, something else is causing it to not fail in non-debug mode [21:51:28] mw.user.options.get( 'visualeditor-enable' ); // -> 0 [21:51:43] defaultUserOptions.enable; -> // 0 [21:51:44] both are 0 [21:51:50] Ah, so that makes sense [21:51:53] VE is not enabled in labs [21:51:58] it loads on that url because veaction=edit [21:52:34] except it obviously is enabled in labs when browsing without debug=true [21:53:02] (03PS4) 10Bartosz Dziewoński: [BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/189499 [21:54:59] James_F: If VE were disabled, naturally the Edit tab wouldn't be modified and veaction serve as override. but it's not (intentionally) disabled in labs. It is actually the default on labs for VE to be disabled, but logged in users can opt in. And you and I have that. [21:55:12] But user.defaults is loading asynchronous (wtf!) in debug mode, so your settings are blown away [21:55:18] Krinkle: Fun. [21:55:27] Not a VE bug :) [21:55:40] Krinkle: Yes, debug mode is broken for prefs [21:55:46] And so user settings aren't respected [21:55:55] Because default settings load after user settings in debug mode [21:55:57] Krinkle: Debug mode is broken by design? [21:56:00] We talked about a way to fix debug mode before [21:56:14] RoanKattouw: Yeah, but dependency resolution should fix that [21:56:21] Except it doesn't [21:56:21] RoanKattouw: options depends on defaults [21:56:29] Yeah, but loading itself is broken [21:56:40] RoanKattouw: Right [21:56:46] Long story short: we inject [21:57:11] Oh yeah [21:57:19] That conversation is exactly what I was thinking about [21:57:32] It's sitting on my desktop [21:58:19] RoanKattouw: we were thinking of appending a callback() since RL works per-file. But since they're all in order, I suppose adding a state() call at the end would work too. [21:58:24] RoanKattouw: Faster, too. [21:58:34] instead of one per script [21:59:34] Yeah exactly [21:59:39] That's actually what I was trying to say at the time [21:59:43] now, what the hell is going on here? James_F: RoanKattouw: http://i.imgur.com/hpfNm3o.png [21:59:59] lolwut? [22:00:00] Ask MatmaRex ? [22:00:01] categories and notice are weird [22:00:12] Does it work in debug=0? [22:01:12] yes [22:01:27] Krinkle: MatmaRex was complaining. [22:01:59] i can't be bothered to debug that, especially since it's only debug=1 [22:02:08] i blame blink being broken as always [22:03:40] hm, ButtonGroupWidget seems to style ButtonInputWidget differently than ButtonWidget. The former is on a line by itself, while the latter is grouped on a single line. [22:04:20] i'm guessing that's not intentional? [22:05:06] (03PS5) 10Bartosz Dziewoński: TextInputWidget: Deprecate 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/189499 [22:05:08] (03PS1) 10Bartosz Dziewoński: [BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/190570 [22:05:26] cscott: yes, a bug, i'm actually fixing it "right now" [22:05:37] * James_F grins. [22:05:38] yay. [22:06:02] cscott: https://gerrit.wikimedia.org/r/#/c/189360/ exhibits the issue too [22:07:30] i checkde it out and got distracted by things being broken all over [22:07:34] Any chance you have a Change-Id for the fix? [22:07:53] i will have it in ten minutes when i write it [22:08:13] (03PS2) 10Kmenger: ButtonElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190499 [22:08:15] (03PS1) 10Kmenger: ButtonInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190572 [22:09:19] MatmaRex: ok, i put a WIP in the title of https://gerrit.wikimedia.org/r/187079 for now, then. [22:09:23] (03CR) 10jenkins-bot: [V: 04-1] ButtonInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190572 (owner: 10Kmenger) [22:11:48] Nice editor snafu Archive.org! https://blog.archive.org/2015/02/11/locking-the-web-open-a-call-for-a-distributed-web/ - JAVAScript (spelling) / with a picture of the infamous Java-coffee loader, captioned "JavaScript". >< [22:13:47] (03PS1) 10Bartosz Dziewoński: Add missing ButtonInputWidget.less and corresponding mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/190574 (https://phabricator.wikimedia.org/T87546) [22:13:58] cscott: ^ [22:14:15] what'd you find with that displaytitle thing RoanKattouw? [22:17:21] (03CR) 10Cscott: [C: 031] Add missing ButtonInputWidget.less and corresponding mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/190574 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński) [22:21:12] (03PS3) 10Bartosz Dziewoński: Add horizontal alignment test to demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) [22:22:21] Krinkle: Ha. [22:24:55] Krenair: Sorry I was wrapping up a meeting [22:25:03] Krenair: I found that all VE is doing is adding a tag, we're not doing anything weird [22:25:13] right, but what comes out in the diff? [22:25:16] Now let me see if I have easy repro steps for Parsoid [22:26:55] I still haven't worked out whether you saw the same issue as I did [22:28:14] 3OOjs-UI: OOjs UI fields are not uniform height - https://phabricator.wikimedia.org/T87546#1037942 (10matmarex) Here's how the demo looks with the two patches above. Assuming we want to match the size in both themes, do we want to make the dropdowns smaller or the textboxes bigger? **Apex theme:** JS: {F40790,... [22:29:34] (03CR) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 (owner: 10Bartosz Dziewoński) [22:29:37] (03CR) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [22:31:41] (03PS2) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 [22:31:43] (03PS5) 10Bartosz Dziewoński: [BREAKING CHANGE] Remove deprecated LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) [22:32:17] (03CR) 10Mooeypoo: [C: 031] "RTL tests with diacritics and directionality changes look good, but I would also give this to someone who can work with more complex scrip" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [22:32:18] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1037956 (10Tgr) jQUI is ~200K minified/uncompressed, OOUI is 300K, so as long as OOUI is not included on every page this will actually increase the payload. I... [22:32:41] (03PS4) 10Bartosz Dziewoński: demo: Add horizontal alignment test [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) [22:36:59] 3VisualEditor: Media Settings: search is not terminated- input box keeps displaying waiting animation - https://phabricator.wikimedia.org/T89303#1037971 (10Etonkovidova) Checked the fix in betalabs. [22:37:10] Krenair: I saw (almost?) all of the page contents being duplicated [22:37:19] okay [22:37:28] (03CR) 10Bartosz Dziewoński: "> I took a quick look, and I can't see much difference with before (which i think was also the intent)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [22:38:00] 3VisualEditor-MediaWiki, VisualEditor: [Regression pre-wmf18] Options/Advanced settings/Display title causes duplicate of parts of the page, does not insert displaytitle - https://phabricator.wikimedia.org/T89383#1037972 (10Krenair) [22:38:09] 3VisualEditor-MediaWiki, VisualEditor: [Regression pre-wmf18] Options/Advanced settings/Display title causes duplication of parts of the page, does not insert displaytitle - https://phabricator.wikimedia.org/T89383#1035060 (10Krenair) [22:38:58] Confirmed in Parsoid, appears to be a problem specific to selser [22:39:00] I'll file a bug [22:39:51] we have a task [22:39:56] you could tag it against parsoid [22:40:31] Where? [22:40:38] T89383? [22:41:12] yes [22:41:28] OK yeah I'll repurpose that one [22:46:33] 3MediaWiki-ResourceLoader: ResourceLoaderImage missing file - https://phabricator.wikimedia.org/T89505#1037987 (10Chad) 3NEW [22:46:54] 3MediaWiki-ResourceLoader: ResourceLoaderImage missing file - https://phabricator.wikimedia.org/T89505#1037994 (10Chad) [22:48:13] 3MediaWiki-ResourceLoader: ResourceLoaderImage missing file - https://phabricator.wikimedia.org/T89505#1037999 (10greg) p:5Triage>3High [22:48:39] 3MediaWiki-ResourceLoader: ResourceLoaderImage missing file - https://phabricator.wikimedia.org/T89505#1038001 (10matmarex) I would like to point out that this code specifically special-cases rsvg and thus like 348 shouldn't be executed in WMF production at all. Why is it being executed? [22:50:02] (03PS6) 10Bartosz Dziewoński: Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) [22:51:11] (03PS2) 10Kmenger: ButtonInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190572 [22:51:19] (03CR) 10jenkins-bot: [V: 04-1] Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88082) (owner: 10Bartosz Dziewoński) [22:51:38] 3MediaWiki-ResourceLoader: ResourceLoaderImage missing file - https://phabricator.wikimedia.org/T89505#1038015 (10Krenair) So in ResourceLoaderImage::rasterize we create a file and store it's name in $tempFilenamePng, which we then assume to exist afterwards, and try to call file_get_contents. Except in this ca... [22:53:04] 3VisualEditor: Media Settings: search is not terminated- input box keeps displaying waiting animation - https://phabricator.wikimedia.org/T89303#1038017 (10Etonkovidova) 5Open>3Resolved [22:55:19] (03PS7) 10Bartosz Dziewoński: Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88906) [22:56:11] (03CR) 10jenkins-bot: [V: 04-1] ButtonInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190572 (owner: 10Kmenger) [22:57:22] 3MediaWiki-ResourceLoader: ResourceLoaderImage missing file - https://phabricator.wikimedia.org/T89505#1038024 (10Krenair) >>! In T89505#1038001, @matmarex wrote: > I would like to point out that this code specifically special-cases rsvg and thus like 348 shouldn't be executed in WMF production at all. Why is it... [23:00:30] 3VisualEditor-MediaWiki, VisualEditor: [Regression pre-wmf18] Options/Advanced settings/Display title causes duplication of parts of the page, does not insert displaytitle - https://phabricator.wikimedia.org/T89383#1038028 (10Catrope) This is a bug in Parsoid, specifically in selser. When you add ` 3VisualEditor-MediaWiki, Parsoid, VisualEditor: Regression: Selser duplicates entire page when displaytitle is added - https://phabricator.wikimedia.org/T89383#1038032 (10Catrope) [23:04:42] James_F: Page settings dialog for Redirect has a regression. Checkbox is not ticked, yet it thinks it's active. When editing an existing redirect. (mediawiki.org) http://i.imgur.com/00GAXsD.png [23:05:36] Krinkle: there wasa general problem with all checkboxes [23:05:41] esp in Safari [23:05:51] Chrome 42 [23:06:01] ok, loking... [23:07:34] Krinkle; chrome 40 looks ok hmm... [23:11:52] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1038055 (10matmarex) >>! In T89496#1037705, @Jdforrester-WMF wrote: > ``` > ori: that's 300kb of javascript on barack obama for the media player http://i.imgur... [23:12:03] etonkovidova: https://www.mediawiki.org/wiki/JSPERF?veaction=edit [23:12:19] Chrome 40 (stable) and 42 (canary), both no checked checkbox for Redirect [23:14:08] Krinkle: I see the problem - yes I ssupect it's a manifestation of of the problem that it's more apparent in Safari [23:14:57] etonkovidova: I can reproduce the same visual on Safari and Firefox. [23:15:20] Text field is filled in, "Redirect this page" checkbox unticked. [23:15:27] Krinkle: right [23:15:44] Which general problem? [23:16:12] go to Safari - check boxes cannot be checked [23:17:06] etonkovidova: Ah, interesting. [23:17:14] etonkovidova: YEah,in Chrome they can be checked when clicked [23:17:16] exactly :) [23:17:44] Krinkle: https://phabricator.wikimedia.org/T89309 [23:18:11] etonkovidova: I think the issues are unrelated. [23:18:38] ok, the I file a separate bug. [23:18:38] (03CR) 10Jforrester: "What is this trying to demonstrate?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński) [23:18:44] Thanks :) [23:19:02] Krinkle: let me try couple of things before filing [23:21:03] RoanKattouw, $result['editsection']['query']['editingStatsId'] = self::getEditingStatsId(); [23:21:12] imagine that with DoEditSectionLink :) [23:22:18] (03CR) 10Bartosz Dziewoński: "It's demonstrating how the widgets behave when given `display: inline-block` and placed inline, which is a supported use-case." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński) [23:22:53] Krinkle: etonkovidova: i'm fairly sure i fixed that recently [23:23:01] try on beta labs? [23:23:25] (the check boxes not being clickable) [23:23:29] Matmarex: I was trying it in betalbs :) well, let me refresh :) [23:23:36] Krenair: Nice :) [23:24:00] ah, okay, please file that then. :/ [23:24:21] RoanKattouw, one thing I don't like about this is the way I have to krsort in VE to handle wgVisualEditorTabPosition [23:24:59] which could produce a funny order if some other extension was involved [23:25:13] (03PS1) 10Kmenger: Dialog: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190594 [23:26:09] I guess we could have a wfArrayInsertBefore. [23:27:00] Matmarex: Krinkle - not fixed in Safari, ar least [23:27:39] Krinkle: still the issue in chrome looks like Safari - safari is worst, of course, but... [23:28:25] Matmarex:It does happen in Betalabs, when you have already set a target redirect page once and re-open that page with VE, which is the case for this page:https://www.mediawiki.org/wiki/JSPERF?veaction=edit [23:28:37] etonkovidova: All browsers initialise the Redirect dialog without the initial checked value. But other checkboxes work fine in other browsers, including the redirect checkbx works fine in non-Safari. In Safari, all checkboxes (not just redirect) are broken and can't be enabled. [23:29:11] Krinkle: right - I do not argue that [23:29:40] So there's a general bug (not related to browser) of the redirect value not being used the first time (probably a data model issue). And then there's a Safari bug where the user interface can't check any checkboxes. [23:30:05] (03CR) 10Jforrester: "> > What is this trying to demonstrate?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński) [23:30:36] Krinkle: oh, right right sorry - I was not checking actual redirection [23:32:53] RoanKattouw, does https://gist.github.com/Krenair/6d5165a8c8d721547a69 seem reasonable? [23:33:26] If so I'll upload it for review [23:34:26] (03CR) 10Bartosz Dziewoński: [C: 032] TabIndexedElement: Allow tabIndex property to be null [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [23:35:43] (03Merged) 10jenkins-bot: TabIndexedElement: Allow tabIndex property to be null [oojs/ui] - 10https://gerrit.wikimedia.org/r/190365 (owner: 10Cscott) [23:36:51] (03CR) 10Bartosz Dziewoński: [C: 032] Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 (owner: 10Cscott) [23:37:12] (03PS6) 10Bartosz Dziewoński: Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 (owner: 10Cscott) [23:37:14] (03CR) 10jenkins-bot: [V: 04-1] Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [23:37:19] (03CR) 10Bartosz Dziewoński: [C: 032] Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 (owner: 10Cscott) [23:37:44] (03PS7) 10Bartosz Dziewoński: Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [23:37:55] (03CR) 10Bartosz Dziewoński: [C: 032] Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [23:39:03] (03Merged) 10jenkins-bot: Various fixes to the PHP implementation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190364 (owner: 10Cscott) [23:40:59] (03PS9) 10Jforrester: Serialize PHP widget state. [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:41:27] (03PS10) 10Jforrester: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:43:11] (03CR) 10Jforrester: "Not totally enthused and 'infusable' as a name, but…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:44:13] (03CR) 10jenkins-bot: [V: 04-1] Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [23:44:38] (03CR) 10Jforrester: [C: 032] Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [23:45:54] (03Merged) 10jenkins-bot: Use Array.isArray instead of $.isArray [oojs/ui] - 10https://gerrit.wikimedia.org/r/190366 (owner: 10Cscott) [23:47:44] (03CR) 10Kmenger: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190572 (owner: 10Kmenger) [23:49:41] 3VisualEditor: [Regression wmf17]'Redirect this page to' checkbox is unchecked with pre-filled 'Target page for redirection' - https://phabricator.wikimedia.org/T89511#1038148 (10Etonkovidova) 3NEW [23:49:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Please keep the PHP demo in sync. Also, see inline." (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 (owner: 10Esanders) [23:50:31] (03CR) 10Bartosz Dziewoński: "Maybe we should use white icons in MediaWiki theme? Compare: https://gerrit.wikimedia.org/r/#/c/189945/" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 (owner: 10Esanders) [23:51:14] 3MediaWiki-Vagrant, VisualEditor: i18n strings broken in VisualEditor in Vagrant - https://phabricator.wikimedia.org/T89476#1038158 (10Jdforrester-WMF) They load fine for me… [23:53:33] (03PS1) 10Kmenger: DraggableElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190600 [23:53:50] (03PS2) 10Bartosz Dziewoński: Use margins for moving TextInputWidget label [oojs/ui] - 10https://gerrit.wikimedia.org/r/190435 (owner: 10Esanders) [23:54:10] (03PS3) 10Bartosz Dziewoński: TextInputWidget: Use margins for moving the label [oojs/ui] - 10https://gerrit.wikimedia.org/r/190435 (owner: 10Esanders) [23:54:14] (03CR) 10Bartosz Dziewoński: [C: 032] TextInputWidget: Use margins for moving the label [oojs/ui] - 10https://gerrit.wikimedia.org/r/190435 (owner: 10Esanders) [23:55:28] (03Merged) 10jenkins-bot: TextInputWidget: Use margins for moving the label [oojs/ui] - 10https://gerrit.wikimedia.org/r/190435 (owner: 10Esanders) [23:57:34] (03PS2) 10Bartosz Dziewoński: [BREAKING CHANGE] Rename setPosition to setLabelPosition [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 (owner: 10Esanders) [23:57:46] 3VisualEditor-MediaWiki-Media, VisualEditor: Media Advanced settings help icons are misaligned - https://phabricator.wikimedia.org/T89465#1038172 (10Jdforrester-WMF) 5Open>3Resolved [23:57:59] (03PS3) 10Bartosz Dziewoński: [BREAKING CHANGE] TextInputWidget: Rename #setPosition to #setLabelPosition [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 (owner: 10Esanders)