[00:06:41] 3Multimedia, MediaWiki-extensions-TimedMediaHandler, OOjs-UI: Replace use of deprecated jQuery UI with OOjs UI - https://phabricator.wikimedia.org/T89496#1038190 (10TheDJ) TMH is like UploadWizard. Tinker on one end, and it breaks on the other. [00:06:55] 3VisualEditor: Make slugs keyboard accessible again - https://phabricator.wikimedia.org/T89352#1038192 (10Jdforrester-WMF) p:5Triage>3High [00:08:06] 3OOjs-UI, VisualEditor: [Regression wmf-17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1033117 (10Jdforrester-WMF) [00:08:46] 3VisualEditor-ContentEditable, VisualEditor: Unable to add a video as media - https://phabricator.wikimedia.org/T88925#1038197 (10Jdforrester-WMF) 5stalled>3declined a:3Jdforrester-WMF Provisionally declining; if you can replicate, please re-open. [00:09:13] 3Quality-Assurance, VisualEditor, VisualEditor-MediaWiki: Update language_screenshot test - https://phabricator.wikimedia.org/T89370#1038201 (10Jdforrester-WMF) p:5Triage>3Normal [00:10:08] (03CR) 10Krinkle: [C: 04-1] Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [00:12:18] (03PS1) 10Catrope: Rename test modules to stop confusing QUnit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190603 [00:12:22] (03PS1) 10Kmenger: DraggableGroupElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190604 [00:12:29] There goes cleanup commit 1 of ~8 [00:12:31] :) [00:12:32] RoanKattouw: https://phabricator.wikimedia.org/T87160 [00:13:00] Shall I just upload my core patch and see what others say then RoanKattouw? [00:13:34] Krenair: Sorry, missed your ping earrlier [00:14:23] Krenair: Looks fine to me, the only thing I wonder is why is $section treated specially [00:14:33] Rather than being part of $result['attribs'] [00:14:38] I guess it's because it has a default value? [00:15:39] it's applicable to all links [00:15:55] we shouldn't have to pull it out of $result['editsection']['attribs']['section'] [00:16:36] Right [00:16:37] (03PS1) 10Catrope: Fix typos in ve.dm.example.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190605 [00:16:43] Because you'd have to iterate over all links as well [00:16:47] That's sensible [00:17:24] Krenair: Yeah I'd say throw it in Gerrit, see what MW core people say [00:17:37] I'm not really an MW core person any more so I can't comment as well as I could have a few years ago [00:17:50] okay [00:17:52] :( [00:21:25] (03CR) 10Jforrester: [C: 032] Rename test modules to stop confusing QUnit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190603 (owner: 10Catrope) [00:22:22] (03CR) 10Jforrester: [C: 032] Fix typos in ve.dm.example.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190605 (owner: 10Catrope) [00:23:06] (03Merged) 10jenkins-bot: Rename test modules to stop confusing QUnit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190603 (owner: 10Catrope) [00:24:10] (03Merged) 10jenkins-bot: Fix typos in ve.dm.example.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190605 (owner: 10Catrope) [00:24:32] I couldn't remember the way to mark hooks deprecated RoanKattouw, but https://gerrit.wikimedia.org/r/#/c/190607/1 [00:25:02] I don't know how to do that either [00:26:02] so I just left a comment in docs/hooks.txt [00:26:27] I imagine someone will be along to -1 it for that and make me look stupid at some point :p [00:26:35] 3VisualEditor-Performance, VisualEditor: ~200ms spent on CSSStyleDeclaration.getPropertyValue() due to jQuery hide()/show() - https://phabricator.wikimedia.org/T87160#1038218 (10Catrope) >>! In T87160#1035744, @ori wrote: > Still seeing this: > > {F40531} > > > (On osmium's Barack Obama, all repos on HEAD) T... [00:28:32] Oh but of course jenkins is first [00:31:50] Ugh, mediawiki preferences are shit [00:31:51] ["visualeditor-enable"] => string(0) "" [00:31:51] ["visualeditor-betatempdisable"] => string(1) "1" [00:31:52] ["visualeditor-enable"] => int(1) [00:31:54] ["visualeditor-betatempdisable"] => int(0) [00:32:14] So much for consistency [00:32:18] default values are kept as-is. [00:32:22] Database values are always strings [00:37:30] 3VisualEditor: Referenced footnote not displayed correctly in VE using Chrome 28 on Win 7 =========================================================== Re-checking - no re-numbering happens anymore. The discrepncy in display of such references in VE and Read mode(and Reference list) is described below(also see the a... [00:38:27] 3VisualEditor: Referenced footnote not displayed correctly in VE using Chrome 28 on Win 7 - https://phabricator.wikimedia.org/T54262#574817 (10Etonkovidova) [00:38:52] https://phabricator.wikimedia.org/T89513 [00:38:55] 3VisualEditor: Referenced footnote not displayed correctly in VE using Chrome 28 on Win 7 - https://phabricator.wikimedia.org/T54262#574817 (10Etonkovidova) [00:50:41] Krinkle: known bug [00:52:44] https://phabricator.wikimedia.org/T54542 [00:53:07] (03PS1) 10Catrope: Make newFromAnnotation test construct doc2 from data, not HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190617 [01:00:33] MatmaRex: There are a few prefs that do normalise to pure booleans and integers [01:00:38] there's a filter for them in the Preferences class [01:01:06] I guess we could tie something into the 'type' [01:01:11] e.g. toggle -> filter boolean [01:05:59] (03PS2) 10Catrope: [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 [01:07:10] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 (owner: 10Catrope) [01:08:14] 3VisualEditor-CopyPaste, VisualEditor: Using keyboard shortcuts (in multiple browsers) or the "Open menu" (in Firefox only) to copy a paragraph and a reference together causes selected content to be deleted (not cut) instead - https://phabricator.wikimedia.org/T89025#1038363 (10Jdforrester-WMF) [01:08:15] 3VisualEditor-CopyPaste, VisualEditor: Ctrl+C copying of text with template removes text in FF - https://phabricator.wikimedia.org/T86921#1038362 (10Jdforrester-WMF) [01:08:20] (03PS2) 10Catrope: [WIP] Don't animate the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189776 [01:08:26] 3VisualEditor-CopyPaste, VisualEditor: Ctrl+C copying of text with template removes text in FF - https://phabricator.wikimedia.org/T86921#979507 (10Jdforrester-WMF) [01:10:17] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Using browser native interactive spell-check tool causing repeated automatic deletion in Chrome - https://phabricator.wikimedia.org/T65462#1038381 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Agreed, we've fixed this. [01:19:42] 3VisualEditor-EditingTools, VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node in Firefox - https://phabricator.wikimedia.org/T70537#1038419 (10Jdforrester-WMF) [01:27:45] (03PS1) 10Catrope: Remove useless getDataElementFromDomElement / getDomElementsFromDataElement tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190620 [01:45:06] (03PS1) 10Catrope: DomFromModelTest: Call modify() on the document, not the data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190622 [01:45:13] (03PS1) 10Catrope: Update for Ifcef8eb56f28 in VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190623 [01:46:46] (03CR) 10jenkins-bot: [V: 04-1] Update for Ifcef8eb56f28 in VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190623 (owner: 10Catrope) [01:49:24] (03PS1) 10Catrope: Inline ve.ce.View#renderAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190625 [01:50:38] 3Parsoid, VisualEditor-Performance, VisualEditor, RESTBase: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1038487 (10Jdforrester-WMF) Note that this was accepted with provisions; it's unclear how adding the data-mw API call to the... [01:50:49] (03CR) 10jenkins-bot: [V: 04-1] Inline ve.ce.View#renderAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190625 (owner: 10Catrope) [01:51:52] 3Parsoid, VisualEditor-Performance, VisualEditor: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1038499 (10Jdforrester-WMF) So, what is the ask here? Trivially, piping an HTTP request through PHP is go... [01:53:40] 3VisualEditor-Initialisation, VisualEditor-Performance, VisualEditor: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#1038503 (10Jdforrester-WMF) This is really a tracker bug more than a specific call-to-action, so we decided in the meeting to remove it from the Q... [01:53:45] 3VisualEditor-Initialisation, VisualEditor-Performance, VisualEditor: Improve VisualEditor's loading performance in Firefox - https://phabricator.wikimedia.org/T52616#1038504 (10Jdforrester-WMF) [01:55:44] 3VisualEditor-Tables, VisualEditor-ContentEditable, VisualEditor: VisualEditor: Tab/Shift-Tab behaviour in other contexts (and tables) - https://phabricator.wikimedia.org/T72665#1038507 (10Jdforrester-WMF) This is a nice-to-have feature but it isn't critical to any of the common edit workflows for the user group... [01:56:14] 3VisualEditor-Tables, VisualEditor-ContentEditable, VisualEditor: Tab/Shift-Tab behaviour in contexts other than list indent/outdent (//e.g.// tables) - https://phabricator.wikimedia.org/T72665#1038508 (10Jdforrester-WMF) [01:56:22] 3VisualEditor-Tables, VisualEditor-ContentEditable, VisualEditor: Tab/Shift-Tab behaviour in contexts other than list indent/outdent (e.g. tables) - https://phabricator.wikimedia.org/T72665#755967 (10Jdforrester-WMF) [01:57:35] 3VisualEditor-ContentEditable, VisualEditor: Up/down keys in table when you've selected a cell move left/right instead - https://phabricator.wikimedia.org/T67589#1038512 (10Jdforrester-WMF) [01:58:01] 3VisualEditor-ContentEditable, VisualEditor: Up/down keys in table when you've selected a cell move left/right instead - https://phabricator.wikimedia.org/T67589#686090 (10Jdforrester-WMF) This is a nice-to-have feature but it isn't critical to any of the common edit workflows for the user groups targeted right... [01:58:04] (03PS1) 10Mooeypoo: Focus the input when the dialog is ready [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190627 [01:58:07] 3VisualEditor-ContentEditable, VisualEditor: Up/down keys in table when you've selected a cell move left/right instead - https://phabricator.wikimedia.org/T67589#1038515 (10Jdforrester-WMF) [01:59:39] 3VisualEditor-Performance, VisualEditor-DataModel, VisualEditor: Reduce VisualEditor's memory usage - https://phabricator.wikimedia.org/T55825#1038518 (10Jdforrester-WMF) This is a high-level tracker bug rather than a blocker; it needs child bugs with more specifics to be nominated as blockers. Consequently, we... [01:59:45] 3VisualEditor-Performance, VisualEditor-DataModel, VisualEditor: Reduce VisualEditor's memory usage - https://phabricator.wikimedia.org/T55825#1038519 (10Jdforrester-WMF) [02:00:40] 3VisualEditor-EditingTools, VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1038524 (10Jdforrester-WMF) [02:01:03] (03PS1) 10Catrope: ve.dm.ElementLinearData: Remove unused rules.removeStyles feature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190628 [02:02:29] (03CR) 10jenkins-bot: [V: 04-1] ve.dm.ElementLinearData: Remove unused rules.removeStyles feature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190628 (owner: 10Catrope) [02:02:46] 3VisualEditor-EditingTools, VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - https://phabricator.wikimedia.org/T53798#1038526 (10Jdforrester-WMF) We disagree with the premise; instead, there should only be help links where they are useful to explain the complexity of a... [02:04:54] 3VisualEditor-MediaWiki-Links, VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1038537 (10Jdforrester-WMF) As a product decision, we decided to remove this as a blocker to the release, and instead focus on the citation improvements first before taking this on. Consequ... [02:05:02] 3VisualEditor-MediaWiki-Links, VisualEditor: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1038538 (10Jdforrester-WMF) [02:08:32] (03PS2) 10Catrope: Inline ve.ce.View#renderAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190625 [02:08:42] (03PS2) 10Catrope: ve.dm.ElementLinearData: Remove unused rules.removeStyles feature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190628 [02:10:27] 3OOjs-UI, VisualEditor: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1038556 (10Jdforrester-WMF) As a product decision, we decided to remove this as a blocker to the release; instead, this potentially will be part of our polish effort instead. Consequentl... [02:10:33] 3OOjs-UI, VisualEditor: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1038557 (10Jdforrester-WMF) [02:21:27] (03PS2) 10Catrope: DomFromModelTest: Call modify() on the document, not the data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190622 [02:22:01] (03PS3) 10Catrope: Inline ve.ce.View#renderAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190625 [02:22:21] (03PS3) 10Catrope: ve.dm.ElementLinearData: Remove unused rules.removeStyles feature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190628 [02:22:48] 3VisualEditor-Performance, VisualEditor: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#1038583 (10Jdforrester-WMF) [02:28:16] 3VisualEditor-EditingTools, VisualEditor: Cite: unexpected behavior attempting multiple citations (e.g. first Website, then Book) - https://phabricator.wikimedia.org/T71483#1038585 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF I don't think this is worth adding an interstitial for. [02:30:20] 3VisualEditor: Referenced footnote not displayed correctly in VE using Chrome 28 on Win 7 - https://phabricator.wikimedia.org/T54262#1038589 (10Jdforrester-WMF) [02:30:45] 3VisualEditor-MediaWiki-Links, VisualEditor: Cite backlinks turn from alpha to numeric - https://phabricator.wikimedia.org/T89413#1038592 (10Jdforrester-WMF) [02:31:02] 3VisualEditor-MediaWiki-Links, VisualEditor: Cite backlinks turn from alpha to numeric - https://phabricator.wikimedia.org/T89413#1035637 (10Jdforrester-WMF) This will be fixed once {T53245} is complete. [02:32:55] 3VisualEditor: Odd result: Subst'd template, or converted to HTML, or ??? - https://phabricator.wikimedia.org/T89163#1038606 (10Jdforrester-WMF) [02:32:56] 3VisualEditor-CopyPaste, VisualEditor: Cutting and pasting a paragraph causes (only) the last inline template to be replaced by HTML - https://phabricator.wikimedia.org/T86401#1038607 (10Jdforrester-WMF) [02:33:16] 3VisualEditor-CopyPaste, VisualEditor: Cutting and pasting a paragraph causes (only) the last inline template to be replaced by HTML - https://phabricator.wikimedia.org/T86401#1038612 (10Jdforrester-WMF) p:5Normal>3High [02:34:58] 3VisualEditor-ContentEditable, VisualEditor: VisualEditor: Node action icon (e.g. for template) appearing in wrong location - https://phabricator.wikimedia.org/T53548#1038614 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF >>! In T53548#1034742, @Elitre wrote: > I think this is still happening. See... [02:35:13] 3VisualEditor-ContentEditable, VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - https://phabricator.wikimedia.org/T52036#1038619 (10Jdforrester-WMF) [02:35:41] 3VisualEditor-ContentEditable, VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - https://phabricator.wikimedia.org/T52036#556659 (10Jdforrester-WMF) [02:43:41] 3VisualEditor-Performance, VisualEditor: Instrument (i.e., track) additional progress markers for VE load - https://phabricator.wikimedia.org/T89536#1038627 (10ori) 3NEW a:3Catrope [02:46:19] 3VisualEditor-Performance, VisualEditor: Instrument (i.e., track) additional progress markers for VE load - https://phabricator.wikimedia.org/T89536#1038636 (10ori) p:5Normal>3High [02:48:14] (03PS1) 10Krinkle: mw.ViewPageTarget: Remove workaround for cascading defaultUserOptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190630 [02:48:25] RoanKattouw: ^ Yay :) [02:49:14] (03CR) 10Krinkle: "Be sure to test/verify the different preferences combinations, and with regards to T89513." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190630 (owner: 10Krinkle) [02:49:23] 3OOjs-UI: TextInputLabel is visible when not in use - https://phabricator.wikimedia.org/T89431#1038642 (10matmarex) 5Open>3Resolved [02:51:52] (03CR) 10Bartosz Dziewoński: mw.ViewPageTarget: Remove workaround for cascading defaultUserOptions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190630 (owner: 10Krinkle) [03:11:37] (03PS16) 10Catrope: [WIP] Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [03:14:59] 3Parsoid, VisualEditor-Performance, VisualEditor, RESTBase: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1038691 (10GWicke) @jdforrester-wmf, the main speed-up for VE would come from using Parsoid HTML for views, which in turn req... [03:18:14] (03PS17) 10Catrope: [WIP] Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [03:21:03] (03PS2) 10Krinkle: mw.ViewPageTarget: Remove workaround for cascading defaultUserOptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190630 [03:21:18] (03CR) 10Krinkle: mw.ViewPageTarget: Remove workaround for cascading defaultUserOptions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190630 (owner: 10Krinkle) [03:25:14] 3Parsoid, VisualEditor-Performance, VisualEditor: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1038704 (10GWicke) @jdforrester-wmf: My original measurements indicated a significantly larger performanc... [03:39:00] Krinkle: has VE / OOUI.js thought about dancing around requestAnimationFrame, like FastDom does? [03:40:03] basically, did we consider batching DOM read / writes? [03:41:45] milimetric: I've thought about it [03:43:13] did you consider it potentially useful or of no real benefit? [03:43:24] milimetric: At the moment, we're doing higher-level clean up first (removing code that should be in CSS instead, removing dead code, optimising the logic itself in code that runs a lot etc.) [03:43:43] milimetric: I've considered FastDom for other projects personally. I think the benefit is minimal in higher quality code. [03:44:14] And making all DOM actions asynchronous doesn't seem all that beneficial. It can actually make it harder for the browser to optimise reflows. [03:44:45] reordering code to touch the DOM less often in general, and manually grouping related read/writes is a lot easier and requires less effort to achieve. [03:45:13] hm, i don't know about less effort, but i agree with the rest [03:45:15] If statements depend on each other in order, they can't be re-ordered as it would break. And it they can be re-ordered, then they can just be re-ordered directly. [03:45:36] milimetric: Changing all dom actions to be wrapped in a fastdom/read/write is a lot of abstraction and extra code. [03:45:39] the key thing is that grouping read/writes is one thing, and making them sync up with frames is another [03:45:48] it's not automatically detecting what is a read and write, that's to the developer to flag. [03:45:54] well, yeah, if your read/writes are all over the place [03:45:56] At which point you might as well just to it right. [03:46:14] in the case of knockout or other frameworks for example it seems possible to write extenders or single points where it's done generally [03:46:42] but it's hard for me to reason without concrete examples [03:46:52] i'm going to play with it this weekend, I'll let you know if I find anything earth shattering [03:46:58] I figured if anyone messed with it, it'd be you :) [03:46:59] cool [03:47:11] milimetric: Wait, you're dan. [03:47:16] yes [03:47:16] Hi Dan :) [03:47:19] hi Timo [03:47:30] you still in SF? [03:47:47] I don't think Iv'e spoken with you before on IRC. At least not knowingly knowing it was you. [03:47:53] nah, I got back last sunday [03:47:56] London [03:48:04] cool, wow - late! [03:48:19] Yeah, I stayed an extra week [03:48:24] yeah, we spoke before, but I have that feeling too - IRC and RL are disconnected [03:48:56] So yeah, fastdom is primarily beneficial (in theory anyway) if you have large amounts of unconnected code (separate concerns/responsibilities) that have to do their own read/writes. [03:49:03] e.g. not something you can re-order within one class or function. [03:49:07] I agree about the higher level stuff btw. According to the data I'm gathering there interesting things to examine at the highest level: http://tools-static.wmflabs.org/wikimetrics/ve.html [03:49:15] (no critique of the code allowed, it's just a prototype) [03:49:17] There's a lot of low hanging fruit. [03:50:13] We can file the nails later, but cut of the big chunks first [03:50:16] yeah, well, I'm interested in fastdom for a specific use case. In knockout there are "extenders". So when you do: [03:50:18] :D [03:50:32] cut off* [03:50:41] a = ko.computed(function () { /* this sets up a dependency */ }); [03:50:52] when the things that a depends on change, a() changes [03:51:08] so if you don't want that to kill your DOM, because it happens synchronously, you do this: [03:51:10] propagation [03:51:26] a = ko.computed(function () { /* this sets up a dependency */ }).extend({rateLimit: 10}); [03:51:36] and then it waits 10 milis before synchronizing to the dom [03:51:42] milimetric: Hm.. the same wiki code is repeated like 20 times in that dropdown menu [03:51:52] and you can make a special computed like a "fastComputed" that just always uses an extender [03:52:03] so... it's trivial to replace that extender with one that uses fastDom [03:52:29] ha! that's new... [03:52:37] thx, i'll fix that [03:53:30] I forgot about fastdom though, thanks for the heads up [03:53:42] I last looked into it when Paul Irish popularised it back in 2013 [03:54:02] yeah, he's got a few interesting posts I'm re-reading. React.js made me look at it again [03:54:22] I really dislike how they stick HTML in that awful jsx stuff [03:54:22] ew [03:54:28] milimetric: http://ractivejs.org/ is also interesting. [03:54:32] but their ideas on dom diffing are great [03:54:39] milimetric: It's like mustache, but with the power of knockout [03:54:48] but without the nasty unimaginative syntax [03:55:07] whos' to say you need to squish things in attributes to do bindings. It's not like allowing invalid HTML syntax is a feature. [03:55:25] So disallow that feature and you've got the ability to do bindings [03:55:47] two-way [03:55:59] yeah, I imagine React.js devs feel the same way about their weird JSX as I feel about the knockout bindings [03:56:23] those are like 10% of knockout, and the cool stuff comes in how extensible the dependency management system is [03:56:26] 3§Collaboration-Team, Flow, WikiEditor, VisualEditor: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1038747 (10Mattflaschen) >>! In T78346#1026966, @Quiddity wrote: > Separately, I know there is some amount of local customization of the WikiEditor Toolbar but... [03:56:30] I did look at Ractive, pretty closely [03:56:40] and yeah, it solves in some ways the syntax issues people have with knockout [03:56:56] but it's not nearly as nice of a dependency tracking system [03:57:05] It's a choice. [03:57:12] I think it's very good at what it does. [03:57:31] I haven't made a larger project with Angular or Knockout, but I feel it won't fit in realistically. [03:57:32] it's ok, on a scale of one to knockout it's like 7.5 [03:57:33] :) [03:57:46] It tries to take over too much. And fails at both in practice. [03:57:57] angular is way monolithic for me, knockout is the exact opposite [03:58:08] Yeah, it's more extendable [03:58:14] but that would mean you decide to extend it [03:58:22] i'll have to have a real in depth tech talk at some point where I go over stuff. Maybe when I figure how to use fastDom with it [03:58:37] Rewriting everything as Knockout extension. Which is fine if it's flexible enough. [03:58:43] It's a tough call without more data [03:58:45] and practice [03:59:06] well we wrote a serious dashboarding prototype with knockout components [03:59:13] it's by far the best experience i've had in web dev so far [03:59:27] milimetric: I rewrote https://www.mediawiki.org/wiki/JSPERF recently. Lots of new talks and resources I found recently (and Gabriel too!) [03:59:32] Give it a look :) [03:59:52] oh cool, will do [04:00:02] thx [04:06:42] (03Abandoned) 10Mattflaschen: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 (owner: 10Paladox) [04:07:32] (03Restored) 10Mattflaschen: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [04:23:21] (03CR) 10Mattflaschen: Convert .css to .less (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [04:23:30] (03CR) 10Mattflaschen: Convert .css to .less (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [04:38:46] (03CR) 10Mattflaschen: [C: 04-1] "First, you need to learn LESS better. Find a good tutorial or book. You are still making basic mistakes like https://gerrit.wikimedia.or" (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [04:40:37] (03CR) 10Mattflaschen: "Also, you need to be patient, and not send me emails that just say "please review" (especially when it's only been less than a week since " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [04:49:55] (03CR) 10Mattflaschen: "Note, the old patch (reactivated) is https://gerrit.wikimedia.org/r/#/c/189333/ ." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190240 (owner: 10Paladox) [05:04:37] Krinkle: btw, if you're still around at this ungodly hour that static site was jacked so I had to move that prototype graph. The data and analysis are solid, we're moving the code into dashiki soon and making it pretty: [05:04:38] https://edit-analysis.wmflabs.org/ve.html [05:18:44] jacked? [05:19:46] Hijacked [05:28:37] 3Parsoid, VisualEditor-Performance, VisualEditor: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1038828 (10ori) ``` Failed requests: 118... [05:39:23] 3§Collaboration-Team, Flow, WikiEditor, VisualEditor: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1038829 (10GOIII) >>! In T78346#1038747, @Mattflaschen wrote: > Note: Enhancing WikiEditor for normal pages is completely outside the scope of this bug. Then... [08:46:06] 3VisualEditor-Performance, VisualEditor: ve.init.mw.ViewPageTarget.transformPage triggers recalculate style due to $.fn.animate - https://phabricator.wikimedia.org/T89543#1038909 (10ori) 3NEW [09:15:32] 3VisualEditor: License URLs in VisualEditor media insertion dialog are broken - https://phabricator.wikimedia.org/T89544#1038923 (10Eloquence) 3NEW [09:47:40] 3VisualEditor-EditingTools, VisualEditor-DataModel, VisualEditor: Pasting text with code annotations within other annotated text should not cause nesting - https://phabricator.wikimedia.org/T89545#1038935 (10Krinkle) 3NEW [09:56:25] 3VisualEditor-Performance, VisualEditor: ve.init.mw.ViewPageTarget.transformPage triggers recalculate style due to $.fn.animate - https://phabricator.wikimedia.org/T89543#1038943 (10Krinkle) a:3Krinkle [10:06:27] 3VisualEditor: Cannot clear the styling of a code formatted text when the cursor is active inside the block or part of the block is selected - https://phabricator.wikimedia.org/T89547#1038954 (10Ryasmeen) 3NEW [10:08:50] 3VisualEditor: Cannot clear the styling of a code formatted text when the cursor is active inside the block or part of the block is selected - https://phabricator.wikimedia.org/T89547#1038961 (10Ryasmeen) [10:35:30] (03CR) 10Krinkle: [C: 04-1] "Untested, but test is broken or uses undocumented syntax." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189162 (https://phabricator.wikimedia.org/T88875) (owner: 10Brion VIBBER) [10:38:11] (03PS11) 10Amire80: Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [10:38:27] (03PS12) 10Amire80: Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [11:17:04] (03CR) 10Amire80: [C: 031] "I confirm that Hebrew seems to work well OK with and without diacritics." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [11:35:49] 3VisualEditor-Performance, VisualEditor: ~200ms spent on CSSStyleDeclaration.getPropertyValue() due to jQuery hide()/show() - https://phabricator.wikimedia.org/T87160#1039003 (10matmarex) 5Open>3Resolved [12:28:04] 3MediaWiki-Database, MediaWiki-ResourceLoader: MessageBlobStore::clear queries take 40+ seconds - https://phabricator.wikimedia.org/T89550#1039027 (10Nikerabbit) 3NEW [12:31:21] (03PS15) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [12:32:36] (03CR) 10Paladox: "Hi I did it from start with other patch I went through to look at the code to see if it breaks and tested it with my wiki. This patch shou" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [12:35:40] (03CR) 10Paladox: "I did not add all the things or changed all the things you said since I did not understand what to do there I did write acomment under you" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [12:52:10] (03CR) 10Paladox: Convert .css to .less (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [13:03:30] (03PS16) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [13:08:05] (03CR) 10Paladox: "Should this change from" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [13:08:58] (03CR) 10Paladox: "I have done what you previously told me in the commits above now. except from one I am guessing that this is what you meant in the comment" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [13:27:51] 3MediaWiki-Page-editing: New configuration settings $wgMergeHistoryRevisionsLimit - https://phabricator.wikimedia.org/T89551#1039064 (10Bugreporter) 3NEW [13:43:45] (03PS14) 10Paladox: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [13:43:59] (03PS15) 10Paladox: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [13:46:42] (03PS16) 10Paladox: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [13:47:32] (03PS17) 10Paladox: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [15:06:03] 3MediaWiki-Page-editing: In edit preview, show categories in their standard position relative to the parsed page - https://phabricator.wikimedia.org/T4679#1039128 (10Qgil) [15:08:10] 3MediaWiki-Page-editing: In edit preview, show categories in their standard position relative to the parsed page - https://phabricator.wikimedia.org/T4679#1039130 (10Qgil) @Kozuch, we all have busy times, no worries. However, do you plan to come back to this task at some point? I'm asking because the task is sti... [17:16:51] 3VisualEditor-MediaWiki-References, VisualEditor: Cite Web dialog always shows the details of the URL that was entered first in the “Autofill from URL”. - https://phabricator.wikimedia.org/T89555#1039247 (10Swainr) 3NEW [17:27:58] 3VisualEditor-MediaWiki-References, VisualEditor: Cite Web dialog always shows the details of the URL that was entered first in the “Autofill from URL”. - https://phabricator.wikimedia.org/T89555#1039258 (10Swainr) Screencast http://youtu.be/uLuB-otNG-4 [17:28:31] 3VisualEditor-MediaWiki-References, VisualEditor: Cite Web dialog always shows the details of the URL that was entered first in the “Autofill from URL”. - https://phabricator.wikimedia.org/T89555#1039259 (10Swainr) [17:30:31] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=29494782 [17:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111834066 [17:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111837041 [17:30:31] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111837146 [17:30:31] Corruption alert: visualeditor-needcheck on ukwiki: https://uk.wikipedia.org/?diff=15624637 [18:10:12] 3Parsoid, Flow, VisualEditor, RESTBase, VisualEditor-Performance: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#1039289 (10GWicke) [19:04:49] 3VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor: Allow template parameters to be rearranged and field names to be changed - https://phabricator.wikimedia.org/T89560#1039329 (10Negative24) 3NEW [19:50:41] 3MediaWiki-ResourceLoader: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561#1039385 (10Krenair) [21:28:22] 3MediaWiki-ResourceLoader: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561#1039453 (10Krinkle) p:5Triage>3Normal [22:04:37] (03PS1) 10Gerrit Patch Uploader: Remove color overwrite for dialog header border bottom [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190682 [22:04:40] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190682 (owner: 10Gerrit Patch Uploader) [22:19:13] 3TemplateData: TemplateData: Store TemplateData in its own namespace ("Template data:") with a JSON content type and associated to the Template: namespace - https://phabricator.wikimedia.org/T56140#1039513 (10Tacsipacsi) [22:20:10] 3TemplateData: TemplateData: Page properties should not be stored twice (both Template and Template/doc) - https://phabricator.wikimedia.org/T52512#563145 (10Tacsipacsi) [22:27:06] 3VisualEditor-EditingTools, VisualEditor: VE citation form bugginess on iOS - https://phabricator.wikimedia.org/T68562#1039528 (10Etonkovidova) It's been fixed in beta [22:27:33] 3VisualEditor-EditingTools, VisualEditor: VE citation form bugginess on iOS - https://phabricator.wikimedia.org/T68562#1039531 (10Etonkovidova) 5Open>3Resolved p:5Triage>3Low [22:29:43] 3Parsoid, VisualEditor, RESTBase, VisualEditor-Performance: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1039534 (10GWicke) [22:55:11] 3VisualEditor: Unknown file can't be changed to a correct one - https://phabricator.wikimedia.org/T89570#1039559 (10Drongou) 3NEW