[00:00:53] yes, and the parsoid is outputing the following [00:00:54] [info][wikifyl/Artes?oldid=886] started parsing [00:00:59] [info][wikifyl/Artes?oldid=886] completed parsing in 2455 ms [00:01:38] that also establishes that curl is fine [00:01:41] mw.loader.getState( 'ext.visualEditor.viewPageTarget.init' ) [00:01:42] "error" [00:02:13] on enwiki main page I get "ready" [00:02:28] http://wikifyl.com.ar/Artes?debug=true -> errors in console [00:02:43] http://wikifyl.com.ar/Extensions/VisualEditor/lib/ve/src/ve.js 404 [00:03:31] http://wikifyl.com.ar/extensions/VisualEditor/LICENSE.txt exists [00:03:44] but, uh: http://wikifyl.com.ar/extensions/VisualEditor/lib/ve/ [00:03:47] that's not right [00:04:11] lfschenone, it looks like you missed VE itself [00:04:23] VE-MW isn't going to work unless you download VE [00:04:33] !! [00:04:37] checking .. [00:04:58] https://www.mediawiki.org/wiki/Extension:VisualEditor#Download - you need to cd to extensions/VisualEditor and run "git submodule update --init" [00:08:43] looks good lfschenone [00:09:38] how stupid i was .. [00:09:42] thanks for your time guys [00:09:49] im now getting a new error on the log [00:09:50] [Sun Feb 15 18:58:57.490924 2015] [:error] [pid 26473] [client 92.11.235.50:38954] PHP Notice: Undefined index: x-cache in /var/www/html/wikifyl.com.ar/extensions/VisualEditor/ApiVisualEditor.php on line 55 [00:09:59] but the VE seems to work [00:10:14] hm [00:11:02] it's a mere notice [00:11:10] don't worry, I'll figure it out [00:11:15] thanks krenair [00:11:19] gwicke, that's checking for an X-Cache response header from parsoid [00:11:20] does that only come up when you have parsoid behind its own cache? [00:11:24] ! [00:12:09] it may apply to other people's installs as well, and could be caused by a bad assumption I made when writing code :p [00:21:25] Krenair: not sure, I don't recall adding a check like that [00:21:48] it's not something that's added by parsoid afaik [00:53:00] gwicke, it was added in https://gerrit.wikimedia.org/r/#/c/87532/ [00:53:25] looks like X-Cache is added by Varnish [00:54:23] getResponseHeader returned null if the header was not set [00:55:25] then the ParsoidVRS change just changed to checking array indexes, which can cause PHP to raise notices if not set [00:55:43] Can we make the editor better for mobiles [00:55:59] Krenair: I see [00:56:49] Krenair: if it's still safe, perhaps silence that in VRS with @? [00:57:18] or do the isset dance [00:57:32] gwicke, have you read CC/PHP? :P [00:57:58] https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Error_handling [00:58:07] the isset dance it is then [01:00:51] didn't know about the E_STRICT issue [01:01:11] but of course @ is more often abused than used widely [01:01:15] *wisely [01:01:20] widely too though [01:10:15] 2VisualEditor, 2VisualEditor-ContentEditable, 2VisualEditor-CopyPaste, 2VisualEditor-Performance, and 1 other: Pasting content results in scroll flickering - https://phabricator.wikimedia.org/T89623#1040634 (10Krinkle) 3NEW [01:15:26] (03PS1) 10Alex Monk: Don't try to get X-Cache header if it's not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190758 [01:34:37] 2VisualEditor, 2VisualEditor-ContentEditable, 2VisualEditor-Performance, and 1 other: Removing characters causes re-rendering of paragraph (causing spell-check to flicker) - https://phabricator.wikimedia.org/T89625#1040664 (10Krinkle) 3NEW [03:30:30] (03CR) 10GWicke: [C: 032] Don't try to get X-Cache header if it's not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190758 (owner: 10Alex Monk) [03:32:14] (03Merged) 10jenkins-bot: Don't try to get X-Cache header if it's not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190758 (owner: 10Alex Monk) [03:58:48] I am interested in building VisualEditor for the latest Drupal (and also Drupal 8 ready) [03:59:16] I was not sure whether to come here or comment on https://www.mediawiki.org/wiki/VisualEditor/Setup first [04:03:43] * mavaddat waves [04:11:55] * mavaddat waves at Keegan [04:12:39] Hi mavaddat. You're likely best to go to mw.org first [04:12:48] OK [04:13:33] The server at mw.org can't be found, because the DNS lookup failed. DNS is the network service that translates a website's name to its Internet address. Did you mean http://www.m-w.org/? Did you mean http://mw.com/? Did you mean http://mv.org/? [04:14:15] ohhh https://www.mediawiki.org/wiki/MediaWiki [04:14:31] :$ [04:16:08] does VisualEditor require installing MediaWiki? [04:19:14] OK I found some answers: http://stackoverflow.com/questions/12085857/how-to-enable-mediawikis-new-visual-editor [04:27:48] Sorry, I should have been more clear :) [04:29:27] no worries, I realize IRC communication requires weeding out n00bs (A) [04:29:54] mavaddat: I'm not an engineer, so I do not know all the details. However, I believe that visualeditor can be run without MediaWiki. You do, however, need a node.js server running [04:30:47] I know the intention is the finished product is stand-alone, I do not know for certainty if it's at that state yet though [04:31:21] You can set up a Vagrant instance of MediaWiki if you don't want to go through the whole LAMP process [04:31:37] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [04:31:53] yes, that seems to be message on https://www.mediawiki.org/wiki/Parsoid/Setup as well [04:44:16] 2VisualEditor: Category was duplicated and given different sort keys - https://phabricator.wikimedia.org/T89618#1040768 (10NicoV) To be more accurate: - [[Category:One two three four]] has been replaced by [[Category:One two three four|Category:One two]] and [[Category:One two three four| three four]] (note... [04:58:43] mavaddat, hi [04:59:30] VisualEditor's MediaWiki extension needs to contact Parsoid (a node.js server) so it can parse wikitext [04:59:38] But core VisualEditor can run standalone [05:03:51] mavaddat, https://bits.wikimedia.org/static-1.25wmf16/extensions/VisualEditor/lib/ve/demos/ve/desktop.html [05:06:02] ty Krenair [05:08:15] I had it backwards, as normal :) [05:13:42] 2VisualEditor, 2Wikimedia-Site-requests: Enable VE in other namespaces - https://phabricator.wikimedia.org/T89593#1040774 (10Glaisher) >>! In T89593#1040460, @Juandev wrote: > Do we need for this change the consensus of the community? Yes. [05:59:20] (03CR) 10Mattflaschen: "I replied to your question." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [05:59:32] (03CR) 10Mattflaschen: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [07:20:20] 2VisualEditor-MediaWiki, 2VisualEditor, 2VisualEditor-MediaWiki-Templates: Allow template parameters to be rearranged and field names to be changed - https://phabricator.wikimedia.org/T89560#1040874 (10Mooeypoo) This is already possible with TemplateData editor; the order is dictated by the paramOrder arra... [07:21:33] 2VisualEditor-MediaWiki, 2TemplateData, 2VisualEditor, 2VisualEditor-MediaWiki-Templates: Allow template parameters to be rearranged and field names to be changed - https://phabricator.wikimedia.org/T89560#1040882 (10Mooeypoo) [07:24:37] +Krenair, so then VisualEditor core does not require Nodejs? [07:35:36] mavaddat: correct [07:35:45] OK, that's great news [08:26:40] according to the Wikimedia engineering draft goals for 2014–2015, VisualEditor does not have a standalone core component yet [08:26:48] is this true or false? [08:27:03] See https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals#Editing [10:43:26] 2MediaWiki-Page-editing, 2MediaWiki-ResourceLoader, and 1 other: jquery dialog with auto size takes 50% screen width in RTL language wikis - https://phabricator.wikimedia.org/T86979#1041085 (10Aklapper) @Krinkle, any suggestions? [11:09:51] 2MediaWiki-Page-editing, 13MediaWiki-Core-Team, and 1 other: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1041131 (10Aklapper) Not sure if this is still Core or already DB territory. Probably the former if MW does... [11:10:23] 2MediaWiki-ResourceLoader, 13MediaWiki-Core-Team, and 1 other: Fix "PHP Notice: Uninitialized string offset: 1 in includes/libs/jsminplus.php on line 1968" - https://phabricator.wikimedia.org/T77169#1041133 (10Aklapper) p:5Triage>3Volunteer? [11:40:17] 2MediaWiki-ResourceLoader, 2MediaWiki-Interface, and 1 other: Stop serving SVG images to Opera 12 - https://phabricator.wikimedia.org/T87504#1041200 (10Aklapper) [12:07:41] 2MediaWiki-ResourceLoader, 2MediaWiki-Database, and 1 other: MessageBlobStore::clear queries take 40+ seconds - https://phabricator.wikimedia.org/T89550#1041242 (10Aklapper) p:5Triage>3Normal [12:08:40] 2MediaWiki-Page-editing, and 1 other: New configuration settings $wgMergeHistoryRevisionsLimit - https://phabricator.wikimedia.org/T89551#1041244 (10Aklapper) p:5Low>3Volunteer? [14:20:02] 3VisualEditor: Category was duplicated and given different sort keys - https://phabricator.wikimedia.org/T89618#1041477 (10Krenair) Sounds like {T76715} [14:53:44] (03PS1) 10Esanders: Only modify body class when first/last window opens/closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/190806 (https://phabricator.wikimedia.org/T89613) [15:24:47] ed: where did you say the code that determines the name of the ref node lives? I need to fix https://phabricator.wikimedia.org/T88152 [15:25:30] edsanders: * [15:26:19] also is it possible to just overwrite that by having an inspector for reference nodes instead? [15:26:50] since we need to do reference previews for kaity's design [15:29:27] DesktopContext [15:29:36] You should speak to Trevor though [15:29:49] I think he has plans to restructure that so we can show more information [15:30:43] 3VisualEditor, VisualEditor-CopyPaste: Cutting and pasting a paragraph causes (only) the last inline template to be replaced by HTML - https://phabricator.wikimedia.org/T86401#1041586 (10Esanders) The DM html generated shows the problem here. The template consists of three children, the first two of which are ca... [15:31:39] 3VisualEditor, VisualEditor-CopyPaste: Cutting and pasting a paragraph causes (only) the last inline template to be replaced by HTML - https://phabricator.wikimedia.org/T86401#1041589 (10Esanders) A separate problem is that the '' tag isn't getting a data-ve-ignore attribute, which is why we are seeing bad... [15:34:34] 3VisualEditor-EditingTools, VisualEditor: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1041591 (10Mvolz) [15:38:12] 3VisualEditor-EditingTools, VisualEditor: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1041607 (10Mvolz) [15:38:55] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-References: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#1041611 (10matmarex) [15:39:09] edsanders: yeah will do- is it possible to overwrite with inspector though? [15:39:38] we'll have to overwrite it with something more complex [15:39:51] mvolz: the context menus are evil [15:40:04] it's still just a non-interactive preview though, so wouldn't be an inspector [15:42:48] edsanders: I guess what I'm saying is that there should be an interactive preview :) [15:42:55] a.k.a and edit button within [15:43:07] well, an edit button is what we have already [15:43:20] (03PS1) 10Gerrit Patch Uploader: Remove CSS definition for tables in dialogs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190812 [15:43:23] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190812 (owner: 10Gerrit Patch Uploader) [15:43:53] mvolz: might interest you: https://phabricator.wikimedia.org/T71474 [15:43:54] there will be a button to start editing like you say, which will launch the inspector - but we won't build the whole inspector on focus. [15:44:20] edsanders: okay [15:44:23] so : https://phab.wmfusercontent.org/file/data/qbb7qg5vvxmeax5flewa/PHID-FILE-7ncrjnd5ux3iuakn7s4o/magic_cite3-02.png [15:44:48] that is going to be context menu still [15:45:11] yes [15:52:57] (03CR) 10Bartosz Dziewoński: "Eww. I'd really suggest killing this, rather than piling on more hacks." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190806 (https://phabricator.wikimedia.org/T89613) (owner: 10Esanders) [15:54:27] 3VisualEditor, VisualEditor-DataModel: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#1041635 (10matmarex) [15:54:30] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-References: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#1041634 (10matmarex) [15:54:38] 3VisualEditor, VisualEditor-MediaWiki-References, VisualEditor-DataModel: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#558083 (10matmarex) [15:57:04] 3VisualEditor, VisualEditor-MediaWiki-References, VisualEditor-DataModel: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - https://phabricator.wikimedia.org/T52474#1041642 (10matmarex) [15:57:05] 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-References: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#1041641 (10matmarex) [15:57:24] 3VisualEditor, VisualEditor-MediaWiki-References, VisualEditor-ContentEditable: References in blockquote invisible outside it; reflist outside blockquote invisible inside it - https://phabricator.wikimedia.org/T54398#1041643 (10matmarex) [15:57:30] 3VisualEditor, VisualEditor-MediaWiki-References, VisualEditor-DataModel: VisualEditor: [Regression] References in templates don't appear in references list - https://phabricator.wikimedia.org/T53289#1041645 (10matmarex) [15:57:40] 3VisualEditor: Copy and pasting complex templates between instances results in blank renderings and non-template garbage - https://phabricator.wikimedia.org/T89658#1041647 (10Esanders) 3NEW a:3Esanders [16:00:31] 3VisualEditor, VisualEditor-ContentEditable, Citoid: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#1041657 (10Mvolz) [16:04:25] (03PS1) 10Esanders: Correctly tag clipboard DM from MWTransclusionNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190814 (https://phabricator.wikimedia.org/T89658) [16:19:36] Quiz time! [16:19:52] If I place my cursor here:

A|B

[16:20:15] and paste 'Non-empty span' [16:20:40] what do I get? (Chrome 40) [16:22:33] (03CR) 10Mvolz: [C: 031] "Thanks! Works as expected ;)" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190627 (owner: 10Mooeypoo) [16:22:49] the answer is obviously '

ANon-empty spanB

' [16:22:53] I guess Non-empty span [16:23:53] mavaddat, you will lose empty spans if you don't give them some attributes, yes - this is even more fun - it just throws it outside the paragraph [16:26:04] (6) ooohh [16:36:58] 3VisualEditor: Category was duplicated and given different sort keys - https://phabricator.wikimedia.org/T89618#1041699 (10NicoV) Not sure, for several reasons : * I don't see any mention in T76715 of categories becoming grouped on one line * I tried reproducing T76715 and I see the category appearing several ti... [16:39:13] 3MediaWiki-Interface, MediaWiki-ResourceLoader: Stop serving SVG images to Opera 12 - https://phabricator.wikimedia.org/T87504#1041702 (10matmarex) Emailed wikitech-l: https://lists.wikimedia.org/pipermail/wikitech-l/2015-February/080841.html [16:42:10] (03CR) 10Ricordisamoa: Correctly tag clipboard DM from MWTransclusionNodes (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190814 (https://phabricator.wikimedia.org/T89658) (owner: 10Esanders) [16:52:19] (03PS2) 10Esanders: Correctly tag clipboard DM from MWTransclusionNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190814 (https://phabricator.wikimedia.org/T89658) [16:52:21] (03PS1) 10Esanders: Fix clipboard DM for transclusion nodes starting with invisible tags [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190822 (https://phabricator.wikimedia.org/T86401) [16:56:02] (03PS2) 10Mvolz: Focus the input when the dialog is ready [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190627 (owner: 10Mooeypoo) [17:18:01] 3MediaWiki-Page-editing, MediaWiki-ResourceLoader: jquery dialog with auto size takes 50% screen width in RTL language wikis - https://phabricator.wikimedia.org/T86979#1041813 (10Krinkle) >>! In T86979#984648, @Amire80 wrote: > So I guess that it should be something like > > ``` > .ltr .ui-dialog { > left:... [17:30:32] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12240443 [17:30:32] Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1487617 [17:30:32] Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org/?diff=1487619 [17:30:32] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111896762 [17:30:32] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34335505 [17:30:33] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34340682 [17:30:33] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34340699 [17:30:34] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34341997 [17:30:34] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34342013 [17:30:35] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34342025 [17:30:35] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68617228 [17:30:36] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68632937 [17:34:21] 3VisualEditor, VisualEditor-ContentEditable: Regression pre-wmf16: Language context menu lags behind the cursor position and typed text , if text format is Heading or Page title. - https://phabricator.wikimedia.org/T87298#1041870 (10Etonkovidova) The issue happens for Heading or Page title only. - Apply languag... [17:34:43] 3VisualEditor, VisualEditor-ContentEditable: Regression pre-wmf16: Language context menu lags behind the cursor position and typed text , if text format is Heading or Page title. - https://phabricator.wikimedia.org/T87298#1041871 (10Etonkovidova) p:5Triage>3Volunteer? [17:36:33] 3VisualEditor, VisualEditor-ContentEditable: Regression pre-wmf16: Language context menu lags behind the cursor position and typed text , if text format is Heading or Page title. - https://phabricator.wikimedia.org/T87298#988348 (10Etonkovidova) [17:48:33] (03CR) 10Jforrester: [C: 032] Focus the input when the dialog is ready [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190627 (owner: 10Mooeypoo) [17:48:46] (03Merged) 10jenkins-bot: Focus the input when the dialog is ready [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190627 (owner: 10Mooeypoo) [18:06:22] 3VisualEditor, VisualEditor-MediaWiki, Parsoid: Regression: Selser duplicates entire page when displaytitle is added - https://phabricator.wikimedia.org/T89383#1041934 (10ssastry) p:5Triage>3High a:3ssastry [18:06:53] 3VisualEditor, VisualEditor-MediaWiki, Parsoid: Regression: Selser duplicates entire page when displaytitle is added - https://phabricator.wikimedia.org/T89383#1035060 (10ssastry) Fix will be deployed today. [18:14:05] mooeypoo: ping ^-^ [18:14:14] mvolz, yo [18:14:16] :) [18:15:12] mvolz, quick question -- as I was installing Citoid and the service and such, I ran into an issue and I realized that I have to override $wgCitoidServiceUrl to *not* use https [18:15:35] Probably since I don't have https enabled on my local machine... [18:15:36] :D [18:16:56] ah, yeah [18:16:58] mvolz, so also, Firefox works fine for me without https, too, so I'm not sure if the comment there was about production wikis or something that changed, maybe? [18:17:06] so in firefox, if you are accessing a site through https [18:17:15] and you try to access citoid through http [18:17:23] it blocks the request. [18:17:27] I see [18:17:34] so on localhost, it's all http, so it's fine [18:17:34] I think Chrome does that too now? [18:17:36] It should [18:17:56] mvolz, well if I quote a url that's https I may run into trouble [18:17:58] didn't test that yet [18:18:03] i may have to enable https then [18:18:08] i don't know, this was like 6 months ago where it worked in chromium but not firefox, who knows [18:18:15] or just be aware i can't use citoid for https stuff [18:18:24] it works for me so far but I didn't try https stuff [18:18:34] Depending on what you're using exactly, a URL like //foo.bar/baz might work [18:19:40] mooeypoo: on localhost it's fine because localhost is http. So you're both http [18:19:44] yeah I tested mostly with nytimes.com (non https) and Scitation(AIP) science stuff which isn't https either [18:19:55] Oh that stuff should also be fined [18:19:56] *fine [18:20:03] Because it's going through Citoid/Zotero first [18:20:08] Your browser doesn't query nytimes directly [18:20:08] yeah input doesn't matter [18:20:43] oh okay [18:20:46] the only protocols that have to match is your wiki installation and your citoid installation [18:20:53] They match [18:21:04] might be worth adding a note to the docs, though. [18:21:19] (03Abandoned) 10Jforrester: Update VE core submodule to master (3a53aad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190495 (owner: 10Jforrester) [18:21:23] because it's the front end code that firefox is blocking, which only queries citoid directly, not other urls [18:21:25] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/190743/ [18:21:43] mooeypoo: yeah good call [18:21:53] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (331116b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190743 (owner: 10Jforrester) [18:22:02] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/189472/ [18:22:13] James_F: o/ [18:22:18] Krinkle: ? [18:23:11] btw, mvolz, there are also tiny (really minor) style adjustments that weren't applied to citoid when we changed them recently -- like spaces between [foo] and removing $: this.$ [18:23:29] James_F: Checking in :) [18:23:39] mvolz, I figured I can help with that too, just didn't want to step on your toes with a somewhat wider patch [18:23:41] (03Merged) 10jenkins-bot: Update VE core submodule to master (331116b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190743 (owner: 10Jforrester) [18:23:46] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/187951/ https://gerrit.wikimedia.org/r/#/c/188028/ https://gerrit.wikimedia.org/r/#/c/188029/ [18:24:05] Krinkle: Aha. What are you working on today? Got further with the karma disconnect issue? [18:24:39] mooeypoo: don't worry about it, feel free to do style errors [18:24:42] and then go blame ed [18:24:42] James_F: Yeah, down to libsqlite3 [18:24:44] :D [18:24:51] James_F: Thanks to tstarling [18:25:12] James_F: Apparently, the way MediaWIki is using sqlite, it doesn't account for concurrency at all. Not just when it's heated, but just at all. [18:25:14] mvolz, I was told to always blame RoanKattouw [18:25:24] (03CR) 10Catrope: [C: 032] Correctly tag clipboard DM from MWTransclusionNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190814 (https://phabricator.wikimedia.org/T89658) (owner: 10Esanders) [18:25:25] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/189737/ https://gerrit.wikimedia.org/r/#/c/190814/ https://gerrit.wikimedia.org/r/#/c/190822/ [18:25:33] James_F: The unit test I fixed in mediawiki core was going crazy on this but even with that patch, it still happens too often. [18:25:47] Krinkle: :-( [18:25:51] https://phabricator.wikimedia.org/T89075 https://phabricator.wikimedia.org/T89180#1033549 [18:25:56] https://gerrit.wikimedia.org/r/#/c/190154/ [18:26:07] James_F: And in labs, requests are much more likely to overlap [18:26:35] Hence it in prod it either has never happened or is so rare we probably thought it was something else and away on recheck [18:26:56] * James_F nods. [18:26:58] basically any concurrency of any kind, will result in sqlite file lock error that is unrecoverable essentially [18:27:02] (03Merged) 10jenkins-bot: Correctly tag clipboard DM from MWTransclusionNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190814 (https://phabricator.wikimedia.org/T89658) (owner: 10Esanders) [18:27:28] (03CR) 10Esanders: [C: 032] Inline ve.ce.View#renderAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190625 (owner: 10Catrope) [18:27:34] Tim found some horrible code in the sqlite lib for dealing with posix file locks and how to wait for them. It's a public interface, but we're not using that at the moment. Will coordinate with mwcore to get us using this. [18:28:30] James_F: RoanKattouw: Among the horrible code is a 80-lines long comment by the author explaining why it sucks and why it shouldn't have worked. [18:28:38] :D [18:28:42] Krinkle: Wow. [18:29:12] James_F: RoanKattouw: https://github.com/smparkes/sqlite/blob/master/src/os_unix.c#L605-L693 [18:29:30] "but wait, there's more: .." [18:31:32] (03CR) 10Esanders: [C: 032] Make newFromAnnotation test construct doc2 from data, not HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190617 (owner: 10Catrope) [18:31:56] mvolz, also, I just sat with RoanKattouw about something in the repo, and he mentioned that I shouldn't have the deploy repo on my computer [18:32:16] mvolz, maybe we should take that off the documentation too, if that's the case. I'll reinstall from scratch [18:32:44] The deployment repo contains binaries compiled for 64-bit Ubuntu [18:32:53] If you run it on a different system, it'll explode [18:33:31] (03Merged) 10jenkins-bot: Make newFromAnnotation test construct doc2 from data, not HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190617 (owner: 10Catrope) [18:33:33] Also we shouldn't have binaries in there, that's one of the things Alexandros is working on fixing [18:33:37] (03CR) 10Esanders: [C: 032] Remove useless getDataElementFromDomElement / getDomElementsFromDataElement tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190620 (owner: 10Catrope) [18:34:13] 3VisualEditor, VisualEditor-CopyPaste, VisualEditor-DataModel: Copy and pasting complex templates between instances results in blank renderings and non-template garbage - https://phabricator.wikimedia.org/T89658#1041989 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High [18:35:32] (03Merged) 10jenkins-bot: Remove useless getDataElementFromDomElement / getDomElementsFromDataElement tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190620 (owner: 10Catrope) [18:36:31] (03CR) 10Esanders: [C: 032] DomFromModelTest: Call modify() on the document, not the data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190622 (owner: 10Catrope) [18:38:13] Krinkle: Wow some of those locking issues are seriously terrible [18:38:26] Like close() dropping all locks even if you have the file open under a different FD [18:38:32] Hehe [18:38:36] I figured you'd be amused [18:39:56] 3OOjs-UI: Add SVG+PNG distribution serving SVG images to modern browsers and PNG as a fallback, primarily for PHP OOUI support in older browsers - https://phabricator.wikimedia.org/T87501#1042001 (10matmarex) a:3matmarex [18:40:07] (03PS1) 10Bartosz Dziewoński: Introduce mixed SVG+PNG distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) [18:40:14] (03CR) 10Catrope: [C: 032] Fix clipboard DM for transclusion nodes starting with invisible tags [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190822 (https://phabricator.wikimedia.org/T86401) (owner: 10Esanders) [18:40:27] edsanders: Re ---^^ , we really need converter tests for clipboard mode [18:40:55] edsanders: It bothers me a little that there are no tests that you had to update for that commit, and that there is no easy way for you to add a new one to assert the link->span behavior [18:41:00] true [18:41:16] (03Merged) 10jenkins-bot: DomFromModelTest: Call modify() on the document, not the data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190622 (owner: 10Catrope) [18:41:18] (03Merged) 10jenkins-bot: Inline ve.ce.View#renderAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190625 (owner: 10Catrope) [18:42:14] (03Merged) 10jenkins-bot: Fix clipboard DM for transclusion nodes starting with invisible tags [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190822 (https://phabricator.wikimedia.org/T86401) (owner: 10Esanders) [18:43:59] works in FF though [18:48:29] XMLHttpRequest: Inconsistent camel-case (XML and Http), not for XML (plain text, json, html etc.) and not exclusive to HTTP (also supports other protocols now). [18:48:36] Best method name ever [18:49:04] 3VisualEditor, VisualEditor-CopyPaste, VisualEditor-DataModel: Cutting and pasting a paragraph causes (only) the last inline template to be replaced by HTML - https://phabricator.wikimedia.org/T86401#1042055 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [18:49:43] :-) [18:50:05] 3VisualEditor, VisualEditor-Performance: ve.ce.Surface.showSelection forces a style recalc - https://phabricator.wikimedia.org/T87419#1042060 (10Jdforrester-WMF) a:3Esanders [18:50:26] 3VisualEditor, VisualEditor-ContentEditable: Position event not emitted after slug close - https://phabricator.wikimedia.org/T85014#1042064 (10Jdforrester-WMF) a:5dchan>3Esanders [18:51:17] 3VisualEditor-Tables, VisualEditor: [Regression wmf16]: Firefox only: Tables - When a cell is highlighted, a thick border line displayed in the middle - https://phabricator.wikimedia.org/T88474#1042066 (10Jdforrester-WMF) p:5Low>3Normal [18:51:37] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki, VisualEditor-MediaWiki-References: "Nested" dialogs (template inside a basic reference) break the OOUI hack to prevent scrolling while dialog is open - https://phabricator.wikimedia.org/T89613#1042070 (10Jdforrester-WMF) p:5Triage>3Normal [18:52:53] 3BetaFeatures, VisualEditor, VisualEditor-Performance: VisualEditor beta feature on enwiki causes edit tab to flicker - https://phabricator.wikimedia.org/T89668#1042077 (10ori) 3NEW [18:53:45] 3VisualEditor-Initialisation, VisualEditor-Performance, VisualEditor: VisualEditor beta feature on enwiki causes edit tab to flicker - https://phabricator.wikimedia.org/T89668#1042085 (10Catrope) [18:57:14] 3VisualEditor, VisualEditor-ContentEditable: Regression pre-wmf16: Entire line of text gets highlighted , when applying link or language to a text in Heading or Page Title format. - https://phabricator.wikimedia.org/T87297#1042089 (10Etonkovidova) Happens in Chrome 40 too. Firefox is ok. Assigning //Normal// pri... [18:57:27] 3VisualEditor, VisualEditor-ContentEditable: Regression pre-wmf16: Entire line of text gets highlighted , when applying link or language to a text in Heading or Page Title format. - https://phabricator.wikimedia.org/T87297#1042090 (10Etonkovidova) p:5Triage>3Normal [19:01:47] (03CR) 10Jforrester: [C: 031] Introduce mixed SVG+PNG distribution (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [19:01:51] (03PS1) 10Catrope: Add round-trip test to getModelFromDom tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190845 [19:02:02] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Duplicate resize handles appear on unhighlighted image nodes after resize - https://phabricator.wikimedia.org/T72817#1042091 (10Krinkle) Still reproducible on latest master. On fast networks it's harder to reproduce but there's no doubt we're missing som... [19:02:43] (03PS2) 10Catrope: Add round-trip test to getModelFromDom tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190845 [19:04:17] (03PS2) 10Jforrester: Only replace selection when we know it has changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189472 (https://phabricator.wikimedia.org/T87419) (owner: 10Esanders) [19:04:23] (03PS8) 10Jforrester: Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders) [19:04:30] (03PS6) 10Jforrester: Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 (owner: 10Esanders) [19:04:35] (03PS8) 10Jforrester: Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 (owner: 10Esanders) [19:05:15] edsanders: Does https://gerrit.wikimedia.org/r/#/c/189627/13..15/src/dm/ve.dm.APIResultsProvider.js address all your comments? Good to merge? [19:19:35] (03CR) 10Bartosz Dziewoński: Introduce mixed SVG+PNG distribution (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [19:27:11] 3OOjs-UI: OOjs UI fields are not uniform height - https://phabricator.wikimedia.org/T87546#1042127 (10matmarex) [19:27:34] (03CR) 10Esanders: [C: 032] Create APIResultsProvider and APIResultsQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [19:28:10] 3MediaWiki-Interface, MediaWiki-ResourceLoader: Stop serving SVG images to Opera 12 - https://phabricator.wikimedia.org/T87504#1042128 (10matmarex) 5Open>3Resolved a:3matmarex [19:28:10] 3OOjs-UI: OOjs UI: trouble with CheckboxInputWidget in Opera - https://phabricator.wikimedia.org/T75517#1042133 (10matmarex) [19:29:27] (03Merged) 10jenkins-bot: Create APIResultsProvider and APIResultsQueue and add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189627 (owner: 10Mooeypoo) [19:30:39] 3Continuous-Integration, OOjs-UI: PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#1042139 (10matmarex) What is the status of this? [19:31:33] (03PS1) 10Mooeypoo: Add Gruntfile and fix style errors [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 [19:31:35] (03CR) 10jenkins-bot: [V: 04-1] Add Gruntfile and fix style errors [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 (owner: 10Mooeypoo) [19:36:39] (03PS2) 10Mooeypoo: Add Gruntfile and fix style errors [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 [19:36:46] (03PS2) 10Jforrester: [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [19:38:18] hi all, Sumit here, I'd like to get some feedback regarding a project related to visual-editor,that I have in mind [19:38:52] (03CR) 10Bartosz Dziewoński: [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [19:39:37] mvolz, I took the liberty of adding jscs/jshint/etc grunt tasks to Citoid extension and fixed up whatever it complained about [19:39:48] (03CR) 10Jforrester: [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [19:40:01] (03PS1) 10Jforrester: Update VE core submodule to master (f86c97c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190848 [19:40:21] ugh [19:40:25] MatmaRex: Yeah. [19:40:26] James_F: you can probably write [19:40:31] James_F: you can probably write ~'both' then [19:40:38] 'mixed' will do. [19:40:39] tilde is the "unquote" operator [19:41:00] also, a keywaord? what's it do? [19:41:38] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (f86c97c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190848 (owner: 10Jforrester) [19:41:38] subbu|afk, so is https://phabricator.wikimedia.org/T66171#1032427 going to be done in Parsoid now? [19:42:19] Me and Ori had planned to do this in ParsoidVRS in MW core, I had some code written for it even. [19:42:39] (03PS3) 10Jforrester: [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [19:43:01] MatmaRex: It's less. Who knows? ;-) ^^^ Renamed to 'mixed' instead. [19:45:19] (03PS2) 10Jforrester: Update VE core submodule to master (f86c97c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190623 (owner: 10Catrope) [19:45:30] 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1042171 (10matmarex) 5Open>3stalled a:5matmarex>3ori [19:45:43] (03Abandoned) 10Jforrester: Update VE core submodule to master (f86c97c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190848 (owner: 10Jforrester) [19:46:48] (03PS1) 10Esanders: WIP Test clipboard mode in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190849 [19:47:08] RoanKattouw, so all the tests that currently fail in core on clipboard mode are the ones with comments [19:47:26] I started adding 'clipboardBody' to them, but then I realised they are actually crap tests [19:47:48] Why are they crap tests? [19:47:52] the were originally written to test edge behaviour around metadata (e.g. with annotations and whitespace) [19:48:03] (03PS18) 10Jforrester: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [19:48:03] and were dumbly converted when comments became real data [19:48:07] 3VisualEditor, VisualEditor-MediaWiki-References: Cite Web dialog always shows the details of the URL that was entered first in the “Autofill from URL”. - https://phabricator.wikimedia.org/T89555#1042181 (10Etonkovidova) I think that here is a confusion in reference numbering in Media caption(the issue is known)... [19:48:27] (03CR) 10Jforrester: "PS18: Rebase onto pull-through so this is now testable and should work." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [19:48:32] I think you know better what they are testing, but most of them should be converted to tests probably? [19:48:39] (03CR) 10jenkins-bot: [V: 04-1] WIP Test clipboard mode in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190849 (owner: 10Esanders) [19:48:55] then I can rebase that ^ and it will probably pass [19:48:59] (03PS2) 10Jforrester: [PULL THROUGH] Add Vector-specific rules for slug animation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190461 (owner: 10Esanders) [19:49:19] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (f86c97c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190623 (owner: 10Catrope) [19:49:21] (except for actual comment testing) [19:49:37] Yeah probably [19:49:45] Krenair, we are going to record finer grained info about where time is being spent during serialization (dom-diff, selser, non-selser, etc) and what paths are being taken. [19:49:53] Some of them may be worth duplicating into comment tests, like a few of them concerning whitespace [19:50:02] yes [19:50:12] But most of them should probably be [19:50:14] do you want to do that because you know those bugs better? [19:50:16] I already converted a few of them [19:50:18] but not all [19:50:20] Sure [19:50:30] (03CR) 10Jforrester: [C: 031] Add Gruntfile and fix style errors (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 (owner: 10Mooeypoo) [19:50:37] subbu|afk, oh okay, that sounds better than what we were going to be able to do [19:50:37] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Add Vector-specific rules for slug animation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190461 (owner: 10Esanders) [19:50:50] also I don't know if you care about test performance, but I'm running non-clipboard/clipboard mode on all 150+ cases [19:51:01] I don't really care, no [19:51:04] That sounds fine [19:51:06] for most cases asserting that clipboard mode does nothing [19:51:09] Actually that sounds correct [19:51:14] Because ... exactly [19:51:20] Krenair, but, total time is also available, but it will not include network time, or time in routing inside parsoid, etc .. timing in ParsoidVRS will include those components if you wanted the time that ParsoidVRS sees. [19:51:27] (03Merged) 10jenkins-bot: Update VE core submodule to master (f86c97c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190623 (owner: 10Catrope) [19:51:37] Presumably using .clipboardBody || .body so that it asserts they're the same if clipboardBody isn't explicitly set? [19:52:04] yes, clipboardBody || normalizedBody || body [19:52:59] I mean, it's trivial to see, because none of our code contains "isForClipboard" so testing it 150 times seems a little excessive but at least it's thorough [19:53:13] and we may add more cases to core in future [19:54:15] edsanders: * will add. :-) [19:55:05] ...if we use isForClipboard in core [19:55:55] RoanKattouw, I'm thinking we should use it less actually [19:57:00] if we had another node which generated comments, we'd have to duplicate that logic for converting it to a span [20:04:08] can visual editor currently recognize canvas,because it does not seem to do so? [20:04:13] (03CR) 10Bartosz Dziewoński: [C: 04-1] [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [20:04:20] (03PS4) 10Bartosz Dziewoński: [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) [20:04:34] (03CR) 10Bartosz Dziewoński: [C: 031] [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [20:05:04] (03CR) 10Jforrester: [C: 031] "Trevor should really be the one to make the go/no-go decision on this breaking change." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [20:05:19] codezee: canvas? [20:05:57] MatmaRex: yes, see here https://www.mediawiki.org/wiki/User:Sumit.iitp/graphs, when editing in VE mode, the graphs disappear [20:06:18] MatmaRex: and the graphs are rendered using canvas [20:07:10] codezee: oh. we don't support the Graph extension currently now, there's a bug filed. https://phabricator.wikimedia.org/T89287 [20:07:28] codezee: Oh, that's because the Graph extension needs to register itself with VE to fill in the contents. [20:07:35] codezee: See http://parsoid-lb.eqiad.wikimedia.org/mediawikiwiki/User%3ASumit.iitp%2Fgraphs?oldid=1411384 for the Parsoid HTML DOM. [20:07:51] (03PS1) 10Mooeypoo: Apply citation when user hits 'enter' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190852 [20:07:59] MatmaRex: Yeah, codezee is thinking of being the one to fix that bug as a GSoC project. [20:08:44] MatmaRex,James_F: actually I was wondering about this bug only,I'm interested to work on this and how about if the graph could be made to recognize and also a tool could be provided for basic editing? [20:09:02] Also, ideally the Graph extension should put out a non-JS static version which the Canvas replaces. [20:11:25] as for the idea, I looked more into it, and thought that just like the math extension, whenever a graph is encountered, a basic set of tools be provided like add/delete values, scale options, for editing [20:13:43] something like at http://www.onlinecharttool.com/graph, but more limited [20:14:13] James_F: by the way, just how high priority https://phabricator.wikimedia.org/T86865 is? because i asked for design input to help me make it not look like poop a month ago [20:15:55] James_F: if i am supposed to get that done, i need design support or carte blanche to do things my way [20:20:12] MatmaRex: Carte blanche is a bit strong. [20:20:47] well, let's just say "official blessing" then. ;) [20:21:20] Tweak a few things and send me a screenshot? ;-) [20:21:55] hm. [20:22:14] Like the layout for "Move page: Main Page". [20:24:02] MatmaRex: Also, https://phabricator.wikimedia.org/T87501 isn't a blocker for Special:MovePage as there aren't any icons there… [20:24:58] James_F: checkboxes. [20:26:16] MatmaRex: Oh, right. [20:32:06] James_F: want to do some merging? https://gerrit.wikimedia.org/r/#/c/190574/ and also https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/ui+branch:master+topic:ruby,n,z [20:33:52] MatmaRex: https://gerrit.wikimedia.org/r/#/c/189360/ has an outstanding request from me. :-) [20:34:23] (03CR) 10Jforrester: [C: 032] Add missing ButtonInputWidget.less and corresponding mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/190574 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński) [20:34:35] James_F: yes, i'm currently thinking about it [20:34:41] Kk. [20:35:21] the demo doesn't really give us much space to explain, nor are long explanation in line with the rest of the demo [20:35:25] but oh well [20:35:40] (03Merged) 10jenkins-bot: Add missing ButtonInputWidget.less and corresponding mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/190574 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński) [20:37:37] James_F: "Multiple widgets displayed in a single line, like they could be in a compact form or when used as parts of a bigger widget."? not sure how much sense that makes [20:38:24] MatmaRex: Maybe "Multiple widgets shown as a single line, as used in compact forms or in parts of a bigger widget.". [20:38:55] alright, thanks [20:42:09] (03PS5) 10Bartosz Dziewoński: demo: Add horizontal alignment test [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) [20:44:20] (03CR) 10Jforrester: [C: 032] demo: Add horizontal alignment test [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński) [20:44:32] 3OOjs-UI: OOjs UI fields are not uniform height - https://phabricator.wikimedia.org/T87546#1042244 (10Jdforrester-WMF) Good enough for me, I think. [20:44:46] 3OOjs-UI: OOjs UI fields are not uniform height - https://phabricator.wikimedia.org/T87546#1042245 (10Jdforrester-WMF) 5Open>3Resolved [20:45:29] 3OOjs-UI: OOjs UI fields are not uniform height - https://phabricator.wikimedia.org/T87546#1042248 (10matmarex) I haven't done anything about the heights of things, by the way. (Not sure if I should.) [20:47:15] MatmaRex: Yeah, but it's… fine, I think. TrevorParscal can over-ride if he wants more. [20:48:41] (03Merged) 10jenkins-bot: demo: Add horizontal alignment test [oojs/ui] - 10https://gerrit.wikimedia.org/r/189360 (https://phabricator.wikimedia.org/T87546) (owner: 10Bartosz Dziewoński) [20:51:09] (03PS3) 10Jforrester: build: Pass RuboCop, customize settings [oojs/ui] - 10https://gerrit.wikimedia.org/r/190564 (owner: 10Bartosz Dziewoński) [20:51:13] (03CR) 10Jforrester: [C: 032] build: Pass RuboCop, customize settings [oojs/ui] - 10https://gerrit.wikimedia.org/r/190564 (owner: 10Bartosz Dziewoński) [20:51:29] (03CR) 10Jforrester: [C: 032] docparser: Add support for 'protected' methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190395 (owner: 10Bartosz Dziewoński) [20:52:07] (03CR) 10Jforrester: [C: 032] "Trust is a lovely thing." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190396 (owner: 10Bartosz Dziewoński) [20:52:47] MatmaRex: Want to merge https://gerrit.wikimedia.org/r/#/q/owner:%22Kmenger+%253Ckmenger%2540wikimedia.org%253E%22+status:open,n,z please? [20:53:06] right, i was meaning to look at that [20:53:07] (03Merged) 10jenkins-bot: build: Pass RuboCop, customize settings [oojs/ui] - 10https://gerrit.wikimedia.org/r/190564 (owner: 10Bartosz Dziewoński) [20:53:35] and complain that the docs are not in the PHP version, hmph [20:53:46] {{sofixit}} [20:56:19] (03CR) 10Bartosz Dziewoński: [C: 032] Widget: add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190136 (owner: 10Kmenger) [20:56:29] (03CR) 10Bartosz Dziewoński: [C: 032] Widget: add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190136 (owner: 10Kmenger) [20:56:32] (03PS2) 10Bartosz Dziewoński: Widget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190136 (owner: 10Kmenger) [20:56:47] (03CR) 10Bartosz Dziewoński: [C: 032] Widget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190136 (owner: 10Kmenger) [20:56:48] ugh [20:58:24] (03CR) 10Bartosz Dziewoński: [C: 032] ButtonElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190499 (owner: 10Kmenger) [20:58:39] (03Merged) 10jenkins-bot: Widget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190136 (owner: 10Kmenger) [20:58:51] (03PS1) 10Catrope: ElementLinearData tests: compare stores more elegantly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190921 [20:59:52] (03Merged) 10jenkins-bot: ButtonElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190499 (owner: 10Kmenger) [21:03:47] (03PS3) 10Bartosz Dziewoński: ButtonInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190572 (owner: 10Kmenger) [21:04:14] (03CR) 10Bartosz Dziewoński: "Reformatted the code example." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190572 (owner: 10Kmenger) [21:04:19] (03CR) 10Bartosz Dziewoński: [C: 032] ButtonInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190572 (owner: 10Kmenger) [21:07:27] (03CR) 10Jforrester: [C: 032] DropdownWidget: Simplify redundant code [oojs/ui] - 10https://gerrit.wikimedia.org/r/190478 (owner: 10Bartosz Dziewoński) [21:08:15] MatmaRex: And https://gerrit.wikimedia.org/r/#/c/190367/ would love some review. ;-) [21:09:08] (03PS2) 10Catrope: ElementLinearData tests: compare stores more elegantly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190921 [21:09:10] (03PS2) 10Bartosz Dziewoński: Dialog: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190594 (owner: 10Kmenger) [21:09:28] (03CR) 10Bartosz Dziewoński: "Reformatted the code example." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190594 (owner: 10Kmenger) [21:09:34] (03Merged) 10jenkins-bot: ButtonInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190572 (owner: 10Kmenger) [21:09:36] (03Merged) 10jenkins-bot: DropdownWidget: Simplify redundant code [oojs/ui] - 10https://gerrit.wikimedia.org/r/190478 (owner: 10Bartosz Dziewoński) [21:09:38] (03CR) 10Bartosz Dziewoński: [C: 032] Dialog: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190594 (owner: 10Kmenger) [21:11:34] (03Merged) 10jenkins-bot: Dialog: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/190594 (owner: 10Kmenger) [21:11:47] (03PS2) 10Bartosz Dziewoński: DraggableElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190600 (owner: 10Kmenger) [21:13:11] (03CR) 10Bartosz Dziewoński: "Removed "Currently, DraggableElement can only be mixed into OO.ui.OptionWidget.", as it's supposed to be mixinable into other widgets now," [oojs/ui] - 10https://gerrit.wikimedia.org/r/190600 (owner: 10Kmenger) [21:13:27] (03CR) 10Bartosz Dziewoński: [C: 032] DraggableElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190600 (owner: 10Kmenger) [21:13:41] (03CR) 10Bartosz Dziewoński: [C: 032] DraggableGroupElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190604 (owner: 10Kmenger) [21:14:03] (03PS1) 10Catrope: Add fromDataBody property for DomFromModel tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190931 [21:14:43] (03Merged) 10jenkins-bot: DraggableElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190600 (owner: 10Kmenger) [21:14:59] (03Merged) 10jenkins-bot: DraggableGroupElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/190604 (owner: 10Kmenger) [21:15:47] (03PS4) 10Jforrester: docparser: Add support for 'protected' methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190395 (owner: 10Bartosz Dziewoński) [21:16:01] (03CR) 10Jforrester: [C: 032] docparser: Add support for 'protected' methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190395 (owner: 10Bartosz Dziewoński) [21:16:07] (03PS4) 10Jforrester: testsuitegenerator: Only test every pair of config options rather than every triple [oojs/ui] - 10https://gerrit.wikimedia.org/r/190396 (owner: 10Bartosz Dziewoński) [21:18:05] 3VisualEditor, Parsoid, VisualEditor-MediaWiki: Regression: Selser duplicates entire page when displaytitle is added - https://phabricator.wikimedia.org/T89383#1042277 (10ssastry) 5Open>3Resolved [21:20:08] (03Merged) 10jenkins-bot: docparser: Add support for 'protected' methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/190395 (owner: 10Bartosz Dziewoński) [21:24:48] (03CR) 10Bartosz Dziewoński: [C: 032] "Why is the blasted thing not merging…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190396 (owner: 10Bartosz Dziewoński) [21:26:08] (03Merged) 10jenkins-bot: testsuitegenerator: Only test every pair of config options rather than every triple [oojs/ui] - 10https://gerrit.wikimedia.org/r/190396 (owner: 10Bartosz Dziewoński) [21:26:14] 3VisualEditor, VisualEditor-MediaWiki-References: Cite Web dialog always shows the details of the URL that was entered first in the “Autofill from URL”. - https://phabricator.wikimedia.org/T89555#1042290 (10Swainr) Sorry, rephrasing the steps-: 1> Cite -> Autofill from URL. Enter any URL, ex- http://go.com and... [21:28:27] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Comments in "unsafe" content locations are not displayed - https://phabricator.wikimedia.org/T73085#1042294 (10Whatamidoing-WMF) [21:30:35] 3VisualEditor: Unknown file can't be changed to a correct one - https://phabricator.wikimedia.org/T89570#1042304 (10Drongou) Example : https://test2.wikipedia.org/w/index.php?title=Drong-5&oldid=153189&veaction=edit [21:37:24] James_F: i'm on it when i finish unbreaking JS/PHP comparison tests. [21:37:35] * James_F nods. [21:45:32] (03PS7) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) [21:45:37] (03CR) 10jenkins-bot: [V: 04-1] Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [21:46:42] (03PS4) 10Jforrester: [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 [21:46:44] argh, jQuery sucks. [21:46:57] guess what $el.toggleClass('foo', null) does. [21:47:06] MatmaRex: In https://gerrit.wikimedia.org/r/188289 I've split the icons into "packs" in demos/icons.js; needs actual work. :-) [21:47:14] MatmaRex: Tell us [21:47:23] James_F: well, it adds the class. [21:47:28] rather than remove it. [21:47:32] wat [21:47:39] therefore TextInputWidget is broken. [21:48:02] state [21:48:04] Type: Boolean [21:48:05] A Boolean (not just truthy/falsy) value to determine whether the class should be added or removed. [21:48:07] OK fair enough [21:48:09] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [21:48:13] this is also a case of JavaScript sucking [21:48:19] >> null && true [21:48:20] MatmaRex: (object) null [21:48:22] >> null && false [21:48:23] MatmaRex: (object) null [21:48:38] >> !!null [21:48:38] RoanKattouw: (boolean) false [21:48:41] But yes [21:48:44] anyway [21:48:46] fixing. [21:49:04] && and || as fall-through operators is great until you want to use them as logical operators [21:49:43] RoanKattouw: but that is only useful when the left side is truthy [21:49:50] MatmaRex: Fun. [21:50:25] Yeah [21:50:32] this.foo && this.foo.bar is useful [21:50:37] But when it fails it doesn't return false [21:51:28] (03PS1) 10Bartosz Dziewoński: Update JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/190938 [21:51:30] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Don't add label position classes when there's no label [oojs/ui] - 10https://gerrit.wikimedia.org/r/190939 [22:03:22] (03CR) 10Bartosz Dziewoński: [C: 031] "James?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 (owner: 10Esanders) [22:04:17] (03CR) 10Jforrester: [C: 031] "Fine by me, but breaking changes should go through Trevor as it's his responsibility to tell people we broke their world (and his credibil" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 (owner: 10Esanders) [22:05:21] (03PS8) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) [22:07:59] ugh [22:08:02] >> document.createElement('input').maxLength [22:08:03] MatmaRex: ReferenceError: document is not defined [22:08:19] that's 524288 in Blink, -1 elsewhere. [22:18:52] Fun. [22:18:54] (03Abandoned) 10Alex Monk: WIP: Log Parsoid request timings to EventLogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (https://phabricator.wikimedia.org/T66171) (owner: 10GWicke) [22:19:29] 3VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki: Log Parsoid server-side save performance - https://phabricator.wikimedia.org/T66171#1042389 (10Krenair) a:5Krenair>3None [22:21:11] (03PS2) 10Bartosz Dziewoński: Update JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/190938 [22:21:13] (03PS2) 10Bartosz Dziewoński: TextInputWidget: Don't add label position classes when there's no label [oojs/ui] - 10https://gerrit.wikimedia.org/r/190939 [22:21:15] (03PS1) 10Bartosz Dziewoński: tests: Fix the check for properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 [22:21:17] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Allow maxLength of 0 in JS as well as PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 [22:21:19] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Only put $label in the DOM if needed [oojs/ui] - 10https://gerrit.wikimedia.org/r/190944 [22:21:24] there. stupid thing is all green now. [22:21:30] :-) [22:21:54] (03CR) 10Bartosz Dziewoński: TextInputWidget: Accept 'maxLength' configuration option (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/185563 (owner: 10Bartosz Dziewoński) [22:22:04] :D [22:30:00] (03PS11) 10Bartosz Dziewoński: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [22:30:02] (03PS4) 10Bartosz Dziewoński: ButtonWidget: Rename nofollow config option to noFollow [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [22:30:15] (03PS11) 10Bartosz Dziewoński: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [22:31:08] (03CR) 10Jforrester: [C: 04-1] ButtonWidget: Rename nofollow config option to noFollow (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [22:31:44] (03CR) 10Bartosz Dziewoński: "Not sure if we should be documenting the old name at all." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [22:32:20] MatmaRex: We can't use @deprecated on config, so it's the only way to tell people not to use it. [22:32:41] um? [22:32:56] or we could tell people not to use it by not admitting it exists. [22:32:56] MatmaRex: According to cscott, I believe? [22:33:04] or we could, y'know, just kill the stupid thing [22:33:06] Eh. Or that. :-) [22:33:11] because no one uses it anyway [22:33:15] No unannounced breaking changes. [22:33:40] * MatmaRex grumbles and HTTP_REFERER [22:33:43] about* [22:34:03] Indeed. [22:34:15] Kill the documentation and I'll +2. [22:39:56] (03PS5) 10Bartosz Dziewoński: ButtonWidget: Rename nofollow config option to noFollow [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [22:40:43] (03CR) 10Bartosz Dziewoński: "I took the liberty of striking it from the documentation. Can't let typos proliferate. ;)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [22:41:58] (03CR) 10Bartosz Dziewoński: "(Only rebased.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [22:42:29] (03CR) 10Jforrester: [C: 031] ButtonWidget: Rename nofollow config option to noFollow (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [22:44:44] 3TemplateData, VisualEditor, VisualEditor-MediaWiki, VisualEditor-MediaWiki-Templates: Allow template parameters to be rearranged and field names to be changed - https://phabricator.wikimedia.org/T89560#1042444 (10Jdforrester-WMF) Fields are shown in the community-set order in the TemplateData, as Moriel says.... [22:44:54] 3TemplateData, VisualEditor, VisualEditor-MediaWiki, VisualEditor-MediaWiki-Templates: Allow template parameters to be rearranged and field names to be changed - https://phabricator.wikimedia.org/T89560#1042446 (10Jdforrester-WMF) [22:44:56] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Let users relabel (or renumber if auto-numbered) parameters in the transclusion dialog - https://phabricator.wikimedia.org/T52268#586508 (10Jdforrester-WMF) [22:45:21] mooeypoo: https://phabricator.wikimedia.org/T89544 [22:45:47] 3VisualEditor, VisualEditor-MediaWiki-Media: License URLs in VisualEditor media insertion dialog are broken - https://phabricator.wikimedia.org/T89544#1042451 (10Jdforrester-WMF) p:5Triage>3High a:3Mooeypoo [22:45:48] 3VisualEditor: Category was duplicated and given different sort keys - https://phabricator.wikimedia.org/T89618#1042454 (10Whatamidoing-WMF) I think that the cats getting grouped on one line is a red herring (a second, unrelated bug). If memory serves, that happens when someone tries to delete the "unnecessary"... [22:47:23] 3VisualEditor, Wikimedia-Site-requests: Enable VE in other namespaces (which?) on some wiki (which?) - https://phabricator.wikimedia.org/T89593#1042456 (10Jdforrester-WMF) [22:48:47] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Deal with universal types like mw:Error, mw:ExpandedAttrs, mw:Placeholder - https://phabricator.wikimedia.org/T63969#1042458 (10Jdforrester-WMF) [22:48:49] 3VisualEditor: Unknown file can't be changed to a correct one - https://phabricator.wikimedia.org/T89570#1042457 (10Jdforrester-WMF) [22:49:08] 3VisualEditor, VisualEditor-MediaWiki-Media: Unknown file can't be changed to a correct one - https://phabricator.wikimedia.org/T89570#1042459 (10Jdforrester-WMF) p:5Triage>3Low [22:52:03] (03PS1) 10Mooeypoo: Correct the license URL in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190952 (https://phabricator.wikimedia.org/T89544) [23:20:04] 3MediaWiki-Vagrant, VisualEditor, MediaWiki-Configuration: Vagrant VE role localsettings conflicts with VisualEditor's user option defaults - https://phabricator.wikimedia.org/T88665#1042490 (10Jdforrester-WMF) 5Open>3Resolved Should now be fixed. [23:23:23] (03PS2) 10Jforrester: [WIP] Reduce complexity around onbeforeunload handler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177107 (owner: 10Catrope) [23:23:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Reduce complexity around onbeforeunload handler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/177107 (owner: 10Catrope) [23:23:52] (03PS7) 10Jforrester: [WIP] Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [23:23:56] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [23:25:04] (03PS2) 10Jforrester: [WIP] [PULL THROUGH] Add high-level transactions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187409 (owner: 10Cscott) [23:25:11] (03CR) 10jenkins-bot: [V: 04-1] [WIP] [PULL THROUGH] Add high-level transactions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187409 (owner: 10Cscott) [23:26:40] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/189737/ https://gerrit.wikimedia.org/r/#/c/189472/ https://gerrit.wikimedia.org/r/#/c/187951/ https://gerrit.wikimedia.org/r/#/c/188028/ https://gerrit.wikimedia.org/r/#/c/188029/ [23:27:02] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/190952/ now though. [23:27:24] (03CR) 10Catrope: [C: 032] Correct the license URL in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190952 (https://phabricator.wikimedia.org/T89544) (owner: 10Mooeypoo) [23:28:41] 3VisualEditor, VisualEditor-MediaWiki-Media: License URLs in VisualEditor media insertion dialog are broken - https://phabricator.wikimedia.org/T89544#1042548 (10Jdforrester-WMF) 5Open>3Resolved [23:29:11] (03Merged) 10jenkins-bot: Correct the license URL in the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190952 (https://phabricator.wikimedia.org/T89544) (owner: 10Mooeypoo) [23:30:05] (03CR) 10Jforrester: [C: 032] TextInputWidget: Don't add label position classes when there's no label [oojs/ui] - 10https://gerrit.wikimedia.org/r/190939 (owner: 10Bartosz Dziewoński) [23:30:36] (03CR) 10Jforrester: [C: 032] Update JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/190938 (owner: 10Bartosz Dziewoński) [23:30:58] (03CR) 10Jforrester: [C: 031] tests: Fix the check for properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 (owner: 10Bartosz Dziewoński) [23:31:13] (03CR) 10Jforrester: [C: 032] TextInputWidget: Allow maxLength of 0 in JS as well as PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [23:31:36] (03CR) 10Jforrester: [C: 031] TextInputWidget: Only put $label in the DOM if needed [oojs/ui] - 10https://gerrit.wikimedia.org/r/190944 (owner: 10Bartosz Dziewoński) [23:31:59] (03Merged) 10jenkins-bot: TextInputWidget: Don't add label position classes when there's no label [oojs/ui] - 10https://gerrit.wikimedia.org/r/190939 (owner: 10Bartosz Dziewoński) [23:32:01] (03Merged) 10jenkins-bot: Update JS/PHP comparison test suite [oojs/ui] - 10https://gerrit.wikimedia.org/r/190938 (owner: 10Bartosz Dziewoński) [23:32:25] MatmaRex: You seen my carving up of https://gerrit.wikimedia.org/r/#/c/188289/ into icon packs? [23:33:29] James_F: no, but will look [23:34:19] MatmaRex: Thanks. The actual work of making images.less split its files into different 'packs' is your job. :-) [23:34:35] (03CR) 10Jforrester: [C: 031] Apply citation when user hits 'enter' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190852 (owner: 10Mooeypoo) [23:34:52] yeah [23:35:02] James_F: is there a bug about this you can assign to me? [23:35:52] MatmaRex: Seemingly not. Want me to make one? [23:36:41] meh, no need [23:36:47] 3OOjs-UI: Provide support for "icon packs" so that not all of the OOjs UI theme needs to be loaded at once for users - https://phabricator.wikimedia.org/T89686#1042576 (10Jdforrester-WMF) 3NEW a:3TrevorParscal [23:36:50] Oh, too late. :-) [23:37:03] heh. okay then. [23:37:07] 3OOjs-UI: Provide support for "icon packs" so that not all of the OOjs UI theme needs to be loaded at once for users - https://phabricator.wikimedia.org/T89686#1042584 (10Jdforrester-WMF) a:5TrevorParscal>3matmarex [23:38:12] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#1042595 (10Jdforrester-WMF) Ping. What's happening with this? [23:40:15] (03PS13) 10Jforrester: Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [23:44:36] (03CR) 10Ricordisamoa: [C: 031] "The link to the spec should be:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [23:45:00] (03CR) 10Ricordisamoa: "(the attribute's value must be a valid non-negative integer)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [23:47:25] 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1042606 (10matmarex) 3NEW [23:47:37] (03CR) 10Ricordisamoa: TextInputWidget: Accept 'maxLength' configuration option (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/185563 (owner: 10Bartosz Dziewoński) [23:47:48] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I like this a lot. High-level thoughts:" (036 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:49:57] 3VisualEditor, VisualEditor-MediaWiki-References: [Regression wmf13] Creating a citation without filling in a required field throws "Cannot read property 'createElement' of null" - https://phabricator.wikimedia.org/T78626#1042619 (10Ryasmeen) 5Resolved>3Open [23:50:35] 3VisualEditor, VisualEditor-MediaWiki-References: [Regression wmf13] Creating a citation without filling in a required field throws "Cannot read property 'createElement' of null" - https://phabricator.wikimedia.org/T78626#849740 (10Ryasmeen) Still reproducible on Betalabs {F41908} [23:51:36] 3MediaWiki-extensions-Translate, Possible-Tech-Projects, VisualEditor-MediaWiki-Plugins: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#1042621 (10Qgil) If there is no interest / critical mentoring mass to prom... [23:58:06] James_F: to verify https://gerrit.wikimedia.org/r/#/c/190942/ , you could just open the tests in firefox (but not chrome). [23:58:21] `document.createElement('input').hasOwnProperty('value')` is false on Firefox, but true on Chrome. [23:58:40] 3VisualEditor, VisualEditor-MediaWiki: Page created/restored confirmation message appears after clicking on Edit for a new page - https://phabricator.wikimedia.org/T58921#1042629 (10Ryasmeen) [23:59:01] MatmaRex: I +1'ed because Ed/Trevor should review as well, not because I don't trust you. [23:59:10] 3VisualEditor, VisualEditor-MediaWiki: Page created/restored confirmation message appears after clicking on Edit for a new page - https://phabricator.wikimedia.org/T58921#625428 (10Ryasmeen) [23:59:12] (03PS2) 10Bartosz Dziewoński: tests: Fix the check for properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 [23:59:45] okay