[00:01:49] 3VisualEditor: Category was duplicated and given different sort keys - https://phabricator.wikimedia.org/T89618#1042635 (10Etonkovidova) I agree with the previous comment -the issue seems similar to T76998 and T85671. The categories are not deleted, but "jammed" together on one line - the diff shows it. ```{{P... [00:02:00] 3VisualEditor: Category was duplicated and given different sort keys - https://phabricator.wikimedia.org/T89618#1042638 (10Etonkovidova) p:5Triage>3Normal [00:03:34] 3VisualEditor, Wikimedia-Site-requests: Enable VE in other namespaces (which?) on some wiki (which?) - https://phabricator.wikimedia.org/T89593#1042641 (10Etonkovidova) p:5Triage>3Normal [00:04:27] Welcome back, Krinkle. [00:06:47] (03CR) 10Jforrester: [C: 032] "Prodding Jenkins." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186553 (owner: 10Ryasmeen) [00:06:52] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Splitting up the Required parameter checking test from Cite test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186553 (owner: 10Ryasmeen) [00:06:58] (03CR) 10Jforrester: [C: 04-1] "Needs rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186553 (owner: 10Ryasmeen) [00:07:10] (03CR) 10Jforrester: [C: 04-1] "Needs rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187650 (owner: 10Ryasmeen) [00:07:15] 01:03:11 git.exc.GitCommandError: 'git remote update origin' returned exit status 1: error: Failed to connect to 2620:0:861:3:208:80:154:81: Network is unreachable while accessing https://gerrit.wikimedia.org/r/p/mediawiki/vendor/info/refs [00:07:19] wth? [00:07:30] Krinkle: Helpful. [00:07:37] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/13268/console [00:12:00] 3VisualEditor, VisualEditor-MediaWiki: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1042653 (10Jdforrester-WMF) p:5Triage>3Normal [00:13:34] 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-MediaWiki-Templates: Comment syntax shown in template's name in VisualEditor - https://phabricator.wikimedia.org/T89615#1042661 (10Jdforrester-WMF) p:5Triage>3Low [00:13:58] 3VisualEditor-Tables, VisualEditor, VisualEditor-MediaWiki: Template-generated table cells in the table at https://en.wikipedia.org/wiki/Skyfall#Accolades do not have the blue shields/highlights/whatever applied - https://phabricator.wikimedia.org/T89614#1042663 (10Jdforrester-WMF) p:5Triage>3Normal [00:16:52] 3OOjs-UI, VisualEditor, VisualEditor-MediaWiki: The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens - https://phabricator.wikimedia.org/T89612#1042666 (10Jdforrester-WMF) p:5Triage>3Normal [00:17:03] 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1042668 (10Jdforrester-WMF) p:5Triage>3High [00:17:10] 3VisualEditor, VisualEditor-Performance: ve.init.mw.ViewPageTarget.transformPage triggers recalculate style due to $.fn.animate - https://phabricator.wikimedia.org/T89543#1042669 (10Jdforrester-WMF) p:5Triage>3High [00:23:38] James_F has found an onkeypress oddity: Chrome on Mac (but not on Linux) seems to trigger keypress with code 63272 for CTRL+DEL (in vague accordance with http://www.quirksmode.org/js/keys.html#t26 ) [00:24:27] divec_: But only for Ctrl+Delete; all the others are "normal". [00:24:58] divec_: Ctrl+Delete and Ctrl+Fn+Backspace have the same result, BTW. [00:25:35] James_F: is cscott in the office, by chance? [00:25:59] MatmaRex: You mean, is he working today? He's not been in the office since January when he went back to Boston. [00:26:06] MatmaRex: And no, I don't think he is. [00:26:42] oh. well, he should update his contact list entry then, because it says he's in SF. okay. [00:28:02] MatmaRex: The office contact list got munged at some point. He's never been SF-based. [00:28:23] * MatmaRex grumbles [00:29:34] (03CR) 10Esanders: [C: 032] ElementLinearData tests: compare stores more elegantly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190921 (owner: 10Catrope) [00:29:43] Welcome back, edsanders. [00:29:53] sup [00:30:11] Are you in the office James_F? [00:30:26] edsanders: Roan and Moriel are having fun to my right fixing some issue with the Citoid tool. [00:30:28] Krenair: Yeah. [00:30:38] Isn't it a holiday there? [00:30:39] Krenair: 'Cos I'm cool. Or something. [00:30:43] :D [00:30:52] problem? [00:30:57] 3VisualEditor, VisualEditor-MediaWiki-References: Cite Web dialog always shows the details of the URL that was entered first in the “Autofill from URL”. - https://phabricator.wikimedia.org/T89555#1042673 (10Etonkovidova) Perfect! Thanks. Yes, the big is clearly there. No errors in the Console. Should 'Autofill... [00:30:58] James_F: Can you trigger the same weirdness if you do CTRL+END or CTRL+LEFT? [00:31:10] 3VisualEditor, VisualEditor-MediaWiki-References: Cite Web dialog always shows the details of the URL that was entered first in the “Autofill from URL”. - https://phabricator.wikimedia.org/T89555#1042674 (10Etonkovidova) p:5Triage>3High [00:31:12] divec_: Looking. [00:32:22] divec_: Yes. Ctrl+Home == 63273; Ctrl+End == 63275. [00:32:31] divec_: Ctrl+cursors doesn't insert. [00:32:44] edsanders: Race condition between async processing where the .done() callback expects object properties to exist, and a teardown process nulling out those properties [00:33:06] (03CR) 10Esanders: [C: 032] TextInputWidget: Only put $label in the DOM if needed [oojs/ui] - 10https://gerrit.wikimedia.org/r/190944 (owner: 10Bartosz Dziewoński) [00:33:14] In mooeypoo's code though [00:33:30] She's refactoring / rewriting a bunch of the Citoid VE code [00:34:49] (03CR) 10Bartosz Dziewoński: "(will give proper review tomorrow, have some thoughts I need to sleep on)" (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [00:35:47] (03PS1) 10Esanders: Missing mixing documentation in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190961 [00:36:06] (03PS3) 10Catrope: [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 [00:36:08] (03PS1) 10Catrope: Remove data-parsoid hack in ve.dm.Annotation#isGenerated [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190962 [00:36:16] (03PS2) 10Catrope: Missing mixin documentation in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190961 (owner: 10Esanders) [00:36:32] (03CR) 10Catrope: [C: 032] Missing mixin documentation in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/190961 (owner: 10Esanders) [00:36:49] edsanders: https://gerrit.wikimedia.org/r/#/c/190942/ [00:37:12] In that case, I propose to block silly keypress events with codes around that value. Quirksmode says: "Onkeypress, Safari gives weird keyCode values in the 63200 range for delete, end, function keys, home and pageUp.Down. The onkeydown and -up values are normal." [00:37:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 (owner: 10Catrope) [00:37:25] (03PS3) 10Bartosz Dziewoński: TextInputWidget: Add missing LabelElement mixin documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190961 (owner: 10Esanders) [00:37:27] (03CR) 10Esanders: [C: 032] Apply citation when user hits 'enter' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190852 (owner: 10Mooeypoo) [00:37:42] (03Merged) 10jenkins-bot: Apply citation when user hits 'enter' [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190852 (owner: 10Mooeypoo) [00:37:46] (03CR) 10Bartosz Dziewoński: [C: 032] TextInputWidget: Add missing LabelElement mixin documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190961 (owner: 10Esanders) [00:38:05] (03CR) 10Jforrester: [C: 04-1] Remove data-parsoid hack in ve.dm.Annotation#isGenerated (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190962 (owner: 10Catrope) [00:38:35] (03PS1) 10Catrope: [PULL THROUGH] Update for htmlAttributes going away [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 [00:38:39] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Update for htmlAttributes going away [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope) [00:38:59] MatmaRex, that looks like Krinkle territory [00:39:31] in MWTransclusionModel#addPart, we are returning a promise that seems to not be resolved, or throw an exception. I'm so confused with this code. is this on purpose? [00:39:32] divec_: Works for me. [00:39:56] (03CR) 10Esanders: "Need Timo review." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 (owner: 10Bartosz Dziewoński) [00:39:58] edsanders: but Krinkle will have a stroke when he sees it, because these tests don't run on jenkins. [00:40:29] :-) [00:41:12] James_F: One other thing - does the CTRL+END bug happen in master? (I presume so - in which case, this is a bug exposure rather than a regression per se) [00:41:21] yes, but then you can make it his problem to fix [00:41:26] (03Merged) 10jenkins-bot: TextInputWidget: Add missing LabelElement mixin documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/190961 (owner: 10Esanders) [00:41:39] (03CR) 10Krinkle: "The properties should always be there. That's standards behaviour. Unlike attributes, which are meant for serialisation/parsing purposes o" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 (owner: 10Bartosz Dziewoński) [00:41:45] edsanders: he already made it my problem and i've been running away from it since [00:42:00] MatmaRex: Which tests don't run on Jenkins? phpjs/ [00:42:01] ? [00:42:06] yes [00:42:15] I am not qualified to say if it is a good idea... [00:42:20] I didn't particularly like the way they get generated, but they're not even run? [00:42:33] (03CR) 10Bartosz Dziewoński: "Standards are standards, but `document.createElement( 'input' ).hasOwnProperty( 'value' )` is still false on certain browsers." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 (owner: 10Bartosz Dziewoński) [00:42:44] Krinkle: they're not. you said it's impossible. [00:43:55] (03CR) 10Krinkle: "What I mean is, test change is in the right direction. Because they're supposed to exist. However undefined is in invalid value for those " [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 (owner: 10Bartosz Dziewoński) [00:44:12] MatmaRex: They generate json and are reun from test/index.php or something? [00:45:02] element[prop] !== undefined will always be true, unless the key is invalid, it which case it'll be undefined always [00:45:48] Krinkle: there's a Ruby script that generates the JSON (build step). then there's index.php which has PHP code that generates HTML from the JSON, and which loads QUnit JS tests that generate DOM from JSON and compare it to DOM from HTML [00:47:12] MatmaRex: If we can abstract the build steps away to pre-commit Grunt (shell out to ruby or php if need be), then it should be possible to run it in Jenkins with plain html/js [00:47:18] But yeah, ideally noneof that should be neccecary [00:48:18] (03CR) 10Bartosz Dziewoński: "But these properties do not apply to all HTML elements, `element` in this code might be a `
` node which doesn't have a 'value' prope" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 (owner: 10Bartosz Dziewoński) [00:50:02] MatmaRex: Hm.. if this is given other types of elements though, then why would it need manual inclusion of those attributes? [00:50:10] 3VisualEditor, VisualEditor-MediaWiki: Create a guided tour for VisualEditor using Getting Started tooltips - https://phabricator.wikimedia.org/T89074#1042689 (10Jdforrester-WMF) [00:50:18] MatmaRex: They'd be synchronised the same way? [00:50:19] 3VisualEditor, VisualEditor-MediaWiki-References, Citoid: Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-selected - https://phabricator.wikimedia.org/T88152#1042690 (10Jdforrester-WMF) [00:50:25] Or are they live values. [00:50:29] * Krinkle needs to zoom out of hte diff [00:50:33] 3VisualEditor: Make slugs keyboard accessible again - https://phabricator.wikimedia.org/T89352#1042691 (10Jdforrester-WMF) [00:50:41] i don't understand the question [00:50:44] 3VisualEditor, VisualEditor-ContentEditable: Focus highlights for elements using CSS column-count are too tall in Chrome - https://phabricator.wikimedia.org/T52036#1042692 (10Jdforrester-WMF) [00:50:53] okay, so [00:50:55] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Comments in "unsafe" content locations are not displayed - https://phabricator.wikimedia.org/T73085#1042693 (10Jdforrester-WMF) [00:51:29] MatmaRex: Node IDL attributes reflect their value from the content attributes aka, Node properties are synced from attributes [00:51:33] (some of them!) [00:51:42] not 'value' or 'checked' [00:52:08] Krinkle: we want to compare how the PHP and JS versions of the same code work (we want them to work the same). but in PHP, we have "", while in JS we have $('input').val('foo'), which means that their DOM attributes are not the same, so we compare properties [00:52:28] and we have to ignore the attributes [00:52:34] Right [00:52:35] That makes sense [00:52:41] this was a simple hacky way to do it, it could be done better probably [00:52:50] I suppose we could add a .properties={} [00:52:52] but i copy-pasted and adapted the code [00:52:56] But I see what it's doing now [00:52:56] thx [00:53:04] it was probably late when i wrote this :P [00:53:15] (03PS4) 10Catrope: [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 [00:53:25] (03PS2) 10Catrope: [PULL THROUGH] Update for htmlAttributes going away [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 [00:53:29] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Update for htmlAttributes going away [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope) [00:53:31] MatmaRex: And this is only used for that test? [00:53:39] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: In Firefox "TypeError: this.$documentNode is undefined" appears while selecting a citation note for a second time but not consecutively - https://phabricator.wikimedia.org/T73375#1042697 (10Etonkovidova) The error is not displayed anymore. [00:53:41] I thought I played with this test much earlier [00:53:45] assertion* [00:53:46] yes [00:53:51] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: In Firefox "TypeError: this.$documentNode is undefined" appears while selecting a citation note for a second time but not consecutively - https://phabricator.wikimedia.org/T73375#1042698 (10Etonkovidova) 5Open>3Resolved [00:55:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 (owner: 10Catrope) [00:55:45] (03PS2) 10Catrope: Remove data-parsoid hack in ve.dm.Annotation#isGenerated [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190962 [00:55:47] (03PS5) 10Catrope: [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 [00:56:16] (03CR) 10Jforrester: [C: 032] Remove data-parsoid hack in ve.dm.Annotation#isGenerated [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190962 (owner: 10Catrope) [00:56:35] (03CR) 10Esanders: [C: 032] Remove data-parsoid hack in ve.dm.Annotation#isGenerated [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190962 (owner: 10Catrope) [00:57:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 (owner: 10Catrope) [00:57:49] (03PS6) 10Catrope: [WIP] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 [00:58:23] (03CR) 10Esanders: [C: 032] Add fromDataBody property for DomFromModel tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190931 (owner: 10Catrope) [00:59:08] good night [01:00:56] (03CR) 10Esanders: [C: 032] Add round-trip test to getModelFromDom tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190845 (owner: 10Catrope) [01:01:01] Good night MatmaRex. [01:02:13] mooeypoo: https://phabricator.wikimedia.org/T88152 [01:03:44] 3VisualEditor-EditingTools, VisualEditor: Cannot clear the styling of a code formatted text when the cursor is active inside the block or part of the block is selected - https://phabricator.wikimedia.org/T89547#1042712 (10Jdforrester-WMF) p:5Triage>3Normal [01:03:47] 3VisualEditor: Cannot clear the styling of a code formatted text when the cursor is active inside the block or part of the block is selected - https://phabricator.wikimedia.org/T89547#1042714 (10Jdforrester-WMF) p:5Normal>3Triage [01:04:07] 3VisualEditor: Cannot clear the styling of a code formatted text when the cursor is active inside the block or part of the block is selected - https://phabricator.wikimedia.org/T89547#1038954 (10Jdforrester-WMF) p:5Triage>3Normal [01:06:36] 3VisualEditor-EditingTools, VisualEditor: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1042718 (10Jdforrester-WMF) [01:06:37] 3VisualEditor, VisualEditor-ContentEditable, Citoid: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#1042719 (10Jdforrester-WMF) [01:27:23] (03PS7) 10Catrope: [BREAKING CHANGE] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 [01:32:12] James_F: So based on your Mac Chrome trace, pressing CTRL+DEL in a raw textarea *actually inserts a private use character* [01:32:25] divec_: Fun times, right? [01:33:07] Please tell me you're using some crazy Martian IME ... [01:34:12] It's called "native OS behaviour", sadly. [01:34:41] (03PS3) 10Catrope: [PULL THROUGH] Update for htmlAttributes going away [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 [01:34:44] James_F: Could you repeat the trace, putting text ahead of the cursor before pressing CTRL+DEL? (The change ordering could be pretty crucial here) [01:34:45] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Update for htmlAttributes going away [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope) [01:34:54] divec_: Sure. [01:34:58] On eventLogger.html that is [01:35:19] divec_: Doing. [01:35:37] divec_: Sending. [01:37:44] (03PS4) 10Catrope: [PULL THROUGH] Update for htmlAttributes going away [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 [01:39:22] (03PS5) 10Catrope: [PULL THROUGH] Update for htmlAttributes going away [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 [01:41:11] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Update for htmlAttributes going away [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope) [01:46:40] mooyepoo: T89544 License URLs in VisualEditor media insertion dialog are broken - hmm... does not work for me [01:47:34] (03PS1) 10Jforrester: Remove some errant references to MediaWiki/Parsoid that don't belong [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190967 [01:47:46] mooeypoo: there is another link to CC-BY-SA 3.0 License in 'Save your changes' box [01:48:56] etonkovidova, what do you mean? [01:49:37] mooyepoo: CC-BY-SA-3.0 goes to [01:49:38] http://en.wikipedia.beta.wmflabs.org/w/www.creativecommons.org/licenses/by-sa/3.0 ERROR 404 – File not found [01:53:09] should be something like: CC BY-SA 3.0 License [01:55:10] haah [01:55:59] :) [01:56:18] That needs http:// prefixing [01:56:22] Or // really [01:56:25] O.O [01:56:36] * mooeypoo mutters *api* cough *api* [01:56:44] O_O [02:00:47] etonkovidova, can you tell me what image this happened with ? [02:01:24] just type CC-BY [02:05:10] etonkovidova, I can't find any of those errors. Do you have a specific image example maybe? [02:05:16] it might be localized to beta [02:07:24] hmmm... so you enter CC-BY and see a link that is displayed in UI as CC-BY-SA-3.0 and in fact CC-BY-SA-3.0 [02:07:42] yeah I searched for CC-BY but all images have proper links [02:07:47] click and a normal page is displayed, not an ERROR 404 not found page [02:07:55] if you can give me a specific image that you see it in, that'll help [02:08:05] any image you see that has url without http:// [02:08:16] File:Tmp4.xcf [02:08:29] which file has a good link? [02:09:38] I checked four first images returned by 'CC-BY' search - and all have a bad link [02:11:03] all have good links for me [02:12:04] well, ok then :( [02:16:24] etonkovidova, I'm going to submit a fix that will probably fix it [02:16:26] but i can't test [02:16:53] tomorrow I can show you :) [02:25:04] (03PS1) 10Mooeypoo: Normalize external links from the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190970 [02:26:37] (03CR) 10Catrope: [C: 04-1] Normalize external links from the API (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190970 (owner: 10Mooeypoo) [02:31:10] (03CR) 10Catrope: [C: 032] Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [02:31:16] Whee. [02:32:18] (03CR) 10Jforrester: [C: 031] ve.dm.ElementLinearData: Remove unused rules.removeStyles feature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190628 (owner: 10Catrope) [02:33:07] (03Merged) 10jenkins-bot: Native backspace and delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [02:34:06] (03PS1) 10Jforrester: Update VE core submodule to master (e56418a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190971 [02:34:17] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (e56418a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190971 (owner: 10Jforrester) [02:36:01] (03Merged) 10jenkins-bot: Update VE core submodule to master (e56418a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190971 (owner: 10Jforrester) [02:44:26] (03PS1) 10Mooeypoo: Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) [02:44:28] (03CR) 10jenkins-bot: [V: 04-1] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [02:44:44] (03PS3) 10Mooeypoo: Add Gruntfile and fix style errors [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 [02:49:30] (03PS2) 10Mooeypoo: Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) [02:52:13] (03PS1) 10Catrope: Follow-up c762da42: fix ProcessDialog error handling [oojs/ui] - 10https://gerrit.wikimedia.org/r/190974 [02:55:57] (03CR) 10Divec: "The Ctrl+Delete problem on Mac is a Chromium bug:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179223 (owner: 10Divec) [03:21:26] (03PS1) 10Catrope: ce.MWTransclusionNode: Protect against race condition in GCN rendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190975 [03:25:22] (03PS9) 10Krinkle: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [04:05:08] (03CR) 10Krinkle: [C: 04-1] "The existing code is a mess. I don't know off hand what it should be, but it's failing to handle the error at the moment." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [04:14:26] (03CR) 10Krinkle: [C: 031] "Step forward. Overall code is in need of some extra love, but this looks good, fixed the issue and is indeed semantically correct. It'll a" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 (owner: 10Bartosz Dziewoński) [04:15:47] (03PS2) 10Krinkle: TextInputWidget: Allow maxLength of 0 in JS as well as PHP [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [04:16:04] (03PS3) 10Krinkle: TextInputWidget: Allow maxLength of 0 in JS (matching PHP) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [04:16:32] (03CR) 10Krinkle: [C: 032] "Minor clarification on commitmsg (wasn't clear whether it updates both JS and PHP or just JS)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [04:21:37] Krinkle, are you suggesting that I rename those params to match what mediawiki.api uses? I think it kind of makes sense for http errors as well [04:22:35] Krenair: Im find with the variablenames. They're called three different ways (mw-api error with code,info; http error with errorText,error ; and from mw.Target.loadError with null,string,null) [04:22:41] As long as they're used correctly [04:52:28] (03PS10) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) [04:56:14] (03CR) 10jenkins-bot: [V: 04-1] Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [05:05:27] (03PS11) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) [05:20:00] (03CR) 10Ricordisamoa: "What about linking to the HTML5 specification in the commit message?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [06:08:34] 3VisualEditor, Parsoid, VisualEditor-ContentEditable: VisualEditor: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1042911 (10Whatamidoing-WMF) I'm adding Parsoid to this, because Subbu thought that it might be solvable there. [07:41:18] 3VisualEditor, VisualEditor-MediaWiki: Create a guided tour for VisualEditor using Getting Started tooltips - https://phabricator.wikimedia.org/T89074#1042974 (10TheDJ) I think we should really take another look at the 'on boarding' ui, because 2 edit buttons is just 'weird'. If we keep that, we should explain i... [08:56:46] (03PS2) 10Prtksxna: MediaWiki Theme: Add focus state for frameless button [oojs/ui] - 10https://gerrit.wikimedia.org/r/189949 (https://phabricator.wikimedia.org/T87692) [08:59:18] (03CR) 10Prtksxna: "Esanders, I've added a framless button with an indicator to the demo page. It was sticking out of the element due to a negative right marg" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189949 (https://phabricator.wikimedia.org/T87692) (owner: 10Prtksxna) [09:22:57] (03PS8) 10Amire80: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 [09:24:36] (03CR) 10Amire80: [BrowserTest] Move screenshot taking functionality to a gem (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [09:30:12] 3UI-Standardization, OOjs-UI, WMF-Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1043075 (10Prtksxna) >>! In T88449#1035507, @violetto wrote: > If it's not #DDD in mw.ui, we should change it @Prtksxna. I can't recall if it was a recent change, I just real... [09:41:55] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Remove most exceptions from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189760 (owner: 10Amire80) [09:43:29] (03Merged) 10jenkins-bot: [BrowserTest] Remove most exceptions from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189760 (owner: 10Amire80) [09:46:18] 3VisualEditor, VisualEditor-Performance: Show the VisualEditor toolbar/editor chrome as soon as VE scripts are loaded, rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#1043104 (10Esanders) [09:57:19] (03PS9) 10Amire80: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 [09:57:46] (03PS10) 10Amire80: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 [10:02:32] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [10:06:31] (03Abandoned) 10Prtksxna: MediaWiki Theme: Update the check icon (from Wikifont) and the checkbox CSS [oojs/ui] - 10https://gerrit.wikimedia.org/r/183811 (owner: 10Prtksxna) [10:06:34] (03PS1) 10Amire80: [BrowserTest] Remove an empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191003 [10:08:09] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Remove an empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191003 (owner: 10Amire80) [10:08:55] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191003 (owner: 10Amire80) [10:08:58] (03Merged) 10jenkins-bot: [BrowserTest] Move screenshot taking functionality to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189738 (owner: 10Amire80) [10:09:32] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191003 (owner: 10Amire80) [10:20:13] (03PS2) 10Amire80: [BrowserTest] Remove an empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191003 [10:21:51] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Remove an empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191003 (owner: 10Amire80) [10:23:08] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191003 (owner: 10Amire80) [10:47:47] (03PS1) 10Amire80: Remove a Rubocop exception that doesn't produce offenses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191010 [10:54:14] (03PS1) 10Amire80: Make the Gemfile more like the one in the MW repo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191012 [10:55:02] (03CR) 10jenkins-bot: [V: 04-1] Make the Gemfile more like the one in the MW repo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191012 (owner: 10Amire80) [10:56:56] (03CR) 10Amire80: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191012 (owner: 10Amire80) [11:25:19] (03PS1) 10Amire80: [BrowserTest] Fix ParenthesesAsGroupedExpression Rubocop failures [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191019 [11:25:21] (03PS1) 10Amire80: [BrowserTest] Add parentheses to regexp parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191020 [11:55:51] 3OOjs-UI: PopupButtonWidget menu is not keyboard traversable/closeable - https://phabricator.wikimedia.org/T87695#1043347 (10Prtksxna) >>! In T87695#1031204, @matmarex wrote: > Is this still a problem after the recent button pressability refactor? The popup still doesn't go away when hitting `ESC`. [11:56:33] (03PS1) 10Prtksxna: PopupWidget: Add keydown listener and hide popup on ESC [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) [12:00:53] 3VisualEditor-Tables, VisualEditor, VisualEditor-ContentEditable: VisualEditor: Chrome lets you place the cursor either side of a Table (eww) and VE doesn't correct this - https://phabricator.wikimedia.org/T73560#1043359 (10Esanders) [12:00:53] 3VisualEditor, VisualEditor-ContentEditable: Cursoring with arrows from outside a table into it and typing causes pawns - https://phabricator.wikimedia.org/T75691#1043358 (10Esanders) [12:29:37] (03PS1) 10Esanders: Ignore duplicates when comparing class lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191028 [12:31:24] (03PS1) 10Esanders: Fix indentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191029 [13:06:08] (03PS1) 10Esanders: Add tests for MW node variants (heading/table/pre) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191036 (https://phabricator.wikimedia.org/T74398) [13:06:10] (03PS1) 10Esanders: Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) [13:08:06] (03PS4) 10Esanders: TextInputWidget: Allow maxLength of 0 in JS (matching PHP) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [13:08:22] (03CR) 10jenkins-bot: [V: 04-1] Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [13:08:49] (03CR) 10Esanders: [C: 032] tests: Fix the check for properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 (owner: 10Bartosz Dziewoński) [13:09:02] (03PS2) 10Esanders: TextInputWidget: Only put $label in the DOM if needed [oojs/ui] - 10https://gerrit.wikimedia.org/r/190944 (owner: 10Bartosz Dziewoński) [13:10:08] (03CR) 10Esanders: [C: 032] ce.MWTransclusionNode: Protect against race condition in GCN rendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190975 (owner: 10Catrope) [13:10:38] (03CR) 10Esanders: [C: 032] Follow-up c762da42: fix ProcessDialog error handling [oojs/ui] - 10https://gerrit.wikimedia.org/r/190974 (owner: 10Catrope) [13:11:43] (03Merged) 10jenkins-bot: ce.MWTransclusionNode: Protect against race condition in GCN rendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190975 (owner: 10Catrope) [13:12:55] (03PS3) 10Esanders: Add round-trip test to getModelFromDom tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190845 (owner: 10Catrope) [13:14:03] (03CR) 10Esanders: "I'm just thinking if any other users of VE would ever find this feature helpful..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190628 (owner: 10Catrope) [13:14:38] (03CR) 10jenkins-bot: [V: 04-1] TextInputWidget: Allow maxLength of 0 in JS (matching PHP) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [13:15:17] (03CR) 10Bartosz Dziewoński: [C: 032] TextInputWidget: Allow maxLength of 0 in JS (matching PHP) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [13:15:32] (03Merged) 10jenkins-bot: tests: Fix the check for properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/190942 (owner: 10Bartosz Dziewoński) [13:19:17] (03CR) 10Esanders: [C: 032] Add round-trip test to getModelFromDom tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190845 (owner: 10Catrope) [13:20:26] (03Merged) 10jenkins-bot: TextInputWidget: Allow maxLength of 0 in JS (matching PHP) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190943 (owner: 10Bartosz Dziewoński) [13:20:28] (03Merged) 10jenkins-bot: Follow-up c762da42: fix ProcessDialog error handling [oojs/ui] - 10https://gerrit.wikimedia.org/r/190974 (owner: 10Catrope) [13:21:44] (03Merged) 10jenkins-bot: Add round-trip test to getModelFromDom tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190845 (owner: 10Catrope) [13:25:14] (03CR) 10Esanders: [C: 032] ve.dm.ElementLinearData: Remove unused rules.removeStyles feature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190628 (owner: 10Catrope) [13:27:10] (03Merged) 10jenkins-bot: ve.dm.ElementLinearData: Remove unused rules.removeStyles feature [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190628 (owner: 10Catrope) [13:29:08] (03CR) 10jenkins-bot: [V: 04-1] Add fromDataBody property for DomFromModel tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190931 (owner: 10Catrope) [13:29:10] (03CR) 10jenkins-bot: [V: 04-1] Remove data-parsoid hack in ve.dm.Annotation#isGenerated [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190962 (owner: 10Catrope) [13:29:33] (03PS2) 10Esanders: Add fromDataBody property for DomFromModel tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190931 (owner: 10Catrope) [13:29:35] (03PS3) 10Esanders: Remove data-parsoid hack in ve.dm.Annotation#isGenerated [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190962 (owner: 10Catrope) [13:29:37] (03PS3) 10Esanders: ElementLinearData tests: compare stores more elegantly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190921 (owner: 10Catrope) [13:29:39] (03PS8) 10Esanders: [BREAKING CHANGE] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 (owner: 10Catrope) [13:37:37] [13oojs.github.io] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/oojs/oojs.github.io/commit/625f377508748893495c2ec27876b0faafcf7d42 [13:37:38] 13oojs.github.io/06master 14625f377 15James D. Forrester: Publish v1.1.4 release from npm [13:38:43] [13oojs.github.io] 15Krinkle closed pull request #7: Publish v1.1.4 release from npm (06master...06oojs-1.1.4) 02https://github.com/oojs/oojs.github.io/pull/7 [13:38:53] [13oojs.github.io] 15Krinkle 04deleted 06oojs-1.1.4 at 14caeaa8c: 02https://github.com/oojs/oojs.github.io/commit/caeaa8c [13:48:04] (03CR) 10Esanders: [C: 032] ElementLinearData tests: compare stores more elegantly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190921 (owner: 10Catrope) [13:53:07] (03Merged) 10jenkins-bot: ElementLinearData tests: compare stores more elegantly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190921 (owner: 10Catrope) [13:53:09] (03CR) 10jenkins-bot: [V: 04-1] Add fromDataBody property for DomFromModel tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190931 (owner: 10Catrope) [13:53:11] (03CR) 10jenkins-bot: [V: 04-1] Remove data-parsoid hack in ve.dm.Annotation#isGenerated [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190962 (owner: 10Catrope) [13:56:59] 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1043476 (10matmarex) a:3matmarex [13:58:29] 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1043480 (10matmarex) [13:58:30] 3UI-Standardization, OOjs-UI: Disabled button color not right - https://phabricator.wikimedia.org/T88483#1043479 (10matmarex) [14:03:23] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190931 (owner: 10Catrope) [14:04:46] (03CR) 10Esanders: [C: 032] Add fromDataBody property for DomFromModel tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190931 (owner: 10Catrope) [14:06:45] (03Merged) 10jenkins-bot: Add fromDataBody property for DomFromModel tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190931 (owner: 10Catrope) [14:06:47] (03Merged) 10jenkins-bot: Remove data-parsoid hack in ve.dm.Annotation#isGenerated [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190962 (owner: 10Catrope) [14:12:48] 3UI-Standardization, OOjs-UI: Disabled button color not right - https://phabricator.wikimedia.org/T88483#1043518 (10matmarex) [14:12:49] 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1043516 (10matmarex) 5Open>3Resolved a:3Prtksxna [14:12:50] 3UI-Standardization, OOjs-UI, WMF-Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1043519 (10matmarex) [14:12:53] 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1002931 (10matmarex) Looks all fixed now. >>! In T88038#1030823, @Prtksxna wrote: > According to M37 frameless buttons should be `#CCC` which looks better. Fixed in 528cb6717f... [14:14:29] 3UI-Standardization, OOjs-UI: Disabled button style not right - https://phabricator.wikimedia.org/T88483#1043523 (10matmarex) [14:16:05] (03PS4) 10Bartosz Dziewoński: MediaWiki Theme: Use white icons for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna) [14:17:24] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Remove an empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191003 (owner: 10Amire80) [14:19:54] (03Merged) 10jenkins-bot: [BrowserTest] Remove an empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191003 (owner: 10Amire80) [14:23:59] (03PS5) 10Bartosz Dziewoński: MediaWiki Theme: Use white icons for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna) [14:24:35] (03CR) 10Bartosz Dziewoński: [C: 032] "Tweaked it." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna) [14:25:56] (03Merged) 10jenkins-bot: MediaWiki Theme: Use white icons for disabled buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna) [14:27:01] 3UI-Standardization, OOjs-UI: Disabled button style not right - https://phabricator.wikimedia.org/T88483#1043528 (10matmarex) 5Open>3Resolved [14:27:56] 3UI-Standardization, OOjs-UI: Disabled button style not right - https://phabricator.wikimedia.org/T88483#1012803 (10matmarex) Should be all fixed now. If you spot any inconsistencies between OOUI and mediawiki.ui, let's put them on T88449. [14:31:55] 3OOjs-UI, VisualEditor, VisualEditor-Performance: ~50ms spent animating a.oo-ui-buttonElement-button - https://phabricator.wikimedia.org/T88386#1043542 (10matmarex) [14:33:07] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#1043543 (10matmarex) [14:33:51] 3OOjs-UI: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#808058 (10matmarex) I don't really see the value in changing this, sorry. (But won't oppose if someone does it, I guess.) [14:35:06] 3Continuous-Integration, OOjs-UI: PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#1043547 (10matmarex) p:5Normal>3High [14:35:25] 3UI-Standardization, OOjs-UI: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1043549 (10matmarex) [14:36:39] 3OOjs-UI: Make buttons steal focus after click unless configured otherwise - https://phabricator.wikimedia.org/T76636#1043556 (10matmarex) p:5Normal>3Low [14:37:14] 3UI-Standardization, OOjs-UI: Move the "MediaWiki" OOjs UI theme to the MediaWiki repo - https://phabricator.wikimedia.org/T76633#1043558 (10matmarex) p:5Normal>3Low [14:38:15] 3VisualEditor: MediaWiki theme: A SurfaceWidget should have the Blue Bar Of Activity applied to is when active - https://phabricator.wikimedia.org/T78358#1043560 (10matmarex) [14:39:25] 3OOjs-UI: OOjs UI: Enhance or remove OutlineWidget - https://phabricator.wikimedia.org/T70070#1043566 (10matmarex) [14:48:35] 3OOjs-UI: Audit all required constructor arguments and throw exceptions if they are not provided - e.g. FieldLayout - https://phabricator.wikimedia.org/T76648#1043592 (10matmarex) a:3matmarex [15:04:12] (03CR) 10Zfilipin: [C: 032] Remove a Rubocop exception that doesn't produce offenses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191010 (owner: 10Amire80) [15:05:48] 3VisualEditor, MediaWiki-extensions-ContentTranslation: refactor upload.rb: move it from the VE repo to a reusable module so that it would be possible to use it for other features - https://phabricator.wikimedia.org/T89718#1043602 (10Amire80) 3NEW [15:06:13] (03Merged) 10jenkins-bot: Remove a Rubocop exception that doesn't produce offenses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191010 (owner: 10Amire80) [15:09:23] (03CR) 10Zfilipin: [C: 032] Make the Gemfile more like the one in the MW repo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191012 (owner: 10Amire80) [15:10:09] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Fix ParenthesesAsGroupedExpression Rubocop failures [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191019 (owner: 10Amire80) [15:11:00] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add parentheses to regexp parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191020 (owner: 10Amire80) [15:11:28] (03Merged) 10jenkins-bot: Make the Gemfile more like the one in the MW repo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191012 (owner: 10Amire80) [15:11:57] (03Merged) 10jenkins-bot: [BrowserTest] Fix ParenthesesAsGroupedExpression Rubocop failures [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191019 (owner: 10Amire80) [15:13:38] (03Merged) 10jenkins-bot: [BrowserTest] Add parentheses to regexp parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191020 (owner: 10Amire80) [15:20:05] 3VisualEditor, VisualEditor-ContentEditable: Unable to add a video as media - https://phabricator.wikimedia.org/T88925#1043622 (10Raymond) I cannot replicate it now. Seems fixed. Whatever it was :-) [15:36:53] (03PS1) 10Amire80: Fix the Rubocop offense SpaceAroundOperators [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191059 [15:36:55] (03PS1) 10Amire80: Fix the Rubocop offense StringLiterals [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191060 [15:38:19] (03PS4) 10Mvolz: Add Gruntfile and fix style errors [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 (https://phabricator.wikimedia.org/T89145) (owner: 10Mooeypoo) [15:40:07] (03PS5) 10Jforrester: Add Gruntfile and fix style errors [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 (https://phabricator.wikimedia.org/T89145) (owner: 10Mooeypoo) [15:41:17] Dear gerrit, you suck: [15:41:26] (03CR) 10Mvolz: [C: 031] "Repo already had a LICENSE file (LICENSE.txt) so I fixed the existing one and changed the link to it in package.json." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 (https://phabricator.wikimedia.org/T89145) (owner: 10Mooeypoo) [15:41:52] "Code Review - Error Invalid use of BasicClientConnManager: connection still allocated. Make sure to release the connection before allocating another one." [15:41:54] (03CR) 10Mvolz: [V: 031] Add Gruntfile and fix style errors [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 (https://phabricator.wikimedia.org/T89145) (owner: 10Mooeypoo) [15:42:53] (03CR) 10Mvolz: [C: 031] "Accidentally + 1 Verified instead of +1 Code-review. Oops. :)." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 (https://phabricator.wikimedia.org/T89145) (owner: 10Mooeypoo) [15:43:19] (03CR) 10Jforrester: [C: 032] Add Gruntfile and fix style errors [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 (https://phabricator.wikimedia.org/T89145) (owner: 10Mooeypoo) [15:43:28] (03Merged) 10jenkins-bot: Add Gruntfile and fix style errors [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190847 (https://phabricator.wikimedia.org/T89145) (owner: 10Mooeypoo) [15:46:53] (03PS3) 10Mvolz: Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [16:00:20] (03CR) 10Zfilipin: [C: 032] Fix the Rubocop offense SpaceAroundOperators [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191059 (owner: 10Amire80) [16:02:13] (03Merged) 10jenkins-bot: Fix the Rubocop offense SpaceAroundOperators [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191059 (owner: 10Amire80) [16:02:41] (03Merged) 10jenkins-bot: Fix the Rubocop offense StringLiterals [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191060 (owner: 10Amire80) [16:10:34] (03PS2) 10Jforrester: ve.dm.MWImageNode: Fix indentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191029 (owner: 10Esanders) [16:10:39] (03CR) 10Jforrester: [C: 032] ve.dm.MWImageNode: Fix indentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191029 (owner: 10Esanders) [16:12:29] (03Merged) 10jenkins-bot: ve.dm.MWImageNode: Fix indentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191029 (owner: 10Esanders) [16:12:47] (03CR) 10Jforrester: [C: 031] Add tests for MW node variants (heading/table/pre) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191036 (https://phabricator.wikimedia.org/T74398) (owner: 10Esanders) [16:17:18] 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1043695 (10matmarex) 3NEW [16:19:28] (03CR) 10Jforrester: [C: 04-1] Simplify AlignableNode by inheriting from ClassAttributeNode (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [16:21:13] Re. MatmaRex. [16:21:21] hi. [16:34:45] 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1043761 (10matmarex) The following patch to work. {P303} [16:35:19] 3UI-Standardization, OOjs-UI, Living-Style-Guide: Create a nonprocedural markup for OOJS-UI - https://phabricator.wikimedia.org/T88026#1043764 (10matmarex) [16:37:38] 3VisualEditor: w: based links do not parse properly in VisualEditor - https://phabricator.wikimedia.org/T89724#1043770 (10Leaderboard) 3NEW [16:47:16] 3VisualEditor: w: based links do not parse properly in VisualEditor - https://phabricator.wikimedia.org/T89724#1043795 (10Jdforrester-WMF) Hey, Could you explain what you would expect to happen if you make a link to "w:Item"? From my testing VisualEditor and the wikitext editor both behave identically, as I woul... [16:49:23] (03CR) 10Bartosz Dziewoński: [C: 04-1] "High-level thoughts:" (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [16:51:28] 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1043814 (10matmarex) (My real use-case is the #infuse method in https://gerrit.wikimedia.org/r/#/c/190368/ / {T74716}.) [16:53:18] Krinkle: [16:53:22] Meh. [16:53:31] Tab-complete fun. [16:54:37] 3VisualEditor: w: based links do not parse properly in VisualEditor - https://phabricator.wikimedia.org/T89724#1043832 (10Leaderboard) It comes as a red link. [16:55:10] 3VisualEditor: w: based links do not parse properly in VisualEditor - https://phabricator.wikimedia.org/T89724#1043841 (10Leaderboard) See my sandbox:-https://en.wikibooks.org/wiki/User:Leaderboard/sandbox?venotify=created [16:55:17] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1043842 (10Jdforrester-WMF) [16:56:10] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1043770 (10Jdforrester-WMF) >>! In T89724#1043841, @Leaderboard wrote: > See my sandbox:-https://en.wikibooks.org/wiki/User:Leaderboard/sandbox?venotify=created That's a link to "... [16:59:01] (03CR) 10Bartosz Dziewoński: [C: 032] TextInputWidget: Only put $label in the DOM if needed [oojs/ui] - 10https://gerrit.wikimedia.org/r/190944 (owner: 10Bartosz Dziewoński) [16:59:26] MatmaRex: … [16:59:40] MatmaRex: Patience? [16:59:49] um, it's already +2'd [16:59:55] four hours ago [17:00:08] it even was verfied by jenkins, yet not merged [17:00:19] i would just submit it, but our repos have stupid settings that don't let me [17:00:20] Oh, I see. [17:00:30] (03Merged) 10jenkins-bot: TextInputWidget: Only put $label in the DOM if needed [oojs/ui] - 10https://gerrit.wikimedia.org/r/190944 (owner: 10Bartosz Dziewoński) [17:00:33] so i've been doing that instead. like every day. [17:00:37] Ed rebased but didn't +2 again. [17:00:47] MatmaRex: yeah, the +2 applied ot patch set 1 [17:00:50] I normally fix these issues. [17:01:00] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1043857 (10Leaderboard) But this is what I have entered in the Link box - w:Item See my sandbox again. It comes to the same thing. [17:01:02] hence the gate got cancelled [17:01:05] Krinkle: i know why it's broken [17:01:15] that doesn't mean it's not broken [17:01:17] Arguably, it's not broken. [17:02:06] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1043858 (10Jdforrester-WMF) I entered "w:Item" into the link box, pressed done and the link went blue immediately. I saved to demonstrate: https://en.wikibooks.org/w/index.php?titl... [17:02:19] Changing this behaviour would likely result in wontfix. [17:02:26] Krinkle: Could you look at https://gerrit.wikimedia.org/r/#/c/191063/ BTW? [17:03:45] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1043877 (10Leaderboard) I saw this. What's wrong? [17:04:31] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1043880 (10Leaderboard) Look at my sandbox again. The second link is my edit. It's still red. [17:05:29] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1043882 (10Jdforrester-WMF) I don't understand what you're doing. Are you sure you're entering the target of the link into the link tool? [17:05:54] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1043883 (10Leaderboard) Yes. [17:06:54] James_F: done [17:13:51] howdy y'all [17:14:06] Heya TrevorParscal. [17:14:32] TrevorParscal: Could you do a couple of 10 second CRs? [17:14:43] always [17:15:03] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/189949/ and https://gerrit.wikimedia.org/r/#/c/190514/ [17:15:29] (03CR) 10Mvolz: [C: 04-1] "Other than the missing bracket spaces which it pains me to let you know are missing (it is no secret that I hate padding spaces in general" (038 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [17:15:52] (03PS1) 10Bartosz Dziewoński: Use OO.initClass() rather than setting .static manually [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191076 [17:15:56] TrevorParscal: And then whether you're OK with these breaking changes: https://gerrit.wikimedia.org/r/#/c/190839/ and https://gerrit.wikimedia.org/r/#/c/190436/ [17:18:09] TrevorParscal: and when you're done with these, i have some wild ideas for OOjs (not UI). https://phabricator.wikimedia.org/T89721 [17:18:52] MatmaRex: Down boy. ;-) [17:19:30] :) [17:19:43] ok... lookin [17:21:24] MatmaRex: I've considered that before, the case I think is most useful is the static constructor [17:21:47] a static constructor is useless when inherited [17:21:52] (03CR) 10Jforrester: "> I ran Grunt and it doesn't seem to detect when there are and are not bracket spaces; shouldn't that be detected in .jscsrc?" (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [17:23:16] because the static method has no reference to the class, you can't use a reference, you have to hard code the class name... such that Animal.static.newFromName() -> new Animal (makes sense) Dog.static.newFromName() -> new Animal (confusing) [17:23:26] so, your class thing is cool [17:24:34] 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1043986 (10TrevorParscal) Would also be useful for inheriting static constructors. Obviously overriding static constructors may be needed sometimes, but generally it's a pain... [17:25:36] yeah [17:26:43] (03CR) 10Trevor Parscal: [C: 032] MediaWiki Theme: Add focus state for frameless button [oojs/ui] - 10https://gerrit.wikimedia.org/r/189949 (https://phabricator.wikimedia.org/T87692) (owner: 10Prtksxna) [17:27:10] 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1044000 (10Jdforrester-WMF) 5Open>3Resolved [17:27:28] (03CR) 10Trevor Parscal: [C: 04-1] "Would like to see the deprecation comment suggested by James be added first. This is a bit crufty." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [17:28:00] (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [17:28:02] (03Merged) 10jenkins-bot: MediaWiki Theme: Add focus state for frameless button [oojs/ui] - 10https://gerrit.wikimedia.org/r/189949 (https://phabricator.wikimedia.org/T87692) (owner: 10Prtksxna) [17:29:07] (03CR) 10Trevor Parscal: [C: 04-1] "Can please we alias the function for 1 release? It's a 1 liner and we can easily add an @until comment above it." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 (owner: 10Esanders) [17:29:41] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Make default distribution provide SVG with PNG fallback [oojs/ui] - 10https://gerrit.wikimedia.org/r/190839 (https://phabricator.wikimedia.org/T87501) (owner: 10Bartosz Dziewoński) [17:34:57] labs is broken so no needcheck report today [17:34:59] 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1044016 (10matmarex) a:3matmarex [17:35:28] (03PS4) 10Esanders: [BREAKING CHANGE] Rename setPosition to setLabelPosition [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 [17:36:06] (03CR) 10Mvolz: "Yup, I ran a fresh npm install, it doesn't seem to detect the lack of spaces in this commit or any that I remove- does it work for you?" (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [17:36:39] (03PS5) 10Esanders: [BREAKING CHANGE] Rename setPosition to setLabelPosition [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 [17:38:07] beta is doooowwwwwnnn [17:38:22] (03PS5) 10Esanders: Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 [17:38:59] mvolz, lots of other stuff is as well [17:40:55] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Rename setPosition to setLabelPosition [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 (owner: 10Esanders) [17:43:19] mooeypoo: is jslinting working for you on the citoid repo? [17:43:37] I keep on getting >> 0 files linted. Please check your ignored files. [17:44:00] (03CR) 10Mooeypoo: "I keep getting 0 linted files for jshint for some reason in this commit (But not in the commit below for the specific grunt file addition." (034 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [17:44:29] but src is running fine and that's literally using the files listed for jslint...oh ha. [17:44:30] yeah. [17:46:20] (03CR) 10Jforrester: Refactor Citoid extension as an inspector (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [17:46:51] (03CR) 10Jforrester: "> I keep getting 0 linted files for jshint for some reason in this commit (But not in the commit below for the specific grunt file additio" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [17:55:16] mvolz, ha, yeah, I don't know why that happens, it technically shouldn't :\ I'll have to look deeper [18:08:42] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1044073 (10Leaderboard) Just to know , I'm using IE11. Does that have any effect? [18:14:51] (03CR) 10Mvolz: "Yup, got the same 0 jslint files issue. Totally weird because src works just fine and it uses the same object!" (033 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [18:16:06] Blaise is fascinated by the builders using jackhammers [18:17:20] Whoops I totally forgot about the meeting while writing that comment :/ [18:18:03] mvolz, I said I needed you to re-review my code once I fix it :p [18:18:14] (03PS6) 10Esanders: Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 [18:18:18] sweet, I just saved 1 minutes! [18:18:21] err 15* [18:19:13] mvolz: :-) [18:22:12] (03PS5) 10Jforrester: MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://phabricator.wikimedia.org/T51452) [18:22:44] (03CR) 10Jforrester: "PS5 is a rebase onto Ed's code that should make these tests work (finally)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://phabricator.wikimedia.org/T51452) (owner: 10Jforrester) [18:22:45] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1044098 (10Krinkle) 3NEW [18:24:05] (03CR) 10jenkins-bot: [V: 04-1] MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://phabricator.wikimedia.org/T51452) (owner: 10Jforrester) [18:24:16] James_F: I find that removing an empty block is also stripping the last character of the prevous block (e.g. when pressing backspace with cursor in an empty list item or paragraph below a heading, the cursor is now in the heading and VE removed its last character). Seems unexpected? [18:25:18] RoanKattouw_away: I moved the Wikimania thing to 3pm because the MediaWiki-Core team got rescheduled for today at 2pm [18:25:46] Krinkle: "empty block"? [18:26:02] James_F: Anything that's empty. E.g. a paragraph that has no more text left. [18:26:09] Or a list item the user is removing [18:26:22] Hmm. Sounds very odd. What browser? [18:26:33] (03PS10) 10Mvolz: [WIP] Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) [18:26:41] James_F: Chrome [18:26:43] consistent [18:31:47] (03PS2) 10Catrope: Ignore duplicates when comparing class lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191028 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [18:33:45] (03CR) 10Catrope: [C: 032] Ignore duplicates when comparing class lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191028 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [18:35:39] (03Merged) 10jenkins-bot: Ignore duplicates when comparing class lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191028 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [18:37:11] 3VisualEditor, VisualEditor-DataModel: class="wikitable wikitable" corrupted to class="wikitable" - https://phabricator.wikimedia.org/T88148#1044170 (10Jdforrester-WMF) 5Open>3Resolved [18:37:48] 3VisualEditor, VisualEditor-CopyPaste, VisualEditor-ContentEditable: Pasting contents into slug at end of document breaks surface - https://phabricator.wikimedia.org/T89738#1044173 (10Krinkle) 3NEW [18:38:46] James_F: The charachter removal I'm hesitant to file the bug. Rather have you reproduce it in cast it's one of those things you say is a feature. [18:39:36] Sounds like it might be due to divec's native backspace/delete commit? That was merged yseterday [18:39:44] Krinkle: I can't replicate in prod. [18:40:01] Me neither. But on master though. [18:40:18] Ah. Yeah, might well be a bug in divec's backspace stuff. [18:40:28] Thought I'd tested that but might have over-looked it. [18:40:41] Krinkle: Please do file a task. [18:41:20] James_F: In prod I can't click in the slug at the end of a page after a highlighted node. E.g. https://www.mediawiki.org/wiki/OOjs/Events?veaction=edit I can see the blue hover effect (though partially cut off) but it's not taking click events. [18:41:22] Can you reproduce that? [18:41:37] (sorry, I'm on an edit journy and running into a stack of bugs unexpectedly) [18:41:38] Krinkle: Yeah, it's an Ed bug. [18:41:43] Krinkle: :-( [18:42:28] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1044211 (10Catrope) I can't reproduce this in IE11 either. Steps: - Put cursor on empty line - Click Link button - Type `w:Item` - Click Done - Blue link is inserted with text `w:... [18:43:52] (03CR) 10Catrope: [C: 04-1] Use OO.initClass() rather than setting .static manually (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191076 (owner: 10Bartosz Dziewoński) [18:44:15] Krinkle: (And can I get a recheck on https://gerrit.wikimedia.org/r/191063 please.) [18:45:18] 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1044215 (10cscott) Yes, sounds good to me! Another slight inconsistency regards how child content is added to... [18:45:38] James_F: The "Review changes" dialog has two weirdness I'm observing. It's fullscreen at small window sizes (though pretty high cut off, >= 830px), and quite small on larger window sizes. I'm annoyed by the tiny diff viewer I get. When I resize the window to be narrower, I actually get a larger diff viewer, which is a weird hack. Should it always be full screen? Or at least grow a bit (given s [18:45:38] pace). [18:45:50] (03CR) 10Bartosz Dziewoński: Use OO.initClass() rather than setting .static manually (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191076 (owner: 10Bartosz Dziewoński) [18:45:56] Krinkle: It does grow… [18:46:04] James_F: Not vertically [18:46:14] Krinkle: It should be 'large' in the main dialog and 'larger' in the diff view. [18:46:24] Oh, vertically. That's a TrevorParscal question. [18:46:41] (03CR) 10Trevor Parscal: [C: 031] "Address Roan's comments and we are good here." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191076 (owner: 10Bartosz Dziewoński) [18:46:56] (03CR) 10Catrope: [C: 032] Use OO.initClass() rather than setting .static manually (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191076 (owner: 10Bartosz Dziewoński) [18:47:29] (03CR) 10Trevor Parscal: Use OO.initClass() rather than setting .static manually (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191076 (owner: 10Bartosz Dziewoński) [18:47:30] 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1044231 (10matmarex) I think FormLayout is the only case where that happens, and indeed it should not happen a... [18:47:39] James_F: Most dialogs allow their entire contents to be displayed and are made smaller with scroll if the window is not tall enough (with a minimum height). E.g. template dialog with lots of parameter will take up all vertical space nicely on a large window. But this one is not adapting to the diff size. It's actually making me want to use the wikitext editor. Where I can see the diff proper. [18:47:54] TrevorParscal: ^ :) Is this on purpose? [18:47:59] Oh, eh. [18:48:17] James_F: Hm.. (re: citoid-npm) explicitly adding jslint as opposed to removing it? [18:48:19] (03CR) 10Catrope: [C: 032] Add tests for MW node variants (heading/table/pre) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191036 (https://phabricator.wikimedia.org/T74398) (owner: 10Esanders) [18:48:30] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1044243 (10Leaderboard) When I directly copied the link from your comment , it is now not coming as a link at all(original issue). [18:48:59] (03Merged) 10jenkins-bot: Use OO.initClass() rather than setting .static manually [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191076 (owner: 10Bartosz Dziewoński) [18:50:02] (03Merged) 10jenkins-bot: Add tests for MW node variants (heading/table/pre) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191036 (https://phabricator.wikimedia.org/T74398) (owner: 10Esanders) [18:51:07] Krinkle: so, the height [18:51:32] you are saying it would be nice for the dialog to be taller (in the case of the diff anyway) [18:51:45] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1044259 (10Leaderboard) When I directly copied the link from your comment , it is now not coming as a link at all(original issue). [18:51:54] 3VisualEditor: Actually run MediaWiki-VisualEditor's tests for MWHeadingNode / MWPreformattedNode - https://phabricator.wikimedia.org/T74398#1044261 (10Jdforrester-WMF) 5Open>3Resolved [18:52:15] (03CR) 10Mooeypoo: Refactor Citoid extension as an inspector (038 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [18:52:27] (03PS4) 10Mooeypoo: Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) [18:52:30] TrevorParscal: yeah, ideally it would just be automatic height. E.g. allow it to full the screen height if there's a lot of content. [18:52:35] mvolz, ^^ [18:53:08] TrevorParscal: Anything as long as I don't have a (relatively) tiny letter box view of a large diff. Its' tedious. [18:53:09] Krinkle: so, there is an auto-height thing, but it is probably being overridden or not working correctly [18:53:35] (03PS1) 10Bartosz Dziewoński: Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) [18:53:42] yeah, i've also thought about how dialogs could be toggled full/floating without making the UI really compex [18:53:47] *complex [18:54:10] TrevorParscal: When resizing narrower, it switches to mobile-style full screen. Is that intentionally activated on desktop? [18:54:16] the support is there for changing between sizes, stuff like searching for images is SO nice full screen [18:54:27] yeah [18:54:42] it is intentional that we automatically change to full when we don't have enough room, yes [18:55:07] but, in theory we could allow dialogs to be full-browsered using a switch or something... [18:55:23] diff browsing, image browsing, it makes sense that people would actually benefit from that [18:56:48] TrevorParscal: It doesn't have to be full width per se. I can see that being negative for diff. The same way that Wikipedia content should not be 100% fluid. And with absence of sidebar that'll be even worse than the wikitext diff. [18:56:51] for large monitors [18:56:59] As long as it utilises the height [18:57:10] like the template dialog does already [18:57:13] Yeah,I suspect auto height is malfuctioning [18:58:46] (03CR) 10Bartosz Dziewoński: "Should we also provide .klass, the way we have both .super and .parent?" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [18:59:38] Krinkle: well, auto-height is only in use if you don't override the getBodyHeight method [18:59:57] and the save dialog does override it to be 350 sans footer [18:59:57] MatmaRex: With a 'k'? [19:00:22] it's actually been done to avoid the window being auto-sized [19:00:24] (03PS1) 10Jforrester: Update VE core submodule to master (4d6cd42) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191102 [19:00:25] James_F: yes. for IE8 stuffs. [19:00:32] because the footer being shown and hidden causes the window to change sizes [19:00:34] MatmaRex: Eww. [19:01:04] James_F: it is a common convention, also for a variable that contains a class name / class object. do you know a better one? [19:01:24] (03PS2) 10Jforrester: Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [19:01:35] (03CR) 10Jforrester: "PS2 is a rebase onto the dependent pull-through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [19:01:35] (some use 'cls', but that's worse) [19:01:58] MatmaRex: No, just… eww. [19:02:08] .constructor [19:02:10] ? [19:02:12] (03CR) 10Mvolz: [C: 031] Refactor Citoid extension as an inspector (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [19:02:21] i mean, that's how you get the class from within the instance [19:02:21] David's filibuster code uses klass as a parameter name IIRC [19:02:34] TrevorParscal: hmm, yeah, also reasonable. dunno if it could be confusing. [19:02:38] TrevorParscal: Let's not overwrite .constructor because it's a native property [19:02:46] RoanKattouw: fair [19:02:48] MyClass.static.constructor is already set, it's Object [19:03:04] that seems useless, but yaeh [19:03:18] (03CR) 10jenkins-bot: [V: 04-1] Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [19:03:25] i also don't like klass [19:03:33] and I also don't like IE8 [19:03:35] it's a little krappy [19:03:36] :( [19:03:38] lol [19:03:47] Krinkle: do you have a cycle to spare for https://phabricator.wikimedia.org/T89668 ? [19:04:18] (03CR) 10Mooeypoo: Refactor Citoid extension as an inspector (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [19:04:19] (if so, please assign it to yourself -- and if not, not! :)) [19:04:24] ori: you using the blink tag again? [19:04:56] gotta hit those conversion targets [19:05:25] I wanted "CONGRATULATIONS!!!! YOU ARE THE 1,000,000 EDITOR TODAY!!! CLICK HERE TO CLAIM YOUR PRIZE", but James_F talked me out of it. [19:05:35] ori: BonziEditor! [19:05:41] ori: Can you punch the monkey? [19:05:47] Can I ever. [19:05:53] * ori coughs. [19:06:09] (03PS2) 10Mooeypoo: Normalize external links from the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190970 [19:06:10] (03CR) 10Bartosz Dziewoński: "Discussed on IRC, everyone hates .klass, so let's just not do it!" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [19:06:14] ori: "She knows one magic secret that makes editors wild!" [19:07:06] ok, so this is what I think about klass [19:07:34] I think we should use ['class'] for now, and when we drop IE8 (in the future) we can replace them all with .class [19:08:08] I know it's slightly uglier for now, but it is equivalent (no breaking changes to the API over time) [19:08:20] MatmaRex: ? [19:08:43] TrevorParscal: +1 [19:08:53] mvolz, uh, I assume you've read the docs about the hooks you're using -- I was just curious to see what they were, and I ran into the docs for "ContentHandlerDefaultModelFor" which has the explanation of being "Allows to control the content model a given title will default to." --> is this.. uh... English? What? What is this hook doing? [19:09:10] TrevorParscal: WFM. [19:09:12] we get all of the functionality and some of the pretty today, and the rest of the pretty "tomorrow" [19:09:22] RoanKattouw: ^^^ [19:10:00] And in VE we can use .class immediately, because we don't support IE8? [19:10:29] in ve, yes [19:10:37] 3VisualEditor: Move generateCitationFeatures out of MWTarget - https://phabricator.wikimedia.org/T89746#1044332 (10Esanders) 3NEW [19:10:48] just like we use .bind() or whatever other things [19:10:52] dude, my patio behind my house, no rebar (steel reinforcement), no gravel underneeth... just 4" of concrete on top of dirt! [19:10:55] TrevorParscal: SGTM but also ask Kr [19:10:56] (03CR) 10Cscott: "@JamesF: I'm not a huge fan of 'infuse' either, but that seemed to be the consensus in T74716. One James Forester suggested it. But if y" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [19:10:59] Krinkle: [19:11:18] overload [19:11:21] whoever installed that concrete should be ashamed of themselves and their family [19:11:33] cscott: :-) [19:11:39] Krinkle: overload? [19:11:53] * Krinkle is overloaded [19:11:55] TrevorParscal: Time to have a chat with the guy across the street? :P [19:12:04] 3VisualEditor, VisualEditor-CopyPaste, VisualEditor-ContentEditable: Pasting contents into slug at end of document breaks surface - https://phabricator.wikimedia.org/T89738#1044343 (10Ryasmeen) [19:12:06] 3VisualEditor: [Regression wmf-16] Including a template/comment/table/gallery/math node in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1044344 (10Ryasmeen) [19:12:12] Krinkle: And .overlord for .super/ [19:12:42] RoanKattouw: lol, that guy walked out into the street in his underwear this morning and started talking to get Floyd about some job he wants him to do [19:12:59] mvolz, basically, I was trying to see if I can add "ResourceLoaderRegisterModules" hook that will check if 'ext,visualeditor.mwreference' is loaded before loading our modules at all; that will replace the JS version you had with "mw.loader.using( 'ext.visualEditor.mwreference' ).done( ... )" [19:13:14] what's this overload/overlord stuff? [19:13:36] TrevorParscal: So are underwear guy, FBI raid guy and I-grew-up-in-your-house guy all the same guy? [19:13:42] yes [19:13:46] I thought so [19:13:48] Just checking :) [19:13:57] (03CR) 10Esanders: "How about the name describes the high level purpose, like: 'dynamic' or 'usesJS' or 'interactive' or ..." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [19:14:12] mooeypoo: You really really do not need a hook for that [19:14:40] mooeypoo: $wgVisualEditorPluginModules[] = 'ext.citoid.ve'; , see e.g. the Math extension for example [19:14:47] RoanKattouw, "ResourceLoaderRegisterModules" seems to be the closest, though I'd have to rearrange the way we-- oh [19:15:05] everyone else in the area is very normal and reasonable... except for my next door neighbor (to the east) who is the literal incarnation of satan - he eats children and swindles desperate people out of their eternal souls [19:16:21] (03CR) 10Bartosz Dziewoński: "Tags that are not Elements can be just converted to HTML string, like HtmlSnippets. (Unless they can't? I think they can.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [19:16:50] (03CR) 10Cscott: "@Ed: do the brainstorming/bike-shedding in T74716?" (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [19:19:01] Krinkle, when you have time, can you help me try and figure out why the grunt tasks I set up in Citoid extensions have jshint *ignore* both my module files, even though jscs reads them (and they both use the same folder setting in the Gruntfile) ? [19:19:10] mooeypoo: link? [19:19:28] (03CR) 10Trevor Parscal: "Sorry about there being a bit of back and forth about the name, "infuse" is at least short. We were originally half-jokingly calling it "r" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [19:19:39] ori: OK. Probably tomorrow. Assign to me :) [19:19:51] RoanKattouw: What was the ping for? [19:19:59] Krinkle: cool, thanks [19:20:13] Krinkle, https://gerrit.wikimedia.org/r/#/c/190847/ <-- this is merged already, those are the grunt definitions. It *worked* for me then. But then I changed the name of the files here: https://gerrit.wikimedia.org/r/#/c/190973/ and it ignores my 2 modules, even though the Gruntfile has modules/*.js [19:20:15] [11:10] RoanKattouw TrevorParscal: SGTM but also ask Kr [19:20:17] [inkle] [19:20:19] 3VisualEditor-Initialisation, VisualEditor-Performance, VisualEditor: VisualEditor beta feature on enwiki causes edit tab to flicker - https://phabricator.wikimedia.org/T89668#1044376 (10ori) a:3Krinkle [19:20:41] In re scrollback conversation about .klass and ['class'] and stuff [19:21:02] Krinkle, it says "Running "jshint:all" (jshint) task >> 0 files linted. Please check your ignored files." but I can't figure out where I may be setting them as ignored [19:21:47] 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1044378 (10cscott) @matmarex: grepping for serializeContent in my patch shows that FormLayout, PanelLayout, an... [19:22:43] history [19:22:47] RoanKattouw: Right. I'm reading that task [19:22:54] sorry - wrong window :( [19:22:55] RoanKattouw: I'd like us to consider not adding that property [19:23:09] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Provide a character insertion tool - https://phabricator.wikimedia.org/T52296#1044387 (10Whatamidoing-WMF) [19:24:08] Krinkle: what's the argument against the property? [19:24:13] because it would be very useful [19:24:40] but the status quo is without, so now is a good time to defend said status quo [19:24:51] 3OOjs-UI: Inconsistency in how child content is added to widgets - https://phabricator.wikimedia.org/T89750#1044403 (10matmarex) 3NEW [19:24:58] TrevorParscal: I want to make sure we're not becoming a too generic framework that tailors to multiple models of how to design apps. It should tailor to one model well. [19:25:27] but static inheritance without late static binding sucks, no? [19:25:34] TrevorParscal: I'm looking through it now, but my gut says there's a non-hacky way to do this without it. And that adding it would obfuscate as opposed to clean up. [19:25:39] TrevorParscal: Maybe [19:25:41] a la PHP in versions past [19:25:46] TrevorParscal: I know [19:25:56] I literally wrote that 4 minutes ago in my unpublished comment [19:25:59] 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1042606 (10matmarex) Let's split that to T89750. I like having many small bugs, makes me look efficient when I... [19:26:03] "A bit like Late Static Bindings in PHP (e.g. akin to `static::`, not `self::`). " [19:26:07] lol [19:26:17] 3UI-Standardization, OOjs-UI: OOjs UI: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1044417 (10cscott) There were some comments about the 'infuse' name. I don't have any favorite paint colors here. But to make the discussion concrete, we need names for: # The JS side meth... [19:26:41] yeah, I've almost written this patch a few times, but always decided that the hacking required to avoid this change wasn't all that bad [19:26:51] but, indeed I feel it is sometimes hacked around [19:26:52] 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1044418 (10ori) a:5ori>3matmarex >>! In T89423#1037020, @matmarex wrote: > What page were you testing on? http://osmium/wiki/Barack_Obama To reach it,... [19:26:59] TrevorParscal: Examples? [19:27:06] static constructors [19:27:08] newFromSomething [19:27:12] when you sublcass [19:27:16] what happens? [19:27:42] even through the static property was inherited, it produces an instance of the paren't class [19:27:48] *parent's [19:28:03] TrevorParscal: It doesn't. It wouldn't have access to even the parent right now [19:28:23] RoanKattouw, Krinkle: FYI, latest-ish Chrom{e|ium} nightlies contain nice UX improvements to the DevTools timeline [19:28:33] no, no, ... um.. inside the function you have to hardcode the class you are constructing [19:28:44] Right [19:29:09] contrived example: MyThing.static.newFromName = function () { return new MyThing() }; [19:29:10] TrevorParscal: So, not saying it's better, but to provoke thinking, why not pass as argument? [19:29:25] 3VisualEditor, VisualEditor-MediaWiki-References, Citoid: Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-selected - https://phabricator.wikimedia.org/T88152#1044427 (10Mooeypoo) a:3Mooeypoo [19:29:35] It's hardcoded either way (Dog.do, do(Dog)). But makes it implicit instead of abstracted behind 3 layers of indirection [19:29:43] That seems more 'static' of a utility [19:29:46] so SubMyThing.static.newFromName( SubMyThing, name ); ? [19:30:01] No, you wouldn't specify Sub twice [19:30:07] static doesn't mean pure [19:30:12] Unless we want them to be overriddable [19:30:21] in which case I think the code is trying to do shit way too much [19:30:56] TrevorParscal: We shouldn't have '.static' I suppose. [19:31:05] That would simplify it a little bit [19:31:22] The reasons for having it are obsolete [19:31:27] but it's quite useful to have inheritable static properties and methods, prototypal inheritance has given us this facility, we are using it normally [19:31:43] TrevorParscal: static isn't live inheritance though, is it? [19:31:49] yes [19:31:51] it is [19:31:51] Which means we can just as well copy them from and to the constructor [19:32:23] Right [19:32:32] Why? [19:32:50] We actively don't want classes to change after their definition. [19:33:10] Not in this classical model we're persuing anyway. [19:33:14] we don't use MyThing.staticMethod because it doesn't inherit.... SubMyThing.static is an object with a prototype defined by MyThing.static [19:33:35] Yeah, but what's the value in doing a live inherit instead of copy [19:33:37] that way things fall through [19:33:45] yeah, we use live inherit [19:33:51] I know, I pushed for that. [19:33:54] You had it copy originally [19:33:58] and that has been awesome! [19:34:00] And it worked just fine [19:34:07] There's 0 difference in any code we've ever written [19:34:13] We don't modify our prototypes. [19:34:17] are you arguing against yourself? [19:34:18] lol [19:34:25] I've changed. [19:34:28] i see [19:34:34] Maybe [19:34:42] Just curious if you can defend it [19:34:50] well, I think that it's not true to say we've not taken advantage of static inheritance [19:35:16] and whether it could have been copied or using a prototype is not really the issue [19:35:29] You mean we modify parent classes after defining sub classes? [19:35:38] in either case, having a property to access the class solves the same problem [19:35:43] no we do not [19:35:58] the child class has a new static object that falls through (via prototype) to the parent [19:35:59] It's a stretch in the here and now for a different change I have in mind, but back to the issue, if we had copy instead of inherit, we could rid .static and use Foo.bar directly [19:36:02] which means we have .this [19:36:28] how would we know which things to copy? just using hasOwnProperty? [19:36:34] Sure [19:36:41] i'm not against that [19:36:48] except constructor and prototype. It's not hack, it's by design. [19:36:55] The rest are static members [19:36:56] it would certainly make programming nicer to have less to write [19:37:13] there must be some good reason we moved away from that [19:37:21] you argued we shouldn't copy [19:37:26] TrevorParscal: Because I said it'd perform better [19:37:43] TrevorParscal: And because I found it cleaner to keep a reference to the original instead of copying. [19:37:45] is that performance just not significant enough? [19:37:54] (03CR) 10Cscott: "Well, the widget demo is certainly a "worst case" for infuse. In my use in the Collections extension there are 2-4 widgets on the page I " [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [19:37:57] to justify the mess...? [19:38:07] However 1) the copy is not a copy, it's still a reference to the same functions. So it's merely the cost of an extra property, not a new value [19:38:25] and 2) it's cost of a property vs cost of deep inheritance look up. [19:38:36] v8 certainly likes it when objects have a limited shape and don't keep changing all the time. [19:38:42] cscott: The plan is for the entire skin to be OOUI widgets, a few dozen of which will probably get infused… [19:38:50] So in that regard closing the inheritance would make things much more predictable. [19:38:56] TrevorParscal: For the same reason that Object.prototype is evil. [19:39:29] Krinkle: you mean why modifying Object.prototype is evil? [19:39:58] cscott: I don't know if that scale is tenable, though. [19:39:59] TrevorParscal: Keeping a live link to everything everywhere is quite fragile. More an exposed wound than a feature. [19:40:17] ok, so MatmaRex, what are your thoughts about Krinkle's 180 here? [19:41:07] maybe I just find Krinkle oddly persuasive, but it would be nice to do away with the whole .static stuff, and then we get "this" instead of ".class" [19:41:38] Krinkle: thank you for looking at this critically [19:42:04] TrevorParscal: It's still dawning on me. Giving it some more thoguht [19:42:08] TrevorParscal, I'm working on Citoid inspectorifying, and we seem to be missing a way to display warnings to the user. There's the ooui error handling, but what do I do if an error isn't a stopping error but a "warning" ? as in, "continue this process but let the user know something wasn't right" (this happens in Citoid when responses are not accurate) [19:42:21] Krinkle: nothing here is urgent, we are just trying to move in the right direction [19:42:34] think away [19:43:24] TrevorParscal: Krinkle: i don't really have an informed opinion. i don't know what led you to make OOjs work the way it does, but so far i've been finding it nice to work with. what exactly are you arguing for right now, killing .static? [19:44:49] MatmaRex: basically, attach static members to the constructor, like real static members. Thus, we'd have to kill the live inheritance link and instead copy member references instead of inheriting. We'd still "inherit" (or "mixin") parent class' static members, but only at definition time, not retroactively. Which is evil anyway. [19:45:15] (we'd have to kill it since we cant' Object.create a class constructor) [19:45:44] Thus self/this becomes a natural feature by accessing SubClass.unserialise [19:46:19] Fun, first ever breaking change in OOjs? :-( [19:46:28] (03CR) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [19:46:45] James_F: I think we can support .static for the near future without much cost. [19:47:12] at the same time [19:47:19] OK. [19:48:10] sounds like a lot of copying, and not javascript-like (whether that's good or bad depends on your point of view, heh). could make debugging harder, i guess? [19:48:35] there aren't really any good arguments for or against that change [19:49:27] MatmaRex: The copying is relatively cheap, compared to the cost of Object.create and deep inheritance traversal it has to do at run-time continuously now. [19:49:40] MatmaRex: mixin() isn't unnatural to JS though. [19:50:28] The entire classical system is however unnatural to JS. Douglas Crockford is actually pushing for abandoning "new" alltogether. I've given that a serious consideration and for new code, I'd probably give that a try too. It saves to many hassles (never ever have "this" again in any code!) [19:50:28] i'm sure that's devilishly optimized anyway (the traversal) [19:51:09] It also keeps it open to live mutation. Which we actively don't want. Anything doing that would likely be a bug or a hack. [19:52:16] MatmaRex: Anyway, I've compared performance last year. When we had it that way in some environments already. It's negligible. Maintenance and readability is more significant in this case. It's about what looks intuitive and is useful us. This is all micro-optimisation anyway. [19:52:34] It seems neat to be able to use .this normally. [19:53:28] i abuse that when debugging/fiddling-with things sometimes. and in general, when an inheritance system allows you to "reopen" and modify an existing class, it also has inheritance work that way. [19:54:07] normally, as in, .this in static methods referring to the constructor function? [19:54:13] MatmaRex: Yes [19:54:53] i'd call what we have now also "normal", it all makes sense since .static is a property on the constructor, it's just different [19:55:05] MatmaRex: It doesn't freeze objects. The modification can still apply at any moment the factory can change. But yeah, existing objects at run time are standalone. it's trivial to refresh though. I don't think that's where the time goes in debugging. I'll keepit in mind though, it's an interesting point. [19:55:34] MatmaRex: .static is a static property [19:55:36] MatmaRex: Yeah [19:55:56] Well, but it's a hack, and we can add a second hack on top, or kill the first one and get both for free. [19:57:07] you need to tell that to ed about his overflow:hidden on body [19:57:32] but, eh, i dunno. copying properties also feels hacky [19:57:39] 3MediaWiki-Page-editing, MediaWiki-Core-Team: ipblocks query from EditPage unconditionally goes to master - https://phabricator.wikimedia.org/T51419#1044585 (10Umherirrender) 5Open>3Resolved [19:58:14] MatmaRex: We could also consider setting .__proto__ on the constructor function :) [19:58:19] and inherit that way [19:59:27] 3VisualEditor-MediaWiki, VisualEditor: Move generateCitationFeatures out of MWTarget - https://phabricator.wikimedia.org/T89746#1044595 (10Jdforrester-WMF) [19:59:38] 3VisualEditor-MediaWiki, VisualEditor: Move generateCitationFeatures out of MWTarget - https://phabricator.wikimedia.org/T89746#1044597 (10Jdforrester-WMF) p:5Triage>3Normal [19:59:55] (03PS5) 10Mooeypoo: Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) [20:00:03] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1044600 (10Jdforrester-WMF) p:5Triage>3High a:3Krenair [20:00:45] 3VisualEditor, MediaWiki-extensions-ContentTranslation: refactor upload.rb: move it from the VE repo to a reusable module so that it would be possible to use it for other features - https://phabricator.wikimedia.org/T89718#1044606 (10Jdforrester-WMF) p:5Triage>3Low [20:01:05] James_F, did you assign that to me because I've looked at that code recently? [20:01:12] Krenair: Yeah. [20:01:46] (03PS1) 10Mooeypoo: Reject promises with OOUI error handling [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/191123 [20:01:46] 3VisualEditor, VisualEditor-MediaWiki-References, Citoid: Don't let the Citoid tool be added to the "catchall" toolbar group, because it makes for a confusing/broken experience - https://phabricator.wikimedia.org/T89555#1044610 (10Jdforrester-WMF) [20:01:59] 3VisualEditor, VisualEditor-MediaWiki-References, Citoid: Don't let the Citoid tool be added to the "catchall" toolbar group, because it makes for a confusing/broken experience - https://phabricator.wikimedia.org/T89555#1039247 (10Jdforrester-WMF) a:3Mvolz [20:03:38] :/ [20:05:51] okay, it was actually mwedit I went through, not mwtiming. but this looks much simpler [20:07:11] Oh, right, yeah. [20:10:47] (03CR) 10Jforrester: [C: 032] Normalize external links from the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190970 (owner: 10Mooeypoo) [20:12:28] (03Merged) 10jenkins-bot: Normalize external links from the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190970 (owner: 10Mooeypoo) [20:14:16] (03PS1) 10Catrope: Followup 6a6bb90ab: update CSS file path in eg-iframe.html [oojs/ui] - 10https://gerrit.wikimedia.org/r/191127 [20:14:52] Krinkle, where are you getting those logs in https://phabricator.wikimedia.org/T89735 from? [20:15:11] Krenair: Chrome console [20:15:24] ok, how do I turn on the logging then? [20:15:39] Oh, I didn't realise that wasn't default [20:15:47] (03PS2) 10Jforrester: Follow-up 6a6bb90ab: Update CSS file path in eg-iframe.html [oojs/ui] - 10https://gerrit.wikimedia.org/r/191127 (owner: 10Catrope) [20:15:52] Krenair: [20:15:53] (03CR) 10Jforrester: [C: 032] Follow-up 6a6bb90ab: Update CSS file path in eg-iframe.html [oojs/ui] - 10https://gerrit.wikimedia.org/r/191127 (owner: 10Catrope) [20:15:53] mw.trackSubscribe('', function (topic, data) { [20:15:53] console.log('[mw.track] ' + topic, data); [20:15:54] }); [20:15:58] in Common.js :) [20:16:25] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1044631 (10Krinkle) [20:17:00] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1044632 (10Krenair) [20:17:11] 3VisualEditor, VisualEditor-CopyPaste, VisualEditor-DataModel: Cutting and pasting a paragraph causes (only) the last inline template to be replaced by HTML - https://phabricator.wikimedia.org/T86401#1044633 (10Jdforrester-WMF) [20:17:18] stupid phabricator conflicts [20:17:25] (03Merged) 10jenkins-bot: Follow-up 6a6bb90ab: Update CSS file path in eg-iframe.html [oojs/ui] - 10https://gerrit.wikimedia.org/r/191127 (owner: 10Catrope) [20:17:27] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Using browser native interactive spell-check tool causing repeated automatic deletion in Chrome - https://phabricator.wikimedia.org/T65462#1044635 (10Jdforrester-WMF) [20:17:42] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Provide a character insertion tool - https://phabricator.wikimedia.org/T52296#1044636 (10Jdforrester-WMF) [20:17:57] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1044098 (10Krenair) [20:17:59] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1044639 (10Krinkle) [20:18:11] xD [20:18:44] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1044098 (10Krinkle) [20:19:36] 3VisualEditor-Tables, VisualEditor, VisualEditor-ContentEditable: VisualEditor: Chrome lets you place the cursor either side of a Table (eww) and VE doesn't correct this - https://phabricator.wikimedia.org/T73560#1044641 (10Jdforrester-WMF) [20:20:13] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-Tables: Chrome lets you place the cursor either side of a Table (eww) and VE doesn't correct this - https://phabricator.wikimedia.org/T73560#1044642 (10Jdforrester-WMF) [20:23:03] (03PS1) 10Kmenger: ButtonWidget: Add example and link [oojs/ui] - 10https://gerrit.wikimedia.org/r/191129 [20:23:28] 3VisualEditor, VisualEditor-ContentEditable, VisualEditor-Tables: Chrome lets you place the cursor either side of a Table (eww) and VE doesn't correct this - https://phabricator.wikimedia.org/T73560#1044650 (10Ryasmeen) [20:23:29] 3VisualEditor-EditingTools, VisualEditor: VisualEditor:After adding a focusable node inside a content cell , placing cursor at the end of the table scrolls the page down - https://phabricator.wikimedia.org/T74804#1044649 (10Ryasmeen) [20:24:13] 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1044660 (10Krinkle) If I understand correctly, this task is asking for a way to access the current class from a static method. Given `Dog.static.unserialize` is not overridden... [20:24:27] (03PS1) 10Alex Monk: Don't log against undefined target constructor name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191130 (https://phabricator.wikimedia.org/T89735) [20:25:58] (03CR) 10jenkins-bot: [V: 04-1] Don't log against undefined target constructor name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191130 (https://phabricator.wikimedia.org/T89735) (owner: 10Alex Monk) [20:27:46] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1044682 (10Krenair) {T78236} strikes again. [20:28:46] Krinkle, how did the previous code not fail that test? :/ [20:29:22] Krenair: previous code only had one variable [20:29:25] now there's two. One per line. [20:29:52] The error is misleading [20:29:56] oh it's moaning about it not being one per line [20:29:58] it doens't want an empty line, just a line break [20:30:22] I thought it wanted a newline between the end of the var statement and the following code [20:30:58] (03PS2) 10Alex Monk: Don't log against undefined target constructor name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191130 (https://phabricator.wikimedia.org/T89735) [20:32:02] James_F: When I copied those lines from the console for the .undefined track bug, I got this when I pasted: https://gist.github.com/Krinkle/1335cb214afe9eca2f30 [20:32:11] Where in the hell did that css come from [20:33:11] dev tools? [20:33:30] yeah. copying a line with ">Object" in it, somehow brings along the dev tools' own stylesheet [20:33:37] complete mustery to me how that manages to leak [20:34:07] that Images/statusbarButtonGlyphs.png reference would be chrome-devtools://devtools/bundled/Images/statusbarButtonGlyphs.png [20:35:46] Krinkle: Magic shadow DOM access? [20:39:31] RoanKattouw: so, i want to make the getToolsForFragment functionality of ToolFactory generic, because it's the same functionality needed for any other factory that relates registered classes with the model classes derived from a fragment [20:40:51] So like get[Things]ForFragment? [20:40:56] You'd have like a FragmentFactory? [20:41:00] Or maybe as a mixin? [20:41:04] maybe a mixin [20:41:18] since ToolFactory exists in OOjs UI [20:41:27] never done a factory mixin before... [20:42:01] FragmentMetaFactory [20:42:25] ThingsRelatedToFragmentsFactory [20:42:47] TrevorParscal: Your topic needs to be Refactory. [20:43:02] Yes :) [20:43:03] and I would use getItemsForFragment i guess [20:43:09] Yeah it should be a mixin [20:43:13] But I don't know what it should be named [20:43:32] RoanKattouw: then what good are you!? [20:43:33] lol [20:43:46] TrevorParscal, any chance I can get code review on this ? https://gerrit.wikimedia.org/r/#/c/190400/ it's the media dialog "better resizing" fix [20:43:55] lookin [20:44:59] (03CR) 10Jforrester: [C: 031] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [20:45:31] TrevorParscal: FactorFactory? [20:46:00] TrevorParscal, also, I've refactored the Citoid extension as an inspector -- the next step will be to adjust your context code to it, so I'm waiting on that. [20:46:21] mooeypoo: https://gerrit.wikimedia.org/r/#/c/190400/3/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js,unified why are you setting all these data attributes? [20:46:42] and, also you know you can pass an object to attr to set multiple at once [20:47:24] You mean the rowHeight and min/max Width ? [20:47:59] TrevorParscal, each result/image must know its own limits and the row height so it can adjust to it. The wrapper must be the row height itself even if the image is too small for it, so it has to know what to adjust to [20:48:39] I can probably set it up as an object and extend each with the data element [20:48:45] Also setting .attr( 'data-foo', 'bar' ) is equivalent to .data( 'foo', 'bar' ) [20:48:48] TrevorParscal, also, oops, I should get rid of the $: this.$ [20:49:10] oh oh further down, sorry, I was looking up at line 131 [20:49:32] oh, okay, these are for debugging purposes, if anything happens, we can immediately inspect the DOM and see what's going on.. [20:49:43] Should I remove them and only add when needed? I didn't think it was that horrible to keep it in [20:51:07] (03CR) 10Jforrester: [C: 031] Don't log against undefined target constructor name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191130 (https://phabricator.wikimedia.org/T89735) (owner: 10Alex Monk) [20:51:15] 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1044732 (10TrevorParscal) I support one of two outcomes. 1. We use ['class'] to access this new property for now (since IE8 can't handled reserved words as property names) an... [20:51:20] RoanKattouw: Can I grab a +2 on https://gerrit.wikimedia.org/r/#/c/191102/ please? [20:52:03] mooeypoo: I gotta eat lunch, i will give more review when I return [20:53:04] TrevorParscal, bon apetit. [20:54:40] (03PS1) 10Kmenger: Element: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191170 [20:54:49] TrevorParscal, for when you come back, just a quickie explanation -- the attribute settings for the data-whatever are there for visual inspection; they're strictly for debugging, I just didn't think that they're wasting anything by being there, so I left them in. The benefit is that if you randomly encounter a "bad case" (something is wrong with alignment or sizing) you can inspect the row and immediately spot the limits that it has [20:54:49] on itself. It is not strictly needed and the code has no use for it (the rows themselves cache those values in their own objects so I never read that value in the code) but i thought it was useful. I can either leave it or take it off, depending on your input. [20:55:14] (03CR) 10Mvolz: [C: 031] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [20:55:20] TrevorP|Away, ^ [21:02:38] mooeypoo: Maybe put in a FIXME to remove them? [21:18:13] James_F, well, it's in a patchset that's being reviewed. If we agree to take thenm off, I might as well just edit the ps [21:18:44] mooeypoo: Sure. [21:23:32] (03PS1) 10Kmenger: FieldLayout: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191185 [21:30:08] 3OOjs-UI: Audit all required constructor arguments and throw exceptions if they are not provided - e.g. FieldLayout - https://phabricator.wikimedia.org/T76648#1044841 (10matmarex) a:5matmarex>3None [21:30:10] 3VisualEditor: w: based interwiki links are shown as red after being made in VisualEditor - https://phabricator.wikimedia.org/T89724#1044843 (10Jdforrester-WMF) 5Open>3stalled [21:34:02] Krenair: Other than https://gerrit.wikimedia.org/r/#/c/189049/ what else do you have coming in MW-core that will need review? [21:34:18] Krenair: (Am talking to them about things we need from them.) [21:38:40] (03PS1) 10Bartosz Dziewoński: PHP: Remove redundant documentation for getInputElement() [oojs/ui] - 10https://gerrit.wikimedia.org/r/191187 [21:38:42] (03PS1) 10Bartosz Dziewoński: Some documentation tweaks [oojs/ui] - 10https://gerrit.wikimedia.org/r/191188 [21:44:01] James_F, https://gerrit.wikimedia.org/r/#/c/190607/ [21:46:23] (03PS1) 10Mvolz: [WIP] Add Grunt and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 [21:47:26] Krenair: Aha, of course, thanks. [21:50:36] mvolz: The task needs to be called 'test' to work in the CI pipeline. [21:54:32] 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1044890 (10matmarex) I'm going to skip the toolbar-related things, we will never support them in PHP and they'... [21:58:10] James_F: thanks :) [22:11:39] mvolz, the citoid service -- is it supposed to use the same code style as VE ? [22:12:03] 'cause I see a few instances where it doesn't, not sure if I should comment or not, since I seemed to pass your local grunt test? [22:20:51] (03PS1) 10Kmenger: FlaggedElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191197 [22:21:44] mooey|away: I think the services people use a different coding style than we do [22:23:41] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Moving an image in the document results in pixelated thumbnail - https://phabricator.wikimedia.org/T72816#1044936 (10Etonkovidova) It seems like it's been fixed - when resized(enlarged) images are dragged&dropped - they do not get reversed to the original r... [22:24:00] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Moving an image in the document results in pixelated thumbnail - https://phabricator.wikimedia.org/T72816#1044937 (10Etonkovidova) 5Open>3Resolved [22:29:18] 3VisualEditor, Parsoid, VisualEditor-Performance: Batch Parsoid's API requests - https://phabricator.wikimedia.org/T45888#1044949 (10ssastry) It is good thing to reduce the load on the API cluster, but I don't think this task should be a VE Q3 blocker. Right now, (a) Parsoid tracks all edits -- so there is goi... [22:29:57] 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1044952 (10violetto) 5Resolved>3Open I'm reopening this task also. It should look like the focus state for normal buttons like I described earlier. **Correct** {F42768} {F42769}... [22:32:53] 3OOjs-UI: Remove deprecated `nofollow` config option. - https://phabricator.wikimedia.org/T89767#1044961 (10cscott) 3NEW a:3cscott [22:34:40] (03PS1) 10Bartosz Dziewoński: FieldLayout: Clean up and remove lies [oojs/ui] - 10https://gerrit.wikimedia.org/r/191200 [22:34:43] (03PS1) 10Bartosz Dziewoński: PHP demo: Correct path to CSS files [oojs/ui] - 10https://gerrit.wikimedia.org/r/191201 [22:34:44] (03PS1) 10Bartosz Dziewoński: MediaWikiTheme: Resynchronize PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/191202 [22:36:50] 3UI-Standardization, OOjs-UI: Disabled button style not right - https://phabricator.wikimedia.org/T88483#1044978 (10violetto) Thanks, saw the fixes they look great. [22:37:43] 3UI-Standardization, OOjs-UI, WMF-Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1044979 (10violetto) Saw the changes, they look great. [22:37:50] (03PS6) 10Cscott: ButtonWidget: Rename nofollow config option to noFollow [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 [22:37:56] (03PS1) 10Kmenger: GroupElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191203 [22:39:06] (03CR) 10Cscott: "Created new task for the deprecation; added comments as suggested by Trevor and James." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [22:43:21] (03PS1) 10Cscott: [BREAKING CHANGE] ButtonWidget: remove deprecated nofollow option alias [oojs/ui] - 10https://gerrit.wikimedia.org/r/191204 (https://phabricator.wikimedia.org/T89767) [22:46:43] (03PS1) 10Kmenger: IconElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191205 [22:46:58] mooey|away: it's WIP [22:47:03] not done yet :) [22:58:08] 3VisualEditor-EditingTools, VisualEditor: Give exact match when looking for a specific file - https://phabricator.wikimedia.org/T64917#1045042 (10Etonkovidova) Using the double quotes produce the search results that match the exact phrase within the quote - as expected: So both following phrases will return the... [22:58:38] 3VisualEditor-EditingTools, VisualEditor: Give exact match when looking for a specific file - https://phabricator.wikimedia.org/T64917#1045045 (10Etonkovidova) 5Open>3declined [22:59:34] I need an adjective that means "is related to models" [23:00:11] the mixin I'm making can be used with any factory who's items are related to models (have a modelClasses property) [23:00:22] 3VisualEditor, VisualEditor-Performance, Parsoid: Batch Parsoid's API requests - https://phabricator.wikimedia.org/T45888#1045050 (10Jdforrester-WMF) I concur. [23:00:33] 3VisualEditor, Parsoid, VisualEditor-Performance: Batch Parsoid's API requests - https://phabricator.wikimedia.org/T45888#1045051 (10Jdforrester-WMF) [23:01:52] (03CR) 10Jforrester: [C: 04-2] "Not until 0.10.0 release." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191204 (https://phabricator.wikimedia.org/T89767) (owner: 10Cscott) [23:02:09] (03PS1) 10Kmenger: IconWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191207 [23:02:26] (03CR) 10Jforrester: [C: 04-2] "Not until 0.9.0 release." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński) [23:02:38] (03CR) 10Jforrester: [C: 04-2] "Not until 0.9.0 release." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 (owner: 10Bartosz Dziewoński) [23:03:17] TrevorParscal: "modely" ;) [23:03:22] "modeloid" [23:03:28] lol!!! [23:03:43] (03CR) 10Jforrester: [C: 04-1] "Needs to use the 'test' grunt task name to get run." [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (owner: 10Mvolz) [23:03:45] ModeledFactory [23:04:53] (03CR) 10Jforrester: [C: 032] ButtonWidget: Rename nofollow config option to noFollow [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [23:05:14] TrevorParscal: Modellesque. [23:05:18] mooeypoo: Modelling [23:05:30] TrevorParscal: Modelish. [23:05:40] TrevorParscal: Modelim. [23:06:20] (03Merged) 10jenkins-bot: ButtonWidget: Rename nofollow config option to noFollow [oojs/ui] - 10https://gerrit.wikimedia.org/r/190514 (owner: 10Cscott) [23:07:28] edsanders, you around for code review? https://gerrit.wikimedia.org/r/#/c/189628/ <-- switching MW to the new provider/queue and https://gerrit.wikimedia.org/r/#/c/190973/ Citoid inspetorizing [23:08:50] (03PS1) 10Kmenger: IndicatorElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191208 [23:09:31] inspectorizing* [23:10:26] 3VisualEditor, VisualEditor-Performance, VisualEditor-Initialisation: VisualEditor "beta" appended label causes edit tab to flicker - https://phabricator.wikimedia.org/T89668#1045063 (10Jdforrester-WMF) p:5Triage>3Volunteer? [23:11:21] 3VisualEditor, VisualEditor-MediaWiki: Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1045069 (10Jdforrester-WMF) p:5Triage>3Normal [23:12:21] 3VisualEditor, VisualEditor-CopyPaste, VisualEditor-DataModel: Pasting text with code annotations within other annotated text should not cause nesting - https://phabricator.wikimedia.org/T89545#1045074 (10Jdforrester-WMF) p:5Triage>3Normal [23:18:10] ugh, jshint's 'browser' preset is pretty evil [23:18:23] turns out that 'name' is a preset global variable, for example. [23:19:35] (03PS1) 10Kmenger: InputWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191210 [23:19:38] window.name is a string property :) [23:24:37] I wish I had a better name for an item in the context menu than ContextItem [23:27:15] "Bob" ? [23:28:19] 3VisualEditor, VisualEditor-Performance: Default to not performing sanity checks - https://phabricator.wikimedia.org/T87161#1045117 (10ori) [23:29:24] 3VisualEditor, VisualEditor-MediaWiki-References: [Regression wmf13] Creating a citation without filling in a required field throws "Cannot read property 'createElement' of null" - https://phabricator.wikimedia.org/T78626#1045126 (10Krenair) I unbroke beta, and then tried to reproduce this issue there, but could... [23:29:38] 3VisualEditor, VisualEditor-Performance: Default to not performing sanity checks - https://phabricator.wikimedia.org/T87161#985165 (10ori) Per discussion with Roan and James on 17-Feb-2015, we are going to stop running the sanity check on every run. We'll keep the code for now, but we'll hide it behind a magic q... [23:30:24] (03PS6) 10Catrope: MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://phabricator.wikimedia.org/T51452) (owner: 10Jforrester) [23:30:59] mooeypoo: Hm.. why does TemplateData create six global variables? [23:31:13] Krinkle, where? [23:31:15] I'm surprised Ed or Bartosz didn't flag this [23:31:22] mooeypoo: https://gerrit.wikimedia.org/r/#/c/167046/29 [23:31:35] It's creating six, new, implicit global variables [23:31:40] global classes? [23:31:53] That seems a bit uncalled for [23:32:06] all of VE has 1 [23:32:29] wait, I'm missing something, where are you looking at and what globals are you talking about? [23:32:37] meh [23:33:00] mooeypoo: variables are global by default in javascript. I suspect you ran into a jshint error and then added them to jshintrc to silence the error [23:33:02] Krinkle, you mean TemplateDataModel / TemplateDataDialog / etc ? [23:33:04] https://gerrit.wikimedia.org/r/#/c/167046/30/.jshintrc [23:33:08] that should've been a red flag [23:33:50] (03PS1) 10Catrope: Followup 0547d8c8: hopefully fix plugin garbage removal code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191212 [23:34:17] Krinkle, whats the good way of doing this? it used to be "mw.libs.templateDataGenerator" etc, but I was told to not use that anymore, and it also became long with some of those names. [23:34:18] ori: https://gerrit.wikimedia.org/r/191212 [23:34:26] (03CR) 10Jforrester: [C: 04-1] "This leads to horrible crashes when you e.g. try to insert a node into a heading." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://phabricator.wikimedia.org/T51452) (owner: 10Jforrester) [23:35:10] Krinkle, also, VE is big enough to warrant leaking a global to the window context as 've' and hanging everything else from there, I didn't think TemplateData warranted that? [23:35:14] mooeypoo: anything really. mw.TemplateData.Model, mw.tdg.Model, or if it justifies its own namespace (which it doesn't) it could be TemplateData.Model (where TemplateData is the namespace, like jQuery, and OO) [23:35:30] mooeypoo: You think TemplateData warrants 6 of those? [23:35:31] ;-) [23:35:35] mooeypoo: mw.TemplateData >>>> mw.tdg. [23:36:08] Krinkle: Could you review https://gerrit.wikimedia.org/r/191212? [23:36:15] okay [23:36:26] Krenair: You may also want to see https://gerrit.wikimedia.org/r/191212 [23:36:43] mw.TemplateData would be fine. Just no new global variable for each class. [23:36:52] Krinkle, alright, I'll fix it up [23:37:03] Nest it under TemplateData.* or mw.TemplateData.* or mw.tdg. No preference there. :) [23:37:33] RoanKattouw: ok [23:38:59] (03CR) 10Catrope: [C: 032] Fix V8 deopt for ve.ce.BranchNode#onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189683 (owner: 10Ori.livneh) [23:39:18] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/191102/ please? [23:39:49] edsanders: Are you going to merge https://gerrit.wikimedia.org/r/#/c/189769/ or not today? [23:39:55] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (4d6cd42) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191102 (owner: 10Jforrester) [23:40:03] RoanKattouw: And https://gerrit.wikimedia.org/r/#/c/189737/ maybe? [23:40:18] maybe [23:40:32] Committal. That's what I like about you. :-) [23:41:05] (03Merged) 10jenkins-bot: Fix V8 deopt for ve.ce.BranchNode#onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189683 (owner: 10Ori.livneh) [23:41:32] (03Merged) 10jenkins-bot: Update VE core submodule to master (4d6cd42) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191102 (owner: 10Jforrester) [23:42:55] (03CR) 10Esanders: [C: 04-1] Adjust Queue and Provider to work with generalized parents (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo) [23:43:48] (03PS2) 10Krinkle: mw.Target: Hopefully fix plugin garbage removal code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191212 (owner: 10Catrope) [23:44:45] (03PS3) 10Krinkle: mw.Target: Hopefully fix plugin garbage removal code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191212 (owner: 10Catrope) [23:45:05] RoanKattouw: Got any particular test case that is easy repro, or are they all weird stuff? [23:45:07] (03CR) 10Jforrester: [C: 04-1] "Killing the end-of-line comments produces ghastly code style." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191212 (owner: 10Catrope) [23:45:21] Krinkle: There are no reproduction steps. There never have been. [23:46:16] (03CR) 10Jforrester: mw.Target: Hopefully fix plugin garbage removal code (0310 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191212 (owner: 10Catrope) [23:46:55] Krinkle, ... why [23:47:00] RoanKattouw, does dom elements commit have serious implications for DM serialization? [23:47:28] (03PS1) 10Bartosz Dziewoński: [WIP] Don't use positional arguments to constructors that take 'config' objects [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) [23:47:46] Tail comments are hard to read. And less structured. Looks messy [23:48:15] Actually I think the tail comments were easier to read than this [23:48:32] Especially in the mids of string concatenation where the comma and plus sign are enough to keep track of [23:49:12] Krenair: It's just like a plain object with keys and values next to one another. Comments on top aligned, values below. How is it differnet from any other inline comments we have. [23:49:22] Also, what's with all teh weird selectors? [23:49:51] They are trying to catch out specific broken browser plugins that we've seen so far [23:50:00] I mean the formatting [23:50:04] I know the values and matching pattern [23:50:11] [ id = foo ] ? [23:51:03] They're supposed now natively, since latest jQuery. Though attribtue selectors are still quite buggy and tend to incur full recursion [23:51:07] in safari it still happens [23:51:13] supported( [23:53:09] (03PS4) 10Krinkle: mw.Target: Hopefully fix plugin garbage removal code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191212 (owner: 10Catrope) [23:53:11] Anyway, not my problem. [23:53:18] Too tired to argue for this one [23:53:53] (03CR) 10Esanders: "the rule until this point was that required arguments weren't in config. why are we changing this?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński) [23:54:06] (03CR) 10Alex Monk: [C: 032] mw.Target: Hopefully fix plugin garbage removal code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191212 (owner: 10Catrope) [23:54:08] I figured of all styles this one would be least controversial [23:55:30] (03CR) 10Esanders: [C: 032] FieldLayout: Clean up and remove lies [oojs/ui] - 10https://gerrit.wikimedia.org/r/191200 (owner: 10Bartosz Dziewoński) [23:55:42] (03Merged) 10jenkins-bot: mw.Target: Hopefully fix plugin garbage removal code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191212 (owner: 10Catrope) [23:56:08] (03CR) 10Esanders: [C: 032] Some documentation tweaks [oojs/ui] - 10https://gerrit.wikimedia.org/r/191188 (owner: 10Bartosz Dziewoński) [23:56:36] (03CR) 10Esanders: [C: 032] PHP: Remove redundant documentation for getInputElement() [oojs/ui] - 10https://gerrit.wikimedia.org/r/191187 (owner: 10Bartosz Dziewoński) [23:57:05] (03PS1) 10Kmenger: SelectWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191216 [23:57:42] (03PS1) 10Mooeypoo: Change global class variables to mw.TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 [23:57:45] Krinkle, ^^ [23:58:14] (03Merged) 10jenkins-bot: PHP: Remove redundant documentation for getInputElement() [oojs/ui] - 10https://gerrit.wikimedia.org/r/191187 (owner: 10Bartosz Dziewoński) [23:58:16] (03Merged) 10jenkins-bot: Some documentation tweaks [oojs/ui] - 10https://gerrit.wikimedia.org/r/191188 (owner: 10Bartosz Dziewoński) [23:58:17] mooeypoo: cool. [23:58:18] (03Merged) 10jenkins-bot: FieldLayout: Clean up and remove lies [oojs/ui] - 10https://gerrit.wikimedia.org/r/191200 (owner: 10Bartosz Dziewoński) [23:59:03] mooeypoo: Not for now, but I also noticed it lists jquery twice and mediawiki twice. To match other projects, use mw/$ or mediaWiki/jQuery. Not both.