[00:00:08] <Krenair>	 James_F, so in my TODO for the WikiEditor instrumentation stuff, I think I need to: Figure out abort.type, wait for analytics to deal with the saveFailure.type schema (emailed details), wait for my MW core dependencies to be merged...
[00:00:15] <Krenair>	 and then maybe I can upload a commit to WikiEditor
[00:00:32] <mooeypoo>	 Krinkle, oh, I thought both should be declared. I can take it off in this commit too as part of the cleanup
[00:01:00] <Krenair>	 well, maybe the last two (core dependencies and WE commit) can be swapped
[00:02:22] <Krinkle>	 mooeypoo: declaring both means your application can get into a state where half the code work and the other half not (depending on which one fails) and under normal modus, it's just inconsistent to mix them. In ve we want to use $ and mw directly (so no aliasing from mediaWiki/jQuery). the "jquery" (lowercase) setting is from JSHint to tolerate both. You'll want to add $ and mw to globals, (wi
[00:02:22] <Krinkle>	 th value 'false', read-only roots)
[00:03:14] <Krinkle>	 mooeypoo: most files already use mw directly without a function closure around the file. in td. Nice 
[00:03:28] <grrrit-wm>	 (03CR) 10Krinkle: Change global class variables to mw.TemplateData (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 (owner: 10Mooeypoo)
[00:03:59] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "If you click away from inspector without filling in a URL you get a reference to nothing left in the document." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo)
[00:08:23] <wikibugs>	 3VisualEditor: [Regression wmf-16] Including a template/comment/table/gallery/math node in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1045233 (10Ryasmeen)
[00:15:22] <James_F>	 Krenair: You could upload your patch now. :-)
[00:15:27] <James_F>	 Krenair: But sure.
[00:15:50] <Krenair>	 it's not ready because I need to deal with abort.type and I hope saveFailure.type will change
[00:16:18] <Krenair>	 But I guess I could upload it now
[00:19:05] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Creating numbered lists with images resets the numbering back to 1 for each list item - https://phabricator.wikimedia.org/T71205#1045247 (10Etonkovidova) Step #4 "they... select their image, and place it with their cursor directly at the end of the line."- is not repr...
[00:19:14] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Creating numbered lists with images resets the numbering back to 1 for each list item - https://phabricator.wikimedia.org/T71205#1045248 (10Etonkovidova) 5Open>3Resolved
[00:21:53] <mooeypoo>	 Krinkle, yeah I only made a closure for the .ui file that is a singleton that intializes everything else.
[00:24:18] <grrrit-wm>	 (03CR) 10Krinkle: [WIP] Add Grunt and clean-up its errors (034 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (owner: 10Mvolz)
[00:24:23] <mooeypoo>	 Krinkle, when I take off "mediaWiki": false I get a lot of errors in grunt
[00:25:30] <mooeypoo>	 actually, ha, I already have mw in there. I can just use that instead of mediaWiki I think
[00:26:49] <grrrit-wm>	 (03CR) 10Mooeypoo: Change global class variables to mw.TemplateData (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 (owner: 10Mooeypoo)
[00:31:33] <grrrit-wm>	 (03PS2) 10Mooeypoo: Change global class variables to mw.TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 
[00:32:05] <grrrit-wm>	 (03PS1) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) 
[00:32:10] <Krenair>	 James_F, meh, I decided to just upload it
[00:32:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk)
[00:32:28] <Krenair>	 will probably notice a ton of issues myself when I first look at it in gerrit
[00:33:34] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1045293 (10Krinkle) While this error is only intermittently reported by Jenkins in the karma-qunit experimental job, this is likely because the build often f...
[00:33:47] <wikibugs>	 3VisualEditor-MediaWiki, VisualEditor: Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1045296 (10Krinkle)
[00:33:49] <wikibugs>	 3Continuous-Integration, VisualEditor: Jenkins: Convert mwext qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#765899 (10Krinkle)
[00:34:49] <Krenair>	 And Jenkins will help, of course
[00:34:54] <Krenair>	 unlike usual
[00:35:00] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor: VisualEditor:  If you open the image inspector, and the image doesn't have a type specified (like thumb), then you can't get out again - https://phabricator.wikimedia.org/T67166#1045298 (10Etonkovidova) 5Open>3Resolved
[00:35:01] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-Plugins: VisualEditor: Support media (tracking) - https://phabricator.wikimedia.org/T39870#1045300 (10Etonkovidova)
[00:36:46] <grrrit-wm>	 (03PS2) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) 
[00:36:48] <Krenair>	 I missed a bit of the commit.
[00:40:40] <James_F>	 Krenair: Cool.
[00:41:59] <grrrit-wm>	 (03PS3) 10Catrope: Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders)
[00:42:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk)
[00:43:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders)
[00:45:25] <grrrit-wm>	 (03PS3) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) 
[00:48:06] <Krinkle>	 mooeypoo: jscs doesn't run on that repo, but generally there's no space between } and () there on the bottom. The previous code didn't have it either :)
[00:48:17] <Krinkle>	 It's fine though. We can do a jscs pass later.
[00:48:19] <James_F>	 mooeypoo: Seen https://phabricator.wikimedia.org/T89435 ?
[00:49:04] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Media: License URLs in VisualEditor media insertion dialog are broken - https://phabricator.wikimedia.org/T89544#1045341 (10Etonkovidova) Checked in betalabs.
[00:57:45] <wikibugs>	 3VisualEditor, WikiEditor, VisualEditor-Performance, Analytics, MediaWiki-Core-Team: Apply Schema:Edit instrumentation to WikiEditor - https://phabricator.wikimedia.org/T88027#1045363 (10Krenair) TODO: * I should figure out what we can do about action.abort.type * Deal with the action.saveFailure.type schema iss...
[00:58:04] <Krenair>	 James_F, ^
[00:58:47] <James_F>	 Krenair: Saw, thanks.
[00:59:02] <Krenair>	 I wasn't sure if I should use the Blocked-on- tags or not James_F 
[00:59:18] <James_F>	 LGTM.
[00:59:26] <Krenair>	 I'm not sure how urgent we consider this right now
[00:59:34] <James_F>	 Lots urgent.
[00:59:48] <James_F>	 Did you see the WMF quarterly report? This was the only non-green item.
[01:05:23] <grrrit-wm>	 (03PS6) 10Mooeypoo: Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) 
[01:05:31] <Krenair>	 James_F, I probably did, but do you happen to have a link?
[01:06:26] <James_F>	 Krenair: One moment.
[01:06:57] <grrrit-wm>	 (03CR) 10Mooeypoo: "I've fixed the inspector to pop staging when it loses focus." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo)
[01:07:01] <James_F>	 Krenair: https://upload.wikimedia.org/wikipedia/commons/1/11/Wikimedia_Foundation_Quarterly_Report%2C_FY_2014-15_Q2_%28October-December%29.pdf
[01:07:38] <James_F>	 Krenair: Slide 6.
[01:07:45] <Krenair>	 thanks
[01:08:31] <mooeypoo>	 James_F, I'll take a look, but Krenair should probably be aware of this too as it seems to be ImageInfoCache
[01:08:40] <mooeypoo>	 James_F, Krenair this https://phabricator.wikimedia.org/T89435
[01:09:02] <James_F>	 Oh, right, yeah.
[01:09:23] <mooeypoo>	 Krenair, this is the reason I have "if ve.init.platform" in MWImageNode btw.
[01:09:42] <Krenair>	 ah
[01:09:57] <Krenair>	 yeah I saw a bit of that earlier because it's tagged for VE-MW
[01:10:05] <mooeypoo>	 Krenair, you fixed it up to if ( ve.init.platform.imageInfoCache ) {
[01:10:23] <mooeypoo>	 which is the same idea -- but I think it's missing from ImageInfoCache
[01:13:45] <wikibugs>	 3VisualEditor, VisualEditor-Performance: Instrument (i.e., track) additional progress markers for VE load - https://phabricator.wikimedia.org/T89536#1045421 (10ori) Suppose we call these "phases". For each phase, I need an "entry" event and an "exit" event. For example:  ```lang=js ve.track( 'trace.setupToolbar....
[01:15:22] <Krenair>	 "getRequestPromise assumes ve.init.target exists, accessing apiRequest."
[01:15:23] <Krenair>	 aha
[01:15:27] <Krenair>	 I have a commit that might fix that :p
[01:17:52] <wikibugs>	 3UI-Standardization, OOjs-UI: Disabled OOjs UI button in MediaWiki theme needs more contrast - https://phabricator.wikimedia.org/T88038#1045424 (10violetto) @Prtksxna, yes those color values are accurate. I checked the updated demo today and they look great.
[01:18:31] <grrrit-wm>	 (03PS1) 10Catrope: Remove the sanity check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191233 (https://phabricator.wikimedia.org/T87161) 
[01:20:26] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Remove the sanity check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191233 (https://phabricator.wikimedia.org/T87161) (owner: 10Catrope)
[01:21:29] <grrrit-wm>	 (03CR) 10Catrope: "You can still perform a sanity check from the console as follows:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191233 (https://phabricator.wikimedia.org/T87161) (owner: 10Catrope)
[01:22:00] <grrrit-wm>	 (03CR) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo)
[01:22:32] <grrrit-wm>	 (03PS19) 10Mooeypoo: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 
[01:27:21] <Krenair>	 mooey|away, I'm not quite sure what you mean in your last two messages though
[01:27:27] <Krenair>	 <mooeypoo> Krenair, you fixed it up to if ( ve.init.platform.imageInfoCache ) {
[01:27:28] <Krenair>	 <mooeypoo> which is the same idea -- but I think it's missing from ImageInfoCache
[01:28:24] <Krenair>	 check for ve.init.platform.imageInfoCache... in ImageInfoCache? :/
[01:37:08] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "Tested on osmium." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191233 (https://phabricator.wikimedia.org/T87161) (owner: 10Catrope)
[01:38:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove the sanity check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191233 (https://phabricator.wikimedia.org/T87161) (owner: 10Catrope)
[02:03:45] <wikibugs>	 3VisualEditor, VisualEditor-Performance, Analytics-Engineering: Report on the central tendency for length of pages which are edited for VisualEditor performance benchmarking - https://phabricator.wikimedia.org/T89788#1045518 (10Jdforrester-WMF) 3NEW a:3Milimetric
[02:06:58] <wikibugs>	 3VisualEditor, VisualEditor-Performance: Default to not performing sanity checks - https://phabricator.wikimedia.org/T87161#1045527 (10Jdforrester-WMF) 5Open>3Resolved
[02:28:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders)
[02:59:52] <grrrit-wm>	 (03PS12) 10Cscott: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) 
[02:59:54] <grrrit-wm>	 (03PS1) 10Cscott: Element.php: Add "data" property [oojs/ui] - 10https://gerrit.wikimedia.org/r/191243 
[02:59:56] <grrrit-wm>	 (03PS1) 10Cscott: Element.php: Add "text" configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/191244 
[03:00:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott)
[03:01:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Element.php: Add "text" configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/191244 (owner: 10Cscott)
[03:09:48] <grrrit-wm>	 (03PS13) 10Cscott: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) 
[03:09:50] <grrrit-wm>	 (03PS2) 10Cscott: Element.php: Add "text" configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/191244 
[08:12:40] <grrrit-wm>	 (03CR) 10Prtksxna: "Reducing the opacity of the icons will cause problems on colored backgrounds." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna)
[08:27:39] <wikibugs>	 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1045920 (10Prtksxna) >>! In T87692#1044952, @violetto wrote: > @Prtksxna, can we make it so it's 1px inside 1px outside? So it's 2px in total. This applies to all focus states with an o...
[08:28:44] <grrrit-wm>	 (03PS1) 10Prtksxna: MediaWiki Theme: Fix border width for frameless buttons' focus state [oojs/ui] - 10https://gerrit.wikimedia.org/r/191266 (https://phabricator.wikimedia.org/T87692) 
[08:34:59] <wikibugs>	 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1045924 (10violetto) @Prtksxna, can it have the same padding around the text like a normal framed button?
[08:50:24] <wikibugs>	 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1045937 (10Prtksxna) >>! In T87692#1045924, @violetto wrote: > @Prtksxna, can it have the same padding around the text like a normal framed button?  I am not sure where this is being us...
[08:53:06] <wikibugs>	 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1045939 (10violetto) I imagine links in the top header, secondary actions in a workflow next to a primary button, etc. Definitely not used as anchor links where it might mess things up....
[08:54:52] <wikibugs>	 3OOjs-UI, VisualEditor: Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1045940 (10TheDJ) 3NEW
[09:01:53] <wikibugs>	 3VisualEditor: Clicking the title should give feedback as to why it is not editable - https://phabricator.wikimedia.org/T89811#1045952 (10TheDJ) 3NEW
[09:08:28] <wikibugs>	 3OOjs-UI: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari - https://phabricator.wikimedia.org/T69156#1045960 (10TheDJ) if jQuery UI can add a selector focusable and 'tabbable' for this. Can't we mix those in ourselves ? We'd have to account for the situation where both jQueryUI and OOjs UI are l...
[09:11:46] <wikibugs>	 3OOjs-UI: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari - https://phabricator.wikimedia.org/T69156#1045961 (10TheDJ) Let me add links for jQuery UI's :focusable and :tabbable   http://api.jqueryui.com/focusable-selector/ http://api.jqueryui.com/tabbable-selector/
[09:35:36] <wikibugs>	 3OOjs-UI: Toolbar menus don't disappear when another menu is opened on touch devices - https://phabricator.wikimedia.org/T87818#1045987 (10TheDJ) This is also reproducible if you use keyboard navigation btw.
[10:27:10] <grrrit-wm>	 (03PS1) 10Ori.livneh: Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 
[10:28:38] <grrrit-wm>	 (03PS2) 10Ori.livneh: Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 
[10:31:26] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update for Ia0e0fe4fc: Replace ve.dm.Model#matchesAttributeSpec [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 
[10:31:31] <wikibugs>	 3OOjs-UI: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari - https://phabricator.wikimedia.org/T69156#1046074 (10TheDJ) Some more notes: * The previously suggested focus trap only works for tab, not for shift-tab * a focus trap only fixes keyboard navigation, not screenreader accessibility ** You...
[10:31:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update for Ia0e0fe4fc: Replace ve.dm.Model#matchesAttributeSpec [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh)
[10:33:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[11:03:04] <wikibugs>	 3WikiLove, OOjs-UI, Possible-Tech-Projects: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#1046101 (10TheDJ) 3NEW
[11:35:30] <grrrit-wm>	 (03PS18) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 
[11:37:04] <grrrit-wm>	 (03CR) 10Paladox: "Hi I am not ignoring you question. I have uploaded the changes that you suggested adding. Please could you review again and see if I misse" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox)
[11:37:14] <grrrit-wm>	 (03CR) 10Paladox: "@Mattflaschen" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox)
[12:00:42] <wikibugs>	 3OOjs-UI, VisualEditor: Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1046159 (10matmarex)
[12:00:43] <wikibugs>	 3OOjs-UI: PopupButtonWidget menu is not keyboard traversable/closeable - https://phabricator.wikimedia.org/T87695#1046160 (10matmarex)
[12:01:05] <wikibugs>	 3OOjs-UI: PopupButtonWidget menu is not keyboard traversable/closeable - https://phabricator.wikimedia.org/T87695#1046161 (10matmarex) a:3Prtksxna
[12:34:42] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "We've been using opacity to change the shade for a while already, I don't think we should worry about it until someone reports it as actua" [oojs/ui] - 10https://gerrit.wikimedia.org/r/189945 (https://phabricator.wikimedia.org/T88483) (owner: 10Prtksxna)
[12:51:32] <wikibugs>	 3WikiLove, OOjs-UI, Possible-Tech-Projects: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#1046192 (10Ricordisamoa) a:3Ricordisamoa
[13:13:23] <Krenair>	 James_F isn't it like 5 AM there?
[13:17:09] <MatmaRex>	 James_F does not wake at the sight of dawn; dawn wakes at the sight of James_F
[13:33:09] <tommorris>	 MatmaRex: truth.
[14:14:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] PHP demo: Correct path to CSS files [oojs/ui] - 10https://gerrit.wikimedia.org/r/191201 (owner: 10Bartosz Dziewoński)
[14:15:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: PHP demo: Correct path to CSS files [oojs/ui] - 10https://gerrit.wikimedia.org/r/191201 (owner: 10Bartosz Dziewoński)
[14:19:48] <wikibugs>	 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1046258 (10matmarex) I have no strong feelings one way or the other.  Krinkle's proposal requires copying the property/method references, rather than relying on prototypes to...
[14:31:36] <wikibugs>	 3OOjs-UI: All icons should use 65% black rather than solid black in the MediaWiki theme - https://phabricator.wikimedia.org/T86047#1046283 (10Prtksxna) Would that be `#A5A5A5`?
[14:32:04] <prtksxna>	 MatmaRex: Would that (^) make all the icons look gray?
[14:33:53] <MatmaRex>	 allegedly
[14:34:20] <MatmaRex>	 i have no idea why we'd want that, myself
[14:35:19] <grrrit-wm>	 (03CR) 10Prtksxna: [C: 032] MediaWikiTheme: Resynchronize PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/191202 (owner: 10Bartosz Dziewoński)
[14:36:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWikiTheme: Resynchronize PHP with JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/191202 (owner: 10Bartosz Dziewoński)
[14:37:13] <prtksxna>	 I suppose it won't be for the whole theme.
[15:17:54] <James_F>	 Krenair: It's 07:17 here now. I generally wake at ~ 05:45 and simple code review is simple. :-)
[15:18:23] <Krenair>	 You logged into IRC at about 05:10
[15:18:26] <James_F>	 Krenair: I'm now in the office, if you're curious. :-)
[15:18:44] <Krenair>	 maybe that was just your bouncer unbreaking though
[15:18:49] <James_F>	 Oh, that. That was my bouncer reconnecting because freenode flaked. Shock, horror.
[15:26:04] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Clicking the page's title h1 should give feedback as to why it is not editable - https://phabricator.wikimedia.org/T89811#1046371 (10Jdforrester-WMF) p:5Triage>3Normal
[15:27:42] <wikibugs>	 3OOjs-UI, VisualEditor: Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1046382 (10Jdforrester-WMF) I would say that this is "intentional behaviour" on the part of VisualEditor, but this issue will go away in this case once {...
[15:28:54] <wikibugs>	 3VisualEditor: Category disappeared during edit - https://phabricator.wikimedia.org/T85671#1046387 (10Jdforrester-WMF)
[15:32:53] <wikibugs>	 3OOjs-UI, VisualEditor: [Regression wmf-17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1046418 (10Jdforrester-WMF)
[15:33:06] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1044098 (10Jdforrester-WMF)
[15:33:23] <wikibugs>	 3VisualEditor, VisualEditor-Performance: ve.init.mw.ViewPageTarget.transformPage triggers recalculate style due to $.fn.animate - https://phabricator.wikimedia.org/T89543#1046421 (10Jdforrester-WMF)
[15:33:40] <wikibugs>	 3VisualEditor, VisualEditor-Performance: Instrument (i.e., track) additional progress markers for VE load - https://phabricator.wikimedia.org/T89536#1046423 (10Jdforrester-WMF)
[15:33:53] <wikibugs>	 3Continuous-Integration, VisualEditor: Investigate Chrome disconnect failures when running MediaWiki tests on labs slaves - https://phabricator.wikimedia.org/T89075#1046426 (10Jdforrester-WMF)
[15:34:19] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1046428 (10Jdforrester-WMF)
[15:34:41] <wikibugs>	 3VisualEditor, Analytics-Engineering, VisualEditor-Performance: Report on the central tendency for length of pages which are edited for VisualEditor performance benchmarking - https://phabricator.wikimedia.org/T89788#1046434 (10Jdforrester-WMF)
[15:38:42] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: Native browser interactive spell-check tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T61748#1046463 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF >>! In T61748#836003, @Whatamidoing-WMF wrote: > I think we're...
[15:55:52] <whatami>	 The second weekly bug triage meeting will start in about five minutes.  Instructions for joining the WebEx portion of the meeting are at https://www.mediawiki.org/wiki/Talk:VisualEditor/Portal  I plan to post links to the bugs being discussed in #wikimedia-office if you want to follow along in IRC.
[16:09:07] <wikibugs>	 3OOjs-UI: All icons should use 65% black rather than solid black in the MediaWiki theme - https://phabricator.wikimedia.org/T86047#1046597 (10KHammerstein) @Prtksxna Its #555
[16:20:02] <Krinkle>	 MatmaRex: There's a way to rid .static *and* not do a copy.
[16:20:23] <Krinkle>	 Testing at the moment, but pretty sure it works. And actually performs faster than Object.create and sometimes faster than copy as well.
[16:20:58] <Krinkle>	 And incidentally, also what ES6 will use for static members of its classes.
[16:22:10] <MatmaRex>	 Krinkle: the __proto__ thing you mentioned? i was under impression it's not widely supported?
[16:22:16] <wikibugs>	 3OOjs-UI, VisualEditor: [Regression wmf-17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1046674 (10Aklapper) Is there any relevant output in the [[ https://developer.apple.com/library/mac/documentation/AppleApplications/Conceptual/Safari_Developer_Guide/Introduction/Introduc...
[16:22:42] <MatmaRex>	 it'd be very neat if it works
[16:23:05] <Krinkle>	 MatmaRex: Modifying rich existing objects receives a penalty as v8 would have no clue what an object will look like. It assumes it doesnt' change
[16:23:19] <Krinkle>	 but right after creation is fine. And the recommended method for polyfils of ES6 as well.
[16:23:49] <MatmaRex>	 whee
[16:24:02] <Krinkle>	 Looks like old IE doesn't support it
[16:24:08] <Krinkle>	 in any form
[16:24:15] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1046697 (10damons) I think 20ms is massive.
[16:24:28] <Krinkle>	 MatmaRex: http://jsfiddle.net/vvnghzbc/
[16:24:45] <Krinkle>	 MatmaRex: The nice thing is also that using proto one doesn't have to restore .constructor and .prototype
[16:24:48] <Krinkle>	 they just naturally work
[16:24:55] <Krinkle>	 and remain non-enumerable as well. which is neat
[16:24:58] <Krinkle>	 Oh well.
[16:29:54] <Krinkle>	 http://jsperf.com/constructor-vs-v8-proto/3
[16:46:02] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1046858 (10Krenair) >>! In T89423#1044418, @ori wrote: >>>! In T89423#1037020, @matmarex wrote: >> What page were you testing on? >  > http://osmium/wiki/Ba...
[16:50:12] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1046873 (10matmarex) Indeed, I don't have access to production (and don't really want it). I'll assume that you basically tested on en.wp, dig in and see wh...
[16:51:22] <wikibugs>	 3VisualEditor-MediaWiki-Links, VisualEditor: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1046880 (10Jdforrester-WMF) p:5High>3Normal
[17:08:46] <wikibugs>	 3VisualEditor, Analytics-Engineering, VisualEditor-Performance, Analytics-Kanban: Report on the central tendency for length of pages which are edited for VisualEditor performance benchmarking - https://phabricator.wikimedia.org/T89788#1046935 (10ggellerman)
[17:10:24] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T89072#1046949 (10Jdforrester-WMF)
[17:10:25] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Create a guided tour for VisualEditor using Getting Started tooltips - https://phabricator.wikimedia.org/T89074#1046950 (10Jdforrester-WMF)
[17:19:04] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T89072#1046975 (10Wittylama) Further to Erik's comment in the Triage meeting about this -  One of the first things that existing wikimedians will want to know when they...
[17:28:21] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1047031 (10Jdforrester-WMF)
[17:28:29] <wikibugs>	 3VisualEditor, VisualEditor-Performance: Instrument (i.e., track) additional progress markers for VE load - https://phabricator.wikimedia.org/T89536#1047032 (10Jdforrester-WMF)
[17:28:38] <wikibugs>	 3VisualEditor, VisualEditor-Performance: ve.init.mw.ViewPageTarget.transformPage triggers recalculate style due to $.fn.animate - https://phabricator.wikimedia.org/T89543#1047033 (10Jdforrester-WMF)
[17:28:49] <wikibugs>	 3OOjs-UI, VisualEditor: [Regression wmf-17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1047034 (10Jdforrester-WMF)
[17:28:57] <wikibugs>	 3VisualEditor: [Regression wmf-16] Including a template/comment/table/gallery/math node in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1047035 (10Jdforrester-WMF)
[17:29:06] <wikibugs>	 3Continuous-Integration, VisualEditor: Investigate Chrome disconnect failures when running MediaWiki tests on labs slaves - https://phabricator.wikimedia.org/T89075#1047036 (10Jdforrester-WMF)
[17:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111947620
[17:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111947672
[17:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111959077
[17:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111970687
[17:30:32] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70916212
[17:30:33] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70917274
[17:30:33] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70918179
[17:30:34] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ltwiki: https://lt.wikipedia.org/?diff=4710273
[17:33:08] <MatmaRex>	 James_F: hey, we talked about the VE "Edit" tab not showing up in debug mode the other day, didn't we? did anyone figure out why it happens?
[17:33:26] <James_F>	 MatmaRex: User module sent at the wrong time in debug mode.
[17:33:48] <MatmaRex>	 oh. right. isn't that ori's fault? :>
[17:39:35] <grrrit-wm>	 (03PS1) 10Kmenger: Window: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191363 
[18:10:29] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1047188 (10Krenair) I just tried this and could not reproduce the issue. Do you get this consistently? Can you write the steps down here?
[18:14:48] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Create a guided tour for VisualEditor using Getting Started tooltips - https://phabricator.wikimedia.org/T89074#1047204 (10Jdforrester-WMF)
[18:14:55] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Change Welcome dialogue content to more helpful message to new users - https://phabricator.wikimedia.org/T89072#1047205 (10Jdforrester-WMF)
[18:24:19] <ori>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/191287/
[18:24:34] <ori>	 I need to fix the tests, but quick sanity check appreciated
[18:24:39] <RoanKattouw>	 Yeah already looking
[18:24:46] <RoanKattouw>	 Thanks for that man
[18:24:56] <RoanKattouw>	 I had also noticed in profiling that that function had high overheda
[18:25:16] <RoanKattouw>	 I optimized a little bit by checking for false early, and by doing the isEqualDomElements thing
[18:25:46] <RoanKattouw>	 (i.e. if the output DOM node is already equal to the DOM node we're going to transplant attributes from, don't do anything)
[18:25:50] <RoanKattouw>	 But this is good
[18:27:09] <ori>	 cool, i'll fix the tests then
[18:27:12] <RoanKattouw>	 ori: However please rebase your commit onto https://gerrit.wikimedia.org/r/189769
[18:27:22] <RoanKattouw>	 Which renames that property
[18:28:09] <ori>	 will do
[18:28:11] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: Change Welcome dialogue content to more helpful message to new users based on the GuidedTour - https://phabricator.wikimedia.org/T89072#1047229 (10Jdforrester-WMF)
[18:28:53] <RoanKattouw>	 You will have to redo a few things though because buildHtmlAttributeList goes away completely
[18:29:02] <RoanKattouw>	 And instead the filtering logic is in renderHtmlAttributeList
[18:30:23] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Needs rebasing onto https://gerrit.wikimedia.org/r/189769" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[18:32:55] <grrrit-wm>	 (03CR) 10Ori.livneh: Replace ve.dm.Model#matchesAttributeSpec (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[18:35:33] <grrrit-wm>	 (03PS1) 10Kmenger: WindowManager: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191371 
[18:37:46] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1047264 (10matmarex) Good news! I have discovered that we accidentally disable and then re-enable pretty much the entire toolbar while the page loads. Getti...
[18:38:29] <MatmaRex>	 RoanKattouw: edsanders: at least one of you probably should look at that ^
[18:38:48] <RoanKattouw>	 Ooh
[18:38:55] <RoanKattouw>	 I'll look at that after my meeting
[18:39:06] <ori>	 \o/
[18:39:27] <ori>	 RoanKattouw: btw, I'm a bit sick and have a doctor's appt in the afternoon; I won't be in until 2 or 3 today
[18:39:35] <RoanKattouw>	 OK
[18:40:03] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/189472/ then https://gerrit.wikimedia.org/r/#/c/191130/ then https://gerrit.wikimedia.org/r/#/c/187951/ + stack then your work to get https://gerrit.wikimedia.org/r/#/c/191037/ and https://gerrit.wikimedia.org/r/#/c/162310/ working (MW-land tests for class duplication, and MWHeader munging).
[18:40:58] <RoanKattouw>	 James_F: Should we backport the myEventWatcherDiv fix to wmf17?
[18:41:02] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/189769/ then https://gerrit.wikimedia.org/r/#/c/189628/ then https://gerrit.wikimedia.org/r/#/c/186548/
[18:41:11] <RoanKattouw>	 needcheck showed a few of those again today
[18:41:17] <James_F>	 RoanKattouw: Yeah, let's.
[18:41:24] <RoanKattouw>	 Cool, will do
[18:41:27] <James_F>	 Ta.
[18:45:37] <grrrit-wm>	 (03PS1) 10Catrope: mw.Target: Hopefully fix plugin garbage removal code [extensions/VisualEditor] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/191376 
[18:46:36] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1047284 (10Esanders) what is the order of things in core?
[18:46:52] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki: The message visualeditor-recreate says "Press continue", but it's unclear what does "continue" refer to - https://phabricator.wikimedia.org/T75971#1047289 (10Jdforrester-WMF) p:5Triage>3Low
[18:47:04] <wikibugs>	 3VisualEditor, VisualEditor-ContentLanguage: First word in new paragraph using an IME disappears after pressing space - https://phabricator.wikimedia.org/T76281#1047290 (10Jdforrester-WMF) p:5Triage>3High
[18:48:43] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: ve.ui.Toolbar: Don't call #updateToolState from #initialize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191378 (https://phabricator.wikimedia.org/T89423) 
[18:49:34] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Needs Ed or Roan to check my reasoning." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191378 (https://phabricator.wikimedia.org/T89423) (owner: 10Bartosz Dziewoński)
[18:49:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] mw.Target: Hopefully fix plugin garbage removal code [extensions/VisualEditor] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/191376 (owner: 10Catrope)
[18:51:50] <wikibugs>	 3MediaWiki-Interface, VisualEditor, Parsoid, MediaWiki-General-or-Unknown, RESTBase, Services, VisualEditor-Performance: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#1047315 (10GWicke) @jdforrester-wmf, is this really high priority for you right now right now? Should we pri...
[18:56:35] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1047317 (10matmarex) Standalone has the same order – first setSurface() is called, calling Toolbar#initialize, which disables everything because there's no...
[19:00:13] <wikibugs>	 3UI-Standardization, OOjs-UI: buttons on login page are inconsistant - https://phabricator.wikimedia.org/T89860#1047332 (10Jaredzimmerman-WMF) 3NEW
[19:02:40] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1047349 (10Esanders) Just be careful when writing a fix here because the correct initial select in the model is in fact NullSelection. We then attempt to fi...
[19:47:30] <Eloquence>	 James_F, so are you OK with me moving VE "polish" type issues into the Features backlog on the workboard?
[19:48:17] <Eloquence>	 also just happy to add an appropriate tag, just want to make sure we evaluate them as we get closer to release
[19:48:46] <MatmaRex>	 i keep reading "polish" and keep thinking "poland"
[19:49:14] <Eloquence>	 heh
[19:49:22] <Eloquence>	 damn those polish input methods
[19:50:15] <James_F>	 Eloquence: Yeah, sorry, I was going to do it but sure.
[19:50:24] <MatmaRex>	 (i'm not even sure what it's supposed to mean, since people are tagging just about everything as "polish". might as well just skip it…)
[19:51:14] <Eloquence>	 James_F, no worries, I just want to set aside some time to document some smaller stuff that may not be logged yet.
[19:51:22] <James_F>	 Eloquence: Kk.
[19:51:33] <James_F>	 Eloquence: I can always reject your suggestions out of hand. ;-)
[19:51:41] <Eloquence>	 indeed
[19:52:56] <MatmaRex>	 edsanders|away: standalone demo 'slugs.html' page doesn't actually focus the surface on load (with or without my patch).
[19:53:36] <MatmaRex>	 says i have a "Linear: 5 - 5" selection, which is obviously not true, as i cannot type
[19:53:53] <MatmaRex>	 (index 5 is inside the first table in that demo)
[19:57:53] <MatmaRex>	 and, uh, generally focussing the surface is quite broken
[19:58:19] <MatmaRex>	 so you might want to look into that
[20:02:13] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoader: Invalid argument supplied for foreach - https://phabricator.wikimedia.org/T46907#1047654 (10Chad)
[20:04:31] <wikibugs>	 3MediaWiki-ResourceLoader: Warning:  Invalid argument supplied for foreach() in lessc.inc.php on line 507 - https://phabricator.wikimedia.org/T63706#1047679 (10Chad)
[20:09:23] <grrrit-wm>	 (03PS2) 10TheDJ: Remove CSS definition for tables in dialogs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190812 (owner: 10Gerrit Patch Uploader)
[20:11:15] <wikibugs>	 3OOjs-UI, VisualEditor: [Regression wmf-17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1047769 (10Jdforrester-WMF) a:3matmarex
[20:11:26] <wikibugs>	 3OOjs-UI, VisualEditor: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1047770 (10Jdforrester-WMF)
[20:11:42] <wikibugs>	 3VisualEditor: [Regression wmf16] Including a template/comment/table/gallery/math node in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1047777 (10Jdforrester-WMF) p:5High>3Unbreak!
[20:11:59] <wikibugs>	 3VisualEditor, VisualEditor-DataModel: [Regression?] VE corruption issue(?) moving pre-existing categories to the middle of the page - https://phabricator.wikimedia.org/T74048#1047792 (10Jdforrester-WMF)
[20:15:23] <wikibugs>	 3VisualEditor-EditingTools, VisualEditor, VisualEditor-ContentEditable: [Regression pre-wmf16] Entire line of text gets highlighted, when applying link or language to a text in Heading or Page Title format - https://phabricator.wikimedia.org/T87297#1047824 (10Jdforrester-WMF) p:5Normal>3Low
[20:17:05] <grrrit-wm>	 (03PS1) 10Catrope: Add a bunch of trace.foo.{enter|exit} events logged through ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191389 
[20:17:11] <MatmaRex>	 edsanders|away: also. i am fairly sure it is impossible for the NullSelection case to be triggered, at least currently.
[20:17:33] <MatmaRex>	 i would have tested with it if i found a way to make it happen
[20:17:39] <James_F>	 RoanKattouw: Is that meant to be tagged against https://phabricator.wikimedia.org/T89536 ?
[20:17:47] <RoanKattouw>	 Yes, sorry
[20:17:56] <RoanKattouw>	 Fixing
[20:18:15] <grrrit-wm>	 (03PS2) 10Catrope: Add a bunch of trace.foo.{enter|exit} events logged through ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191389 (https://phabricator.wikimedia.org/T89536) 
[20:18:19] <James_F>	 RoanKattouw: No worries. :-)
[20:19:49] <MatmaRex>	 James_F: you know, me fixing mac-safari-only bugs is probably the most inefficient way to fix them
[20:19:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add a bunch of trace.foo.{enter|exit} events logged through ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191389 (https://phabricator.wikimedia.org/T89536) (owner: 10Catrope)
[20:20:10] <James_F>	 MatmaRex: Other people fixing critical OOjs UI bugs is also unlikely to be efficient, however.
[20:20:57] <Eloquence>	 James_F, do we have a bug for migrating mediawiki.feedback to OOjs UI? if not I'll fine one real quick
[20:21:19] <James_F>	 Eloquence: There's a bug somewhere, but not for OOjs UI.
[20:21:27] * James_F eyes mooeypoo speculatively.
[20:22:21] <James_F>	 Eloquence: Possibly re-use https://phabricator.wikimedia.org/T35365 ?
[20:22:28] <MatmaRex>	 James_F: that safari bug might be fixed by https://gerrit.wikimedia.org/r/#/c/189361/
[20:22:36] <MatmaRex>	 (included in v0.7, en.wp runs 0.6.6+)
[20:23:01] <James_F>	 MatmaRex: The Safari bug is new in wmf17. (I.e., broken in 0.7.0, was working in 0.6.6)
[20:23:13] <James_F>	 MatmaRex: That patch indeed may be what broke it.
[20:23:19] <grrrit-wm>	 (03PS3) 10Catrope: Add a bunch of trace.foo.{enter|exit} events logged through ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191389 (https://phabricator.wikimedia.org/T89536) 
[20:23:29] <MatmaRex>	 oh. well, try reverting it then?
[20:23:39] <grrrit-wm>	 (03PS1) 10Kmenger: ButtonGroupWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191391 
[20:23:58] <MatmaRex>	 it's the only thing that could reasonably change how checkboxes get clicked
[20:24:05] <MatmaRex>	 have changed*
[20:24:15] <wikibugs>	 3VisualEditor: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1047843 (10Eloquence) 3NEW
[20:24:23] <James_F>	 MatmaRex: Plausible.
[20:25:18] <Eloquence>	 James_F, placed it in random order in the column, is the order meaningful?
[20:25:45] <wikibugs>	 3UI-Standardization, VisualEditor, MediaWiki-General-or-Unknown: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1047856 (10Jdforrester-WMF) p:5Triage>3Normal
[20:25:50] <grrrit-wm>	 (03CR) 10Cscott: "Split this from Ifaf4e0c0e0a7860709fc47628954fd37cfabf2be, as requested by MatmaRex." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191243 (owner: 10Cscott)
[20:26:04] <James_F>	 Eloquence: Not hugely.
[20:26:06] <Eloquence>	 kk
[20:26:18] <grrrit-wm>	 (03CR) 10Cscott: "Split from Ifaf4e0c0e0a7860709fc47628954fd37cfabf2be, as requested by MatmaRex." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191244 (owner: 10Cscott)
[20:27:11] <grrrit-wm>	 (03PS4) 10Catrope: Add a bunch of trace.foo.{enter|exit} events logged through ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191389 (https://phabricator.wikimedia.org/T89536) 
[20:27:39] <grrrit-wm>	 (03CR) 10Cscott: "These are addressed in Patch Set 13. I haven't done the serialize->getConfig() change or some of the other renames mentioned in MatmaRex'" (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott)
[20:28:10] <wikibugs>	 3OOjs-UI, VisualEditor: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1047867 (10matmarex) Does clicking the label (test next to the checkbox) work?
[20:28:14] <grrrit-wm>	 (03PS1) 10Catrope: In setupSurface, build the model tree separately [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191394 
[20:28:31] <RoanKattouw>	 ori: https://gerrit.wikimedia.org/r/191389 https://gerrit.wikimedia.org/r/191394
[20:31:03] <wikibugs>	 3MediaWiki-Interface, VisualEditor: [mediawiki.feedback.js] Resizing the dialog causes submit and cancel buttons to disappear/become detached - https://phabricator.wikimedia.org/T54588#1047901 (10Jdforrester-WMF)
[20:31:30] <wikibugs>	 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1047904 (10cscott) I think for TextInputMenuSelectWidget you should change the parameter name from `input` to...
[20:31:36] <James_F>	 Eloquence: https://phabricator.wikimedia.org/T89880 might be a good candidate to stalk.
[20:34:18] <grrrit-wm>	 (03PS1) 10Kmenger: DropdownWidget: Add @private to private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/191397 
[20:36:46] <grrrit-wm>	 (03CR) 10Cscott: "@Ed: for consistency in serialization/construction. It allows you to write meta-constructors, de/serializers, GUI design tools, etc, with" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński)
[20:38:36] <wikibugs>	 3OOjs-UI, VisualEditor: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1047933 (10matmarex) 5Open>3stalled Can't reproduce on beta labs using (via crossbrowsertesting.com):  * Safari 8 on Mac OS X 10.10 * Safari 7 on Mac OS X 10.9 * Safari 6 on Mac OS X 1...
[20:39:17] <MatmaRex>	 James_F: are you sure that's broken? wfm
[20:39:33] <James_F>	 MatmaRex: Broken here (testing enwiki).
[20:40:00] <MatmaRex>	 wait, enwiki?
[20:40:04] <MatmaRex>	 enwiki is supposed not to be broken
[20:40:10] <MatmaRex>	 according to what you told me twenty minutes ago
[20:40:12] <James_F>	 wmf17.
[20:40:21] <James_F>	 Oooooooh.
[20:40:21] <MatmaRex>	 can you test on labs?
[20:40:31] <James_F>	 Yup.
[20:40:42] <James_F>	 Also broken.
[20:40:54] <James_F>	 The tick never appears no matter what I do.
[20:41:21] <MatmaRex>	 James_F: is it just the check icon not being visible, or the state not changing? try enabling redirect in page settings
[20:41:38] <RoanKattouw>	 [2015-02-17 15:46:58] <edsanders> RoanKattouw, does dom elements commit have serious implications for DM serialization?
[20:41:45] <James_F>	 Aha. The state changes, but the icon's invisible, yeah.
[20:41:53] <James_F>	 Sorry, would have looked earlier.
[20:41:58] <RoanKattouw>	 edsanders|away: It shouldn't really. It's basically trying to be an in-place replacement of the attribute restoring code
[20:42:40] <grrrit-wm>	 (03CR) 10Cscott: "It would also be possible to do this without deprecating the old positional calling convention -- that is, just establish a new general ru" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński)
[20:42:54] <MatmaRex>	 huh
[20:42:57] <RoanKattouw>	 edsanders|away: Also the tests still cover that, and while I did touch the tests a lot, most of the changes are 1) removing htmlAttributes from expected linmod data, and 2) setting fromDataBody in places where the serialization from pure data differs from the serialization from data that has originalDomElements available
[20:43:04] <MatmaRex>	 so what, does it not understand svgs?
[20:43:18] <James_F>	 MatmaRex: All the other SVGs work fine, and this used to work fine too.
[20:43:56] <James_F>	 Did we change how the icon gets painted in?
[20:45:57] <MatmaRex>	 nope
[20:46:16] <MatmaRex>	 the only change to MW checkboxes between 0.6.6 and 0.7 is the one i already linked
[20:46:31] <James_F>	 Was there a change in 0.6.5 -> 0.6.6?
[20:46:44] <MatmaRex>	 James_F: can you inspect the checkbox, remove the "z-index: 1;" rule, and see if that fixes it?
[20:47:15] <MatmaRex>	 nah, no changes afaics
[20:47:43] <James_F>	 MatmaRex: No fix.
[20:47:52] <MatmaRex>	 (make sure you're inspecting the <input> and not the <span>)
[20:48:48] <MatmaRex>	 James_F: does the browser see the background-image on <span> ::before?
[20:48:52] <James_F>	 I was.
[20:49:21] <MatmaRex>	 (this is safari 8, right?)
[20:49:44] <James_F>	 MatmaRex: I'm testing with Safari 8, yes.
[20:50:00] <James_F>	 No background-image on the input.
[20:50:28] <James_F>	 On the span, ::before has background-size: 100% 100% but no background-image.
[20:50:38] <James_F>	 Oh, wait, yes.
[20:50:45] <James_F>	 .oo-ui-checkboxInputWidget input[type="checkbox"] + span::before
[20:51:12] <James_F>	 background-image: url(data:image/svg+xml,%3C%3Fxml…
[20:51:22] <James_F>	 Disabling and enabling makes it work.
[20:51:49] <James_F>	 But only until I toggle the input's state.
[20:51:52] <James_F>	 Any ideas?
[20:53:21] <MatmaRex>	 heh
[20:53:33] <James_F>	 Cry? :-)
[20:53:34] <MatmaRex>	 get a better browser…
[20:54:18] <wikibugs>	 3VisualEditor, VisualEditor-MediaWiki-Media: Media Settings "Uploaded by..."   not consistently accurate - https://phabricator.wikimedia.org/T88835#1047988 (10Etonkovidova) The fix is verified in betalabs.
[20:54:52] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoaderImage missing file - https://phabricator.wikimedia.org/T89505#1047992 (10Jdforrester-WMF) Resolved?
[20:55:09] <MatmaRex>	 well, good thing we know why it's broken
[20:55:25] <James_F>	 Do we need to apply it "later"
[20:55:26] <James_F>	 ?
[20:55:58] <MatmaRex>	 there isn't even any fancy JS running there that would change how we apply it
[20:56:10] <MatmaRex>	 James_F: can you check in the PHP widgets demo has the same issue?
[20:56:23] <MatmaRex>	 https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/widgets.php
[20:56:53] <MatmaRex>	 oh, bah, that's broken. this works: https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/widgets.php?graphic=mixed
[20:56:56] <James_F>	 MatmaRex: https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/widgets.php?theme=mediawiki&graphic=mixed&direction=ltr
[20:57:16] <James_F>	 MatmaRex: No, that checkbox works as expected.
[20:57:45] <grrrit-wm>	 (03CR) 10TheDJ: [C: 031] "Seems fine to me. Controls have some issues, but they are not related to the changes this patch is trying to introduce." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88906) (owner: 10Bartosz Dziewoński)
[20:58:00] <James_F>	 MatmaRex: Oh. And .js too.
[20:58:02] * James_F sighs.
[20:58:09] <James_F>	 This is VE's fault?
[20:58:10] <James_F>	 How?!
[20:58:15] <grrrit-wm>	 (03CR) 10Cscott: [WIP] Don't use positional arguments to constructors that take 'config' objects (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński)
[21:02:08] <MatmaRex>	 eh
[21:05:05] <MatmaRex>	 hmm, i did manage to reproduce it now, at least.
[21:05:27] <MatmaRex>	 but it took a few clicks until it stopped working
[21:06:08] <James_F>	 Hmm.
[21:06:43] <James_F>	 MatmaRex: Yeah, now on refresh it stops working as soon as I un-select an initially-active checkbox.
[21:07:08] <James_F>	 MatmaRex: But only in the JS version; the PHP one works fine.
[21:07:55] <grrrit-wm>	 (03PS3) 10Ori.livneh: Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 
[21:08:41] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 04-1] "(Still need to update the docs.)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[21:09:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[21:09:12] <MatmaRex>	 James_F: funny thing, it seems to work correctly if i kill the border-radius on the checkbox <span>.
[21:09:26] <MatmaRex>	 oh wait, no more.
[21:09:31] <MatmaRex>	 only for a while. :)
[21:09:47] <grrrit-wm>	 (03PS8) 10Jforrester: Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88906) (owner: 10Bartosz Dziewoński)
[21:10:16] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88906) (owner: 10Bartosz Dziewoński)
[21:11:27] <grrrit-wm>	 (03PS5) 10Ori.livneh: Add a bunch of trace.foo.{enter|exit} events logged through ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191389 (https://phabricator.wikimedia.org/T89536) (owner: 10Catrope)
[21:11:33] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Add a bunch of trace.foo.{enter|exit} events logged through ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191389 (https://phabricator.wikimedia.org/T89536) (owner: 10Catrope)
[21:11:51] <James_F>	 ori: Is this the bit where you ask for that to be cherry-picked to production?
[21:12:38] <grrrit-wm>	 (03PS2) 10Ori.livneh: In setupSurface, build the model tree separately [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191394 (owner: 10Catrope)
[21:12:51] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] In setupSurface, build the model tree separately [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191394 (owner: 10Catrope)
[21:13:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a bunch of trace.foo.{enter|exit} events logged through ve.track() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191389 (https://phabricator.wikimedia.org/T89536) (owner: 10Catrope)
[21:13:30] <ori>	 James_F: naw
[21:13:33] <James_F>	 OK.
[21:13:55] <James_F>	 (Does it need a schema change or are we using the NavTiming stuff or whatever?)
[21:15:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: In setupSurface, build the model tree separately [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191394 (owner: 10Catrope)
[21:15:44] <ori>	 no, we aren't logging these at all; these are signals that are used by vbench to segment the initialization process into stages that can be measured separately
[21:16:01] <ori>	 they're too low-level for client-side instrumentation, IMO
[21:16:08] <ori>	 James_F: ^
[21:16:38] <James_F>	 Ah, OK.
[21:17:22] <spagewmf>	 MatmaRex, TrevorP|Away, werdna : Roan invited me to Front end standards group meeting "Monthly on the third Wednesday", but nobody here. ?
[21:17:51] <ori>	 spagewmf: RoanKattouw just sent an email indicating that it is cancelled for this week
[21:17:55] <ori>	 and apologizing for the short notice
[21:18:30] <spagewmf>	 thx
[21:19:33] <wikibugs>	 3VisualEditor, VisualEditor-Performance: Instrument (i.e., track) additional progress markers for VE load - https://phabricator.wikimedia.org/T89536#1048079 (10Jdforrester-WMF) 5Open>3Resolved
[21:21:28] <wikibugs>	 3OOjs-UI, VisualEditor: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1048083 (10matmarex) Looked into it with James: the checkbox state does get changed, but Safari doesn't render the green checkbox (even though the inspector says that it's there). I did ma...
[21:22:02] <MatmaRex>	 James_F: so, we can write special JS just for safari to twiddle the property back-and-forth whenever checkbox state changes, but that would be, you know, stupid
[21:22:16] <MatmaRex>	 backgrounds are not supposed to disappear
[21:22:36] * James_F shrugs.
[21:22:46] <James_F>	 Working > clean.
[21:24:03] <MatmaRex>	 no guarantee that it's going to work, either
[21:24:08] <James_F>	 True.
[21:25:20] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] Remove CSS definition for tables in dialogs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190812 (owner: 10Gerrit Patch Uploader)
[21:25:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove CSS definition for tables in dialogs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190812 (owner: 10Gerrit Patch Uploader)
[21:25:37] <MatmaRex>	 James_F: can you spend a minute furiously clicking checkboxes in the PHP demo, just to verify that this doesn't affect them?
[21:25:52] <MatmaRex>	 the latency of the browser testing things is massive here
[21:27:39] <grrrit-wm>	 (03PS2) 10TheDJ: Remove color overwrite for dialog header border bottom [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190682 (owner: 10Gerrit Patch Uploader)
[21:27:59] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] Remove color overwrite for dialog header border bottom [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190682 (owner: 10Gerrit Patch Uploader)
[21:29:07] <wikibugs>	 3VisualEditor: FOUC of "beta" suffix - https://phabricator.wikimedia.org/T89892#1048091 (10Eloquence) 3NEW
[21:29:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove color overwrite for dialog header border bottom [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190682 (owner: 10Gerrit Patch Uploader)
[21:32:49] <wikibugs>	 3VisualEditor: FOUC of "beta" suffix - https://phabricator.wikimedia.org/T89892#1048116 (10matmarex)
[21:32:50] <wikibugs>	 3VisualEditor-Initialisation, VisualEditor-Performance, VisualEditor: VisualEditor "beta" appended label causes edit tab to flicker - https://phabricator.wikimedia.org/T89668#1048117 (10matmarex)
[21:35:27] <MatmaRex>	 James_F: is there any way to file this as a Safari bug?
[21:35:27] <grrrit-wm>	 (03PS3) 10Gerrit Patch Uploader: Rework color definition in CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 
[21:35:30] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 (owner: 10Gerrit Patch Uploader)
[21:35:58] <James_F>	 MatmaRex: Yes, probably. If you can isolate the test case more it'd help.
[21:36:04] <MatmaRex>	 James_F: the fun thing here is, this affects the ::before pseudoelement. so we can't even do .css('background-image', 'whatever') on it.
[21:36:25] <James_F>	 MatmaRex: TheDJ is good for this stuff, if no-one else. Krinkle has also reported these kinds of issues before.
[21:36:27] <MatmaRex>	 James_F: it happens on OOUI demo, that's reasonably isolated
[21:37:38] <James_F>	 Kk.
[21:39:42] <Krinkle>	 James_F: Redirect dialog checkbox?
[21:40:13] <James_F>	 Krinkle: All checkboxen don't paint in their background-image tick.
[21:40:33] <Krinkle>	 Ah, right. There were two bugs.
[21:40:40] <Krinkle>	 That was last weeks regression
[21:40:51] <James_F>	 Two weeks ago, I think.
[21:45:36] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Workaround for Safari being useless at being a browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/191476 (https://phabricator.wikimedia.org/T89309) 
[21:45:43] <MatmaRex>	 James_F: enjoy, and please test. ^
[21:45:47] <James_F>	 Oy.
[21:45:55] <Krinkle>	 James_F: Was it not fixed for most browsers?
[21:45:59] <Krinkle>	 James_F: Only in Safari now?
[21:46:08] <James_F>	 Krinkle: Yes.
[21:46:16] <James_F>	 Krinkle: Scrollback exists. :-P
[21:46:24] <Krinkle>	 2 weeks ago the checkbox was gone in all browsers. Not because of a rendering bug I think but because of a state bug, it wasn't setting the initial one, but when clicked it worked fine
[21:46:29] <wikibugs>	 3OOjs-UI, VisualEditor: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1048174 (10matmarex) 5stalled>3Open
[21:46:53] <grrrit-wm>	 (03PS1) 10Kmenger: DropdownWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191477 
[21:47:08] <Krinkle>	 MatmaRex: Hm.. is it not something like silly like using : insteadof :: for before/after?
[21:47:23] <MatmaRex>	 Krinkle: what's wrong with using : for before/after?
[21:47:35] <Krinkle>	 MatmaRex: support for :: (standards) came later.
[21:47:42] <MatmaRex>	 yes, i know
[21:47:42] <Krinkle>	 but : works everywhere
[21:47:48] <Krinkle>	 Safari should be fine b now though
[21:47:50] <MatmaRex>	 that's why i'm asking what's wrong with :
[21:47:53] <MatmaRex>	 but that's safari 8 anyway
[21:47:58] <MatmaRex>	 latest hottest
[21:48:08] <Krinkle>	 well, 2 year old webkit, but yeah
[21:48:14] <Krinkle>	 Apple takes a while to go from a to b.
[21:48:23] <MatmaRex>	 it's a rendering bug that affects VE almost every time, OOUI JS demo when you click twenty times, and *not* OOUI PHP demo
[21:48:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Yeah, this works. Argh." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191476 (https://phabricator.wikimedia.org/T89309) (owner: 10Bartosz Dziewoński)
[21:48:37] <MatmaRex>	 have fun clicking furiously
[21:50:27] <Krinkle>	 svg2png uses phantomjs
[21:50:41] <James_F>	 MatmaRex: I did.
[21:50:49] <James_F>	 Krinkle: Yes.
[21:51:18] <Krinkle>	 it has a weird way of detecting a global install, not like grunt usually does. So it broke when I upgraded my global install last week. 
[21:51:25] <Krinkle>	 downgrading fixed it.
[21:51:28] <Krinkle>	 it just hangs forever
[21:51:38] <James_F>	 Oh. Fun.
[21:51:51] <James_F>	 If we can switch over to headless Chrome or whatever, let's do that.
[21:51:55] <James_F>	 But unless it's urgent…
[21:54:12] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1048198 (10matmarex) The worst case is that toolbar icons will not be disabled when they should, until the user clicks the surface himself. But that's not g...
[21:54:44] <James_F>	 RoanKattouw: Can you reply on https://phabricator.wikimedia.org/T89423 please?
[21:59:48] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think I'll scale this back a bit, and implement the config-only approach as simply an alternative (and not the recommended, documented w" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński)
[22:00:47] <wikibugs>	 3MediaWiki-ResourceLoader: ResourceLoaderImage missing file - https://phabricator.wikimedia.org/T89505#1048215 (10Krenair) 5Open>3Resolved a:3Krenair Hopefully.
[22:12:05] <wikibugs>	 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1048235 (10TrevorParscal) Using .static.class is the only way to go without a major version change in OOjs, because it's a major breaking change to get rid of .static or start...
[22:12:08] <Krinkle>	 MatmaRex: So in Safari, oojs-ui demos, mediawiki theme, latest master; checkbox renders initially
[22:12:20] <Krinkle>	 MatmaRex: click to uncheck works,too. but hten can't be re-enabled
[22:12:28] <TrevorParscal>	 MatmaRex: https://phabricator.wikimedia.org/T89721
[22:12:37] <wikibugs>	 3WikiEditor: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1048236 (10TheDJ) Adding Roan, as walking encyclopedia of 'weird IE bugs encountered when implementing wiki editors' and original author of the workaround.
[22:13:23] <TrevorParscal>	 MatmaRex: let's pull the trigger on option #1 (add .static.class, use ['class'] for now inside OOjs and OOjs UI for IE backward compatibility)
[22:13:57] <TrevorParscal>	 if we change from .static to copying constructor stuff directly, it's a breaking change in OOjs, let's save that sort of thing for a 2.0 release
[22:14:26] <MatmaRex>	 Krinkle: yes.
[22:15:10] <MatmaRex>	 TrevorParscal: meh, wouldn't be that breaking. as in, i'm fairly sure nothing would break. we could just set fn.static = fn, probably
[22:15:17] <Krinkle>	 Failed to load resource: mediawiki.svg.css in widgets.php
[22:15:22] <MatmaRex>	 but okay
[22:15:30] <Krinkle>	 was renamed it seems
[22:15:31] <MatmaRex>	 Krinkle: unrelated, already fixed
[22:15:38] <Krinkle>	 yeah I know
[22:15:42] <Krinkle>	 but keeps it from working to test it
[22:15:47] <Krinkle>	 oh, OK.
[22:15:55] <MatmaRex>	 Krinkle: switch to "mixed" in the header button things
[22:17:12] <TrevorParscal>	 MatmaRex: no, I think it's a pretty big change because we would be copying things from the constructor to achieve the static inheritance
[22:19:17] <Krinkle>	 MatmaRex: Removing emit('change') fixes it also
[22:19:23] <Krinkle>	 from OO.ui.CheckboxInputWidget.prototype.setSelected
[22:20:30] <Krinkle>	 yeah on php output it works always and in js it's broken after first click. But when removing that emit() and running grunt-build, it's fine. So maybe one of our callbacks is doing something shady
[22:20:43] <MatmaRex>	 Krinkle: i'm fairly sure VE depends on that change being emitted.
[22:20:55] <Krinkle>	 MatmaRex: obviously we're not removing it as a fix
[22:21:09] <Krinkle>	 it's a start of tracking down an alternative route to fixing the bug
[22:21:35] <MatmaRex>	 but that is quite amusing. we don't connect to that particular event in OOUI.
[22:21:53] <Krinkle>	 I'd rather not detach/re-attach as fix. It's not in a hot part of the code, but it's not exactly shining of performance either.
[22:21:54] <MatmaRex>	 Krinkle: are you sure it fixes it? permanently?
[22:22:17] <MatmaRex>	 removing border-radius also fixed it for me, until i clicked more and it stopped being fixed
[22:22:28] <Krinkle>	 MatmaRex: remove from build or live?
[22:22:28] <MatmaRex>	 it's not reliably broken
[22:22:44] <Krinkle>	 Hm.. I've put emit() back,it's still working
[22:23:15] <MatmaRex>	 i needed to click a few times in the demo to trigger it, not just on and off
[22:23:23] <Krinkle>	 MatmaRex: Ah ,vector only. the mixed mode is the one that's working
[22:23:24] <Krinkle>	 always
[22:23:25] <Krinkle>	 for me
[22:23:26] <RoanKattouw>	 mooeypoo: https://phabricator.wikimedia.org/T49395#490610
[22:23:48] <Krinkle>	 I switched to mixed in js as well by accident which it why it seemed fixed
[22:23:49] <Krinkle>	 interesting.
[22:24:08] <Krinkle>	 yeah, raster also works, and mixed, but svg shows the bug
[22:24:11] <MatmaRex>	 hmm. it uses the PNG fallback? that would be weird
[22:24:29] <Krinkle>	 I don't know if it uses it, but it helps it feel comfortable
[22:24:39] <MatmaRex>	 or does the presence of PNG make the SVG work?
[22:25:53] <Krinkle>	 Exactly
[22:26:37] <edsanders>	 MatmaRex, fair enough
[22:27:59] <Krinkle>	 MatmaRex: Ha, it seems there's a known Safari bug with using the + selector and :checked
[22:28:49] <MatmaRex>	 …man, what year is it
[22:29:10] <Krinkle>	 shouldn't matter though in this case
[22:34:26] <Krinkle>	 MatmaRex: So it's using the svg in mixed mode from what I can tell.
[22:35:02] <Krinkle>	 but it's definitely working in mode
[22:35:04] <Krinkle>	 mixed mode
[22:35:19] <Krinkle>	 perhaps one of the extra background rules makes it happy
[22:42:59] <wikibugs>	 3WikiEditor: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1048345 (10TheDJ) Wondering if this code is superflous, with the actual problems now fixed in the textSelection plugin instead. (where we don't check for msie, but instead just for the document.selectio...
[22:43:20] <grrrit-wm>	 (03CR) 10TheDJ: Skip an old IE 8 bug workaround in WikiEditor on IE 11/Spartan (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189162 (https://phabricator.wikimedia.org/T88875) (owner: 10Brion VIBBER)
[22:48:05] <Krinkle>	 MatmaRex: changing opacity to 0.2 instead of 0 for the native checkbox shows that it is toggling the native one properly. confirmed with logging $0.checked. The value is changing properly. But when in vector/svg, the span itself is drawn next to the checkbox instead of over top.
[22:49:03] <Krinkle>	 Hm.. when the checkbox is render properly it is also next to it. 
[22:49:09] <Krinkle>	 Wait, we're not using that extra span to render the tick
[22:49:29] <Krinkle>	 it's the ::before of the span
[22:49:32] <Krinkle>	 interesting
[22:51:19] <grrrit-wm>	 (03CR) 10Brion VIBBER: Skip an old IE 8 bug workaround in WikiEditor on IE 11/Spartan (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189162 (https://phabricator.wikimedia.org/T88875) (owner: 10Brion VIBBER)
[22:54:30] <wikibugs>	 3WikiLove, OOjs-UI, Possible-Tech-Projects: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#1048351 (10Mattflaschen) I'm willing to review this.
[22:58:59] <Krenair>	 nuria, hey
[23:02:47] <grrrit-wm>	 (03PS4) 10Ori.livneh: Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 
[23:03:32] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "I tried hard to break this and I couldn't." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191378 (https://phabricator.wikimedia.org/T89423) (owner: 10Bartosz Dziewoński)
[23:04:58] <Krinkle>	 MatmaRex: Hm.. we are inconsitently using :before and ::before it seems. But not the cause.
[23:05:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[23:05:14] <Krinkle>	 I've narrowed it down to that area though I think. Wow, this is some weird stuff
[23:05:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ui.Toolbar: Don't call #updateToolState from #initialize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191378 (https://phabricator.wikimedia.org/T89423) (owner: 10Bartosz Dziewoński)
[23:09:06] <MatmaRex>	 Krinkle: yes, it's some heavy magic. it was pretty closely migrated from mediawiki.ui, which didn't have the ability to add extra elements everywhere
[23:09:23] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Replace ve.dm.Model#matchesAttributeSpec (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[23:09:51] <grrrit-wm>	 (03CR) 10Catrope: Replace ve.dm.Model#matchesAttributeSpec (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[23:10:10] <grrrit-wm>	 (03PS1) 10Mooeypoo: Warn if a TemplateData block already exists in related page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191491 (https://phabricator.wikimedia.org/T74062) 
[23:10:13] <grrrit-wm>	 (03PS3) 10Catrope: Only replace selection when we know it has changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189472 (https://phabricator.wikimedia.org/T87419) (owner: 10Esanders)
[23:10:15] <grrrit-wm>	 (03PS2) 10Ori.livneh: Update for Ia0e0fe4fc: Replace ve.dm.Model#matchesAttributeSpec [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 
[23:10:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update for Ia0e0fe4fc: Replace ve.dm.Model#matchesAttributeSpec [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh)
[23:10:58] <wikibugs>	 3VisualEditor: Remove use of ve.indexOf - https://phabricator.wikimedia.org/T89905#1048393 (10Krinkle) 3NEW
[23:11:40] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1048400 (10Jdforrester-WMF) 5stalled>3Resolved
[23:11:47] <wikibugs>	 3VisualEditor: Remove use of ve.indexOf - https://phabricator.wikimedia.org/T89905#1048403 (10Krinkle)
[23:12:24] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1048406 (10matmarex) 5Resolved>3Open @ori, I couldn't quite reproduce the flame graphs, so can you recheck with the above patch merged? It shouldn't aff...
[23:12:52] <MatmaRex>	 bah
[23:12:55] <MatmaRex>	 nice conflict
[23:13:04] <grrrit-wm>	 (03PS1) 10Kmenger: ActionSet: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191493 
[23:13:09] <grrrit-wm>	 (03CR) 10Krinkle: "I like where this is going." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[23:13:18] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Minor comment. Otherwise LGTM." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191491 (https://phabricator.wikimedia.org/T74062) (owner: 10Mooeypoo)
[23:13:25] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1048410 (10matmarex) 5Open>3Resolved
[23:13:31] <ori>	 I am the world's worst git rebaser
[23:14:04] <grrrit-wm>	 (03PS5) 10Ori.livneh: Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 
[23:14:05] <wikibugs>	 3OOjs-UI, VisualEditor, VisualEditor-Performance: Massive recalculate style triggered by OO.ui.Widget.setDisabled - https://phabricator.wikimedia.org/T89423#1035798 (10matmarex) (Whoops, that was another case of {T78236}.)
[23:14:51] <grrrit-wm>	 (03PS3) 10Ori.livneh: Update for Ia0e0fe4fc: Replace ve.dm.Model#matchesAttributeSpec [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 
[23:15:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update for Ia0e0fe4fc: Replace ve.dm.Model#matchesAttributeSpec [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh)
[23:15:18] <Krinkle>	 MatmaRex: Hm.. I figured pointer-events woudl be an issue. But surprisingly it's not.
[23:15:49] <Krinkle>	 MatmaRex: It's covering the checkbox and yet it's still receiving click events natively directly onto the checkbox from the span that's next to it.
[23:15:59] <Krinkle>	 We're not listening on the span
[23:16:07] <Krinkle>	 How come this works at all?
[23:16:40] <MatmaRex>	 Krinkle: in two ways
[23:16:51] <James_F>	 1) Poorly
[23:16:52] <MatmaRex>	 one, the entire thing is usually wrapped in a <label/> from FieldWidget
[23:16:54] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 (owner: 10Catrope)
[23:16:55] <James_F>	 2) Nobody knows
[23:16:55] <James_F>	 ?
[23:17:01] <James_F>	 edsanders: Eek. Yay.
[23:17:09] <Krinkle>	 MatmaRex: Right. the <label> trick. Good.
[23:17:37] <MatmaRex>	 two, the <input/> is positioned above the <span/> with z-index. this was broken until last week, when i added the z-index, previously standalone checkboxes indeed didn't work
[23:17:46] <MatmaRex>	 (and no one noticed because of the label)
[23:17:50] <Krinkle>	 Ah, right.
[23:17:54] <Krinkle>	 OK :)
[23:18:21] <MatmaRex>	 (for a while i blamed this z-index change for the breakage, but removing it didn't seem to help)
[23:18:38] <wikibugs>	 3VisualEditor, VisualEditor-Performance, VisualEditor-Initialisation: VisualEditor "beta" appended label causes edit tab to flicker - https://phabricator.wikimedia.org/T89668#1048428 (10Eloquence) @matmarex, this is not quite the same phenomenon I observed in T89892. On my setup (Chrome/Ubuntu), the "beta" suffi...
[23:19:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Store originalDomElements instead of htmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189769 (owner: 10Catrope)
[23:20:06] <grrrit-wm>	 (03PS1) 10Mooeypoo: Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 
[23:20:27] <mooeypoo>	 anyone for review? This fixes a rather huge bug in TemplateData dialog ^^
[23:21:18] <mooeypoo>	 wait, crap, i found anoter bug with it
[23:21:23] <grrrit-wm>	 (03PS2) 10Mooeypoo: [wip] Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 
[23:21:33] <grrrit-wm>	 (03PS6) 10Jforrester: Update VE core submodule to master (7d2a68e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope)
[23:22:33] <grrrit-wm>	 (03PS4) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) 
[23:22:56] <grrrit-wm>	 (03PS1) 10Kmenger: ActionSet: Add @private to onActionChange method [oojs/ui] - 10https://gerrit.wikimedia.org/r/191495 
[23:26:09] <nuria>	 krenair: hello!
[23:26:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (7d2a68e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope)
[23:26:22] <nuria>	 krenair: sorry i stepped out for a little bit
[23:26:35] <nuria>	 Krenair: sorry i stepped out for a little bit
[23:27:12] <Krenair>	 nuria, I was wondering about how I'd actually be able to fill out the value of action.abort.type in the edit schema
[23:27:17] <Krenair>	 the options seem very strange
[23:27:28] <RoanKattouw>	 I don't think nuria had anything to do with designing that stuff
[23:27:32] <RoanKattouw>	 That was all me and James
[23:28:12] <grrrit-wm>	 (03PS6) 10Ori.livneh: Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 
[23:28:42] <nuria>	 Krenair: RoanKattouw is right
[23:28:58] <ori>	 he always is
[23:29:06] <grrrit-wm>	 (03PS3) 10Mooeypoo: Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 
[23:29:07] <Krenair>	 ok...
[23:29:13] <nuria>	 RoanKattouw: one thing i was mentioning to James_F about the schema is that it mixes "user data" with "application exceptions" 
[23:29:55] <nuria>	 RoanKattouw: for example 'responseEmpty' and 'responseUnknown' are application errors (likely what the user sees in that case is the same)
[23:30:41] <nuria>	 RoanKattouw: So for a future revision we can put "application errors" in a different schema, in th absence of  a client side errorlog 
[23:30:51] <nuria>	 that is the best we can do
[23:33:21] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: non-editable element inserted before a colon - https://phabricator.wikimedia.org/T72171#1048495 (10Etonkovidova) Confirmed in betalabs - for en wiki too. - Insert a colon into a paragraph text and - Important!- put white spaces around it  The colon (:) w...
[23:33:45] <wikibugs>	 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: non-editable element inserted before a colon - https://phabricator.wikimedia.org/T72171#1048496 (10Etonkovidova) p:5Triage>3Normal
[23:34:59] <James_F>	 nuria: Isn't tgr building a client-side error log system for JS?
[23:35:30] <nuria>	 James_F: I do not not know that that work has started but yes, we talked about this last year
[23:35:36] * James_F nods.
[23:35:54] <James_F>	 Of course, what you're pointing out is mostly that MediaWiki's API sucks.
[23:35:54] <grrrit-wm>	 (03PS7) 10Catrope: Update VE core submodule to master (7d2a68e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 
[23:36:00] <James_F>	 Which we agree with. ;-)
[23:36:02] <nuria>	 James_F: tgr was planning to use another kafka topic to log errors (will work great for that)
[23:36:07] * James_F nods.
[23:36:32] <James_F>	 nuria: But "user is stuck" is still "user is stuck" whether it's "user is stuck and it's our fault" or not.
[23:37:31] <nuria>	 James_F: yes, but when analyzing user data if the user sees a [pls try again" screen in case1: responseEmpty and case2: responseUnknown 
[23:37:55] <nuria>	 James_F: it makes no sense to segregate those two cases for user analisys
[23:38:09] <James_F>	 Sure.
[23:38:10] <nuria>	 James_F: the funel is the same
[23:38:14] * James_F nods
[23:38:25] <nuria>	 *analysis
[23:42:34] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Update VE core submodule to master (7d2a68e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope)
[23:43:39] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (7d2a68e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope)
[23:45:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (7d2a68e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope)
[23:46:41] <grrrit-wm>	 (03PS1) 10Kmenger: ActionSet: Add description for specialFlags property [oojs/ui] - 10https://gerrit.wikimedia.org/r/191500 
[23:48:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ActionSet: Add description for specialFlags property [oojs/ui] - 10https://gerrit.wikimedia.org/r/191500 (owner: 10Kmenger)
[23:55:58] <ori>	 RoanKattouw: i think <https://gerrit.wikimedia.org/r/#/c/191287/> is ok now
[23:56:36] <Krenair>	 legoktm, https://integration.wikimedia.org/ci/job/mediawiki-extensions-zend/3685/consoleFull
[23:57:10] <Krenair>	 So RoanKattouw, James_F: What are we going to do about action.abort.type?
[23:57:29] <legoktm>	 Krenair: dunno, Gather is a mobile-team extension
[23:58:00] <Krenair>	 legoktm, yeah there's nothing broken about their extension, the deprecation and replacement is in this commit :)
[23:58:05] <Krenair>	 the problem is the change you suggested
[23:58:24] <legoktm>	 Krenair: er, what commit is that for?
[23:58:28] <legoktm>	 oh
[23:58:49] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh)
[23:59:13] <legoktm>	 ugh
[23:59:28] <Krenair>	 https://gerrit.wikimedia.org/r/190607
[23:59:33] <legoktm>	 Krenair: meh, I guess do the deprecation in a follow-up commit which we can merge once VE is changed?
[23:59:49] <Krenair>	 I guess.