[00:00:47] (03Merged) 10jenkins-bot: Replace ve.dm.Model#matchesAttributeSpec [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191287 (owner: 10Ori.livneh) [00:00:58] MatmaRex: Have you been able to reproduce the checkbox saga in a more reduced test case fashion? [00:01:03] I'm making one now [00:02:15] 3VisualEditor: [Regression wmf18] Reference and template dialog boxes display 'Apply changes' button as active upon opening - https://phabricator.wikimedia.org/T89913#1048566 (10Etonkovidova) 3NEW [00:02:30] Krinkle: no, i don't have a mac, and using crossbrowsertesting and such means a half second latency between when i click and when it is registered [00:02:42] so i submitted a patch and left it there [00:02:58] cool [00:07:37] 3VisualEditor, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki-References: The citation dialog should disable the "Apply changes" button until a change is present - https://phabricator.wikimedia.org/T76927#1048579 (10Etonkovidova) [00:14:45] 3VisualEditor, VisualEditor-EditingTools: Permit sorting of categories via drag-and-drop - https://phabricator.wikimedia.org/T52809#1048591 (10Etonkovidova) [00:17:02] (03PS4) 10Ori.livneh: Update for Ia0e0fe4fc: Replace ve.dm.Model#matchesAttributeSpec [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 [00:17:07] (03CR) 10jenkins-bot: [V: 04-1] Update for Ia0e0fe4fc: Replace ve.dm.Model#matchesAttributeSpec [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:17:38] (03PS1) 10Kmenger: ActionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191507 [00:19:28] MatmaRex: I can reproduce it without javascript now on http://s.codepen.io/Krinkle/debug/JoLyzx? - could you verify via crossbrowsertesting? [00:19:44] (03CR) 10Catrope: [C: 032 V: 032] mw.Target: Hopefully fix plugin garbage removal code [extensions/VisualEditor] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/191376 (owner: 10Catrope) [00:19:54] (03CR) 10Trevor Parscal: [C: 04-1] "I think this isn't quite where it needs to be to supplant the current, albeit broken, implementation. Keyboard accessibility is still an i" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) (owner: 10Esanders) [00:20:30] Krinkle: you're asking me to endure the pain of working on a computer with half a second latency for every action. but okay, i'll do it, for you [00:21:48] (03PS2) 10Kmenger: ActionSet: Add description for specialFlags property [oojs/ui] - 10https://gerrit.wikimedia.org/r/191500 [00:22:29] Krinkle: background-image: url(http://krinkle.dev/oojs-ui/dist/themes/mediawiki/images/icons/check-constructive.svg), not gonna work ;) [00:22:34] Yeah,fixed [00:22:43] same url [00:22:53] (codepen url) [00:23:36] can reproduce. only took effect after fifth click on every checkbox [00:23:58] Thx [00:24:04] MatmaRex: With OS/browser version? [00:24:46] safari 8 on mac os x 10.10 [00:24:48] (03PS2) 10Mooeypoo: Warn if a TemplateData block already exists in related page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191491 (https://phabricator.wikimedia.org/T74062) [00:25:05] on http://app.crossbrowsertesting.com/livetests/run with the wikimedia account [00:25:10] Krinkle: https://bugs.webkit.org/show_bug.cgi?id=17680 [00:25:35] MatmaRex: i think that one might be related [00:25:48] Krinkle, can you review this? it is the change of global class names in TemplateData and it's starting to get stuff dependent on it now https://gerrit.wikimedia.org/r/#/c/191217/ [00:26:16] thedj: Yeah, I found that one. I can reproduce it without :before/:after though [00:26:17] http://codepen.io/Krinkle/pen/JoLyzx?editors=110 [00:26:24] (03PS4) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [00:26:31] (03CR) 10jenkins-bot: [V: 04-1] Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [00:26:51] thedj: On a plain :checked+span with e.g. bacjground-color it works [00:27:04] Its triggered in our case on something more specific I've yet to narrow down [00:27:22] I started that pen with a very simple case which worked consistently [00:27:28] now cutting down from the ther end [00:27:31] other(* [00:28:34] (03PS5) 10Jforrester: Update VE core submodule to master (032c9a4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:29:19] RoanKattouw: https://gerrit.wikimedia.org/r/191298 [00:29:54] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (032c9a4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:30:02] lol, i made it work 2 times, kept clicking and then it suddently stopped working... [00:30:06] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (032c9a4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:30:19] (2 times == 2 sequences of on/off) [00:30:28] Also repo on WebKit nightly fiw [00:30:35] fwiw [00:31:13] (03PS5) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [00:31:55] I'll be damned [00:31:58] it's the transition [00:32:24] Transition? [00:32:25] (03PS6) 10Jforrester: Update VE core submodule to master (032c9a4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:32:35] Can someone explain to me why ticking and unticking a checkbox needs a transition? [00:32:39] That seems counterproductive! [00:32:51] It makes the interface appear *less* responsive to the user's action [00:32:58] Can someone tell me why having a transition means Safari can do longer adhere to CSS2.1? [00:33:08] Lol [00:33:12] Amazing response [00:33:26] Hehe :) [00:34:08] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (032c9a4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:34:26] OK. We're killing the transition. Except if there's a feasible way to make it not run on WebKit. [00:34:32] Even latest WebKit nightly has the bug [00:37:21] (03PS1) 10Jforrester: extension.json: Rebuild using maintenance/convertExtensionToRegistration.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191511 [00:37:37] Krinkle: its transition + SVG [00:37:42] Yeah [00:37:42] works with a gif or png [00:37:52] I found that out earlier [00:37:54] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:38:38] (03CR) 10jenkins-bot: [V: 04-1] extension.json: Rebuild using maintenance/convertExtensionToRegistration.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191511 (owner: 10Jforrester) [00:38:49] RoanKattouw: That's one for your list. Having a with a transition and an svg background-image means selector "input[type="checkbox"]:checked + span" no longer consistently applies. [00:39:03] hehe [00:39:05] lol [00:39:15] Note that it's not transitions or backgrounds on the checkbox. It's on a normal span. [00:39:24] Even when keeping the checkbox completely unstyled (native) [00:40:50] Krinkle: how did it work before OOUI 0.7? [00:41:10] MatmaRex: I don't think it did; we may have just not noticed it until then. [00:41:13] MatmaRex: It didn't. This has been for at least 2 weeks. [00:41:36] how do you not notice all checkboxes not working on half the computers in the office? [00:41:43] (all OOUI checkboxes, meh) [00:41:55] it's only on mediawiki style though. [00:42:11] and it usually works the 1st time, and sometimes the 2nd time. [00:42:24] who clicks a checkbox 3 times in succession :) [00:43:20] Krinkle: are you filing a webkit issue, or want me to file it ? [00:43:44] thedj: I'm narrowing down the test first [00:43:48] I'm not convinced [00:44:08] When I removed background-color: white; it also seemed to be fixed [00:44:14] with svg and transition [00:44:32] (03CR) 10Ori.livneh: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:44:43] perhaps there is a 'complexity counter' or something [00:45:44] Yeah, it's definitely related to the background color as well [00:45:46] wtf! [00:46:03] I've removed other rules still and still happening, so it'd be relatively low complexity [00:46:14] unless bgcolor is more complex than z-index, opacity and border-radius [00:46:47] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (032c9a4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:47:50] 3VisualEditor, VisualEditor-Performance: ve.ce.Surface.showSelection forces a style recalc - https://phabricator.wikimedia.org/T87419#1048685 (10Catrope) I can't reproduce this being very impactful any more, but Ed's patch reduces the number of calls to this, so sure, why not. [00:48:06] (03PS4) 10Catrope: Only replace selection when we know it has changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189472 (https://phabricator.wikimedia.org/T87419) (owner: 10Esanders) [00:48:38] (03Merged) 10jenkins-bot: Update VE core submodule to master (032c9a4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191298 (owner: 10Ori.livneh) [00:49:47] cscott: sorry about no infusion-related activities from me today, had to unbreak some things. i'll respond and implement the two things i promised tomorrow [00:50:12] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191511 (owner: 10Jforrester) [00:50:35] (03PS2) 10Jforrester: Remove some errant references to MediaWiki/Parsoid that don't belong [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190967 [00:51:20] (03CR) 10Catrope: [C: 032] Only replace selection when we know it has changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189472 (https://phabricator.wikimedia.org/T87419) (owner: 10Esanders) [00:53:22] (03Merged) 10jenkins-bot: Only replace selection when we know it has changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189472 (https://phabricator.wikimedia.org/T87419) (owner: 10Esanders) [00:53:56] (03CR) 10Catrope: [C: 032] Don't log against undefined target constructor name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191130 (https://phabricator.wikimedia.org/T89735) (owner: 10Alex Monk) [00:55:13] (03PS1) 10Mooeypoo: Display TemplateData parameter table according to param order [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191514 [00:55:40] (03Merged) 10jenkins-bot: Don't log against undefined target constructor name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191130 (https://phabricator.wikimedia.org/T89735) (owner: 10Alex Monk) [00:55:43] 3TemplateData: TemplateData: Have the GUI editor warn the user if a related page already contains a TemplateData block - https://phabricator.wikimedia.org/T74062#1048708 (10Mooeypoo) a:3Mooeypoo [00:56:33] (03CR) 10Trevor Parscal: [C: 032] Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88906) (owner: 10Bartosz Dziewoński) [00:56:39] thedj: OK. Go ahead :) http://codepen.io/Krinkle/pen/JoLyzx?editors=110 / http://s.codepen.io/Krinkle/debug/JoLyzx? [00:56:54] thedj: removing the transition, or background-color, or using png instead of svg avoids the bug [00:57:06] it's those three factors from what I can see [00:57:44] (03CR) 10Trevor Parscal: [C: 032] "We can also solve this later by removing the transition, at which point we can mostly revert this." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191476 (https://phabricator.wikimedia.org/T89309) (owner: 10Bartosz Dziewoński) [00:57:59] (03Merged) 10jenkins-bot: Refactor keyboard accessibility of SelectWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/189988 (https://phabricator.wikimedia.org/T88906) (owner: 10Bartosz Dziewoński) [00:58:33] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Hold on" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191476 (https://phabricator.wikimedia.org/T89309) (owner: 10Bartosz Dziewoński) [00:59:02] TrevorParscal: it seems that just using the "mixed" distribution, which we merged earlier, also "fixes" this [00:59:33] per Krinkle [00:59:37] wow [00:59:49] so it would be nice to avoid this incredibly idiotic hack [00:59:55] (03CR) 10Trevor Parscal: [C: 032] TextInputWidget: Deprecate 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/189499 (owner: 10Bartosz Dziewoński) [01:00:03] TrevorParscal: Transition, useful or not [01:00:16] Taking the Safari bug out of the balance completely [01:00:57] 3OOjs-UI, VisualEditor: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1048715 (10matmarex) Also affects the radio buttons, by the way. [01:02:17] (03CR) 10Jforrester: [C: 032] ActionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191507 (owner: 10Kmenger) [01:02:24] (03CR) 10Jforrester: [C: 032] ActionSet: Add description for specialFlags property [oojs/ui] - 10https://gerrit.wikimedia.org/r/191500 (owner: 10Kmenger) [01:02:35] (03CR) 10Jforrester: [C: 032] ActionSet: Add @private to onActionChange method [oojs/ui] - 10https://gerrit.wikimedia.org/r/191495 (owner: 10Kmenger) [01:02:57] (03CR) 10Jforrester: [C: 032] ActionSet: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191493 (owner: 10Kmenger) [01:03:03] Krinkle: the transition is neat, even neater on radios (and will probably be neater on checkboxes when we use the mediawiki-theme checkbox icon). barring other considerations, i'd vote to keep it. [01:03:05] (03Merged) 10jenkins-bot: TextInputWidget: Deprecate 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/189499 (owner: 10Bartosz Dziewoński) [01:03:24] (03CR) 10Jforrester: [C: 032] DropdownWidget: Add @private to private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/191397 (owner: 10Kmenger) [01:03:37] (03CR) 10Jforrester: [C: 032] ButtonGroupWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191391 (owner: 10Kmenger) [01:03:49] (03Merged) 10jenkins-bot: ActionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191507 (owner: 10Kmenger) [01:03:51] (03CR) 10Jforrester: [C: 032] WindowManager: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191371 (owner: 10Kmenger) [01:04:08] (03CR) 10Jforrester: [C: 032] Window: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191363 (owner: 10Kmenger) [01:04:17] (03CR) 10Jforrester: [C: 032] SelectWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191216 (owner: 10Kmenger) [01:04:29] (03CR) 10Jforrester: [C: 032] InputWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191210 (owner: 10Kmenger) [01:04:39] (03CR) 10Jforrester: [C: 032] IndicatorElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191208 (owner: 10Kmenger) [01:04:47] (03Merged) 10jenkins-bot: ActionSet: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191493 (owner: 10Kmenger) [01:04:51] (03CR) 10Jforrester: [C: 032] IconWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191207 (owner: 10Kmenger) [01:05:01] (03CR) 10Jforrester: [C: 032] IconElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191205 (owner: 10Kmenger) [01:05:12] (03CR) 10Jforrester: [C: 032] GroupElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191203 (owner: 10Kmenger) [01:05:30] (03CR) 10Jforrester: [C: 032] FlaggedElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191197 (owner: 10Kmenger) [01:05:41] (03CR) 10Jforrester: [C: 032] FieldLayout: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191185 (owner: 10Kmenger) [01:05:43] (03Merged) 10jenkins-bot: ActionSet: Add @private to onActionChange method [oojs/ui] - 10https://gerrit.wikimedia.org/r/191495 (owner: 10Kmenger) [01:05:45] (03Merged) 10jenkins-bot: ActionSet: Add description for specialFlags property [oojs/ui] - 10https://gerrit.wikimedia.org/r/191500 (owner: 10Kmenger) [01:05:47] (03Merged) 10jenkins-bot: DropdownWidget: Add @private to private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/191397 (owner: 10Kmenger) [01:05:49] (03Merged) 10jenkins-bot: ButtonGroupWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191391 (owner: 10Kmenger) [01:05:51] (03CR) 10Jforrester: [C: 032] Element: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191170 (owner: 10Kmenger) [01:06:01] (03CR) 10Jforrester: [C: 032] ButtonWidget: Add example and link [oojs/ui] - 10https://gerrit.wikimedia.org/r/191129 (owner: 10Kmenger) [01:07:43] (03PS2) 10Jforrester: DropdownWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191477 (owner: 10Kmenger) [01:07:58] (03CR) 10Jforrester: [C: 032] "PS2 fixes some indentation." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191477 (owner: 10Kmenger) [01:08:23] MatmaRex: Are you fixing https://gerrit.wikimedia.org/r/#/c/191476/ in the next 10 minutes? [01:08:30] MatmaRex: 'Cos we need to cut a release… [01:08:45] James_F: it's allegedly already fixed [01:08:50] by using the mixed distribution [01:08:55] MatmaRex: Nonsense. [01:08:58] which just became the default [01:09:02] i know [01:09:02] MatmaRex: Only for MW. [01:09:06] doesn't make it not true [01:09:15] (03Merged) 10jenkins-bot: WindowManager: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191371 (owner: 10Kmenger) [01:09:17] (03Merged) 10jenkins-bot: Window: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191363 (owner: 10Kmenger) [01:09:19] (03Merged) 10jenkins-bot: SelectWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191216 (owner: 10Kmenger) [01:09:20] yeah, but well, who cares? [01:09:21] (03Merged) 10jenkins-bot: InputWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191210 (owner: 10Kmenger) [01:09:23] (03Merged) 10jenkins-bot: IndicatorElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191208 (owner: 10Kmenger) [01:09:26] only MW uses these stupid checkboxes [01:09:28] MatmaRex: I want OOjs UI to be a good library. [01:09:47] Apex theme is not affected, and only that is part of OOjs UI proper [01:10:02] Not true. MW theme is also OOjs UI proper. [01:10:22] my hack only fixes JS+MW, leaving PHP+MW still broken and Apex negatively affected [01:10:31] (03Merged) 10jenkins-bot: IconWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191207 (owner: 10Kmenger) [01:10:33] (03Merged) 10jenkins-bot: IconElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191205 (owner: 10Kmenger) [01:10:35] (03Merged) 10jenkins-bot: GroupElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191203 (owner: 10Kmenger) [01:10:37] (03Merged) 10jenkins-bot: FlaggedElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191197 (owner: 10Kmenger) [01:10:39] (03Merged) 10jenkins-bot: FieldLayout: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191185 (owner: 10Kmenger) [01:10:41] (03Merged) 10jenkins-bot: Element: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/191170 (owner: 10Kmenger) [01:10:43] (03CR) 10jenkins-bot: [V: 04-1] ButtonWidget: Add example and link [oojs/ui] - 10https://gerrit.wikimedia.org/r/191129 (owner: 10Kmenger) [01:10:45] (03Merged) 10jenkins-bot: DropdownWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/191477 (owner: 10Kmenger) [01:11:20] James_F: so, i'll let you make the decision, but in my opinion the hack i proposed is currently unnecessary and harmful [01:11:32] (removed my -2) [01:12:23] (03PS1) 10Mooeypoo: Display a message when no parameters are defined [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191518 (https://phabricator.wikimedia.org/T53429) [01:12:44] 3TemplateData: TemplateData: Display a useful message instead of an empty table for templates that take no parameters - https://phabricator.wikimedia.org/T53429#1048755 (10Mooeypoo) a:3Mooeypoo [01:13:10] (03CR) 10Bartosz Dziewoński: [C: 032] MediaWiki Theme: Fix border width for frameless buttons' focus state [oojs/ui] - 10https://gerrit.wikimedia.org/r/191266 (https://phabricator.wikimedia.org/T87692) (owner: 10Prtksxna) [01:14:12] (03PS2) 10Catrope: ButtonWidget: Add example and link [oojs/ui] - 10https://gerrit.wikimedia.org/r/191129 (owner: 10Kmenger) [01:14:39] (03Merged) 10jenkins-bot: MediaWiki Theme: Fix border width for frameless buttons' focus state [oojs/ui] - 10https://gerrit.wikimedia.org/r/191266 (https://phabricator.wikimedia.org/T87692) (owner: 10Prtksxna) [01:14:54] MatmaRex: Eh. [01:15:14] (03CR) 10Jforrester: [C: 032] ButtonWidget: Add example and link [oojs/ui] - 10https://gerrit.wikimedia.org/r/191129 (owner: 10Kmenger) [01:15:59] 3OOjs-UI: OOjs UI: trouble with CheckboxInputWidget in Opera - https://phabricator.wikimedia.org/T75517#1048759 (10Jdforrester-WMF) [01:16:02] 3OOjs-UI: Add SVG+PNG distribution serving SVG images to modern browsers and PNG as a fallback, primarily for PHP OOUI support in older browsers - https://phabricator.wikimedia.org/T87501#1048757 (10Jdforrester-WMF) 5Open>3Resolved [01:16:10] 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1048761 (10Jdforrester-WMF) 5Open>3Resolved [01:16:37] (03Merged) 10jenkins-bot: ButtonWidget: Add example and link [oojs/ui] - 10https://gerrit.wikimedia.org/r/191129 (owner: 10Kmenger) [01:16:55] MatmaRex: It worked fine for me in Apex when I tested it. What broke? [01:17:26] (03PS1) 10Kmenger: IconElement: Add description and fix display of static properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/191519 [01:17:33] 3OOjs-UI: ButtonWidget (frameless)‎ has no visual focus state in the MediaWiki theme - https://phabricator.wikimedia.org/T87692#1048765 (10matmarex) You can do anything with enough negative margins. Or you might try [[https://developer.mozilla.org/en-US/docs/Web/CSS/outline | outline ]] + [[ https://developer.mo... [01:17:33] (03CR) 10Catrope: [C: 032] Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders) [01:17:54] James_F: nothing broke, it's just unnecessary code that will bite us in the ass at some point [01:18:09] MatmaRex: That's why we'll revert it once Krinkle's patch lands. [01:18:37] if you think supporting JS+MW+vectoronly, which no one will ever use, is that important, then okay [01:18:41] :) [01:18:49] (03CR) 10Jforrester: [C: 032] IconElement: Add description and fix display of static properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/191519 (owner: 10Kmenger) [01:18:55] MatmaRex: :-P [01:18:59] OK. [01:19:28] it's not really something that causes me to lose sleep, personally [01:20:08] (03Merged) 10jenkins-bot: Support generic data transfer handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187951 (owner: 10Esanders) [01:21:00] So in summary: The patch negatively affects Apex theme (performance) in fixing a MW-theme specific bug. And the fix only fixes JS mode, not PHP mode. And MW-theme in MW core uses Mixed, which doesn't exhibit the bug. [01:21:33] (03Merged) 10jenkins-bot: IconElement: Add description and fix display of static properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/191519 (owner: 10Kmenger) [01:21:39] Once thedj has a WebKit reference, I'll amend the patch to maybe add a comment referencing that report. [01:22:15] (03CR) 10Jforrester: "Should we also handle this when the popup isn't autoclose? They're manually closing it…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [01:22:34] Krinkle: OK. [01:22:38] It's an unfortunate scenario, since all three factors that awaken the bug (bg color, svg, transition) are desired. Removing bg-color seems harmless at first, but will break when on a colored or shared background, making the checkbox look disabled. [01:22:48] Otherwise I'd just remove one of those three props [01:23:16] Like in the login form on mobile, or in a fieldset with grey background. [01:23:33] Yeah. [01:26:34] (03PS1) 10Jforrester: Tag v0.8.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/191522 [01:26:50] MatmaRex: +2 https://gerrit.wikimedia.org/r/191522 please? [01:27:42] the release notes are somewhat inflated, heh [01:27:47] (03CR) 10Bartosz Dziewoński: [C: 032] Tag v0.8.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/191522 (owner: 10Jforrester) [01:27:59] MatmaRex: :-) [01:28:04] (03CR) 10Catrope: [C: 032] Display TemplateData parameter table according to param order [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191514 (owner: 10Mooeypoo) [01:28:07] And yeah, kirstenMA's awesome. [01:28:59] (03Merged) 10jenkins-bot: Display TemplateData parameter table according to param order [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191514 (owner: 10Mooeypoo) [01:29:11] 3OOjs-UI: Consider changing toggle to toggleVisibility - https://phabricator.wikimedia.org/T76644#1048774 (10matmarex) >>! In T76644#821446, @matmarex wrote: > I considered it and in my opinion `.toggle()` is intuitive enough, matches the convention established by jQuery And now that we ditched jQuery's `.toggl... [01:29:13] (03Merged) 10jenkins-bot: Tag v0.8.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/191522 (owner: 10Jforrester) [01:30:28] (03CR) 10Catrope: [C: 04-1] Display a message when no parameters are defined (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191518 (https://phabricator.wikimedia.org/T53429) (owner: 10Mooeypoo) [01:31:42] 3VisualEditor, VisualEditor-MediaWiki: VisualEditor is emitting event "timing.ve.behavior.firstTransaction.undefined" - https://phabricator.wikimedia.org/T89735#1048775 (10Jdforrester-WMF) 5Open>3Resolved [01:31:53] 3VisualEditor, VisualEditor-Performance: ve.ce.Surface.showSelection forces a style recalc - https://phabricator.wikimedia.org/T87419#1048777 (10Jdforrester-WMF) 5Open>3Resolved [01:32:23] 3OOjs-UI: All SelectWidgets (most importantly DropdownWidget/MenuSelectWidget and ButtonSelectWidget) are not keyboard-accessible - https://phabricator.wikimedia.org/T88906#1048779 (10Jdforrester-WMF) 5Open>3Resolved [01:33:43] (03PS3) 10Catrope: Change global class variables to mw.TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 (owner: 10Mooeypoo) [01:36:23] (03PS1) 10Jforrester: Update OOjs UI to v0.8.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191523 [01:37:43] 3OOjs-UI, VisualEditor: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1048784 (10matmarex) @Krinkle has spent more time determining the cause of this. Apparently it happens when `:checked` and `+` selectors and used, and the element being styled has a backg... [01:37:55] Krinkle: sanity check ^ [01:38:05] (03PS4) 10Mooeypoo: Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 [01:38:18] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.8.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191523 (owner: 10Jforrester) [01:38:27] (03PS5) 10Mooeypoo: Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 [01:38:33] Krinkle: that gave me the thought, we could just use the "linear-gradient(transparent, transparent)" thing as a semi-permanent low-cost workaround. [01:38:37] (03PS3) 10Mooeypoo: Warn if a TemplateData block already exists in related page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191491 (https://phabricator.wikimedia.org/T74062) [01:38:40] James_F: ^ [01:42:03] (03PS2) 10Mooeypoo: Display a message when no parameters are defined [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191518 (https://phabricator.wikimedia.org/T53429) [01:42:06] (03CR) 10jenkins-bot: [V: 04-1] Display a message when no parameters are defined [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191518 (https://phabricator.wikimedia.org/T53429) (owner: 10Mooeypoo) [01:42:23] (03CR) 10Catrope: Change global class variables to mw.TemplateData (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 (owner: 10Mooeypoo) [01:42:43] (03CR) 10Catrope: [C: 04-1] "See inline comment on PS3. Also, why did you remove the closures from some files but not others?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 (owner: 10Mooeypoo) [01:44:07] (03PS3) 10Mooeypoo: Display a message when no parameters are defined [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191518 (https://phabricator.wikimedia.org/T53429) [01:44:41] (03CR) 10Catrope: [C: 032] Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 (owner: 10Mooeypoo) [01:46:33] (03PS2) 10Jforrester: Update OOjs UI to v0.8.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191523 [01:47:13] (03PS4) 10Mooeypoo: Change global class variables to mw.TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 [01:48:04] (03CR) 10Catrope: [C: 032] Display a message when no parameters are defined [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191518 (https://phabricator.wikimedia.org/T53429) (owner: 10Mooeypoo) [01:48:23] 3TemplateData: TemplateData: Display a useful message instead of an empty table for templates that take no parameters - https://phabricator.wikimedia.org/T53429#1048807 (10Jdforrester-WMF) 5Open>3Resolved [01:48:35] (03Merged) 10jenkins-bot: Display a message when no parameters are defined [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191518 (https://phabricator.wikimedia.org/T53429) (owner: 10Mooeypoo) [01:49:13] (03CR) 10Catrope: [C: 032] Change global class variables to mw.TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 (owner: 10Mooeypoo) [01:49:44] (03Merged) 10jenkins-bot: Change global class variables to mw.TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191217 (owner: 10Mooeypoo) [01:50:28] ori: 3611664663f0a739507c8d2a7fb439cab4b2cfdb [01:50:46] 3TemplateData: TemplateData: Have the GUI editor warn the user if a related page already contains a TemplateData block - https://phabricator.wikimedia.org/T74062#1048822 (10Jdforrester-WMF) [01:50:53] ori: That was my thing. Your thing is 4cf393da542aa4acce21f3cff2e040b3e53a0121 [01:51:21] RoanKattouw: https://gerrit.wikimedia.org/r/#/q/If14d382beae3f42d2ffb3a43ee0c3e2a488a5fa1,n,z *looks winsome* [01:52:15] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.8.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191523 (owner: 10Jforrester) [01:54:12] (03Merged) 10jenkins-bot: Update OOjs UI to v0.8.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191523 (owner: 10Jforrester) [01:54:52] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/190967/ [01:55:03] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/189737/ [01:56:21] (03PS4) 10Catrope: Warn if a TemplateData block already exists in related page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191491 (https://phabricator.wikimedia.org/T74062) (owner: 10Mooeypoo) [01:56:32] (03CR) 10Catrope: [C: 032] Warn if a TemplateData block already exists in related page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191491 (https://phabricator.wikimedia.org/T74062) (owner: 10Mooeypoo) [01:56:35] (03CR) 10jenkins-bot: [V: 04-1] Warn if a TemplateData block already exists in related page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191491 (https://phabricator.wikimedia.org/T74062) (owner: 10Mooeypoo) [01:58:00] (03CR) 10Catrope: [C: 032] Remove some errant references to MediaWiki/Parsoid that don't belong [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190967 (owner: 10Jforrester) [02:02:16] (03PS6) 10Mooeypoo: Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 [02:03:19] 3VisualEditor: Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1048837 (10Etonkovidova) 3NEW [02:03:43] (03Merged) 10jenkins-bot: Remove some errant references to MediaWiki/Parsoid that don't belong [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190967 (owner: 10Jforrester) [02:04:21] (03CR) 10jenkins-bot: [V: 04-1] Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 (owner: 10Mooeypoo) [02:09:20] (03Merged) 10jenkins-bot: Warn if a TemplateData block already exists in related page [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191491 (https://phabricator.wikimedia.org/T74062) (owner: 10Mooeypoo) [02:09:40] (03CR) 10Catrope: [C: 032] Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 (owner: 10Mooeypoo) [02:09:40] 3TemplateData: Have the TemplateData GUI editor warn the user if a related page already contains a TemplateData block - https://phabricator.wikimedia.org/T74062#1048862 (10Jdforrester-WMF) 5Open>3Resolved [02:10:13] (03Merged) 10jenkins-bot: Allow adding a new parameter again [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191494 (owner: 10Mooeypoo) [02:14:07] 3VisualEditor, VisualEditor-Performance, VisualEditor-Initialisation: VisualEditor "beta" appended label causes edit tab to flicker - https://phabricator.wikimedia.org/T89668#1048877 (10Eloquence) p:5Volunteer?>3Low [02:15:08] ^ James_F just moving more small polish things into the features/UX backlog for consideration during pre release cleanup [02:15:12] 3VisualEditor, VisualEditor-Performance, VisualEditor-Initialisation: VisualEditor "beta" appended label causes edit tab to flicker - https://phabricator.wikimedia.org/T89668#1048883 (10Jdforrester-WMF) This would go away if we resolved {T60583}… [02:15:33] * James_F nods. [02:19:44] 3OOjs-UI, VisualEditor: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1048894 (10Krinkle) Reduced test case: http://s.codepen.io/Krinkle/debug/JoLyzx ([view source](http://codepen.io/Krinkle/pen/JoLyzx?editors=110)). In Safari 8 on OS X 10.9 or 10.10, the c... [02:20:21] James_F: I'll add it in a comment on the patch for now [02:20:28] ori: Ta. [02:23:05] James_F, speaking of making james sad, can I show you another small bug you may not have noticed yet [02:23:13] Eloquence: Sure. [02:25:26] (03CR) 10Ori.livneh: "For the test page on osmium, median CPU time for the convertModelFromDom stage went down by 47%, from 324.31ms to 200.82ms. This is becaus" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190963 (owner: 10Catrope) [02:26:06] ori: Thanks! [02:26:42] (03CR) 10Catrope: [C: 032] Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [02:28:46] (03CR) 10jenkins-bot: [V: 04-1] Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [02:29:37] (03PS7) 10Catrope: Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [02:32:11] (03CR) 10jenkins-bot: [V: 04-1] Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [02:35:19] (03PS8) 10Catrope: Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [02:35:53] (03PS7) 10Catrope: Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 (owner: 10Esanders) [02:36:02] (03CR) 10Catrope: [C: 032] Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 (owner: 10Esanders) [02:36:11] (03CR) 10Catrope: [C: 032] Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [02:36:25] (03PS9) 10Catrope: Unify data transfer handlers for paste and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 (owner: 10Esanders) [02:37:54] (03Merged) 10jenkins-bot: Try html/plain text drop if no file handlers found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188028 (owner: 10Esanders) [02:38:07] (03Merged) 10jenkins-bot: Simplify AlignableNode by inheriting from ClassAttributeNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/189737 (owner: 10Esanders) [02:47:28] 3VisualEditor, VisualEditor-Performance: Don't disable native object editing in IE and WebKit browsers - https://phabricator.wikimedia.org/T89928#1048939 (10ori) 3NEW a:3Catrope [03:07:55] (03CR) 10Catrope: [C: 04-1] Unify data transfer handlers for paste and drop (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188029 (owner: 10Esanders) [03:08:37] (03CR) 10Jforrester: "Trevor says just detect if the search-and-replace dialog is open and if so close it on opening (and v.v.)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [03:11:21] (03PS1) 10Jforrester: Update VE core submodule to master (a7cd696) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191532 [03:12:31] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (a7cd696) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191532 (owner: 10Jforrester) [03:12:37] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (a7cd696) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191532 (owner: 10Jforrester) [03:14:26] James_F: RoanKattouw_away: https://bugs.webkit.org/show_bug.cgi?id=141789 [03:15:27] Krinkle: Thanks. [04:11:18] 3VisualEditor, VisualEditor-Performance: Incrementally parse and convert API response as data comes in - https://phabricator.wikimedia.org/T89930#1048973 (10ori) 3NEW [05:32:16] 3OOjs-UI: All icons should use 65% black rather than solid black in the MediaWiki theme - https://phabricator.wikimedia.org/T86047#1049012 (10Prtksxna) >>! In T86047#1046597, @KHammerstein wrote: > @Prtksxna Its #555 Ah! Right, sorry. I calculated 65% of white {icon frown-o}. Do you want //all// icons to be th... [05:33:53] 3VisualEditor: [Regression wmf 17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1049013 (10Ryasmeen) 3NEW [05:45:45] 3VisualEditor: [Regression wmf 17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1049020 (10Ryasmeen) [06:04:10] (03PS1) 10Krinkle: MediaWiki Theme: Drop unnecessary pseudo-element of CheckboxInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/191538 [06:04:12] (03PS1) 10Krinkle: MediaWiki Theme: Drop unnecessary pseudo-element of RadioInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/191539 [06:07:29] (03CR) 10Krinkle: [C: 04-1] "Hm.. this changed the appearance of RadioSelectWidget, which needs a similar fix." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191539 (owner: 10Krinkle) [06:24:56] 3VisualEditor: [Regression wmf 17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1049044 (10Ryasmeen) p:5High>3Unbreak! [06:27:03] 3VisualEditor: [Regression wmf 17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1049045 (10Ryasmeen) This is probably worse , being unable to further any edit.Pressing Enter also deleting the edited content {F43369} [06:31:39] 3VisualEditor: Backspace key at end of document moves the cursor up a line - https://phabricator.wikimedia.org/T74689#1049058 (10Krinkle) I can't reproduce this. Placing the cursor at the end of the paragraph under "Record impression" on [mw:Extension:CentralNotice/Banner_loading]( https://www.mediawiki.org/w/in... [07:47:45] 3VisualEditor: [Regression wmf 17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1049133 (10Catrope) @dchan Could this be a regression from native backspacing? It seems that if you select text at the beginning of a paragraph and press backspace, the nativ... [07:49:11] 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf 17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1049134 (10Catrope) a:3dchan [08:07:26] (03PS11) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 [08:09:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 (owner: 10SuchetaG) [08:14:14] 3VisualEditor, VisualEditor-Performance: Incrementally parse and convert API response as data comes in - https://phabricator.wikimedia.org/T89930#1049161 (10Catrope) Does Oboe.js support incremental decoding within a single string in the JSON it's decoding? That would be required, because the bulk of the JSON re... [08:23:18] 3MediaWiki-Page-editing, MediaWiki-RfCs: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1049169 (10Fomafix) [08:33:34] 3Editing, MediaWiki-Page-editing: LivePreview should not show edit section buttons - https://phabricator.wikimedia.org/T89941#1049201 (10Fomafix) [08:56:18] 3VisualEditor: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1049222 (10Tbayer) 3NEW [08:58:14] (03PS4) 10Catrope: Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [08:59:40] (03PS12) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 [08:59:54] (03CR) 10jenkins-bot: [V: 04-1] Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [09:02:12] 3VisualEditor: Deleting section heading leaves "====" - https://phabricator.wikimedia.org/T87424#1049232 (10Tbayer) I can still reproduce it as described. To clarify, when I wrote "the following is left in the wikitext", I was referring to the wikitext as shown in the preview diff, in the "review your c... [09:08:54] 3VisualEditor: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1049240 (10Catrope) This appears to happen because store indexes in the pasted linear data aren't remapped. The reference contains italicized text, and the italics annotat... [09:28:21] 3Editing, MediaWiki-Page-editing: LivePreview should not show edit section buttons - https://phabricator.wikimedia.org/T89941#1049256 (10Fomafix) a:3Fomafix [09:36:50] 3VisualEditor: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1049262 (10Catrope) a:3Catrope [09:36:58] (03PS1) 10Catrope: newFromDocumentInsertion: Also remap store indexes in internalList data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191557 (https://phabricator.wikimedia.org/T89943) [09:38:10] (03CR) 10jenkins-bot: [V: 04-1] newFromDocumentInsertion: Also remap store indexes in internalList data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191557 (https://phabricator.wikimedia.org/T89943) (owner: 10Catrope) [09:43:00] 3MediaWiki-Page-editing: LivePreview doesn't allow interaction with page content outside of #wikiPreview (it is not passed to mw.hook) - https://phabricator.wikimedia.org/T71108#1049290 (10TheDJ) [10:14:29] (03PS2) 10Catrope: newFromDocumentInsertion: Also remap store indexes in internalList data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191557 (https://phabricator.wikimedia.org/T89943) [10:14:31] (03PS1) 10Catrope: Add some more tests for newFromDocumentInserton [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191561 [10:18:48] 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf 17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1049351 (10Catrope) It looks like there is a check in handleLinearDelete falling back to programmatic behavior if the cursor is near an element... [10:25:54] 3VisualEditor, MediaWiki-extensions-ContentTranslation: refactor upload.rb: move it from the VE repo to a reusable module so that it would be possible to use it for other features - https://phabricator.wikimedia.org/T89718#1049356 (10Amire80) a:3Amire80 [10:26:17] (03PS1) 10Amire80: [BrowserTest] Move the screenshot uploading to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191563 (https://phabricator.wikimedia.org/T89718) [10:28:55] (03PS2) 10Amire80: [BrowserTest] Move the screenshot uploading to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191563 (https://phabricator.wikimedia.org/T89718) [10:29:45] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Move the screenshot uploading to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191563 (https://phabricator.wikimedia.org/T89718) (owner: 10Amire80) [10:32:51] (03Merged) 10jenkins-bot: [BrowserTest] Move the screenshot uploading to a gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191563 (https://phabricator.wikimedia.org/T89718) (owner: 10Amire80) [11:00:34] 3VisualEditor, MediaWiki-extensions-ContentTranslation: refactor upload.rb: move it from the VE repo to a reusable module so that it would be possible to use it for other features - https://phabricator.wikimedia.org/T89718#1049412 (10Amire80) 5Open>3Resolved Moved upload.rb to a gem: https://rubygems.org/gem... [11:59:46] 3Editing, MediaWiki-Page-editing: LivePreview should not show edit section buttons - https://phabricator.wikimedia.org/T89941#1049560 (10matmarex) 5Open>3Resolved [11:59:47] 3MediaWiki-RfCs, MediaWiki-Page-editing: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1049562 (10matmarex) [12:37:08] 3Editing, MediaWiki-Page-editing: LivePreview should not show edit section buttons - https://phabricator.wikimedia.org/T89941#1049603 (10TheDJ) Was just thinking, it's actually a bit weird that the 'preview' mode of the parse module doesn't activate this option automatically.... [13:13:31] (03PS1) 10Esanders: Separate out toolbar attachment in overridable method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191587 [13:36:54] (03CR) 10Esanders: "I agree the design is not the greatest - considered some ways of highlighting the line, could just stick with what we have (dotted outline" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) (owner: 10Esanders) [13:37:55] (03PS7) 10Esanders: Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) [13:52:37] (03PS8) 10Esanders: Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) [13:58:17] 3OOjs-UI: OOjs UI: trouble with CheckboxInputWidget in Opera - https://phabricator.wikimedia.org/T75517#1049676 (10matmarex) 5Open>3Resolved The issue has now been fixed, and the fix will be included in MediaWiki version 1.25wmf19. According to https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap, that vers... [14:01:29] (03Abandoned) 10Bartosz Dziewoński: Workaround for Safari being useless at being a browser [oojs/ui] - 10https://gerrit.wikimedia.org/r/191476 (https://phabricator.wikimedia.org/T89309) (owner: 10Bartosz Dziewoński) [14:11:42] (03CR) 10Fomafix: [C: 04-1] "Untested." (033 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [14:42:20] (03CR) 10Esanders: "I've restored the previous styling (blue background, dashed border)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) (owner: 10Esanders) [14:51:44] 3UI-Standardization, OOjs-UI, VisualEditor, MediaWiki-General-or-Unknown: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1049748 (10Ricordisamoa) [15:20:53] (03CR) 10Mvolz: "Yup, the design that Kaity did has it as an inspector, not a dialog." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [15:34:17] (03PS1) 10Mvolz: Remove dialog from catchall menu [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/191621 (https://phabricator.wikimedia.org/T89555) [15:59:52] (03CR) 10Esanders: "Not without completely refactoring how inspectors behave. They aren't modal, whereas dialogs can be." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [16:02:48] (03CR) 10Esanders: "The problem is that because a staged reference looks the same as a completed reference there is no indication to the user that what they h" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [16:07:40] (03CR) 10Mvolz: "If we don't add the reference until after the template has been filled and it's addable, that's slightly better, but there will still be p" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [16:16:16] So, I'm seeing "TypeError: originFn is undefined" ... I assume this means the oojs being used is out of date? [16:20:01] oo! just found an old IRC log where mooey|away had the same problem and TrevorP|Away helped ... [16:20:57] mooey|away's problem was code wasn't synced.... checking. [16:24:15] (03PS1) 10Amire80: [BrowserTest] Remove outdated offenses from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191627 [16:34:29] (03PS2) 10Mvolz: Add Grunt and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) [16:36:52] (03CR) 10Jforrester: [C: 032] Remove dialog from catchall menu [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/191621 (https://phabricator.wikimedia.org/T89555) (owner: 10Mvolz) [16:37:53] 3VisualEditor, VisualEditor-MediaWiki-References, Citoid: Don't let the Citoid tool be added to the "catchall" toolbar group, because it makes for a confusing/broken experience - https://phabricator.wikimedia.org/T89555#1050012 (10Jdforrester-WMF) 5Open>3Resolved [16:39:03] (03CR) 10Mvolz: Add Grunt and clean-up its errors (034 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [16:39:07] (03PS1) 10Divec: Prevent the default action for uncollapsed linear delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191632 (https://phabricator.wikimedia.org/T89933) [16:40:05] 3MediaWiki-Page-editing, Wikidata, MediaWiki-API: ApiStashEdit silently loses custom DataUpdates. - https://phabricator.wikimedia.org/T86305#1050019 (10daniel) 5Open>3Resolved a:3daniel Wikibase no longer uses addSecondaryDataUpdates() [16:41:13] (03PS1) 10Bartosz Dziewoński: Work around Safari 8 misrendering checkboxes in SVG-only distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/191633 (https://phabricator.wikimedia.org/T89309) [16:41:15] 3VisualEditor, VisualEditor-ContentEditable: [Regression wmf17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1050026 (10Jdforrester-WMF) [16:43:17] (03CR) 10Jforrester: Add Grunt and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [16:46:15] (03PS3) 10Mvolz: Add Grunt and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) [16:47:11] (03CR) 10Mvolz: Add Grunt and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [16:50:22] (03CR) 10Jforrester: [C: 031] Add Grunt and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [16:54:53] 3OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1050071 (10matmarex) p:5Triage>3Normal [16:54:58] 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1050073 (10matmarex) p:5Triage>3High [16:55:18] 3OOjs-UI: Inconsistency in how child content is added to widgets - https://phabricator.wikimedia.org/T89750#1050084 (10matmarex) p:5Triage>3High a:3matmarex [16:56:28] 3OOjs-UI, VisualEditor: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1050090 (10matmarex) [16:59:09] 3VisualEditor, VisualEditor-CopyPaste: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1050096 (10Aklapper) p:5Triage>3High [17:00:03] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1050098 (10Perhelion) On request I've created an new signature icon: * [[ http://commons.wikimedia.org/wiki/File:Insert-signature2.svg | File:Insert-signature2.svg ]] Because the current icon shows some... [17:02:16] 3VisualEditor: VisualEditor: histograms are duplicated while editing - https://phabricator.wikimedia.org/T55583#1050101 (10Aklapper) 5Open>3Resolved a:3Aklapper I don't see anything weird either on https://fr.wikipedia.org/w/index.php?title=Aix-en-Othe&veaction=edit Closing as FIXED. [17:16:40] (03CR) 10Alex Monk: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191632 (https://phabricator.wikimedia.org/T89933) (owner: 10Divec) [17:16:45] 3VisualEditor: VisualEditor: adding section for references will suppress the Related Articles one - https://phabricator.wikimedia.org/T55699#1050117 (10Aklapper) > When creating a section for references and adding the relevant tag, What I tried: Write the text "Notes" right above "Voci correlate", mark that tex... [17:17:32] (03CR) 10Esanders: "Indeed, the staged content is very small, and without a modal dialog it's going to be hard to make that clear. We should continue this dis" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [17:19:58] (03CR) 10Esanders: [C: 032] Prevent the default action for uncollapsed linear delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191632 (https://phabricator.wikimedia.org/T89933) (owner: 10Divec) [17:22:14] (03PS2) 10Esanders: Fix appearance of icons on disabled TextInputWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 [17:24:04] 3VisualEditor, VisualEditor-MediaWiki-Templates: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#1050127 (10Aklapper) [17:26:24] 3VisualEditor-MediaWiki-Links, VisualEditor: Duplicate suggestion in VisualEditor link adder when entring an existing page name with underscore - https://phabricator.wikimedia.org/T87727#1050134 (10Aklapper) [17:30:02] 3VisualEditor, VisualEditor-DataModel: VisualEditor: Duplicating categories (and possibly also something else) - https://phabricator.wikimedia.org/T56169#1050144 (10Aklapper) [17:30:34] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=111987301 [17:30:34] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34366243 [17:30:34] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34371810 [17:30:34] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34372908 [17:30:34] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34372912 [17:30:35] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34373060 [17:30:35] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34373252 [17:30:36] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68690817 [17:30:36] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=41364305 [17:30:36] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=41370653 [17:30:37] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70929587 [17:30:42] 3VisualEditor, VisualEditor-MediaWiki: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#818786 (10Aklapper) [17:31:02] 3VisualEditor: Category was duplicated and given different sort keys - https://phabricator.wikimedia.org/T89618#1040554 (10Aklapper) [17:38:08] 3VisualEditor-MediaWiki-Links, VisualEditor: Duplicate suggestion in VisualEditor link adder when entering an existing page name with underscore - https://phabricator.wikimedia.org/T87727#1050173 (10Aklapper) [17:43:22] 3VisualEditor, VisualEditor-Performance, Analytics-Engineering, Analytics-Kanban: Report on the central tendency for length of pages which are edited for VisualEditor performance benchmarking - https://phabricator.wikimedia.org/T89788#1050190 (10kevinator) p:5Triage>3Normal [17:50:09] 3UI-Standardization, OOjs-UI, VisualEditor, MediaWiki-General-or-Unknown: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1050217 (10Jdforrester-WMF) This doesn't have anything to do with extending or modifying the OOjs UI library, just using it. [17:50:19] 3UI-Standardization, VisualEditor, MediaWiki-General-or-Unknown: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1050218 (10Jdforrester-WMF) [17:51:12] 3UI-Standardization, OOjs-UI: Move the "MediaWiki" OOjs UI theme to the MediaWiki repo - https://phabricator.wikimedia.org/T76633#1050224 (10Jdforrester-WMF) p:5Low>3Volunteer? [17:54:48] 3VisualEditor, VisualEditor-Performance, Analytics-Engineering, Analytics-Kanban: Report on the central tendency for length of pages which are edited for VisualEditor performance benchmarking - https://phabricator.wikimedia.org/T89788#1050231 (10Milimetric) Thanks for the tag, Grace. James, how about a breakdow... [17:56:36] 3VisualEditor, VisualEditor-Performance, Analytics-Engineering, Analytics-Kanban: Report on the central tendency for length of pages which are edited for VisualEditor performance benchmarking - https://phabricator.wikimedia.org/T89788#1050237 (10Jdforrester-WMF) >>! In T89788#1050231, @Milimetric wrote: > Thanks... [18:00:04] (03PS3) 10Esanders: Fix appearance of icons and labels on disabled TextInputWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 [18:00:41] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Cursor cannot move through text created with jquery.IME when editing bulleted text - https://phabricator.wikimedia.org/T55711#1050250 (10dchan) [18:00:42] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: CE eats up syllables except a last syllable of a word in Korean IME - https://phabricator.wikimedia.org/T52631#1050251 (10dchan) [18:00:43] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Marathi/Devanagari: After typing first character cursor moves in wrong direction when using jquery.IME - https://phabricator.wikimedia.org/T55701#1050252 (10dchan) [18:00:44] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Typing problem in Assamese - https://phabricator.wikimedia.org/T54726#1050254 (10dchan) [18:00:45] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: Incorrect and irremovable text placement with IMEs - https://phabricator.wikimedia.org/T55708#1050255 (10dchan) [18:00:46] 3VisualEditor, VisualEditor-ContentLanguage: VisualEditor: When using jquery.IME, type a word and press space bar = eliminates typed text immediately - https://phabricator.wikimedia.org/T55700#1050253 (10dchan) [18:00:47] 3VisualEditor, VisualEditor-ContentLanguage: Make the Sogou Input IME work - https://phabricator.wikimedia.org/T49436#1050256 (10dchan) [18:00:48] 3VisualEditor, VisualEditor-ContentEditable: VisualEditor: Change event reaction order - https://phabricator.wikimedia.org/T59290#1050248 (10dchan) 5Open>3Resolved IME support has improved markedly due to incrementally revamped event logic. Significant milestones included: https://gerrit.wikimedia.org/r/866... [18:01:22] (03CR) 10Esanders: "Then you'd need to make the text white for consistency, and then you'd need to make the background darker to make the text legible. This i" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 (owner: 10Esanders) [18:03:46] 3VisualEditor, VisualEditor-Performance, Analytics-Engineering, Analytics-Kanban: Report on the central tendency for length of pages which are edited for VisualEditor performance benchmarking - https://phabricator.wikimedia.org/T89788#1050267 (10Milimetric) > That'd be great. :-) The initial impetus of this requ... [18:04:33] 3VisualEditor-MediaWiki-Links, VisualEditor: Links don't get created fast enough (creates an internal link to selected text rather than an external link to URL pasted) - https://phabricator.wikimedia.org/T89010#1050270 (10Aklapper) [18:05:17] 3MediaWiki-Page-editing: Enable microsurveys for long-term tracking of editing experience - https://phabricator.wikimedia.org/T89970#1050279 (10Whatamidoing-WMF) 3NEW [18:16:28] (03PS1) 10Vikassy: [BrowserTest] Edited language screenshot steps which had iframe elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191655 (https://phabricator.wikimedia.org/T89370) [18:17:32] mooeypoo: okay what weird stuff is happening :) [18:18:16] mvolz, hang on, I'm loading it again so I can give you the exact error [18:18:18] (03PS1) 10Alex Monk: Use new SkinEditSectionLinks hook instead of DoEditSectionLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191658 (https://phabricator.wikimedia.org/T88027) [18:18:58] p.s. you can always file a bug too [18:19:02] I think we under-file bugs [18:19:07] it makes things googleable [18:19:10] google is good. [18:19:11] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] Edited language screenshot steps which had iframe elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191655 (https://phabricator.wikimedia.org/T89370) (owner: 10Vikassy) [18:19:47] (03PS5) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) [18:19:53] mvolz: agreed, but sometimes I find stuff in IRC logs via google [18:20:04] (03PS1) 10Jforrester: Prevent the default action for uncollapsed linear delete [VisualEditor/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/191661 (https://phabricator.wikimedia.org/T89933) [18:20:27] ^-^ [18:20:30] mvolz, so, apparently it works now [18:20:36] mvolz, yesterday it gave me errors on the translators [18:20:42] 3UI-Standardization, VisualEditor, MediaWiki-General-or-Unknown: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1050348 (10Ricordisamoa) >>! In T89878#1050217, @Jdforrester-WMF wrote: > This doesn't have anything to do with extending or modifying the OOjs UI library, just... [18:20:50] mvolz, something about translator server not running [18:20:53] but today it works! [18:21:11] was the output from zotero or from citoid? [18:21:29] translation-server == zotero [18:21:55] if zotero is dead it should still work. but in production, it doesn't [18:22:05] and someday i will get those logs. [18:22:06] someday. [18:22:48] (03PS1) 10Esanders: Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 [18:23:07] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1050362 (10Paladox) Thanks will add it soon to the patch. [18:23:24] edsanders: so like who do we ask about this inspector vs. dialog thing- trevor? kaity? both? [18:23:34] 3MediaWiki-Page-editing: Enable microsurveys for long-term tracking of editing experience - https://phabricator.wikimedia.org/T89970#1050364 (10Whatamidoing-WMF) I seem to have accidentally deleted the end of the second paragraph: The stray "If" should say: "If the rate is set to just 1% of edits (or even lowe... [18:23:42] yeah - lets start with Trevor [18:24:29] we should come up with a clear idea of what we thing will solve the problem before seeing if we need more designs [18:24:46] (03PS2) 10Jforrester: Prevent the default action for uncollapsed linear delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191632 (https://phabricator.wikimedia.org/T89933) (owner: 10Divec) [18:24:48] (03CR) 10jenkins-bot: [V: 04-1] Prevent the default action for uncollapsed linear delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191632 (https://phabricator.wikimedia.org/T89933) (owner: 10Divec) [18:25:00] (03CR) 10Mooeypoo: "I don't know, I think that's a non-issue, honestly. If a user wants to add a reference, they insert the link, and the inspector tells them" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [18:26:06] (03CR) 10Bartosz Dziewoński: [C: 04-1] "What is "oo-ui-pointer-indicator"? Just bad copy-paste?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 (owner: 10Esanders) [18:26:50] (03PS1) 10Jforrester: Prevent the default action for uncollapsed linear delete [VisualEditor/VisualEditor] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/191663 (https://phabricator.wikimedia.org/T89933) [18:27:14] 3VisualEditor, VisualEditor-MediaWiki-Media: Media Settings "Uploaded by..." not consistently accurate - https://phabricator.wikimedia.org/T88835#1050382 (10Etonkovidova) [18:27:59] (03CR) 10Catrope: [C: 032] Separate out toolbar attachment in overridable method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191587 (owner: 10Esanders) [18:28:04] (03CR) 10Catrope: [C: 031] Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [18:28:16] (03CR) 10Esanders: "must have been a double cursor. grr" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 (owner: 10Esanders) [18:28:58] (03PS4) 10Esanders: Fix appearance of icons and labels on disabled TextInputWidgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 [18:30:59] 3VisualEditor: Remainder of heading irrecoverably removed after deleting part of it - https://phabricator.wikimedia.org/T89972#1050397 (10Mvolz) 3NEW [18:31:02] mvolz: edsanders whats the problem you are solving? [18:31:30] using an indicator for the citation inserter [18:31:33] (03PS3) 10Catrope: Prevent the default action for uncollapsed linear delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191632 (https://phabricator.wikimedia.org/T89933) (owner: 10Divec) [18:31:45] *inspector [18:31:53] *using an inspector [18:32:08] inspectors aren't modal and don't give you a good idea of when you have been successful [18:32:45] so you could paste the link in, think you are done (because you can see the new citation on the page) and click away, which cancels the process [18:32:52] inspector means pointing to the location in context? [18:33:20] and dialogue means a more modal overlay, correct? [18:33:24] right, it's the popup with the triangle at the top, like we use for links [18:33:30] ok [18:33:33] dialogs can be modal [18:33:35] let me see where we are at [18:33:47] RoanKattouw: https://phabricator.wikimedia.org/T89788#1050267 [18:34:03] e.g. media inserter [18:34:29] (03Merged) 10jenkins-bot: Remove dialog from catchall menu [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/191621 (https://phabricator.wikimedia.org/T89555) (owner: 10Mvolz) [18:34:37] (03PS5) 10Bartosz Dziewoński: TextInputWidget: Fix appearance of icons and labels when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 (owner: 10Esanders) [18:34:41] (03CR) 10Bartosz Dziewoński: [C: 032] TextInputWidget: Fix appearance of icons and labels when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 (owner: 10Esanders) [18:34:47] ok, so I looked at the implementation, talked to Moriel and looked over the gerret comments [18:35:14] the design work that was done overlooks a lot of interaction issues [18:35:16] edsanders: I think the new design helps the user get a better sense of when its succesful [18:35:28] (03Merged) 10jenkins-bot: Separate out toolbar attachment in overridable method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191587 (owner: 10Esanders) [18:35:28] so, we really are making it up as we go along now that we are dealing with reality [18:35:34] (03CR) 10Jforrester: [C: 032] Prevent the default action for uncollapsed linear delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191632 (https://phabricator.wikimedia.org/T89933) (owner: 10Divec) [18:35:54] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Remove outdated offenses from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191627 (owner: 10Amire80) [18:36:00] TrevorParscal: great I'd like to keep working with you guys on the implementation [18:36:40] is the latest on wmf labs? [18:36:42] first off, the design calls for the reference to be visible (as in, already inserted) before the user has entered anything (re: https://www.mediawiki.org/wiki/VisualEditor/Design/Reference_Dialog#mediaviewer/File:Magic_cite-02.png ) [18:37:15] kaity: no, there's a patch that's in progress that's been per the design, and now we are running into problems completing it because the design is incomplete [18:37:19] and incorrect [18:37:26] (03Merged) 10jenkins-bot: TextInputWidget: Fix appearance of icons and labels when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/190473 (owner: 10Esanders) [18:37:41] so... anyway - the reference is inserted immediately, even though it's just an empty placeholder [18:37:54] 3VisualEditor, VisualEditor-MediaWiki, VisualEditor-Performance, Parsoid: Log Parsoid server-side save performance - https://phabricator.wikimedia.org/T66171#1050443 (10Jdforrester-WMF) [18:38:00] if the user clicks away, what should happen? currently it removes the reference [18:38:29] this is confusing [18:38:32] 3VisualEditor: Remainder of heading irrecoverably removed after deleting part of it - https://phabricator.wikimedia.org/T89972#1050447 (10Mvolz) [18:38:37] TrevorParscal: a design is never complete [18:38:44] please... [18:38:48] (03Merged) 10jenkins-bot: Prevent the default action for uncollapsed linear delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191632 (https://phabricator.wikimedia.org/T89933) (owner: 10Divec) [18:38:56] so let me know how I can help [18:38:57] we are implementing something, there's a time for it to be ready [18:39:52] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191627 (owner: 10Amire80) [18:40:45] the problem is that the non-modal inspector has interactions which are not being accounted for, such as the user clicking away before entering a url of a source (so the reference is still blank), the user clicking away after pasting a url of a source (during a lookup) [18:41:40] I think inserting the reference upon insert gives the user the impression that they've completed something [18:41:44] the pros of inspector are that it gives user a better sense of location and context [18:42:09] yeah, there's nothing wrong with using an inspector to insert something, we have other working cases of that [18:42:10] TrevorParscal: I remember we worked on that idea together [18:42:18] 3WikiLove, OOjs-UI, Possible-Tech-Projects: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#1050469 (10EBernhardson) p:5Triage>3Normal [18:42:45] We dont have to show the reference number right away [18:43:03] so, we either need to not insert a blank reference during insertion, or we need to leave it when the user clicks away [18:43:13] and I think we agree that the former is less confusing [18:43:29] I would suggest that when the user clicks away, you should act as it they clicked Done [18:43:41] Which means, if there's a URL, process it, if there's no URL, remove the ref [18:43:42] 3VisualEditor: Visual Editor: editing an existing internal link sometimes result in wrong link - https://phabricator.wikimedia.org/T86326#1050479 (10Aklapper) [18:43:43] 3VisualEditor-MediaWiki-Links, VisualEditor, VisualEditor-MediaWiki: VisualEditor: If a link that doesn't have a pipe is changed, the link target remains - https://phabricator.wikimedia.org/T59506#1050478 (10Aklapper) [18:43:44] 3VisualEditor: changing link -- ends up changing only link descritption - https://phabricator.wikimedia.org/T85337#1050480 (10Aklapper) [18:43:45] 3VisualEditor-MediaWiki-Links, VisualEditor-EditingTools, VisualEditor: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#1050481 (10Aklapper) [18:43:54] Same how a link is removed if you try to set its target to nothing [18:43:56] RoanKattouw: I agree [18:44:18] so, clicking away while a reference is being looked up [18:44:38] what if the response from the server is "I have nothing for that" or "that was an invalid query" [18:44:42] The only difference is that citoid takes a little while to process (unlike links) -- we could set that reference to "pending" while it's working, though [18:45:37] 3VisualEditor-MediaWiki-Links, VisualEditor-EditingTools, VisualEditor: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#641557 (10Aklapper) Merged in a bunch of duplicates. T63558 mig... [18:45:39] TrevorParscal, there's a "520" response now from citoid when there's no reply from the URL and we process it as a stripped basic citation [18:45:53] i think continuing the process when the user clicks away and inserting the reference in the cases where it worked and doing no insertion in cases where it did not is a mistake [18:46:05] mvolz, the case of failure without 520 -- how often would this happen? [18:46:06] You're right that there's no good way to do error handling [18:46:59] Because as far as I can see, even on failures of the URL, we still end up with *some* sort of reference [18:47:02] even if it's incomplete and basic [18:47:23] we have to stop special casing every single interaction - we have a design language already, inspectors are non-modal, if you are editing existing content then whatever you do is applied immediately, if you are inserting content then nothing will actually happen until you take deliberate action (clicking insert button) [18:48:02] when we make every single feature behave just a little differently, the user is always going to be surprised [18:48:42] TrevorParscal, but wouldn't this (staging and then popping/applying) be more similar to what we do with links ? [18:49:16] so, what I suggest is, do not stage reference insertions, abort all async operations when cancelling (or clicking away) and only insert something when the user clicks the insert button [18:49:25] From the user's perspective, we apply immediately when we add links. The same is happening in references, unless the user supplies no data (or bad data) in which case it vanishes --- same as links. [18:49:25] No? [18:49:39] use the link inspector to insert a link, like between 2 spaces [18:49:43] that's insertion mode [18:49:55] otherwise, it applies a link and then goes into editing mode [18:50:09] TrevorParscal: But in insertion mode, if you click away, it inserts the link [18:50:17] I don't know if that's the intended behavior, but that's what happens [18:51:35] hmm - looking at ve's handling of link and language inspector in insertion mode [18:52:05] (03CR) 10jenkins-bot: [V: 04-1] Use new SkinEditSectionLinks hook instead of DoEditSectionLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191658 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk) [18:52:07] (03CR) 10jenkins-bot: [V: 04-1] Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [18:52:07] I think Roan is right, that at least currently, even pressing esc or clicking away results in inserting the link or language [18:52:41] so, RoanKattouw, you are saying that if they've entered anything, the reference is inserted when the leave (by any means) [18:52:47] (should be, sorry) [18:53:02] RoanKattouw: I got worse so I'm staying home today and am not going to be terribly productive [18:53:20] ori: Not infecting team mates is productivity enough. [18:53:21] ori: No worries [18:53:24] and if it didn't resolve to a nice reference, then it will just be a blank reference containing the URL they pasted (or something similarly generic) [18:53:35] I was planning to spend today working on my backburner project anyway [18:53:46] thanks [18:53:50] TrevorParscal: I think that's one way to approach it [18:54:00] I don't think the current link inspector insertion behavior is very sensible [18:54:03] TrevorParscal, to be consistent with links i think that's a good behavior. I also think it's expected to the user, but I am not sure if I know enough to say that so generally. It's what *I* personally would expect. [18:54:08] But we either change that, or we follow it [18:54:19] it's not sensible [18:54:19] ok, so if that's the case, are we going to make the reference node pending while that async operation is occuring? [18:54:25] i think i filed at least one bug about it [18:54:26] ...maybe [18:54:30] Here's another option: [18:54:31] Since the rest of the inspectors behave this way [18:54:39] then imho it makes sense for citoid to as well [18:54:48] if we want to change the behavior in general that's a different issue. [18:54:52] We follow Kaity's design more closely and insert a reference without a number, just [] [18:55:01] i.e. something that indicates it's not real yet [18:55:20] Then if you close the inspector in any other manner than clicking Done, we just remove it and discard your URL [18:55:43] I think we should retain the info, honestly. Unless you click cancel. [18:56:19] staging the reference aside, what about the async-ness [18:56:34] if you paste a URL and leave, it's not yet editable because we haven't resolved it yet [18:56:36] it's pending [18:56:43] 3VisualEditor-EditingTools, VisualEditor: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1050552 (10KHammerstein) [18:56:45] Well if the only way to get async-ness is to click Done, you don't have this problem [18:57:09] Why not make the node pending until it's set? [18:57:12] then you basically agree with me then, that clicking away, even if you've entered something, means nothing gets inserted [18:57:25] mooeypoo: I'm suggesting that [18:59:56] (03CR) 10Mvolz: "The issue is that the user may not realize that clicking away will cancel the insertion process. Or they may just do it compulsively. Or t" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [19:00:45] 3VisualEditor-EditingTools, VisualEditor: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1050578 (10KHammerstein) [19:02:04] 3VisualEditor-EditingTools, VisualEditor: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#676536 (10KHammerstein) [19:04:14] (03PS2) 10Alex Monk: Use new SkinEditSectionLinks hook instead of DoEditSectionLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191658 (https://phabricator.wikimedia.org/T88027) [19:06:12] (03CR) 10jenkins-bot: [V: 04-1] Use new SkinEditSectionLinks hook instead of DoEditSectionLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191658 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk) [19:07:04] We can't return the cursor to the document until the pending state is resolved one way or another [19:07:42] wtf @ that failure [19:08:01] Is that because of MobileFrontend? [19:08:12] closing the inspector by clicking away must resolve the pending state immediately [19:09:01] otherwise the user could start typing and add content to the staging stack, and if the pending state was rejected their typing would be removed [19:09:36] MatmaRex, why do dropdown widgets and comboboxes look slightly different [19:09:56] the dropdown widget approach is considerably less hacky, can't we just use that for comboboxes? [19:10:15] 3MediaWiki-Page-editing: Enable microsurveys for long-term tracking of editing experience - https://phabricator.wikimedia.org/T89970#1050635 (10Aklapper) @Whatamidoing-WMF: Please feel free to fix the initial task description by clicking "Edit Task" :) [19:10:20] solves all the disabled state problems [19:10:56] edsanders: we probably can, it's just more code that no one was written yet [19:11:00] has* [19:11:28] MatmaRex, I'm only talking about CSS - from what I can see we just need to delete a few lines and it will work automatically [19:11:43] edsanders: you are right, we are trying to sort it out in a way that doesn't have that issue [19:11:57] we just lose the left border on the indicator [19:12:26] (03CR) 10Legoktm: [C: 04-1] "Need to update extension.json as well" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191658 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk) [19:12:40] TrevorParscal, what I did with the current (soon to be old) special character inserter is to stage a space and select that [19:12:53] it shows the insertion point but it is clear nothing has been inserted yet [19:12:56] legoktm: Any idea why https://gerrit.wikimedia.org/r/#/c/191511/ fails? [19:13:26] 00:50:29 exception 'ConfigException' with message 'GlobalVarConfig::get: undefined option: 'VisualEditorPluginModules'' in /mnt/jenkins-workspace/workspace/mwext-VisualEditor-qunit/src/includes/config/GlobalVarConfig.php:53 [19:13:51] you still have the problem of users thinking they can click away to finish, but that is unavoidable as long as inspectors aren't modal [19:14:04] (03CR) 10Legoktm: [C: 04-1] "Need to add "VisualEditorPluginModules" to "config"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191511 (owner: 10Jforrester) [19:14:08] legoktm: Oh, yeah, it doesn't include… [19:14:10] * James_F nods. [19:14:12] the alternative would be to make inspectors modalable(?) [19:14:25] edsanders: oh. well, yeah. i assumed that the border was wanted. we'd need to tweak some more things to make the actual dropdown look right, probably. [19:14:31] http://etherpad.wikimedia.org/p/ReferenceInspector [19:14:33] * optionally modular [19:14:48] because the click block is only semi transparent [19:14:53] but that's a pretty bold step [19:15:26] (03PS2) 10Jforrester: extension.json: Rebuild using maintenance/convertExtensionToRegistration.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191511 [19:15:39] MatmaRex, not really- it just changes the width to be full instead of up to the indicator [19:15:45] (03CR) 10Jforrester: "Done." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191511 (owner: 10Jforrester) [19:15:58] I can't see why you'd want the border on one but not t'other [19:16:21] 3OOjs-UI, VisualEditor: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1050667 (10Etonkovidova) Re-opening it - Firefox 35(on Mac) still have the issue - Template text input areas do display a vertical scroll bar for chunks of text before clicking Insert. Aft... [19:16:43] 3OOjs-UI, VisualEditor: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1050668 (10Etonkovidova) 5Resolved>3Open [19:17:37] (03Merged) 10jenkins-bot: [BrowserTest] Edited language screenshot steps which had iframe elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191655 (https://phabricator.wikimedia.org/T89370) (owner: 10Vikassy) [19:17:52] 3VisualEditor, VisualEditor-DataModel: [Regression?] VE corruption issue(?) moving pre-existing categories to the middle of the page - https://phabricator.wikimedia.org/T74048#1050680 (10Whatamidoing-WMF) Here's another: https://fr.wikipedia.org/w/index.php?title=Procès_de_Nuremberg&diff=111949556&oldid=1118451... [19:20:25] edsanders: to be honest, i don't really care what we change, as long as it looks sensible [19:21:35] 3VisualEditor: Don't add empty gallery tags - https://phabricator.wikimedia.org/T89978#1050709 (10Whatamidoing-WMF) 3NEW [19:21:45] (03PS1) 10Ori.livneh: Update ve.init.mw.trackSubscriber to emit 'wgVersion' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191672 [19:22:11] James_F: i was lazy [19:22:21] 3VisualEditor, VisualEditor-DataModel: [Regression?] VE corruption issue(?) moving pre-existing categories to the middle of the page - https://phabricator.wikimedia.org/T74048#1050723 (10Catrope) >>! In T74048#1050680, @Whatamidoing-WMF wrote: > Here's another: https://fr.wikipedia.org/w/index.php?title=Procès_... [19:24:36] 3VisualEditor, VisualEditor-MediaWiki-Media: License URLs in VisualEditor media insertion dialog are broken - https://phabricator.wikimedia.org/T89544#1050727 (10Etonkovidova) [19:26:10] ori: :-) [19:28:17] edsanders: RoanKattouw: kaity: mooeypoo: http://etherpad.wikimedia.org/p/ReferenceInspector [19:28:21] this is what I propose [19:30:28] MatmaRex, what's the difference between DropdownWidget and DropdownInputWidget !? [19:30:51] 3VisualEditor-MediaWiki-Links, VisualEditor-EditingTools, VisualEditor: VisualEditor: The link suggestor should suggest links from the current namespace ahead of named links - https://phabricator.wikimedia.org/T57390#1050747 (10Aklapper) [19:30:56] edsanders: the latter is an InputWidget and the former isn't [19:31:05] edsanders: meaning that you can stick it in a HTML
and submit it [19:31:20] hm [19:31:34] but they should look and behave the same? [19:31:36] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Search results (for links, redirects, categories…) should select the exact match by default - https://phabricator.wikimedia.org/T71716#1050754 (10Aklapper) [19:31:39] the former is a monstrous JS creature, also, so it's not available in PHP. the latter is, as a