[00:00:08] Yeah it kind of assumes that you can't save with no changes [00:00:16] Which is nonsense. [00:00:22] basically in some cases more than one of these options can apply [00:00:52] Yeah [00:00:59] You should ask James_F about those [00:05:54] (03PS1) 10Mooeypoo: Move toggle() from Widget to Element [oojs/ui] - 10https://gerrit.wikimedia.org/r/191817 [00:08:20] TrevorParscal: ---^^ [00:26:20] (03PS2) 10Mooeypoo: Move toggle() from Widget to Element [oojs/ui] - 10https://gerrit.wikimedia.org/r/191817 [00:35:50] (03CR) 10Bartosz Dziewoński: "Why?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191817 (owner: 10Mooeypoo) [00:42:29] (03CR) 10Mooeypoo: "So that we can toggle any element's visibility, like Fieldsets and FieldsetLayouts" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191817 (owner: 10Mooeypoo) [01:00:50] (03CR) 10Nuria: [WIP] Schema:Edit instrumentation (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk) [01:02:45] Krenair: Please let me know if I am totally off on the comments to your patch. I am not sure why some events are logged in from the client whereas others are logged in from the server, I *thought* in wikitext case we will be logging everything from server. [01:07:17] I think if we captured save attempts on the server we'd get stuff like VE as well [01:08:08] although actually we would get the session ID identifying wikieditor [01:08:13] so ok [01:09:13] for init though... [01:12:58] RoanKattouw [01:13:23] Did we talk about this? [01:20:43] RoanKattouw: MDN wiki profiles are localised. Apparently Krinkle has an account on Stackoverloop [01:20:58] https://developer.mozilla.org/nl/profiles/krinkle [01:20:59] :D [01:25:17] RoanKattouw, nuria: I think we did discuss this at some point [01:25:53] and put the editingStatsId in the url [01:26:28] Krenair: ok, let me see if i understand, in the server we cannot log "save" events cause we do not know what editor do they come from? [01:26:56] although actually we would get the session ID identifying wikieditor [01:26:56] so ok [01:27:42] Krenair: ok, so our approach is changing edit urls so they include the "editing sessionID" and persist all events using that, correct? [01:28:24] if we log init from the server we can just start using the session ID there [01:28:34] and have it persist via the hidden form field [01:29:04] Krenair: right [01:29:22] we'd still have ready and abort on the client obviously [01:29:56] krenair: abort is "abandoning page" or clicking "cancel"? [01:30:19] I have been working on the assumption it is both. [01:31:13] Krenair: ok, I thought cancel carried some server side action but if it does not then it must be logged by the client using the same identifier [01:31:29] that javascript can get from the form [01:31:44] ok, I get that now [01:32:01] 'Cancel' is just a link back to the article [01:32:15] The server side action it carries is viewing the page. [01:32:22] Which we're not going to be allowed to log. [01:32:41] Krenair: ok, that is why you have a listener on that link? [01:33:31] I have a listener on that link? [01:34:13] i mean " you will have a listener on the user having clicked the link" [01:34:23] so you can catch the "cancel" [01:34:37] or "abort" right? [01:35:45] I have a listener on the user leaving the page. [01:36:10] It cannot check what link they clicked from there, AFAIK [01:37:56] (03CR) 10Alex Monk: [C: 04-1] "some fundamental issues with this still" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk) [01:39:26] (03CR) 10Catrope: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191532 (owner: 10Jforrester) [01:41:38] nuria, oh! I remember now [01:42:09] Krenair: aham ... [01:42:15] action.init.mechanism [01:42:29] ? [01:42:48] (03PS2) 10Catrope: Add dependency on ext.ve.mw in ext.ve.mwreference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191788 [01:42:53] (03PS4) 10Catrope: Update VE core submodule to master (a7cd696) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191532 (owner: 10Jforrester) [01:43:30] I think we can do that from the server, actually. [01:43:30] So it might not have been that. [01:44:24] (03PS3) 10Catrope: Add dependency on ext.ve.mw in ext.ve.mwreference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191788 [01:44:26] (03PS5) 10Catrope: Update VE core submodule to master (a7cd696) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191532 (owner: 10Jforrester) [01:46:12] Krenair: wait .. what is " action.init.mechanism" [01:46:36] string - "click", "new", "url" [01:46:52] click: Editing has been initiated from an edit link [01:46:53] new: Editing has been initiated by clicking on redlink if type=page or new section link if type=section [01:46:57] url: Editing has been initiated by direct navigation." [01:46:59] according to the schema [01:52:12] (03CR) 10Jforrester: [C: 032] Add dependency on ext.ve.mw in ext.ve.mwreference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191788 (owner: 10Catrope) [01:52:38] RoanKattouw: is there a good reason to delay ve.init.mw.ViewPageTarget.setupToolbar until ve.init.Target.createSurface is done? Why don't we start setting up the toolbar earlier, during the dead time when VE is waiting for the API to respond? [01:52:55] ori: You need to talk to edsanders [01:53:07] He is working on something that sounded extremely similar to what you just said [01:53:15] edsanders: I need to talk with you! [01:53:21] ori: Also this is why you may want to attend our standups [01:53:59] I know, I should. I still have my Core meeting workload, which is why I've been a bit reluctant to commit. [01:54:11] (03Merged) 10jenkins-bot: Add dependency on ext.ve.mw in ext.ve.mwreference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191788 (owner: 10Catrope) [01:59:04] Krenair: the schema -seems to me- has a lot of client specific info that wikitext might have a hard time filling w/o adding specific js on client side [01:59:31] yes [01:59:42] Krenair: I would not try to fill that info in [01:59:48] I am not trying to [01:59:59] Krenair: rather i would assume some of those fields will be empty for wikitext data [02:00:13] Krenair: good [02:00:27] (03PS1) 10Bartosz Dziewoński: FormLayout: Allow adding child layouts via config [oojs/ui] - 10https://gerrit.wikimedia.org/r/191832 (https://phabricator.wikimedia.org/T89750) [02:00:29] (03PS1) 10Bartosz Dziewoński: Set proper spacing between interleaved FieldsetLayouts and FormLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/191833 [02:00:31] (03PS1) 10Bartosz Dziewoński: Unbreak form submission in JavaScript [oojs/ui] - 10https://gerrit.wikimedia.org/r/191834 [02:00:33] Krenair: cause putting more js in client just for that will be real ... sad [02:02:49] (03PS5) 10Alex Monk: Use new SkinEditSectionLinks hook instead of DoEditSectionLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191658 [02:03:02] (03PS6) 10Alex Monk: Use new SkinEditSectionLinks hook instead of DoEditSectionLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191658 [02:03:43] 3VisualEditor, VisualEditor-Performance: Stash VisualEditor edits using edit stash - https://phabricator.wikimedia.org/T90040#1051997 (10ori) 3NEW a:3aaron [02:04:25] (03PS6) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) [02:04:26] nuria, is that looking a bit better? [02:08:08] (03CR) 10Alex Monk: [WIP] Schema:Edit instrumentation (033 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk) [02:08:43] Krenair: /looking [02:13:53] nuria, you want secure random for the session id? [02:14:14] what library/function do you have in mind? [02:14:46] Krenair: more than "secure" , something w/o duplicates in a 100.000 range [02:14:54] Krenair: and there is alredy one [02:15:01] *already [02:15:04] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (a7cd696) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191532 (owner: 10Jforrester) [02:15:18] nuria, okay... where can I find it? :) [02:15:34] Krenair: let me find it, ori point me to it the other day [02:15:48] ah, MWCryptRand? [02:15:55] * Krenair just went digging around core for it [02:15:58] (03PS1) 10Catrope: Update VE core submodule to master (c65f3bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191836 [02:16:23] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/191532/ [02:16:25] (Rehi.) [02:17:18] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c65f3bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191836 (owner: 10Catrope) [02:17:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (a7cd696) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191532 (owner: 10Jforrester) [02:18:42] (03PS1) 10Catrope: Update VE core submodule to master (c65f3bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191838 [02:18:48] (03Abandoned) 10Catrope: Update VE core submodule to master (c65f3bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191836 (owner: 10Catrope) [02:20:38] Krenair: class MWCryptRand [02:20:49] ./includes/utils/MWCryptRand.php [02:21:16] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (c65f3bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191838 (owner: 10Catrope) [02:23:05] (03Merged) 10jenkins-bot: Update VE core submodule to master (c65f3bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191838 (owner: 10Catrope) [02:23:33] Krenair, MatmaRex: Shouldn't you go to sleep? :-) [02:23:53] wait.. where is Krenair based? [02:23:55] Europe? [02:24:02] sleep is for the weak [02:24:44] i woke up late, not feeling sleepy. this is within my standard operating hours. :) [02:25:25] James_F, haha :) [02:25:53] (03PS7) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) [02:26:08] nuria, UTC [02:26:08] nuria: Yeah, Krenair and MatmaRex are in .UK and .PL respectively. [02:26:14] James_F: whatttt? [02:26:22] Inorite. [02:26:28] 3OOjs-UI: Inconsistency in how child content is added to widgets - https://phabricator.wikimedia.org/T89750#1052188 (10matmarex) >>! In T89687#1044378, @cscott wrote: > @matmarex: grepping for serializeContent in my patch shows that FormLayout, PanelLayout, and DropdownInputWidget all require serializeContent.... [02:26:58] James_F: i was going to call it a day but now you guys have shame me ..... [02:27:05] :-D [02:27:16] nuria: No no, don't let their insanity bully you. :-) [02:27:40] James_F: You convinced me, CIAO!! [02:27:41] nuria: hey, i was late for my morning-evening standup. [02:27:44] :-D [02:28:17] 3OOjs-UI: Inconsistency in how child content is added to widgets - https://phabricator.wikimedia.org/T89750#1052190 (10matmarex) [02:28:42] the morning standup at 17:00, MatmaRex? [02:28:51] oh no, 19:00, hah [02:30:34] yeah. i didn't quite sleep in that late, but it was, uh, lunchtime? [02:30:59] (03CR) 10Bartosz Dziewoński: [C: 032] Element.php: Add "data" property [oojs/ui] - 10https://gerrit.wikimedia.org/r/191243 (owner: 10Cscott) [02:31:12] Tsk. [02:31:20] We're clearly bad influences. [02:32:14] (03CR) 10Bartosz Dziewoński: [C: 032] Element.php: Add "text" configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/191244 (owner: 10Cscott) [02:32:33] (03Merged) 10jenkins-bot: Element.php: Add "data" property [oojs/ui] - 10https://gerrit.wikimedia.org/r/191243 (owner: 10Cscott) [02:36:07] (03PS1) 10Bartosz Dziewoński: Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 [02:36:08] (03PS1) 10Bartosz Dziewoński: Prefer OO.isPlainObject to $.isPlainObject [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 [02:36:44] 3Community-Engagement, MediaWiki-Page-editing: Enable microsurveys for long-term tracking of editing experience - https://phabricator.wikimedia.org/T89970#1052201 (10Rdicerb) [02:37:23] (03CR) 10Jforrester: [C: 032] Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 (owner: 10Bartosz Dziewoński) [02:37:29] (03Merged) 10jenkins-bot: Element.php: Add "text" configuration option [oojs/ui] - 10https://gerrit.wikimedia.org/r/191244 (owner: 10Cscott) [02:39:46] (03CR) 10Jforrester: [C: 032] Prefer OO.isPlainObject to $.isPlainObject [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 (owner: 10Bartosz Dziewoński) [02:41:58] (03CR) 10jenkins-bot: [V: 04-1] Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 (owner: 10Bartosz Dziewoński) [02:42:00] (03CR) 10jenkins-bot: [V: 04-1] Prefer OO.isPlainObject to $.isPlainObject [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 (owner: 10Bartosz Dziewoński) [02:42:01] Eh. [02:42:25] (03PS2) 10Bartosz Dziewoński: Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 [02:42:38] (03PS2) 10Bartosz Dziewoński: Prefer OO.isPlainObject to $.isPlainObject [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 [02:54:29] ugh [02:54:32] OO.ui.Error = function OoUiElement( message, config ) { [02:55:37] (03PS1) 10Bartosz Dziewoński: Error: Fix function name [oojs/ui] - 10https://gerrit.wikimedia.org/r/191844 [02:56:02] (03CR) 10Jforrester: [C: 032] Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 (owner: 10Bartosz Dziewoński) [02:59:20] (03CR) 10Jforrester: [C: 032] Error: Fix function name [oojs/ui] - 10https://gerrit.wikimedia.org/r/191844 (owner: 10Bartosz Dziewoński) [03:03:29] (03CR) 10jenkins-bot: [V: 04-1] Error: Fix function name [oojs/ui] - 10https://gerrit.wikimedia.org/r/191844 (owner: 10Bartosz Dziewoński) [03:05:48] (03PS2) 10Bartosz Dziewoński: Allow passing positional parameters inside the config object [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) [03:07:12] (03CR) 10jenkins-bot: [V: 04-1] Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 (owner: 10Bartosz Dziewoński) [03:07:14] (03CR) 10jenkins-bot: [V: 04-1] Prefer OO.isPlainObject to $.isPlainObject [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 (owner: 10Bartosz Dziewoński) [03:10:50] (03PS3) 10Bartosz Dziewoński: Allow passing positional parameters inside the config object [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) [03:13:59] 3OOjs-UI: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1052221 (10matmarex) I scaled back the patch, and implemented the config-only approach as simply an alternativ... [03:18:47] (03CR) 10jenkins-bot: [V: 04-1] Allow passing positional parameters inside the config object [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński) [03:24:08] (03CR) 10Bartosz Dziewoński: "I'd be happy with an alias, too." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [07:57:27] (03CR) 10Ricordisamoa: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 (owner: 10Bartosz Dziewoński) [08:19:47] 3Community-Engagement, MediaWiki-Page-editing: Enable microsurveys for long-term tracking of editing experience - https://phabricator.wikimedia.org/T89970#1052454 (10Qgil) [08:46:37] (03PS1) 10Krinkle: build: Remove unused generateDocs.sh script [oojs/core] - 10https://gerrit.wikimedia.org/r/191856 [09:30:59] (03CR) 10QEDK: [C: 031] Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 (owner: 10Bartosz Dziewoński) [09:33:41] (03CR) 10QEDK: [C: 031] Use new SkinEditSectionLinks hook instead of DoEditSectionLink [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191658 (owner: 10Alex Monk) [09:35:10] (03CR) 10QEDK: [V: 04-1] [WIP] Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [09:35:21] (03CR) 10QEDK: [WIP] Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [10:30:52] 3MediaWiki-ResourceLoader: Evaluate folding msg_resource and msg_resource_links tables into objectcache - https://phabricator.wikimedia.org/T90001#1052653 (10Aklapper) p:5Triage>3Normal [11:29:02] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Remove outdated offenses from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191627 (owner: 10Amire80) [11:30:57] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Remove outdated offenses from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191627 (owner: 10Amire80) [11:35:24] (03CR) 10Mobrovac: [C: 031] "LGTM overall, a couple of minor comments in-lined." (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [11:38:46] (03PS1) 10Amire80: [BrowserTest] Remove extra empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191866 [11:39:31] (03PS2) 10Amire80: [BrowserTest] Remove outdated offenses from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191627 [11:41:20] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Remove extra empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191866 (owner: 10Amire80) [11:46:08] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191866 (owner: 10Amire80) [11:50:55] 3OOjs-UI: Include lib and dist into jsduck output directory - https://phabricator.wikimedia.org/T90120#1052925 (10Krinkle) 3NEW a:3Krinkle [11:51:05] (03CR) 10Krinkle: "This needs coordination with CI. The documentation is now containing examples that don't work. T90120." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190116 (owner: 10Catrope) [11:52:06] (03CR) 10Krinkle: [C: 032] [BrowserTest] Remove extra empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191866 (owner: 10Amire80) [11:53:49] (03Merged) 10jenkins-bot: [BrowserTest] Remove extra empty line to make Rubocop pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191866 (owner: 10Amire80) [11:53:58] (03Merged) 10jenkins-bot: [BrowserTest] Remove outdated offenses from .rubocop_todo.yml [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191627 (owner: 10Amire80) [12:04:39] ori, so yes - this is what I'm looking at - there are a few complications though [12:09:52] 1. the toolbar does need some sort of surface to attach to (without a big rewrite) as the surface stores which commands are available, and therefore what to show in the toolbar [12:10:10] this isn't a huge problem, as we can fairly cheaply construct a non-attached dummy surface and discard it later [12:12:39] 2. after ve core is loaded we load additional modules, as these files load they register themselves with the toolbar which automatically updates to show them. [12:13:17] of additional modules loads at the same speed or slower than the Parsoid HTML, so by the time we can show the toolbar, all we have left to do is run the HTML through the converter [12:14:05] although the converter can take a while on long pages it blocks the client synchronously making any animation we start before it freeze [12:14:20] the net effect being: on first load the toolbar doesn't appear much sooner [12:14:39] on second load it works beautifully though :/ [12:25:16] (03PS19) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [12:26:47] (03PS31) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [12:27:01] (03PS12) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 (https://phabricator.wikimedia.org/T37342) [12:39:22] (03CR) 10Paladox: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [13:07:02] (03CR) 10Fomafix: [C: 04-1] Convert .css to .less (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [13:27:24] (03CR) 10Krinkle: [C: 032] Error: Fix function name [oojs/ui] - 10https://gerrit.wikimedia.org/r/191844 (owner: 10Bartosz Dziewoński) [13:28:57] (03Merged) 10jenkins-bot: Error: Fix function name [oojs/ui] - 10https://gerrit.wikimedia.org/r/191844 (owner: 10Bartosz Dziewoński) [13:48:29] (03PS1) 10Krinkle: build: Use grunt-contrib-copy instead of custom 'copy' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/191876 [13:53:16] (03PS1) 10Esanders: Fix DropdownWidget and ComboboxWidget appearance [oojs/ui] - 10https://gerrit.wikimedia.org/r/191877 (https://phabricator.wikimedia.org/T87832) [13:58:46] (03CR) 10Bartosz Dziewoński: "Please synchronize with the PHP demo." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191877 (https://phabricator.wikimedia.org/T87832) (owner: 10Esanders) [14:06:14] ugh [14:06:37] i ran npm install to test out that build patch, and OBVIOUSLY everything is hosed now [14:16:30] (03CR) 10Bartosz Dziewoński: [C: 032] build: Use grunt-contrib-copy instead of custom 'copy' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/191876 (owner: 10Krinkle) [14:17:01] MatmaRex: Oops? [14:17:12] 3UI-Standardization, OOjs-UI: MediaWiki UI ComboBox design needed - https://phabricator.wikimedia.org/T87832#1053203 (10Aklapper) [14:17:14] Krinkle: no? [14:17:19] it works, so i +2'd [14:17:24] Oh, ok :) [14:17:26] fixed my local stuff already [14:17:39] (by deleting node_modules and trying again) [14:17:47] (03Merged) 10jenkins-bot: build: Use grunt-contrib-copy instead of custom 'copy' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/191876 (owner: 10Krinkle) [14:21:00] MatmaRex: Meh, grunt's file system is so weird (that part affected our custom copy as well). There's no easy way to just copy dir X into for Y [14:21:29] It has to be recursive and then strip [14:22:04] I think there's a way it's just a bit counter intuitive [14:22:38] There's a cnp package that mimicks cp -R [14:26:37] (03CR) 10Bartosz Dziewoński: [C: 04-1] "So by "unify" you mean "make entirely indistinguishable". I think that's a step backwards. These focus indicators especially should be onl" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191877 (https://phabricator.wikimedia.org/T87832) (owner: 10Esanders) [14:31:29] Krinkle: by the way. i'm thinking of hacking up something to make https://phabricator.wikimedia.org/T87724 happen (actually running the PHP/JS tests) [14:32:03] MatmaRex: Cool. [14:32:12] and the question is [14:32:48] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1053269 (10Paladox) Hi internet explorer does not support mask. please could you do the image without having to do mask thanks. [14:33:23] Krinkle: will it just work (on jenkins) if i write a grunt task (running as a part of the 'build' process) that would just shell out to ruby and php to generate some json files, that would then be loaded by the QUnit tests via ajax? [14:33:48] MatmaRex: I've got a comment in the works regarding .static.class. I'd like that to move ahead as well. I'll provide details there soon, but basically: copy static as direct members. And for back-compat inherit .static if it exists. We can migrate at whatever pace we feel comfortable. But we can start using it in the place we want to. [14:33:49] or is there something hopeless about this and i shouldn't waste time? [14:34:22] MatmaRex: Shelling out should work. Ajax loading might get tricky. [14:34:27] if there's no server, so we're on the file: protocol, then we probably can't ajax? [14:34:44] Actually, if using karma, you will be on a server. [14:34:50] in that case i could generate the index.htlm with JSON embedded, then [14:35:00] index.html is not used [14:35:06] well, whatever [14:35:16] No, it matter actually. [14:35:23] i could generate whatever it is, that is used by the real tests [14:35:33] that would have the ruby and php output embedded somehow [14:35:35] I've run into this before with Karma. It doesn't take static input. [14:35:46] It'd have to be a .js file or loaded over ajax indeed [14:35:58] Yeah [14:36:01] i could append it at the end of the oojs-ui.js, who cares [14:36:08] Yeah [14:36:40] 3Wikimedia-Hackathon-2015, Cite: Allow readers to mark a sentence/selection as needing a citation - https://phabricator.wikimedia.org/T89578#1053283 (10Qgil) p:5Triage>3Low [14:36:54] so, this isn't hopeless? i'll try to come up with something that works for me, and throw it to you if it doesn't work with our CI [14:37:01] a separate .text file even loaded by ajax as a pure string (if it's one string) or json payload as you see git [14:37:03] fit* [14:37:09] Sure [15:39:20] 3VisualEditor, VisualEditor-ContentEditable: Deleting and then typing text with any annotation, does not remove the style. - https://phabricator.wikimedia.org/T90155#1053504 (10Swainr) 3NEW [16:01:02] Hi. Sorry if I'm missing an obvious thing. Is there a way to have the visual editor enabled, but have the source editor as default? [16:03:09] 3UI-Standardization, OOjs-UI, Living-Style-Guide: Create a nonprocedural markup for OOJS-UI - https://phabricator.wikimedia.org/T88026#1053687 (10Aklapper) [16:04:39] (03CR) 10Jforrester: Add Grunt and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [16:07:49] xl0: yeah [16:08:02] english wikipedia uses that kind of setup, no? [16:09:10] actually, i think that's the default. you need to enable VE in your user preferences. [16:11:35] MatmaRex: as an enwiki user, that’s the behaviour there. Source by default, VE as option. [16:12:43] (03CR) 10Ricordisamoa: [C: 031] Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 (owner: 10Bartosz Dziewoński) [16:14:06] (03CR) 10Ricordisamoa: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 (owner: 10Bartosz Dziewoński) [16:25:01] (03CR) 10Mobrovac: Add Grunt and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [16:26:07] (03CR) 10Jforrester: [C: 032] Prefer OO.isPlainObject to $.isPlainObject [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 (owner: 10Bartosz Dziewoński) [16:26:16] (03CR) 10Jforrester: [C: 032] Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 (owner: 10Bartosz Dziewoński) [16:26:43] (03CR) 10Jforrester: [C: 031] Work around Safari 8 misrendering checkboxes in SVG-only distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/191633 (https://phabricator.wikimedia.org/T89309) (owner: 10Bartosz Dziewoński) [16:27:33] (03PS1) 10Bartosz Dziewoński: Element.php: Tweak docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/191897 [16:27:35] (03PS1) 10Bartosz Dziewoński: docparser.rb: Ruby 1.9.3 compatibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/191898 [16:27:57] (03CR) 10Jforrester: [C: 032] Element.php: Tweak docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/191897 (owner: 10Bartosz Dziewoński) [16:28:19] (03Merged) 10jenkins-bot: Remove '$: this.$' from code examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/191840 (owner: 10Bartosz Dziewoński) [16:28:24] (03CR) 10Jforrester: [C: 031] "Ruby's not really my thing…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191898 (owner: 10Bartosz Dziewoński) [16:32:19] (03CR) 10jenkins-bot: [V: 04-1] Prefer OO.isPlainObject to $.isPlainObject [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 (owner: 10Bartosz Dziewoński) [16:33:40] 3OOjs-UI: Remove deprecated `nofollow` config option - https://phabricator.wikimedia.org/T89767#1053956 (10Jdforrester-WMF) p:5Triage>3Low [16:33:45] (03PS1) 10Bartosz Dziewoński: [WIP] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 [16:34:22] 3UI-Standardization, OOjs-UI: MediaWiki UI ComboBox design needed - https://phabricator.wikimedia.org/T87832#1053969 (10Jdforrester-WMF) a:3Esanders [16:34:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (owner: 10Bartosz Dziewoński) [16:35:14] oh well. [16:35:32] Krinkle: can we get composer installer there? ^ [16:37:42] (03Merged) 10jenkins-bot: Element.php: Tweak docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/191897 (owner: 10Bartosz Dziewoński) [16:38:16] MatmaRex: should be possible but not trivial. mixing npm and composer macros mean we lose bash context (e.g. env doesn't persist). [16:38:39] if the composer-install works without any env vars and then npminstall/test can work, we should be able to do it. [16:39:09] i have no idea. i could probably reimplement that part of composer that we use in ten lines of PHP [16:39:10] MatmaRex: can you create a phab task? [16:39:25] so maybe i'll try that first instead [16:41:59] OK [16:42:56] 3MediaWiki-Page-editing, MediaWiki-API: Create + edit through API not properly rolled back during downtime - https://phabricator.wikimedia.org/T36903#1054034 (10Anomie) [16:43:29] 3MediaWiki-Page-editing, MediaWiki-API: Create + edit through API not properly rolled back during downtime - https://phabricator.wikimedia.org/T36903#402424 (10Anomie) The problem here seems unlikely to be in the API; rather, it's probably in the core page editing code itself. If it hasn't already been fixed in... [16:44:38] (03CR) 10Jforrester: [C: 032] Prefer OO.isPlainObject to $.isPlainObject [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 (owner: 10Bartosz Dziewoński) [16:45:53] (03Merged) 10jenkins-bot: Prefer OO.isPlainObject to $.isPlainObject [oojs/ui] - 10https://gerrit.wikimedia.org/r/191841 (owner: 10Bartosz Dziewoński) [16:46:25] 3MediaWiki-Page-editing: Edit conflicts (tracking) - https://phabricator.wikimedia.org/T72163#1054046 (10Anomie) [16:47:51] 3UI-Standardization, VisualEditor, MediaWiki-General-or-Unknown: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1054053 (10Ricordisamoa) You removed {#OOjs-UI} from T89815, but it is still not clear to me why this is tagged {#VisualEditor}. [16:49:33] 3UI-Standardization, VisualEditor, MediaWiki-General-or-Unknown: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1054057 (10Jdforrester-WMF) >>! In T89878#1054053, @Ricordisamoa wrote: > You removed {#OOjs-UI} from T89815, but it is still not clear to me why this is tagged... [16:51:17] (03PS2) 10Bartosz Dziewoński: [WIP] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) [16:52:11] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [16:52:18] ugh [16:52:22] that's spurious, i think [16:52:29] Looks it. [16:52:35] (03CR) 10Bartosz Dziewoński: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [16:52:50] esprima fails semi-frequently. [16:52:59] Yet another bloody npm issue. [16:53:34] why did the tests get all messed up again, anyway? they were pretty reliable for a while [16:53:37] MatmaRex Thanks. It seems to be the case actually. I looked at the wrong thing. [16:53:57] MatmaRex: Upstream libraries' upstream libraries' upstreams, I believe. [16:54:09] fun [16:54:14] MatmaRex: And/or race conditions between them. [16:54:25] we have almost 100 MB of node_modules, so yeah… [16:54:53] * MatmaRex watches the lines scroll [16:56:13] it is kind of silly that we run the build twice. [16:57:03] ha. it runs! [16:57:08] Success. [16:57:32] MatmaRex: npm install covers npm build; npm test also covers npm build, yeah. [16:57:46] Maybe we should do npm build-and-test somehow as a single run. [16:58:00] the tests don't pass, though (they do locally). [16:58:09] and the diagnostics are poop [16:58:10] 16:56:33 Chromium 40.0.2214 (Ubuntu) JSPHP ButtonWidget FAILED [16:58:10] 16:56:33 {"disabled":true} [16:58:10] 16:56:33 Expected: [object Object] [16:58:10] 16:56:33 Actual: [object Object] [17:01:14] (03PS32) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [17:02:25] 3WikiEditor: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1054089 (10Paladox) I have added the new image to the patch I have also updated the png version. [17:06:54] (03CR) 10Paladox: Convert .css to .less (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [17:10:30] (03PS20) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [17:19:07] (03PS30) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181790 [17:20:47] (03CR) 10Krinkle: Add Grunt and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [17:21:03] (03CR) 10Krinkle: Add Grunt and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [17:27:23] 3Continuous-Integration, OOjs-UI: Run the OOjs UI PHP test code on patchsets - https://phabricator.wikimedia.org/T87724#1054184 (10Aklapper) [17:30:34] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112001516 [17:30:34] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112005151 [17:30:34] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112005442 [17:30:34] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112017941 [17:30:34] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34374992 [17:35:27] (03PS3) 10Bartosz Dziewoński: [WIP] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) [17:44:20] (03PS1) 10Jforrester: Blacklist Safari versions 6 and below; whitelist 7+ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191914 [17:46:11] (03CR) 10jenkins-bot: [V: 04-1] Blacklist Safari versions 6 and below; whitelist 7+ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191914 (owner: 10Jforrester) [17:51:12] (03PS2) 10Jforrester: Blacklist Safari versions 6 and below; whitelist 7+ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191914 [17:54:48] (03CR) 10Jforrester: "PS2: It helps to commit all the changes in a commit…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191914 (owner: 10Jforrester) [18:00:21] (03CR) 10Bartosz Dziewoński: "It works! It's not very pretty, but it runs the tests, and they pass." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [18:18:35] (03CR) 10Jforrester: [C: 031] "Nice." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [18:22:06] 3OOjs-UI: Include lib and dist into jsduck output directory - https://phabricator.wikimedia.org/T90120#1054380 (10Catrope) Oops! It worked on my machine? :P [18:23:13] (03CR) 10Fomafix: Convert .css to .less (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [18:23:46] 3Continuous-Integration, OOjs-UI: Include lib and dist into OOjs UI's jsduck output directory so the documentation examples work - https://phabricator.wikimedia.org/T90120#1054394 (10Jdforrester-WMF) p:5Triage>3Normal [18:29:14] (03CR) 10Catrope: [C: 032] Blacklist Safari versions 6 and below; whitelist 7+ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191914 (owner: 10Jforrester) [18:29:25] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The karma test only runs the Apex theme, the standalone only runs MediaWiki. Both should run both." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [18:30:38] (03PS21) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [18:31:01] (03Merged) 10jenkins-bot: Blacklist Safari versions 6 and below; whitelist 7+ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191914 (owner: 10Jforrester) [18:37:46] 3VisualEditor: [Regression pre-wmf19] Getting error "Cannot read property 'addMessages' of undefined" while switching to edit source mode - https://phabricator.wikimedia.org/T90248#1054449 (10Ryasmeen) 3NEW [18:44:58] 3TemplateData, VisualEditor: Template Documentation Editor: Language label and Template description input field text should be aligned - https://phabricator.wikimedia.org/T90252#1054518 (10Etonkovidova) 3NEW a:3Mooeypoo [18:48:02] hmm Do we have an example of an inspector that expands in height? I need the inspector to grow after an action is taken [18:48:45] (03PS4) 10Bartosz Dziewoński: [WIP] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) [18:49:46] edsanders|away: ping when you're around [18:50:07] ori: Likely not for the rest of the day, per stand-up. [18:50:28] nod [18:51:12] (03PS5) 10Bartosz Dziewoński: Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) [18:51:21] (Sadly.) [18:52:16] Krinkle: okay, that runs and is pretty neat, if you ask me. the only thing bugging me is https://gerrit.wikimedia.org/r/#/c/191899/5/tests/QUnit.assert.equalDomElement.js [18:52:32] (03CR) 10Jforrester: [C: 031] "Nice work. Timo should probably +2." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [18:52:33] is there no way to get karma to produce sensible output by itself? [18:56:07] (03PS2) 10Bartosz Dziewoński: docparser.rb: Ruby 1.9.3 compatibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/191898 [18:56:11] (03PS3) 10Bartosz Dziewoński: docparser.rb: Ruby 1.9.3 compatibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/191898 [18:56:27] MatmaRex: Do we run Rubocop in OOjs UI? [18:56:33] yes [18:57:44] (03PS4) 10Bartosz Dziewoński: docparser.rb: Ruby 1.9.3 compatibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/191898 [18:57:47] Oh, yeah. [18:58:07] Should things that fix Ruby compatibility not change something so Rubocop validates it? [18:58:07] added some links to the commit message that could convince anyone of the correctness of the change. ;) [18:58:28] Is there a .rubocoprc or something? [18:58:40] .rubocop.yml [18:58:54] So why doesn't https://gerrit.wikimedia.org/r/191898 modify that file? [18:59:02] i don't think it has an option to check syntax for given ruby version [18:59:06] * James_F sighs. [18:59:08] Useful. [18:59:14] but who knows [19:00:01] James_F: per the long-standing tradition in the ruby community, it has pretty much no documentation [19:00:08] :-) [19:00:33] our .rubocop.yml mostly disables all of the options that i couldn't figure out how to configure [19:00:53] Aha, yes. [19:00:58] "ruby_version": "2.0.0", [19:01:00] Apparently. [19:01:00] or maybe it just, per another long-standing tradition, prioritizes convention over configuration [19:01:06] https://github.com/bbatsov/rubocop#json-formatter [19:09:31] 10VisualEditor, 10WikiEditor, 10Flow, 6§Collaboration-Team, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1054747 (10EBernhardson) [19:11:11] (03CR) 10Bartosz Dziewoński: [C: 04-1] Move toggle() from Widget to Element (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191817 (owner: 10Mooeypoo) [19:14:06] 10VisualEditor, 10WikiEditor, 10Flow, 6§Collaboration-Team, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1054792 (10Mattflaschen) [19:22:28] (03CR) 10Jforrester: [C: 032] docparser.rb: Ruby 1.9.3 compatibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/191898 (owner: 10Bartosz Dziewoński) [19:23:52] (03Merged) 10jenkins-bot: docparser.rb: Ruby 1.9.3 compatibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/191898 (owner: 10Bartosz Dziewoński) [19:24:22] (03CR) 10Jforrester: [C: 032] build: Remove unused generateDocs.sh script [oojs/core] - 10https://gerrit.wikimedia.org/r/191856 (owner: 10Krinkle) [19:32:17] ryasmeen: https://meta.wikimedia.org/wiki/Tech/News/2015/09?veaction=edit [19:32:47] Thanks James_F [19:33:18] (03CR) 10jenkins-bot: [V: 04-1] build: Remove unused generateDocs.sh script [oojs/core] - 10https://gerrit.wikimedia.org/r/191856 (owner: 10Krinkle) [19:33:46] (03CR) 10Jforrester: [C: 032] "Eurgh." [oojs/core] - 10https://gerrit.wikimedia.org/r/191856 (owner: 10Krinkle) [19:34:21] (03PS6) 10Jforrester: Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [19:39:54] (03Merged) 10jenkins-bot: build: Remove unused generateDocs.sh script [oojs/core] - 10https://gerrit.wikimedia.org/r/191856 (owner: 10Krinkle) [19:40:44] (03PS3) 10Mooeypoo: Move toggle() from Widget to Element [oojs/ui] - 10https://gerrit.wikimedia.org/r/191817 [20:01:51] (03CR) 10Bartosz Dziewoński: [C: 032] Move toggle() from Widget to Element [oojs/ui] - 10https://gerrit.wikimedia.org/r/191817 (owner: 10Mooeypoo) [20:07:57] (03Merged) 10jenkins-bot: Move toggle() from Widget to Element [oojs/ui] - 10https://gerrit.wikimedia.org/r/191817 (owner: 10Mooeypoo) [20:17:42] (03CR) 10Bartosz Dziewoński: [C: 04-1] PopupWidget: Add keydown listener and hide popup on ESC (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [20:18:13] (03PS1) 10Ori.livneh: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 [20:18:20] RoanKattouw_away, James_F|Away ^ [20:18:28] should stop negative timing measurements [20:20:06] (03CR) 10jenkins-bot: [V: 04-1] Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 (owner: 10Ori.livneh) [20:20:28] npm and karma failures, really? [20:39:51] ori: Code style violation. Not allowed multiple var statements in the same scope. [20:40:02] ori: And must do a newline between var assigments. [20:40:06] * James_F fixes. [20:41:28] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Actually, I think we should set the appropriate bigger margins on the label of inline fieldLayout, rather than by margin-right on the inpu" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191538 (owner: 10Krinkle) [20:44:28] (03PS2) 10Jforrester: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 (owner: 10Ori.livneh) [20:44:34] mooeypoo: that OOUI patch was the only thing you wanted me to look at, or is there something else? [20:46:02] James_F: you asked about comparings docs of PHP and JS OOUI, try running this in repo root: `ruby bin/doccomparer.rb src php JS PHP` [20:46:27] Nice. [20:46:28] it'll output a big chunk of text listing all differences [20:46:46] Yeah. [20:46:49] it's pretty stupid, though, and doesn't know about intentional differences between PHP and JS [20:47:02] Yeah. [20:47:11] if you come up with a sensible format of marking them up, i'll be happy to implement support [20:47:15] E.g. "Title text or a function that returns text. If not provided, the static property 'title' is used." vs. "Title. If not provided, the static property 'title' is used." [20:47:29] MatmaRex: I think that's beyond my pay grade; I leave such things to Krinkle. :-) [20:47:53] it's still useful. apparently, we have some typos in one version of TabIndexedElement. [20:49:24] (03CR) 10TheDJ: [C: 031] "I'm good with this. Seems to fix the problem reliably." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191633 (https://phabricator.wikimedia.org/T89309) (owner: 10Bartosz Dziewoński) [20:49:45] (03CR) 10Jforrester: [C: 032] Work around Safari 8 misrendering checkboxes in SVG-only distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/191633 (https://phabricator.wikimedia.org/T89309) (owner: 10Bartosz Dziewoński) [20:50:05] 10OOjs-UI, 4OOjs-UI-next-release, 10VisualEditor, 7Browser-Support-Apple-Safari, 4§ VisualEditor Q3 Blockers: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1055232 (10Jdforrester-WMF) 5Open>3Resolved [20:50:17] wow, so much color [20:50:39] MatmaRex: Wait, you don't strip colour from your IRC client? [20:50:41] How do you cope?! [20:51:08] James_F: so far out bots only used black and teal :) [20:51:12] our* [20:51:15] (03Merged) 10jenkins-bot: Work around Safari 8 misrendering checkboxes in SVG-only distribution [oojs/ui] - 10https://gerrit.wikimedia.org/r/191633 (https://phabricator.wikimedia.org/T89309) (owner: 10Bartosz Dziewoński) [20:51:41] IME over many years, colours are mostly used by IRC disrupters and spammers. [20:51:54] So I've got into the habit of them being disabled. [20:54:11] i rarely venture out of wikimedia channels, which are mostly populated by sensible people [20:54:39] (and also many have colors disabled on channel-level :D) [20:54:59] (channel-wide, rather) [20:55:27] I have it disabled at the source (my bouncer). [20:56:42] eh, gonna take a stab at the icon packs now. unless you happen to have something better for me to do [20:57:37] MatmaRex: Go go go! :-D [20:59:12] James_F, RoanKattouw_away: action.init.mechanism [20:59:25] "new" can mean two things [20:59:31] you could have both "url" and "new" [21:00:02] except I guess the bit about clicking for "new" [21:00:03] sigh [21:00:21] Krenair: Yeah. [21:00:40] ori: https://phabricator.wikimedia.org/T89656 [21:00:59] if there's no referrer, it's "url" [21:01:14] MatmaRex: same here: " i rarely venture out of wikimedia channels, which are mostly populated by sensible people" [21:01:15] otherwise, if section=new or the article does not exist, it's "new" [21:01:22] otherwise, it's "click" [21:01:29] I think. [21:01:40] Mostly. [21:02:40] (03PS8) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) [21:03:14] so... back to where I was before. abort.type [21:04:27] but no RoanKattouw, so [21:05:26] (03PS5) 10Bartosz Dziewoński: [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [21:07:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [21:09:47] well, isn't this lovely. [21:09:48] Rasterizing SVG to PNG (293 files)... [21:09:48] 0% [ [21:09:48] ] 0.00% (0.1s) Fatal error: spawn ENAMETOOLONG [21:11:02] MatmaRex: Ha. Fun. [21:12:04] apparently, a list of 293 files passed as JSON blob via command-line parameters is too much for windows. can't really blame it. [21:16:50] (03PS4) 10Jforrester: Add Grunt with jshint and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [21:21:42] 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 7I18n: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1055309 (10Umherirrender) a:3Umherirrender [21:25:30] (03PS5) 10Jforrester: Add Grunt with jshint and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [21:26:08] (03CR) 10Jforrester: Add Grunt with jshint and clean-up its errors (033 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [21:26:40] (03CR) 10Jforrester: "As you can see, now I've connected up CI to this, it doesn't pass. Closer, though!" [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [21:27:25] 10VisualEditor, 10Citoid, 6operations, 4§ VisualEditor Q3 Blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1055318 (10Jdforrester-WMF) 3NEW [21:28:26] 10VisualEditor, 10Citoid, 6operations, 4§ VisualEditor Q3 Blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1055332 (10Jdforrester-WMF) [21:28:33] 10VisualEditor, 10Citoid, 6operations, 4§ VisualEditor Q3 Blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1055318 (10Jdforrester-WMF) [21:28:42] ori: https://phabricator.wikimedia.org/T90281 is now a tracker for all this stuff. [21:29:00] cool, i just updated https://phabricator.wikimedia.org/T76308 [21:31:02] (03CR) 10Catrope: [C: 04-1] Fix ve.init.mw.trackSubscriber.js (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 (owner: 10Ori.livneh) [21:38:43] 10TemplateData, 10VisualEditor: Template Documentation Editor: Suggested, Required, Deprecated values cannot be unset - https://phabricator.wikimedia.org/T90283#1055374 (10Etonkovidova) 3NEW a:3Mooeypoo [21:39:24] (03PS1) 10Ori.livneh: ve#track: refactor callback calling convention [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191998 [21:39:30] RoanKattouw: ^ [21:42:44] (03CR) 10Catrope: [C: 04-1] ve#track: refactor callback calling convention (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191998 (owner: 10Ori.livneh) [21:43:44] (03PS2) 10Ori.livneh: ve#track: refactor callback calling convention [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191998 [21:44:43] Dear Internet Explorer [21:45:01] >>> d = document.createElement( 'div' ); d.setAttribute( 'width', '240px' ); d.getAttribute( 'width' ); [21:45:03] RoanKattouw: ReferenceError: document is not defined [21:45:03] 240px [21:45:17] > t= document.createElement( 'table' ); t.setAttribute( 'width', '240px' ); t.getAttribute( 'width' ); [21:45:18] 240 [21:45:21] COME ON [21:45:46] ori, ping [21:45:59] edsanders: hey, how's the move going? [21:46:14] not to bad - moved one bookcase so far [21:47:05] edsanders: I proposed to RoanKattouw yesterday that instead of sitting on our hands while waiting for the ApiVisualEditor response to complete that we should start drawing the toolbar. He mentioned you were working on something that sounded similar to that. [21:47:31] ori, so yes - this is what I'm looking at - there are a few complications though [21:47:31] * kaity is now known as kaity|away [21:47:32] 1. the toolbar does need some sort of surface to attach to (without a big rewrite) as the surface stores which commands are available, and therefore what to show in the toolbar [21:47:32] this isn't a huge problem, as we can fairly cheaply construct a non-attached dummy surface and discard it later [21:47:33] 2. after ve core is loaded we load additional modules, as these files load they register themselves with the toolbar which automatically updates to show them. [21:47:36] of additional modules loads at the same speed or slower than the Parsoid HTML, so by the time we can show the toolbar, all we have left to do is run the HTML through the converter [21:47:39] although the converter can take a while on long pages it blocks the client synchronously making any animation we start before it freeze [21:47:42] the net effect being: on first load the toolbar doesn't appear much sooner [21:47:46] oh, I missed this entirely. reading.. [21:49:41] so further to point 2, I started experimenting with disabling the toolFactor events on the dummy toolbar [21:49:43] edsanders: we can make the converter cooperative by yielding periodically [21:49:46] so it just shows a basic toolbar [21:49:58] setTimeout( continueConverting, 0 ); [21:50:30] ori: I've considered that [21:50:36] You'd have to refactor some stuff there though [21:50:40] I wish we had ES6 yield [21:51:02] let's keep ES6 yield for the 2025 Q1 release [21:51:05] ori, also the converter is usually less than the API request [21:51:10] The thing about ES6 yield is that its applicability is really narrow, and most of the interesting things people are doing with it is shoehorning it into promises [21:51:33] While the converter is like the *exact* thing that yield was designed for [21:51:35] you can have es6 yields right now.. if you are willing to run a tool: https://github.com/babel/babel [21:51:41] 10TemplateData, 10VisualEditor: Template Documentation Editor: layout suggestions - https://phabricator.wikimedia.org/T90286#1055418 (10Etonkovidova) 3NEW a:3Mooeypoo [21:51:51] even has source map support [21:52:22] if we did the basic toolbar thing this wouldn't be a problem [21:52:59] are you for doing that? [21:53:08] it would take me a while to find my way around that code [21:53:43] (03PS3) 10Ori.livneh: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 [21:54:17] i can experiment with making the converter cooperative [21:55:35] yeah - I'm working on the toolbar stuff [21:56:49] (03PS6) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [21:57:40] (03CR) 10jenkins-bot: [V: 04-1] Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 (owner: 10Ori.livneh) [22:00:42] (03PS4) 10Ori.livneh: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 [22:01:03] (03PS1) 10Catrope: Add 'width' and 'height' to the list of attributes corrupted by IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192003 [22:01:49] (03CR) 10Catrope: [C: 032] Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 (owner: 10Ori.livneh) [22:02:24] RoanKattouw: and https://gerrit.wikimedia.org/r/#/c/191998/ [22:02:30] (03CR) 10Catrope: [C: 032] ve#track: refactor callback calling convention [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191998 (owner: 10Ori.livneh) [22:02:33] thanks [22:03:25] (03CR) 10jenkins-bot: [V: 04-1] ve#track: refactor callback calling convention [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191998 (owner: 10Ori.livneh) [22:04:50] ori, RoanKattouw convert yielding would be nice for other reasons, i.e. showing a progress bar [22:05:16] (03Merged) 10jenkins-bot: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 (owner: 10Ori.livneh) [22:05:48] hey, is there a Wikicon help icon? I see ttps://commons.wikimedia.org/wiki/File:Sun_help.svg but I'm looking for the (?) in VE ('oo-ui-icon-help') [22:06:11] (03PS7) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [22:06:59] (03CR) 10Esanders: "Yes - I debated that. Without it the focus is very soft, but I can go the other way too." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191877 (https://phabricator.wikimedia.org/T87832) (owner: 10Esanders) [22:08:58] ah, it's projects/oojs/ui/dist/themes/mediawiki/images/icons/help.svg; is it on Commons somewhere? Maybe I can I refer to that image from a mw.org page. [22:09:59] yup, File:VisualEditor_-_Icon_-_Help.svg [22:11:43] (03PS2) 10Esanders: Fix DropdownWidget and ComboboxWidget appearance [oojs/ui] - 10https://gerrit.wikimedia.org/r/191877 (https://phabricator.wikimedia.org/T87832) [22:21:38] edsanders: Yeah, I asked Ori to experiment with a promised-base interface in the converter [22:22:04] For now we'll probably also want to keep a synchronous interface around though, because some callers aren't easy to convert to an async pattern [22:46:29] greg-g: Can we (by which I mean ori) get a deploy slot now for an EventLogging change for VisualEditor? [22:47:35] (03PS1) 10Jforrester: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192011 [22:47:43] (03PS2) 10Jforrester: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192011 [22:48:03] another one? [22:48:09] what up? [22:48:26] greg-g: Fixing the timing data to not have negative numbers. :-) [22:48:32] greg-g: Seems like a bonus. [22:48:52] "we're so fast we give you the data before you even requested it!" [22:48:55] sure, doit [22:49:33] Kk. [22:49:43] ori: Want to do the honours or should I grab someone else? [22:49:55] i can do it [22:49:57] thanks [22:50:00] Cool. [22:50:24] (03CR) 10Ori.livneh: [C: 032] Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192011 (owner: 10Jforrester) [22:50:25] (03PS1) 10Jforrester: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/192012 [22:50:32] (03CR) 10GWicke: "In other projects mocha and mocha-jshint has worked well:" [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [22:51:11] (03CR) 10Ori.livneh: [C: 032] Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/192012 (owner: 10Jforrester) [22:52:56] (03Merged) 10jenkins-bot: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192011 (owner: 10Jforrester) [22:54:26] (03Merged) 10jenkins-bot: Fix ve.init.mw.trackSubscriber.js [extensions/VisualEditor] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/192012 (owner: 10Jforrester) [22:59:09] (03CR) 10Jforrester: [C: 032] "Oy." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192003 (owner: 10Catrope) [23:01:16] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1055606 (10GWicke) [23:04:20] (03Merged) 10jenkins-bot: Add 'width' and 'height' to the list of attributes corrupted by IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192003 (owner: 10Catrope) [23:14:09] 10VisualEditor: [Regression pre-wmf19] Cursoring is totally broken in Betalabs getting error: "ve.ui.CiteFromIDDiologTool is undefined" - https://phabricator.wikimedia.org/T90297#1055624 (10Ryasmeen) 3NEW [23:16:44] (03CR) 10Catrope: "Caused https://phabricator.wikimedia.org/T90297 due to a typo" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/191621 (https://phabricator.wikimedia.org/T89555) (owner: 10Mvolz) [23:17:54] (03PS1) 10Catrope: Fix JS error caused by typo [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/192020 (https://phabricator.wikimedia.org/T90297) [23:18:11] 10VisualEditor: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1055666 (10KHammerstein) 3NEW [23:18:20] (03CR) 10Jforrester: [C: 04-1] "I liked the distinction between these two too." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191877 (https://phabricator.wikimedia.org/T87832) (owner: 10Esanders) [23:18:35] (03CR) 10Jforrester: [C: 032] "Spillung!" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/192020 (https://phabricator.wikimedia.org/T90297) (owner: 10Catrope) [23:18:43] (03Merged) 10jenkins-bot: Fix JS error caused by typo [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/192020 (https://phabricator.wikimedia.org/T90297) (owner: 10Catrope) [23:18:57] James_F: I just created a task to move media to the top-level toolbar [23:19:02] 10VisualEditor, 10Citoid, 4WMF-deploy-2015-02-25_(1.25wmf19): [Regression pre-wmf19] Cursoring is totally broken in Betalabs getting error: "ve.ui.CiteFromIDDiologTool is undefined" - https://phabricator.wikimedia.org/T90297#1055679 (10Jdforrester-WMF) 5Open>3Resolved a:3Catrope [23:19:08] kaity: Cool. [23:19:25] James_F: I know we have lots of other things to do, just wanted to record it as something we've talked about doing before! [23:19:53] James_F: I'm cool with editing or putting on the backlog, whatever you want to do [23:20:02] kaity: Absolutely. Do you think we should push for it in the 'release'? [23:20:13] kaity: If so, nominate it and we can discuss at the weekly triage. [23:21:24] James_F: Do you think its pretty simple technically? [23:22:50] kaity: Yeah, it's trivial technically, mostly it's a do-we-have-enough-design/product-time-to-test-and-iterate. [23:24:03] I'll discuss with design :) thanks! [23:24:08] Awesome. :-) [23:30:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 4§ VisualEditor Q3 Blockers: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1055707 (10Jdforrester-WMF) p:5Triage>3Normal [23:30:32] 10TemplateData: Template Documentation Editor: Suggested, Required, Deprecated values cannot be unset - https://phabricator.wikimedia.org/T90283#1055711 (10Jdforrester-WMF) [23:30:44] 10TemplateData: Template Documentation Editor: Language label and Template description input field text should be aligned - https://phabricator.wikimedia.org/T90252#1055713 (10Jdforrester-WMF) [23:31:01] 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, 4§ VisualEditor Q3 Blockers: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1055720 (10KHammerstein) [23:37:14] (03CR) 10Esanders: "They're unlikely to appear side by side ever so making the ever so slightly different is of little value. In Apex the combobox has a drop " [oojs/ui] - 10https://gerrit.wikimedia.org/r/191877 (https://phabricator.wikimedia.org/T87832) (owner: 10Esanders) [23:39:32] 10VisualEditor, 10VisualEditor-ContentEditable: Deleting and then typing text with any annotation, does not remove the style. - https://phabricator.wikimedia.org/T90155#1055739 (10Swainr) Screencast showing the behavior in test2 Chrome https://www.youtube.com/watch?v=vIXKHSyjDME. [23:40:50] 10VisualEditor, 10VisualEditor-ContentEditable: Typing,deleting and then again typing text with any annotation, does not remove the style. - https://phabricator.wikimedia.org/T90155#1055741 (10Swainr) [23:40:53] Oh no, the circus is in town (wikibugs) [23:42:06] Krinkle: Apparently it has lots of colours now. [23:42:59] 10VisualEditor, 10VisualEditor-ContentEditable: Annotated text: typing,deleting and then again typing it, does not remove the annotation. - https://phabricator.wikimedia.org/T90155#1055745 (10Swainr) [23:43:35] 10VisualEditor, 10Citoid, 4WMF-deploy-2015-02-25_(1.25wmf19): [Regression pre-wmf19]Getting error: "ve.ui.CiteFromIDDiologTool is undefined" while opening a page in Betalabs - https://phabricator.wikimedia.org/T90297#1055746 (10Ryasmeen) [23:43:45] 10VisualEditor, 10Citoid, 4WMF-deploy-2015-02-25_(1.25wmf19): [Regression pre-wmf19]Getting error: "ve.ui.CiteFromIDDiologTool is undefined" while opening a page in Betalabs - https://phabricator.wikimedia.org/T90297#1055624 (10Ryasmeen) Verified the fix in Betalabs [23:44:09] (03PS1) 10Jforrester: Move to wfUseMW for comptaibility detection [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192022 [23:44:12] (03PS1) 10Jforrester: Update author credits [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192023 [23:44:15] (03PS1) 10Jforrester: Convert to use extension registration [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192024 (https://phabricator.wikimedia.org/T87977) [23:44:39] The first patch made me go :( but now I'm :) [23:44:43] (03PS2) 10Jforrester: Move to wfUseMW for compatibility detection [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192022 [23:44:59] 10VisualEditor, 7Performance: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1055763 (10GWicke) 3NEW [23:45:15] legoktm: wfUseMW >>> $wgVersion execution inside Extension.php [23:47:13] (03CR) 10Legoktm: [C: 032] Move to wfUseMW for compatibility detection [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192022 (owner: 10Jforrester) [23:47:18] legoktm: Ta. [23:47:20] (03PS2) 10Legoktm: Update author credits [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192023 (owner: 10Jforrester) [23:47:32] (03CR) 10Legoktm: [C: 032] Update author credits [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192023 (owner: 10Jforrester) [23:47:35] :-) [23:47:39] (03PS2) 10Legoktm: Convert to use extension registration [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192024 (https://phabricator.wikimedia.org/T87977) (owner: 10Jforrester) [23:47:50] 10TemplateData: Convert TemplateData to use extension registration - https://phabricator.wikimedia.org/T87977#1055777 (10Jdforrester-WMF) a:3Jdforrester-WMF [23:48:07] (03Merged) 10jenkins-bot: Move to wfUseMW for compatibility detection [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192022 (owner: 10Jforrester) [23:48:12] 10TemplateData: Convert TemplateData to use extension registration - https://phabricator.wikimedia.org/T87977#1001809 (10Jdforrester-WMF) p:5Triage>3Normal [23:48:42] 10TemplateData: Add parameter for namespace of wiki-page-name type - https://phabricator.wikimedia.org/T88900#1055785 (10Jdforrester-WMF) p:5Triage>3Normal [23:49:51] James_F: the PHP file has $wgPageProps, but I don't see where that exists? [23:50:00] Oh, hmm. [23:50:13] the script doesn't either so it put it under "config" which is wrong [23:50:31] (change visibility) 00:09, 5 December 2010 Reedy (talk | contribs | block) deleted Manual:$wgPageProps (Deleted in r75282) (view/restore) [23:51:31] James_F: it was removed in 2010: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/r75282, so probably should be removed [23:51:55] Ha. Hmm. [23:52:32] 10VisualEditor, 7Performance, 4§ VisualEditor Q3 Blockers: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1055794 (10Catrope) [23:53:21] A Q3 blocker? :/ [23:53:58] (03Merged) 10jenkins-bot: Update author credits [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192023 (owner: 10Jforrester) [23:54:05] That's just a nomination :) [23:54:06] (03PS1) 10Jforrester: Kill reference to $wgPageProps [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192028 [23:55:03] Krenair: Work faster! ;-) [23:55:26] RoanKattouw: https://gerrit.wikimedia.org/r/192028 [23:55:42] (03CR) 10Catrope: [C: 032] Kill reference to $wgPageProps [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192028 (owner: 10Jforrester) [23:56:11] 10VisualEditor, 10VisualEditor-ContentEditable: Annotated text: typing,deleting and then again typing it, does not remove the annotation. - https://phabricator.wikimedia.org/T90155#1055802 (10Etonkovidova) https://www.youtube.com/watch?v=vIXKHSyjDME says it's private :( There are still some issues with typ... [23:56:14] (03Merged) 10jenkins-bot: Kill reference to $wgPageProps [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192028 (owner: 10Jforrester) [23:56:46] busy with college work :/ [23:56:57] 10VisualEditor: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1055804 (10Ryasmeen) 3NEW [23:58:11] (03PS1) 10Jforrester: Enable $wgTemplateDataUseGUI by default [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192030 [23:58:52] (03PS3) 10Jforrester: Convert to use extension registration [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192024 (https://phabricator.wikimedia.org/T87977) [23:58:56] Krenair: Good excuse. :-) [23:59:02] (03PS1) 10Catrope: Work around Firefox bug allowing cursor in cE=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192031 (https://phabricator.wikimedia.org/T70537)