[00:00:17] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Technical-Debt, 4§ VisualEditor Q3 Blockers: Reduce number of load.php calls on VisualEditor open (down from 3) - https://phabricator.wikimedia.org/T53569#1055818 (10Jdforrester-WMF) [00:00:44] (03CR) 10Jforrester: "(Already on for all wikis in WMF production.)" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192030 (owner: 10Jforrester) [00:01:29] Krinkle: What bugs are you working on now? https://phabricator.wikimedia.org/T53569 has your name all over it… [00:01:57] In the foreground: T89543 & T90120 [00:02:16] T90120 isn't a priority. [00:02:33] T89543 is, though. [00:02:59] 10VisualEditor: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1055819 (10Ryasmeen) {F44568} [00:03:52] 10VisualEditor: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1055821 (10Catrope) Cursoring off a focusable node is also broken in Firefox: the page scrolls all the way down, and a subsequent arrow key press puts the cursor at the start of... [00:04:28] (03CR) 10Mooeypoo: [C: 032] Enable $wgTemplateDataUseGUI by default [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192030 (owner: 10Jforrester) [00:05:00] (03Merged) 10jenkins-bot: Enable $wgTemplateDataUseGUI by default [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192030 (owner: 10Jforrester) [00:05:08] 10VisualEditor: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1055827 (10Ryasmeen) [00:08:06] 10VisualEditor: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1055832 (10Catrope) a:3dchan [00:08:33] (03PS1) 10Krinkle: build: Include 'lib' and 'dist' in jsduck output [oojs/ui] - 10https://gerrit.wikimedia.org/r/192034 (https://phabricator.wikimedia.org/T90120) [00:08:36] 10VisualEditor: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1055804 (10Catrope) p:5High>3Unbreak! [00:09:39] James_F: Aye, sorry. It does cross over with CI simplification though. And might function as showcase for how to do copying for other purposes (such as for demo). [00:10:05] I successfully switched our jsduck publication pipepine (the normal ones without examples per se) to run in labs and use the publisher proxy. [00:10:13] That means we now paved the way to publish anything. [00:10:50] Now publishing demos is a possibility, but not currently an immediate priority. But just FYI, it's become a lot simpler thanks to Hashar. [00:11:12] Krinkle: CI simplification also isn't a priority either. [00:11:27] Krinkle: I'm sure hashar's awesome. :-) However… [00:11:35] It means I have 3-5 hours a week more time for VE. [00:12:10] Not doing it at all would save more time for VE. ;-) [00:12:42] Okay :) – I finished that initial braindump. The path is there. ready to be taken when it's on the top. [00:12:53] Taking T89543 now [00:13:00] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 4§ VisualEditor Q3 Blockers: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1055840 (10Jdforrester-WMF) [00:13:08] Thanks. [00:13:35] Krinkle: What from https://phabricator.wikimedia.org/maniphest/?statuses=open,stalled&assigned=PHID-USER-sai77mtxmpqnm6pycyvz#R can I take off your plate? [00:14:38] ? Does phabricator not allow scrolling? [00:14:40] Weird.. [00:14:47] I can't scroll on that page for some reason [00:14:49] Krinkle: It does, but not over the left nav. [00:14:57] Krinkle: And yes, I bitched about this too. [00:15:03] Oh, I see. [00:15:04] Wow [00:15:09] Inorite. [00:15:12] Anyway, focus. [00:15:21] 10VisualEditor, 10VisualEditor-ContentEditable: Annotated text: typing,deleting and then again typing it, does not remove the annotation. - https://phabricator.wikimedia.org/T90155#1055842 (10Etonkovidova) In the attached screencast 1. I clicked on Tool menu - italic 2. started typing words - they are in... [00:16:19] James_F: https://phabricator.wikimedia.org/T89327 is no longer a high priority and has weird linux stuff attached to it, making it not a good use of my time. [00:16:37] Krinkle: How would you feel if I removed T90120, T89668, T89182 and T46364 from "Assigned" to you? [00:16:46] OK. [00:17:13] T90120 is fixed essentially, I pushed the patch 10 minutes ago [00:17:23] Ha. OK. [00:17:45] I'm fine with unassigning https://phabricator.wikimedia.org/T89668 [00:17:55] I'll review and merge if it works. [00:18:18] RoanKattouw / James_F: what's "responseUnknown" really? [00:18:34] T89182 as well. I created an unrelated commit that made Ed realise it didn't have tests. I can write them at some point. It's triaged as low. [00:18:51] and T46364 as well. Yeah. [00:18:53] Assigned == cookie licked; distraction; unhelpful. [00:18:54] OK. [00:18:55] i'm analyzing the total failure rate, and what we initially thought about edit conflicts causing that weekly trend is somewhat true, but it's MUCH more pronounced for "responseUnknown" [00:19:00] Yeah, I understand [00:19:08] Thanks [00:19:36] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance: VisualEditor "beta" appended label causes edit tab to flicker - https://phabricator.wikimedia.org/T89668#1055847 (10Jdforrester-WMF) a:5Krinkle>3None [00:19:37] 10VisualEditor, 7Technical-Debt: Test batchSplice polyfill - https://phabricator.wikimedia.org/T89182#1055848 (10Jdforrester-WMF) a:5Krinkle>3None [00:19:38] 10VisualEditor, 7Technical-Debt: VisualEditor: Clean up duplication of Mac/PC command/ctrl in all command registrars - https://phabricator.wikimedia.org/T46364#1055849 (10Jdforrester-WMF) a:5Krinkle>3None [00:20:03] 10MediaWiki-ResourceLoader, 10Librarization: Make ResourceLoader a standalone library - https://phabricator.wikimedia.org/T32956#1055850 (10Jdforrester-WMF) a:5Krinkle>3None [00:20:18] milimetric: We're not quite sure [00:20:32] milimetric: We should probably log some additional data so we can find out [00:20:58] RoanKattouw: if you'd like me to rush to show you real numbers, I can send you a TSV with the results [00:21:08] otherwise I'll keep trying to work out how to visualize it [00:21:22] I have failure rates by type by day for all wikis [00:21:25] Nice. [00:21:31] actually, here [00:21:43] https://www.irccloud.com/pastebin/44FPhp4b [00:22:42] James_F: psst, don't tell anyone, but gerritbot is no longer successfully adding #pathforreview to tasks. [00:22:46] you can see how response-unknown is almost 1/2 of all failures, and definitely follows that "lower on weekends + christmas + new year" trend [00:22:51] it still mentions the tag, but it's not added [00:22:53] Yay? [00:23:12] Krinkle: I noticed. It's a yay from me. [00:23:17] me2 [00:23:18] Krinkle: Sadly I think it's a bug they're fixing. :-( [00:27:09] (03CR) 10Legoktm: [C: 032] Convert to use extension registration [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192024 (https://phabricator.wikimedia.org/T87977) (owner: 10Jforrester) [00:27:42] (03Merged) 10jenkins-bot: Convert to use extension registration [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192024 (https://phabricator.wikimedia.org/T87977) (owner: 10Jforrester) [00:27:57] 10TemplateData: Convert TemplateData to use extension registration - https://phabricator.wikimedia.org/T87977#1055883 (10Jdforrester-WMF) 5Open>3Resolved [00:28:08] "The action you are taking has no effect: The task already has the selected status." [00:28:22] 10VisualEditor: [Regression pre-wmf19]Cannot open Reference List dialog, getting this error in the console "TypeError: this.node.getAttribute(...).body is undefined" - https://phabricator.wikimedia.org/T90309#1055885 (10Ryasmeen) 3NEW [00:28:33] 10VisualEditor: [Regression pre-wmf19]Cannot open Reference List dialog, getting this error in the console "TypeError: this.node.getAttribute(...).body is undefined" - https://phabricator.wikimedia.org/T90309#1055892 (10Ryasmeen) p:5Triage>3Unbreak! [00:29:39] Krinkle: i filed that bug. [00:31:48] legoktm: :-) [00:33:17] legoktm, what'd you try to do? [00:33:47] mark it resolved? [00:34:11] 10TemplateData: Template Documentation Editor: layout suggestions - https://phabricator.wikimedia.org/T90286#1055900 (10Jdforrester-WMF) [00:34:35] 10VisualEditor, 10VisualEditor-Performance, 4§ VisualEditor Q3 Blockers: Stash VisualEditor edits using edit stash - https://phabricator.wikimedia.org/T90040#1051997 (10Jdforrester-WMF) [00:34:57] Krenair: yup [00:35:04] 10VisualEditor, 10Parsoid, 7Blocked-on-Parsoid, 7Parsoid-DOM: [Regression] Automatically added reference lists do not have unique about attributes - https://phabricator.wikimedia.org/T90309#1055907 (10Catrope) [00:35:37] yeah James already did it [00:35:46] the one type of conflict detection phabricator *does* have [00:35:53] 10VisualEditor, 4WMF-deploy-2015-02-18_(1.25wmf18): Media Settings: search is not terminated- input box keeps displaying waiting animation - https://phabricator.wikimedia.org/T89303#1032970 (10Jdforrester-WMF) [00:35:54] and it's the useless type [00:36:37] (03PS6) 10Bartosz Dziewoński: [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [00:36:38] ^ i feel dirty [00:36:39] (03PS1) 10Bartosz Dziewoński: Fix typo: contian › contain [oojs/ui] - 10https://gerrit.wikimedia.org/r/192039 [00:36:54] (03PS2) 10Bartosz Dziewoński: Fix typo: contian → contain [oojs/ui] - 10https://gerrit.wikimedia.org/r/192039 [00:37:01] (03PS3) 10Bartosz Dziewoński: Fix typo: contian → contain [oojs/ui] - 10https://gerrit.wikimedia.org/r/192039 [00:37:35] Krenair: :-D [00:37:48] (03CR) 10Alex Monk: [C: 032] Fix typo: contian → contain [oojs/ui] - 10https://gerrit.wikimedia.org/r/192039 (owner: 10Bartosz Dziewoński) [00:37:57] MatmaRex: Looking. [00:38:16] (03CR) 10Bartosz Dziewoński: "Split 'em up. Build process now generates a ton of files with icons in them, and the demo loads them all. I feel that this is terribly bol" [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [00:38:28] 10VisualEditor, 10Parsoid, 7Blocked-on-Parsoid, 7Parsoid-DOM: [Regression] Automatically added reference lists do not have unique about attributes - https://phabricator.wikimedia.org/T90309#1055935 (10Catrope) This is caused by a bug in Parsoid. The page in question ( http://en.wikipedia.beta.wmflabs.org/... [00:39:06] James_F: also, about the icons. there is a "logOut", but no "logIn"? and "elipsis" is possibly a typo [00:39:14] MatmaRex: Inorite. [00:39:33] And yeah, ellipsis, you're right. [00:40:23] ori: I still get [Edit] Missing or empty schema in the console on test2wiki [00:42:07] (03CR) 10Jforrester: [C: 032] "Nicely done. Works on my machine. ;-)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192034 (https://phabricator.wikimedia.org/T90120) (owner: 10Krinkle) [00:42:34] 10OOjs-UI, 10Continuous-Integration: Include lib and dist into OOjs UI's jsduck output directory so the documentation examples work - https://phabricator.wikimedia.org/T90120#1055942 (10Jdforrester-WMF) 5Open>3Resolved [00:42:39] 10VisualEditor, 10Parsoid, 7Blocked-on-Parsoid, 7Parsoid-DOM: [Regression] Automatically added reference lists do not have unique about attributes - https://phabricator.wikimedia.org/T90309#1055944 (10ssastry) a:3marcoil [00:43:04] 10OOjs-UI, 4OOjs-UI-next-release, 10Continuous-Integration, 4WMF-deploy-2015-02-25_(1.25wmf19): Include lib and dist into OOjs UI's jsduck output directory so the documentation examples work - https://phabricator.wikimedia.org/T90120#1052925 (10Jdforrester-WMF) [00:43:27] MatmaRex: I need to add some more icons Design sent me, too. [00:44:12] 10OOjs-UI, 5Patch-For-Review: Provide support for "icon packs" so that not all of the OOjs UI theme needs to be loaded at once for users - https://phabricator.wikimedia.org/T89686#1055947 (10matmarex) https://gerrit.wikimedia.org/r/#/c/188289/ [00:45:03] James_F: alright. it should be easy. adding new packs will be a bit tedious, though. [00:45:15] (will have to be repeated in several places) [00:45:16] MatmaRex: Something for me to do, not you. ;-) [00:45:19] * James_F nods. [00:46:40] (03Merged) 10jenkins-bot: Fix typo: contian → contain [oojs/ui] - 10https://gerrit.wikimedia.org/r/192039 (owner: 10Bartosz Dziewoński) [00:46:42] (03Merged) 10jenkins-bot: build: Include 'lib' and 'dist' in jsduck output [oojs/ui] - 10https://gerrit.wikimedia.org/r/192034 (https://phabricator.wikimedia.org/T90120) (owner: 10Krinkle) [00:47:26] (03PS7) 10Jforrester: [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 [00:47:37] (03CR) 10Jforrester: "Lovely work, thanks Bartosz." [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [00:47:42] (03PS8) 10Jforrester: [WIP] MediaWiki Theme: Add "WikiFont" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 [00:48:42] James_F: i also submitted https://github.com/dbushell/grunt-svg2png/pull/25 for the issue i ran into at the beginning. upstream doesn't look very responsive, though. :/ [00:48:44] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, 4§ VisualEditor Q3 Blockers: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#1055957 (10Catrope) This is a bug in the Parsoid serializer. Table syntax suppo... [00:49:11] MatmaRex: Fun. :-( [00:53:05] RoanKattouw: http://people.wikimedia.org/~ori/ve.svg (flamegraph for ApiVisualEditor) [00:53:06] (03PS3) 10Catrope: ve#track: refactor callback calling convention [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191998 (owner: 10Ori.livneh) [00:56:21] James_F: hmm, i accidentally made myself the "Author" of that commit. didn't mean to, can you --reset-author when you next update it? [00:56:31] MatmaRex: No worries. [00:58:12] 10VisualEditor, 10VisualEditor-ContentEditable, 4§ VisualEditor Q3 Blockers: [Regression wmf17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1055991 (10Ryasmeen) 5Open>3Resolved [00:59:00] 10VisualEditor, 10VisualEditor-ContentEditable, 4§ VisualEditor Q3 Blockers: [Regression wmf17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1049013 (10Ryasmeen) Verified the fix in Betalabs [00:59:41] ori, interesting. you don't happen to have the same data from before we moved to using VirtualRESTServiceClient do you? [01:06:17] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0, 7Verified-in-Phase2, 4§ VisualEditor Q3 Blockers: [Regression wmf17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1056034 (10Ryasmeen) [01:06:30] RoanKattouw / James_F: https://edit-analysis.wmflabs.org/adhoc.html#ve-failures.tsv [01:06:32] failures by type [01:06:45] milimetric: Ouch. Nice. [01:06:48] all wikis, since december 11 because earlier there's not enough data [01:07:01] James_F: this is a more naive way of looking at failure [01:07:11] The variance is dominated by response-unknown? [01:07:17] yes [01:07:25] Fascinating. [01:07:25] that's the main reason I rushed this graph :) [01:07:31] Yeah. [01:07:48] There's no obvious periodicity at all if you remove the response-unknown. [01:07:50] Wow. [01:08:01] well, it's there but it's more subtle for the other types [01:08:04] like look at conflict [01:08:10] you'll see it if you stare hard enough :) [01:08:19] but response unknown is definitely the thing to look at right away [01:08:22] Oh, right, yeah. [01:08:22] at least get more logging around it [01:08:29] cc RoanKattouw ;-) [01:08:58] you want to fix the responseUnknown stuff? [01:10:04] Krenair: no, I don't (have that data from pre-VirtualRESTServiceClient) [01:10:16] Krenair: that'd be lovely :) [01:10:41] and guys, sorry this is all still with static data ending at the end of January, we're working hard at making it re-compute daily [01:11:28] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0, 7Verified-in-Phase2: [Regression wmf17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1056035 (10Ryasmeen) [01:12:00] action.saveFailure.type's schema is broken in general [01:12:25] heh... uh... [01:12:48] if that's true Krenair, please let me know about anything else that's broken before I go and be fascinated by trends based on bad data [01:12:57] but for now I'm outta here, o/ have a nice weekend [01:14:44] action.abort.type is weird [01:16:23] RoanKattouw, Krenair: your input on wld be appreciated too [01:17:48] ori, this sounds similar to something I tried briefly when we spoke at the office [01:19:11] but more complete [01:19:18] and via context? :/ [01:19:20] 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1056040 (10Perhelion) >>! In T37342#1053269, @Paladox wrote: I have uploaded a new version (the "s" more away from pencil and without mask) [01:20:39] 10VisualEditor, 10Parsoid, 7Blocked-on-Parsoid, 7Parsoid-DOM: [Regression] Automatically added reference lists do not have unique about attributes - https://phabricator.wikimedia.org/T90309#1056053 (10ssastry) a:5marcoil>3ssastry [01:20:40] oh, some other people complained about the same thing [01:20:57] EducationProgram implements it's own context source? ...what? [01:21:32] Krenair: Don't start on EducationProgram. [01:21:36] Krenair: It's misery all the way down. [01:24:38] 10VisualEditor, 10VisualEditor-ContentEditable: Annotated text: typing,deleting and then again typing it, does not remove the annotation. - https://phabricator.wikimedia.org/T90155#1056060 (10Ryasmeen) 5Open>3Resolved [01:30:41] Oh oh, I'm in love with a new css transition [01:32:23] Krinkle: Down, boy. [01:55:03] (03PS7) 10Mooeypoo: [WIP] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) [01:55:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [01:59:05] (03PS8) 10Mooeypoo: [WIP] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) [01:59:18] (03PS9) 10Mooeypoo: [WIP] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) [01:59:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [02:04:23] (03PS1) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [02:04:51] James_F: I hope you like the new transition of the toolbar. It's quite smooth :) [02:05:39] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [02:07:01] (03PS2) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [02:07:28] I'm still looking into alternatives that also take the page content upwards at the same time. A bit tricky. [02:08:11] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [02:08:36] 02:07:32 Warning: Invalid argument: function: method 'efGatherExtensionSetup' not found in /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/Setup.php on line 671 [02:10:52] 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1056084 (10Paladox) Thank you for doing that. It is that another image had to have mask removed because it was not showing in internet explorer. but thanks fo... [02:16:20] Krinkle: Lovely. [02:18:08] (03PS9) 10Jforrester: MediaWiki Theme: Add "Wikicon" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 [02:18:38] (03CR) 10Jforrester: "PS9: More icons; most issues resolved." [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [02:18:55] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [02:19:28] Krinkle: "A transition would be justified here is avoid having the other content suddenly jump upwards.” [02:19:44] Krinkle: Do you mean "A transition would be justified here to avoid having the other content suddenly jump upwards."? [02:20:10] Yeah, wil include in next revision [02:21:31] Cool. [02:25:53] James_F: Is there some behaviour we do where in case of an uncaight exeption we refresh the page? [02:26:09] That's not us right? [02:27:39] Oh, right. I get it. [02:27:49] Clicking "Read" if there is an exception, preventDefault is not called. [02:27:57] So it reloads to read mode, as an anchor tag would [02:28:31] I was getting a strange bug where when going to read mode, all the vector page action dropdown items bulk out and swing back in , but it was really just a very fast reload [02:40:22] Krinkle: Yeah. [02:41:20] (03PS2) 10Jforrester: [PULL THROUGH] Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [02:43:07] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [02:44:58] (03PS1) 10Alex Monk: Don't try to route any events into schema.Edit if it's not actually installed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192049 (https://phabricator.wikimedia.org/T88667) [02:45:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Vagrant: Declare conditional dependency on WikimediaEvents, and don't try to use schema.Edit unless it's present - https://phabricator.wikimedia.org/T88667#1056099 (10Krenair) a:3Krenair [02:49:09] (03PS3) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [02:49:29] translate for the smooth in and out. max-height for the page flow [02:49:32] I think this works [02:49:36] well [02:50:07] * James_F nods. [02:50:26] Krinkle: How long does it take to make a pipeline voting? Do you need to spend 6 hours pushing Zuul patches? [02:50:44] James_F: Depends. Probably not [02:51:04] Krinkle: https://gerrit.wikimedia.org/r/#/c/191064/ is just a voting:false removal… [02:53:13] Krinkle: (And it's the only job in the repo…) [02:54:48] (03PS4) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [02:55:37] (03CR) 10Krinkle: "Fixed to work properly in Firefox and Safari as well." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [02:55:59] James_F: Oh thats an easy one [02:56:38] Krinkle: I was hoping so… ;-) [02:56:52] James_F: But ahm. The last commit didnt run npm at all [02:56:55] https://gerrit.wikimedia.org/r/#/c/192020/ [02:56:58] voting or non voting [02:57:22] Krinkle: Wrong repo. [02:57:27] Ah, i see [02:57:35] Krinkle: We're talking about mediawiki/services/citoid not mediawiki/extensions/Citoid. [02:57:43] Also, yes, they differ in capitalisation. Don't ask. [02:57:51] Yeah, I saw it just now [02:58:33] 7 minutes to merge, 2 minutes to deploy, 30 seconds to reload-conf Zuul [02:58:45] No compilation for zuul, only for jjb [02:59:23] Aha. Nice. [02:59:29] Thank you. :-) [03:06:01] James_F, I saw https://phabricator.wikimedia.org/T90304 [03:06:06] and https://rest.wikimedia.org/ [03:06:14] do you know why that just returns {"items":["en.wikipedia.org"]}? :| [03:06:58] Krenair: Yeah. ori and RoanKattouw are having fun. [03:12:27] hm: https://rest.wikimedia.org/en.wikipedia.org/v1/page/html/Wikipedia:Assume_good_faith [03:12:42] but for enwiki only? [03:20:50] 10VisualEditor, 10VisualEditor-DataModel, 4§ VisualEditor Q3 Blockers: VisualEditor: Comments in "unsafe" content locations are not displayed - https://phabricator.wikimedia.org/T73085#1056119 (10matmarex) Am I missing something obvious, or is this actually pretty simple? The logic for this behavior is in... [03:21:16] :D [03:23:24] Krenair: It's waiting on hardware build-out. [03:24:06] MatmaRex: Nice. [03:24:07] before we can start relying on it, ok. but only supporting enwiki right now? really? [03:24:36] Krenair: It's waiting for hardware to be able to cope with more than one wiki's worth of content. [03:25:06] In that case I'm surprised it can cope with enwiki. [03:25:19] Krenair: 200 GB << 3 TB. [03:25:42] Krenair: One wikis as a proof of concept… [03:26:42] That seems like the worse possible choice to start with if the issue is the amount of content [03:26:42] (03CR) 10Jforrester: "recheck" [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [03:27:01] (03CR) 10jenkins-bot: [V: 04-1] Add Grunt with jshint and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [03:27:53] RoanKattouw: [03:27:54] https://gerrit.wikimedia.org/r/#/c/192049/1/modules/ve-mw/init/ve.init.mw.trackSubscriber.js [03:28:02] Krenair: Eh. [03:28:06] Anyway. I'm going home. [03:28:14] Good night all. [03:28:21] Especially persons wot should be asleep. [03:28:23] :-P [03:28:36] :D [03:29:04] (03CR) 10Catrope: [C: 032] Don't try to route any events into schema.Edit if it's not actually installed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192049 (https://phabricator.wikimedia.org/T88667) (owner: 10Alex Monk) [03:30:47] (03Merged) 10jenkins-bot: Don't try to route any events into schema.Edit if it's not actually installed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192049 (https://phabricator.wikimedia.org/T88667) (owner: 10Alex Monk) [03:41:59] (03PS1) 10Bartosz Dziewoński: Generate CommentNodes more leniently [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192051 (https://phabricator.wikimedia.org/T73085) [03:47:31] (03CR) 10jenkins-bot: [V: 04-1] Generate CommentNodes more leniently [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192051 (https://phabricator.wikimedia.org/T73085) (owner: 10Bartosz Dziewoński) [03:48:15] 10VisualEditor, 10VisualEditor-DataModel, 5Patch-For-Review, 4§ VisualEditor Q3 Blockers: VisualEditor: Comments in "unsafe" content locations are not displayed - https://phabricator.wikimedia.org/T73085#773774 (10matmarex) The patch above correctly displays all six comments in the example from task desc... [03:58:41] (03PS1) 10Alex Monk: Move insert media button to top level toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) [03:59:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 4§ VisualEditor Q3 Blockers: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1056165 (10Krenair) a:3Krenair [04:02:03] (03PS2) 10Bartosz Dziewoński: Generate CommentNodes more leniently [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192051 (https://phabricator.wikimedia.org/T73085) [04:02:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review, 4§ VisualEditor Q3 Blockers: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1056168 (10Krenair) [04:02:23] 10VisualEditor, 10VisualEditor-DataModel, 5Patch-For-Review, 4§ VisualEditor Q3 Blockers: VisualEditor: Comments in "unsafe" content locations are not displayed - https://phabricator.wikimedia.org/T73085#1056169 (10matmarex) a:3matmarex [06:34:41] (03PS1) 10Krinkle: Build: Use jquery from npm instead of embedded in the repo [oojs/core] - 10https://gerrit.wikimedia.org/r/192063 [06:34:43] (03PS1) 10Krinkle: Build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/192064 [06:35:19] (03CR) 10jenkins-bot: [V: 04-1] Build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/192064 (owner: 10Krinkle) [06:37:05] (03PS2) 10Krinkle: Build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/192064 [06:37:07] (03PS2) 10Krinkle: Build: Use jquery from npm instead of embedded in the repo [oojs/core] - 10https://gerrit.wikimedia.org/r/192063 [09:30:14] (03CR) 10Esanders: PopupWidget: Add keydown listener and hide popup on ESC (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [09:39:28] 4OOjs-UI-0.7.0, 10Wikibugs: wikibugs test bug - https://phabricator.wikimedia.org/T1152#20004 (10valhallasw) [10:05:26] 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 7I18n, 5Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1056380 (10Umherirrender) [10:39:38] (03CR) 10Esanders: "This can actually be merged after the pull through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [10:47:15] (03PS3) 10Esanders: Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 [10:47:17] (03PS1) 10Esanders: Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) [10:49:01] (03CR) 10jenkins-bot: [V: 04-1] Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [10:49:53] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 4§ VisualEditor Q3 Blockers: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1056399 (10dchan) It looks like this broke at ecdb3793f0870bc4f36de0e636f6ed79879e0... [10:51:11] (03CR) 10jenkins-bot: [V: 04-1] Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [10:57:16] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-LabeledSectionTransclusion, 5Patch-For-Review: Create a VisualEditor plugin tool to add/edit LabelledSectionTransclusion markers - https://phabricator.wikimedia.org/T72581#1056403 (10marcoil) [11:04:39] (03CR) 10Zfilipin: "Do you know how to proceed, or do you need help? Did your question get answered at QA mailing list?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [11:40:43] (03CR) 10Krinkle: [C: 04-1] "Menus from the toolbar are cut off due to overflow hidden." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [12:45:26] 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1056482 (10Paladox) Hi could you please do what you did with the image your uploaded and do it to this one https://git.wikimedia.org/blob/mediawiki%2Fextensio... [12:45:34] 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1056483 (10Paladox) Thanks. [12:48:13] (03PS4) 10Esanders: Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 [12:48:15] (03PS2) 10Esanders: Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) [12:50:02] (03CR) 10jenkins-bot: [V: 04-1] Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [12:50:11] (03CR) 10jenkins-bot: [V: 04-1] Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [12:50:29] (03PS33) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [12:53:36] (03PS3) 10Esanders: Generate CommentNodes more leniently [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192051 (https://phabricator.wikimedia.org/T73085) (owner: 10Bartosz Dziewoński) [12:54:02] (03CR) 10Esanders: [C: 032] "Made comments in comments.html more descriptive." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192051 (https://phabricator.wikimedia.org/T73085) (owner: 10Bartosz Dziewoński) [12:57:19] (03Merged) 10jenkins-bot: Generate CommentNodes more leniently [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192051 (https://phabricator.wikimedia.org/T73085) (owner: 10Bartosz Dziewoński) [13:15:48] (03PS1) 10Krinkle: ve.ui.Toolbar: Add z-index to oo-ui-toolbar-bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192075 [13:18:43] (03PS1) 10Esanders: Fix old metadata tests to use actual metadata [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192076 [13:19:36] (03PS1) 10Divec: Fix unmodifiedness test in showSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192077 (https://phabricator.wikimedia.org/T90306) [13:26:55] (03CR) 10Krinkle: "fixme: This is yielding NaN." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 (owner: 10Ori.livneh) [13:30:03] (03CR) 10Krinkle: "Probably due to this.timeStamp no longer existing :) It's very easy to test these types of changes by simply adding these two lines to you" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 (owner: 10Ori.livneh) [13:40:09] (03PS2) 10Esanders: Test clipboard mode in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190849 [14:09:24] (03PS6) 10Mvolz: Add Grunt with jshint and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) [14:22:06] (03CR) 10Krinkle: "latedef is mitigated by either declaring functions in the right other (understandably not practical in this case since none of them are us" [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [14:22:12] (03CR) 10Mobrovac: [C: 031] "LGTM. Strange that this time jshint didn't report function declaration/usage problems. I concur with it though - better to place the decla" [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [14:29:54] (03PS5) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [14:31:01] (03CR) 10Krinkle: "It's not strange. The latedef option was removed in this last patch version by Marielle :)" [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [14:31:41] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [14:32:24] (03PS6) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [14:38:36] (03PS7) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [14:43:17] (03CR) 10Mvolz: "Yeah, I read the docs and they basically said it was *mostly* a readability issue;" [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [14:47:38] (03PS8) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [14:48:27] (03CR) 10Krinkle: "Fixed various typos, simplified implementation, documented the hell out of the weirdnesses encountered. Read for review :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [14:50:05] (03CR) 10Krinkle: "I agree. Let's resolve that later. One more quick note though." (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [14:51:13] (03CR) 10Krinkle: Add Grunt with jshint and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [14:54:28] (03CR) 10Krinkle: "The slideDown is already being eliminated by I30a7b69b77b8 which makes the page flow smoother as well." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [15:01:16] (03CR) 10Mvolz: Add Grunt with jshint and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [15:03:08] (03CR) 10Krinkle: Add Grunt with jshint and clean-up its errors (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [15:09:06] (03PS7) 10Mvolz: Add Grunt with jshint and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) [15:09:48] (03PS1) 10Krinkle: ve.init.mw.ViewPageTarget: Update toolbox on activated instead of active [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192079 [15:10:23] (03CR) 10Krinkle: [C: 032] Add Grunt with jshint and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [15:10:43] (03Merged) 10jenkins-bot: Add Grunt with jshint and clean-up its errors [services/citoid] - 10https://gerrit.wikimedia.org/r/191190 (https://phabricator.wikimedia.org/T89736) (owner: 10Mvolz) [15:18:03] (03PS1) 10Krinkle: ve.init.mw.ViewPageTarget: Avoid content shift due to #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192080 [15:19:58] (03PS1) 10Krinkle: mw.ViewPageTarget.init: Reduce duplication around getTarget() calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192081 [15:23:44] (03PS2) 10Krinkle: mw.ViewPageTarget.init: Reduce duplication around getTarget() calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192081 [15:27:09] (03CR) 10Bartosz Dziewoński: PopupWidget: Add keydown listener and hide popup on ESC (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [15:27:52] (03PS11) 10Mvolz: Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) [15:32:36] (03CR) 10Mvolz: "Taking this out of WIP. It's not complete in that we don't have complete coverage for all the different types of openGraph metadata vertic" [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) (owner: 10Mvolz) [15:44:08] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1056637 (10Krinkle) Personally, I favour prototypal inheritance using objects and makers (e.g. no classes, constructor prototypes, `new`, or `this` what... [16:38:43] (03CR) 10Krinkle: MediaWiki Theme: Drop unnecessary pseudo-element of CheckboxInputWidget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191538 (owner: 10Krinkle) [16:46:16] (03PS1) 10Mvolz: [WIP] Create CitoidRequest object [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 [16:50:11] (03PS2) 10Bartosz Dziewoński: MediaWiki Theme: Drop unnecessary pseudo-element of CheckboxInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/191538 (owner: 10Krinkle) [16:50:33] (03CR) 10Bartosz Dziewoński: [C: 032] "Okay then, baby steps. I'll submit a follow-up later today." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191538 (owner: 10Krinkle) [16:50:43] (03PS2) 10Bartosz Dziewoński: MediaWiki Theme: Drop unnecessary pseudo-element of RadioInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/191539 (owner: 10Krinkle) [16:50:57] (03CR) 10Bartosz Dziewoński: [C: 032] "I'll submit a follow-up later today to clean up the margins." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191539 (owner: 10Krinkle) [16:51:56] (03Merged) 10jenkins-bot: MediaWiki Theme: Drop unnecessary pseudo-element of CheckboxInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/191538 (owner: 10Krinkle) [16:54:04] (03Merged) 10jenkins-bot: MediaWiki Theme: Drop unnecessary pseudo-element of RadioInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/191539 (owner: 10Krinkle) [17:05:43] (03PS1) 10Krinkle: Correct jsduck documentation tags casing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192086 [17:23:30] (03PS1) 10Bartosz Dziewoński: MediaWiki theme: Simplify spacing of checkboxes/radios in FieldLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/192088 [17:23:34] Krinkle|detached: ^ [17:27:13] (03PS2) 10Bartosz Dziewoński: MediaWiki theme: Simplify spacing of checkboxes/radios in FieldLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/192088 [17:30:37] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12262999 [17:30:37] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12263019 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112044886 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112045227 [17:30:37] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112055608 [17:30:37] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=41383258 [17:30:38] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=41386980 [17:30:39] Corruption alert: visualeditor-needcheck on elwiki: https://el.wikipedia.org/?diff=5086545 [17:30:39] Corruption alert: visualeditor-needcheck on elwiki: https://el.wikipedia.org/?diff=5086547 [17:30:40] Corruption alert: visualeditor-needcheck on elwiki: https://el.wikipedia.org/?diff=5086560 [17:30:40] Corruption alert: visualeditor-needcheck on elwiki: https://el.wikipedia.org/?diff=5086573 [19:40:50] (03PS1) 10Bartosz Dziewoński: Add disabled RadioInputWidget to demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/192091 [19:40:52] (03PS1) 10Bartosz Dziewoński: RadioOptionWidget: Make disabling single options work [oojs/ui] - 10https://gerrit.wikimedia.org/r/192092 [19:45:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Vagrant, 4WMF-deploy-2015-02-25_(1.25wmf19): Declare conditional dependency on WikimediaEvents, and don't try to use schema.Edit unless it's present - https://phabricator.wikimedia.org/T88667#1056774 (10Jdforrester-WMF) 5Open>3Resolved [19:47:48] (03CR) 10Jforrester: "What's happening with this?" [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 (owner: 10Anishvisa) [19:51:43] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0, 7Verified-in-Phase2: [Regression wmf17] Content getting lost while deleting some part of a paragraph - https://phabricator.wikimedia.org/T89933#1056786 (10Jdforrester-WMF) [19:55:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10Quality-Assurance, 7I18n, 4WMF-deploy-2015-02-25_(1.25wmf19): Update language_screenshot test - https://phabricator.wikimedia.org/T89370#1056794 (10Jdforrester-WMF) [19:55:46] 10VisualEditor, 10VisualEditor-ContentEditable, 4WMF-deploy-2015-02-25_(1.25wmf19), 4§ VisualEditor Q3 Blockers: VisualEditor: Cannot go to the next line of an article after inserting a special character in a block slug and "TypeError: Inserted data is tr... - https://phabricator.wikimedia.org/T67873#1056795 [19:58:26] 10VisualEditor, 4§ VisualEditor Q3 Blockers, and 0 others: [Regression pre-wmf15] Switch to source editing while keeping changes is not retaining the edits - https://phabricator.wikimedia.org/T86562#1056797 (10Jdforrester-WMF) [19:58:54] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 10VisualEditor-CopyPaste, and 15 others: Create remaining VisualEditor projects and migrate "tracking" tasks into the relevant projects - https://phabricator.wikimedia.org/T75907#1056798 (10Jdforrester-WMF) [19:59:09] 10VisualEditor, and 0 others: VisualEditor Q3 Release Criteria - https://phabricator.wikimedia.org/T86867#1056799 (10Jdforrester-WMF) [19:59:32] 10OOjs-UI, 4OOjs-UI-next-release, 10VisualEditor, 7Browser-Support-Apple-Safari: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1056800 (10Jdforrester-WMF) [19:59:45] (03PS1) 10Ori.livneh: ve#resolveUrl: stop accepting string values for base [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192093 [20:02:32] 10VisualEditor, 10VisualEditor-ContentEditable, 4§ VisualEditor Q3 Blockers, and 0 others: VisualEditor: Change event reaction order - https://phabricator.wikimedia.org/T59290#1056812 (10Jdforrester-WMF) [20:02:58] (03CR) 10jenkins-bot: [V: 04-1] ve#resolveUrl: stop accepting string values for base [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192093 (owner: 10Ori.livneh) [20:03:49] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 7Browser-Support-Apple-Safari, 4§ VisualEditor Q3 Blockers, and 0 others: [Regression wmf14] Safari - 'Add template' is greyed out - https://phabricator.wikimedia.org/T86038#1056817 (10Jdforrester-WMF) [20:04:22] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, and 0 others: [Regression] Textboxes in template editor no longer expand automatically when it's opened - https://phabricator.wikimedia.org/T85689#1056818 (10Jdforrester-WMF) [20:07:37] 10VisualEditor, 10VisualEditor-CopyPaste, 4§ VisualEditor Q3 Blockers: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1056829 (10Jdforrester-WMF) [20:07:38] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Technical-Debt: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#1056830 (10Jdforrester-WMF) [20:11:32] 10VisualEditor: [Regression pre-wmf19] Getting error "Cannot read property 'addMessages' of undefined" while switching to edit source mode - https://phabricator.wikimedia.org/T90248#1056833 (10Jdforrester-WMF) I can't replicate this now; instead I'm getting plagued by the 500-error-from-Beta-Cluster-bits issue... [20:12:12] 10VisualEditor, 7Performance, 7Technical-Debt: Remove use of ve.indexOf - https://phabricator.wikimedia.org/T89905#1056837 (10Jdforrester-WMF) p:5Triage>3Low [20:12:33] 10VisualEditor, 10VisualEditor-Performance: Don't disable native object editing in IE and WebKit browsers - https://phabricator.wikimedia.org/T89928#1056838 (10Jdforrester-WMF) p:5Triage>3Normal [20:15:39] 10VisualEditor: Don't add empty gallery tags - https://phabricator.wikimedia.org/T89978#1056842 (10Jdforrester-WMF) 5Open>3Invalid a:3Jdforrester-WMF We already do this; if you try to add a gallery with no contents, or remove all the contents of an existing gallery, VisualEditor removes the gallery. This... [20:16:18] 10VisualEditor, 10MediaWiki-Vagrant: i18n strings broken in VisualEditor in Vagrant - https://phabricator.wikimedia.org/T89476#1056845 (10Jdforrester-WMF) 5Open>3Invalid a:3Jdforrester-WMF [20:19:36] James_F: could I persuade you to make https://phabricator.wikimedia.org/T88827 a Q3 blocker? [20:20:30] ori: Hmm. I can nominate it, I guess. [20:20:46] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 4§ VisualEditor Q3 Blockers: Parsoid should return the full srcset for high DPI devices - https://phabricator.wikimedia.org/T88827#1056848 (10Jdforrester-WMF) Nominating. [20:20:51] thanks [20:21:07] ori: Were you and RoanKattouw_away thinking that https://phabricator.wikimedia.org/T49344 would be a Q3 blocker? [20:22:24] I don't think so [20:23:05] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Technical-Debt: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#1056851 (10Jdforrester-WMF) [20:23:06] 10VisualEditor, 10VisualEditor-CopyPaste, 4§ VisualEditor Q3 Blockers: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1056850 (10Jdforrester-WMF) [20:23:09] OK. [20:25:42] 10TemplateData: TemplateData GUI does not add type - https://phabricator.wikimedia.org/T86922#1056854 (10Jdforrester-WMF) [20:27:43] 10OOjs-UI: OOjs UI: Make layouts semi-responsive - https://phabricator.wikimedia.org/T74840#1056861 (10Jdforrester-WMF) p:5High>3Normal [20:29:35] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 7Performance: Removing characters causes re-rendering of paragraph (causing spell-check to flicker) - https://phabricator.wikimedia.org/T89625#1056865 (10Jdforrester-WMF) I get no flicker in Chrome or Firefox. In Safari the mis... [20:31:20] MatmaRex: Grumble. [20:32:03] grumble grumble. [20:32:24] MatmaRex: Writing https://gerrit.wikimedia.org/r/#/c/192051/ without making sure it worked first is unhelpful. [20:32:51] MatmaRex: Because edsanders|away's merged it even though we know it breaks the user experience in VE-MW, you've made VE-core toxic and un-pullable. [20:32:59] James_F: are you saying it doesn't work? i tested it quite a bit. [20:33:22] MatmaRex: The number one request is for the situation in https://phabricator.wikimedia.org/T90321 to be handled correctly. [20:33:27] (including with mw, by injecting the new JS into live pages) [20:33:48] On pages with \n\n comments? [20:33:58] 'Cos that was the reason we didn't do this the first two times. [20:34:08] And unless Parsoid has magically fixed itself since… [20:34:14] James_F: i don't think that's a blocker, and that shouldn't happen often anyway [20:34:18] uhh [20:34:19] Dirty diffs and broken UX are no fun at all. [20:34:22] given wikitext likeL [20:34:25] like: [20:34:39] para1\n\npara2 [20:34:56] Parsoid gives

para1

\n

para2

[20:35:04] i think that's sensible [20:35:40] with my patch in VE, a generated wrapper paragraph is added around the comment; i think that's sensible too, since it gets removed on the way oyut [20:35:41] out* [20:36:03] Oh, yeah, we made recent changes to remove more generated paragraphs, didn't we? [20:36:06] Never mind then. [20:36:10] Hopefully it'll be OK. [20:36:31] i am fairly sure it works correctly, if it doesn't, do revert [20:36:50] * James_F nods. [20:36:54] * MatmaRex tests it some more [20:37:03] (03CR) 10Jforrester: [C: 032] Correct jsduck documentation tags casing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192086 (owner: 10Krinkle) [20:37:38] (03Merged) 10jenkins-bot: Correct jsduck documentation tags casing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/192086 (owner: 10Krinkle) [20:39:01] (03CR) 10Jforrester: "> They're unlikely to appear side by side ever so making the ever so slightly different is of little value." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191877 (https://phabricator.wikimedia.org/T87832) (owner: 10Esanders) [20:40:19] (03CR) 10Jforrester: "> This can actually be merged after the pull through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [20:43:13] (03CR) 10Jforrester: [C: 032] Build: Use jquery from npm instead of embedded in the repo [oojs/core] - 10https://gerrit.wikimedia.org/r/192063 (owner: 10Krinkle) [20:43:44] (03CR) 10Jforrester: [C: 032] Build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/192064 (owner: 10Krinkle) [20:43:53] (03CR) 10Mvolz: "I haven't written the tests that would use this yet, so I have been letting it languish, unfortunately." [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 (owner: 10Anishvisa) [20:48:54] (03CR) 10jenkins-bot: [V: 04-1] Build: Use jquery from npm instead of embedded in the repo [oojs/core] - 10https://gerrit.wikimedia.org/r/192063 (owner: 10Krinkle) [20:48:56] (03CR) 10jenkins-bot: [V: 04-1] Build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/192064 (owner: 10Krinkle) [20:49:19] (03CR) 10Jforrester: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/192063 (owner: 10Krinkle) [20:49:30] (03PS8) 10Anishvisa: Add IDs for tests for Citoid extension [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 [20:50:17] (03CR) 10Jforrester: "> I haven't written the tests that would use this yet, so I have been letting it languish, unfortunately." [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 (owner: 10Anishvisa) [20:52:16] (03CR) 10Jforrester: [C: 032] "OK, let's try again…" [oojs/core] - 10https://gerrit.wikimedia.org/r/192063 (owner: 10Krinkle) [20:54:34] (03Merged) 10jenkins-bot: Build: Use jquery from npm instead of embedded in the repo [oojs/core] - 10https://gerrit.wikimedia.org/r/192063 (owner: 10Krinkle) [20:57:26] (03Merged) 10jenkins-bot: Build: Update devDependencies [oojs/core] - 10https://gerrit.wikimedia.org/r/192064 (owner: 10Krinkle) [21:03:24] (03PS1) 10Catrope: Follow-up 9b582485: implement back compat for timeStamp correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192097 [21:04:29] (03CR) 10Jforrester: [C: 031] Follow-up 9b582485: implement back compat for timeStamp correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192097 (owner: 10Catrope) [21:05:35] MatmaRex, James_F: One of the issues IIRC was with comments in strange table locations [21:05:39] I'll have to test those cases [21:05:41] RoanKattouw: Yeah. [21:06:06] Although your childNodeTypes logic may protect against that [21:06:11]
Foo
etc. [21:06:26] James_F: Although the demo has this: https://gerrit.wikimedia.org/r/#/c/192051/3/demos/ve/pages/comments.html,unified [21:06:31] it does [21:06:44] Previously most of those comments were invisible, haven't checked how many are visible now [21:06:50] * James_F nods. [21:06:52] the ones inside table cells [21:07:13] Yeah. [21:07:18] It looks fine in VE-core. [21:07:26] it's not quite lenient enough, the comment at the beginning of the document (before table) doesn't display for some reason [21:07:26] My concern is about dirty-diffs/Parsoid compatibility. [21:07:47] MatmaRex: It's in a block slug position. Isn't that a fail case? [21:07:51] MatmaRex: Oooh I like your DM changes [21:07:58] isValidChildNodeType() was sorely needed [21:08:05] it's probably a bug in Converter itself, somewhere [21:08:10] Hmm. [21:08:18] but i'm not really keep on changing that myself [21:08:21] keen* [21:08:33] MatmaRex: It's possible that the context stack doesn't contain an entry for the top level [21:08:35] or something [21:08:54] (03CR) 10Jforrester: [C: 032] Fix old metadata tests to use actual metadata [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192076 (owner: 10Esanders) [21:09:28] (03CR) 10Jforrester: "Didn't we spend a huge amount of effort to remove every single use of z-index just a few months ago?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192075 (owner: 10Krinkle) [21:09:59] (03CR) 10Jforrester: Add some more tests for newFromDocumentInserton (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191561 (owner: 10Catrope) [21:10:24] (03PS2) 10Jforrester: Transaction#newFromDocumentInsertion: Add some more tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191561 (owner: 10Catrope) [21:10:50] RoanKattouw: Is https://gerrit.wikimedia.org/r/#/c/191561/ a WIP for you to add the tests asked for in T89943 or is it "good to go" and you'll follow up with yet more? [21:11:21] (03CR) 10jenkins-bot: [V: 04-1] Transaction#newFromDocumentInsertion: Add some more tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191561 (owner: 10Catrope) [21:11:40] * James_F sighs at CI. [21:11:42] (03CR) 10Catrope: [C: 04-1] mw.ViewPageTarget.init: Reduce duplication around getTarget() calls (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192081 (owner: 10Krinkle) [21:12:03] James_F: I kind of can't be bothered to add those tests [21:12:16] (03CR) 10Jforrester: [C: 04-1] "Per Trevor's suggestion." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [21:12:30] RoanKattouw: Can I add them if you tell me the issue? Or would it take too long? [21:12:31] Because DocumentSet, when I do get around to working on that, will make that code go away [21:12:38] "When". [21:12:39] :-P [21:12:50] (03Merged) 10jenkins-bot: Fix old metadata tests to use actual metadata [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192076 (owner: 10Esanders) [21:13:10] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191561 (owner: 10Catrope) [21:13:11] No not really. I can't be bothered because writing a proper test case is complicated and requires some changes in the way those tests are run [21:13:17] Ah, OK. [21:14:53] I mean I realize that's a bad excuse and I should feel bad and write those tests [21:14:56] :-) [21:15:00] But I've been putting that off [21:15:06] RoanKattouw: I've made it your Tuesday target for WFH. [21:15:41] When do I ever WFH? [21:15:57] RoanKattouw: When you need a room for an extended period? [21:16:03] RoanKattouw: Also, frankly, right now. ;-) [21:16:05] I suppose so [21:16:07] And yes :) [21:16:50] (03CR) 10Catrope: [C: 032] ve.init.mw.ViewPageTarget: Update toolbox on activated instead of active [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192079 (owner: 10Krinkle) [21:17:20] Hmm, "shiften" [21:17:26] That feels less wrong than it possibly should [21:17:32] RoanKattouw: Krinkle|detached's Germanic roots showing? [21:17:55] ;-) [21:18:20] I can accept "shiften" in a commit message [21:18:22] But not "edgcasees" [21:18:26] :-D [21:18:38] (03PS2) 10Catrope: ve.init.mw.ViewPageTarget: Avoid content shift due to #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192080 (owner: 10Krinkle) [21:18:41] (03Merged) 10jenkins-bot: ve.init.mw.ViewPageTarget: Update toolbox on activated instead of active [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192079 (owner: 10Krinkle) [21:18:44] (03CR) 10Catrope: [C: 032] ve.init.mw.ViewPageTarget: Avoid content shift due to #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192080 (owner: 10Krinkle) [21:18:48] What's not to like? It's clearly talking about Ed's G-Case of Spanish. [21:19:16] (03PS1) 10Jforrester: Update VE core submodule to master (bf202b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192101 [21:19:24] RoanKattouw: ^^^ Test that re. MW comments? [21:21:02] (03Merged) 10jenkins-bot: ve.init.mw.ViewPageTarget: Avoid content shift due to #contentSub [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192080 (owner: 10Krinkle) [21:26:52] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (bf202b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192101 (owner: 10Jforrester) [21:26:54] James_F: Will do that next after https://gerrit.wikimedia.org/r/#/c/192047 [21:27:05] * James_F nods. [21:27:21] Oh, test updates needed? [21:27:32] * James_F tsks MatmaRex. :-) [21:28:13] (03CR) 10Catrope: [C: 04-1] mw.ViewPageTarget: Remove JS animations from transformPage() (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [21:28:33] bah [21:28:59] MatmaRex: No biggie. [21:29:48] want me to fix? or are you on it? [21:30:04] I'm fiddling with changelogs; if you could fix I'd be grateful. [21:30:32] (03CR) 10Catrope: [C: 04-1] "It's used in the tests, in ve.dm.example.js:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192093 (owner: 10Ori.livneh) [21:33:08] sure [21:37:23] Wow, do I feel evil. [21:37:29] | text = '''This MediaWiki page documents {{#if:{{{softwarePage|}}}|[[{{{softwarePage}}}{{!}}{{{software|the software}}}]]|{{{software|the software}}}}}'s changelog''' {{#if:{{{version|}}}|for version{{{version}}}|for the most recent versions}}.{{#if:{{{archivePage|}}}|

For previous changelogs covering other versions, please see [[{{{archivePage}}}|the archives]].}} [21:37:39] I'm the reason we have to build VisualEditor. [21:37:42] I am the problem. [21:37:47] * James_F holds his head in his hands. [21:40:14] haha [21:44:05] (03PS2) 10Bartosz Dziewoński: Update VE core submodule to master (bf202b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192101 (owner: 10Jforrester) [21:45:06] RoanKattouw: https://www.mediawiki.org/wiki/VisualEditor/changelog/Archive/MediaWiki_1.20 – like? [21:46:04] James_F: Why are you showing my changelogs from 2012? [21:46:26] RoanKattouw: I was mostly talking about the template at the top. :-) [21:46:32] (03CR) 10Catrope: "There are a few visual problems with this change:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [21:46:43] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (bf202b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192101 (owner: 10Jforrester) [21:47:06] (03CR) 10Catrope: mw.ViewPageTarget: Remove JS animations from transformPage() (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [21:47:12] Right :) [21:47:24] |version = s released alongside MediaWiki 1.20 [21:47:25] eww [21:47:46] Yeah, but this lets me also have "| version = 0.7.0" for OOjs UI. [21:48:00] Once we're properly versioned in VE-MW we can have proper version names. ;-P [21:48:00] Does it not do version0.7.0 then? [21:48:07] Not with a space. ;-0 [21:48:15] But your VE usage has a space! [21:48:16] *nbsp space. [21:48:23] |version = s released [21:48:24] Right [21:48:25] What, me, a hack? [21:48:32] So |version =  0.7.0 [21:48:35] Yup. [21:48:55] (03PS9) 10Catrope: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [21:50:05] RoanKattouw: Also, I wrote those changelogs. [21:50:35] (03CR) 10Catrope: [C: 032] Fix unmodifiedness test in showSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192077 (https://phabricator.wikimedia.org/T90306) (owner: 10Divec) [21:51:04] (03PS3) 10Bartosz Dziewoński: Update VE core submodule to master (bf202b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192101 (owner: 10Jforrester) [21:51:20] (forgot to commit a typo fix, eh) [21:56:38] :-) [21:59:01] (03Merged) 10jenkins-bot: Fix unmodifiedness test in showSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192077 (https://phabricator.wikimedia.org/T90306) (owner: 10Divec) [21:59:09] (03CR) 10Catrope: [C: 032] Test clipboard mode in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190849 (owner: 10Esanders) [22:00:28] (03CR) 10Catrope: [C: 031] Move insert media button to top level toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) (owner: 10Alex Monk) [22:00:40] James_F: I +1ed https://gerrit.wikimedia.org/r/#/c/192052/ but you have the final say on that one [22:00:44] * James_F nods. [22:01:06] (03Merged) 10jenkins-bot: Test clipboard mode in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190849 (owner: 10Esanders) [22:01:18] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 4WMF-deploy-2015-02-25_(1.25wmf19), 4§ VisualEditor Q3 Blockers: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1056884 (10Jdforrester-WMF) 5Open>3Resolved [22:04:12] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (bf202b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192101 (owner: 10Jforrester) [22:04:38] Gosh. [22:05:47] (03PS5) 10Catrope: Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [22:12:42] (03CR) 10Catrope: "On second load this works nicely. On first load it suffers from similar transition issues to Timo's code." (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [22:13:48] (03CR) 10Jforrester: [C: 032] Transaction#newFromDocumentInsertion: Add some more tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191561 (owner: 10Catrope) [22:15:08] (03Merged) 10jenkins-bot: Update VE core submodule to master (bf202b6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192101 (owner: 10Jforrester) [22:23:59] (03PS2) 10Jforrester: Move insert media button to top level toolbar between cite and structure [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) (owner: 10Alex Monk) [22:24:43] (03CR) 10Jforrester: "PS: Move to between cite & structure groups, given the justification is asking for prominence." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) (owner: 10Alex Monk) [22:25:38] RoanKattouw: BTW, does visiting https://commons.wikimedia.org/wiki/File:VisualEditor-logo.svg in Chrome cause your browser tab to crash? [22:25:52] (03CR) 10jenkins-bot: [V: 04-1] Move insert media button to top level toolbar between cite and structure [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) (owner: 10Alex Monk) [22:25:57] No [22:26:00] (Another one like https://commons.wikimedia.org/wiki/File:Example.jpg that Timo found.) [22:26:09] Hmm. Maybe a Mac/Chrome issue only? [22:26:41] James_F: Do I need to view the actual SVG as well? [22:26:43] Or just load that URL? [22:26:51] RoanKattouw: Just the URL. Insta-crash here. [22:26:56] Oh [22:26:59] I can do either and it works fine [22:27:18] RoanKattouw: Incognito, normal session, additional profile, new start. All the same. [22:29:07] (03PS6) 10Catrope: Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [22:29:24] James_F: Both of them are dead for me. [22:29:36] Deskana: Mac Chrome or something else? [22:29:41] Mac Chrome indeed. [22:29:47] (03CR) 10Catrope: [C: 032] Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [22:29:49] Hmm. I blame Steve Jobs. [22:29:52] Clearly it's his fault. [22:30:06] Works in Firefox. [22:30:08] So yes, Steve Jobs. [22:30:09] Yeah. [22:30:40] Why is everyone working on a Saturday! [22:31:04] mvolz: Why are *you* working on a Saturday? ;-) [22:31:46] (03Merged) 10jenkins-bot: Use new attachToolbar method for attaching the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191662 (owner: 10Esanders) [22:32:12] * James_F grins. [22:32:14] We're all so dedicated. [22:32:27] That's us. [22:32:33] I'm the only one in the office, mind. [22:32:43] RoanKattouw and Deskana are just slacking off from home. ;-) [22:33:10] I'm always slacking off from home :) [22:33:30] It's kind of crazy how much code I've merged on this Saturday afternoon [22:33:36] What's crazier is that most of it was written today [22:33:43] RoanKattouw: :-) [22:33:58] RoanKattouw: Today for the people writing it, often, but not 'today' in SF terms. [22:34:23] It's almost like when you give people the flexibility to work when they want, they'll actually work at productive points for them and not just work 9-5! [22:34:39] Indeed. [22:34:54] But, please team, no death marches. :-) [22:36:20] (03CR) 10Jforrester: [C: 032] "IHateIE8 indeed. :-)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189162 (https://phabricator.wikimedia.org/T88875) (owner: 10Brion VIBBER) [22:36:28] (03Merged) 10jenkins-bot: Skip an old IE 8 bug workaround in WikiEditor on IE 11/Spartan [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189162 (https://phabricator.wikimedia.org/T88875) (owner: 10Brion VIBBER) [22:36:42] (03PS3) 10Catrope: Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [22:37:13] (03CR) 10Jforrester: [C: 031] Ask for whole revision when checking for existing TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191766 (owner: 10Mooeypoo) [22:37:26] (03CR) 10Catrope: "PS3: rebase" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [22:38:00] RoanKattouw: Inhertidoc indeed! [22:40:35] James_F, you're not sure about it? you nominated this task to be a q3 blocker [22:40:39] (03CR) 10Catrope: [C: 04-1] "Holding this up for now because Ed and Timo submitted commits with competing approaches to converting the toolbar animation to a CSS trans" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [22:40:56] (03CR) 10jenkins-bot: [V: 04-1] Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [22:40:59] Krenair: Kaity asked me to nominate it. [22:41:01] test failure is in Flow :/ [22:41:11] James_F, couldn't kaity do that? [22:41:25] Krenair: Mine is not to question why, mine is but to do an die. [22:55:09] 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1056912 (10Perhelion) >>! In T37342#1056482, @Paladox wrote: > Hi could you please do what you did with the image... Here is the icon without mask but same ef... [23:07:36] 10WikiEditor, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1056924 (10GOIII) T34184 **`WikiEditor: Replace $.client.profile().name === 'msie' with feature detection`** The above seems related... shou... [23:08:11] 10VisualEditor, 10VisualEditor-Performance: Incrementally parse and convert API response as data comes in - https://phabricator.wikimedia.org/T89930#1056926 (10Catrope) >>! In T89930#1050841, @Krinkle wrote: > Incrementally parsing HTML contents from a string inside JSON seems impractical indeed. I think we... [23:10:41] (03CR) 10Catrope: "It looks like the z-index issue is due to an undeclared dependency on https://gerrit.wikimedia.org/r/#/c/192075 in VE core. The other issu" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [23:23:03] (03PS9) 10Jforrester: Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) (owner: 10Esanders) [23:23:25] (03CR) 10Jforrester: [C: 031] "It's not good, but it's marginally better than the current situation. :-(" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) (owner: 10Esanders) [23:53:21] (03PS2) 10Ori.livneh: ve#resolveUrl: stop accepting string values for base [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192093