[00:52:57] (03CR) 10Nuria: [WIP] Schema:Edit instrumentation (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk) [02:14:06] 10MediaWiki-Page-editing, 6Community-Liaison: Enable microsurveys for long-term tracking of editing experience - https://phabricator.wikimedia.org/T89970#1057054 (10Whatamidoing-WMF) I'd be very happy to include "bounces", since we need to hear "this is awful, I couldn't figure out how to do anything!" or "th... [05:48:03] (03CR) 10Catrope: [C: 032] ve#resolveUrl: stop accepting string values for base [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192093 (owner: 10Ori.livneh) [05:52:37] (03Merged) 10jenkins-bot: ve#resolveUrl: stop accepting string values for base [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192093 (owner: 10Ori.livneh) [06:19:07] 10VisualEditor, 7Technical-Debt: Factor out code duplication in ve.ui.*Action tests - https://phabricator.wikimedia.org/T90370#1057120 (10Catrope) 3NEW [06:21:56] 10VisualEditor, 10VisualEditor-ContentEditable, 4§ VisualEditor Q3 Blockers: Scroll highlighted node into view - https://phabricator.wikimedia.org/T90371#1057129 (10Catrope) 3NEW [06:24:47] 10VisualEditor, 10VisualEditor-ContentEditable, 4§ VisualEditor Q3 Blockers: Scroll highlighted node into view - https://phabricator.wikimedia.org/T90371#1057137 (10Catrope) [06:27:27] 10VisualEditor, 10VisualEditor-Performance, 4§ VisualEditor Q3 Blockers: Send Parsoid API request immediately when user clicks edit - https://phabricator.wikimedia.org/T90372#1057139 (10Catrope) 3NEW a:3Catrope [06:28:37] 10VisualEditor, 10VisualEditor-Performance, 4§ VisualEditor Q3 Blockers: Send Parsoid API request immediately when user clicks edit - https://phabricator.wikimedia.org/T90372#1057147 (10Catrope) [06:31:24] 10VisualEditor, 10VisualEditor-Performance: Benchmark hot cache load times - https://phabricator.wikimedia.org/T90373#1057149 (10Catrope) 3NEW a:3ori [06:36:33] 10VisualEditor, 10VisualEditor-Performance, 4§ VisualEditor Q3 Blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1057157 (10Catrope) 3NEW a:3Catrope [06:38:07] 10VisualEditor, 10VisualEditor-Performance, 4§ VisualEditor Q3 Blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1057165 (10Catrope) [06:41:05] 10VisualEditor, 10VisualEditor-Performance, 4§ VisualEditor Q3 Blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1057167 (10Catrope) Blocked on RESTbase being fully deployed and reliable. We can't use `parsoid-lb.eqiad.wikimedia.org` for this in its current form... [06:41:41] 10VisualEditor, 10VisualEditor-Performance, 4§ VisualEditor Q3 Blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1057168 (10Catrope) [06:57:56] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 4§ VisualEditor Q3 Blockers: Incrementally build CE tree/DOM - https://phabricator.wikimedia.org/T90376#1057179 (10Catrope) 3NEW a:3ori [06:58:07] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 4§ VisualEditor Q3 Blockers: Incrementally build CE tree/DOM - https://phabricator.wikimedia.org/T90376#1057187 (10Catrope) [07:58:35] 10VisualEditor: tiny windows with scrollbars should be increased - https://phabricator.wikimedia.org/T90377#1057196 (10ThurnerRupert) 3NEW [08:01:49] 10VisualEditor: tiny windows with scrollbars should be increased - https://phabricator.wikimedia.org/T90377#1057203 (10ThurnerRupert) [08:02:30] 10VisualEditor: tiny windows with scrollbars should be increased - https://phabricator.wikimedia.org/T90377#1057196 (10ThurnerRupert) [08:04:43] 10VisualEditor: tiny windows with scrollbars should be increased - https://phabricator.wikimedia.org/T90377#1057206 (10ThurnerRupert) [08:06:21] 10VisualEditor: tiny windows with scrollbars should be increased - https://phabricator.wikimedia.org/T90377#1057196 (10ThurnerRupert) [09:06:49] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-Translate, 10Possible-Tech-Projects: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#1057222 (10Nemo_bis) >>! In T55974#1042621, @Qgil wrote: > If th... [09:55:17] 10VisualEditor: improve checked versions workflow - https://phabricator.wikimedia.org/T90380#1057256 (10ThurnerRupert) 3NEW [10:21:50] 10VisualEditor, 10VisualEditor-MediaWiki-Links: insert reference confusing enough to produce broken link - https://phabricator.wikimedia.org/T90379#1057273 (10TTO) [10:39:51] 10VisualEditor: improve checked versions workflow - https://phabricator.wikimedia.org/T90380#1057279 (10ThurnerRupert) [10:58:18] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-Translate: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#1057283 (10Qgil) [11:08:21] 10MediaWiki-Page-editing, 6Community-Liaison: Enable microsurveys for long-term tracking of editing experience - https://phabricator.wikimedia.org/T89970#1057291 (10Qgil) Is this a #possible-tech-projects suitable for #Google-Summer-of-Code-2015 or #Outreachy-round-10 ? [12:02:20] (03PS1) 10Krinkle: ButtonElement: Remove conditionals for 'this.$button' [oojs/ui] - 10https://gerrit.wikimedia.org/r/192182 [12:03:03] (03CR) 10Krinkle: "Why is access to $button conditional? Removal proposed in follow-up I308340d92b." [oojs/ui] - 10https://gerrit.wikimedia.org/r/157274 (owner: 10Trevor Parscal) [13:03:37] (03PS22) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [13:03:50] (03CR) 10Paladox: "@Fomafix please review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [13:04:10] (03PS34) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [13:04:24] (03PS13) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 (https://phabricator.wikimedia.org/T37342) [13:06:07] edsanders: Dropped for you as well ha? [13:06:17] This happens to me like once a day. Entire Sky connection gone. [13:06:32] You as well? [13:34:06] not that I noticed [13:46:59] 10VisualEditor, 10VisualEditor-ContentLanguage: Cursor not moving past "ग्र" and other multiple code-unit grapheme clusters on left arrow key press - https://phabricator.wikimedia.org/T53846#1057367 (10Siddhartha-Ghai) Seems to be fixed now, though probably needs to be tested extensively before closing. [13:56:58] 10OOjs-UI, 7Accessibility: RadioSelectWidget is not screenreader accessible - https://phabricator.wikimedia.org/T90386#1057378 (10TheDJ) 3NEW [13:58:43] (03PS1) 10TheDJ: ComboBox: Use combobox role [oojs/ui] - 10https://gerrit.wikimedia.org/r/192186 [14:06:27] (03CR) 10jenkins-bot: [V: 04-1] ComboBox: Use combobox role [oojs/ui] - 10https://gerrit.wikimedia.org/r/192186 (owner: 10TheDJ) [14:07:08] 10VisualEditor, 10VisualEditor-MediaWiki-Links: insert reference confusing enough to produce broken link - https://phabricator.wikimedia.org/T90379#1057386 (10GOIII) ``` lang=html [https://easa.europa.eu/system/files/dfu/Annexes%20to%20Regulation.pdf Annexes to the draft Commission Regulation on... [14:23:28] argh, I hate this [14:23:41] * mvolz took waaaay too long to debug a this issue [14:24:03] at least now i fully appreciate bind(). [14:37:50] (03PS2) 10Mvolz: [WIP] Create CitoidRequest object [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) [14:38:45] (03PS3) 10Mvolz: [WIP] Create CitoidRequest object [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) [14:39:44] (03PS4) 10Mvolz: [WIP] Create CitoidService object [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) [14:43:02] 10MediaWiki-Page-editing, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 7JavaScript, 5Patch-For-Review: Dynamically loading TimedMediaHandler for new content (preview) - https://phabricator.wikimedia.org/T74675#1057416 (10TheDJ) I've been experimenting more with this. Current problems. * Some... [14:48:03] (03PS5) 10Mvolz: Create CitoidService object [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) [15:30:52] (03PS3) 10Krinkle: mw.ViewPageTarget.init: Reduce duplication around getTarget() calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192081 [15:31:54] (03CR) 10Krinkle: mw.ViewPageTarget.init: Reduce duplication around getTarget() calls (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192081 (owner: 10Krinkle) [15:36:08] mvolz: You'll want to call .bind() on the passing end instead of the receiving end to separate the concerns about what the callback will be [15:36:23] In the current way it may make more sense to use .call() [15:36:38] e.g. callback( 'data', this.method.bind(this) ) [15:36:49] then the callback can call that callback without needing to know what it may need to be bound to [15:37:13] if you're using bind without passing the value elsewhere (e.g. stored in local variable and only used once) then .call() is more appropiate [15:37:41] runnerFunction.call(citoidService, id, opts, .. ); [15:38:22] but in this case I'd do the bind on the other side so this code can invoke runnerFunction() cleanly [15:42:07] (03PS1) 10Mvolz: [WIP] Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) [15:42:25] I'll try that [15:43:18] if this makes sense at all, how far down the chain does bind work? I'm having a lot of issues converting all these callbacks to OO :) [15:43:41] I'll have nested callbacks and none of them know what this is :( [15:57:28] mvolz: I'm not sure what you're asking. .bind() essentially creates a new function that is like: function wrapper() { return otherFunction.apply( context, arguments ); } [15:57:32] Krinkle: actually I don't think I understood what you said correctly- how do i bind on the passing end? do I add 'this' as a function inside the callback? [15:58:17] where .apply() calls a function with a specific (instead of implied) 'this' value and an arrray of arguments that is forwarded from the call that will be made [15:58:41] mvolz: so instead of saying doStuff( data, this.whenItsDone ) [15:58:54] and then doStuff doing this.whenItsDone.bind(), and call that [15:58:55] instead [15:59:03] doStuff( data, this.whenItsDone.bind( this ) ) [15:59:28] then doStuff can call the function you gave it (the result of bind) directly [15:59:57] mvolz: As for being down the chain, I presume you mean the nesting of inline callbacks? [16:00:33] That should not be affected by this, though to avoid confusion of which 'this' is where in the nesting, I generally recommend you don't use 'this' for that case. [16:00:36] I'll show an example [16:01:04] I'm still stuck on bind, hold on :) [16:02:30] Okay :) [16:11:11] mvolz: https://gist.github.com/Krinkle/27650f52ac3e2879d56a [16:11:15] Perhaps that helps? [16:17:28] okay, I got the bind on the passing end thing now :) [16:18:20] mvolz: basically, if the function is defined inline (e.g. you're writing the function in place of an argument as opposed to referring to another method), then .bind() is confusing and you're better off using a variable that is part of the access closure. [16:18:27] And when referring to other methods, bind them on the passing end. [16:18:55] yeah that makes sense [16:19:01] then as you work your way up [16:19:08] everything is bound correctly [16:19:18] Yep [16:20:09] mvolz: While things may be chained functionally, there are two ways to avoid a nesting visually in the code. One is to move out callbacks into separately declared functions referenced by name. Two is to use promise.then [16:20:19] (as shown in the first section of that example) [16:20:31] Both have their place. [16:20:38] depending on what it is you're doing [16:35:34] (03PS6) 10Mvolz: Create CitoidService object [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) [16:38:02] (03CR) 10Mvolz: "Did you mean to upload something new here? This is the same as the previous patch :)." [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 (owner: 10Anishvisa) [16:38:36] (03PS2) 10Mvolz: [WIP] Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) [17:30:36] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12275204 [17:30:36] Corruption alert: visualeditor-needcheck on cswiki: https://cs.wikipedia.org/?diff=12275217 [17:30:36] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13708918 [17:30:36] Corruption alert: visualeditor-needcheck on hewiki: https://he.wikipedia.org/?diff=16575674 [17:30:36] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68759443 [17:30:36] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68759745 [17:30:36] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68762129 [17:30:37] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70975488 [18:33:20] (03PS2) 10Ori.livneh: Follow-up 9b582485: implement back compat for timeStamp correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192097 (owner: 10Catrope) [18:33:28] (03CR) 10Ori.livneh: [C: 032] Follow-up 9b582485: implement back compat for timeStamp correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192097 (owner: 10Catrope) [18:35:09] (03Merged) 10jenkins-bot: Follow-up 9b582485: implement back compat for timeStamp correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192097 (owner: 10Catrope) [19:08:26] (03PS1) 10Bartosz Dziewoński: ve.ce.FocusableNode: Remove superfluous ve.ce.Surface#appendHighlights call [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192204 [20:39:02] (03PS1) 10Bartosz Dziewoński: ve.ce.FocusableNode: Ignore children of elements using CSS column-count in Chrome [VisualEditor/VisualEditor] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/192240 (https://phabricator.wikimedia.org/T52036) [20:39:26] (03PS1) 10Bartosz Dziewoński: ve.ce.FocusableNode: Ignore children of elements using CSS column-count in Chrome [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192241 (https://phabricator.wikimedia.org/T52036) [20:39:43] (03Abandoned) 10Bartosz Dziewoński: ve.ce.FocusableNode: Ignore children of elements using CSS column-count in Chrome [VisualEditor/VisualEditor] (wmf/1.25wmf17) - 10https://gerrit.wikimedia.org/r/192240 (https://phabricator.wikimedia.org/T52036) (owner: 10Bartosz Dziewoński) [21:29:41] (03PS1) 10Esanders: Add clipboard tests and fix transclusion clipboard logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192244 [21:31:32] (03CR) 10jenkins-bot: [V: 04-1] Add clipboard tests and fix transclusion clipboard logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192244 (owner: 10Esanders) [21:41:37] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget.init: Reduce duplication around getTarget() calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192081 (owner: 10Krinkle) [21:44:16] (03CR) 10Catrope: [C: 032] ve.ce.FocusableNode: Remove superfluous ve.ce.Surface#appendHighlights call [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192204 (owner: 10Bartosz Dziewoński) [21:44:38] (03Merged) 10jenkins-bot: mw.ViewPageTarget.init: Reduce duplication around getTarget() calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192081 (owner: 10Krinkle) [21:47:19] (03Merged) 10jenkins-bot: ve.ce.FocusableNode: Remove superfluous ve.ce.Surface#appendHighlights call [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192204 (owner: 10Bartosz Dziewoński) [21:50:18] (03CR) 10Anishvisa: "I was just fixing the commit message to abide by the guidelines." [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 (owner: 10Anishvisa) [22:07:28] 10TemplateData: TemplateData: Store TemplateData in its own namespace ("Template data:") with a JSON content type and associated to the Template: namespace - https://phabricator.wikimedia.org/T56140#1057988 (10He7d3r)