[01:40:50] 10VisualEditor, 10VisualEditor-DataModel, 5WMF-deploy-2015-02-18_(1.25wmf18), 5§ VisualEditor Q3 Blockers: class="wikitable wikitable" corrupted to class="wikitable" - https://phabricator.wikimedia.org/T88148#1058089 (10Verdy_p) I can't understand why a duplicate class name is acceptable. Of course you mus... [01:42:41] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1058090 (10Ryasmeen) Still getting this issue i... [01:42:53] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1058091 (10Ryasmeen) 5Resolved>3Open [01:53:34] (03PS1) 10Ori.livneh: Emit trace.init.{enter,exit} events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192256 [02:41:15] (03PS1) 10Catrope: Update VE core submodule to master (8434ab8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192259 [02:43:11] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (8434ab8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192259 (owner: 10Catrope) [03:19:47] (03PS2) 10Catrope: Add clipboard tests and fix transclusion clipboard logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192244 (owner: 10Esanders) [03:21:20] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1058110 (10Catrope) >>! In T90306#1058090, @Rya... [03:25:59] (03PS2) 10Catrope: Update VE core submodule to master (8434ab8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192259 [03:26:01] (03PS3) 10Catrope: Fix transclusion clipboard logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192244 (owner: 10Esanders) [03:31:51] (03CR) 10Catrope: [C: 032] Fix transclusion clipboard logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192244 (owner: 10Esanders) [03:33:12] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1058116 (10Catrope) I've fixed the failing test... [03:33:39] (03Merged) 10jenkins-bot: Fix transclusion clipboard logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192244 (owner: 10Esanders) [04:15:12] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (8434ab8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192259 (owner: 10Catrope) [04:17:08] (03Merged) 10jenkins-bot: Update VE core submodule to master (8434ab8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192259 (owner: 10Catrope) [04:22:10] (03CR) 10Catrope: "How is this different from trace.activate.{enter,exit}? activate.enter fires in the activate() method, right after init.enter, and activat" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192256 (owner: 10Ori.livneh) [04:43:36] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1058139 (10Ryasmeen) 5Open>3Resolved [04:43:54] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1055804 (10Ryasmeen) Verified the fix in Betalabs [05:58:21] (03PS1) 10Legoktm: composer.json: Add description field [oojs/ui] - 10https://gerrit.wikimedia.org/r/192271 [05:58:23] (03PS1) 10Legoktm: Add "composer test" command to lint PHP files and run phpcs [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 [06:26:03] (03Abandoned) 10Ori.livneh: Emit trace.init.{enter,exit} events [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192256 (owner: 10Ori.livneh) [07:21:55] 10VisualEditor, 10VisualEditor-Performance: Reconsider OO.getHash - https://phabricator.wikimedia.org/T90413#1058258 (10ori) 3NEW [08:46:27] (03PS10) 10Krinkle: mw.ViewPageTarget: Use CSS for toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [08:46:29] (03PS1) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192281 (https://phabricator.wikimedia.org/T89543) [08:51:24] (03PS1) 10Krinkle: mw.ViewPageTarget.init: Add missing 'return target' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192285 [08:51:52] (03CR) 10Krinkle: "This broke section edit links as the handler did not forward the return value. I had this fixed locally but forgot to include in the patch" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192081 (owner: 10Krinkle) [08:53:15] Krenair: Could you review quickfix https://gerrit.wikimedia.org/r/192285 ? [08:53:25] (good morning :) ) [09:08:44] (03PS2) 10Krinkle: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192281 (https://phabricator.wikimedia.org/T89543) [09:08:46] (03PS11) 10Krinkle: mw.ViewPageTarget: Use CSS for toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [09:10:46] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Use CSS for toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [09:12:13] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [09:15:30] (03CR) 10Krinkle: "@Roan: The up-then-down seems specific to Firefox and is now fixed I think." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [09:25:59] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: Initiating VisualEditor via "Edit" button Firefox scrolls to bottom of page - https://phabricator.wikimedia.org/T90420#1058373 (10Krinkle) [10:28:03] (03CR) 10Esanders: "The reason I was avoiding this approach is that it uses $.css (i.e. getComputedStyle) a whole bunch of times on every node in every templa" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192241 (https://phabricator.wikimedia.org/T52036) (owner: 10Bartosz Dziewoński) [10:36:54] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 5§ VisualEditor Q3 Blockers: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1058485 (10Pginer-WMF) For the option to create a red link, we may consider a language more related to the user action. So instead of "Page doe... [10:50:05] (03PS1) 10Krinkle: mw.ViewPageTarget: Use CSS for toolbar transition (alt) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192292 (https://phabricator.wikimedia.org/T89543) [10:53:53] (03CR) 10Krinkle: "I've got an alternative patch (I40eec27ea014) that puts the transform on the entire target. That removes the need to keep content and tool" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [11:26:06] (03PS1) 10Amire80: [BrowserTest] Remove upload.rb - it's fully replaced with the gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192293 [11:27:49] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Remove upload.rb - it's fully replaced with the gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192293 (owner: 10Amire80) [11:27:55] (03PS2) 10Amire80: [BrowserTest] Remove upload.rb - it's fully replaced with the gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192293 [11:46:45] (03PS2) 10Krinkle: mw.ViewPageTarget: Use CSS for toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192292 (https://phabricator.wikimedia.org/T89543) [11:48:01] (03Abandoned) 10Krinkle: mw.ViewPageTarget: Use CSS for toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192292 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [11:57:57] (03CR) 10Amire80: [C: 032] [BrowserTest] Remove upload.rb - it's fully replaced with the gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192293 (owner: 10Amire80) [11:59:54] (03Merged) 10jenkins-bot: [BrowserTest] Remove upload.rb - it's fully replaced with the gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192293 (owner: 10Amire80) [12:16:21] (03CR) 10Krinkle: "Yeah, but there is one case where they are appropriate: When your DOM order does not reflect the desired stacking order. If our toolbar wo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192075 (owner: 10Krinkle) [12:17:52] (03PS2) 10Krinkle: ve.ui.Toolbar: Add z-index to oo-ui-toolbar-bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192075 [12:18:07] (03Abandoned) 10Krinkle: ve.ui.Toolbar: Add z-index to oo-ui-toolbar-bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192075 (owner: 10Krinkle) [12:29:31] (03PS12) 10Krinkle: mw.ViewPageTarget: Use CSS for toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) [12:32:47] (03CR) 10Krinkle: "I've incorporated Ed's overall approach of using overflow/height and fixed the remaining issues with it not transitioning during teardown " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [12:36:24] (03CR) 10Krinkle: "I've settled on using height/overflow (like Ed did in this commit) and addressed the issue with it not transitioning during teardown, firs" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [12:49:35] (03CR) 10Krinkle: Show the toolbar as soon as the target has been activated (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [12:55:58] (03CR) 10Krinkle: "I've attempted a rebase locally of this on top of I30a7b69b77b and it seems quite smooth. I like how the dummy toolbar contents gets silen" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [13:00:25] 10VisualEditor, 5Patch-For-Review: VisualEditor language screenshot scenario for page settings is broken - https://phabricator.wikimedia.org/T86634#1058713 (10Amire80) 5Open>3Resolved [13:00:41] 10VisualEditor, 7Browser-test-bug: VisualEditor language screenshot scenario for page settings is broken - https://phabricator.wikimedia.org/T86634#973109 (10Amire80) [13:13:50] 10VisualEditor, 10VisualEditor-MediaWiki: Browser title of editing page in VisualEditor is not correct - https://phabricator.wikimedia.org/T90433#1058722 (10Bugreporter) 3NEW [13:21:15] 10VisualEditor, 10VisualEditor-MediaWiki: Browser title of editing page in VisualEditor is not correct (drops namespace prefix?) - https://phabricator.wikimedia.org/T90433#1058737 (10Aklapper) p:5High>3Triage [13:44:30] 10VisualEditor, 7Browser-test-bug: in language screenshots there must be a way to add more margins around the element that is being cropped - https://phabricator.wikimedia.org/T87786#1058779 (10Amire80) a:3Vikassy [13:45:33] 10VisualEditor, 7Browser-test-bug: in language screenshots there must be a way to add more margins around the element that is being cropped - https://phabricator.wikimedia.org/T87786#998863 (10Amire80) Assigning to @Vikassy, who volunteered on IRC :) This will probably have to be changed in the screenshot gem. [14:02:29] (03PS1) 10Amire80: [BrowserTest] Update Gemfile.lock [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192310 [14:02:31] (03PS1) 10Amire80: [BrowserTest] Define Rubocop LineLength as 100 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192311 [15:16:45] (03CR) 10Esanders: Show the toolbar as soon as the target has been activated (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [15:30:05] (03PS4) 10Esanders: Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) [15:32:10] (03CR) 10jenkins-bot: [V: 04-1] Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [15:54:51] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget.init: Add missing 'return target' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192285 (owner: 10Krinkle) [15:56:51] (03Merged) 10jenkins-bot: mw.ViewPageTarget.init: Add missing 'return target' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192285 (owner: 10Krinkle) [15:58:49] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192281 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [16:00:41] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Remove JS animations from transformPage() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192281 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [16:02:00] 10VisualEditor, 10VisualEditor-Performance, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: ve.init.mw.ViewPageTarget#transformPage triggers recalculate style due to $.fn.animate - https://phabricator.wikimedia.org/T89543#1059070 (10Jdforrester-WMF) 5Open>3Resolved [16:03:09] (03PS13) 10Catrope: mw.ViewPageTarget: Use CSS for toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [16:05:58] Krinkle|detached, putting the target toolbar class in attach means that the margins transition from 0 to -1em [16:06:25] which means the toolbar contents moves up and left as it is opening [16:08:27] oh wait, I thought your code was merged [16:11:21] (03PS1) 10Catrope: Followup 14a4a4ae1: *actually* fix back compat for this.timeStamp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192327 [16:11:27] MatmaRex: done, but recheck's needed [16:11:35] edsanders: No he split his commit into two parts, and I merged the part not related to the toolbar [16:13:32] (03CR) 10Zfilipin: [C: 031] "Is there a reason for the upgrade? RuboCop?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192310 (owner: 10Amire80) [16:14:08] (03PS2) 10Jforrester: Follow-up 14a4a4ae1: *actually* fix back compat for this.timeStamp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192327 (owner: 10Catrope) [16:14:10] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Define Rubocop LineLength as 100 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192311 (owner: 10Amire80) [16:14:18] (03CR) 10Jforrester: [C: 032] Follow-up 14a4a4ae1: *actually* fix back compat for this.timeStamp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192327 (owner: 10Catrope) [16:14:52] (03CR) 10Amire80: "I couldn't run Rubocop without it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192310 (owner: 10Amire80) [16:16:11] (03CR) 10jenkins-bot: [V: 04-1] Follow-up 14a4a4ae1: *actually* fix back compat for this.timeStamp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192327 (owner: 10Catrope) [16:16:15] edsanders: If you could merge https://gerrit.wikimedia.org/r/#/c/191557/ and https://gerrit.wikimedia.org/r/#/c/192031/ Roan and I can do yet-another-pullthrough. :-) [16:17:08] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1059116 (10JanZerebecki) 3NEW [16:17:18] edsanders: (And Roan can do CR on Timo's stuff.) [16:17:42] (03CR) 10Esanders: "Do the tests in the dependent commit cover this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191557 (https://phabricator.wikimedia.org/T89943) (owner: 10Catrope) [16:18:09] edsanders: No, the other commit's commit message even says so [16:18:12] Oh, I see on the message it says not [16:18:15] why not? [16:18:25] edsanders: DocumentSets. [16:18:34] Because it was 2am and I couldn't be bothered, mostly [16:18:42] But it'd be a fair amount of work [16:18:47] hmm [16:18:54] (03CR) 10Bartosz Dziewoński: "Yes, I was also wary, but I implemented it, tested it and (per commit message) this doesn't seem to cause a performance hit. Probably the " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192241 (https://phabricator.wikimedia.org/T52036) (owner: 10Bartosz Dziewoński) [16:19:02] You have to have two different documents with different stores, and then assert that the store merge operation happens correctly [16:19:19] Which as far as I could tell means rewriting the test runner and the test specification format for that test [16:19:33] edsanders: As RoanKattouw pointed out to me when I asked, DocumentSets will make this moot anyway, and it's "so close" (ha!). [16:19:36] All for internalList-related functionality, while I'm supposed to be working on DocumentSet so we can kill InternalList [16:19:53] morning [16:19:54] James_F's skepticism about how close DocumentSet is is warranted :) [16:19:57] It needs more work [16:20:02] Morning ori [16:20:03] Morning, ori. [16:20:32] (03CR) 10Esanders: [C: 032] newFromDocumentInsertion: Also remap store indexes in internalList data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191557 (https://phabricator.wikimedia.org/T89943) (owner: 10Catrope) [16:21:09] 10VisualEditor, 10VisualEditor-CopyPaste, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1059129 (10Jdforrester-WMF) 5Open>3Resolved [16:21:22] (03CR) 10Jforrester: [C: 032] Follow-up 14a4a4ae1: *actually* fix back compat for this.timeStamp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192327 (owner: 10Catrope) [16:22:35] (03Merged) 10jenkins-bot: newFromDocumentInsertion: Also remap store indexes in internalList data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191557 (https://phabricator.wikimedia.org/T89943) (owner: 10Catrope) [16:22:37] (03CR) 10Esanders: "getClientRects is a native API that avoids getComputedStyles, that's why we switched to it. This would undo all that optimisation. Profili" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192241 (https://phabricator.wikimedia.org/T52036) (owner: 10Bartosz Dziewoński) [16:22:50] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/190630/ https://gerrit.wikimedia.org/r/#/c/190022/ [16:23:19] (03Merged) 10jenkins-bot: Transaction#newFromDocumentInsertion: Add some more tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/191561 (owner: 10Catrope) [16:23:22] (03Merged) 10jenkins-bot: Follow-up 14a4a4ae1: *actually* fix back compat for this.timeStamp [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192327 (owner: 10Catrope) [16:23:51] (03CR) 10Catrope: [C: 04-1] mw.ViewPageTarget: Use CSS for toolbar transition (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [16:24:41] (03CR) 10Zfilipin: [C: 032] "Strange. Did you confuse "bundle install" and "bundle update"? ;)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192310 (owner: 10Amire80) [16:26:14] (03PS3) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) [16:27:19] (03CR) 10Catrope: "I still see something strange at the start of the opening transition, where the bottom border of the toolbar is initially inside the margi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [16:29:10] (03PS6) 10Esanders: [DEPRECATING CHANGE] Rename setPosition to setLabelPosition [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 [16:29:57] (03CR) 10Jforrester: [C: 032] [DEPRECATING CHANGE] Rename setPosition to setLabelPosition [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 (owner: 10Esanders) [16:34:03] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Update Gemfile.lock [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192310 (owner: 10Amire80) [16:34:05] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Define Rubocop LineLength as 100 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192311 (owner: 10Amire80) [16:35:14] (03CR) 10Amire80: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192310 (owner: 10Amire80) [16:38:11] (03Merged) 10jenkins-bot: [DEPRECATING CHANGE] Rename setPosition to setLabelPosition [oojs/ui] - 10https://gerrit.wikimedia.org/r/190436 (owner: 10Esanders) [16:42:49] 10VisualEditor, 10VisualEditor-Performance: Load and display the welcome dialog straight after the toolbar, without waiting for the content area - https://phabricator.wikimedia.org/T90454#1059169 (10Jdforrester-WMF) 3NEW [16:45:46] (03PS1) 10Jforrester: Revert "Localisation updates from https://translatewiki.net." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192334 [16:46:12] (03CR) 10Catrope: [C: 032] Revert "Localisation updates from https://translatewiki.net." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192334 (owner: 10Jforrester) [16:46:24] (03CR) 10Bartosz Dziewoński: "I am entirely unable to reproduce the performance problems with this approach using Blink-based Opera browser (Mozilla/5.0 (Windows NT 6.1" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192241 (https://phabricator.wikimedia.org/T52036) (owner: 10Bartosz Dziewoński) [16:48:43] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: Remove workaround for cascading defaultUserOptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190630 (owner: 10Krinkle) [16:49:12] (03Merged) 10jenkins-bot: Revert "Localisation updates from https://translatewiki.net." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192334 (owner: 10Jforrester) [16:51:16] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Remove workaround for cascading defaultUserOptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190630 (owner: 10Krinkle) [16:52:11] (03CR) 10Esanders: [C: 032] "I think we worked around most of those issues by lazy-evaluating these highlights on first focus. I can't think of another away around thi" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192241 (https://phabricator.wikimedia.org/T52036) (owner: 10Bartosz Dziewoński) [16:54:36] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: enwiki template {{columns-list}} looks particularly-broken at high zoom/low width - https://phabricator.wikimedia.org/T52269#1059222 (10Jdforrester-WMF) [16:54:37] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Google-Chrome, 7Upstream, and 2 others: Focus highlights for elements using CSS column-count are too tall in Chrome - https://phabricator.wikimedia.org/T52036#1059219 (10Jdforrester-WMF) 5Open>3Resolved a:5Esanders>3matmarex [16:54:54] (03Merged) 10jenkins-bot: ve.ce.FocusableNode: Ignore children of elements using CSS column-count in Chrome [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192241 (https://phabricator.wikimedia.org/T52036) (owner: 10Bartosz Dziewoński) [16:55:32] argh. one of the links in commit message is http D: [16:56:01] (03PS1) 10Catrope: Use prefixed page title for browser title bar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192338 (https://phabricator.wikimedia.org/T90433) [17:00:42] edsanders: You about to +2 https://gerrit.wikimedia.org/r/#/c/192031/ or should I not wait to do the pull-through? [17:01:12] (03CR) 10Esanders: [C: 032] "Interestingly if you select across a focusable it still gets highlighted. user-select: none doesn't do this when ce=false, so probably a s" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192031 (https://phabricator.wikimedia.org/T70537) (owner: 10Catrope) [17:01:20] Well answered. :-) [17:02:10] 10VisualEditor, 10VisualEditor-EditingTools, 7Browser-Support-Firefox, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: In production, sometimes page scrolling stops working and in the console getting "Error: offset was inside a handlesOwnC... - https://phabricator.wikimedia.org/T70537#1059252 [17:03:01] RoanKattouw, see this in FF: http://jsfiddle.net/8ea7aff2/4/ [17:03:09] (03CR) 10Alex Monk: [C: 032] Use prefixed page title for browser title bar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192338 (https://phabricator.wikimedia.org/T90433) (owner: 10Catrope) [17:03:10] select from Line 1 to 3 in each example [17:03:19] Oh God [17:03:28] I read the docs for user-select and they seemed to suggest this wouldn't happen [17:03:33] I was expecting your commit to be broken for this reason [17:03:52] at the moment this bug works in our favour [17:04:04] Yeah but eventually it won't [17:04:27] We can also use user-select: all [17:05:04] GRRRAH [17:05:05] Also: [17:05:07] Note: One of the differences between browser implementations is inheritance. In Firefox, -moz-user-select is not inherited by absolutely positioned elements, but in Safari and Chrome, -webkit-user-select is inherited by those elements. [17:05:26] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-02-25_(1.25wmf19): Browser title of editing page in VisualEditor is not correct (drops namespace prefix?) - https://phabricator.wikimedia.org/T90433#1059286 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3Catrope [17:05:27] That suggests we might need .ve-ce-focusableNode * { -moz-user-select: none/all; } [17:08:18] yum, stars selectors [17:11:42] (03CR) 10jenkins-bot: [V: 04-1] Work around Firefox bug allowing cursor in cE=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192031 (https://phabricator.wikimedia.org/T70537) (owner: 10Catrope) [17:12:21] (03Merged) 10jenkins-bot: Use prefixed page title for browser title bar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192338 (https://phabricator.wikimedia.org/T90433) (owner: 10Catrope) [17:15:58] (03CR) 10Krinkle: mw.ViewPageTarget: Use CSS for toolbar transition (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [17:18:02] (03PS1) 10Krinkle: mw.ViewPageTarget: Remove obsolete transitions for margin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192342 [17:18:07] RoanKattouw: ^ [17:18:41] (03CR) 10Esanders: [C: 04-1] "Does this need a star selector?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192031 (https://phabricator.wikimedia.org/T70537) (owner: 10Catrope) [17:19:14] (03CR) 10Bartosz Dziewoński: [C: 032] "Oh yes, this was bugging me. Thanks." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192342 (owner: 10Krinkle) [17:19:22] Thanks :) [17:19:33] Thank you for removing it from Vector [17:19:47] * Krinkle is in a christmas mindset. [17:19:52] Just watched the Dr Who ep, finally [17:20:27] (03CR) 10Catrope: mw.ViewPageTarget: Use CSS for toolbar transition (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [17:21:13] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Remove obsolete transitions for margin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192342 (owner: 10Krinkle) [17:25:50] RoanKattouw: Hm.. There's a tricky bit with the css state managing. Which is why I'm unsure of calling initialize() async [17:25:54] MatmaRex, Krinkle what is wrong with resize transitions? [17:26:31] RoanKattouw: ve-active is added when surface is ready, but unlike teardown, setup does not have a promise to wait for [17:27:24] How is the teardown promise done? [17:27:31] A timeout? transitionend event? [17:27:35] RoanKattouw: Yeah [17:27:44] But there's nowhere for the promise to go to rightnow [17:27:47] we'd need a change in ve-core [17:28:04] but actually, we probably shouldn't be blocking on that [17:28:16] edsanders: not much, but they're annoying to support, and their usefulness was disputed on https://phabricator.wikimedia.org/T85614 [17:28:26] Krinkle: Wait, hold on [17:28:29] the toolbar is added and transitions but it's done as far as the state is concerned [17:28:35] How does VE core have a teardown promise for the toolbar? [17:28:40] The transition stuff isn't in VE core [17:28:45] RoanKattouw: tearDownToolbar returns promise [17:29:09] Yes, and that's in VE-MW [17:29:20] The promise it returns comes from $.fn.slideUp() [17:29:22] Ah, right [17:29:23] Yeah [17:29:27] Well, yeah, in the current codee [17:29:37] but we wait for tearDownToolbar in tearDownSurface [17:29:58] which cancel() waits for [17:30:00] OK, we can do this [17:30:05] using activatingDeferred [17:30:23] RoanKattouw: So the question is, is it okay for the transition-in of toolbar to not start until surface is ready [17:30:26] or should it start asap [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112117815 [17:30:36] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112121781 [17:30:36] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34406572 [17:30:36] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34406580 [17:30:36] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34407304 [17:30:37] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34416301 [17:30:37] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=34416493 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68774786 [17:30:38] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68781623 [17:30:39] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68795099 [17:30:39] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=41402974 [17:30:40] Corruption alert: visualeditor-needcheck on dewiki: https://de.wikipedia.org/?diff=139120589 [17:30:40] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=70994294 [17:30:43] Krinkle: Well, Ed's change moves the timing of when the toolbar is attached [17:30:49] Yeah [17:30:52] To well before the real surface is ready [17:30:58] RoanKattouw: I'd like to get that in without the transition change [17:30:59] You guys should really rebase your changes onto each other [17:31:06] Or one onto the other, or something [17:31:08] Yeah me too [17:31:24] It's funny, I asked Ed to split his change, and instead what happened was you split your change :) [17:31:29] I'm not rebasing it onto mine though, I want the dummy toolbar to land first [17:31:39] OK maybe you can rebase your change onto his then? [17:31:48] Yeah, but stripping transition change from his change [17:32:04] Sure [17:32:40] I removed like 25 screenshots from my VE folder this weekend. Tech debt I haven't bother even writing a task for. Jut things I noticed and captured. All fixed now [17:32:43] Weeee [17:34:04] (03CR) 10Krinkle: [C: 032] "esprima is getting really annoying. Re-submit" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192342 (owner: 10Krinkle) [17:36:00] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Remove obsolete transitions for margin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192342 (owner: 10Krinkle) [17:38:38] Krinkle: Is esprima one of the tickets in Phabricator? [17:38:46] Nope [17:38:50] Should it be? [17:39:17] https://github.com/jscs-dev/node-jscs/issues/787 [17:39:18] https://github.com/npm/npm/issues/7130#issuecomment-75508043 [17:39:22] I guess, yeah [17:39:28] I thought it was gone with update to npm 2.4 [17:39:30] it was gone for a while [17:39:32] but it's back... [17:39:38] has to do with concurrent writers to the central cache [17:39:44] not with workspace cleaning, that was fixed [17:39:52] Helpful. [17:41:22] edsanders: Ugh, using user-select: all doesn't fix the bug [17:41:36] So I'll just stick with none [17:41:57] And we'll just not tell Firefox about the bug where you can select us:none stuff in cE [17:42:13] Knowing how little they work on cE support, if we don't tell them they'll never fix it [17:42:55] (03PS1) 10Kmenger: IconElement: Add description for config options [oojs/ui] - 10https://gerrit.wikimedia.org/r/192348 [17:43:42] RoanKattouw: Optimism bias. :_) [17:44:10] (03PS2) 10Catrope: Work around Firefox bug allowing cursor in cE=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192031 (https://phabricator.wikimedia.org/T70537) [17:48:30] (03PS5) 10Catrope: Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [17:48:45] (03PS5) 10Krinkle: Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [17:48:47] (03CR) 10Jforrester: [C: 032] IconElement: Add description for config options [oojs/ui] - 10https://gerrit.wikimedia.org/r/192348 (owner: 10Kmenger) [17:50:16] (03Merged) 10jenkins-bot: IconElement: Add description for config options [oojs/ui] - 10https://gerrit.wikimedia.org/r/192348 (owner: 10Kmenger) [17:50:22] (03PS6) 10Krinkle: Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [17:50:27] (03CR) 10jenkins-bot: [V: 04-1] Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [17:57:23] 10VisualEditor, 10Citoid: Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec - https://phabricator.wikimedia.org/T90463#1059517 (10ssastry) 3NEW a:3Mvolz [17:58:12] (03CR) 10Catrope: [C: 031] Simplify slug behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/190022 (https://phabricator.wikimedia.org/T89192) (owner: 10Esanders) [17:58:55] 10VisualEditor, 10Citoid: Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec - https://phabricator.wikimedia.org/T90463#1059536 (10ssastry) [17:58:58] are there known major issues with firefox right now? [17:59:43] 10VisualEditor, 10Citoid: Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec - https://phabricator.wikimedia.org/T90463#1059517 (10ssastry) [18:00:09] (nm, seems just one user's issue) [18:01:48] (03CR) 10jenkins-bot: [V: 04-1] Work around Firefox bug allowing cursor in cE=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192031 (https://phabricator.wikimedia.org/T70537) (owner: 10Catrope) [18:03:23] 10OOjs-UI, 10VisualEditor, 7Design: Button labels are invisible while the button is clicked - https://phabricator.wikimedia.org/T90465#1059546 (10Eloquence) 3NEW [18:10:53] 10OOjs-UI, 10VisualEditor, 7Design: Button labels are invisible while the button is clicked - https://phabricator.wikimedia.org/T90465#1059593 (10matmarex) This is already fixed (try it on labs), but not yet deployed. [18:11:01] 10OOjs-UI: Primary buttons change text colour when pressed - https://phabricator.wikimedia.org/T88948#1059595 (10matmarex) [18:11:02] 10OOjs-UI, 10VisualEditor, 7Design: Button labels are invisible while the button is clicked - https://phabricator.wikimedia.org/T90465#1059594 (10matmarex) [18:11:50] 10OOjs-UI, 10VisualEditor, 7Design: Button labels are invisible while the button is clicked - https://phabricator.wikimedia.org/T90465#1059598 (10Eloquence) Thanks Bartosz! [18:13:43] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Performance: VisualEditor: Editing a transclusion with many templates hangs the browser - https://phabricator.wikimedia.org/T71799#1059604 (10Etonkovidova) p:5Triage>3Normal [18:14:23] Eloquence: No major issues that I know of, no. [18:15:48] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-Performance: Re-consider using OO.getHash in convertModelFromDom - https://phabricator.wikimedia.org/T90413#1059609 (10Jdforrester-WMF) p:5Triage>3Normal [18:16:13] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Incrementally build CE tree/DOM - https://phabricator.wikimedia.org/T90376#1059616 (10Jdforrester-WMF) p:5Triage>3High [18:16:25] 10VisualEditor, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1059618 (10Jdforrester-WMF) p:5Triage>3High [18:16:41] 10VisualEditor, 10VisualEditor-Performance: Benchmark hot cache load times - https://phabricator.wikimedia.org/T90373#1059620 (10Jdforrester-WMF) p:5Triage>3Normal [18:17:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Send Parsoid API request immediately when user clicks edit - https://phabricator.wikimedia.org/T90372#1059632 (10Jdforrester-WMF) p:5Triage>3Unbreak! [18:18:57] 10VisualEditor, 10VisualEditor-MediaWiki-Links: insert reference confusing enough to produce broken link - https://phabricator.wikimedia.org/T90379#1059635 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF [18:19:38] James_F: Are there browsers on here http://caniuse.com/#search=requestAnimationFrame in red or green+yellow that we need to support, ever? [18:19:48] (in ve-mw) [18:20:44] Krinkle: We're meant to eventually work in Android 3+; if we need to bump that to 4.4+ that's a serious reduction in device coverage. Also, IE9 is meant to be eventually supported but meh. [18:21:02] OK. I'll do a fallback. no worries [18:21:12] Krinkle: Cool. [18:21:15] It's one line of code. [18:21:19] But just checking [18:21:39] * James_F nods. [18:24:55] 10VisualEditor: tiny windows with scrollbars should be increased - https://phabricator.wikimedia.org/T90377#1059677 (10Jdforrester-WMF) In your screenshots, the diff window is already 900px wide; standard width, as used for the other windows, is 700px wide. I don't think going full-screen is a good outcome for u... [18:25:35] (03PS1) 10Kmenger: IconElement: Add description of methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/192361 [18:27:47] Oh bollocks. WE're loading jQuery UI also before the surface is considerd ready [18:27:55] because we depend on mw.feedback [18:27:56] :( [18:28:08] There's a couple repaints and stuff that it does onload [18:28:08] Krinkle: Yeah, there's a ticket to convert it. [18:28:14] Can we lazy load it? [18:28:21] Maybe mooeypoo should convert it sooner rather than later? [18:28:24] It's in its own request either way [18:28:27] Yeah I noticed that the other day [18:28:32] JUI does some stupid things on load [18:28:36] (*coughs*) [18:28:43] RoanKattouw: Like, exist? [18:28:46] Can we load mw.feedback on demand or something? [18:28:48] James_F: That too [18:28:51] jQuery core does that on-demand now (like Sizzle). jQuery UI, too, but we're using an old version [18:28:56] (03PS10) 10Mooeypoo: [WIP] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) [18:30:18] Ha, so if I use requestAnimationFrame instead of setTimeout to set the height to scrollHeight, there is no transition, and the toolbar initially renders without the negative margin from mwViewPAgeTarget.vector.js because... because ResourceLoader sets the styles *after* the js starts executing. [18:30:21] Debug mode disabled [18:30:33] Krinkle: Fun. [18:30:33] vector.css* [18:31:08] RoanKattouw: I put a debugger in the top of mw.vpt.js and the