[00:03:19] <mooeypoo>	 Krinkle, I'm working on mw.Feedback in core, and I get an error in sublime's jshint (I think?) saying that 'super' is reserved; RoanKattouw suggested as a workaround to use "parent" instead for now, but is this something that I should fix somewhow with some global or... am I doing something wrong?
[00:07:42] <grrrit-wm>	 (03PS1) 10Kmenger: FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 
[00:15:52] <grrrit-wm>	 (03PS1) 10Ori.livneh: Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 
[00:16:07] <grrrit-wm>	 (03PS2) 10Ori.livneh: Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 
[00:16:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 (owner: 10Ori.livneh)
[00:19:33] <grrrit-wm>	 (03PS3) 10Ori.livneh: Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 
[00:19:36] <grrrit-wm>	 (03CR) 10Catrope: "I actually can't dispense with the feedback promise, because it replaces this.feedback: it prevents us from instantiating mw.Feedback over" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192378 (owner: 10Catrope)
[00:20:00] <grrrit-wm>	 (03PS4) 10Ori.livneh: Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 
[00:20:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[00:20:07] <ori>	 sorry for gerrit spam.
[00:20:35] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] Load mw.feedback on demand [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192378 (owner: 10Catrope)
[00:21:41] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: VisualEditor: Comments in "unsafe" content locations are not displayed - https://phabricator.wikimedia.org/T73085#1061026 (10matmarex) @Ryasmeen, can you elaborate? I can't reproduce that, neither in labs nor prod – I...
[00:23:46] <ori>	 RoanKattouw: I just tested "Load mw.feedback on demand" and it works well. Can I merge it, or do you want to wait for Kunal to review?
[00:23:56] <RoanKattouw>	 Why Kunal?
[00:24:05] <ori>	 that's who you added as a reviewer
[00:24:06] <legoktm>	 yes, why me? :P
[00:24:10] <RoanKattouw>	 No, I added Krinkle 
[00:24:16] <legoktm>	 I think I was auto-added because of extension.json changes.
[00:24:17] <RoanKattouw>	 Or ...
[00:24:20] <RoanKattouw>	 Oh, right
[00:24:21] <ori>	 :)
[00:24:35] <RoanKattouw>	 ori: I want James_F to approve
[00:24:38] <RoanKattouw>	 of there not being a spinner
[00:24:55] <ori>	 over to you, James_F
[00:26:07] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1061034 (10Etonkovidova) Checked the scenario described by Catrope in bet...
[00:27:27] <grrrit-wm>	 (03PS8) 10Jforrester: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders)
[00:27:37] <James_F>	 Approve what?
[00:28:13] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "PS8 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders)
[00:29:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders)
[00:29:50] <Krenair>	 James_F, https://gerrit.wikimedia.org/r/192378
[00:30:05] <grrrit-wm>	 (03PS2) 10Ori.livneh: Load mw.feedback on demand [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192378 (owner: 10Catrope)
[00:30:10] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Load mw.feedback on demand [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192378 (owner: 10Catrope)
[00:30:32] <MatmaRex>	 James_F: TrevorParscal: hey, i kind of ran out of things that needed doing immediately – do you want me to work on something particular (VE-related?), or get back to wrangling OOUI into mediawiki/core?
[00:31:12] <TrevorParscal>	 MatmaRex: so... faking toolbar group merging?
[00:31:18] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 (owner: 10Ori.livneh)
[00:31:32] <RoanKattouw>	 Krinkle: https://gerrit.wikimedia.org/r/#/c/192479/
[00:31:49] <MatmaRex>	 TrevorParscal: oh, right. so, what about that? i still have no idea what you want that to behave like
[00:32:47] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: VisualEditor: Comments in "unsafe" content locations are not displayed - https://phabricator.wikimedia.org/T73085#1061044 (10Ryasmeen) Hmm, I am able to reproduce it consistently.Nope thats a different case, I am not...
[00:32:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 (owner: 10Ori.livneh)
[00:32:54] <grrrit-wm>	 (03CR) 10Jforrester: Add "composer test" command to lint PHP files and run phpcs (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 (owner: 10Legoktm)
[00:34:36] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] LabelElement: Add description, config description, static property description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192455 (owner: 10Kmenger)
[00:34:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Element: Add description for configs and static property [oojs/ui] - 10https://gerrit.wikimedia.org/r/192390 (owner: 10Kmenger)
[00:35:43] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] DraggableElement: Mark private methods and add description to events [oojs/ui] - 10https://gerrit.wikimedia.org/r/192379 (owner: 10Kmenger)
[00:38:25] <MatmaRex>	 whoop, i just experienced the weirdest cursor behavior
[00:38:59] <grrrit-wm>	 (03PS2) 10Jforrester: ComboBox: Use combobox role [oojs/ui] - 10https://gerrit.wikimedia.org/r/192186 (owner: 10TheDJ)
[00:39:05] <MatmaRex>	 1. have a comment at the end of paragraph 2. place cursor there, type "a" 3. click to place the cursor anywhere else (in different paragraph) 4. place the cursor after the "a", backspace
[00:39:19] <MatmaRex>	 observed: the cursor starts blinking at the right edge of browser window.
[00:39:50] <MatmaRex>	 (using opera, like chrome)
[00:40:52] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] ComboBox: Use combobox role [oojs/ui] - 10https://gerrit.wikimedia.org/r/192186 (owner: 10TheDJ)
[00:42:09] <grrrit-wm>	 (03PS2) 10Jforrester: IconElement: Add description of methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/192361 (owner: 10Kmenger)
[00:42:42] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: VisualEditor: Comments in "unsafe" content locations are not displayed - https://phabricator.wikimedia.org/T73085#1061059 (10matmarex) Ooh, thank you, that was helpful. I can reproduce only if the reference is at the...
[00:43:05] <MatmaRex>	 good news: not my fault. bad news: more stuff's broken
[00:43:09] <James_F>	 MatmaRex: :-)
[00:43:54] <wikibugs>	 10VisualEditor: [Regression wmf 18]  "Error: Offset could not be translated to a DOM element and offset" appears while deleting the text inside a bullet/numbered item and then cursor starts behaving weirdly while typing text - https://phabricator.wikimedia.org/T90478#1061060 (10Ryasmeen) a:3dchan
[00:46:18] <ori>	 Krinkle: Jenkins's -1 on https://gerrit.wikimedia.org/r/192479 is bogus
[00:47:26] <MatmaRex>	 by the way, do we/Parsoid not handle <poem>s?
[00:49:53] <James_F>	 MatmaRex: No.
[00:50:04] <RoanKattouw>	 Krinkle: I remember you fixing something that was supposed to make @example work in the live OOUI docs
[00:50:23] <TrevorParscal>	 MatmaRex: i'll whip up a description of what I mean by faking group merging
[00:50:32] <RoanKattouw>	 Krinkle: Is that deployed yet? Because kirstenMA tells me that she gets "ReferenceError: OO is not defined" at https://doc.wikimedia.org/oojs-ui/master/#!/api/OO.ui.SelectWidget
[00:50:55] <TrevorParscal>	 in the mean time, it appears that PanelLayout having expanded be a default makes very little sense in many cases
[00:51:11] <TrevorParscal>	 and inverting that will be no small task because of all the callers needing to be adjusted
[00:51:25] <TrevorParscal>	 but, we need to make it false by deafult - true by default was a mistake
[00:52:00] <ryasmeen>	 MatmaRex: So it was an existing issue about adding comments right? Should I create a separate ticket on that then?
[00:54:12] <MatmaRex>	 ryasmeen: yeah
[00:54:46] <RoanKattouw>	 Krinkle: Also @example is broken for me locally now, did you renaming eg-iframe.html cause that?
[00:55:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Load mw.feedback on demand [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192378 (owner: 10Catrope)
[00:56:51] <James_F>	 RoanKattouw: Blunt enough? https://en.wikipedia.org/w/index.php?title=User:Mvolz/veCiteFromURL.js&diff=648560732&oldid=632957838
[00:58:34] <grrrit-wm>	 (03PS1) 10Catrope: Follow-up bade83bfdfc: fix @example again [oojs/ui] - 10https://gerrit.wikimedia.org/r/192482 
[00:59:03] <RoanKattouw>	 Krinkle: Aha, looks like it was because you removed ../ prefixes when renaming the file, fixed in ---^^
[00:59:10] <RoanKattouw>	 kirstenMA: ----^^ fixes @example for me locally
[00:59:16] <wikibugs>	 10VisualEditor: Comment is not getting added after Citation, Template,Gallery,Math node and Table - https://phabricator.wikimedia.org/T90517#1061082 (10Ryasmeen) 3NEW
[00:59:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: LabelElement: Add description, config description, static property description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192455 (owner: 10Kmenger)
[00:59:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Element: Add description for configs and static property [oojs/ui] - 10https://gerrit.wikimedia.org/r/192390 (owner: 10Kmenger)
[00:59:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: DraggableElement: Mark private methods and add description to events [oojs/ui] - 10https://gerrit.wikimedia.org/r/192379 (owner: 10Kmenger)
[00:59:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: ComboBox: Use combobox role [oojs/ui] - 10https://gerrit.wikimedia.org/r/192186 (owner: 10TheDJ)
[00:59:59] <wikibugs>	 10VisualEditor: Comment is not getting added after Citation, Template,Gallery,Math node and Table - https://phabricator.wikimedia.org/T90517#1061089 (10Ryasmeen) a:3matmarex
[01:00:12] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-2] "No, fix the base please." [oojs/ui] - 10https://gerrit.wikimedia.org/r/192482 (owner: 10Catrope)
[01:03:06] <grrrit-wm>	 (03PS2) 10Catrope: Follow-up bade83bfdfc: actually remove ../ [oojs/ui] - 10https://gerrit.wikimedia.org/r/192482 
[01:03:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Better. :-)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192482 (owner: 10Catrope)
[01:05:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up bade83bfdfc: actually remove ../ [oojs/ui] - 10https://gerrit.wikimedia.org/r/192482 (owner: 10Catrope)
[01:08:22] <mooeypoo>	 James_F, how horrific would it be to decide that mw.feedback note message is changing in the oouification?
[01:08:37] <James_F>	 mooeypoo: ?
[01:09:06] <mooeypoo>	 the way the message is built right now is really against ooui design schema
[01:15:25] <wikibugs>	 10VisualEditor, 5Patch-For-Review, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: [Regression wmf16] Including a template/comment/table/gallery/math node in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1061111 (10Jdforrester-WMF) 5Open>3Res...
[01:15:44] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 5Patch-For-Review, 5WMF-deploy-2015-02-25_(1.25wmf19): VisualEditor: Clicking on somewhere else in the document after opening a link inspector inside a slug throws error "TypeErro... - https://phabricator.wikimedia.org/T74494#1061113
[01:15:58] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 5WMF-deploy-2015-02-25_(1.25wmf19): Position event not emitted after slug close - https://phabricator.wikimedia.org/T85014#1061117 (10Jdforrester-WMF) 5Open>3Resolved
[01:16:12] <grrrit-wm>	 (03PS1) 10Kmenger: PopupButtonWidget: Add description and example and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/192485 
[01:16:15] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 5WMF-deploy-2015-02-25_(1.25wmf19): VisualEditor: Left/right cursoring into block slug doesn't trigger animations - https://phabricator.wikimedia.org/T67742#1061120 (10Jdforrester-WMF) 5Open>3Resolved
[01:18:04] <grrrit-wm>	 (03PS3) 10Jforrester: Update VE core submodule to master (e6a37e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190461 (owner: 10Esanders)
[01:18:49] <grrrit-wm>	 (03PS4) 10Jforrester: Update VE core submodule to master (e6a37e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190461 (owner: 10Esanders)
[01:19:11] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (e6a37e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190461 (owner: 10Esanders)
[01:21:55] <TrevorParscal>	 ok, MatmaRex: http://f.cl.ly/items/2b0b3R1l1K2W0T020j0j/Toolbar-Group-Merging.png
[01:22:13] <James_F>	 +1
[01:22:29] <TrevorParscal>	 basically, in the future we will have tools in a tree-like model
[01:22:31] <TrevorParscal>	 but for now
[01:22:35] <grrrit-wm>	 (03PS1) 10Catrope: Remove use of getDocument/getWindow in ve.utils.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192486 
[01:22:55] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove use of getDocument/getWindow in ve.utils.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192486 (owner: 10Catrope)
[01:23:04] <MatmaRex>	 TrevorParscal: hmm, okay. so only for items on the bar itself.
[01:23:12] <TrevorParscal>	 if you could just come up with a semi-reasonable way to indicate neighboring groups should be extra friendly and appear connected, that would solve the immediate issue
[01:23:30] <TrevorParscal>	 yeah, we don't need to do anything fancier than this
[01:23:41] <TrevorParscal>	 for now
[01:23:43] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] PopupButtonWidget: Add description and example and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/192485 (owner: 10Kmenger)
[01:24:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (e6a37e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190461 (owner: 10Esanders)
[01:24:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove use of getDocument/getWindow in ve.utils.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192486 (owner: 10Catrope)
[01:25:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] TitledElement: Add description and config and static descriptions [oojs/ui] - 10https://gerrit.wikimedia.org/r/192469 (owner: 10Kmenger)
[01:25:40] <grrrit-wm>	 (03PS1) 10Catrope: Fix a few silly RL module dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192488 
[01:26:37] <grrrit-wm>	 (03CR) 10Jforrester: "extension.json…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192488 (owner: 10Catrope)
[01:26:44] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[01:27:17] <grrrit-wm>	 (03PS2) 10Catrope: Fix a few silly RL module dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192488 
[01:28:28] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix a few silly RL module dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192488 (owner: 10Catrope)
[01:28:56] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-2] "Doesn't work yet, hold on" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192488 (owner: 10Catrope)
[01:30:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix a few silly RL module dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192488 (owner: 10Catrope)
[01:33:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] PopupButtonWidget: Add description and example and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/192485 (owner: 10Kmenger)
[01:35:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: TitledElement: Add description and config and static descriptions [oojs/ui] - 10https://gerrit.wikimedia.org/r/192469 (owner: 10Kmenger)
[01:35:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[01:37:29] <grrrit-wm>	 (03PS3) 10Alex Monk: Move insert media button to top level toolbar between cite and structure [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) 
[01:37:54] <grrrit-wm>	 (03PS3) 10Catrope: Fix a few silly RL module dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192488 
[01:45:29] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix a few silly RL module dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192488 (owner: 10Catrope)
[01:47:11] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192361 (owner: 10Kmenger)
[01:47:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix a few silly RL module dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192488 (owner: 10Catrope)
[01:47:46] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] RadioOptionWidget: Make disabling single options work [oojs/ui] - 10https://gerrit.wikimedia.org/r/192092 (owner: 10Bartosz Dziewoński)
[01:48:08] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add disabled RadioInputWidget to demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/192091 (owner: 10Bartosz Dziewoński)
[01:48:52] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 6Analytics-Engineering, 6Analytics-Kanban, 5§ VisualEditor Q3 Blockers: Report on the central tendency for length of pages which are edited for VisualEditor performance benchmarking - https://phabricator.wikimedia.org/T89788#1061159 (10Jdforrester-WMF) >>! In T...
[01:51:44] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 6Analytics-Engineering, 6Analytics-Kanban, 5§ VisualEditor Q3 Blockers: Report on the central tendency for length of pages which are edited for VisualEditor performance benchmarking - https://phabricator.wikimedia.org/T89788#1061160 (10Jdforrester-WMF) >>! In T...
[01:57:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: IconElement: Add description of methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/192361 (owner: 10Kmenger)
[01:57:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add disabled RadioInputWidget to demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/192091 (owner: 10Bartosz Dziewoński)
[01:59:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: RadioOptionWidget: Make disabling single options work [oojs/ui] - 10https://gerrit.wikimedia.org/r/192092 (owner: 10Bartosz Dziewoński)
[02:16:56] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Hmm… actually I think this points out a minor bug I caused in 9bd4eb3ab5b78fa97d688fbaa0a932c5f5fbf66f. this.$button *should* be null unti" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192182 (owner: 10Krinkle)
[02:35:21] <grrrit-wm>	 (03PS1) 10Catrope: Factor out the API request into its own method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192494 
[02:35:23] <grrrit-wm>	 (03PS1) 10Catrope: Promisify ve.init.mw.Target#load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192495 
[02:38:05] <Krenair>	 Another commit to merge conflict with :(
[02:40:36] <Krenair>	 Oh well. Lgtm.
[02:40:48] <RoanKattouw>	 Were you doing stuff in load()?
[02:40:55] <RoanKattouw>	 Or onModulesReady()?
[02:40:58] <RoanKattouw>	 I thought that was pretty stale code
[02:41:22] <grrrit-wm>	 (03PS2) 10Catrope: Factor out the Parsoid API request into its own method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192494 
[02:41:27] <grrrit-wm>	 (03PS2) 10Catrope: Promisify ve.init.mw.Target#load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192495 
[02:43:01] <Krenair>	 load
[02:43:32] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Factor out the Parsoid API request into its own method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192494 (owner: 10Catrope)
[02:44:07] <Krenair>	 in https://gerrit.wikimedia.org/r/#/c/186548/
[02:45:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Factor out the Parsoid API request into its own method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192494 (owner: 10Catrope)
[02:51:20] <grrrit-wm>	 (03PS14) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) 
[02:52:27] <grrrit-wm>	 (03CR) 10Jforrester: "What's needed here?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187889 (owner: 10Divec)
[02:53:43] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[02:55:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[02:56:55] <James_F>	 Oh, eh.
[03:01:13] <grrrit-wm>	 (03PS2) 10Jforrester: FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[03:01:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[03:05:29] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] PopupButtonWidget: Add description and example and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/192485 (owner: 10Kmenger)
[03:12:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[03:19:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] PopupButtonWidget: Add description and example and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/192485 (owner: 10Kmenger)
[03:32:54] <wikibugs>	 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia: Use source urls in mw.loader.store - https://phabricator.wikimedia.org/T90524#1061235 (10Tgr) 3NEW
[03:53:56] <wikibugs>	 10VisualEditor, 10Flow, 10Wikimedia-Hackathon-2015: Associate non-body content such as annotations and talk to a location in the article - https://phabricator.wikimedia.org/T89575#1061255 (10Mattflaschen)
[03:55:07] <wikibugs>	 10VisualEditor, 10Flow, 10Wikimedia-Hackathon-2015: Associate non-body content such as annotations and talk to a location in the article - https://phabricator.wikimedia.org/T89575#1039670 (10Mattflaschen)
[06:12:13] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance: Evaluate VisualEditor smoothness - https://phabricator.wikimedia.org/T90531#1061416 (10TTO)
[07:52:24] <wikibugs>	 10VisualEditor: Space at the start of a line is being nowikid - https://phabricator.wikimedia.org/T90533#1061569 (10Martijn_Hoekstra) 3NEW
[08:55:54] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Backspace/delete can remove unpaired unicorn images - https://phabricator.wikimedia.org/T90540#1061680 (10dchan) 3NEW a:3dchan
[09:19:13] <wikibugs>	 10VisualEditor, 6Release-Engineering, 7Browser-test-bug: browsertests-VisualEditor-language-screenshot jenkins job failing - https://phabricator.wikimedia.org/T1321#1061704 (10Amire80) 5Open>3Resolved p:5Lowest>3Normal a:3zeljkofilipin
[09:19:37] <wikibugs>	 10VisualEditor, 6Release-Engineering, 7Browser-test-bug: browsertests-VisualEditor-language-screenshot jenkins job failing - https://phabricator.wikimedia.org/T1321#23157 (10Amire80) It was moved to run on Mac, and now runs successfully.
[09:20:44] <wikibugs>	 10VisualEditor, 6Release-Engineering, 7Browser-test-bug: Fix browsertests-VisualEditor-language-screenshot-windows_8.1-firefox Jenkins job - https://phabricator.wikimedia.org/T76133#1061711 (10Amire80) 5Open>3Resolved
[09:34:14] <wikibugs>	 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia: Use source urls in mw.loader.store - https://phabricator.wikimedia.org/T90524#1061843 (10Aklapper) p:5Triage>3Normal
[09:59:11] <wikibugs>	 10VisualEditor, 7Browser-test-bug, 7I18n: language screenshot scenarios should run automatically for languages that have translation above a certain threshold - https://phabricator.wikimedia.org/T90560#1061923 (10Amire80) 3NEW
[10:38:36] <grrrit-wm>	 (03PS1) 10Esanders: Fix disconnect of focus change handler in surface destroy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192528 
[10:38:38] <grrrit-wm>	 (03PS1) 10Esanders: Clear surface observer when re-activating a surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192529 
[10:45:15] <grrrit-wm>	 (03PS1) 10Esanders: Revert "ve.ce.FocusableNode: Remove superfluous ve.ce.Surface#appendHighlights call" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192530 
[10:45:46] <grrrit-wm>	 (03PS2) 10Esanders: Revert "ve.ce.FocusableNode: Remove superfluous ve.ce.Surface#appendHighlights call" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192530 
[10:46:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Revert "ve.ce.FocusableNode: Remove superfluous ve.ce.Surface#appendHighlights call" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192530 (owner: 10Esanders)
[11:08:38] <wikibugs>	 10VisualEditor, 10WikiEditor, 6Collaboration-Team, 10Flow, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1061982 (10Pginer-WMF) > Flow is pretty and (I guess) helpful for ongoing or complex discussions; we just don't have as many instances of...
[11:21:33] <Krinkle>	 o/ Krenair
[11:23:00] <grrrit-wm>	 (03CR) 10Krinkle: "Ah, interesting. Yeah. It's doing both 'this.$button = ' *and* setButtonElement in the constructor." [oojs/ui] - 10https://gerrit.wikimedia.org/r/192182 (owner: 10Krinkle)
[11:51:43] <Krinkle>	 Wow
[11:51:46] <Krinkle>	 what happened to the link inspector.
[11:51:57] <Krinkle>	 I found at least 4 weird bugs in the last 2 minutes
[13:16:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Whoops. Sorry." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192530 (owner: 10Esanders)
[13:18:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "ve.ce.FocusableNode: Remove superfluous ve.ce.Surface#appendHighlights call" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192530 (owner: 10Esanders)
[14:09:18] <grrrit-wm>	 (03CR) 10Mobrovac: [C: 031] "LGTM, with a couple of comments in-lined." (033 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) (owner: 10Mvolz)
[14:11:11] <grrrit-wm>	 (03CR) 10Mobrovac: "With all of these callbacks, Citoid seems like a perfect candidate for promisification." [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) (owner: 10Mvolz)
[14:15:49] <wikibugs>	 10VisualEditor: Space at the start of a line is being nowikid - https://phabricator.wikimedia.org/T90533#1062435 (10matmarex) The space would be rendered, turning the entire paragraph into <pre> (monospace text).   Similar issue: T46478
[14:32:45] <grrrit-wm>	 (03PS9) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 
[14:40:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders)
[14:50:07] <grrrit-wm>	 (03PS10) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 
[14:50:09] <grrrit-wm>	 (03PS1) 10Esanders: Make toolbar dialog padding configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192550 
[14:51:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders)
[15:09:48] <grrrit-wm>	 (03CR) 10Mvolz: "Will fix, but this is on top of Change-Id: I8d571305e853f41748ade494f52430a44e11bf75 which needs to be reviewed/merged first :)." [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) (owner: 10Mvolz)
[18:01:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński)
[18:01:11] <grrrit-wm>	 (03CR) 10Mvolz: Use html-metadata library (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) (owner: 10Mvolz)
[18:01:20] <grrrit-wm>	 (03CR) 10Mvolz: "Yes, I really, really need testing :). I've just been chewing through this trying to eventually to get scrape take arguments from localset" [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) (owner: 10Mvolz)
[18:01:23] <grrrit-wm>	 (03PS12) 10Mvolz: Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) 
[18:01:29] <grrrit-wm>	 (03PS8) 10Mvolz: Create CitoidService object [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) 
[18:01:33] <grrrit-wm>	 (03PS6) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[18:01:37] <grrrit-wm>	 (03PS1) 10Mvolz: [WIP] Convert scrape.js into an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192562 (https://phabricator.wikimedia.org/T90341) 
[18:01:58] <grrrit-wm>	 (03PS7) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[18:02:06] <grrrit-wm>	 (03Abandoned) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[18:02:08] <grrrit-wm>	 (03Restored) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[18:02:10] <grrrit-wm>	 (03PS8) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[18:02:18] <grrrit-wm>	 (03Abandoned) 10Mvolz: [WIP] Convert scrape.js into an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192562 (https://phabricator.wikimedia.org/T90341) (owner: 10Mvolz)
[18:02:30] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Clear surface observer when re-activating a surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192529 (owner: 10Esanders)
[18:02:32] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix disconnect of focus change handler in surface destroy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192528 (owner: 10Esanders)
[18:03:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove unused $popupOverlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192573 (owner: 10Esanders)
[18:03:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix disconnect of focus change handler in surface destroy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192528 (owner: 10Esanders)
[18:03:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clear surface observer when re-activating a surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192529 (owner: 10Esanders)
[18:03:17] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński)
[18:05:19] <mvolz>	 Well the gerrit bot is back up apaprently
[18:07:41] <Krinkle>	 Yay. Yeah, it's slowly coming back up
[18:17:08] <MatmaRex>	 is jenkins down?
[18:17:21] <James_F>	 Krinkle: Does that mean NFS is fixed?
[18:18:01] <Krinkle>	 Don't know
[18:18:15] <Krinkle>	 James_F: NFS isn't broken, it's down for maintenance. It'll gradually go back up per virt server I expect.
[18:18:25] <Krinkle>	 our nodes are spread over multiple servers.
[18:18:26] <James_F>	 Krinkle: s/fixed/back up/ :-P
[18:18:35] <James_F>	 Ah, so it's semi-random? Fun.
[18:19:08] <grrrit-wm>	 (03PS2) 10Catrope: Remove unused $popupOverlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192573 (owner: 10Esanders)
[18:21:36] <James_F>	 edsanders: So…
[18:21:41] <edsanders>	 so
[18:22:29] <James_F>	 edsanders: Options: (a) don't have a done button (b) have one in the panel list at the top (c) have one in the panel list at the bottom (d) have one in the character list floating at the top next to the save button (e) have its own bottom bar just for it.
[18:22:42] <James_F>	 edsanders: I prefer b > a > c > d > e.
[18:22:45] <James_F>	 edsanders: Thoughts?
[18:31:00] <James_F>	 edsanders: In terms of things to review + merge: https://gerrit.wikimedia.org/r/#/c/190400/ https://gerrit.wikimedia.org/r/#/c/189628/ https://gerrit.wikimedia.org/r/#/c/191658/ https://gerrit.wikimedia.org/r/#/c/192047/ https://gerrit.wikimedia.org/r/#/c/192495/ https://gerrit.wikimedia.org/r/#/c/186548/
[18:32:46] <edsanders>	 James_F, not (a) or (d)
[18:33:35] <James_F>	 edsanders: B then?
[18:33:47] <James_F>	 [ ^ Done ] or something.
[18:34:05] <edsanders>	 playing around with the layout
[18:34:20] <edsanders>	 none of them look great
[18:34:28] * James_F nods.
[18:37:30] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] "Looks ok to me, will let Roan re-test." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle)
[18:38:36] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Remove unused $popupOverlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192573 (owner: 10Esanders)
[18:40:27] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo)
[18:40:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove unused $popupOverlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192573 (owner: 10Esanders)
[18:42:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adjust Queue and Provider to work with generalized parents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189628 (owner: 10Mooeypoo)
[18:43:19] <mvolz>	 mooeypoo: what was it you wanted to chat about?
[18:46:12] <mooeypoo>	 mvolz, not urgent at all if you're busy with the services thing. I am just trying to understand the cases where we get an error that is not a 520 in the Citoid extension, and if there's a way to reproduce it for testing
[18:46:47] <grrrit-wm>	 (03PS9) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[18:50:27] <mvolz>	 there are 404s for when you try to export something to a format citoid doesn't understand 
[18:50:32] <mvolz>	 but VE wouldn't do that
[18:51:12] <mvolz>	 and 400 if you are missing an argument
[18:51:20] <mvolz>	 also something VE wouldn't do
[18:52:05] <mvolz>	 "mediawiki" is a semi native format, so if Zotero is not working it can still export to that.
[18:52:15] <mvolz>	 only unhappy if you ask for bibtex or something. 
[18:52:17] <mooeypoo>	 mvolz, the code has a path where if the error is not 520, we display a mw.notify message -- I am trying to see if we can be a bit more specific in the message and also how often if at all such message will ever pop up
[18:52:47] <mooeypoo>	 sounds like it really shouldn't
[18:53:09] <mvolz>	 the only other thing is if citoid isn't responding to requests at all
[18:53:15] <mvolz>	 i.e. is dead
[18:53:25] <mvolz>	 or it's possible that it gets overloaded and times out or something
[18:53:51] <mvolz>	 but not easy to replicate that. if you want to play around with it you can just put some code in to make citoid give you the error you want though.
[18:54:21] <mvolz>	 like app.post('/url', function(req, res){
[18:54:39] <mvolz>	 res.statusCode = 5000000;
[18:54:47] <mvolz>	 res.send("fake error");
[18:54:50] <mvolz>	 in server.js
[18:54:53] <mvolz>	 and then run it :)
[18:54:54] <mooeypoo>	 hmm
[18:55:33] <mooeypoo>	 I'm more trying to figure out if we can make the error message a little less vague. IT sounds like the message we should have in there is "Service temporarily unavailable." 
[18:55:46] <mooeypoo>	 this message should appear and then offer the user to use one of the other dialogs
[18:55:53] <mvolz>	 yeah that sounds fine
[18:55:55] <mooeypoo>	 like, manualy fill out the info
[18:56:12] <mooeypoo>	 so I just wnat to make sure. IT sounds like this shouldn't really happen unless the service is either malfunctioning or down?
[18:56:30] <mvolz>	 well if it gets overloaded and times out
[18:56:30] <mooeypoo>	 or VE is malfunctioning and sending it bad parameters
[18:56:39] <mvolz>	 then a timeout might mean you could try again soon
[18:56:55] <mooeypoo>	 Do we have a way to indicate if it's a timeout or any other error?
[18:57:00] <mvolz>	 if it's not responding to requests at all then definitely offer the option
[18:57:35] <mooeypoo>	 ie, does it return some error code or should we account for timeouts
[18:59:01] <mvolz>	 not yet
[18:59:05] <mvolz>	 but I should do that
[18:59:06] <mvolz>	 :)
[19:00:01] <mvolz>	 so 408s. another thing to add to phab.
[19:00:02] <mvolz>	 :)
[19:00:13] <mvolz>	 I'm actually not sure how VE handles this
[19:00:26] <mvolz>	 does it also have a timer for web requests? I'm assuming it does
[19:02:22] <James_F>	 ori: https://gerrit.wikimedia.org/r/#/c/175488/
[19:02:22] <mooeypoo>	 mvolz, we're using promises for this. If we need to account for timeouts, I might have to add something in there.
[19:08:17] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192573 (owner: 10Esanders)
[19:08:32] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192569 (owner: 10Esanders)
[19:09:07] <Pickle-san>	 I describe a problem at this link: https://www.mediawiki.org/wiki/Extension_talk:VisualEditor#Selecting_.27Edit.27_button_produces_no_observable_result._53883.  I believe the problem stems from a simple configuration issue.  It's almost like there's an "air-gap" between MediaWiki and Parsoid.  Parsoid is working fine.  Is someone able to help me review my configuration?
[19:10:30] <James_F>	 Pickle-san: Are you sure the Web server can access that IP and port from the user process in which it runs?
[19:10:53] <James_F>	 Pickle-san: If you sudo www-data (or whatever) and then telnet to the IP/port, does it work?
[19:11:59] <Pickle-san>	 Thanks, James_F.  I believe so, but let me confirm.
[19:13:04] <James_F>	 Pickle-san: What browser are you using, and do you get any JavaScript errors in its log?
[19:13:40] <bmansurov>	 Hello, can someone help me with oojs-ui? I'm rendering a button in PHP and would like to control it with JS. How can I select the already rendered button with JS (without re-rendering it)? thanks
[19:15:15] <James_F>	 bmansurov: Wait for that code to land.
[19:15:24] <James_F>	 bmansurov: (It's not yet complete.)
[19:15:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused $popupOverlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192573 (owner: 10Esanders)
[19:15:43] <bmansurov>	 James_F: any idea when it will land?
[19:15:45] <James_F>	 Specifically, https://gerrit.wikimedia.org/r/#/c/190368/
[19:16:02] <bmansurov>	 James_F: ok thanks
[19:16:05] <James_F>	 bmansurov: MatmaRex will know more than me… possibly in the next week.
[19:16:13] <bmansurov>	 great!
[19:18:17] <MatmaRex>	 bmansurov: James_F: cscott was working on it, but i'm not sure how much of a priority it is for him, and i didn't want to "take over" the project
[19:18:41] <cscott>	 I'm actually working on that patch right this minute.
[19:19:03] <MatmaRex>	 <3
[19:19:12] <cscott>	 refactoring serialize->getConfig turns out to make a number of things nicer.
[19:19:19] <bmansurov>	 MatmaRex, cscott: I see. I'm trying to convert our buttons in MobileFrontend and would love to see this done sooner ;)
[19:19:37] <cscott>	 bmansurov: sooner than "I'm working on this right now"?
[19:20:07] <bmansurov>	 cscott: yes, right this instant ;) 
[19:20:12] <cscott>	 you're welcome to test using the patches in gerrit, it all works and the user-facing side won't change much.
[19:20:27] <cscott>	 unless the VE guys decide they want to paint the bikeshed a different color than "infusable".
[19:20:28] <bmansurov>	 cscott: is there any documentation?
[19:20:33] <James_F>	 cscott: ;-)
[19:20:43] <James_F>	 bmansurov: It's not even written yet. 
[19:20:57] <James_F>	 bmansurov: But in principle the code should be self-documenting.
[19:21:04] <cscott>	 bmansurov: see the phab ticket, and the patch.  there's really only two user-visible methods:
[19:21:12] <bmansurov>	 ok
[19:21:18] <cscott>	 'infusable=>true' on the PHP side to mark those widgets you want to export to JS land.
[19:21:42] <cscott>	 and OO.ui.infuse('an-HTML-id') to get the widget corresponding to your infusable widget.
[19:21:51] <bmansurov>	 great, thanks
[19:21:54] <cscott>	 it helps to also set 'id' => 'something-sane' on the PHP side, of course.
[19:22:02] <cscott>	 but that's not a "new" interface, per se.
[19:24:08] <Pickle-san>	 James_F: The issue is present in all browsers.  With Firefox, there is a JavaScript error that occurs when the page is first rendered, but not when the "Edit" link is selected.  The error is -- Error: JavaScript parse error: Parse error: Missing operand in file 'MediaWiki:Common.js' on line 15 load.php:1
[19:24:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Needs rebasing." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187144 (owner: 10Esanders)
[19:25:03] <grrrit-wm>	 (03PS2) 10Jforrester: PopupButtonWidget: Add description and example and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/192485 (owner: 10Kmenger)
[19:25:10] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] PopupButtonWidget: Add description and example and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/192485 (owner: 10Kmenger)
[19:25:38] <James_F>	 Pickle-san: Aha. You've got a broken MediaWiki:Common.js file and it's poisoning all JS on the page.
[19:26:02] <James_F>	 Pickle-san: Blank that file (or work out what's broken with it and fix it) and theoretically VisualEditor should just work.
[19:26:02] <Pickle-san>	 James_F: We have validated previously that a page can be parsed when passed directly to Parsoid.
[19:27:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: PopupButtonWidget: Add description and example and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/192485 (owner: 10Kmenger)
[19:27:25] <grrrit-wm>	 (03PS3) 10Jforrester: FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[19:27:30] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[19:30:22] <Pickle-san>	 James_F: We found one file in the entire distribution that had a name resembling Common.js.  It did not even have 15 lines.
[19:30:53] <RoanKattouw>	 Pickle-san: He means the wiki page MediaWiki:Common.js
[19:32:08] <James_F>	 Pickle-san: As in http://99.99.99.99/wiki/MediaWiki:Common.js – click "edit source" and then blank it.
[19:33:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: FlaggedElement: Add description of event and config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/192477 (owner: 10Kmenger)
[19:34:34] <grrrit-wm>	 (03PS8) 10Jforrester: Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński)
[19:37:02] <Pickle-san>	 James_F: We've blanked out the page.  The JavaScript error is gone, but the issue I'm trying to resolve is still present.  A developer is looking at it with me.  There is definitely some squirrely code on the page that JavaScript would not appreciate.  How
[19:37:37] <James_F>	 Pickle-san: Hmm.
[19:39:19] <Pickle-san>	 James_F: I wonder whether I'm dealing with just a brain-dead configuration issue.
[19:39:46] <James_F>	 Pickle-san: The config you posted looked fine, but possibly.
[19:42:08] <Pickle-san>	 James_F: The Interwiki setting in parsoid/api/LocalSettings.js is what MediaWiki needs to latch onto, correct?
[19:42:40] <James_F>	 Pickle-san: The config in Parsoid is what lets Parsoid find MediaWiki; if you can confirm that Parsoid is working, then that's fine.
[19:44:09] <Pickle-san>	 James_F: OK, then we're good.  What's interesting is that the symptoms are like what another user reports as happening when VisualEditor is simply absent.  I've pursued the notion that perms might be too restrictive.
[19:45:00] <James_F>	 Pickle-san: If you're not getting the VE edit tab (but you are getting the wikitext edit tab re-labelled as "Edit Source") then something's broken with your JavaScript or you're being detected as a blacklisted browser.
[19:45:25] <James_F>	 Pickle-san: If you get the VE edit tab but clicking it does nothing, that's more awkward to diagnose.
[19:46:43] <Pickle-san>	 Picke-san: Yeah, even the browser logs are silent.  The HTTP logs don't give any clues, either.
[19:47:18] <James_F>	 In that case I may not be able to help much. :-(
[19:47:41] <Pickle-san>	 James_F: Maybe we can try to fix the Common.js code and put it back.
[19:48:11] <James_F>	 Pickle-san: Possibly, but that won't improve the VisualEditor issue.
[19:51:09] <Pickle-san>	 James_F: OK, good to know.  Yeah, the Edit link is present, but silent.  The observation we've made is almost that the software believes it is in VisualEditor mode, without actually going there.  For example, select "Edit Source," then "Edit" -- the URL is appropriate, but the page is effectively like "Read."
[19:51:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński)
[19:51:33] <James_F>	 Pickle-san: Are you absolutely sure there's nothing in the browser console when you click Edit?
[19:52:28] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Unbreak docparser.rb [oojs/ui] - 10https://gerrit.wikimedia.org/r/192610 
[19:52:46] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Code no work." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński)
[19:52:54] <James_F>	 MatmaRex: :_D
[19:53:02] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "The job now fails because someone has managed to break the doc parser, fixed in https://gerrit.wikimedia.org/r/192610" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński)
[19:53:32] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Whoops." [oojs/ui] - 10https://gerrit.wikimedia.org/r/192610 (owner: 10Bartosz Dziewoński)
[19:54:23] <prr>	 (working with Pickle-san) I get about 20 lines on the console when I click edit... nothing all that alarming.  For example: Expected 'important' but found 'ie'.  Expected ';' or '}' to terminate declaration but found 'ie'.  Declaration dropped. Main_Page:10
[19:54:47] <James_F>	 prr: Which browser are you using?
[19:55:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Unbreak docparser.rb [oojs/ui] - 10https://gerrit.wikimedia.org/r/192610 (owner: 10Bartosz Dziewoński)
[19:55:39] <prr>	 James_F: firefox 35.0.1 on windows 7
[19:55:50] <grrrit-wm>	 (03PS9) 10Bartosz Dziewoński: Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) 
[19:56:16] <James_F>	 prr: Hmm.
[19:57:24] <James_F>	 prr: And does visting https://www.mediawiki.org/wiki/VisualEditor:Test?veaction=edit work?
[19:59:36] <Pickle-san>	 James_F: When I go to our version that page, I see Create and Create Source.  Create Source works, Create does nothing.
[20:00:10] <James_F>	 Pickle-san: Sure. Does it definitely work in your browser on MediaWiki.org though?
[20:00:31] <prr>	 James_F: yep, worked for me.  I got a welcome dialog, and then a formatting toolbar.
[20:00:53] <James_F>	 Good. OK, so your browser isn't the issue. :-)
[20:01:04] <Pickle-san>	 James_F: Yes, it does work.
[20:01:39] <James_F>	 In that case, if in the console you click on the "JS" filter and unselect "Warnings", how many issues come up when you click Edit?
[20:01:44] <James_F>	 (On your site this time.)
[20:03:21] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (31fb72a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192616 
[20:03:53] <prr>	 James_F: correct.  I deselected everything (net, css, etc) except javascript errors, clicked edit, got 0 lines on console
[20:04:10] <James_F>	 prr: OK, in that case I'm totally out of ideas. :-(
[20:04:11] <Pickle-san>	 James_F: By the way, based on the link you sent us, VisualEditor looks really cool.  We're looking forward to using it.  Are you on the development team?
[20:04:24] <James_F>	 Pickle-san: I'm the product manager.
[20:04:40] <James_F>	 Pickle-san: And glad you like the look of it; so sorry it's been such a pain for you to get set up
[20:04:48] <James_F>	 We're a long way from "turn-key" situation.
[20:04:55] <prr>	 James_F: yes, very impressive.  a huge leap forward
[20:05:39] <Pickle-san>	 James_F: I've spoken to our management.  We might have a little budget with which to engage some consulting assistance.  Is such a thing possible?
[20:10:12] <James_F>	 prr: Thanks.
[20:10:41] <James_F>	 Pickle-san: We're not really set up for consultancy services, I'm afraid (we're a non-profit, and experts in VisualEditor outside our team are so far quite scarce).
[20:11:15] <Pickle-san>	 James_F: OK, fine, say it like it is.  :o)
[20:11:32] <James_F>	 Pickle-san: That said, we like to be helpful. :-)
[20:13:47] <Pickle-san>	 James_F: I'm just wondering whether someone who knew what they were doing could take a quick tour of our installation and point out my idiocy within a matter of minutes.  I have tried to follow the instructions online, and have re-traced my steps many times.  We are running this on CentOS 6, which does not appear to be specifically addressed in the instructions.  Linux is Linux, but are there any known weirdnesse
[20:14:23] <James_F>	 Pickle-san: Probably. Linux distributions love to make life difficult for cross-distro support, yes.
[20:15:28] <Pickle-san>	 James_F: Is there some way I could tar up my installation and put it on an FTP site for someone to examine?
[20:16:31] <RoanKattouw>	 Hmm
[20:16:55] <Pickle-san>	 James_F: By the way, if we get to the bottom of this, I would volunteer to write up text for the online documentation.  Perhaps that can be my contribution to the cause.
[20:17:00] <RoanKattouw>	 Pickle-san: Could you go to a page using ?debug=true in the query string, try to open VE, and see if there are any console errors then?
[20:21:01] <Pickle-san>	 RoanKattouw: Cool.  I see a progress bar in the upper right.  Motion is from left to right.  My guess is that it is hung indefinitely.
[20:21:21] <RoanKattouw>	 Probably
[20:21:24] <RoanKattouw>	 Anything in the console?
[20:21:50] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński)
[20:22:19] <RoanKattouw>	 (Also does the URL bar say ?debug=true&veaction=edit or something similar?)
[20:25:49] <Pickle-san>	 RoanKattouw: TypeError: $.browser is undefined TypeError: invalid 'instanceof' operand originFn Use of Mutation Events is deprecated. Use MutationObserver instead. TypeError: originFn is undefined Error: Property "onSplice" is not a function
[20:26:01] <RoanKattouw>	 Oh wow
[20:26:03] <RoanKattouw>	 OK
[20:26:13] <RoanKattouw>	 Can you see which files it blames these errors on?
[20:26:50] <RoanKattouw>	 That's sometimes visible on the right-hand side
[20:27:36] <Pickle-san>	 RoanKattouw: Sorry.  Here it is with file and line numbers:  TypeError: $.browser is undefined ve.ce.BranchNode.js:65 TypeError: invalid 'instanceof' operand originFn oojs.jquery.js:79 Use of Mutation Events is deprecated. Use MutationObserver instead. load.php:4359 TypeError: originFn is undefined oojs.jquery.js:141 Error: Property "onSplice" is not a function oojs.jquery.js:574
[20:28:16] <RoanKattouw>	 Pickle-san: What version of VE are you using?
[20:28:27] <RoanKattouw>	 master from git? A release tarball from somewhere?
[20:30:37] <Pickle-san>	 RoanKattouw: Got it via git about two months ago.  How can I determine the version?
[20:31:30] <RoanKattouw>	 Pickle-san: Run 'git log -1 --oneline'
[20:32:05] <Pickle-san>	 RoanKattouw: 9883566 Update VE core submodule for cherry-picks to make math inspector work.
[20:32:41] <RoanKattouw>	 OK
[20:33:28] <RoanKattouw>	 Pickle-san: Could you update to the latest version?
[20:34:09] <Pickle-san>	 RoanKattouw: What command could I use to update?  Is it rebase?  Sorry, I'm not a git user yet . . . .
[20:34:14] <RoanKattouw>	 No worries
[20:35:35] <RoanKattouw>	 You appear to be in a bit of a weird setup, but hopefully the following will work:
[20:35:37] <RoanKattouw>	 git checkout master
[20:35:39] <RoanKattouw>	 git pull
[20:35:43] <RoanKattouw>	 git submodule update
[20:36:03] <Pickle-san>	 RoanKattouw: All from within the VisualEditor sandbox?
[20:36:56] <RoanKattouw>	 From the same directory where you ran that git log command
[20:40:17] <Pickle-san>	 RoanKattouw: Now the Edit link is gone entirely.  Only Read and Edit Source.  I believe the other code was on a branch.
[20:40:38] <Pickle-san>	 RoanKattouw: I have also restarted HTTPD and Parsoid.
[20:42:12] <RoanKattouw>	 Hmm
[20:42:13] <RoanKattouw>	 Oh which version of MediaWiki are you using?
[20:45:36] <RoanKattouw>	 Yeah it looks like you were using the REL1_23 branch before
[20:47:19] <Pickle-san>	 RoanKattouw: 1.25 for MediaWiki.  There is a 500 error when I refresh the page.
[20:47:51] <prr>	 [Tue Feb 24 13:59:42 2015] [error] [client 10.20.9.123] PHP Fatal error:  Class 'ExtensionRegistry' not found in /var/www/mediawiki-1.25/core/extensions/VisualEditor/VisualEditor.hooks.php on line 428
[20:47:55] <RoanKattouw>	 Hah
[20:48:00] <RoanKattouw>	 What version of 1.25 exactly?
[20:48:11] <RoanKattouw>	 1.25 hasn't been released yet so you must be using a version from git
[20:51:05] <Pickle-san>	 RoanKattouw: d267437 Merge "resourceloader: Refactor empty value trimming for mw.loader.register"
[20:53:02] <werdna>	 TrevorParscal, RoanKattouw, matmarex, how plausible is it to add a hover/click CSS class to the OOUI CSS that causes exactly the same behaviour as if it were hovered/clicked by a user?
[20:53:38] <werdna>	 (For visual regression testing with PhantomCSS)
[20:53:47] <TrevorParscal>	 so..
[20:53:53] <TrevorParscal>	 there used to be more of that, actually
[20:54:03] <RoanKattouw>	 Pickle-san: OK, could you try updating MW core then?
[20:54:04] <TrevorParscal>	 we would set a class on hover and mousedown
[20:54:24] <RoanKattouw>	 Pickle-san: Same steps as before except in the core directory
[20:54:27] <TrevorParscal>	 it was a little over the top, since that behavior mostly works fine in browsers
[20:54:37] <TrevorParscal>	 (:active is pretty broken in older IE)
[20:54:58] <TrevorParscal>	 so, we style using :hover and :active more now, to make things work better in the PHP version
[20:55:21] <TrevorParscal>	 but, we could bring back more of that stuff and select against both (makes the selectors and the JS more complex)
[20:55:33] <werdna>	 TrevorParscal: nod, but could I go through the CSS and add .oo-hover to any rules with :hover?
[20:55:41] <TrevorParscal>	 the good thing is it makes things like emulating mouse-like interaction using touch events easy
[20:55:50] <TrevorParscal>	 because touchstart can add a class
[20:56:08] <TrevorParscal>	 otherwise we have to lean on the browser to emulate :active and :hover, which it does a terrible job at
[20:56:15] <TrevorParscal>	 so, I think this is helpful for both cases
[20:56:34] <werdna>	 Jared and Dan are insisting that we have a visual regression test without emulating hover and active events.
[20:56:36] <TrevorParscal>	 well, you don't want to go too bonkers with it, it will make a mess
[20:56:59] <cscott>	 so.... is the namespace for OOui `oo` or `OO`?
[20:57:10] <werdna>	 I happen to think it's wrongheaded, because it adds an extra layer of failure possibilities, I think it's much better to emulate the events in whatever regression testing we do.
[20:57:12] <TrevorParscal>	 I think you should try doing it on ButtonElement (which nearly everything clickable uses anyway)
[20:57:12] <cscott>	 OOjs-core seems to use `oo` but OOui uses `OO`?
[20:57:32] <werdna>	 But there you go
[20:57:32] <TrevorParscal>	 in JS we use OO, in CSS we use oo
[20:57:35] <werdna>	 I can give it a go.
[20:57:53] <TrevorParscal>	 OOjs core does that internally, that's just a mess that needs to be cleaned up - it exports to OO
[20:57:58] <RoanKattouw>	 cscott: IIRC the global object is OO but OOjs-core does something like var oo = window.OO;
[20:58:17] <cscott>	 oo
[20:58:18] <werdna>	 By the way, I'm going to have a shitload of bugs against OOUI PHP a -- FieldsetLayouts for example are totally broken.
[20:58:22] <RoanKattouw>	 Or ( function ( oo ) { all the code is here } )( OO );
[20:58:22] <TrevorParscal>	 in the past we had the global named oo, but lowercase globals are a bit evil
[20:58:29] <cscott>	 werdna: really?  they work for me.
[20:58:41] <TrevorParscal>	 werdna: bugs are always welcome
[20:59:13] <werdna>	 I was counting on it :)
[20:59:16] <MatmaRex>	 totally?
[20:59:34] <TrevorParscal>	 likely if you are finding bugs you are using it in ways nobody else is, so they will get triaged as a combination of "yeah, it does do that, we never noticed because we don't use it that way anywhere else" and "it's not meant to do that, this is a feature request for something that is meant to do that"
[20:59:37] <cscott>	 yeah, it's the "totally" that surprises me, too.  they are used in the demo, they are obviously not "totally" broken.
[20:59:40] <werdna>	 Well, I might be doing something wrong, but for me they don't align horizontally
[20:59:58] <werdna>	 I'm using the PHP bindings, remember.
[21:00:04] <cscott>	 werdna: as am i
[21:00:06] <MatmaRex>	 i need a screenshot to understand that sentece
[21:00:21] <TrevorParscal>	 werdna: also... the documentation may have misled you to believe it works differently than you expect
[21:00:47] <ori>	 hey RoanKattouw, I need a bit of help, if you have time
[21:00:55] <werdna>	 It appears correctly in PHP
[21:00:59] <TrevorParscal>	 in which case that's likely to be either a documentation issue or a feature request
[21:01:00] <werdna>	 Erm, in JS
[21:01:00] <RoanKattouw>	 ori: Sure
[21:01:10] <ori>	 RoanKattouw: I'll PM
[21:01:10] <werdna>	 Anyway, I'll give you a test case.
[21:01:25] <Pickle-san>	 RoanKattouw: Alright, git actions performed, the Edit button is back.  The page is hanging as before.
[21:01:42] <werdna>	 Not right now but when I'm working again tomorrow
[21:01:54] <RoanKattouw>	 Pickle-san: Any errors in the console? If there are none, try with the ?debug=true thing from before
[21:02:25] <MatmaRex>	 werdna: screeeenshoooots
[21:02:58] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Allow passing positional parameters inside the config object [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) 
[21:02:59] <werdna>	 MatmaRex: I overwrote my test case, it's 10pm and I'm on my tablet, so I'll get it to you tomorrow :p
[21:03:25] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński)
[21:04:45] <Pickle-san>	 RoanKattouw: Holy smokes, it's a bit of a wait, but we have it!  VisualEditor lives! I just about had a heart attack!
[21:06:57] <ori>	 Pickle-san: \o/
[21:07:05] <RoanKattouw>	 Sweet!
[21:07:13] <Pickle-san>	 RoanKattouw: Thank you for your help!  I'm going to give VisualEditor a test drive.  I think our conclusion is that we were in some sort of discombobulated state of git-ness.
[21:07:31] <RoanKattouw>	 Yeah you were running VE 1.23 with MW 1.25-alpha
[21:08:07] <RoanKattouw>	 Then after updating VE you were running VE 1.25-alpha with MW 1.25-slightly-older-alpha
[21:08:16] <RoanKattouw>	 But it's -alpha so we break compat all the time
[21:08:53] <RoanKattouw>	 So now you're running VE 1.25-alpha-from-today with MW 1.25-alpha-from-today
[21:10:08] <Pickle-san>	 RoanKattouw: Excellent.  I will make a note of this.
[21:10:30] <Pickle-san>	 RoanKattouw: What is the projected date of general release?
[21:10:37] <RoanKattouw>	 For 1.25? I don't knwo
[21:11:05] <RoanKattouw>	 " The 1.25.0 stable release is expected to come out on Wednesday, May 27, 2015."
[21:11:27] <Pickle-san>	 RoanKattouw: Cool, thank you.
[21:15:08] <Pickle-san>	 RoanKattouw: I cannot begin to tell you how exciting this is.  Next time you're in Denver, let us know.  We'll buy you your memory stick of choice.  :o)
[21:15:29] <RoanKattouw>	 haha
[21:19:14] <grrrit-wm>	 (03PS1) 10Ori.livneh: [WIP] Reduce reliance of IndexValueStore hashing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192694 
[21:21:57] <grrrit-wm>	 (03PS2) 10Ori.livneh: [WIP] Reduce reliance of IndexValueStore hashing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192694 
[21:26:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Reduce reliance of IndexValueStore hashing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192694 (owner: 10Ori.livneh)
[21:26:19] <James_F>	 Heya.
[21:26:38] <grrrit-wm>	 (03PS1) 10Ori.livneh: [WIP] Reduce reliance of IndexValueStore hashing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192698 
[21:26:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Reduce reliance of IndexValueStore hashing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192698 (owner: 10Ori.livneh)
[21:27:43] <ori>	 (tests expected to fail, I'm using gerrit as a fancy way of delivering a patchfile to RoanKattouw for a sanity check)
[21:28:35] <James_F>	 ori: :-)
[21:28:56] <anomie>	 I'd like to have an oojs-ui BookletLayout embedded in a page, instead of having a dialog covering up the page. It seems like it needs to be put in a relatively-positioned div with an explicit height to work, any tips on figuring out a responsive height? Or am I just crazy?
[21:29:35] <James_F>	 MatmaRex ^^^
[21:30:26] <MatmaRex>	 maybe
[21:31:37] <MatmaRex>	 anomie: try passing `expanded: false` to your PageLayouts
[21:32:20] <MatmaRex>	 does that help?
[21:32:56] <anomie>	 MatmaRex: Doesn't seem to.
[21:35:22] <anomie>	 MatmaRex: If I don't put an explicit height on the element I .append() the booklet.$element to, it decides to render itself with a 0 height. And if I don't use a position:relative container at all, the booklet absolutely positions itself over the other content on the page.
[21:35:56] <MatmaRex>	 i'm reading the code. haven't looked at it in a while, and it was reworked a bit recently
[21:39:07] <MatmaRex>	 anomie: but you're right. it seems to be intentional.
[21:40:25] <MatmaRex>	 BookletLayout is apparently intended to be used within dialogs only
[21:41:00] <anomie>	 MatmaRex: If you can tell me how to determine the usable height of the browser window with jQuery (and what the right event to hook to get notified of changes), I could just set the height of my container.
[21:41:11] * anomie is not terribly familiar with jQuery
[21:41:36] <MatmaRex>	 anomie: as in, viewport height? $(window).height()
[21:42:29] <anomie>	 MatmaRex: viewport sounds right. Does jQuery have an event for when the viewport changes?
[21:42:50] <MatmaRex>	 $(window).on('resize', function(){}
[21:42:53] <MatmaRex>	 )
[21:42:56] <anomie>	 Thanks!
[21:45:22] <MatmaRex>	 hmm, we could probably rejigger things to work without absolute positioning
[21:46:16] <MatmaRex>	 but, eh
[21:53:00] <ryasmeen>	 James_F: So https://phabricator.wikimedia.org/T89192 is working in Betalabs now, but this was broken in wmf16, so we are backporting it to wmf 18 right?
[21:54:35] <James_F>	 ryasmeen: No.
[21:55:07] <James_F>	 ryasmeen: Too much deployment risk, I think. :-(
[21:57:07] <ryasmeen>	 James_F: hmm okay then. 
[22:01:06] <James_F>	 ryasmeen: https://phabricator.wikimedia.org/maniphest/query/yqmDy7sZacYK/#R is looking good. :-)
[22:01:51] <grrrit-wm>	 (03CR) 10GWicke: "I was about to say 'testing' too, but mobrovac beat me to it ;)" (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) (owner: 10Mvolz)
[22:02:52] <grrrit-wm>	 (03CR) 10GWicke: [C: 031] "+1, but should definitely be improved upon (tests, logging, metrics)." [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) (owner: 10Mvolz)
[22:04:35] <ryasmeen>	 James_F: yeah, oh its not sorted by priority anymore I see
[22:04:51] <James_F>	 ryasmeen: It's not grouped, yeah, you can fiddle with the options.
[22:05:30] <ryasmeen>	 James_F: yeah will do that!
[22:10:01] <Krenair>	 James_F, action.abort.type - what are we going to do about these cases where multiple values can be correct?
[22:10:21] <James_F>	 Krenair: What cases are those?
[22:11:21] <Krenair>	 James_F, "nochange" could apply with any of the other options for example
[22:12:04] <Krenair>	 if they try to change editors after they clicked save, it can be both switchwithout and also abandonMidsave
[22:12:20] <Krenair>	 and also potentially nochange, of course
[22:12:48] <grrrit-wm>	 (03PS1) 10Mvolz: [WIP] Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[22:12:54] <James_F>	 Krenair: No. switchWithout means you're switching editors during an edit. abandonMidsave is the only valid possibility there.
[22:13:11] <grrrit-wm>	 (03PS2) 10Mvolz: [WIP] Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[22:13:31] <James_F>	 Krenair: abandonMidsave + noChange gives the user a few milliseconds to achieve it, but in that case just go with abandonMidsave again.
[22:14:51] <Krenair>	 preinit - I don't think we can do much here? can we log before the page is ready?
[22:15:22] <Krenair>	 We probably shouldn't really be detecting VE's tab inside WikiEditor
[22:17:56] <James_F>	 Krenair: Well, I guess we can only log be inference.
[22:18:05] <James_F>	 Err. By inference, even.
[22:38:10] <Krenair>	 James_F, the other issue with action.saveFailure.type remains unresolved
[22:39:44] <James_F>	 Krenair: Which one is that?
[22:39:58] <Krenair>	 The same one I keep telling you about.
[22:40:38] <James_F>	 Krenair: Which one? So far today alone you've complained about five or so different things and yet refused to (a) write them down or (b) explain them with any context.
[22:41:45] <Krenair>	 5 or so different things?
[22:42:02] <James_F>	 I don't know.
[22:42:08] <James_F>	 You're the one with the problems. :-)
[22:42:24] <Krenair>	 Maybe, but if you want this un-stalled...
[22:42:30] <Krenair>	 I have already written down the issue with action.saveFailure.type and you were CC'd
[22:42:34] <Krenair>	 Date: Fri, 13 Feb 2015 23:51:47 +0000
[22:44:08] <James_F>	 Krenair: I'm CC'ed on > 500 e-mails a day. :-)
[22:45:13] <James_F>	 Krenair: Right now I'm replying to four distinct e-mails from Lila alone.
[22:45:19] <Krenair>	 Subject: On the topic of wikitext instrumentation
[22:47:44] <grrrit-wm>	 (03PS3) 10Mvolz: [WIP] Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[22:49:57] <Krenair>	 James_F, if WikiEditor fails to fill out these fields properly, will the data still be useful?
[22:55:47] <grrrit-wm>	 (03CR) 10Cscott: [C: 04-1] Allow passing positional parameters inside the config object (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński)
[22:56:36] <grrrit-wm>	 (03CR) 10Mvolz: Use html-metadata library (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) (owner: 10Mvolz)
[22:58:28] <grrrit-wm>	 (03CR) 10Cscott: Allow passing positional parameters inside the config object (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński)
[23:04:22] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] WIP Redirect diff view changed. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192718 
[23:10:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] WIP Redirect diff view changed. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192718 (owner: 10Cmcmahon)
[23:19:12] <BladeBronson>	 oh, wrong job. :)
[23:22:18] <mooeypoo>	 O.O
[23:30:52] <grrrit-wm>	 (03PS14) 10Cscott: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) 
[23:30:54] <grrrit-wm>	 (03PS12) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) 
[23:30:56] <grrrit-wm>	 (03PS1) 10Cscott: Allow passing positional parameters inside the config object [oojs/ui] - 10https://gerrit.wikimedia.org/r/192722 (https://phabricator.wikimedia.org/T89687) 
[23:30:58] <grrrit-wm>	 (03PS1) 10Cscott: Element: Add `content` config option, matching PHP side. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192723 
[23:32:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott)
[23:32:25] <grrrit-wm>	 (03CR) 10Cscott: "I didn't want to stomp on your patch -- I forked it and applied the suggestions I made above in https://gerrit.wikimedia.org/r/192722 so t" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński)
[23:32:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Element: Add `content` config option, matching PHP side. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192723 (owner: 10Cscott)
[23:36:50] <wikibugs>	 10VisualEditor, 6Release-Engineering, 7Browser-Tests: Selenium bug with Firefox causes VE test failure - https://phabricator.wikimedia.org/T90651#1064254 (10greg)
[23:37:01] <James_F>	 ryasmeen: Do you want to start on the VE weekly write-up?
[23:37:32] <ryasmeen>	 James_F:
[23:37:37] <grrrit-wm>	 (03PS2) 10Cscott: Element: Add `content` config option, matching PHP side. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192723 
[23:37:37] <ryasmeen>	 Yeah
[23:37:39] <grrrit-wm>	 (03PS15) 10Cscott: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) 
[23:37:41] <grrrit-wm>	 (03PS13) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) 
[23:38:08] <ryasmeen>	 James_F: will write up today
[23:38:39] <James_F>	 Krenair: Looking.
[23:39:22] <James_F>	 Krenair: In your e-mail mostly I see a "WikiEditor isn't great" observation…
[23:39:55] <James_F>	 Krenair: Failing to instrument AbuseFilter, SpamBlacklist etc. issues would be really sad, but eh.
[23:40:31] <Krenair>	 It might be possible to write some hack to detect those.
[23:40:33] <James_F>	 Krenair: The number 1 issues I care about are action.saveSuccess vs. action.saveFailure.
[23:40:38] <James_F>	 Krenair: Yeah.
[23:40:52] <Krenair>	 right. The patch I have in core should solve that, possibly with the exception of token failures
[23:40:54] <James_F>	 … and action.init vs. action.ready, maybe.
[23:41:55] <mooeypoo>	 TrevorParscal, can I open a new dialog from another dialog?
[23:42:24] <mooeypoo>	 TrevorParscal, I was trying to call the windowManager to open another dialog and then close the current dialog, but that failed. I assume that can't happen?
[23:43:06] <RoanKattouw>	 You can't, no
[23:43:22] <RoanKattouw>	 WindowManagers managing dialogs are typically exclusive
[23:43:49] <mooeypoo>	 RoanKattouw, ok, I'll open the other dialog after I close this one, then
[23:43:53] <RoanKattouw>	 I think the hack that the language inspector uses is it takes advantage of the fact that dialogs and inspectors use different window sets?
[23:44:06] <mooeypoo>	 RoanKattouw, I thought it uses another manager
[23:44:13] <RoanKattouw>	 Yeah, it does
[23:44:18] <RoanKattouw>	 s/window sets/WindowManagers/
[23:44:27] <RoanKattouw>	 (Sorry, WindowSet is the old name for WindowManager)
[23:44:36] <RoanKattouw>	 TrevorParscal is in a meeting right now but when he's back he might have more thoughts
[23:44:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott)
[23:44:56] <grrrit-wm>	 (03CR) 10Cscott: "Ok, this addresses the rest of MatmaRex's suggestions, I think." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott)
[23:45:25] <grrrit-wm>	 (03CR) 10Cscott: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott)
[23:48:07] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Re-enable VisualEditor by default for all users of the English Wikipedia - https://phabricator.wikimedia.org/T90662#1064313 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF
[23:48:39] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#1064321 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF
[23:49:03] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Re-enable VisualEditor by default for all newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90664#1064328 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF
[23:49:39] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1064336 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF
[23:50:28] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Run test of having VisualEditor on for some newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90666#1064348 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF
[23:51:34] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064360 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF
[23:51:54] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Re-enable VisualEditor by default for all newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90664#1064370 (10Jdforrester-WMF)
[23:51:55] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064360 (10Jdforrester-WMF)
[23:52:04] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064360 (10Jdforrester-WMF)
[23:52:05] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Run test of having VisualEditor on for some newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90666#1064348 (10Jdforrester-WMF)
[23:52:30] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064360 (10Jdforrester-WMF)
[23:56:33] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064395 (10Jdforrester-WMF)
[23:56:55] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064405 (10Jdforrester-WMF) p:5Normal>3High
[23:57:27] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1064406 (10Jdforrester-WMF) p:5Low>3Lowest
[23:59:14] <wikibugs>	 10VisualEditor, 10Citoid, 5§ VisualEditor Q3 Blockers: Citoid / citoid integration with VE is emitting data-mw for a template arg that is not compliant with the Parsoid DOMspec - https://phabricator.wikimedia.org/T90463#1064414 (10Jdforrester-WMF)
[23:59:24] <wikibugs>	 10VisualEditor, 5§ VisualEditor Q3 Blockers: [Regression wmf 18]  "Error: Offset could not be translated to a DOM element and offset" appears while deleting the text inside a bullet/numbered item and then cursor starts behaving weirdly while typing text - https://phabricator.wikimedia.org/T90478#1064415 (10Jdfo...
[23:59:30] <grrrit-wm>	 (03PS3) 10Cscott: Element: Add `content` config option, matching PHP side. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192723 
[23:59:31] <wikibugs>	 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Come up with a way of estimating load time and progress along that scale - https://phabricator.wikimedia.org/T90622#1064416 (10Jdforrester-WMF)
[23:59:33] <grrrit-wm>	 (03PS2) 10Cscott: Allow passing positional parameters inside the config object [oojs/ui] - 10https://gerrit.wikimedia.org/r/192722 (https://phabricator.wikimedia.org/T89687) 
[23:59:34] <grrrit-wm>	 (03PS16) 10Cscott: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) 
[23:59:36] <grrrit-wm>	 (03PS14) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716)