[00:03:06] Argh [00:03:32] Now I have to rebase against https://gerrit.wikimedia.org/r/#/c/186548/ :( [00:03:44] woot, mergeness [00:03:45] OTOH it kills the apiRequest function so that's one less problem for me [00:03:47] (03Merged) 10jenkins-bot: Unbreak form submission in JavaScript [oojs/ui] - 10https://gerrit.wikimedia.org/r/191834 (owner: 10Bartosz Dziewoński) [00:03:49] (03Merged) 10jenkins-bot: MediaWiki theme: Simplify spacing of checkboxes/radios in FieldLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/192088 (owner: 10Bartosz Dziewoński) [00:03:51] (03Merged) 10jenkins-bot: MenuOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192991 (owner: 10Kmenger) [00:03:53] (03Merged) 10jenkins-bot: RadioSelectWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/192979 (owner: 10Kmenger) [00:06:07] Krenair: WTF was there nothing using the form-data emulation stuff? :O [00:06:22] what? [00:06:37] Oh hmm it was the default [00:06:56] Krenair: So ve.init.mw.Target.static.apiRequest, which you removed, had this code to use multipart/form-data for POST requests by default [00:07:00] Was that functionality retained? [00:07:43] Like, does mw.Api have it? [00:07:45] * RoanKattouw looks [00:08:06] I'll be damned, it does [00:08:13] But it does require it to be enabled specifically [00:10:42] (03CR) 10Catrope: "FIXME: Put multipart/form-data back" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [00:14:08] RoanKattouw, ah, damn. [00:14:20] How badly has this broken things? [00:14:24] Not very [00:14:34] a performance issue? [00:14:35] I mean everything still works [00:14:45] It's just that POST requests for saves are bigger than they should be [00:14:57] Instead of base64-encoded gzip data they're now base64-encoded + URLencoded gzip data [00:15:03] ah. [00:15:21] Which isn't actually that bad come to think of it [00:15:33] but let's still avoid it [00:15:33] There are only a few characters in the base64 set that get encoded, like '+' and ',' [00:15:35] Yeah [00:15:40] should we do this for all VE POST requests? [00:15:48] Nah only ones with lots of data [00:16:00] We did do it for all of them before but that's wasteful [00:16:10] form-data only makes sense when you have few keys with large values [00:16:25] When you have many keys with short values, and URLencoding of the values isn't a big deal, then form-data is actually wasteful [00:17:15] alright, I'll upload a patch to fix that a little bit later [00:17:33] I guess us using form-data originates from when we were sending un-gzipped HTML, where URL-encoding is a big deal because of things like <, >, ", =, etc being quite common [00:17:35] OK cool [00:19:16] (03PS1) 10Kmenger: MenuSelectWidget: Add description and mark protected method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193004 [00:21:55] (03CR) 10Krinkle: "Yeah. Have someone ready to merge this commit; then deploy the new job and zuul config and recheck this commit and have it merged if passi" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 (owner: 10Legoktm) [00:26:13] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Research incrementally building the CE tree/DOM - https://phabricator.wikimedia.org/T90376#1068350 (10Jdforrester-WMF) [00:26:29] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Research incrementally building the CE tree/DOM - https://phabricator.wikimedia.org/T90376#1057179 (10Jdforrester-WMF) [00:26:41] (03CR) 10Krinkle: [C: 031] Add "composer test" command to lint PHP files and run phpcs [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 (owner: 10Legoktm) [00:27:15] 10VisualEditor, 5§ VisualEditor Q3 Blockers: Adding a template to an article on it.wp means VE gets "frozen" - https://phabricator.wikimedia.org/T90757#1068353 (10Aklapper) I could not reproduce this in Firefox 35 either, behavior was as expected: https://it.wikipedia.org/w/index.php?title=Utente%3AAKlapper_%2... [00:28:36] (03PS1) 10Mooeypoo: Delete boolean values if they are false [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/193007 (https://phabricator.wikimedia.org/T90283) [00:28:40] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/191766/ & https://gerrit.wikimedia.org/r/#/c/192981/ [00:29:02] (03CR) 10jenkins-bot: [V: 04-1] Delete boolean values if they are false [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/193007 (https://phabricator.wikimedia.org/T90283) (owner: 10Mooeypoo) [00:30:06] (03CR) 10Mooeypoo: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/193007 (https://phabricator.wikimedia.org/T90283) (owner: 10Mooeypoo) [00:30:57] (03CR) 10Catrope: [C: 04-1] Ask for whole revision when checking for existing TemplateData (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191766 (owner: 10Mooeypoo) [00:33:58] (03CR) 10Catrope: [C: 032] Correctly validate a provider for local api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192981 (https://phabricator.wikimedia.org/T90795) (owner: 10Mooeypoo) [00:36:06] (03Merged) 10jenkins-bot: Correctly validate a provider for local api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192981 (https://phabricator.wikimedia.org/T90795) (owner: 10Mooeypoo) [00:36:49] (03PS3) 10Mooeypoo: Ask for whole revision when checking for existing TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191766 [00:37:16] (03CR) 10jenkins-bot: [V: 04-1] Ask for whole revision when checking for existing TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191766 (owner: 10Mooeypoo) [00:37:43] (03PS4) 10Mooeypoo: Refactor MWMediaResultWidget to resize better [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 [00:44:49] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 5§ VisualEditor Q3 Blockers: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#1068435 (10Jdforrester-W... [00:44:50] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Tracking: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - https://phabricator.wikimedia.org/T50789#1068440 (10Jdforrester-WMF) [00:47:15] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#1068461 (10Jdforrester-WMF) [00:48:07] 10OOjs-UI: OOjs UI: Toolbar groups should support sub-groups as items - https://phabricator.wikimedia.org/T74159#1068464 (10Jdforrester-WMF) [00:48:08] 10OOjs-UI: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1068463 (10Jdforrester-WMF) [00:48:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1068462 (10Jdforrester-WMF) [00:53:59] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20): Cannot insert local picture in VisualEditor - https://phabricator.wikimedia.org/T90795#1068605 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [00:56:52] RoanKattouw: do you have a suggestion as to where to introduce asyncronicity to the surface creation? i.e., which function call should be modified to return a promise (and its callees modified accordingly)? [00:57:41] ori: You're not going to like my answer [00:57:51] ori: Right now a lot of work is performed in the constructors of ce.Node subclasses [00:58:13] In particular, all ce.Nodes that have children are subclasses of ce.BranchNode, whose constructor invokes the children's constructor [00:58:15] s [00:58:22] This is terrible for several reasons [00:58:33] One is that it doesn't lend itself to async-ifying that well [00:58:45] But also it makes our profiling data looks weird [00:59:01] yeah [00:59:07] it hides work [00:59:18] "we're not doing anything yet, we're just creating objects!" "oh look, we're all done" [01:01:26] Yeah exactly [01:01:36] So you'd have to find a way to separate adding children from the constructor [01:04:12] Hey. [01:04:14] legoktm: You want to deploy https://gerrit.wikimedia.org/r/#/c/192772/ and have me then +2 https://gerrit.wikimedia.org/r/#/c/192272/ to un-break the repo? [01:04:27] sure! [01:04:30] ori: Maybe the constructor could kick off an async process that builds the children, or something [01:04:51] Either that, or you make stuff build manually and just have the thing that builds it take breaks [01:04:52] legoktm: Let's do it. :-) [01:05:14] If you make it all promise-based, I'm afraid of what a tree of thousands of promises will do to performance [01:06:47] (03CR) 10Catrope: "Another thing that is now broken is we don't pass &uselang= with every API request any more, which matters in a few cases." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [01:07:15] * legoktm is deploying [01:09:45] (03PS1) 10Kmenger: TabIndexelement: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193019 [01:16:02] (03CR) 10Legoktm: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 (owner: 10Legoktm) [01:18:17] legoktm: Running the old jobs. [01:18:45] (03PS2) 10Jforrester: Add "composer test" command to lint PHP files and run phpcs [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 (owner: 10Legoktm) [01:19:05] why is it running phplint? [01:19:07] it shouldn't be. [01:19:08] legoktm: Still with the rebase. [01:19:17] I dunno. [01:19:23] Jenkins is magic. [01:19:33] actually this is zuul >.> [01:19:42] (03CR) 10Legoktm: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 (owner: 10Legoktm) [01:19:44] OK, Zuul is Black Magick. [01:19:46] Better? [01:19:52] Still phplint. [01:20:06] oh screw me [01:20:19] Missed a step? [01:21:04] James_F: I forgot to actually deploy it. It's running -composer now. [01:21:07] :-D [01:21:10] That helps. [01:21:18] (03CR) 10Jforrester: [C: 032] Add "composer test" command to lint PHP files and run phpcs [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 (owner: 10Legoktm) [01:21:30] (I can see it already passed oojs-ui-composer.) [01:22:19] woot, go team! [01:22:36] If only -npm ran faster. :-) [01:22:52] legoktm: Thanks for your help. [01:23:18] (03Merged) 10jenkins-bot: Add "composer test" command to lint PHP files and run phpcs [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 (owner: 10Legoktm) [01:30:51] (03PS1) 10Alex Monk: Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193024 [01:33:18] (03CR) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [01:35:58] (03CR) 10Jforrester: [C: 032] MenuSelectWidget: Add description and mark protected method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193004 (owner: 10Kmenger) [01:36:29] (03CR) 10Jforrester: [C: 032] TabIndexelement: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193019 (owner: 10Kmenger) [01:37:43] (03CR) 10Jforrester: [C: 032] "…" [oojs/core] - 10https://gerrit.wikimedia.org/r/192982 (owner: 10Jforrester) [01:40:20] (03Merged) 10jenkins-bot: Tag v1.1.5 [oojs/core] - 10https://gerrit.wikimedia.org/r/192982 (owner: 10Jforrester) [01:42:10] (03CR) 10Alex Monk: Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (https://phabricator.wikimedia.org/T1218) (owner: 10Alex Monk) [01:44:45] (03Merged) 10jenkins-bot: MenuSelectWidget: Add description and mark protected method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193004 (owner: 10Kmenger) [01:44:47] (03Merged) 10jenkins-bot: TabIndexelement: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193019 (owner: 10Kmenger) [01:45:41] (03PS1) 10Catrope: [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 [01:46:31] (03PS1) 10Alex Monk: Follow-up I18162f04: Send uselang parameter with paction=parse request [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193027 [01:46:58] (03CR) 10Alex Monk: "I70c2e6c4" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [01:47:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope) [01:47:56] (03CR) 10jenkins-bot: [V: 04-1] Follow-up I18162f04: Send uselang parameter with paction=parse request [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193027 (owner: 10Alex Monk) [01:49:56] (03CR) 10Alex Monk: "(This was for T67455)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193027 (owner: 10Alex Monk) [01:50:23] 01:46:50 chmod: changing permissions of `/mnt/home/jenkins-deploy/tmpfs/mwext-VisualEditor-qunit/locks': Operation not permitted [01:50:25] what [01:50:32] Krinkle, is it broken again? [01:51:04] ugh [01:51:08] No, it's a new error [01:51:12] Krinkle, Krenair, I got the same in TemplateData [01:51:15] casdcading down from the previous [01:51:22] yeah, it'll affect all mwcore/extensions qunit/phpunit [01:51:26] anything using tmpfs [01:51:46] 10VisualEditor, 10VisualEditor-MediaWiki: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1068831 (10Krenair) I don't think so. Pretty sure WikiEditor has this issue with live preview as well. [01:52:37] actually, this is fixed in puppet, but not on live instances because of stale state. New logic ensures the tmpfs dir is empty, but this is from an old build [01:54:02] so... we need to kick more hosts in labs? [01:57:45] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193027 (owner: 10Alex Monk) [01:58:15] Krenair: Nah, need to rm -rf tmpfs on all instances [01:58:16] I just did [01:58:25] The uid changed [01:58:34] this is cleaned up in teardown as of today [01:58:43] ok, great [01:58:59] but in directories created < today, they were not yet cleaned up, so it would find those locks on new builds as you observed [01:59:05] in which case it can't rm -rf or chmod it [01:59:12] one time clean up [01:59:23] (03PS1) 10Jforrester: Update OOjs to v1.1.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193029 [01:59:25] (03PS1) 10Jforrester: Update OOjs to v1.1.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193030 [02:00:27] (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193029 (owner: 10Jforrester) [02:00:52] (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193030 (owner: 10Jforrester) [02:02:20] (03Merged) 10jenkins-bot: Update OOjs to v1.1.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193029 (owner: 10Jforrester) [02:02:57] (03Merged) 10jenkins-bot: Update OOjs to v1.1.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193030 (owner: 10Jforrester) [02:04:33] (03PS1) 10Jforrester: Tag v0.8.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193032 [02:05:13] 10VisualEditor: "Read more" link is appearing even if the last line if the description of the image fits in the visible area - https://phabricator.wikimedia.org/T87265#1068849 (10Mooeypoo) I can't manage to reproduce this ever since the last update of the image info panel. Can you verify? [02:06:42] 10VisualEditor: "Read more" link is appearing even if the last line if the description of the image fits in the visible area - https://phabricator.wikimedia.org/T87265#1068850 (10Mooeypoo) Ignore that, I just found it. Investigating now. [02:06:54] (03CR) 10Catrope: [C: 032] Tag v0.8.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193032 (owner: 10Jforrester) [02:08:36] (03Merged) 10jenkins-bot: Tag v0.8.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193032 (owner: 10Jforrester) [02:11:35] (03PS1) 10Jforrester: Update OOjs UI to v0.8.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193033 [02:13:42] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.8.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193033 (owner: 10Jforrester) [02:13:57] RoanKattouw: Please +2 https://gerrit.wikimedia.org/r/#/q/I5ad8d6aac0fb4ef146ef4f36459e4b0e398a66e8,n,z including the C+2/V+2 dance with /vendor [02:17:02] 10OOjs-UI, 5OOjs-UI-0.8.1, 10UI-Standardization, 5Patch-For-Review: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1068868 (10Jdforrester-WMF) [02:17:04] 10OOjs-UI, 5OOjs-UI-0.8.1, 10VisualEditor, 7Browser-Support-Apple-Safari, and 2 others: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1068871 (10Jdforrester-WMF) [02:18:12] 10OOjs-UI, 10OOjs-UI-0.8.1, 10Continuous-Integration, 5WMF-deploy-2015-03-04_(1.25wmf20): Run the OOjs UI PHP test code on patchsets - https://phabricator.wikimedia.org/T87724#997358 (10Jdforrester-WMF) [02:18:13] 10OOjs-UI, 10OOjs-UI-0.8.1, 10VisualEditor, 7Browser-Support-Apple-Safari, and 3 others: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1033117 (10Jdforrester-WMF) [02:18:14] 10OOjs-UI, 10OOjs-UI-0.8.1, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20): Inconsistency in how child content is added to widgets - https://phabricator.wikimedia.org/T89750#1044403 (10Jdforrester-WMF) [02:18:15] 10OOjs-UI, 10OOjs-UI-0.8.1, 10Continuous-Integration, 5WMF-deploy-2015-02-25_(1.25wmf19), 5WMF-deploy-2015-03-04_(1.25wmf20): Include lib and dist into OOjs UI's jsduck output directory so the documentation examples work - https://phabricator.wikimedia.org/T90120#1052925 (10Jdforrester-WMF) [02:36:51] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [02:37:19] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) (owner: 10Alex Monk) [02:38:30] (03CR) 10jenkins-bot: [V: 04-1] Move insert media button to top level toolbar between cite and structure [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) (owner: 10Alex Monk) [03:29:38] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) (owner: 10Alex Monk) [03:56:20] 10VisualEditor, 10Continuous-Integration, 5§ VisualEditor Q3 Blockers: Investigate browser disconnect failures when running MediaWiki tests on labs slaves - https://phabricator.wikimedia.org/T89075#1068957 (10Krinkle) [04:57:24] (03PS1) 10Legoktm: jenkins job validation, do not submit [oojs/ui] - 10https://gerrit.wikimedia.org/r/193046 [04:59:31] 10MediaWiki-ResourceLoader: Remove mediawiki.action.history group - https://phabricator.wikimedia.org/T90842#1069032 (10Catrope) 3NEW a:3ori [04:59:51] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [oojs/ui] - 10https://gerrit.wikimedia.org/r/193046 (owner: 10Legoktm) [08:37:40] 10MediaWiki-Page-editing, 10MediaWiki-RfCs, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1069268 (10TheDJ) [08:42:16] 10MediaWiki-Page-editing, 10MediaWiki-RfCs, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1069277 (10TheDJ) [08:43:22] 10MediaWiki-Page-editing, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 7JavaScript, 5Patch-For-Review: Dynamically loading TimedMediaHandler for new content (preview) - https://phabricator.wikimedia.org/T74675#1069283 (10TheDJ) [09:09:16] hi guys [09:59:28] 10VisualEditor: Space at the start of a line is being nowikid - https://phabricator.wikimedia.org/T90533#1069372 (10Martijn_Hoekstra) I meant rendered on screen, rather than rendered in wikitext. The entire block " " can (and should?) be omitted altogether; the user certainly didn't intend to st... [10:12:51] 10VisualEditor, 10MediaWiki-extensions-Translate, 7I18n, 3LE-Sprint-83: not able to mark a page for translation at mediawiki.org - https://phabricator.wikimedia.org/T90704#1069403 (10Nikerabbit) There seems to be a general issue of too many and/or inefficient write queries against the message group stats t... [10:13:58] 10VisualEditor, 10MediaWiki-extensions-Translate, 7I18n, 3LE-Sprint-83: not able to mark a page for translation at mediawiki.org - https://phabricator.wikimedia.org/T90704#1069405 (10Nikerabbit) a:3Nikerabbit [10:39:00] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow: Implement VE layout from Pau's mockups - https://phabricator.wikimedia.org/T90764#1069434 (10Pginer-WMF) As discussed, since we want to keep the editing mode as a persistent preference it may not be clear how to preview to those users that prefer using the w... [10:41:02] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Update Gemfile.lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192729 (owner: 10Amire80) [10:42:21] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Update the scenario for Cite screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192730 (owner: 10Amire80) [10:43:19] (03Merged) 10jenkins-bot: [BrowserTest] Update Gemfile.lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192729 (owner: 10Amire80) [10:44:22] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Fix VisualEditor_More_Settings scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192731 (owner: 10Amire80) [10:44:59] (03Merged) 10jenkins-bot: [BrowserTest] Update the scenario for Cite screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192730 (owner: 10Amire80) [10:46:25] (03Merged) 10jenkins-bot: [BrowserTest] Fix VisualEditor_More_Settings scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192731 (owner: 10Amire80) [10:49:52] 10VisualEditor: Visual Editor default configuration - https://phabricator.wikimedia.org/T90854#1069438 (10Syleas) 3NEW [10:52:57] (03PS5) 10Amire80: [BrowserTest] Update the Edit tab scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192770 [10:53:04] (03PS6) 10Amire80: [BrowserTest] Update the Edit tab scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192770 [10:59:36] Hey all, having issues with parsoid and visualeditor, when I try and edit a page the loading bar pops up but then get an "Error loading data from server: parserror. Would you like to retry". running my mediawiki on https, and im not sure if that is issue at hand? any help would be greatly appreciated, thanks in advance [10:59:51] (03PS7) 10Amire80: [BrowserTest] Update the Edit tab scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192770 [11:00:36] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Update the Edit tab scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192770 (owner: 10Amire80) [11:02:39] (03Merged) 10jenkins-bot: [BrowserTest] Update the Edit tab scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192770 (owner: 10Amire80) [11:11:11] 10VisualEditor: Context menu moves to middle of inline selection when an inspector is opened - https://phabricator.wikimedia.org/T90857#1069478 (10Esanders) 3NEW a:3Esanders [11:12:31] (03PS1) 10Esanders: Prevent context from moving if selection is changed by opening [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193077 (https://phabricator.wikimedia.org/T90857) [11:12:33] (03CR) 10Bartosz Dziewoński: "Status: This is currently on hold, we might instead go with Krinkle's proposal from T89721." [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [11:21:44] Hi guys. Im using https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FVisualEditor.git/1f4335a1e234a64816347a1e50bc1d907033ef84 with 1.24 mediawiki. If i click on edit it just reopens the reading section [11:21:47] any suggestions? [11:32:32] (03CR) 10Esanders: Context refactor (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [11:33:17] (03CR) 10Esanders: [C: 04-1] "See also more replies on PS2 (although I don't consider them blockers to merging this)" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [11:36:36] 10VisualEditor, 5§ VisualEditor Q3 Blockers: Adding a template to an article on it.wp means VE gets "frozen" - https://phabricator.wikimedia.org/T90757#1069508 (10Elitre) I was even able to reproduce with Safari on a Mac, but couldn't upload the screencast due to Phab's size limit. I think the key here is posi... [11:39:38] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: "Welcome to VisualEditor" broken at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T90858#1069509 (10zeljkofilipin) 3NEW [11:55:38] (03CR) 10Esanders: [C: 04-1] "* If I edit an existing basic reference I get an exceptions when closing the dialog." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [11:59:11] (03CR) 10Esanders: "* If I insert a Cite-web the external link it renders opens in the same window." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [11:59:46] (03CR) 10Esanders: Context refactor (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [12:04:28] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: "Advanced settings" broken at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T90861#1069555 (10zeljkofilipin) 3NEW [12:29:15] Hey all, having issues with parsoid and visualeditor, when I try and edit a page the loading bar pops up but then get an "Error loading data from server: parserror. Would you like to retry". running my mediawiki on https, and im not sure if that is issue at hand? any help would be greatly appreciated, thanks in advance [12:31:22] Flayckz: Today_: hey, most people here are from american timezones, so you might have to wait a while for them to wake up :) [12:32:04] parsoid configuration is not one of the things i'm familiar with, alas [12:36:13] (03CR) 10Esanders: [C: 04-1] "PS3" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 (owner: 10Mooeypoo) [12:37:21] (03CR) 10Esanders: [C: 032] Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193024 (owner: 10Alex Monk) [12:39:31] (03Merged) 10jenkins-bot: Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193024 (owner: 10Alex Monk) [12:40:17] (03CR) 10Esanders: [C: 04-1] PopupWidget: Add keydown listener and hide popup on ESC (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [12:50:05] 10VisualEditor: Help VisualEditor users find the wikitext save button - https://phabricator.wikimedia.org/T90864#1069602 (10Nemo_bis) 3NEW [12:59:39] (03PS1) 10Jforrester: Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again [extensions/VisualEditor] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/193088 [13:02:12] 10OOjs-UI, 7Browser-Support-Opera: OOjs UI: trouble with CheckboxInputWidget in Opera - https://phabricator.wikimedia.org/T75517#1069638 (10matmarex) @Tacsipacsi If that happens only the first time when you check a checkbox, then that's possible, since the image will now only be loaded when necessary (previous... [13:08:27] (03PS13) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 [13:10:29] (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [13:13:40] (03PS14) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 [13:18:57] (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [13:27:03] (03PS15) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 [13:29:11] (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [13:29:27] (03PS1) 10Bartosz Dziewoński: InputWidget: Focus checkboxes and radios when the label is clicked, too [oojs/ui] - 10https://gerrit.wikimedia.org/r/193099 [13:42:31] 10MediaWiki-Page-editing, 7JavaScript: LivePreview fires wikipage.content hook before attaching content, which breaks some scripts - https://phabricator.wikimedia.org/T90851#1069674 (10Aklapper) [13:43:51] 10MediaWiki-Page-editing, 7JavaScript: LivePreview fires wikipage.content hook before attaching content, which breaks some scripts - https://phabricator.wikimedia.org/T90851#1069675 (10Aklapper) p:5Triage>3Normal [13:43:59] 10MediaWiki-Page-editing, 7JavaScript: LivePreview should give feedback when failing - https://phabricator.wikimedia.org/T90490#1069676 (10Aklapper) p:5Triage>3Normal [13:44:32] 10MediaWiki-Page-editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript: New improved LivePreview incompatible with ProofreadPage's fancy forms for Index: namespace pages - https://phabricator.wikimedia.org/T78709#1069677 (10Aklapper) p:5Triage>3Normal [13:57:25] 10MediaWiki-ResourceLoader: Remove mediawiki.action.history group - https://phabricator.wikimedia.org/T90842#1069741 (10Aklapper) p:5Triage>3Low [14:08:21] 10MediaWiki-Page-editing, 6Editing: Bogus "You have not provided an edit summary" message subsequent to edit conflict - https://phabricator.wikimedia.org/T90794#1069774 (10Aklapper) Thanks for taking the time to report this! > Please note that I have several user scripts enabled in my settings, which might be... [14:19:05] (03CR) 10Alex Monk: [C: 032] Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again [extensions/VisualEditor] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/193088 (owner: 10Jforrester) [14:21:12] (03Merged) 10jenkins-bot: Follow-up I18162f04: Set contentType: 'multipart/form-data' on some requests again [extensions/VisualEditor] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/193088 (owner: 10Jforrester) [14:52:04] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: VisualEditor: Show a user's recent uploads in the MW insert media dialog - https://phabricator.wikimedia.org/T62398#1069809 (10MarkAHershberger) Jdforrester-WMF writes: > This is a functionality task. The search results caching task was > resol... [14:55:00] Heya. [15:24:30] (03CR) 10Esanders: Context refactor (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [15:29:48] James_F, hey [15:29:59] were you really up at 5 AM this morning? [15:33:06] Yes. [15:33:20] My flight landed at 04:50 EST actually. [15:33:28] So 05:00 PST was pretty trivial. :-) [15:37:31] (03PS1) 10Esanders: Remove unnecessary disconnect in surface destroy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193111 [15:43:16] 10OOjs-UI, 5Patch-For-Review: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1069976 (10matmarex) 5Open>3Resolved [15:43:31] (03PS1) 10Bartosz Dziewoński: testsuitegenerator: Exclude 'text' parameter from tests, like 'content' [oojs/ui] - 10https://gerrit.wikimedia.org/r/193113 [15:43:33] (03PS1) 10Bartosz Dziewoński: tests: Run JS/PHP tests for widgets with required parameters, too [oojs/ui] - 10https://gerrit.wikimedia.org/r/193114 [15:43:56] 10OOjs-UI, 10OOjs-UI-0.8.1: Make it possible to instantiate all Widgets/Layouts/Elements without positional arguments, using just config options array/object, in both PHP and JS - https://phabricator.wikimedia.org/T89687#1069979 (10Jdforrester-WMF) [16:05:44] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: "Welcome to VisualEditor" broken at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T90858#1070062 (10Swainr) Open any of the Cite Tool options/Template/References List/Formula/Special Character, the dialogs are broken in beta. The dialogs... [16:10:09] (03PS4) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 [16:11:44] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Vagrant, 10Wikidata: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1059116 (10JanZerebecki) When running the qunit job in jenkins for wikibase.git it also fails withou... [16:12:19] (03PS10) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) [16:14:29] (03PS5) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 [16:19:11] (03PS6) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 [16:19:41] (03PS7) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 [16:30:32] (03PS1) 10Bartosz Dziewoński: PHP TitledElement: Actually set $this->title [oojs/ui] - 10https://gerrit.wikimedia.org/r/193121 [16:30:34] (03PS1) 10Bartosz Dziewoński: PHP PanelLayout: Fix getConfig() for 'expanded' config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/193122 [16:30:36] (03PS1) 10Bartosz Dziewoński: tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 [16:33:15] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: "Advanced settings" broken at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T90861#1070166 (10zeljkofilipin) [16:33:47] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: "Welcome to VisualEditor" broken at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T90858#1070172 (10zeljkofilipin) [16:33:57] (03CR) 10jenkins-bot: [V: 04-1] tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [16:34:55] (03PS16) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 [16:34:57] (03PS1) 10Esanders: Create toolbar dialog tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193125 [16:35:22] (03CR) 10Bartosz Dziewoński: "The standalone tests pass for me locally, but the karma version is failing. No idea why." [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [16:37:47] (03PS2) 10Esanders: Create toolbar dialog tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193125 [16:37:49] (03PS17) 10Esanders: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 [16:46:34] (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [16:50:53] edsanders: re: https://gerrit.wikimedia.org/r/#/c/192738/7/src/ui/contextitems/ve.ui.ToolContextItem.js,unified [16:51:00] i don't think I quite understand your comment [16:51:27] TrevorParscal, delete those three lines [16:51:32] have a look at gallery for example [16:51:38] it has a title "Gallery" [16:51:53] then because there's no description , the description falls back to the title ("Gallery") [16:52:06] right, because we need the description to be different than the title, or just not exist, no value in them being duplicated [16:52:07] and you get [icon] "Gallery" \n "Gallery" [16:52:19] yup [16:53:04] on a related note [16:53:33] I appreciate the separation of title & description, but it some cases it seems like we're putting information on two lines that could fit on one [16:53:37] or the title isn't really necessary [16:53:43] (03PS8) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [16:53:56] e.g. templates are only ever going to have one piece of information, the template name [16:54:01] (03PS9) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [16:54:01] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20): Cannot insert local picture in VisualEditor - https://phabricator.wikimedia.org/T90795#1070285 (10gregoire) Hi @mooeypo, I see this is now marked as resolved. That was quick :-) How can I proceed to get t... [16:54:45] likewise images [16:55:03] edsanders: the "Generated from: " part being nessecary [16:55:07] what are your thoughts? [16:55:16] in these cases the template name / image path isn't easily editable, so having it in the title area kind of makes sense [16:55:26] I added it because usually the template names are not quite descriptive enough to make sense [16:55:29] well that ties in with this [16:56:03] so, first off, if there are multiple templates in the transclusion, it's a list [16:56:16] second, I intend for them to be links to the template pages (just haven't done that yet) [16:57:00] so the multiple templates is a good case, but I feel like it's a small edge case where we'd be justified in special casing the regular case [16:57:04] another example where I considered putting the description in the title is language [16:57:07] perhaps we could have an inline mode [16:57:19] Where we separate with a colon [16:57:23] "Language: British" [16:57:25] but, the problem is we have autonyms in the language spoken, not in the content language [16:57:27] "Template: Echo" [16:57:45] TrevorParscal, why is that a problem? [16:58:05] well, the idea you have is different because you are adding "Language: " to be beginning [16:58:08] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, 7Performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1026793 (10GWicke) Some recent discussion on the old gerrit patch for parsoid integration: https://gerrit.wikimedia.org/r/#/... [16:58:14] we could do that for language and template [16:58:17] but not transclusion [16:58:23] thoughts? [16:59:06] I have code that changes the title based on whether it's a single template or not already (to use template vs. transclusion) [16:59:19] it's sort of a design question (which we can sort out now) [16:59:41] yeah - for multi transclusions you definitely want to use block mode [16:59:49] and also a james looking over my shoulder and saying "ok, ok, let's just get this first thing out and make more improvements later" [16:59:49] well, probably [17:00:03] yeah as I said, not a blocker [17:00:13] I'm open to your suggestion, the "Language:" or "Template:" prefixes [17:00:21] but, maybe add that as a task [17:00:49] but, yeah, the title wouldn't support linking to the template [17:00:57] and that's the other task I wanted to add [17:01:00] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Vagrant, 10Wikidata, and 2 others: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1070309 (10JanZerebecki) [17:01:09] TrevorParscal, edsanders, mooey|away, kaity|away, did the discussion every happen about whether to keep the citoid extension a dialog or make it an inspector or not? [17:01:20] along with using the page images API and wikidata for showing a thumbnail for links [17:01:43] mvolz, yeah, TrevorParscal sent around some designs [17:01:46] mvolz: we are happy with the new design (inspector) [17:01:47] did you get? [17:01:59] omg, did I seriously not include her on the email thread? [17:02:26] egg on my face [17:02:29] no, you explicitly asked us not to tell her [17:02:38] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Vagrant, 10Wikidata, and 2 others: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1070314 (10JanZerebecki) a:3JanZerebecki [17:02:56] :P [17:03:01] fwd would be nice [17:03:10] * ori is trolling, obviously. [17:03:18] fixed [17:03:41] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, 7Performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1070315 (10GWicke) [17:03:45] no worries, I have my head buried in service land anyway [17:04:00] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, 7Performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1070316 (10GWicke) p:5Normal>3High [17:04:18] mvolz: also: https://phabricator.wikimedia.org/T62768 [17:04:21] that's the design [17:04:38] and mooey|away has done it already last I saw [17:04:42] (03PS1) 10Mvolz: Add ability to set requesting User-Agent [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) [17:08:09] 10OOjs-UI, 7Browser-Support-Opera: OOjs UI: trouble with CheckboxInputWidget in Opera - https://phabricator.wikimedia.org/T75517#1070331 (10Tacsipacsi) @matmarex: I tested again and the error is that there isn’t disappear until I move the cursor from the box. I don’t get any error messages while trying to clic... [17:09:01] (03PS2) 10Mvolz: Add ability to set requesting User-Agent [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) [17:09:59] yeah I figured I should know what was up before I actually reviewed that. [17:10:40] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, 7Performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1070339 (10GWicke) [17:10:42] 10Cite: Page number attribute for tags - https://phabricator.wikimedia.org/T15127#1070340 (10jeremyb-phone) [17:13:10] (03CR) 10Esanders: [C: 04-1] "+2 after this" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [17:15:25] (03PS3) 10Trevor Parscal: Context refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 [17:15:54] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [17:17:26] edsanders: https://gerrit.wikimedia.org/r/#/c/192972/3 resolves your -1 by the way [17:18:28] TrevorParscal, comment typo: https://gerrit.wikimedia.org/r/#/c/192738/ [17:19:21] (03PS10) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [17:19:37] (03CR) 10Trevor Parscal: Context refactor (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [17:20:48] (03PS11) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [17:21:07] (03PS4) 10Trevor Parscal: Context refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 [17:21:23] (03CR) 10Trevor Parscal: Context refactor (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [17:21:36] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [17:22:26] (03CR) 10Esanders: [C: 032] Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [17:24:20] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [17:24:30] (03Merged) 10jenkins-bot: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [17:25:19] dude, jenkins is on crack today [17:25:47] also, https://gerrit.wikimedia.org/r/#/c/192972/ needs to be made into a proper pull through [17:26:59] allthough I don't think there's any breakage anymore (if you use older vemw with newer ve) [17:27:56] (03PS5) 10Jforrester: [PULL THROUGH] Context refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [17:28:15] TrevorParscal: Oh, ha. [17:28:24] TrevorParscal: Am about to pull through for you. [17:29:50] thanks [17:30:02] and edsanders, thanks for the review [17:30:33] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=112190879 [17:30:33] Corruption alert: visualeditor-needcheck on viwiki: https://vi.wikipedia.org/?diff=20554303 [17:30:42] (03PS6) 10Jforrester: Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [17:30:54] Indeed. edsanders and TrevorParscal, you both rock. [17:32:04] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: [Regression pre-wmf20] "Advanced settings" broken at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T90861#1070399 (10Jdforrester-WMF) p:5Triage>3Unbreak! [17:32:27] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: [Regression pre-wmf20] "Welcome to VisualEditor" broken at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T90858#1070402 (10Jdforrester-WMF) p:5Triage>3High [17:33:30] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [17:34:28] 10VisualEditor, 5Patch-For-Review: Context menu moves to middle of inline selection when an inspector is opened - https://phabricator.wikimedia.org/T90857#1070407 (10Jdforrester-WMF) p:5Triage>3Normal [17:35:00] (03CR) 10Trevor Parscal: [C: 032] Create toolbar dialog tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193125 (owner: 10Esanders) [17:39:34] 10VisualEditor: Help VisualEditor users find the wikitext save button - https://phabricator.wikimedia.org/T90864#1070430 (10Jdforrester-WMF) Well, we will move the wikitext save button to the top right when we do the "integrated two editors in one tab" work, but that's not for a while (and will be pretty disrupt... [17:42:23] 10VisualEditor, 10VisualEditor-EditingTools, 5§ VisualEditor Q3 Blockers: Adjust the context menu to be able to display richer data for tools that want it - https://phabricator.wikimedia.org/T89054#1070443 (10Jdforrester-WMF) [17:42:24] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Tools should be able to specify a label for their appearance in the context menu - https://phabricator.wikimedia.org/T88337#1070441 (10Jdforrester-WMF) 5Open>3Resolved [17:42:54] 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, 5§ VisualEditor Q3 Blockers: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1070447 (10Jdforrester-WMF) [17:42:55] 10VisualEditor, 10VisualEditor-ContentEditable, 10Citoid, 7Design, 5WMF-deploy-2015-03-04_(1.25wmf20): VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#1070444 (10Jdforrester-WMF) 5Open>3Resolved a:3TrevorParsc... [17:43:21] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1070449 (10Jdforrester-WMF) Blockers resolved; this is now "just" a question of getting the image and Wikidata description and filling it in. Potentially relatively easy. [17:43:43] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1070455 (10Jdforrester-WMF) [17:43:44] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Adjust the context menu to be able to display richer data for tools that want it - https://phabricator.wikimedia.org/T89054#1070452 (10Jdforrester-WMF) 5Open>3Resolved [17:46:24] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [17:47:40] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [17:50:43] James_F, https://phabricator.wikimedia.org/T90861#1070399 and https://phabricator.wikimedia.org/T90858#1070402 are probably the same bug, dialogs are completely broken [17:51:04] Krenair: Yeah. :-( Can you investigate? [17:53:39] (03CR) 10Jforrester: [C: 032] testsuitegenerator: Exclude 'text' parameter from tests, like 'content' [oojs/ui] - 10https://gerrit.wikimedia.org/r/193113 (owner: 10Bartosz Dziewoński) [17:54:08] James_F, "beta is fucked, again"? [17:54:11] 10VisualEditor, 7Performance, 5§ VisualEditor Q3 Blockers: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1070484 (10Jdforrester-WMF) a:3Catrope [17:54:13] Probably. [17:54:25] Also my browser's rendering is horribly broken :/ [17:54:26] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 5§ VisualEditor Q3 Blockers: Show the VisualEditor toolbar/editor chrome as soon as VE scripts are loaded, rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#1070486 (10Jdforrester-WMF) a:3Esanders [17:54:33] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Technical-Debt, 5§ VisualEditor Q3 Blockers: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#1070487 (10TrevorParscal) a:3Catrope [17:54:43] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: API requests to action=visualeditor&paction=parse more than four times slower than requests directly to parsoid-lb - https://phabricator.wikimedia.org/T87553#1070488 (10Jdforrester-WMF) a:3Catrope [17:54:52] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 7Browser-Support-Firefox, 5§ VisualEditor Q3 Blockers: Using keyboard shortcuts (in multiple browsers) or the "Open menu" (in Firefox only) to copy a paragraph and a reference togethe... - https://phabricator.wikimedia.org/T89025#1070489 [17:55:26] (03Merged) 10jenkins-bot: testsuitegenerator: Exclude 'text' parameter from tests, like 'content' [oojs/ui] - 10https://gerrit.wikimedia.org/r/193113 (owner: 10Bartosz Dziewoński) [17:56:00] actually might not be an issue with beta [17:56:41] Krenair: Beta Cluster bits broken or something? [17:56:53] nah, otherwise it'd be far more broken [17:57:07] 10VisualEditor, 10VisualEditor-EditingTools, 5§ VisualEditor Q3 Blockers: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - https://phabricator.wikimedia.org/T70590#1070491 (10TrevorParsca... [17:57:13] 10OOjs-UI, 10VisualEditor, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: ~50ms spent animating a.oo-ui-buttonElement-button - https://phabricator.wikimedia.org/T88386#1070492 (10TrevorParscal) a:3TrevorParscal [17:57:26] 10OOjs-UI, 7Browser-Support-Opera: OOjs UI: trouble with CheckboxInputWidget in Opera - https://phabricator.wikimedia.org/T75517#1070493 (10matmarex) Hmm. I can reproduce that now – when I double-click on the checkbox label (which results in text being selected), the checkbox appears in incorrect state, and fi... [17:58:03] James_F, I can reproduce the issue locally. [17:58:36] Krenair: Ick. [17:59:19] 10VisualEditor, 10VisualEditor-ContentEditable, 5§ VisualEditor Q3 Blockers: Scroll to an item when it is selected e.g. when it has been newly inserted - https://phabricator.wikimedia.org/T53911#1070499 (10Jdforrester-WMF) [17:59:41] (03PS1) 10Brion VIBBER: Update parser test case for gallery srcset support [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193146 (https://phabricator.wikimedia.org/T64709) [18:00:42] (03CR) 10Cscott: "Weird. Maybe it's not waiting for documentReady, so on the larger pages those particular bits of the DOM haven't been parsed yet? (Writi" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [18:06:48] (03PS2) 10Bartosz Dziewoński: InputWidget: Focus checkboxes and radios, too, when the label is clicked [oojs/ui] - 10https://gerrit.wikimedia.org/r/193099 [18:11:05] (03CR) 10Jforrester: [C: 031] tests: Run JS/PHP tests for widgets with required parameters, too [oojs/ui] - 10https://gerrit.wikimedia.org/r/193114 (owner: 10Bartosz Dziewoński) [18:11:18] (03CR) 10Jforrester: [C: 032] PHP TitledElement: Actually set $this->title [oojs/ui] - 10https://gerrit.wikimedia.org/r/193121 (owner: 10Bartosz Dziewoński) [18:11:41] (03CR) 10Jforrester: [C: 032] PHP PanelLayout: Fix getConfig() for 'expanded' config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/193122 (owner: 10Bartosz Dziewoński) [18:12:58] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: [Regression pre-wmf20] Dialogs broken on master - https://phabricator.wikimedia.org/T90858#1070531 (10Krenair) [18:13:07] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: [Regression pre-wmf20] "Advanced settings" broken at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T90861#1070533 (10Krenair) [18:13:08] 10VisualEditor, 10Beta-Cluster, 7Browser-test-bug: [Regression pre-wmf20] Dialogs broken on master - https://phabricator.wikimedia.org/T90858#1069509 (10Krenair) [18:13:31] 10VisualEditor, 7Browser-test-bug: [Regression pre-wmf20] Dialogs broken on master - https://phabricator.wikimedia.org/T90858#1069509 (10Krenair) [18:13:40] 10VisualEditor, 7Browser-test-bug: [Regression pre-wmf20] "Advanced settings" broken at en.wikipedia.beta.wmflabs.org - https://phabricator.wikimedia.org/T90861#1069555 (10Krenair) [18:14:10] 10VisualEditor, 7Accessibility, 5§ VisualEditor Q3 Blockers: Make slugs keyboard accessible again - https://phabricator.wikimedia.org/T89352#1070541 (10Jdforrester-WMF) a:3Esanders [18:14:18] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Google-Chrome, and 2 others: Chrome lets you place the cursor either side of a Table (eww) and VE doesn't correct this - https://phabricator.wikimedia.org/T73560#1070542 (10Jdforrester-WMF) a:3Esanders [18:14:25] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#1070543 (10Jdforrester-WMF) a:3Catrope [18:14:38] 10VisualEditor, 10VisualEditor-DataModel, 5§ VisualEditor Q3 Blockers: VisualEditor: Deleting from a paragraph-terminating node to a paragraph-terminating node (?) is throwing "Unbalanced set of replace operations found" - https://phabricator.wikimedia.org/T74579#1070544 (10Jdforrester-WMF) a:3Catrope [18:14:48] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Apple-Safari, 5§ VisualEditor Q3 Blockers: Random removal of categories when using Safari - https://phabricator.wikimedia.org/T76998#1070545 (10Jdforrester-WMF) a:3Catrope [18:14:56] 10VisualEditor, 10VisualEditor-DataModel, 5§ VisualEditor Q3 Blockers: [Regression?] VE corruption issue(?) moving pre-existing categories to the middle of the page - https://phabricator.wikimedia.org/T74048#1070546 (10Jdforrester-WMF) a:3Catrope [18:15:23] 10VisualEditor, 10VisualEditor-ContentEditable, 5§ VisualEditor Q3 Blockers: Cursoring with arrows from outside a table into it and typing causes pawns - https://phabricator.wikimedia.org/T75691#1070547 (10Jdforrester-WMF) a:3dchan [18:15:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5§ VisualEditor Q3 Blockers: [Regression wmf5] The wikitext editor does not show any wikitext for any page when switching from mobile VE in test2 and Beta Labs - https://phabricator.wikimedia.org/T74571#1070548 (10Jdforrester-WMF) a:3Catrope [18:15:42] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Firefox, 5§ VisualEditor Q3 Blockers: Ctrl+C copying of text with template removes text in FF - https://phabricator.wikimedia.org/T86921#1070549 (10Jdforrester-WMF) a:3Esanders [18:15:49] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 7Browser-Support-Apple-Safari, 5§ VisualEditor Q3 Blockers: [Regression wmf14] Safari - 'Add template' is greyed out - https://phabricator.wikimedia.org/T86038#1070550 (10Jdforrester-WMF) a:3Esanders [18:16:00] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 5§ VisualEditor Q3 Blockers: Insufficient span tags stripping from copy-and-paste (?) - https://phabricator.wikimedia.org/T78540#1070551 (10Jdforrester-WMF) a:3Esanders [18:18:31] (03CR) 10Esanders: "I tried to do this a few months ago, but it required us to be able to calculate the coordinates of an arbitrary dm offset, which we can no" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193077 (https://phabricator.wikimedia.org/T90857) (owner: 10Esanders) [18:18:49] (03CR) 10Jforrester: "Nice." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193077 (https://phabricator.wikimedia.org/T90857) (owner: 10Esanders) [18:21:19] (03PS7) 10Jforrester: Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [18:21:59] James_F, seems to have been caused by the update to OOjs UI v0.8.1 [18:22:15] Krenair: Bah. Entirely plausible. [18:22:37] (Back in a minute) [18:23:06] noticed that there's no .oo-ui-windowManager > .oo-ui-dialog > .oo-ui-window-frame anymore [18:23:19] 10VisualEditor, 10Continuous-Integration, 5§ VisualEditor Q3 Blockers: Concurrent builds using local web browsers on Linux host (Chromium/Firefox) fail - https://phabricator.wikimedia.org/T90673#1064651 (10Jdforrester-WMF) [18:23:20] just .oo-ui-windowManager > .oo-ui-window-frame, which the styles don't apply to [18:24:14] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [18:24:47] (03CR) 10Catrope: "Do we need uselang in other places too? TemplateData comes to mind." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193027 (owner: 10Alex Monk) [18:24:54] (03CR) 10Catrope: [C: 032] Follow-up I18162f04: Send uselang parameter with paction=parse request [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193027 (owner: 10Alex Monk) [18:25:32] TrevorP|Away, https://gerrit.wikimedia.org/r/#/c/193077/ [18:25:44] 10VisualEditor: Fix styling inconsistencies between context item and inspector - https://phabricator.wikimedia.org/T90896#1070594 (10Esanders) 3NEW [18:27:00] (03Merged) 10jenkins-bot: Follow-up I18162f04: Send uselang parameter with paction=parse request [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193027 (owner: 10Alex Monk) [18:28:09] 10VisualEditor, 10Continuous-Integration, 5§ VisualEditor Q3 Blockers: Jenkins: Convert mwext qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#1070614 (10Jdforrester-WMF) [18:28:11] 10VisualEditor, 10VisualEditor-EditingTools, 10Citoid: VisualEditor: Be able to name references manually in the reference dialog - https://phabricator.wikimedia.org/T52568#1070615 (10Whatamidoing-WMF) Perhaps Citoid could suggest a ref name. [18:30:39] RoanKattouw: Which channel is the meeting in? [18:30:48] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20): Cannot insert local picture in VisualEditor - https://phabricator.wikimedia.org/T90795#1070644 (10Catrope) >>! In T90795#1070285, @gregoire wrote: > Hi @mooeypo, > I see this is now marked as resolved. Th... [18:33:57] James_F: #mediawiki-parsoid [18:34:01] Ta. [18:34:27] (03PS1) 10Jforrester: Follow-up I18162f04: Send uselang parameter with paction=parse request [extensions/VisualEditor] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/193151 [18:36:40] so the travel spreadsheet has had access revoked now. interesting [18:36:54] Finally. [18:38:41] hah [18:38:48] Not before I saw a bunch of approvals though [18:38:49] aren't we supposed to answer comments in it? [18:39:01] But I was starting to get worried because there was a freaking cost column [18:39:10] All the values were empty or $0.00 but stil [18:39:26] I can still see it [18:39:27] mooeypoo: No. That's for the Directors to argue with each other, normally. [18:40:05] You sure you're looking at the right link edsanders? There were two links, the original one had disabled access, staff could view the link in the follow-up email [18:40:41] ah [18:43:21] James_F, we got an email telling us to answer.... [18:43:27] 10VisualEditor, 10VisualEditor-EditingTools, 5§ VisualEditor Q3 Blockers: VisualEditor: if you need to type, then you need access to the character inserter - https://phabricator.wikimedia.org/T62657#1070746 (10Whatamidoing-WMF) [18:43:31] I just answered one of Quim's comments at least [18:43:38] 10VisualEditor, 10VisualEditor-EditingTools, 10Citoid: VisualEditor: Be able to name references manually in the reference dialog - https://phabricator.wikimedia.org/T52568#1070748 (10Mvolz) The citoid extension could definitely come up with an automated reference name, but that should be filed as a separate... [18:43:42] 10VisualEditor, 6Collaboration-Team, 10Flow: Sometimes VE toolbar gets stuck in upper left until reflow/resize window - https://phabricator.wikimedia.org/T90762#1070750 (10EBernhardson) p:5Triage>3Normal [18:43:45] * James_F sighs. [18:44:07] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1070754 (10EBernhardson) p:5Triage>3High [18:44:37] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to name references manually in the reference dialog - https://phabricator.wikimedia.org/T52568#1070761 (10Mvolz) [18:45:26] 10VisualEditor, 10Collaboration-Team-Sprint-R-2015-03-11, 10Flow: Sometimes VE toolbar gets stuck in upper left until reflow/resize window - https://phabricator.wikimedia.org/T90762#1070775 (10DannyH) [18:47:38] (03PS1) 10Krinkle: core: Improve class related unit tests [oojs/core] - 10https://gerrit.wikimedia.org/r/193153 [18:47:51] Krinkle: Heya. [18:47:55] James prefers organisations to be shrouded in secrecy, that's why he worked for MI6 [18:48:26] I did not work for the SIS. [18:49:59] (03CR) 10Cscott: [C: 032] "So it does!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193122 (owner: 10Bartosz Dziewoński) [18:50:45] (03PS2) 10Bartosz Dziewoński: PHP TitledElement: Actually set $this->title [oojs/ui] - 10https://gerrit.wikimedia.org/r/193121 [18:50:47] (03CR) 10Cscott: [C: 032] "Redundant +2" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193121 (owner: 10Bartosz Dziewoński) [18:50:50] (03PS2) 10Bartosz Dziewoński: PHP PanelLayout: Fix getConfig() for 'expanded' config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/193122 [18:51:33] 10VisualEditor, 10Continuous-Integration, 7Tracking, 5§ VisualEditor Q3 Blockers: Browser disconnects when running QUnit tests with local browsers (tracking) - https://phabricator.wikimedia.org/T89075#1070833 (10Krinkle) [18:51:38] (03CR) 10Jforrester: [C: 032] PHP PanelLayout: Fix getConfig() for 'expanded' config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/193122 (owner: 10Bartosz Dziewoński) [18:51:44] (03CR) 10Cscott: [C: 032] "Still a +2." [oojs/ui] - 10https://gerrit.wikimedia.org/r/193121 (owner: 10Bartosz Dziewoński) [18:51:52] :-) [18:51:56] This is getting silly. [18:51:58] (03PS2) 10Bartosz Dziewoński: tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 [18:52:00] ;) [18:52:52] 10VisualEditor, 10Continuous-Integration, 5§ VisualEditor Q3 Blockers: Concurrent builds using local Chromium/Firefox browsers on Linux host fail - https://phabricator.wikimedia.org/T90673#1070835 (10Krinkle) [18:52:56] James_F: hey, can you do me a favor? can we rename the "Polish" column on https://phabricator.wikimedia.org/tag/§_visualeditor_q3_blockers/ to something else? i don't have a good reason, but it's bugging me [18:53:07] RoanKattouw: When TrevorP|Away gets in, please point out to him that https://gerrit.wikimedia.org/r/#/c/192972/ is actually failing, not just CI blips. [18:53:13] MatmaRex: It's the standard term… [18:53:54] i suppose. it's a stupid term, though. [18:54:08] MatmaRex, you seen the issue with dialogs yet? [18:54:26] seen it, yeah. didn't debug. should i? [18:54:40] (03Merged) 10jenkins-bot: PHP PanelLayout: Fix getConfig() for 'expanded' config option [oojs/ui] - 10https://gerrit.wikimedia.org/r/193122 (owner: 10Bartosz Dziewoński) [18:54:50] I know what's gone wrong [18:54:53] But I don't know which change caused it [18:55:02] there's no .oo-ui-windowManager > .oo-ui-dialog > .oo-ui-window-frame anymore [18:55:14] just .oo-ui-windowManager > .oo-ui-window-frame, which the styles don't apply to [18:55:46] if you create a new div with class="oo-ui-window oo-ui-dialog oo-ui-processDialog oo-ui-window-active oo-ui-window-setup oo-ui-window-ready" as a sibling of the frame and move the frame inside it, it shows fine [18:56:28] huh. [18:56:38] I thought frames were gone completely as of two versions ago. or am I misunderstanding what you mean by "frame"? [18:56:39] (03Merged) 10jenkins-bot: PHP TitledElement: Actually set $this->title [oojs/ui] - 10https://gerrit.wikimedia.org/r/193121 (owner: 10Bartosz Dziewoński) [18:57:01] You're thinking of iframe isolation I think, chrismcmahon [18:57:07] yes [18:57:29] yeah that's a different thing [18:57:37] (03CR) 10jenkins-bot: [V: 04-1] tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [18:57:52] naming stuff is hard [18:57:56] :) [18:58:41] * MatmaRex digs [18:59:49] (03CR) 10Mobrovac: [C: 04-1] "Generally ok, but some OO-related things need to be adjusted (see in-line comments)" (036 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 (owner: 10Mvolz) [19:01:13] weird, I have VE hung editing a page on mediawiki.org. errors are a 404 from bits and ERR_CACHE_MISS [19:01:44] (03CR) 10Jforrester: [C: 032] Update parser test case for gallery srcset support [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193146 (https://phabricator.wikimedia.org/T64709) (owner: 10Brion VIBBER) [19:01:57] (03Merged) 10jenkins-bot: Update parser test case for gallery srcset support [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193146 (https://phabricator.wikimedia.org/T64709) (owner: 10Brion VIBBER) [19:02:05] no repro, worked fine the 2nd time [19:02:49] (03PS1) 10Mvolz: [WIP] User Agent Config [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 [19:03:25] Krenair: TrevorP|Away just got here, I've asked him to help you with this [19:03:33] ok [19:03:39] (03CR) 10Mobrovac: [C: 032] Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 (https://phabricator.wikimedia.org/T1069) (owner: 10Mvolz) [19:03:40] thanks [19:07:08] Krenair: woah, there is a .oo-ui-windowManager.oo-ui-window [19:07:23] something gets confused about $elements [19:07:56] and [19:08:07] we just added $element as an acceptable parameter to OO.ui.Element [19:08:09] i'm here [19:08:13] TrevorParscal: ^ [19:08:22] (03CR) 10Mooeypoo: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/193007 (https://phabricator.wikimedia.org/T90283) (owner: 10Mooeypoo) [19:08:25] so that's probably the cause. now to find out where this is called [19:09:31] I was looking at Dialog, Frame, Window, WindowManager, etc. since the 0.8.0 tag commit (f90de429e269fbb20aff48ab73be495acf03ca42) [19:09:41] hmm, or maybe not? that doesn't seem to be live yet [19:10:25] MatmaRex: so, is there still an issue? [19:10:33] Yeah windows are broken [19:10:58] [10:55] Krenair there's no .oo-ui-windowManager > .oo-ui-dialog > .oo-ui-window-frame anymore [19:11:00] it's on master [19:11:00] [10:55] Krenair just .oo-ui-windowManager > .oo-ui-window-frame, which the styles don't apply to [19:11:05] found on beta, reproduced locally [19:11:53] so, what's the actual problem? I mean, yes that structure has changed somewhwat [19:11:59] styles do not apply [19:12:03] dialogs are completely broken [19:12:14] http://en.wikipedia.beta.wmflabs.org/wiki/Special:Random?veaction=edit [19:12:15] https://phabricator.wikimedia.org/T90858#1070402 has a lot of screenshots of broken dialogs [19:12:39] thanks [19:13:00] RoanKattouw: TrevorParscal: .oo-ui-windowManager is a .oo-ui-window too, there's no separate element for window and windowmanager. [19:13:08] lolwut [19:14:10] 10OOjs-UI, 10VisualEditor, 7Browser-test-bug: [Regression pre-wmf20] Dialogs broken on master - https://phabricator.wikimedia.org/T90858#1070922 (10Krenair) a:5Krenair>3TrevorParscal [19:14:11] my thoughts exactly [19:16:57] (03CR) 10GWicke: Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (https://phabricator.wikimedia.org/T1218) (owner: 10Alex Monk) [19:17:39] edsanders, you -1'ed with a comment "PS3" but I see no comments on PS3... https://gerrit.wikimedia.org/r/#/c/190400/ [19:19:46] RoanKattouw: wooow [19:20:03] the issue is here in WindowManager: win = this.factory.create( name, this ); [19:20:21] What's wrong with that line? [19:20:28] becausde this.$element [19:20:29] a few levels down, this passes the 'this' (a WindowManager) as a parameterto Dialog constructor [19:20:32] OOOOH [19:20:37] it's taking the window manager as the config options [19:20:39] this is interpreted as a config element? [19:20:46] We've had that happen before [19:20:46] yes, config.$element [19:20:53] gets set to this.$element [19:20:55] And it passed through config.$ correctly and ignored everything else [19:21:06] But now that we have config.$element it's much more disastrous [19:21:07] we just added this feature to Element for infusion [19:21:11] we don't need to pass the window manager to windows on creation [19:21:14] so, you can drop that [19:21:25] Was that missed in a refactor months ago or something? [19:21:34] And just never noticed until config.$element was created? [19:21:40] it was a bit of cruft that shouldn't have been there but wasn't causing problems until now [19:22:20] (03CR) 10Mobrovac: [C: 032] Create CitoidService object [services/citoid] - 10https://gerrit.wikimedia.org/r/192084 (https://phabricator.wikimedia.org/T89968) (owner: 10Mvolz) [19:22:42] MatmaRex: could you add a check [19:22:45] we have this pattern in a few more places in VE. (someFactory.create( …, this )) [19:22:50] inside the OO.ui.Element constructor [19:23:03] just add a check that config isn't an instanceof OO.ui.Element [19:23:05] for instanceof Element? [19:23:07] that way we will catch this [19:23:09] yes [19:23:21] we always inherit from Element, so it should work fine [19:23:33] config should always be a plain object [19:23:43] but, checking that at every constructor is a pain [19:24:06] but checking this particular case inside of Element should be simple and catch most issues [19:24:10] maybe OO.isPlainObject( config ), then? [19:24:20] all configs get bubbled up to Element anyway [19:24:21] or should [19:24:30] I think that has a lot more performance degredation, but.. yeah that would also be OK [19:24:44] could we race OO.isPlainObject against instanceof ? [19:24:57] realizing that isPlainObject covers a larger number of cases [19:25:11] http://jsperf.com/jquery-isplainobject-vs-typeof-vs-instanceof [19:25:11] hmm [19:26:04] holy crap [19:26:10] typeof is soooo fast [19:26:22] instanceof and isPlainObject are pretty close relatively speaking [19:26:27] i wonder if anything might be doing this for legitimate reasons [19:27:19] MatmaRex: using an Element as a config object? [19:27:20] no way [19:28:34] yeah… doesn't look like it [19:28:47] anyway, there's a bug in WindowManager, at least, so let's fix that [19:30:10] (03CR) 10Mobrovac: [C: 04-1] "Really small things, and then we can move on ;)" (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz) [19:31:00] * MatmaRex does [19:35:03] (03PS1) 10Bartosz Dziewoński: WindowManager: Don't pass 'this' to window factory method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193163 (https://phabricator.wikimedia.org/T90858) [19:35:05] (03CR) 10Mobrovac: [C: 04-1] "One minor, but important detail - the User-Agent header cannot be null (if supplied), so we should ensure a string is sent (see comment in" (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) (owner: 10Mvolz) [19:35:08] TrevorParscal: ^ [19:35:53] 10OOjs-UI, 7Browser-Support-Opera: OOjs UI: trouble with CheckboxInputWidget in Opera - https://phabricator.wikimedia.org/T75517#1070971 (10Tacsipacsi) OK, I can go with it. [19:40:18] (03CR) 10Trevor Parscal: [C: 032] WindowManager: Don't pass 'this' to window factory method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193163 (https://phabricator.wikimedia.org/T90858) (owner: 10Bartosz Dziewoński) [19:42:04] (03Merged) 10jenkins-bot: WindowManager: Don't pass 'this' to window factory method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193163 (https://phabricator.wikimedia.org/T90858) (owner: 10Bartosz Dziewoński) [19:50:16] (03CR) 10Esanders: "oops, didn't save the draft" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 (owner: 10Mooeypoo) [19:50:26] mooeypoo, sorry, didn't save the comments [19:50:54] (03PS36) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [19:51:46] (03PS37) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [19:51:47] 10VisualEditor, 10VisualEditor-MediaWiki: Test failure: "Uncaught TypeError: Cannot read property '0' of undefined" - https://phabricator.wikimedia.org/T90916#1071036 (10Krinkle) 3NEW [19:52:48] (03PS38) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [19:55:11] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-02-25_(1.25wmf19): Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1071061 (10Krinkle) Might be fixed, don't I'm not sure why. The references... [19:55:26] 10VisualEditor, 10VisualEditor-MediaWiki, 7Technical-Debt, 5WMF-deploy-2015-02-25_(1.25wmf19): Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1071063 (10Krinkle) [19:55:44] 10VisualEditor, 10VisualEditor-MediaWiki: Test failure: "Uncaught TypeError: Cannot read property '0' of undefined" in mw.ImageInfoCache - https://phabricator.wikimedia.org/T90916#1071070 (10Krinkle) [19:59:02] 10MediaWiki-ResourceLoader, 7Performance: ResourceLoader preloads blob metadata, then does another query for blob contents - https://phabricator.wikimedia.org/T28398#1071088 (10Krinkle) [19:59:19] 10MediaWiki-ResourceLoader: Evaluate folding msg_resource and msg_resource_links tables into objectcache - https://phabricator.wikimedia.org/T90001#1071092 (10Krinkle) [20:00:17] 10MediaWiki-ResourceLoader, 7Performance: ResourceLoader preloads blob metadata, then does another query for blob contents - https://phabricator.wikimedia.org/T28398#294831 (10Krinkle) [20:01:11] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-WikimediaMaintenance, 7Performance: ClearMessageBlobs loop should check slave lag - https://phabricator.wikimedia.org/T60433#1071109 (10Krinkle) [20:01:41] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-WikimediaMaintenance, 7Performance: ClearMessageBlobs loop should check slave lag - https://phabricator.wikimedia.org/T60433#1071113 (10Krinkle) 5Open>3Resolved a:3Krinkle [20:05:12] Krinkle: @cfg is our thing, not jsduck's right? [20:05:19] RoanKattouw: jsduck [20:05:26] Krinkle: I ask because @cfg {string} [config.foo] crashes jsduck [20:05:35] I know that's incorrect and it should be @cfg {string} [foo] [20:05:44] But I should be allowed to have dots in config names [20:05:45] Ha [20:05:50] and not have the documentation software crash :P [20:05:52] Yeah, give me a stack trace or file upstream [20:06:03] mooeypoo: Can you give him your stack trace? [20:06:12] sure [20:06:32] https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck/8068/console has the same issue [20:06:40] but i also have an output in my terminal [20:07:28] edsanders: Do you know why you check here for extsrc https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js#L59 instead of wikitext? [20:07:49] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, 5§ VisualEditor Q3 Blockers: Add original dimensions information from the API to data-mw - https://phabricator.wikimedia.org/T64881#1071131 (10cscott) Mediawiki core seems to use `data-file-width` and `data-file-height` on `... [20:08:01] mooeypoo: That'll do [20:08:13] mooeypoo: RoanKattouw: Do you know which @cfg causes it? Or jsut any with a property? [20:08:32] Because upstream example includes a property https://github.com/senchalabs/jsduck/wiki/@cfg [20:08:34] Krinkle: She was able to reproduce it by editing just one [20:08:44] Krinkle, oh, I added a pastebin anyways before you said it'll do, so that might help? http://pastebin.com/fA34ea6a [20:11:12] Krinkle, RoanKattouw I edited that pastebin with the comment I've used [20:11:26] cool [20:15:14] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, 5§ VisualEditor Q3 Blockers: Add original dimensions information from the API to data-mw - https://phabricator.wikimedia.org/T64881#1071171 (10matmarex) That comes from Multimedia Viewer or some such. [20:15:16] Krinkle, I'm also getting errors from jsduck about "@inheritdoc - parent class not found" with methods that exist in ooui. Is there a way to connect jsduck to ooui for documentation? [20:16:21] mooeypoo: It should be connected already [20:16:23] mooeypoo: what repo? [20:16:27] core [20:16:30] right [20:16:39] Krinkle, https://gerrit.wikimedia.org/r/#/c/192749/7 [20:16:42] core doesn't index oojs-ui yet [20:17:02] look at jsduck.config of VisualEditor and do the same for mediawiki-core. include 2 lines: oojs.js, oojs-ui.js basically [20:17:05] from libs [20:17:12] * mooeypoo nods [20:18:43] https://github.com/senchalabs/jsduck/issues/607 [20:19:17] Krinkle, config.json in jsduck in core already has "../../resources/lib/oojs", "../../resources/lib/oojs-ui" [20:20:47] mooeypoo: it doesn't have any class definition right now [20:20:49] https://gerrit.wikimedia.org/r/#/c/192749/7/resources/src/mediawiki/mediawiki.feedback.js [20:21:08] mw.Feedback.Dialog is not a class and has no parent class [20:21:24] I thought it is enought o say "@extends ..." [20:21:25] It's documented as a method (default) with a parameter config [20:21:33] Yes, but it doesnt [20:21:38] /** 193 [20:21:39] » * mw.Feedback Dialog 194 [20:21:39] » * @param {Object} config Configuration object 195 [20:21:40] » */ [20:21:50] .. I just changed that [20:22:04] Krinkle, sorry, there's a new version (ps8) [20:22:59] line #194; I specified @class and @extends OO.ui.ProcessDialog [20:23:02] mooeypoo: methods can't extend, classes do [20:23:04] Krinkle, but I get these: https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck/8069/console [20:23:21] Right now it declares @class, and then @constructor, which terminates the class definition and strarts the documentation of the constructor method [20:23:30] and then @extends [20:23:36] that's probably ignored [20:23:45] order matters :) [20:23:57] Yeah that was it [20:23:59] My fault [20:24:01] Krinkle, RoanKattouw_away just walked over and pointed that out [20:24:10] Okay :) [20:24:17] ha [20:24:19] thanks :) [20:24:29] it passes (locally at least) now [20:24:30] yay [20:27:13] (03CR) 10Cscott: [C: 04-1] tests: Add infusion tests (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [20:32:20] (03CR) 10Bartosz Dziewoński: tests: Add infusion tests (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [20:33:17] James_F|Away / RoanKattouw_away : new data on success broken down by user types: https://edit-analysis.wmflabs.org/adhoc.html#ve-success-rate-by-user-type.tsv [20:33:37] TrevorParscal: still there? [20:33:52] yes, about to head to lunch / govt office [20:33:57] you coming in? [20:34:16] (03CR) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott) [20:47:09] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1071236 (10cscott) @Krinkle `__proto__` was not standardized in ES6 (except in a "deprecated browser compatibility" appendix), however `Object.setPrototy... [20:51:55] 10OOjs-UI: Turn on type checking for OO.ui.infuse. - https://phabricator.wikimedia.org/T90929#1071279 (10cscott) 3NEW [20:52:06] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1043695 (10cscott) [20:52:07] 10OOjs-UI: Turn on type checking for OO.ui.infuse. - https://phabricator.wikimedia.org/T90929#1071288 (10cscott) [20:53:13] (03PS5) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 [20:54:04] MatmaRex: I decoupled the Element.static.infuse thing from the resolution of how exactly we make .static.class work, so that it can be merged and I can put OOjs on my back burner. [20:54:30] (03Abandoned) 10Cscott: DON'T PUSH: update ooui-core to include .static.class property. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192877 (owner: 10Cscott) [20:55:34] (03CR) 10Cscott: "I removed the dependency on T89721, so that this can be merged right away without waiting on T89721." [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott) [21:01:36] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1071328 (10Krinkle) @cscott: That's not what I had in mind, though that's in interesting idea. I was thinking we'd keep them separate and migrate on our... [21:07:17] 10OOjs-UI: OO.ui.ActionFieldLayout doesn't properly accept a jQuery for its label config value - https://phabricator.wikimedia.org/T90936#1071358 (10Anomie) 3NEW [21:15:23] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1071410 (10cscott) So, how should `OO.ui.Element.static.infuse()` be written? Option 1: ``` var obj = OO.ui.Element.static.unsafeInfuse(typeOrId); if ( !... [21:22:22] 10VisualEditor: "I shouldn't be clickable" in standalone aliens.html demo is clickable - https://phabricator.wikimedia.org/T90945#1071460 (10matmarex) 3NEW [21:25:10] 10MediaWiki-Page-editing, 7JavaScript: LivePreview fires wikipage.content hook before attaching content, which breaks some scripts - https://phabricator.wikimedia.org/T90851#1071484 (10brion) I would lean towards solution 1) - attach before firing the hook. [21:26:48] (03CR) 10Krinkle: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott) [21:29:29] (03CR) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott) [21:34:00] (03PS6) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 [21:34:35] (03CR) 10jenkins-bot: [V: 04-1] Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott) [21:39:32] (03PS7) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 [21:42:42] TrevorParscal: i've been thinking about https://phabricator.wikimedia.org/T90815 and i'm pretty sure that it's not really feasible :/ if the goal is to reduce width, then i think we'd do much better to just remove some white space between toolbar items. [21:45:51] we can make it at least 10narrower and still have it look good http://i.imgur.com/3PK7JgY.png [21:45:55] 10 [21:48:02] MatmaRex: you need to fight it out with Krinkle over whether variables holding constructors should be capitalized or not. (https://gerrit.wikimedia.org/r/192878) [21:48:28] heh [21:49:16] cscott: here's a compromise: just do new OO.ui[data._] :D [21:50:11] if ( !OO.ui[data._] ) {throw …; }obj = new OO.ui[data._]; [21:52:24] (03CR) 10Bartosz Dziewoński: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott) [21:53:16] 10VisualEditor, 10VisualEditor-MediaWiki: Test failure: "Uncaught TypeError: Cannot read property '0' of undefined" in mw.ImageInfoCache - https://phabricator.wikimedia.org/T90916#1071623 (10Krenair) a:3Krenair [21:53:19] (03PS1) 10Alex Monk: ImageInfoCache: Don't try to access imageinfo result if it's not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193268 (https://phabricator.wikimedia.org/T90916) [21:54:00] 10MediaWiki-Page-editing, 7JavaScript: LivePreview fires wikipage.content hook before attaching content, which breaks some scripts - https://phabricator.wikimedia.org/T90851#1071629 (10Krinkle) `wikipage.content` has always been fired before attachment by all handlers other than the initial one (LivePreview an... [21:56:10] 10VisualEditor: Regular expressions in Find - using a? or a* freezes browser - https://phabricator.wikimedia.org/T90958#1071636 (10Etonkovidova) 3NEW [21:56:25] Krenair: Hm.. interesting. The property itself is missing? [21:56:36] Does the api not return error in that case? [21:57:36] Krinkle, it sets a "missing" property [21:58:31] btw, not sure an hasOwn check makes sense there. It's not an arbitrary key. If we do that here, we should also do it in constructors using config.something || 'x' if we expect known keys like that to exist in prototype one day. [21:58:56] ok.. so you suggest just checking if ( page.imageinfo ) ? [21:59:02] yeah, that should do. [21:59:16] Did the error happen for you locally as we;;? [21:59:18] well* [21:59:22] (03PS2) 10Alex Monk: ImageInfoCache: Don't try to access imageinfo result if it's not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193268 (https://phabricator.wikimedia.org/T90916) [21:59:23] yes [22:01:53] (03CR) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott) [22:02:17] wow, Jeff Beal's House of Cards theme is quite popular apparantly. Back in NL today and already heard snippets of it used in three independent tv shows as reel. [22:02:30] (non-fiction shows that is) [22:02:49] about government and general news [22:02:56] Fits quite well :D [22:02:56] Krinkle, I recently hd to reintroduce some ve.getProp() and double-check methods for imageinfo in the API, since it does return results without imageinfo sometimes. [22:03:35] mooeypoo: Cool. Would be good to have an example of that. I smell that might be a bug in the API. [22:03:41] Which is fixable :) [22:04:02] Krinkle, yeah I wrote a comment about it and talked to RoanKattouw_away about it too, I thinkwe reported it (not sure) [22:04:09] okay [22:04:19] Krinkle, basically, we found a nice little case where the image PAGE exists but the image itself doesn't [22:04:30] ah, yeah. [22:04:37] this was in beta labs, but I reproduced it locally by just creating an empty File:Blah.jpg page [22:04:46] that's actually quite common on Commons. (not percentage wise, but quantity wise) [22:04:52] so in beta labs, apparently, a lot of commons images were copied but not completely, or something [22:05:00] yeah [22:05:03] Often happens as result of vandalism [22:05:12] but also as result of failed Flickr imports [22:05:14] so it returns a response without imageinfo [22:05:19] Yea [22:05:37] mooeypoo: But that's deep inside the response [22:05:40] the root will still be there [22:05:43] describing the page [22:05:46] so that's only one level deep [22:05:50] which is very sensible [22:06:01] the page object will exist, but its property may not exist. Yeah [22:06:16] Krenair: o/ qunit-karma passing [22:06:24] Krinkle, found the patch https://gerrit.wikimedia.org/r/#/c/190111/ [22:06:51] mooeypoo: Yeah, and that shouldn't involve getProp [22:06:55] Krinkle, yep, you're right, and I only checked if imageinfo exists and not getProp [22:07:18] *but* that raised a question about the general trustworthiness of the data we're receiving, especially in cases of images and their infos [22:07:23] infoses [22:07:26] ;) [22:07:38] like extmetadata [22:07:55] Also because the contract with the API is for images specifically. E.g. if you comibine this API query with other page names (e.g. articles or templates) those woulnd't have .imageinfo either. So the API does not gurantee it to be there by design. [22:08:09] Krinkle, right, good point [22:08:22] This is why Query-apis are hard to use. Compared to standalone APIs, which have their own error handling [22:08:39] short of providing an invalid title, query will never return error [22:08:50] itll say the page doesn't exist,or include the page but not with teh data you requested. [22:09:11] Krinkle, yeah [22:09:12] So the one level between pages-> properties is and should be conditinoal. [22:09:16] and the documentation isn't entirely helpful either [22:09:29] a question about OOJS UI, is there a documentation (or something i can refer to) on the class name conventions in OOJS UI? bit confused between buttonElement, buttonWidget, labelElement, flaggedElement, actionWidget etc. [22:09:31] But the path from data to data.query.pages and from page property to its values should be unconditional [22:09:50] Krinkle, I hope so, since I use it unconditionally in most places [22:10:12] Yeah, that's the same as calling a function returning an object and accessing its properties. if those are missing, that warrants an exception. [22:10:16] Krinkle, I think I was so jaded by the responses we got from extmetadata (Because of user templates, mostly) that I just didn't feel like i can trust the API responses in general [22:10:17] 10OOjs-UI: OO.ui.ActionFieldLayout doesn't properly accept a jQuery for its label config value - https://phabricator.wikimedia.org/T90936#1071706 (10Catrope) a:3Catrope [22:10:40] Yeah, defensive coding is a good instinct [22:10:49] Krinkle, but you're talking about the basic structure, which is a good point [22:10:49] 10VisualEditor, 10VisualEditor-CopyPaste, 7Verified-in-Phase0, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1071707 (10Etonkovidova) [22:11:16] MatmaRex: [22:12:10] James_F: So. First passing qunit-karma build on https://gerrit.wikimedia.org/r/#/c/193268/ [22:12:16] 1 minute faster than old qunit [22:13:18] nzr: the *Element classes are mostly internal, you probably don't need to know about them unless you're implementing new Widgets [22:13:26] nzr: *Widget classes is the good stuff [22:14:09] (03CR) 10Mooeypoo: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191766 (owner: 10Mooeypoo) [22:14:12] nzr: We don't really have docs on naming conventions I think, that's a great thing to bring to KirstenMA's attention [22:14:15] (hm she's not here) [22:14:28] nzr: widgets are built out of many elements. for example, a ButtonWidget is composed out of a ButtonElement, IconElement, IndicatorElement, and LabelElement [22:14:54] (you can guess which part of the widget each of these provides) [22:15:16] we don't have a lot of "internal" documentation, but we recently gained a pretty neat usage guide [22:15:32] https://www.mediawiki.org/wiki/OOjs_UI [22:15:36] nzr: does this help? [22:17:33] okay, the modular part makes sense but what is the difference between buttonelement and buttonwidget? [22:19:11] (03CR) 10Mooeypoo: Refactor MWMediaResultWidget to resize better (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 (owner: 10Mooeypoo) [22:19:49] (03PS5) 10Mooeypoo: Refactor MWMediaResultWidget to resize better [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 [22:22:58] 10OOjs-UI, 10VisualEditor, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: ~50ms spent animating a.oo-ui-buttonElement-button - https://phabricator.wikimedia.org/T88386#1071779 (10TrevorParscal) 5Open>3Resolved Was fixed by previous performance improvements. [22:24:43] 10MediaWiki-Page-editing, 7JavaScript: LivePreview fires wikipage.content hook before attaching content, which breaks some scripts - https://phabricator.wikimedia.org/T90851#1071797 (10TheDJ) Both TMH and MathJax have patches that fix this using solution 2 now. [22:25:09] 10OOjs-UI, 10VisualEditor: Implement a way to squish toolbars when there's not enough horizontal space - https://phabricator.wikimedia.org/T90815#1071802 (10matmarex) I don't think the mockup is going to work well in practice, and it would be difficult to implement with the current toolbar code. But there's pl... [22:26:31] nzr: sorry, didn't see your reply [22:27:04] MatmaRex: did your window fix get merged into ve or mw yet? [22:27:12] we need to get a pull through together if not [22:27:25] TrevorParscal: probably not [22:27:48] I'll poke James_F|Away about it when he returns [22:28:06] 10MediaWiki-Page-editing, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 7JavaScript, 5Patch-For-Review: Dynamically loading TimedMediaHandler for new content (preview) - https://phabricator.wikimedia.org/T74675#1071821 (10TheDJ) The patches should be working now. There is still further cleanup... [22:28:09] nzr: ButtonElement is a low-level building block, that provides something that looks like a button. ButtonWidget is one of the users of ButtonElement, which implements something that actually behaves like a button. [22:29:00] we also use ButtonElement for some button-like things that we don't need the whole baggage of default behavior for – there's a ButtonSelectWidget that uses it internally, for example [22:29:17] https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/ [22:30:08] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, 5§ VisualEditor Q3 Blockers: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#1071836 (10ssastry) a:3ssastry [22:35:56] (03PS12) 10Mooeypoo: Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) [22:42:48] (03PS1) 10Catrope: Don't call LabelElement constructor twice for ActionFieldLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/193277 (https://phabricator.wikimedia.org/T90936) [22:47:01] TrevorParscal: What were you poking me about? [22:47:23] just curious about pull throughs for that window fix MatmaRex landed earlier [22:48:39] Should we backport https://gerrit.wikimedia.org/r/#/c/193027/ ? [22:49:09] Krenair: James is four hours ahead of you https://gerrit.wikimedia.org/r/#/c/193151/ [22:49:29] ah. I probably saw that earlier and forgot about it [22:49:30] I'll put that in today's SWAT, actually [22:49:42] I was about to do so [22:49:51] Oh go for it then [22:50:26] TrevorParscal: Anything else you want to put in the emergency OOjs UI release? [22:51:19] https://gerrit.wikimedia.org/r/192878 so that people can get used to writing Element.static.infuse() ? [22:51:37] unless we've decided that it should be Element.infuse() instead, I'm so (con)fused. [22:51:59] cscott: Breaking change? [22:52:02] * James_F glares. [22:52:10] no, OO.ui.infuse is still an alias. [22:52:35] we agreed that OO.ui.Element.static.infuse() was too long for anyone who wasn't a type-safety bondage-and-discipline enthusiast. [22:53:05] but some people (MatmaRex) will probably enjoy all the typing, for the promise of slightly-better type safety. [22:53:52] (03CR) 10Alex Monk: [C: 032] Follow-up I18162f04: Send uselang parameter with paction=parse request [extensions/VisualEditor] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/193151 (owner: 10Jforrester) [22:54:01] James_F: no, that was the only urgent thing [22:54:03] but i am a little confused by the current plan for https://phabricator.wikimedia.org/T89721, so maybe it should wait after all. [22:54:04] OK. [22:54:08] cscott: lol!! [22:54:21] TrevorParscal: So, want to put in https://gerrit.wikimedia.org/r/192878 too? [22:54:35] No rush, but you've got 3 minutes. ;-) [22:54:50] (the idea is that you would actually use OO.ui.ButtonWidget.static.infuse('my-button-widget') if you 'knew' the result should be a button widget) [22:54:58] James_F: I've thought better of it. [22:55:07] OK… [22:55:37] according to https://phabricator.wikimedia.org/T89721 there's a chance we might name it OO.ui.Element.infuse() instead AIUI (no '.static'), I don't want to rush something in until that's well and decided. [22:56:00] and OO.ui.ButtonWidget.infuse() would be slightly easier on the bondage-and-discipline enthusiasts. [22:56:07] (03Merged) 10jenkins-bot: Follow-up I18162f04: Send uselang parameter with paction=parse request [extensions/VisualEditor] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/193151 (owner: 10Jforrester) [22:56:07] which they might not like, come to think of it. [22:56:16] sort of defeats the point, don't it? [22:56:38] James_F: yes [22:56:41] (03PS1) 10Jforrester: Tag v0.8.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193279 [22:56:47] TrevorParscal: ^^^ Please. [22:57:00] (03CR) 10Trevor Parscal: [C: 032] Tag v0.8.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193279 (owner: 10Jforrester) [22:57:31] Ta. [22:57:40] cscott: i'm all for having a nice alias [22:57:48] ve.ui.infuse is fine [22:58:01] we put other utilities in that space [22:58:05] see ve.ui.js [22:58:15] mostly factories [22:58:17] TrevorParscal: OO, not ve [22:58:24] but, I mean other things /could/ be there [22:58:25] sorry [22:58:29] OO.ui [22:58:39] see core.js [22:58:40] yeah. well, OO.ui.infuse has been released on 0.8 already, so we're stuck with it :) [22:58:46] even better for my point anyway [22:58:55] tons of utilities [22:59:02] the question is whether we want to give it a longer name in the future, so that some people can voluntarily choose to type more. [22:59:15] cscott: i'm saying, I think that's a good place for it, I don't think we need to reconsider it ever [22:59:55] Stand-ip. [22:59:59] Err. Up. [23:00:03] TrevorParscal: i agree, since javascript != java. but i can see the point where you might want to encourage people from the outset to use the proper names when they call infuse so their code is self-documenting. [23:00:11] 10OOjs-UI, 5OOjs-UI-0.8.2, 10VisualEditor, 7Browser-test-bug: [Regression pre-wmf20] Dialogs broken on master - https://phabricator.wikimedia.org/T90858#1071951 (10Jdforrester-WMF) 5Open>3Resolved [23:00:27] 10OOjs-UI, 5OOjs-UI-0.8.2, 10VisualEditor, 7Browser-test-bug: [Regression pre-wmf20] Dialogs broken on master - https://phabricator.wikimedia.org/T90858#1069509 (10Jdforrester-WMF) a:5TrevorParscal>3matmarex [23:00:58] `var widget = OO.ui.infuse( 'my-widget');` doesn't tell you as much as `var myButton = OO.ui.ButtonWidget.infuse( 'my-button')` (note that I cheated there) [23:01:08] (03PS1) 10Bartosz Dziewoński: [WIP] Scrollbar squishing [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T90815) [23:01:24] TrevorParscal: does this look working more on? ^ [23:01:31] look worth* [23:01:41] the only reason I thought about trying to squeeze this into 0.8 was the thought that we might start writing documentation for the infuse capability before 0.9, and it would be nice to use the 'preferred' convention, if that indeed becomes the preferred convention. ;) [23:01:41] RoanKattouw, re: templatedata uselang - I have no idea. It's probably needed for all API calls that rely on outputting messages in the UI language [23:01:50] cscott: it turns out people are very judgmental to our library because it even suggests that they exercise restraint and provides the greatest value when used together with other well structured code, all of which requires a bit of discipline [23:02:22] and most people seem to react with something like "don't tell me how ta' live ma' life! it's ma' hot body, I do what I want!" [23:02:23] TrevorParscal: the WMF is all about denying people their freedom, that's well known. [23:02:27] TrevorParscal, RoanKattouw: Stand-up? [23:03:10] I used to have a readable username. Now I have 'CAnanian (WMF)'. ;-P [23:04:11] anyway, https://www.mediawiki.org/wiki/OOjs_UI/PHP_Examples#Playing_it_safe documents the BDSM syntax, maybe I'll see if anyone complains that it doesn't work yet. :) [23:04:20] Oh yeah standup [23:04:29] James_F: Coming? [23:04:34] cscott: heh [23:05:40] who was it who wanted to use the infusion stuff the other day? i should ping them to let them know it's been released. how long before the release makes it to mediawiki-core? [23:07:37] 10VisualEditor: Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1071968 (10Krenair) I can't reproduce step 4 - I reopened the categories dialog, but the categories are still all gone. [23:08:08] oh -- and wrt to $.isPlainObject -- I was trying to come up with a consistent test that would be appropriate for (just about) any 'required parameter' that might be there. [23:09:32] 10VisualEditor: Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1071984 (10Krenair) Although I can 'Move x category here' on one of the categories which I cancelled addition of, which does error "Uncaught Error: Cannot remove detached item" [23:09:49] 10VisualEditor, 10VisualEditor-MediaWiki: Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1071985 (10Krenair) [23:11:32] cscott: baha [23:11:50] …who's not on irc right now, apparently [23:12:02] bahodir, from mobile [23:12:03] typeof x == 'object' should probably work we should add a test that x.panels is not falsy to take care of GridLayout (typeof [] == 'object'). this would match the php side better, so might not be a bad idea. [23:13:31] Gah. [23:13:35] I need to run. [23:14:02] RoanKattouw_away / Krenair: Can you do the update-oojs-ui.sh dance, and backport the /vendor and mediawiki/core ones to wmf19 please? [23:14:14] * James_F waves. [23:14:17] (incidentally `typeof x === 'some string'` is a hard-coded optimization is all Javascript engines, as far as I'm aware of. for "well known" strings, this compiles to a direct test of the value's type tag. super-efficient. no string comparisons actually involved) [23:15:04] MatmaRex, do you know what that dance is? [23:15:22] no memory operations involved in that comparison, either, since the type tag is stored as the high bits of the pointer. (well, actually, encoded in the NaN type, if you're using NaN boxing) [23:15:38] * cscott shuts up with his compiler talk :) [23:15:41] .bacj [23:15:45] Krenair: I do, I'll do it [23:15:48] ok [23:16:25] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, 5§ VisualEditor Q3 Blockers: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#1072006 (10ssastry) @Catrope: I cannot reproduce this in plain html2wt mode(I trie... [23:16:51] Krenair: vaguely [23:17:06] (03CR) 10jenkins-bot: [V: 04-1] Tag v0.8.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193279 (owner: 10Jforrester) [23:18:11] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, 5§ VisualEditor Q3 Blockers: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#1072008 (10Catrope) >>! In T85782#1072006, @ssastry wrote: > @Catrope: I cannot re... [23:19:20] (03CR) 10Anomie: [C: 031] Don't call LabelElement constructor twice for ActionFieldLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/193277 (https://phabricator.wikimedia.org/T90936) (owner: 10Catrope) [23:41:43] (03PS1) 10Mooeypoo: Add a threshold to 'read more' calculation in media dialog info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) [23:48:57] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, 5§ VisualEditor Q3 Blockers: Deleting column after header column causes all columns to become header columns - https://phabricator.wikimedia.org/T85782#1072116 (10cscott) So this is the unmodified parsoid output: ``` (03PS1) 10Trevor Parscal: Add insert/edit modes to FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) [23:54:49] TrevorParscal: does this look worth working on? https://gerrit.wikimedia.org/r/193282