[00:04:36] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "Come on Jenkins" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193279 (owner: 10Jforrester)
[00:06:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tag v0.8.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/193279 (owner: 10Jforrester)
[00:08:41] <grrrit-wm>	 (03PS8) 10Trevor Parscal: Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 
[00:09:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal)
[00:09:20] <MatmaRex>	 so, when are we re-enabling manual merges?
[00:09:37] <MatmaRex>	 because it kind of sucks not to be able to merge things when they need to be deployed
[00:09:42] <MatmaRex>	 just sayin'
[00:15:37] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Don't call LabelElement constructor twice for ActionFieldLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/193277 (https://phabricator.wikimedia.org/T90936) (owner: 10Catrope)
[00:16:49] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott)
[00:17:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't call LabelElement constructor twice for ActionFieldLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/193277 (https://phabricator.wikimedia.org/T90936) (owner: 10Catrope)
[00:18:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott)
[00:19:48] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] InputWidget: Focus checkboxes and radios, too, when the label is clicked [oojs/ui] - 10https://gerrit.wikimedia.org/r/193099 (owner: 10Bartosz Dziewoński)
[00:21:05] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "On my localhost, some of the icons still don't rasterize. Will need to clean them up." [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester)
[00:21:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: InputWidget: Focus checkboxes and radios, too, when the label is clicked [oojs/ui] - 10https://gerrit.wikimedia.org/r/193099 (owner: 10Bartosz Dziewoński)
[00:23:14] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Only modify body class when first/last window opens/closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/190806 (https://phabricator.wikimedia.org/T89613) (owner: 10Esanders)
[00:23:41] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/190570 (owner: 10Bartosz Dziewoński)
[00:24:06] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Remove innerOverlay [oojs/ui] - 10https://gerrit.wikimedia.org/r/192574 (owner: 10Esanders)
[00:24:31] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Ewwww." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190806 (https://phabricator.wikimedia.org/T89613) (owner: 10Esanders)
[00:25:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only modify body class when first/last window opens/closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/190806 (https://phabricator.wikimedia.org/T89613) (owner: 10Esanders)
[00:26:25] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Make icon and indicator container sizes consistent [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders)
[00:27:47] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Prevent context from moving if selection is changed by opening [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193077 (https://phabricator.wikimedia.org/T90857) (owner: 10Esanders)
[00:28:14] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Remove unnecessary disconnect in surface destroy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193111 (owner: 10Esanders)
[00:29:27] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Make toolbar dialogs disableable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192569 (owner: 10Esanders)
[00:29:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent context from moving if selection is changed by opening [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193077 (https://phabricator.wikimedia.org/T90857) (owner: 10Esanders)
[00:30:42] <RoanKattouw>	 Wow, $.when() is evil
[00:30:59] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Make toolbar dialog padding configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192550 (owner: 10Esanders)
[00:31:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/190570 (owner: 10Bartosz Dziewoński)
[00:31:38] <RoanKattouw>	 Suppose you have $.when( p1, p2 ).done( function ( a, b ) {  .... } );
[00:31:59] <RoanKattouw>	 If you do p1.resolve( 1, 2 ); p2.resolve( 3, 4 ); , you end up with a = [1,2] and b = [3,4]
[00:32:03] <RoanKattouw>	 Which is sensible
[00:32:08] <RoanKattouw>	 A bit annoying but sensible
[00:32:22] <RoanKattouw>	 But if you resolve with only one argument, then as a "convenience", there's no array wrapper
[00:32:33] <RoanKattouw>	 So p1.resolve( 1 ); p2.resolve( 2 ); gets you a=1, b=2
[00:32:53] <RoanKattouw>	 You can even mix them: p1.resolve( 1, 2 ); p2.resolve( 3 ); results in a = [1,2] and b=3
[00:33:20] <RoanKattouw>	 The ridiculous thing is that you can do p1.resolve( 1, 2, 3 ); p2.resolve( [1,2,3] ); and then a=[1,2,3] and b=[1,2,3]
[00:33:22] <RoanKattouw>	 Good job jQuery
[00:33:26] * RoanKattouw slow claps
[00:37:11] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] Add a threshold to 'read more' calculation in media dialog info (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) (owner: 10Mooeypoo)
[00:39:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove innerOverlay [oojs/ui] - 10https://gerrit.wikimedia.org/r/192574 (owner: 10Esanders)
[00:39:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make icon and indicator container sizes consistent [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders)
[00:41:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unnecessary disconnect in surface destroy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193111 (owner: 10Esanders)
[00:41:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make toolbar dialog padding configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192550 (owner: 10Esanders)
[00:41:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make toolbar dialogs disableable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192569 (owner: 10Esanders)
[00:41:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Create toolbar dialog tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193125 (owner: 10Esanders)
[00:42:23] <grrrit-wm>	 (03PS6) 10Trevor Parscal: Refactor MWMediaResultWidget to resize better [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 (owner: 10Mooeypoo)
[00:44:08] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Refactor MWMediaResultWidget to resize better [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 (owner: 10Mooeypoo)
[00:46:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor MWMediaResultWidget to resize better [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/190400 (owner: 10Mooeypoo)
[00:50:44] <MatmaRex>	 ugh
[00:50:57] <MatmaRex>	 http://bits.beta.wmflabs.org/static-master/extensions/VisualEditor/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
[00:51:10] <MatmaRex>	 the file this serves is three weeks old
[00:51:14] <MatmaRex>	 somebody please tell me why
[00:51:23] <RoanKattouw>	 Caching?
[00:51:29] <RoanKattouw>	 Why is static-master being used anyway
[00:51:33] <RoanKattouw>	 Oh because it's beta labs
[00:51:36] <MatmaRex>	 threeeee weeks
[00:51:40] <RoanKattouw>	 Well debug mode in beta labs is probably pretty broken
[00:51:44] <MatmaRex>	 i just spent a lot of time debugging why debug mode is fucked
[00:52:02] <MatmaRex>	 i mean, http://i.imgur.com/yTozcDn.png
[00:56:13] <RoanKattouw>	 Right
[00:56:30] <MatmaRex>	 https://phabricator.wikimedia.org/T90983
[00:56:48] <mooeypoo>	 MatmaRex, it's worse in RTL
[01:30:18] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5§ VisualEditor Q3 Blockers: Comment is not getting added after Citation, Template,Gallery,Math node and Table - https://phabricator.wikimedia.org/T90517#1072613 (10matmarex) As far as I can tell this is a Parsoid issue, or possibly in the RESTy things between VE...
[01:31:00] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid, 5§ VisualEditor Q3 Blockers: Comment is not getting added after Citation, Template,Gallery,Math node and Table - https://phabricator.wikimedia.org/T90517#1072617 (10matmarex) a:5matmarex>3None
[01:49:58] <grrrit-wm>	 (03CR) 10Krinkle: "Do we account for undefined in the users of this method? It seems it would propagate from batchQueue.processPage() in processQueue(), to b" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193268 (https://phabricator.wikimedia.org/T90916) (owner: 10Alex Monk)
[01:54:26] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Distorted UI of Language Inspector/Special Character appears while trying to open them when the link inspector is already open in CE - https://phabricator.wikimedia.org/T71202#1072707 (10Etonkovidova) Re-checked it in Ptoduction and test2 -  the Langua...
[01:54:52] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Distorted UI of Language Inspector/Special Character appears while trying to open them when the link inspector is already open in CE - https://phabricator.wikimedia.org/T71202#1072708 (10Etonkovidova) 5Open>3Resolved
[01:56:01] <grrrit-wm>	 (03PS2) 10Krinkle: core: Improve class related unit tests [oojs/core] - 10https://gerrit.wikimedia.org/r/193153 
[01:58:36] <grrrit-wm>	 (03PS2) 10Mooeypoo: Add a threshold to 'read more' calculation in media dialog info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) 
[02:12:40] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Google-Chrome: Cannot delete a list style, if present at the start of the page by pressing the “Backspace” key. - https://phabricator.wikimedia.org/T69392#1072736 (10Etonkovidova) If there is no content above bullet list - the last bullet point...
[02:13:08] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Google-Chrome: Cannot delete a list style, if present at the start of the page by pressing the “Backspace” key. - https://phabricator.wikimedia.org/T69392#1072737 (10Etonkovidova) 5Open>3declined
[02:21:18] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: copying a text and moving down using the arrow adds a space - https://phabricator.wikimedia.org/T70676#1072741 (10Etonkovidova) Not reproducible anymore - marking it as Resolved.   For such issues any additional info would be helpful: which browser/...
[02:21:28] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: copying a text and moving down using the arrow adds a space - https://phabricator.wikimedia.org/T70676#1072743 (10Etonkovidova) 5Open>3Resolved
[02:30:23] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: The highlight that appears after adding a template while selecting an image is not proper - https://phabricator.wikimedia.org/T70411#1072761 (10Etonkovidova) 5Open>3Resolved
[02:35:27] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Can't paste in ref dialog - https://phabricator.wikimedia.org/T65252#1072764 (10Etonkovidova) 5Open>3Resolved
[04:41:44] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid, 5§ VisualEditor Q3 Blockers: Comment is not getting added after Citation, Template,Gallery,Math node and Table - https://phabricator.wikimedia.org/T90517#1072846 (10ssastry) This session shows that Parsoid is correctly serializing the html. So, worth...
[06:52:37] <wikibugs>	 10MediaWiki-Page-editing: Parser profiling data should remain collapsible when using LivePreview - https://phabricator.wikimedia.org/T91046#1072885 (10Dalba) 3NEW
[10:10:20] <edsanders>	 InezK_away, no good reason I think the wikitext variable was introduced later
[10:48:04] <wikibugs>	 10MediaWiki-Page-editing: Parser profiling data should remain collapsible when using LivePreview - https://phabricator.wikimedia.org/T91046#1073085 (10Aklapper) p:5Triage>3Lowest
[10:48:48] <wikibugs>	 10MediaWiki-Page-editing: Parser profiling data should remain collapsible when using LivePreview - https://phabricator.wikimedia.org/T91046#1072885 (10Aklapper)
[10:48:49] <wikibugs>	 10MediaWiki-Page-editing, 10MediaWiki-RfCs, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1073086 (10Aklapper)
[11:04:05] <wikibugs>	 10MediaWiki-Page-editing: Parser profiling data should remain collapsible when using LivePreview - https://phabricator.wikimedia.org/T91046#1073124 (10TheDJ) Related to, if not duplicate with: T55918
[11:49:34] <grrrit-wm>	 (03PS1) 10Esanders: i18n for edit button in context item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193346 
[11:52:25] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates: First paragraph for news articles at fr.news ends up inside Template:Date - https://phabricator.wikimedia.org/T90921#1073201 (10Aklapper)
[13:43:20] <wikibugs>	 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Vagrant, 10Wikidata, and 2 others: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1073327 (10Krinkle) This change ([Ic416def846f361425c46f7b](https://gerrit.wikimedia.o...
[13:50:36] <wikibugs>	 10MediaWiki-Page-editing: Edits that were created using StashEdit API show wrong timestamp - https://phabricator.wikimedia.org/T84843#1073330 (10Umherirrender)
[14:07:09] <wikibugs>	 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Vagrant, 10Wikidata, and 2 others: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1073364 (10JanZerebecki) Test run without that setting: https://integration.wikimedia....
[14:11:11] <wikibugs>	 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, 7Performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1073374 (10mobrovac) a:3mobrovac
[14:24:38] <wikibugs>	 10MediaWiki-Page-editing: Difference between timestamps in signature and site interface. - https://phabricator.wikimedia.org/T84843#1073397 (10MaxBioHazard)
[14:25:07] <mobrovac>	 hey guys
[14:26:15] <mobrovac>	 i plan to start working on using restbase as a backend for VE instead of Parsoid (https://phabricator.wikimedia.org/T89066) but I have a question
[14:26:37] <mobrovac>	 to your knowledge, is mediawiki-vagrant used in conjunction with VE?
[14:26:48] <mobrovac>	 i.e. do people test/use it there actively?
[14:49:52] <grrrit-wm>	 (03PS1) 10Esanders: Make align widget work when config is undefined [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193367 
[14:49:54] <grrrit-wm>	 (03PS1) 10Esanders: Remove absolute positioning from description [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193368 
[14:49:56] <grrrit-wm>	 (03PS1) 10Esanders: Provide isAlignable checks for alignable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193369 
[14:49:58] <grrrit-wm>	 (03PS1) 10Esanders: Create AlignableContextItem to quickly adjust AlignableNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193370 
[14:51:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide isAlignable checks for alignable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193369 (owner: 10Esanders)
[14:54:11] <grrrit-wm>	 (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193369 (owner: 10Esanders)
[14:56:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make align widget work when config is undefined [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193367 (owner: 10Esanders)
[15:22:06] <grrrit-wm>	 (03PS1) 10Esanders: Files for special character inserter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 
[15:27:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Files for special character inserter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders)
[15:29:30] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "I still get an exception when editing a basic reference:" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal)
[15:36:48] <wikibugs>	 10VisualEditor, 10Continuous-Integration, 5§ VisualEditor Q3 Blockers: Concurrent builds using local Chromium/Firefox browsers on Linux host fail - https://phabricator.wikimedia.org/T90673#1073556 (10Krinkle) Today I investigated this on integration-slave1010. I set up a MediaWiki by running the build manual...
[15:38:59] <wikibugs>	 10VisualEditor, 10Collaboration-Team-Sprint-R-2015-03-11, 10Flow: R1. Spike: Add relevant MW features to VE on Flow - https://phabricator.wikimedia.org/T90760#1073576 (10matthiasmullie) a:3matthiasmullie
[16:10:59] * werdna waves MatmaRex 
[16:11:42] <MatmaRex>	 hi
[16:16:04] <werdna>	 I'm looking to add the possibility to add extra CSS filters to resource loader (specifically, a filter that replaces colours to simulate colour blindness) for certain requests. Any idea how I might go about that?
[16:20:05] <grrrit-wm>	 (03PS2) 10Esanders: Create AlignableContextItem to quickly adjust AlignableNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193370 
[16:23:57] <grrrit-wm>	 (03CR) 10Mvolz: Make zotero.js an object (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[16:24:11] <grrrit-wm>	 (03PS11) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[16:24:16] <MatmaRex>	 werdna: there doesn't seem to be a way to do this, you'll need to add a new hook somewhere in core
[16:24:30] <grrrit-wm>	 (03PS8) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[16:24:45] <grrrit-wm>	 (03PS3) 10Mvolz: Add ability to set requesting User-Agent [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) 
[16:25:40] <MatmaRex>	 werdna: probably in ResourceLoaderFileModule::readStyleFile() for a simple solution working for almost all cases
[16:25:59] <werdna>	 MatmaRex: I found a filter() function in ResourceLoader.php used for minifying
[16:26:05] <werdna>	 so I thought maybe I could hook into that
[16:26:43] <MatmaRex>	 oh, hmm. that would probably also work
[16:29:27] <grrrit-wm>	 (03CR) 10Mvolz: Make zotero.js an object (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[16:32:55] <grrrit-wm>	 (03PS12) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[16:34:14] <wikibugs>	 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, 7Performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1073712 (10GWicke)
[16:39:38] <grrrit-wm>	 (03PS9) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[16:40:36] <grrrit-wm>	 (03PS4) 10Mvolz: Add ability to set requesting User-Agent [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) 
[16:40:46] <grrrit-wm>	 (03PS2) 10Mvolz: [WIP] User Agent Config [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 
[17:33:07] <grrrit-wm>	 (03PS10) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[17:35:26] <grrrit-wm>	 (03PS11) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[17:36:16] <TrevorParscal>	 James_F: howdy
[17:36:47] <James_F>	 TrevorParscal: How are you?
[17:36:51] <TrevorParscal>	 yeah, ok
[17:36:56] <TrevorParscal>	 kidlets are falling apart
[17:36:59] <James_F>	 :-(
[17:37:02] <James_F>	 Ill?
[17:37:03] <TrevorParscal>	 but, otherwise I'm well
[17:37:05] <TrevorParscal>	 yeah
[17:37:10] <mooeypoo>	 aw!
[17:37:32] * James_F hugs. At a safe, non-infectious distance.
[17:37:54] <TrevorParscal>	 Aurora was sick yesterday, seems to be able to keep food down today (guess it's a 24hr thing) and then we were up really late with Blaise who seems to have got it too
[17:38:08] <TrevorParscal>	 so, are you planning on doing the metrics thing?
[17:38:14] <grrrit-wm>	 (03PS1) 10Esanders: Fix size of context item icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193391 
[17:38:16] <TrevorParscal>	 should I ignore that? or do you want me to do it?
[17:39:01] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Fix size of context item icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193391 (owner: 10Esanders)
[17:39:07] <James_F>	 We should work together on it. :-)
[17:39:13] <James_F>	 I've been out walking a bunch.
[17:39:21] <James_F>	 Need to knuckle down.
[17:41:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix size of context item icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193391 (owner: 10Esanders)
[17:42:51] <James_F>	 TrevorParscal: You seen edsanders's comments on https://gerrit.wikimedia.org/r/192972 about it not working?
[17:43:44] <grrrit-wm>	 (03CR) 10Jforrester: "Is this to replace I40ab227ac ?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193370 (owner: 10Esanders)
[17:44:22] <grrrit-wm>	 (03PS2) 10Jforrester: [PULL THROUGH] Files for special character inserter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders)
[17:45:23] <grrrit-wm>	 (03CR) 10Esanders: "Looks like it does the same thing, so yes." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193370 (owner: 10Esanders)
[17:46:01] <grrrit-wm>	 (03Abandoned) 10Jforrester: [WIP] Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester)
[17:49:29] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] i18n for edit button in context item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193346 (owner: 10Esanders)
[17:50:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Files for special character inserter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders)
[17:51:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n for edit button in context item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193346 (owner: 10Esanders)
[17:54:01] <Krinkle>	 James_F: Ugh, so I've "narrowed" down that Firefox/Chrome disconnecting is not caused by concurrency but could in fact be caused by anything.
[17:54:13] <James_F>	 Krinkle: … helpful.
[17:54:18] <Krinkle>	 At least I can consistently reproduce it (see bug for details)
[17:54:38] <grrrit-wm>	 (03CR) 10Jforrester: "Needs rebasing…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders)
[17:54:53] <Krinkle>	 I'll need upstream to provide some debugging tools (or patch karma locally), as even their loglevel=debug is insufficient to state why or how it was disconnected.
[17:55:16] <Krinkle>	 Getting screenshots from integration slaves was exciting though :)
[17:55:29] <Krinkle>	 Cool to see chromium and firefox pop up and do their work
[17:55:49] <Krinkle>	 20 at once
[17:55:59] <Krinkle>	 but tests passed
[17:56:01] <Krinkle>	 :(
[17:56:15] <Krinkle>	 (with 20x chromium+firefox on one server)
[17:58:02] <mooeypoo>	 hm, did we update ooui in mw yesterday'ish ?
[17:58:10] <Krenair>	 hopefully
[17:58:27] <mooeypoo>	 I am still getting the window bug locally with master MW and master VE
[17:58:46] <Krenair>	 hm, nope, still broken
[17:59:04] <James_F>	 Fixing now.
[17:59:10] <mooeypoo>	 awesomesauce
[17:59:22] <James_F>	 RoanKattouw_away: Thanks for taking care of that like I asked. :-P
[17:59:24] <mooeypoo>	 ok, going to see if I can set up the standup by myself....
[18:02:16] <InezK>	 edsanders: Actually I'm not sure if that check makes sense at all, if extension has empty extsrc it does not mean that it will render to something "empty". It can render based on attrs.
[18:02:53] <TrevorParscal>	 James_F: standup?
[18:02:57] <James_F>	 TrevorParscal: Am in it…
[18:03:12] <TrevorParscal>	 cool story bro
[18:03:54] <TrevorParscal>	 waiting for you man
[18:03:57] <James_F>	 TrevorParscal: Is this Google's split-brain issue again?
[18:04:04] <James_F>	 TrevorParscal: I've been in it for 10 minutes waiting…
[18:04:05] <TrevorParscal>	 maybe?
[18:04:37] <James_F>	 I've reloaded and still it's empty.
[18:04:42] <James_F>	 Did you go to the wrong URL?
[18:05:06] <InezK>	 google
[18:05:13] <James_F>	 Aha. Now there are others.
[18:10:31] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: [BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/190570 
[18:10:35] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.8.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193399 
[18:11:34] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Per Trevor" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190570 (owner: 10Bartosz Dziewoński)
[18:13:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] TextInputWidget: Remove 'icon' and 'indicator' events [oojs/ui] - 10https://gerrit.wikimedia.org/r/190570 (owner: 10Bartosz Dziewoński)
[18:13:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.8.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193399 (owner: 10Jforrester)
[18:16:02] <James_F>	 Eurgh.
[18:16:36] <MatmaRex>	 so when are we enabling manual merges?
[18:16:56] <MatmaRex>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/193282/ is the scrollbar squishing that i need you to look at
[18:17:06] <TrevorParscal>	 will look
[18:17:36] <James_F>	 MatmaRex: That's a real failure. Stop trolling.
[18:17:47] <grrrit-wm>	 (03PS14) 10Paladox: Adds svg to css file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181788 (https://phabricator.wikimedia.org/T37342) 
[18:18:06] <MatmaRex>	 meh
[18:18:36] <MatmaRex>	 did we not update ve/ve to 0.8.1? huh.
[18:19:25] <MatmaRex>	 if we didn't, then it doesn't need emergency update to 0.8.2, by the way.
[18:20:18] <kirstenMA>	 Hi, I was wondering about methods like bindMouseDownListener( ) bindKeyDownListener()... should they be marked protected/private in the docs?
[18:20:52] <MatmaRex>	 kirstenMA: probably protected
[18:21:03] <kirstenMA>	 thanks. will do.
[18:21:15] <MatmaRex>	 (i think we override and use them in subclasses)
[18:22:23] <grrrit-wm>	 (03PS2) 10Jforrester: Update OOjs UI to v0.8.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193399 
[18:22:46] <wikibugs>	 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, 7Performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1074102 (10greg) Where are we on the timeline for this? (Deployment calendar says "late feb early march")
[18:22:48] <kirstenMA>	 okay. how about something like chooseItem() in selectWidget? We say all over not to modify 'choose' programmatically. Should that be marked? 
[18:23:05] <James_F>	 MatmaRex: We did; https://gerrit.wikimedia.org/r/#/c/193033/ never got fixed or merged.
[18:23:14] <James_F>	 MatmaRex: Another thing for me to grumble at RoanKattouw about. ;-)
[18:23:55] <RoanKattouw>	 WTF is 'OO.ui.HtmlSnippet
[18:24:10] <grrrit-wm>	 (03Abandoned) 10Jforrester: Update OOjs UI to v0.8.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193033 (owner: 10Jforrester)
[18:24:34] <James_F>	 RoanKattouw: Added as part of the Infuse stuff. Just merge it already.
[18:25:00] <James_F>	 RoanKattouw: Also you'll need to ask Greg for an emergency deploy slot.
[18:25:04] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.8.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193399 (owner: 10Jforrester)
[18:25:09] <RoanKattouw>	 Yeah will do
[18:25:13] <James_F>	 Thanks.
[18:25:47] <wikibugs>	 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, 7Performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1074120 (10mobrovac) @greg should be right on time. We are contemplating a possible multi-step solution where the first step...
[18:26:21] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: ↵ is shown when wikicode contains single newline, which is not very WYSIWYG - https://phabricator.wikimedia.org/T50290#1074123 (10Whatamidoing-WMF) I like the idea of showing it as a line break.  This might make more sense to less-technical people t...
[18:26:42] <Krinkle>	 Yay, 0.8 also includes all the new wonderful documentation updates from kirstenMA :)
[18:26:57] <kirstenMA>	 :)
[18:27:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.8.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193399 (owner: 10Jforrester)
[18:27:40] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: ↵ is shown when wikicode contains single newline, which is not very WYSIWYG - https://phabricator.wikimedia.org/T50290#1074130 (10Jdforrester-WMF) >>! In T50290#1074123, @Whatamidoing-WMF wrote: > I like the idea of showing it as a line break.  This...
[18:28:43] <James_F>	 Krinkle: Some of them are in 0.8.1 too. kirstenMA is prodigious. :-)
[18:28:46] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5§ VisualEditor Q3 Blockers: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - https://phabricator.wikimedia.org/T51806#1074133 (10Whatamidoing-WMF)
[18:29:56] <kirstenMA>	 Well, James_F, I had a great gerrit reviewer
[18:30:18] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "v0.9.0 ahoy." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 (owner: 10Bartosz Dziewoński)
[18:30:21] <kirstenMA>	 I did that wrong... I don't do irc.. why is your name not linked?
[18:30:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "v0.9.0 ahoy." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński)
[18:30:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Remove deprecated LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński)
[18:30:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Remove deprecated GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 (owner: 10Bartosz Dziewoński)
[18:31:10] <James_F>	 kirstenMA: It's highlighted here; maybe your client only links when it's the first item on the line?
[18:31:30] <kirstenMA>	 ah, okay. thanks.
[18:32:21] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: ↵ is shown when wikicode contains single newline, which is not very WYSIWYG - https://phabricator.wikimedia.org/T50290#1074137 (10Jaredzimmerman-WMF) Unless I'm misunderstanding Whatamidoing, I think they mean that we copy line breaks in as actual l...
[18:35:07] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: ↵ is shown when wikicode contains single newline, which is not very WYSIWYG - https://phabricator.wikimedia.org/T50290#1074156 (10Jdforrester-WMF) >>! In T50290#1074137, @Jaredzimmerman-WMF wrote: > Unless I'm misunderstanding Whatamidoing, I think...
[18:36:35] <grrrit-wm>	 (03PS6) 10Jforrester: [BREAKING CHANGE] Remove deprecated LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński)
[18:40:41] <grrrit-wm>	 (03PS1) 10Kmenger: PopupElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/193405 
[18:40:49] <MatmaRex>	 kirstenMA: that sounds like a public method to me, we call it from elsewhere
[18:41:05] <kirstenMA>	 okay. thanks.
[18:41:07] <MatmaRex>	 kirstenMA: or "private friend" or something, but we don't do these :)
[18:41:12] <kirstenMA>	 lol
[18:41:53] <MatmaRex>	 RoanKattouw: HtmlSnippet in JS is a sign that internals of our PHP and JS implementations of OOUI have diverged initially, and now we've forcibly brought them back together
[18:42:44] <MatmaRex>	 RoanKattouw: we now have at least five different ways to specify that some text should be shown inside a button
[18:43:19] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "PS6 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński)
[18:43:42] <RoanKattouw>	 haha
[18:44:40] <MatmaRex>	 i need to file some bugs about it
[18:45:10] <grrrit-wm>	 (03PS3) 10Jforrester: [BREAKING CHANGE] Remove deprecated GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 (owner: 10Bartosz Dziewoński)
[18:45:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove deprecated LookupInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/185257 (https://phabricator.wikimedia.org/T86851) (owner: 10Bartosz Dziewoński)
[18:45:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "PS3 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 (owner: 10Bartosz Dziewoński)
[18:47:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove deprecated GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/189478 (owner: 10Bartosz Dziewoński)
[18:48:03] <TrevorParscal>	 MatmaRex: so... this squishing change
[18:48:20] <grrrit-wm>	 (03PS2) 10Catrope: [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 
[18:48:22] <grrrit-wm>	 (03PS1) 10Catrope: Make generateCitationFeatures() idempotent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193407 
[18:48:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope)
[18:48:37] <RoanKattouw>	 Krinkle|detached: So hopefully https://gerrit.wikimedia.org/r/193026 will give you a good idea of what I'm trying to do
[18:48:58] <MatmaRex>	 yeah? kinda meh, isn't it?
[18:50:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make generateCitationFeatures() idempotent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193407 (owner: 10Catrope)
[18:53:53] <RoanKattouw>	 Ugh, WTF happened to jshint
[18:55:04] <RoanKattouw>	 James_F: There's no point rechecking the OOUI change because https://integration.wikimedia.org/ci/job/mediawiki-core-npm/3982/console is a "real" failure
[18:55:33] <James_F>	 RoanKattouw: Yeah, but doesn't happen locally; I assumed it was a transient CI muck-up.
[18:55:44] <RoanKattouw>	 It does happen for me locally
[18:55:49] <James_F>	 RoanKattouw: Those files pass in master for me…
[18:55:54] <James_F>	 Did someone bypass CI?
[18:55:58] <RoanKattouw>	 James_F: What does "npm ls jshint" return in your MW core checkout?
[18:56:08] <RoanKattouw>	 James_F: No I think jshint broke something in a minor version release
[18:56:14] <James_F>	 Oh. Fun.
[18:56:15] <RoanKattouw>	 You probably have 2.6.0
[18:56:27] <RoanKattouw>	 I ran npm install and now I have 2.6.1 and JSON isn't recognized any more
[18:56:30] <James_F>	 Yeah.
[18:56:33] <James_F>	 Ah.
[18:56:34] * James_F sighs.
[18:56:40] <James_F>	 jshint considered harmful.
[18:57:13] <James_F>	 2.6.1 doesn't come up when I `npm install`.
[18:57:49] <RoanKattouw>	 What comes up when you run "npm ls jshint" ?
[18:57:58] <RoanKattouw>	 I get:
[18:58:00] <RoanKattouw>	 mediawiki@0.0.0 /home/catrope/git/mediawiki/core
[18:58:01] <James_F>	 "<James_> Yeah".
[18:58:02] <RoanKattouw>	 └─┬ grunt-contrib-jshint@0.11.0
[18:58:03] <RoanKattouw>	   └── jshint@2.6.1 
[18:58:13] <RoanKattouw>	 Oh so 2.6.0?
[18:58:24] <James_F>	 mediawiki@0.0.0 /Users/jdforrester/Documents/git/vagrant/mediawiki
[18:58:24] <James_F>	 └─┬ grunt-contrib-jshint@0.11.0
[18:58:24] <James_F>	   └── jshint@2.6.0 
[18:58:25] <RoanKattouw>	 Maybe it's because I installed from scratch that I have 2.6.1
[18:58:26] <edsanders>	 TrevorParscal, https://gerrit.wikimedia.org/r/#/c/193370/
[18:58:35] * James_F wipes and re-installs
[18:59:00] <TrevorParscal>	 The mockup I gave you was meant to convey, not that things should squish automatically to save space, but that we should be able to make adjacent groups render as if they are joined for organizational purposes (and also perhaps it will save some space as well)
[18:59:23] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: ↵ is shown when wikicode contains single newline, which is not very WYSIWYG - https://phabricator.wikimedia.org/T50290#1074247 (10Jaredzimmerman-WMF) @Jdforrester-WMF let me try to rephrase to see if I understand, the carriage return symbol is shown...
[18:59:28] <James_F>	 RoanKattouw: Yup, now I have 2.6.1 and it's broken.
[18:59:29] * James_F sighs.
[18:59:42] <RoanKattouw>	 OK I have one possible fix already
[18:59:45] <RoanKattouw>	 But let me try another
[18:59:49] * James_F nods.
[18:59:55] <edsanders>	 TrevorParscal, huh?
[19:00:19] <TrevorParscal>	 ???
[19:00:36] <edsanders>	 was that last comment in response to my patch?
[19:00:51] <TrevorParscal>	 no, MatmaRex's
[19:01:05] <RoanKattouw>	 OK so I can't pin jshint to 2.6.0
[19:01:14] <RoanKattouw>	 Because it's installed as a dependency of grunt-jshint-contrib 0.11.0
[19:01:20] <RoanKattouw>	 And its version number didn't change
[19:03:04] <MatmaRex>	 TrevorParscal: okay, i missed that then. rendering different groups as if they were merged together doens't look very feasible, though.
[19:03:25] <TrevorParscal>	 lol...
[19:03:30] <James_F>	 RoanKattouw: We can just add JSON as a global.
[19:03:36] <James_F>	 RoanKattouw: It's a hack, but…
[19:03:39] <TrevorParscal>	 sorry I guess I must have done a terrible job explaining this
[19:04:16] <TrevorParscal>	 we were hoping to get the general effect of a tool tree structure, without having to actually implement it
[19:04:45] <TrevorParscal>	 using CSS hacks or something...
[19:05:33] <grrrit-wm>	 (03PS1) 10Kmenger: SelectWidget: Marked protected methods and clarified choose/press descriptions [oojs/ui] - 10https://gerrit.wikimedia.org/r/193413 
[19:06:31] <MatmaRex>	 TrevorParscal: it can't be done CSS-only because of the hover effects on the group
[19:07:06] <MatmaRex>	 TrevorParscal: it possibly can be done with JS, but actually supporting this would really suck, and there's no sane way to structure the "configuration"
[19:07:14] <MatmaRex>	 so we could maybe do this as one-off in VE
[19:07:33] <MatmaRex>	 if you specify what exactly needs to be implemented
[19:07:33] <TrevorParscal>	 what if we had grouping for groups?
[19:07:55] <MatmaRex>	 Tool, ToolGroup, and ToolGroupGroup? eww
[19:08:00] <TrevorParscal>	 by default they are in their own group (normal behavior we have now
[19:08:05] <TrevorParscal>	 I know man
[19:08:07] <TrevorParscal>	 believe me
[19:08:11] <mooeypoo>	 uhm, for Hackathon projects, do I just add a phabricator task with Wikimania-Hackathon-2015 project in them?
[19:08:14] <mooeypoo>	 anyone knows?
[19:08:20] <TrevorParscal>	 but I'm trying to put off the major toolbar rewrite a little longer
[19:08:28] <TrevorParscal>	 but also achieve some of the benefits
[19:08:52] <TrevorParscal>	 ToolSection
[19:08:59] <TrevorParscal>	 sections have groups, groups have tools
[19:09:16] <TrevorParscal>	 sections are only at the bar level, and are what actually produce those outlines on hover
[19:09:47] <TrevorParscal>	 thoughts?
[19:10:44] <TrevorParscal>	 basically, we add another level of structure, so instead of 2 we have 3, by adding the section level, and we move the outline/hover effect to the section level
[19:10:57] <TrevorParscal>	 sections will be very simple, only one kind (they are all bar-style)
[19:11:25] <MatmaRex>	 hm.
[19:13:37] <wikibugs>	 10VisualEditor, 10Wikimedia-Hackathon-2015: Create an extension/gadget that prompts the user to add citation when they edit in VisualEditor - https://phabricator.wikimedia.org/T91101#1074319 (10Mooeypoo) 3NEW a:3Mooeypoo
[19:13:44] <James_F>	 TrevorParscal: ToolGrouping maybe?
[19:13:52] * James_F is just style and no substance.
[19:14:19] <TrevorParscal>	 MatmaRex's point is, without the DOM changing, we can't really get the hover effect to work correctly
[19:14:41] <James_F>	 Right. :-(
[19:14:48] <TrevorParscal>	 by introducing a level of grouping above groups (I'm suggesting we call ToolSection) we get that
[19:15:01] <TrevorParscal>	 but, it means we need to adjust the toolbar configurations a bit
[19:15:07] * James_F nods.
[19:15:19] <MatmaRex>	 yeah, that would be somewhat backawrds-incompatible, i think?
[19:15:35] <MatmaRex>	 what if we made a ToolGroupTool?
[19:15:42] <MatmaRex>	 a tool that wraps a tool group
[19:15:49] <James_F>	 One or more groups?
[19:15:53] <MatmaRex>	 i mean, "ewww", of course
[19:16:27] <MatmaRex>	 but assuming that we're going to dithc it in a few months, that's less code to write and update now, if it can work
[19:20:41] <James_F>	 OK, I've got to run.
[19:20:52] <RoanKattouw>	 OK I'm starting on the Lyon spreadsheet
[19:21:01] <RoanKattouw>	 Meanwhile Quim is already asking people to fill out a travel request form :S
[19:21:03] <James_F>	 RoanKattouw: In your Copious Free Time™ can you make sure TrevorParscal and edsanders|away work on getting https://gerrit.wikimedia.org/r/#/c/192972/ fixed and merged?
[19:21:11] <RoanKattouw>	 But we have to get manager approval anyway and Tomasz is on vacation
[19:21:14] <James_F>	 RoanKattouw: Indeed. And I need to get the lawyers to OK my travel. Fun!
[19:21:19] <RoanKattouw>	 Yay
[19:23:52] <TrevorParscal>	 so, I need to get Citoid going so I can review mooeypoo's stuff
[19:24:09] <mooeypoo>	 TrevorParscal, apparently I was told by RoanKattouw that I installed it wrong
[19:24:24] <mooeypoo>	 despite the fact I went by these instructions: https://www.mediawiki.org/wiki/Citoid
[19:24:30] <mooeypoo>	 RoanKattouw, so, uh, what's the right way?
[19:24:41] <TrevorParscal>	 but I can change gears and focus on https://gerrit.wikimedia.org/r/#/c/192972/ for now
[19:24:41] <TrevorParscal>	 I haven't finished, but I'm sort of lost now
[19:24:41] <TrevorParscal>	 I got Citoid installed
[19:24:41] <TrevorParscal>	 but nothing is happening
[19:24:49] <TrevorParscal>	 lookin
[19:25:55] <TrevorParscal>	 holy crap that's complicated
[19:26:06] <mooeypoo>	 TrevorParscal,  :\ a little
[19:26:11] <TrevorParscal>	 i think I need a cookie before I begin
[19:26:13] <mooeypoo>	 and by that I mean yes
[19:28:37] <grrrit-wm>	 (03PS3) 10Jforrester: Make icon and indicator container sizes consistent [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders)
[19:28:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "PS3 is a rebase. +2 per Trevor." [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders)
[19:29:12] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 5Patch-For-Review: Icon containers should always be the same size so we can use background-size: contain - https://phabricator.wikimedia.org/T85139#1074379 (10Jdforrester-WMF) 5Open>3Resolved
[19:29:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] PopupElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/193405 (owner: 10Kmenger)
[19:30:16] <grrrit-wm>	 (03Abandoned) 10Bartosz Dziewoński: [WIP] Scrollbar squishing [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński)
[19:30:38] <grrrit-wm>	 (03CR) 10Jforrester: SelectWidget: Marked protected methods and clarified choose/press descriptions (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/193413 (owner: 10Kmenger)
[19:30:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make icon and indicator container sizes consistent [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders)
[19:31:04] <wikibugs>	 10MediaWiki-Page-editing: Pressing "Show changes" doesn't show "Preview of edit summary" - https://phabricator.wikimedia.org/T84883#1074394 (10TheDJ)
[19:31:16] <wikibugs>	 10OOjs-UI, 10VisualEditor: Implement a way to nest toolbar groups without implementing nesting of toolbar groups - https://phabricator.wikimedia.org/T90815#1074395 (10matmarex)
[19:32:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: PopupElement: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/193405 (owner: 10Kmenger)
[19:34:01] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 10VisualEditor-MediaWiki, and 2 others: "Nested" dialogs (template inside a basic reference) break the OOUI hack to prevent scrolling while dialog is open - https://phabricator.wikimedia.org/T89613#1074413 (10Jdforrester-WMF) 5Open>3Resolved
[19:34:54] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 5Patch-For-Review: OO.ui.ActionFieldLayout doesn't properly accept a jQuery for its label config value - https://phabricator.wikimedia.org/T90936#1074418 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal
[19:39:20] <RoanKattouw>	 Krinkle: You missed some fun :) https://github.com/jshint/jshint/issues/2213
[19:40:20] <wikibugs>	 10VisualEditor, 6Community-Liaison: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1074450 (10Elitre) 3NEW a:3Elitre
[19:43:42] <Krinkle>	 RoanKattouw: I noticed it on facebook, that one came in earlier while I was afk
[19:43:45] <Krinkle>	 (your fb)
[19:43:55] <RoanKattouw>	 haha
[19:44:01] <RoanKattouw>	 Oh right Twitter syncs to FB
[19:44:01] <Krinkle>	 RoanKattouw: We auto-update?
[19:44:09] <Krinkle>	 Oh, grunt-contrib-jshint
[19:44:15] <RoanKattouw>	 grunt-contrib-jshint 0.11 appears to depend on 2.6.*
[19:44:17] <RoanKattouw>	 So yeah
[19:44:31] <RoanKattouw>	 For that reason I couldn't even pin in package.json
[19:44:32] <TrevorParscal>	 so, we are now using the composer oojs-ui lib for the client as well as the server I see
[19:44:41] <RoanKattouw>	 Adding "jshint": "2.6.0" just adds another copy of jshint at the top level
[19:44:43] <Krinkle>	 TrevorParscal: We shouldn't be
[19:44:45] <RoanKattouw>	 Nested dependency handling etc
[19:44:53] <TrevorParscal>	 why is OOjs UI still in resources/core
[19:45:03] <TrevorParscal>	 oh.. well, it appears that's what's going on
[19:45:09] <Krinkle>	 TrevorParscal: No it's not
[19:45:39] <Krinkle>	 resources/lib/oojs-ui is what js/css uses
[19:46:11] <TrevorParscal>	 I had to live-patch the vendor/oojs/oojs-ui stuff because https://gerrit.wikimedia.org/r/#/c/193163/ is in the core resources/ lib but no the composer provided /vendor lib
[19:46:37] <TrevorParscal>	 I went to resources/ first, that was already fixed - but I was still getting the problem
[19:46:49] <Krinkle>	 TrevorParscal: probably cache
[19:46:54] <Krinkle>	 TrevorParscal: mediawiki or ve standalone?
[19:46:56] <TrevorParscal>	 went and fixed it in vendor/ (where it was indeed broken) and it started working
[19:46:59] <grrrit-wm>	 (03PS2) 10Kmenger: SelectWidget: Marked protected methods and clarified choose/press descriptions [oojs/ui] - 10https://gerrit.wikimedia.org/r/193413 
[19:47:01] <TrevorParscal>	 mediawiki
[19:47:04] <TrevorParscal>	 localhost
[19:47:07] <TrevorParscal>	 not a cache issue
[19:47:55] <TrevorParscal>	 i don't think
[19:47:56] <TrevorParscal>	 hmm
[19:48:28] <TrevorParscal>	 maybe it is
[19:48:34] <TrevorParscal>	 i hate caching
[19:48:39] <TrevorParscal>	 :)
[19:49:10] <grrrit-wm>	 (03PS9) 10Trevor Parscal: Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 
[19:49:40] <wikibugs>	 10OOjs-UI: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1074492 (10matmarex) Something like https://gerrit.wikimedia.org/r/#/c/193282/ could possibly help here.
[19:53:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal)
[19:57:04] <grrrit-wm>	 (03PS10) 10Trevor Parscal: Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 
[19:57:12] <TrevorParscal>	 edsanders|away: fixed that
[19:57:36] <TrevorParscal>	 I forgot the view.destroy() so it was still listening to things and freaking out because it had no surface
[20:00:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal)
[20:02:29] <mooeypoo>	 TrevorParscal, in actionProcess, there's this.actions.setAbilities to enable/disable buttons, and this.actions.setMode to show/hide buttons -- what is the method to trigger an action? I've been searching for the code and I can't find it
[20:04:40] <wikibugs>	 10MediaWiki-Page-editing, 10MediaWiki-RfCs, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1074562 (10TheDJ)
[20:04:56] <mooeypoo>	 TrevorParscal, is there a way to trigger a specific action outside of the button clicks ?
[20:11:56] <Krinkle>	 TrevorParscal: If you suspect it's using vendor/ in some way, I'd be interested in (later) having you try and reproduce that. That sounds bad :) - It doesn't do that for me though.
[20:19:25] <TrevorParscal>	 mooeypoo: executeAction
[20:19:37] <TrevorParscal>	 OO.ui.ProcessDialog.prototype.executeAction
[20:19:40] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: demo: Call Toolbar#initialize in toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/193427 
[20:19:42] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: demo: Add PopupTool to toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/193428 
[20:19:58] <TrevorParscal>	 Krinkle|detached: I tried, it didn't work - i was fooled
[20:23:30] <TrevorParscal>	 brb, lunch
[20:26:36] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: PopupTool: Tool constructor takes a toolGroup, not a toolbar [oojs/ui] - 10https://gerrit.wikimedia.org/r/193430 
[20:33:03] <ryasmeen>	 Hey RoanKattouw, we have not yet done pull through on this right? https://phabricator.wikimedia.org/T90858
[20:44:55] <InezK>	 mooeypoo: Hi. Do you know which code is responsibly for choosing to load oojs-ui-apex.svg.css or oojs-ui-apex.css?
[20:45:57] <InezK>	 actually.. nevermind
[20:55:52] <grrrit-wm>	 (03PS12) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[20:57:53] <grrrit-wm>	 (03PS13) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[20:58:26] <grrrit-wm>	 (03PS5) 10Mvolz: Add ability to set requesting User-Agent [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) 
[21:04:20] <edsanders>	 InezK, that's what the rendersEmpty property is for
[21:05:04] <edsanders>	 if you have an extension that can render without contents you set that property to true
[21:06:32] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: [WIP] Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 
[21:06:40] <MatmaRex>	 TrevorP|Away: ^
[21:06:53] <MatmaRex>	 somebody poke trevor and have him look at this when he's not away
[21:07:20] <MatmaRex>	 i am away myself, brb
[21:08:14] <RoanKattouw>	 ryasmeen: I think we have by now?
[21:08:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (owner: 10Bartosz Dziewoński)
[21:08:57] <RoanKattouw>	 Hmm but it's not fixed yet in beta labs ...
[21:09:00] <RoanKattouw>	 I wonder why
[21:09:21] <ryasmeen>	 RoanKattouw: yeah, I am still seeing everything broken there
[21:18:34] <MatmaRex>	 RoanKattouw: ryasmeen: beta is broken
[21:19:02] <MatmaRex>	 at least in debug mode, it's serving old content
[21:19:45] <MatmaRex>	 https://phabricator.wikimedia.org/T90983
[21:20:57] <RoanKattouw>	 In non-debug mode too
[21:21:03] <RoanKattouw>	 I'll see if I can fix it in a little bit
[21:21:11] * RoanKattouw is still spreadsheeting
[21:37:33] <grrrit-wm>	 (03PS1) 10Kmenger: PopupWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/193490 
[21:41:13] <wikibugs>	 10OOjs-UI: OO.ui.DropdownWidget doesn't respond to typing like <select> does - https://phabricator.wikimedia.org/T91126#1074742 (10Anomie) 3NEW
[21:49:13] <grrrit-wm>	 (03CR) 10Alex Monk: "We don't, no. We should probably fix that." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193268 (https://phabricator.wikimedia.org/T90916) (owner: 10Alex Monk)
[21:49:16] <mooeypoo>	 TrevorParscal, I found a horrific bug in action sets with RoanKattouw 
[21:49:45] <TrevorParscal>	 yeah?
[21:49:57] <TrevorParscal>	 horrific!!?
[21:50:02] <mooeypoo>	 Yes :\
[21:50:08] <TrevorParscal>	 oh do tell
[21:50:12] <mooeypoo>	 It exits from VE and refreshes the page.
[21:50:20] <RoanKattouw>	 No that's not it
[21:50:22] <RoanKattouw>	 Different bug
[21:50:23] <wikibugs>	 10VisualEditor, 10WikiEditor, 6Collaboration-Team, 10Flow, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1074765 (10GOIII) >>! In T78346#1061982, @Pginer-WMF wrote: >  > @GOIII, so for the specific case of discussions in Wikisource, is there...
[21:50:41] <RoanKattouw>	 TrevorParscal: So Moriel isn't using an ActionFieldSet for the Lookup button any more, because of where it is
[21:50:43] <mooeypoo>	 okay the bug is in process dialog
[21:50:46] <mooeypoo>	 but it has to do with action sets
[21:50:58] <mooeypoo>	 So the citoid inspector has no action widgets
[21:51:05] <RoanKattouw>	 So in order to do the lookup thing, she still uses an action process, she just calls executeAction()
[21:51:10] <RoanKattouw>	 Which is a documented API and everything
[21:51:20] <mooeypoo>	 but i do want to have its lookup process go through an action so it can respond to OO.ui.Error being thrown at it
[21:51:24] <RoanKattouw>	 Except that the error handling code looks for the action widget that launched the action and calls methods on it
[21:51:39] <mooeypoo>	 so I made it an action and used executeAction()
[21:51:49] <mooeypoo>	 and then it died horrifically in a flame of promises
[21:52:08] <mooeypoo>	 Seems like when you executeAction it expects to have a 'this.currentAction' set
[21:52:16] <mooeypoo>	 and that is being set when you *click* the action widget button
[21:52:18] <mooeypoo>	 which I don't have
[21:52:23] <RoanKattouw>	 So there's an executeAction() API that totally looks like it'll work, except it doesn't actually unless you go through an ActionWidget
[21:52:43] <RoanKattouw>	 and this only breaks in the error handling so you don't find out about this quickly
[21:52:58] <TrevorParscal>	 ok
[21:53:07] <TrevorParscal>	 this is because of the overly clever retry crap
[21:53:11] <grrrit-wm>	 (03PS3) 10Alex Monk: ImageInfoCache: Don't try to access imageinfo result if it's not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193268 (https://phabricator.wikimedia.org/T90916) 
[21:53:16] <RoanKattouw>	 Yes it is
[21:53:23] <RoanKattouw>	 The retry button is styled like the action that launched it
[21:53:25] <grrrit-wm>	 (03CR) 10Mvolz: Make zotero.js an object (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[21:53:59] <MatmaRex>	 TrevorParscal: for more horrific things, i implemented https://gerrit.wikimedia.org/r/193484 and it actually kind of works
[21:54:22] <TrevorParscal>	 the deal is, executeAction takes a string, but this.currentAction is an object (the action button)
[21:54:28] <MatmaRex>	 i also fixed a bunch of doozies in tools and toolbars (dependencies)
[21:54:32] <TrevorParscal>	 this is so the retry button can be styled the same
[21:55:23] <RoanKattouw>	 Also it looks like the prevent default on form submit in ProcessDialog is broken
[21:55:26] <RoanKattouw>	 I'm looking into that
[21:55:32] <mooeypoo>	 uh, also, form submission seems to refresh the page
[21:55:37] <mooeypoo>	 ah, yes, that ^^
[21:55:40] <TrevorParscal>	 :(
[21:55:46] <RoanKattouw>	 Breaks her code, but also breaks the link inspector
[21:55:51] <TrevorParscal>	 great
[21:55:54] <RoanKattouw>	 Seems to be a recent change in OOUI, I'm investigating
[21:56:06] <RoanKattouw>	 Ugh everything is breaking today
[21:56:10] <TrevorParscal>	 yeah, Bartosz realized that forms build in OOjs UI were unsubmittable
[21:56:23] <RoanKattouw>	 Earlier jshint released broken code that broke our entire CI pipeline
[21:56:24] <TrevorParscal>	 but, I guess I overlooked that there are cases where that's a good thing
[21:56:40] <mooeypoo>	 TrevorParscal, it might be a good thing if it's specified that whoever uses it should override
[21:56:44] <mooeypoo>	 with return false; or something
[21:56:55] <RoanKattouw>	 https://gerrit.wikimedia.org/r/#/c/191834/ is the change that broke it
[21:57:04] <RoanKattouw>	 It should have fixed callers to onFormSubmit
[21:57:06] <RoanKattouw>	 to return false
[21:57:14] <TrevorParscal>	 yup
[21:57:15] <mooeypoo>	 so a quickfix would be to add return false; to the callers
[21:57:16] <mooeypoo>	 yeah
[21:57:23] <RoanKattouw>	 I think it's only FragmentInspector, checking
[21:57:36] <mooeypoo>	 yeah I think that's the only one that has onFormSubmit
[21:57:59] <grrrit-wm>	 (03CR) 10Catrope: "FIXME should have been marked as a breaking change because it breaks code that expected form submission to be prevented, like FragmentInsp" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191834 (owner: 10Bartosz Dziewoński)
[21:58:01] <MatmaRex>	 ugh
[21:58:03] <RoanKattouw>	 I'll fix it
[21:58:13] <MatmaRex>	 i had no idea we're using FormLayouts
[21:59:12] <mooeypoo>	 okay, TrevorParscal going back to the action for a minute,what should I do? Is this a bug we should fix or should I not use executeAction() outside of action widgets ?
[21:59:26] <mooeypoo>	 and if so how do I get the inspector to respond to OO.ui.Error
[21:59:43] <TrevorParscal>	 mooeypoo: what action are you executing?
[21:59:52] <mooeypoo>	 TrevorParscal, I made my own action "lookup"
[21:59:56] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Make align widget work when config is undefined [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193367 (owner: 10Esanders)
[22:00:17] <TrevorParscal>	 and you are trying to programatically execute that action
[22:00:17] <mooeypoo>	 because the lookup process ends with either success or failure -- the failure is rare, but when it happens, it returns an OO.ui.Error that needs to be displayed
[22:00:36] <mooeypoo>	 and I understand that this must be inside an action process
[22:00:39] <TrevorParscal>	 rather than in response to the actual lookup button being clicked?
[22:00:52] <mooeypoo>	 TrevorParscal, yep, on buttonWidget click and form submit (enter press)
[22:01:12] <mooeypoo>	 well the lookup button being clicked doesn't automatically trigger the action
[22:01:20] <mooeypoo>	 it's a ButtonWidget. Should I make it an action widget? 
[22:01:28] <grrrit-wm>	 (03PS1) 10Catrope: Prevent form submission in FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193494 
[22:01:38] <mooeypoo>	 I didn't look into action widgets too much, but I think that's what executeAction() expects?
[22:01:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make align widget work when config is undefined [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193367 (owner: 10Esanders)
[22:02:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Prevent form submission in FragmentInspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193494 (owner: 10Catrope)
[22:02:27] <RoanKattouw>	 Wow
[22:02:46] <RoanKattouw>	 Google Docs doesn't let you transfer ownership of a doc from an @gmail.com account to an @wikimedia.org account
[22:02:50] <RoanKattouw>	 Thanks a lot Google Docs
[22:03:24] <TrevorParscal>	 mooeypoo: so, basically we have 2 problems, one is that you have non-action buttons that need to be able to execute actions, and that the API is broken
[22:03:57] <mooeypoo>	 TrevorParscal, well, unless the problem isn't with non-action buttons executing actions but rather with OO.ui.Errors needing an action process ?
[22:04:02] <TrevorParscal>	 so, I think you are doing something sane, but the reason this hasn't come up before is because all buttons that executed actions were always defined as action buttons, not arbitrary buttons in the UI
[22:04:32] <RoanKattouw>	 TrevorParscal: Well also a formSubmit event can trigger an action
[22:04:44] <TrevorParscal>	 let me see if I can make the retry stuff work in both cases
[22:05:06] <TrevorParscal>	 yes, I want you to be able to just use the API as you want to, not restructure your crap
[22:05:07] <mooeypoo>	 TrevorParscal, the only reason I made this into an "action" rather than its own standalone method is that i need the OO.ui.Error that's thrown to trigger the rest of the process 
[22:05:18] * mooeypoo nods
[22:05:22] <TrevorParscal>	 yes, there shouldn't be anything wrong with that imo
[22:05:32] <TrevorParscal>	 give me a sec, I will whip up a patch
[22:05:37] <mooeypoo>	 awesomesauce
[22:06:19] <grrrit-wm>	 (03PS2) 10Catrope: Prevent form submission in FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193494 
[22:06:39] <RoanKattouw>	 TrevorParscal: Also, I discovered why FragmentInspector isn't affected by this. The reason will make you cringe
[22:06:46] <RoanKattouw>	 ve.ui.FragmentInspector.prototype.onFormSubmit = function ( e ) {
[22:06:47] <RoanKattouw>	 	this.close( { action: 'done' } );
[22:06:49] <RoanKattouw>	 	e.preventDefault();
[22:06:50] <RoanKattouw>	 };
[22:08:11] <grrrit-wm>	 (03PS1) 10Alex Monk: MWCategoryWidget: Remove entries from this.categories when appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193496 (https://phabricator.wikimedia.org/T89923) 
[22:10:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Prevent form submission in FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193494 (owner: 10Catrope)
[22:10:43] <MatmaRex>	 RoanKattouw: you did that that? ^ :)
[22:11:22] <RoanKattouw>	 I don't remember who put the close thing there
[22:11:23] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Fixed by Roan in https://gerrit.wikimedia.org/r/193494 . Sorry." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191834 (owner: 10Bartosz Dziewoński)
[22:11:36] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "VE fixed*" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191834 (owner: 10Bartosz Dziewoński)
[22:11:45] <MatmaRex>	 did test that*
[22:12:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent form submission in FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193494 (owner: 10Catrope)
[22:15:16] <RoanKattouw>	 Yeah I tested it
[22:15:29] <RoanKattouw>	 I thought I could use return false;, but that didn't work, I had to use e.preventDefault();
[22:16:13] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "FIXME This messed up the toolbars." [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders)
[22:17:02] <MatmaRex>	 RoanKattouw: EventEmitter doesn't support returning values, does it?
[22:17:32] <RoanKattouw>	 Yeah exactly
[22:17:44] <RoanKattouw>	 I thought it was hooked into a jQuery event directly, but it's not, it goes via an OOjs event
[22:17:47] <MatmaRex>	 RoanKattouw: i also had a bit of a doubt about passing the jQuery event there, maybe it should be a callback function that would preventDefault when called
[22:19:04] <MatmaRex>	 RoanKattouw: so we fixed this in VE for now, but i wouldn't complain if we reverted the OOUI change too.
[22:19:16] <MatmaRex>	 (it did turn out to be a breaking change, in a point release.)
[22:20:13] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Infer rety button action flags from symbolc name [oojs/ui] - 10https://gerrit.wikimedia.org/r/193500 
[22:20:16] <RoanKattouw>	 MatmaRex: I'll let you and James_F|Away figure that out
[22:20:25] <RoanKattouw>	 I'm too hungy to make decisions about OOUI release management right no
[22:20:30] <RoanKattouw>	 I should eat something
[22:20:49] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Infer retry button action flags from symbolic name [oojs/ui] - 10https://gerrit.wikimedia.org/r/193500 
[22:20:58] <TrevorParscal>	 ok mooeypoo, https://gerrit.wikimedia.org/r/#/c/193500/
[22:21:02] <TrevorParscal>	 that will do the trick
[22:21:47] <TrevorParscal>	 now you can call executeAction, and it will copy flags from action buttons with the same action (if any) rather than assuming the action was called from a button
[22:21:54] <James_F>	 Hey.
[22:21:57] <TrevorParscal>	 and we now set currentAction within executeAction
[22:21:58] <James_F>	 MatmaRex, TrevorParscal: Want to revert https://gerrit.wikimedia.org/r/191834 and release 0.8.3? Or just leave it?
[22:22:02] <TrevorParscal>	 so, yeah, safe
[22:22:39] <MatmaRex>	 James_F: we merged a bunch of intentionally breaking changes for 0.9, right? so that would be cumbersome
[22:22:57] <MatmaRex>	 James_F: but i am not sure that it was a good change in general
[22:23:08] <TrevorParscal>	 James_F: do we have a patch to deal with the breakage (it should have a config option to make it not submit natively, which is false by default, and then we have to update callers of the form layout to set it)
[22:23:09] <MatmaRex>	 it fixed a real bug, but not in a pretty way
[22:23:25] <MatmaRex>	 TrevorParscal: James_F: yes, roan and I just fixed it in VE
[22:23:26] <James_F>	 MatmaRex: Yes, but we didn't announce it in advance.
[22:23:49] <James_F>	 TrevorParscal: It's no longer broken in master (assuming it didn't break things in other repos).
[22:24:08] <MatmaRex>	 i am for reverting the change and rethinking how we prevent default actions everywhere
[22:24:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1074833 (10Krenair) a:3Krenair
[22:24:14] <TrevorParscal>	 yeah
[22:24:16] <MatmaRex>	 it's also a problem in ButtonWidget (but a much smaller one)
[22:24:23] <TrevorParscal>	 MatmaRex: agreed
[22:24:32] <TrevorParscal>	 sorry for missing that one in code review 
[22:24:35] <TrevorParscal>	 egg on my face
[22:24:48] <MatmaRex>	 (you need to remove the href to be able to handle click events)
[22:24:55] <James_F>	 OK.
[22:25:01] <MatmaRex>	 alright, reverting
[22:25:13] <TrevorParscal>	 mooeypoo: that patch help?
[22:25:15] <TrevorParscal>	 you see that?
[22:25:18] <James_F>	 MatmaRex: So… are we going to come up with a solution we can announce before 0.9.0?
[22:25:36] <James_F>	 MatmaRex: I.e., come up with, implement and deprecate the existing one before the end of Tuesday.
[22:25:46] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Revert "Unbreak form submission in JavaScript" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193502 
[22:25:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Revert "Unbreak form submission in JavaScript" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193502 (owner: 10Bartosz Dziewoński)
[22:26:01] <MatmaRex>	 hmm?
[22:26:53] <James_F>	 MatmaRex: If we're going to fix form submission in Javascript, can we do so in a way that isn't a breaking change? If not, can we do so with a deprecation window?
[22:27:11] <MatmaRex>	 James_F: FormLayout, ButtonWidget and ButtonInputWidget have a set of problems that make them useless if you do not implement *all* behaviors on them in JavaScript. that's the underlying bug here
[22:27:19] <MatmaRex>	 maybe we can do it in non-breaking way
[22:27:24] <MatmaRex>	 fix it*
[22:27:37] * James_F nods.
[22:27:44] <MatmaRex>	 but it's not very pressing, i think
[22:28:09] <MatmaRex>	 let me file that bug
[22:28:51] * James_F nods.
[22:29:02] <mooeypoo>	 TrevorParscal, I'm testing
[22:31:35] <grrrit-wm>	 (03PS14) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[22:32:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Unbreak form submission in JavaScript" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193502 (owner: 10Bartosz Dziewoński)
[22:32:08] <grrrit-wm>	 (03CR) 10Mvolz: Convert scrape.js to Scraper.js (036 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 (owner: 10Mvolz)
[22:32:26] <mooeypoo>	 TrevorParscal, okay, now it works, but I am running into a different issue; when I see the error message "something went wrong" and I hit "submit" the dialog is still pending. Where in this process do I do "popPending()" for the inspector and input ? just before the error is returned? somewhere after in the action?
[22:32:31] <grrrit-wm>	 (03PS6) 10Mvolz: Add ability to set requesting User-Agent [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) 
[22:33:53] <James_F>	 This is going to be a real mess.
[22:34:06] <TrevorParscal>	 mooeypoo: lookin
[22:34:29] <mooeypoo>	 TrevorParscal, also, I either need to not have a "retry" button in the eror message or know how to actually tell it to retry...?
[22:34:33] <RoanKattouw>	 mooeypoo: Don't push or pop pending in processes yourself
[22:34:36] <RoanKattouw>	 executeAction handles that
[22:35:06] <TrevorParscal>	 and retry is smart
[22:35:11] <TrevorParscal>	 that's what currentAction is for
[22:35:26] <James_F>	 Indeed, RoanKattouw, I might ask you to do this.
[22:35:27] <TrevorParscal>	 so it can be retried (unless the OO.ui.Error is unrecoverable)
[22:35:36] <James_F>	 RoanKattouw: We don't branch OOjs UI for releases.
[22:36:11] <mooeypoo>	 hmmm okay
[22:36:15] <James_F>	 RoanKattouw: How I can backport a revert to an old release for 0.8.3? HEAD contains loads of things that can't go out early (breaking changes).
[22:36:32] <RoanKattouw>	 James_F: Releases are tags in OOUI, right?
[22:36:45] <RoanKattouw>	 Also the current release is 0.8.2, you keep living in the future :P
[22:36:59] <James_F>	 RoanKattouw: I live in master. I'm trying to build 0.8.3.
[22:37:18] <RoanKattouw>	 0.8.3 which is like 0.8.2 but without the breaking change?
[22:37:22] <RoanKattouw>	 I can do that
[22:37:31] <TrevorParscal>	 brb
[22:37:32] <James_F>	 RoanKattouw: Specifically, 3f10fd2 needs to go on top of ad42eae.
[22:37:40] <wikibugs>	 10OOjs-UI: Forcefully preventing default event actions on FormLayout, ButtonWidget and ButtonInputWidget is problematic - https://phabricator.wikimedia.org/T91132#1074856 (10matmarex) 3NEW
[22:37:41] <RoanKattouw>	 I want you to decide what should happen, as the de facto release manager for OOUI, and then I'll make it happen
[22:38:02] <James_F>	 RoanKattouw: I've just told you. :-)
[22:38:06] <RoanKattouw>	 OK cool
[22:38:09] <RoanKattouw>	 Yeah, sorry, crossed messages
[22:38:11] <RoanKattouw>	 I will do that
[22:38:14] <James_F>	 Thanks.
[22:38:20] <MatmaRex>	 TrevorP|Away: would appreciate comments on that bug i just filed
[22:38:23] <RoanKattouw>	 I will release 0.8.3 which is 0.8.2 plus that revert
[22:38:25] <James_F>	 I'm imagining some creative use of git cherry-pick will do it.
[22:38:29] <RoanKattouw>	 Yes
[22:38:34] <James_F>	 But can you cherry-pick a merge?
[22:38:41] <James_F>	 Oh, wait, no, but you don't need to.
[22:38:44] <RoanKattouw>	 Not directly but that's OK
[22:38:47] * James_F nods.
[22:38:56] <RoanKattouw>	 I know my way around git, don't worry ;)
[22:38:59] <RoanKattouw>	 I'm going to eat lunch first
[22:39:02] <RoanKattouw>	 And then I'll do this release
[22:39:19] <James_F>	 RoanKattouw: Gah.
[22:39:53] <RoanKattouw>	 Sorry, but it's 2:30 and I'm really quite hungry now
[22:40:38] <RoanKattouw>	 I have been running around figuring out travel and visa situations, and getting a green card letter signed, and dealing with today's jshint crap
[22:43:41] <James_F>	 RoanKattouw_away: Fun.
[22:44:17] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] PopupWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/193490 (owner: 10Kmenger)
[22:44:57] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] demo: Call Toolbar#initialize in toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/193427 (owner: 10Bartosz Dziewoński)
[22:46:13] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] demo: Add PopupTool to toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/193428 (owner: 10Bartosz Dziewoński)
[22:46:35] <mooeypoo>	 TrevorP|Away, okay, now it works well, except for sizing. Since the inspector is small, the error window is much bigger, and it appears a bit off with the buttons outside the view. See screenshot: http://s17.postimg.org/3shxe3yq7/citoid_error.png
[22:46:51] <James_F>	 mooeypoo: Ha, whoops.
[22:46:53] <grrrit-wm>	 (03PS7) 10Mvolz: Add ability to set requesting User-Agent [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) 
[22:47:16] <grrrit-wm>	 (03CR) 10Mvolz: Add ability to set requesting User-Agent (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) (owner: 10Mvolz)
[22:47:17] <mooeypoo>	 James_F, at least it's scrollable.... :D
[22:47:22] <James_F>	 mooeypoo: :-)
[22:48:21] <grrrit-wm>	 (03PS13) 10Mooeypoo: Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) 
[22:48:25] <mooeypoo>	 woot
[22:48:29] <wikibugs>	 10OOjs-UI: Toolbars are messed up, especially in MediaWiki theme - https://phabricator.wikimedia.org/T91135#1074892 (10matmarex) 3NEW a:3Esanders
[22:48:38] <mooeypoo>	 wait, uhm, i need to state it depends on TrevorParscal's fix
[22:48:44] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Filed as T91135." [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders)
[22:48:52] * James_F nods.
[22:50:05] <mooeypoo>	 TrevorParscal, repeating in case it was missed; it works, but sizing looks off: http://s17.postimg.org/3shxe3yq7/citoid_error.png
[22:50:18] <grrrit-wm>	 (03PS14) 10Mooeypoo: Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) 
[22:51:01] <TrevorParscal>	 yeah, we need inspector specific styles for that error screen, and we need to trigger an update size for inspectors when that screen is shown/hidden
[22:52:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] PopupWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/193490 (owner: 10Kmenger)
[22:52:39] <mooeypoo>	 hm I was going to say I can trigger it manually when the error pops up, but from the perspective of the inspector, that's too early
[22:54:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: demo: Call Toolbar#initialize in toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/193427 (owner: 10Bartosz Dziewoński)
[22:54:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: demo: Add PopupTool to toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/193428 (owner: 10Bartosz Dziewoński)
[22:59:07] <grrrit-wm>	 (03PS2) 10Jforrester: PopupWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/193490 (owner: 10Kmenger)
[22:59:13] <RoanKattouw>	 James_F: oojs-ui now has a v0.8.3 tag
[22:59:15] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] PopupWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/193490 (owner: 10Kmenger)
[22:59:23] <James_F>	 RoanKattouw: Tsk. Without a +2 from me? ;-)
[22:59:25] <RoanKattouw>	 So you should be able to do the normal update thing for MW core and VE
[22:59:34] <RoanKattouw>	 Well it's not in master
[22:59:36] <grrrit-wm>	 (03PS1) 10Jforrester: build: Add disconnect tolerance to karma config [oojs/ui] - 10https://gerrit.wikimedia.org/r/193507 
[22:59:46] <RoanKattouw>	 It's a weird out-of-band release so it doesn't even go through Gerrit
[23:00:03] <James_F>	 RoanKattouw: It's not in my tags…
[23:00:19] <James_F>	 RoanKattouw: Did you `git push --tags` and `npm release`?
[23:00:51] <RoanKattouw>	 I did git push --tags but not npm release, will do that
[23:01:07] <RoanKattouw>	 npm release does not appear to exist
[23:03:12] <James_F>	 RoanKattouw: Ah, you might not have rights.
[23:03:31] <RoanKattouw>	 James_F: Can you pull my tag and then run npm release?
[23:03:40] <James_F>	 RoanKattouw: Still can't see your tag.
[23:03:45] <RoanKattouw>	 In an oojs/ui checkout you should be able to do git pull; git checkout v0.8.3
[23:04:19] <James_F>	 Aha, after the fifth `git fetch --tags` it decided there was something there.
[23:04:20] * James_F sighs.
[23:04:20] <RoanKattouw>	 James_F: git.wikimedia.org has no trouble seeing it: https://git.wikimedia.org/summary/oojs%2Fui.git
[23:04:27] <RoanKattouw>	 Oh lovely
[23:04:29] <MatmaRex>	 let's not update things to 0.8.3
[23:04:29] <RoanKattouw>	 Thanks git
[23:04:32] <MatmaRex>	 no need
[23:04:53] <MatmaRex>	 aren't we doing 0.9 next week-ish?
[23:05:02] <James_F>	 RoanKattouw: Yeah, npm publish.
[23:05:08] <RoanKattouw>	 Oh npm publish
[23:05:14] <James_F>	 MatmaRex: Other people use OOjs UI too.
[23:05:20] <RoanKattouw>	 James_F: Are you running that or am I?
[23:05:25] <James_F>	 RoanKattouw: Already done.
[23:05:25] <RoanKattouw>	 Yeah I have no problem not updating MediaWiki
[23:05:28] <MatmaRex>	 meh
[23:05:30] <RoanKattouw>	 But we do need to publish to npm
[23:05:33] <RoanKattouw>	 Cool, thanks
[23:05:44] <James_F>	 Surely the whole point is to unbreak for other people?
[23:06:00] <James_F>	 If it was only ever going to affect us it'd not have been worth it.
[23:06:11] <RoanKattouw>	 Oh ahm
[23:06:17] <RoanKattouw>	 We kind of do need to update MW and VE actually
[23:06:20] <James_F>	 Yeah.
[23:06:24] <RoanKattouw>	 Oh wait no we don't
[23:06:25] <RoanKattouw>	 Sorry
[23:06:26] <James_F>	 …
[23:06:29] <RoanKattouw>	 We've already merged a fix
[23:06:29] <James_F>	 Pick one.
[23:06:32] <James_F>	 In VE.
[23:06:35] <RoanKattouw>	 I'm sorry, too many things going on today
[23:06:36] <James_F>	 What about for non-VE users?
[23:07:30] <RoanKattouw>	 The way FragmentInspector uses FormLayout is pretty obscure
[23:07:46] <James_F>	 Hmm.
[23:07:53] <RoanKattouw>	 I find it difficult to believe that anything other than FragmentInspector subclasses would be affected
[23:07:59] <RoanKattouw>	 And FragmentInspector is in VE core
[23:08:19] <James_F>	 Sure.
[23:08:22] <RoanKattouw>	 That said, we could grep MW extensions for FormLayout
[23:08:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: PopupWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/193490 (owner: 10Kmenger)
[23:10:23] <James_F>	 RoanKattouw: https://github.com/search?q=FormLayout+%40wikimedia&type=Code&utf8=%E2%9C%93
[23:11:07] <James_F>	 RoanKattouw: Only users are OOjs UI itself, VE and OOUIPlayground.
[23:11:15] <wikibugs>	 10VisualEditor, 6Community-Liaison: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1074950 (10Rdicerb) This had great results last year. Thanks for creating a repeat!
[23:11:20] <James_F>	 RoanKattouw: And I presume that that's fine with master.
[23:15:30] <grrrit-wm>	 (03PS1) 10Kmenger: ToggleButtonWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193508 
[23:15:36] <RoanKattouw>	 OK yeah that sounds fine
[23:15:42] <James_F>	 RoanKattouw: So, next:
[23:17:17] <James_F>	 Wait, I might have this.
[23:21:18] <grrrit-wm>	 (03PS11) 10Jforrester: Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal)
[23:24:49] <James_F>	 RoanKattouw: As Ed's not around, could you sanity-check and +2 https://gerrit.wikimedia.org/r/#/c/192972/ please? I've tested it and it now works for me. We need to do the next pull-through. :-)
[23:24:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ToggleButtonWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193508 (owner: 10Kmenger)
[23:25:26] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) 
[23:27:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński)
[23:28:25] <grrrit-wm>	 (03CR) 10Kmenger: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193508 (owner: 10Kmenger)
[23:30:31] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) 
[23:31:08] <MatmaRex>	 TrevorParscal: so, that kind of works. ^
[23:31:09] <RoanKattouw>	 James_F: Will do
[23:31:19] <James_F>	 RoanKattouw: Thanks.
[23:31:20] <ori>	 RoanKattouw: sorry I've been away from VE land all day; some fires to fight in the stats stack
[23:31:24] <TrevorParscal>	 MatmaRex: yeag
[23:31:30] <RoanKattouw>	 ori: I've been fighting fires all day too
[23:31:31] <MatmaRex>	 surprisingly
[23:31:33] <TrevorParscal>	 lookin at ps3 in a sec
[23:35:50] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) 
[23:41:16] <wikibugs>	 10OOjs-UI: OOjs UI: Toolbar groups should support sub-groups as items - https://phabricator.wikimedia.org/T74159#1075015 (10matmarex) > a bar with direct items and a sub-group shown as a list  https://gerrit.wikimedia.org/r/193484 implements this as a hacky special-case for T90815. That will probably need to be...
[23:47:04] <wikibugs>	 10VisualEditor: VisualEditor: receiving a 'not logged in' warning on a page that shows that a user is logged in - https://phabricator.wikimedia.org/T75250#1075031 (10Etonkovidova) p:5Triage>3Normal
[23:47:17] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) 
[23:52:10] <wikibugs>	 10VisualEditor: VisualEditor: receiving a 'not logged in' warning on a page that shows that a user is logged in - https://phabricator.wikimedia.org/T75250#1075041 (10Etonkovidova) p:5Normal>3Low
[23:56:57] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Hmm… this can potentially cause an infinite loop. Should we prevent that, or just document that you shouldn't have the tool include its ow" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński)
[23:57:15] <James_F>	 MatmaRex: Ha. That'd be unfortunate.
[23:57:30] <RoanKattouw>	 So the KLM problems continue
[23:57:40] <RoanKattouw>	 Now KLM claims I'm on standby for my flight tomorrow :O
[23:58:02] <RoanKattouw>	 But I am checked in, and supposedly when I show up at the airport tomorrow I'll get a boarding pass
[23:59:27] <ori>	 do you have a seat assignment?
[23:59:43] <RoanKattouw>	 No, they won't give me one
[23:59:52] <RoanKattouw>	 So even if I do get on the plane, I'll be in some stupid middle seat
[23:59:52] <grrrit-wm>	 (03PS1) 10Kmenger: ToggleWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/193521