[00:00:14] RoanKattouw: Fuuuun. [00:00:23] RoanKattouw: *cough* United *cough*. [00:00:31] RoanKattouw: Want me to grab you a 1-way award flight? [00:01:32] Nah it's fine [00:01:35] Remember, EU airline [00:01:36] RoanKattouw: Standard Award only, but… [00:01:50] If they deny boarding, it's gonna cost them €600 [00:02:11] RoanKattouw: If you loved me more I could grab you a business-class one (also Standard Award). [00:02:23] That's a lot of miles dude [00:02:31] Standard economy is 65k already [00:02:34] Or 55k? [00:02:38] Not worth it, anyway [00:02:46] 65k for Y [00:02:54] I don't really have to be there until the 14th, I'm scheduled to arrive on the 1st [00:02:56] 150k for J [00:03:00] 170k for F. [00:03:10] If KLM screws up, I arrive on the 2nd and I'll have paid negative money for the flight [00:03:19] Meh. [00:03:50] My main concern is that their system might have freaked out over my not having an ESTA or something and I do end up on the flight but in a middle seat [00:03:50] (03CR) 10Trevor Parscal: "Lets just prevent it with an exception being thrown." [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [00:03:51] We'll see [00:05:23] (03CR) 10Trevor Parscal: [C: 032] PopupTool: Tool constructor takes a toolGroup, not a toolbar [oojs/ui] - 10https://gerrit.wikimedia.org/r/193430 (owner: 10Bartosz Dziewoński) [00:06:41] (03CR) 10Trevor Parscal: [C: 032] ToggleWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/193521 (owner: 10Kmenger) [00:07:43] (03Merged) 10jenkins-bot: PopupTool: Tool constructor takes a toolGroup, not a toolbar [oojs/ui] - 10https://gerrit.wikimedia.org/r/193430 (owner: 10Bartosz Dziewoński) [00:09:41] (03CR) 10Trevor Parscal: [C: 032] ToggleButtonWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193508 (owner: 10Kmenger) [00:09:43] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [00:09:45] (03Merged) 10jenkins-bot: ToggleWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/193521 (owner: 10Kmenger) [00:09:48] Woo. [00:09:51] RoanKattouw: Thanks. [00:10:05] When that merges I'll have to rebase my code [00:10:32] Because of course generateCitationFeatures, which hasn't been touched in like a year, now has two competing commits against it :S [00:11:25] (03Merged) 10jenkins-bot: ToggleButtonWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/193508 (owner: 10Kmenger) [00:11:48] (03Merged) 10jenkins-bot: Update VE core submodule to master (2e1a0bb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [00:18:08] (03CR) 10Trevor Parscal: [C: 032] SelectWidget: Marked protected methods and clarified choose/press descriptions [oojs/ui] - 10https://gerrit.wikimedia.org/r/193413 (owner: 10Kmenger) [00:18:21] RoanKattouw: :-D [00:18:23] (03PS2) 10Catrope: Make generateCitationFeatures() idempotent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193407 [00:20:25] (03Merged) 10jenkins-bot: SelectWidget: Marked protected methods and clarified choose/press descriptions [oojs/ui] - 10https://gerrit.wikimedia.org/r/193413 (owner: 10Kmenger) [00:23:04] Well allegedly on line check-in isn't available for my flight at all [00:23:06] So we'll see [00:24:15] (03PS1) 10Kmenger: ToggleSwitchWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/193528 [00:27:40] (03CR) 10Jforrester: [C: 031] Make generateCitationFeatures() idempotent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193407 (owner: 10Catrope) [00:32:43] 10VisualEditor: [Regression-wmf19] Media settings->General settings Caprion - broken layout - https://phabricator.wikimedia.org/T91145#1075071 (10Etonkovidova) 3NEW [00:34:02] (03PS6) 10Bartosz Dziewoński: Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) [00:35:17] 10VisualEditor: [Regression pre-wmf20] Media settings->General settings Caprion - broken layout - https://phabricator.wikimedia.org/T91145#1075080 (10Catrope) [00:35:25] (03CR) 10Bartosz Dziewoński: "Turns out to be simpler to just discard it quietly rather than throwing an exception. We already have the setup to discard tools that are " [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [00:37:03] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#1075085 (10awight) Like @AdHuikeshoven, I just ran into the use case where I can't sign myself to a list of Wikimania talk attendees. [00:37:21] 10OOjs-UI, 10OOjs-UI-0.8.1, 10VisualEditor, 7Browser-Support-Apple-Safari, and 3 others: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1075087 (10Etonkovidova) Seems to be working in both - betalabs and test2 - so marking as Verified accordingly. [00:37:24] 10VisualEditor: [Regression pre-wmf20] Media settings->General settings Caprion - broken layout - https://phabricator.wikimedia.org/T91145#1075089 (10Catrope) Appears to be caused by some sort of regression between OOjs UI 0.8.0 and 0.8.1 [00:38:12] 10OOjs-UI, 10OOjs-UI-0.8.1, 10VisualEditor, 7Browser-Support-Apple-Safari, and 4 others: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1075090 (10Etonkovidova) [00:39:45] RoanKattouw: class="ve-ui-surface oo-ui-toolbar" [00:39:50] 10OOjs-UI, 5OOjs-UI-0.8.2, 10VisualEditor, 7Browser-test-bug: [Regression pre-wmf20] Dialogs broken on master - https://phabricator.wikimedia.org/T90858#1075093 (10Ryasmeen) Verified the fix in Betalabs [00:39:51] that looks like more $element fallout [00:39:55] Another $element thing? [00:39:58] That's the first thing I suspected [00:40:53] Found ti [00:40:57] this.toolbar = new ve.ui.Toolbar( this.surface, { $: this.$ } ); [00:41:03] That must have changed ages ago [00:41:08] 10VisualEditor: [Regression pre-wmf20] Media settings->General settings Caprion - broken layout - https://phabricator.wikimedia.org/T91145#1075096 (10matmarex) The broken surface has `class="ve-ui-surface oo-ui-toolbar …"`, so this is probably more `$element` in config fallout – same root cause as T90858? [00:41:25] [BREAKING CHANGE] Multiple surface support and demo [00:41:29] 2014-12-02 [00:41:54] (03PS1) 10Jforrester: ve.ce.FocusableNode.css: Quieten csslint for Firefox-specific hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193530 [00:42:02] (03PS18) 10Jforrester: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [00:42:39] Ha, whoops. [00:43:34] (03PS1) 10Catrope: Followup cf1e16788069: update call to ve.ui.Toolbar constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193531 (https://phabricator.wikimedia.org/T91145) [00:44:07] (03CR) 10Jforrester: [C: 031] "PS18 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [00:44:10] (03CR) 10jenkins-bot: [V: 04-1] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [00:46:09] (03PS2) 10Jforrester: Follow-up cf1e167880: Update call to ve.ui.Toolbar constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193531 (https://phabricator.wikimedia.org/T91145) (owner: 10Catrope) [00:46:19] (03CR) 10Jforrester: [C: 032] Follow-up cf1e167880: Update call to ve.ui.Toolbar constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193531 (https://phabricator.wikimedia.org/T91145) (owner: 10Catrope) [00:46:40] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up cf1e167880: Update call to ve.ui.Toolbar constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193531 (https://phabricator.wikimedia.org/T91145) (owner: 10Catrope) [00:46:51] oh, i'm late. [00:46:56] 10VisualEditor, 5WMF-deploy-2015-03-04_(1.25wmf20): [Regression pre-wmf20] Media settings->General settings caption - broken layout - https://phabricator.wikimedia.org/T91145#1075103 (10Jdforrester-WMF) 5Open>3Resolved a:3Catrope [00:47:36] 10VisualEditor, 5WMF-deploy-2015-03-04_(1.25wmf20): [Regression pre-wmf20] Reference and Media caption surfaces have broken layout - https://phabricator.wikimedia.org/T91145#1075071 (10Jdforrester-WMF) p:5High>3Unbreak! [00:47:53] Yeah, I'd noticed this bug and pulled Roan's patch as it came in to verify. :-) [00:48:05] Affected reference surfaces too. [00:48:30] (03Merged) 10jenkins-bot: Follow-up cf1e167880: Update call to ve.ui.Toolbar constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193531 (https://phabricator.wikimedia.org/T91145) (owner: 10Catrope) [00:49:21] MatmaRex: Can I borrow your +2 for https://gerrit.wikimedia.org/r/#/c/193530/ instead? ;-) [00:50:09] (03CR) 10Bartosz Dziewoński: [C: 032] ve.ce.FocusableNode.css: Quieten csslint for Firefox-specific hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193530 (owner: 10Jforrester) [00:50:47] Ta. [00:51:41] (03PS3) 10Catrope: [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 [00:52:51] (03Merged) 10jenkins-bot: ve.ce.FocusableNode.css: Quieten csslint for Firefox-specific hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193530 (owner: 10Jforrester) [00:53:22] (03PS1) 10Jforrester: Update VE core submodule to master (7bcf314) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193536 [00:53:29] ^^^ And that please. [00:53:57] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (7bcf314) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193536 (owner: 10Jforrester) [00:54:11] Woo. [00:54:38] 10OOjs-UI: File upload widget - https://phabricator.wikimedia.org/T91146#1075114 (10Anomie) 3NEW [00:54:40] 10OOjs-UI: Multi-select widget - https://phabricator.wikimedia.org/T91147#1075121 (10Anomie) 3NEW [00:54:42] 10OOjs-UI: Date and time input widgets - https://phabricator.wikimedia.org/T91148#1075130 (10Anomie) 3NEW [00:55:09] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope) [00:55:22] (03CR) 10Bartosz Dziewoński: "The display is slightly broken because of T91135, but apart from that this should be good. But please promise you'll rewrite toolbars and " [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [00:55:34] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: [Regression wmf18] Reference and template dialog boxes display 'Apply changes' button as active upon opening - https://phabricator.wikimedia.org/T89913#1075138 (10Jdforrester-WMF) [00:55:37] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/193407/ [00:55:48] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References: "Nested" dialogs (template inside a basic reference) break the OOUI hack to prevent scrolling while dialog is open - https://phabricator.wikimedia.org/T89613#1040336 (10Jdforrester-WMF) [00:56:02] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5WMF-deploy-2015-03-04_(1.25wmf20): Cannot insert local picture in VisualEditor - https://phabricator.wikimedia.org/T90795#1067690 (10Jdforrester-WMF) [00:56:15] RoanKattouw: so that was being run each time you hit edit? [00:56:25] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: Test failure: "Uncaught TypeError: Cannot read property '0' of undefined" in mw.ImageInfoCache - https://phabricator.wikimedia.org/T90916#1075143 (10Jdforrester-WMF) p:5Triage>3Normal [00:56:34] (03Merged) 10jenkins-bot: Update VE core submodule to master (7bcf314) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193536 (owner: 10Jforrester) [00:56:40] (03CR) 10Trevor Parscal: [C: 032] Make generateCitationFeatures() idempotent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193407 (owner: 10Catrope) [00:56:45] TrevorParscal: I don't think so, but the WIP commit that depends on it causes it to potentially be called multiple times [00:56:58] yeah, makes sense to check [00:57:12] Because it moves it to the mw.Target constructor [00:58:17] (03CR) 10Catrope: [C: 032] MWCategoryWidget: Remove entries from this.categories when appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193496 (https://phabricator.wikimedia.org/T89923) (owner: 10Alex Monk) [00:58:39] RoanKattouw: How many of our 5 category corruption bugs do you think that might magically fix? :-) [00:58:45] (03Merged) 10jenkins-bot: Make generateCitationFeatures() idempotent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193407 (owner: 10Catrope) [00:59:02] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20): Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1075146 (10Jdforrester-WMF) 5Open>3Resolved [00:59:09] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-04_(1.25wmf20): Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1048837 (10Jdforrester-WMF) [01:00:17] (03Merged) 10jenkins-bot: MWCategoryWidget: Remove entries from this.categories when appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193496 (https://phabricator.wikimedia.org/T89923) (owner: 10Alex Monk) [01:01:24] (03CR) 10Catrope: [C: 04-1] ImageInfoCache: Don't try to access imageinfo result if it's not set (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193268 (https://phabricator.wikimedia.org/T90916) (owner: 10Alex Monk) [01:01:51] (03CR) 10Jforrester: [C: 031] Add insert/edit modes to FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal) [01:03:21] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193369 (owner: 10Esanders) [01:04:02] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/193368/ https://gerrit.wikimedia.org/r/#/c/193369/ https://gerrit.wikimedia.org/r/#/c/193370/ https://gerrit.wikimedia.org/r/#/c/193293/ are probably all good to go and "easy" reviews… [01:04:35] (03CR) 10Jforrester: [C: 04-1] "Need jsduck fixes." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [01:05:23] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: "Read more" link is appearing even if the last line if the description of the image fits in the visible area - https://phabricator.wikimedia.org/T87265#1075160 (10Jdforrester-WMF) [01:19:51] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/193368/1 https://gerrit.wikimedia.org/r/#/c/193370/ [01:20:12] tsk tsk tsk [01:21:25] (03CR) 10Trevor Parscal: [C: 04-1] "And how else shall we support text-overflow inside a non table-layout: fixed display: table-cell element?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193368 (owner: 10Esanders) [01:21:48] (03CR) 10Catrope: [C: 04-1] Provide isAlignable checks for alignable nodes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193369 (owner: 10Esanders) [01:22:17] 1. I don't yet know how I am to excercise and thus test https://gerrit.wikimedia.org/r/#/c/193370/ [01:22:23] and also, I need to go to Costco... [01:23:01] what happened to 2.? [01:23:05] costco should have been number 2 [01:23:11] but you switched to a plain conjunction [01:23:11] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1075184 (10kaldari) This bug is holding up https://gerrit.wikimedia.org/r/#/c/192473/. Looking for some feedback from @Jdforrester-WMF and/or @Prtksxna abo... [01:23:26] c. i'm tired [01:23:50] IV. it's friday [01:24:04] * the end [01:24:09] lol [01:24:18] have a good weekend ori [01:24:21] you too :) [01:24:21] we should hang soon [01:24:25] yes! [01:24:27] hit me up sometime man! [01:24:28] as you know i need a nudge [01:24:33] ok! [01:24:38] let me know when you are fre [01:24:44] or free for that matter [01:25:02] cyall [01:25:25] (03PS4) 10Alex Monk: ImageInfoCache: Don't try to access imageinfo result if it's not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193268 (https://phabricator.wikimedia.org/T90916) [01:26:50] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1075185 (10Nirzar) @kaldari I am working towards solving these inconsistencies. some of the buttons are being used in VE currently* which can be avoided by... [01:28:21] (03CR) 10Catrope: [C: 04-1] Add insert/edit modes to FragmentInspector (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal) [01:38:42] (03CR) 10Catrope: [C: 032] ImageInfoCache: Don't try to access imageinfo result if it's not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193268 (https://phabricator.wikimedia.org/T90916) (owner: 10Alex Monk) [01:40:54] (03Merged) 10jenkins-bot: ImageInfoCache: Don't try to access imageinfo result if it's not set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193268 (https://phabricator.wikimedia.org/T90916) (owner: 10Alex Monk) [02:11:52] 10OOjs-UI: Multi-select widget - https://phabricator.wikimedia.org/T91147#1075235 (10matmarex) {T88250} is also somewhat related, but it's unclear whether it would present the whole list of items to choose from, or work more like search suggestions. [02:31:45] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-04_(1.25wmf20): Test failure: "Uncaught TypeError: Cannot read property '0' of undefined" in mw.ImageInfoCache - https://phabricator.wikimedia.org/T90916#1075256 (10Jdforrester-WMF) 5Open>3Resolved [02:31:46] 10VisualEditor, 10Continuous-Integration, 5§ VisualEditor Q3 Blockers: Jenkins: Convert mwext qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#1075258 (10Jdforrester-WMF) [03:10:57] 10OOjs-UI, 10MediaWiki-skins-Vector: OOjs UI uses font-size of 12.8px (0.8×16px) for windows and toolbars, but Vector skin uses 14px (0.875×16px) for body content, creating inconsistency between widgets in windows/toolbars and "free-standing" ones - https://phabricator.wikimedia.org/T91152#1075292 (10matmarex)... [03:11:44] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki, 10Apex, and 2 others: OOjs UI uses font-size of 12.8px (0.8×16px) for windows and toolbars, but Vector skin uses 14px (0.875×16px) for body content, creating inconsistency between widgets in windows/toolba... - https://phabricator.wikimedia.org/T91152#1075299 [03:20:25] 10OOjs-UI: OOUI has no way to produce a window-like frame around something other than a window - https://phabricator.wikimedia.org/T91153#1075305 (10matmarex) 3NEW a:3matmarex [06:46:55] 10VisualEditor: VisualEditor gets into endless visualeditoredit API loop when saving the page - https://phabricator.wikimedia.org/T91158#1075415 (10Tgr) 3NEW [09:11:22] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki, 10Apex, and 2 others: OOjs UI uses font-size of 12.8px (0.8×16px) for windows and toolbars, but Vector skin uses 14px (0.875×16px) for body content, creating inconsistency between widgets in windows/toolba... - https://phabricator.wikimedia.org/T91152#1075492 [13:40:28] (03CR) 10Mvolz: [C: 031] Refactor Citoid extension as an inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [13:47:57] (03PS1) 10Zfilipin: WIP T90423 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193567 (https://phabricator.wikimedia.org/T90423) [13:58:46] (03PS2) 10Zfilipin: WIP T90423 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193567 (https://phabricator.wikimedia.org/T90423) [14:08:03] (03PS3) 10Zfilipin: WIP T90423 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193567 (https://phabricator.wikimedia.org/T90423) [14:50:19] (03PS1) 10Mvolz: Fix: Don't convert ISSN/ISBN in MWDeprecated [services/citoid] - 10https://gerrit.wikimedia.org/r/193575 (https://phabricator.wikimedia.org/T90463) [15:24:35] (03Abandoned) 10Zfilipin: WIP T90423 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193567 (https://phabricator.wikimedia.org/T90423) (owner: 10Zfilipin) [15:26:21] What terrible thing will happen if I add tests that require access to the internet? [15:26:44] will it murder jenkins? [15:31:42] (03PS1) 10Zfilipin: [BrowserTest] Use Cucumber tag to specify which scenario to run [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193579 (https://phabricator.wikimedia.org/T90423) [15:32:23] (03CR) 10Zfilipin: "See also https://gerrit.wikimedia.org/r/#/c/193577/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193579 (https://phabricator.wikimedia.org/T90423) (owner: 10Zfilipin) [16:02:48] mvolz: It won't kill Jenkins but it will go against best practices for other reasons [16:02:57] mvolz: Namely that tests should test your application, not someone else's [16:03:26] It will also slow down tests and cause tests failures if the other party is unavailable. [16:07:01] What are you considering using an external service for? [16:33:35] (03PS1) 10Mvolz: [WIP] Add mocha tests [services/citoid] - 10https://gerrit.wikimedia.org/r/193580 (https://phabricator.wikimedia.org/T91168) [16:34:22] Krinkle: well it's a web scraper [16:34:31] so the easiest way to test it is to use things on the internet [16:34:39] definitely planning to load static html as well [16:34:44] but yeah [16:35:35] another complicated part is I'm going to have some tests that require zotero to be running, I've basically decided to not put that in the "grunt test" command because I don't see how jenkins could do that :) [16:36:01] well if we allow cors and have zotero publically in production somewhere we could use that [16:36:13] and have it in a settings file for jenkins [16:36:26] anyway getting ahead of myself. My tests are passing even when they shouldn't be. [16:36:29] waaaai [16:36:45] all two that I wrote. clearly they are not working :/ [16:39:41] (03CR) 10Mvolz: [WIP] Add mocha tests (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/193580 (https://phabricator.wikimedia.org/T91168) (owner: 10Mvolz) [16:48:30] mvolz: Jenkins will run grunt-test, it's doing that already I think. [16:48:40] It can fetch any package.json (dev)dependencies you want to use. [16:48:49] It downloads them in an isolated environment and runs the tests. [16:49:00] You can set up a server on a port temporarily during the grunt run, no problem. [16:49:10] so you can e.g. make requests to the local server. [16:49:55] Though that's only useful if the server in question is powered by code in the repo being tested. If the server is upstream or maintained in a different repo, you may want to instead mock the responses with static sample data. [16:51:39] Typically you'd use unit tests to directly call the functions the server uses (e.g. not every test should go through an http request). And then at the end a small handful of tests that test the entire flow over http. [18:38:14] (03CR) 10Krinkle: "Overall direction looks great. I am worried about module explosion though, do these need to be separate modules?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope) [21:58:28] (03PS2) 10Bartosz Dziewoński: tests: Run JS/PHP tests for widgets with required parameters, too [oojs/ui] - 10https://gerrit.wikimedia.org/r/193114 [21:58:30] (03PS3) 10Bartosz Dziewoński: tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 [21:58:44] (03CR) 10Bartosz Dziewoński: "Rebased." [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [21:59:08] (03CR) 10Bartosz Dziewoński: "The mystery of failing tests resolved: there is no #qunit-fixture when running with Karma. https://github.com/karma-runner/karma-qunit/pul" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [22:00:10] (03CR) 10jenkins-bot: [V: 04-1] tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [22:04:47] (03PS24) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [22:05:07] (03PS39) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [22:22:48] (03PS4) 10Bartosz Dziewoński: tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 [22:22:50] (03PS1) 10Bartosz Dziewoński: Upgrade karma-qunit to ??? [oojs/ui] - 10https://gerrit.wikimedia.org/r/193654 [22:25:54] (03CR) 10jenkins-bot: [V: 04-1] tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [22:27:20] (03CR) 10jenkins-bot: [V: 04-1] Upgrade karma-qunit to ??? [oojs/ui] - 10https://gerrit.wikimedia.org/r/193654 (owner: 10Bartosz Dziewoński)