[00:40:55] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 5§ VisualEditor Q3 Blockers: Parsoid should return the full srcset for high DPI devices - https://phabricator.wikimedia.org/T88827#1076866 (10Jdforrester-WMF) [00:41:50] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 5§ VisualEditor Q3 Blockers: Parsoid should return the full srcset for high DPI devices - https://phabricator.wikimedia.org/T88827#1021211 (10Jdforrester-WMF) [00:45:50] 10VisualEditor, 10Wikimedia-Hackathon-2015: Create an extension/gadget that prompts the user to add citation when they edit in VisualEditor - https://phabricator.wikimedia.org/T91101#1076871 (10Jdforrester-WMF) p:5Triage>3Normal [00:46:23] 10VisualEditor, 10VisualEditor-ContentEditable: [Regression] "I shouldn't be clickable" in standalone aliens.html demo is clickable - https://phabricator.wikimedia.org/T90945#1076875 (10Jdforrester-WMF) [00:46:34] 10VisualEditor, 10VisualEditor-ContentEditable: [Regression] "I shouldn't be clickable" in standalone aliens.html demo is clickable - https://phabricator.wikimedia.org/T90945#1071460 (10Jdforrester-WMF) p:5Triage>3Normal [00:49:23] 10VisualEditor, 7Performance, 5§ VisualEditor Q3 Blockers: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1076881 (10Jdforrester-WMF) p:5Triage>3High [00:54:26] (03CR) 10Jforrester: [C: 032] Provide isAlignable checks for alignable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193369 (owner: 10Esanders) [00:57:01] (03Merged) 10jenkins-bot: Provide isAlignable checks for alignable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193369 (owner: 10Esanders) [00:57:02] 10VisualEditor: Fix styling inconsistencies between context item and inspector - https://phabricator.wikimedia.org/T90896#1076892 (10Jdforrester-WMF) p:5Triage>3Normal [00:57:36] 10VisualEditor: VisualEditor got into endless visualeditoredit API loop when saving the page - https://phabricator.wikimedia.org/T91158#1076895 (10Jdforrester-WMF) p:5Triage>3Normal [01:03:37] (03PS19) 10Jforrester: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [01:03:52] (03CR) 10Jforrester: "PS19 provides the jsduck fixes" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [01:04:05] (03CR) 10Jforrester: [C: 031] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [01:17:11] (03PS1) 10Jforrester: Promote the Language tool Beta Feature to always-on status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193761 [02:05:25] 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar groups should support sub-groups as items - https://phabricator.wikimedia.org/T74159#1076918 (10Jdforrester-WMF) [02:05:33] 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1076920 (10Jdforrester-WMF) [02:06:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1076924 (10Jdforrester-WMF) Per discussion at the VisualEditor triage meeting, we're removing this u... [02:06:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1076927 (10Jdforrester-WMF) [02:37:36] (03PS2) 10Jforrester: Add insert/edit modes to FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal) [02:40:17] (03CR) 10Jforrester: Add insert/edit modes to FragmentInspector (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal) [02:40:22] (03CR) 10Jforrester: [C: 04-1] Add insert/edit modes to FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal) [02:42:33] 10VisualEditor, 10VisualEditor-EditingTools: [Regression wmf22] Resizing the window adds an extra padding below the "Choose a different image" button in Media Settings dialog - https://phabricator.wikimedia.org/T72895#1076932 (10Jdforrester-WMF) 5Open>3Resolved Seems fixed now? [02:45:56] 10VisualEditor, 10Continuous-Integration, 5§ VisualEditor Q3 Blockers: Concurrent builds using local Chromium/Firefox browsers on Linux host fail - https://phabricator.wikimedia.org/T90673#1076934 (10Jdforrester-WMF) [02:48:12] 10VisualEditor, 7Documentation: API design and documentation - https://phabricator.wikimedia.org/T40855#1076937 (10Jdforrester-WMF) a:5Catrope>3None [02:48:25] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - https://phabricator.wikimedia.org/T64850#1076938 (10Jdforrester-WMF) a:5Catrope>3None [02:48:34] 10VisualEditor, 7Documentation, 7Technical-Debt: Complete and document VisualEditor's integration and plugin system - https://phabricator.wikimedia.org/T52514#1076940 (10Jdforrester-WMF) a:5Catrope>3None [02:56:05] (03PS4) 10Jforrester: [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope) [02:56:36] (03CR) 10Jforrester: "PS4 just makes these changes automatically to extension.json too. Ideally the tests will now pass…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:56:50] (03CR) 10Jforrester: "… don't mind me, wrong window." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:57:07] (03CR) 10Jforrester: "PS4 just makes these changes automatically to extension.json too. Ideally the tests will now pass…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope) [02:58:10] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope) [03:03:04] (03PS2) 10Jforrester: [VERY VERY WIP] DocumentSet and subdocuments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179940 (owner: 10Catrope) [03:03:17] (03PS3) 10Jforrester: [VERY VERY WIP] DocumentSet and subdocuments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179940 (https://phabricator.wikimedia.org/T49344) (owner: 10Catrope) [03:10:53] (03CR) 10Jforrester: [C: 032] ToggleSwitchWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/193528 (owner: 10Kmenger) [03:13:49] (03Merged) 10jenkins-bot: ToggleSwitchWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/193528 (owner: 10Kmenger) [03:16:56] (03CR) 10Jforrester: [C: 04-1] "Block on OOjs UI toolbar improvements." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) (owner: 10Alex Monk) [03:21:24] (03CR) 10Jforrester: [C: 032] Fix: Don't convert ISSN/ISBN in MWDeprecated [services/citoid] - 10https://gerrit.wikimedia.org/r/193575 (https://phabricator.wikimedia.org/T90463) (owner: 10Mvolz) [03:21:44] (03Merged) 10jenkins-bot: Fix: Don't convert ISSN/ISBN in MWDeprecated [services/citoid] - 10https://gerrit.wikimedia.org/r/193575 (https://phabricator.wikimedia.org/T90463) (owner: 10Mvolz) [03:23:05] (03CR) 10Jforrester: [C: 032] Delete boolean values if they are false [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/193007 (https://phabricator.wikimedia.org/T90283) (owner: 10Mooeypoo) [03:23:24] 10TemplateData, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20): Template Documentation Editor: Suggested, Required, Deprecated values cannot be unset - https://phabricator.wikimedia.org/T90283#1076977 (10Jdforrester-WMF) 5Open>3Resolved [03:23:54] (03Merged) 10jenkins-bot: Delete boolean values if they are false [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/193007 (https://phabricator.wikimedia.org/T90283) (owner: 10Mooeypoo) [03:27:39] (03Abandoned) 10Jforrester: [WIP] Don't animate the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189776 (owner: 10Catrope) [03:28:40] (03Abandoned) 10Jforrester: [WIP] Make sanity check synchronous [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186100 (https://phabricator.wikimedia.org/T87161) (owner: 10Catrope) [03:35:42] (03Abandoned) 10Alex Monk: Move insert media button to top level toolbar between cite and structure [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192052 (https://phabricator.wikimedia.org/T90299) (owner: 10Alex Monk) [03:36:13] Krenair: It's likely to get merged next week… [03:36:23] * James_F shrugs. [03:36:23] Okay. [03:38:09] Hm. Sanity checks. [03:38:24] James_F, we're not getting things tagged as needcheck anymore, right? [03:39:26] Correct. [03:40:33] Okay. I wonder if we should run a search for known browser-caused corruptions occasionally then. [03:41:12] browser plugin-caused* [03:41:37] * James_F nods. [03:43:39] Should be easy enough to adapt mwgrep for it. I don't know if it'd cause performance issues with the search cluster... Discussions for another time [03:44:05] 10OOjs-UI, 7Technical-Debt: Re-write DraggableGroupElement/DraggableElement to be more robust and generalized - https://phabricator.wikimedia.org/T88854#1077003 (10Jdforrester-WMF) p:5Triage>3Low [03:44:13] 10OOjs-UI, 10VisualEditor: Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1077009 (10Jdforrester-WMF) p:5Triage>3Low [03:44:45] Unlikely for us to find existing ones, if the $.remove stuff works. [03:45:08] And for the things not in $.remove we won't know to search for them. [03:45:27] Right. [03:45:38] If the $.remove stuff works [03:46:04] I'm not sure we know that it does at the moment, do we? [03:46:35] I think it does. [03:46:46] Absence of evidence isn't evidence of absence, however. :-( [03:47:08] Okay. I was never able to actually reproduce the issue. I just blindly attempted to hide it. [04:00:26] 10VisualEditor, 10VisualEditor-Performance: Incrementally parse and convert API response as data comes in - https://phabricator.wikimedia.org/T89930#1077015 (10Jdforrester-WMF) p:5Triage>3Normal [04:00:55] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 7Performance: Removing characters causes re-rendering of paragraph (causing spell-check to flicker) - https://phabricator.wikimedia.org/T89625#1077017 (10Jdforrester-WMF) 5Open>3stalled [04:01:55] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10VisualEditor-Performance, 7Performance: Pasting content results in scroll flickering - https://phabricator.wikimedia.org/T89623#1077018 (10Jdforrester-WMF) p:5Triage>3Normal [04:03:22] 10VisualEditor, 10VisualEditor-Performance: VisualEditor: Opening a very large complex transclusion sometimes hangs in Firefox - https://phabricator.wikimedia.org/T74401#1077023 (10Jdforrester-WMF) p:5Triage>3High [04:03:31] 10VisualEditor, 10VisualEditor-Performance: Layout / recalculate style in ve.ui.Toolbar.calculateOffset - https://phabricator.wikimedia.org/T89419#1077025 (10Jdforrester-WMF) p:5Triage>3Normal [04:03:42] 10VisualEditor, 10VisualEditor-Performance: Recalculate style in ve.ui.Surface.initialize - https://phabricator.wikimedia.org/T89421#1077027 (10Jdforrester-WMF) p:5Triage>3High [04:14:07] Krenair: Yeah, none of us were. :-( [04:28:14] James_F, thank you for writing that email. [04:28:27] No problem. [04:28:41] Mostly it was me trying to work out where we are vis-à-vis our Q3 blockers. [04:29:10] How on track are we to dealing with all our Q3 blockers? [04:29:22] (before the end of Q3...) [04:29:34] Well, the big issue is the citoid service. [04:33:03] Other than that, it's… OK. [04:34:38] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: History actions should scroll the location of the transaction into view (unless it's a meta-data transaction which has no location?) - https://phabricator.wikimedia.org/T60091#1077066 (10Jdforrester-WMF) [04:34:39] 10VisualEditor, 10VisualEditor-ContentEditable, 5§ VisualEditor Q3 Blockers: Scroll to an item when it is selected e.g. when it has been newly inserted - https://phabricator.wikimedia.org/T53911#1077065 (10Jdforrester-WMF) 5Open>3stalled [04:34:44] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Come up with a way of estimating load time and progress along that scale - https://phabricator.wikimedia.org/T90622#1077067 (10Jdforrester-WMF) 5Open>3stalled [04:34:48] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 5§ VisualEditor Q3 Blockers: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1077068 (10Jdforrester-WMF) 5Open>3stalled [04:34:58] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Tracking: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - https://phabricator.wikimedia.org/T50789#1077070 (10Jdforrester-WMF) [04:34:58] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 5§ VisualEditor Q3 Blockers: External link interface for link dialogue - https://phabricator.wikimedia.org/T76398#1077069 (10Jdforrester-WMF) 5Open>3stalled [04:35:03] 10VisualEditor, 10VisualEditor-EditingTools, 7Browser-Support-Firefox, 5§ VisualEditor Q3 Blockers: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1077072 (10Jdforrester-WMF) 5Open>3sta... [04:35:13] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 5§ VisualEditor Q3 Blockers: Parsoid should return the full srcset for high DPI devices - https://phabricator.wikimedia.org/T88827#1077075 (10Jdforrester-WMF) 5Open>3stalled [04:35:49] Krenair: https://phabricator.wikimedia.org/maniphest/query/A1RxDGCaOKAT/#R is a good way to get a gauge [04:37:34] 10OOjs-UI, 10VisualEditor, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: Implement a way to nest toolbar groups without implementing nesting of toolbar groups - https://phabricator.wikimedia.org/T90815#1077077 (10Jdforrester-WMF) [04:37:52] 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar groups should support sub-groups as items - https://phabricator.wikimedia.org/T74159#1077078 (10Jdforrester-WMF) [04:37:53] 10OOjs-UI, 10VisualEditor, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: Implement a way to nest toolbar groups without implementing nesting of toolbar groups - https://phabricator.wikimedia.org/T90815#1068188 (10Jdforrester-WMF) [04:38:04] 10OOjs-UI: OOjs UI: Toolbar groups should support sub-groups as items - https://phabricator.wikimedia.org/T74159#747247 (10Jdforrester-WMF) [04:39:14] Krenair: And https://phabricator.wikimedia.org/project/sprint/burn/1015/ of course. [04:40:17] Is there no way to make "Ideal Points" start from the right date? :/ [04:40:25] It does start from the right date. [04:40:55] But the "we fixed it" data doesn't (I can't make it understand that we fixed things in early January when we only recorded them as fixed in early February). [05:01:38] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1077100 (10Jdforrester-WMF) The query to do this is as follows: https://en.wikipedia.org/w/api.php?action=query&titles=Lorem%20ipsum|Barack%20Obama&prop=pageterms|pageimage... [05:17:04] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20): Context menu moves to middle of inline selection when an inspector is opened - https://phabricator.wikimedia.org/T90857#1077101 (10Jdforrester-WMF) 5Open>3Resolved [05:32:51] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1077126 (10Jdforrester-WMF) [05:33:13] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1012026 (10Jdforrester-WMF) (Updated the description to say the third item is fixed, per Kaldari.) [05:43:17] 10VisualEditor, 6Community-Liaison, 10Wikimania-Hackathon-2015: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1077142 (10Jdforrester-WMF) https://translatewiki.net/w/i.php?title=Special:MessageGroupStats&group=ext-visualeditor-0-all#sortable:3=desc is doing pretty we... [05:56:37] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 7 others: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#1077159 (10Jdforrester-WMF) >>! In T55784#1047315, @GWicke wrote: > @jdforrester-wmf, is this really high prio... [07:35:34] 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 7I18n, 5Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1077227 (10Aklapper) >>! In T85700#1075849, @MaxBioHazard wrote: > not fixed Correct, as thi... [07:42:27] (03PS1) 10Catrope: Avoid calling $.fn.add, it's slow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193782 [07:45:34] 10VisualEditor: VisualEditor got into endless visualeditoredit API loop when saving the page - https://phabricator.wikimedia.org/T91158#1077244 (10Catrope) Could this be a regression from when we moved to `mw.Api` recently? [08:08:54] 10MediaWiki-ResourceLoader, 7Performance, 7Varnish: Investigate cross-domain variance of loading time for similar load.php requests - https://phabricator.wikimedia.org/T91198#1077272 (10Aklapper) p:5Triage>3Normal [08:10:03] (03PS1) 10Catrope: ce.ContentBranchNode: Prevent setupSlugs() from being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193787 [08:10:05] (03PS1) 10Catrope: ce.ContentBranchNode: Don't compare new rendering with old on first render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193788 [08:12:12] (03CR) 10jenkins-bot: [V: 04-1] ce.ContentBranchNode: Don't compare new rendering with old on first render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193788 (owner: 10Catrope) [08:12:36] (03CR) 10jenkins-bot: [V: 04-1] ce.ContentBranchNode: Prevent setupSlugs() from being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193787 (owner: 10Catrope) [08:36:20] (03PS1) 10Prtksxna: Use the correct color for gray buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/193790 (https://phabricator.wikimedia.org/T88622) [09:04:09] (03PS1) 10Prtksxna: Use only 2 variables each for each semantic color [oojs/ui] - 10https://gerrit.wikimedia.org/r/193793 (https://phabricator.wikimedia.org/T88622) [09:05:13] (03PS2) 10Prtksxna: Use only two variables each for each semantic color [oojs/ui] - 10https://gerrit.wikimedia.org/r/193793 (https://phabricator.wikimedia.org/T88622) [09:56:13] (03CR) 10Hashar: [C: 031] "You probably want to give a bit more explanations in the commit message. Ie that this let us remove a more specific macro in JJB ( https:/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193579 (https://phabricator.wikimedia.org/T90423) (owner: 10Zfilipin) [10:22:38] 10VisualEditor, 10VisualEditor-ContentEditable: Native backspace/delete doesn't cause slugs to appear when they should - https://phabricator.wikimedia.org/T91242#1077591 (10Catrope) 3NEW a:3dchan [10:31:16] 10VisualEditor, 10VisualEditor-ContentEditable: Check preventing identical rerenderings in renderContents doesn't work if node contains slugs - https://phabricator.wikimedia.org/T91244#1077641 (10Catrope) 3NEW a:3dchan [10:32:44] (03PS2) 10Catrope: [WIP] ce.ContentBranchNode: Prevent setupSlugs() from being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193787 [10:33:48] (03PS2) 10Catrope: ce.ContentBranchNode: Don't compare new rendering with old on first render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193788 [10:35:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ce.ContentBranchNode: Prevent setupSlugs() from being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193787 (owner: 10Catrope) [10:35:35] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance: setupSlugs is called twice during ContentBranchNode setup - https://phabricator.wikimedia.org/T91245#1077653 (10Catrope) 3NEW [10:35:50] (03PS3) 10Catrope: [WIP] ce.ContentBranchNode: Prevent setupSlugs() from being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193787 (https://phabricator.wikimedia.org/T91245) [10:37:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ce.ContentBranchNode: Prevent setupSlugs() from being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193787 (https://phabricator.wikimedia.org/T91245) (owner: 10Catrope) [10:38:55] 10VisualEditor, 10VisualEditor-ContentEditable: Check preventing identical rerenderings in renderContents doesn't work if node contains slugs - https://phabricator.wikimedia.org/T91244#1077670 (10Catrope) https://gerrit.wikimedia.org/r/#/c/193788/ is somewhat related: it prevents this check from being performe... [10:39:53] 10VisualEditor, 6Community-Liaison, 10Wikimania-Hackathon-2015: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1077671 (10Elitre) We need to consider Phase 5 and 6 wikis, and then the documentation pages - https://www.mediawiki.org/wiki/VisualEditor/TranslationCentral... [11:07:20] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Vagrant, 10Wikidata, and 2 others: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1077706 (10JanZerebecki) The test run without that setting failed even though it shows... [11:10:23] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance: Using data URI images in inline slugs (for chimeras) is slow in Chrome - https://phabricator.wikimedia.org/T91248#1077708 (10Catrope) 3NEW [11:21:13] (03PS2) 10Zfilipin: [BrowserTest] Use Cucumber tag to specify which scenario to run [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193579 (https://phabricator.wikimedia.org/T90423) [11:21:32] (03PS3) 10Zfilipin: [BrowserTest] Use Cucumber tag to specify which scenario to run [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193579 (https://phabricator.wikimedia.org/T90423) [11:30:44] (03CR) 10Catrope: [C: 032] Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [11:32:50] (03Merged) 10jenkins-bot: Show the toolbar as soon as the target has been activated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192072 (https://phabricator.wikimedia.org/T76523) (owner: 10Esanders) [11:37:02] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: Use CSS for toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [11:39:15] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Use CSS for toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192047 (https://phabricator.wikimedia.org/T89543) (owner: 10Krinkle) [11:50:33] (03PS1) 10Rits: T28462 changed print CSS for backlink arrows [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193812 [12:00:31] (03PS1) 10Catrope: Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 [12:02:34] (03CR) 10jenkins-bot: [V: 04-1] Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 (owner: 10Catrope) [12:23:02] (03PS2) 10Krinkle: ve.ce.GeneratedContentNode: Avoid calling $.fn.add, it's slow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193782 (owner: 10Catrope) [12:23:10] (03CR) 10Krinkle: [C: 032] ve.ce.GeneratedContentNode: Avoid calling $.fn.add, it's slow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193782 (owner: 10Catrope) [12:24:48] (03CR) 10Werdna: [C: 031] "LGTM but should be approved by somebody from Editing." [oojs/ui] - 10https://gerrit.wikimedia.org/r/193793 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna) [12:25:10] (03Merged) 10jenkins-bot: ve.ce.GeneratedContentNode: Avoid calling $.fn.add, it's slow [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193782 (owner: 10Catrope) [12:25:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs: Edit notice saying that changes must be reviewed appears even when the user has autoreview rights - https://phabricator.wikimedia.org/T60057#1077788 (10Cenarium) Noting that this would fix the editnotice part of T75931. [12:26:33] (03CR) 10Werdna: [C: 031] "LGTM but should be approved by Editing / a designer." [oojs/ui] - 10https://gerrit.wikimedia.org/r/193790 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna) [12:34:02] RoanKattouw: You.. but.. right. [12:34:04] Welcome to NL. [12:36:36] (03CR) 10Krinkle: "ve.ce.BranchNode test is failing because it currently relies on onSetup adding the class for when updateTagName() re-creates it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 (owner: 10Catrope) [12:36:50] haha [12:39:41] Krinkle: Yeah I was investigating that test failure but stopped to make lunch [12:39:45] I discovered something great [12:40:00] updateTagName()'s docs claim there is a 'rewrap' event [12:40:04] It has event documentation and everything [12:40:11] But nothing emits it and nothing listens to it [12:40:47] Aha [12:41:04] In 2013 Inez changed it from using rewrap to using teardown+setup [12:41:07] But never updated the docs [12:41:23] RoanKattouw: What're you gonna do? Re-add the event and add an inline listener to the constructor? [12:41:28] Probably [12:41:42] I can make it easier on subclasses by automatically transferring classes [12:41:48] I'm checking https://gerrit.wikimedia.org/r/#/c/193788/2/src/ce/ve.ce.ContentBranchNode.js [12:41:53] Curious why we clone the "old" wrapper [12:42:06] Krinkle: Because ve.normalizeNode() modifies [12:42:16] And the whole point is to avoid modifying this.$element if we can [12:42:44] (In a Phabricator task I filed about this, I questioned the necessity of this check, but while we have it we might as well not run it during setup) [12:43:04] Hm.. [12:43:11] Can we not assume the old wrapper to be normalised already? [12:43:40] In Chrome, I don't think so [12:43:52] Also the whole thing is pretty broken anyway, see https://phabricator.wikimedia.org/T91244 [12:44:23] Ah, this isnt character normalisatin [12:44:33] Nope, it's adjacent/empty text node normalization [12:44:42] Is removal of empty node and merging additional behaviour or the sole behaviour of normalise? [12:44:49] Sole [12:45:00] OK. That makes a lot of sense then [12:45:04] Which would make you think it's not that hard to implement [12:45:16] And the fallback implementation in ve.normalizeNode is pretty simple [12:45:38] But that didn't stop IE from having a broken version [12:47:08] Hm.. [12:47:18] renderContents is when updating a transclusion and replacing the html? [12:47:24] (+ initial render) [12:48:14] No this isn't GeneratedContentNode, it's ContentBranchNode [12:48:23] right [12:48:41] It's run when rerendering for a transaction and during setup, and also sometimes when the cursor moves for unicorn reasons [12:48:56] Oh and when the insertion annotations change [12:48:56] Ah, yeah. So it's quite often. [12:49:12] It doesn't run when you type though [12:49:16] I was questioning the likelihood of the contents being the same, whether it's worth the optimisation (aside from the IME issue) [12:49:21] I mean it does, but it bails immediately because rendering is locked [12:49:40] how does this compare to e.g. serialising with innerHTML and comparing that? [12:49:52] Yeah it's not so much an optimization issue as an "if we touch the DOM we will break IMEs" issue [12:49:54] which is recursive in nature and doesn't care abotu text node normalisation [12:50:19] I mean intuitively it seems that rerendering unconditionally would be cheaper than constructing a new rendering, comparing it against the old one, and only replacing it if they differ [12:50:33] attribute order may be tricky, though within the same browser it might work. Not sure. [12:50:36] isEqualNode and normalize are very fast [12:50:43] They don't even register in the profiler [12:50:57] k [12:50:59] cloneNode is also quite fast, we spend like 4ms on it for the entire Obama article [12:51:06] Or well, we would if Chrome wasn't stupid [12:51:08] copy on write I guess? [12:51:31] Or even just plain copy [12:51:31] Instead it's 61ms because sometimes there's an inline slug which has an [12:51:48] It's pure data, so yeah. [12:51:49] Interesting [12:51:55] That's https://phabricator.wikimedia.org/T91248 [12:52:04] cloneNode is fast because it basically doesn't touch the DOM. [12:52:18] In extreme cases (Liam's page of doom) we spend almost 2 seconds in cloneNode and importNode [12:52:32] Most of it when generating slugs [12:53:10] Which are generated by doing something like ve.ce.BranchNode.static.slugTemplate = $('').blahblah; slug = slugTemplate.cloneNode( true ); [12:53:20] Right [12:53:24] (in practice it uses doc.importNode( slugTemplate, true ); but that doesn't matter) [12:53:27] not the cloneNode call from rendercontents [12:53:34] It turns out that generating lots of spans containing these images is slow [12:53:52] I tried using an HTML string as a template, and I ended up spending all that time (more even) in set innerHTML instead [12:54:02] Yeah [12:54:10] Then I tried making the template a function that uses DOM methods to generate the slug, and that blamed most of the time on set src [12:54:11] What aboutu constructing as node instead of parsing html [12:54:26] e.g. storing its properties in a plain object and have it be creatElement + set props [12:54:43] Yeah that's basically what I did except hardcoded into a function [12:55:02] The differences between those 3 were small, what dominated was setting the src of the image [12:55:07] Even though it's a freaking data URI [12:55:10] Cool story, Chrome [12:55:15] ha [12:55:33] And it definitely has to be an inline image? [12:55:33] The timeline actually has tiny "loading image" frames for each of those [12:55:37] as opposed to css [12:55:38] I saw them earlier but dismissed them [12:55:50] Well, it definitely has to be an , I'm not sure how definitely it has to have an src [12:55:56] Yeah, Chrome (maybe other browsers too) loads images directly, not when attached. [12:56:00] I think that's only needed for Firefox, but I'm going to ask divec [12:56:23] Firefox is known to misbehave when an has an src that does not resolve to a real image [12:56:27] I forgot what the image in the slug is for [12:56:31] (Basically scenarios in which the alt text is shown) [12:56:57] Well that image used to be a zero-width non-breaking space [12:57:06] (03CR) 10Krinkle: [C: 031] ce.ContentBranchNode: Don't compare new rendering with old on first render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193788 (owner: 10Catrope) [12:57:17] But that's much more difficult to keep track of and remove [12:57:38] RoanKattouw: Right, because actual text means it's part of the content editable tree [12:57:42] and can cause state issues [12:57:53] Well you can't call removeChild() on a character [12:57:56] But you can on an node [12:58:08] So the image serves as a click target that takes up no space in the text contents of the ce [12:58:27] I know this can't the solution, but.. why not an inline-block span with no contents? [12:58:29] Not so much a click target as tricking the browser into thinking there is content, which allows a cursor to be placed [12:58:42] Browsers don't let you place a cursor into empty spans or even empty paragraphs [12:58:44] Ah, right. The cursor has to go inside [12:58:47] OK [12:58:49] Got it [12:59:07] Because offsets go by character? [12:59:09] Originally, we dealt with this by putting in a zwnbsp [12:59:33] Could we programmatically put the cursor in there and have an empty inline-block span? [12:59:39] Then when you typed, on keydown we'd replace the zwnbsp with a pawn and select the pawn, so the native action would then replace the pawn with the character you typed [12:59:50] This is deeply evil for all the usual reasons that pawning is evil and breaks IMEs [12:59:52] Yeah [13:00:02] So when does this come into play [13:00:15] It's not the slugs we use for inserting paragraphs [13:00:18] Empty paragraphs is the most common case [13:00:38] The other case is two adjacent inline nodes [13:00:47] Or an inline node at the very beginning or end of a paragraph [13:01:05] (For "paragraph" read "ContentBranchNode" which means "paragraph or heading or 
[13:01:13] 	 So they render with proper width/height as click target, right?
[13:01:26] 	 No, they have style="width: 0; height: 0;"
[13:01:47] 	 The only reason they're there is because the browser's cursoring behavior changes if there's really nothing there
[13:02:02] 	 This tricks the browser into thinking there's something there, while staying invisible
[13:02:26] 	 Block slugs do have click targets, and even ButtonWidgets. Those are for inserting paragraphs
[13:02:35] 	 The ones I'm talking about are inline slugs, inside of paragraphs
[13:03:38] 	 Rendering 

 for empty paragraphs would work just as well, except then getting rid of that character at the right time without breaking IMEs is a nightmare
[13:04:06] 	 OK. I reproduced it by adding {{Unsigned}} via Insert Template at the end of a paragraph
[13:04:18] 	 I can cursor over it or by clicking in the empty space anywhere after it on the same line
[13:04:24] 	 Yeah
[13:04:49] 	 And if you inspect the DOM you'll see that after the template there's something like 
[13:05:06] 	 Yeah
[13:05:12] 	 If I remove the  in Chrome
[13:05:25] 	 I can still put my cursor there. both by click and by arrow keys
[13:05:33] 	 and typing inserts chars in the empty span
[13:05:51] 	 Hmm, interesting
[13:05:57] 	 I wonder if that works for empty paragraphs though
[13:06:30] 	 Also try putting two of those templates next to each other
[13:06:39] 	 
Foo bar

[13:08:01] 	 Yup
[13:08:14] 	 Putting two of them next to each other, then removing the  I can cursor between and type
[13:08:19] 	 and text end sup in the slug
[13:08:20] 	 interesting
[13:08:30] 	 two inline templates that is
[13:08:49] 	 
Foo bar

[13:09:03] 	 cursoring to the right of template1 put em in the inline slug
[13:09:23] 	 Might not work if it was always empty
[13:09:33] 	 coudl be some residual thing from the img being there at first
[13:14:08] 	 (03CR) 10Krinkle: [C: 04-1] "Should not be needed. Our test runner creates the #qunit-fixture element." [oojs/ui] - 10https://gerrit.wikimedia.org/r/193654 (owner: 10Bartosz Dziewoński)
[13:14:21] 	 Yeah I don't know
[13:14:28] 	 There's also Firefox :S
[13:16:22] 	 (03CR) 10Krinkle: "Actually, I removed it from OOjs UI last year as we didn't need it. I think it makes the test cleaner though. It's trivial to attach and d" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193654 (owner: 10Bartosz Dziewoński)
[13:16:28] 	 (03CR) 10Krinkle: "(See Element.test.js)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193654 (owner: 10Bartosz Dziewoński)
[13:21:17] 	 (03CR) 10Krinkle: Upgrade karma-qunit to ??? (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/193654 (owner: 10Bartosz Dziewoński)
[13:23:39] 	 RoanKattouw: For https://gerrit.wikimedia.org/r/#/c/179242/1/src/ce/styles/nodes/ve.ce.FocusableNode.css, what is the bug exactly? The first set of target-ie rules uses the exact same selector as the rules above it.
[13:23:53] 	 What makes (potentially) the second of the three rules work?
[13:24:02] 	 Krinkle: highlights plural vs highlight singular
[13:24:11] 	 Oh wow, that's just evil
[13:24:23] 	 Not a great class name
[13:24:34] 	 Well only one of them was meant to be styled originally :P
[13:24:36] 	 And then IE happened
[13:24:58] 	 we usually go with item and item-container or items and items-thing
[13:25:00] 	 or some such
[13:25:27] 	 yeah
[13:25:30] 	 I blame Ed :D
[13:25:44] 	 But yeah good point, one of those classes should probably be renamed
[13:32:39] 	 (03PS2) 10TheDJ: Hide backlink arrow with CSS for print [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193812 (https://phabricator.wikimedia.org/T28462) (owner: 10Rits)
[13:35:32] 	 10VisualEditor, 10Wikidata: Visual Editor does not work well on Wikidata:Project chat - https://phabricator.wikimedia.org/T91252#1077842 (10aude) 3NEW
[13:37:29] 	 (03CR) 10TheDJ: "I've updated the commit message per our https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193812 (https://phabricator.wikimedia.org/T28462) (owner: 10Rits)
[14:17:07] 	 10WikiEditor: Fallback messages get shown on RTL wikis with LTR user interface language - https://phabricator.wikimedia.org/T73661#1077993 (10Fomafix) This is not a general problem on RTL wikis with LTR user interface language. It only occurs on //arwiki//. For example it does not occur on //fawiki//: https://fa...
[14:20:34] 	 Hrmph, because of nastiness in GeneratedContentNode I'm pretty much forced to have addClass() calls in setup
[14:38:51] 	 (03CR) 10Thiemo Mättig (WMDE): [C: 031] "The code does what it's supposed to do. The German Wikipedia, for example, does almost exactly that: https://de.wikipedia.org/wiki/MediaWi" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193812 (https://phabricator.wikimedia.org/T28462) (owner: 10Rits)
[14:43:54] 	 (03PS2) 10Catrope: Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 
[14:43:56] 	 (03PS1) 10Catrope: Fix documentation lies about rewrap event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193823 
[14:43:58] 	 (03PS1) 10Catrope: Make ce.BranchNode#updateTagName do what its documentation says [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193824 
[14:46:32] 	 Krinkle: Re all the new modules in my WIP TargetLoader change: it's not that important that they all be separate modules, but I don't see an easy and sane way to have fewer modules
[14:46:38] 	 I agree having several one-file modules is silly
[14:47:16] 	 I also can't double-include these files because they do things like ve.init = {};
[14:48:32] 	 Krinkle: I was hoping I could pick your brain on the TODO items in the commit message
[14:48:59] 	 Especially the issues of how to deal with errors, how to handle ve-activating/ve-active in this world (should those be set by init init or TargetLoader instead?)
[14:49:20] 	 Basically a lot of the activation code in VPT and MWT assumes that it loads early, and now it loads late
[14:50:05] 	 Right now I'm passing in a data object to activate(), but that requires I have the data ready before I call activate(). Maybe I'll pass in a data promise instead
[14:50:14] 	 That way it'll be easier to support Ed's early toolbar loading thing for instance
[15:05:54] 	 (03CR) 10Krinkle: [C: 031] Fix documentation lies about rewrap event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193823 (owner: 10Catrope)
[15:07:41] 	 RoanKattouw: I saw those questions, but didn't quite get why it would be different. The diff of your commit is surprisingly small. I must've missed the thing that requires it activation stuff needs a change.
[15:08:04] 	 Well I didn't do those things yet
[15:08:22] 	 I mean, I need to change more things but I haven't changed them yet because I haven't decided how to do that yet
[15:10:03] 	 (03CR) 10Krinkle: Make ce.BranchNode#updateTagName do what its documentation says (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193824 (owner: 10Catrope)
[15:10:54] 	 (03CR) 10Catrope: Make ce.BranchNode#updateTagName do what its documentation says (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193824 (owner: 10Catrope)
[15:12:25] 	 Krinkle: So one problem with errors is that we'd just invoke ve.init.mw.Target.onLoadError, but now if TargetLoader runs into an error, ve.init.mw.Target may not have loaded yet, or the nature of the error may be such that it will never load
[15:13:01] 	 RoanKattouw: Hm.. would you be open to unjqueryfying that part a little bit (#updateTagName). E.g. childNodes instead of contents(). Saves some overhead and also another merge/sort/pushStack
[15:13:34] 	 Absolutely
[15:13:37] 	 e.g. element.childNodes, element.className, element.contentEditable
[15:13:44] 	 Because I hate the whole .prop() thing there
[15:13:49] 	 We could still use jquery for the new elem as convenience
[15:13:52] 	 Or not
[15:13:59] 	 At least for append() it's convenient I suppose
[15:14:00] 	 I wasn't even sure if .prop( 'class', ... ) would work, but in the DOM API I know how to do this
[15:14:07] 	 className is the property name
[15:14:11] 	 Yeah, class won't work
[15:14:19] 	 No it does
[15:14:24] 	 For reading at least
[15:14:27] 	 Nope
[15:14:31] 	 And for writing too or the tests would fail
[15:14:39] 	 Yeah, but here's the thing
[15:14:49] 	 It's one of two properties jQuery kept when it said it removed this hack from attr/prop
[15:15:07] 	 class->className, for->htmlFor
[15:15:26] 	 all other stuff and boolean casting and attr->prop proxying was removed
[15:15:38] 	 It's undocumented though
[15:15:48] 	 and definitely not part of the DOM API for read or write
[15:16:37] 	 $.propFix
[15:17:44] 	 .prop( 'className' will work
[15:18:45] 	 RoanKattouw: Hm.. do we need addClass in onSetup even with updateTagNode copying it over?
[15:18:58] 	 (the few you left)
[15:19:05] 	 Yeah, the commit message says why
[15:19:08] 	 GCN does crazy things
[15:19:13] 	 Lke this.$element = $newElement
[15:19:23] 	 and otherwise replacing things in this.$element
[15:19:44] 	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance: Using data URI images in inline slugs (for chimeras) is slow in Chrome - https://phabricator.wikimedia.org/T91248#1078183 (10dchan) In Chromium there is no need to set the src attribute. In Firefox, if the src attribute is not set th...
[15:20:20] 	 Hm. ok
[15:20:30] 	 Perhaps it could be moved into a method GCN can call later
[15:20:39] 	 (03CR) 10Krinkle: [C: 031] Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 (owner: 10Catrope)
[15:21:22] 	 Krinkle: Theoretically LeafNode and BranchNode can listen to the rerender event, but that's doing things the wrong way around
[15:21:33] 	 The API GCN uses is calling teardown then setup
[15:21:46] 	 (or neither, if setup has not yet occurred)
[15:22:01] 	 Should updateTagNode not do that as well?
[15:22:25] 	 updateTagNode does in fact call teardown and setup
[15:22:39] 	 *updateTagName
[15:22:48] 	 Right
[15:23:42] 	 So by removing those addClass calls from onSetup calls that don't happen to affect GCN, we're breaking part of that signature that teardown/setup is enough
[15:23:59] 	 Looking for way that makes this cleaner
[15:25:20] 	 Yeah we kidn of are
[15:25:43] 	 (03CR) 10Krinkle: [WIP] Factor out loading code into TargetLoader (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope)
[15:26:04] 	 RoanKattouw: I'd like to either make GCN responsible for doing what updateTagName is doing. Or make updateTagName not responsible.
[15:26:24] 	 and thus keep onSetup, but that's inefficient.
[15:26:30] 	 We kind of don't want to require a setup.
[15:26:39] 	 And calling setup without there being a setup is also wrong.
[15:27:37] 	 updateTagName and GCN are different things doing similar things
[15:27:47] 	 But it's not an either-or thing
[15:27:54] 	 They are different pieces of code that both change $element
[15:28:02] 	 Yeah, but neither is really setting up the element as related to the 'setup' event from setLive
[15:28:38] 	 I suppose updateTagName does actually
[15:28:40] 	 Hm..
[15:28:45] 	 Well, both kind of don't and kind of do
[15:28:57] 	 They emit teardown, detach the old element, attach a new one, call setup
[15:29:02] 	 Would it be feasible to construct a new ce.Node and only call teardown.
[15:29:12] 	 Is there a cost?
[15:29:59] 	 updateTagName would have to know about all things constructors might do. Not just class and ce
[15:30:29] 	 If setup is only emitted from updateTagName and GCN, we could also use something like initialize. And call that from the constructor by default
[15:30:35] 	 and then also call it from updateTagName before setup
[15:30:51] 	 should have the same perf improvement still
[15:31:40] 	 10VisualEditor, 10VisualEditor-Performance, 7Performance, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Show the VisualEditor toolbar/editor chrome as soon as VE scripts are loaded, rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#1078209...
[15:31:45] 	 Hey.
[15:31:46] 	 Hm.. we should define the subset of properties that warrant and support setup, as opposed to re-construction. 
[15:32:43] 	 I imagine if a paragraph becomes a heading, it's reconstructed.
[15:32:49] 	 not torndown/setup
[15:33:16] 	 Well that's a different class
[15:33:35] 	 teardown is called on a HeadingNode instance and setup is called on a ParagraphNode instance
[15:34:09] 	 For uTN and GCN, we call teardown and setup on the same instance, but for sensible implementations that should still work
[15:34:19] 	 You're right thought I think we need something like an initialize function
[15:35:09] 	 Krinkle: Constructing a new ce.Node is difficult if you're trying to do that from inside of said ce.Node :)
[15:36:48] 	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Using data URI images in inline slugs (for chimeras) is slow in Chrome (and possibly others) - https://phabricator.wikimedia.org/T91248#1078226 (10Jdforrester-WMF) p:5Triage>3High
[15:37:30] 	 10VisualEditor, 10VisualEditor-ContentEditable: Check preventing identical re-renderings in renderContents doesn't work if node contains slugs - https://phabricator.wikimedia.org/T91244#1078232 (10Jdforrester-WMF) p:5Triage>3High
[15:38:04] 	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: setupSlugs is called twice during ContentBranchNode setup - https://phabricator.wikimedia.org/T91245#1078235 (10Jdforrester-WMF) p:5Triage>3High
[15:38:58] 	 The annoying thing is that this teardown/setup API is actually working fine
[15:39:12] 	 The only problem is the performance issue of calling .addClass() after the node is already attached
[15:39:53] 	 10VisualEditor, 10Wikidata: Visual Editor does not work well on Wikidata:Project chat - https://phabricator.wikimedia.org/T91252#1078240 (10Jdforrester-WMF) > Can visual editor add support for these things?  Sure. I estimate 1–2 years' time.  > If not, is there a way to disable visual editor on particular page...
[15:40:36] 	 RoanKattouw: Right, it's not a generic contract. It only has to support its own.
[15:41:06] 	 In that, a class knows in what cases it may be 'updated'. And thus what always survives and what needs ensuring in setup
[15:41:18] 	 So the separation is clear.
[15:41:34] 	 Except that updateTagName is called by subclasses. 
[15:41:38] 	 So that one is a bit vague
[15:41:44] 	 Yeah that's basically the kind-of-weak argument for why I did what I did in that commit
[15:41:54] 	 transplanting class/contentEditable just becomes a default 'setup'
[15:42:03] 	 When a class is a GCN subclass, it knows that it is a GCN subclass and that weird shit will happen to its .$element
[15:42:21] 	 s/is a GCN subclass/has GCN mixed in/
[15:42:50] 	 Whereas updateTagName is defined on BranchNode (but not LeafNode, WTF?)
[15:43:00] 	 10Cite, 5Patch-For-Review: Cite: Support multi-column and alternative list-style for  tag (like enwiki {{reflist}}) - https://phabricator.wikimedia.org/T53260#1078247 (10TheDJ) It should be noted that mobilefrontend already does some CSS overrides here (setting a default column width).
[15:49:27] 	 10VisualEditor, 10VisualEditor-EditingTools, 10Parsoid, 5§ VisualEditor Q3 Blockers: Comment is not getting added after Citation, Template,Gallery,Math node and Table - https://phabricator.wikimedia.org/T90517#1078283 (10ssastry) I watched the movie and looked at the specific place where Rummana added the...
[15:53:59] 	 Krinkle: werdna found https://code.google.com/p/chromium/issues/detail?id=463119 oO
[15:54:19] 	 (03CR) 10Divec: [C: 032] ce.ContentBranchNode: Don't compare new rendering with old on first render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193788 (owner: 10Catrope)
[15:56:26] 	 10VisualEditor, 10Wikidata: Visual Editor does not work well on Wikidata:Project chat - https://phabricator.wikimedia.org/T91252#1078304 (10aude) wonder how edits like https://www.wikidata.org/w/index.php?title=Wikidata%3AProject_chat&diff=200207987&oldid=200207707 are made in visual editor? particularly signi...
[15:57:48] 	 (03Merged) 10jenkins-bot: ce.ContentBranchNode: Don't compare new rendering with old on first render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193788 (owner: 10Catrope)
[16:00:02] 	 10VisualEditor, 10Wikidata: Visual Editor does not work well on Wikidata:Project chat - https://phabricator.wikimedia.org/T91252#1078315 (10Jdforrester-WMF) >>! In T91252#1078304, @aude wrote: > wonder how edits like https://www.wikidata.org/w/index.php?title=Wikidata%3AProject_chat&diff=200207987&oldid=200207...
[16:00:48] 	 10VisualEditor, 10Wikidata: Visual Editor does not work well on Wikidata:Project chat - https://phabricator.wikimedia.org/T91252#1078318 (10aude) ah, ok :)
[16:06:00] 	 (03CR) 10Mvolz: Make zotero.js an object (036 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[16:06:11] 	 (03PS13) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[16:06:13] 	 (03CR) 10jenkins-bot: [V: 04-1] Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[16:13:36] 	 10VisualEditor, 10Wikidata: VisualEditor does not work well on Wikidata:Project chat - https://phabricator.wikimedia.org/T91252#1078342 (10Jdforrester-WMF) p:5Triage>3Low
[16:14:24] 	 10VisualEditor, 10VisualEditor-ContentEditable: Native backspace/delete doesn't cause slugs to appear when they should - https://phabricator.wikimedia.org/T91242#1078350 (10Jdforrester-WMF) p:5Triage>3High
[16:16:57] 	 (03PS14) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[16:17:07] 	 (03PS2) 10Catrope: Make ce.BranchNode#updateTagName do what its documentation says [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193824 
[16:20:11] 	 (03PS15) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[16:20:13] 	 (03PS15) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[16:20:49] 	 (03CR) 10Krinkle: [C: 032] Fix documentation lies about rewrap event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193823 (owner: 10Catrope)
[16:21:43] 	 (03PS3) 10Catrope: Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 
[16:22:31] 	 RoanKattouw: FYI: append() adds nodes to a fragment and appends that. 
[16:22:49] 	 10Cite: Add tracking category for pages with  tags and without  - https://phabricator.wikimedia.org/T91263#1078389 (10Krenair)
[16:22:59] 	 Krinkle: OK... why is that relevant?
[16:22:59] 	 Since the target is attached, I'm not sure if there's a perf difference, but for other cases the fragment is nice to have a single append
[16:23:01] 	 (03Merged) 10jenkins-bot: Fix documentation lies about rewrap event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193823 (owner: 10Catrope)
[16:23:08] 	 Oh I see
[16:23:16] 	 less redraws
[16:23:41] 	 There are probably other places where we should use that too
[16:23:44] 	 appending a fragment is essentially like array.push.apply
[16:23:49] 	 We have a number of while ( foo.firstChild ) loops floating around
[16:23:55] 	 it has no wrapper, but is flattened into a single dom action
[16:24:27] 	 Yeah, I forgot the wrapper is detached in this case.
[16:24:48] 	 Which is why I suggested keeping append() with e.g. append( [0].childNodes )
[16:24:56] 	 but is fine I gues
[16:24:59] 	 s
[16:25:50] 	 (03CR) 10Krinkle: [C: 031] "Not yet tested." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193824 (owner: 10Catrope)
[16:27:09] 	 RoanKattouw: Nice catch on the table attr change -> class change
[16:27:23] 	 10Cite: Add tracking category for pages with  tags and without  - https://phabricator.wikimedia.org/T91263#1078417 (10Krenair)
[16:27:24] 	 10Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - https://phabricator.wikimedia.org/T69700#1078418 (10Krenair)
[16:29:04] 	 Krinkle: I was testing it and seeing table cells with both classes applied :)
[16:31:10] 	 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10UI-Standardization, and 2 others: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1078430 (10Jdforrester-WMF)
[16:33:36] 	 10VisualEditor, 10VisualEditor-Performance, 7Performance, 5§ VisualEditor Q3 Blockers: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1078444 (10Jdforrester-WMF)
[16:35:01] 	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance: Launch beta welcome dialog early - https://phabricator.wikimedia.org/T91265#1078447 (10Catrope) 3NEW
[16:35:13] 	 RoanKattouw: Dupe?
[16:35:36] 	 https://phabricator.wikimedia.org/T90454
[16:35:48] 	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance: Launch beta welcome dialog early - https://phabricator.wikimedia.org/T91265#1078458 (10Jdforrester-WMF)
[16:35:49] 	 10VisualEditor, 10VisualEditor-Performance: Load and display the welcome dialog straight after the toolbar, without waiting for the content area - https://phabricator.wikimedia.org/T90454#1078459 (10Jdforrester-WMF)
[16:35:56] 	 RoanKattouw: Do you want to nominate that for Q3?
[16:36:13] 	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Load and display the welcome dialog straight after the toolbar, without waiting for the content area - https://phabricator.wikimedia.org/T90454#1059169 (10Jdforrester-WMF)
[16:36:57] 	 Whoops sorry
[16:37:13] 	 Oh you've already nominated it, cool
[16:37:25] * James_F got bored waiting for an answer. :-)]
[16:37:46] 	 But it's not as high a priority as the 11 other tasks you've already got assigned to you. :-)
[16:42:39] 	 (03PS8) 10Mvolz: Add ability to set requesting User-Agent [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) 
[16:46:49] 	 (03PS9) 10Mvolz: Add ability to set requesting User-Agent [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) 
[16:47:41] 	 (03PS2) 10Mvolz: [WIP] Add mocha tests [services/citoid] - 10https://gerrit.wikimedia.org/r/193580 (https://phabricator.wikimedia.org/T91168) 
[16:50:47] 	 (03PS2) 10Krinkle: build: Add disconnect tolerance to karma config [oojs/ui] - 10https://gerrit.wikimedia.org/r/193507 (https://phabricator.wikimedia.org/T90673) (owner: 10Jforrester)
[16:51:23] 	 10VisualEditor: Editor scrolls to bottom after loading in Firefox - https://phabricator.wikimedia.org/T91266#1078495 (10Catrope)
[16:52:07] 	 (03CR) 10Krinkle: [C: 032] "There are upstream issues with this so this should not be necessary in the long run. However as a sort of automatic semi 'recheck' this mi" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193507 (https://phabricator.wikimedia.org/T90673) (owner: 10Jforrester)
[16:53:30] 	 Krinkle: Yeah. :-(
[16:53:54] 	 Krinkle: Worth doing for VE-core and MW-core karma too? Or just leave it?
[16:55:25] 	 (03CR) 10Krinkle: "It's not clear to me what bug or behaviour this is changing. Makes it hard to review. Is there a bug report or can you describe briefly wh" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191766 (owner: 10Mooeypoo)
[16:55:42] 	 James_F: Yes ve-core, not mw
[16:55:47] 	 OK.
[16:56:15] 	 James_F: It seems ci is an everlasting whack-a-mole
[16:56:20] 	 Yeah. :-(
[16:56:25] 	 Now stuck on https://phabricator.wikimedia.org/T90984
[16:56:37] 	 pending input from hashar as I don't know zuul internals well enough
[17:00:00] 	 (03CR) 10Krinkle: "I'll address issues other than 'static'. Will find solution there with upstream and look into our decision to use this despite it being ES" [oojs/core] - 10https://gerrit.wikimedia.org/r/192969 (owner: 10Jforrester)
[17:00:18] 	 Krinkle: Fun. Can https://gerrit.wikimedia.org/r/191063 just get deployed now?
[17:01:33] 	 (03PS1) 10Jforrester: build: Add disconnect tolerance to karma config [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193843 (https://phabricator.wikimedia.org/T90673) 
[17:03:50] 	 (03CR) 10Mvolz: "I'll get to this later, but I did want to mention that using grunt has a purpose, which is citoid is already using grunt to run linting, s" [services/citoid] - 10https://gerrit.wikimedia.org/r/193580 (https://phabricator.wikimedia.org/T91168) (owner: 10Mvolz)
[17:04:15] 	 10VisualEditor: Editor scrolls to bottom after loading in Firefox - https://phabricator.wikimedia.org/T91266#1078539 (10Jdforrester-WMF)
[17:04:16] 	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: Initiating VisualEditor via "Edit" button Firefox scrolls to bottom of page - https://phabricator.wikimedia.org/T90420#1078540 (10Jdforrester-WMF)
[17:04:25] 	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox, 5§ VisualEditor Q3 Blockers: Initiating VisualEditor via "Edit" button Firefox scrolls to bottom of page - https://phabricator.wikimedia.org/T90420#1078542 (10Jdforrester-WMF) p:5Triage>3High
[17:05:05] 	 (03Merged) 10jenkins-bot: build: Add disconnect tolerance to karma config [oojs/ui] - 10https://gerrit.wikimedia.org/r/193507 (https://phabricator.wikimedia.org/T90673) (owner: 10Jforrester)
[17:21:50] 	 10VisualEditor, 10Beta-Cluster, 10Wikimedia-Search: File search on beta labs returns results from production commons and beta commons. VE search results are in unexpected order also. - https://phabricator.wikimedia.org/T90650#1078611 (10greg) p:5Triage>3High
[17:21:52] 	 10VisualEditor, 10Beta-Cluster, 10Wikimedia-Search: File search on beta labs returns results from production commons and beta commons. VE search results are in unexpected order also. - https://phabricator.wikimedia.org/T90650#1064118 (10greg) p:5High>3Normal
[17:22:09] 	 (03CR) 10Mobrovac: [C: 032] "Gr8!" [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) (owner: 10Mvolz)
[17:33:09] 	 (03CR) 10Jforrester: [C: 031] Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[17:37:29] 	 (03CR) 10Mobrovac: "Still needs improvement." (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/193580 (https://phabricator.wikimedia.org/T91168) (owner: 10Mvolz)
[17:46:15] 	 (03CR) 10Mooeypoo: "There is no bug report because I was the one who spotted it a couple of hours after the previous patch was merged." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191766 (owner: 10Mooeypoo)
[17:47:21] 	 mooeypoo: https://gerrit.wikimedia.org/r/#/c/193843/ :-)
[17:58:09] 	 (03CR) 10Mobrovac: [C: 04-1] "The bindings where present in set #13, but seem to have vanished in the latest version (#15). What happened, @mvolz?" [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[18:08:16] 	 (03PS16) 10Mvolz: Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) 
[18:15:32] 	 RoanKattouw: hey, i missed stand-up, but i'm just reading your e-mail
[18:15:48] 	 mooeypoo: So I had moved the deploy instructions below the from scratch ones, but on second thought, I just deleted it.
[18:16:13] 	 ori: I already got an answer from David saying the src attribute isn't necessary in Chrome, so that should be a nice win
[18:16:44] 	 And Timo has already merged a few things, let me see
[18:17:44] 	 https://gerrit.wikimedia.org/r/193813 turned out to save quite a bit on that insane page James found with lots of tables
[18:18:00] 	 "Implement a way to nest toolbar groups without implementing nesting of toolbar groups"?
[18:18:35] 	 https://gerrit.wikimedia.org/r/193788 has already been merged and reduces those comparisons we talked about a little bit
[18:18:53] 	 I discovered setupSlugs() runs twice on setup but my WIP commit to fix that doesn't work, so that needs more work
[18:20:25] 	 https://gerrit.wikimedia.org/r/193026 is the load early stuff I'm working on, it needs some more work to figure out where things like error handling and CSS classes are gonna go since it's changing the init execution timeline, I need to pick TImo's brain about that when he's back
[18:21:01] 	 ori: Something I think you were working on but I don't think I ever saw code for is using iteration to replace getHash() in IndexValueStore
[18:21:05] 	 mvolz, okay so I need to reinstall from scratch? https://www.mediawiki.org/wiki/Citoid
[18:21:08] 	 what's the best way?
[18:21:18] 	 is it working? then no
[18:21:39] 	 mvolz, it is, but if it's not the right way then maybe I better?
[18:21:48] 	 there's nothing wrong with deploy except 1) it only works on 64 bit ubuntu and 2) is horribly outdated
[18:21:50] 	 or it doesn't matter?
[18:21:54] 	 but as long as you get pull it's okay
[18:21:56] 	 ori: Also Ed and Timo's toolbar changes landed today, so we now set up a basic toolbar while the editor is loading and slide it in using CSS transitions
[18:22:00] 	 mvolz, right, the outdated part is what i'm worried about
[18:22:31] 	 you can git pull all the citoid stuff
[18:22:34] 	 edsanders: Although I noticed that setupToolbar() seems to still be called from scratch when the editor is ready, we don't appear to be reusing the "fake" toolbar at all
[18:22:47] 	 mvolz, yeah in src
[18:23:05] 	 the only thing you can't do that with is zotero, which doesn't matter as much, and the translators, which matter a bit more, but still not all that much
[18:23:08] 	 mvolz, I can't really with the deploy itself, because I had to change the config files
[18:23:19] 	 ah
[18:23:27] 	 then, yeah. :/
[18:23:34] 	 but I can with the src folder, it's a submodule i think
[18:23:49] 	 yeah it is
[18:23:57] 	 well that's the most important bit to keep updated.
[18:23:59] 	 mvolz, i can also git stash -> pull -> stash apply in the deploy repo
[18:24:10] 	 it's annoying but will work
[18:24:21] 	 that part probably won't change much tbh
[18:24:25] 	 ok, I'll stay with deploy for now. TrevorP|Away will have to install from scratch
[18:24:35] 	 yeah I also run things from src anyways
[18:24:42] 	 the server and the translators
[18:24:42] 	 muahaha
[18:24:58] 	 mvolz: "deincluding"? https://www.mediawiki.org/w/index.php?title=Citoid&diff=0&oldid=1418356
[18:28:11] 	 I can offer no explanation, only an apology.
[18:29:03] 	 mvolz: :-D
[18:30:44] 	 "Implement a way to nest toolbar groups without implementing nesting of toolbar groups" - seriously, what?
[18:31:10] 	 Krenair: Because it's hard and we have neither the time nor the appetite.
[18:33:24] 	 mooeypoo: XMLHttpRequest cannot load http://citoid.wmflabs.org/api?search=http%3A%2F%2Fwww.bbc.com%2Fnews%2Fworld-us-canada-31688942&format=mediawiki. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://en.wikipedia.beta.wmflabs.org' is therefore not allowed access. The response had HTTP status code 502.
[18:35:24] 	 10VisualEditor, 10Collaboration-Team-Sprint-R-2015-03-11, 10Flow: R1. Spike: Add relevant MW features to VE on Flow - https://phabricator.wikimedia.org/T90760#1078920 (10matthiasmullie) @Mattflaschen If I understand it correctly, it's not so much the (links|media|templates) plugins that are too MW core speci...
[18:37:28] 	 10VisualEditor, 6Mobile-Web: Editor switcher styling regression - https://phabricator.wikimedia.org/T91283#1078925 (10Jdlrobson) 3NEW
[18:38:52] 	 10VisualEditor, 6Mobile-Web: Editor switcher styling regression - https://phabricator.wikimedia.org/T91283#1078943 (10Jdforrester-WMF) What should it look like? That's pretty much on-spec. for the MediaWiki theme that Design have asked for, but I might be missing something?
[18:40:04] 	 hi.
[18:40:52] 	 Hey MatmaRex.
[18:41:36] 	 10VisualEditor, 10VisualEditor-ContentEditable: Change how link annotations work (and fix link continuation rendering) - https://phabricator.wikimedia.org/T91285#1078952 (10dchan) 3NEW a:3dchan
[18:41:40] 	 10VisualEditor, 10Wikidata: VisualEditor does not work well on Wikidata:Project chat - https://phabricator.wikimedia.org/T91252#1078961 (10matmarex) As for signatures, there's a gadget available: https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js. No promises, but it was working last time...
[18:41:57] 	 (03CR) 10Mobrovac: [C: 032] Make zotero.js an object [services/citoid] - 10https://gerrit.wikimedia.org/r/192197 (https://phabricator.wikimedia.org/T78389) (owner: 10Mvolz)
[18:42:29] 	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: [Regression wmf4] Link continuation is broken - https://phabricator.wikimedia.org/T74108#1078966 (10dchan)
[18:42:30] 	 10VisualEditor, 10VisualEditor-ContentEditable: Change how link annotations work (and fix link continuation rendering) - https://phabricator.wikimedia.org/T91285#1078967 (10dchan)
[18:42:42] 	 10VisualEditor, 10VisualEditor-MediaWiki, 10Collaboration-Team-Sprint-R-2015-03-11, 10Flow: R1. Spike: Add relevant MW features to VE on Flow - https://phabricator.wikimedia.org/T90760#1078973 (10Krenair)
[18:43:11] 	 (03CR) 10Jforrester: "Needs rebase." [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 (owner: 10Mvolz)
[18:44:59] 	 mvolz: ^^^ :-(
[18:45:48] 	 10OOjs-UI: Make documentation on toolbars, tool groups, and tools - https://phabricator.wikimedia.org/T91195#1078986 (10matmarex) Note that there are some vague plans for a pretty major reworking of how toolbars work: {T74159}. Right now you can't have nested menus at all (there's only a rigid structure: toolbar...
[18:46:55] 	 mooeypoo, divec : A Firefox bug that you will definitely enjoy: https://bugzilla.mozilla.org/show_bug.cgi?id=1138419 .
[18:47:48] 	 aharoni: Whoops.
[18:48:27] 	 My favorite part is, of course:
[18:48:30] 	 "It looks to me like the previous behavior may have actually been incorrect, and now things are behaving as designed (if not as desired!)."
[18:48:36] 	 Yeah.
[18:48:39] * James_F sighs.
[18:48:43] 	 (03PS1) 10Gerrit Patch Uploader: Reuse variable profile instead of $.client.profile() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/193861 
[18:48:46] 	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/193861 (owner: 10Gerrit Patch Uploader)
[18:48:48] 	 Ah, BiDi, how you screw things up. :-)
[18:48:58] 	 10OOjs-UI, 5§ VisualEditor Q3 Blockers: Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget - https://phabricator.wikimedia.org/T89399#1078997 (10matmarex) Blocks {T64084}.
[18:52:40] 	 10VisualEditor, 6Mobile-Web: Editor switcher styling regression - https://phabricator.wikimedia.org/T91283#1079012 (10Jdlrobson) Icons are misaligned, tap areas are tiny, font is inconsistent with rest of the mobile experience Previously the highlight was a light blue - not sure if that is a regression or a pu...
[18:54:04] 	 so as ve.instances does not exist anymore is there new way of getting a reference to the surface or target?
[18:54:39] 	 10VisualEditor, 10VisualEditor-ContentEditable, 10Wikimedia-Hackathon-2015: Change how link annotations work (and fix link continuation rendering) - https://phabricator.wikimedia.org/T91285#1079018 (10dchan)
[18:58:12] 	 InezK, yes
[18:58:28] 	 what would it be
[18:58:29] 	 ve.init.target
[18:58:35] 	 hm, ok
[18:58:45] 	 ve.init.target.getSurface()
[18:58:47] 	 etc.
[18:58:57] 	 is it known how it is gonna behave in case of initializing multiple surface in the same document?
[18:59:03] 	 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid-Nowiki: Nowiki added around a ref tag with a ref name containing unbalanced quotation marks - https://phabricator.wikimedia.org/T91287#1079044 (10Whatamidoing-WMF) 3NEW
[18:59:11] 	 Not by me :)
[18:59:28] 	 RoanKattouw would know
[19:00:28] 	 (03PS16) 10Mvolz: Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[19:00:48] 	 (03PS3) 10Rits: T28462 changed print CSS for backlink arrows edited CSS according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193812 
[19:01:56] 	 aharoni, ha! oops
[19:04:12] 	 (03PS17) 10Mvolz: [WIP] Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 
[19:05:55] 	 (03CR) 10Mobrovac: [C: 032] [WIP] Convert scrape.js to Scraper.js [services/citoid] - 10https://gerrit.wikimedia.org/r/192702 (owner: 10Mvolz)
[19:06:33] 	 (03CR) 10Mobrovac: [C: 04-1] "needs a rebase now" [services/citoid] - 10https://gerrit.wikimedia.org/r/193134 (https://phabricator.wikimedia.org/T89757) (owner: 10Mvolz)
[19:10:25] 	 (03PS1) 10Mvolz: Revert "[WIP] Convert scrape.js to Scraper.js" [services/citoid] - 10https://gerrit.wikimedia.org/r/193868 
[19:10:27] 	 (03PS1) 10Kmenger: ProgressBar: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/193869 
[19:13:22] 	 (03PS1) 10Mobrovac: Revert "[WIP] Convert scrape.js to Scraper.js" [services/citoid] - 10https://gerrit.wikimedia.org/r/193873 
[19:14:09] 	 (03CR) 10jenkins-bot: [V: 04-1] ProgressBar: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/193869 (owner: 10Kmenger)
[19:14:15] 	 (03Abandoned) 10Mobrovac: Revert "[WIP] Convert scrape.js to Scraper.js" [services/citoid] - 10https://gerrit.wikimedia.org/r/193873 (owner: 10Mobrovac)
[19:14:33] 	 InezK: there are multiple surfaces in the VE standalone demo, test out there?
[19:15:22] 	 (03CR) 10Esanders: "Needs some rebasing work as targets are OO.ui.Elements now, and target init appends target.$element to #container." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) (owner: 10Alex Monk)
[19:19:02] 	 (03Abandoned) 10Mvolz: Revert "[WIP] Convert scrape.js to Scraper.js" [services/citoid] - 10https://gerrit.wikimedia.org/r/193868 (owner: 10Mvolz)
[19:21:30] 	 (03PS2) 10Kmenger: ProgressBar: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/193869 
[19:38:38] 	 10VisualEditor: Clicking on the link from the new preview interface link dialogue opens a "404-page not found"page instead of opening the article - https://phabricator.wikimedia.org/T91291#1079190 (10Ryasmeen) 3NEW
[19:38:50] 	 10VisualEditor: Clicking on the link from the new preview interface link dialogue opens a "404-page not found"page instead of opening the article - https://phabricator.wikimedia.org/T91291#1079199 (10Ryasmeen) p:5Triage>3High
[19:41:00] 	 (03PS1) 10Mvolz: Fix callback in CitoidService.prototype.scrape [services/citoid] - 10https://gerrit.wikimedia.org/r/193877 
[19:43:13] 	 InezK: There's a ve.init.target.surfaces array, and AIUI ve.init.target.getSurface() is the currently active one
[19:43:19] 	 10VisualEditor, 6Collaboration-Team, 10Flow: Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1079213 (10DannyH)
[19:43:35] 	 oh, I see, thank you!
[19:44:58] 	 (03CR) 10Mobrovac: [C: 032] Fix callback in CitoidService.prototype.scrape [services/citoid] - 10https://gerrit.wikimedia.org/r/193877 (owner: 10Mvolz)
[19:45:15] 	 (03Merged) 10jenkins-bot: Fix callback in CitoidService.prototype.scrape [services/citoid] - 10https://gerrit.wikimedia.org/r/193877 (owner: 10Mvolz)
[19:50:23] 	 (03CR) 10Bartosz Dziewoński: [C: 032] Use the correct color for gray buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/193790 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna)
[19:51:01] 	 (03CR) 10jenkins-bot: [V: 04-1] Use the correct color for gray buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/193790 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna)
[19:51:19] 	 (03PS1) 10Kmenger: CheckboxInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/193880 
[19:52:02] 	 (03PS2) 10Bartosz Dziewoński: Use the correct color for gray buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/193790 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna)
[19:52:09] 	 (03CR) 10Bartosz Dziewoński: [C: 032] Use the correct color for gray buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/193790 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna)
[19:54:20] 	 (03Merged) 10jenkins-bot: Use the correct color for gray buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/193790 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna)
[19:57:45] 	 (03CR) 10Bartosz Dziewoński: "What about icon colors defined in images.json?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193793 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna)
[19:58:35] 	 (03CR) 10Jforrester: [C: 04-1] Use only two variables each for each semantic color (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/193793 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna)
[19:58:44] 	 dude, this is amazing: http://f.cl.ly/items/3u1Q1J1S062H2l220h3C/Screen%20Shot%202015-03-02%20at%2011.57.54%20AM.png
[19:59:39] 	 Google Docs tried to render an avatar for this "sharer" whose name is apparently missing and thus NULL, and the display name is apparently also missing and thus undefined?
[19:59:46] 	 :-D
[19:59:49] 	 ( randomCrap ).toString
[20:00:29] 	 TrevorParscal: hey, we had a bug in the OOUI icon rasterizing for a while where the PNG would contain the SVG source code, rendered neatly in monospace font :D
[20:01:33] 	 TrevorParscal: https://code.google.com/p/chromium/issues/detail?id=463119
[20:01:50] 	 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1079340 (10violetto) **constructive, destructive, progressive buttons - Which styles do we want to use?**  Like @Nirzar mentioned, ButtonWidget (progressiv...
[20:02:08] 	 10VisualEditor: [Regression pre-wmf20] Red links are appearing as existing link in VE - https://phabricator.wikimedia.org/T91299#1079344 (10Ryasmeen) 3NEW
[20:02:17] 	 10VisualEditor: [Regression pre-wmf20] Red links are appearing as existing link in VE - https://phabricator.wikimedia.org/T91299#1079352 (10Ryasmeen) p:5Triage>3High
[20:06:46] 	 (03PS1) 10Kmenger: FieldLayout: Fix display of bulleted list [oojs/ui] - 10https://gerrit.wikimedia.org/r/193885 
[20:07:45] 	 kirstenMA: Fun. :-(
[20:08:55] 	 (03CR) 10Jforrester: [C: 032] CheckboxInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/193880 (owner: 10Kmenger)
[20:09:50] 	 James_F: Hope that was the best way to deal with that? I'll check my other lists... I think I've used a few.
[20:10:02] 	 ryasmeen: Dear God when is beta labs ever going to stop being haunted
[20:10:05] 	 kirstenMA: Yeah, eurgh. Jsduck sucks.
[20:10:11] 	 RoanKattouw: When we shut it down?
[20:10:14] 	 ryasmeen: https://phabricator.wikimedia.org/T91299#1079344 doesn't happen on my laptop, only on beta
[20:10:23] 	 Hmm maybe it's an MW core regression, let me check
[20:10:29] 	 RoanKattouw: oh thats strange!
[20:10:35] 	 (03Merged) 10jenkins-bot: CheckboxInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/193880 (owner: 10Kmenger)
[20:12:19] 	 Oh, ugh, maybe we're getting parser cache misses on beta?
[20:12:23] 	 That would be /very/ strange
[20:13:05] 	 (03PS3) 10Trevor Parscal: Add insert/edit modes to FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) 
[20:13:07] 	 Yup, chronic parser cache misses on beta
[20:13:09] 	 wtf
[20:13:34] 	 Well to be fair that does expose a bug in my code
[20:13:39] 	 All the other lists look great, btw. Not sure what was up with FieldLayout.
[20:14:51] 	 kirstenMA: what's your `jsduck --version`? some distros used to have jsduck 4 until recently, or something. doc.wm.o uses jsduck 5.
[20:15:20] 	 I'm JSDuck 5.3.4 (Ruby 2.0.0)
[20:15:35] 	 huh.
[20:15:49] 	 (03PS1) 10Catrope: Don't claim all links exist when ParserCache misses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193886 (https://phabricator.wikimedia.org/T91299) 
[20:16:02] 	 It's a mystery :)
[20:16:31] 	 it works for me locally, too. magic indeed
[20:16:57] 	 10VisualEditor, 5Patch-For-Review: [Regression pre-wmf20] Red links are appearing as existing link in VE - https://phabricator.wikimedia.org/T91299#1079422 (10Catrope) This was caused by the link cache population code not handling ParserCache misses correctly. My patch addresses this, but someone should also f...
[20:22:51] 	 (03CR) 10Jforrester: [C: 031] "LGTM from a product POV." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal)
[20:22:59] 	 (03CR) 10jenkins-bot: [V: 04-1] Don't claim all links exist when ParserCache misses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193886 (https://phabricator.wikimedia.org/T91299) (owner: 10Catrope)
[20:24:47] 	 (03CR) 10Jforrester: [C: 032] Don't claim all links exist when ParserCache misses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193886 (https://phabricator.wikimedia.org/T91299) (owner: 10Catrope)
[20:25:56] 	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20): Don't show redlinks as existing links if MediaWiki didn't tell us one way or the other - https://phabricator.wikimedia.org/T91299#1079495 (10Jdforrester-WMF) 5Open>3Resolved a:3Catrope
[20:25:59] 	 (03PS4) 10Trevor Parscal: Add insert/edit modes to FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) 
[20:26:05] 	 (03CR) 10Trevor Parscal: Add insert/edit modes to FragmentInspector (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal)
[20:27:32] 	 (03Merged) 10jenkins-bot: Don't claim all links exist when ParserCache misses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193886 (https://phabricator.wikimedia.org/T91299) (owner: 10Catrope)
[20:27:51] 	 10VisualEditor: [Regression pre-wmf20]Link inspector opening in wrong position - https://phabricator.wikimedia.org/T91307#1079509 (10Ryasmeen) 3NEW
[20:28:19] 	 RoanKattouw: More on link inspector ^^
[20:28:28] 	 TrevorP|Away: You get this one: https://phabricator.wikimedia.org/T91307#1079509
[20:28:40] 	 TrevorP|Away: Since your context rewrite just landed :)
[20:31:15] 	 (03CR) 10Brion VIBBER: [C: 032] "lgtm" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193812 (owner: 10Rits)
[20:31:42] 	 (03CR) 10jenkins-bot: [V: 04-1] Add insert/edit modes to FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal)
[20:31:48] 	 (03CR) 10Catrope: [C: 032] Add insert/edit modes to FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal)
[20:31:56] 	 Ahm
[20:32:07] 	 (03PS3) 10Krinkle: Make ce.BranchNode#updateTagName do what its documentation says [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193824 (owner: 10Catrope)
[20:32:08] 	 Oh it's just a karma timeout
[20:32:14] 	 So it doesn't make me look that bad :)
[20:33:42] 	 (03CR) 10Krinkle: "Hm.. so what is actually the main reason for having a separate target loader? What immediate solved problem or gained ability does this ge" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope)
[20:33:53] 	 (03Merged) 10jenkins-bot: Add insert/edit modes to FragmentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193293 (https://phabricator.wikimedia.org/T70590) (owner: 10Trevor Parscal)
[20:34:24] 	 (03Merged) 10jenkins-bot: T28462 changed print CSS for backlink arrows edited CSS according to coding conventions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/193812 (owner: 10Rits)
[20:37:01] 	 (03CR) 10Catrope: "This is part of why I need to write a commit summary :) . This will close T53569 and T90372. When the user clicks edit, we want to immedia" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (owner: 10Catrope)
[20:46:34] 	 (03PS1) 10Kmenger: RadioInputWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/193895 
[20:48:12] 	 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you ... - https://phabricator.wikimedia.org/T70590#1079602
[20:48:19] 	 (03CR) 10jenkins-bot: [V: 04-1] Make ce.BranchNode#updateTagName do what its documentation says [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193824 (owner: 10Catrope)
[20:49:20] 	 RoanKattouw: you gotta minute to talk to James and me on hangouts?
[20:53:18] 	 TrevorParscal: Ahm sure
[20:53:43] 	 Lemme grab my headphones
[20:53:49] 	 RoanKattouw: Hm.. when does e.g. teardown of tablecell get run?
[20:55:18] 	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Distorted UI of Language Inspector/Special Character appears while trying to open them when the link inspector is already open in CE - https://phabricator.wikimedia.org/T71202#1079628 (10Etonkovidova) Checked betalabs  - all is displayed correctly.
[20:55:26] 	 hey MatmaRex I got the accessibility simulation going
[20:55:34] 	 and filed a bug against Chromium in the process :p
[20:55:54] 	 haha :D
[20:55:57] 	 TrevorParscal: Is there a way to force OOUI widgets to use Mobile styles on a desktop display?
[20:56:04] 	 RoanKattouw: ?
[20:56:18] 	 https://code.google.com/p/chromium/issues/detail?id=463119
[20:56:33] 	 werdna: By design, shouldn't there no longer be such a thing as "mobile styles"? The whole point is to have one set of designs…
[20:56:47] 	 not quite
[20:56:55] * James_F sighs.
[20:56:58] 	 for example, quiet buttons appear differently on mobile and desktop
[20:57:05] 	 Then why the hell have we said that they'd be the same for so long?
[20:57:11] 	 That seems like a completely broken design.
[20:57:21] 	 because on desktop they get their colour on hover, and on mobile they get their colour all the time because there is no such thing as hovering
[20:57:25] 	 This has been the sole motivating factor.
[20:57:39] 	 Argh.
[20:57:48] 	 This is why I said that the design was terrible and needed improving.
[20:58:06] 	 maybe you should apply for a designer job :p
[20:58:47] 	 Or just start rejecting bad designs? Oh, wait… :-)
[20:58:58] 	 anyways, I think there are some small and justified (if not justifiable) differences between desktop and mobile
[20:59:15] 	 but I don't know – I'm just doing what I'm told in this case, May/Jared asked for a desktop/mobile switch so I'm giving it to them :p
[20:59:59] 	 kind of proud of this accessibility switch – I don't think it's ever been done before
[20:59:59] 	 http://living-style-guide.wmflabs.org/wiki/OOjs_UI
[21:00:06] 	 will try to clean it up and libraryize it
[21:00:15] 	 eh
[21:00:26] 	 werdna: It's a really nice touch.
[21:00:37] 	 werdna: lol, that is pretty neat
[21:01:02] 	 I realise that simulations have been done before, but I couldn't find anything that would let you change a whole site / element to different simulations
[21:01:56] 	 anyways, TrevorParscal am I right that there are some separate mobile + desktop styles?
[21:02:11] 	 werdna: No, there aren't. That's kind of the problem.
[21:02:38] 	 (03PS1) 10Krinkle: Fix invalid use of border shorthand syntax [oojs/ui] - 10https://gerrit.wikimedia.org/r/193901 
[21:03:02] 	 10VisualEditor, 5WMF-deploy-2015-03-04_(1.25wmf20): [Regression pre-wmf20] Reference and Media caption surfaces have broken layout - https://phabricator.wikimedia.org/T91145#1079664 (10Etonkovidova) Verified in betalabs.
[21:03:38] 	 James_F: the problem with what?
[21:04:18] 	 werdna: With people demanding that the buttons look different in mobile vs. desktop, when the entire point of OOjs UI and the MediaWiki theme is that there isn't a distinction.
[21:04:37] 	 werdna: I think there have been some times where the designers say "it will look this way" and then someone says "yeah, that doesn't work well on mobile" and they say "um, we'll just make it different for mobile then"
[21:04:50] 	 Rather than "you're right, we'll fix the design".
[21:05:03] 	 Not just for the theme, but also for e.g. tool layout in forms.
[21:05:19] 	 Which violates completely the concept of mobile-desktop-together. :-)
[21:05:30] 	 I don't really want to get drawn into an argument about the designs themselves, because I'm outrageously unqualified to do so.
[21:05:40] 	 Fair.
[21:06:02] 	 I just want to ask the technical question – are widgets styled differently on mobile and desktop, and if so, is it possible to 'force' the mobile styles?
[21:06:03] 	 Though I'd say that your HCI experience is much more significant, extensive and valuable than your comment suggests. :-)
[21:06:11] 	 werdna: The answers are "no
[21:06:14] 	 " and "no".
[21:06:25] 	 Currently. Theoretically this could change, of course.
[21:06:39] 	 well, I don't want to get into the argument because I think the various positions are already well represented :p
[21:06:52] 	 Don't Make Me Think ;-)
[21:06:54] 	 (03CR) 10Jforrester: [C: 032] Fix invalid use of border shorthand syntax [oojs/ui] - 10https://gerrit.wikimedia.org/r/193901 (owner: 10Krinkle)
[21:06:57] 	 :-)
[21:07:08] 	 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1079695 (10matmarex)
[21:08:38] 	 10VisualEditor: After adding a Cite web , when the context menu appears for the first time, clicking on the URL tries to leave the VE and open the URL in the same page instead of opening it in a new tab - https://phabricator.wikimedia.org/T91314#1079701 (10Ryasmeen) 3NEW
[21:11:08] 	 James_F: according to Jared, "The only difference is that we skip the hover states on mobile [i.e. use hover states as normal states], there isn't a different design per se."
[21:11:51] 	 werdna: So on mobile devices that support hover (no, really, there are some) it should still work.
[21:11:52] 	 ?
[21:12:09] 	 werdna: In that case, *:hover { none }; or whatever would do it?
[21:12:26] 	 not quite
[21:12:31] 	 (03PS5) 10Jforrester: [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[21:12:36] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[21:12:50] 	 *:hover, *.mobile { /* hover styles */ }
[21:12:52] 	 more like
[21:12:57] 	 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1079758 (10matmarex) So the idea is that: * When there is too little space, we should tighten the whitespace a bit (https://gerrit....
[21:12:58] 	 (03Merged) 10jenkins-bot: Fix invalid use of border shorthand syntax [oojs/ui] - 10https://gerrit.wikimedia.org/r/193901 (owner: 10Krinkle)
[21:13:09] 	 Why would there be *.mobile?
[21:13:37] 	 fine, .my-widget @media mobile {
[21:13:42] 	 Sure.
[21:13:51] 	 But I still don't see a need for a mobile class.
[21:14:11] 	 If all it is is the observation that "hover doesn't work here", we can just have a switch that disables hover states in the browser.
[21:14:12] 	 it was pseudocode, not actual implementation
[21:14:20] 	 (03Restored) 10Bartosz Dziewoński: [WIP] Scrollbar squishing [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński)
[21:14:31] 	 Or, more usefully, you can actually disable hover states manually when you test using the browser tools.
[21:14:41] 	 (03PS2) 10Bartosz Dziewoński: Tighten toolbar whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) 
[21:14:44] 	 (03CR) 10jenkins-bot: [V: 04-1] Tighten toolbar whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) (owner: 10Bartosz Dziewoński)
[21:14:49] 	 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1079780 (10Jaredzimmerman-WMF)
[21:15:29] 	 10OOjs-UI: Toolbars are messed up, especially in MediaWiki theme - https://phabricator.wikimedia.org/T91135#1079801 (10matmarex) a:5Esanders>3matmarex
[21:15:35] 	 10OOjs-UI: Toolbars are messed up, especially in MediaWiki theme - https://phabricator.wikimedia.org/T91135#1074892 (10matmarex) p:5Triage>3High
[21:15:55] 	 I'm possibly missing something. :-)
[21:16:14] * werdna shrugs
[21:16:21] 	 I'll let that get hashed out between Prateek, May and your team.
[21:16:35] 	 If there are different mobile styles, I need to know how to trigger them. That's all.
[21:16:45] 	 Sure. But I'd feel bad if you spent ages building a tool to try to disable hover effects.
[21:17:58] 	 nod, well, as far as I know the design is to display hover states as the initial state for touch-supporting devices (including, for example, devices with both touch and mice)
[21:18:43] 	 so if I can find a way to simulate those devices to illustrate the design, then that would meet the objective I'm given.
[21:19:01] 	 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1079827 (10Jaredzimmerman-WMF) @KHammerstein & @nirzar did you have a expanded version and compact version that we could use to sho...
[21:27:14] 	 10VisualEditor, 10VisualEditor-Links, 5§ VisualEditor Q3 Blockers: Clicking on the link from the new preview interface link dialogue opens a "404-page not found"page instead of opening the article - https://phabricator.wikimedia.org/T91291#1079852 (10Jdforrester-WMF) a:3TrevorParscal
[21:28:18] 	 (03PS1) 10Catrope: Fix transfer of reference contents from removed reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193956 
[21:28:41] 	 James_F: Urgent fix for compat with today's Parsoid deployment, needs SWAT today ---^^
[21:28:50] 	 RoanKattouw: Thanks. Will get it done.
[21:29:07] 	 We thought we had this all tied up and of course I find this bug with 2 minutes of testing after deploying :|
[21:29:36] 	 James_F: Thanks. I will probably not be awake by SWAT time
[21:29:43] * James_F imagined not.
[21:29:43] 	 Having been up since 4:50am
[21:31:01] 	 RoanKattouw: Re: table teardown, when does that happen? Do we transform data cells into heading cells
[21:31:02] 	 ?
[21:31:19] 	 Krinkle: What code are you looking at exactly?
[21:31:29] 	 RoanKattouw: The teardown handler you added for table cell node
[21:31:33] 	 I put the data->heading thing in teardown temporarily, and then the next commit moved it to onAttributeChange
[21:31:34] 	 I'm trying to reproduce it
[21:31:43] 	 And I hope I remembered to remove the teardown handler?
[21:32:08] 	 We process a transaction changing the 'style' attribute on the TableCellNode
[21:32:48] 	 Before today, that would invoke teardown, which didn't remove the old class but didn't need to because updateTagName() would wipe it out, then invoke setup which set the new class
[21:33:04] 	 After my first commit, uTN preserves classes so I needed to add a teardown handler which removed the class
[21:33:10] 	 RoanKattouw: what are you doing back in NL?
[21:33:26] 	 Then in my next commit, I moved this stuff into the constructor and instead have the class switch be handled by onAttributeChange
[21:33:35] 	 werdna: My grandma turns 80 next weekend
[21:33:41] 	 aha
[21:33:45] 	 gefeliciteerd! :)
[21:33:51] 	 So I'm here for a slightly earlier version of my traditional March/April trip :)
[21:33:53] 	 Thanks :)
[21:33:55] 	 Dankejwel
[21:34:13] 	 why March/April? I don't suppose Koningsdag is your thing
[21:34:30] 	 Two birthdays in the family a week apart
[21:34:37] 	 fair enough
[21:34:41] 	 (03PS1) 10Bartosz Dziewoński: Restore previous toolbar items margins and padding [oojs/ui] - 10https://gerrit.wikimedia.org/r/193957 (https://phabricator.wikimedia.org/T91135) 
[21:34:45] 	 Although I suppose I'm taking two trips to the East Coast around that time this year instead
[21:34:57] 	 So that wouldn't have happened anyway
[21:35:31] 	 what's on the east coast?
[21:36:05] 	 Boston and Montreal
[21:36:09] 	 LibrePlanet and PyCon, respectively
[21:36:12] 	 (03PS7) 10Bartosz Dziewoński: Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) 
[21:36:23] 	 (03CR) 10Bartosz Dziewoński: "Rebased." [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński)
[21:36:24] 	 RoanKattouw: Hm.. I'm not not sure how to make it trigger teardown for a table cell nod
[21:36:31] 	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/193956/1/modules/ve-mw/dm/nodes/ve.dm.MWReferenceNode.js
[21:36:45] 	 Krinkle: Select a table cell, use dropdown in toolbar to switch between data cell and header cell
[21:37:19] 	 Although in my latest commit (I forget if you merged it or not) the teardown handler shouldn't be doing anything meaningful, the class is changed in the attributeChange handler instead
[21:37:20] 	 (03CR) 10Trevor Parscal: [C: 032] Fix transfer of reference contents from removed reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193956 (owner: 10Catrope)
[21:37:37] 	 (03PS1) 10Jforrester: Fix transfer of reference contents from removed reference [extensions/VisualEditor] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/193958 
[21:37:45] 	 (03PS1) 10Jforrester: Fix transfer of reference contents from removed reference [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193959 
[21:38:01] 	 What is "the new preview interface link dialogue"?
[21:38:23] 	 Krenair: Probably the result of the latest context refactor?
[21:38:25] 	 It's in master already
[21:38:58] * Krenair `git submodule update`s
[21:39:05] 	 oh, I see
[21:39:24] 	 (03Merged) 10jenkins-bot: Fix transfer of reference contents from removed reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193956 (owner: 10Catrope)
[21:39:49] 	 Krenair: Can you get https://gerrit.wikimedia.org/r/#/q/Ib87491b6fa6a77d62384158f8e8f7dcc2a36c23a,n,z built into a pair of MW-core patches?
[21:40:19] 	 sure
[21:40:26] 	 Thanks. :-)
[21:42:18] 	 (03CR) 10Alex Monk: [C: 032] Fix transfer of reference contents from removed reference [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193959 (owner: 10Jforrester)
[21:42:23] 	 (03CR) 10Alex Monk: [C: 032] Fix transfer of reference contents from removed reference [extensions/VisualEditor] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/193958 (owner: 10Jforrester)
[21:43:27] 	 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1079910 (10matmarex) From task summary:  > all the buttons except those displayed on the last line are lacking a background  This a...
[21:43:44] 	 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1079911 (10matmarex)
[21:46:33] 	 RoanKattouw: I tried that but couldn't find how
[21:46:36] 	 RoanKattouw: See it now.
[21:46:41] 	 OK
[21:46:44] 	 RoanKattouw: It's in the dropdown that normally manifests headings/paragraphs
[21:46:46] 	 interesting
[21:46:49] 	 Yeah
[21:46:55] 	 I was looking in the table menu
[21:46:56] 	 (03PS3) 10Bartosz Dziewoński: [WIP] Tighten toolbar whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) 
[21:47:01] 	 I was messing with that one and at one point saw a cell with both classes
[21:47:11] 	 So it was a  not a  but had the background of a 
[21:47:31] 	 TrevorParscal: that toolbar stack is for you ^. i'd appreciate comments on the WIP too (need to add event debouncing and implement for MediaWiki theme)
[21:47:33] 	 Part of me feels like it would be better to style td.ve-ce-tableCell and th.ve-ce-tableCell instead of .ve-ce-tableCell-{data,header}
[21:47:36] 	 But that's for another time
[21:48:48] 	 (03Merged) 10jenkins-bot: Fix transfer of reference contents from removed reference [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/193959 (owner: 10Jforrester)
[21:49:17] 	 (03Merged) 10jenkins-bot: Fix transfer of reference contents from removed reference [extensions/VisualEditor] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/193958 (owner: 10Jforrester)
[21:51:17] 	 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1079949 (10matmarex) >>! In T52227#1079827, @Jaredzimmerman-WMF wrote: > @KHammerstein & @nirzar did you have a expanded version an...
[21:52:29] 	 RoanKattouw: got it
[21:55:39] 	 RoanKattouw: mooeypoo ran into a nasty thing in GeneratedContentNodes
[21:55:48] 	 Ugh
[21:55:53] 	 What is it this time with GCN
[21:56:00] 	 I ran into GCN problems today to
[21:56:46] 	 RoanKattouw: because render() does this.$element = $newElements
[21:57:30] 	 That's the exact problem I ran into
[21:57:32] 	 if you pass this.$element to a mixin (such as IconElement, so it doesn't create a new span, but just applies the icon classes to this.$element directly)
[21:57:44] 	 then this.$icon -> old this.$element
[21:57:45] 	 ARGH
[21:57:47] 	 Right
[21:58:02] 	 (It also "eats" away whatever classes you applied on your original element)
[21:58:04] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Tighten toolbar whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) (owner: 10Bartosz Dziewoński)
[21:58:13] 	 Yeah that was my problem, the class eating
[21:58:15] 	 so, you can run this.setIconElement( this.$element )
[21:58:16] 	 so doing this.$element.addClass( 'foo' ) in the constructor is meaningless.
[21:58:20] 	 and that is fine
[21:58:23] 	 James_F, https://gerrit.wikimedia.org/r/#/c/193964/ and https://gerrit.wikimedia.org/r/#/c/193965/
[21:58:24] 	 but you have to remember to do that
[21:58:44] 	 The whole this.$element switch trick was added when we unwrapped GCNs
[21:58:50] 	 TrevorParscal: Well here's an evil suggestion
[21:59:01] 	 this.$element isn't a reference to a node, it's a jQuery collection
[21:59:16] 	 this.$icon is the same collection by reference
[21:59:39] 	 I'm not aware of neat clean jQuery methods for this, but you could remove all nodes from the collection and then add new ones
[21:59:53] 	 i thought collections were immutable
[22:00:01] 	 Ahm... I guess they might be
[22:00:01] 	 Krenair: Added to the Deployment calendar with your name against them.
[22:00:02] 	 10VisualEditor: Frozen link inspector and "Uncaught Error..." when a link is repeatedly inserted - https://phabricator.wikimedia.org/T91318#1079977 (10Etonkovidova) 3NEW
[22:00:09] 	 You might be right there
[22:00:11] 	 i mean, probably not ACTUALLY, but they are meant to be
[22:00:28] 	 Yeah I'm sure they're array-like enough you could mutate them
[22:00:35] 	 But it's probably a bad idea and not well-supported
[22:00:41] 	 how about we introduce meta-jquery, which allows you to create a mutable collection :)
[22:00:41] 	 My name? Ok...
[22:00:58] 	 probably a bad idea, but... yeahg
[22:01:03] 	 And the whole notion of abusing arrays this way is very much black magic anyway
[22:01:18] 	 So we possibly should not be unwrapping GCNs
[22:01:26] 	 But my question is... why the hell do you have an Iconed GCN?
[22:01:31] 	 That seems really weird
[22:02:17] 	 As for applying classes, sure, maybe
[22:02:23] 	 But GCNs are really volatile and should be treated as such
[22:02:36] 	 A GCN is a pack of dynamite
[22:02:56] 	 But the dynamite in a box, do stuff with the box, and never look at the dynamite
[22:03:19] 	 I'm not sure whether to compare it with nitroglycerin or Schrödinger's Cat but it's a bit like both
[22:03:32] 	 When you touch it bad things happen, because it changes on you when you're not looking
[22:06:43] 	 (03PS1) 10Trevor Parscal: Make annotation inspector getMode method trim [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193971 
[22:07:24] 	 (03PS2) 10Catrope: Make annotation inspector getMode method trim [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193971 (owner: 10Trevor Parscal)
[22:08:20] 	 (03CR) 10Krinkle: [C: 032] Make ce.BranchNode#updateTagName do what its documentation says [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193824 (owner: 10Catrope)
[22:08:26] 	 (03PS4) 10Krinkle: Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 (owner: 10Catrope)
[22:09:03] 	 (03CR) 10Catrope: [C: 04-1] Make annotation inspector getMode method trim (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193971 (owner: 10Trevor Parscal)
[22:10:27] 	 (03Merged) 10jenkins-bot: Make ce.BranchNode#updateTagName do what its documentation says [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193824 (owner: 10Catrope)
[22:16:37] 	 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1080080 (10kaldari) Had a good meeting with May and Nirzar. Here are some notes from the meeting: * The styles for constructive, destructive, and progressi...
[22:16:54] 	 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1080081 (10kaldari)
[22:17:13] 	 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1012026 (10kaldari)
[22:17:25] 	 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1012026 (10kaldari)
[22:17:33] 	 RoanKattouw: OK. I;m reading the comment atop updateTagName. The somewhat arbitrary subset of things it takes care of without needing setup is documetned. So that's good.
[22:18:35] 	 RoanKattouw: Last bit regarding https://gerrit.wikimedia.org/r/#/c/193813 , should we document briefly inline in relevant classes why it's duplicated in onSetup? Right now there's a comment in onSetup, but not in the constructor. I fear it might get out of sync or not be obvious what parts should be in both.
[22:19:04] 	 Maybe around constructor's "// DOM changes "  document like "Keep onSetup in sync with this section"
[22:19:38] 	 Or even moved into a non-standard method introduced there and called from both that we'd slowly move towards (e.g. initialize)
[22:20:06] 	 10VisualEditor: Double clicking at the end of a line which only contains a link, opens the context menu in the middle of the line instead of opening right below the link - https://phabricator.wikimedia.org/T91321#1080103 (10Ryasmeen)
[22:20:40] 	 Krinkle: Good point
[22:20:50] 	 I'll do that tomorrow, I'm fading now
[22:21:01] 	 Also looking at mode.isWrapped and conditionally adding the class
[22:21:19] 	 Which seems a bit odd. I;m sure there's a reason
[22:22:27] 	 (03CR) 10Krinkle: [C: 04-1] "Almost ready :) Two minor questions." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 (owner: 10Catrope)
[22:22:36] 	 I've commented so you'll see it tomorrow
[22:28:59] 	 (03PS4) 10Krinkle: Ask for whole revision when checking for existing TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/191766 (owner: 10Mooeypoo)
[22:31:30] 	 Krinkle, sorry if that was confusing. If you want more context, this was the previous commit that the above is fixing up https://gerrit.wikimedia.org/r/#/c/191491/
[22:33:58] 	 10VisualEditor, 10Collaboration-Team-Sprint-R-2015-03-11, 10Flow: Sometimes VE toolbar gets stuck in upper left until reflow/resize window - https://phabricator.wikimedia.org/T90762#1080168 (10DannyH) a:3Mattflaschen
[22:35:40] 	 mooeypoo: Got it
[22:35:53] 	 mooeypoo: James_F|Away: Is it a known issue that loading action=edit causes the button to flash grey and then white?
[22:36:04] 	 I can file a bug. I just captured it in a 4sec video
[22:36:15] 	 the Manage TD button
[22:36:30] 	 Krinkle, it isn't known
[22:36:34] 	 good point. I just tried it out
[22:36:38] 	 it flashed really quickly
[22:36:39] 	 hm
[22:37:13] 	 (03PS1) 10Mooeypoo: Add an icon to hidden templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) 
[22:39:04] 	 10OOjs-UI, 10TemplateData: Button widget flashes grey before settling on white - https://phabricator.wikimedia.org/T91324#1080209 (10Krinkle) 3NEW
[22:39:31] 	 mooeypoo: What does ([\s\S]*?) match?
[22:39:36] 	 Is it different from .* ?
[22:39:55] 	 new lines?
[22:40:08] 	 Maybe //i would suffice
[22:40:14] 	 spaces, I think? let me verify
[22:40:36] 	 well, I used the same regex that I later use to fetch the templatedata
[22:40:38] 	 It's matchnig both space and non-space (\s and \S)
[22:40:42] 	 Yeah
[22:40:55] 	 RoanKattouw, so we need a way to be able to log save failure types from both WikiEditor and VE. But they currently use different error code systems
[22:41:16] 	 VE apparently does some weird things with detecting what extensions some errors have come from
[22:41:18] 	 but you're right, in this case only  is probably enough, especially since the extension won't let the user save an empty  tag
[22:41:20] 	 "JavaScript and VBScript do not have an option to make the dot match line break characters. In those languages, you can use a character class such as [\s\S] to match any character. "
[22:41:32] 	 and does not support anything close to the full extent of the editpage status constants
[22:41:37] 	 – regular-expressions.info
[22:42:09] 	 mooeypoo: Of course it does not cover 
,  and