[00:00:36] (03CR) 10Esanders: [C: 031] "+1 for the bits Trevor wrote (onInspectorClosing)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194227 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [00:01:52] James_F, that's evil link path stuff [00:02:50] (03CR) 10Esanders: [C: 04-1] Only store selections which yield a valid context position [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194227 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [00:03:49] (03PS6) 10Esanders: Only store selections which yield a valid context position [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194227 (https://phabricator.wikimedia.org/T91307) [00:04:16] (03CR) 10Esanders: [C: 031] "Missed a line in PS5. Good now." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194227 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [00:05:33] (03CR) 10Trevor Parscal: [C: 032] Only store selections which yield a valid context position [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194227 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [00:07:45] (03Merged) 10jenkins-bot: Only store selections which yield a valid context position [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194227 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [00:17:44] James_F: Argh. Turns out cmd+shift+6 is hijacked by CloudApp for Mac since the latest update. [00:17:49] VE didn't get it. [00:18:00] Iv'e disabled that app for now but.. annoying. [00:18:19] (03PS1) 10Kmenger: TextInputWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/194239 [00:22:16] Krinkle: Helpful. [00:23:16] James_F: after some refactoring to support 800+ wikis we are now getting ready to compile the list of wikis to enable in restbase for the first round. We don't have private wiki support yet, so special wikis are out. Any preferences? [00:23:32] all wikipedias? [00:23:43] gwicke: All Wikipedias would be a good start, yeah. [00:23:46] (03PS1) 10Esanders: Fix desktop context positioning (again) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194240 (https://phabricator.wikimedia.org/T91307) [00:24:07] edsanders: Grumpy? :-) [00:24:08] James_F: ok, also easy to compile with a regexp [00:24:16] gwicke: Cool. [00:24:17] thx! [00:24:34] gwicke: Could it be Wikipedias + phase 0 (testwiki, test2wiki, mediawikiwiki)? [00:24:43] gwicke: That makes it easier to test. [00:24:47] yes, definitely [00:24:52] (Not sure if the test wikis count as "Wikipedias".) [00:24:54] Cool. Thanks! [00:25:09] I think for VE we'll probably only test on test.* at first [00:25:44] tired [00:25:56] edsanders: *hugs* [00:26:00] and the context is horrible [00:26:09] event-wise [00:26:16] edsanders: If you're done with TrevorParscal for the day, get some sleep and get your headphones for the standup tomorrow. :-P [00:27:04] TrevorParscal: You don't get out so easily. ;-) [00:27:12] can then slowly add wikis if things look good [00:27:13] we currently have *all* wikis enabled on the test cluster [00:27:27] gwicke: Yeah, sounds reasonable. [00:29:09] gwicke, aren't there private wikipedias? [00:29:58] Krenair: I'm not aware of any; and if there are, then we won't see their content as we don't forward cookies yet [00:30:02] hmm, apparently not [00:30:09] 10VisualEditor: Citation-Website: Cite inspector does not display a warning when required field - URL - is missing /empty - https://phabricator.wikimedia.org/T91471#1085159 (10Etonkovidova) 3NEW [00:30:12] Krenair: No. Just locked ones. [00:30:16] I was thinking of the wikipedia arbcom wikis [00:30:26] That's not a Wikipedia, I believe. [00:30:29] which are 'special', not 'wikipedia' [00:30:36] *nod* [00:30:57] but have *.wikipedia.org addresses [00:31:41] I'm excluding specials [00:31:44] 10VisualEditor, 10VisualEditor-MediaWiki-References: [Regression wmf13] Creating a citation without filling in a required field throws "Cannot read property 'createElement' of null" - https://phabricator.wikimedia.org/T78626#1085167 (10Etonkovidova) Cannot reproduce it either. What is surprising though - from... [00:31:55] the list I'm working from is the regular wikis from sitematrix [00:32:48] and membership of special and wikipedia are mutually exclusive? [00:33:05] yes, pretty sure [00:33:18] there's no match for arbcom in there [00:33:23] yes they are [00:33:26] 288 wikis [00:34:36] https://gist.github.com/gwicke/9338f3aafd73d6ba6dc8 [00:52:08] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design, and 2 others: [tracking] button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1085199 (10kaldari) [00:59:36] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1085212 (10kaldari) 3NEW [00:59:38] (03PS1) 10Jforrester: Update VE core submodule to master (4253322) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194245 [01:00:09] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design, and 2 others: [tracking] button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1085220 (10kaldari) [01:00:10] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1085221 (10kaldari) [01:02:39] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1085236 (10kaldari) [01:03:59] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design, and 2 others: [tracking] button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1085238 (10Jdlrobson) Thanks for the clarification @Ricordisamoa and sorry for wrongfully assuming. It's frustrating from the insi... [01:09:11] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1085255 (10kaldari) When I discussed this with Trevor, he suggested reducing the size of MediaWiki UI buttons to match the size of OOjs UI buttons. I create... [01:18:33] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1085267 (10kaldari) Another possible solution is to create a dedicated mobile theme for OOjs UI. The downside of this is increased maintenance cost. [01:19:14] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1085272 (10Jaredzimmerman-WMF) I don't understand why we're not using the same properties and values everywhere for this, the stated goal and literal name o... [01:19:55] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1085273 (10Jaredzimmerman-WMF) @kaldari I want to strike that last comment of yours from the record ;) [01:22:39] (03CR) 10Trevor Parscal: [C: 032] Fix desktop context positioning (again) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194240 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [01:24:44] (03Merged) 10jenkins-bot: Fix desktop context positioning (again) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194240 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [01:27:06] James_F: so that was a total waste of time, I have to go to a different place tomorrow [01:27:19] government is the worst [01:29:19] TrevorParscal: Fun. :-( [01:29:48] the good thing is, the other place is closer to my house and open until 7 [01:29:51] so, yeah [01:29:55] (03CR) 10MZMcBride: "Nice work." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194194 (https://phabricator.wikimedia.org/T76998) (owner: 10Catrope) [01:33:40] James_F: so, the stupid regression thing is properly fixed [01:33:46] Cool. [01:33:49] it was a bad combination of something ed and I each changed [01:33:54] so, he helped me sort it out [01:33:54] :-) [01:33:57] Right. [01:34:03] What about the other issues? [01:34:22] And/or are you going to +2 https://gerrit.wikimedia.org/r/#/c/188280/ ? :-) [01:34:24] which ones? [01:34:36] * James_F looks. [01:35:37] TrevorParscal: https://phabricator.wikimedia.org/maniphest/query/Bl8AwbZzeyEh/#R [01:36:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20): [Regression pre-wmf20] Link inspector opening in wrong position when selection is at the start of a line - https://phabricator.wikimedia.org/T91307#1085295 (10Jdforrester-WMF) 5Open>3Resolved [01:36:33] TrevorParscal: https://phabricator.wikimedia.org/T91337 is a trivial CSS rule I guess. [01:36:52] TrevorParscal: https://phabricator.wikimedia.org/T91314 is probably just an order-of-execution thing? Not sure. [01:37:06] yeah, ryasmeen showed that to me, we need a max-height [01:37:08] TrevorParscal: https://phabricator.wikimedia.org/T91336 is odd – it works for Citations? [01:37:18] * mooeypoo shoots phpunit [01:38:31] I'll have to look into those other ones, can you assign them to me? [01:38:43] TrevorParscal: That search is for bugs assigned to you in VE. ;-) [01:38:52] ok, then that's fine [01:39:13] 10VisualEditor, 10VisualEditor-MediaWiki: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and so fail to go anywhere - https://phabricator.wikimedia.org/T85622#1085299 (10Jdforrester-WMF) a:3TrevorParscal [01:39:24] Krinkle, aaaaaaaa. I'm fixing an issue with TemplateDataBlob, where if the params: {} is empty, paramOrder needs to be an empty array. I've corrected it in the TemplateDataBlock where it normalizes everything. I then added all instances to the output in the test cases. I am getting insanely annoying failures from phpunit, though. Help? [01:39:50] mooeypoo: link? [01:40:01] 10VisualEditor, 10VisualEditor-Links, 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the context menu and so fail to go anywhere useful - https://phabricator.wikimedia.org/T91291#1085305 (10Jdforrester-WMF) p:5High>3Normal [01:40:05] Krinkle, I'm getting failures on things that phpunit should ignore. The first couple of cases, there shouldn't be any comparison between input and output, because the status is itself a failure, and yet the output goes "Failed asserting that the two strings are equal." whaaaaat [01:40:11] mooeypoo: jenkins bug or local failure? [01:40:14] Krinkle, let me push it now [01:40:18] it's local, but let me push it [01:40:20] OK [01:40:53] (03PS2) 10Jforrester: Update VE core submodule to master (b90965c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194245 [01:41:43] (03PS1) 10Mooeypoo: [wip] Fix php errors in paramOrder [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194251 (https://phabricator.wikimedia.org/T91470) [01:42:01] Krinkle, I'm about to tear my hair out. I am probably doing something completely stupid, but it's really frustrating... ^^ [01:42:12] James_F: so, is there already a pull-through written for https://gerrit.wikimedia.org/r/#/c/188280/ ? [01:42:17] (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (b90965c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194245 (owner: 10Jforrester) [01:42:29] TrevorParscal: Yes. https://gerrit.wikimedia.org/r/#/c/193374/ [01:42:37] (03CR) 10jenkins-bot: [V: 04-1] [wip] Fix php errors in paramOrder [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194251 (https://phabricator.wikimedia.org/T91470) (owner: 10Mooeypoo) [01:43:56] Krinkle, uh... what... the hell... is that blob of random text. I don't get that locally. [01:44:20] (03Merged) 10jenkins-bot: Update VE core submodule to master (b90965c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194245 (owner: 10Jforrester) [01:44:48] Krinkle, ... I get all the other 14 errors, though. meh. [01:45:22] mooeypoo: OK. So are all errors unexpected or just some? [01:45:28] mooeypoo: be sure to click full console log [01:45:31] https://integration.wikimedia.org/ci/job/mwext-TemplateData-testextension-zend/93/consoleFull [01:45:36] Krinkle, I did, yeah [01:46:11] okay, so I don't *think* any of those should happen, but I may have screwed up somewhere. Regardless, the most prominent issue is the first one: 1) TemplateDataBlobTest::testParse with data set #0 (array('[] [01:46:31] So I see three files of errors. I might have missed one [01:46:47] see how "Property "templatedata" is expected to be of type "object"." [01:46:50] * Missing paramOrder. Needs either to update test cases or the logic to always add / not add it. [01:46:52] it should have stopped there [01:47:01] * sets.0.param: Looking at this one in a sec [01:47:16] (missing param order is 12x) [01:47:23] Krinkle, I thought I added it to all outputs, but I may have missed some. Either way, why is test #0 comparing *ANYTHING* ? there's no output at all in there [01:47:41] * huge blob: Because paramOrder (not) being there, the blob is now of a different size. The meta-test veryfing how we handle oversized data would need its count updated. [01:47:55] Though most likely you when teh other bugs are fixed, the size will be the same again [01:48:03] so ignore that one for now [01:49:16] Krinkle, but I added it to the default values [01:49:24] why is it not there by default ... what am I missing [01:49:35] mooeypoo: #0 is comparing that an empty input of [] returns the default [01:49:46] right [01:49:54] but I added paramOrder = array() [01:49:54] (03PS20) 10Trevor Parscal: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [01:49:56] to the defaults [01:50:15] Krinkle, https://gerrit.wikimedia.org/r/#/c/194251/1/TemplateDataBlob.php line #49 [01:50:27] (03PS3) 10Trevor Parscal: [PULL THROUGH] Files for special character inserter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [01:50:32] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Files for special character inserter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [01:50:45] mooeypoo: Yes, but it previously did not [01:50:47] It's new [01:50:55] Krinkle, right. What is it comparing to, though? [01:50:57] Previously paramOrder was only there if there were >0 parameters [01:51:27] mooeypoo: hehe [01:51:32] mooeypoo: Lookat Test#assertTemplateData [01:51:34] Krinkle, ... uh oh [01:51:36] what did I do [01:51:39] which is what #testParse uses [01:51:43] which is what the cases are fed to [01:52:02] $case['output'] = '{ "description": null, "params": {}, "sets": [], "maps": {} }'; [01:52:08] aaa! [01:52:16] omg, blah, I missed that [01:52:19] (03CR) 10Trevor Parscal: [C: 04-1] "I updated it so RL didn't crash on trying to include a file that doesn't exist anymore (in PS3) but it still doesn't seem to work, some ot" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [01:52:39] James_F: https://gerrit.wikimedia.org/r/#/c/193374/ looks gtg, but the pull through is borked [01:52:48] shall I +2 now or wait till the pull through issues are resolved? [01:52:50] mooeypoo: That one isn't really exposed in practice. It's just a fallback assertion to fill in the matrix. In practice, if there is an error (like in that case) the output would be discarded. [01:52:55] Krinkle, ha!!! there's onle 1 error now. [01:53:06] Krinkle, yeah I thought the fallback is that !isOk() method [01:53:06] TrevorParscal: I can fiddle with the pull-through I guess. +2 and it'll be my/Ed's problem to fix in the morning. [01:53:09] I missed that one [01:53:13] ok [01:53:40] (03CR) 10Trevor Parscal: [C: 032] Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [01:53:42] (03CR) 10Krinkle: [wip] Fix php errors in paramOrder (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194251 (https://phabricator.wikimedia.org/T91470) (owner: 10Mooeypoo) [01:53:53] Woo-hoo. [01:54:18] ok, gotta take Cadence to swimming now [01:54:20] cyall [01:54:26] Enjoy. [01:55:35] Krinkle, how do I fix the "Data too large to save" [01:55:39] what did I do to get it there... [01:59:48] er why would adding a default paramOrder change the size of the pseudoRandomString [02:01:00] (03Merged) 10jenkins-bot: Move special character inserter to toolbar dialog manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/188280 (owner: 10Esanders) [02:01:36] Krinkle, do I just change the size to what I expect now, or is there some calculation you did to get to that byte size? [02:02:43] (03PS4) 10Jforrester: [PULL THROUGH] Files for special character inserter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:03:54] (03CR) 10jenkins-bot: [V: 04-1] [PULL THROUGH] Files for special character inserter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:04:50] (03PS5) 10Jforrester: Update VE core submodule to master (a65ad7c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:05:00] (03PS2) 10Mooeypoo: Add paramOrder by default to TemplateData blobs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194251 (https://phabricator.wikimedia.org/T91470) [02:05:34] (03CR) 10jenkins-bot: [V: 04-1] Add paramOrder by default to TemplateData blobs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194251 (https://phabricator.wikimedia.org/T91470) (owner: 10Mooeypoo) [02:08:22] (03PS3) 10Mooeypoo: Add paramOrder by default to TemplateData blobs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194251 (https://phabricator.wikimedia.org/T91470) [02:08:33] (03PS6) 10Jforrester: Update VE core submodule to master (a65ad7c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:13:19] (03PS7) 10Jforrester: Update VE core submodule to master (a65ad7c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:13:46] (03CR) 10Jforrester: [C: 032] Add paramOrder by default to TemplateData blobs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194251 (https://phabricator.wikimedia.org/T91470) (owner: 10Mooeypoo) [02:14:02] 10TemplateData, 5WMF-deploy-2015-03-04_(1.25wmf20), 7Wikimedia-log-errors: Invalid foreach and undefined property in TemplateData - https://phabricator.wikimedia.org/T91470#1085318 (10Jdforrester-WMF) 5Open>3Resolved [02:14:23] (03Merged) 10jenkins-bot: Add paramOrder by default to TemplateData blobs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194251 (https://phabricator.wikimedia.org/T91470) (owner: 10Mooeypoo) [02:14:26] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (a65ad7c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:16:07] (03PS8) 10Jforrester: Update VE core submodule to master (a65ad7c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:18:29] mooeypoo: Nope, just update it to what the test failure claims [02:18:42] (as long as the number change looks reasonable to you) [02:19:54] mooeypoo: Aye, The change to count() was not what I meant. Either the error is still there or the code is confusing. [02:20:18] if ( .isset.. ) { .. } elseif ( ..count >= 0 ) { .. } [02:20:19] (03PS9) 10Jforrester: Update VE core submodule to master (a65ad7c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:20:30] mooeypoo: That means there can still be an else and thus the property would be undefined [02:20:47] mooeypoo: this isn't the case because the elseif condition is impossible to not be true. [02:20:54] it can be assigned directly [02:20:57] Krinkle, wait, what do you mean? I thought you said that--- right [02:21:13] there's an else if but it's really an 'else' I see what you mean [02:21:23] I thought it might make it clearer, but I could've just done that in a comment [02:21:35] Yeah, the code currently looks as if there can be an else case, in which case the error would re-occur. [02:21:45] I thought you meant I should combine the two and I combined into the 'else if' instead of into the 'else' [02:21:45] paramNames is already perfectly fine [02:21:51] it's an array with zero or more items. [02:21:59] If there is no override, that can be used directly as fallback [02:22:06] yeah [02:24:02] (03CR) 10Mooeypoo: [C: 032] "Yay for specialCharacter" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:24:56] Krinkle, is it an urgent thing to fix? the condition semantically works, unless I'm missing something. This is more unnecessary condition [02:25:13] Yeah, it's more a if (true == true) thing [02:26:06] (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (a65ad7c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:26:18] (03Merged) 10jenkins-bot: Update VE core submodule to master (a65ad7c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193374 (owner: 10Esanders) [02:27:08] mooeypoo: http://imgur.com/a/3CJCY [02:27:14] (Whilst you're working…) [02:27:42] 10VisualEditor, 10GlobalUserPage, 10Parsoid: Parsoid rendering shows links to global user pages red instead of blue - https://phabricator.wikimedia.org/T91477#1085321 (10Krinkle) 3NEW [02:28:46] 10VisualEditor, 10GlobalUserPage, 10Parsoid: Parsoid rendering shows links to global user pages red instead of blue - https://phabricator.wikimedia.org/T91477#1085328 (10Jdforrester-WMF) p:5Triage>3Low [02:31:05] pretty sure that class of issues is known already [02:32:39] (03PS1) 10Mooeypoo: Make elseif into else because it is [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194256 [02:33:13] Krinkle, ^^ [02:33:27] it'd be a TitleIsAlwaysKnown hook thing [02:34:08] Krenair: Ah, is that a thing we don't cover yet? [02:34:21] Krenair: (That hook.) [02:34:47] I think I commented on this when we found something similar with EducationProgram [02:34:57] * James_F nods. [02:35:00] Low priority. [02:35:30] https://phabricator.wikimedia.org/T72123 [02:36:38] Krenair: Should we create a ticket for "Obey TitleIsAlwaysKnown hook in redlink detection"? [02:36:51] 10VisualEditor, 10GlobalUserPage, 10Parsoid: Parsoid rendering shows links to global user pages red instead of blue - https://phabricator.wikimedia.org/T91477#1085336 (10Krenair) Basically the same thing as T72123. [02:37:09] Krenair: And make those two children of it. [02:37:14] James_F, could do that [02:37:22] I would just generalise the one with the lower ticket id [02:37:28] and dupe the others in [02:37:38] Or that. [02:38:42] Either works. [02:39:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-EducationProgram: VisualEditor's redlink detection doesn't obey TitleIsAlwaysKnown hook, so pages in the Education Program namespaces and GlobalUserPages show up as red - https://phabricator.wikimedia.org/T72123#1085338 (10Jdforrester-WMF) p:5... [02:39:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-EducationProgram: VisualEditor's redlink detection doesn't obey TitleIsAlwaysKnown hook, so pages in the Education Program namespaces and GlobalUserPages show up as red - https://phabricator.wikimedia.org/T72123#726825 (10Jdforrester-WMF) [02:39:33] 10VisualEditor, 10GlobalUserPage, 10Parsoid: Parsoid rendering shows links to global user pages red instead of blue - https://phabricator.wikimedia.org/T91477#1085341 (10Jdforrester-WMF) [02:39:42] {{done}} [02:41:17] (03CR) 10Krinkle: [C: 032] Make elseif into else because it is [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194256 (owner: 10Mooeypoo) [02:41:29] \o/ [02:41:38] Krinkle, a friend of mine suggests we should implement "elsent" [02:41:50] (03Merged) 10jenkins-bot: Make elseif into else because it is [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194256 (owner: 10Mooeypoo) [02:42:08] OK, time for certain people whose nicks begin "Kr" to get some sleep, and the rest of us to get food. [02:42:31] Good night. :-) [02:42:44] :) [02:42:59] But something is wrong on the internet! [02:43:25] Perl has unless, iirc [02:43:57] ... unless... elsent... make programmers crazy! [02:44:35] (03CR) 10Jforrester: [C: 032] TextInputWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/194239 (owner: 10Kmenger) [02:44:57] (03CR) 10Jforrester: [C: 032] tests: Run JS/PHP tests for widgets with required parameters, too [oojs/ui] - 10https://gerrit.wikimedia.org/r/193114 (owner: 10Bartosz Dziewoński) [02:45:25] (03CR) 10Jforrester: [C: 031] "Well, it seems to work…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) (owner: 10Bartosz Dziewoński) [02:46:06] (03CR) 10Jforrester: [C: 032] Restore previous toolbar items margins and padding [oojs/ui] - 10https://gerrit.wikimedia.org/r/193957 (https://phabricator.wikimedia.org/T91135) (owner: 10Bartosz Dziewoński) [02:46:26] (03Merged) 10jenkins-bot: TextInputWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/194239 (owner: 10Kmenger) [02:46:27] 10OOjs-UI, 5Patch-For-Review: Toolbars are messed up, especially in MediaWiki theme - https://phabricator.wikimedia.org/T91135#1085349 (10Jdforrester-WMF) p:5Low>3High [02:48:59] (03Merged) 10jenkins-bot: tests: Run JS/PHP tests for widgets with required parameters, too [oojs/ui] - 10https://gerrit.wikimedia.org/r/193114 (owner: 10Bartosz Dziewoński) [02:49:01] (03Merged) 10jenkins-bot: Restore previous toolbar items margins and padding [oojs/ui] - 10https://gerrit.wikimedia.org/r/193957 (https://phabricator.wikimedia.org/T91135) (owner: 10Bartosz Dziewoński) [03:06:40] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1085366 (10kaldari) @Jaredzimmerman-WMF From my conversations with Trevor, the reason MediaWiki-themed OOjs UI buttons are small is because VisualEditor has... [03:41:22] 10VisualEditor: When you open the Cite > Re-use dialog, the cursor should be placed in the search box - https://phabricator.wikimedia.org/T91479#1085382 (10Whatamidoing-WMF) [03:58:25] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 5Patch-For-Review: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox - https://phabricator.wikimedia.org/T78733#1085404 (10bd808) Enabling HHVM's stat cache is a bust. The implementation in HHVM awesomely uses `inotify` to have the kernel notify it o... [05:27:04] (03CR) 10Mattflaschen: [C: 04-1] "There are at least two things not done from patch set 9. I stopped checking when I got to the second one." (033 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [08:15:05] 10MediaWiki-Page-editing: Protection from double form submission - https://phabricator.wikimedia.org/T3351#1085625 (10epriestley) [08:15:12] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:15:13] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:15:14] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#1085633 (10epriestley) [08:15:23] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:15:24] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:15:26] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:15:27] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:15:29] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:15:36] 10MediaWiki-Page-editing: Interlanguage links will fail in Latin-1 wikis if they contain both 8-bit and UTF-8 characters - https://phabricator.wikimedia.org/T3591#1085652 (10epriestley) [08:16:02] 10MediaWiki-Page-editing: Suppress template list when adding a new section - https://phabricator.wikimedia.org/T4948#1085845 (10epriestley) [08:16:20] 10MediaWiki-Page-editing: Save drafts facility - https://phabricator.wikimedia.org/T5781#82222 (10epriestley) [08:16:26] 10MediaWiki-Page-editing: Save drafts facility - https://phabricator.wikimedia.org/T5781#82222 (10epriestley) [08:20:08] 10MediaWiki-Page-editing: Move section edit links to the bottom of the section - https://phabricator.wikimedia.org/T2559#1086068 (10epriestley) 5Invalid>3Resolved [08:20:27] 10MediaWiki-Page-editing: Deficiencies in the handling of multiple warning messages when editing - https://phabricator.wikimedia.org/T2741#1086132 (10epriestley) [08:20:30] 10MediaWiki-Page-editing: links longer than 255 byte create brokenlink - https://phabricator.wikimedia.org/T2765#1086134 (10epriestley) [08:20:37] 10MediaWiki-Page-editing: parts of the text get duplicated when text exceeds a certain length - https://phabricator.wikimedia.org/T2749#1086144 (10epriestley) [08:21:19] 10MediaWiki-Page-editing: Categories don't seem to show up on the preview page - https://phabricator.wikimedia.org/T2841#1086189 (10epriestley) [08:21:29] 10MediaWiki-Page-editing: Unable to unprotect pages in the MediaWiki namespace - https://phabricator.wikimedia.org/T2625#37619 (10epriestley) [08:22:37] 10MediaWiki-Page-editing: A patch to change --~~~~ to —~~~~ - https://phabricator.wikimedia.org/T2715#33584 (10epriestley) [08:22:39] 10MediaWiki-Page-editing: A patch to change --~~~~ to —~~~~ - https://phabricator.wikimedia.org/T2715#33584 (10epriestley) [08:22:40] 10MediaWiki-Page-editing: A patch to change --~~~~ to —~~~~ - https://phabricator.wikimedia.org/T2715#33584 (10epriestley) [08:22:44] 10MediaWiki-Page-editing: A patch to change --~~~~ to —~~~~ - https://phabricator.wikimedia.org/T2715#33584 (10epriestley) [08:22:45] 10MediaWiki-Page-editing: A patch to change --~~~~ to —~~~~ - https://phabricator.wikimedia.org/T2715#33584 (10epriestley) [08:22:47] 10MediaWiki-Page-editing: A patch to change --~~~~ to —~~~~ - https://phabricator.wikimedia.org/T2715#33584 (10epriestley) [08:22:49] 10MediaWiki-Page-editing: A patch to change --~~~~ to —~~~~ - https://phabricator.wikimedia.org/T2715#33584 (10epriestley) [08:23:23] 10MediaWiki-Page-editing: Unable to unprotect pages in the MediaWiki namespace - https://phabricator.wikimedia.org/T2625#37619 (10epriestley) [08:23:31] 10MediaWiki-Page-editing: The signature button above the edit box - https://phabricator.wikimedia.org/T3782#60629 (10epriestley) [08:23:34] 10MediaWiki-Page-editing: The signature button above the edit box - https://phabricator.wikimedia.org/T3782#1086790 (10epriestley) [08:23:36] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#1086796 (10epriestley) [08:23:39] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:23:42] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:23:43] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:23:47] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:23:48] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:23:50] 10MediaWiki-Page-editing: Warn if edit summary is blank - https://phabricator.wikimedia.org/T3687#59062 (10epriestley) [08:23:55] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:23:57] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:23:58] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:00] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:01] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:02] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:03] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:05] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:06] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:08] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:10] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:12] 10MediaWiki-Page-editing, 7JavaScript: JavaScript error in page editing in some localizations - https://phabricator.wikimedia.org/T3877#1086935 (10epriestley) [08:24:13] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:18] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:20] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:21] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:23] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:24] 10MediaWiki-Page-editing: wpTextbox1= showing up on preview and edit w/duplicate text afterwards - https://phabricator.wikimedia.org/T2217#27006 (10epriestley) [08:24:54] 10MediaWiki-Page-editing: mail-to-wiki gateway: add and create wiki pages from e-mail - https://phabricator.wikimedia.org/T3675#1087097 (10epriestley) [08:24:59] 10MediaWiki-Page-editing: mail-to-wiki gateway: add and create wiki pages from e-mail - https://phabricator.wikimedia.org/T3675#58535 (10epriestley) [08:41:40] 10MediaWiki-Page-editing: Add a spell checker with configuration files in wiki - https://phabricator.wikimedia.org/T3677#1087304 (10Chad) 5Resolved>3declined a:3Chad [08:51:32] 10MediaWiki-Page-editing: Fix fragment identifiers in links to sections - https://phabricator.wikimedia.org/T7019#1087473 (10Qgil) Accidental clash. Known issue. Sorry for the noise. [09:02:58] (03CR) 10Zfilipin: "ping" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193579 (https://phabricator.wikimedia.org/T90423) (owner: 10Zfilipin) [09:03:44] (03PS4) 10Hashar: [BrowserTest] Use Cucumber tag to specify which scenario to run [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193579 (https://phabricator.wikimedia.org/T90423) (owner: 10Zfilipin) [09:05:37] (03CR) 10Hashar: [C: 032] "Lets land this tag, will let Zeljkof update the Jenkins job at https://gerrit.wikimedia.org/r/#/c/193577/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193579 (https://phabricator.wikimedia.org/T90423) (owner: 10Zfilipin) [09:07:48] (03Merged) 10jenkins-bot: [BrowserTest] Use Cucumber tag to specify which scenario to run [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193579 (https://phabricator.wikimedia.org/T90423) (owner: 10Zfilipin) [09:18:39] 10MediaWiki-Page-editing: Move section edit links to the bottom of the section - https://phabricator.wikimedia.org/T2559#1087540 (10Aklapper) 5Resolved>3Invalid a:3Aklapper [09:28:52] nar, VE freezes on the page with unsaved revision [09:29:59] it would be nice to have an option to recover the code inserted, when VE falls [09:39:57] 10VisualEditor, 10MediaWiki-General-or-Unknown, 7Technical-Debt: Put jquery.client back in VE core - https://phabricator.wikimedia.org/T91460#1087618 (10Aklapper) [10:09:31] 10VisualEditor: [Regression pre-wmf20] The transition while switching between Readmode and VE is not smooth, the whole block of content repeats as a flicker below the actual content - https://phabricator.wikimedia.org/T91442#1087670 (10Aklapper) With which browsers was this tested? [10:17:16] 10MediaWiki-Page-editing, 7Tracking: character conversion (tracking) - https://phabricator.wikimedia.org/T5985#1087729 (10TTO) [11:07:56] (03CR) 10Prtksxna: [C: 04-1] Syncing some button styles with MediaWiki UI (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) (owner: 10Kaldari) [11:26:55] 10VisualEditor, 7Technical-Debt: Put jquery.client back in VE core - https://phabricator.wikimedia.org/T91460#1087878 (10Catrope) [11:27:32] 10MediaWiki-Page-editing: preview instead of save - https://phabricator.wikimedia.org/T4603#1087886 (10Aklapper) 5Resolved>3Invalid a:3Aklapper [11:41:48] 10MediaWiki-Page-editing: Allow null edits to fill in missing edit summaries - https://phabricator.wikimedia.org/T3279#1087993 (10Aklapper) 5Resolved>3declined a:3Aklapper [11:41:59] 10MediaWiki-Page-editing: Use realtime blocklists like Spamhaus XBL when pages are edited by non-users - https://phabricator.wikimedia.org/T3400#1087999 (10Aklapper) 5Resolved>3declined a:3Aklapper [12:10:59] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: First paragraph for news articles at fr.news ends up inside Template:Date - https://phabricator.wikimedia.org/T90921#1088115 (10Elitre) [12:56:26] (03CR) 10Prtksxna: PopupWidget: Add keydown listener and hide popup on ESC (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [12:56:33] (03PS2) 10Prtksxna: PopupWidget: Add keydown listener and hide popup on ESC [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) [12:58:04] (03CR) 10jenkins-bot: [V: 04-1] PopupWidget: Add keydown listener and hide popup on ESC [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [13:48:09] (03PS1) 10Esanders: Use the inspector's previousSelection for context positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194322 (https://phabricator.wikimedia.org/T91307) [14:11:43] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: First paragraph for news articles at fr.news ends up inside Template:Date - https://phabricator.wikimedia.org/T90921#1088289 (10Catrope) Yeah, this is a Parsoid bug. Well kind of. The `{{Date}}` template generates: ``` [[Catégorie:{{{1}}}]] '''{... [14:55:16] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#1088420 (10Catrope) I can't reproduce this now. I followed the exact steps in the screencast and... [15:02:04] (03PS1) 10Mobrovac: Use the RESTBase back-end if available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194338 (https://phabricator.wikimedia.org/T89066) [15:14:14] 10OOjs-UI, 10VisualEditor, 10VisualEditor-Performance, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: ~50ms spent animating a.oo-ui-buttonElement-button - https://phabricator.wikimedia.org/T88386#1088510 (10Jdforrester-WMF) [15:14:29] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10UI-Standardization, and 2 others: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1088511 (10Jdforrester-WMF) [15:16:13] Heya. [15:17:43] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 5Patch-For-Review, and 2 others: [Regression pre-wmf20] Link inspector opening in wrong position when selection is at the start of a line - https://phabricator.wikimedia.org/T91307#1088522 (10Jdforrester-WMF) [15:17:44] 10VisualEditor, 10VisualEditor-ContentEditable, 10Citoid, 7Design, and 2 others: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#1088523 (10Jdforrester-WMF) [15:17:46] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1088525 (10Jdforrester-WMF) [15:17:47] 10VisualEditor, 10VisualEditor-DataModel, 7Browser-Support-Apple-Safari, 5WMF-deploy-2015-02-18_(1.25wmf18), and 3 others: Categories incorrectly moved up, possibly due to improperly closed table - https://phabricator.wikimedia.org/T72373#1088524 (10Jdforrester-WMF) [15:17:49] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Don't show redlinks as existing links if MediaWiki didn't tell us one way or the other - https://phabricator.wikimedia.org/T91299#1088527 (10Jdforrester-WMF) [15:18:34] 10VisualEditor, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: [Regression pre-wmf20] Reference and Media caption surfaces have broken layout - https://phabricator.wikimedia.org/T91145#1075071 (10Jdforrester-WMF) [15:18:41] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Don't show redlinks as existing links if MediaWiki didn't tell us one way or the other - https://phabricator.wikimedia.org/T91299#1079344 (10Jdforrester-WMF) [15:18:52] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 5Patch-For-Review, and 2 others: [Regression pre-wmf20] Link inspector opening in wrong position when selection is at the start of a line - https://phabricator.wikimedia.org/T91307#1079509 (10Jdforrester-WMF) [15:19:06] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1048837 (10Jdforrester-WMF) [15:19:18] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Context menu moves to middle of inline selection when an inspector is opened - https://phabricator.wikimedia.org/T90857#1069478 (10Jdforrester-WMF) [15:19:28] 10VisualEditor, 10VisualEditor-ContentEditable, 10Citoid, 7Design, and 2 others: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#746210 (10Jdforrester-WMF) [15:19:36] 10VisualEditor, 10VisualEditor-DataModel, 7Browser-Support-Apple-Safari, 5WMF-deploy-2015-02-18_(1.25wmf18), and 3 others: Categories incorrectly moved up, possibly due to improperly closed table - https://phabricator.wikimedia.org/T72373#751578 (10Jdforrester-WMF) [15:20:20] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide the character inserter everywhere that you can input text - https://phabricator.wikimedia.org/T62657#1088559 (10Jdforrester-WMF) [15:21:59] (03PS3) 10Prtksxna: PopupWidget: Add keydown listener and hide popup on ESC [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) [15:23:17] (03CR) 10Catrope: "$ ack-grep 'background-position: center center' src | wc -l" [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders) [15:24:06] RoanKattouw: Can you review & merge https://gerrit.wikimedia.org/r/#/c/194322/ please? [15:24:59] (03CR) 10Catrope: "While we're at it, maybe we can also make background-repeat: no-repeat; the default in iconElement and indicatorElement? That's also dupli" [oojs/ui] - 10https://gerrit.wikimedia.org/r/181617 (https://phabricator.wikimedia.org/T85139) (owner: 10Esanders) [15:25:25] James_F: I would if I knew that code [15:25:55] RoanKattouw: Yeah. :-( Hopefully the cut will be late enough for TrevorP|Away to review it and for us to do a pull-through, then. [15:26:13] Oh right it's Wednesday [15:26:26] Well I'm -1ing it anyway :S [15:27:31] (03CR) 10Catrope: [C: 04-1] Use the inspector's previousSelection for context positioning (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194322 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [15:31:05] RoanKattouw: Seen Timo's -1 on https://gerrit.wikimedia.org/r/#/c/193813/ ? [15:33:19] Oh [15:33:37] I did see it the day before yesterday, then thought "I'm going to sleep, I'll deal with this tomorrow", and then forgot about it yesterday [15:33:43] :-) [15:37:33] (03CR) 10Jforrester: "The dependency will be released in OOjs UI 0.9.0 later today, at which point we can merge this." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/190973 (https://phabricator.wikimedia.org/T88152) (owner: 10Mooeypoo) [15:38:40] https://phabricator.wikimedia.org/project/sprint/board/401/query/open/?order=priority [15:38:53] James_F: You wouldn't know a way to make this the default display for that board? [15:39:13] especacially 'open' but sort would be nice too [15:39:21] Krinkle: You mean order=priority? There isn't one, sorry. [15:39:36] https://phabricator.wikimedia.org/project/board/401/ shows only open tasks. [15:39:49] https://phabricator.wikimedia.org/project/sprint/board/401/ shows all tasks, not just open ones. [15:40:00] Either of those can't be configured for ordering, sadly. [15:40:16] You can drag the items around to make "natural" order the same, of course. [15:41:01] Krinkle: Could you (re-)review https://gerrit.wikimedia.org/r/177107 please? [15:42:13] James_F: Ah, interesting. [15:42:20] Krinkle: Also, did you talk to MatmaRex about https://gerrit.wikimedia.org/r/#/c/193123/ yet? [15:42:45] James_F: Reviewing in general or the current test failure? [15:45:19] Krinkle: In general. [15:46:12] 10OOjs-UI, 10Continuous-Integration: OOjs UI's PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#1088702 (10Jdforrester-WMF) [15:47:24] (03CR) 10Catrope: [C: 04-1] Add an icon to hidden templates (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) (owner: 10Mooeypoo) [15:51:49] Krinkle: I re-ordered a bunch of them to match status. [15:51:53] Krinkle: Because I'm nice like that. [15:53:11] Hey TrevorParscal. [15:53:16] hi [15:53:17] Just setting up now. Whee. [15:53:22] cool [15:53:51] yeah, something is broken about those tests. [15:53:52] i was planning to participate remotely given i've just now woken up [15:53:52] also, hi. [15:53:57] TrevorParscal: :-D [15:54:07] (03PS8) 10Bartosz Dziewoński: tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 [15:54:13] morning folks [15:54:44] James_F: cya in the hangout in a min [15:56:32] (03CR) 10jenkins-bot: [V: 04-1] tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [15:56:52] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and the context menu and so fail to go anywhere - https://phabricator.wikimedia.org/T85622#1088773 (10Jdforrester-WMF) [15:56:55] (03CR) 10Catrope: [C: 04-1] Add a threshold to 'read more' calculation in media dialog info (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) (owner: 10Mooeypoo) [15:57:06] 10VisualEditor, 10VisualEditor-Links, 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the context menu and so fail to go anywhere useful - https://phabricator.wikimedia.org/T91291#1088777 (10Jdforrester-WMF) [15:57:08] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and the context menu and so fail to go anywhere - https://phabricator.wikimedia.org/T85622#950855 (10Jdforrester-WMF) [15:57:18] 10VisualEditor, 10VisualEditor-Links: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the context menu and so fail to go anywhere useful - https://phabricator.wikimedia.org/T91291#1079190 (10Jdforrester-WMF) [15:57:38] TrevorParscal: Once you guys are done with that meeeting, I'd like to talk to you about Icon/IndicatorElement [15:58:22] 10VisualEditor, 10VisualEditor-Links: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the context menu and so fail to go anywhere useful - https://phabricator.wikimedia.org/T91291#1079190 (10Jdforrester-WMF) [15:58:23] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and the context menu and so fail to go anywhere - https://phabricator.wikimedia.org/T85622#950855 (10Jdforrester-WMF) [16:00:25] TrevorParscal: Dialing in? [16:00:31] * James_F goes radio-silent. [16:03:13] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the context menu and so fail to go anywhere - https://phabricator.wikimedia.org/T85622#1088798 (10Catrope) [16:04:02] not using hangouts? did we not say we were going to? [16:04:14] i'm all alone in the hangout [16:05:29] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Pasting in text containing a tab character causes VE to scroll to the top - https://phabricator.wikimedia.org/T74390#1088802 (10Aklapper) [16:05:38] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari: VisualEditor: Copying text causes browser to scroll to the top of the page and move the cursor to the top in Safari - https://phabricator.wikimedia.org/T73728#757885 (10Aklapper) [16:05:53] (03PS1) 10Matthias Mullie: Add missing dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194343 [16:06:18] 10VisualEditor, 10VisualEditor-Tables: Cannot scroll down when editing long tables - https://phabricator.wikimedia.org/T76891#1088809 (10Aklapper) [16:06:50] 10VisualEditor, 10VisualEditor-Tables: Long tables - no page scrolling when moving up and down with arrow buttons - https://phabricator.wikimedia.org/T85542#949222 (10Aklapper) [16:13:28] 10VisualEditor, 10VisualEditor-ContentEditable: Visual editor: issues with removing leading space pre blocks - https://phabricator.wikimedia.org/T53758#1088841 (10Aklapper) [16:16:16] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the context menu and so fail to go anywhere - https://phabricator.wikimedia.org/T85622#1088868 (10Catrope) a:5TrevorParscal>3Catrope [16:16:34] (03PS1) 10Catrope: Resolve URLs in LinkContextItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194345 (https://phabricator.wikimedia.org/T85622) [16:17:54] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#1088879 (10Krenair) Might have been the fix for T89923. [16:17:57] (03PS1) 10Catrope: Resolve URLs in MWInternalLinkContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194347 (https://phabricator.wikimedia.org/T85622) [16:22:08] (03PS2) 10Catrope: Add missing jquery.uls dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194343 (owner: 10Matthias Mullie) [16:22:35] Krinkle: https://gerrit.wikimedia.org/r/194343 https://gerrit.wikimedia.org/r/177107 [16:22:53] TrevorParscal: https://gerrit.wikimedia.org/r/194345 https://gerrit.wikimedia.org/r/194347 [16:23:07] 10VisualEditor, 10VisualEditor-ContentEditable: Visual editor: issues with removing leading space pre blocks - https://phabricator.wikimedia.org/T53758#1088912 (10Aklapper) > * It is not possible to delete a block on the first line of a page I managed after removing the text and then putting the cursor in fro... [16:35:28] 10VisualEditor, 10VisualEditor-ContentEditable: Visual Editor: Bullet renders on last line for citation templates that span multiple lines - https://phabricator.wikimedia.org/T53760#1088956 (10Aklapper) 5Open>3Resolved a:3Aklapper Sorry that this has not received feedback earlier, and thanks for reportin... [16:40:20] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Bulleted bullets and bulleted headers produced; can't save - https://phabricator.wikimedia.org/T54639#1088969 (10Aklapper) 5Open>3stalled Hi @Thryduulf! Sorry that nobody has taken a look at this report yet and given feedback. I tried copying b... [16:41:31] 10VisualEditor: VisualEditor: adding section for references will suppress the Related Articles one - https://phabricator.wikimedia.org/T55699#1088972 (10Aklapper) 5stalled>3declined a:3Aklapper Closing task as declined as per last two comments as nobody managed to reproduce. Please reopen if this problem... [16:44:59] (03PS1) 10Esanders: Handle optional parameters correctly in table selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194351 [16:45:01] (03PS1) 10Esanders: Fix up selection if we cursor into or next to a table node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194352 (https://phabricator.wikimedia.org/T73560) [16:45:49] (03PS5) 10Catrope: Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 [16:46:21] (03CR) 10Catrope: [C: 032] Handle optional parameters correctly in table selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194351 (owner: 10Esanders) [16:47:18] (03CR) 10jenkins-bot: [V: 04-1] Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 (owner: 10Catrope) [16:47:49] (03PS6) 10Catrope: Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 [16:48:00] 10VisualEditor: Linking issue. - https://phabricator.wikimedia.org/T90878#1089004 (10Aklapper) 5Open>3stalled [16:48:19] 10VisualEditor: Linking issue. - https://phabricator.wikimedia.org/T90878#1069887 (10Aklapper) What exactly does "i cannot edit" mean? Please see https://www.mediawiki.org/wiki/How_to_report_a_bug and provide exact version information both for MediaWiki and VisualEditor (branch? revision?). Please also see http... [16:48:35] (03Merged) 10jenkins-bot: Handle optional parameters correctly in table selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194351 (owner: 10Esanders) [16:48:46] (03CR) 10Catrope: [C: 032] Fix up selection if we cursor into or next to a table node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194352 (https://phabricator.wikimedia.org/T73560) (owner: 10Esanders) [16:49:13] edsanders: What bug was caused by https://gerrit.wikimedia.org/r/#/c/194148/1/src/ce/ve.ce.Surface.js ? [16:49:25] Or are you not aware of one? [16:49:46] RoanKattouw, I can't get that codepath to run [16:50:14] I think you need to down-arrow into a focusablenode in Chrome? [16:50:14] we fix up landing in a focusable elsewhere in the code [16:50:26] Or, no, left/right arrow [16:50:29] Oh, I see [16:50:34] look at getSurroundingFocusableNode [16:51:18] it may be that we can remove that whole block (viewNode.isFocusable()) [16:51:33] Oh right, afterDocumentKeyDown already does that too [16:51:49] (03Merged) 10jenkins-bot: Fix up selection if we cursor into or next to a table node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194352 (https://phabricator.wikimedia.org/T73560) (owner: 10Esanders) [16:51:59] That commit --^^ touches that other code path [16:52:09] So we have two code paths that try to fix up these selections [16:52:25] And I'm not completely convinced that the decision of which one runs first is even deterministic [16:53:11] edsanders: Could you file a tech debt task about that and assign it to divec ? [16:56:57] 10VisualEditor: Page bump when editing a section in VE - https://phabricator.wikimedia.org/T88613#1089056 (10Aklapper) >>! In T88613#1032142, @Aklapper wrote: > Duplicate of T55217 and/or T52206? ^ @awight: Could you answer this (and potentially merge)? [17:00:47] 10VisualEditor: Removing extra blank line removes all blank lines - https://phabricator.wikimedia.org/T88306#1089061 (10Aklapper) Confirming, though only works for me when removing the first line of two empty lines via Backspace key in F36 (removing the second one does nothing). [17:01:23] 10VisualEditor: Removing extra blank line from two blank lines removes both blank lines - https://phabricator.wikimedia.org/T88306#1089062 (10Aklapper) p:5Triage>3Low [17:05:39] (03CR) 10Kaldari: Syncing some button styles with MediaWiki UI (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) (owner: 10Kaldari) [17:06:32] 10VisualEditor, 10VisualEditor-EditingTools: Characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1089069 (10Aklapper) p:5Triage>3Low Confirming in Firefox 36 on Fedora 21 but this only happens at certain zoom levels in the browser. At certain zoom lev... [17:06:59] (03PS9) 10Bartosz Dziewoński: tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 [17:07:02] 10VisualEditor, 10VisualEditor-EditingTools: At certain browser zoom levels, the special characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1089071 (10Aklapper) [17:08:48] * andre__ is going to triage and reproduce a few more older "Needs Triage" VE tasks and set some priority on them (mostly "low") [17:09:25] (03PS4) 10Kaldari: Syncing some button styles with MediaWiki UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) [17:14:28] 10VisualEditor: VisualEditor: Coordinates template is displaying in the wrong place - https://phabricator.wikimedia.org/T67648#1089080 (10Aklapper) Cannot reproduce the problem anymore on https://en.wikipedia.org/wiki/Harton,_North_Yorkshire?veaction=edit even after hovering over the Coord template and clicking... [17:15:42] 10OOjs-UI, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1089082 (10Jdforrester-WMF) [17:17:15] (03CR) 10Esanders: Use the inspector's previousSelection for context positioning (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194322 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [17:20:16] 10VisualEditor, 10VisualEditor-ContentEditable: Unused and/or broken code in ce.Surface selection fixup - https://phabricator.wikimedia.org/T91518#1089097 (10Esanders) 3NEW a:3dchan [17:22:42] TrevorParscal: https://gerrit.wikimedia.org/r/194345 https://gerrit.wikimedia.org/r/194347 https://gerrit.wikimedia.org/r/194322 [17:23:18] (03CR) 10Catrope: Use the inspector's previousSelection for context positioning (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194322 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [17:26:36] (03CR) 10Alex Monk: [C: 032] Resolve URLs in MWInternalLinkContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194347 (https://phabricator.wikimedia.org/T85622) (owner: 10Catrope) [17:28:04] RoanKattouw: :-D [17:28:22] (03CR) 10Alex Monk: [C: 032] Resolve URLs in LinkContextItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194345 (https://phabricator.wikimedia.org/T85622) (owner: 10Catrope) [17:29:03] 10VisualEditor: Narrow search templates - https://phabricator.wikimedia.org/T86713#1089150 (10Aklapper) The dropdown of the oo-ui-lookupElement is currently the same width as the search input field itself, and that width is limited by the Search button on the right of the search input field. Probably defining t... [17:30:20] 10OOjs-UI, 10VisualEditor: List of proposals when searching templates in VE is narrow (same width as the search field itself though space available) - https://phabricator.wikimedia.org/T86713#1089165 (10Aklapper) p:5Triage>3Lowest [17:30:43] (03Merged) 10jenkins-bot: Resolve URLs in LinkContextItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194345 (https://phabricator.wikimedia.org/T85622) (owner: 10Catrope) [17:31:45] (03Merged) 10jenkins-bot: Resolve URLs in MWInternalLinkContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194347 (https://phabricator.wikimedia.org/T85622) (owner: 10Catrope) [17:32:52] 10OOjs-UI: Icon-only framed buttons are asymmetrical - https://phabricator.wikimedia.org/T91523#1089187 (10matmarex) 3NEW [17:36:38] (03CR) 10Jforrester: [C: 04-1] "You need to make the changes to extension.json too." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194343 (owner: 10Matthias Mullie) [17:38:05] (03CR) 10Mooeypoo: Add an icon to hidden templates (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) (owner: 10Mooeypoo) [17:38:15] (03PS4) 10Bartosz Dziewoński: PopupWidget: Add keydown listener and hide popup on ESC [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [17:38:36] (03CR) 10Bartosz Dziewoński: [C: 032] "Added some @private annotations." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [17:39:30] (03CR) 10Jforrester: [C: 032] Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 (owner: 10Catrope) [17:39:58] (03CR) 10Jforrester: [C: 031] tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [17:40:19] 10VisualEditor, 10Citoid, 6operations, 5§ VisualEditor Q3 Blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1089221 (10akosiaris) [17:40:31] (03Merged) 10jenkins-bot: PopupWidget: Add keydown listener and hide popup on ESC [oojs/ui] - 10https://gerrit.wikimedia.org/r/191027 (https://phabricator.wikimedia.org/T87695) (owner: 10Prtksxna) [17:41:23] (03CR) 10Mooeypoo: Add a threshold to 'read more' calculation in media dialog info (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) (owner: 10Mooeypoo) [17:41:27] 10OOjs-UI, 10VisualEditor: Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1089236 (10Jdforrester-WMF) [17:42:16] RoanKattouw, added comment/answers to both of these reviews. I'm mostly concerned about your point with the hidden templates... if you used a template that added an image, it's no longer hidden, isn't it? [17:42:19] I'm a little confused. [17:42:30] 10OOjs-UI, 10VisualEditor: Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1089262 (10matmarex) This is likely fixed now, but it should be tested carefully since there's a lot of things happening when Escape is pressed. [17:42:59] oh... okay. James_F just explained where I thought of it wrong. [17:43:12] mooeypoo: .text() === '' does not mean nothing is shown [17:43:16] is the crux of the issue [17:43:31] RoanKattouw, yeah I got confused, okay, I see what you mean [17:43:37] but is it only an "image" that is a problem? [17:43:41] RoanKattouw: I think .text() === '' || .has() is enough as a first approximation. [17:43:43] can we have a div with some sizing? [17:43:59] RoanKattouw: Otherwise we'll have to do really expensive .css evaluations. [17:44:07] as in, is it enough for me to check if there's either no text or an imgae, or do we need to --- yeah, work with some CSS [17:44:13] we do this after the node is rendered anyways [17:44:18] so we could, theoretically, check the sizing [17:44:24] (and practically) [17:44:28] 10MediaWiki-Page-editing: Request for "Create as blank" button for new pages - https://phabricator.wikimedia.org/T3621#1089292 (10Aklapper) 5Resolved>3declined a:3Aklapper [17:44:34] But do we need to? [17:44:38] RoanKattouw: People will report edge case issues and we can fix them later. [17:44:56] (03CR) 10Catrope: Add a threshold to 'read more' calculation in media dialog info (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) (owner: 10Mooeypoo) [17:45:23] James_F: What specific cases are we targeting here? Categories and other metadata? [17:45:30] RoanKattouw: Yeah. [17:45:40] RoanKattouw: Also indicators, I guess. [17:45:50] RoanKattouw: Not sure how those are coped with by this? [17:45:52] Right [17:46:02] Does Parsoid output them as a meta? [17:46:07] So what about coordinate templates [17:46:10] Those contain text [17:46:19] But they generate something that's absolutely positioned in the corner [17:46:25] You probably want an icon for those too, right? [17:46:30] They should die in a fire. ;-) [17:46:35] (03CR) 10Mooeypoo: Add a threshold to 'read more' calculation in media dialog info (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) (owner: 10Mooeypoo) [17:46:38] But yes. Eurgh. [17:46:55] Also, &RLM [17:47:05] i wonder if that counts as text().length == 0 [17:47:10] mooeypoo: Check. :-) [17:47:13] Probably not [17:47:18] 10MediaWiki-Page-editing: Add a hook to Revision - https://phabricator.wikimedia.org/T5577#1089335 (10Aklapper) 5Resolved>3declined a:3Aklapper [17:47:50] James_F: So for that reason I'd suggest rendering first and then measuring the rendering [17:48:00] Ick. Expensive. [17:48:13] (03Merged) 10jenkins-bot: Don't call .addClass() in CE nodes' setup handlers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193813 (owner: 10Catrope) [17:48:27] RoanKattouw, $( '' ).append( '&rlm' ).text().length == 4 [17:48:36] :\ [17:48:44] RoanKattouw: You just don't care about performance! ;-) [17:48:53] RoanKattouw, The method is already done *after* rendering [17:48:54] Also I'd recommend appending the icon to this.$element rather than making it an icon [17:48:59] so I can measure the size [17:49:01] (03PS1) 10Jforrester: Update VE core submodule to master (7dcd5e8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194360 [17:49:02] Because what if this.$element is absolutely positioned [17:49:03] RoanKattouw: ^^^ Please +2. [17:49:08] This is GCn, it could be anything [17:49:13] oi [17:49:29] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (7dcd5e8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194360 (owner: 10Jforrester) [17:49:47] ... meh [17:50:07] damn templates. [17:50:45] mooeypoo: Try ‏ [17:50:52] mooeypoo: &rlm is just a string with length 4 [17:51:00] 1 [17:51:05] Right [17:51:06] (and yikes, yes, sorry) [17:51:07] semi colon? :D [17:51:09] That makes more sense [17:51:32] (03Merged) 10jenkins-bot: Update VE core submodule to master (7dcd5e8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194360 (owner: 10Jforrester) [17:51:32] $( '' ).append( '‏' ).text().length === 1 [17:51:36] Damn. [17:51:37] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Google-Chrome, and 3 others: Chrome lets you place the cursor either side of a Table (eww) and VE doesn't correct this - https://phabricator.wikimedia.org/T73560#1089356 (10Jdforrester-WMF) 5Open>3Resolved [17:51:37] okay [17:51:55] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and context menu and so fail to go anywhere - https://phabricator.wikimedia.org/T85622#1089358 (10Jdforrester... [17:52:04] so.. what's the safest thing to do here? if text.length === 0 or css width/height = 0 [17:52:04] ? [17:52:21] this is whack. [17:53:15] crap, only css [17:53:36] I would suggest .width() / .height() [17:53:39] Also pick TrevorP|Away's brain [17:53:49] RoanKattouw, yeah that's what I meant, just asking in general terms [17:54:07] mooeypoo: !(text.length !== 0 || css width/height !== 0) [17:54:08] won't checking these affect performance? didn't we have some bugs about reducing the amount of time we're using css to check sizes of stuff? [17:54:12] and visibilities and such [17:54:35] mooeypoo: As text.length !== 0 will lazy-evals true in the majority case, and so close out the operation before the expensive css measurements. [17:55:15] De Morgan's theorem rises again. :-) [17:56:47] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and context menu and so fail to go anywhere - https://phabricator.wikimedia.org/T85622#1089368 (10Jdforrester... [17:56:56] James_F, RoanKattouw I'm totally writing this rule as a double negative, just to showcase my disdain of the reason we have to do it at all [17:57:02] mooeypoo: On GCN reners I'm not too worried [17:57:07] *renders [17:59:02] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 5Patch-For-Review: Track module initialization errors in ResourceLoader - https://phabricator.wikimedia.org/T85263#1089371 (10Tgr) 5Open>3Resolved [17:59:10] (03PS3) 10Jforrester: Add missing jquery.uls dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194343 (owner: 10Matthias Mullie) [18:00:09] (03PS4) 10Jforrester: Correct jquery.uls dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194343 (owner: 10Matthias Mullie) [18:00:14] (03CR) 10Jforrester: [C: 032] Correct jquery.uls dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194343 (owner: 10Matthias Mullie) [18:05:38] (03Merged) 10jenkins-bot: Correct jquery.uls dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194343 (owner: 10Matthias Mullie) [18:06:51] (03PS13) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 [18:07:12] TrevorP|Away: Review https://gerrit.wikimedia.org/r/194322 , verify my comments on https://gerrit.wikimedia.org/r/#/c/193975/1/modules/ve-mw/ce/styles/nodes/ve.ce.MWTransclusionNode.css [18:09:16] Krinkle: Review https://gerrit.wikimedia.org/r/177107 [18:09:31] Krinkle: And then https://phabricator.wikimedia.org/T91460 if you have time [18:11:41] RoanKattouw, what was my fault? [18:13:41] 10VisualEditor: Wrap invisible characters in new content with - https://phabricator.wikimedia.org/T85943#1089388 (10Whatamidoing-WMF) I'm adding this diff here, as probably being related: https://en.wikipedia.org/w/index.php?title=Sasneham_Sumithra&diff=prev&oldid=649819519 [18:13:49] James_F: due to lack of response on upstream karma issue tracker, I've just reached out over the karma-users google groups mailing list (where the two lead maintainers seem to be more responsive) [18:14:07] regarding disconnects with concurrent builds [18:14:15] Krinkle: Fun. [18:14:32] Krenair: Reviewing code so fast that you took out 2/3s of Trevor's CR backlog :P [18:14:52] haha [18:15:18] Krenair: Did you test https://gerrit.wikimedia.org/r/#/c/182432/ with VE-MW to see if https://phabricator.wikimedia.org/T85619 actually got fixed? [18:16:35] Sigh. That commit. [18:16:49] :_D [18:16:55] Thought that'd slow you down. ;-) [18:17:16] I seem to recall it fixed the obvious issue but left some other things (e.g. validation) broken [18:17:43] (03PS1) 10Kmenger: DropdownInputWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/194363 [18:20:53] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Add a Preview feature to show actual version of page (minus slugs, etc.) - https://phabricator.wikimedia.org/T62535#1089421 (10Whatamidoing-WMF) Suggestion from SarahTehCat: Use the 'Live Preview' system (if it's stable). [18:27:30] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to name references manually in the reference dialog - https://phabricator.wikimedia.org/T52568#1089438 (10Whatamidoing-WMF) Here's another idea for an automatically suggested (but still editable) ref name that would work with manually formatted... [18:30:38] (03CR) 10Mooeypoo: Add an icon to hidden templates (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) (owner: 10Mooeypoo) [18:30:56] (03PS2) 10Mooeypoo: Add an icon to hidden templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) [18:32:27] (03CR) 10Jforrester: [C: 032] DropdownInputWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/194363 (owner: 10Kmenger) [18:34:14] (03Merged) 10jenkins-bot: DropdownInputWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/194363 (owner: 10Kmenger) [18:41:25] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, and 2 others: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1089476 (10GWicke) [18:41:27] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: Thoughts on element IDs, sections, incremental parsing and fast section editing - https://phabricator.wikimedia.org/T87556#1089477 (10GWicke) [18:44:10] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#1089479 (10Tgr) [18:44:41] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#942722 (10Tgr) Rewrote what this task is about based on the discussion in the comments. [18:46:36] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 7Blocked-on-MediaWiki-Core, 5Patch-For-Review: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#942722 (10MarkTraceur) [18:47:00] (03CR) 10Trevor Parscal: [C: 032] Use the inspector's previousSelection for context positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194322 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [18:49:05] (03Merged) 10jenkins-bot: Use the inspector's previousSelection for context positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194322 (https://phabricator.wikimedia.org/T91307) (owner: 10Esanders) [18:49:44] (03PS1) 10Jforrester: Update VE core submodule to master (79004c9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194366 [18:52:23] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Adjust the context menu to be able to display richer data for tools that want it - https://phabricator.wikimedia.org/T89054#1089512 (10Jdforrester-WMF) [19:04:26] (03CR) 10Mooeypoo: Add a threshold to 'read more' calculation in media dialog info (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) (owner: 10Mooeypoo) [19:05:03] (03PS3) 10Mooeypoo: Add a threshold to 'read more' calculation in media dialog info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) [19:09:30] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1089549 (10TrevorParscal) Why don't we make Class.static -> Class for backwards compatibility, and go with Timo's suggestion of just using copying of pro... [19:10:50] (03CR) 10Trevor Parscal: [C: 04-1] "I think you may be right, that Timo's proposal is good, and I've suggested a way to achieve backwards compatibility so it's a minor releas" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [19:12:47] (03CR) 10Catrope: Add a threshold to 'read more' calculation in media dialog info (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) (owner: 10Mooeypoo) [19:13:00] (03CR) 10Catrope: [C: 032] Add a threshold to 'read more' calculation in media dialog info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) (owner: 10Mooeypoo) [19:13:47] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5WMF-deploy-2015-03-04_(1.25wmf20): "Read more" link is appearing even if the last line if the description of the image fits in the visible area - https://phabricator.wikimedia.org/T87265#1089556 (10Jdforrester-WMF) 5Open>3Resolved [19:15:03] (03Merged) 10jenkins-bot: Add a threshold to 'read more' calculation in media dialog info [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193286 (https://phabricator.wikimedia.org/T87265) (owner: 10Mooeypoo) [19:15:17] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1089562 (10Krinkle) >>! In T89721#1076106, @cscott wrote: > The users would be surprised because all of the other static methods in OOjs UI are currently... [19:18:09] Could someone +2 https://gerrit.wikimedia.org/r/#/c/194366/ (pull-through of Ed's latest fix)? [19:18:21] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (79004c9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194366 (owner: 10Jforrester) [19:18:26] Thanks RoanKattouw. :-) [19:20:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (79004c9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194366 (owner: 10Jforrester) [19:20:44] RoanKattouw: dude, why are you reviewing code? [19:21:20] (03PS1) 10Kmenger: ComboBoxWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/194372 [19:21:28] write some freaking code man, I just spent all this time carefully testing and reviewing https://gerrit.wikimedia.org/r/#/c/193286/ only for you to +2 it just before me [19:21:30] omg!! [19:22:50] haha [19:23:30] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1089590 (10cscott) I like @TrevorParscal's suggestion. It's possible some code might break -- it should probably be a major version bump, just to be saf... [19:23:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10Flow, 3Collaboration-Team-Sprint-R-2015-03-11, 5Patch-For-Review: R1. Spike: Add relevant MW features to VE on Flow - https://phabricator.wikimedia.org/T90760#1089591 (10matthiasmullie) See patch above, which adds some of the mw-* modules (links, images, templa... [19:23:41] this is like in Silicon Valley, when they both work on DRM... except we already are using SCRUM, and I was working from my list assigned to me [19:23:45] lol [19:24:08] I didn't see that episode [19:24:12] Oh did James put this commit on your list? [19:24:16] yes [19:24:20] Aha [19:24:23] On Sunday? [19:24:25] when you return, we will finish the season [19:24:30] Yes [19:24:30] in the email [19:24:35] Right [19:24:37] So three days ago :P [19:24:51] i'm just giving you a hard time [19:24:59] I took a stab at reviewing her code a few hours ago before the US woke up [19:25:00] Speaking [19:25:02] of [19:25:08] Could you check my reasoning at https://gerrit.wikimedia.org/r/#/c/193975/1/modules/ve-mw/ce/styles/nodes/ve.ce.MWTransclusionNode.css ? [19:25:19] Specifically my rant about padding and margin [19:26:36] (03CR) 10Catrope: Add an icon to hidden templates (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) (owner: 10Mooeypoo) [19:28:05] RoanKattouw, the duplication thing -- if we're using LESS, we could define mixins. Otherwise, I could create a "master" class called something like ve-ce-IconedNode or something and just attach it to both comment and transclusion node [19:34:07] (03CR) 10Cscott: [C: 032] tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [19:37:47] (03Merged) 10jenkins-bot: tests: Add infusion tests [oojs/ui] - 10https://gerrit.wikimedia.org/r/193123 (owner: 10Bartosz Dziewoński) [19:46:02] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1089705 (10bmansurov) Maybe we should override VE style in MF for everything except the VE itself? [19:47:02] (03CR) 10Jforrester: [C: 032] ComboBoxWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/194372 (owner: 10Kmenger) [19:48:07] (03CR) 10Mooeypoo: TextInputWidget: Use MutationObserver for #onElementAttach support (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) (owner: 10Bartosz Dziewoński) [19:48:25] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1089712 (10TrevorParscal) We can also add copying without changing static at all. Then, people can start moving functions over. Aliasing static to Class... [19:48:52] (03PS1) 10Kmenger: DecoratedOptionWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/194381 [19:49:06] (03Merged) 10jenkins-bot: ComboBoxWidget: Add description, example, and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/194372 (owner: 10Kmenger) [19:49:29] 10VisualEditor: Typing after closing link inspector - the first letter gets transposed - https://phabricator.wikimedia.org/T91541#1089714 (10Etonkovidova) 3NEW [20:04:19] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Not sure if this actually works well enough. Gotta work it more." [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) (owner: 10Bartosz Dziewoński) [20:05:26] (03PS1) 10Kmenger: SelectWidget: Add example and link to decorated option widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/194384 [20:07:32] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1089859 (10Jaredzimmerman-WMF) @bmansurov it seems if MobileFontend would like to use the normal state of the controls and VE would like to use an alternati... [20:10:20] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1089882 (10cscott) @Trevor adding copying without changing `static` is the thing I was objecting to in option 4 above. I don't think that's a good idea.... [20:12:44] RoanKattouw: Special:Import is giving me "Import failed: Loss of session data. Please try again." on my localhost [20:12:59] I'm trying to import an export from en wiki so I can make a video for metrics [20:13:03] what's going on? [20:13:22] Have you tried doing it again? [20:13:27] yes [20:13:32] Usually it just means your session expired and if you try again it'll work [20:13:34] and logging in/out and trying it again [20:13:35] So it fails persistently? [20:13:37] several times [20:13:37] (03CR) 10Jforrester: [C: 032] SelectWidget: Add example and link to decorated option widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/194384 (owner: 10Kmenger) [20:13:37] yes [20:13:42] Does editing a page normally work? [20:13:59] (03CR) 10Jforrester: [C: 032] DecoratedOptionWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/194381 (owner: 10Kmenger) [20:14:12] RoanKattouw: yes [20:14:13] Through the wikitext editor I mean [20:14:17] lookin [20:14:41] yes [20:15:12] Hmm, weird [20:15:28] Normally "loss of session data" indicates your session store is broken, but if normal edits work that's probably not the case [20:15:42] well, it's a ~75mb file [20:15:50] maybe it's past my php upload limit [20:15:51] (03Merged) 10jenkins-bot: SelectWidget: Add example and link to decorated option widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/194384 (owner: 10Kmenger) [20:16:02] Oh that's entirely possible [20:16:04] Even likely [20:16:04] (03Merged) 10jenkins-bot: DecoratedOptionWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/194381 (owner: 10Kmenger) [20:16:05] i mean, that's certainly a confusing error if that's the problem, but [20:16:05] yeah [20:16:27] You should probably just import it from the command line [20:16:38] ok, how do I do that? [20:16:47] cd to MW core dir [20:16:52] a script in the maintenance dir somewhere? [20:17:00] yup [20:17:09] * TrevorParscal follows Roan's instructions [20:17:11] php maintenance/importDump.php --dry-run blah.xml [20:17:23] Then if that doesn't report anything scary, repeat without --dry-run [20:18:17] (03CR) 10Divec: [C: 032] "Clearly I need to focus more ..." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194148 (owner: 10Esanders) [20:18:38] (03PS4) 10Bartosz Dziewoński: [WIP] Tighten toolbar whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) [20:18:39] ok, that worked, doing it without dry-run and it's giving me warnings about failing to make a bunch of thumbnails because of write permissions issues [20:18:40] (03PS1) 10Bartosz Dziewoński: demo: Load styles before building demo widgets (not asynchronously) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 [20:18:49] * MatmaRex grumbles [20:18:56] and some preg_replace_callback() Compliation failed issues [20:19:15] OK, well [20:19:16] I may have an old version of Scribuntu [20:19:20] Hmm right [20:19:32] Well look at your recent changes page, see if things got imported right [20:19:41] it's still working [20:32:22] 10OOjs-UI, 7Technical-Debt: OOUI's GroupWidget and ItemWidget must die - https://phabricator.wikimedia.org/T91565#1089967 (10matmarex) 3NEW [20:33:44] (03PS1) 10Mooeypoo: Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) [20:34:08] (03PS1) 10Kmenger: GroupWidget and ItemWidget: Mark private [oojs/ui] - 10https://gerrit.wikimedia.org/r/194387 [20:34:58] MatmaRex, what do you think about ve.ui.MWCategoryWidget.prototype.addItems ? [20:35:01] (03CR) 10jenkins-bot: [V: 04-1] Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [20:35:11] (03CR) 10jenkins-bot: [V: 04-1] demo: Load styles before building demo widgets (not asynchronously) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [20:36:16] TrevorParscal: Is https://gerrit.wikimedia.org/r/#/c/194387/ right? [20:37:13] Krenair: thoughts that probably should not be shared in a logged channel, why? [20:37:53] (yes, the promisifying is weird and probably not supported in OOUI) [20:37:57] (03Merged) 10jenkins-bot: Fix typo in direction calculation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194148 (owner: 10Esanders) [20:39:13] MatmaRex, haha. I wondered if you might consider adding some way to do that properly [20:40:38] (03PS5) 10Bartosz Dziewoński: Tighten toolbar whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) [20:43:51] Krenair: which bug is this about? [20:45:25] MatmaRex, I don't think we have a bug for it [20:46:30] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1090027 (10bmansurov) @Jaredzimmerman-WMF, that makes sense. Currently we are not able to merge some of our patches because of this problem. If VE team can... [20:47:19] :o [20:47:25] Krenair: what issue is this about, then? [20:47:42] oh, there might have been something I blamed this on [20:47:46] looking at it a bit more, i see no reason why overriding addItems() like this would be problematic, actually. [20:47:51] on this* [20:48:07] I forgot what it was [20:49:20] well, other than the fact that you create items inside that method with `new ve.ui.MWCategoryItemWidget(…)`, so if MWCategoryItemWidget additems() is called with the same arguments twice, it might add the items twice too, because they will be different objects, and OOUI addItems() checks for existing items with just $.inArray [20:49:55] (so comparing object identity, and not object properties etc.) [20:51:43] oh, but it checks for this, it seems [20:52:07] and removes the duplicate [20:52:18] so it's a bit nasty, but it's likely to work correctly [20:52:30] (03CR) 10Bartosz Dziewoński: [C: 032] GroupWidget and ItemWidget: Mark private [oojs/ui] - 10https://gerrit.wikimedia.org/r/194387 (owner: 10Kmenger) [20:52:54] (03CR) 10Bartosz Dziewoński: "Related: T91565" [oojs/ui] - 10https://gerrit.wikimedia.org/r/194387 (owner: 10Kmenger) [20:53:20] (03CR) 10Bartosz Dziewoński: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [20:54:38] (03Merged) 10jenkins-bot: GroupWidget and ItemWidget: Mark private [oojs/ui] - 10https://gerrit.wikimedia.org/r/194387 (owner: 10Kmenger) [20:55:25] 10VisualEditor, 10VisualEditor-ContentEditable: Unused and/or broken code in ce.Surface selection fixup - https://phabricator.wikimedia.org/T91518#1090067 (10dchan) The code also assumes the cmp result will be -1|0|+1 instead of negative|zero|positive [20:55:52] 10OOjs-UI, 10VisualEditor: Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1090074 (10matmarex) a:3matmarex [21:08:59] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Database: Fix "DatabaseSqlite::replace/single-row NOT NULL constraint failed" for md_module table - https://phabricator.wikimedia.org/T91567#1090122 (10Krinkle) 3NEW a:3Krinkle [21:19:45] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Database: Fix "DatabaseSqlite::replace/single-row NOT NULL constraint failed" for md_module table - https://phabricator.wikimedia.org/T91567#1090196 (10Krinkle) [21:20:55] James_F: So... in todays episode of stuff is broken.. I've mostly exhausted the progress I can make without wasting time learning things that are better deferred to others. Athough the net number of issues has gone up in making that progress. [21:21:07] I want to work on something else now :P [21:25:58] 10WikiEditor, 7Browser-Support-Internet-Explorer, 7Testme, 7Upstream: Google toolbar spell check not compatible with WikiEditor - https://phabricator.wikimedia.org/T25518#1090225 (10TheDJ) 5Open>3declined a:3TheDJ [21:34:12] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Unit-tests: Fix "DatabaseSqlite::replace/single-row NOT NULL constraint failed" for md_module table - https://phabricator.wikimedia.org/T91567#1090255 (10Krinkle) [21:57:54] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, 5§ VisualEditor Q3 Blockers: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1090328 (10cscott) Reproduced the bug with https://en.wikipedia.org/w/index.php?title=User%3ACscot... [22:03:49] can someone remind me how to dump the HTML DOM which VE sends back to Parsoid for an edit? [22:04:02] Or, better yet, point me to the wiki page that explains this and other VE debugging techniques? [22:04:19] cscott: During which state? While having the editor open? [22:04:21] yes [22:04:30] MatmaRex or edsanders would be your best bet :) [22:04:32] cscott: https://www.mediawiki.org/wiki/Parsoid/Debugging#Dumping_HTML_DOM_before_save_in_VE [22:04:39] is probably what you mean [22:05:11] seems right, thanks. [22:05:42] (subbu pointed me to that a few days ago and i remembered) [22:07:14] Krinkle: Want me to give you something? [22:07:52] James_F: Depends. I'm currently picking up pieces and figuring out what I was doing earlier before stuff broke. [22:08:00] jquery.client? [22:08:06] infusion test/ [22:08:12] 10VisualEditor, 10VisualEditor-DataModel, 5§ VisualEditor Q3 Blockers: VisualEditor: Make transaction processing exception-safe - https://phabricator.wikimedia.org/T70892#1090338 (10Jdforrester-WMF) a:5Esanders>3Catrope [22:08:17] Infusion test got merged. [22:10:08] Krinkle: https://phabricator.wikimedia.org/T66772 would be good to work on if you want something totally not CI-related. [22:11:01] I merged MatmaRex's infusion test. Did that break things? (I was trusting jenkins would tell me if it did.) [22:11:15] hm? [22:11:35] oh, no, I think I misunderstood Krinkle. Something *else* broke, but he was reviewing the infusion test patch before he got distracted? [22:11:46] Yeah. [22:11:58] Yeah [22:12:20] 10VisualEditor: Image for Audio Clip Resizes - https://phabricator.wikimedia.org/T91574#1090342 (10MNguyen) 3NEW [22:12:30] ok, MatmaRex and I can go back to sleep now [22:14:34] James_F, I re-reviewed action.abort.type options and wanted to go through them with you (or RoanKattouw_away, oops) [22:14:35] (03PS8) 10Trevor Parscal: Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:14:49] (03CR) 10Trevor Parscal: [C: 032] Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:15:18] James_F, are you in a meeting or...? [22:15:38] James_F: Aye, that's a tricky one. A quick and dirty approach could work, but there's some target-related issues currently in progress to do it well. Mostly because of asynchronous callback potentially crossing the boundary between different contexts (e.g. if you go back to read mode or to editsource mode and the request comes back later). Not sure we have a good way of tagging along that kind [22:15:38] of stuff right now. [22:15:39] I'll see [22:15:43] Sounds fun [22:15:54] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Performance, 7Performance, 5§ VisualEditor Q3 Blockers: On VisualEditor load, async pre-load all the TemplateData for the page to make editing templates speedier - https://phabricator.wikimedia.org/T66772#1090352 (10Krinkle) a:5Catrope>3Krink... [22:16:37] meh [22:16:51] (03Merged) 10jenkins-bot: Fake toolbar group nesting [oojs/ui] - 10https://gerrit.wikimedia.org/r/193484 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:17:31] edsanders: how can I test https://gerrit.wikimedia.org/r/#/c/193370 ? [22:18:23] maybe I should send an email [22:27:29] (emailed) [22:28:25] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, 5§ VisualEditor Q3 Blockers: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1090416 (10cscott) Ah ha! ``` $ echo '
-- -

- 10VisualEditor, 10VisualEditor-Tables: Possibly unintended splitting of a table into two tables using VE - https://phabricator.wikimedia.org/T64510#1090420 (10Aklapper) 5Open>3stalled p:5Triage>3Low [22:30:07] 10VisualEditor, 10VisualEditor-Tables: Possibly unintended splitting of a table into two tables using VE - https://phabricator.wikimedia.org/T64510#663547 (10Aklapper) I'm setting this task's status to stalled as long as clear steps to reproduce are not known (plus this issue is now a year old). [22:36:52] 10VisualEditor: VisualEditor: The special character inserter tool should use the full width of the toolbar, rather than a narrow floating box - https://phabricator.wikimedia.org/T62770#1090459 (10Aklapper) > The floating palette for the special character tool is annoyingly out of reach if your cursor is at the... [22:40:22] 10VisualEditor: VisualEditor: adding a reference duplicates infobox on da.wp - https://phabricator.wikimedia.org/T61600#1090470 (10Aklapper) [22:41:27] (03PS1) 10Kmenger: LabelWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/194405 [22:46:34] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor:The Save page seems to continue for indefinite amount of time for a specific case - https://phabricator.wikimedia.org/T59898#1090481 (10Aklapper) 5Open>3stalled Could not reproduce on https://en.wikipedia.org/w/index.php?title=User%3AAKlapper_%28WMF... [22:51:37] 10VisualEditor: Page bump when editing a section in VE - https://phabricator.wikimedia.org/T88613#1090506 (10awight) Thanks for the ping! These both look like the same bug, I'll take the plunge and attempt to merge. [22:53:22] TrevorParscal, block images in core mix in alignable [22:53:33] 10VisualEditor: Page bump when editing a section in VE - https://phabricator.wikimedia.org/T88613#1090532 (10awight) [22:53:34] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: When editing a section, don't wait for loading to be complete before scrolling to the section - https://phabricator.wikimedia.org/T55217#1090533 (10awight) [22:53:35] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: No loading animation when editing a section deep down a page - https://phabricator.wikimedia.org/T52206#1090534 (10awight) [22:54:34] 10VisualEditor, 7I18n: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters - https://phabricator.wikimedia.org/T85093#1090539 (10Aklapper) [22:55:12] (03PS1) 10Divec: WIP: Fix arrow key fixups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 [22:55:44] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: No loading animation when editing a section deep down a page - https://phabricator.wikimedia.org/T52206#1090549 (10awight) I've merged in two related bug reports--please note that these bugs bring up an additional usability issue. If the GUI is not disab... [22:57:56] 10VisualEditor, 10VisualEditor-ContentEditable: Unused and/or broken code in ce.Surface selection fixup - https://phabricator.wikimedia.org/T91518#1090554 (10dchan) Hmm, this is interesting. - The code in afterDocumentKeyDown selects any focusable node that the focus has landed in or crossed (thereby clearin... [22:58:40] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Text in Templates is not found by VisualEditor's Find / Search - https://phabricator.wikimedia.org/T84920#1090556 (10Aklapper) p:5Triage>3Low [23:03:44] 10VisualEditor: VisualEditor got into endless visualeditoredit API loop when saving the page - https://phabricator.wikimedia.org/T91158#1090561 (10matmarex) Timo and Nik complained about running into this issue too. [23:04:19] 10VisualEditor: VisualEditor got into endless visualeditoredit API loop when saving the page - https://phabricator.wikimedia.org/T91158#1090564 (10Manybubbles) I believe I hit this today. I've since closed the tab so my browser is no use, sorry! [23:06:06] 10OOjs-UI: OOjs UI: Toolbar groups should support sub-groups as items - https://phabricator.wikimedia.org/T74159#1090567 (10Jdforrester-WMF) [23:06:08] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 5§ VisualEditor Q3 Blockers: Implement a way to nest toolbar groups without implementing nesting of toolbar groups - https://phabricator.wikimedia.org/T90815#1090565 (10Jdforrester-WMF) 5Open>3Resolved [23:11:35] (03PS1) 10Kmenger: IndicatorWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/194410 [23:15:37] James_F: can I merge ? [23:18:54] 10VisualEditor: VisualEditor got into endless visualeditoredit API loop when saving the page - https://phabricator.wikimedia.org/T91158#1090605 (10matmarex) VisualEditor definitely does quite a bit of manual token handling instead of using `postWithToken` (although I don't see obvious mistakes at a glance). Not... [23:23:37] 10VisualEditor: VisualEditor got into endless visualeditoredit API loop when saving the page - https://phabricator.wikimedia.org/T91158#1090619 (10RobLa-WMF) I'm pretty sure I hit this bug when I made [this edit on mediawiki.org on 2015-02-26](https://www.mediawiki.org/w/index.php?title=CirrusSearch/BlogDraft&di... [23:25:32] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor got into endless visualeditoredit API loop when saving the page - https://phabricator.wikimedia.org/T91158#1090627 (10Krenair) [23:29:31] James_F: ping? [23:29:35] 10VisualEditor, 10VisualEditor-CopyPaste, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: Editor freezes after copypasting a reference and trying to insert a references list - https://phabricator.wikimedia.org/T89943#1090642 (10Etonkovidova) [23:32:15] he's marked as away [23:32:44] Hey. [23:32:46] Here now. [23:33:14] ori: https://gerrit.wikimedia.org/r/#/c/112590/ should probably have a note first. [23:33:32] 10OOjs-UI, 10OOjs-UI-0.8.1, 10VisualEditor, 7Browser-Support-Apple-Safari, and 5 others: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1090653 (10Etonkovidova) [23:33:46] ori: I'll write a note in next week's Tech News. [23:34:10] seems overly-timid to me, but your call [23:34:15] (03PS1) 10Mooeypoo: Show the field's example if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194416 (https://phabricator.wikimedia.org/T53049) [23:36:01] 10VisualEditor, 10VisualEditor-Tables: Menu items in table popup widget (e.g. "Insert before") truncated in most languages (box not wide enough) - https://phabricator.wikimedia.org/T78119#1090662 (10Aklapper) [23:36:14] Krenair: I'm back now, BTW – you had a question earlier? [23:36:26] I sent an email [23:36:41] Aha. [23:36:43] * James_F looks. [23:37:16] (03CR) 10Jforrester: [C: 032] LabelWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/194405 (owner: 10Kmenger) [23:37:19] (03CR) 10Trevor Parscal: [C: 04-1] "There's gotta be a way to make this more compact, or at least not repeat the left align icon in the interface (also being used as the icon" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193370 (owner: 10Esanders) [23:39:14] (03Merged) 10jenkins-bot: LabelWidget: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/194405 (owner: 10Kmenger) [23:39:30] (03CR) 10Jforrester: [C: 032] IndicatorWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/194410 (owner: 10Kmenger) [23:41:02] MatmaRex: Want to do some last-minute heroics to get https://gerrit.wikimedia.org/r/#/c/194197/ into this week's OOjs UI release? [23:41:10] MatmaRex: https://gerrit.wikimedia.org/r/#/c/194385/1/demos/demo.js,unified [23:41:24] i'm pretty sure those aren't going to fire in all browsers [23:41:31] (03Merged) 10jenkins-bot: IndicatorWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/194410 (owner: 10Kmenger) [23:41:35] 10VisualEditor, 10VisualEditor-Tables: Menu items in table popup widget (e.g. "Insert before") truncated in most languages (box not wide enough) - https://phabricator.wikimedia.org/T78119#1090670 (10Aklapper) The three options are truncated in most languages I tried in Firefox 36: {F55266} Still wondering what... [23:41:39] MatmaRex: what did you test with already? [23:46:23] 10TemplateData, 5Patch-For-Review, 7Verified-in-Phase0, 5WMF-deploy-2015-03-04_(1.25wmf20): Template Documentation Editor: Suggested, Required, Deprecated values cannot be unset - https://phabricator.wikimedia.org/T90283#1090685 (10Etonkovidova) [23:46:24] (03PS2) 10Mooeypoo: Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) [23:46:51] 10VisualEditor, 10VisualEditor-EditingTools, 7I18n: Load charset into special characters option - https://phabricator.wikimedia.org/T64919#1090688 (10Aklapper) [23:49:36] (03CR) 10Trevor Parscal: [C: 04-1] demo: Load styles before building demo widgets (not asynchronously) (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [23:50:00] 10TemplateData, 5Patch-For-Review: TemplateData: Provide property "example" for template parameters - https://phabricator.wikimedia.org/T53049#1090723 (10Mooeypoo) a:3Mooeypoo [23:50:12] James_F: do you know if Krinkle will be around any time soon, or is he done for the day? [23:50:30] ori: Don't know; he's probably done. [23:51:19] nod [23:52:27] (03PS1) 10Jforrester: Tag v0.9.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/194417 [23:52:40] (03CR) 10Trevor Parscal: [C: 032] Tag v0.9.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/194417 (owner: 10Jforrester) [23:54:40] (03Merged) 10jenkins-bot: Tag v0.9.0 [oojs/ui] - 10https://gerrit.wikimedia.org/r/194417 (owner: 10Jforrester) [23:56:06] James_F: maybe [23:56:08] oh, too late [23:56:32] MatmaRex: Yeah. :-( [23:56:35] Next week. [23:56:36] James_F: the problem with that is that it only works when you append the TextInputWidget itself, and not when you wrap it in FieldLayout for example [23:56:45] Oooh. [23:56:49] so, basically, it doesn't work [23:56:50] Yeah, that's unhelpful. [23:57:11] i can fix that, but then you get the mysterious performance impact again [23:57:12] 10VisualEditor, 10VisualEditor-Performance: ve.init.mw.ViewPageTarget.prototype.setupToolbar called twice - https://phabricator.wikimedia.org/T91595#1090740 (10ori) 3NEW a:3Krinkle [23:57:26] * James_F nods. [23:57:32] i'm going to try doings things with it, eh [23:57:44] TrevorP|Away: it allegedly doesn't always work with mobile browsers, or some such [23:58:13] but apart from that should be reliable [23:58:38] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your curs... - https://phabricator.wikimedia.org/T70590#1090750