[00:03:09] (03PS1) 10Jforrester: Update OOjs UI to v0.9.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194420 [00:04:40] MatmaRex: We are meant to support mobile. :-) [00:05:19] (03CR) 10Esanders: "Suggestions?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193370 (owner: 10Esanders) [00:05:40] James_F: sure, but this is just the demo [00:05:47] git remote update && git checkout master && git checkout -Boojs-ui-0.9.0 && nano composer.json && php composer.phar update && git add oojs && git add -p && git commit && git review [00:05:49] Umm. [00:05:53] I mean, yes. [00:05:56] (Sorry.) [00:06:08] (03PS6) 10Bartosz Dziewoński: Tighten toolbar whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) [00:06:14] Looks like James_F is having fun. [00:06:38] (03CR) 10Bartosz Dziewoński: "(Removed the dependency on https://gerrit.wikimedia.org/r/#/c/194385/, which is for the demo only and may or may not work.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) (owner: 10Bartosz Dziewoński) [00:07:02] Krenair: It's almost like I've made it very simple for myself. :-) [00:07:11] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.9.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194420 (owner: 10Jforrester) [00:07:23] Oh really? [00:07:36] I think Jenkins heard you. [00:08:26] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Verified-in-Phase0, and 2 others: Show the VisualEditor toolbar/editor chrome as soon as VE scripts are loaded, rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#1090781 (10Etonkovidova) [00:09:44] Krenair: Yeah, jsduck being irritating again. [00:10:56] Eurgh. [00:11:05] :) [00:11:07] And Krinkle's broken how jsduck config works and now it's not obvious how to fix. [00:11:32] Krenair: Do you have any idea where to set --external now? [00:11:56] Nope. [00:11:56] There's external.js but that's looking for links which I didn't have to set before. [00:12:00] Maybe MatmaRex knows? [00:13:20] eh [00:13:30] looking [00:13:34] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 7Verified-in-Phase0, and 2 others: Context menu moves to middle of inline selection when an inspector is opened - https://phabricator.wikimedia.org/T90857#1090799 (10Etonkovidova) [00:13:46] They're specified in https://github.com/senchalabs/jsduck/blob/master/lib/jsduck/external_classes.rb so I guess it'd Just Work™. [00:15:34] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1090810 (10Etonkovidova) [00:17:46] (03PS2) 10Jforrester: MWParameterPage: Show the field's example if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194416 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [00:19:07] (03CR) 10Bartosz Dziewoński: demo: Load styles before building demo widgets (not asynchronously) (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [00:20:12] James_F: well, why not in the external.js files? [00:20:22] in .jsduck [00:20:27] MatmaRex: I have no idea how they work, but they don't have the same config. [00:20:32] or .docs in ve-mw [00:20:39] This is for ve-core. [00:20:40] okay… me neither then [00:20:48] Previously it was just "--external": "HTMLDocument,Window,Node,Set,Range,Selection,ClientRect,File,Blob,DataTransfer,DataTransferItem", [00:20:58] Now I have to give a link for each thing? Where to? [00:21:30] James_F: jsduck.json still exists? [00:21:38] or do i have old version? [00:21:48] Ooooh, it got renamed and I didn't see the new one. [00:21:50] OK, that's easy. [00:23:43] (03PS2) 10Jforrester: Update OOjs UI to v0.9.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194420 [00:23:51] Thanks, MatmaRex. [00:24:00] In return, want to be the one to throw the switch? :-) [00:24:08] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.9.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194420 (owner: 10Jforrester) [00:24:11] 10VisualEditor, 7Verified-in-Phase0, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: [Regression pre-wmf20] Reference and Media caption surfaces have broken layout - https://phabricator.wikimedia.org/T91145#1090819 (10Etonkovidova) [00:24:30] off now. good night [00:24:41] (03CR) 10Jforrester: [C: 04-1] "One question." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194416 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [00:24:44] See you. :-) [00:24:55] MatmaRex: Don't want to V+2 the /vendor one? :-) [00:26:10] (03Merged) 10jenkins-bot: Update OOjs UI to v0.9.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194420 (owner: 10Jforrester) [00:28:54] 10VisualEditor: [Reression-20] Media->Caption - Special Character inserter does not work - https://phabricator.wikimedia.org/T91600#1090822 (10Etonkovidova) 3NEW [00:29:09] 10OOjs-UI, 5OOjs-UI-0.9.0, 5OOjs-UI-next-release, 7Accessibility: PopupButtonWidget menu is not keyboard traversable/closeable - https://phabricator.wikimedia.org/T87695#1090829 (10Jdforrester-WMF) [00:29:33] 10OOjs-UI, 5OOjs-UI-0.9.0, 10VisualEditor, 5WMF-deploy-2015-03-11_(1.25wmf21), 5§ VisualEditor Q3 Blockers: Implement a way to nest toolbar groups without implementing nesting of toolbar groups - https://phabricator.wikimedia.org/T90815#1090831 (10Jdforrester-WMF) [00:29:34] 10OOjs-UI, 5OOjs-UI-0.9.0, 7Accessibility, 5WMF-deploy-2015-03-11_(1.25wmf21): PopupButtonWidget menu is not keyboard traversable/closeable - https://phabricator.wikimedia.org/T87695#996868 (10Jdforrester-WMF) [00:29:35] 10OOjs-UI, 5OOjs-UI-0.9.0, 5Patch-For-Review, 5WMF-deploy-2015-03-11_(1.25wmf21): OO.ui.ActionFieldLayout doesn't properly accept a jQuery for its label config value - https://phabricator.wikimedia.org/T90936#1090834 (10Jdforrester-WMF) [00:29:35] 10OOjs-UI, 5OOjs-UI-0.9.0, 10VisualEditor, 10VisualEditor-MediaWiki, and 2 others: "Nested" dialogs (template inside a basic reference) break the OOUI hack to prevent scrolling while dialog is open - https://phabricator.wikimedia.org/T89613#1090833 (10Jdforrester-WMF) [00:29:37] 10OOjs-UI, 5OOjs-UI-0.9.0, 5Patch-For-Review, 5WMF-deploy-2015-03-11_(1.25wmf21): Icon containers should always be the same size so we can use background-size: contain - https://phabricator.wikimedia.org/T85139#1090832 (10Jdforrester-WMF) [00:33:57] 10VisualEditor: [Regression-20] Media->Caption - Special Character inserter does not work - https://phabricator.wikimedia.org/T91600#1090850 (10Etonkovidova) [00:35:44] 10VisualEditor: [Regression wmf20] Special Character inserter does not work in Media captions - https://phabricator.wikimedia.org/T91600#1090853 (10Jdforrester-WMF) [01:41:45] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References: [Regression wmf20] Special Character inserter does not work in Media captions or basic references - https://phabricator.wikimedia.org/T91600#1090982 (10Jdforrester-WMF) p:5High>3Normal [01:42:30] 10VisualEditor, 10VisualEditor-MediaWiki: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1090985 (10Jdforrester-WMF) 3NEW [01:45:13] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20): At certain browser zoom levels, the special characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1091006 (10Jdforrester-WMF) a:3Esanders [01:45:27] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20): At certain browser zoom levels, the special characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1027607 (10Jdforrester-WMF) Looks like this is fixed with the new design. [01:45:51] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20): At certain browser zoom levels, the special characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1091011 (10Jdforrester-WMF) 5Open>3Resolved [02:03:03] 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, 5§ VisualEditor Q3 Blockers: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1091033 (10KHammerstein) [02:03:44] 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, 5§ VisualEditor Q3 Blockers: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#676536 (10KHammerstein) [02:11:39] (03CR) 10Prtksxna: Syncing some button styles with MediaWiki UI (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) (owner: 10Kaldari) [02:25:32] (03PS13) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) [02:25:44] (03PS14) 10Alex Monk: [WIP] Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) [03:31:11] 10OOjs-UI, 10VisualEditor: List of proposals when searching templates in VE is narrow (same width as the search field itself though space available) - https://phabricator.wikimedia.org/T86713#1091110 (10Sunpriat) then why not put the button in the upper right corner [04:02:54] 10OOjs-UI, 10OOjs-UI-0.8.1, 10VisualEditor, 7Browser-Support-Apple-Safari, and 3 others: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#1091156 (10Ryasmeen) [05:00:01] (03CR) 10Kaldari: Syncing some button styles with MediaWiki UI (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) (owner: 10Kaldari) [05:47:59] (03PS1) 10Legoktm: Add composer entry point for phpcs and linting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194456 (https://phabricator.wikimedia.org/T90943) [05:59:39] 10VisualEditor, 15Roadmap, 10Wikimedia-Site-requests, 7Epic: Run test of having VisualEditor on for some newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90666#1091242 (10Eloquence) [06:00:46] 10VisualEditor, 15Roadmap, 10Wikimedia-Site-requests, 7Epic: Run test of having VisualEditor on for some newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90666#1064348 (10Eloquence) Added to #roadmap for late March 2015 (**stretch goal** per Q3 goals). [06:01:37] (03PS5) 10Kaldari: Syncing some button styles with MediaWiki UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) [06:03:14] (03PS6) 10Kaldari: Syncing some button styles with MediaWiki UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) [06:16:37] (03CR) 10Prtksxna: [C: 031] Syncing some button styles with MediaWiki UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) (owner: 10Kaldari) [08:34:31] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#1091521 (10Pine) Would anyone object to bumping up the priority of this to normal? [08:40:44] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Unit-tests: Fix "DatabaseSqlite::replace/single-row NOT NULL constraint failed" for md_module table - https://phabricator.wikimedia.org/T91567#1091539 (10hashar) [08:45:59] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Unit-tests: Fix "DatabaseSqlite::replace/single-row NOT NULL constraint failed" for md_module table - https://phabricator.wikimedia.org/T91567#1091546 (10hashar) [09:06:49] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20): At certain browser zoom levels, the special characters « » are shown one above the other in insertion tools - https://phabricator.wikimedia.org/T89109#1091588 (10Aklapper) Verified; indeed fixed for me on http://en.wikipedia.bet... [09:26:57] 10VisualEditor: VisualEditor: The special character inserter tool should use the full width of the toolbar, rather than a narrow floating box - https://phabricator.wikimedia.org/T62770#1091618 (10Aklapper) 5Open>3Resolved a:3Aklapper Fixed by the "Special Characters" insertion redesign (can be tested alre... [09:45:05] (03CR) 10Zfilipin: "Yes please, if anything is unclear do ask at QA mailing list. I think the changes to Gemfile.lock should stay in the commit." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [09:57:49] [10:52] wikibugs [2015-03-04 14:12:18] VisualEditor, VisualEditor-EditingTools, VisualEditor-Performance, Performance, § VisualEditor Q3 Blockers: On VisualEditor load, async pre-load all the TemplateData for the page to make editing templates speedier - https://phabricator.wikimedia.org/T66772#1090352 (Krinkle) a:Catrope>Krink... [09:58:01] Krinkle|detached: If you're going to work on that, please base your code on my TargetLoader refactor [09:58:09] Krinkle|detached: And also help me finish my TargetLoader refactor [09:58:23] That's much higher priority than that TemplateData thing [10:03:20] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Bulleted bullets and bulleted headers produced; can't save - https://phabricator.wikimedia.org/T54639#1091705 (10Thryduulf) I don't recall this error, and I too can't reproduce anything now using Firefox 30. Given that it's been ~18 months since th... [10:09:36] 10VisualEditor, 10VisualEditor-ContentEditable: Visual editor: issues with removing leading space pre blocks - https://phabricator.wikimedia.org/T53758#1091714 (10Thryduulf) >>! In T53758#1088912, @Aklapper wrote: >> * When the pre-formatted block follows a mutli-line template, that template is deleted and the... [10:11:18] 10VisualEditor: Visual Editor default configuration - https://phabricator.wikimedia.org/T90854#1091715 (10Aklapper) 5Open>3stalled Thanks for taking the time to report this! Could you please provide specific steps to reproduce, step by step, as a list, which allow no "interpretation" of how to reproduce the... [10:12:37] 10VisualEditor: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#1091717 (10Aklapper) [10:12:57] 10VisualEditor: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#1069602 (10Aklapper) >>! In T90864#1070430, @Jdforrester-WMF wrote: > There's already a GuidedTour kicked off by the GettingStarted system for the first-time wikitext edit experience; is this insuff... [10:25:25] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: VisualEditor got into endless visualeditoredit API loop when saving the page - https://phabricator.wikimedia.org/T91158#1091735 (10Aklapper) p:5Normal>3High [10:30:44] 10VisualEditor, 10VisualEditor-EditingTools: Table blocks text - https://phabricator.wikimedia.org/T78138#1091737 (10Aklapper) 5Open>3stalled @Jopparn: Thanks for taking the time to report this! > The problem is that the box currently covers around 30% of the line of text above the table. Could you pleas... [10:32:28] 10VisualEditor, 10VisualEditor-EditingTools: Table context indicator partially covers text in line above table - https://phabricator.wikimedia.org/T78138#1091739 (10Aklapper) [10:36:16] 10MediaWiki-ResourceLoader, 10VisualEditor: Devise a means of testing local code on production wikis - https://phabricator.wikimedia.org/T87384#1091746 (10Aklapper) @ori: Does matmarex' comment fulfil your needs? If yes, should this be documented somewhere (where?) and this ticket closed? [10:39:39] 10VisualEditor: Cursor positioned too high (like superscript) when adding new item to numbered list - https://phabricator.wikimedia.org/T86928#1091754 (10Aklapper) [10:40:20] 10VisualEditor: Cursor positioned too high (like superscript) when adding new item to numbered list - https://phabricator.wikimedia.org/T86928#979633 (10Aklapper) p:5Triage>3Low I can confirm this in Firefox 36 and Google Chrome 41. [10:40:31] 10VisualEditor, 10VisualEditor-ContentEditable: Cursor positioned too high (like superscript) when adding new item to numbered list - https://phabricator.wikimedia.org/T86928#1091757 (10Aklapper) [10:41:54] 10VisualEditor, 10VisualEditor-ContentLanguage, 7I18n: VisualEditor: Cursor skips by one character for Thai characters (expected skipping by one block) - https://phabricator.wikimedia.org/T64028#1091758 (10Aklapper) [10:48:52] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: Implement script-specific cursoring for Devanagari if native cursoring is insufficient - https://phabricator.wikimedia.org/T55754#1091762 (10Aklapper) [10:49:30] (03PS1) 10Amire80: Update Gemfile.lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194486 [10:50:01] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: Implement script-specific cursoring for Devanagari if native cursoring is insufficient - https://phabricator.wikimedia.org/T55754#549766 (10Aklapper) >>! In T55754#549797 in October 2013, @Jdforrester-WMF wrote: > we're switching back to native curs... [10:51:20] (03PS2) 10Zfilipin: [BrowserTest] Update Ruby gems [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194486 (owner: 10Amire80) [10:51:43] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Update Ruby gems [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194486 (owner: 10Amire80) [10:54:29] (03Merged) 10jenkins-bot: [BrowserTest] Update Ruby gems [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194486 (owner: 10Amire80) [10:59:28] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor: Cursor jumps to the beginning of the sentence/paragraph when using jquery.IME - https://phabricator.wikimedia.org/T56283#1091783 (10Aklapper) I've set my Language settings on https://en.wikipedia.org to using native keyboard for Hindi input. > 5)Cl... [11:14:33] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Feedback dialogs not scrolled to when editing section on long page - https://phabricator.wikimedia.org/T55173#1091810 (10Aklapper) 5Open>3stalled @Greenrd: Sorry that this task has not received feedback earlier, and thank you for reporting this! > I... [11:19:00] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Feedback dialogs not scrolled to when editing section on long page - https://phabricator.wikimedia.org/T55173#1091816 (10Aklapper) Ahm, I'm sorry (obviously requires VE to be enabled to see those section heading links). Tried on http://en.wikipedia.beta.w... [11:22:28] 10VisualEditor, 10VisualEditor-ContentLanguage, 7I18n: VisualEditor: Typing problem in Assamese - https://phabricator.wikimedia.org/T54726#1091820 (10Aklapper) Is what is left to do in this ticket "just" a duplicate of {T51569}? Or is there more to do (if so, what?) [11:37:32] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: Allow inserting non-breakable space ( ) - https://phabricator.wikimedia.org/T86636#1091838 (10Aklapper) [11:37:52] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: Allow inserting non-breakable space ( ) - https://phabricator.wikimedia.org/T86636#973156 (10Aklapper) p:5Triage>3Low UI-wise, could probably be added as a special character? [12:27:36] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#1091883 (10Aklapper) @Pine: Yes I'd object. :) Please see T53154#536989 [13:18:11] MatmaRex: In the oojs/ui demo page, do you see the correct color for the icon in ButtonWidget (frameless, progressive)‎? [13:18:35] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#1091934 (10matmarex) [13:20:30] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#536893 (10matmarex) I updated the description with information about the gadget implementing this feature. [13:21:00] prtksxna: what is the correct color? [13:21:14] the icon i see is black. [13:21:23] MatmaRex: Blue? [13:21:27] MatmaRex: The destructive and constructive ones have colored icons. [13:22:37] yeah… i think the icon doesn't have the progressive variant defined. [13:22:54] the colored variants available for each icon are defined in the images.json file [13:22:59] Right [13:23:08] and i don't think anybody has really thought about them [13:23:24] MatmaRex: Should all icons be in these three colors by default. Green trash cans etc. [13:23:25] the ones available now are basically just the "placeholders" i created when developing the feature with trevor [13:23:37] I see white and gold. (joke) [13:23:42] hah [13:24:04] i think it was decided that we should only use the ones that make sense - so, no constructive trash cans, no destructive plus icons [13:24:28] but nobody bothered to think it through and decide which ones make sense :) [13:24:29] MatmaRex: Makes sense. I might change the icon, just on the demo page. [13:24:41] Its been bothering me :P [13:24:50] yeah. it's a bug, definitely [13:24:58] there don't seem to be any progressive icons defined at all, apparently [13:25:17] only variants are: [13:25:19] "add": { "file": "add.svg", "variants": [ "constructive" ] }, [13:25:19] "check": { "file": "check.svg", "variants": [ "constructive" ] }, [13:25:19] "remove": { "file": "remove.svg", "variants": [ "destructive" ] }, [13:25:23] and [13:25:24] "circle": { "file": "circle.svg", "variants": [ "constructive" ] }, [13:25:32] which is a hack for the radio buttons, really [13:26:15] Yeah, I just saw… [13:26:36] so yeah, if you want to do this work, i'm sure no one would mind :) [13:26:45] I'll make the check progressive then, its an alright use case — like on a "Done" button [13:27:01] MatmaRex: You mean actually figure out which icon *could* need which variants? [13:27:21] yeah [13:27:35] and yep, just doing one would also work [13:29:22] I'll ask… [13:33:16] (03PS1) 10Prtksxna: MediaWiki Theme: Add the progressive variant to the check icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/194506 [13:46:07] (03CR) 10Bartosz Dziewoński: [C: 032] MediaWiki Theme: Add the progressive variant to the check icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/194506 (owner: 10Prtksxna) [13:48:21] (03Merged) 10jenkins-bot: MediaWiki Theme: Add the progressive variant to the check icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/194506 (owner: 10Prtksxna) [14:39:29] (03PS1) 10Bartosz Dziewoński: demo: Fix typo in toolbars demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/194518 [15:09:33] Hey. [15:16:24] (03PS1) 10Bartosz Dziewoński: Fold text style dropdown into basic text style bar in toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) [15:16:47] morning, James_F [15:17:01] * James_F frantically tries to repair his development machine to take a video for Metrics. [15:34:20] (03CR) 10Bartosz Dziewoński: [C: 032] Syncing some button styles with MediaWiki UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) (owner: 10Kaldari) [15:50:06] (03PS1) 10Mvolz: [WIP] Update translators and citoid to master [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194536 [16:01:51] (03PS2) 10Mvolz: [WIP] Update translators and citoid to master [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194536 (https://phabricator.wikimedia.org/T89756) [16:10:35] (03CR) 10Bartosz Dziewoński: demo: Load styles before building demo widgets (not asynchronously) (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [16:16:52] 10VisualEditor, 10Wikimedia-Site-requests, 5Patch-For-Review, 7user-notice: Disable "Beta" suffixes on tabs for VisualEditor opt-in wikis - https://phabricator.wikimedia.org/T60583#1092336 (10gpaumier) [16:25:08] (03PS1) 10Alexandros Kosiaris: Remove the zotero translation server and translators [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194548 (https://phabricator.wikimedia.org/T89872) [16:26:56] (03CR) 10Mvolz: [C: 031] Remove the zotero translation server and translators [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194548 (https://phabricator.wikimedia.org/T89872) (owner: 10Alexandros Kosiaris) [16:29:58] (03CR) 10Mvolz: "My only comment re: translators is I have been modifying the google books one to work with translation-server (flag 'v') in "production"- " [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194548 (https://phabricator.wikimedia.org/T89872) (owner: 10Alexandros Kosiaris) [16:32:10] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10UI-Standardization, and 3 others: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1092412 (10Jdforrester-WMF) [16:32:11] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Verified-in-Phase0, and 3 others: Show the VisualEditor toolbar/editor chrome as soon as VE scripts are loaded, rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#1092408 (10Jdforrester-WMF) [16:32:12] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-04_(1.25wmf20), 7user-notice, 5§ VisualEditor Q3 Blockers: Adjust the context menu to be able to display richer data for tools that want it - https://phabricator.wikimedia.org/T89054#1092409 (10Jdforrester-WMF) [16:32:13] 10VisualEditor, 10VisualEditor-ContentEditable, 10Citoid, 7Design, and 3 others: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#1092410 (10Jdforrester-WMF) [16:34:39] 10VisualEditor, 10MediaWiki-General-or-Unknown: What you see is not what you get : the references disappear after change of their template - https://phabricator.wikimedia.org/T91654#1092421 (10Nnemo) 3NEW [16:40:59] 10VisualEditor, 10MediaWiki-General-or-Unknown: [What you see is not what you get] The references disappear after change of their template - https://phabricator.wikimedia.org/T91654#1092451 (10Nnemo) [16:45:49] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Possible-Tech-Projects: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1092492 (10Mvolz) I can offer moral/ VE installation support but I'd need another editing team member to co-mentor for the nitty gritty. [16:54:09] (03PS3) 10Mvolz: [WIP] Update citoid to master and localsettings.js [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194536 (https://phabricator.wikimedia.org/T89756) [16:55:15] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Possible-Tech-Projects: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1092531 (10NiharikaKohli) @Mvolz that's great! [17:00:28] 10VisualEditor, 10VisualEditor-EditingTools: [Regression pre-wmf21] Comment icon is now huge - https://phabricator.wikimedia.org/T91656#1092549 (10Jdforrester-WMF) 3NEW [17:18:03] (03PS4) 10Mvolz: [WIP] Add ability to request AcceptLanguage [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 [17:20:03] (03PS5) 10Mvolz: [WIP] Add ability to request AcceptLanguage [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 [17:36:41] Hello! There's a VE-related task in the buffer for the upcoming GSoC/Outreachy round. https://phabricator.wikimedia.org/T89287 Mvolz has offered to be a mentor. We need another mentor to pop it out of the queue and onto the desk. Anyone who's interested in mentoring and has the time for that? Comments and general discussion about the task is very welcome! [17:41:25] Niharika, mvolz hi! [17:41:36] Hi mooeypoo. [17:41:53] I hear there's a potential GSoC idea [17:41:59] heya Niharika [17:42:00] Bingo. [17:42:05] Awesome :) [17:42:28] mooeypoo: it's a bit above my paygrade but I'm willing to support "I can't ve to work!!!" panic and the like [17:42:34] * Niharika is mentor-hunting [17:42:41] James_F: Not so quick :) Those jsduck errors were nothing out of the ordinary. OOjs UI added more native types. The jsduck update didn't change that. [17:42:52] mvolz, I'll be happy to join in on that [17:42:54] I accidentally a word but you get the idea. [17:43:08] Yeah, it just got renamed. [17:43:09] mvolz,it's okay, I accidentally a words all the time [17:43:10] Krinkle: Yeah, I worked out where you'd moved the damn jsduck config. :-P [17:43:39] Niharika, do you have a project in mind [17:44:01] mooeypoo: I...am not a prospective student, if that's what you're thinking. [17:44:15] RoanKattouw_away: Yeah, I was gonna ask you about the template data batching. Got a few different ideas about collecting it, but not sure what works best with our model. Iterating over the linmod after it's done seems most quick/dirty but not very performant or scalable I imagine. [17:44:22] mooeypoo: https://phabricator.wikimedia.org/maniphest/query/wD5d_PpG53g2/#R [17:44:35] mooeypoo: they need people specifically to mentor this task: https://phabricator.wikimedia.org/T89287 [17:44:37] Niharika, oh, okay, I assumed [17:44:51] it is to get ve to work with maps extension, which looks hard to me :). [17:45:00] I'm a co-organizer for the upcoming round, working with Quim. [17:45:17] that's why I'd need someone else to mentor [17:45:37] in addition [17:45:46] Right. We need two mentors. [17:46:10] mooeypoo: Thoughts? [17:46:17] Niharika, hm. Okay, I"m looking at this page. [17:46:30] Does Yuri not want to mentor? [17:46:35] Niharika, I'd love to help with this. It looks like it may be similar to the TemplateData editor we currently have for editing json outside of VE [17:46:42] The Graph extension is his project after all. [17:46:44] however, we will likely need Parsoid here too [17:46:50] Yeah. [17:47:13] Niharika, we don't seem to have the actual data being transfered to VE from Parsoid about the json blob, that would be something we need to ask Parsoid to send us [17:47:59] mooeypoo: Okay. So could you add a comment about that on the task? So I can ping Parsoid folks and ask them to comment back and push this from nowhere to somewhere. [17:48:08] will do [17:48:12] Thanks! [17:49:21] And in general, if there are other potential VE related tasks befitting a GSoC timeframe, they are welcome to be added to Possible-Tech-Projects workboard. [17:50:42] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Possible-Tech-Projects: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1092746 (10Mooeypoo) I'd love to help with this as well. It looks like this would involve making something somewhat similar to the TemplateData json-string editor... [17:50:46] Niharika, I commented [17:51:13] What other projects do people think would be good VisualEditor-related GSoC/OPW projects? [17:51:43] 10VisualEditor, 10VisualEditor-Performance: ve.init.mw.ViewPageTarget.prototype.setupToolbar called twice - https://phabricator.wikimedia.org/T91595#1092750 (10Krinkle) This is probably related to the dummy toolbar we have. Before the document is requested, parsed and converted, we create a dummy toolbar that... [17:51:51] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, 6Services: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1092751 (10Mvolz) [17:59:12] (03PS6) 10Mvolz: Add ability to request AcceptLanguage [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 [18:04:27] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 7Blocked-on-Editing, 5Patch-For-Review: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#1092773 (10RobLa-WMF) [18:05:20] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 7Blocked-on-Editing, 5Patch-For-Review: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#942722 (10RobLa-WMF) The people that have the expertise to review this a... [18:07:00] (03PS7) 10Mvolz: Add ability to request AcceptLanguage [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 [18:09:39] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, 6Services: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1092795 (10NiharikaKohli) [18:11:16] (03CR) 10Bartosz Dziewoński: [C: 032] Syncing some button styles with MediaWiki UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) (owner: 10Kaldari) [18:11:56] (03CR) 10Bartosz Dziewoński: "Not sure if this affects VE-MW." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [18:13:13] (03Merged) 10jenkins-bot: Syncing some button styles with MediaWiki UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/194155 (https://phabricator.wikimedia.org/T88449) (owner: 10Kaldari) [18:13:13] 10OOjs-UI, 10VisualEditor: Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1092801 (10matmarex) 5Open>3Resolved Yuppp, works perfectly. [18:13:24] 10OOjs-UI, 10VisualEditor: Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1092804 (10matmarex) a:5matmarex>3Prtksxna [18:15:03] (03PS15) 10Alex Monk: Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) [18:16:48] edsanders: https://phabricator.wikimedia.org/T91656 is icky. [18:17:42] 10OOjs-UI, 10VisualEditor, 5WMF-deploy-2015-03-04_(1.25wmf20): Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1092821 (10Jdforrester-WMF) [18:18:31] (03PS16) 10Alex Monk: Schema:Edit instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) [18:19:14] Krinkle: Rather than the template data batching I'd prefer to focus on finishing the TargetLoader commit for now [18:20:03] Krinkle: A lot of code in the activation code path, especially the early toolbar stuff and .ve-activating, is not very compatible with being run late [18:20:16] TargetLoader fires the API request very early but runs the VPT code later [18:20:24] Right now it runs the VPT code only when the API request is done [18:20:39] I was thinking of refactoring that so it could be passed a dataPromise rather than a data object [18:20:58] But still, we'll have to figure out what to move into TargetLoader or init init and what to keep in VPT and in what form [18:21:14] Stuff like .ve-activating will probably need to happen as early as possible [18:22:04] RoanKattouw: How's the video coming? [18:22:12] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, 6Services: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1092849 (10marcoil) Parsoid already includes the graph data JSON in the metadata for editing. If you go to http://parsoid.wmflabs.org/medi... [18:22:20] I have a WT video that I'll send you [18:22:23] 10VisualEditor, 10MediaWiki-extensions-EasyTimeline, 10Possible-Tech-Projects: EasyTimeline: in-browser visual editing - https://phabricator.wikimedia.org/T29157#1092851 (10Jdforrester-WMF) [18:22:24] Ta. [18:22:28] Just DropBox it or whatever. [18:22:38] For VE I think I'll use my standard local hack [18:22:46] Sure. [18:22:48] It will look a bit weird [18:25:27] hmm [18:26:10] RoanKattouw: Weird but working is OK. Just do it. :-) [18:26:13] Krinkle: jQuery trick question. is the order of elements returned by .parents() specified, and why is it different than the order of any other collection? the is at the end, not at the beginning, and allegedly jQuery collections are sorted in document order. [18:28:14] (03PS1) 10Mvolz: [WIP] Outgoing proxy [services/citoid] - 10https://gerrit.wikimedia.org/r/194559 [18:28:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Outgoing proxy [services/citoid] - 10https://gerrit.wikimedia.org/r/194559 (owner: 10Mvolz) [18:30:36] (03CR) 10Mobrovac: [C: 032] "Very nice!" [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 (owner: 10Mvolz) [18:31:20] 10VisualEditor, 10VisualEditor-Performance: ve.init.mw.ViewPageTarget.prototype.setupToolbar called twice - https://phabricator.wikimedia.org/T91595#1092942 (10Jdforrester-WMF) p:5Triage>3Normal [18:31:30] 10VisualEditor, 10VisualEditor-ContentEditable: Unused and/or broken code in ce.Surface selection fixup - https://phabricator.wikimedia.org/T91518#1092954 (10Jdforrester-WMF) p:5Triage>3High [18:31:51] (hmm, it is specified. weird.) [18:32:04] James_F: So I have WT and VE master, the other one you wanted was December? [18:32:09] RoanKattouw: Yeah. [18:32:15] 10VisualEditor, 10VisualEditor-ContentEditable: Display bug for character formatting: characters are bolded until you press enter at the end of a line - https://phabricator.wikimedia.org/T91672#1092956 (10Whatamidoing-WMF) 3NEW [18:32:38] RoanKattouw: If you have e.g. late November lying around anyway that's fine. [18:33:04] How about wmf13? [18:33:17] Sure. [18:33:21] Hmm I guess wmf12 is what was actually on enwiki over Christmas? [18:33:22] (03CR) 10Mvolz: "Yet again, I discovered a problem with this change AFTER merging." [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 (owner: 10Mvolz) [18:33:25] Yes. [18:33:27] But wmf13 is fine. [18:33:32] Less visual change anyway. [18:33:35] Which is good. [18:33:40] Oh right [18:33:43] OK I'll use wmf13 [18:33:46] (Wmf13 is when we switched OOjs UI from Apex to MediaWiki.) [18:35:36] (03CR) 10Jforrester: "> Not sure if this affects VE-MW." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [18:36:20] MatmaRex: It seems the parents() and similar collections don't do merge/add/sort. They use jQuery.dir() and pushStack() instead which only de-duplicates but preserved traversal order. [18:36:29] evil. [18:36:31] Whather that is parentNode, or prevUntil(), it preserves it [18:36:34] It's a feature of sorts [18:36:54] MatmaRex: Why does it matter [18:37:08] Krinkle: Oh so jQuery has an API for ".add() but without the stupid expensive compareDocumentOrder sort", it just doesn't expose it to people like me who would like to use it? [18:37:12] You can trigger a sort if you want to, though. [18:37:27] Krinkle: because i need to find the topmost node of a detached tree, and this confused me, because this single method was returning elements in the "wrong" order [18:37:43] but ah, we're talking about a library where each() and map() callbacks take different parameters. :) [18:37:55] MatmaRex: Hm.. I'd do that in a while (node.parentNode) loop. [18:38:27] so would i, if i was not using jQuery, which is supposed to make that kind of things easy [18:38:52] MatmaRex: What do you need it for after that? There might be a Sizzle method for that. [18:38:52] ;) [18:39:19] Sizzle does parent lookups quite often. not exposed as a single method though (it's only 3 lines of code), but many use cases with the restult of it it does have. [18:39:20] i'm going to slap a MutationObserver on it because i'm awful like that [18:39:28] anyway [18:39:49] RoanKattouw: Can you send me at least the two current videos? [18:39:54] Will do [18:39:56] RoanKattouw: Ta. [18:41:17] James_F: They're in our shared folder on Dropbox now [18:42:25] RoanKattouw: I saw, thanks. [18:43:11] Krinkle: oh, another annoying this is that $foo.parents().addBack() normalizes the order. [18:43:13] Meanwhile I'm downloading stuff from Gerrit at a snail's pace :S [18:43:24] MatmaRex: Yup [18:43:31] thing is that* [18:44:48] RoanKattouw: So, I'll get back to the TargetLoader in a minute, but just want to flush my brain about gathering information from template nodes in a good way that works with how we do stuff. I don't know very well how our communication works between nodes, documents, surfaces and targets. E.g.g which way the data is supposed to flow or pulled. [18:45:21] One of the ideas I had is to have the node, at construction or attach time (setDocument), tell the document about the template names(s). [18:45:48] Which can then add it to the singleton cache. which would have a debounce buffer. Possibly even a pause() mode so that it can not debounce at all while the document is first built. [18:45:51] Something like that [18:46:00] I was thinking of structuring it like LinkCache and ImageInfoCahe [18:46:07] Make it just another ApiResponseCache subclass [18:46:07] But the logic shouldn't be in the document, it's in target. So how to communicate from document to target? [18:46:11] It's top down, right? [18:46:13] Have you seen that code recently? [18:46:38] And how to know when the document is "done". [18:50:11] RoanKattouw: How's the video coming? [18:50:17] WTF was the 1.25wmf13 branch deleted in ext/VE? [18:50:20] James_F: git hates me [18:50:34] RoanKattouw: Oh, sorry. :-( [18:51:34] Did these branches get deleted without tags being created in their place? [18:52:40] Yes. [18:52:54] Do we need to give up? [18:52:55] So we destroyed the historical record, awesome [18:53:02] Fortunately my laptop has it [18:53:05] No, I'm running wmf13 now [18:53:54] OK. [18:54:23] 11s for wmf13 [18:54:30] 8s for master and WT, roughly [18:54:36] The video also shows the font size jump wonderfully [18:54:41] Uploading to Dropbox now [18:55:02] And done [18:55:26] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, 6Services: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1093066 (10Yurik) @marcoil, I'm not sure what that labs instance does, or when demo page was imported. Graph ext used to keep all of its... [18:55:44] James_F: You should have all three videos now. But after metrics, let's talk about why those branches disappeared [18:58:36] RoanKattouw: Yeah. [19:00:11] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, 6Services: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1093077 (10marcoil) @Yurik: That labs instance is the Parsoid we use for editing, and the page should have been produced directly from the... [19:03:26] (03PS2) 10Bartosz Dziewoński: TextInputWidget: Use MutationObserver for #onElementAttach support [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) [19:04:09] (03CR) 10Bartosz Dziewoński: "Okay, actually should work now, with the caveats listed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) (owner: 10Bartosz Dziewoński) [19:04:34] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, 6Services: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1093088 (10marcoil) Sorry, the correct URL for the updated Parsoid instance is http://parsoid-lb.eqiad.wikimedia.org/mediawikiwiki/Extensi... [19:18:49] 10VisualEditor: [Regression pre-wmf21] Comment icon is larger than the height of a line - https://phabricator.wikimedia.org/T91681#1093156 (10Etonkovidova) 3NEW [19:21:01] (03PS1) 10Bartosz Dziewoński: TextInputWidget: Adjust size and label on first focus, too [oojs/ui] - 10https://gerrit.wikimedia.org/r/194571 (https://phabricator.wikimedia.org/T89399) [19:21:22] 10VisualEditor: [Regression pre-wmf21] Comment icon is larger than the height of a line - https://phabricator.wikimedia.org/T91681#1093171 (10matmarex) [19:21:23] 10VisualEditor, 10VisualEditor-EditingTools: [Regression pre-wmf21] Comment icon is now huge - https://phabricator.wikimedia.org/T91656#1093172 (10matmarex) [19:22:25] 10VisualEditor, 10VisualEditor-EditingTools: [Regression pre-wmf21] Comment icon is now huge - https://phabricator.wikimedia.org/T91656#1093183 (10matmarex) a:3matmarex [19:34:20] (03CR) 10Krinkle: TextInputWidget: Use MutationObserver for #onElementAttach support (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) (owner: 10Bartosz Dziewoński) [19:44:47] 10VisualEditor: [Regression pre-wmf21] Comment icon is larger than the height of a line - https://phabricator.wikimedia.org/T91681#1093275 (10Etonkovidova) [19:44:48] 10VisualEditor, 10VisualEditor-EditingTools: [Regression pre-wmf21] Comment icon is now huge - https://phabricator.wikimedia.org/T91656#1093276 (10Etonkovidova) [19:45:07] (03PS1) 10Bartosz Dziewoński: ve.ce.CommentNode: Specify 'background-size' override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194576 (https://phabricator.wikimedia.org/T91656) [19:48:45] (03CR) 10Bartosz Dziewoński: TextInputWidget: Use MutationObserver for #onElementAttach support (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) (owner: 10Bartosz Dziewoński) [19:52:56] (03PS3) 10Bartosz Dziewoński: TextInputWidget: Use MutationObserver for #onElementAttach support [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) [19:54:13] (03CR) 10Bartosz Dziewoński: TextInputWidget: Use MutationObserver for #onElementAttach support (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) (owner: 10Bartosz Dziewoński) [20:01:45] OK, that's done. What's next? [20:04:01] Ugh [20:04:20] So I could swear that at some point in time we had code that only retried a badtoken once, and then displayed a badtoken error [20:04:34] Now I have to either find it, or admit that I dreamed it [20:09:32] RoanKattouw_away: I don't recall that feature. [20:09:35] RoanKattouw_away: But maaybe? [20:13:02] RoanKattouw_away: we do [20:13:03] in core [20:13:10] mw.Api#postWithToken [20:13:42] James_F: hey, so, what does https://gerrit.wikimedia.org/r/#/c/188289/ need and should i do it? [20:13:58] MatmaRex: AFAIK two things: [20:14:12] 1) The SVGs need manually fixing so they down-render to PNG correctly. [20:14:33] 2) OOjs UI needs to support languages, not just ltr/rtl, as variants for icons. [20:14:41] 3) The icon pack system needs to be extended to Apex. [20:15:10] 4) The icons in VE-core that map to the MediaWiki theme (e.g. link) need to be copied into OOjs UI as the Apex versions of those icons. [20:15:19] hmm. about 3, is it a hard requirement that every theme must implement all the icons you're adding here? is seems a bit awkward to me. [20:15:44] we should stick to a "core" subset of icons, and only use these in OOUI proper, and only require these to be implemented in all themes. [20:15:46] 5) The icons in VE-core that don't have an equivalent in MW need to be copied to both Apex and MediaWiki themes. [20:15:52] i think [20:15:55] (I lied about two things.) [20:16:09] The problem with that is it will make VE-core unusable. [20:16:17] I don't have time to explain right now, sorry. [20:19:31] alright [20:20:06] Later, I promise. [20:31:39] MatmaRex: hi [20:32:08] I had a look onto your JavaScript addint signatures and I figured out it still does not want to add them to main ns [20:32:20] MatmaRex: but I think we may create a template for that [20:32:55] Juandev: you can configure it to allow adding them in any namespace [20:33:04] by default, it only does it in non-content namespaces [20:33:41] Juandev: see the bottom of https://meta.wikimedia.org/wiki/User_talk:Matma_Rex/visualeditor-signature.js [20:37:55] (03CR) 10Alex Monk: "nitpicking inline." (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194338 (https://phabricator.wikimedia.org/T89066) (owner: 10Mobrovac) [20:37:57] (03PS25) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [20:38:58] MatmaRex: i SEE [20:47:57] (03PS26) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [20:48:19] (03CR) 10Paladox: "@Mattflaschen please review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [20:53:46] 10OOjs-UI, 10VisualEditor, 7Verified-in-Phase0, 5WMF-deploy-2015-03-04_(1.25wmf20): Dismissing popup tool group with ESC does not consume key event, attempts to close VE editor - https://phabricator.wikimedia.org/T89810#1093484 (10Etonkovidova) [20:55:14] (03PS4) 10Krinkle: TextInputWidget: Use MutationObserver for #onElementAttach support [oojs/ui] - 10https://gerrit.wikimedia.org/r/194197 (https://phabricator.wikimedia.org/T64084) (owner: 10Bartosz Dziewoński) [20:55:19] (03PS2) 10Krinkle: TextInputWidget: Adjust size and label on first focus, too [oojs/ui] - 10https://gerrit.wikimedia.org/r/194571 (https://phabricator.wikimedia.org/T89399) (owner: 10Bartosz Dziewoński) [21:18:56] (03CR) 10Mooeypoo: Add an icon to hidden templates (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) (owner: 10Mooeypoo) [21:19:28] 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1093567 (10KLans_WMF) [21:20:28] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, and 3 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1093569 (10Arlolra) [21:21:21] 10VisualEditor, 10VisualEditor-ContentEditable: Display bug for character formatting: characters are bolded until you press enter at the end of a line - https://phabricator.wikimedia.org/T91672#1093577 (10Etonkovidova) Step 3 (copying) is not necessary for reproducing the bug. Step 5 - move the cursor back ad... [21:21:35] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, and 3 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#850842 (10Arlolra) [21:21:36] 10VisualEditor, 10VisualEditor-Performance, 10Flow, 10Parsoid, and 4 others: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#1093580 (10Arlolra) [21:21:42] 10VisualEditor, 10VisualEditor-ContentEditable: Display bug for character formatting: characters are bolded until you press enter at the end of a line - https://phabricator.wikimedia.org/T91672#1093581 (10Etonkovidova) p:5Triage>3Lowest [21:23:28] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, and 3 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1093590 (10Arlolra) More discussion on moving out data-mw in T54936. [21:23:31] Krinkle: you merging that MutationObserver horribleness, perhaps? :) [21:23:50] MatmaRex: Nope, not on my calendar at the moment. Just fixing up Zuul stuckness [21:25:51] 10VisualEditor, 10VisualEditor-Performance, 10Flow, 10Parsoid, and 4 others: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#1093597 (10Arlolra) The main part of this task "Move data-parsoid out of the DOM, add uids" is complete. For data-mw, see:... [21:25:59] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 7 others: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#1093603 (10Arlolra) [21:26:00] 10VisualEditor, 10VisualEditor-MediaWiki: Release VisualEditor-MediaWiki as "1.0" - https://phabricator.wikimedia.org/T84936#1093602 (10Arlolra) [21:26:02] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, and 3 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1093601 (10Arlolra) [21:26:03] 10VisualEditor, 10VisualEditor-Performance, 10Flow, 10Parsoid, and 4 others: Move data-parsoid and possibly data-mw out of the DOM, add uids - https://phabricator.wikimedia.org/T54936#1093600 (10Arlolra) 5Open>3Resolved [21:29:36] 10VisualEditor, 10VisualEditor-MediaWiki: [What you see is not what you get] The references disappear after change of their template - https://phabricator.wikimedia.org/T91654#1093628 (10matmarex) [21:35:36] does anyone recall change in oojs dialogs about when actions are initialized? [21:35:42] (03CR) 10Alex Monk: "I'm not completely happy with introducing all this code into VE specifically (one of the benefits of moving to using VRS was to shift all " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194338 (https://phabricator.wikimedia.org/T89066) (owner: 10Mobrovac) [21:35:57] I'm in initialize method of dialog and this.actions does not have actions yet - but in newer code it seems to have [21:37:51] 10VisualEditor, 10VisualEditor-MediaWiki: [What you see is not what you get] The references disappear after change of their template - https://phabricator.wikimedia.org/T91654#1093638 (10Jdforrester-WMF) This is because the article uses the "Références" template rather than the tag. [21:39:05] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Allow preference to move toolbar to over navigation sidebar - https://phabricator.wikimedia.org/T53951#1093641 (10matmarex) Hmm, interesting idea. Lack of vertical space is especially a problem when using an on-screen keyboard, like on a tablet. {F56237} [21:39:54] 10VisualEditor, 10VisualEditor-MediaWiki-References: Have the References list tool insert a general references list (99% action), rather than stopping to ask the user about which group to use - https://phabricator.wikimedia.org/T71727#1093643 (10Jdforrester-WMF) p:5Triage>3Normal [21:41:22] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Allow preference to move toolbar to over navigation sidebar - https://phabricator.wikimedia.org/T53951#1093648 (10Jdforrester-WMF) In that case, though, we'd only really have room for six toolbar options and then "…", which I'm not sure is much better. :-( [21:41:41] 10VisualEditor, 10VisualEditor-MediaWiki: [What you see is not what you get] The references disappear after change of their template - https://phabricator.wikimedia.org/T91654#1093649 (10matmarex) [21:41:42] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Parsoid's render of {{reflist}} has no context, so no references appear; similarly, edited templates inside structures, look odd on edit - https://phabricator.wikimedia.org/T53146#1093650 (10matmarex) [21:42:44] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 7Technical-Debt: Move the reference, reference list and citation systems into the Cite extension's repo - https://phabricator.wikimedia.org/T67630#1093652 (10Jdforrester-WMF) [21:44:32] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, and 3 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1093666 (10Arlolra) [21:44:41] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki: Wrap invisible characters in new content with - https://phabricator.wikimedia.org/T85943#1093667 (10Jdforrester-WMF) p:5Triage>3Lowest [21:45:28] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, and 3 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#850842 (10Arlolra) [21:51:34] 10VisualEditor, 10VisualEditor-Performance, 10RESTBase, 5§ VisualEditor Q3 Blockers: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1093695 (10Jdforrester-WMF) So should we re-phrase this into loading data-mw from a separate A... [21:53:33] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Duplicating categories (and possibly also something else) - https://phabricator.wikimedia.org/T56169#1093716 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [21:54:10] 10VisualEditor, 10VisualEditor-MediaWiki, 5§ VisualEditor Q3 Blockers: Same Category get added multiple times ,for every change in “Sort this page by default as” value. - https://phabricator.wikimedia.org/T76715#1093721 (10Jdforrester-WMF) 5Open>3Resolved Seems likely. [21:55:31] 10VisualEditor: Category was duplicated and given different sort keys - https://phabricator.wikimedia.org/T89618#1093726 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Closing this for now as probably fixed; any reproductions after 3 March (barring caches) should make this be re-opened, though. [21:57:48] 10VisualEditor: Don't allow me to add duplicate categories in Safari - https://phabricator.wikimedia.org/T89619#1093734 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Looks like this is now fixed AFAICT. [22:04:42] 10VisualEditor, 10VisualEditor-Performance, 10WikiEditor, 10Analytics, and 3 others: Apply Schema:Edit instrumentation to WikiEditor - https://phabricator.wikimedia.org/T88027#1093918 (10Krenair) >>! In T88027#1045283, @gerritbot wrote: > Change 191221 had a related patch set uploaded (by Alex Monk): > [WI... [22:05:20] Krenair: ❤ [22:05:26] :) [22:05:43] Or "ε>" if you want to be more traditional. [22:05:57] It doesn't fill out the entire schema like I would've hoped [22:06:10] But apparently Analytics can work with what it does fill [22:06:14] It's a good start. [22:06:33] I left a couple of TODOs in there, for future work. [22:06:53] Now we need to get someone to review it [22:07:02] * James_F nods. [22:08:08] 10VisualEditor, 10Wikimedia-Site-requests, 3Roadmap: Re-enable VisualEditor by default for all newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90664#1093935 (10Jdforrester-WMF) [22:08:17] 10VisualEditor, 10Wikimedia-Site-requests, 3Roadmap: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#1093937 (10Jdforrester-WMF) [22:09:43] 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, and 2 others: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1093942 (10Jdforrester-WMF) [22:19:33] 10VisualEditor, 10VisualEditor-MediaWiki: Reconsider location, interaction pattern of search field in Category dialog - https://phabricator.wikimedia.org/T91469#1093965 (10Jdforrester-WMF) p:5Triage>3Normal [22:20:12] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Adding text to a category resulted in an extra section heading with span tags - https://phabricator.wikimedia.org/T71803#1093969 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF We fixed this a while ago, I think. [22:36:13] (03CR) 10Jforrester: [C: 032] "Merging similar styles can be TD." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) (owner: 10Mooeypoo) [22:37:20] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-03-11_(1.25wmf21), 5§ VisualEditor Q3 Blockers: Hidden templates should display as an icon in-page in VisualEditor so they can be interacted with (e.g. a puzzle piece?) - https://phabricator.wikimedia.org/T51806#1094021 (10Jdforrester-WMF) 5... [22:37:21] 10VisualEditor: VisualEditor: can't fix a broken template since this will result invisible - https://phabricator.wikimedia.org/T55205#1094024 (10Jdforrester-WMF) [22:37:22] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Display and let users edit arbitrary HTML anchors, e.g. in section headings - https://phabricator.wikimedia.org/T52633#1094023 (10Jdforrester-WMF) [22:38:08] 10VisualEditor, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: [Regression wmf16] Including a template/comment/table/gallery/math node in a slug makes the editor completely unresponsive - https://phabricator.wikimedia.org/T89192#1094025 (10Ryasme... [22:38:15] subbu: do you know if Roan ever filed a bug for the Parsoid part of -- namely, getting rid of './' and '../' prefixes in Parsoid URLs? [22:38:40] ori: trade-off is that we'd have to encode colons then [22:38:49] (03Merged) 10jenkins-bot: Add an icon to hidden templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) (owner: 10Mooeypoo) [22:38:54] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-11_(1.25wmf21): VisualEditor: Display and let users edit arbitrary HTML anchors, e.g. in section headings - https://phabricator.wikimedia.org/T52633#1094030 (10Jdforrester-WMF) 5Open>3Resolved a:3Mooeypoo [22:39:09] ori: we debated this a few times, but decided that ./ sucks less [22:39:15] mooeypoo: https://gerrit.wikimedia.org/r/#/c/194576/ [22:39:39] ../ should go (or be gone) though [22:40:05] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Firefox, 7Verified-in-Phase0, and 3 others: [Regression pre-wmf19] Cursoring is totally broken in Betalabs with Firefox - https://phabricator.wikimedia.org/T90306#1094037 (10Ryasmeen) [22:40:06] yes, the ../ is gone .. removed it in nov. [22:40:32] kk [22:41:01] 10VisualEditor, 10Citoid, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-02-25_(1.25wmf19): [Regression pre-wmf19]Getting error: "ve.ui.CiteFromIDDiologTool is undefined" while opening a page in Betalabs - https://phabricator.wikimedia.org/T90297#1094043 (10Ryasmeen) [22:41:54] 10VisualEditor, 10Citoid, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-02-25_(1.25wmf19): [Regression pre-wmf19] Getting error: "ve.ui.CiteFromIDDiologTool is undefined" while opening a page in Betalabs - https://phabricator.wikimedia.org/T90297#1094045 (10Jdforrester-WMF) [22:42:13] 10VisualEditor, 10VisualEditor-EditingTools, 7Browser-Support-Firefox, 7Verified-in-Phase0, and 3 others: In production, sometimes page scrolling stops working and in the console getting "Error: offset was inside a handlesOwnChildren node" in Firefox - https://phabricator.wikimedia.org/T70537#1094048 (10Rya... [22:43:14] (03CR) 10Mooeypoo: [C: 032] "Lookin' good" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194576 (https://phabricator.wikimedia.org/T91656) (owner: 10Bartosz Dziewoński) [22:43:44] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: VisualEditor: Cannot go to the next line of an article after inserting a special character in a block slug and "TypeError: Inserted data is trying to clos... - https://phabricator.wikimedia.org/T67873#1094051 [22:45:26] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 7Verified-in-Phase0, and 2 others: VisualEditor: Clicking on somewhere else in the document after opening a link inspector inside a slug throws error "TypeError: Cannot read propert... - https://phabricator.wikimedia.org/T74494#1094052 [22:45:40] (03Merged) 10jenkins-bot: ve.ce.CommentNode: Specify 'background-size' override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194576 (https://phabricator.wikimedia.org/T91656) (owner: 10Bartosz Dziewoński) [22:46:19] subbu, gwicke: thanks! [22:47:41] (03PS2) 10Jforrester: Fold text style dropdown into basic text style bar in toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:48:15] (03CR) 10Jforrester: [C: 031] "PS2 retains the 'text_style' icon which makes this a bit too heavy, but at least explicable." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:48:34] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 7Verified-in-Phase0, and 2 others: [Regression pre-wmf20] Link inspector opening in wrong position when selection is at the start of a line - https://phabricator.wikimedia.org/T91307#1094062 (10Ryasmeen) [22:49:10] MatmaRex: Want to +1 my change to your change in https://gerrit.wikimedia.org/r/194526 (or just +2)? [22:50:07] James_F: i was implementing by trevor's mockup on the bug. i think the icon isn't necessary. but i don't care too much either way [22:50:20] MatmaRex: Ah, hmm. [22:50:26] (03CR) 10Bartosz Dziewoński: [C: 031] "I was implementing by Trevor's mockup on the bug. I think the icon isn't necessary, but I don't care too much either way." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:50:37] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: Don't show redlinks as existing links if MediaWiki didn't tell us one way or the other - https://phabricator.wikimedia.org/T91299#1094063 (10Ryasmeen) [22:50:38] (03CR) 10Jforrester: [C: 032] Fold text style dropdown into basic text style bar in toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:50:47] (03PS3) 10Jforrester: Fold text style dropdown into basic text style bar in toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:51:07] James_F: i'm not sure if the mockup was supposed to be a part of dynamic folding on narrow toolbar, or static [22:51:28] MatmaRex: Probably both. Eh. Ill people don't get to give input. :-) [22:51:53] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-11_(1.25wmf21): [Regression pre-wmf21] Comment icon is now huge - https://phabricator.wikimedia.org/T91656#1094065 (10Jdforrester-WMF) 5Open>3Resolved [22:51:59] (03PS1) 10Krinkle: Update JSDuck config to standard jsduck.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194727 [22:52:54] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 5WMF-deploy-2015-03-04_(1.25wmf20), 5§ VisualEditor Q3 Blockers: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and context menu and so fail to go a... - https://phabricator.wikimedia.org/T85622#1094071 [22:53:27] (03CR) 10Jforrester: [C: 032] Fold text style dropdown into basic text style bar in toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:54:00] Krinkle: Finally. Is that ready to go immediately? [22:54:07] James_F: Should be yeah [22:54:20] (03CR) 10Jforrester: [C: 032] Update JSDuck config to standard jsduck.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194727 (owner: 10Krinkle) [22:54:27] Good. [22:54:37] Krinkle: How's your helping RoanKattouw_away going? :-) [22:54:45] Errr.. [22:54:50] I've thought abuot it [22:54:56] It's a hard problem to solve. [22:55:02] Yeah. :-( [22:56:49] (03Merged) 10jenkins-bot: Update JSDuck config to standard jsduck.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194727 (owner: 10Krinkle) [22:56:55] (03Merged) 10jenkins-bot: Fold text style dropdown into basic text style bar in toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194526 (https://phabricator.wikimedia.org/T90815) (owner: 10Bartosz Dziewoński) [22:57:05] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Google-Chrome, and 4 others: Chrome lets you place the cursor either side of a Table (eww) and VE doesn't correct this - https://phabricator.wikimedia.org/T73560#1094091 (10Ryasmeen) [22:57:44] (03PS1) 10Jforrester: Update VE core submodule to master (9fb4bdb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194733 [22:58:31] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 7Verified-in-Phase0, 5WMF-deploy-2015-03-04_(1.25wmf20): "Read more" link is appearing even if the last line if the description of the image fits in the visible area - https://phabricator.wikimedia.org/T87265#1094104 (10Ryasmeen) [23:01:01] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Adding text to a category resulted in an extra section heading with span tags - https://phabricator.wikimedia.org/T71803#1094109 (10Etonkovidova) Inclined to mark it as resolved since it seems to be fixed. Instead of ```

We could of course revisit making that a native system. At least a small part of it [23:16:56] Hmm. How hard would that be? [23:17:04] Basically the only part of it that's causing thi is the "redlink" they have to create the notice [23:17:16] Yeah. [23:17:26] They basically create all non-existing notices (thus making them no longer non-existant) with a link pointing to where it can be "really" created. [23:17:33] Which isn't even visible to non-sysops [23:17:36] (03CR) 10Jforrester: "> Does this not conflict with OOUI 0.9.0, needing the same fix as https://gerrit.wikimedia.org/r/194576 ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) (owner: 10Mooeypoo) [23:18:07] MatmaRex: See http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit [23:18:25] (03CR) 10Bartosz Dziewoński: "But the size is not specified. Place it in a heading or a and it looks weird." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193975 (https://phabricator.wikimedia.org/T51806) (owner: 10Mooeypoo) [23:18:44] MatmaRex: Eh. Maybe. [23:19:06] If there were some mechanism in MediaWiki core where they could use an interface message like "editnotice-create" to display that, that would work. MediaWiki core would need to be given some configurable to state where teh page would be (e.g. defaults to MediaWiki:Editnotice-nsid-pagetitle, and probably template:editnotice/pagename or pagename/editnotice for them). And then use can('edit') to [23:19:07] display it ornot. [23:19:11] And VE would never trigger it [23:19:17] James_F: http://i.imgur.com/fgSMFnT.png [23:19:27] unless you say this is intentional [23:19:32] which it might as well be [23:19:34] It's not unintentional. [23:19:43] Eh. Sure, let's fix. [23:19:49] I'll fix, you merge. [23:20:03] oookay [23:20:23] Do I need the super-specific selector for this one? [23:23:01] James_F: Want me to put on a phabricator task ^ ? [23:23:06] James_F: probably [23:23:14] Krinkle: Please. [23:23:55] James_F: doesn't need to be super-specific, just more specific than .oo-ui-iconElement.oo-ui-iconElement-icon [23:24:22] .ve-ce-mwTransclusionNode.oo-ui-iconElement is pretty specific. [23:24:53] possibly specific enough [23:25:06] Also, whoops. [23:25:10] which one applies depends on load order, which is technically known here [23:25:14] I need to follow-up your VE-core thing. [23:25:19] Fool that I am. :-( [23:25:22] (VE loads later) [23:30:22] (03PS1) 10Jforrester: Follow-up I11b9f0ab: Make the MWTransclusionNode icon a fixed size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194744 [23:32:33] (03CR) 10jenkins-bot: [V: 04-1] Follow-up I11b9f0ab: Make the MWTransclusionNode icon a fixed size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194744 (owner: 10Jforrester) [23:35:46] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up I11b9f0ab: Make the MWTransclusionNode icon a fixed size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194744 (owner: 10Jforrester) [23:36:03] James_F: hmm. looks like the toolbar change did affect ve-mw, after all. [23:36:12] MatmaRex: Yeah, trying to fix. [23:36:17] i probably should've put the new tool in a new group [23:36:26] MatmaRex: But my local wiki isn't co-operating, and is instead crashing. [23:36:36] MatmaRex: Maybe we should call it HACKHACKHACK? ;-) [23:36:51] wouldn't oppose that ;) [23:36:54] MatmaRex: Also, the almost-working nested menus is fun. :-) [23:37:23] yeah, it's an interesting effect [23:37:47] (03CR) 10jenkins-bot: [V: 04-1] Follow-up I11b9f0ab: Make the MWTransclusionNode icon a fixed size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194744 (owner: 10Jforrester) [23:37:52] Bleh. [23:38:31] (03PS1) 10Mooeypoo: Add optional text to deprecated property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194748 (https://phabricator.wikimedia.org/T90734) [23:38:55] what is it with that change [23:39:01] 23:36:37 Warning: /mnt/jenkins-workspace/workspace/mwext-VisualEditor-jsduck/lib/ve/lib/oojs-ui/oojs-ui.js:12489: Unknown type MouseEvent [23:39:01] 23:36:37 Warning: /mnt/jenkins-workspace/workspace/mwext-VisualEditor-jsduck/lib/ve/lib/oojs-ui/oojs-ui.js:12535: Unknown type KeyboardEvent [23:39:06] surely that was fixed [23:39:16] It was. [23:39:20] Did Krinkle unfix it? [23:39:23] * James_F looks. [23:39:44] must've done it very carefully to avoid the tests failing [23:39:56] Yeah, hence my surprise. [23:40:00] (03CR) 10jenkins-bot: [V: 04-1] Add optional text to deprecated property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194748 (https://phabricator.wikimedia.org/T90734) (owner: 10Mooeypoo) [23:44:14] There. [23:44:16] (03PS1) 10Jforrester: Follow-up I5918367: Add new classes to jsduck.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194752 [23:45:00] James_F: the jsduck job has a nasty habit of only running when .js files were touched [23:45:03] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up I5918367: Add new classes to jsduck.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194752 (owner: 10Jforrester) [23:45:05] Ah. [23:45:10] That'd… yeah. [23:45:22] And lib/ve doesn't count as .js files being touched. [23:45:24] * James_F sighs. [23:45:27] James_F: that broke mediawiki/core master in the past, since it processes .css files too, but wasn't triggered on changes to them. [23:45:33] (i think this particular thing was fixed) [23:47:30] James_F: uh. Titleblacklist also has a noedit ability? [23:47:40] Template:Editnotices\/.* [23:47:40] https://en.wikipedia.org/w/index.php?title=Template:Editnotices/Group/Help:Cite_errors&action=edit [23:47:49] (03Merged) 10jenkins-bot: Follow-up I5918367: Add new classes to jsduck.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194752 (owner: 10Jforrester) [23:47:54] (03PS1) 10Nirzar: Button styles between OOJS and MW [oojs/ui] - 10https://gerrit.wikimedia.org/r/194753 [23:48:05] (03PS2) 10Bartosz Dziewoński: Follow-up I11b9f0ab: Make the MWTransclusionNode icon a fixed size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194744 (owner: 10Jforrester) [23:48:07] That's like regex page protection [23:48:09] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up I11b9f0ab: Make the MWTransclusionNode icon a fixed size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194744 (owner: 10Jforrester) [23:48:10] Interesting [23:48:19] Krinkle: … whut? [23:48:26] MatmaRex: Fun. [23:48:28] Krinkle: by which you mean, evil [23:48:34] No, that's awesome [23:48:47] It's just implemented in the most unexpected of ways [23:48:51] i don't understand why en.wp has this custom system, when there is an identical one in the MediaWiki namespace [23:49:18] MatmaRex: two use cases: 1) non-sysops, 2) displaying a link [23:49:25] meh [23:49:33] * James_F nods. [23:50:11] (03Merged) 10jenkins-bot: Follow-up I11b9f0ab: Make the MWTransclusionNode icon a fixed size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194744 (owner: 10Jforrester) [23:51:01] MatmaRex: Although the existence of that titleblacklist entry is baffling [23:51:09] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Parameter data doesn't always end up in the right parameter box in Firefox - https://phabricator.wikimedia.org/T69427#1094249 (10Etonkovidova) The issue is confirmed - it is most noticeable in FF35 on Windows. I've attached a screencast for FF35 on Ma... [23:51:14] That means it might as well.. not exist [23:51:22] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Parameter data doesn't always end up in the right parameter box in Firefox - https://phabricator.wikimedia.org/T69427#1094252 (10Etonkovidova) p:5Triage>3Low [23:52:19] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Sometimes it's somehow possible for VE/Parsoid to insert a
at the start of a heading - https://phabricator.wikimedia.org/T53444#1094258 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF No reproduction steps in > 18 months. If you c... [23:52:28] There's way too much cruft around this, James_F. I don't think anything we can come up with in short-term would be used by enwiki. Even if it might encourage new wikis to no longer copy enwiki's system, their's is so big they'd need weeks to migrate. [23:52:44] Krinkle: Sure. Think we should decline it from the blockers list? [23:53:09] Yeah. I'll finish my braindump on that new task, but for ve performance it's not worth it I think. [23:53:33] (03CR) 10Kaldari: [C: 04-1] Button styles between OOJS and MW (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194753 (owner: 10Nirzar) [23:53:41] 10OOjs-UI, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1094265 (10matmarex) [23:54:40] 10OOjs-UI: OOUI has no way to produce a window-like frame around something other than a window - https://phabricator.wikimedia.org/T91153#1094267 (10matmarex) p:5High>3Normal [23:57:40] 10OOjs-UI, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1094279 (10Jdforrester-WMF) How much actual space does this save for VE-MW? [23:58:50] (03PS1) 10Jforrester: Follow-up Id9e657f12: Don't add moreTextStyle to the same group as it breaks downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194757 [23:58:55] MatmaRex: ^^ [23:59:36] James_F: thanks, you verified it? [23:59:39] Yup. [23:59:47] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up Id9e657f12: Don't add moreTextStyle to the same group as it breaks downstream [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194757 (owner: 10Jforrester) [23:59:51] (In VE-MW and VE-core.)