[00:00:14] With Monday finishing off ^^^ that stack. [00:00:42] Yeah that stack is most of the way there but doesn't actually catch exceptions yet [00:01:03] (03Merged) 10jenkins-bot: TextInputMenuSelectWidget: Add description and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/194983 (owner: 10Kmenger) [00:01:07] Yeah, why are those static methods lol [00:02:11] (03PS2) 10Catrope: Move ve.dm.Document#spliceMetadata to dm.MetaLinearData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194978 [00:02:26] (03PS2) 10Catrope: Remove unused variables in dm.TransactionProcessor#applyAnnotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194979 [00:02:31] (03PS2) 10Catrope: Remove unnecessary support for nesting annotation and replace operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194980 [00:02:35] (03PS2) 10Catrope: Queue linear model modifications in TransactionProcessor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194981 [00:02:48] oh, also [00:02:53] it didn't fit in the screenshot [00:03:02] (03CR) 10jenkins-bot: [V: 04-1] Remove unnecessary support for nesting annotation and replace operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194980 (owner: 10Catrope) [00:03:03] but there's a /* Static Methods */ heading above that mess [00:03:08] (03CR) 10jenkins-bot: [V: 04-1] Queue linear model modifications in TransactionProcessor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194981 (owner: 10Catrope) [00:03:17] I don't know if you guys saw my comment on https://phabricator.wikimedia.org/T90454 (display beta welcome dialog early) [00:03:44] basically my version was a pile of hacks that still broke in the edit-redirect-page case [00:04:10] Krenair: needs moar promises [00:05:49] manager.openWindow( 'betaWelcome' ).done( function ( opened ) { opened.done( function ( closing ) { closing.done( function () { /* some code */ } ); } ); } ); [00:05:54] :( [00:05:56] (03CR) 10Catrope: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194980 (owner: 10Catrope) [00:06:11] (03CR) 10Catrope: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194981 (owner: 10Catrope) [00:06:41] ); [00:07:36] Krenair: closingPromise = manager.openWindow( 'betaWelcome' ).then( function ( opened ) { return opened.then( function ( closing ) { return closing; } ); } ); [00:08:06] maybeShowDialogs( closingPromise || $.Deferred().resolve() ); or something [00:08:22] * RoanKattouw is just sketching code in broad strokes because it's 1am and he's too tired to write real code [00:10:38] RoanKattouw, maybeShowDialogs is the bit which does all the logic to determine whether to open the beta welcome dialog or not [00:11:31] it has the crazy deferred code to automatically open the notices popup when you close the dialog [00:12:41] Oh right [00:12:59] Isn't that also where the redirect stuff is though? [00:13:14] it's also where we have the redirect code, yes [00:13:42] (auto-open meta dialog when editing a redirect) [00:15:26] RoanKattouw: wow, that is really twisted. whyyyyy. [00:16:34] MatmaRex: What's twisted? [00:16:58] mw.Target [00:17:01] and its events [00:17:15] Literally [00:17:56] RoanKattouw: OK. So what do you need from me for targetLoader. What shall we start with? [00:18:02] * Krinkle catches up with todays activity first [00:18:41] 20 minutes of activity? :p [00:18:41] "Today's" activity [00:19:14] Krinkle: Well you had some suggestions for things that could be done in an initial commit [00:19:34] And you seem to be getting ready to do some work while I'm falling asleep and about to leave for the weekend [00:20:36] So maybe you could either make some progress on the TargetLoader thing, moving stuff like ve-activating and other init-y things to better places, or, if you'd rather do that synchronously with me next week, do other things to clear your plate so you have time to do that next week? [00:21:53] RoanKattouw: "doesn't actually catch exceptions yet" – details, details. :-) [00:22:22] Heh well all the stage-setting is done [00:22:48] In theory all it needs now is a carefully crafted try-catch block [00:23:01] In theory. [00:25:00] Yeah I'm sure I'll encounter a few surprises in relevant DocumentSynchronizer and ElementLinearData / MetaLinearData code [00:25:14] :-) [00:27:01] 10VisualEditor, 6Mobile-Web: Mobile VE - Back and Next buttons should align to top toolbar - https://phabricator.wikimedia.org/T91841#1097328 (10KHammerstein) 3NEW [00:30:33] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194980 (owner: 10Catrope) [00:31:20] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web: Mobile VE - Back and Next buttons should align to top toolbar - https://phabricator.wikimedia.org/T91841#1097336 (10Krenair) [00:34:05] 10VisualEditor, 6Mobile-Web: Mobile VE - Context toolbars are misaligned and confusing users - https://phabricator.wikimedia.org/T91842#1097338 (10KHammerstein) 3NEW [00:37:56] 10VisualEditor, 6Mobile-Web: Mobile VE - tapping a different context item should indicate change - https://phabricator.wikimedia.org/T91843#1097345 (10KHammerstein) 3NEW [00:40:07] 10VisualEditor, 6Mobile-Web: Mobile VE - Link inspector should have a back or cancel button - https://phabricator.wikimedia.org/T91844#1097351 (10KHammerstein) 3NEW [00:41:50] 10VisualEditor, 6Mobile-Web: Mobile VE - Context Toolbar titles are messed up - https://phabricator.wikimedia.org/T91845#1097358 (10KHammerstein) 3NEW [00:44:00] RoanKattouw: I'll be on Dokkum from next Monday [00:44:13] And I'm leaving Harlingen tomorrow :S [00:44:13] Just FYI [00:46:16] 10VisualEditor, 6Mobile-Web: Mobile VE - Toolbar buttons are the incorrect sizes - https://phabricator.wikimedia.org/T91847#1097374 (10KHammerstein) 3NEW [00:47:07] RoanKattouw, for my unit tests I have an async test that I want to check if it failed; so, can I do something like this: [00:47:43] this.runWhatever( foo ).then( false, true ).then( function ( result ) { assert.ok( result, 'failed!' ); } ) [00:48:15] What is .then( false, true ) ? [00:48:33] it should return false if success and true if fail, no? [00:48:44] https://gerrit.wikimedia.org/r/#/c/193434/ :S [00:48:51] copying paste my comment with a question mark [00:49:30] RoanKattouw, instead of doing something like .then( function () { return false; }, function () { return true; } [00:49:33] mooeypoo: You can't pass booleans to .then(), only functions [00:49:41] Unless jQuery has undocumented magic [00:49:51] mooeypoo: What are you testing? [00:49:53] damnit I wanted to cheat even more than usual. Fiiiiine. [00:50:11] Krinkle, I'm testing that on crappy json string, my source handler is rejecting the promise as it should. [00:50:26] which would trigger a message dialog in the ui in the actual code [00:51:38] mooeypoo: then( function () { assert.ok(true); }, function () { assert.ok(false); }) [00:51:46] oh crap, I need to *RESOLVE* [00:51:52] right right [00:52:09] this is what I get for trying to Roanify my promises too early [00:53:06] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web: Mobile VE - Cite dialogue fields are buggy - https://phabricator.wikimedia.org/T91849#1097395 (10KHammerstein) 3NEW [00:57:10] RoanKattouw, I still roanified it somewhat. You'll have to see if you like it or not when I submit to review. [00:58:53] (03PS1) 10Mooeypoo: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 [00:58:59] and Krinkle will either be happy or horrified. [01:00:04] (03PS2) 10Mooeypoo: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) [01:00:15] (03CR) 10Mooeypoo: [C: 04-1] "Waiting on James for correct copy for the messages." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo) [01:00:43] (03CR) 10jenkins-bot: [V: 04-1] Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo) [01:00:48] ... whaat [01:01:58] With is with all the removed "/" characters in */ [01:02:03] that comments out half the file [01:02:05] is that on purpose? [01:05:20] oh, crap, I forgot to clean that up [01:07:06] (03PS3) 10Mooeypoo: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) [01:07:10] we need that repo to be checked by jsduck, too [01:07:40] (03CR) 10jenkins-bot: [V: 04-1] Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo) [01:08:05] (03CR) 10Krinkle: Reorganize api calls and add sourceHandler and error message (034 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo) [01:08:51] (03PS4) 10Mooeypoo: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) [01:09:23] 10TemplateData, 10Continuous-Integration: Run JSduck in CI for TemplateData extension - https://phabricator.wikimedia.org/T91851#1097467 (10Jdforrester-WMF) 3NEW [01:10:07] mooeypoo: I'll enable jsduck [01:10:17] It's now 10x easier to do that [01:10:20] Krinkle: Thanks! Was just about to write the patch for you. [01:10:21] (For me) [01:10:25] Krinkle, I am also adding @class and @constructor to all other classes in that extension [01:10:35] James_F: Ah, go ahead. It'll be a good check to see if the new system is not weird. [01:10:38] :-) [01:10:50] James_F: use oojs-core and oojs-ui and ve-core as example. [01:11:06] Krinkle: And publish too? [01:11:20] Sure [01:13:58] 10OOjs-UI, 10UI-Standardization, 7Design: Use case for PopupButtonWidget (framed, no popup head)‎ - https://phabricator.wikimedia.org/T88625#1097488 (10matmarex) In practice, we're using it for the "help" buttons in various VisualEditor dialogs. {F57433} [01:14:12] Krinkle: What template do I steal for that? [01:14:20] James_F: No job template :) [01:14:22] James_F: Only zuul :) [01:14:24] Gah. [01:14:28] Zuul job template. [01:14:37] Whatever it's called. [01:14:39] We now have a job that can be invoked by Zuul for different repositories [01:14:59] I'm not calling you out for terminology. The thing you're looking for isn't there anymore. [01:15:14] - job-template: [01:15:14] name: 'mwext-VisualEditor-jsduck-publish' [01:15:18] For the test pipeline, you just add 'jsduck' [01:15:19] - job-template: [01:15:19] name: 'mwext-MultimediaViewer-jsduck-publish' [01:15:25] Etc. [01:15:27] They exist. [01:15:29] For publish you'll need a jenkins job indeed. [01:15:39] That's what I was talking about. :-P [01:16:06] James_F: Use mwext-GuidedTour-jsduck-publish as example [01:16:12] The others have custom scripts still [01:16:23] Do I make the builder be jsduck and then… good, that means yes. :-) [01:16:49] (03PS5) 10Mooeypoo: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) [01:19:31] {{done}} [01:20:58] Krinkle, if you also have time to review this, that'll be great https://gerrit.wikimedia.org/r/#/c/194748/3 [01:21:03] but maybe not now.. don't you need to sleep? [01:21:11] (03PS1) 10Krinkle: Document code with JSDuck [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 [01:21:28] mooeypoo: ^ check that one out and run jsduck locally to refine the errors [01:22:02] (03CR) 10Jforrester: [C: 031] Document code with JSDuck [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 (owner: 10Krinkle) [01:22:02] Let me know if there's any edge cases you need help with. It's not something we've done before. The main special part here is that oojs-ui is not shipped in the repo. [01:22:17] (03CR) 10Krinkle: [C: 04-1] "Needs work to actually pass." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 (owner: 10Krinkle) [01:22:32] Krinkle: Being fussy. :-) [01:23:00] 10OOjs-UI, 10UI-Standardization, 7Design: Use case for PopupButtonWidget (framed, no popup head)‎ - https://phabricator.wikimedia.org/T88625#1097512 (10violetto) [01:23:02] 10OOjs-UI, 10UI-Standardization, 7Design: PopupButtonWidget (frameless, with popup head)‎ shows at hover instead of onClick? - https://phabricator.wikimedia.org/T88630#1097513 (10violetto) [01:23:51] err I'm getting weird jsduck errors now [01:24:58] Krinkle, all my @inheritdoc is flagged for the OO.ui.ProcessDialog [01:25:19] oh.. wait, no, my fault [01:25:28] I forgot that I added the @class and @inherits in the other commit [01:25:30] mooeypoo: Yup. You can suppress the @extend and @mixin etc. with OO.* in --external, but inheritdoc won't work. [01:25:39] So you'll have to inline what you want to document, or leave it out entirely. [01:25:50] err @extends [01:25:53] Which makes sense code wise since you don't have the oojs-ui file in the repo either. [01:26:00] Yeah, but that wont make the error go away [01:26:11] hmm [01:26:24] okay so best way is to copy/paste the docs? [01:26:25] you can only inherit documentation from your own code base [01:26:34] Well, the parts relevant to you. [01:26:43] Can even use a url to upstream for more details [01:26:46] Like we do with jQuery [01:27:27] The OO.* --external ignore I added means it will allow those in class relationships and it will render them as text instead of a link [01:27:30] and no error [01:27:37] * mooeypoo nods [01:27:57] Krinkle, also, it gives me eror on almost everything in ext.templateDataGenerator.ui [01:28:19] "global method: setNoticeMessage" and "global method: resetNoticeMessage" [01:28:22] and init [01:28:48] btw, all the doc fixups, do you want me to add them to this commit or start a dependent commit ? [01:29:09] mooeypoo: most "global" things mean there is no parent blocj [01:29:15] most likely a missing @class at the start [01:29:22] handle them top down and re-run [01:30:35] eh [01:30:53] I added @class to the singleton and it still flags the same global methods [01:31:51] mooeypoo: Did you use my commit as base? In that case be sure to make the class block a block and not a comment [01:31:57] I moved it to be a /*! file header [01:31:59] which are not inded [01:32:01] indexed [01:32:05] Because @author is invalid [01:32:10] for code blocks [01:32:24] and it was documenting a string instead of the block [01:32:28] "global class use strict" [01:32:32] https://github.com/wikimedia/mediawiki-extensions-TemplateData/blob/3cc6afaa750c01beb3675b1e9e4c6e04605b2923/modules/ext.templateDataGenerator.ui.js#L9-L10 [01:32:48] oh! right [01:33:25] undo my change and move it back to the class (though one line down from where it was), that should fix it [01:34:51] ok that worked [01:35:00] now it complains about 'unnamed property' and unnamed method' [01:35:02] O.o [01:35:14] James_F: Yeah, the 'master' filter is important since for tags ZUUL_BRANCH is undefined and it would overwrite the parent directory [01:35:31] * James_F nods. [01:35:32] Thanks to how Bash just casts null to empty string [01:36:02] and then rsync will actually delete all sibling directories [01:36:14] because the user wants to override project/ [01:37:05] James_F: Wanna compile/push the job to Jenkins? [01:37:21] Then I'll deploy the Zuul change after [01:37:45] Krinkle: I don't have access to do that, I thought? [01:37:53] All wmf staff hs [01:37:58] Oh, really? Eek. [01:41:47] what the... I have "duplicate method name" on two methods that have not even remotely the same name [01:42:02] "onDialogApply" and "replaceTemplateData" [01:42:53] and more 'unnamed property' values that I just don't understand why they're like that [01:44:01] (03PS2) 10Mooeypoo: Document code with JSDuck [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 (owner: 10Krinkle) [01:44:15] Krinkle, ^^ can you take a look ? I don't understand what it wants now.. [01:44:26] I have 5 issues left [01:45:38] Krinkle, http://pastebin.com/UusjyjMV [01:45:40] Two properties with no name have the same non-name [01:45:52] what? where do I set a name? [01:45:58] should be inferred [01:46:07] replaceTemplateData = function ( newTemplateData ) { [01:46:12] onDialogApply = function ( templateDataString ) { [01:46:27] is it because there's no function XXXX ( ... ) name ? [01:46:53] Those are local variables [01:47:02] which are methods [01:47:11] the entire thing is a singleton, most of those are "local" variables [01:47:30] why is it flagging those specific methods and not the rest [01:47:53] mooeypoo: ext.templateDataGenerator.ui.js class stil has no name due to it indexing the string 'use strict' [01:48:20] ohh [01:48:23] Move that down one line, and either remove @author or into a /*! file comment outside the closure [01:50:13] I've used var ... = function () { .. in the past and it was able to pick up on the name [01:50:56] Krinkle, I took off @author, moved the comment so it's right above the mw.libs.tdgUi = ( function () { line, and added @class [01:50:58] it's still not working [01:51:53] (03PS3) 10Mooeypoo: Document code with JSDuck [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 (owner: 10Krinkle) [01:51:55] Krinkle, ^^ [01:52:00] this is so frustrating :\ [01:52:28] And the errors are the same errors [01:52:57] mooeypoo: have a look at the html outout as well to see what it's thinking [01:54:42] mooeypoo: https://gist.github.com/Krinkle/089447276cd4fcb877c0 [01:54:45] That fixes the errors for me [01:54:58] The '=' assignments need a name given [01:55:07] hm so naming literally [01:56:22] \o/ [01:56:26] Krinkle, that works. Thanks! [01:56:36] (03PS4) 10Mooeypoo: Document code with JSDuck [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 (owner: 10Krinkle) [02:02:35] 10OOjs-UI, 10UI-Standardization, 7Design: PopupButtonWidget (frameless, with popup head)‎ shows at hover instead of onClick? - https://phabricator.wikimedia.org/T88630#1097560 (10Jaredzimmerman-WMF) How/Is this different from Tipsy? (functionally) [02:05:12] James_F: Is the job push working? [02:06:09] Krinkle: Sorry, got distracted whilst looking for documentation to work out how to do it. [02:06:12] Not tried. [02:10:08] James_F: OK [02:12:20] Krinkle: "error: [Errno 13] Permission denied: 'jenkins_job_builder.egg-info/requires.txt' " [02:15:56] Oh, I need to do this with sudo? Lame. [02:17:59] 10VisualEditor, 7Technical-Debt: Put jquery.client back in VE core - https://phabricator.wikimedia.org/T91460#1097566 (10Jdforrester-WMF) Does this mean we need to spin it out as a real library? [02:19:17] Krinkle: Also we're running I guess an old version of JJB – latest release was 1.1.0 on Christmas Eve, our master is not updated since mid-October. [02:19:48] James_F: Doesn't matter much [02:20:10] It's a parser for yaml->xml. Whatever bug fixes or new features it has we're not using or affected by. [02:20:11] Krinkle: Do you really want me to execute `jenkins-jobs --conf etc/jenkins_jobs.ini update config/ 'operations-apache-config-lint'`? [02:20:52] Oh, yeah, I was reading the instructions about keeping current with Jenkins, not JJB. Never mind. :-) [02:22:16] Hey TrevorParscal. You OK? [02:28:10] James_F: I've trimmed 1 kilobyte off of the JJB page [02:28:24] Krinkle: OK. Is that a 'yes', or a 'no'? :-) [02:28:32] It should be simpler now [02:28:45] James_F: The argument is the job name. Not operations-puppet most likely [02:28:51] Oh. [02:28:54] That makes sense. [02:28:56] 'example-jenkins-job' [02:29:03] is what the docs say now [02:29:26] output/mwext-TemplateData-jsduck-publish instead. [02:29:29] * James_F nods. [02:29:35] -output/ [02:29:40] But yeah [02:29:42] Documentation is much better now. [02:30:09] So, `integration/jenkins-job-builder$ jenkins-jobs --conf etc/jenkins_jobs.ini update config/ 'output/mwext-TemplateData-jsduck-publish'`? [02:30:29] no output/ [02:30:44] OK. [02:30:46] But yeah, that looks good [02:31:27] {{doing}} [02:32:11] Oh dear. [02:32:14] Python fatal. [02:32:24] urllib2.URLError: [02:32:34] Is CI running on a self-signed cert? [02:32:39] James_F: Did you run 'test' first to create the xml files? Does cat output/... show the xml? [02:32:45] Did you create the /etc/ini file? [02:33:32] etc/jenkins_jobs.ini exists, yes. [02:33:52] I didn't follow the instructions to test it that didn't exist until 3 minutes ago, no. [02:34:02] Said instructions don't say how, I'd point out. [02:34:18] this was there already [02:34:27] "Now use jenkins-jobs test to validate the YAML files and generate the XML files in output/ directory." [02:34:28] Helpful. [02:34:46] Yeah, teh command is called 'test' [02:34:52] but it's what creates the files [02:35:20] jenkins-jobs test config/ -o output/ [02:35:24] That I ran, yes. [02:35:26] The file exists. [02:35:30] Godo [02:35:31] Good [02:35:38] https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder#Authenticate_JJB [02:35:52] And the ini file points to the correct server and has our uusername/token in it? [02:36:04] your* [02:36:15] Yes? [02:36:29] url=https://integration.wikimedia.org/ci/ still? [02:36:39] Yup [02:36:48] Oh, do I need the 'allow_duplicates=True' bit? [02:36:57] Maybe. [02:37:00] That wasn't there. [02:37:01] Might as well copy it [02:38:28] Trying again; [02:38:41] No, fails with the same SSL certificate failure. [02:40:43] Krinkle: I take it you have no ideas? :-) [02:41:22] Indeed [02:41:24] Let me try [02:41:28] Kk. [02:44:42] James_F: What version of python and pip? [02:44:47] jenkins-jobs --conf etc/jenkins_jobs.ini update config/ 'mwext-TemplateData-jsduck-publish' [02:44:47] INFO:root:Updating jobs in ['config/'] (['mwext-TemplateData-jsduck-publish']) [02:44:50] Works for me [02:44:53] pip 1.5.6 from /usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pip-1.5.6-py2.7.egg (python 2.7) [02:45:04] (`pip --version` output) [02:45:10] pip 1.5.6 from /usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pip-1.5.6-py2.7.egg (python 2.7) [02:45:14] Same here [02:45:20] Hmmmmm. [02:45:35] Maybe I'm having issues because I'm connecting from inside the cluster? [02:45:48] I usually connect from inside the cluster [02:45:51] Does integration have its own SSL service or do I magically bypass? [02:45:52] Hmm. [02:45:54] In that case… [02:46:33] Let's retry later. It's harmless to push a job that already exists. [02:46:35] So we can keep testing it [03:00:28] 10OOjs-UI, 10UI-Standardization, 7Design: PopupButtonWidget (frameless, with popup head)‎ shows at hover instead of onClick? - https://phabricator.wikimedia.org/T88630#1097585 (10violetto) I'm removing F37375 from the description because it is a tipsy. Tipsy-ies are non-interactive. You cannot move your cu... [03:00:48] (03CR) 10Jforrester: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 (owner: 10Krinkle) [03:06:07] 10OOjs-UI, 10UI-Standardization, 7Design: PopupButtonWidget should be shown at hover not on-click. - https://phabricator.wikimedia.org/T88630#1097586 (10violetto) a:3Prtksxna [03:09:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey TitleIsAlwaysKnown hook (so that EducationProgram pages and GlobalUserPage links render correctly) - https://phabricator.wikimedia.org/T72123#1097589 (10Krenair) E... [03:16:12] 10OOjs-UI, 10UI-Standardization, 7Design: Document tipsy - https://phabricator.wikimedia.org/T91856#1097595 (10violetto) 3NEW [03:16:58] 10OOjs-UI, 10UI-Standardization, 7Design: Document tipsy - https://phabricator.wikimedia.org/T91856#1097603 (10violetto) This is currently used on Flow, correct @pginer-wmf? [03:29:20] 10OOjs-UI, 10UI-Standardization, 7Design: Document frameless popupButtonWidget - https://phabricator.wikimedia.org/T91857#1097605 (10violetto) 3NEW [03:30:10] 10TemplateData, 10Continuous-Integration: Run JSduck in CI for TemplateData extension - https://phabricator.wikimedia.org/T91851#1097612 (10Krinkle) 5Open>3Resolved a:3Krinkle [03:30:20] 10TemplateData, 10Continuous-Integration: Run JSDuck in CI for TemplateData extension - https://phabricator.wikimedia.org/T91851#1097617 (10Krinkle) [03:33:49] (03CR) 10Krinkle: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 (owner: 10Krinkle) [03:35:18] (03CR) 10Jforrester: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo) [03:35:51] (03CR) 10jenkins-bot: [V: 04-1] Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo) [03:37:03] Ok. That's not good [03:38:01] What isn't? [03:38:24] Did the jenkins job not simulate a merge in your recheck and thus the jsduck is there? [03:38:28] Oh that comimit isn't merge that [03:38:29] yet [03:38:29] I was verifying that a commit in the TemplateData repo that has no jsduck stuff yet does indeed correctly fail. [03:38:38] James_F: merge this :P https://gerrit.wikimedia.org/r/#/c/194997/ [03:38:42] Yeah. OK for me to merge Ieb812a2fb? [03:39:05] (03CR) 10Jforrester: [C: 032] Document code with JSDuck [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 (owner: 10Krinkle) [03:39:10] The jsduck job (no prefix name for project) uses something quite new, so I'm on the look for that causing issues. [03:39:21] I thoguht maybe it did a plain git checkout of that patch, without merging onto master first locally [03:39:37] (03Merged) 10jenkins-bot: Document code with JSDuck [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194997 (owner: 10Krinkle) [03:41:55] * James_F nods. [03:42:07] (03PS4) 10Jforrester: Add optional text to deprecated property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194748 (https://phabricator.wikimedia.org/T90734) (owner: 10Mooeypoo) [03:43:17] (03CR) 10Jforrester: [C: 04-1] "Needs rebase. (Sorry.)" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo) [03:47:04] 10VisualEditor, 10VisualEditor-MediaWiki-References: Have the References list tool insert a general references list (99% action), rather than stopping to ask the user about which group to use - https://phabricator.wikimedia.org/T71727#1097618 (10Whatamidoing-WMF) For bonus points, you could keep the "What grou... [04:05:46] (03PS2) 10Krinkle: build: Update jscs to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194760 (owner: 10Jforrester) [04:10:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey TitleIsAlwaysKnown hook (so that EducationProgram pages and GlobalUserPage links render correctly) - https://phabricator.wikimedia.org/T72123#1097626 (10Jdforrester... [04:36:55] (03CR) 10Krinkle: [C: 032] build: Update jscs to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194760 (owner: 10Jforrester) [04:39:13] (03Merged) 10jenkins-bot: build: Update jscs to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/194760 (owner: 10Jforrester) [04:44:20] (03PS1) 10Krinkle: Enforce disallowMixedSpacesAndTabs jscs rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195013 [07:33:22] (03CR) 10Mvolz: "It's also missing the changes to localsettings.js.sample" [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 (owner: 10Mvolz) [07:35:35] (03CR) 10Mvolz: "Disregard that." [services/citoid] - 10https://gerrit.wikimedia.org/r/193154 (owner: 10Mvolz) [07:43:51] (03PS1) 10Mvolz: [WIP] Allow outbound proxy config; breaking change [services/citoid] - 10https://gerrit.wikimedia.org/r/195024 [07:46:49] (03PS2) 10Mvolz: [WIP] Allow outbound proxy config; breaking change [services/citoid] - 10https://gerrit.wikimedia.org/r/195024 (https://phabricator.wikimedia.org/T90341) [07:49:50] 10VisualEditor: Table cells disappearing when adding a "-" - https://phabricator.wikimedia.org/T91866#1097760 (10NicoV) 3NEW [07:51:54] (03PS1) 10Mvolz: [WIP] Fix acceptLanguage commit [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [07:52:28] (03Abandoned) 10Mvolz: [WIP] Outgoing proxy [services/citoid] - 10https://gerrit.wikimedia.org/r/194559 (owner: 10Mvolz) [07:55:25] (03CR) 10Mvolz: "I figure if I add enough reviewers we'll figure out who's responsible for +2 on the deploy directory ... does anyone know?" [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194548 (https://phabricator.wikimedia.org/T89872) (owner: 10Alexandros Kosiaris) [07:59:14] 10VisualEditor, 10VisualEditor-DataModel, 3VisualEditor 2014/15Q3 blockers, 5WMF-deploy-2015-02-25_(1.25wmf19), 5WMF-deploy-2015-03-04_(1.25wmf20): [Regression?] VE corruption issue(?) moving pre-existing categories to the middle of the page - https://phabricator.wikimedia.org/T74048#1097771 (10NicoV) Do... [08:39:50] (03PS2) 10Mvolz: [WIP] Fix acceptLanguage commit [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [08:51:08] 10OOjs-UI, 10VisualEditor: Pop-up "You are not logged in." warning cannot be closed via the "X" on touch devices - https://phabricator.wikimedia.org/T91757#1097800 (10Nnemo) [08:54:04] 10OOjs-UI, 10VisualEditor: Pop-up "You are not logged in." warning cannot be closed via the "X" on touch devices - https://phabricator.wikimedia.org/T91757#1097801 (10Nnemo) >>! In T91757#1096576, @Etonkovidova wrote: > Note: another issue (possibly, not related) - all drop down menus when open - stay open. Y... [09:02:36] (03PS3) 10Mvolz: [WIP] Fix acceptLanguage commit [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [09:05:02] (03PS4) 10Mvolz: [WIP] Fix acceptLanguage commit [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [09:32:31] (03PS5) 10Mvolz: [WIP] Fix acceptLanguage commit [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [10:40:53] (03PS6) 10Mvolz: Fix acceptLanguage commit a30d6be [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [10:44:04] (03PS3) 10Mvolz: Allow outbound proxy config; breaking change [services/citoid] - 10https://gerrit.wikimedia.org/r/195024 (https://phabricator.wikimedia.org/T90341) [10:46:21] (03CR) 10Mvolz: "I'm taking this out of WIP, but I haven't actually tested this change with an actual outbound proxy." [services/citoid] - 10https://gerrit.wikimedia.org/r/195024 (https://phabricator.wikimedia.org/T90341) (owner: 10Mvolz) [10:47:05] (03CR) 10Mvolz: "P.S. Roan, tell Trevor sorry :P" [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 (owner: 10Mvolz) [10:56:09] (03CR) 10Mobrovac: [C: 04-1] "You need to set the NO_PROXY var as well to be able to talk to zotero. See the in-line comment." (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/195024 (https://phabricator.wikimedia.org/T90341) (owner: 10Mvolz) [11:00:58] (03CR) 10Mobrovac: "Some additional comments for localsettings.js.sample" (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/195024 (https://phabricator.wikimedia.org/T90341) (owner: 10Mvolz) [11:11:08] (03CR) 10Mobrovac: [C: 04-1] "See the comment about error-throwing in Scraper.js" (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 (owner: 10Mvolz) [11:18:10] (03PS4) 10Mvolz: Allow outbound proxy config; breaking change [services/citoid] - 10https://gerrit.wikimedia.org/r/195024 (https://phabricator.wikimedia.org/T90341) [11:18:31] (03CR) 10Mvolz: Allow outbound proxy config; breaking change (033 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/195024 (https://phabricator.wikimedia.org/T90341) (owner: 10Mvolz) [11:34:06] (03CR) 10Mvolz: Fix acceptLanguage commit a30d6be (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 (owner: 10Mvolz) [11:35:44] (03PS7) 10Mvolz: Fix acceptLanguage commit a30d6be [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [11:37:09] (03PS8) 10Mvolz: [WIP] Fix acceptLanguage commit a30d6be [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [11:43:31] (03PS9) 10Mvolz: Fix acceptLanguage commit a30d6be [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [11:48:39] (03PS10) 10Mvolz: [WIP] Fix acceptLanguage commit a30d6be [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [11:56:38] (03PS11) 10Mvolz: Fix acceptLanguage commit a30d6be [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [12:05:02] (03PS12) 10Mvolz: Fix acceptLanguage commit a30d6be [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 [12:07:26] (03CR) 10Mvolz: "Okay, what I ended up doing was:" [services/citoid] - 10https://gerrit.wikimedia.org/r/195025 (owner: 10Mvolz) [12:19:54] 10VisualEditor, 10VisualEditor-MediaWiki: References disappear after change of their "Références" template call ( tag not used) - https://phabricator.wikimedia.org/T91654#1097958 (10Nnemo) [12:56:55] 10VisualEditor, 10MediaWiki-General-or-Unknown, 7Mobile: In the mobile Web visual editor, trying to edit the template call fails - https://phabricator.wikimedia.org/T91880#1097994 (10Nnemo) 3NEW [14:46:06] (03CR) 10Alexandros Kosiaris: "I got +2 but this is implicitly inherited from the overall gerrit policy. I pretty sure I should NOT be using it regularly in this project" [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194548 (https://phabricator.wikimedia.org/T89872) (owner: 10Alexandros Kosiaris) [14:49:31] (03CR) 10Alexandros Kosiaris: [C: 031] Allow outbound proxy config; breaking change (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/195024 (https://phabricator.wikimedia.org/T90341) (owner: 10Mvolz) [15:25:28] 10VisualEditor, 10Parsoid: Table cells disappearing when adding a "-" - https://phabricator.wikimedia.org/T91866#1098144 (10matmarex) [15:41:13] 10OOjs-UI, 10UI-Standardization, 7Design: Document tipsy - https://phabricator.wikimedia.org/T91856#1098154 (10matmarex) Previously: {T70745}. [15:58:42] (03CR) 10Jforrester: "As a /deploy repo this should only be merged just before it's deployed into production." [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194548 (https://phabricator.wikimedia.org/T89872) (owner: 10Alexandros Kosiaris) [16:00:57] (03PS7) 10Bartosz Dziewoński: Tighten toolbar whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) [16:39:40] 10OOjs-UI, 5Patch-For-Review, 3VisualEditor 2014/15Q3 blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1098192 (10matmarex) Wide: {F58299,size=full} Narrow: {F58305,size=full} (It mostly cooperates with Vec... [16:44:35] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1098207 (10Jdforrester-WMF) [16:44:35] 10VisualEditor, 10Parsoid: Table cells disappearing when adding a "-" - https://phabricator.wikimedia.org/T91866#1098206 (10Jdforrester-WMF) [16:49:18] (03PS2) 10Jforrester: Enforce disallowMixedSpacesAndTabs jscs rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195013 (owner: 10Krinkle) [16:49:31] (03PS3) 10Jforrester: build: Enforce disallowMixedSpacesAndTabs jscs rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195013 (owner: 10Krinkle) [16:49:41] (03CR) 10Jforrester: [C: 032] build: Enforce disallowMixedSpacesAndTabs jscs rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195013 (owner: 10Krinkle) [16:51:39] 10OOjs-UI, 5Patch-For-Review, 3VisualEditor 2014/15Q3 blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1098218 (10Jdforrester-WMF) Is there a particular reason we don't make the narrower styling the default? [16:51:41] (03CR) 10jenkins-bot: [V: 04-1] build: Enforce disallowMixedSpacesAndTabs jscs rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195013 (owner: 10Krinkle) [16:52:10] (03Merged) 10jenkins-bot: build: Enforce disallowMixedSpacesAndTabs jscs rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195013 (owner: 10Krinkle) [17:11:06] 10OOjs-UI, 5Patch-For-Review, 3VisualEditor 2014/15Q3 blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1098239 (10matmarex) Yeah, the wide one looks better. Especially in the MediaWiki theme, where there are... [17:11:34] 10OOjs-UI, 5Patch-For-Review, 3VisualEditor 2014/15Q3 blockers: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow - https://phabricator.wikimedia.org/T52227#1098240 (10Jdforrester-WMF) Fair. [17:12:11] (03PS8) 10Jforrester: Toolbar: Tighten whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) (owner: 10Bartosz Dziewoński) [17:12:56] (03CR) 10Jforrester: [C: 031] Toolbar: Tighten whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) (owner: 10Bartosz Dziewoński) [17:43:18] (03PS11) 10Physikerwelt: Exports the MathCache table [extensions/Math] - 10https://gerrit.wikimedia.org/r/174727 [17:46:04] (03PS9) 10Bartosz Dziewoński: Tighten toolbar whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) [17:51:26] (03PS10) 10Bartosz Dziewoński: Toolbar: Tighten whitespace on narrow displays [oojs/ui] - 10https://gerrit.wikimedia.org/r/193282 (https://phabricator.wikimedia.org/T52227) [18:15:19] (03PS1) 10Bartosz Dziewoński: ve.ui.Toolbar: Do not remove event listeners in #setup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195046 [18:15:21] (03PS1) 10Bartosz Dziewoński: ve.ui.Toolbar: Fix up onWindowResize to call parent method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195047 (https://phabricator.wikimedia.org/T52227) [18:15:27] (03PS1) 10Bartosz Dziewoński: Do not call Toolbar#initialize twice during editor setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195048 [18:15:29] (03PS1) 10Bartosz Dziewoński: ve.init.mw.ViewPageTarget: Recalculate toolbar sizes when adding "Save" button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195049 (https://phabricator.wikimedia.org/T52227) [18:17:45] (03CR) 10jenkins-bot: [V: 04-1] ve.ui.Toolbar: Fix up onWindowResize to call parent method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195047 (https://phabricator.wikimedia.org/T52227) (owner: 10Bartosz Dziewoński) [18:18:26] (03CR) 10Physikerwelt: "@Chad: Thank you." (034 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/174727 (owner: 10Physikerwelt) [18:20:27] (03PS12) 10Physikerwelt: Exports the MathCache table [extensions/Math] - 10https://gerrit.wikimedia.org/r/174727 [19:09:30] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, and 3 others: Parsoid performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1098348 (10Eloquence) [19:09:53] (03PS1) 10Bartosz Dziewoński: ve.ui.FormatTool: Set deactivateOnSelect = false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195056 (https://phabricator.wikimedia.org/T91827) [19:20:57] (03PS1) 10Bartosz Dziewoński: Don't flicker "Manage TemplateData" button's disabledness state [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195057 (https://phabricator.wikimedia.org/T91324) [19:21:20] 10TemplateData, 5Patch-For-Review: Button widget flashes grey before settling on white - https://phabricator.wikimedia.org/T91324#1098397 (10matmarex) a:3matmarex [19:22:11] (03CR) 10Jforrester: [C: 031] Don't flicker "Manage TemplateData" button's disabledness state [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195057 (https://phabricator.wikimedia.org/T91324) (owner: 10Bartosz Dziewoński) [19:28:30] 10TemplateData, 5Patch-For-Review: Button widget flashes grey before settling on white - https://phabricator.wikimedia.org/T91324#1098419 (10matmarex) p:5Triage>3Normal [19:50:43] 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: Use a new focus indicator on MediaWiki UI text fields - https://phabricator.wikimedia.org/T73150#1098440 (10Florian) That's how it looks like on a scrollable textarea: {F58521} And this if you use WikiEditor: {F58523} That the right blue indica... [20:29:35] 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: Use a new focus indicator on MediaWiki UI text fields - https://phabricator.wikimedia.org/T73150#1098454 (10Ricordisamoa) I must say that I find the new style much more distracting than the previous one. Note how the Twitter Bootstrap (and Phabri... [21:01:33] 10MediaWiki-Page-editing, 7Accessibility: Give a hint there is a save button in action=edit - https://phabricator.wikimedia.org/T74350#1098482 (10Nemo_bis) [21:04:08] 10VisualEditor, 10VisualEditor-Performance: ve.init.mw.ViewPageTarget.prototype.setupToolbar called twice - https://phabricator.wikimedia.org/T91595#1098487 (10matmarex) Hmm, I may have accidentally fixed a part of this in https://gerrit.wikimedia.org/r/195046 and https://gerrit.wikimedia.org/r/195048, or poss... [21:10:50] (03PS1) 10Bartosz Dziewoński: demo: Use popup with head in the toolbars demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/195066 [21:24:18] 10OOjs-UI, 10VisualEditor: Pop-up "You are not logged in." warning cannot be closed via the "X" on touch devices - https://phabricator.wikimedia.org/T91757#1098509 (10matmarex) a:3matmarex [21:24:26] 10OOjs-UI: Toolbar menus don't disappear when another menu is opened on touch devices - https://phabricator.wikimedia.org/T87818#1098510 (10matmarex) a:3matmarex [21:24:44] (03PS1) 10Bartosz Dziewoński: Remove half-baked touch event handling [oojs/ui] - 10https://gerrit.wikimedia.org/r/195067 (https://phabricator.wikimedia.org/T87818) [22:28:29] MatmaRex: Having fun? :-) [22:29:42] James_F: fixing bugs by removing code is the best fun i ever had [22:29:47] * James_F grins. [22:30:06] Technically that'd be a breaking change. [22:30:30] But eh. [22:36:06] wait, which one? [22:36:22] Removing nominal touch support. [22:36:40] Possibly more than nominal, if I remember the iOS issues correctly. [22:37:11] James_F: you know, we have none of that stuff for, say, buttons. [22:37:13] it didn't break anything for me. [22:37:27] MatmaRex: In iOS? In iOS as used in MobileFrontend? [22:37:29] i would imagine that someone would have noticed if no buttons worked on ios. [22:37:39] MatmaRex: ISTR there were some serious borkages there. [22:37:49] but figuring out this kind of thing is why i added mobile people as reviewers [22:37:54] * James_F nods. [22:38:08] and why i trust that you will hunt them down and make them look at it if they ignore gerrit queues. :) [22:38:12] :-D [22:38:52] i'm not hip enough to own i-devices myself. :) [22:39:10] * James_F mumbles about CrossBrowserTesting.com :-P [22:49:40] Can anyone point me to a page with a working copy of OOjs UI toolbar? [22:51:30] 10VisualEditor, 10VisualEditor-Performance, 3VisualEditor 2014/15 Q3 blockers: Eliminate call to $.getVisibleText() in ve.init.mw.Target.prototype.onNoticesReady - https://phabricator.wikimedia.org/T87412#1098575 (10Jdforrester-WMF) a:3Krinkle [22:52:07] (03CR) 10Jforrester: "Does this also cover T90304 (Load HTML in parallel with JSON metadata) and/or T87553 (API requests to action=visualeditor&paction=parse mo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope) [22:52:57] Negative24: en.wikipedia.org/wiki/Special:Random?veaction=edit [22:53:19] Negative24: https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#toolbars-mediawiki-vector-ltr for the demo. [22:54:30] James_F: Well yes. I was aware of the first naturally and the demo's source I have looked at and it is a bit more complicated than I would like since it is run automatically and uses loops. [22:54:52] *uses loops to initialize the toolbars [22:55:21] * James_F nods. [22:56:37] Negative24: MatmaRex would be an expert more than me. [22:57:27] James_F: Thanks. [22:58:07] yeah, the demo is a really bad example [22:58:20] Slightly too clever. [22:58:27] way too clever. [22:58:36] It's mostly for showing the interface, not how to code it. [22:59:09] MatmaRex: I looked at it for awhile and I still can't make sense of it. [23:02:44] (03PS2) 10Bartosz Dziewoński: ButtonElement: Use #setButtonElement correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/192182 (owner: 10Krinkle) [23:02:56] (03PS3) 10Bartosz Dziewoński: ButtonElement: Use #setButtonElement correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/192182 (owner: 10Krinkle) [23:03:01] (03CR) 10Bartosz Dziewoński: [C: 031] ButtonElement: Use #setButtonElement correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/192182 (owner: 10Krinkle) [23:04:45] Negative24: i'm afraid we have no other examples, other than VE's use of the toolbars (which is crazy in entirely different ways) [23:05:21] and i'm not really able to explain it succintly, i'm not sure if i understand that fully myself :) [23:06:06] (03CR) 10Bartosz Dziewoński: [C: 032] "How about now?" [oojs/core] - 10https://gerrit.wikimedia.org/r/194813 (owner: 10Krinkle) [23:06:59] (03CR) 10jenkins-bot: [V: 04-1] jsduck: Set --processes=0 to fix warnings-exit-nonzero [oojs/core] - 10https://gerrit.wikimedia.org/r/194813 (owner: 10Krinkle) [23:07:01] MatmaRex: Hmm. I have created a task on the subject (T91195). It seems that toolbars are setup for a rewrite soon. [23:07:23] hopefully [23:07:41] (03CR) 10Bartosz Dziewoński: "I guess not." [oojs/core] - 10https://gerrit.wikimedia.org/r/194813 (owner: 10Krinkle) [23:08:07] James_F: are we planning to do anything about that? ^ not being able to merge changes is… suboptimal [23:08:21] MatmaRex: Hopefully in a way that's a bit more easy to understand :) [23:15:57] MatmaRex: I have faith that Krinkle|detached will fix it soon enough.