[00:00:04] Chrome [00:00:45] Chrome Version 41.0.2272.76 (64-bit) on a Mac running Yosemite Version 10.10.2 [00:00:49] TrevorParscal: on mac? strange? i see perfect line height [00:00:55] wait, attaching screens. [00:01:13] did you run "grunt build" in the command line after making changes? [00:01:27] otherwise the CSS doesn't get compiled and you won't see your changes [00:03:31] yes. i did [00:03:32] http://i.imgur.com/qlmOZV3.png [00:04:20] TrevorParscal: this is in chrome 40 on mac [00:05:25] i will take a look tomorrow, I have to help with family stuff now [00:05:58] I will be in the office, so we can look at it in person if it starts getting confusing [00:06:00] TrevorParscal: okay, because fixing the line height was one of the point of making this patch along with making it in sync with mw buttons [00:06:27] I know, and I'm confident we will achieve that [00:06:30] cyall tomorrow [00:07:09] TrevorParscal: sounds good! [01:06:19] Krenair, if you can make a failing unit test then it'll be easier for others to take a look - dm internal list is pretty complex. [01:06:36] will try that later [03:14:15] when you edit the group, the keyedNodes entry for the old node group is removed and the reference gets an entry in the new node group [03:14:47] But undoing does not reverse this [03:16:58] I think ve.dm.MWReferenceModel.prototype.updateInternalItem is supposed to handle this, but it is not called on undo [07:27:29] (03PS41) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [07:28:36] (03CR) 10Paladox: "@Krinkle please could you review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [07:29:18] (03CR) 10Paladox: "@Krinkle please could you review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [11:11:13] (03PS10) 10Alex Monk: If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://phabricator.wikimedia.org/T56906) [12:36:05] 10MediaWiki-ResourceLoader, 10Continuous-Integration, 10MediaWiki-Vagrant, 10Wikidata, and 3 others: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1109063 (10Tobi_WMDE_SW) [12:51:38] [13:25] Krenair [2015-03-10 16:03:26] undoing changes to the group of a reference... does not work properly [12:51:50] Krenair, edsanders: https://phabricator.wikimedia.org/T91943 [12:53:36] yeah, that's the task I was looking at [12:53:43] I think I might have noticed something similar being broken when I was working on subdocuments [12:53:50] As in, code that I expected to exist didn't exist [12:58:00] did you read https://phabricator.wikimedia.org/T71119#1107032 ? [12:58:18] I'm not sure what the proper way to reverse it on undo would be [13:09:30] Strange [13:09:40] There should be nothing fundamentally different about undo, in theory [13:09:52] What happens if you change the reference's group twice? i.e. from A to B and then from B to C [13:09:59] Does that produce the same error [13:13:22] RoanKattouw, no error when I change it twice [13:13:32] weird [13:18:58] (03CR) 10Catrope: [C: 032] Make ve.init.sa.Target toolbar config overridable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195833 (https://phabricator.wikimedia.org/T90762) (owner: 10Mattflaschen) [13:21:00] (03Merged) 10jenkins-bot: Make ve.init.sa.Target toolbar config overridable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195833 (https://phabricator.wikimedia.org/T90762) (owner: 10Mattflaschen) [13:21:51] Krenair: Oooh I think I understand [13:22:31] Group changes are done by MWReferenceModel [13:22:44] But they should really be handled by an onAttributeChange listener in MWReferenceNode [13:22:49] yes [13:23:00] If you directly commit a transaction to change a group, it doesn't work, it only works if you go through MWReferenceModel [13:23:11] Which obviously undo doesn't do, because it just directly commits the mirror image of the transaction [13:24:38] This is horrible [13:26:33] I remember solving this problem in my subdocuments branch but IIRC it required a different event for attributes changign [13:26:44] Or listening to both attributes, or something [13:27:53] Krenair: First pass at a fix that you could try: add an onAttributeChange handler to MWReferenceNode, if the attribute being changed is listGroup, listKey or listIndex, then do this.removeFromInternalList(); this.addToInternalList(); , except that removeFrom needs to pass the old values and addTo needs to pass the new ones [13:27:56] Does that make sense? [13:28:32] You would also have to remove the existing removeFrom+addTo calls in updateInternalItem [13:28:35] yep [13:28:37] oh, wait [13:28:38] // HACK: Removing and re-inserting nodes to/from the internal list is done [13:28:39] // because internal list doesn't yet support attribute changes [13:28:49] we'll get one onAttributeChange call per attribute [13:28:53] Yeah :S [13:29:05] but we want to remove based on all the old values [13:29:07] I'm now looking into how my documentset branch addressed this [13:29:09] and add based on all the new ones [13:29:20] Well, theoretically yes [13:29:48] But if we remove and add several times that sucks but it's not a complete disaster, right? [13:30:01] I mean if there's a naming conflict then the reference will briefly be mis-associated with a semi-random existing reference [13:30:12] But the next attribute change event that fires immediately after will fix that [13:31:49] Krenair: Oh, shit, you were onto something [13:31:51] + // Unfortunately onAttributeChange fires twice if both group and name have changed, [13:31:52] + // but the first time it fires, both attributes have already changed. [13:31:54] + // This makes it difficult to use the from parameter to get the old values, so instead we compare [13:31:55] + // the current group and name to the registered group and name and reregister if they differ. [13:32:33] If group and name change in the same transaction, then we'll first fire (attributeChange, 'name', oldName, newName) but at that point we won't know what oldGroup is [13:32:49] The next event will tell us but that's in the future, and this.element.attributes.listGroup is already the new value [13:33:37] Krenair: So in my branch I fixed this by having addToInternalList() (or my equivalent thereof) set this.registeredName and this.registeredGroup, and then removeFromInternalList() uses those properties rather than looking at attributes [13:33:54] That way you know for sure you always deregister with the same information you originally registered with [13:39:40] Krenair: So if you implement that then I think you should be set [13:39:57] okay [13:39:58] thanks RoanKattouw [14:00:26] (03CR) 10Catrope: [C: 032] Revert "Prevent form submission in FragmentInspector" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195780 (owner: 10Bartosz Dziewoński) [14:01:59] (03PS4) 10Krinkle: [BREAKING CHANGE] ve.utils: Remove ve.indexOf in favour of Array#indexOf [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195582 [14:04:03] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] ve.utils: Remove ve.indexOf in favour of Array#indexOf [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195582 (owner: 10Krinkle) [14:04:35] (03CR) 10Krinkle: "@Ed: How does that relate to the second OR-ed check. Should that still run if there is no blacklist? (in ve.dm.ElementLinearData#sanitize)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195582 (owner: 10Krinkle) [14:04:47] (03Merged) 10jenkins-bot: Revert "Prevent form submission in FragmentInspector" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195780 (owner: 10Bartosz Dziewoński) [14:06:08] (03PS6) 10Catrope: [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) [14:06:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope) [14:16:24] Krenair: Re Gadgets 2.0 as a Q4 proposal: AWESOME [14:16:38] It was legoktm's idea :) [14:17:15] I was working with him on it at wikimania, so agreed to help further [14:20:13] RoanKattouw, so we need to handle listGroup, listKey and listIndex attributes [14:20:54] I don't see why we can't use from/to parameters for listGroup [14:21:17] old listKey and listIndex though... [14:24:11] That's the thing [14:24:39] You get the events in the following order (attributeChange, 'listGroup', oldGroup, newGroup) ; (attributeChange, 'listKey', oldKey, newKey) [14:24:46] (or vice versa) [14:24:59] But at the point in time when the first event fires, you have no way of knowing what oldKey is [14:25:27] Because this.element.attributes is updated before any of the events fire, rather than being updated in lockstep with the events [14:26:18] right [14:26:36] so we need to set registeredListKey and registeredListIndex in addToInternalList? [14:26:50] Yeah [14:27:08] Set them there, and use those rather than element.attributes in removeFromInternalList [14:37:33] (03PS1) 10Alex Monk: Handle undoing of reference group changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195901 (https://phabricator.wikimedia.org/T71119) [14:51:25] (03CR) 10Krinkle: demo: Load styles before building demo widgets (not asynchronously) (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [14:52:03] Heya. [14:52:05] Krenair: Fancy. :-) [14:52:44] I don't suppose anyone (RoanKattouw_away?) looked at https://gerrit.wikimedia.org/r/#/c/195580/ did they? [14:52:51] (VE SWAT pullthrough that's failing tests.) [14:55:48] (03PS1) 10Krinkle: Add composer entry point for phpcs and linting [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195907 (https://phabricator.wikimedia.org/T90943) [14:55:58] (03CR) 10Krinkle: [C: 032] "Fix tests." [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195907 (https://phabricator.wikimedia.org/T90943) (owner: 10Krinkle) [14:56:12] Krinkle: Was that it? Eurgh. [14:56:19] James_F: That's 30% of it [14:56:25] OK, well, that's a start. ;-) [14:56:56] (03PS2) 10Jforrester: Remove the zotero translation server and translators [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194548 (https://phabricator.wikimedia.org/T89872) (owner: 10Alexandros Kosiaris) [14:56:59] (03CR) 10jenkins-bot: [V: 04-1] Add composer entry point for phpcs and linting [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195907 (https://phabricator.wikimedia.org/T90943) (owner: 10Krinkle) [14:57:13] Helpful. [14:58:16] (03CR) 10Krinkle: [V: 032] "Making progress to fix tests. The composer is passing here. The others were already failing." [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195907 (https://phabricator.wikimedia.org/T90943) (owner: 10Krinkle) [14:58:21] (03CR) 10Catrope: [C: 04-1] Handle undoing of reference group changes (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195901 (https://phabricator.wikimedia.org/T71119) (owner: 10Alex Monk) [14:59:35] (03PS1) 10Krinkle: Update JSDuck config to standard jsduck.json [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195908 [14:59:58] It's a good excercise, since we'll need this in REL* at some point as well I imagine [15:00:42] (03CR) 10jenkins-bot: [V: 04-1] Update JSDuck config to standard jsduck.json [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195908 (owner: 10Krinkle) [15:01:00] Krinkle: If we ever backport stuff there. [15:01:44] (03CR) 10Krinkle: [C: 032 V: 032] "Making progress. JSDuck is now working. (though needs I690d10)." [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195908 (owner: 10Krinkle) [15:01:53] (03PS1) 10Krinkle: Follow-up I5918367: Add new classes to jsduck.json [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195909 [15:02:33] Krinkle: BTW, when you're done rescuing us, why /did/ I5918367 not fail without that follow-up? [15:02:52] It did [15:03:31] James_F: It failed on wmf branch [15:03:40] Krinkle: But it worked in master. [15:03:45] Krinkle: And then later failed in master. [15:03:51] James_F: It didn't fail on master because it didn't have --process=0, so it used parallel processing which means no error handling [15:04:01] Krinkle: Which is almost exactly what CI is meant to prevent. [15:04:03] Ah. [15:04:10] * James_F sighs. [15:04:34] James_F: It reported the error on master as well, but ended with success [15:05:04] Krinkle: Unhelpful. :-) [15:05:23] (03PS2) 10Jforrester: Update VE core to c0d60b6 for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195580 [15:06:23] 10VisualEditor, 10VisualEditor-Performance, 10RESTBase: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1109568 (10Jdforrester-WMF) [15:06:24] (03CR) 10Krinkle: [C: 032 V: 032] "Making progress. Composer and jsduck now passing. QUnit still has an odd exception caused by a missing class." [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195909 (owner: 10Krinkle) [15:07:15] 10VisualEditor, 10VisualEditor-Performance, 10RESTBase: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1016326 (10Jdforrester-WMF) Roan suggests that, instead, this should be RESTbase's problem and VisualEditor continues to dumb... [15:07:36] (03CR) 10jenkins-bot: [V: 04-1] Update VE core to c0d60b6 for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195580 (owner: 10Jforrester) [15:10:29] (03PS7) 10Esanders: Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) [15:11:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 3VisualEditor 2014/15 Q3 blockers: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1109578 (10Jdforrester-WMF) [15:13:19] James_F: Reproducing mising class error locally now [15:13:36] James_F: Aside from my backports just now, do we have any wmf20 commits that are merged but not deployed? [15:15:16] James_F: It's failing in ve.ui.AnnotationTool.js:287 [15:15:29] Krinkle: No, that's it. [15:15:33] * James_F looks. [15:15:47] I can reproduce it locally with mw-core and ve-mw of wmf20. [15:15:55] :-( [15:15:58] ve-mw@wmf20 with latest mwcore@master is fine [15:16:11] So presumably we're using something from oojs-ui that is not yet released or backported? [15:16:12] OO.inheritClass( ve.ui.MoreTextStyleTool, OO.ui.ToolGroupTool ); [15:16:17] ToolGroupTool is new in OOUi [15:16:25] Oh. [15:16:30] But that shouldn't be in the backport. [15:16:35] How did that end up in the branch, though? [15:16:40] * James_F sighs. [15:16:47] Did we merge that during the branch creation process? [15:17:19] I'm investigating [15:17:25] OK [15:17:36] It's in https://gerrit.wikimedia.org/r/#/c/193484/ which is 0.9.0 which is wmf21+ only. [15:17:52] I clearly screwed up. I'm just not sure how. [15:17:58] Ahm [15:18:00] (This is unrelated to the change we're backporting.) [15:18:03] WTF is going on with VisualEditor's wmf20 branch [15:18:07] Exactly [15:18:08] It wasn't created by make-wmf-branch [15:18:17] RoanKattouw: VE-core? [15:18:21] No, VE-MW [15:18:28] It wasn't? [15:18:31] That's not good. [15:18:36] Its git log does not contain a "Creating branch" commit, and its .gitreview points to maste [15:18:38] r [15:18:43] Let's see if I can salvage from MW core wmf20 [15:18:46] Yeah, I noticed that [15:18:54] I figured maybe our make branch script dind't do that anymore [15:21:29] WTF [15:21:30] 10VisualEditor, 10VisualEditor-Performance, 10RESTBase: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1109610 (10marcoil) >>! In T88623#1109590, @Catrope wrote: > Given that T90374 will almost certainly be done before T78676, i... [15:21:38] This mistake was made when creating the branch, somehow [15:21:54] Checking other extensions [15:22:16] All extensions are affected [15:23:46] But wmf19 is fine [15:23:56] Something weird happened to wmf20 [15:24:10] This makes it harder but not impossible to check if James_F made it even worse, I'll check that now [15:24:25] RoanKattouw: Why thank you. :-P [15:24:37] I'll try to catch Mukunda about this before he creates the wmf21 branches later today [15:24:42] RoanKattouw: I imagine the switchover might have made the wmf cut worse. [15:24:43] Yeah. [15:25:36] What switchover? [15:25:49] Reedy -> Mukunda [15:27:12] Well wmf19 was created by Mukunda according to git log and it doesn't have this issue [15:28:38] Aha [15:28:56] ? [15:29:12] https://gerrit.wikimedia.org/r/#/c/195290/ , which I blindly +2ed because it looked auto-generated, was broke [15:29:14] n [15:29:43] :-( [15:30:49] FWIW the wmf20 wikis work fine with VisualEditor. [15:31:02] It's not obvious why [15:31:12] What was broken about it? [15:31:36] James_F: Run cd lib/ve && git log 79004c9a36b483b640d1e64cba28596ad6700eaa..bc8b38893c72a09428dc44a2ca66b8017e733f62 [15:31:45] Expect 1 change, see a dozen [15:32:09] You didn't break this the obvious way by resetting the submodule pointer to my commit instead of cherry-picking it [15:32:17] Yeah, that's not good. [15:32:22] Maybe you branched the wmf20 branch of VE core at the wrong point and cherry-picked on top of that [15:32:27] Why is the cherry-pick including… oh. [15:32:45] This appears to be the only wmf20 VE core cherry-pick [15:32:53] So this is easy to recover [15:32:57] Well. Maybe I shouldn't have trusted wmf20 in VE-MW to tell me what wmf20 of VE-core was. [15:33:11] Because clearly it was wrong. [15:33:17] Oh you created a second one, whatever, I can clean this up too [15:33:22] No, it was correct at the time [15:33:32] Are you sure? [15:33:33] Maybe you forgot to git submodule update enough times or something [15:33:38] Submodules are confusing man [15:33:41] Well git says so [15:34:20] * James_F sighs. [15:34:35] Thankfully from wmf21 onwards the VE-core pointer will be created automatically. [15:34:39] Yeah [15:34:42] So fewer changes to muck this up. [15:34:55] Another reason why I need to pay attention when Mukunda runs make-wmf-branch today [15:35:00] :-) [15:37:17] Krinkle, why is this failing, it works locally https://gerrit.wikimedia.org/r/#/c/191037/ ? [15:37:46] (03PS1) 10Jforrester: Update VE core submodule to master (4d7fda1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195919 [15:38:13] edsanders: Could you +2 https://gerrit.wikimedia.org/r/195919 for the wmf21 cut? [15:39:05] (03PS1) 10Catrope: Fix broken .gitreview file [VisualEditor/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195920 [15:39:16] James_F: +2 ---^^ please? [15:39:21] RoanKattouw: I can't. [15:39:28] You should be able to [15:39:29] Oh, wait, I can. [15:39:30] It's VE core [15:39:31] I shouldn't. [15:39:33] But I can. [15:39:36] (03CR) 10Jforrester: [C: 032] Fix broken .gitreview file [VisualEditor/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195920 (owner: 10Catrope) [15:39:36] Yeah. [15:39:38] Thanks [15:39:43] Quality security measures, us. [15:39:45] Once that merges, I'm going to have to do things that confuse Gerrit [15:39:51] Let's see how successful that will be [15:41:09] edsanders: Looks like a genuine failure to me. [15:41:42] (03Merged) 10jenkins-bot: Fix broken .gitreview file [VisualEditor/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195920 (owner: 10Catrope) [15:41:55] works in QUnit locally [15:42:12] edsanders: Including Chrome? [15:42:23] edsanders: Maybe old WebKit (PhantomJS) deduplicates classes [15:42:25] RoanKattouw: :-) [15:42:41] ugh [15:43:12] Yeah that doesn't work, I'll have to do a bit of forgery here [15:45:08] Oh great grrrit-wm broke again [15:45:08] fails in FF [15:45:24] RoanKattouw: It's just being restarted a lot by YuviPanda. [15:45:32] RoanKattouw: Not actually broken. Probably. [15:45:36] not broken [15:45:43] I removed about 60% moving parts. should be more stable now. [15:47:41] (03PS2) 10Catrope: Update VE core submodule for cherry-pick [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195926 [15:47:43] (03PS2) 10Catrope: Follow-up 02923f694630: fix submodule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195924 [15:47:46] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule for cherry-pick [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195926 (owner: 10Catrope) [15:47:51] (03CR) 10jenkins-bot: [V: 04-1] Follow-up 02923f694630: fix submodule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195924 (owner: 10Catrope) [15:48:37] oooh [15:48:43] GRMBL [15:49:21] (03PS1) 10Catrope: Fix broken .gitreview [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195929 [15:49:23] (03PS1) 10Catrope: Follow-up 02923f694630: fix submodule [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195930 [15:49:25] (03PS1) 10Catrope: Update VE core submodule for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195931 [15:49:29] (03Abandoned) 10Catrope: Follow-up 02923f694630: fix submodule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195924 (owner: 10Catrope) [15:49:37] (03Abandoned) 10Catrope: Update VE core submodule for cherry-pick [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195926 (owner: 10Catrope) [15:50:35] (03CR) 10jenkins-bot: [V: 04-1] Fix broken .gitreview [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195929 (owner: 10Catrope) [15:51:07] (03CR) 10Catrope: [C: 032 V: 032] Fix broken .gitreview [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195929 (owner: 10Catrope) [15:52:40] (03CR) 10Catrope: [C: 032] Follow-up 02923f694630: fix submodule [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195930 (owner: 10Catrope) [15:52:46] (03CR) 10Catrope: [C: 032] Update VE core submodule for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195931 (owner: 10Catrope) [15:57:36] James_F: Holy crap we are so lucky [15:57:43] The only reason that wmf20 wikis aren't fatally broken is this: [15:57:44] 23:25 logmsgbot: legoktm Synchronized php-1.25wmf20/extensions/VisualEditor/lib/ve/src/ce/nodes/ve.ce.TableCellNode.js: https://gerrit.wikimedia.org/r/#/c/195290/ (duration: 00m 06s) [15:57:59] That's a ridiculously specific sync which pretty much no other deployer would have done [15:58:06] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Citoid, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-sel... - https://phabricator.wikimedia.org/T88152#1109689 [15:58:11] Most people including myself are lazy and do sync-dir extensions/VisualEditor [15:58:16] RoanKattouw: o.O yw? :P [15:58:30] Which, if that had been done, would have broken everything [15:58:41] I just synced what changed in the submodule update [15:58:45] So instead, it'll break on the next scap [15:58:52] lolol [15:58:52] You synced what the submodule update *claimed* it changed [15:59:08] oh heh [15:59:14] It actually updated a lot more code to master-ish, introducing a dependency on an undeployed version of OOUI [15:59:34] I'm cleaning this up now [15:59:57] Thankfully James_F had me and Krinkle investigate the Jenkins failures in wmf20 [16:00:02] (03CR) 10Jforrester: [C: 032] Add bash script for updating submodule [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195911 (owner: 10Mvolz) [16:00:12] (We tend to ignore Jenkins failures in wmf branches most of the time, because they're so frequently full of crap) [16:00:13] (03Merged) 10jenkins-bot: Follow-up 02923f694630: fix submodule [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195930 (owner: 10Catrope) [16:00:15] (03Merged) 10jenkins-bot: Update VE core submodule for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195931 (owner: 10Catrope) [16:00:32] Right, now I need to get those two commits up there deployed [16:01:25] RoanKattouw: You rock. [16:01:37] Oh, meh. [16:02:20] (03CR) 10Jforrester: "Bleh, needs a submitter." [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195911 (owner: 10Mvolz) [16:03:41] (03PS1) 10Jforrester: Update citoid submodule to master (2cd246b) [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195937 [16:03:58] (03CR) 10Mvolz: "I need to update this anyway :). Phew!" [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195911 (owner: 10Mvolz) [16:04:32] Yay for frequent Sublime releases lately [16:04:36] Lots of minor bug fixes [16:04:41] Like every week [16:04:50] auto-download [16:04:57] (03PS5) 10Krinkle: [BREAKING CHANGE] ve.utils: Remove ve.indexOf in favour of Array#indexOf [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195582 [16:05:41] Krinkle: Almost as frequent as Atom. ;-) [16:06:44] (03PS6) 10Krinkle: [BREAKING CHANGE] ve.utils: Remove ve.indexOf in favour of Array#indexOf [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195582 [16:07:47] (03PS2) 10Mvolz: Add bash script for updating submodule [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195911 [16:09:55] (03PS3) 10Mvolz: Add bash script for updating submodule [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195911 [16:12:25] (03CR) 10Jforrester: [C: 031] Add bash script for updating submodule [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195911 (owner: 10Mvolz) [16:12:56] mvolz: Oh, you'd already done the submodule update. [16:13:00] mvolz: Forgive me. [16:13:20] (03Abandoned) 10Jforrester: Update citoid submodule to master (2cd246b) [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195937 (owner: 10Jforrester) [16:13:38] We're both really eager, I can tell [16:13:51] I also pmed poor gwicke about answering that phabricator thread [16:13:57] like 2 minutes before you did [16:13:58] haha [16:14:13] mvolz: :-D [16:14:24] RoanKattouw: Is the deploy you're doing including https://gerrit.wikimedia.org/r/#/c/195290/ ? [16:15:49] Hey James_F, saw your comment on my warning task, has the core patch with the ooui update been merged already too? [16:16:08] marktraceur: No, that's a wmf22 thing. [16:16:13] James_F: Yes and also Ed's thing [16:16:15] marktraceur: So merged in a few hours. [16:16:18] RoanKattouw: Awesome, thanks. [16:16:29] OK... [16:16:38] James_F: Don't suppose you have a link to the patch? [16:16:43] marktraceur: It'll be in OOjs UI v0.9.1. [16:16:47] marktraceur: I've not created it yet. [16:16:51] * marktraceur waits. [16:17:04] marktraceur: We do a cut after MediaWiki's wmfN is cut and deployed. [16:18:24] Gives us the maximum amount of time for it to be tested in beta [16:19:18] Makes sense to me, just need it to write my next patch [16:19:20] Well, rebase [16:19:42] (03PS5) 10Krinkle: TDG: Support optional text of 'deprecated' property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194748 (https://phabricator.wikimedia.org/T90734) (owner: 10Mooeypoo) [16:20:28] (03CR) 10Krinkle: "(rephrased since text is already allowed in the deprecated property, this adds supports to TDG, which explains why this commit doesn't upd" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194748 (https://phabricator.wikimedia.org/T90734) (owner: 10Mooeypoo) [16:23:03] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers: [Regression pre-wmf21] Tool bar does not stay in focus when a page scrolls down - https://phabricator.wikimedia.org/T92305#1109758 (10Etonkovidova) [16:24:45] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (4d7fda1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195919 (owner: 10Jforrester) [16:24:53] Thanks. [16:25:58] (03Abandoned) 10Jforrester: Update VE core to c0d60b6 for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/195580 (owner: 10Jforrester) [16:26:44] Ooh. https://en.wikipedia.org/w/index.php?oldid=650919447 is interesting. [16:27:22] (03Merged) 10jenkins-bot: Update VE core submodule to master (4d7fda1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195919 (owner: 10Jforrester) [16:35:35] James_F: Ooh cool [16:35:47] RoanKattouw: Isn't guillom awesome? [16:36:39] kirstenMA: testing [16:36:49] thanks [16:47:43] RoanKattouw, kirstenMA, edsanders: TrevorP|Away and I are going to miss the stand up, sorry. [16:48:04] Oh right, Q4 prios meeting [16:48:15] Fun times. :-) [16:48:22] I'm likely to miss it too [16:48:43] Tsk. [16:51:14] (03PS4) 10Kmenger: ActionSet: Add description for events and clarify method descriptions [oojs/ui] - 10https://gerrit.wikimedia.org/r/195489 [16:51:30] 10VisualEditor: Make the visual template editor drag-able & re-sizable to allow editing easy - https://phabricator.wikimedia.org/T92396#1109854 (1001tonythomas) p:5Triage>3Normal [16:51:42] 10OOjs-UI, 10VisualEditor: OOjs UI: Responsive VE toolbar - https://phabricator.wikimedia.org/T92315#1109859 (10Jdforrester-WMF) Isn't this just a dupe of {T52227}? [16:51:55] 10OOjs-UI: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow (responsive layout) - https://phabricator.wikimedia.org/T52227#1109861 (10Jdforrester-WMF) [16:58:51] 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): Hidden templates should display as an icon in-page in VisualEditor so they can be interacted with (e.g. a puzzle piece?) - https://phabricator.wikimedia.org/T51806#1109877 (10Etonkovidova)... [17:02:02] 10MediaWiki-Page-editing, 10MediaWiki-Interface: Wikitext editor no longer links to full help - https://phabricator.wikimedia.org/T92398#1109891 (10awight) 3NEW [17:08:28] (03PS6) 10Krinkle: TDG: Support optional text of 'deprecated' property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194748 (https://phabricator.wikimedia.org/T90734) (owner: 10Mooeypoo) [17:09:53] Krinkle|detached, what should $.unique(['a','b','a']) return? [17:10:03] >>> $.unique(['a','b','a']) [17:10:04] James_F: ReferenceError: $ is not defined [17:10:08] Meh. [17:10:15] edsanders: ecmabot-wm is your friend. [17:11:06] because in Chrome you get ['a','b'] and in FF you get ['a','b','a'] [17:14:25] edsanders: Oh dear. [17:16:51] (03PS1) 10Mvolz: Change string used by extension to identify itself [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/195954 [17:17:49] edsanders: Unique is only for DOM nodes, not arbitrary values [17:18:48] what the hell. "Use British English" doesn't display an icon now at all, not only that, but it doesn't seem to be rendered as a transclusionNode... parsoid sends us but the render() method isn't even popping up. I am so confused. Aren't still transclusions? [17:19:05] (03CR) 10Jforrester: [C: 032] Change string used by extension to identify itself [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/195954 (owner: 10Mvolz) [17:19:17] (03Merged) 10jenkins-bot: Change string used by extension to identify itself [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/195954 (owner: 10Mvolz) [17:19:28] oh... it's a transclusionMeta [17:19:32] (03CR) 10Jforrester: [C: 032] TDG: Support optional text of 'deprecated' property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194748 (https://phabricator.wikimedia.org/T90734) (owner: 10Mooeypoo) [17:19:35] crap [17:19:59] It uses Sizzle.uniqueSort [17:20:16] (03Merged) 10jenkins-bot: TDG: Support optional text of 'deprecated' property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194748 (https://phabricator.wikimedia.org/T90734) (owner: 10Mooeypoo) [17:20:18] (03PS1) 10Cmcmahon: [BrowserTest] update locator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195956 [17:20:55] James_F, so, I have no idea how this worked before (you and I both tested this!) but it seems {{Use British English}} is rendering as MWTransclusionItem which means it doesn't even trigger the whole "add an icon to empty transclusions" code path. [17:21:06] according to the docs it's only supposed to be used with DOM elements [17:21:13] mooeypoo: We were trying {{Use American English}}, I think. [17:21:24] mooeypoo: Do they differ? [17:21:31] James_F, no, I think it was Use British English, 'cause I imported it to my local wiki [17:21:35] but let me try that too [17:22:00] hm yeah I only have "Use British English" in my local wiki [17:22:01] (03CR) 10Krinkle: "Two issues:" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194748 (https://phabricator.wikimedia.org/T90734) (owner: 10Mooeypoo) [17:22:29] James_F: I was in the middle of reviewing that [17:22:43] O.O can we unmerge? [17:22:47] Hence I rebased it [17:22:52] And I mentioned it in the meeting you didn't attend :P [17:22:54] Krinkle: Yeah, sorry, the cut happened and expediency trumps minor language changes. [17:23:06] James_F: There's a UX bug. [17:23:12] Krinkle: Had you reviewed it on Monday when mooeypoo asked it'd have been fine. :-P [17:23:15] The field is disabled when the text is empty. [17:23:22] Yeah, I saw that. It's a bit meh. [17:23:27] Krinkle, isn't that what's supposed to happen though? [17:23:46] mooeypoo: Enable deprecated: the toggle goes from false to true. An optional text field appears. This is valid. [17:23:59] wait, okay, I get it, we should have deprecated: true without text [17:24:02] I'll fix that [17:24:04] mooeypoo: Type something, undo the typing. Now the entire switch gets disabled. [17:24:17] Krinkle, gotcha [17:24:57] Krinkle: "Guidance" was the word mooeypoo and I settled on in discussion, FWIW. [17:28:34] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1110096 (10Jdforrester-WMF) [17:29:48] (03PS2) 10Jforrester: [BrowserTest] Update locator for the Insert/More link changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195956 (owner: 10Cmcmahon) [17:29:52] (03CR) 10Jforrester: [C: 032] [BrowserTest] Update locator for the Insert/More link changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195956 (owner: 10Cmcmahon) [17:30:01] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-11_(1.25wmf21): The transition while switching between Readmode and VE is now not smooth, new content is inserted before the old content is removed leading to a flicker - https://phabricator.wikimedia.org/T91442#1110108 (10Ryasmeen) 5Resolved>3... [17:30:50] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-11_(1.25wmf21): The transition while switching between Readmode and VE is now not smooth, new content is inserted before the old content is removed leading to a flicker - https://phabricator.wikimedia.org/T91442#1084313 (10Ryasmeen) Still happenin... [17:30:58] (03PS1) 10Esanders: Replace $.unique with simpleArrayUnion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195959 [17:31:45] 10VisualEditor: [Regression wmf22] The lookup in citation dialog is throwing error not returning any result - https://phabricator.wikimedia.org/T92412#1110125 (10Ryasmeen) [17:32:30] (03PS1) 10Mooeypoo: Followup to Iadc6abdcc: Allow for empty text in deprecated property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195960 [17:32:30] ryasmeen: wmf22? wmf21 is barely branched. :-) Do you mean wmf21 or pre-wmf22? [17:32:32] Krinkle, ^^ [17:33:26] James_F: Err..should be wmf21 [17:33:41] ryasmeen: OK. [17:33:50] (03CR) 10jenkins-bot: [V: 04-1] Followup to Iadc6abdcc: Allow for empty text in deprecated property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195960 (owner: 10Mooeypoo) [17:33:55] 10VisualEditor: [Regression wmf21] The lookup in citation dialog is throwing error not returning any result - https://phabricator.wikimedia.org/T92412#1110131 (10Jdforrester-WMF) [17:34:01] meh [17:34:24] (03Merged) 10jenkins-bot: [BrowserTest] Update locator for the Insert/More link changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195956 (owner: 10Cmcmahon) [17:35:17] okay that didn't work. damnit [17:35:40] (03PS2) 10Catrope: Replace $.unique with simpleArrayUnion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195959 (owner: 10Esanders) [17:36:52] (03CR) 10Catrope: [C: 032] Replace $.unique with simpleArrayUnion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195959 (owner: 10Esanders) [17:39:15] (03Merged) 10jenkins-bot: Replace $.unique with simpleArrayUnion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195959 (owner: 10Esanders) [17:41:24] (03PS1) 10Jforrester: Update VE core submodule to master (e9e39f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195963 [17:41:52] ori: marktraceur tells me in SoS that https://phabricator.wikimedia.org/T89088 is blocked on you [17:42:18] RoanKattouw: i'll unblock, need to poke bblack about it [17:42:23] (03PS8) 10Jforrester: Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [17:43:13] Thanks ori, RoanKattouw [17:43:33] (03CR) 10Jforrester: "PS8 is a rebase onto a pull-through of Ed's fix." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [17:43:44] Krinkle: Did you email or otherwise contact rmoen about https://github.com/wikimedia/jquery-client/pull/1 ? [17:43:48] He's the only hold-out [17:43:51] I did [17:44:05] RoanKattouw: what do i need to do ? [17:44:14] rmoen: Sign :) [17:44:29] rmoen: Say "yes" on GitHub. [17:45:00] (03CR) 10Jforrester: [C: 032] Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [17:45:23] Its not obvious which is why I'm asking [17:45:34] lol, i've never done this [17:45:48] edsanders: +2 on https://gerrit.wikimedia.org/r/#/c/195963/ appreciated. [17:45:52] rmoen: One second. [17:46:13] rmoen: Comment on https://github.com/wikimedia/jquery-client/pull/1 [17:46:49] James_F: done [17:46:55] rmoen: Thanks! [17:47:05] Thanks Krinkle. [17:49:47] (03PS2) 10Mooeypoo: Followup to Iadc6abdcc: Allow for empty text in deprecated property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195960 [17:50:53] (03CR) 10Jforrester: [C: 031] "Well, it works…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195582 (owner: 10Krinkle) [17:51:54] RoanKattouw, edsanders: Did we reach a consensus/action plan on https://gerrit.wikimedia.org/r/#/c/195228/ vs. https://gerrit.wikimedia.org/r/#/c/195236/ or are we still not engaging? :-) [17:54:16] 10VisualEditor, 10Citoid: [Regression wmf21] The lookup in citation dialog is throwing error not returning any result - https://phabricator.wikimedia.org/T92412#1110229 (10Jdforrester-WMF) [17:55:12] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-LabeledSectionTransclusion, 5Patch-For-Review: Create a VisualEditor plugin tool to add/edit LabelledSectionTransclusion markers - https://phabricator.wikimedia.org/T72581#1110235 (10marcoil) [17:56:32] 10VisualEditor, 10Citoid: [Regression wmf21] The lookup in citation dialog is throwing error not returning any result - https://phabricator.wikimedia.org/T92412#1110238 (10Mvolz) 5Open>3Resolved [17:57:06] 10VisualEditor, 10Citoid: [Regression wmf21] The lookup in citation dialog is throwing error not returning any result - https://phabricator.wikimedia.org/T92412#1110087 (10Mvolz) A problem with the labs machine, fixed. [17:58:12] 10VisualEditor, 10Citoid: [Regression wmf21] The lookup in citation dialog is throwing error not returning any result - https://phabricator.wikimedia.org/T92412#1110244 (10Jdforrester-WMF) That was quick. :-) [17:59:30] 10VisualEditor, 10Citoid: [Regression wmf21] The lookup in citation dialog is throwing error not returning any result - https://phabricator.wikimedia.org/T92412#1110250 (10Mvolz) Noticed it myself before you added the citoid project and it showed up in my email :D. [18:03:12] 10OOjs-UI, 10VisualEditor: VisualEditor's and OOjs UI's toolbars are conceptually incompatible - https://phabricator.wikimedia.org/T92282#1110266 (10Aklapper) Is this #Technical-Debt ? If so feel free to associate that project. [18:05:55] James_F, we're holding off for now, the bug it was causing has been hacked around [18:10:40] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Insert/Media inspector should appear with focus on input box and default text pre-selected - https://phabricator.wikimedia.org/T88021#1110305 (10Cmcmahon) Just updating to note that fixing this should turn the browser test builds back to green. [18:11:49] ryasmeen James_F I just noticed that https://phabricator.wikimedia.org/T88021 hasn't seen any action since January, thought I would follow up on that. [18:16:21] edsanders, James_F: MY impression of the situation is that Trevor has proposed a different solution that requires more work but nobody (at least not me) has the will and/or time to implement it right now [18:17:47] This is frustrating. {{Use British English}} is now identified as MWTransclusionMetaItem [18:18:01] Which means it completely skips the "should we display it with an icon" stage [18:18:04] aaaa. [18:18:52] mooeypoo: Now that we have the icon thing we could get rid of transclusion meta items [18:19:39] mooeypoo: You can test this by sabotaging the first if statement in ve.dm.MWTransclusionNode.static.toDataElement with false && [18:19:49] RoanKattouw, I was thinking about that, but then we'll also have Categories displayed, no? [18:21:26] What do you mean by "categories displayed"? [18:21:37] RoanKattouw, what type of transclusions ever are set as Meta items? [18:21:47] If we have a category in the middle of the text, is that meta? [18:22:51] or anything else I may not consider. I'm worried of getting rid of the transclusion meta item completely [18:24:04] if ( converter.isDomAllMetaOrWhitespace( domElements, ['mwTransclusion', 'mwTransclusionInline', 'mwTransclusionBlock'] ) ) { [18:24:08] getting parsoidserver-http: HTTP 0 on VE, anyone want to tell me what I missed recently before I go investigating myself? :D [18:24:18] So that checks that the only thing in there is meta items or whitespace [18:24:22] * mvolz has not been doing many ve things lately [18:24:27] mvolz: I think that means Parsoid isn't running at all [18:24:41] Or nothing is listening on the port VE is trying to talk to, or whatever [18:24:43] I think that's what HTTP 0 means [18:24:59] RoanKattouw: thanks [18:25:34] mooeypoo: So basically what that line of code does is invoke the converter on domElements again, but this time pretending it doesn't know about mwTransclusion*, and checking whether the result is only meta items and whitespace [18:30:26] (03PS1) 10Esanders: Provide oo.unique for remove duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 [18:31:08] edsanders: shouldn't that be 'o.unique', then? :P [18:31:23] ori: :-D [18:31:36] if you put oo into oo you break the internet [18:33:53] edsanders: +2 https://gerrit.wikimedia.org/r/#/c/195963/ ? [18:34:12] (03PS2) 10Esanders: Provide oo.unique for remove duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 [18:34:41] ori, happy? https://gerrit.wikimedia.org/r/#/c/195971/1..2/tests/unit/core.test.js [18:34:51] edsanders: :-) [18:34:58] haha [18:35:13] mooeypoo: So in English, what that means is that a transclusion is a meta item only if everything that it contains is meta-like (like categories), or whitespace [18:35:13] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (e9e39f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195963 (owner: 10Jforrester) [18:35:19] Ta. [18:35:23] mooeypoo: A transclusion that contains both "real" content and a category won't be a meta ite [18:35:37] IIRC transclusion meta items were introduced because of the problem that you're solving with the icon thing [18:35:47] i.e. transclusions producing empty or meta-only results [18:36:43] mooeypoo: Actually now that I think about it... what kinds of transclusions were you writing this for in the first place? Things that produce
or something? Because there can't be that many cases of transclusions that produce empty-ish results but weren't already being meta-d [18:36:46] edsanders: http://stackoverflow.com/a/14438954/582542 is a bit more elegant, imo.. but that's nitpicky [18:37:02] mooeypoo: Unless I'm missing something, which I probably am, and I'd like you to tell me what that is :) [18:37:26] (03Merged) 10jenkins-bot: Update VE core submodule to master (e9e39f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195963 (owner: 10Jforrester) [18:37:32] (03Merged) 10jenkins-bot: Test for class attribute duplication bug [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191037 (https://phabricator.wikimedia.org/T88148) (owner: 10Esanders) [18:37:33] ori, http://jsperf.com/array-unique-es [18:37:52] ori: In theory Ed's version should be twice as fast [18:38:20] Also wow it's very disappointing to see that Set is that slow [18:39:05] edsanders: ah, clever! yeah, that makes sense, since the target array is shorter. [18:39:19] (or at most equally as long, in the very final element) [18:39:36] This is how you can tell I'm a recent graduate [18:39:39] :P [18:39:55] I was like "why is he using redu... oooh" [18:40:26] (03CR) 10Krinkle: "Yay!" (033 comments) [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders) [18:43:53] * Krinkle sees his version of chrome is 0.001 version lower than the one in that jsperf run and realises that must be Ori using Chromium [18:44:09] (whereas I use canary, which is built after chromium) [18:44:31] haha, that testifies to the EFF's point about user agents / privacy / entropy [18:45:43] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-References: [Regression wmf-20]- Internal links, when clicked in a Reference context menu does nothing. - https://phabricator.wikimedia.org/T92427#1110468 (10Swainr) 3NEW [18:46:02] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-References: [Regression wmf-20]- Internal links, when clicked in a Reference context menu does nothing. - https://phabricator.wikimedia.org/T92427#1110475 (10Catrope) a:3TrevorParscal [18:46:16] Is that intentional? [18:46:27] It might be [18:46:31] But TrevorP|Away would know [18:47:49] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-References: [Regression wmf-20]- Internal links, when clicked in a Reference context menu does nothing. - https://phabricator.wikimedia.org/T92427#1110477 (10Swainr) Screeshot {F82700} [18:47:52] ori: for some reason Set is quite considerably faster in Safari [18:50:57] 10VisualEditor, 10VisualEditor-MediaWiki-References: [Regression pre-wmf21]Delete the last character after any citation and the cursor jumps to the right side of the reference editor. - https://phabricator.wikimedia.org/T92292#1110488 (10Swainr) [18:51:22] safari is a turd [18:51:35] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] ve.utils: Remove ve.indexOf in favour of Array#indexOf [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195582 (owner: 10Krinkle) [18:51:36] 10OOjs-UI, 10UI-Standardization, 7Design: Implement frameless popupButtonWidget - https://phabricator.wikimedia.org/T91857#1110503 (10Jaredzimmerman-WMF) p:5Triage>3High [18:51:50] ori: Did you know... [18:51:55] 10OOjs-UI, 10Living-Style-Guide, 10UI-Standardization, 7Design: Add warning button styles to buttons - https://phabricator.wikimedia.org/T92026#1110504 (10Jaredzimmerman-WMF) p:5Triage>3High [18:52:49] ori: That var a = new Array( N ); a.splice( K, 0, 'x' ); a.splice( 0, 1 ); return a.indexOf( 'x' ); , which should return K-1, will return K in Safari, but only if N>=10^5 and K>=8 ? [18:53:26] amazing [18:53:48] Because the second splice call removes an undefined from the end instead of at the requested offset [18:53:55] (03Merged) 10jenkins-bot: [BREAKING CHANGE] ve.utils: Remove ve.indexOf in favour of Array#indexOf [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195582 (owner: 10Krinkle) [18:54:13] But only for sparse arrays of length at least 100k, and only if the first 8 elements are undefined apparently [18:54:26] That one was fun to find [18:57:27] and only on wednesdays [18:57:30] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: Entering a single '-' character in a table results in a new row - https://phabricator.wikimedia.org/T88318#1110534 (10Jdforrester-WMF) 5Open>3Resolved [19:04:10] 10VisualEditor, 10VisualEditor-EditingTools, 3VisualEditor 2014/15 Q3 blockers: VisualEditor: Be able to name references manually in the reference dialog - https://phabricator.wikimedia.org/T52568#1110556 (10Whatamidoing-WMF) [19:04:13] 10VisualEditor: Make the visual template editor drag-able & re-sizable to allow editing easy - https://phabricator.wikimedia.org/T92396#1110557 (10Aklapper) @01tonythomas: Do you plan to work on this or talk to the VE maintainers, or what was the reason to set this to "Normal" priority? [19:04:43] RoanKattouw, sorry, I ran out with trevor to get food before his meeting. The template "{{Use British English}}" was the first cause of this, and it *worked* yesterday, though now it doesn't. I'm not sure if anything got changed recently on the parsoid side, but it produces a tag now which isn't caught on the code path that I worked on [19:06:58] So what did it produce before? [19:07:40] I am not sure [19:08:17] But it was an MWTransclusionNode [19:09:37] ok I'm going upstairs instead of taking up room in that hangout. [19:11:18] [13jquery-client] 15Krinkle 04force-pushed 06testing from 1491ddd19 to 145356a5f: 02https://github.com/wikimedia/jquery-client/commits/testing [19:11:18] 13jquery-client/06testing 145356a5f 15Timo Tijhof: Bootstrap repo with JSHint, JSCS, Karma, and JSDuck [19:12:07] it's funny how what is very normal in gerrit (amending pending commits in topic branches) is actually quite bad practice in the normal world and marked red by github :P [19:13:52] (03PS3) 10Esanders: core: Provide oo.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 [19:16:22] (03PS2) 10Alex Monk: Handle undoing of reference group changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195901 (https://phabricator.wikimedia.org/T71119) [19:23:23] (03PS2) 10Bartosz Dziewoński: demo: Load styles before building demo widgets (not asynchronously) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 [19:27:11] (03CR) 10Bartosz Dziewoński: demo: Load styles before building demo widgets (not asynchronously) (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [19:28:48] (03PS3) 10Bartosz Dziewoński: demo: Load styles before building demo widgets (not asynchronously) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 [19:29:47] 10VisualEditor, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q3 blockers: Come up with a better way to auto-label references - https://phabricator.wikimedia.org/T92432#1110610 (10Jdforrester-WMF) 3NEW [19:46:11] [13jquery-client] 15Krinkle 04force-pushed 06testing from 145356a5f to 149df70db: 02https://github.com/wikimedia/jquery-client/commits/testing [19:46:11] 13jquery-client/06testing 149df70db 15Timo Tijhof: Bootstrap repo with JSHint, JSCS, Karma, and JSDuck [20:00:40] (03PS1) 10Bartosz Dziewoński: ActionWidget: Fix bad copy-paste in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/195997 [20:06:59] (03CR) 10Jforrester: [C: 032] ActionWidget: Fix bad copy-paste in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/195997 (owner: 10Bartosz Dziewoński) [20:07:46] (03CR) 10Jforrester: [C: 032] ActionSet: Add description for events and clarify method descriptions [oojs/ui] - 10https://gerrit.wikimedia.org/r/195489 (owner: 10Kmenger) [20:08:59] (03CR) 10Jforrester: [C: 031] demo: Load styles before building demo widgets (not asynchronously) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [20:09:08] (03Merged) 10jenkins-bot: ActionWidget: Fix bad copy-paste in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/195997 (owner: 10Bartosz Dziewoński) [20:10:03] TrevorP|Away: https://gerrit.wikimedia.org/r/#/c/183474/ [20:10:05] (03Merged) 10jenkins-bot: ActionSet: Add description for events and clarify method descriptions [oojs/ui] - 10https://gerrit.wikimedia.org/r/195489 (owner: 10Kmenger) [20:15:47] ryasmeen: BTW, how's the changelog going? [20:16:43] Krinkle: Do you want me to make the MW-core patch pulling in jQuery.client as a library? [20:16:50] Krinkle: Or are you already doing? [20:16:50] James_F: Not yet [20:16:59] What's left to do? [20:17:12] Adding header and actually releasing to npm. I"m fixing the tests now [20:17:17] * James_F nods. [20:17:21] And a release number. :-) [20:17:23] 1.0.0? [20:17:33] Yeah [20:17:38] I'll be back in a few hours [20:17:39] It's been v0.1.0 forever. [20:17:41] OK. [20:17:48] Ping me when you want it. [20:18:02] * James_F was assuming he'd create another maintenance/resources/update-*.sh script. [20:18:42] James_F:Just about to send you :) [20:18:49] (03CR) 10Trevor Parscal: [C: 032] Button styles between OOJS and MW [oojs/ui] - 10https://gerrit.wikimedia.org/r/194753 (https://phabricator.wikimedia.org/T88449) (owner: 10Nirzar) [20:18:54] ryasmeen: Awesome. [20:21:00] (03Merged) 10jenkins-bot: Button styles between OOJS and MW [oojs/ui] - 10https://gerrit.wikimedia.org/r/194753 (https://phabricator.wikimedia.org/T88449) (owner: 10Nirzar) [20:27:39] (03PS7) 10Catrope: [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) [20:27:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope) [20:28:11] RoanKattouw: Gerrit just doesn't love you. [20:29:24] 10OOjs-UI, 7Technical-Debt: OOUI's GroupWidget and ItemWidget must die - https://phabricator.wikimedia.org/T91565#1110857 (10matmarex) There's an #updateDisabled method on Widget which is also part of this mess. [20:31:36] (03CR) 10Trevor Parscal: [C: 032] demo: Load styles before building demo widgets (not asynchronously) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [20:33:39] (03Merged) 10jenkins-bot: demo: Load styles before building demo widgets (not asynchronously) [oojs/ui] - 10https://gerrit.wikimedia.org/r/194385 (owner: 10Bartosz Dziewoński) [20:38:07] 10OOjs-UI: Icon-only framed buttons are asymmetrical - https://phabricator.wikimedia.org/T91523#1110902 (10matmarex) Way worse now in MediaWiki theme after https://gerrit.wikimedia.org/r/#/c/194753/ was merged. {F82975} [20:40:12] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 5Patch-For-Review: Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of undefined" - https://phabricator.wikimedia.org/T71119#1110907 (10Krenair) a:5Esanders>3Krenair [20:40:37] RoanKattouw, okay, can I drag you back to talking about transclusion metas? I understand you're suggesting we get rid of all transclusion metaItems -- I didn't know enough about what these COULD be to say if that's disastrous, James_F says it shiould be fine. Should I just do it? I can remove the condition you talked about earlier, that'll do it. [20:40:43] (03CR) 10Bartosz Dziewoński: "FIXME:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/194753 (https://phabricator.wikimedia.org/T88449) (owner: 10Nirzar) [20:42:21] 10VisualEditor, 10VisualEditor-DataModel: Don't wrap text in paragraphs when avoidable (especially inside
  • , ) - https://phabricator.wikimedia.org/T92441#1110914 (10Catrope) 3NEW [20:42:45] 10VisualEditor, 10VisualEditor-DataModel: Don't wrap text in paragraphs when avoidable (especially inside
  • , ) - https://phabricator.wikimedia.org/T92441#1110927 (10Catrope) [20:44:50] RoanKattouw, I also have a question for you regarding loading Citoid tool (or another script inside the extension itself) before "ve.init.mw.Target.prototype.generateCitationFeatures" is loaded, when you have a moment. [20:45:32] mooeypoo: Shoot [20:47:00] ok, I need to pre-emptively change the toolbar buttons from "Cite" menu to be a button for citoid + a menu for the others. *BUT* I need to *only* do that if Citoid is loaded. I was thinking of taking the toolbarGroups static property and, somewhere after Citoid extension is loaded but before the toolbar is setup manipulate the object to change those buttons conditionally [20:47:11] preferably, this conditional manipulation should be in the Citoid extension [20:47:21] because we don't want ve-mw to check whether citoid extension exists [20:47:53] so I looked at ve.init.mw.Target.prototype.generateCitationFeatures and that method loads *before* the citoid tool is loaded [20:48:40] so I'm looking for either a parser hook or something similar to load just before the toolbar setup so I can change the static.toolbarGroups object from the Citoid extension... does something like this exist? [20:48:53] Hmmm [20:49:03] This is a case where I really want access to TrevorP|Away's brain [20:49:06] How |Away is he in real life? [20:49:11] TrevorP|Away asked to ask you [20:49:24] haha [20:49:26] Thanks Trevor :P [20:49:27] and he says he'll join here in a second [20:49:39] RoanKattouw, well, he suggested that I should work within generateCitationFeatures [20:49:43] OK let me get back to you in a second here, this meeting is just ending [20:49:46] but told me I should check the timing first [20:49:55] so., I did, and it loads too early :\ [20:50:13] RoanKattouw: howdy [20:50:25] there's gotta be another place where I can do this... [20:52:09] So [20:52:56] Why is there such a gap between what the Citoid and Citoid-less UIs look like? [20:53:01] Can we shrink that gap? [20:53:09] And in doing so make this problem a lot easier? [20:53:16] uhm [20:53:38] Well, the gap isn't too big -- without citoid, we have a dropdown "Cite" menu [20:53:55] Like, in the new design there's a single tool that launches an inspector that optionally launches a dialog where you can choose between types, and in the old design those types are tools directly [20:54:00] with Citoid, we have a "Cite" button that is Citoid inspector, and next to it a dropdown menu that is the current drop down [20:54:07] but they're also both a group button [20:54:12] Oh I see [20:54:14] what MatmaRex worked on last week [20:54:23] so it involves redoing the toolGroup object [20:54:24] So you're not relocating any tools, you're just adding one in a very specific place? [20:54:32] changing, really [20:54:32] And changing the type of the toolgroup? [20:54:35] ve.ui.MWAdvancedSettingsPage.prototype.onEnableDisplayTitleCheckboxChange is weird [20:54:42] if I could splice the toolGroup and add in, that'll solve the issue [20:54:49] i need to do that *BEFORE* the toolbar is setup [20:54:54] if it was set to not selected... setSelected( false ) ? [20:56:36] RoanKattouw, in ve.init.Target there's setupToolbar() [20:56:37] you can always re-setup the toolbar. [20:56:42] hopefully. [20:56:45] (brb) [20:56:54] ... how? [20:57:09] get the ve.ui.Toolbar and call #setup on it with the right parameters [20:57:22] wait, really? [20:57:31] but... that would also mean we'll be setting up the toolbar twice [20:57:38] which sounds like it's not that good for performance [20:57:38] OK, so hold on [20:57:59] It sounds like all you need to do is modify the toolbar description object before it's used to set up the toolbar [20:58:09] You just need that, and you don't need anything fancy [20:58:10] Is that right? [20:58:14] Because that's a more general problem [20:58:26] I was thinking, if I can extend and use ve.init.Target#setupToolbar() just before this.getToolbar().setup( this.constructor.static.toolbarGroups, surface ); I can manipulate the toolGroups object [20:58:36] RoanKattouw, yes [20:58:51] the problem is doing it from *outside* VE [20:58:58] otherwise I could just extend that above method from ve-mw [20:58:59] Both in that it affects many (but not all) other extensions who want to add to the toolbar, and in that generateCitationFeatures() is irrelevant [20:59:09] Yeah, so it's a toolbar extensibility issue [20:59:23] and then manipulate whatever and send to setup() but that will only work if I ask VE to check if Citoid exists [20:59:27] Determining that generateCitationFeatures() has (almost) nothing to do with it makes it sound a lot less scary [20:59:29] which can be done as a hack, but shouldn't [20:59:39] Now we're just talking about a toolbar extension API really [20:59:40] RoanKattouw, yeah, you're right [20:59:40] Right? [20:59:44] yes [20:59:44] OK, so [20:59:53] but rearranging the toolbar, so not just adding a button or a group [20:59:53] At this point, I request that TrevorParscal rejoin the fray [21:00:09] ok, i have a meeting now though [21:00:17] Right [21:00:26] ah. We can postpone this, then [21:00:48] unless you have an idea of some hook for me to use, RoanKattouw ? [21:02:57] No, I don't think anything like that exists [21:03:08] The bad news is that this has been an open problem for a long time [21:03:26] hello,i have installed the visualeditor and linked it with parsoid but when i try to edit the page in localhost,the dialog popup with error loading data from server:500 [21:03:28] The good news is that this is the exact problem we have known needed to be solved for a long time [21:03:50] yeah Trevor said something about having to rewrite the toolbar, but this, according to James_F, is urgent, so we can't wait for such rewrite. [21:03:54] I am trying to find a hack [21:04:17] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 5Patch-For-Review: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox - https://phabricator.wikimedia.org/T78733#1111069 (10dduvall) Some controlled tests verify that NFS + stat is a part of this performance issue, but maybe not the whole problem. Fi... [21:04:38] RoanKattouw: mooeypoo: yeah, the toolbar is not very configurable [21:05:07] mooeypoo: Oh now that you said "I need a hack", I think I might have one [21:05:13] Are you familiar with our plugin system? [21:05:19] more or less [21:05:29] OK so you know you can do $wgPluginModules[] = 'blah'; [21:05:33] you register a plugin module [21:05:34] yeah [21:05:36] (but i'm fairly sure we could mostly achieve what you want with the limited API we have) [21:05:43] And you can also do mw.libs.ve.addPlugin( 'blah' ); [21:05:50] from JS, e.g. if you're a Gadget [21:05:54] ooh okay [21:06:02] But you can ALSO do mw.libs.ve.addPlugin( function() { .... } ); [21:06:15] okay [21:06:25] And that function will be executed after all modules (including plugin modules) have loaded but before the target is constructed [21:06:38] ooooooo [21:06:40] So in that function, you can modify ve.init.mw.ViewPageTarget.toolbarBlahBlah [21:06:50] Which is a hack, but that's what you asked for [21:06:52] ok hang on [21:07:02] right now, Citoid uses the plugin system in the php file [21:07:06] $wgVisualEditorPluginModules[] = 'ext.citoid.visualEditor'; [21:07:23] Yeah [21:07:35] So the question there is, is calling addPlugin() from within a plugin module supported [21:07:53] right, since the toolbar thing will be a subset of the citoid module, I assume [21:07:58] The answer is "not explicitly, but from reading the code I deduce that in practice it probably does work" [21:08:05] hello,i have installed the visualeditor and linked it with parsoid but when i try to edit the page in localhost,the dialog popup with error loading data from server:500 [21:08:07] or should we load the entire citoid module like that [21:08:10] No no [21:08:24] addPlugin() from within a plugin will be fine [21:08:42] but when do I do that to be BEFORE the setup ? [21:08:51] this is a question of timing [21:08:54] mooeypoo: In the top scope of your module [21:09:09] Oh also, at that point I suppose it's easier [21:09:29] Your module can just depend on ext.visualEditor.viewPageTarget, and modify ve.init.mw.ViewPageTarget.static.whatever from the top scope [21:09:31] No addPlugin() needed [21:09:57] rits: Hmm that probably means Parsoid threw an error [21:10:11] rits: Do you see any error messages in Parsoid's log or in the shell where you are running Parsoid? [21:10:15] RoanKattouw, hmmm [21:11:27] rits: Or, for that matter, do you see any errors in Apache's error log? I just realized it's probably not a Parsoid error but an error from Apache/PHP/MediaWiki [21:12:17] no there was no error their in the shell i didnt see in the apache log [21:14:14] mooeypoo: Do you understand what I mean by "top scope"? [21:14:22] RoanKattouw, yeah I think so [21:14:34] (03CR) 10Esanders: core: Provide oo.unique for removing duplicates from arrays (033 comments) [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders) [21:15:02] I have the ve.ui.CiteFromIdInspectorTool.js that lods first; it also has a test in there to check if there's any citoid map json message to load (otherwise it returns before constructing the tool) [21:15:10] that should be a place to add the toolbar manipulation [21:15:15] it's just crappy [21:15:39] Yeah, I never said it wasn't a hack :P [21:15:43] hehe [21:16:02] MatmaRex, so, uhm, how do I do the grouping of two buttons? You made this for the standalone, I think, with textStyle [21:16:20] is that in the tool definition or in the toolbarGroups [21:16:22] rits, what is the response from the API as shown in your browser's network tab? [21:17:52] mooeypoo: it's a big mess, best to look at the commit where i did it: https://gerrit.wikimedia.org/r/#/c/194526/ [21:17:58] (also, a followup: https://gerrit.wikimedia.org/r/#/c/195606/) [21:18:12] this was the response in the network tab code: "500" info: "parsoidserver-http: HTTP 500" [21:18:16] what's one more mess within this mess... [21:18:20] Oh, aha [21:18:23] So it is a Parsoid error [21:19:52] what should i do? [21:20:01] (two followups, in fact, also https://gerrit.wikimedia.org/r/194757) [21:20:54] rits: Parsoid should have logged something somewhere [21:21:01] in theory [21:22:49] sorry i didnt understand? what should i do then ? [21:23:33] 10OOjs-UI: "Search Widget Dialog" in demos acts broken when you try to use it. - https://phabricator.wikimedia.org/T92448#1111119 (10KMenger) 3NEW [21:29:13] 10VisualEditor, 6Collaboration-Team, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25: Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1111141 (10EBernhardson) [21:29:21] 10OOjs-UI: Various widgets refuse to tab to other widgets - https://phabricator.wikimedia.org/T92449#1111143 (10Anomie) 3NEW [21:29:24] 10VisualEditor, 6Collaboration-Team, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 3Roadmap: Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1111150 (10EBernhardson) [21:30:20] rits: Well there should be an error either in the shell where Parsoid is running, or in a log file [21:30:31] I don't know exactly where Parsoid logs to and that might depend on how you installed it [21:30:44] The people over in #mediawiki-parsoid might be able to help you with that, if you can't find the error message [21:31:08] My (blind) guess is that you probably didn't configure Parsoid correctly, specifically the part where you point it to your api.php URL [21:32:44] yup i pointed to "http://localhost/w/api.php" but it did not worked then also its the same error [21:35:00] 10VisualEditor: Context 1px too short causing scroll bar to render - https://phabricator.wikimedia.org/T92450#1111166 (10Esanders) 3NEW a:3TrevorParscal [21:35:29] rits: If you click Edit source, what is the URL that ends up in your address bar? [21:35:39] Probably something with index.php?action=edit in it [21:36:37] veaction=edit this comes [21:37:09] rits: I mean the link that takes you to the old editor. "Edit source", not "Edit" [21:37:39] oh this is the one title=Main_Page&action=edit [21:38:39] Yeah [21:38:43] What's the full URL there? [21:39:14] http://localhost/core/index.php?title=Main_Page&action=edit [21:39:19] OK [21:39:27] Then point Parsoid to http://localhost/core/api.php [21:39:35] (Also visit that URL in your browser and check you get a help page back) [21:39:55] 10VisualEditor: Context 1px too short causing scroll bar to render - https://phabricator.wikimedia.org/T92450#1111189 (10Jdforrester-WMF) Rounding issue? [21:40:00] Once you've edited the Parsoid config, restart Parsoid (kill it, then start it again), and then try opening VE again [21:40:10] * mooeypoo does the toolbar dance [21:40:55] ok thank you i will report back :) [21:42:34] 10TemplateData, 5WMF-deploy-2015-03-11_(1.25wmf21): TemplateData GUI needs to let users set a string as the (secondary) value for 'deprecated' (as a description), not just boolean - https://phabricator.wikimedia.org/T90734#1111210 (10Jdforrester-WMF) 5Open>3Resolved [21:42:42] (03PS1) 10Kmenger: Window: Clarify descriptions of methods and configs [oojs/ui] - 10https://gerrit.wikimedia.org/r/196074 [21:42:53] ryasmeen: Oh, we should add https://phabricator.wikimedia.org/T90734 to the change log, sorry, I forgot to mention it. [21:43:49] (03CR) 10Jforrester: [C: 032] Window: Clarify descriptions of methods and configs [oojs/ui] - 10https://gerrit.wikimedia.org/r/196074 (owner: 10Kmenger) [21:44:22] 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1111223 (10DannyH) [21:44:39] 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25: S7. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1111225 (10DannyH) [21:45:53] (03Merged) 10jenkins-bot: Window: Clarify descriptions of methods and configs [oojs/ui] - 10https://gerrit.wikimedia.org/r/196074 (owner: 10Kmenger) [21:46:05] 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1066843 (10DannyH) [21:46:19] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers: [Regression pre-wmf21] Tool bar does not stay in focus when a page scrolls down - https://phabricator.wikimedia.org/T92305#1111244 (10Etonkovidova) Re-checked on FF, Chrome, and Safari - the issue is resolved. [21:49:16] 10OOjs-UI: MenuOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos - https://phabricator.wikimedia.org/T92452#1111263 (10KMenger) 3NEW [21:58:35] [13jquery-client] 15Krinkle 04force-pushed 06testing from 149df70db to 1452bfaca: 02https://github.com/wikimedia/jquery-client/commits/testing [21:58:35] 13jquery-client/06testing 1452bfaca 15Timo Tijhof: Bootstrap repo with JSHint, JSCS, Karma, and JSDuck [22:00:34] (03PS1) 10Mooeypoo: Add a tool group to VE toolbar with Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 [22:00:44] 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-R-2015-03-11, 5Patch-For-Review: Sometimes VE toolbar gets stuck in upper left until reflow/resize window - https://phabricator.wikimedia.org/T90762#1111326 (10DannyH) 5Open>3Resolved [22:00:57] RoanKattouw, TrevorP|Away https://gerrit.wikimedia.org/r/196077 [22:01:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10Flow, 3Collaboration-Team-Sprint-R-2015-03-11, 5Patch-For-Review: R1. Spike: Add relevant MW features to VE on Flow - https://phabricator.wikimedia.org/T90760#1111327 (10DannyH) 5Open>3Resolved [22:01:22] 10VisualEditor, 10Flow, 10LiquidThreads, 3Collaboration-Team-Sprint-R-2015-03-11: R6. LQT conversion test for Mediawiki.org VE/Feedback - https://phabricator.wikimedia.org/T90025#1111331 (10DannyH) 5Open>3Resolved [22:01:57] mooeypoo: You should ask James_F about what the best course of action is for those i18n messages, since they change pretty dramatically [22:02:10] RoanKattouw, he was right next ot me when we changed them [22:02:16] they changed per his request [22:02:40] :-) [22:02:51] We can always fix it in post. [22:03:07] 10VisualEditor: Comment body in context showing a scrollbar - https://phabricator.wikimedia.org/T92450#1111340 (10Esanders) [22:03:58] RoanKattouw: it worked thank you :) [22:04:01] OK [22:04:21] mooeypoo: So what's up with the whole thing where you copy the toolbar object and return a copy? [22:04:24] Can't it be modified in place? [22:04:40] RoanKattouw, yes, that's actually a habit. I didn't think about that [22:04:52] I don't feel strongly either way, and I will defer to Krinkle|detached on what's better [22:05:06] I can just return the same object too [22:05:08] But I just wanted to point out that you don't "really" need to copy and replace [22:05:15] yeah [22:05:20] Well or you could just search in the object and modify it directly [22:05:38] RoanKattouw, yeah i don't have to copy. I'm searching the copy now, and i don't have to, really [22:05:51] RoanKattouw, you like my downgrade-from-horrible-to-less-horrible comment? [22:07:17] (03CR) 10Catrope: [C: 04-1] Add a tool group to VE toolbar with Citoid (032 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 (owner: 10Mooeypoo) [22:07:23] 10VisualEditor: Comment body in context showing a scrollbar - https://phabricator.wikimedia.org/T92450#1111348 (10Esanders) Apparently not [22:07:27] apparently not... [22:07:29] mooeypoo: Yes, I like that strategy [22:08:30] I was slightly worried that it is again going over an object, but I think those things are cheap in performance, no? [22:09:05] Yeah it's fine [22:09:24] Oh ahm [22:09:29] What is not fine is you're using a for ... in loop [22:09:37] The values of tool there are integers, right? [22:09:40] (03PS1) 10Mooeypoo: Clean up unnecessary hack for Citoid tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196079 [22:09:48] RoanKattouw, yeah [22:09:51] You should use a for ( i = 0; ... ) loop instead [22:09:58] i wasn't aware there's a performance issue with either [22:10:01] i thought it's a matter of convenience [22:10:03] when iterating over plain arrays [22:10:21] Not because of performance issues but because of dirty prototype issues [22:10:28] (and also because of code style) [22:10:29] ohhh [22:10:38] (03PS12) 10Trevor Parscal: MediaWiki Theme: Add "Wikicon" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [22:10:40] (03CR) 10jenkins-bot: [V: 04-1] MediaWiki Theme: Add "Wikicon" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [22:10:47] that makes sense (prototype, but also code style) [22:10:48] MatmaRex: that icon commit still has issues with RTL [22:10:54] any ideas? [22:11:02] what issues? [22:11:28] only the "icons" and "indicators" groups seem to work correctly, other groups have some but not all icons coming through [22:11:50] it looks like it's actually a problem of them not being copied or generated when there are ltr or rtl versions of the graphics [22:12:11] just download the patch, build, view the demo in RTL, scroll down, you will see lots of missing icons [22:12:22] mooeypoo: Because if some id^H^H^Hone does Array.prototype.foo = function () { ... }; then that for in loop will pick up 'foo' as a key in every array :S [22:12:22] the CSS is generated correctly, the graphics are just not on disk [22:12:53] RoanKattouw, yeah I remember we talked about this in another context now [22:13:41] Oh I'm sure we must have, at some point over the years [22:13:43] This tends to come up [22:14:11] hmmm. [22:14:14] [13jquery-client] 15Krinkle 04force-pushed 06testing from 1452bfaca to 14e680c58: 02https://github.com/wikimedia/jquery-client/commits/testing [22:14:14] 13jquery-client/06testing 14e680c58 15Timo Tijhof: Bootstrap repo with JSHint, JSCS, Karma, and JSDuck... [22:17:34] TrevorParscal: bahhh. colorize-svg doesn't handle RTL flipping at all. [22:17:52] MatmaRex: So how did it work in the past? [22:17:53] (03PS8) 10Catrope: [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) [22:18:22] James_F: because it just so happens that so far, both -ltr.svg file and -rtl.svg was always used, for different icons [22:18:25] e.g. [22:18:32] MatmaRex: Ha. [22:18:33] "next": { "file": "move-ltr.svg" }, [22:18:33] "previous": { "file": "move-rtl.svg" }, [22:18:40] MatmaRex: That makes so much sense. [22:18:41] * James_F sighs. [22:18:44] so one handled one of them, and second handled the other [22:18:52] and it just happened to work correctly [22:18:58] ha ha ha [22:19:32] Amazing [22:19:41] Depressing. :-) [22:20:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope) [22:21:25] (03CR) 10Mooeypoo: Add a tool group to VE toolbar with Citoid (032 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 (owner: 10Mooeypoo) [22:22:24] (03PS2) 10Mooeypoo: Add a tool group to VE toolbar with Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 [22:22:45] TrevorParscal: will you be implementing this, or do you want me to? (can't do it today) [22:23:16] (03CR) 10Catrope: Add a tool group to VE toolbar with Citoid (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 (owner: 10Mooeypoo) [22:23:21] TrevorParscal: oh, and there's a second issue, too. [22:23:50] cssjanus doesn't generate a .rtl.css file if there's nothing to flip. [22:24:05] Fun. [22:24:24] That can be fixed with a follow-up conditional copy, perhaps. [22:24:34] MatmaRex: you can do it in a follow up [22:24:36] yeah? [22:24:37] if foo.rtl.css doesn't exist, cp foo.css to foo.rtl.css [22:24:38] so we need to either force it to do it somehow, or teach the JS code more things about the CSS [22:24:50] yeah [22:25:24] but this feels like something that should have a config option [22:25:38] ha [22:25:38] \ [22:25:38] options.generateExactDuplicates [22:25:38] Type: Boolean Default value: false [22:25:38] Whether to generate the RTL file if it ends up being the same as the LTR file. [22:26:05] (03CR) 10Krinkle: Add a tool group to VE toolbar with Citoid (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 (owner: 10Mooeypoo) [22:28:20] (03CR) 10Alex Monk: "Sigh... Yeah, that's completely broken this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) (owner: 10Alex Monk) [22:29:15] 10VisualEditor, 10VisualEditor-Performance: The loading bar should be more visible - https://phabricator.wikimedia.org/T92456#1111381 (10tarlocesilion) 3NEW [22:30:06] TarLocesilion: :-) [22:30:20] TarLocesilion: First person I've seen reference my personæ. :-) [22:30:32] * TarLocesilion nods [22:31:12] you know, I have my personae, you have yours, they are naturally similar :) [22:31:20] (03CR) 10Bartosz Dziewoński: [C: 04-1] "* colorize-svg doesn't support RTL flipping (when 'file-ltr.svg' is given, 'file-rtl.svg' needs to be copied and colorized the same; maybe" [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [22:35:06] (03PS9) 10Catrope: [WIP] Factor out loading code into TargetLoader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) [22:37:20] 10VisualEditor, 10VisualEditor-Performance: The loading bar should be more visible - https://phabricator.wikimedia.org/T92456#1111397 (10tarlocesilion) [22:48:46] (03PS1) 10Kmenger: OutlineSelectWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196093 [22:52:42] RoanKattouw, this isn't working. The tools are constantly initialized *BEFORE* the lookup/for loop is running. I even created another js file to be on top of the tool definitions, where I made that loop and defined it in global (properly namespaced) variable -- and that's still not working. [22:55:10] RoanKattouw: You still don't have an npm account? [22:55:19] Do I not? [22:55:27] Krinkle: Send me instructions and I will follow [22:55:56] mooeypoo: Did you use a debugger to verify the timing? [22:56:01] RoanKattouw, yes [22:56:02] RoanKattouw: https://docs.npmjs.com/getting-started/publishing-npm-packages#creating-a-user [22:56:07] I'm doing something wrong, it's not even triggering [22:56:22] it's failing on OO.ui.ToolGroupTool.prototype.createGroup = function ( group ) { [22:56:24] because the group is empty [22:57:19] mooeypoo: But your debugger statement at the top of that file is never triggering? [22:57:27] RoanKattouw, "raw" script (For loop) inside ( function () { ... }() ) closure followed by the definition of the toolbarGroup [22:57:46] no [22:57:47] wtf. [22:57:54] Krinkle: I created a user called catrope [22:57:57] something is wrong with my debugger. [22:58:06] because it's STORING *some* of the information that is defined in that file [22:58:09] so it clearly runs [22:58:34] RoanKattouw: I ran 'npm owner add catrope' in oojs, oojs-ui and jquery-client. [22:58:45] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-04_(1.25wmf20): Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1111434 (10Etonkovidova) Re-opening: the issue is present in be... [22:58:57] https://www.npmjs.com/package/jquery-client :) [22:59:05] Awesome :) [22:59:11] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-04_(1.25wmf20): Categories become "detached item" after clicking 'Cancel' button - https://phabricator.wikimedia.org/T89923#1111436 (10Etonkovidova) 5Resolved>3Open [22:59:24] Also I love the internet [22:59:29] It automatically picked up my Gravatar [23:00:12] I ran the most minimalist account creation process that has ever existed on the command line, you ran another command on the command line, and now a picture of me is on the project page [23:00:12] RoanKattouw: To publish: Ensure git clone workspace is clean, merged, relevant commit tagged and pushed, then when having that commit checked out and clean workspace, run 'npm publish'. (So it uses workspace, not git) [23:00:14] 10OOjs-UI: MenuOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos - https://phabricator.wikimedia.org/T92452#1111446 (10matmarex) [23:00:31] And uses version and name from package.json in that CWD [23:00:34] OK, so at a clean state, git checkout tagname; npm publish ? [23:00:38] Yup [23:00:41] Cool [23:00:50] Maybe next time oojs-ui, you can give it a try :) [23:01:06] Did we do today's OOUI release already? [23:01:10] No. [23:01:13] Not that I volunteer for it [23:01:16] I need to sleep soon [23:01:23] I'm waiting on MatmaRex and TrevorParscal to finish with the icon set stuff. [23:01:32] Or tell me they give up for this week. Again. :-( [23:01:43] MatmaRex: where are we at? [23:01:45] sorry, I was afk [23:02:31] uhm [23:02:38] i commented on it [23:02:43] colorize-svg doesn't support RTL flipping (when 'file-ltr.svg' is given, 'file-rtl.svg' needs to be copied and colorized the same; maybe -left and -right too, configurable like in CSSJanus?). [23:02:43] CSSJanus needs `generateExactDuplicates: true`. [23:03:24] 10MediaWiki-ResourceLoader: OutputPage::addModuleStyles() should throw an exception if the listed modules have dependencies. - https://phabricator.wikimedia.org/T92458#1111458 (10EBernhardson) [23:03:27] adding this to colorize-svg is going to be nasty [23:03:38] not very difficult to get working, maybe, but sooo eww [23:04:15] James_F: OK. It's ready for you to fetch it from https://github.com/wikimedia/jquery-client/blob/v1.0.0/jquery.client.js https://github.com/wikimedia/jquery-client/raw/v1.0.0/jquery.client.js in to libs in mw if you want [23:04:34] it's all because trevor spent the time rewriting my ball-of-mud code for it into something pretty, tacking on features makes me feel way more guilty that it would :P [23:04:48] (03PS10) 10Catrope: Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) [23:05:06] Krinkle: Should I make update-jquery.client.sh? [23:05:48] Krinkle, James_F: https://gerrit.wikimedia.org/r/193026 is the TargetLoader change but scoped down to just T53569 [23:05:52] And no longer WIP [23:05:52] (03CR) 10jenkins-bot: [V: 04-1] Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope) [23:05:53] James_F: Hm.. maybe just treat it as an external lib like with jquery. It's not compiled or built, so doesn't need npm per se. [23:06:03] ...dammit [23:06:04] Krinkle: But we're doing npm releases, right? [23:06:18] James_F: But a primitive 'update-libs' script that fetches different resources based on version would be rad. [23:06:30] Krinkle: Meh. Another time. [23:06:34] I'll give that a shot over the weekend. [23:06:54] extension.json is not a valid JSON file [23:06:56] lol [23:06:59] I hadn't seen that one before [23:07:06] O_O? [23:07:29] (03PS11) 10Catrope: Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) [23:07:46] There, now with fewer misplaced commas [23:07:47] OK, if you do it, sure. ;-) But I'd much rather you worked on karma, or the re-implementation of the edit notice thing. [23:08:24] RoanKattouw: Nothing on T78628 or T90372 for now, or just doing later? [23:08:27] (03CR) 10Trevor Parscal: [C: 032] "RTL issues should be fixed in a follow up because they are related not to the icon sources or configurations but the build process." [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [23:08:30] (03CR) 10jenkins-bot: [V: 04-1] MediaWiki Theme: Add "Wikicon" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [23:08:53] https://phabricator.wikimedia.org/T78628 was tagged but never really covered, it's a tracking bug whose only open dependency is T53569 [23:08:59] So that was just cheating [23:09:28] As for https://phabricator.wikimedia.org/T90372 , older patchsets have code that fixes it, but I took that out here as part of scoping it down [23:09:51] Tomorrow I will salvage that code out of the older patchsets and put it in a WIP patch [23:10:24] Basically that's the hard part where all the issues I previously picked Krinkle's brain about come up [23:11:01] RoanKattouw: OK. [23:11:03] But Krinkle rightly encouraged me to split this change up, and I managed to get something out of it that can stand on its own and fixes an old bug, so that's good :) [23:11:17] Speaking of [23:11:35] Now that jquery.client has a release in npm, I suppose that means we're really close to having it in VE core [23:11:47] But I still need either Krinkle or James_F to actually do that :D [23:12:21] (03PS1) 10Kmenger: OutlineControlsWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196096 [23:12:26] RoanKattouw: Cool. I'll get on reviewing this change. Looks a lot more like something that's peacemeal and easily landable. [23:12:50] 10TemplateData, 5Patch-For-Review, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-03-04_(1.25wmf20): Template Documentation Editor: Suggested, Required, Deprecated values cannot be unset - https://phabricator.wikimedia.org/T90283#1111462 (10Etonkovidova) [23:12:51] (03PS13) 10Trevor Parscal: MediaWiki Theme: Add "Wikicon" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [23:12:58] *piecemeal [23:13:02] (03CR) 10Trevor Parscal: [C: 032] MediaWiki Theme: Add "Wikicon" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [23:13:14] I am now laughing construing the meaning of peacemeal xD [23:13:26] (03PS3) 10Mooeypoo: Add a tool group to VE toolbar with Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 [23:13:30] RoanKattouw, I found my error. It works now, but it was PAINFUL to write. [23:13:35] this is such a horrible hack :( [23:13:43] Anyway, sorry, enough making fun of my coworkers [23:14:18] Krinkle: Thanks. I'll call it a night soon, and tomorrow I'll poke at part 2 (starting with code that I originally put in this patch but took out) [23:14:43] James_F: TrevorP|Away: i'm going to try fixing that rtl thing [23:14:56] so give me half an hour [23:15:18] mooeypoo: Hmmm [23:15:27] MatmaRex: OK. [23:15:29] mooeypoo: It seems to me that some of that pain is caused by you splitting that file [23:15:39] If you didn't split it, you could have a private variable in your closure [23:15:43] (03Merged) 10jenkins-bot: MediaWiki Theme: Add "Wikicon" icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester) [23:15:49] RoanKattouw, I tried that and it didn't work [23:16:03] Also the JSON.parse check is now duplicated, which makes me feel more like it shouldn't be split [23:16:07] 10OOjs-UI, 10UI-Standardization, 7Tracking: Get OOUI PHP to be good to go - https://phabricator.wikimedia.org/T74713#1111466 (10Jdforrester-WMF) [23:16:08] 10OOjs-UI, 5OOjs-UI-next-release: Provide support for "icon packs" so that not all of the OOjs UI theme needs to be loaded at once for users - https://phabricator.wikimedia.org/T89686#1111464 (10Jdforrester-WMF) 5Open>3Resolved [23:16:08] mooeypoo: How did it not work? [23:16:24] it kept calling for the tool instantiation befeore the loop [23:16:30] which made no sense at all [23:16:41] okay, i may have had another issue there, let me merge the files back [23:17:06] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - https://phabricator.wikimedia.org/T70590#1111467 (... [23:18:11] (03CR) 10Catrope: [C: 04-1] Add a tool group to VE toolbar with Citoid (033 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 (owner: 10Mooeypoo) [23:18:25] 10MediaWiki-ResourceLoader: ResourceLoader should not restrict addModuleStyles() to modules purely provide styles - https://phabricator.wikimedia.org/T92459#1111469 (10Krinkle) 3NEW a:3TrevorParscal [23:18:46] Krinkle: Is there a task for jquery.client librarification? [23:19:38] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Verified-in-Phase0, and 4 others: Show the VisualEditor toolbar/editor chrome as soon as VE scripts are loaded, rather than blocking on waiting for the content to load - https://phabricator.wikimedia.org/T76523#1111482 (10Etonkovidova) [23:19:59] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown: Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1111485 (10Mattflaschen) 5duplicate>3Open We decided (with advice from @legoktm) not to rely on the shim for now. We'll address this dire... [23:20:05] James_F: Not as such, but there is a "put it in VE core" task [23:20:13] RoanKattouw: Yeah, I know. [23:20:15] OK. [23:20:43] 10MediaWiki-ResourceLoader: ResourceLoader should restrict addModuleStyles() to modules that only provide styles - https://phabricator.wikimedia.org/T92459#1111502 (10Catrope) [23:21:41] 10MediaWiki-ResourceLoader: ResourceLoader should not restrict addModuleStyles() to modules purely provide styles - https://phabricator.wikimedia.org/T92459#1111514 (10Krinkle) [23:21:49] 10MediaWiki-ResourceLoader: ResourceLoader should not restrict addModuleStyles() to modules purely provide styles - https://phabricator.wikimedia.org/T92459#1111469 (10Krinkle) p:5Triage>3Normal [23:22:09] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown: Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1096593 (10Mattflaschen) [23:22:13] 10MediaWiki-ResourceLoader: ResourceLoader should not restrict addModuleStyles() to modules purely provide styles - https://phabricator.wikimedia.org/T92459#1111469 (10Krinkle) [23:22:14] 10MediaWiki-ResourceLoader: Using addModuleStyles() and then addModules() for one module on one page duplicates the styles - https://phabricator.wikimedia.org/T87871#1111521 (10Krinkle) [23:22:28] 10MediaWiki-ResourceLoader: OutputPage::addModuleStyles() should throw an exception if the listed modules have dependencies. - https://phabricator.wikimedia.org/T92458#1111523 (10Krinkle) [23:22:29] 10MediaWiki-ResourceLoader: ResourceLoader should not restrict addModuleStyles() to modules purely provide styles - https://phabricator.wikimedia.org/T92459#1111469 (10Krinkle) [23:22:34] 10MediaWiki-ResourceLoader: ResourceLoader should restrict addModuleStyles() to modules that only provide styles - https://phabricator.wikimedia.org/T92459#1111525 (10Catrope) [23:22:46] 10OOjs-UI, 5OOjs-UI-0.9.0, 7Accessibility, 7Verified-in-Phase0, and 2 others: PopupButtonWidget menu is not keyboard traversable/closeable - https://phabricator.wikimedia.org/T87695#1111526 (10Etonkovidova) [23:22:50] (03PS4) 10Mooeypoo: Add a tool group to VE toolbar with Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 [23:24:21] (03CR) 10Catrope: [C: 04-1] Add a tool group to VE toolbar with Citoid (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 (owner: 10Mooeypoo) [23:24:34] 10MediaWiki-ResourceLoader: ResourceLoader should restrict addModuleStyles() to modules that only provide styles - https://phabricator.wikimedia.org/T92459#1111539 (10Krinkle) [23:24:42] RoanKattouw: thx [23:25:00] Krinkle: Double negative :D [23:25:19] mooeypoo: With the exception of that final nitpick, that code is good to go as far as I'm concerned [23:26:17] Krinkle: Did either of us ever file a task about doing document.write( '' ); at the end of debug mode loads? [23:26:45] RoanKattouw: Nope. [23:26:50] (with fewer single quotes but you get what I mean) [23:26:55] Krinkle: Could you file one? [23:27:01] RoanKattouw: [23:27:02] http://i.imgur.com/tDlQW8F.png [23:27:19] Right yeah [23:27:26] I think you sent me that link last time I said I'd file a task for it [23:27:30] Yeah [23:27:30] And I think I didn't at the time [23:27:38] James_F: okay, adding it in the first section? [23:27:48] (03PS1) 10Jforrester: Provide the jquery.client library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196102 (https://phabricator.wikimedia.org/T91460) [23:28:23] ryasmeen: Yes. [23:28:30] 10MediaWiki-ResourceLoader, 10VisualEditor: Devise a means of testing local code on production wikis - https://phabricator.wikimedia.org/T87384#1111564 (10Krinkle) p:5Triage>3Low [23:28:41] (03CR) 10Catrope: [C: 032] Provide the jquery.client library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196102 (https://phabricator.wikimedia.org/T91460) (owner: 10Jforrester) [23:28:47] 10MediaWiki-ResourceLoader, 10MediaWiki-Unit-tests, 7JavaScript, 7Technical-Debt: Add tests for mw.loader.store - https://phabricator.wikimedia.org/T78369#1111567 (10Krinkle) p:5Triage>3Low [23:28:51] RoanKattouw: Tsk. It's not even used! :-) [23:29:00] Patches inbound [23:29:10] * James_F nods. [23:29:10] 10MediaWiki-ResourceLoader: OutputPage::addModuleStyles() should throw an exception if the listed modules have dependencies. - https://phabricator.wikimedia.org/T92458#1111572 (10Krinkle) p:5Triage>3Normal [23:29:11] 10VisualEditor, 10VisualEditor-Performance: Don't disable native object editing in IE and WebKit browsers - https://phabricator.wikimedia.org/T89928#1111574 (10Jdforrester-WMF) [23:29:12] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 3VisualEditor 2014/15 Q3 blockers: Using data URI images in inline slugs (for chimeras) is slow in Chrome (and possibly others) - https://phabricator.wikimedia.org/T91248#1111573 (10Jdforrester-WMF) [23:29:14] 10VisualEditor, 7Technical-Debt, 5WMF-deploy-2015-03-18_(1.25wmf22): Put jquery.client back in VE core - https://phabricator.wikimedia.org/T91460#1111570 (10Jdforrester-WMF) 5Open>3Resolved [23:29:33] TrevorP|Away: James_F: okay, i've got it mostly working. it sucks but oh well [23:30:16] will push in a sec [23:30:40] 10VisualEditor, 10jQuery-Client, 7Technical-Debt, 5WMF-deploy-2015-03-18_(1.25wmf22): Put jquery.client back in VE core - https://phabricator.wikimedia.org/T91460#1084669 (10Jdforrester-WMF) [23:31:06] (03Merged) 10jenkins-bot: Provide the jquery.client library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196102 (https://phabricator.wikimedia.org/T91460) (owner: 10Jforrester) [23:31:13] 10MediaWiki-ResourceLoader, 7JavaScript, 7Performance: localStorage nearly or totally filled with routine operation - https://phabricator.wikimedia.org/T58728#1111580 (10Krinkle) [23:31:14] 10MediaWiki-ResourceLoader: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#1111581 (10Krinkle) [23:32:16] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 5Patch-For-Review: Use source urls in mw.loader.store - https://phabricator.wikimedia.org/T90524#1111595 (10Krinkle) p:5Normal>3Low [23:34:23] (03CR) 10Krinkle: "Quick incomplete review." (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope) [23:35:48] (03PS1) 10Catrope: Only call execCommand() on the surface in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) [23:37:38] (03CR) 10jenkins-bot: [V: 04-1] Only call execCommand() on the surface in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope) [23:38:08] (03CR) 10Krinkle: "404 link :)" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196102 (https://phabricator.wikimedia.org/T91460) (owner: 10Jforrester) [23:38:35] RoanKattouw: My commit didn't actually add a dependency on jquery.client, just added it. [23:38:45] Krinkle: Bah. Bloody github. [23:38:58] * James_F fixes. [23:39:02] James_F: Sure but it exists in core and init init depends on it [23:39:06] I guess the tests don't though [23:39:24] RoanKattouw: But nothing in VE-core depends on it. [23:39:29] RoanKattouw: So code in VE-core using it won't work well. [23:39:31] Oh right [23:39:34] :-D [23:39:35] I can fix that [23:39:38] OK. [23:39:44] Fix the AUTHORS.txt typo? [23:40:01] s/ https://github.com/wikimedia/jquery-client / https://github.com/wikimedia/jquery.client / [23:40:05] <-> [23:40:08] Whatever. [23:40:08] (03PS1) 10Bartosz Dziewoński: build: Set 'generateExactDuplicates: true' for CSSJanus [oojs/ui] - 10https://gerrit.wikimedia.org/r/196107 [23:40:10] (03PS1) 10Bartosz Dziewoński: build: Implement basic image flipping support in colorize-svg [oojs/ui] - 10https://gerrit.wikimedia.org/r/196108 [23:40:35] (03PS1) 10Catrope: Implement ve.init.Platform static functions using $.client [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196109 [23:40:37] (03CR) 10Jforrester: [C: 032] "Eww." [oojs/ui] - 10https://gerrit.wikimedia.org/r/196107 (owner: 10Bartosz Dziewoński) [23:41:22] 10VisualEditor, 10Wikimedia-Hackathon-2015, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1111623 (10Whatamidoing-WMF) "Enable" means "click on the Beta Features link, find 'VisualEditor', tick the... [23:41:32] (03PS1) 10Catrope: Follow-up d6dac30a097: fix typo in github URL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196110 [23:42:04] RoanKattouw: Or that. :-) [23:42:37] (03CR) 10Jforrester: [C: 032] Follow-up d6dac30a097: fix typo in github URL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196110 (owner: 10Catrope) [23:42:51] (03CR) 10jenkins-bot: [V: 04-1] Implement ve.init.Platform static functions using $.client [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196109 (owner: 10Catrope) [23:43:42] (03Merged) 10jenkins-bot: build: Set 'generateExactDuplicates: true' for CSSJanus [oojs/ui] - 10https://gerrit.wikimedia.org/r/196107 (owner: 10Bartosz Dziewoński) [23:44:36] there are 216 .css files in the distribution now, by the way. this is insane. [23:44:47] (03CR) 10Jforrester: [C: 032] "Holding my nose, per Bartosz. :-)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196108 (owner: 10Bartosz Dziewoński) [23:44:51] MatmaRex: Indeed. [23:45:01] MatmaRex: It'll be worse when we also do this to Apex. [23:45:13] (03Merged) 10jenkins-bot: Follow-up d6dac30a097: fix typo in github URL [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196110 (owner: 10Catrope) [23:45:20] (03PS1) 10Catrope: Add jquery.client as a base library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196111 [23:45:40] (03PS2) 10Catrope: Implement ve.init.Platform static functions using $.client [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196109 [23:45:46] this really is rather silly. [23:45:53] (03PS2) 10Catrope: Only call execCommand() on the surface in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) [23:46:16] surely we don't need to always generate both .css and .min.css, nor do we need the three vector/raster/mixed versions. [23:46:54] there must be a sensible way to pass this to grunt, as command-line parameters or whatever, and only run the appropriate tasks [23:47:21] (we could maybe create separate grunt tasks for this somehow) [23:47:23] (03Merged) 10jenkins-bot: build: Implement basic image flipping support in colorize-svg [oojs/ui] - 10https://gerrit.wikimedia.org/r/196108 (owner: 10Bartosz Dziewoński) [23:48:22] (03PS1) 10Kmenger: ActionWidget: Clarify description and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/196112 [23:48:25] (03CR) 10Jforrester: [C: 032] Add jquery.client as a base library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196111 (owner: 10Catrope) [23:48:27] if we're aiming to make OOUI usable outside of VE/MediaWiki, then having 228 files in the distribution is definitely not the way to go [23:48:58] (03CR) 10Jforrester: [C: 032] OutlineSelectWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196093 (owner: 10Kmenger) [23:49:02] i can't imagine anyone actually using a library like this, being forced to either copy the whole shebang, or fish out the versions they want [23:49:05] * MatmaRex files a bug [23:49:10] (03CR) 10Jforrester: [C: 032] OutlineControlsWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196096 (owner: 10Kmenger) [23:49:28] (03PS2) 10Jforrester: ActionWidget: Clarify description and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/196112 (owner: 10Kmenger) [23:49:49] (03CR) 10Jforrester: [C: 032] ActionWidget: Clarify description and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/196112 (owner: 10Kmenger) [23:51:04] (03Merged) 10jenkins-bot: Add jquery.client as a base library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196111 (owner: 10Catrope) [23:51:31] 10OOjs-UI: Address insane distribution bloat - https://phabricator.wikimedia.org/T92464#1111655 (10matmarex) 3NEW [23:51:51] RoanKattouw: With your patch VE-MW loading is pretty stupendously fast. [23:51:55] (03Merged) 10jenkins-bot: OutlineSelectWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196093 (owner: 10Kmenger) [23:51:59] RoanKattouw: Nice work. [23:52:01] (03Merged) 10jenkins-bot: OutlineControlsWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196096 (owner: 10Kmenger) [23:52:44] (03Merged) 10jenkins-bot: ActionWidget: Clarify description and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/196112 (owner: 10Kmenger) [23:53:10] James_F: What, TargetLoader? [23:54:08] RoanKattouw: Yeah. [23:54:14] James_F: also, is it worth it for me to write down all the issues i see with the icons? (will they be accepted/fixed?) [23:54:18] RoanKattouw: Even with debug=true it loads in less than a second. [23:54:23] because i see a bunch :( [23:54:26] MatmaRex: Issues? [23:55:08] hah nice [23:55:12] yes. [23:56:00] (03CR) 10Krinkle: "Hm.. I'd rather browser sniffs are version-bound. Or in absence of that (since it's a current bug), at least a reference to our bug about " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope) [23:56:09] (03CR) 10Krinkle: [C: 04-1] Only call execCommand() on the surface in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope) [23:56:11] (03PS1) 10Kmenger: ActionSet: Clarify description: [oojs/ui] - 10https://gerrit.wikimedia.org/r/196118 [23:56:59] (03PS1) 10Catrope: Only set a data URI src on inline slugs in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196119 (https://phabricator.wikimedia.org/T91248) [23:57:21] kirstenMA: Did you mean to add more to that commit message? [23:57:31] (ending in ":") - otherwise I'll merge it :) [23:58:00] no, just that. It was just a little note, but I thought it was worth adding. Thanks! [23:58:17] (03PS2) 10Krinkle: ActionSet: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196118 (owner: 10Kmenger) [23:58:26] (03CR) 10Krinkle: [C: 032] ActionSet: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196118 (owner: 10Kmenger) [23:58:32] (03PS1) 10Jforrester: Tag v0.9.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/196120 [23:58:43] (03CR) 10Catrope: "Re version-bound-ness: there currently does not exist a version of Firefox in which this isn't broken, as far as I'm aware. Once one comes" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope)