[00:01:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: ActionSet: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196118 (owner: 10Kmenger)
[00:01:41] <MatmaRex>	 James_F: stuff that bugs me: the cross-out lines being in different directions in different icons, templateAdd icon resembling nothing at all, stop icon having inverted color scheme, articleCheck RTL having a flipped tick, betaLaunch being English-specific (and just plain stupid, seriously; we don't need visual puns in icons), userInactive icon looking stoned.
[00:01:52] <MatmaRex>	 that's for starters. :)
[00:03:06] <MatmaRex>	 oh, and of course the new icons looking very distinct from the old icons (just look at undo/redo or next/previous, and compare to the new arrows and carets), and how no one thought to draw things like a help icon in the new ones.
[00:05:25] <MatmaRex>	 James_F: in general i think we did a very poor job with this and i'm not exactly comfortable pushing it out, but i understand i've been preemptively overruled on this, so i'm trying to improve the situation.
[00:05:56] <MatmaRex>	 so should i repeat that "upstream" to design, or suck it up and not waste time? my comments on various icons in the past were not well-received.
[00:06:27] <grrrit-wm>	 (03CR) 10Catrope: "Re spec: I checked and the specification of https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#execcommand%28%29 , while specifying " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope)
[00:08:03] <RoanKattouw>	 OK, bedtime
[00:08:58] <grrrit-wm>	 (03CR) 10Krinkle: "Yeah, I figured it couldn't be bound right now. But as a maintenance principle, an unbounded check should have information near it for why" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope)
[00:09:30] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "RTL issues fixed or worked around in https://gerrit.wikimedia.org/r/196107 and https://gerrit.wikimedia.org/r/196108 ." [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester)
[00:13:27] <gwicke>	 James_F: I did a bunch of test edits on test.wikipedia.org; other than test.wikipedia.org being generally slow the VE <-> RESTBase integration seems to be doing its job fine
[00:15:14] <wikibugs>	 10MediaWiki-ResourceLoader: For raw script loading, use document.write() to get a callback for the previous document.write() - https://phabricator.wikimedia.org/T92466#1111705 (10Krinkle) 3NEW
[00:15:30] <wikibugs>	 10MediaWiki-ResourceLoader: For raw script loading, use document.write() to get a callback for the previous document.write() - https://phabricator.wikimedia.org/T92466#1111712 (10Krinkle)
[00:17:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-11_(1.25wmf21): The transition while switching between Readmode and VE is now not smooth, new content is inserted before the old content is removed leading to a flicker - https://phabricator.wikimedia.org/T91442#1111715 (10Krinkle) Yep. Confirmed....
[00:18:26] <grrrit-wm>	 (03PS1) 10Kmenger: InputWidget: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196127 
[00:18:44] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1111716 (10Prtksxna) In quiet buttons, icons need to be `#555` all the time and change color according to their class (progressiv...
[00:19:01] <grrrit-wm>	 (03CR) 10Divec: [C: 032] Only set a data URI src on inline slugs in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196119 (https://phabricator.wikimedia.org/T91248) (owner: 10Catrope)
[00:20:13] <Eloquence>	 James_F, hooray for the death of <sup>beta</sup>
[00:20:26] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1111721 (10violetto) yeah
[00:21:19] <wikibugs>	 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, and 4 others: Parsoid performance: Use RESTBase from the MediaWiki Virtual Rest Service - https://phabricator.wikimedia.org/T89066#1111722 (10GWicke) 5Resolved>3Open Re-opening as it is not actually the case across the board.  This...
[00:21:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only set a data URI src on inline slugs in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196119 (https://phabricator.wikimedia.org/T91248) (owner: 10Catrope)
[00:21:49] <wikibugs>	 10VisualEditor, 10Wikimedia-Hackathon-2015, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1111726 (10Jaredzimmerman-WMF) @pginer-WMF and @nirzar were experimenting with a 1 click way to enable cont...
[00:24:01] <wikibugs>	 10VisualEditor, 10Wikimedia-Hackathon-2015, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1111729 (10Nirzar) @Jaredzimmerman-WMF it is done :) CX gets enabled without going to the beta preferences....
[00:25:18] <wikibugs>	 10VisualEditor, 10VisualEditor-Initialisation, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: MediaWiki api Cache-Control headers are different than MediaWiki's.  This causes problems for VE users on some browsers. - https://phabricator.wikimedia.org/T74480#1111730 (10MarkAHershberger) 5Open>3Re...
[00:51:22] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Beta-Cluster: On Beta Cluster, switching from VisualEditor to edit source mode intermittently loads the wikitext editor without any CSS - https://phabricator.wikimedia.org/T86624#1111775 (10Krenair) a:5Krenair>3None
[00:57:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): [Regression pre-wmf21] Tool-Format menu does not display all options - https://phabricator.wikimedia.org/T91772#1111800 (10Ryasmeen)
[00:58:15] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): [Regression pre-wmf21] The Row/Column indicator for table is not aligned with the cell properly - https://phabricator.wikimedia.org/T91727#1111806 (10Ryasmeen)
[00:59:43] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): [Regression pre-wmf21] Comment icon is now huge - https://phabricator.wikimedia.org/T91656#1111814 (10Ryasmeen)
[00:59:54] <wikibugs>	 10OOjs-UI: Various widgets refuse to tab to other widgets - https://phabricator.wikimedia.org/T92449#1111817 (10matmarex) Vaguely related? {T91132}  I can only reproduce using Firefox and not Opera 28 (like Chrome), IE 11 or Opera 12.
[01:00:45] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, and 2 others: [Regression wmf20] Cursor traverses through the table unexpectedly with right/left arrow keys and throws following error in the console "Uncaught Typ... - https://phabricator.wikimedia.org/T91726#1111820
[01:01:03] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): The option for Header cell/Content cell in a table does not retain the check mark next to it, that appears initially while se... - https://phabricator.wikimedia.org/T91827#1111821
[01:08:41] <wikibugs>	 10TemplateData, 7Verified-in-Phase0, 5WMF-deploy-2015-03-11_(1.25wmf21): TemplateData GUI needs to let users set a string as the (secondary) value for 'deprecated' (as a description), not just boolean - https://phabricator.wikimedia.org/T90734#1111828 (10Ryasmeen)
[01:10:03] <Eloquence>	 the new link dialog is great!
[01:10:28] <Eloquence>	 really nice to be able to see citation content
[01:14:13] <TrevorParscal>	 hey James_F
[01:14:15] <TrevorParscal>	 i'm back
[02:14:09] <wikibugs>	 10VisualEditor, 10Wikimedia-Hackathon-2015, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1111887 (10Jaredzimmerman-WMF) @Pginer-WMF and @Nirzar can you link to the code used by CX to do this please.
[02:27:25] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Accessibility, 7Design: ToggleSwitchWidget has no visual representation for focused state - https://phabricator.wikimedia.org/T88973#1111898 (10Jaredzimmerman-WMF) @violetto looks good but is the height consistent next to other controls? also don't forget we need the alter...
[03:07:20] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design: Implement tipsy - https://phabricator.wikimedia.org/T91856#1111978 (10Jaredzimmerman-WMF) p:5Triage>3Normal
[03:07:26] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Accessibility, 7Design: ToggleSwitchWidget has no visual representation for focused state - https://phabricator.wikimedia.org/T88973#1111981 (10Jaredzimmerman-WMF) p:5Triage>3High
[03:07:46] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design: Hover state on buttons - https://phabricator.wikimedia.org/T92049#1111989 (10Jaredzimmerman-WMF) p:5Triage>3Normal
[03:08:00] <wikibugs>	 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1111994 (10Jaredzimmerman-WMF) p:5Triage>3High
[03:08:07] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design: ButtonWidget (icon)‎ & ButtonWidget (icon, progressive)‎ should be styled like normal buttons - https://phabricator.wikimedia.org/T88617#1111999 (10Jaredzimmerman-WMF) p:5Triage>3High
[03:08:14] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Accessibility, 7Design: When user dismisses a modal dialog, the screen reader should let the user know of their last location. - https://phabricator.wikimedia.org/T87714#1112002 (10Jaredzimmerman-WMF) p:5Triage>3Normal
[03:12:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, 3Editing Department 2014/15 Q4 blockers: Create a guided tour for VisualEditor using GuidedTour guiders - https://phabricator.wikimedia.org/T89074#1112016 (10Jaredzimmerman-WMF) a:3KHammerstein
[05:28:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 3VisualEditor 2014/15 Q3 blockers: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1112183 (10GOIII) >>! In T91608#1102537, @Krenair wrote: > I think we should, after discussing with @Jdforrester...
[06:36:33] <wikibugs>	 10OOjs-UI: oojs ui `npm build` fails in Rasterizing SVG to PNG with "Warning: Bad argument  - https://phabricator.wikimedia.org/T92479#1112232 (10Spage) 3NEW
[07:16:35] <wikibugs>	 10VisualEditor, 10Wikimedia-Hackathon-2015, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1112259 (10Pginer-WMF) The Phab ticket is {T89701}. There are linked the following patchsets from Gerrit: -...
[08:27:52] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: Highlight target references [extensions/Cite] - 10https://gerrit.wikimedia.org/r/196172 (https://phabricator.wikimedia.org/T10303) 
[08:27:55] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/196172 (https://phabricator.wikimedia.org/T10303) (owner: 10Gerrit Patch Uploader)
[08:29:05] <grrrit-wm>	 (03CR) 10Schnark: "This is the first time I used Gerrit Patch Uploader, so please tell me if I did something wrong, or could do something better." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/196172 (https://phabricator.wikimedia.org/T10303) (owner: 10Gerrit Patch Uploader)
[08:29:51] <wikibugs>	 10Cite, 5Patch-For-Review: Highlight target references - https://phabricator.wikimedia.org/T10303#1112297 (10Schnark) a:3Schnark
[08:39:16] <wikibugs>	 10MediaWiki-Page-editing, 10WikiEditor, 10MediaWiki-Interface: Wikitext editor no longer links to full help - https://phabricator.wikimedia.org/T92398#1112302 (10Schnark) This has been removed (or rather: hidden) on purpose, see https://gerrit.wikimedia.org/r/76069
[08:56:34] <wikibugs>	 10VisualEditor, 10Flow, 10Thanks, 5Patch-For-Review: Update to Pimple 2.x in Flow broke merge pipelines for Thanks, VisualEditor - https://phabricator.wikimedia.org/T91967#1112316 (10hashar)
[09:25:03] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-11_(1.25wmf21): The transition while switching between Readmode and VE is now not smooth, new content is inserted before the old content is removed leading to a flicker - https://phabricator.wikimedia.org/T91442#1112418 (10Catrope) >>! In T91442#1...
[09:27:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add a tool group to VE toolbar with Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 (owner: 10Mooeypoo)
[09:27:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a tool group to VE toolbar with Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196077 (owner: 10Mooeypoo)
[09:58:01] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentLanguage: Create wiki page to document VE manual IME test procedure and results - https://phabricator.wikimedia.org/T92486#1112466 (10dchan) 3NEW a:3dchan
[10:47:14] <wikibugs>	 10VisualEditor: Firefox normalizes numerical attributes with leading zeroes - https://phabricator.wikimedia.org/T92488#1112553 (10Esanders) 3NEW
[10:53:27] <RoanKattouw>	 edsanders: FFFFFFFFFF
[10:53:37] <edsanders>	 :)
[10:55:35] <RoanKattouw>	 div = document.createElement('div'); div.innerHTML = '<table><tr><td rowspan="02"></td></tr></table>'; div.innerHTML;
[10:55:51] <RoanKattouw>	 You're right, that round-trips in Chrome (modulo <tbody>) but not in Firefox
[10:56:28] <RoanKattouw>	 Unfortunately there are problems with the XML method when used in Firefox
[10:56:39] <RoanKattouw>	 Or... well maybe not
[10:57:14] <RoanKattouw>	 There was this issue that when serializing an HTML DOM using the XML serializer in Firefox, URLs in href attributes got their escaping normalized
[10:57:42] <RoanKattouw>	 But we might not hit that because we won't actually be serializing an HTML DOM as XML, only an XML DOM as XML and an HTML DOM as HTML
[10:57:44] <grrrit-wm>	 (03PS1) 10Esanders: Use equalDomElements in onCopy tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196196 
[10:58:33] <grrrit-wm>	 (03PS1) 10Esanders: Ignore linebreaks after <!DOCTYPE>s [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196197 
[10:58:49] <RoanKattouw>	 Thanks, I've been meaning to do the equalDomElements thing forver
[10:59:10] <edsanders>	 how important is the leading zeroes case?
[10:59:16] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use equalDomElements in onCopy tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196196 (owner: 10Esanders)
[10:59:32] <RoanKattouw>	 Probably not very
[10:59:59] <RoanKattouw>	 It'll result in dirty-diffing, but not in hideous ways like IE's style="background: rgb(255,0,0);"
[11:01:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use equalDomElements in onCopy tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196196 (owner: 10Esanders)
[11:03:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Ignore linebreaks after <!DOCTYPE>s [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196197 (owner: 10Esanders)
[11:05:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ignore linebreaks after <!DOCTYPE>s [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196197 (owner: 10Esanders)
[11:07:10] <RoanKattouw>	 IE shares the rowspan bug
[11:09:20] <grrrit-wm>	 (03PS1) 10Catrope: Add rowspan and colspan to list of corrupted attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196202 (https://phabricator.wikimedia.org/T92488) 
[11:09:33] <RoanKattouw>	 (That's not a fix for Firefox, only for IE)
[11:10:29] <grrrit-wm>	 (03PS2) 10Catrope: Add rowspan and colspan to list of corrupted attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196202 (https://phabricator.wikimedia.org/T92488) 
[11:11:38] <RoanKattouw>	 edsanders: Are you filing bugs against Firefox about these, or shall I?
[11:11:54] <edsanders>	 I haven't
[11:15:23] <RoanKattouw>	 OK
[11:15:26] <RoanKattouw>	 I'll file then
[11:15:36] <RoanKattouw>	 I also discovered that they have a tracking bug for innerHTML round-trip issues
[11:15:45] <RoanKattouw>	 Which I just attached my old <pre> round-trip bug to
[11:30:16] <edsanders>	 so they believe in the principle?
[11:32:28] <prtksxna>	 edsanders: Is the schema of images.json documented somewhere? I can't understand some of the changes made in https://gerrit.wikimedia.org/r/#/c/188289/
[11:33:40] <edsanders>	 not sure, if not it's in the minds of TrevorP|Away and MatmaRex
[11:33:53] <prtksxna>	 edsanders: Specifically, the stuff in "css". Should I be changing filenames in images.icons to use the new files?
[11:34:11] <prtksxna>	 edsanders: Alright! I'll ask when MatmaRex is around then. Thanks :)
[11:49:49] <grrrit-wm>	 (03PS1) 10Prtksxna: [wip] replace icons for demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/196206 
[12:05:29] <wikibugs>	 10OOjs-UI: LookupElement gets clipped inside ProcessDialog - https://phabricator.wikimedia.org/T89494#1112688 (10Catrope) This is because you're not passing an overlay. We should probably document overlays and their usage better. By default, LookupElement puts its dropdown directly next to itself in the DOM, and...
[12:06:21] <grrrit-wm>	 (03CR) 10Catrope: Load RL modules in one load.php request, rather than in two stages (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[12:06:39] <grrrit-wm>	 (03PS1) 10Divec: WIP allegro giocoso doloroso: block bogus 'emit' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196207 
[12:08:14] <grrrit-wm>	 (03PS12) 10Catrope: Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) 
[12:08:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP allegro giocoso doloroso: block bogus 'emit' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196207 (owner: 10Divec)
[12:09:43] <RoanKattouw>	 divec: lol
[12:21:18] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1112690 (10Prtksxna) @MatmaRex, is there a way in `src/themes/mediawiki/MediaWikiTheme.js` to change the icon of the element on h...
[12:22:59] <grrrit-wm>	 (03PS1) 10Prtksxna: [wip] Quiet colors on icons for quiet buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/196210 (https://phabricator.wikimedia.org/T88622) 
[12:25:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Quiet colors on icons for quiet buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/196210 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna)
[12:35:36] <grrrit-wm>	 (03CR) 10Catrope: "https://bugzilla.mozilla.org/show_bug.cgi?id=1142480" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196197 (owner: 10Esanders)
[12:36:33] <wikibugs>	 10VisualEditor, 5Patch-For-Review: Firefox normalizes numerical attributes with leading zeroes - https://phabricator.wikimedia.org/T92488#1112694 (10Catrope) https://bugzilla.mozilla.org/show_bug.cgi?id=1142478
[12:41:53] <grrrit-wm>	 (03PS1) 10Prtksxna: [wip] MediaWiki Theme: Add button definitions for -warning flag [oojs/ui] - 10https://gerrit.wikimedia.org/r/196211 
[12:45:27] <grrrit-wm>	 (03CR) 10Prtksxna: [C: 04-1] "Not sure if the colors are right" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196211 (owner: 10Prtksxna)
[12:52:33] <grrrit-wm>	 (03PS4) 10Catrope: WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) (owner: 10Esanders)
[12:54:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://bugzilla.wikimedia.org/70375) (owner: 10Esanders)
[12:56:39] <grrrit-wm>	 (03PS5) 10Catrope: WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://phabricator.wikimedia.org/T72375) (owner: 10Esanders)
[12:57:49] <RoanKattouw>	 12:54:07 	Expected: [object Object],[object Object],[object Object]
[12:57:51] <RoanKattouw>	 12:54:07 	Actual: [object Object],[object Object],[object Object]
[12:57:53] <RoanKattouw>	 Gee thanks QUnit
[12:58:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP Failing test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://phabricator.wikimedia.org/T72375) (owner: 10Esanders)
[13:08:45] <YuviPanda>	 RoanKattouw: hahaha :)
[13:19:45] <grrrit-wm>	 (03PS1) 10Prtksxna: MediaWiki Theme: textInputWidget: Update focus state [oojs/ui] - 10https://gerrit.wikimedia.org/r/196213 
[13:24:40] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1112848 (10Prtksxna)
[13:25:00] <grrrit-wm>	 (03PS2) 10Prtksxna: MediaWiki Theme: textInputWidget: Update focus state [oojs/ui] - 10https://gerrit.wikimedia.org/r/196213 (https://phabricator.wikimedia.org/T73150) 
[13:36:52] <grrrit-wm>	 (03PS1) 10Esanders: Move selection sub-classes to sub-folder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196214 
[13:36:54] <grrrit-wm>	 (03PS1) 10Esanders: Convert spaces to tab indentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196215 
[13:36:56] <grrrit-wm>	 (03PS1) 10Esanders: Add merged cells table to converter examples [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196216 
[13:36:58] <grrrit-wm>	 (03PS1) 10Esanders: Add unit tests for ve.dm.Selection sub-classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196217 
[13:37:09] <edsanders>	 RoanKattouw_away, what are you comparing?
[13:45:18] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] WIP allegro giocoso doloroso: block bogus 'emit' (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196207 (owner: 10Divec)
[13:46:11] <wikibugs>	 10MediaWiki-Page-editing, 10WikiEditor, 10MediaWiki-Interface: Wikitext editor no longer links to full help - https://phabricator.wikimedia.org/T92398#1112931 (10Aklapper) p:5Triage>3Lowest
[13:46:45] <RoanKattouw_away>	 edsanders: It was your failing test thingy
[13:46:49] <RoanKattouw_away>	 I think I found out why it happens
[13:46:54] <RoanKattouw_away>	 I gotta run and be back in 30 mins
[13:47:22] <RoanKattouw_away>	 But the crux of the issue is that a.canBeMergedWith(b) returns true where a is an empty paragraph and b is an alienInline inside a sibling paragraph
[13:51:47] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 3VisualEditor 2014/15 Q3 blockers: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1112947 (10Krenair) @Catrope, @Krinkle: What do you think about the first two items there?
[13:54:29] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 031] "This extension does have so many problems. This patch happens to touch two of them:" (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/196172 (https://phabricator.wikimedia.org/T10303) (owner: 10Gerrit Patch Uploader)
[14:11:38] <wikibugs>	 10OOjs-UI: oojs ui `npm build` fails in Rasterizing SVG to PNG with "Warning: Bad argument - https://phabricator.wikimedia.org/T92479#1113001 (10matmarex) NPM loves to corrupt downloaded packages and then throw cryptic errors, so before we try debugging, please try removing the `node_modules` directory in reposi...
[14:42:12] <wikibugs>	 10OOjs-UI: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow (responsive layout) - https://phabricator.wikimedia.org/T52227#1113059 (10matmarex) Okay, so I this bug mostly turned into "Make the toolbar narrower when the window is narrow", rather than what the curren...
[14:42:16] <wikibugs>	 10OOjs-UI, 10VisualEditor: OOjs UI: Responsive VE toolbar - https://phabricator.wikimedia.org/T92315#1106133 (10matmarex) >>! In T92315#1109859, @Jdforrester-WMF wrote: > Isn't this just a dupe of T52227: OOjs UI: Toolbar should collapse items rather than span multiple lines when the window is narrow (responsi...
[14:42:52] <wikibugs>	 10OOjs-UI: OOjs UI: Make the toolbar narrower when the window is narrow (responsive layout) - https://phabricator.wikimedia.org/T52227#1113062 (10matmarex)
[14:43:14] <wikibugs>	 10OOjs-UI, 10VisualEditor: OOjs UI: Responsive VE toolbar - https://phabricator.wikimedia.org/T92315#1113064 (10matmarex)
[14:44:09] <wikibugs>	 10OOjs-UI: OOjs UI: Make the toolbar narrower when the window is narrow (responsive layout) - https://phabricator.wikimedia.org/T52227#581319 (10matmarex)
[14:44:10] <wikibugs>	 10OOjs-UI: OOjs UI: Toolbar groups should support sub-groups as items - https://phabricator.wikimedia.org/T74159#1113068 (10matmarex)
[14:44:28] <wikibugs>	 10OOjs-UI: OOjs UI: Toolbar groups should support sub-groups as items - https://phabricator.wikimedia.org/T74159#747247 (10matmarex)
[14:44:28] <wikibugs>	 10OOjs-UI, 10VisualEditor: OOjs UI: Responsive VE toolbar - https://phabricator.wikimedia.org/T92315#1106133 (10matmarex)
[14:44:55] <wikibugs>	 10OOjs-UI: OOjs UI: Make the toolbar narrower when the window is narrow (responsive layout) - https://phabricator.wikimedia.org/T52227#1113071 (10matmarex) 5Open>3Resolved
[14:44:56] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1055666 (10matmarex)
[14:45:27] <grrrit-wm>	 (03PS1) 10Divec: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196224 
[14:47:20] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1113074 (10matmarex)
[14:47:59] <grrrit-wm>	 (03Abandoned) 10Divec: WIP allegro giocoso doloroso: block bogus 'emit' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196207 (owner: 10Divec)
[14:48:30] <wikibugs>	 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1113076 (10matmarex) 5Open>3stalled
[14:48:31] <wikibugs>	 10OOjs-UI: Turn on type checking for OO.ui.infuse. - https://phabricator.wikimedia.org/T90929#1113077 (10matmarex)
[14:51:31] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: [Regression pre-wmf21] When a table cell is selected, the Insert menu is enabled even though none of its contents are - https://phabricator.wikimedia.org/T91826#1113085 (10matmarex) 5Open>3Resolved
[15:08:31] <wikibugs>	 10VisualEditor: Make the visual template editor drag-able & re-sizable to allow editing easy - https://phabricator.wikimedia.org/T92396#1113149 (10matmarex) Same feature request as T51969?
[15:15:51] <guillom>	 RoanKattouw: Hi! Can you let me know when you have 5−10 minutes?
[15:17:32] <RoanKattouw>	 guillom: I'm about to do a SWAT deploy, I'm free after that
[15:17:40] <RoanKattouw>	 So in like 5ish minutes
[15:17:44] <guillom>	 RoanKattouw: ok; ping me then?
[15:17:54] <RoanKattouw>	 Will do
[15:18:00] <guillom>	 thanks!
[15:21:07] <grrrit-wm>	 (03PS2) 10Divec: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196224 
[15:40:38] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721#1113223 (10He7d3r)
[15:42:10] <grrrit-wm>	 (03CR) 10Fomafix: "I get the error:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk)
[15:45:58] * James_F waves.
[15:46:22] <grrrit-wm>	 (03PS6) 10Catrope: Fix unbalanced transaction when removing to/from the edge of an inline node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://phabricator.wikimedia.org/T72375) (owner: 10Esanders)
[15:49:47] <grrrit-wm>	 (03PS1) 10Anomie: Only prevent default for handled keypresses [oojs/ui] - 10https://gerrit.wikimedia.org/r/196248 (https://phabricator.wikimedia.org/T92449) 
[15:51:07] <RoanKattouw>	 guillom: Sorry for the delay, I'm here now
[15:51:44] <guillom>	 RoanKattouw: No worries
[15:52:37] <James_F>	 RoanKattouw: What are you doing? You can't go around actually fixing T72375! It's months-old tradition that we don't do that now! :-)
[15:53:15] <RoanKattouw>	 haha
[15:54:27] <guillom>	 RoanKattouw: So, as you may have heard, I'm setting up a process to review a few hundred diffs of edits made with VE every week, and classify them to keep track of the number of bugs that show up ( https://phabricator.wikimedia.org/T90894 ). The results are posted on a wiki page ( https://en.wikipedia.org/wiki/User:Guillaume_(WMF)/sandbox2 for now, but later a more general VE subpage) and James_F suggested that we take a look at those 
[15:54:27] <guillom>	 together every week to see if they're already tracked in Phabricator, or if I should file new tickets. I don't expect this to take more than 5 to 10 minutes. Are you in? :) 
[15:54:48] <RoanKattouw>	 Sure
[15:54:51] <RoanKattouw>	 I did skim that earlier
[15:54:57] <RoanKattouw>	 But I'd love to go over them in a systematic fashion
[15:55:24] <guillom>	 Great; is now a good time to review yesterday's list?
[15:56:23] <RoanKattouw>	 Yeah let's do it
[15:56:38] <RoanKattouw>	 Can I skip the ones marked as OK?
[15:57:01] <guillom>	 Of course :)
[15:57:30] <wikibugs>	 10Cite, 5Patch-For-Review, 7user-notice: Highlight target references - https://phabricator.wikimedia.org/T10303#1113296 (10He7d3r)
[15:57:35] <RoanKattouw>	 OK
[15:57:43] <RoanKattouw>	 The one marked user error is very clearly indeed user error
[15:57:49] <guillom>	 yes
[15:58:06] <RoanKattouw>	 Even replacing a comment telling them not to do what they did
[15:58:11] <guillom>	 the "borderline" category is for edits that probably result from user error but could maybe have been prevented by a better UI
[15:58:12] <RoanKattouw>	 And it's in a template parameter so it's all wikitext
[15:58:19] <RoanKattouw>	 OK
[15:58:23] <RoanKattouw>	 So bad-UX-induced user error
[15:58:28] <guillom>	 (so not bugs)
[15:58:31] <guillom>	 yes
[15:58:49] <guillom>	 For https://en.wikipedia.org/w/index.php?diff=650904407 I wasn't sure
[15:58:52] <RoanKattouw>	 Re https://en.wikipedia.org/w/index.php?diff=650909605 I wonder what the template data on reflist is
[15:59:27] <RoanKattouw>	 In https://en.wikipedia.org/w/index.php?diff=650904407 there was already an image with a newline at the end of its caption
[15:59:32] <RoanKattouw>	 Oh but that was also VE-generated, never mind
[15:59:37] <RoanKattouw>	 Yeah https://en.wikipedia.org/w/index.php?diff=650904407 is probably a bug
[15:59:46] <guillom>	 ok
[15:59:48] <RoanKattouw>	 Pretty cosmetic but we or Parsoid should handle it
[15:59:55] <guillom>	 yeah, it's minor
[16:00:09] <James_F>	 RoanKattouw: We have a task already for stripping whitespace from the ends of captions.
[16:00:18] <grrrit-wm>	 (03PS3) 10Divec: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196224 (https://phabricator.wikimedia.org/T92286) 
[16:00:18] <James_F>	 RoanKattouw: I think it's blocked on sub-documents to do sanely.
[16:01:08] <RoanKattouw>	 guillom: For https://en.wikipedia.org/w/index.php?diff=650909605, I point to http://i.imgur.com/Kg6Fhjn.png
[16:01:11] <guillom>	 https://en.wikipedia.org/w/index.php?diff=650901877 is basically about adding parameters to templates even if they're not in the template's TemplateData. Not sure there's much we can do about it
[16:01:26] <RoanKattouw>	 The user pasted a youtube link in a field marked "column width"
[16:01:32] <Krenair>	 Have been wondering how https://phabricator.wikimedia.org/T58289 is supposed to look
[16:01:37] <guillom>	 Yeah. Users are stoopid. I know :D
[16:01:51] <Krenair>	 when you have non-editable content at the top of the page
[16:02:01] <guillom>	 But there's an argument to be made that users expect to be able to edit references where they are displayed
[16:02:07] <RoanKattouw>	 Yes
[16:02:10] <Krenair>	 would ve's toolbar come first, then the non-editable content greyed out?
[16:02:37] <Krenair>	 or would we replace only the editable part with the VE toolbar+surface?
[16:02:42] <RoanKattouw>	 James_F: Sounds sensible; and subdocuments would make in-reflist editing of refs easier
[16:03:02] <RoanKattouw>	 Krenair: Toolbar first, then non-editable contnet
[16:03:42] <RoanKattouw>	 guillom: Yeah for the |Father= one, maybe we should warn when users add undocumented params
[16:03:56] <RoanKattouw>	 But we can't say they don't exist, because absence of evidence isn't evidence of absence especially in this case
[16:04:00] <grrrit-wm>	 (03PS1) 10Krinkle: mw.ViewPageTarget: Hide ve-ui-surface instead of ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196250 (https://phabricator.wikimedia.org/T91442) 
[16:04:02] <grrrit-wm>	 (03PS1) 10Krinkle: mw.ViewPageTarget: Hide ve-ui-surface during activation as well. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196251 (https://phabricator.wikimedia.org/T91442) 
[16:04:14] <grrrit-wm>	 (03PS2) 10Krinkle: mw.ViewPageTarget: Hide ve-ui-surface during activation as well [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196251 (https://phabricator.wikimedia.org/T91442) 
[16:04:34] <guillom>	 RoanKattouw: agreed
[16:04:49] <grrrit-wm>	 (03PS4) 10Divec: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196224 (https://phabricator.wikimedia.org/T90478) 
[16:05:11] <guillom>	 To be fair some of those "borderline" diffs may be entirely due to the user's cluelessness, sometimes it's hard to tell
[16:05:34] <guillom>	 Stuff like https://en.wikipedia.org/w/index.php?diff=650917185 is ambiguous
[16:05:56] <guillom>	 I don't think the user meant to remove the bullets
[16:06:30] <guillom>	 But it may just be that they removed them unintentionally
[16:06:53] <RoanKattouw>	 What's wrong with https://en.wikipedia.org/w/index.php?diff=650901406 ? Residence param
[16:06:54] <RoanKattouw>	 ?
[16:07:07] <James_F>	 RoanKattouw: https://phabricator.wikimedia.org/T68736
[16:08:08] <RoanKattouw>	 guillom: Yeah maybe
[16:08:26] <guillom>	 RoanKattouw: yes, residence
[16:08:29] <RoanKattouw>	 guillom: One thing that bothers me a bit is that Ctrl+0 is mapped to "convert to paragraph"
[16:08:50] <RoanKattouw>	 While the user may expect it to be "undo the effects of Ctrl+plus/Ctrl+minus"
[16:09:36] <siddhism>	 !logs
[16:09:58] <guillom>	 RoanKattouw: Which diff are you referring to?
[16:10:05] <RoanKattouw>	 siddhism: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki-visualeditor/
[16:10:29] <RoanKattouw>	 guillom: The list item -> paragraph one
[16:10:39] <guillom>	 RoanKattouw: Ah, ok.
[16:10:46] <RoanKattouw>	 If you select the list items and press Ctrl+0, I believe you'll get that diff
[16:11:08] <guillom>	 hmm, ok. Let's table that one and we'll see if it comes up again later
[16:11:26] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: [Regression wmf18]  Deleting the text inside a bullet/numbered item, heading, other nodes throws error - https://phabricator.wikimedia.org/T90478#1113367 (10dchan) The missing slug allows the exception to occur,...
[16:11:58] <guillom>	 In https://en.wikipedia.org/w/index.php?diff=650898172 newlines were added within a bullet list. Not sure why the user would want to do that, but there again it's difficult to see what they wanted to do
[16:12:58] <RoanKattouw>	 Hmm that's splitting a list
[16:13:13] <RoanKattouw>	 What I suspect happened is they changed their mind about where to add the bullet they added
[16:13:21] <RoanKattouw>	 And in the process they split the list by pressing enter twice
[16:13:46] <RoanKattouw>	 For numbered lists, split lists are really obvious (numbering resets to 1), but for bullet lists they're easy to miss
[16:14:12] <guillom>	 could be; it's a minor issue
[16:14:22] <RoanKattouw>	 Oh hey that Ctrl+0 thing I said
[16:14:37] <RoanKattouw>	 They converted the list items to preformatted :O
[16:14:51] <RoanKattouw>	 So they would have had to use the format dropdown or press Ctrl+7
[16:15:10] <guillom>	 Well, the bullet was removed but the space after the bullet remained
[16:15:27] <guillom>	 or the shortcut, yes
[16:16:35] <RoanKattouw>	 Yeah I suppose it could be a serialization error too
[16:16:40] <RoanKattouw>	 But I've never seen that
[16:16:51] <guillom>	 I4ll see if I see other occurrences
[16:16:54] <guillom>	 I'll
[16:16:57] <guillom>	 As for https://en.wikipedia.org/w/index.php?diff=650910137, James tells me you have an open ticket for stripping whitespace at the end of links, but that it's hard to do.
[16:17:32] <guillom>	 (BEcause the link included the space, a nowiki was inserted so the link wouldn't bleed to the next word)
[16:19:43] <RoanKattouw>	 As for https://en.wikipedia.org/w/index.php?diff=650910062 , that's the same as the youtube issue (same user probably?), except that the line break between {{reflist}} and {{recycling}} was also deleted
[16:19:51] <RoanKattouw>	 guillom: Yes, that's correct
[16:20:14] <RoanKattouw>	 https://en.wikipedia.org/w/index.php?diff=650910137 is technically user error because the user selected the word plus the space
[16:20:38] <RoanKattouw>	 But it's a stretch to call that a user error when the space isn't even visibly linked
[16:20:44] <guillom>	 right
[16:20:57] <RoanKattouw>	 And when Shift+Ctrl+arrow selects trailing whitespace in some operating systems
[16:20:59] <guillom>	 RoanKattouw: Do you know the name of that bug in phabricator?
[16:21:32] <RoanKattouw>	 I believe it's https://phabricator.wikimedia.org/T39835
[16:21:48] <guillom>	 thanks
[16:22:28] <guillom>	 So the last one is https://en.wikipedia.org/w/index.php?diff=650896366 where the user removed references, but maybe they meant to do that.
[16:23:06] <RoanKattouw>	 I was about to ask about that one
[16:24:16] <guillom>	 The edit summary says "references" so clearly they intended to do *something* with them
[16:24:23] <guillom>	 but dunno what
[16:24:28] <guillom>	 Alright, I think that's it
[16:24:41] <RoanKattouw>	 OK
[16:25:14] <guillom>	 Thanks RoanKattouw :) I think it'll go faster as I become more familiar with the usual suspects
[16:25:38] <RoanKattouw>	 Cool
[16:25:43] <RoanKattouw>	 Yeah, a lot of this is experience
[16:27:49] <guillom>	 RoanKattouw: https://phabricator.wikimedia.org/T39835 seems to be about whitespace-only links, not trailing whitespaces in links. Are they the same issue?
[16:30:25] <RoanKattouw>	 guillom: You're right, I was thinking of https://phabricator.wikimedia.org/T54037
[16:30:37] <RoanKattouw>	 Which is the other one is blocked on
[16:30:48] <guillom>	 Thanks!
[16:31:17] <Krinkle>	 James_F: Wow, resources src/lib rename was in REL1_23
[16:31:19] <Krinkle>	 I'm getting old
[16:31:26] <James_F>	 Krinkle: :-)
[16:31:48] <Krinkle>	 I never thought to backport the jsduck fix for that. That explains why the post-merge job is broken
[16:31:59] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Strip annotations (e.g. bold, italics, link) from terminal whitespace - https://phabricator.wikimedia.org/T54037#1113438 (10gpaumier)
[16:37:37] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-References: [Regression wmf-20]- Internal links, when clicked in a Reference context menu does nothing. - https://phabricator.wikimedia.org/T92427#1113450 (10Swainr) Screencast-  http://youtu.be/ms70EGvd6V4
[16:41:53] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add rowspan and colspan to list of corrupted attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196202 (https://phabricator.wikimedia.org/T92488) (owner: 10Catrope)
[16:42:21] <siddhism>	 hello. i am a potential student for this year 's gsoc
[16:42:28] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 7Browser-Support-Firefox, 7Browser-Support-Internet-Explorer, and 3 others: Firefox normalizes numerical attributes with leading zeroes - https://phabricator.wikimedia.org/T92488#1113468 (10Jdforrester-WMF) 5Open>3Resolved a:3Catrope
[16:42:35] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 7Browser-Support-Firefox, 7Browser-Support-Internet-Explorer, and 3 others: Firefox normalizes numerical attributes with leading zeroes - https://phabricator.wikimedia.org/T92488#1112553 (10Jdforrester-WMF) p:5Triage>3High
[16:43:20] <siddhism>	 i am interested in Unified language proofing tools integration framework, for which visual editor specific bug is suggested as micro task
[16:43:39] <MatmaRex>	 hey
[16:45:00] <siddhism>	 will this be a good bug to start with. https://phabricator.wikimedia.org/T91847
[16:45:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add rowspan and colspan to list of corrupted attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196202 (https://phabricator.wikimedia.org/T92488) (owner: 10Catrope)
[16:47:30] <wikibugs>	 10VisualEditor, 10WikiEditor, 6Collaboration-Team, 10Flow, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1113489 (10Mattflaschen) >>! In T78346#1099845, @Pginer-WMF wrote: > For the mention dialog (check mockups below), I would recommend the...
[16:48:03] <siddhism>	 i was looking at the code. i have set up the visual editor. how do i get to the css specific to mobile
[16:48:09] <wikibugs>	 10VisualEditor, 10WikiEditor, 6Collaboration-Team, 10Flow, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1113492 (10Pginer-WMF) > - Inspector (the one you see when you click the link icon) We can start using this. I can create a mockup to ill...
[16:48:27] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References: [Regression pre-wmf21]Delete the last character after any citation and the cursor jumps to the right side of the reference editor. - https://phabricator.wikimedia.org/T92292#1113494 (10Swainr) Screencast-  http://youtu.be/yxVRLn8Xhpc
[16:50:08] <grrrit-wm>	 (03PS1) 10Alex Monk: Don't try to load edit schema if it's not installed [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/196255 
[16:50:30] <grrrit-wm>	 (03CR) 10Alex Monk: "Whoops, yes, sorry. Fixed in I0a1841ad" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk)
[17:03:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Don't try to load edit schema if it's not installed [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/196255 (owner: 10Alex Monk)
[17:03:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't try to load edit schema if it's not installed [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/196255 (owner: 10Alex Monk)
[17:05:45] <wikibugs>	 10Cite, 10Parsoid: Use CSS to style Parsoid's Cite extension output - https://phabricator.wikimedia.org/T86782#1113564 (10ssastry) >>! In T86782#1000248, @marcoil wrote: > * To ensure minimal disruption with existing HTML produced by MW, we'll change the main reference CSS class from 'reference' to 'mw-referen...
[17:10:22] <gwicke>	 James_F: got a moment to chat about the RB roll-out?
[17:13:10] <James_F>	 gwicke: Sure.
[17:14:35] <Krenair>	 Why does phabricator's scroll bar break when you've used an anchor link? :/
[17:15:01] <Krenair>	 does that happen to anyone else?
[17:15:12] <Krenair>	 i.e. https://phabricator.wikimedia.org/T91608 - scroll bar works
[17:15:15] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] "6 months and 7 days actually." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://phabricator.wikimedia.org/T72375) (owner: 10Esanders)
[17:15:23] <Krenair>	 https://phabricator.wikimedia.org/T91608#1102537 - refuses to let you scroll
[17:16:12] <MatmaRex>	 Krenair: huh. that happens to me, yes, i could never figure out why.
[17:16:25] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Deleting from an empty paragraph to the end of an inline node throws an exception - https://phabricator.wikimedia.org/T72375#1113645 (10Jdforrester-WMF) 5Open>3Resolved a:5Esanders>...
[17:16:27] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Plugins, 10VisualEditor-Tables, 7Tracking: Support tables (tracking) - https://phabricator.wikimedia.org/T41596#1113648 (10Jdforrester-WMF)
[17:16:28] <MatmaRex>	 click on the page to make it work. it's something with their custom scrollbar implementation.
[17:16:38] <Krenair>	 I would report it upstream if I didn't manage to lock myself out of that account :/
[17:16:46] <MatmaRex>	 (as in, couldn't reliably reproduce)
[17:16:49] <gwicke>	 James_F: since testing on test.wikipedia.org is looking good we are considering to roll out to the other phase0 wikis next
[17:17:23] <gwicke>	 including mw.org
[17:17:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix unbalanced transaction when removing to/from the edge of an inline node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/158662 (https://phabricator.wikimedia.org/T72375) (owner: 10Esanders)
[17:18:15] <James_F>	 gwicke: Did you fix the deletion/revdeletion issue?
[17:18:44] <gwicke>	 James_F: not yet, but it's pretty much orthogonal to VE use
[17:19:16] <gwicke>	 it's no worse than using the Parsoid caches
[17:19:25] * James_F nods.
[17:20:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-References: [Regression wmf-20]- Internal links, when clicked in a Reference context menu does nothing. - https://phabricator.wikimedia.org/T92427#1113673 (10Etonkovidova) p:5Triage>3High
[17:21:15] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/196250/ and child probably want back-porting.
[17:21:33] <gwicke>	 James_F: I'm not too keen on changing stuff tomorrow, so it's basically either today or Monday
[17:21:50] <James_F>	 gwicke: Did you want to expand to phase0?
[17:22:05] <gwicke>	 James_F: yes
[17:22:10] <James_F>	 gwicke: Go for it.
[17:22:25] <grrrit-wm>	 (03PS2) 10Gerrit Patch Uploader: Use background-image instead of <img> for toolbar icons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186639 
[17:22:28] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186639 (owner: 10Gerrit Patch Uploader)
[17:22:38] <gwicke>	 James_F: ok
[17:23:31] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] mw.ViewPageTarget: Hide ve-ui-surface instead of ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196250 (https://phabricator.wikimedia.org/T91442) (owner: 10Krinkle)
[17:23:52] <MatmaRex>	 Krenair: locked out? D:
[17:24:03] <MatmaRex>	 Krenair: /phabricator/webroot/rsrc/js/core/behavior-watch-anchor.js looks fishy to me.
[17:24:11] <Krenair>	 yeah, I can't get into my secure.phabricator.com account anymore
[17:24:17] <MatmaRex>	 (and /phabricator/webroot/rsrc/externals/javelin/lib/Scrollbar.js of course)
[17:24:47] <Krenair>	 had 2 factor, then my device broke. phabricator does not provide reset tokens
[17:24:52] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] mw.ViewPageTarget: Hide ve-ui-surface during activation as well [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196251 (https://phabricator.wikimedia.org/T91442) (owner: 10Krinkle)
[17:25:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.ViewPageTarget: Hide ve-ui-surface instead of ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196250 (https://phabricator.wikimedia.org/T91442) (owner: 10Krinkle)
[17:25:53] <grrrit-wm>	 (03PS1) 10Jforrester: mw.ViewPageTarget: Hide ve-ui-surface instead of ve-ce-surface [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196269 (https://phabricator.wikimedia.org/T91442) 
[17:26:15] <wikibugs>	 10VisualEditor, 10Continuous-Integration, 7Tracking, 3VisualEditor 2014/15 Q3 blockers: Browser disconnects when running QUnit tests with local browsers (tracking) - https://phabricator.wikimedia.org/T89075#1113700 (10Krinkle)
[17:26:25] <James_F>	 edsanders: +2 https://gerrit.wikimedia.org/r/196269 please?
[17:26:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.ViewPageTarget: Hide ve-ui-surface during activation as well [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196251 (https://phabricator.wikimedia.org/T91442) (owner: 10Krinkle)
[17:29:10] <Krinkle>	 James_F: Attending to https://phabricator.wikimedia.org/T91715 now given that ci is blocked on mmcore for now.
[17:29:21] <James_F>	 Krinkle: Good.
[17:29:25] <James_F>	 Oh, yes, that reminds me.
[17:30:04] <wikibugs>	 10VisualEditor, 10Continuous-Integration, 10Flow, 6Mobile-Web, 10Wikimedia-Hackathon-2015: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1113707 (10Jdforrester-WMF) p:5Triage>3Normal
[17:30:25] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 10Parsoid: Parsoid should return the full srcset for high DPI devices - https://phabricator.wikimedia.org/T88827#1113708 (10Jdforrester-WMF) p:5Triage>3Normal
[17:30:36] <wikibugs>	 10VisualEditor, 6Release-Engineering, 7Browser-Tests: Create VisualEditor tests targeting the older version of browsers (Chrome and Firefox for now) for better backward compatibility - https://phabricator.wikimedia.org/T90678#1113710 (10Jdforrester-WMF) p:5Triage>3High
[17:30:45] <wikibugs>	 10VisualEditor, 6Release-Engineering, 7Browser-Tests: Selenium bug with Firefox causes VE test failure - https://phabricator.wikimedia.org/T90651#1113712 (10Jdforrester-WMF) p:5Triage>3High
[17:30:48] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1113715 (10wctaiwan) I think the new border introduced in https://gerrit.wikimedia.org/r/#/c/162153/ is a bit too thick. to the point of being slightly jarring.
[17:31:53] <grrrit-wm>	 (03PS1) 10Mooeypoo: Remove MWTransclusionMetaNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 
[17:32:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove MWTransclusionMetaNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 (owner: 10Mooeypoo)
[17:32:38] <mooeypoo>	 btw Krinkle this is the fix to the commit that was merged while you were reviewing it... if you could take a quick look, that'll be good. https://gerrit.wikimedia.org/r/#/c/195960/
[17:32:47] <grrrit-wm>	 (03CR) 10Jforrester: "No tests? Tsk." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 (owner: 10Mooeypoo)
[17:32:48] <wikibugs>	 10VisualEditor, 6Release-Engineering, 7Browser-Tests: Selenium bug with Firefox causes VE test failure - https://phabricator.wikimedia.org/T90651#1113724 (10Cmcmahon) Note that I removed the "&" from the string with this commit: https://gerrit.wikimedia.org/r/#/c/195683
[17:35:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove MWTransclusionMetaNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 (owner: 10Mooeypoo)
[17:36:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Apple-Safari: Displaytitle can't be selected until you have typed something or made other changes in Safari - https://phabricator.wikimedia.org/T89617#1113733 (10Jdforrester-WMF) 5Open>3Resolved a:3matmarex
[17:36:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Apple-Safari: Displaytitle can't be selected until you have typed something or made other changes in Safari - https://phabricator.wikimedia.org/T89617#1040544 (10Jdforrester-WMF) Fixed when we fixed the other Safari checkbox issue.
[17:36:48] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Using data URI images in inline slugs (for chimeras) is slow in Chrome (and possibly others) - https://phabricator.wikimedia.org/T91248#1113738 (10Jdforrester-WMF) a:3Catrope
[17:37:21] <MatmaRex>	 Krenair: are you using that CSS hack to kill the custom scrollbar?
[17:37:50] <Krenair>	 no
[17:38:54] <MatmaRex>	 hmm. i am. the code path with custom scrollbar has this:
[17:38:56] <MatmaRex>	 "If nothing is focused, or the document body is focused, change focus
[17:38:56] <MatmaRex>	 to the viewport. This makes the arrow keys, spacebar, and page
[17:38:57] <MatmaRex>	 up/page down keys work immediately after the page loads, without
[17:38:57] <MatmaRex>	 requiring a click."
[17:39:05] <grrrit-wm>	 (03CR) 10Prtksxna: MediaWiki Theme: textInputWidget: Update focus state (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/196213 (https://phabricator.wikimedia.org/T73150) (owner: 10Prtksxna)
[17:39:11] <MatmaRex>	 and then some crazy code
[17:39:46] <James_F>	 MatmaRex: So, the most valuable thing to work on would be https://phabricator.wikimedia.org/T91349 then https://phabricator.wikimedia.org/T91600 and finally maybe https://phabricator.wikimedia.org/T71727 and 
[17:39:50] <MatmaRex>	 ugly stuff, not gonna dig deeper. it's not annoying me enough.
[17:39:59] <James_F>	 https://phabricator.wikimedia.org/T90896
[17:40:00] <James_F>	 Bah.
[17:40:10] <James_F>	 MatmaRex: Enough?
[17:41:01] <MatmaRex>	 quite. will look.
[17:43:13] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Deleting through a list throws an exception - https://phabricator.wikimedia.org/T92286#1113764 (10Jdforrester-WMF) p:5Triage>3High
[17:43:44] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown: Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1113766 (10EBernhardson)
[17:44:05] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown: Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1096593 (10EBernhardson) Implement some sort of plugability that allows Flow to integrate into the core js
[17:44:19] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown: Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1113772 (10EBernhardson) p:5Triage>3Normal
[17:44:20] <wikibugs>	 10VisualEditor: Comment body in context showing a scrollbar - https://phabricator.wikimedia.org/T92450#1113775 (10Jdforrester-WMF) p:5Triage>3Normal
[17:44:29] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown, 3Collaboration-Team-Sprint-S-2015-03-25: Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1096593 (10EBernhardson)
[17:45:36] <grrrit-wm>	 (03PS2) 10Jforrester: mw.ViewPageTarget: Hide ve-ui-surface instead of ve-ce-surface [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196269 (https://phabricator.wikimedia.org/T91442) 
[17:47:49] <mooeypoo>	 RoanKattouw, I'm getting a bit lost with those MWTransclusionMeta tests
[17:48:48] <mooeypoo>	 I was thinking of changing them to display inline transclusion node, but what it expects is a little weird with [Object object] outputs and such. Should I change this test to display inline nodes, or delete it completely since we removed the meta transclusion node?
[17:49:11] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 3VisualEditor 2014/15 Q3 blockers: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1113799 (10Catrope) To possibly make this even worse: we probably want this list to be shared between VE **core*...
[17:49:26] <RoanKattouw>	 mooeypoo: So yeah the Jenkins/Karma output for unit tests is useless
[17:49:42] <RoanKattouw>	 mooeypoo: You should instead run the unit tests in your browser, that'll give you a sensible diff between actual and expected
[17:49:50] <mooeypoo>	 RoanKattouw, I'm going over the /Special:JavaScriptTest/qunit
[17:49:51] <RoanKattouw>	 mooeypoo: [[Special:JavaScriptTest/qunit]]
[17:49:55] <mooeypoo>	 RoanKattouw, I am
[17:50:57] <mooeypoo>	 I  can take what I see in result and put it in "expected" as it *seems* reasonable to me, but I am not entirely sure how to actually create a sensible node with all that data. 
[17:51:11] <mooeypoo>	 especially since some of those have [object Object] outputs
[17:51:48] <grrrit-wm>	 (03CR) 10Krinkle: "I guess there are tests :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 (owner: 10Mooeypoo)
[17:52:04] <RoanKattouw>	 mooeypoo: Can you send me a screenshot of what you get?
[17:52:25] <James_F>	 RoanKattouw: Can you +2 https://gerrit.wikimedia.org/r/#/c/196269/ so I can do the other one?
[17:52:26] <RoanKattouw>	 Yeah Special:JavaScriptTest is also unhelpful in that it still gives you [Object object] garbage, just slightly deeper
[17:52:48] <mooeypoo>	 will do hang on
[17:52:49] <Krinkle>	 mooeypoo: Look at jenkins /mwext-VisualEditor-qunit instead of mwext-VisualEditor-qunit-karma
[17:52:55] <Krinkle>	 mwext-VisualEditor-qunit-karma is non-voting and not yet working
[17:53:28] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: Hide ve-ui-surface instead of ve-ce-surface [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196269 (https://phabricator.wikimedia.org/T91442) (owner: 10Jforrester)
[17:53:55] <RoanKattouw>	 Krinkle: But Karma works in VE core and gives unhelpful output there already
[17:54:04] <Krinkle>	 Yeah
[17:54:07] <RoanKattouw>	 On top of that, QUnit also doesn't provide full depth even in the browser
[17:54:08] <Krinkle>	 I filed it upstream
[17:54:11] <RoanKattouw>	 This used to work in the past
[17:54:14] <Krinkle>	 The error shown I get is:
[17:54:14] <Krinkle>	 00:04:14.357 >> Error: Unknown node type: mwTransclusionMeta 
[17:54:22] <RoanKattouw>	 hah OK well yeah
[17:54:25] <mooeypoo>	 sure, that's understandable
[17:54:29] <Krinkle>	 00:04:14.358 >> ve.dm.Converter (MW) - getDomFromModel 
[17:54:36] <mooeypoo>	 but I'm not sure how to create a sensible expected value
[17:54:39] <RoanKattouw>	 Trying to construct transclusion meta nodes will crash, that's fair
[17:54:45] <Krinkle>	 Looking up that test in the repo should explain itself. I don't usually look at the output at all.
[17:54:57] <mooeypoo>	 also I'm getting quite a lot of failures that have nothig to do with my patch
[17:55:10] <mooeypoo>	 like type: /table -> type: /mwTable
[17:55:17] <mooeypoo>	 I'm taking a full screenshot, hang on
[17:55:37] <Krinkle>	 "Subscribe" on https://github.com/karma-runner/karma-qunit/issues/24 :)
[17:56:53] <RoanKattouw>	 mooeypoo: So one thing you can do is doc = ve.dm.converter.getModelFromDom( ve.createDocumentFromHtml( '<body>' + ve.dm.mwExample.MWTransclusion.meta + '</body>' ); and look at doc.data.data
[17:57:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.ViewPageTarget: Hide ve-ui-surface instead of ve-ce-surface [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196269 (https://phabricator.wikimedia.org/T91442) (owner: 10Jforrester)
[17:59:12] <grrrit-wm>	 (03Abandoned) 10Jforrester: Clean up unnecessary hack for Citoid tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196079 (owner: 10Mooeypoo)
[17:59:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: No longer possible to convert an auto-numbered link to one with a label - https://phabricator.wikimedia.org/T92525#1113837 (10matmarex) 3NEW
[17:59:28] <mooeypoo>	 RoanKattouw, http://awesomescreenshot.com/0864m1al8b
[17:59:30] <grrrit-wm>	 (03PS1) 10Jforrester: mw.ViewPageTarget: Hide ve-ui-surface during activation as well [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196280 (https://phabricator.wikimedia.org/T91442) 
[17:59:40] <James_F>	 RoanKattouw: and https://gerrit.wikimedia.org/r/#/c/196280/ ? :-)
[17:59:46] <mooeypoo>	 err damnit it took the wrong part
[18:01:11] <grrrit-wm>	 (03CR) 10Catrope: "This hack doesn't do what you think it does." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196079 (owner: 10Mooeypoo)
[18:01:29] <James_F>	 RoanKattouw: Yeah, that's why I abandoned it after explaining.
[18:01:34] <RoanKattouw>	 Oh hah James_F abandoned it, that's why my -2 didn't take
[18:01:50] <mooeypoo>	 RoanKattouw, there we go, that's the right piece: http://awesomescreenshot.com/0254m1b621
[18:01:50] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, and 4 others: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1113860 (10gpaumier)
[18:02:01] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Tag v0.9.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/196120 (owner: 10Jforrester)
[18:02:33] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] MediaWiki Theme: textInputWidget: Update focus state [oojs/ui] - 10https://gerrit.wikimedia.org/r/196213 (https://phabricator.wikimedia.org/T73150) (owner: 10Prtksxna)
[18:02:45] <RoanKattouw>	 mooeypoo: That output looks right to me
[18:02:50] <RoanKattouw>	 mooeypoo: And it's not hard to reconstruct either
[18:02:50] <mooeypoo>	 RoanKattouw, " Catrope: "This hack doesn't do what you think it does."" <-- this should go with the meme
[18:03:05] <RoanKattouw>	 There's only one [Object object] and you can derive what's in there from the JSON blob in originalMw
[18:03:08] <mooeypoo>	 RoanKattouw, the result, yes, but what do I do with the object Object
[18:03:24] <RoanKattouw>	 It would have looked cooler with the bolded red C: -2 alongside
[18:03:41] <mooeypoo>	 oh hm i see
[18:03:42] <grrrit-wm>	 (03CR) 10Jforrester: "Killed so I can rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/196120 (owner: 10Jforrester)
[18:03:51] <mooeypoo>	 ok I'll give it another try with the parts
[18:04:12] <mooeypoo>	 also, i have about 7 pages of failures
[18:04:19] <mooeypoo>	 for RANDOM crap like mwTable
[18:04:22] <mooeypoo>	 and mwHeading
[18:04:26] <mooeypoo>	 how is that possible ? :\
[18:04:46] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Only prevent default for handled keypresses [oojs/ui] - 10https://gerrit.wikimedia.org/r/196248 (https://phabricator.wikimedia.org/T92449) (owner: 10Anomie)
[18:04:52] <RoanKattouw>	 If you run the tests with ?debug=true, does that make it better?
[18:05:02] <RoanKattouw>	 Also you're running them in Chrome, right, not Firefox?
[18:05:08] <mooeypoo>	 chrome, yeah
[18:05:21] <mooeypoo>	 my wiki is always debug=true
[18:05:30] <RoanKattouw>	 (The tests have been broken in Firefox for years, just today Ed started submitting a few patches to fix Firefox test failures)
[18:05:33] <RoanKattouw>	 hah, weird
[18:05:46] <mooeypoo>	 IU have really WEIRD failures, too
[18:05:48] <RoanKattouw>	 I don't know why the mwTable stuff happens but it's almost certainly nothing to do with your patch
[18:05:58] <mooeypoo>	 expected type: table -> result type: mwTable
[18:06:05] <mooeypoo>	 that doesn't look like a browser specific bug..
[18:06:32] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] InputWidget: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196127 (owner: 10Kmenger)
[18:06:34] <mooeypoo>	 okay, I"ll fix my own thing and see if it passes, but these failures are weird
[18:07:09] <RoanKattouw>	 Yeah I don't know why that would happen
[18:07:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: MediaWiki Theme: textInputWidget: Update focus state [oojs/ui] - 10https://gerrit.wikimedia.org/r/196213 (https://phabricator.wikimedia.org/T73150) (owner: 10Prtksxna)
[18:07:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only prevent default for handled keypresses [oojs/ui] - 10https://gerrit.wikimedia.org/r/196248 (https://phabricator.wikimedia.org/T92449) (owner: 10Anomie)
[18:07:43] <mooeypoo>	 and how were they not caught by jenkins?
[18:08:02] <mooeypoo>	 ... anyways, i don't know what's going on but it's odd. I'll fix the meta stuff and see if we can spot the test weirdness
[18:09:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: InputWidget: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/196127 (owner: 10Kmenger)
[18:09:21] <grrrit-wm>	 (03PS3) 10Catrope: Only call execCommand() on the surface in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) 
[18:09:36] <RoanKattouw>	 mooeypoo: It's probably something just on your machine. Is your submodule up-to-date?
[18:10:16] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Move selection sub-classes to sub-folder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196214 (owner: 10Esanders)
[18:10:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Convert spaces to tab indentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196215 (owner: 10Esanders)
[18:11:39] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add merged cells table to converter examples [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196216 (owner: 10Esanders)
[18:12:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move selection sub-classes to sub-folder [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196214 (owner: 10Esanders)
[18:12:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Convert spaces to tab indentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196215 (owner: 10Esanders)
[18:13:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add merged cells table to converter examples [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196216 (owner: 10Esanders)
[18:13:50] <James_F>	 RoanKattouw: Gah.
[18:13:52] <James_F>	 "POST https://www.mediawiki.org/w/api.php 503 (Service Unavailable)"
[18:16:09] <TrevorParscal>	 MatmaRex: so, we need to do an audit on OOjs UI
[18:16:23] <TrevorParscal>	 and probably also VisualEditor core and the VisualEditor extension
[18:16:57] <TrevorParscal>	 has to do with mixins that inherit
[18:17:14] <TrevorParscal>	 we need to only allow mixins to mixin other other classes, not inherit
[18:17:26] <TrevorParscal>	 because the inherited properties/methods don't get copied
[18:17:57] <wikibugs>	 10VisualEditor: Fix styling inconsistencies between context item and inspector - https://phabricator.wikimedia.org/T90896#1113909 (10Rits) hello, i wanted to work on this bug, please explain it further for the starting pointers, thanks
[18:17:58] <TrevorParscal>	 this usually presents with mysteriously missing methods and properties
[18:18:15] <MatmaRex>	 GroupWidget and ItemWidget, for starters. (and actually that might be all)
[18:18:23] <TrevorParscal>	 and is often "fixed" by mixing in the mixin and it's parent classes
[18:18:44] <James_F>	 ryasmeen: https://meta.wikimedia.org/wiki/Tech/News/2015/12
[18:18:47] <MatmaRex>	 yep
[18:19:01] <ryasmeen>	 yeah thanks James_F
[18:19:40] <TrevorParscal>	 so if b inherits a and c mixes in b, c only had b's own props copied and has no access to a's props - but if b mixes in a, and c mixes in b, then c has all of a's and b's own props
[18:19:55] <TrevorParscal>	 this may or may not also exist in VisualEditor somewhere
[18:20:50] <TrevorParscal>	 we need a list of classes being mixed in, and then need to go verify they are using mixinClass or initClass, not inheritClass
[18:21:21] <RoanKattouw>	 I can almost guarantee you there's at least one such case hiding in a corner somewhere
[18:23:52] <grrrit-wm>	 (03PS1) 10Krinkle: Fix "Error /styles/widgets/images/broken-image.png 404 (Not Found)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196289 
[18:24:05] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release: Various widgets refuse to tab to other widgets - https://phabricator.wikimedia.org/T92449#1113943 (10Jdforrester-WMF) a:3Anomie
[18:24:39] <TrevorParscal>	 Krinkle: maybe we can also add a check in OOjs core, so when a class is being mixed in, if it's prototype isn't falling through to Object than something is probably wrong
[18:25:32] <Krinkle>	 TrevorParscal: I think we've discussed this befor
[18:25:35] <Krinkle>	 TrevorParscal: What's the case again?
[18:26:10] <Krinkle>	 TrevorParscal: How can a prototype not fall through to Object?
[18:26:18] <Krinkle>	 (aside from ES5 null objects)
[18:30:54] <mooeypoo>	 RoanKattouw, in the test 'expected' section, the code does: domElements: $( ve.dm.mwExample.MWTransclusion.meta ).toArray() --> what I am confused about is where do I take the *actual* info so I can have all the mw: and parts, etc
[18:31:32] <RoanKattouw>	 mooeypoo: You should replace the expected stuff from the test with the "actual" from the test result
[18:31:50] <RoanKattouw>	 The domElements: thing is inside an object (attributes:) that's inside an object that's inside that array that you should be modifying
[18:32:06] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: ve.ui.MWLinkNodeInspector: Restore action buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196291 (https://phabricator.wikimedia.org/T92525) 
[18:32:06] <mooeypoo>	 so not use the object again, just hard-code the expected result?
[18:32:08] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Remove unused ve.ui.*Inspector.static.removable = false; [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196292 
[18:35:46] <RoanKattouw>	 mooeypoo: Yeah pretty much
[18:36:05] <RoanKattouw>	 Normal transclusion nodes don't have a domElements property storing the original DOM
[18:36:18] <RoanKattouw>	 Transclusion metas did, for no particularly good reason since originalDomElements exists as a core feature now
[18:36:28] <mooeypoo>	 okay
[18:37:38] <James_F>	 Krinkle: Re. https://gerrit.wikimedia.org/r/#/c/196289/ where is it used?
[18:39:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References: Have the References list tool insert a general references list (99% action), rather than stopping to ask the user about which group to use - https://phabricator.wikimedia.org/T71727#1114040 (10matmarex) a:3matmarex
[18:40:08] <grrrit-wm>	 (03PS4) 10Esanders: core: Provide OO.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 
[18:40:21] <TrevorParscal>	 Krinkle: i'm talking about mixins
[18:40:33] <TrevorParscal>	 if a mixin uses prototypal inheritance, it causes a problem
[18:40:44] <TrevorParscal>	 because we only copy own props (for good reason)
[18:40:53] <TrevorParscal>	 that make sense?
[18:42:10] <TrevorParscal>	 I'm suggesting we may be able to detect when this is being done (mixing in a class that uses prototypal inheritance) and throw an exception
[18:42:17] <TrevorParscal>	 maybe not in v1, but in v2 perhaps?
[18:42:32] <TrevorParscal>	 James_F: that image was used by the media inspector of yesteryear
[18:42:48] <TrevorParscal>	 if it's not being used anymore (when images fail to load) then we can ditch it
[18:43:47] <James_F>	 Possibly. mooeypoo
[18:43:49] <James_F>	 ?
[18:44:13] <mooeypoo>	 what?
[18:44:24] <Krinkle>	 TrevorParscal: Right. You mean requiring mixins to be plain objects
[18:44:40] <TrevorParscal>	 right
[18:44:41] <Krinkle>	 Yeah, that makes sense
[18:44:41] <James_F>	 mooeypoo: https://gerrit.wikimedia.org/r/#/c/196289/
[18:44:48] <Krinkle>	 TrevorParscal: File a task?
[18:44:52] <TrevorParscal>	 sure
[18:45:15] <Krinkle>	 James_F: It is used when you search for something and the thumbnail is broken.. Either because SVG not being installed or because Commons has a partial outage :P
[18:45:23] <James_F>	 Krinkle: Ha. OK.
[18:45:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix "Error /styles/widgets/images/broken-image.png 404 (Not Found)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196289 (owner: 10Krinkle)
[18:45:31] <Krinkle>	 James_F: e.g. when the image thumbnail returns plain text instead of an image
[18:45:51] <mooeypoo>	 I don't think it's used. Where would it be used? We have an issue with broken images in general (they vanish from the page)
[18:45:54] <Krinkle>	 James_F: In my testing locally I got plain text 'HEaders already sent" which is not a real image. It was only happening for one image because we have good caching 
[18:46:08] <mooeypoo>	 we *should* have a broken image and a way to display it when images are broken, but for the moment we don't
[18:46:33] <Krinkle>	 It is used whenever a thumbnail url fails to load. Either because of time out or because of the image being too big, or if the thumbnail scaler failed. Lots of scenarios. In that case it triggers on('error') and we don't show it
[18:46:46] <Krinkle>	 and instead show our own instead of the browser's default "broken image" image
[18:46:46] <mooeypoo>	 But it's not ...
[18:46:51] <Krinkle>	 but now the broken image image was broken.
[18:46:55] <Krinkle>	 :P
[18:47:06] <TrevorParscal>	 I also added a hint about this to: https://www.mediawiki.org/w/index.php?title=OOjs/Inheritance
[18:47:20] <mooeypoo>	 Neither the browser's nor our own image shows if the image can't be loaded
[18:47:22] <Krinkle>	 mooeypoo: It was definitely being shown.
[18:47:22] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 7Design: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1114080 (10Jdforrester-WMF) 5Open>3Resolved
[18:47:23] <wikibugs>	 10OOjs: Require classes being mixed in to be plain objects - https://phabricator.wikimedia.org/T92540#1114083 (10TrevorParscal) 3NEW a:3Krinkle
[18:47:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix "Error /styles/widgets/images/broken-image.png 404 (Not Found)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196289 (owner: 10Krinkle)
[18:47:50] <mooeypoo>	 Krinkle, kill your internet connection and edit a page with red linked images (or with images that were there before, but without internet connection)
[18:47:55] <mooeypoo>	 result = all images VANISH.
[18:47:57] <mooeypoo>	 no broken image
[18:48:00] <mooeypoo>	 just no image
[18:48:10] <mooeypoo>	 it's a big bug we have about red link images too
[18:49:19] <Krinkle>	 mooeypoo: http://i.imgur.com/uCMth4t.png
[18:49:38] <Krinkle>	 We add class thumbnail-error and add a background image of our own
[18:49:43] <grrrit-wm>	 (03PS2) 10Jforrester: Tag v0.9.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/196120 
[18:50:24] <grrrit-wm>	 (03PS1) 10Legoktm: Remove U+FEFF before opening <?php tag [extensions/Math] - 10https://gerrit.wikimedia.org/r/196297 
[18:50:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove U+FEFF before opening <?php tag [extensions/Math] - 10https://gerrit.wikimedia.org/r/196297 (owner: 10Legoktm)
[18:51:25] <Krinkle>	 mooeypoo: when fixed, it shows our broken-image icon centred in the thumbnail area
[18:51:32] <Krinkle>	 it's not much, but it's something
[18:51:35] <grrrit-wm>	 (03CR) 10Kaldari: "@TrevorParscal: This change breaks the OOjs UI demo page ("Demo styles failed to load.")" [oojs/ui] - 10https://gerrit.wikimedia.org/r/188289 (owner: 10Jforrester)
[18:51:36] <TrevorParscal>	 it's an easter egg
[18:51:39] <TrevorParscal>	 it's netscape style
[18:51:46] <grrrit-wm>	 (03PS3) 10Jforrester: Tag v0.9.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/196120 
[18:51:57] <mooeypoo>	 oh *that* broken image
[18:52:14] <mooeypoo>	 well it will show an empty image atm
[18:52:18] <grrrit-wm>	 (03CR) 10Mvolz: "This should be merged now that localsettings is in puppet (as well as changes that remove the deploy directory, although less critical)." [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195912 (owner: 10Mvolz)
[18:52:25] <mooeypoo>	 but the "broken image" won't show in VE itself, int he content editable
[18:52:31] <mooeypoo>	 which is a huge bug, but apparently unrelated to this
[18:52:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove U+FEFF before opening <?php tag [extensions/Math] - 10https://gerrit.wikimedia.org/r/196297 (owner: 10Legoktm)
[18:53:15] <grrrit-wm>	 (03Abandoned) 10Mvolz: Configure citoid to use the new zotero service [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195333 (https://phabricator.wikimedia.org/T89873) (owner: 10Alexandros Kosiaris)
[18:53:44] <Krinkle>	 James_F: I'd like to propose we do minor editing of Release notes for OOjs UI. Making it a little bit more useful. Basically, in addition to hoisting breaking changes: Alphabetise the rest. Normalise any different component prefixes that should be the same, and remove noise of changes that are not consumer-facing.
[18:53:56] <Krinkle>	 We already have a git log if thats all it it.
[18:56:08] <James_F>	 Krinkle: Everything other than component name normalisation can be done automatically.
[18:58:09] <Krinkle>	 James_F: Yeah. If there are changes that don't make sense when alphabetised (e.g. do, undo, redo) then those can be removed anyway. We could blacklist certain components that are uninteresting.
[19:02:18] <spagewmf>	 MatmaRex, James_F : congratulations on http://localhost/projects/oojs/ui/demos/#icons-mediawiki-vector-ltr !  I mentioned it on the Wikifont/Wikicons page. Is there a task to have the demos deployed somewhere?
[19:03:12] <MatmaRex>	 spagewmf: there is a demo page on tool tabs, https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/
[19:04:57] <James_F>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/196120/ *cough*
[19:04:59] <mooeypoo>	 omg this is insane. RoanKattouw the "ve.dm.Converter (MW): getDomFromModel" is driving me crazy. It seems to expect the result span to have ' data-ve-no-generated-contents="true"'. I add that in, and now it fails because another part of the same test needs it.
[19:05:12] <mooeypoo>	 needs it out, i mean.
[19:05:13] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Tag v0.9.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/196120 (owner: 10Jforrester)
[19:05:16] <mooeypoo>	 this is frustrating
[19:05:54] <TrevorParscal>	 spagewmf: yeah, I think it will be deployed shortly
[19:05:55] <RoanKattouw>	 Oh, crap, right, sorry
[19:06:07] <mooeypoo>	 ...
[19:06:09] <TrevorParscal>	 spagewmf: now the long and difficult process of making the icons suck less
[19:06:15] <spagewmf>	 MatmaRex, TrevorParscal : thanks.  FYI werdna and prtksxna's living style guide will have a similar iconography page, but with guidance. 
[19:06:28] <spagewmf>	 https://phabricator.wikimedia.org/T77940
[19:06:30] <wikibugs>	 10VisualEditor, 7Verified-in-Phase0, 7Verified-in-Phase2, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-04_(1.25wmf20): [Regression pre-wmf20] Reference and Media caption surfaces have broken layout - https://phabricator.wikimedia.org/T91145#1114191 (10Ryasmeen)
[19:06:34] <RoanKattouw>	 mooeypoo: For the body: property, use the version without data-ve-no-generated-contents
[19:06:50] <RoanKattouw>	 mooeypoo: Then add a clipboardBody: property with the same HTML but with data-ve-no-generated-contents
[19:06:51] <mooeypoo>	 RoanKattouw, where do I set that up!? I only have one place :((
[19:06:58] <mooeypoo>	 oh
[19:07:00] <mooeypoo>	 gaaah
[19:07:26] <mooeypoo>	 RoanKattouw, the tests read the html from ve.dm.mwExample.MWTransclusion object 'meta'
[19:07:31] <RoanKattouw>	 Don't worry, in addition to body and clipboardBody we also have normalizedBody and froomDataBody :P
[19:07:40] <RoanKattouw>	 mooeypoo: Oh OK then add a clipboard version there
[19:07:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tag v0.9.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/196120 (owner: 10Jforrester)
[19:07:42] <mooeypoo>	 I don't understand what to add; they both read the same
[19:07:52] <RoanKattouw>	 Similar to inlineOpenClipboard for instance
[19:07:59] <mooeypoo>	 ok
[19:08:26] <wikibugs>	 10OOjs-UI, 10OOjs-UI-0.8.2, 10VisualEditor, 7Browser-test-bug, and 4 others: [Regression pre-wmf20] Dialogs broken on master - https://phabricator.wikimedia.org/T90858#1114202 (10Ryasmeen)
[19:08:48] <mooeypoo>	 RoanKattouw, okay. Now how do I separate those two tests?
[19:09:16] <mooeypoo>	 add clipboardBody
[19:09:21] <mooeypoo>	 i think... i found it .
[19:09:23] <mooeypoo>	 aaah
[19:10:05] <James_F>	 TrevorParscal: https://phabricator.wikimedia.org/maniphest/query/Bl8AwbZzeyEh/#R
[19:10:14] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-Tables, 7Verified-in-Phase0, and 4 others: [Regression wmf20] Table gets broken while changing the cell type after a merge cell operation - https://phabricator.wikimedia.org/T91831#1114212 (10Ryasmeen)
[19:10:23] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-References: [Regression wmf20] Internal links, when clicked in a Reference context menu does nothing. - https://phabricator.wikimedia.org/T92427#1114213 (10Jdforrester-WMF)
[19:11:30] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.9.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196305 
[19:12:21] <mooeypoo>	 OMG, I did it
[19:12:37] <mooeypoo>	 My eyes are bleeding
[19:12:56] <grrrit-wm>	 (03PS2) 10Mooeypoo: Remove MWTransclusionMetaNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 
[19:13:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: Don't show redlinks as existing links if MediaWiki didn't tell us one way or the other - https://phabricator.wikimedia.org/T91299#1114236 (10Ryasmeen)
[19:13:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.9.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196305 (owner: 10Jforrester)
[19:14:09] * mooeypoo stares at jenkins
[19:15:03] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 7Verified-in-Phase2, and 3 others: Adjust the context menu to be able to display richer data for tools that want it - https://phabricator.wikimedia.org/T89054#1114241 (10Ryasmeen)
[19:15:57] <wikibugs>	 10VisualEditor, 10Citoid, 6operations, 3VisualEditor 2014/15 Q3 blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1114251 (10mobrovac)
[19:16:06] <mooeypoo>	 IT PASSSSSED!
[19:16:51] <wikibugs>	 10VisualEditor, 10Citoid, 6operations, 3VisualEditor 2014/15 Q3 blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1055318 (10mobrovac)
[19:16:59] <RoanKattouw>	 mooeypoo: SWEET
[19:17:04] <TrevorParscal>	 MatmaRex: I'm talking to James_F about whether to use RLIM for the new icons in the MW pull through of the latest OOjs UI release
[19:17:06] <TrevorParscal>	 thoughts?
[19:17:13] <mooeypoo>	 RoanKattouw, especially sweet for my computer. I was about to toss it out a window.
[19:17:18] <RoanKattouw>	 mooeypoo: You wrote your first DM unit test, well done
[19:17:30] <mooeypoo>	 yaaay....
[19:17:48] <mooeypoo>	 That was whack. But I think at least I get how it works now.
[19:18:03] <MatmaRex>	 TrevorParscal: hmm
[19:18:32] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Deleting through a list throws an exception - https://phabricator.wikimedia.org/T92286#1114286 (10Jdforrester-WMF)
[19:19:03] <James_F>	 mooeypoo: "Works".
[19:19:04] <MatmaRex>	 TrevorParscal: yeah, we probably could
[19:19:11] <James_F>	 MatmaRex: Could or should?
[19:19:39] <MatmaRex>	 definitely could, i'm considering if should
[19:20:01] <MatmaRex>	 right now i don't remember what the state of RTL support in it is
[19:20:30] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 7Verified-in-Phase0, and 3 others: [Regression pre-wmf20] Link inspector opening in wrong position when selection is at the start of a line - https://phabricator.wikimedia.org/T91307#1114288 (10Ryasmeen)
[19:20:30] <James_F>	 RoanKattouw: How messy is it to revert a change in wmf21 for wmf21 only (i.e. not revert in master, let it ride for wmf22)?
[19:20:35] <MatmaRex>	 and i don't think it was tested with a icon set this big
[19:20:52] <James_F>	 MatmaRex: We could do it directly for now, and then do it later?
[19:20:53] <MatmaRex>	 ah, no, nevermind, we're splitting it
[19:20:57] <RoanKattouw>	 mooeypoo: So a couple weeks ago I spent 3 days updating/fixing failing DM tests after making a DM change that changed how every single linear model element was represented
[19:20:58] <MatmaRex>	 yeah
[19:21:08] <MatmaRex>	 we definitely can just use the "mixed" distribution now
[19:21:19] <RoanKattouw>	 James_F: Thanks to the latter part (willingness to let it ride with wmf22), not messy at all
[19:21:21] <MatmaRex>	 and them seamlessly switch each icon module to using RLImageModule
[19:21:43] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10Citoid, 7Design, and 5 others: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - https://phabricator.wikimedia.org/T71474#1114293 (10Ryasmeen)
[19:21:56] <RoanKattouw>	 James_F: git checkout wmf/1.25wmf21 ; git revert hashOfCommit; git review;
[19:22:35] <James_F>	 RoanKattouw: That's it? OK.
[19:22:36] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables, 7Verified-in-Phase0, 7Verified-in-Phase2, and 3 others: [Regression wmf20] Cursor traverses through the table unexpectedly with right/left arrow keys and throws following error in the console "Uncaught TypeError: Cannot... - https://phabricator.wikimedia.org/T91726#1114294
[19:22:45] <James_F>	 RoanKattouw: It'll deal with the merge commit?
[19:22:47] <MatmaRex>	 James_F: TrevorParscal: using RLImageModule would mean that we would have to update the Resources.php entry every time we change the names of icons, or add/remove some
[19:23:15] <RoanKattouw>	 mooeypoo: Oh, meh, you did do something wrong
[19:23:17] <MatmaRex>	 (unless you make it load the JSON definition file somehow, no idea how that would affect MW's performance)
[19:23:19] <RoanKattouw>	 Well, "wrong"
[19:23:34] <James_F>	 MatmaRex: Yeah. Or make a ResourcesOOjsUI.php file.
[19:23:40] <MatmaRex>	 so assuming that we'll continue working on the icons, using RLImageModule would just add more work for us
[19:23:45] <MatmaRex>	 hmmm. that could work
[19:23:48] <RoanKattouw>	 mooeypoo: Can you keep the original HTML as meta: feeding into body: , but then add another property called metaFromData: which feeds into fromDataBody: ?
[19:24:39] <MatmaRex>	 and also. assuming that this is going to be *the* icon set for MediaWiki now, we will want to generate .mw-icon-<whatever> classes in addition to .oo-ui-icon-<whatever>, and RLImageModule can't do that yet
[19:25:09] <MatmaRex>	 should be easy to implement, but it's not implemented right now
[19:28:25] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196305 (owner: 10Jforrester)
[19:28:39] <grrrit-wm>	 (03PS5) 10Catrope: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196224 (https://phabricator.wikimedia.org/T90478) (owner: 10Divec)
[19:28:45] <James_F>	 MatmaRex: OK, should I go ahead with crappy RL modules for now and we'll fix it later?
[19:28:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196224 (https://phabricator.wikimedia.org/T90478) (owner: 10Divec)
[19:29:20] <James_F>	 RoanKattouw: ^^^ Backport?
[19:29:27] <MatmaRex>	 James_F: yeah, i think. can you file a task for me to do the later fixing afterwards?
[19:29:33] <James_F>	 MatmaRex: Will do.
[19:30:01] <RoanKattouw>	 James_F: Yes
[19:31:05] <wikibugs>	 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 7Technical-Debt: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1114343 (10Jdforrester-WMF) 3NEW a:3matmarex
[19:31:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196224 (https://phabricator.wikimedia.org/T90478) (owner: 10Divec)
[19:33:07] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 7Browser-Support-Google-Chrome, and 5 others: Chrome lets you place the cursor either side of a Table (eww) and VE doesn't correct this - https://phabricator.wikimedia.org/T73560#1114361 (10Ryasmeen)
[19:35:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Handle undoing of reference group changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195901 (https://phabricator.wikimedia.org/T71119) (owner: 10Alex Monk)
[19:36:09] <James_F>	 RoanKattouw: Fun times.
[19:36:20] <grrrit-wm>	 (03PS1) 10Jforrester: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196314 (https://phabricator.wikimedia.org/T90478) 
[19:36:29] <grrrit-wm>	 (03PS1) 10Jforrester: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196315 (https://phabricator.wikimedia.org/T90478) 
[19:36:43] <wikibugs>	 10MediaWiki-Page-editing, 7Performance: Edit page flickers on load due JS-inserted div#wikiDiff - https://phabricator.wikimedia.org/T92552#1114371 (10Krinkle) 3NEW a:3Krinkle
[19:36:51] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-04_(1.25wmf20), and 2 others: Deleting through a list throws an exception - https://phabricator.wikimedia.org/T92286#1114380 (10Jdforrester-WMF) 5Open>3Resolved
[19:37:20] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-04_(1.25wmf20), and 2 others: [Regression wmf18]  Deleting the text inside a bullet/numbered item, heading, other nodes throws error - https://phabricator.wikimedia.org/T90478#1114387 (10Jdforrester-WMF) 5Open...
[19:37:39] <wikibugs>	 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 7Technical-Debt: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1114390 (10Legoktm) RLIM?
[19:38:04] <James_F>	 legoktm: ResourceLoaderImageModule.
[19:38:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle undoing of reference group changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/195901 (https://phabricator.wikimedia.org/T71119) (owner: 10Alex Monk)
[19:38:31] <wikibugs>	 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 7Technical-Debt: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1114394 (10Legoktm)
[19:38:36] * legoktm edits
[19:39:01] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 5WMF-deploy-2015-03-18_(1.25wmf22): Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of undefined" - https://phabricator.wikimedia.org/T71119#1114398 (10Jdforrester-WMF)
[19:39:08] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21), 7user-notice: Hidden templates should display as an icon in-page in VisualEditor so they can be interacted with (e.g. a puzzle piece?) - https://phabricator.wikimedia.org/T51806#1114399 (...
[19:39:13] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add unit tests for ve.dm.Selection sub-classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196217 (owner: 10Esanders)
[19:39:17] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-11_(1.25wmf21), 7user-notice: VisualEditor: Display and let users edit arbitrary HTML anchors, e.g. in section headings - https://phabricator.wikimedia.org/T52633#1114400 (10gpaumier)
[19:39:28] <wikibugs>	 10TemplateData, 7Verified-in-Phase0, 5WMF-deploy-2015-03-11_(1.25wmf21), 7user-notice: TemplateData GUI needs to let users set a string as the (secondary) value for 'deprecated' (as a description), not just boolean - https://phabricator.wikimedia.org/T90734#1114401 (10gpaumier)
[19:39:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Remove unused ve.ui.*Inspector.static.removable = false; [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196292 (owner: 10Bartosz Dziewoński)
[19:40:07] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ve.ui.MWLinkNodeInspector: Restore action buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196291 (https://phabricator.wikimedia.org/T92525) (owner: 10Bartosz Dziewoński)
[19:40:38] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-18_(1.25wmf22): No longer possible to convert an auto-numbered link to one with a label - https://phabricator.wikimedia.org/T92525#1114406 (10Jdforrester-WMF) 5Open>3Resolved
[19:41:26] <RoanKattouw>	 MatmaRex: It looks to me like the test failures at https://gerrit.wikimedia.org/r/#/c/196305/ are indicative of something toolbar-related being broken in OOjs UI 0.9.1
[19:41:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add unit tests for ve.dm.Selection sub-classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196217 (owner: 10Esanders)
[19:42:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ui.MWLinkNodeInspector: Restore action buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196291 (https://phabricator.wikimedia.org/T92525) (owner: 10Bartosz Dziewoński)
[19:42:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused ve.ui.*Inspector.static.removable = false; [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196292 (owner: 10Bartosz Dziewoński)
[19:43:03] <Krenair>	 RoanKattouw, https://phabricator.wikimedia.org/T91608#1113799 - ... this is not helpful -_-
[19:43:05] * MatmaRex looks
[19:43:27] <MatmaRex>	 RoanKattouw: ah, yes
[19:43:31] <RoanKattouw>	 Krenair: Sorry, I was going to follow that up with something actually helpful and then got distractd
[19:43:36] <MatmaRex>	 RoanKattouw: https://gerrit.wikimedia.org/r/195047 needs merging
[19:43:37] <Krenair>	 :D
[19:43:43] <RoanKattouw>	 MatmaRex, James_F: Also we should probably run these things before actually cutting the release
[19:43:53] <James_F>	 RoanKattouw: Details. :-)
[19:43:55] <drobbins>	 Setting up VE (REL1_24) with MW 1.24.1 -- I'm having an issue with the "parsing" animation not disappearing after parsing completes. It just hangs in browser.
[19:44:02] <RoanKattouw>	 MatmaRex: Ahm, does that mean there was a breaking change in OOUI?
[19:44:07] <MatmaRex>	 everything worked with that patch last time i checked
[19:44:19] <grrrit-wm>	 (03PS2) 10Catrope: ve.ui.Toolbar: Fix up onWindowResize to call parent method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195047 (https://phabricator.wikimedia.org/T52227) (owner: 10Bartosz Dziewoński)
[19:44:35] <MatmaRex>	 RoanKattouw: if it does mean that, then every change that adds a new method is a breaking change.
[19:44:54] <MatmaRex>	 because of how we don't have private methods at all.
[19:45:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 3VisualEditor 2014/15 Q3 blockers: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1114429 (10Catrope) I agree with the course of action outlined (use JSON files, custom RL module for VE-MW) but...
[19:45:18] <drobbins>	 Anyone know of working versions with 1.24.1? Shouldn't the REL1_24 branch work?
[19:45:46] <MatmaRex>	 hey drobbins, hang on, we're unbreaking things
[19:45:49] <MatmaRex>	 :)
[19:46:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.ui.Toolbar: Fix up onWindowResize to call parent method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195047 (https://phabricator.wikimedia.org/T52227) (owner: 10Bartosz Dziewoński)
[19:46:24] <RoanKattouw>	 Oh I see
[19:46:37] <drobbins>	 MatmaRex: okay
[19:46:39] <RoanKattouw>	 You're adding a method to a base class where the subclass already has a method with the same name
[19:46:42] <RoanKattouw>	 That's sensible
[19:46:48] <drobbins>	 MatmaRex: in REL1_24 or in general? :)
[19:46:54] <RoanKattouw>	 Now I understand what happened
[19:46:55] <MatmaRex>	 RoanKattouw: if we want to turn out private methods really private (just function foo() {} rather than class.prototype.foo = function () {}), then i'm open to discussion
[19:47:03] <MatmaRex>	 turn our*
[19:47:12] <RoanKattouw>	 drobbins: Is the  extensions/VisualEditor/lib/ve directory empty by any chance?
[19:47:28] <RoanKattouw>	 MatmaRex: Meh, no, I'll accept this as a limitation of OOjs
[19:47:45] <RoanKattouw>	 Although maybe we shouldn't make our event listener methods public and named this predictably
[19:47:46] <drobbins>	 RoanKattouw: no, it isn't.
[19:47:53] <James_F>	 RoanKattouw: I should merge 195047 into the update?
[19:47:54] <drobbins>	 RoanKattouw: it has stuff in it
[19:48:07] <RoanKattouw>	 drobbins: OK. When you encounter the eternal progress bar, are there any errors in your browser console?
[19:48:19] <RoanKattouw>	 James_F: Yes
[19:48:20] <MatmaRex>	 sorry for not flagging the breakage more clearly
[19:48:23] <James_F>	 RoanKattouw: Or just force-merge and add later?
[19:48:41] <wikibugs>	 10OOjs-UI: indicator missing from ButtonSelectWidget - https://phabricator.wikimedia.org/T92553#1114437 (10kaldari) 3NEW
[19:49:09] <RoanKattouw>	 MatmaRex: So, next crisis :P ---^^
[19:49:20] <drobbins>	 RoanKattouw: nothing new there.
[19:49:28] <wikibugs>	 10MediaWiki-Page-editing, 10WikiEditor, 10MediaWiki-General-or-Unknown: Include WikiEditor in core - https://phabricator.wikimedia.org/T91872#1114447 (10Krinkle) 5Open>3declined a:3Krinkle WikiEditor has been bundled with MediaWiki since [MediaWiki 1.18](https://www.mediawiki.org/wiki/MediaWiki_1.18)....
[19:49:39] <RoanKattouw>	 drobbins: What if you add ?debug=true to the URL and try loading VE again, while keeping your browser console open? Do any errors appear then?
[19:49:48] <drobbins>	 RoanKattouw: it did work initially, like first try. Then failed for every try after, even after restarting everything and clearing broswer cache
[19:49:52] <grrrit-wm>	 (03PS2) 10Jforrester: Update OOjs UI to v0.9.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196305 (https://phabricator.wikimedia.org/T52227) 
[19:49:54] <drobbins>	 RoanKattouw: will try
[19:49:59] <wikibugs>	 10OOjs-UI: indicator missing from ButtonSelectWidget (MediaWiki skin) - https://phabricator.wikimedia.org/T92553#1114460 (10kaldari)
[19:50:13] <grrrit-wm>	 (03Abandoned) 10Jforrester: ve.ui.Toolbar: Fix up onWindowResize to call parent method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195047 (https://phabricator.wikimedia.org/T52227) (owner: 10Bartosz Dziewoński)
[19:50:39] <drobbins>	 RoanKattouw: Yes, then I have some custom JS that this wiki has throwing an exception.
[19:50:49] <RoanKattouw>	 Right
[19:50:52] <wikibugs>	 10MediaWiki-Page-editing, 5Patch-For-Review, 7Performance: Edit page flickers on load due JS-inserted div#wikiDiff - https://phabricator.wikimedia.org/T92552#1114468 (10Krinkle)
[19:50:54] <grrrit-wm>	 (03PS2) 10Alex Monk: [WIP] Show non-editable parts of pages in their normal places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) 
[19:50:57] <RoanKattouw>	 Try fixing (or removing) that custom JS
[19:51:11] <RoanKattouw>	 Exceptions in custom wiki JS have a tendency to poison VE
[19:51:30] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release: OOjs UI: Make the toolbar narrower when the window is narrow (responsive layout) - https://phabricator.wikimedia.org/T52227#1114470 (10Jdforrester-WMF)
[19:51:36] <drobbins>	 RoanKattouw: ah, nifty. Will do.
[19:51:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.9.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196305 (https://phabricator.wikimedia.org/T52227) (owner: 10Jforrester)
[19:52:27] <RoanKattouw>	 Krenair: Sorry if that response wasn't materially more helpful. I have no good ideas for how to share this data
[19:52:36] <wikibugs>	 10VisualEditor: Tool bar: oo-ui-icon-ref-cite-web is positioned farther from oo-ui-indicator-down element than other Toolbar items  - https://phabricator.wikimedia.org/T92554#1114475 (10Etonkovidova) 3NEW
[19:52:41] <Krenair>	 RoanKattouw, okay.
[19:52:48] <RoanKattouw>	 I agree with James that we should have a JSON file in VE core and do the RL cleverness he discussed in VE-MW
[19:52:49] <Krenair>	 How does VE core load its files anyway?
[19:52:53] <RoanKattouw>	 That part all sounds good and well thought-out to me
[19:52:55] <RoanKattouw>	 Krenair: Badly
[19:52:59] <James_F>	 Krenair: Poorly.
[19:52:59] <Krenair>	 heh.
[19:53:02] <James_F>	 Hah.
[19:53:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Show non-editable parts of pages in their normal places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) (owner: 10Alex Monk)
[19:53:07] <RoanKattouw>	 Krenair: VisualEditor.php is almost a full duplicate of modules.json
[19:53:10] <Krenair>	 Just rely on the code using it to include all the right files?
[19:53:10] <Krenair>	 :/
[19:53:10] <James_F>	 RoanKattouw: You've been spending too much time in my company. :-)
[19:53:33] <RoanKattouw>	 So all that stuff sounds excellent to me
[19:53:44] <rits>	 kernair: hello i was working on this bug https://phabricator.wikimedia.org/T78038 i could'nt get in which width has to be adjusted as i tried to fix the margin it doesnt changed anything
[19:53:48] <RoanKattouw>	 But as for the problem of how do we deduplicate it between VE and WE.... I don't know
[19:54:22] <grrrit-wm>	 (03PS3) 10Alex Monk: [WIP] Show non-editable parts of pages in their normal places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) 
[19:54:33] <RoanKattouw>	 mooeypoo: I think this https://phabricator.wikimedia.org/T92554#1114475 is a result of your cleverness?
[19:54:37] <wikibugs>	 10VisualEditor: Tool bar: oo-ui-icon-ref-cite-web is positioned farther from oo-ui-indicator-down element than other Toolbar items - https://phabricator.wikimedia.org/T92554#1114489 (10Etonkovidova) 5Open>3Invalid
[19:54:53] <RoanKattouw>	 ....although etonkovidova just closed it as invalid
[19:55:10] <James_F>	 RoanKattouw: Options: (a) Don't. (b) Make WE depend on VE. (c) Make VE depend on WE. (d) Put it in MW-core and make both depend on it.
[19:55:22] <James_F>	 RoanKattouw: Pick one.
[19:55:29] <Krenair>	 d is the least bad
[19:55:40] <RoanKattouw>	 (d) is obviously better than (b) and (c)
[19:55:45] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196305 (https://phabricator.wikimedia.org/T52227) (owner: 10Jforrester)
[19:55:46] <RoanKattouw>	 But does VE core not deserve special characters?
[19:55:47] <Krenair>	 but then people will be upset that we merged yet another thing that core doesn't use into core
[19:55:56] <James_F>	 RoanKattouw: Not this week. Later.
[19:55:57] <Krenair>	 oh right, that's still no good for ve core
[19:56:08] <James_F>	 I DGAF about VE-core for this.
[19:56:20] <James_F>	 Let's not make perfect the enemy of the good.
[19:56:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Show non-editable parts of pages in their normal places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) (owner: 10Alex Monk)
[19:56:29] <RoanKattouw>	 Sounds reasonable
[19:56:40] <James_F>	 Later we'll put it in VE-core.
[19:56:44] <James_F>	 Once we've retired WE.
[19:56:50] <James_F>	 (Years away.)
[19:56:53] <Krenair>	 rits: sorry, I'm not quite sure what you're talking about
[19:56:53] <James_F>	 Success.
[19:57:08] <mooeypoo>	 RoanKattouw, yes. That's how it's supposed to look if Citoid exists.
[19:58:11] <grrrit-wm>	 (03PS3) 10Jforrester: Update OOjs UI to v0.9.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196305 (https://phabricator.wikimedia.org/T52227) 
[19:58:14] * James_F grumbles about new languages breaking the build.
[19:58:15] <drobbins>	 RoanKattouw: I fixed the custom JS exception; there are two others that have been there in the past -- one is an uncaught security error thrown by the DISQUS widget, another is a syntax error in Vector's JS that is from what I can tell only cosmetic.
[19:58:28] <drobbins>	 (and problem still exists)
[19:58:30] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Remove MWTransclusionMetaNode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 (owner: 10Mooeypoo)
[19:58:34] <MatmaRex>	 James_F: do people actually use WikiEditor's symbol inserter?
[19:58:42] <James_F>	 MatmaRex: Many thousands.
[19:58:47] <MatmaRex>	 every large wiki has a custom character insert thing.
[19:58:50] <grrrit-wm>	 (03PS4) 10Alex Monk: [WIP] Show non-editable parts of pages in their normal places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) 
[19:58:57] <RoanKattouw>	 drobbins: "Syntax error" and "only cosmetic" are total opposites :D
[19:59:00] <James_F>	 MatmaRex: Yeah, which we also need to burn to the ground. :-)
[19:59:03] <MatmaRex>	 i haven't even known about WikiEditor's one for the longest time.
[19:59:08] <RoanKattouw>	 If it's a syntax error, that's a serious problem, not a cosmetic one
[19:59:14] <RoanKattouw>	 drobbins: What's the Vector error?
[19:59:21] <rits>	 krenair: for this bug i couldnt get what width has to adjusted https://phabricator.wikimedia.org/T78038 margin doesnt fix anything 
[19:59:37] <Krenair>	 Posted more than two months ago.
[19:59:43] <Krenair>	 It might no longer be correct
[19:59:49] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-04_(1.25wmf20): Special character inserter width needs adjusting - https://phabricator.wikimedia.org/T78038#1114511 (10Jdforrester-WMF) 5Open>3Resolved
[20:00:01] <James_F>	 rits: We replaced that system with a new one.
[20:00:05] <drobbins>	 RoanKattouw: vector has this in it, and Chrome doesn't like it: .filter( '[href^=http://], [href^=https://]' )
[20:00:07] <James_F>	 rits: I've closed it as fixed.
[20:00:11] <James_F>	 rits: Thanks for the spot.
[20:00:15] <wikibugs>	 10OOjs-UI: ButtonWidget with icon only looks weird (MediaWiki skin) - https://phabricator.wikimedia.org/T92556#1114516 (10kaldari) 3NEW
[20:00:16] <drobbins>	 actually, that's in common.js.
[20:00:19] <drobbins>	 More stuff I can fix
[20:00:49] <rits>	 okey your welcome :)
[20:01:31] <RoanKattouw>	 drobbins: oooh
[20:01:43] <RoanKattouw>	 drobbins: What is the exact error message?
[20:01:49] <RoanKattouw>	 It's probably harmless but I want to make sure
[20:01:55] <grrrit-wm>	 (03CR) 10Mooeypoo: Remove MWTransclusionMetaNode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 (owner: 10Mooeypoo)
[20:02:19] <James_F>	 RoanKattouw: Please do the needful on https://gerrit.wikimedia.org/r/#/q/I936ea56e1c99f576f44115a9b2fa075ef1ab14bd,n,z ? :-)
[20:02:35] <drobbins>	 RoanKattouw: I think I can remove that custom JS.
[20:02:38] <drobbins>	 one moment.
[20:03:03] <grrrit-wm>	 (03CR) 10Catrope: Remove MWTransclusionMetaNode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 (owner: 10Mooeypoo)
[20:03:53] <drobbins>	 RoanKattouw: hmmm... that appears to fix it. I'll test a bit more and see if it's consistently working now.
[20:03:54] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.9.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196305 (https://phabricator.wikimedia.org/T52227) (owner: 10Jforrester)
[20:04:05] <James_F>	 RoanKattouw: Ta.
[20:04:08] <drobbins>	 RoanKattouw: the DISQUS widget attempts to open a frame, and fails. THat doesn't seem to affect things.
[20:04:25] <RoanKattouw>	 drobbins: OK, can you do the following experiment?
[20:05:14] <mooeypoo>	 RoanKattouw, James_F is telling me to tell you to fix ghastly the system you wrote
[20:05:24] <RoanKattouw>	 drobbins: Hold on before I ask that, did you try using ?debug=true yet?
[20:05:34] <RoanKattouw>	 drobbins: That won't make it work but it will surface errors more clearly
[20:05:41] <RoanKattouw>	 mooeypoo: Really it should just be better-documented
[20:05:49] <drobbins>	 RoanKattouw: yes, I was using ?debug=true in my testing after you suggested it
[20:05:50] <James_F>	 RoanKattouw: Any-documented. :-P
[20:05:56] <mooeypoo>	 RoanKattouw, "just".
[20:06:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.9.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196305 (https://phabricator.wikimedia.org/T52227) (owner: 10Jforrester)
[20:06:30] <mooeypoo>	 RoanKattouw, what value am I supposed to put into metaFromData ?
[20:06:45] <RoanKattouw>	 drobbins: OK cool. In that case, go to a wiki page, open the inspector, go to the Network tab, and use the clear icon to clear any results already shown. Then click the edit tab, and report what you see in the inspector
[20:06:59] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (89b0629) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 
[20:07:02] <RoanKattouw>	 (the clear icon looks like a "forbidden" icon)
[20:07:12] <drobbins>	 RoanKattouw: what should I be looking for?
[20:07:18] <RoanKattouw>	 mooeypoo: metaFromData should be what you currently have in meta
[20:07:26] <RoanKattouw>	 mooeypoo: And meta should be changed back to what it was before your change
[20:07:33] <RoanKattouw>	 drobbins: Requests to load.php and api.php
[20:07:39] <mooeypoo>	 ahha
[20:07:46] <RoanKattouw>	 drobbins: And any failures (usually marked red)
[20:08:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (89b0629) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 (owner: 10Jforrester)
[20:08:35] <James_F>	 Oh, meh.
[20:08:39] <wikibugs>	 10OOjs-UI: indicator missing from ButtonSelectWidget (MediaWiki skin) - https://phabricator.wikimedia.org/T92553#1114532 (10kaldari) If I remove... .oo-ui-decoratedOptionWidget.oo-ui-indicatorElement .oo-ui-indicatorElement-indicator { height: 100%; } ...it seems to work fine. I wonder what that height: 100% is...
[20:09:03] <grrrit-wm>	 (03CR) 10Catrope: "VisualEditor.php needs to be updated for renamed files" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 (owner: 10Jforrester)
[20:09:12] <James_F>	 RoanKattouw: Yeah, I know.
[20:09:27] <James_F>	 RoanKattouw: If only VisualEditor.php and extension.json read from modules.json.
[20:09:40] <RoanKattouw>	 Yeah...
[20:09:41] <mooeypoo>	 RoanKattouw, okay, I think I got it, retesting now
[20:10:07] <RoanKattouw>	 mooeypoo: Awesome. Once you're done I can explain what was going on there, I hope it'll make at least some amount of sense
[20:10:21] <wikibugs>	 10TemplateData: Unable to type in label and description field - https://phabricator.wikimedia.org/T92558#1114548 (10Florian) 3NEW
[20:11:45] <grrrit-wm>	 (03PS2) 10Jforrester: Update VE core submodule to master (89b0629) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 
[20:11:48] <drobbins>	 RoanKattouw: only problem is that it's failing loading some images; however, I think this is related to the wiki in question, not VE.
[20:11:51] <wikibugs>	 10TemplateData: Unable to type in label and description field - https://phabricator.wikimedia.org/T92558#1114565 (10Florian)
[20:12:03] <mooeypoo>	 RoanKattouw, it works, and it actually makes a lot of sense -- I was wondering how to test what we get from Parsoid as the raw data. 
[20:12:08] <mooeypoo>	 the confusing part was how to implement in this system
[20:12:26] <James_F>	 RoanKattouw: Could you do the other 0.9.1 (inc. V+2-bypass-submit for /vendor) so we can merge that?
[20:12:27] <drobbins>	 Now I need to figure out why the toolbar disappeared when I removed that custom JS.
[20:12:27] <wikibugs>	 10TemplateData: [Regression wmf21] Unable to type in label and description field - https://phabricator.wikimedia.org/T92558#1114568 (10Catrope) a:3MSchottlender-WMF
[20:12:36] <RoanKattouw>	 James_F: Sure, sorry
[20:12:48] <grrrit-wm>	 (03PS3) 10Mooeypoo: Remove MWTransclusionMetaNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 
[20:12:56] <RoanKattouw>	 drobbins: So is VE loading now or not?
[20:13:39] <drobbins>	 RoanKattouw: yes, all working now.
[20:13:45] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Remove MWTransclusionMetaNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 (owner: 10Mooeypoo)
[20:13:52] <RoanKattouw>	 drobbins: Awesome, good to hear
[20:13:53] <drobbins>	 RoanKattouw: it looks like it was simply those fugly js issues.
[20:14:07] <drobbins>	 RoanKattouw: thanks for the rapid and effective help
[20:14:57] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of unde... - https://phabricator.wikimedia.org/T71119#1114570
[20:15:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (89b0629) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 (owner: 10Jforrester)
[20:16:35] <drobbins>	 it looks like my JS fixes need more work though.
[20:16:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove MWTransclusionMetaNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196274 (owner: 10Mooeypoo)
[20:16:46] <drobbins>	 no exception, but my tests disabled the toolbar.
[20:17:44] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release: Various widgets refuse to tab to other widgets - https://phabricator.wikimedia.org/T92449#1114583 (10Jdforrester-WMF) 5Open>3Resolved
[20:17:54] <drobbins>	 there we go...
[20:21:30] <drobbins>	 RoanKattouw: quick question for you -- is 1.23.5 a suitable version for use with VE? Or is it really best to upgrade to 1.24.1 first?
[20:21:52] <James_F>	 drobbins: 1.24.1
[20:21:59] <RoanKattouw>	 drobbins: If you are using the REL1_24 version of VE, you should use MW 1.24
[20:22:03] <James_F>	 drobbins: 1.23.x versions of VisualEditor are very old now.
[20:22:07] <drobbins>	 RoanKattouw: yes, this is for another wiki.
[20:22:09] <RoanKattouw>	 But also that
[20:22:12] <drobbins>	 James_F: I can do that, thanks :)
[20:22:40] <grrrit-wm>	 (03CR) 10Mobrovac: [C: 032] Add bash script for updating submodule [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195911 (owner: 10Mvolz)
[20:25:14] <drobbins>	 RoanKattouw: I need to test this -- how might VisualEditor interact with a custom bootstrap skin? Does it require special support in the skin to display properly or is it fairly resilient in this regard?
[20:25:53] <grrrit-wm>	 (03CR) 10Mobrovac: [C: 032] Remove the zotero translation server and translators [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/194548 (https://phabricator.wikimedia.org/T89872) (owner: 10Alexandros Kosiaris)
[20:27:08] <wikibugs>	 10VisualEditor, 10Citoid, 6operations, 3VisualEditor 2014/15 Q3 blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1114609 (10Jdforrester-WMF)
[20:27:50] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Insert a new references list immediately, rather than showing a dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196366 (https://phabricator.wikimedia.org/T71727) 
[20:27:59] <grrrit-wm>	 (03CR) 10Mobrovac: [C: 032] Update citoid submodule to master (2cd246b) [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/195912 (owner: 10Mvolz)
[20:28:28] <MatmaRex>	 drobbins: VisualEditor makes some assumptions about skin layout currently, and about certain ids being present in HTML output (like #ca-edit forthe "Edit" tab)
[20:29:12] <drobbins>	 MatmaRex: how does it interact with the edit tab?
[20:29:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Insert a new references list immediately, rather than showing a dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196366 (https://phabricator.wikimedia.org/T71727) (owner: 10Bartosz Dziewoński)
[20:29:35] <wikibugs>	 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of unde... - https://phabricator.wikimedia.org/T71119#1114628
[20:29:54] <MatmaRex>	 drobbins: also, VE will normally not load on skins that are not explicitly supported – to test out your skin, add `$wgVisualEditorSupportedSkins[] = 'myskinname';` in LocalSettings.php after loading VE and the skin
[20:30:08] <MatmaRex>	 drobbins: well, it loads itself when the tab is clicked? :)
[20:30:28] <drobbins>	 MatmaRex: okay.
[20:30:31] <drobbins>	 I'll test it out.
[20:30:36] <drobbins>	 thanks.
[20:33:02] <ankita-ks>	 Hi, I have been trying to work on this bug : https://phabricator.wikimedia.org/T92027 
[20:33:47] <ankita-ks>	 Can someone tell me what css pages I should be looking at? 
[20:34:17] <MatmaRex>	 hi ankita-ks, you might want to ask at #wikimedia-mobile – they're the ones usually working on VisualEditor and MobileFrontend integration
[20:34:37] <ankita-ks>	 Ah..okay..thanks! MatmaRex 
[20:35:58] <Krenair>	 RoanKattouw, so if we move all this into some sort of custom RL module
[20:36:02] <Krenair>	 we... put that in core?
[20:36:10] <Krenair>	 and then access the contents from the client... somehow?
[20:37:38] <RoanKattouw>	 Do we have a RLModule subclass for delivering JSON blobs yet?
[20:39:17] <TrevorParscal>	 RoanKattouw: how's it going?
[20:39:34] <ankita-ks>	 Hi, is there a visual editor bug that you can suggest, that'll help me get familiar with the code-base? 
[20:39:35] <RoanKattouw>	 Just looking at random things, not much going on
[20:39:47] <TrevorParscal>	 when do you come back to SF man? we miss you
[20:39:49] <RoanKattouw>	 I should theoretically be working on TargetLoader phase 2 but small misc things keep coming up
[20:39:54] <RoanKattouw>	 TrevorParscal: Flying on Monday
[20:40:08] <Krenair>	 RoanKattouw, don't think so
[20:40:08] <RoanKattouw>	 First I have to play taxi driver and go to a party
[20:40:11] <RoanKattouw>	 this weekend
[20:40:23] <RoanKattouw>	 Krenair: Well then we should write one, we'll need one in any case
[20:41:32] <mooeypoo>	 meh, I think we need to revert something in TemplateData
[20:42:38] <RoanKattouw>	 Krenair: Is that something you'd want to take on?
[20:42:58] <Krenair>	 I'm not sure how much work that'd be
[20:43:01] <TrevorParscal>	 RoanKattouw: awesome man
[20:43:02] <RoanKattouw>	 TrevorParscal: I will be back in SF for all of three days :D
[20:43:10] <TrevorParscal>	 I will actually be in on Tuesday
[20:43:15] <RoanKattouw>	 Oh nice
[20:43:22] <TrevorParscal>	 my WFH day is going to be monday next week
[20:45:27] <RoanKattouw>	 I'll be working from the plane on Monday but I should have wifi on board
[20:45:38] <RoanKattouw>	 Althogh last time it frequently broke for hours at a time
[20:48:37] <MatmaRex>	 Krenair: RoanKattouw: there is ResourceLoaderLanguageDataModule, could refactor it, or copy-paste and tweak.
[20:49:19] <RoanKattouw>	 Oooh yes good find
[20:49:20] <MatmaRex>	 TrevorParscal: about the audit you mentioned earlier today. are there any blockers, or should we just do it?
[20:49:43] <MatmaRex>	 TrevorParscal: or maybe we should just start supporting that? (no idea if it's feasible)
[20:49:55] <MatmaRex>	 (about mixins inheriting other mixins)
[20:49:58] <TrevorParscal>	 MatmaRex: no blockers that I know of, it's just something that I was talking to Moriel about and realized we needed to cleanup
[20:50:05] <thedj>	 hmm, did logging get added to wikieditor ?
[20:50:11] <Krenair>	 eventlogging?
[20:50:11] <Krenair>	 yes
[20:50:13] <Krenair>	 why?
[20:50:31] <thedj>	 because now i have JS errors due to not having logging extensions installed
[20:50:34] <TrevorParscal>	 MatmaRex: you are going to give Krinkle a panic attcak
[20:50:38] <Krenair>	 hm
[20:50:42] <Krenair>	 thedj, pull the latest version?
[20:50:49] <Krenair>	 that sounds like something we fixed a couple of hours ago
[20:51:20] <TrevorParscal>	 i guess, if mixinClass copied the own properties of the class being mixed in, and also traversed up the prototype chain and copied those own properties as well until it reached Object.prototype
[20:51:25] <TrevorParscal>	 that could work
[20:51:34] <MatmaRex>	 TrevorParscal: i mean, if we're going to switch to copying eveyrthing always, anyway
[20:51:36] <TrevorParscal>	 and would avoid the whole confusing situation
[20:51:43] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196366 (https://phabricator.wikimedia.org/T71727) (owner: 10Bartosz Dziewoński)
[20:51:57] <MatmaRex>	 which was the outcome of the .static.class discussion, iirc
[20:52:36] <thedj>	 Krenair: ah bingo
[20:52:48] <thedj>	 i still had yesterdays version there
[20:52:51] <MatmaRex>	 then having class B that inherits class A, or class B that mixins class A, would be exactly equivalent
[20:52:54] <Krenair>	 :)
[20:53:02] <MatmaRex>	 (as long as there are no other mixins to muck things up)
[20:54:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196366 (https://phabricator.wikimedia.org/T71727) (owner: 10Bartosz Dziewoński)
[20:55:02] <grrrit-wm>	 (03PS1) 10Mooeypoo: Prevent a dependent property from updating on infinite loops [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/196420 (https://phabricator.wikimedia.org/T92558) 
[20:55:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Prevent a dependent property from updating on infinite loops [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/196420 (https://phabricator.wikimedia.org/T92558) (owner: 10Mooeypoo)
[20:56:17] <wikibugs>	 10TemplateData, 5Patch-For-Review: [Regression wmf21] Unable to type in label and description field - https://phabricator.wikimedia.org/T92558#1114723 (10Mooeypoo) a:5MSchottlender-WMF>3Mooeypoo This is happening due to a problem with the commit that introduced optional/dependent properties ( https://gerri...
[20:56:36] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196315 (https://phabricator.wikimedia.org/T90478) (owner: 10Jforrester)
[20:56:49] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196314 (https://phabricator.wikimedia.org/T90478) (owner: 10Jforrester)
[20:57:38] <wikibugs>	 10OOjs-UI, 5OOjs-UI-0.9.1, 5WMF-deploy-2015-03-18_(1.25wmf22): Various widgets refuse to tab to other widgets - https://phabricator.wikimedia.org/T92449#1114727 (10Jdforrester-WMF)
[20:57:39] <wikibugs>	 10OOjs-UI, 5OOjs-UI-0.9.1, 5WMF-deploy-2015-03-18_(1.25wmf22): OOjs UI: Make the toolbar narrower when the window is narrow (responsive layout) - https://phabricator.wikimedia.org/T52227#1114728 (10Jdforrester-WMF)
[20:57:40] <wikibugs>	 10OOjs-UI, 5OOjs-UI-0.9.1, 10UI-Standardization, 7Design, 5WMF-deploy-2015-03-18_(1.25wmf22): Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1114729 (10Jdforrester-WMF)
[20:57:43] <wikibugs>	 10OOjs-UI, 5OOjs-UI-0.9.1, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Use MutationObserver to detect when an OO.ui.Element is attached to a document - https://phabricator.wikimedia.org/T64174#1114733 (10Jdforrester-WMF)
[20:57:44] <wikibugs>	 10OOjs-UI, 5OOjs-UI-0.9.1, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget - https://phabricator.wikimedia.org/T89399#1114731 (10Jdforrester-WMF)
[20:57:45] <wikibugs>	 10OOjs-UI, 5OOjs-UI-0.9.1, 5WMF-deploy-2015-03-18_(1.25wmf22): Provide support for "icon packs" so that not all of the OOjs UI theme needs to be loaded at once for users - https://phabricator.wikimedia.org/T89686#1114730 (10Jdforrester-WMF)
[20:57:46] <wikibugs>	 10OOjs-UI, 5OOjs-UI-0.9.1, 5WMF-deploy-2015-03-18_(1.25wmf22): Toolbar menus don't disappear when another menu is opened on touch devices - https://phabricator.wikimedia.org/T87818#1114735 (10Jdforrester-WMF)
[20:57:47] <wikibugs>	 10OOjs-UI, 5OOjs-UI-0.9.1, 5WMF-deploy-2015-03-18_(1.25wmf22): OOUI has no way to produce a window-like frame around something other than a window - https://phabricator.wikimedia.org/T91153#1114734 (10Jdforrester-WMF)
[20:57:47] <wikibugs>	 10OOjs-UI, 5OOjs-UI-0.9.1, 10VisualEditor, 5WMF-deploy-2015-03-18_(1.25wmf22): Pop-up "You are not logged in." warning cannot be closed via the "X" on touch devices - https://phabricator.wikimedia.org/T91757#1114736 (10Jdforrester-WMF)
[20:57:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Prevent a dependent property from updating on infinite loops (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/196420 (https://phabricator.wikimedia.org/T92558) (owner: 10Mooeypoo)
[20:58:07] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 031] Only call execCommand() on the surface in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope)
[20:59:06] <grrrit-wm>	 (03PS3) 10Jforrester: Update VE core submodule to master (89b0629) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 
[20:59:45] <grrrit-wm>	 (03PS1) 10Kaldari: Fixing indicators for ButtonSelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/196423 (https://phabricator.wikimedia.org/T92553) 
[20:59:53] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Needs rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175488 (owner: 10Esanders)
[20:59:59] <Krinkle>	 I don't think having mixinClass follow the inheritance chain provides any value. It will just create two ways to do the same thing instead of one. mixins should mix in their mixins, inheritance is just an honest mistake, so you fix it.
[21:01:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (89b0629) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 (owner: 10Jforrester)
[21:01:47] <MatmaRex>	 okay
[21:01:48] <grrrit-wm>	 (03PS2) 10Mooeypoo: Prevent a dependent property from updating on infinite loops [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/196420 (https://phabricator.wikimedia.org/T92558) 
[21:02:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196315 (https://phabricator.wikimedia.org/T90478) (owner: 10Jforrester)
[21:02:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Stop bogus emits from handleLinearDelete [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196314 (https://phabricator.wikimedia.org/T90478) (owner: 10Jforrester)
[21:03:10] <grrrit-wm>	 (03PS2) 10Kaldari: Fixing indicators for ButtonSelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/196423 (https://phabricator.wikimedia.org/T92553) 
[21:03:33] <wikibugs>	 10OOjs-UI, 10VisualEditor: Find and eradicate mixins that have parent classes - https://phabricator.wikimedia.org/T92563#1114778 (10matmarex) 3NEW
[21:03:54] <wikibugs>	 10OOjs-UI, 7Technical-Debt: OOUI's GroupWidget and ItemWidget must die - https://phabricator.wikimedia.org/T91565#1114794 (10matmarex)
[21:03:55] <wikibugs>	 10OOjs-UI, 10VisualEditor: Find and eradicate mixins that have parent classes - https://phabricator.wikimedia.org/T92563#1114793 (10matmarex)
[21:04:00] <MatmaRex>	 TrevorParscal: filed ^
[21:05:21] <RoanKattouw>	 Oooh
[21:05:25] <RoanKattouw>	 James_F|Away: I know why that pull-through breaks
[21:05:44] <RoanKattouw>	 Krinkle: Did you test your VE core indexOf change against VE-MW?
[21:05:50] <TrevorParscal>	 MatmaRex: thanks man
[21:06:26] <RoanKattouw>	 Krinkle: 21:01:18 >> TypeError: 'null' is not an object (evaluating 'reg.registry[models[i]].static.matchTagNames.indexOf')  suggests you might not have
[21:06:30] * RoanKattouw fixes
[21:07:09] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Using data URI images in inline slugs (for chimeras) is slow in Chrome (and possibly others) - https://phabricator.wikimedia.org/T91248#1114807 (10Jdforrester-...
[21:08:05] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21), 7user-notice: Hidden templates should display as an icon in-page in VisualEditor so they can be interacted with (e.g. a puzzle piece?) - https://phabricator.wikimedia.org/T51806#1114817 (...
[21:08:25] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: New internal links on /w/index.php?… pages are created relative to /w/ not /wiki/ in the CE and context menu and so fail to go anywhere - https://phabricator.wikimedia.org/T85622#1114820 (10Ryasmeen)
[21:08:32] <mooeypoo>	 James_F|Away, https://gerrit.wikimedia.org/r/#/c/194748/
[21:08:44] <grrrit-wm>	 (03CR) 10Ori.livneh: Load RL modules in one load.php request, rather than in two stages (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[21:09:19] <RoanKattouw>	 mooeypoo: Does not cherry-pick cleanly to wmf21, requires conflict resolution
[21:10:26] <Krinkle>	 RoanKattouw: Tested against Chrome.
[21:12:44] <RoanKattouw>	 MatmaRex: New OOUI version appears to break wrapping in edit notices
[21:13:32] <grrrit-wm>	 (03PS1) 10Catrope: Follow-up 94d3aff4f0c7: fix fatal for classes with .static.matchTagNames unset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196430 
[21:13:41] <RoanKattouw>	 Krinkle: ---^^
[21:13:43] <MatmaRex>	 RoanKattouw: oh poop. i know why, fixing
[21:14:09] <Krenair>	 RoanKattouw, so you think we should have some sort of ResourceLoaderJSONDataModule in core?
[21:14:13] <MatmaRex>	 i added white-space: nowrap to the toolbar, forgotten that we have popups inside it
[21:14:21] <RoanKattouw>	 James_F: I feel like we really need to do better QA on OOUI releases before releasing them, right now we release blindly
[21:14:30] <Krenair>	 then configure it to point at our specialcharacters.json?
[21:14:35] <James_F>	 Yeah.
[21:14:37] <MatmaRex>	 ergh
[21:14:38] <RoanKattouw>	 Krenair: Yeah, maybe
[21:14:50] <RoanKattouw>	 Krenair: The only thing is, the existing uses all call functions
[21:14:56] <RoanKattouw>	 e.g. mw.blah.set( { ... } );
[21:14:56] <Krenair>	 yes
[21:15:06] <James_F>	 RoanKattouw: mooey|away's gone for the daty.
[21:15:12] <RoanKattouw>	 So we'd probably want to support either calling a function or setting a variable :S
[21:15:38] <RoanKattouw>	 James_F: OK well if you/she want(s) that TD fix cherry-picked, it needs a manual cherry-pick
[21:15:42] <Krinkle>	 RoanKattouw: Oh, I was expecting a PhantomJS error not supporting native indexOf. 
[21:15:46] <James_F>	 RoanKattouw: Can you?
[21:15:50] <Krinkle>	 But yeah a null error, wasn't expecting that.
[21:15:52] <RoanKattouw>	 meh I guess so
[21:15:59] <Krinkle>	 RoanKattouw: There was one for rules.blacklist. I fixed that one\
[21:16:05] <James_F>	 RoanKattouw: I'm already 20 minutes late for my next meeting fixing three other pull-throughs.
[21:16:05] <Krinkle>	 RoanKattouw: jQuery.inArray masked that one for us
[21:16:06] <RoanKattouw>	 Krinkle: Well I reproduced it in Chrome by just loading my wiki :)
[21:16:12] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Follow-up 94d3aff4f0c7: fix fatal for classes with .static.matchTagNames unset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196430 (owner: 10Catrope)
[21:16:14] <RoanKattouw>	 Yeah this is the same thing
[21:16:24] <Krinkle>	 RoanKattouw: Yeah, but it didn't fail any unit tests
[21:17:12] <Krinkle>	 MatmaRex: Could you rename your release note bot? It autocompletes from "Matma" every time :P
[21:17:13] <grrrit-wm>	 (03PS1) 10Jforrester: Update VisualEditor core submodule to wmf/1.25wmf20 HEAD (a3f1224) [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196432 
[21:17:23] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Prevent a dependent property from updating on infinite loops [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/196420 (https://phabricator.wikimedia.org/T92558) (owner: 10Mooeypoo)
[21:17:30] <Krinkle>	 I'm trying to teach myself to type "bart" instead.
[21:17:32] <MatmaRex>	 Krinkle: i would if i could
[21:17:39] <Krinkle>	 MatmaRex: Ha, touche
[21:18:15] <MatmaRex>	 although, hmm. the problem is with its email
[21:18:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up 94d3aff4f0c7: fix fatal for classes with .static.matchTagNames unset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196430 (owner: 10Catrope)
[21:18:28] <grrrit-wm>	 (03PS1) 10Jforrester: Update VisualEditor core submodule to wmf/1.25wmf21 HEAD (263b194) [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196433 
[21:18:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent a dependent property from updating on infinite loops [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/196420 (https://phabricator.wikimedia.org/T92558) (owner: 10Mooeypoo)
[21:18:47] <grrrit-wm>	 (03PS1) 10Catrope: Prevent a dependent property from updating on infinite loops [extensions/TemplateData] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196434 (https://phabricator.wikimedia.org/T92558) 
[21:19:01] <RoanKattouw>	 James_F: nm it cherry-picks cleanly, just needed rebase
[21:19:05] <James_F>	 RoanKattouw: Can I get +2s on https://gerrit.wikimedia.org/r/196432 https://gerrit.wikimedia.org/r/196433 and https://gerrit.wikimedia.org/r/196280 so I can make pull-throughs?
[21:19:09] <James_F>	 RoanKattouw: Kk.
[21:19:14] <RoanKattouw>	 On it
[21:19:18] <James_F>	 RoanKattouw: Thanks. :-)
[21:19:28] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VisualEditor core submodule to wmf/1.25wmf20 HEAD (a3f1224) [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196432 (owner: 10Jforrester)
[21:21:15] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VisualEditor core submodule to wmf/1.25wmf21 HEAD (263b194) [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196433 (owner: 10Jforrester)
[21:21:30] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: Hide ve-ui-surface during activation as well [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196280 (https://phabricator.wikimedia.org/T91442) (owner: 10Jforrester)
[21:21:35] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown, 3Collaboration-Team-Sprint-S-2015-03-25: Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1114873 (10EBernhardson) a:3EBernhardson
[21:21:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VisualEditor core submodule to wmf/1.25wmf20 HEAD (a3f1224) [extensions/VisualEditor] (wmf/1.25wmf20) - 10https://gerrit.wikimedia.org/r/196432 (owner: 10Jforrester)
[21:21:45] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Prevent a dependent property from updating on infinite loops [extensions/TemplateData] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196434 (https://phabricator.wikimedia.org/T92558) (owner: 10Catrope)
[21:21:54] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown, 3Collaboration-Team-Sprint-S-2015-03-25: Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1096593 (10EBernhardson) a:5EBernhardson>3None
[21:21:55] <RoanKattouw>	 James_F: I'm also adding ---^^ in for SWAT today
[21:22:11] <James_F>	 RoanKattouw: Yeah. Can I be horrible and ask you to make the MW-core pull-throughs?
[21:22:15] <RoanKattouw>	 Will do
[21:22:20] <James_F>	 Thank you.
[21:22:20] <RoanKattouw>	 The wmf20 one can be made already, I'll do that
[21:22:23] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 7Verified-in-Phase0, and 3 others: Context menu moves to middle of inline selection when an inspector is opened - https://phabricator.wikimedia.org/T90857#1114878 (10Ryasmeen)
[21:22:25] <RoanKattouw>	 Once they're done I'm off to bed though
[21:22:29] <RoanKattouw>	 Not gonna stick around for SWAT
[21:22:33] <James_F>	 Sure. I'll superintend the SWAT.
[21:23:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VisualEditor core submodule to wmf/1.25wmf21 HEAD (263b194) [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196433 (owner: 10Jforrester)
[21:23:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.ViewPageTarget: Hide ve-ui-surface during activation as well [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196280 (https://phabricator.wikimedia.org/T91442) (owner: 10Jforrester)
[21:23:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent a dependent property from updating on infinite loops [extensions/TemplateData] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196434 (https://phabricator.wikimedia.org/T92558) (owner: 10Catrope)
[21:24:04] <wikibugs>	 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1114885 (10kaldari) 3NEW
[21:24:27] <wikibugs>	 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: OOjs UI and MediaWiki UI buttons are different sizes - https://phabricator.wikimedia.org/T91473#1114896 (10kaldari) 5Open>3Resolved a:3kaldari
[21:24:28] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design, and 2 others: [tracking] button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1114898 (10kaldari)
[21:24:57] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design, and 2 others: [tracking] button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1012026 (10kaldari)
[21:24:58] <wikibugs>	 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1114902 (10kaldari)
[21:25:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: "Read more" link is appearing even if the last line if the description of the image fits in the visible area - https://phabricator.wikimedia.org/T87265#1114904 (10Ryasmeen)
[21:25:56] <Krenair>	 James_F, RoanKattouw: I think swat is technically full today :/
[21:26:30] <grrrit-wm>	 (03PS4) 10Jforrester: Update VE core submodule to master (89b0629) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 
[21:27:10] <Krenair>	 oh well
[21:29:18] <RoanKattouw>	 James_F: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core+-branch:master+status:open+owner:%22Catrope+%253Croan.kattouw%2540gmail.com%253E%22,n,z
[21:29:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (89b0629) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 (owner: 10Jforrester)
[21:31:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (89b0629) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196331 (owner: 10Jforrester)
[21:35:22] <MatmaRex>	 Krinkle: ha. fixed it.
[21:36:01] <Krenair>	 Krinkle: got a moment to discuss ResourceLoader things?
[21:36:14] <Krinkle>	 MatmaRex: Thx
[21:36:17] <Krinkle>	 Krenair: Maybe
[21:36:20] <Krinkle>	 Krenair: What's up?
[21:36:45] <Krenair>	 for storing special character data we were thinking of sticking it all in a .json file in MW core
[21:36:53] <Krenair>	 and using a ResourceLoaderJSONDataModule to load it
[21:36:58] <grrrit-wm>	 (03CR) 10Catrope: Load RL modules in one load.php request, rather than in two stages (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[21:37:02] <Krenair>	 which has yet to be created
[21:38:45] <MatmaRex>	 James_F|Away: RoanKattouw: alright, so the VE toolbar is messed up in beta (the wrapping thing, and it doesn't float). i messed up some things, sorry :/ doing the fixes now, but this might be a pain to update.
[21:38:53] <Krinkle>	 Krenair: Where would such module expose the data?
[21:39:07] <RoanKattouw>	 It doesn't float :O
[21:39:22] <Krenair>	 That's the thing, I'm not sure :\
[21:39:22] <RoanKattouw>	 MatmaRex: OK well this is why we do OOUI releases on Wed/Thu
[21:39:28] <RoanKattouw>	 So we have plenty of time to fix fallout
[21:39:45] <MatmaRex>	 yeah
[21:39:52] <RoanKattouw>	 Krinkle: Current examples of modules that could be ported to this (e.g. language data) appear to mostly use function calls (e.g. mw.blahblah.set( {...} ); )
[21:40:05] <Krinkle>	 RoanKattouw: Yeah
[21:40:06] <MatmaRex>	 RoanKattouw: it doesn't float because an exception is thrown in the code that makes it floating.
[21:40:16] <RoanKattouw>	 Ouch
[21:40:27] <MatmaRex>	 because i got the order of two lines of code wrong
[21:40:28] <Krinkle>	 RoanKattouw: Krenair: Hm.. so to what extend can it be abstracted? They all have different data sources.
[21:40:37] <Krinkle>	 The logic for passing a file name, and reading/parsing the file?
[21:40:46] <Krenair>	 yeah
[21:40:55] <Krinkle>	 This would be the first module that does that
[21:41:01] <Krenair>	 and then they'd all want to have different places to expose it
[21:41:01] <Krinkle>	 language data wouldn't
[21:41:09] <Krenair>	 so...
[21:41:16] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Toolbar: Be less aggressive with 'white-space: nowrap' [oojs/ui] - 10https://gerrit.wikimedia.org/r/196445 
[21:41:17] <RoanKattouw>	 Right I guess language data is generated instead of being a file
[21:41:18] <Krenair>	 I'm wondering if this is really a good idea now
[21:41:29] <RoanKattouw>	 Krenair: Maybe it's not
[21:41:31] <Krinkle>	 I'd say go for it, and see if you end up duplicating a lot from languagedata
[21:41:48] <Krinkle>	 I mean, go for a dedicated module that exposes this, not a generic one like JSONData
[21:41:55] <Krenair>	 right
[21:41:55] <RoanKattouw>	 Maybe we should write the special characters one first, and then see what kind of generic code can be extracted from it
[21:42:13] <Krinkle>	 Krenair: I already abstracted a fair bit with regards to cache invalidation with the hash methods
[21:42:17] <RoanKattouw>	 I was maybe a bit overly trigger-happy to get you to write something generic :)
[21:42:32] <Krinkle>	 Krenair: Though unlike language data, we have an option to not read the data to determine timestamps.
[21:42:40] <Krenair>	 right
[21:42:50] <Krinkle>	 Krenair: Try not to load the file contents in the mtime method, that way modules=startup doesn't open any files.
[21:42:53] <Krenair>	 we can get the timestamp from the actual file
[21:42:58] <Krinkle>	 Yup
[21:43:09] <Krinkle>	 and maybe the filename as well, just for future sake.
[21:43:40] <Krinkle>	 There's a safeMtime method already
[21:43:49] <Krinkle>	 Though not sure if it's in abstract or in file module
[21:44:09] <Krinkle>	 It got moved to the base class so its available in your subclass
[21:44:32] <Krenair>	 I wonder if we should stick specialcharacters under mw.language somewhere
[21:44:33] <Krinkle>	 safeFilemtime *
[21:45:46] <Krinkle>	 Krenair: Yeah, possibly.
[21:45:58] <Krenair>	 I don't want to just dump it under mw somewhere :)
[21:51:54] <MatmaRex>	 RoanKattouw: okay, forgot what i said. i did implement that correctly, and it is not broken now. beta was just messed up.
[21:52:18] <grrrit-wm>	 (03CR) 10Nirzar: [C: 031] "This same fix is also needed for Apex theme. Apex ButtonSelectWidget is broken due to height:100%" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196423 (https://phabricator.wikimedia.org/T92553) (owner: 10Kaldari)
[21:52:36] <MatmaRex>	 so https://gerrit.wikimedia.org/r/#/c/196445/ is the only thing that needs to be fixed.
[21:53:33] <RoanKattouw>	 MatmaRex: That looks like it can trivially be comma-combined into the line right above?
[21:54:32] <MatmaRex>	 RoanKattouw: i guess it can, but it does something rather different
[21:54:40] <RoanKattouw>	 OK that's fair
[21:54:43] <MatmaRex>	 or rather, the selectors have nothing in common
[21:54:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Toolbar: Be less aggressive with 'white-space: nowrap' [oojs/ui] - 10https://gerrit.wikimedia.org/r/196445 (owner: 10Bartosz Dziewoński)
[21:55:24] <RoanKattouw>	 OK I should really get some sleep now
[21:55:35] <RoanKattouw>	 When James_F|Away gets back, tell him what happened
[21:56:12] <MatmaRex>	 night
[22:00:05] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 3VisualEditor 2014/15 Q3 blockers: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1115010 (10Krenair) a:3Krenair
[22:00:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Toolbar: Be less aggressive with 'white-space: nowrap' [oojs/ui] - 10https://gerrit.wikimedia.org/r/196445 (owner: 10Bartosz Dziewoński)
[22:04:36] <wikibugs>	 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 5Patch-For-Review: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox - https://phabricator.wikimedia.org/T78733#1115016 (10Jdlrobson) Disabling tests made no difference for me @Legoktm This hook is only run in test mode anyhow so that didn't surprise...
[22:12:12] <Krinkle>	 James_F: Do you know how enableObjectResizing/enableInlineTableEditing affect the editor? Some way to make things go wrong in Firefox if those are not disabled?
[22:12:25] <Krinkle>	 I don't see a difference when I comment out the disabling of those in Firefox
[22:17:04] <wikibugs>	 10OOjs-UI: Because of OOjs UI, inputboxes got too wide - https://phabricator.wikimedia.org/T92570#1115029 (10tarlocesilion) 3NEW
[22:17:53] <ankita-ks>	 HI, why are most bugs in VisualEditor listed as needs triage? Would it be a good idea to work on something that needs triage? 
[22:20:02] <ori>	 ankita-ks: that's just the default state for new bugs
[22:20:27] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "This is a problem because the icons and indicators don't have any top margin comparable to the label, making them not vertically align pro" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196423 (https://phabricator.wikimedia.org/T92553) (owner: 10Kaldari)
[22:21:50] <MatmaRex>	 ankita-ks: only 167 out of about a thousand open bugs for VE :)
[22:22:34] <ankita-ks>	 interesting...i might not have set the filters right then. 
[22:23:01] <wikibugs>	 10VisualEditor: "Cannot read property 'getSurface' of null" error when clicking in  'Insert paragraph'  Basic citation inspector - https://phabricator.wikimedia.org/T92572#1115055 (10Etonkovidova) 3NEW
[22:23:21] <MatmaRex>	 "needs triage" basically means that no one has really looked at the bug, so the report might be misleading or incorrect or something
[22:23:43] <wikibugs>	 10VisualEditor: "Cannot read property 'getSurface' of null" error when clicking in  'Insert paragraph'  in Basic citation inspector - https://phabricator.wikimedia.org/T92572#1115066 (10Etonkovidova)
[22:23:48] <wikibugs>	 10OOjs-UI: Make documentation on toolbars, tool groups, and tools - https://phabricator.wikimedia.org/T91195#1115068 (10Negative24) I'll be taking apart [[ http://tools.wmflabs.org/oojs-ui/oojs-ui/demos/#toolbars-mediawiki-vector-ltr | the demo ]] and making a bit of documentation from that. It seems to be the s...
[22:23:54] <MatmaRex>	 but if it's clear that something is a bug and you know how to fix it, then it's perfectly okay to fix those
[22:25:30] <rits>	 MatmaRex: hello as i am working on this bug set to needs triage, then should i fix it i found their icons class and just added the padding, is it right 
[22:27:46] <MatmaRex>	 rits: how would i know? i haven't seen what you changed
[22:27:53] <MatmaRex>	 i'm not even sure which bug this is about
[22:28:32] <rits>	 sorry just forgot to paste the link https://phabricator.wikimedia.org/T92027
[22:29:30] <rits>	 i have fixed the padding to 10px of the toolbar icons
[22:29:31] <wikibugs>	 10VisualEditor: "Cannot read property 'getSurface' of null" error when clicking in  'Insert paragraph'  in Basic citation inspector - https://phabricator.wikimedia.org/T92572#1115088 (10Etonkovidova) Typing in the Image Caption 'Insert paragraph' produces: TypeError: this.getRoot(...) is null
[22:30:18] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Include editing-core icon pack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196457 
[22:30:46] <MatmaRex>	 rits: please submit the patch for review to Gerrit. https://www.mediawiki.org/wiki/Gerrit
[22:31:16] <rits>	 MatmaRex: ok
[22:32:50] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Include editing-core icon pack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196457 (owner: 10Trevor Parscal)
[22:33:43] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Google's Closure Library editor does it, too:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope)
[22:33:48] <grrrit-wm>	 (03CR) 10Krinkle: "(though they do the inverse)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope)
[22:34:00] <MatmaRex>	 James_F dear, we'll need to make a OOUI release with https://gerrit.wikimedia.org/r/#/c/196445/ included soonish :(
[22:34:11] <James_F>	 MatmaRex: Just that?
[22:34:29] <James_F>	 MatmaRex: And this is just for master, or for back-porting to production?
[22:34:39] <MatmaRex>	 master
[22:34:42] <grrrit-wm>	 (03CR) 10Krinkle: "http://stackoverflow.com/a/3315596/319266" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope)
[22:34:48] <James_F>	 MatmaRex: OK, that's easy.
[22:34:51] <MatmaRex>	 and yeah, just that hopefully? are there any other regressions?
[22:35:04] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Don't disable native object editing in IE and WebKit browsers - https://phabricator.wikimedia.org/T89928#1115124 (10Jdforrester-WMF) 5Open>3Resolved
[22:35:17] <MatmaRex>	 well, i guess there are
[22:35:21] <MatmaRex>	 but more minor
[22:35:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Include editing-core icon pack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196457 (owner: 10Trevor Parscal)
[22:35:35] <MatmaRex>	 https://phabricator.wikimedia.org/T92553 https://phabricator.wikimedia.org/T92556
[22:35:56] <MatmaRex>	 not sure if these actually affect anything
[22:36:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only call execCommand() on the surface in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196105 (https://phabricator.wikimedia.org/T89928) (owner: 10Catrope)
[22:36:26] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Regression[pre-wmf21]Link icon is missing form the VE Toolbar. - https://phabricator.wikimedia.org/T92576#1115129 (10Swainr) 3NEW
[22:37:16] <Krinkle>	 http://qooxdoo.org/contrib/project/htmlarea/html_editing
[22:37:20] <Krinkle>	 Wow cool stuff
[22:37:37] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Regression[pre-wmf21]Link icon is missing form the VE Toolbar. - https://phabricator.wikimedia.org/T92576#1115139 (10Swainr) {F85993}  {F85995}
[22:37:37] <Krinkle>	 Hah, it's not just disabled in other browsers, those commands don't even exist elsewhere
[22:38:00] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Regression[pre-wmf21]Link icon is missing from VE Toolbar. - https://phabricator.wikimedia.org/T92576#1115141 (10Swainr)
[22:38:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression pre-wmf21] Link icon is missing form the VE toolbar - https://phabricator.wikimedia.org/T92576#1115145 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3TrevorParscal
[22:38:46] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression pre-wmf22] Link icon is missing form the VE toolbar - https://phabricator.wikimedia.org/T92576#1115152 (10Swainr)
[22:38:46] <TrevorParscal>	 MatmaRex: so, that whole panelLayout framed option
[22:39:00] <TrevorParscal>	 it's causing a double frame for inspectors
[22:39:04] <grrrit-wm>	 (03Abandoned) 10Jforrester: [BREAKING CHANGE] Tool: Use the LabelElement and TitledElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 (owner: 10Jforrester)
[22:39:16] <TrevorParscal>	 because inspectors are really just process dialogs
[22:39:24] <TrevorParscal>	 and process dialogs are hard coded to framed: true
[22:39:51] <grrrit-wm>	 (03PS2) 10Jforrester: [BREAKING CHANGE] ButtonWidget: remove deprecated nofollow option alias [oojs/ui] - 10https://gerrit.wikimedia.org/r/191204 (https://phabricator.wikimedia.org/T89767) (owner: 10Cscott)
[22:40:11] <TrevorParscal>	 and, honestly the framed-ness is something we should decide at the window manager level
[22:40:50] <TrevorParscal>	 so that might have been a misstep
[22:41:43] <TrevorParscal>	 not only should there be a way to configure it (rather than it being hard coded) but the WindowManager, not the Window should be where it's configured
[22:41:56] <TrevorParscal>	 and Windows are constructed before they are added to a manager
[22:42:19] <TrevorParscal>	 and PanelLayout options are currently not changeable (no methods to modify them after construction)
[22:43:11] <MatmaRex>	 uh
[22:43:42] <Negative24>	 MatmaRex: Do you know of an easy way to get the source for the OOjs UI demo?
[22:43:47] <MatmaRex>	 nothing should have changed in windows' display
[22:44:00] <TrevorParscal>	 MatmaRex: inspectors are windows inside the context
[22:44:29] <James_F>	 Negative24: It's not designed as a useful source of source code; it's written cryptically.
[22:44:30] <TrevorParscal>	 windows look the same, but because you no longer style the frame using the window manager CSS, but instead the window CSS, it's causing a double border
[22:44:56] <Negative24>	 James_F: Do you have any other options?
[22:45:05] <James_F>	 Negative24: That said, https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/demos/ is the master version of that code.
[22:45:25] <TrevorParscal>	 so, my idea is, make PanelLayout options changeable and then have Windows ask the WindowManager if it should be framed during each setup
[22:45:27] <wikibugs>	 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1115168 (10DannyH)
[22:45:33] <TrevorParscal>	 OR
[22:45:36] <Negative24>	 James_F: Thanks
[22:45:42] <TrevorParscal>	 we could return to the WindowManager controlling that CSS
[22:45:47] <TrevorParscal>	 we could make the styles a mixin
[22:46:01] <TrevorParscal>	 and not use framed for the window's panel
[22:46:07] <TrevorParscal>	 (I vote for the latter)
[22:46:16] <TrevorParscal>	 it's simpler to do the latter
[22:47:10] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References: [Regression pre-wmf21]Delete the last character after any citation and the cursor jumps to the right side of the reference editor. - https://phabricator.wikimedia.org/T92292#1115172 (10Etonkovidova) p:5Triage>3Low
[22:47:29] <MatmaRex>	 okay, that's probably sensible, but i'm trying to figure out how inspectors work again
[22:48:12] <MatmaRex>	 and how did we not have this problem before
[22:48:19] <TrevorParscal>	 they are just windows inside a DIV
[22:48:27] <TrevorParscal>	 because window managers used to provide the styling
[22:48:31] <MatmaRex>	 ooooh
[22:48:34] <MatmaRex>	 i see it now
[22:48:41] <MatmaRex>	 it's a non-modal window manager inside a popup
[22:48:56] <MatmaRex>	 non-modal windows used to not have border, now they accidentally do
[22:49:14] <TrevorParscal>	 so, we need to revert small parts of https://gerrit.wikimedia.org/r/#/c/194976/
[22:49:48] <wikibugs>	 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1115185 (10DannyH)
[22:50:13] <TrevorParscal>	 such as https://gerrit.wikimedia.org/r/#/c/194976/1/src/themes/mediawiki/windows.less,unified and https://gerrit.wikimedia.org/r/#/c/194976/1/src/themes/apex/windows.less,unified
[22:50:18] <wikibugs>	 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1066862 (10DannyH)
[22:50:21] <MatmaRex>	 yeah… basically the changes to Window and windows.less?
[22:50:34] <TrevorParscal>	 where you used to only apply these styles if they were floating modal windows
[22:51:06] <MatmaRex>	 and you'd want a mixin like FramedElement, if i understand correctly?
[22:51:07] <TrevorParscal>	 those selectors are good, the properties could be made into a mixin shared with PanelLayout in framed mode
[22:51:34] <TrevorParscal>	 no, just let WindowManager style it's windows, stop doing this with the Window's frame panel
[22:51:56] <TrevorParscal>	 this won't be needed: https://gerrit.wikimedia.org/r/#/c/194976/1/src/Window.js,unified
[22:51:58] <MatmaRex>	 yes, okay. revert all changes to windows. i'm okay with that
[22:52:02] <TrevorParscal>	 cool
[22:52:08] <TrevorParscal>	 could you do that?
[22:52:29] <MatmaRex>	 but it's not clear to me what the fate of PanelLayout changes from that would be
[22:52:35] <MatmaRex>	 sure
[22:52:48] <TrevorParscal>	 PanelLayout's new feature is fine to keep
[22:53:10] <TrevorParscal>	 and the common CSS code between the Window framing and the Panel framing can be put into a mixin in common.css and used both places
[22:53:24] <TrevorParscal>	 we just need to not use this for Window's in the way it's being done
[22:53:29] <TrevorParscal>	 and that will fix it :)
[22:53:49] <MatmaRex>	 oh, a LESS mixin, not OOjs mixin. that makes sense. :)
[22:54:22] <wikibugs>	 10MediaWiki-ResourceLoader, 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 3VisualEditor 2014/15 Q3 blockers: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1115196 (10Krenair) We decided just to share it between VE-MW and WE for now, by p...
[22:55:33] <MatmaRex>	 will do
[22:57:02] <wikibugs>	 10OOjs-UI, 10UI-Standardization: "Stepper" numeric input (numeric field with up/down controls) in OOjs-UI - https://phabricator.wikimedia.org/T92263#1115198 (10violetto)
[22:59:42] <wikibugs>	 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1115201 (10DannyH)
[22:59:45] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Window: Revert changes from 521061dd [oojs/ui] - 10https://gerrit.wikimedia.org/r/196471 
[23:00:10] <MatmaRex>	 TrevorParscal: ^ let me just try it with VE, but that should be good
[23:00:48] <TrevorParscal>	 lgtm code wise
[23:03:49] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Window: Revert changes from 521061dd [oojs/ui] - 10https://gerrit.wikimedia.org/r/196471 
[23:04:17] <MatmaRex>	 changed the apex styles to match the older ones from demo. slightly different, but i think that actually looked better.
[23:05:33] <MatmaRex>	 (seems to work as expected with VE)
[23:11:10] <grrrit-wm>	 (03PS5) 10Krinkle: core: Provide OO.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[23:11:39] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] "Fixed typo 'arr' and 'duplication' typos." [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[23:11:54] <Krinkle>	 MatmaRex: sanity check? ^
[23:13:33] <MatmaRex>	 Krinkle: looks sane
[23:13:40] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] core: Provide OO.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[23:13:50] <Krinkle>	 Oh, right. that's gonna fail
[23:13:55] <Krinkle>	 Because saucelabs
[23:15:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] core: Provide OO.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[23:26:15] <wikibugs>	 10VisualEditor, 10WikiEditor, 6Collaboration-Team, 10Flow, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1115277 (10DannyH) I added new screenshots from the prototype to T90764.  I have a question about the Mentions modal: If there are a lot...
[23:26:50] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Window: Revert changes from 521061dd [oojs/ui] - 10https://gerrit.wikimedia.org/r/196471 (owner: 10Bartosz Dziewoński)
[23:29:15] <grrrit-wm>	 (03PS10) 10Mooeypoo: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) 
[23:31:38] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers: Audit and fix events bound to CE nodes but not unbound when destroy() is called - https://phabricator.wikimedia.org/T92583#1115302 (10TrevorParscal) 3NEW a:3Catrope
[23:31:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Window: Revert changes from 521061dd [oojs/ui] - 10https://gerrit.wikimedia.org/r/196471 (owner: 10Bartosz Dziewoński)
[23:32:12] <James_F>	 Finally.
[23:33:59] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Stringify and parse rendered references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196481 (https://phabricator.wikimedia.org/T92427) 
[23:36:08] <grrrit-wm>	 (03PS1) 10Jforrester: Tag v0.9.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/196482 
[23:36:13] <James_F>	 TrevorParscal: ^^^
[23:36:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Stringify and parse rendered references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196481 (https://phabricator.wikimedia.org/T92427) (owner: 10Trevor Parscal)
[23:36:31] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Tag v0.9.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/196482 (owner: 10Jforrester)
[23:37:01] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] core: Provide OO.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[23:38:53] <grrrit-wm>	 (03PS11) 10Mooeypoo: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) 
[23:39:37] <wikibugs>	 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, 6operations: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1115326 (10Dzahn) related to the DNS work on labs i would suspect.  https://phabricator.wi...
[23:40:08] <wikibugs>	 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, 6operations: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1115328 (10Dzahn) @Coren ^ is that possible ?
[23:40:45] <mooeypoo>	 Krinkle, can you sanity check and review this TemplateData patch? It should reorganize and re-sort the problem that the earlier bug exposed, but I want to make sure someone double-checks my thought pattern here on organization. https://gerrit.wikimedia.org/r/#/c/194991/11
[23:41:07] <mooeypoo>	 Krinkle, it *should* fix the deeper problem that an earlier bug exposed.
[23:41:12] <grrrit-wm>	 (03PS2) 10Jforrester: Stringify and parse rendered references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196481 (https://phabricator.wikimedia.org/T92427) (owner: 10Trevor Parscal)
[23:41:41] <Krinkle>	 mooeypoo: OK. Will review in the next hour
[23:41:46] <mooeypoo>	 awesome, thanks
[23:42:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tag v0.9.2 [oojs/ui] - 10https://gerrit.wikimedia.org/r/196482 (owner: 10Jforrester)
[23:42:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] core: Provide OO.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[23:42:24] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt, 3VisualEditor 2014/15 Q3 blockers: Audit and fix events bound to CE nodes but not unbound when destroy() is called - https://phabricator.wikimedia.org/T92583#1115334 (10Jdforrester-WMF) p:5Triage>3High
[23:43:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Stringify and parse rendered references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196481 (https://phabricator.wikimedia.org/T92427) (owner: 10Trevor Parscal)
[23:43:54] <rits>	 hello,i made a change in a css file of the visual-editor but now on git diff its not displaying any change, any possible errors, i am stuck here 
[23:44:16] <wikibugs>	 10MediaWiki-Page-editing, 7Performance: Edit page flickers on load due JS-inserted div#wikiDiff - https://phabricator.wikimedia.org/T92552#1115344 (10Krinkle) 5Open>3Resolved
[23:45:55] <grrrit-wm>	 (03Abandoned) 10Mooeypoo: Followup to Iadc6abdcc: Allow for empty text in deprecated property [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195960 (owner: 10Mooeypoo)
[23:49:04] <grrrit-wm>	 (03CR) 10Krinkle: "T92351 - being worked on." [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[23:49:06] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References: Copy/pasting deletes references, can't save - https://phabricator.wikimedia.org/T89146#1115354 (10Etonkovidova) Can not reproduce it weither - Chrome 40, Mac.
[23:51:09] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.9.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196488 
[23:51:29] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.9.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196488 (owner: 10Jforrester)
[23:55:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.9.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196488 (owner: 10Jforrester)