[00:36:01] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] jsduck: Set --processes=0 to fix warnings-exit-nonzero [oojs/core] - 10https://gerrit.wikimedia.org/r/194813 (owner: 10Krinkle)
[00:38:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: jsduck: Set --processes=0 to fix warnings-exit-nonzero [oojs/core] - 10https://gerrit.wikimedia.org/r/194813 (owner: 10Krinkle)
[00:43:10] <grrrit-wm>	 (03PS6) 10Krinkle: core: Provide OO.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[00:43:26] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] core: Provide OO.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[00:45:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: core: Provide OO.unique for removing duplicates from arrays [oojs/core] - 10https://gerrit.wikimedia.org/r/195971 (owner: 10Esanders)
[01:02:13] <rits>	 hello, i was submitting a patch,as when i did git review -R, this error showed up
[01:02:15] <rits>	 git_review.cmd.CannotInstallHook: Problems encountered installing commit-msg hook The following command failed with exit code 255     "GET https://gerrit.wikimedia.org/tools/hooks/commit-msg"
[01:04:57] <superm401>	 rits, what's your username?
[01:05:03] <superm401>	 On Gerrit
[01:05:12] <rits>	 rits
[01:05:26] <superm401>	 What does:
[01:05:27] <superm401>	 git remote -v
[01:05:29] <superm401>	 show?
[01:06:18] <rits>	 origin	ssh://rits@gerrit.wikimedia.org:29418/mediawiki/core.git (fetch) origin
[01:06:20] <rits>	 	ssh://rits@gerrit.wikimedia.org:29418/mediawiki/core.git (push)
[01:06:44] <superm401>	 rits, you're submitting the current patch to core?
[01:06:45] <rits>	 superm401:^
[01:07:36] <rits>	 no i did to the visualeditor extension  but i did git review -R in that folder only in which i made the change
[01:07:54] <rits>	 i just did git remote -v in core
[01:08:19] <rits>	 should i do in that same folder
[01:08:32] <rits>	 git remote -v
[01:08:45] <superm401>	 rits, yes.
[01:10:12] <rits>	 origin	https://gerrit.wikimedia.org/r/p/VisualEditor/VisualEditor.git (fetch)
[01:10:14] <rits>	  origin	https://gerrit.wikimedia.org/r/p/VisualEditor/VisualEditor.git (push)
[01:10:50] <rits>	 superm401,this came
[01:11:03] <grrrit-wm>	 (03PS19) 10Krinkle: Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[01:11:26] <superm401>	 rits, run:
[01:11:34] <superm401>	 git remote set-url origin ssh://rits@gerrit.wikimedia.org:29418/VisualEditor/VisualEditor.git
[01:11:41] <superm401>	 Then try to git review again.
[01:11:56] <rits>	 ok 
[01:12:39] <grrrit-wm>	 (03PS1) 10Rits: T90896 Changed CSS of Context menu Edit button and inspector's Done button by adding a margin-right of 0.625em [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196853 
[01:12:41] <superm401>	 This is an annoying thing with Gerrit.  If it's added with http, it has to be fixed like this.
[01:14:06] <rits>	 superm401:okey i'll remember this up now, thank you so much,it worked :)
[01:14:19] <superm401>	 rits, no problem.
[01:20:01] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] "Confirmed everything still works as it should. Saves 1 request and 3KB." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[01:25:03] <grrrit-wm>	 (03PS20) 10Krinkle: Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[01:25:31] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[01:26:13] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 7Performance, and 2 others: Reduce number of load.php calls on VisualEditor open (down from 3) - https://phabricator.wikimedia.org/T53569#1119462 (10Krinkle) Saves 1 request and 3KB.  From 20 total request (512KB), to 19 total requests (518KB)....
[01:26:28] <grrrit-wm>	 (03PS3) 10Krinkle: Send Parsoid API request immediately when user clicks edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196584 (https://phabricator.wikimedia.org/T90372) (owner: 10Catrope)
[01:27:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[01:28:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Send Parsoid API request immediately when user clicks edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196584 (https://phabricator.wikimedia.org/T90372) (owner: 10Catrope)
[01:31:11] <grrrit-wm>	 (03CR) 10Krinkle: "Not yet tested but looks good, straight forward step." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196584 (https://phabricator.wikimedia.org/T90372) (owner: 10Catrope)
[02:43:12] <grrrit-wm>	 (03PS21) 10Krinkle: Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[02:43:16] <grrrit-wm>	 (03PS4) 10Krinkle: Send Parsoid API request immediately when user clicks edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196584 (https://phabricator.wikimedia.org/T90372) (owner: 10Catrope)
[02:56:33] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "PS19..21 changes look sane to me." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[03:01:06] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Sent from my phone." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[03:03:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Load RL modules in one load.php request, rather than in two stages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[03:04:11] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Combine API requests required to load VE - https://phabricator.wikimedia.org/T78628#1119484 (10Jdforrester-WMF)
[03:04:12] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Technical-Debt, and 2 others: Reduce number of load.php calls on VisualEditor open (down from 3) - https://phabricator.wikimedia.org/T53569#1119482 (10Jdforrester-WMF) 5Open>3Resolved
[03:07:14] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] Send Parsoid API request immediately when user clicks edit (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196584 (https://phabricator.wikimedia.org/T90372) (owner: 10Catrope)
[03:07:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-2] "Not until it's a proper pull-through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196723 (owner: 10Trevor Parscal)
[03:14:57] <grrrit-wm>	 (03CR) 10Aklapper: "Please fix the topic: http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196853 (owner: 10Rits)
[03:57:04] <wikibugs>	 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1119518 (10Mattflaschen) @Pginer-WMF, can you make a 24x24 user mention SVG for the toolbar icon?
[05:12:26] <wikibugs>	 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 5Patch-For-Review, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1119548 (10Mattflaschen) That patch limits us to the three icons requested.  It does also still have the menu button.  I assume we...
[05:14:14] <superm401>	 ^ Would be great if some VE people could take a look at that.  Talk to you all later.
[07:24:47] <grrrit-wm>	 (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196871 
[07:25:43] <grrrit-wm>	 (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196871 (owner: 10Legoktm)
[08:46:28] <pratikbsp>	 is it possible to modify labels in visualeditor during editing or are they set during start of visualeditor ?
[10:05:29] <wikibugs>	 10OOjs-UI: ButtonWidget with icon only looks weird (MediaWiki skin) - https://phabricator.wikimedia.org/T92556#1119639 (10Ricordisamoa) Mentioned at T91523#1110902
[11:32:20] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] Move hardcoded parsed thumbnail html from i18n to config [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader)
[11:32:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move hardcoded parsed thumbnail html from i18n to config [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader)
[12:07:12] <grrrit-wm>	 (03PS1) 10Esanders: Use store indices in annotate operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196879 
[12:08:47] <grrrit-wm>	 (03PS2) 10Rits: T90896 Fixed styling inconsistencies between context item and inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196853 
[12:25:18] <grrrit-wm>	 (03CR) 10TheDJ: "I have no problem with this if only MathSearch is using this, but I do see https://www.mediawiki.org/wiki/Extension:Math/additionalAnnotat" [extensions/Math] - 10https://gerrit.wikimedia.org/r/189348 (owner: 10Physikerwelt)
[12:32:06] <wikibugs>	 10MediaWiki-Page-editing: When the editor is editing a section, MediaWiki loses the changes and the edit summary and forgets about the section - https://phabricator.wikimedia.org/T92761#1119694 (10TheDJ)
[12:34:53] <wikibugs>	 10MediaWiki-Page-editing: When the editor is editing a section, MediaWiki loses the changes and the edit summary and forgets about the section - https://phabricator.wikimedia.org/T92761#1119696 (10TheDJ) Do you open the login page as a NEW page in a separate window or not ?  I was not able to reproduce so far. W...
[14:20:23] <wikibugs>	 10WikiEditor: Media selector doesn't find local media in private wiki - https://phabricator.wikimedia.org/T65282#1119711 (10Johanmy) I still have the same problem in version 1.25wmf17 (d70b751) e.g. typing "l" shows only two images, adding an "e" shows only one, other(!) image. In order to find a file, I have to...
[14:46:02] <grrrit-wm>	 (03PS7) 10Physikerwelt: New hook MathFormulaPostRender (replaces MathFormulaRendered) [extensions/Math] - 10https://gerrit.wikimedia.org/r/189348 
[14:48:39] <grrrit-wm>	 (03CR) 10Physikerwelt: "@TheDJ: The documentation page, was written by a NIST student, working on the DRMF project http://drmf.wmflabs.org/wiki/Main_Page. I'll ta" [extensions/Math] - 10https://gerrit.wikimedia.org/r/189348 (owner: 10Physikerwelt)
[15:15:37] <grrrit-wm>	 (03PS1) 10Physikerwelt: Add extension.json [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196886 (https://phabricator.wikimedia.org/T92762) 
[15:16:31] <grrrit-wm>	 (03PS2) 10Physikerwelt: Add extension.json [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196886 (https://phabricator.wikimedia.org/T92762) 
[15:20:42] <grrrit-wm>	 (03CR) 10Physikerwelt: "I wonder that Jeninks is happy. After the rebase, some of the files referenced in extjson do not exist anymore. So jenkins should fail." [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196886 (https://phabricator.wikimedia.org/T92762) (owner: 10Physikerwelt)
[15:29:40] <grrrit-wm>	 (03PS1) 10Esanders: Make range option in getUsedStoreValuesFromRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196887 
[15:37:04] <grrrit-wm>	 (03PS1) 10Physikerwelt: Remove API from MathSearch [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196888 
[15:39:43] <grrrit-wm>	 (03PS2) 10Physikerwelt: Remove API from MathSearch [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196888 
[15:39:58] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032] Remove API from MathSearch [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196888 (owner: 10Physikerwelt)
[15:42:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove API from MathSearch [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196888 (owner: 10Physikerwelt)
[15:45:44] <grrrit-wm>	 (03PS3) 10Physikerwelt: WIP: Add extension.json [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196886 (https://phabricator.wikimedia.org/T92762) 
[15:46:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Add extension.json [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196886 (https://phabricator.wikimedia.org/T92762) (owner: 10Physikerwelt)
[15:46:54] <grrrit-wm>	 (03PS1) 10Esanders: Store reference to DM document in transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196889 
[15:48:24] <grrrit-wm>	 (03CR) 10Physikerwelt: "Nice, Jenkins actually does his job. I have to apologize for my doubts." [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196886 (https://phabricator.wikimedia.org/T92762) (owner: 10Physikerwelt)
[15:52:09] <grrrit-wm>	 (03PS2) 10Esanders: Store reference to DM document in transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196889 
[15:53:16] <grrrit-wm>	 (03PS4) 10Physikerwelt: Add extension.json [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/196886 (https://phabricator.wikimedia.org/T92762) 
[16:06:13] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: CSS modules should be considered "ready" when they are applied to a page - https://phabricator.wikimedia.org/T92747#1119775 (10matmarex)
[16:06:14] <wikibugs>	 10MediaWiki-ResourceLoader: ResourceLoader should restrict addModuleStyles() to modules that only provide styles - https://phabricator.wikimedia.org/T92459#1119776 (10matmarex)
[16:08:45] <wikibugs>	 10VisualEditor: Keyboard shortcuts dialog should be scrollable - https://phabricator.wikimedia.org/T92723#1119778 (10Aklapper) Thanks for taking the time to report this!  Hmm, the dialog //is// scrollable here (but rather poorly displayed in Firefox 36; like the last line being cut).  If it is entirely not scrol...
[16:09:32] <wikibugs>	 10MediaWiki-ResourceLoader, 7JavaScript: CSS modules should be considered "ready" when they are applied to a page - https://phabricator.wikimedia.org/T92747#1119781 (10matmarex) This is currently the expected behavior (so: not a bug, works as designed), but the behavior is clearly suboptimal and has bitten peo...
[16:11:28] <wikibugs>	 10OOjs-UI, 10VisualEditor, 7Design: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1119783 (10Ankita-ks) Hi, where is the help-icon loaded from? Also, the icons available in the codebase are of the inverted color scheme (i.e, gray question mark on a whi...
[16:15:10] <grrrit-wm>	 (03PS2) 10Esanders: Make range optional in getUsedStoreValuesFromRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196887 
[16:15:12] <grrrit-wm>	 (03PS3) 10Esanders: Store reference to DM document in transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196889 
[16:18:46] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 8 others: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#1119789 (10GWicke) p:5High>3Normal
[16:23:13] <wikibugs>	 10VisualEditor: Keyboard shortcuts dialog should be scrollable - https://phabricator.wikimedia.org/T92723#1119796 (10tarlocesilion) 100% zoom (standard), 768px height, Firefox 35 (and the same in current 36). URL - random - e.g. https://pl.wikipedia.org/wiki/Nurmachan_Tyn%C3%A4lijew?veaction=edit  When I zoom it...
[16:24:54] <wikibugs>	 10MediaWiki-ResourceLoader: Optimize the order of styles and scripts - https://phabricator.wikimedia.org/T92764#1119805 (10Subfader)
[16:29:32] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7Epic: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1119816 (10GWicke) p:5High>3Normal
[16:53:40] <grrrit-wm>	 (03PS8) 10Physikerwelt: New hook MathFormulaPostRender (replaces MathFormulaRendered) [extensions/Math] - 10https://gerrit.wikimedia.org/r/189348 
[17:14:19] <wikibugs>	 10MediaWiki-ResourceLoader: Optimize the order of styles and scripts - https://phabricator.wikimedia.org/T92764#1119879 (10Krinkle) I'm not sure what this warning is signifying in this case.  Simplified version of the output:: ``` <head>     <meta charset="UTF-8" />     <title>MediaWiki</title>     <link rel="sh...
[17:15:40] <wikibugs>	 10MediaWiki-ResourceLoader, 7Performance: Optimize the order of styles and scripts - https://phabricator.wikimedia.org/T92764#1119883 (10Krinkle)
[17:22:04] <rits>	 hello, please review the patch https://gerrit.wikimedia.org/r/#/c/196853/,correct me if i am wrong , thank you
[17:22:53] <siddhism>	 rits: correct the link
[17:24:30] <rits>	 hello, please review the patch https://gerrit.wikimedia.org/r/#/c/196853/  ,correct me if i am wrong , thank you
[17:34:37] <Niharika>	 rits: Did you read the link Andre linked to?
[17:36:25] <rits>	 Niharika:yes i corrected the commit message 
[17:36:31] <rits>	 Niharika:is it not correct yet ?
[17:37:21] <Niharika>	 rits: No. The bug ID has to come in the last line of the commit message. See https://gerrit.wikimedia.org/r/#/c/195039/ for example. 
[17:39:03] <rits>	 Niharika:oh,ok  i missed it thanks, i will just change it
[17:40:32] <grrrit-wm>	 (03PS3) 10Rits: Fixed styling inconsistencies between context item and inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196853 (https://phabricator.wikimedia.org/T90896) 
[17:42:51] <rits>	 Niharika:fixed it, please review it  https://gerrit.wikimedia.org/r/#/c/196853/
[17:44:42] <Niharika>	 rits: That's upto someone from the VE team to review. Unreasonable to expect that to happen on Sunday. Try asking tomorrow. 
[17:45:20] <grrrit-wm>	 (03PS4) 10Esanders: Store reference to DM document in transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196889 
[17:50:32] <wikibugs>	 10VisualEditor: VisualEditor find and replace tool gets the page to auto-scroll and moves the button away from the cursor - https://phabricator.wikimedia.org/T86459#1119952 (10Rits) hello, i was working on this bug, found that this situation just arise only for the first time when the found word is out of the wi...
[17:52:15] <rits>	 Niharika: ok thank you :), i had a few doubts for this bug https://phabricator.wikimedia.org/T86459 , just posted a comment there , please review it.
[17:54:56] <Niharika>	 rits: My answer is still the same. It's upto someone from VE team to comment on. Try tomorrow. 
[17:55:09] <wikibugs>	 10WikiEditor, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1119953 (10TheDJ) 5Open>3Resolved
[17:55:31] <rits>	 Niharika: ok :)
[17:57:34] <wikibugs>	 10WikiEditor, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: Check for current presence of old IE bug in WikiEditor - https://phabricator.wikimedia.org/T88875#1119955 (10TheDJ)
[17:57:34] <wikibugs>	 10WikiEditor: WikiEditor: Replace $.client.profile().name === 'msie' with feature detection - https://phabricator.wikimedia.org/T34184#1119954 (10TheDJ)
[17:58:57] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "* I haven't looked at what this actually changes, but according to the commit message this isn't what the task asked for? It mentions "pad" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196853 (https://phabricator.wikimedia.org/T90896) (owner: 10Rits)
[18:07:49] <wikibugs>	 10WikiEditor, 6Language-Engineering: Toolbar buttons misrendering in wikitext editor in Arabic Wikipedia when user language set to LTR language - https://phabricator.wikimedia.org/T88463#1119969 (10TheDJ) This also causes trouble on https://ar.wikipedia.org/wiki/ميدياويكي:Common.css btw, which is left to right...
[18:11:49] <wikibugs>	 10WikiEditor, 7I18n: remove messages for features that aren't going to be developed - https://phabricator.wikimedia.org/T73287#1119978 (10TheDJ) 5Open>3Resolved a:3TheDJ All messages of modules that aren't actually in use (either at WMF or externally) have been removed.  Publish and side-by-side preview...
[18:12:16] <wikibugs>	 10WikiEditor: WikiEditor: ext.wikiEditor.toolbar.hideSig.js is loaded even when the enhanced editing toolbar is disabled - https://phabricator.wikimedia.org/T35923#1119983 (10TheDJ) p:5Triage>3Low
[18:12:25] <wikibugs>	 10WikiEditor: Convert WikiEditor to use extension registration - https://phabricator.wikimedia.org/T87993#1119985 (10TheDJ) p:5Triage>3Normal
[18:20:17] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor, 7Performance: wikieditor pages not being cached by browsers when they should be - https://phabricator.wikimedia.org/T71211#1119995 (10TheDJ) I'm not really seeing this, for me the version stays consistent for as long as it can be guaranteed to be consistent.  Possibl...
[18:20:54] <wikibugs>	 10OOjs-UI, 10VisualEditor, 7Design: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1119997 (10matmarex) >>! In T86693#1119196, @Ankita-ks wrote: > What css files should I be looking at if I want to work on this?   Primarily /src/themes/mediawiki/tools.l...
[18:21:05] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor, 7Performance: wikieditor pages not being cached by browsers when they should be - https://phabricator.wikimedia.org/T71211#1119998 (10TheDJ) p:5Triage>3Lowest
[18:25:07] <wikibugs>	 10MediaWiki-ResourceLoader, 10WikiEditor, 7Performance: wikieditor pages not being cached by browsers when they should be - https://phabricator.wikimedia.org/T71211#1120001 (10TheDJ) Actually, it does seem that it might be a specific version for each individual Edit page ....
[18:47:28] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance: VisualEditor:  Opening a very large complex transclusion sometimes hangs in Firefox - https://phabricator.wikimedia.org/T74401#1120023 (10Aklapper) Is this the same problem as {T71799}?
[18:47:39] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: In transclusion dialog, only suggest templates intended for use in that namespace (e.g. suppress meta-templates from content namespaces) - https://phabricator.wikimedia.org/T58516#1120026 (10Aklapper) Is this a duplicate of {T54448} (or similar enough)?
[18:48:53] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Offer to edit a transcluded page; handle that entering {{ isn't necessarily a template - https://phabricator.wikimedia.org/T92695#1120030 (10Aklapper)
[18:49:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Offer to edit a transcluded page; handle that entering {{ isn't necessarily a template - https://phabricator.wikimedia.org/T92695#1118340 (10Aklapper) Is this a duplicate of {T87130} (or the underlying problem being similar enough)?
[18:51:35] <grrrit-wm>	 (03CR) 10TheDJ: [C: 031] New hook MathFormulaPostRender (replaces MathFormulaRendered) [extensions/Math] - 10https://gerrit.wikimedia.org/r/189348 (owner: 10Physikerwelt)
[18:55:23] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1120055 (10matmarex) >>! In T88622#1112690, @Prtksxna wrote: > @MatmaRex, is there a way in `src/themes/mediawiki/MediaWikiTheme....
[18:59:16] <drobbins>	 hello :) I am getting an error: "Your wiki requires a logged-in account to access the API." when clicking the "Edit" tab.
[18:59:31] <drobbins>	 User is logged in and with appropriate rights to hit the API.
[19:00:37] <drobbins>	 I have a custom auth extension -- but I haven't seen it mess up API stuff in the past.
[19:01:30] <drobbins>	 Ah, this is probably the private wiki thing.
[19:03:01] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Templates generating non-text content, like images, are not handled correctly when deciding to show the puzzle icon - https://phabricator.wikimedia.org/T92773#1120064 (10matmarex) 3NEW
[19:07:37] <wikibugs>	 10OOjs-UI, 10Living-Style-Guide, 10UI-Standardization, 7Design: Add 'warning' or 'warn' flag to OOjs UI stylings - https://phabricator.wikimedia.org/T92026#1120077 (10matmarex)
[19:07:44] <wikibugs>	 10OOjs-UI, 10Living-Style-Guide, 10UI-Standardization, 7Design: Add 'warning' or 'warn' flag to OOjs UI stylings - https://phabricator.wikimedia.org/T92026#1101756 (10matmarex) >>! In T92026#1106965, @Jaredzimmerman-WMF wrote: > @werdna's task name was more accurate than this one.   Well, that's easily fix...
[19:09:30] <wikibugs>	 10OOjs-UI, 10Living-Style-Guide, 10UI-Standardization, 7Design: Add 'warning' or 'warn' flag to OOjs UI stylings - https://phabricator.wikimedia.org/T92026#1120080 (10matmarex) >>! In T92026#1106964, @Jaredzimmerman-WMF wrote: > This isn't specific to buttons… tipsy, icon buttons, and possibly other contro...
[19:13:49] <wikibugs>	 10MediaWiki-Page-editing, 7JavaScript, 7Regression: LivePreview: Since 1.25wmf12 the preview of the summary does not get updated on "Show changes" - https://phabricator.wikimedia.org/T84836#1120083 (10matmarex) 5Open>3Resolved
[19:13:49] <wikibugs>	 10MediaWiki-Page-editing, 10MediaWiki-RfCs, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1120085 (10matmarex)
[19:17:22] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Nitpicking :)" (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/196172 (https://phabricator.wikimedia.org/T10303) (owner: 10Gerrit Patch Uploader)
[19:18:26] <Krenair>	 drobbins, huh
[19:18:37] <Krenair>	 it should use your existing session to contact the api
[19:18:56] <Krenair>	 are you logged in, while the error is saying you're not?
[19:20:27] <drobbins>	 Krenair: I can get it working by making it a public wiki
[19:20:47] <drobbins>	 I did have cookie forwarding enabled. This setup has varnish, and maybe that is causing some cookie issues.
[19:20:50] <wikibugs>	 10OOjs-UI, 7Easy, 7Technical-Debt: Clean up after https://gerrit.wikimedia.org/r/181617 "Make icon and indicator container sizes consistent" - https://phabricator.wikimedia.org/T92774#1120088 (10matmarex) 3NEW
[19:20:56] <drobbins>	 I was trying to map it to the non-varnish api though.
[19:24:14] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Templates generating non-text content, like images, are not handled correctly when deciding to show the puzzle icon - https://phabricator.wikimedia.org/T92773#1120095 (10Mooeypoo) This was supposed to be fixed in a followup commit, and I can't reproduce it now. T...
[19:27:48] <Krenair>	 drobbins, can you open up the dev console's network tab and see what the exact response from the server is?
[19:28:19] <drobbins>	 Krenair: yes, I can. Let me get it back to that state.
[19:31:09] <drobbins>	 Krenair: I think the main issue is that parsoid is getting timeouts when hitting the API. Trying to figure out why...
[19:33:50] <drobbins>	 hrm, dunno.
[19:35:29] <drobbins>	 I can probably debug using the network tab. It is trying to hit an API url and it's just sitting there, not responding.
[19:36:39] <drobbins>	 I'm getting a 503 - backend fetch failed. LIkely from varnish.
[19:38:19] <drobbins>	 It's possible that my working varnish configuration does not work well at all for private wikis.
[19:42:06] <grrrit-wm>	 (03PS5) 10Jforrester: Send Parsoid API request immediately when user clicks edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196584 (https://phabricator.wikimedia.org/T90372) (owner: 10Catrope)
[19:42:43] <grrrit-wm>	 (03CR) 10Jforrester: Send Parsoid API request immediately when user clicks edit (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196584 (https://phabricator.wikimedia.org/T90372) (owner: 10Catrope)
[19:43:57] <drobbins>	 Okay, I think this issue is beyond parsoid, so going to start doing some non-parsoid troubleshooting first.
[19:46:08] <drobbins>	 Krenair: actually, I think that the api call is hanging.
[19:46:47] <Krenair>	 drobbins, are you able to use the API directly?
[19:46:52] <drobbins>	 Krenair: what do you mean by directly?
[19:47:12] <Krenair>	 like, can you log into the wiki, and then start browsing stuff via api.php?
[19:47:12] <drobbins>	 Yes
[19:47:12] <drobbins>	 so I figure this is some issue with the API connecting to the parsoid backend, which makes sense.
[19:47:27] <drobbins>	 I can test the URL in LocalSettings.php to make sure it's working.
[19:48:32] <Krenair>	 It's not clear to me where the issue is here.
[19:48:49] <drobbins>	 ok
[19:48:49] <drobbins>	 it is pointing to localhost:8000
[19:49:17] <Krenair>	 what is coming up in parsoid's terminal?
[19:50:55] <drobbins>	 it does appear that I am having various issues hitting api.php.
[19:51:03] <drobbins>	 Let me try restarting some things.
[19:51:21] <drobbins>	 like php-fpm.
[19:53:49] <drobbins>	 php-fpm was hosed. Not yet fixed, but at least api.php isn't dead anymore.
[19:56:26] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Offer to edit a transcluded page; handle that entering {{ isn't necessarily a template - https://phabricator.wikimedia.org/T92695#1120116 (10Krenair) I think it's a different issue.
[19:56:32] <drobbins>	 I have a feeling that granting * readapi access will fix it.
[19:59:01] <James_F>	 drobbins: Won't be great for your site security, though.
[19:59:12] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance: VisualEditor:  Opening a very large complex transclusion sometimes hangs in Firefox - https://phabricator.wikimedia.org/T74401#1120117 (10Krenair)
[19:59:13] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Performance: VisualEditor: Editing a transclusion with many templates hangs the browser - https://phabricator.wikimedia.org/T71799#1120118 (10Krenair)
[20:00:06] <drobbins>	 James_F: doesn't work, anyway.
[20:00:14] <James_F>	 :-(
[20:00:14] <drobbins>	 this is on a test wiki.
[20:02:49] <drobbins>	 will figure it out eventually.
[20:06:46] <wikibugs>	 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1120120 (10TheDJ)
[20:07:44] <wikibugs>	 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#424521 (10TheDJ) I've removed this from the RFC list, as having been mostly done already, or at the very least very far underway. Further RFC discussion seem...
[20:13:05] <Krenair>	 James_F, https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=148251&oldid=148250
[20:13:17] <Krenair>	 assuming that's ok, otherwise I'll do it in the afternoon
[20:13:20] <James_F>	 Krenair: Aha, thanks; was just about to make that commit.
[20:13:24] <James_F>	 Krenair: That's great, thank you. :-)
[20:13:50] <James_F>	 Krenair: Irritatingly gerrit doesn't have a thanks button. :-)
[20:13:55] <Krenair>	 :P
[21:27:18] <wikibugs>	 10WikiEditor: Copy-Paste: Browsers fail on HTML code paste on WikiEditor - https://phabricator.wikimedia.org/T25200#1120145 (10TheDJ) 5Open>3Invalid a:3TheDJ Closed because it is no longer relevant. Probably related to the copy and paste behavior of the iframe-based wikieditor. This has since been removed.
[21:58:30] <wikibugs>	 10WikiEditor, 7Browser-Support-Internet-Explorer: Toolbar : Special character insertion moves cursor to beginning of edit box - https://phabricator.wikimedia.org/T24479#1120182 (10TheDJ) Seems that this is still a bit fishy in IE8 today. I followed the steps:   - Click on character   - Scroll the character pal...
[21:59:45] <grrrit-wm>	 (03PS1) 10Esanders: Demo typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196962 
[22:03:17] <drobbins>	 weird. [*]['read'] = true definitely makes it work.
[22:03:23] <drobbins>	 turn that off, even with readapi on, and it doesn't work.
[22:07:39] <drobbins>	 the specific symptom I am seeing now is the progress animation loading forever. And an API call failed...
[22:08:47] <drobbins>	 okay, without ['*']['read'], this URL doesn't load: /api.php?format=json&uselang=en&action=visualeditor&paction=parse&page=Main_Page
[22:09:53] <drobbins>	 parsoid log shows "Failed API request, error code is 'ETIMEDOUT'.
[22:10:31] <drobbins>	 the parsoid log entry in full is: 
[22:10:40] <drobbins>	 [warning/api][labs/Main_Page?oldid=33] Failed API request, {"error":{"code":"ETIMEDOUT"},"retries-remaining":8}
[22:11:05] <drobbins>	 is seems like just plain old read access is required.
[22:12:42] <drobbins>	 potentially something messing with cookie forwarding, maybe Varnish.
[22:12:48] <drobbins>	 ?
[22:16:18] <Krenair>	 drobbins, so...
[22:17:06] <Krenair>	 drobbins, what request is parsoid making that fails?
[22:18:42] <grrrit-wm>	 (03CR) 10Jforrester: Demo typos (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196962 (owner: 10Esanders)
[22:18:57] <drobbins>	 I am guessing it is going through varnish and it is stripping cookies that are getting forwarded. So auth is failing, which is why enabling read fixes it.
[22:19:53] <drobbins>	 I can see an api call in the network pane, but I don't think this is parsoid.
[22:20:02] <drobbins>	 so not sure, how does one increase parsoid verbosity?
[22:21:31] <drobbins>	  /api.php?format=json&uselang=en&action=visualeditor&paction=parse&page=Main_Page << that is the call in the network pane that is hanging, looking deeper, parsoid is trying to hit the API and getting 'ETIMEDOUT'.
[22:24:05] <drobbins>	 the URL in localsettings.js is going through Varnish. Although I tried bypassing varnish using an alternate port, and that didn't seem to fix it.
[22:37:03] <wikibugs>	 10WikiEditor: WikiEditor: Allow tooltips for characters - https://phabricator.wikimedia.org/T28571#1120218 (10TheDJ) p:5Normal>3Low
[22:37:32] <drobbins>	 increased parsoid verbosity, but I'm not seeing an increase in verbosity in the logs.
[22:38:01] <wikibugs>	 10WikiEditor, 7Browser-Support-Internet-Explorer: WikiEditor styles missing in debug mode in IE - https://phabricator.wikimedia.org/T33423#1120221 (10TheDJ)
[22:39:24] <drobbins>	 this is what the web server logs are showing:
[22:39:28] <drobbins>	 *873 upstream timed out (110: Connection timed out) while reading response header from upstream, client: 127.0.0.1, server: labs.funtoo.org, request: "GET /api.php?format=json&action=query&meta=siteinfo&siprop=namespaces%7Cnamespacealiases%7Cmagicwords%7Cfunctionhooks%7Cextensiontags%7Cgeneral%7Cinterwikimap%7Clanguages%7Cprotocols&rawcontinue=1 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000",
[22:39:30] <drobbins>	 host: "labs.funtoo.org"
[22:41:15] <drobbins>	 that is one of the failures -- the other was already pasted.
[22:42:06] <wikibugs>	 10WikiEditor: toolbar section names and/or buttons wrap, obscuring textinput, if window is small - https://phabricator.wikimedia.org/T25116#1120226 (10TheDJ) 5Open>3Resolved a:3TheDJ If I understand this problem correctly, then I fixed this a long while ago. The toolbar now adds more lines if the content d...
[23:16:23] <grrrit-wm>	 (03PS1) 10TheDJ: Insert link: trim whitespace from the external link [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/196966 (https://phabricator.wikimedia.org/T25499) 
[23:54:32] <grrrit-wm>	 (03PS1) 10Legoktm: Use ResourceLoader::isModuleRegistered() [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/196970 
[23:54:58] <grrrit-wm>	 (03PS1) 10Legoktm: Use ResourceLoader::isModuleRegistered() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196971