tag. It is completely uneditable, but can be deleted or moved [19:03:31] cscott: All the praise for the bespoke editor for hieroglyphics is due unto edsanders. [19:03:45] mooeypoo:oh ok understood completely, thanks for describing so well :) [19:03:48] sort of an off-brand knock-off, with a few letters knocked out of the last name ("to reduce costs") [19:03:50] edsanders, right. There are alien nodes and alienExtension nodes [19:03:55] in VisualEditor-MediaWiki we have MWAlienExtensionNode, which is a MediaWiki extension we don't have custom support for (e.g. graph) [19:04:13] yes, thanks edsanders [19:04:16] but as all extensions are of the form content we let you edit these in a generic way [19:04:29] rits, ^^ [19:04:51] rits, if you're interested in working on the graph extension, for instance, that will be something that will help you start. [19:05:12] (ah, so edsanders is the one trying to obscure the connection between the aliens and the hieroglyphics. got it.) [19:05:14] whereas custom supoprt (e.g. the support for Math tags) allows us to show nice controls to set only available attributes [19:06:17] cscott, mwhiero support is pretty much the same as the alienextension editor, except there are not attributes, and we have custom icons and labels [19:07:11] mooeypoo:yes i am interested working for the graph extension , i have started looking into the bug https://phabricator.wikimedia.org/T92868 as described under the task [19:08:09] there are also alien selections, I think? [19:09:42] 10VisualEditor, 10Citoid: [Regression pre-wmf22] Cannot switch to VE in beta - "Cannot read property 'mw' of undefined {stack: (...)" by Citoid - https://phabricator.wikimedia.org/T92866#1122529 (10Mooeypoo) This should really be fixed in the core of the issue -- we should have some hook or event or method to... [19:11:25] rits, great, feel free to jump in here if you have any questions [19:12:10] cscott: Aliens and MWAliens are totally different things. [19:14:44] Hey guys, nuria told me about https://phabricator.wikimedia.org/T92869 but I couldn't see it 'cause it's restricted. It sounds like just a simple typo: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js#L1665 [19:15:04] that should be "navigate" instead of "navigation" according to the schema: https://meta.wikimedia.org/wiki/Schema:Edit [19:16:00] (03PS1) 10Kmenger: GroupElement: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/197113 [19:16:04] (03PS1) 10Mobrovac: Update Citoid dependencies [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/197114 (https://phabricator.wikimedia.org/T92845) [19:16:17] mooeypoo:yes thank you so much :) [19:16:54] 10VisualEditor, 10Citoid: [Regression pre-wmf22] Cannot switch to VE in beta - "Cannot read property 'mw' of undefined {stack: (...)" by Citoid - https://phabricator.wikimedia.org/T92866#1122571 (10Mvolz) This has been a continuing issue- at least that's why we loaded it "with" VisualEditor.ext.reference befor... [19:18:21] (03CR) 10Mobrovac: [C: 032 V: 032] Update Citoid dependencies [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/197114 (https://phabricator.wikimedia.org/T92845) (owner: 10Mobrovac) [19:20:57] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0: Position event not emitted after slug close - https://phabricator.wikimedia.org/T85014#1122594 (10Ryasmeen) [19:21:13] hi--I'm confused about a message I'm getting when I try to update my local build. I did a 'git checkout master' then 'git pull' and then I was told to enter a commit message to explain why the merge is necessary. This has never happened before. Can anyone tell me what I should do? [19:22:29] milimetric: from the bug report, "Krenair: Have stuck this in WMF-NDA because it contains a user agent, timestamp, page name/revision ID, etc." [19:22:57] will add you [19:23:22] done [19:23:39] milimetric: your diagnosis sounds right to me. [19:25:37] (03CR) 10Esanders: Make loading progress bar determinate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196583 (https://phabricator.wikimedia.org/T90622) (owner: 10Esanders) [19:25:41] (03PS7) 10Esanders: Make loading progress bar determinate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196583 (https://phabricator.wikimedia.org/T90622) [19:25:46] (03CR) 10jenkins-bot: [V: 04-1] Make loading progress bar determinate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196583 (https://phabricator.wikimedia.org/T90622) (owner: 10Esanders) [19:27:05] 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, and 4 others: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1122633 (10Jdforrester-WMF) [19:27:06] 10VisualEditor, 10Citoid, 6operations, 3VisualEditor 2014/15 Q3 blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1122634 (10Jdforrester-WMF) [19:27:25] Hi, can someone tell me what are mixin classes? [19:27:39] thanks Krenair, it sounds like there were a lot of those events. [19:27:42] I am sorry [19:27:46] ankita-ks: https://www.mediawiki.org/wiki/OOjs/Inheritance [19:28:00] ankita-ks: no need to apologize! [19:28:01] James_F : thanks! :) [19:28:10] ankita-ks: Good questions to ask. :-) [19:28:15] oh no. i wanted to rephrase that. :P [19:29:19] (03PS8) 10Esanders: Make loading progress bar determinate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196583 (https://phabricator.wikimedia.org/T90622) [19:29:21] (03PS2) 10Esanders: Grey-out body as soon as edit is clicked [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197073 [19:30:18] https://en.wikipedia.org/wiki/Mixin has some more general examples. It's a mechanism for multiple inheritance, so that a Button can also have a LabelElement and a TabIndexedElement and an IconElement, etc. [19:31:26] TrevorParscal: CR on appreciated! [19:31:29] technically a button *has* a label, but in oojs land, the button *is* a labelled element, and has all the methods that LabelElement does (or almost all of them). [19:31:40] ori: on it [19:31:43] James_F : so using mixin methods and functions can be selectively copied to another class? Or all of them are copied? [19:32:11] ankita-ks: for most purposes, you can just say "all of them are copied". [19:32:34] i think there are some minor exceptions having to do with the under-the-covers implementation of mixins, but nothing user-visible. [19:32:59] ankita-ks: are you interested in the JavaScript or the PHP implementation? [19:33:22] JavaScript [19:33:41] on the PHP side, the methods aren't copied, instead there is some magic that goes on under the covers when you call an "undefined method" on the PHP object, which redirects it to a method call on the appropriate mixin. [19:33:57] In JavaScript the methods are simply copied over at initialization time. [19:34:16] hmm..interesting. [19:34:20] but regardless, those are implementation details. from the user's perspective, the mixin methods just "exist" on the object. [19:34:32] one semi-magical way or another. :) [19:36:10] ah..okay..I was trying to figure out how the data-models once computed are rendered in the transclusion box. [19:37:20] Basically I am wondering how the dm and ce parts interact. Are there any relevant resources? [19:37:38] TrevorParscal: :) thanks! [19:37:38] ori: my only nitpick is, _mwq being a cryptic name [19:38:04] mw as a global was perhaps a mistake, but at least it's a pretty commonly used abbreviation for MediaWiki [19:38:05] TrevorParscal: what would you suggest? _mwInlineScriptQueue ? [19:38:17] that's already better [19:38:20] ankita-ks: we don't have nowhere near enough documentation on the internals, i'm afraid [19:38:33] the rule is this: the broader the scope of the variable, the clearer the name must be [19:38:39] ankita-ks: well, if you're interested in the actual implementation of mixins in JavaScript, the code is at https://github.com/wikimedia/oojs/blob/master/src/core.js#L92 [19:38:50] _mwq is the kind of variable one might expect to see within a closure [19:38:52] ankita-ks: for the higher-level stuff, other people here are probably better able to answer [19:39:03] not in the global scope, ephemeral or not [19:39:17] also, why the leading "_" ? [19:39:36] why not make mediawiki.js build upon mw should it already exist? [19:39:53] TrevorParscal: I meant it as a subtle nod to '_gaq', the Google Analytics event queue, which uses a similar approach. But that's a pretty obscure reference. [19:40:03] 10VisualEditor, 10Citoid: [Regression pre-wmf22] Cannot switch to VE in beta - "Cannot read property 'mw' of undefined {stack: (...)" by Citoid - https://phabricator.wikimedia.org/T92866#1122720 (10Mooeypoo) Yes, I've tried to make the new toolbar change conditional, but the error still pops up on the previous... [19:40:15] ori: _gaq _gaq _gaq [19:40:18] such that "window.mw = { inlineScriptQueue: [] };" and then later "window.mw = mw || {}"; [19:40:25] sorry, i was just clearing my throat. :) [19:40:34] cscott: ;) [19:41:12] well, Google makes mistakes every day [19:41:18] never forget that :) [19:41:30] ankita-ks: and, continuing my useless info (but for completeness) the PHP implementation of mixins is at https://github.com/wikimedia/oojs-ui/blob/master/php/Element.php#L97 [19:41:42] ankita-ks: MatmaRex wrote that, I believe. It contains some magic. [19:42:14] ori: anyway, I'm not like drawing a line in the sand, but that general best practice about naming things is something to think about [19:42:34] * ori nods [19:42:51] cscott: might be mine or TrevorParscal's [19:42:52] 10VisualEditor, 10Citoid: [Regression pre-wmf22] Cannot switch to VE in beta - "Cannot read property 'mw' of undefined {stack: (...)" by Citoid - https://phabricator.wikimedia.org/T92866#1122738 (10Mvolz) Boo :( [19:43:18] we'll say you're both magicians [19:43:23] thanks cscott , MatmaRex :) [19:43:48] I wrote that, fwiw [19:44:14] MatmaRex probably fixed it somewhere along the line though [19:44:32] lol [19:44:38] 10VisualEditor, 10Citoid: [Regression pre-wmf22] Cannot switch to VE in beta - "Cannot read property 'mw' of undefined {stack: (...)" by Citoid - https://phabricator.wikimedia.org/T92866#1122739 (10Mooeypoo) Also, Citoid's dependencies are ``` 'dependencies ' => array( 'ext.visualEditor.mwreference', 'j... [19:45:00] I had edited it at some point for the infusion code, but I think I later backed out my changes and did whatever-it-was some other way. [19:45:03] * cscott is fuzzy [19:45:26] anyway, I bet ankita-ks would ask TrevorParscal about transclusions. he probably knows more about that part than I do. [19:45:43] i'll go back into my low-level hacking hole and worry over small changes to parserTests.txt. [19:45:55] s/would ask/should ask/ [19:46:13] thanks cscott . Now I know who to bug. :) [19:47:32] James_F: So how does roll out on it and fr work in terms of mediawiki messages and adding template data? am I needed for that anywhere? [19:48:01] ankita-ks: transclusions aye? [19:48:10] mvolz: We need to write up instructions. [19:48:37] TrevorParscal: from above: "(03:36:11 PM) ankita-ks: ah..okay..I was trying to figure out how the data-models once computed are rendered in the transclusion box. Basically I am wondering how the dm and ce parts interact." [19:48:58] Yes, TrevorParscal [19:49:04] once you get above the Transaction level in VE I'm useless. :) [19:49:24] I am working on this task : https://phabricator.wikimedia.org/T52281 [19:49:43] ankita-ks: awesome [19:50:26] So I was thinking that whenever the transclusion box is being rendered, it must somehow obtain the information about all the templates and contents inside it. [19:51:04] to be clear, when you say "box" do you mean the same thing as when we often say "window" or "dialog"? [19:51:16] yes. I am sorry . [19:51:22] no worries, just wanted to be clear [19:52:10] so, yes, what goes on is we construct a ve.dm.TransclusionModel from the JSON data we got from Parsoid that was embedded in the Parsoid HTML we got from the server when we were initializing the editor [19:52:32] okay [19:52:53] that doesn't have all the information though, just template names, parameter names and values, and bits of raw wikitext that might be inbetween templates [19:53:04] okay [19:53:36] it's important to note that if one template opens a tag, any number of templates produce content, and final template closes that original tag - the whole thing is a "transclusion" [19:53:49] (03PS1) 10Physikerwelt: Reduce log output size [extensions/Math] - 10https://gerrit.wikimedia.org/r/197123 [19:54:10] and there may be any number of templates in series and sometimes even bits of raw wikitext between them [19:54:27] okay.. [19:55:15] ok, so once we construct the ve.dm.TransclusionModel (which contains 0 or more template and content parts in a sequence) we ask the TemplateData API for more information about the templates in the transclusion [19:55:17] {{echo|hello, {{echo|world}}{{!}}}} [19:55:39] this data is cached, so we only ask for things we don't already know [19:55:59] okay [19:56:17] the TemplateData API reads a JSON description that is optionally added by the template's author [19:56:28] many templates have this information now, which is awesome [19:56:54] * ragesoss is tingling with anticipation for cite-by-url. [19:58:15] sorry, battery went flat [19:58:31] np [19:59:01] so.. If there's no template data specified for a template, we fall back on just showing param names directly [19:59:44] alright [20:00:06] this particular task is talking about a situation where this.transclusionModel becomes empty [20:00:15] either initially or by the last item being removed [20:00:42] okay [20:01:15] also, what is a MWTransclusionNode ? [20:01:59] the former could be detected within onTransclusionReady, the latter within onReplacePart [20:02:56] ok, so crash course - VisualEditor has a linear model (a giant array containing every tag opening, tag closing and character of content) [20:03:06] from this we generate a tree structure [20:03:11] that's the model tree [20:03:26] ve.dm.*Node is a class all the nodes in this tree inherit from [20:03:26] alright [20:03:45] from that model tree, we also have a view tree [20:03:57] this is made of ve.ce.*Node objects [20:04:01] ce = content editable [20:04:05] dm = data model [20:04:30] the ve.dm.MWTransclusionNode is an object that represents a piece of data in the linear model [20:04:37] 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, and 4 others: Cite: Auto-filled references based on destination URL / ISBN / etc. - https://phabricator.wikimedia.org/T62768#1122855 (10Jdforrester-WMF) 5Open>3Resolved [20:05:08] the ve.ce.MWTranclusionNode is an object that provides a view/controller for a ve.dm.MWTransclusionNode [20:05:13] (03PS2) 10Physikerwelt: Reduce log output size [extensions/Math] - 10https://gerrit.wikimedia.org/r/197123 [20:05:21] [20:05:44] thank you very much! :) [20:05:47] no problem [20:05:52] that clears a lot of things [20:06:08] so, if you want to trigger a special UI for when the transclusion is empty [20:07:14] okay [20:07:21] edit ve.ui.MWTransclusionDialog.prototype.onTransclusionReady and ve.ui.MWTransclusionDialog.prototype.onReplacePart to detect when this.transclusionModel.getParts().length === 0 [20:07:33] and hide/show the UI as needed [20:07:37] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 3VisualEditor 2014/15 Q3 blockers: Load the edit HTML without wrapping it in JSON via the API - https://phabricator.wikimedia.org/T87553#1122863 (10Jdforrester-WMF) [20:07:38] 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1122864 (10Jdforrester-WMF) [20:07:38] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 3VisualEditor 2014/15 Q3 blockers: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1122865 (10Jdforrester-WMF) [20:07:50] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 3VisualEditor 2014/15 Q3 blockers: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1055763 (10Jdforrester-WMF) [20:07:56] great! on it. [20:07:57] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 3VisualEditor 2014/15 Q3 blockers: Load the edit HTML without wrapping it in JSON via the API - https://phabricator.wikimedia.org/T87553#994044 (10Jdforrester-WMF) [20:07:58] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 3VisualEditor 2014/15 Q3 blockers: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1055763 (10Jdforrester-WMF) [20:07:59] :) [20:08:04] you could, for instance detect this condition and insert a TemplatePlaceholder (as the code does in some way already) [20:08:09] 10VisualEditor, 10VisualEditor-Performance, 7Performance: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1055763 (10Jdforrester-WMF) [20:08:11] and that's an easy win [20:08:21] 10VisualEditor, 10VisualEditor-Performance, 7Performance: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1055763 (10Jdforrester-WMF) Per Roan, have merged this into {T87553}. [20:08:29] yes..that can be done [20:09:19] look at ve.ui.MWTemplateDialog.prototype.getSetupProcess [20:09:34] 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers: VisualEditor: Up and down cursor keys don't let you cursor from a focusable node into a slug - https://phabricator.wikimedia.org/T64542#1122888 (10Jdforrester-WMF) [20:09:41] 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers: Cursoring with arrows from outside a table into it and typing causes pawns - https://phabricator.wikimedia.org/T75691#1122891 (10Jdforrester-WMF) [20:10:03] see how it uses this.transclusionModel.addPart to add a new ve.dm.MWTemplatePlaceholderModel in the case where the transclusion would otherwise be empty [20:10:45] you really just need to do the same thing within onReplacePart to cover the case where the transclusion is being made empty [20:10:47] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [Regression pre-wmf15] New section is not getting added while trying to attempt add one for the first time in a page - https://phabricator.wikimedia.org/T86566#1122895 (10Jdforrester-WMF) 5Invalid>3Resolved [20:11:00] also, beware, addPart is async [20:11:15] and will eventually trigger onReplacePart [20:11:23] this should be fine, but just something to understand [20:11:32] good luck, let me know if you need more help [20:11:40] edsanders|away: https://phabricator.wikimedia.org/T89352 is the last 40-pointer that doesn't have any work done on it yet. Thoughts? [20:12:23] okay! Thanks again TrevorParscal :) [20:12:29] anytime [20:12:31] * ankita-ks takes all the knowledge in [20:12:37] glad to have you around [20:12:46] :) [20:12:53] I've got a worrisome problem report here: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#.3Cspan_lang.3D.22FR.22.3E_repeatedly_and_other_things [20:13:08] [[MediaWiki:Badtitletext|,]] seems to be back. [20:14:31] (03PS1) 10Ori.livneh: Report metrics using StatsD [services/citoid] - 10https://gerrit.wikimedia.org/r/197126 [20:14:37] mvolz, James_F ^ [20:14:52] (03PS2) 10Ori.livneh: Report metrics using StatsD [services/citoid] - 10https://gerrit.wikimedia.org/r/197126 [20:17:45] (03PS1) 10Kmenger: IndicatorElement: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/197128 [20:18:15] ori: That's remarkably simple and concise. [20:18:21] mooeypoo: how's the citation stuff going? [20:18:50] TrevorParscal: She's lunching right now. [20:19:02] no worries.. [20:21:25] (03CR) 10Ori.livneh: [C: 031] Grey-out body as soon as edit is clicked (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197073 (owner: 10Esanders) [20:24:43] (03PS3) 10Physikerwelt: Reduce log output size [extensions/Math] - 10https://gerrit.wikimedia.org/r/197123 [20:27:46] is VE broken on beta? [20:28:17] yup [20:28:23] https://phabricator.wikimedia.org/T92866#1122199 [20:30:05] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 5Patch-For-Review: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox - https://phabricator.wikimedia.org/T78733#1122962 (10dduvall) @Jdlrobson can you provide the URL of the request that's taking so long? I fear we're all working off the same symptom... [20:30:41] (03PS4) 10Physikerwelt: Simplify logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/197123 [20:35:02] eh [20:36:08] I will be done with this task in at most a couple of days: https://phabricator.wikimedia.org/T52281 . Is it possible that it could be assigned to me? [20:36:29] 10OOjs-UI, 7Technical-Debt: Create a generalised multi-select widget - https://phabricator.wikimedia.org/T91147#1122982 (10Jdforrester-WMF) [20:36:30] 10OOjs-UI: File upload widget - https://phabricator.wikimedia.org/T91146#1122981 (10Jdforrester-WMF) [20:36:30] 10OOjs-UI: OO.ui.DropdownWidget doesn't respond to typing like