[00:02:29] <grrrit-wm>	 (03Abandoned) 10MarkAHershberger: Address an exception seen in IE when copy-pasting line endings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197375 (https://phabricator.wikimedia.org/T92969) (owner: 10MarkAHershberger)
[00:12:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Expand annotation beyond a word if it exists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197425 (https://phabricator.wikimedia.org/T86399) (owner: 10Mooeypoo)
[00:12:54] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor: Adding a link right before a wikilinked word leads to unexpected results, including a nowiki - https://phabricator.wikimedia.org/T72286#1126980 (10Jdforrester-WMF)
[00:12:56] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Wordbreak detection is faulty for selection starting just up-page of a link annotation - https://phabricator.wikimedia.org/T86399#1126978 (10Jdforrester-WMF)...
[00:14:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Expand annotation beyond a word if it exists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197425 (https://phabricator.wikimedia.org/T86399) (owner: 10Mooeypoo)
[00:15:37] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (95d161f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197445 
[00:20:02] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor: Adding a link right before a wikilinked word leads to unexpected results, including a nowiki - https://phabricator.wikimedia.org/T72286#1127001 (10Mooeypoo) 5Open>3Resolved a:3Mooeypoo Resolved with this: https://gerrit.wikimedia.org/r/#/c/197425
[00:20:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "This looks strangely familiar. :-)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/197441 (owner: 10Bartosz Dziewoński)
[00:22:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): VisualEditor: Adding a link right before a wikilinked word leads to unexpected results, including a nowiki - https://phabricator.wikimedia.org/T72286#1127004 (10Jdforrester-WMF)
[00:22:42] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): VisualEditor: Adding a link right before a wikilinked word leads to unexpected results, including a nowiki - https://phabricator.wikimedia.org/T72286#746252 (10Jdforrester-WMF)
[00:22:56] <rits>	 hello, as i inserted a graph on the wiki page through the edit  source and when i started editing the graph doesn't shows up but thats because of the alien node behaviour but when i edited something like a line
[00:23:03] <rits>	  and saved the page the graph does not shows up in the edited page its just gone,is that how the alien node work why is it not showing up after the page is saved
[00:24:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: demo: Add one more toolbars demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/197441 (owner: 10Bartosz Dziewoński)
[00:24:30] <wikibugs>	 10VisualEditor, 7Mobile: JS exception in mobile site - https://phabricator.wikimedia.org/T93031#1127020 (10Jdlrobson) 3NEW
[00:24:33] <James_F>	 mooeypoo: https://phabricator.wikimedia.org/T78202
[00:24:38] <James_F>	 mooeypoo: https://phabricator.wikimedia.org/T89352
[00:24:43] <wikibugs>	 10VisualEditor, 7Mobile: JS exception in mobile site - https://phabricator.wikimedia.org/T93031#1127028 (10Jdlrobson)
[00:27:01] <wikibugs>	 10VisualEditor, 7Mobile: JS exception in mobile site - https://phabricator.wikimedia.org/T93031#1127033 (10Jdforrester-WMF) p:5Triage>3Unbreak!
[00:28:21] <grrrit-wm>	 (03PS1) 10Esanders: Add handlers for font annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197447 (https://phabricator.wikimedia.org/T92969) 
[00:31:24] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (95d161f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197445 (owner: 10Jforrester)
[00:33:23] <wikibugs>	 10OOjs-UI: OOJS UI: Create a toolbar in demo page which looks like VE toolbar.  - https://phabricator.wikimedia.org/T93033#1127046 (10Nirzar) 3NEW
[00:33:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (95d161f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197445 (owner: 10Jforrester)
[00:35:57] <RoanKattouw>	 mooeypoo: I hear there's a problem with TargetLoader and mobile? What's going on?
[00:36:08] <mooeypoo>	 MobileFrontend is crashing
[00:36:16] <mooeypoo>	 not even on VE, on view page
[00:36:21] <RoanKattouw>	 Oh I see the bot reporting the task now
[00:36:22] <mooeypoo>	 TypeError: Cannot set property 'targetLoader' of undefined TypeError: Cannot set property 'targetLoader' of undefined {stack: (...), message: "Cannot set property 'targetLoader' of undefined"}
[00:36:34] <mooeypoo>	 I was thinking it's the missing dependency of targetLoader
[00:36:36] <RoanKattouw>	 Oh, hmm
[00:36:37] <mooeypoo>	 but that didn't work out
[00:36:45] <RoanKattouw>	 Yeah it kind of depends on init init but not really
[00:36:50] <RoanKattouw>	 What is depending on TargetLoader though?
[00:37:09] <RoanKattouw>	 Oh mw.Target does of course 
[00:37:10] <RoanKattouw>	 Sigh
[00:37:21] <mooeypoo>	 I *thought* MobileFrontend should depend on it, but adding that dependency doesn't work
[00:37:41] <RoanKattouw>	 No no
[00:38:12] <RoanKattouw>	 I have a quick hack
[00:38:21] <mooeypoo>	 oh, ok
[00:38:45] <Krenair>	 hey milimetric, are you guys still seeing invalid events? it should be OK now
[00:38:53] <Krenair>	 (VE abort ones, specifically)
[00:38:54] <grrrit-wm>	 (03PS1) 10Catrope: Unbreak TargetLoader when ViewPageTarget.init isn't present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197450 
[00:39:04] <Krenair>	 if not we can close that task
[00:39:17] <RoanKattouw>	 mooeypoo: There, that ---^^
[00:39:55] <mooeypoo>	 Checked, works
[00:40:12] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] "Works" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197450 (owner: 10Catrope)
[00:40:36] <grrrit-wm>	 (03PS1) 10Mooeypoo: Unbreak TargetLoader when ViewPageTarget.init isn't present [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197451 
[00:40:49] <mooeypoo>	 thanks RoanKattouw !
[00:41:18] <grrrit-wm>	 (03PS2) 10Jforrester: Unbreak TargetLoader when ViewPageTarget.init isn't present [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197451 (https://phabricator.wikimedia.org/T93031) (owner: 10Mooeypoo)
[00:41:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Unbreak TargetLoader when ViewPageTarget.init isn't present [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197451 (https://phabricator.wikimedia.org/T93031) (owner: 10Mooeypoo)
[00:42:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Unbreak TargetLoader when ViewPageTarget.init isn't present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197450 (owner: 10Catrope)
[00:43:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Unbreak TargetLoader when ViewPageTarget.init isn't present [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197451 (https://phabricator.wikimedia.org/T93031) (owner: 10Mooeypoo)
[00:45:47] <Krenair>	 RoanKattouw, okay so I've been going over what you said earlier re. revision ids/timestamps
[00:46:01] <Krenair>	 it looks like we already pass the latest revision timestamp as basetimestamp
[00:46:10] <Krenair>	 or wfTimestampNow() if we're creating the page
[00:46:34] <Krenair>	 just needs the latest revision ID I think
[00:47:07] <RoanKattouw>	 Yeah
[00:47:15] <RoanKattouw>	 So there's one subtlely there
[00:47:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Mobile, 3VisualEditor 2014/15 Q3 blockers, and 2 others: JS exception in mobile site - https://phabricator.wikimedia.org/T93031#1127082 (10Jdforrester-WMF) 5Open>3Resolved a:3Catrope
[00:48:26] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Mobile, 3VisualEditor 2014/15 Q3 blockers, and 2 others: JS exception in mobile site - https://phabricator.wikimedia.org/T93031#1127020 (10Jdforrester-WMF)
[00:48:46] <RoanKattouw>	 When a race condition occurs where we are trying to edit the latest version of the page but obtain HTML from RB that's for a slightly older version
[00:49:11] <RoanKattouw>	 (possibly because RB is a bit behind or possibly because an actual race condition occurred and the new rev was created after the RB request but before the API request)
[00:49:27] <RoanKattouw>	 then the basetimestamp we should use is that rev's timestamp, not the real latest rev's timestamp
[00:49:41] <RoanKattouw>	 This is only relevant when we fetch HTML separately from RB
[00:50:00] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Report metrics using StatsD [services/citoid] - 10https://gerrit.wikimedia.org/r/197126 (https://phabricator.wikimedia.org/T87496) (owner: 10Ori.livneh)
[00:50:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Report metrics using StatsD [services/citoid] - 10https://gerrit.wikimedia.org/r/197126 (https://phabricator.wikimedia.org/T87496) (owner: 10Ori.livneh)
[00:50:55] <wikibugs>	 10VisualEditor, 10Citoid, 6operations, 3VisualEditor 2014/15 Q3 blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1127102 (10Jdforrester-WMF)
[00:51:33] <wikibugs>	 10VisualEditor, 10Citoid, 6operations, 3VisualEditor 2014/15 Q3 blockers: Improve citoid production service - https://phabricator.wikimedia.org/T90281#1127104 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF All dependencies closed. Marking as fixed.
[00:52:49] <Krenair>	 RoanKattouw, ok so... do I need to do something different?
[00:53:03] <RoanKattouw>	 For now, no
[00:53:04] <RoanKattouw>	 Well
[00:53:07] <grrrit-wm>	 (03PS4) 10Physikerwelt: Update to new hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/197429 
[00:53:20] <RoanKattouw>	 No, not for now
[00:54:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update to new hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/197429 (owner: 10Physikerwelt)
[00:56:21] <grrrit-wm>	 (03PS5) 10Physikerwelt: Update to new hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/197429 
[00:56:43] <grrrit-wm>	 (03PS6) 10Physikerwelt: Update to new hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/197429 
[00:57:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update to new hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/197429 (owner: 10Physikerwelt)
[01:00:55] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Add handlers for font annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197447 (https://phabricator.wikimedia.org/T92969) (owner: 10Esanders)
[01:02:01] <Krenair>	 hm, I still have that issue where if I focus a citation node it breaks a large part of the page
[01:02:09] <Krenair>	 but only on my local wiki, not beta
[01:02:11] <Krenair>	 very weird
[01:04:09] <James_F>	 Krenair: Have you got an old version of Cite/Parsoid/Citoid/something?
[01:04:18] <Krenair>	 Maybe.
[01:04:34] <Krenair>	 I don't think Parsoid can do this much damage :D
[01:04:39] <Krenair>	 Citoid is not installed
[01:05:43] <Krenair>	 James_F, so basically I focus this node, and the majority of the text on the page is moved inside the inspector
[01:06:10] <grrrit-wm>	 (03PS7) 10Physikerwelt: Update to new hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/197429 
[01:06:23] <James_F>	 Krenair: That is… very bad, yes.
[01:06:29] <James_F>	 Krenair: Totally clean VE, VE-MW?
[01:06:51] <Krenair>	 no, I'm working :p
[01:07:10] <Krenair>	 base is 331351703b04fe12e9fa7843adffb5bcb8ef2f04 (merged a few hours ago), VE core is unmodified
[01:07:28] * James_F grins.
[01:07:57] <Krenair>	 James_F, http://i.imgur.com/Sa5GaOi.png
[01:08:16] <Krenair>	 That's not Parsoid's work.
[01:09:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web: [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1127171 (10Jdforrester-WMF)
[01:09:12] <James_F>	 RoanKattouw: https://phabricator.wikimedia.orgT93036 :-(
[01:09:56] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032] "wow, ps 7.... and I thought it would be trival to fix the test." [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/197429 (owner: 10Physikerwelt)
[01:10:02] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-18_(1.25wmf22): No longer possible to convert an auto-numbered link to one with a label - https://phabricator.wikimedia.org/T92525#1127179 (10Jdforrester-WMF) p:5Triage>3High
[01:10:11] <wikibugs>	 10OOjs-UI, 10OOjs-UI-0.9.1, 5WMF-deploy-2015-03-18_(1.25wmf22): Various widgets refuse to tab to other widgets - https://phabricator.wikimedia.org/T92449#1127180 (10Jdforrester-WMF) p:5Triage>3Normal
[01:10:47] <Krenair>	 RoanKattouw, editingold looks like it's going to be fun to parse on the client side
[01:10:47] <Krenair>	 could just pass it from the server, of course :(
[01:10:48] <Krenair>	 I am very suspicious of mw.message.
[01:11:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update to new hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/197429 (owner: 10Physikerwelt)
[01:11:35] <RoanKattouw>	 Oh is it a parsed message?
[01:11:55] <wikibugs>	 10VisualEditor, 10Utilities-UnicodeJS, 3VisualEditor 2014/15 Q3 blockers: Wordbreak detection is faulty for selection starting just down-page of a single character - https://phabricator.wikimedia.org/T78202#1127184 (10Jdforrester-WMF) p:5Normal>3High
[01:11:55] <Krenair>	 <strong>Warning: You are editing an out-of-date revision of this page.</strong>
[01:11:56] <Krenair>	 If you save it, any changes made since this revision will be lost.
[01:12:17] <RoanKattouw>	 It's an {{fmbox}} call on enwiki
[01:12:45] <Krenair>	 >_>
[01:12:55] <Krenair>	 Great.
[01:12:59] <Krenair>	 Needs server parsing then.
[01:13:40] <Krenair>	 I think the default one would work if mw.message had a parseAsBlock equivalent
[01:14:23] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance: Current status and retrospective of VisualEditor performance - https://phabricator.wikimedia.org/T93012#1127194 (10Jdforrester-WMF) p:5Triage>3High
[01:17:29] <RoanKattouw>	 Ugh, messages
[01:17:32] <RoanKattouw>	 Why must they suck so much
[01:17:46] <Krenair>	 Will just have to pass 'editingoldmsg' along with content, basetimestamp, etc...
[01:17:54] <RoanKattouw>	 Well, I mean
[01:18:03] <RoanKattouw>	 We could do it only if it's an oldid
[01:18:15] <RoanKattouw>	 an oldid that !== the latest revid even
[01:20:10] <Krenair>	 RoanKattouw, remind me why we are doing this on the client?
[01:21:00] <Krinkle>	 "Utilities-UnicodeJS" ?
[01:21:31] <Krenair>	 RoanKattouw, for when we download this all from Restbase?
[01:21:48] <RoanKattouw>	 Yeah
[01:22:04] <RoanKattouw>	 To be fair editingold can probably stay on the server now that I think about it
[01:22:19] <Krenair>	 we need to handle the case where the API returns data for a different rev ID?
[01:22:32] <gwicke>	 Krenair: there is a race condition there
[01:22:39] <RoanKattouw>	 Yeah we need to be able to handle cases where the API data and the RB HTML are for different revs
[01:22:43] <Krenair>	 A lot of the stuff returned there will break in that case.
[01:22:47] <Krenair>	 Not just editingold
[01:22:49] <RoanKattouw>	 I mean in that case I guess we will detect and rereques
[01:22:51] <RoanKattouw>	 t
[01:23:00] <gwicke>	 imagine an event like Michael Jackson dying, and everybody trying to edit the same page
[01:23:00] <Krenair>	 yes
[01:23:04] <RoanKattouw>	 Well what I'm concerned about is editingold and basetimestamp
[01:23:09] <RoanKattouw>	 What else is there?
[01:23:18] <RoanKattouw>	 Hmm I guess there's link data
[01:23:23] <Krenair>	 all the notices which depend on the current state of the page
[01:24:04] <RoanKattouw>	 Oh right some of them depend on existence
[01:24:10] <Krenair>	 page existence, protection...
[01:25:19] <Krenair>	 I think in that case we just re-request the provided from restbase using the provided rev id
[01:25:28] <Krenair>	 the parsoid html from restbase*
[01:29:07] * gwicke nods
[01:36:17] <RoanKattouw>	 Yeah
[01:36:52] <RoanKattouw>	 Re-request whichever one gave you the older data, using the revid you got from the newer one
[01:40:58] <wikibugs>	 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1127249 (10EBernhardson) a:3EBernhardson
[01:41:24] <wikibugs>	 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1066843 (10EBernhardson) what should the interface for switching look like?
[01:47:29] <wikibugs>	 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1127254 (10Mattflaschen)
[02:03:45] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: VE in IE is stripping the contents of <font> tags from pasted text - https://phabricator.wikimedia.org/T92969#1127270 (10Jdforrester-WMF) p:5Triage>3Normal
[02:12:33] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests, 5Patch-For-Review: Enable VE in ns 102 (WikiProject) on plwiki - https://phabricator.wikimedia.org/T92698#1127301 (10Jdforrester-WMF)
[02:12:38] <wikibugs>	 10VisualEditor, 10Wikimedia-Site-requests, 5Patch-For-Review: Enable VE in ns 102 (WikiProject) on plwiki - https://phabricator.wikimedia.org/T92698#1127302 (10Jdforrester-WMF) a:3Jdforrester-WMF
[02:13:49] <wikibugs>	 10VisualEditor, 10Citoid: Lookup is returning invalid url in Autofill Citation dialog - https://phabricator.wikimedia.org/T93005#1127306 (10Jdforrester-WMF) p:5Triage>3Unbreak!
[02:14:05] <wikibugs>	 10VisualEditor: [Regression pre-wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog - https://phabricator.wikimedia.org/T93002#1127309 (10Jdforrester-WMF) p:5Triage>3High
[02:14:14] <wikibugs>	 10OOjs-UI, 10VisualEditor: [Regression pre-wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog - https://phabricator.wikimedia.org/T93002#1127310 (10Jdforrester-WMF) p:5High>3Normal
[02:14:32] <wikibugs>	 10VisualEditor: Link inspector does not close while placing the cursor on the same line (for empty line) and also it shifts the cursor to the left after typing the first character on CE while the inspector is open - https://phabricator.wikimedia.org/T93013#1127312 (10Jdforrester-WMF) p:5Triage>3Normal
[02:14:59] <wikibugs>	 10VisualEditor, 10Citoid: Lookup is returning invalid url in Autofill Citation dialog - https://phabricator.wikimedia.org/T93005#1127314 (10Jdforrester-WMF) a:3Mooeypoo
[02:23:47] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Visual Editor special character at ln: - https://phabricator.wikimedia.org/T92959#1127327 (10Krenair) Are the changes made to that page just not taking effect inside VE?
[02:26:24] <wikibugs>	 10VisualEditor, 10MediaWiki-ContentHandler, 10MediaWiki-Internationalization: Default content model should apply to to non-customised messages in the MediaWiki: namespace - https://phabricator.wikimedia.org/T92899#1127329 (10Krenair)
[02:26:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Insert a new references list immediately, rather than showing a dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196366 (https://phabricator.wikimedia.org/T71727) (owner: 10Bartosz Dziewoński)
[02:27:11] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 5WMF-deploy-2015-03-18_(1.25wmf22): Have the References list tool insert a general references list (99% action), rather than stopping to ask the user about which group to use - https://phabricator.wikimedia.org/T71727#1127331 (10Jdforrester-WMF) 5Open>3...
[02:27:28] <wikibugs>	 10VisualEditor, 10MediaWiki-ContentHandler, 10MediaWiki-Internationalization: Default content model should apply to to non-customised messages in the MediaWiki: namespace - https://phabricator.wikimedia.org/T92899#1127333 (10Krenair)
[02:28:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Insert a new references list immediately, rather than showing a dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196366 (https://phabricator.wikimedia.org/T71727) (owner: 10Bartosz Dziewoński)
[02:37:56] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Move oldid/timestamp inference from API module to client-side JS - https://phabricator.wikimedia.org/T92993#1127342 (10Krenair) The revision's timestamp should be in the parsoid HTML so it can be edited without having to get more data from the API. (The API re...
[02:39:46] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Move oldid/timestamp inference from API module to client-side JS - https://phabricator.wikimedia.org/T92993#1127344 (10Krenair) >>! In T92993#1127342, @Krenair wrote: > The API requires it for conflict detection.  {T34037}
[02:50:08] <grrrit-wm>	 (03PS1) 10Mattflaschen: LookupElement: Add optional config field for suggestions when empty [oojs/ui] - 10https://gerrit.wikimedia.org/r/197475 (https://phabricator.wikimedia.org/T92588) 
[02:52:54] <grrrit-wm>	 (03CR) 10Alex Monk: WIP - Load all of WikiEditor's special characters (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91618) (owner: 10Alex Monk)
[02:53:18] <grrrit-wm>	 (03PS2) 10Alex Monk: WIP - Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) 
[02:54:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP - Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[02:55:02] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] "TODO:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[02:56:31] <Krenair>	 Krinkle, any idea what this test failure is? https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/14459/console
[02:56:34] <Krenair>	 I've seen it before
[02:57:36] <Krinkle>	 Krenair: it means either a dependency is not loaded (maybe an outdated ve-core commit) or a race condition of something using platform singleton when it is not yet available since it is instantiated async
[02:58:01] <Krenair>	 would a missing message cause that to fail?
[02:58:20] <Krinkle>	 Seems unlikely
[02:58:36] <Krenair>	 hm
[02:58:36] <Krinkle>	 Check erorr logs in the artefacts to be sure: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/14459/
[02:58:42] <Krinkle>	 (log in first)
[02:58:50] <Krinkle>	 debug-www
[02:59:32] <Krenair>	 Is this another wmf-only jenkins feature?
[03:00:15] <Krinkle>	 I don't think it is.
[03:00:41] <Krenair>	 Just need to login first? :/
[03:00:52] <Krinkle>	 To view artefacts, yes
[03:00:54] <Krinkle>	 standard ldap
[03:01:39] <Krenair>	 there are some weird errors in here like DB stuff
[03:10:58] <Krinkle>	 yeah, those are known but shouldn't affect the run
[03:11:01] <Krinkle>	 Krenair: recheck to be sure
[03:11:16] <Krinkle>	 Those db errors have been by focus for over a month now.
[03:12:15] <grrrit-wm>	 (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[04:05:51] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Link inspector won't open after placing cursor on another link while the link inspector is open, cannot inspect any other... - https://phabricator.wikimedia.org/T93011#1127391
[04:06:24] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-03-18_(1.25wmf22): No longer possible to convert an auto-numbered link to one with a label - https://phabricator.wikimedia.org/T92525#1127393 (10Ryasmeen) Verified the fix in Betalabs
[04:10:29] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Selecting an inspector while another inspector is open shows both inspector buttons as 'clicked' - https://phabricator.wikimedia.org/T93016#1127399 (10Ryasmeen) Verified the fix in Betalabs
[04:34:33] <wikibugs>	 10VisualEditor: Slugs should not be visible through context menu - https://phabricator.wikimedia.org/T93042#1127402 (10Ryasmeen)
[04:35:29] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Set a maxsize on the context menu display for references, as it can go pretty bad with nested nodes lik... - https://phabricator.wikimedia.org/T91337#1127413
[04:37:41] <grrrit-wm>	 (03PS1) 10Alex Monk: Load special characters in Platform instead of SpecialCharacterDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197478 (https://phabricator.wikimedia.org/T91608) 
[04:38:12] <grrrit-wm>	 (03CR) 10Alex Monk: "core change in I75f80132" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[06:39:21] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: VisualEditor: Unnecessary <span>s inserted into articles - https://phabricator.wikimedia.org/T71494#1127507 (10Whatamidoing-WMF) This has suddenly started happening all over the place.  It's also adding language codes.  It might be related to copying.  I've de...
[06:42:07] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1127514 (10Whatamidoing-WMF) 3NEW
[06:47:02] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: VisualEditor: Unnecessary <span>s inserted into articles - https://phabricator.wikimedia.org/T71494#1127527 (10Whatamidoing-WMF) https://fr.wikipedia.org/w/index.php?title=Zach_Galifianakis&diff=next&oldid=112817147 adds left-to-right code.    https://fr.wikip...
[06:55:32] <wikibugs>	 10VisualEditor: Newly made links are red until page is saved - https://phabricator.wikimedia.org/T75741#1127532 (10Whatamidoing-WMF) 5Invalid>3Open This has re-appeared.  You can read the editor's report at https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=651892335#Weird_bug_w...
[08:08:13] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentLanguage: Create wiki page to document VE manual IME test procedure and results - https://phabricator.wikimedia.org/T92486#1127655 (10dchan) Done: https://www.mediawiki.org/wiki/VisualEditor/IME_Testing
[08:08:44] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentLanguage: Create wiki page to document VE manual IME test procedure and results - https://phabricator.wikimedia.org/T92486#1127656 (10dchan) 5Open>3Resolved
[08:51:38] <grrrit-wm>	 (03PS1) 10Esanders: Remove font tags on import (paste/drop) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197485 
[09:33:51] <Kostic>	 Good day. Does anybody know how can I make Lockdown extension to play nice with VisualEditor? VisualEditor doesn't work on pages that are 'protected' with Lockdown. Mediawiki 1.24.1
[09:48:21] <Kostic>	 :(
[10:00:36] <Kostic>	 Okay, what action parameters from list: http://www.mediawiki.org/wiki/Manual:Parameters_to_index.php#Actions are required so VisualEditor can run?
[10:01:40] <grrrit-wm>	 (03CR) 10Perhelion: [C: 031] Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[11:18:56] <werdna>	 Kostic: I use Lockdown and I don't have this problem
[11:19:03] <werdna>	 Kostic: what's actually happening when you say "doesn't work"
[11:19:20] <werdna>	 otherwise I'll suggest you start paying it more or blocking facebook for it ;-)
[11:20:23] <Kostic>	 werdna: pages that are 'protected' by Lockdown can't be edited via "Edit" button at the top (the VisualEditor button) or by appending ?veaction=edit to the page url.
[11:20:34] <Kostic>	 werdna: I do not understand the reference to facebook.
[11:20:39] <werdna>	 what do you mean "can't be edited"
[11:20:45] <werdna>	 does the button do nothing?
[11:20:51] <werdna>	 does it give you an error message?
[11:20:53] <Kostic>	 And I'm sorry if I sound like a whining customer.
[11:20:53] <werdna>	 a blank page?
[11:20:59] <werdna>	 does something happen that you don't expect
[11:21:05] <werdna>	 oh no, no whining, I'm just making a joke
[11:21:33] <werdna>	 (if it isn't working/doing its job, then maybe it's slacking off)
[11:21:36] <Kostic>	 werdna: No, it just reloads the page. I can edit page in WikiEditor without a problem but I can't do the same with VisualEditor.
[11:21:44] <Kostic>	 Ahhh.... :D
[11:21:55] <Kostic>	 I now understand. Sorry, not a native English speaker.
[11:22:03] <werdna>	 it's okay
[11:22:14] <werdna>	 have you tried opening the debug console in your browser? do you get an error message?
[11:22:30] <werdna>	 is your page, per chance, read restricted?
[11:22:41] <Kostic>	 One more detail, I'm also using AccessControlPanel which is a 'frontend' to Lockdown extension.
[11:22:41] <werdna>	 because if that's the case then you need to do something special so that Parsoid can get the content
[11:22:51] <Kostic>	 werdna: yes.
[11:23:04] <werdna>	 https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid_in_private_wikis
[11:23:15] <Kostic>	 Only one group (beside sysop) can read pages in that namespace.
[11:23:52] <werdna>	 https://www.mediawiki.org/wiki/Extension:VisualEditor#Complete_configuration_options
[11:24:02] <werdna>	 you need to read those two sections of the page, that will help you.
[11:24:30] <werdna>	 the problem is that Parsoid is an external service, and it is not able to read the pages because it doesn't have credentials
[11:24:33] <Kostic>	 I have already read the whoe parsoid section but I haven't installed the parsoid php extension.
[11:24:47] <Kostic>	 I know. I spent the whole day configuring node and parsoid on Centos 6.
[11:25:49] <Kostic>	 werdna: I have a almost exact problem as in this Talk http://www.mediawiki.org/wiki/Thread:Extension_talk:Lockdown/Lockdown_and_VisualEditor_-_can%27t_edit_protected_pages
[11:26:12] <Kostic>	 (I'm not getting any output or error when starting parsoid with node api/server.js).
[11:26:12] <werdna>	 Kostic: I had the same problem, on CentOS 5
[11:26:24] <Kostic>	 Ouch...
[11:27:13] <werdna>	 anyway, have you turned on $wgVisualEditorParsoidForwardCookies?
[11:27:25] <werdna>	 and also $wgSessionsInObjectCache?
[11:27:32] <Kostic>	 Yes and I'm installing Parsoid php extension.
[11:27:38] <werdna>	 ah okay ;)
[11:27:50] <werdna>	 those two variables should fix your problem
[11:27:52] <werdna>	 hopefully
[11:30:54] <Kostic>	 Hm... I'm now getting a message that I should enable cookies in my browser.
[11:30:57] <Kostic>	 They are enabled.
[11:31:13] <werdna>	 okay, do you have object caching enabled?
[11:31:51] <Kostic>	 $wgSessionsInObjectCache = true;
[11:32:24] <werdna>	 https://www.mediawiki.org/wiki/Manual:Cache#Object_caching
[11:32:32] <werdna>	 yes, that is the setting to put the sessions in an object cache
[11:32:38] <werdna>	 but you also need to have an object cache for that to work
[11:33:03] <Kostic>	 I enabled setting above in LocalSettings.php by uncommenting it.
[11:33:12] <Kostic>	 Ah, ok. I'm using XCache.
[11:33:40] <Kostic>	 ## Shared memory settings
[11:33:42] <Kostic>	 $wgMainCacheType = CACHE_ACCEL;
[11:33:44] <Kostic>	 $wgMemCachedServers = array();
[11:33:52] <werdna>	 okay
[11:33:59] <werdna>	 maybe you need to log in/out again
[11:34:03] <werdna>	 for the change to take effect.
[11:34:13] <Kostic>	 It logged me out already.
[11:34:28] <Kostic>	 I'm now unable to log in because it thinks I do not have cookies enabled. :)
[11:37:08] <Kostic>	 Restart of httpd and parsoid fixed it.
[11:37:41] <Kostic>	 And I still can't edit the page in VisualEditor. Just WikiEditor.
[11:37:44] <Kostic>	 Hm...
[11:39:39] <Kostic>	 werdna: what version of Mediawiki, VisualEditor and Lockdown are you using? Latest, 1.24 one?
[11:48:09] <Kostic>	 werdna: Anyway, thanks for your time. :)
[11:49:51] <Kostic>	 "// Namespaces to enable VisualEditor in
[11:49:53] <Kostic>	 $wgVisualEditorNamespaces = array_merge( $wgContentNamespaces, array( NS_USER ) );"
[11:55:52] <Kostic>	 "novenamespace: VisualEditor is not enabled in namespace 3002"
[12:01:29] <Kostic>	 If I enable VisualEditor in all namespaces, whenever I make page readable by a user group, editing with VisualEditor dissapears.
[12:36:48] <grrrit-wm>	 (03CR) 10Esanders: "ping" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders)
[12:55:56] <werdna>	 Kostic: sorry, was away.
[12:56:12] <Kostic>	 werdna: don't be. :)
[12:56:14] <werdna>	 I'm using a customised version, so it probably won't help
[12:56:38] <Kostic>	 I made a reply to your suggestion at Lockdown extension's Talk page.
[12:57:02] <Kostic>	 werdna: do you, maybe, use AccessControlPanel extension?
[12:57:17] <werdna>	 no, but that's unlikely to be the issue.
[12:57:27] <werdna>	 do you have an error message in your debug console when you try to edit with VE?
[12:58:28] <Kostic>	 You are reffering to a debug log file?
[12:59:05] <Kostic>	 My Parsoid instance is started by a upstart script I found and adapted for Centos 6. I can, if you wish, start Parsoid manually.
[13:01:13] <werdna>	 no no
[13:01:21] <werdna>	 In your browser's console
[13:01:24] <werdna>	 like, a JavaScript error.
[13:03:12] <Kostic>	 Wait a sec.
[13:03:13] <rj2223>	 Hello
[13:03:53] <Kostic>	 Nothing in Firefox console.
[13:04:00] <rj2223>	 I ve setup a media wiki, how can I use Visual editor ?
[13:04:23] <Kostic>	 I tried to edit the page by appending ?veaction=edit to a url (because VE Tab button 'Edit' isn't available).
[13:05:14] <Kostic>	 rj2223: setup a Parsoid and then install Visual Editor extension. This page has all the info you need: http://www.mediawiki.org/wiki/Extension:VisualEditor
[13:06:01] <rj2223>	 great ! I cannot find it out ! Thanks
[13:06:11] <Kostic>	 werdna: If you do not understand my problem, please tell me so I could try to explain it better.
[13:06:14] <Kostic>	 rj2223: nothing. :)
[13:06:37] <Kostic>	 rj2223: If you encounter an obstacle, come back here. I'll try to help you.
[13:07:08] <Kostic>	 rj2223: also, advice. It's easier to setup a VisualEditor on a more up to date system such as Ubuntu 14.04 (because of node).
[13:08:01] <rj2223>	 ok Thank you
[13:11:36] <Kostic>	 werdna: would a detailed debug log containing all data after the request to edit the page with VE be usefull?
[13:12:12] <werdna>	 Kostic: even after going to the page with ?veaction=edit
[13:12:42] <Kostic>	 Ok, wait a sec while I try to strip the output of any sensitive data.
[13:14:46] <Kostic>	 werdna: http://fpaste.org/199474/26684473/
[13:15:25] <werdna>	 Kostic: I think the error is more likely to be in JavaScript than in MediaWiki itself
[13:16:07] <werdna>	 I'm pretty sure veaction is read in JS, not in PHP
[13:16:11] <Kostic>	 Ok. What information do you requre?
[13:16:18] <Kostic>	 That is correct. :)
[13:16:43] <werdna>	 if there's nothing coming up in the debug console of your browser then I have no idea
[13:18:02] <Kostic>	 Is there a situation where VisualEditor doesn't load on a page?
[13:18:07] <Kostic>	 Defined in VisualEditor code?
[13:18:57] <Kostic>	 As an example, a page contains a lot of markup not supported by VisualEditor.
[13:19:02] * Kostic is speculating.
[13:19:28] <werdna>	 I would imagine an error message would be displayed
[13:21:05] <Kostic>	 Something like "novenamespace: VisualEditor is not enabled in namespace 138" ?
[13:21:12] <Kostic>	 I got that message once.
[13:21:50] <Kostic>	 Let me try to reproduce the message again.
[13:25:46] <Kostic>	 Nope... Can't reproduce that message again. :(
[13:27:28] <grrrit-wm>	 (03PS1) 10Esanders: Factor out ve.compareClassLists functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 
[13:29:08] <grrrit-wm>	 (03PS2) 10Esanders: Factor out ve.compareClassLists functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 
[13:32:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Factor out ve.compareClassLists functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 (owner: 10Esanders)
[13:33:57] <werdna>	 Kostic: you might need to wait until the US wakes up then, I have no idea
[13:33:58] <Kostic>	 werdna: when you said that you were using a customised solution, were you reffering to Lockdown extension, VisualEditor or some Wikimedia project?
[13:34:14] <werdna>	 I use it at a client site
[13:34:53] <Kostic>	 What did you customise? Lockdown or VisualEditor?
[13:35:38] <Kostic>	 Sorry. You aren't probably allowed to share that info.
[13:37:36] <Kostic>	 I'll try to bring up a bit more pristine installation of mediawiki on another host.
[13:42:42] <Kostic>	 werdna: Thank you for taking time to try to help me. I really appreciate it.
[13:42:58] <Kostic>	 I'll wait until the US wakes up.
[13:43:20] <werdna>	 I customised Lockdown + MediaWiki
[13:43:22] <werdna>	 VE not too much
[13:43:30] <werdna>	 no problem, sorry I couldn't help you
[13:47:57] <Kostic>	 werdna: One more question (I promise :) ), was that a stable release of Mediawiki or the latest from git?
[14:12:49] <werdna>	 Kostic: from git
[14:21:42] <wikibugs>	 10VisualEditor, 10Citoid: Lookup is returning invalid url in Autofill Citation dialog - https://phabricator.wikimedia.org/T93005#1128601 (10Mvolz) I definitely think we should make this more user friendly, but I'm not sure exactly how we should do it.  I think having a message for 520s like "Sorry, we were una...
[14:22:39] <grrrit-wm>	 (03PS11) 10Mvolz: [WIP] Add IDs for tests for Citoid extension [services/citoid] - 10https://gerrit.wikimedia.org/r/185837 (owner: 10Anishvisa)
[14:31:33] * James_F waves.
[14:32:17] * mvolz waves back
[15:07:29] <grrrit-wm>	 (03CR) 10MarkAHershberger: [C: 031] "This appears to have fixed the problem for me." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197447 (https://phabricator.wikimedia.org/T92969) (owner: 10Esanders)
[15:11:29] <grrrit-wm>	 (03PS2) 10Mvolz: Prefer requestFromURL when DOI is in URL [services/citoid] - 10https://gerrit.wikimedia.org/r/197080 
[15:11:44] <grrrit-wm>	 (03CR) 10Mvolz: Prefer requestFromURL when DOI is in URL (033 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/197080 (owner: 10Mvolz)
[15:13:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197623 (owner: 10L10n-bot)
[15:14:44] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: VE in IE is stripping the contents of <font> tags from pasted text - https://phabricator.wikimedia.org/T92969#1128822 (10MarkAHershberger) I think we can close this when the pa...
[15:17:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197619 (owner: 10L10n-bot)
[15:17:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197618 (owner: 10L10n-bot)
[15:18:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/197610 (owner: 10L10n-bot)
[15:20:53] <hexmode>	 edsanders: thanks for that fix... Now, is there any example code that would show me how to turn "<span style='font-weight:bold'>...</span>" into "<b>...</b>" ???
[15:21:02] * hexmode goes to open a task for this
[15:22:30] <edsanders>	 hexmode, in dm.SpanAnnotation
[15:22:52] <hexmode>	 edsanders: ty... will look
[15:22:56] <edsanders>	 hmm
[15:22:58] <James_F>	 RoanKattouw_away: https://gerrit.wikimedia.org/r/#/c/196741/ and parent then https://gerrit.wikimedia.org/r/#/c/191100/ 
[15:23:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/197599 (owner: 10L10n-bot)
[15:23:15] <edsanders>	 I don't know if we have mutating annotation types
[15:23:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] DraggableGroupElement: Clarify description and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/197253 (owner: 10Kmenger)
[15:23:36] <RoanKattouw>	 edsanders: You mean an annotation's toDataElement returning an annotation of a different type?
[15:23:42] <edsanders>	 right
[15:23:48] <RoanKattouw>	 That's theoretically supported
[15:23:56] <RoanKattouw>	 I'm not aware of it actually being used anywhere
[15:24:08] <RoanKattouw>	 So it may or may not actually work, but I think it's intended to work
[15:24:43] <grrrit-wm>	 (03PS2) 10Jforrester: ve.ui.ToolbarDialogTool: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197378 (owner: 10Esanders)
[15:24:49] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] ve.ui.ToolbarDialogTool: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197378 (owner: 10Esanders)
[15:24:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/197587 (owner: 10L10n-bot)
[15:25:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/197586 (owner: 10L10n-bot)
[15:25:53] <James_F>	 RoanKattouw_away: Thereafter, https://gerrit.wikimedia.org/r/#/c/196879/ https://gerrit.wikimedia.org/r/#/c/196887/ https://gerrit.wikimedia.org/r/#/c/196889/ https://gerrit.wikimedia.org/r/#/c/197046/ https://gerrit.wikimedia.org/r/#/c/197047/ https://gerrit.wikimedia.org/r/#/c/197353/ https://gerrit.wikimedia.org/r/#/c/197478/ https://gerrit.wikimedia.org/r/#/c/197447/
[15:25:56] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: VE should translate <span style="font-weight: bold">...</span> into <b>...</b> - https://phabricator.wikimedia.org/T93081#1128841 (10MarkAHershberger) 3NEW
[15:27:45] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: VE should translate <span style="font-weight: bold">...</span> into <b>...</b> - https://phabricator.wikimedia.org/T93081#1128855 (10MarkAHershberger)
[15:28:27] <edsanders>	 RoanKattouw, hexmode, so the theory is that you override static.toDataElement to return a different type (e.g. bold)
[15:29:24] * hexmode likes the theory...
[15:29:39] <edsanders>	 but with annotations we store the instance immediately, and don't recreate from the type, so you end up with a spanannotation instance with type=bold
[15:29:51] <wikibugs>	 10VisualEditor, 10Citoid: More user-friendly message for 520s (when the service is unable to obtain metadata about the resource) - https://phabricator.wikimedia.org/T93005#1128864 (10Mvolz)
[15:30:00] <RoanKattouw>	 Oh, ugh
[15:30:02] <edsanders>	 so we need to fix converter
[15:30:35] <edsanders>	 the reason it works with elements is that in the linear data we just store the plain object: { type: heading {
[15:30:42] <edsanders>	 {type: heading}
[15:30:55] <edsanders>	 but with annotations we store the instance wrapping the plain object
[15:33:57] * edsanders steps through the converter
[15:35:31] <edsanders>	 annotation = this.annotationFactory.create( modelName, childDataElements[0] );
[15:35:35] <edsanders>	 that is the offending line
[15:35:50] <RoanKattouw>	 Oh lol wut
[15:35:53] <edsanders>	 at this point childDataElements is whatever you got from toDataElements (so bold)
[15:36:05] <RoanKattouw>	 Yeah modelName should be childDataElements[0].type instead
[15:36:05] <edsanders>	 but modelName is what it matched originally (textStyle/span)
[15:36:27] <RoanKattouw>	 I think NodeFactory already has a wrapper method that essentially does create( dataElement.type, dataElement );
[15:36:35] <RoanKattouw>	 So maybe AnnotationFactory should have that as well
[15:37:50] <grrrit-wm>	 (03PS1) 10Esanders: Use type from toDataElements when creating annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197634 
[15:38:21] <wikibugs>	 10MediaWiki-ResourceLoader, 10Beta-Cluster: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences lacks normal styling - https://phabricator.wikimedia.org/T93050#1128882 (10Jdforrester-WMF)
[15:38:36] <grrrit-wm>	 (03CR) 10Mobrovac: [C: 04-1] "Still needs a bit of work." (037 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/197080 (owner: 10Mvolz)
[15:39:36] <wikibugs>	 10MediaWiki-ResourceLoader, 10Beta-Cluster: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences lacks normal styling - https://phabricator.wikimedia.org/T93050#1127937 (10Jdforrester-WMF) This feels like it might possibly be caused by the recent ResourceLoader change by @ori to resequence module load...
[15:39:39] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "Ideally this would use createFromElement(), but for some reason that only exists in MetaItemFactory, not NodeFactory or AnnotationFactory." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197634 (owner: 10Esanders)
[15:39:54] <edsanders>	 ah meta item
[15:39:56] <edsanders>	 of course
[15:40:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197559 (owner: 10L10n-bot)
[15:40:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/197558 (owner: 10L10n-bot)
[15:40:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/197558 (owner: 10L10n-bot)
[15:40:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cite] - 10https://gerrit.wikimedia.org/r/197557 (owner: 10L10n-bot)
[15:40:34] <RoanKattouw>	 I remember writing that function but I could swear it was in NodeFactory
[15:40:39] <RoanKattouw>	 Apparently not
[15:40:39] <edsanders>	 type is a common property of models
[15:40:43] <RoanKattouw>	 Yeah
[15:40:46] <edsanders>	 so we could have a modelFactory base class
[15:40:48] <RoanKattouw>	 We don't currently have a ModelFactory
[15:40:52] <grrrit-wm>	 (03PS6) 10BryanDavis: Code style cleanup [extensions/Math] - 10https://gerrit.wikimedia.org/r/197123 (owner: 10Physikerwelt)
[15:40:59] <RoanKattouw>	 I wonder what else would be in it other than createFromElement
[15:40:59] <edsanders>	 but we should
[15:41:06] <grrrit-wm>	 (03PS7) 10BryanDavis: Code style cleanup [extensions/Math] - 10https://gerrit.wikimedia.org/r/197123 (owner: 10Physikerwelt)
[15:41:07] <RoanKattouw>	 We do already have ModelRegistry
[15:41:13] <RoanKattouw>	 Which is differnet
[15:41:33] <edsanders>	 well dm annotationfactory is empty
[15:41:38] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] Code style cleanup [extensions/Math] - 10https://gerrit.wikimedia.org/r/197123 (owner: 10Physikerwelt)
[15:43:08] <RoanKattouw>	 hah so it is
[15:43:27] <grrrit-wm>	 (03PS3) 10BryanDavis: Update to PSR-3 logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/197217 (owner: 10Physikerwelt)
[15:43:51] <edsanders>	 where is nodefactory populated?
[15:44:31] <RoanKattouw>	 By ModelRegistry
[15:44:39] <RoanKattouw>	 ve.dm.ModelRegistry.prototype.register
[15:44:49] <edsanders>	 ah
[15:45:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update to PSR-3 logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/197217 (owner: 10Physikerwelt)
[15:45:45] <edsanders>	 hexmode, so if you pull master now with that fix you can override toDataElement ( which has domElements as an argument )
[15:45:56] <edsanders>	 and if it has style bold you can return a different type
[15:46:15] <hexmode>	 edsanders: tyvm
[15:46:22] <edsanders>	 but just to throw a spanner in the works there's probably more work to be done to the converter
[15:46:39] <edsanders>	 because you could have <span style="bold+italic">
[15:46:45] <edsanders>	 in which case you need to return two annotations
[15:46:51] * hexmode nods
[15:47:45] <edsanders>	 so in the converter where we just did that fix we assume that childDataElements is length 1
[15:47:50] <edsanders>	 (hence childDataElements[0])
[15:48:25] <edsanders>	 that would need to made into a loop
[15:49:04] <edsanders>	 also going into attribute annotations is a bit of a Pandora's box
[15:49:16] <edsanders>	 <b style="font-style:italic">
[15:49:36] <edsanders>	 really we should be matching styles regardless of which tag they're attached to
[15:49:53] <hexmode>	 yep
[15:50:15] <hexmode>	 html is ugly
[15:50:17] <edsanders>	 and even above the annotation level: <p style="font-weight:bold">
[15:50:20] <RoanKattouw>	 Yeah I had plans for this once
[15:50:26] <RoanKattouw>	 To support "attribute annotations"
[15:50:33] <edsanders>	 yeah, we did fill a whiteboard or two
[15:50:37] <RoanKattouw>	 But that got dropped from that dmrewrite iteration because I had other stuff to do
[15:50:59] <RoanKattouw>	 I think that was when I was also introducing mutating types
[15:52:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Prevent backspacing/deleting over table cells (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[15:53:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: DraggableGroupElement: Clarify description and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/197253 (owner: 10Kmenger)
[15:53:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ui.ToolbarDialogTool: Fix documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197378 (owner: 10Esanders)
[15:53:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use type from toDataElements when creating annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197634 (owner: 10Esanders)
[15:53:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Code style cleanup [extensions/Math] - 10https://gerrit.wikimedia.org/r/197123 (owner: 10Physikerwelt)
[15:54:55] <wikibugs>	 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 7I18n, 5Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1128938 (10Umherirrender) With version 1.25wmf22 new long comments for revision will be trunc...
[15:55:27] <edsanders>	 hexmode, also you can only do it when you're pasting, we don't want to dirty-diff <span style="bold"> to <b>
[15:55:57] <hexmode>	 sure.  makes sense.
[15:56:16] <James_F>	 Well.
[15:56:18] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [skins/Vector] - 10https://gerrit.wikimedia.org/r/197538 (owner: 10L10n-bot)
[15:56:24] <James_F>	 We don't want to accidentally dirty-diff.
[15:56:56] <James_F>	 But cleaning up insane wikitext/HTML isn't totally stupid as a "clean-up" button or something, in the future.
[15:57:06] <James_F>	 Distant future.
[15:57:18] <wikibugs>	 10MediaWiki-ResourceLoader, 10Beta-Cluster: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences lacks normal styling - https://phabricator.wikimedia.org/T93050#1128952 (10Krinkle) These tab styles are provided by `mediawiki.special.preferences.less` from the Vector skin, added to the `mediawiki.speci...
[15:57:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Improve backspacing over the end of a list with empty last item (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński)
[16:00:25] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] "Trevor, why is this still -1ed?" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński)
[16:02:43] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "It's not implementing what the discussion on Phabricator settled on. It adds .class instead of aliasing .static and allowing 'this' to nat" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński)
[16:03:43] <grrrit-wm>	 (03PS3) 10Mvolz: Prefer requestFromURL when DOI is in URL [services/citoid] - 10https://gerrit.wikimedia.org/r/197080 
[16:03:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/Vector] - 10https://gerrit.wikimedia.org/r/197538 (owner: 10L10n-bot)
[16:03:59] <James_F>	 Krinkle: Did you have a chance to talk to jshint about .static being allowed in ES3?
[16:04:05] <grrrit-wm>	 (03CR) 10Mvolz: Prefer requestFromURL when DOI is in URL (037 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/197080 (owner: 10Mvolz)
[16:04:12] <James_F>	 Hey MatmaRex!
[16:04:20] <MatmaRex>	 hi
[16:04:45] <prtksxna>	 MatmaRex: o/
[16:04:55] <grrrit-wm>	 (03CR) 10Krinkle: "https://github.com/jshint/jshint/issues/2231" [oojs/core] - 10https://gerrit.wikimedia.org/r/192969 (owner: 10Jforrester)
[16:05:20] <James_F>	 Krinkle: Thanks. :-)
[16:05:59] <James_F>	 Krinkle: Is jshint the kind of project where issues without attached pull requests get mostly ignored?
[16:06:08] <Krinkle>	 Not usually
[16:06:47] <Krinkle>	 I've pinged rwaldron via jQuery. I could create a patch but it's not really important on my list right now I think.
[16:06:55] <wikibugs>	 10VisualEditor, 10Citoid, 5Patch-For-Review: [Regression pre-wmf22] Cannot switch to VE in beta - "Cannot read property 'mw' of undefined {stack: (...)" by Citoid - https://phabricator.wikimedia.org/T92866#1129030 (10Mvolz) 5Open>3Resolved
[16:07:34] <wikibugs>	 10VisualEditor, 10Citoid, 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression pre-wmf22] Cannot switch to VE in beta - "Cannot read property 'mw' of undefined {stack: (...)" by Citoid - https://phabricator.wikimedia.org/T92866#1129032 (10Jdforrester-WMF)
[16:07:50] <MatmaRex>	 darn, i ignore emails for just barely two days and suddenly i have a jillion unread.
[16:08:18] <James_F>	 Krinkle: Sure, yeah, not a priority.
[16:11:56] <wikibugs>	 10OOjs-UI: OOJS UI: Create a toolbar in demo page which looks like VE toolbar. - https://phabricator.wikimedia.org/T93033#1129052 (10matmarex) 5Open>3Resolved a:3matmarex The one added in https://gerrit.wikimedia.org/r/#/c/197441/ should be close enough. It's already live on http://tools.wmflabs.org/oojs-u...
[16:12:21] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release: OOJS UI: Create a toolbar in demo page which looks like VE toolbar. - https://phabricator.wikimedia.org/T93033#1129055 (10Jdforrester-WMF) p:5Triage>3Normal
[16:19:51] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "Needs to update the Specification and server-side handling / tests as well." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) (owner: 10Mooeypoo)
[16:20:05] <guillom>	 RoanKattouw: Can you let me know when you have 10 minutes today to take a look at VE diffs?
[16:20:27] <RoanKattouw>	 guillom: Around 11am?
[16:20:52] <guillom>	 RoanKattouw: I'm in a meeting from 11 to 11:30
[16:21:03] <guillom>	 Free before and after
[16:21:28] <wikibugs>	 10VisualEditor, 10Citoid, 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression pre-wmf22] Cannot switch to VE in beta - "Cannot read property 'mw' of undefined {stack: (...)" by Citoid - https://phabricator.wikimedia.org/T92866#1129134 (10Etonkovidova) The fix works - verified in beta.
[16:21:36] <RoanKattouw>	 11:30 then?
[16:21:44] <guillom>	 RoanKattouw: Works for me. Thanks!
[16:23:31] <grrrit-wm>	 (03PS1) 10Catrope: Follow-up f620111b: pass parameters to fallback requestPageData() call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197644 (https://phabricator.wikimedia.org/T93036) 
[16:23:38] <grrrit-wm>	 (03PS2) 10Catrope: Follow-up f620111b: pass parameters to fallback requestPageData() call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197644 (https://phabricator.wikimedia.org/T93036) 
[16:26:22] <wikibugs>	 10TemplateData, 5Patch-For-Review, 5WMF-deploy-2015-03-11_(1.25wmf21), 7user-notice: TemplateData: Provide property "example" for template parameters - https://phabricator.wikimedia.org/T53049#1129159 (10Krinkle) The feature support in MWParameterPage is a bit presumptuous as the exact definition and prope...
[16:26:25] <grrrit-wm>	 (03CR) 10Krinkle: "See also T53049 for question about the feature in general." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo)
[16:26:33] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo)
[16:33:17] <wikibugs>	 10MediaWiki-ResourceLoader: Evaluate folding msg_resource and msg_resource_links tables into objectcache - https://phabricator.wikimedia.org/T90001#1129175 (10Krinkle)
[16:35:53] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use store indices in annotate operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196879 (owner: 10Esanders)
[16:36:24] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Make range optional in getUsedStoreValuesFromRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196887 (owner: 10Esanders)
[16:36:38] <grrrit-wm>	 (03PS5) 10Catrope: Store reference to DM document in transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196889 (owner: 10Esanders)
[16:36:48] <wikibugs>	 10MediaWiki-ResourceLoader: Evaluate folding msg_resource and msg_resource_links tables into objectcache - https://phabricator.wikimedia.org/T90001#1051117 (10Krinkle)
[16:36:59] <wikibugs>	 10MediaWiki-ResourceLoader: Evaluate folding msg_resource and msg_resource_links tables into objectcache - https://phabricator.wikimedia.org/T90001#1051117 (10Krinkle)
[16:39:38] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Store reference to DM document in transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196889 (owner: 10Esanders)
[16:41:30] <mooeypoo>	 James_F, your input? https://phabricator.wikimedia.org/T53049
[16:43:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use store indices in annotate operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196879 (owner: 10Esanders)
[16:43:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make range optional in getUsedStoreValuesFromRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196887 (owner: 10Esanders)
[16:45:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Store reference to DM document in transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196889 (owner: 10Esanders)
[16:45:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set originalDomElements whenever a data element is created [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197046 (owner: 10Esanders)
[16:47:51] <mooeypoo>	 Krinkle, can you re-review this? I really want to try and get this merged. Fixed your comments and the issue with the import. https://gerrit.wikimedia.org/r/#/c/194991/
[16:48:02] <James_F>	 RoanKattouw: Then https://gerrit.wikimedia.org/r/#/c/160308/ :-)
[16:48:04] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "About the test changes: isn't originalDomElements ignored/stripped by most comparison functions in the test suite? I wonder to what extent" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197047 (owner: 10Esanders)
[16:48:06] <Krinkle>	 Yup. In time for your birthday
[16:48:11] <James_F>	 Krinkle: :-P
[16:48:19] <Krinkle>	 I'll do my best
[16:48:29] <mooeypoo>	 Yay!
[16:51:10] <wikibugs>	 10TemplateData, 5Patch-For-Review: [Regression wmf21] Unable to type in label and description field - https://phabricator.wikimedia.org/T92558#1129242 (10Mooeypoo) 5Open>3Resolved Should be fixed now.
[16:51:32] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Simplify annotation hashes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197353 (owner: 10Esanders)
[16:51:36] <wikibugs>	 10TemplateData, 5WMF-deploy-2015-03-11_(1.25wmf21), 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression wmf21] Unable to type in label and description field - https://phabricator.wikimedia.org/T92558#1129254 (10Mooeypoo)
[16:52:35] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Looks good, but the documentation comment needs to be updated." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197478 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[16:57:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Simplify annotation hashes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197353 (owner: 10Esanders)
[16:59:36] <wikibugs>	 10VisualEditor, 10Citoid: More user-friendly message for 520s (when the service is unable to obtain metadata about the resource) - https://phabricator.wikimedia.org/T93005#1129305 (10Mooeypoo) @Mvolz, I agree, and I like your idea about not prepending the http://. In fact, what we could do in 520 errors is not...
[17:00:14] <grrrit-wm>	 (03PS1) 10BryanDavis: Fix PHPUnit provider name [extensions/Math] - 10https://gerrit.wikimedia.org/r/197659 
[17:05:38] <grrrit-wm>	 (03PS1) 10Divec: WIP: BREAKING CHANGE: Use unicode character class to calculate word expansions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) 
[17:06:05] <grrrit-wm>	 (03PS2) 10Alex Monk: Load special characters in Platform instead of SpecialCharacterDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197478 (https://phabricator.wikimedia.org/T91608) 
[17:08:09] <grrrit-wm>	 (03CR) 10Esanders: [BREAKING CHANGE] Remove domElements attribute from aliens (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197047 (owner: 10Esanders)
[17:08:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: BREAKING CHANGE: Use unicode character class to calculate word expansions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) (owner: 10Divec)
[17:10:00] <grrrit-wm>	 (03PS3) 10Esanders: [BREAKING CHANGE] Remove domElements attribute from aliens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197047 
[17:15:03] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "unit tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński)
[17:15:08] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 7Browser-Support-Firefox: Preserve `data-parsoid` attribute on internal copy-paste so that Parsoid preserves e.g. syntax layout - https://phabricator.wikimedia.org/T74426#1129342 (10ssastry)
[17:16:25] <RoanKattouw>	 edsanders: Did you see my question about unit tests on https://gerrit.wikimedia.org/r/#/c/197047/3 ?
[17:16:29] <grrrit-wm>	 (03PS2) 10Krinkle: Fix PHPUnit provider name [extensions/Math] - 10https://gerrit.wikimedia.org/r/197659 (owner: 10BryanDavis)
[17:16:39] <grrrit-wm>	 (03CR) 10Krinkle: "Naming convention is provide* and test*." [extensions/Math] - 10https://gerrit.wikimedia.org/r/197659 (owner: 10BryanDavis)
[17:16:44] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Fix PHPUnit provider name [extensions/Math] - 10https://gerrit.wikimedia.org/r/197659 (owner: 10BryanDavis)
[17:17:13] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add handlers for font annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197447 (https://phabricator.wikimedia.org/T92969) (owner: 10Esanders)
[17:17:38] <edsanders>	 RoanKattouw, yes, everything except aliens or original attributes will be ignored
[17:17:49] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Fix PHPUnit provider name [extensions/Math] - 10https://gerrit.wikimedia.org/r/197659 (owner: 10BryanDavis)
[17:17:57] <RoanKattouw>	 ?
[17:18:51] <edsanders>	 alienNode's toDomElements is basically 'return originalDomElements'
[17:19:00] <edsanders>	 so if we don't put any in the test data it won't roundtrip
[17:19:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add handlers for font annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197447 (https://phabricator.wikimedia.org/T92969) (owner: 10Esanders)
[17:19:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix PHPUnit provider name [extensions/Math] - 10https://gerrit.wikimedia.org/r/197659 (owner: 10BryanDavis)
[17:20:14] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10WMF-deploy-2015-03-25_(1.25wmf23), 7Browser-Support-Internet-Explorer: VE in IE is stripping the contents of <font> tags from pasted text - https://phabricator.wikimedia.org/T92969#1129373 (10Jdforrester-WMF) 5Open>3Resolved
[17:20:30] <James_F>	 mooeypoo: https://gerrit.wikimedia.org/r/197661
[17:21:51] <RoanKattouw>	 edsanders: Right, but in the other direction it doesn't assert they're there
[17:21:53] <RoanKattouw>	 But I guess that's fine
[17:22:00] <Krinkle>	 Wait.. did I miss the startup?
[17:22:08] <RoanKattouw>	 Yes
[17:22:12] <Krinkle>	 Oh, right. It changed timezones twice for me
[17:22:19] <edsanders>	 RoanKattouw, no, but then we'd need to provide them for /every/ element
[17:22:23] <edsanders>	 paragraphs etc.
[17:22:33] <RoanKattouw>	 edsanders: Yeah ain't nobody got time for that
[17:22:40] <RoanKattouw>	 Krinkle: It's getting earlier every time :P
[17:22:46] <RoanKattouw>	 Krinkle: It'll change again (an hour later) on March 29
[17:22:51] <Krinkle>	 Yeah from 19:00 to 18:00 in 2 weeks
[17:22:54] <Krinkle>	 17:00 *
[17:22:54] <Krenair>	 RoanKattouw, hey, so, when you have a moment, I wrote https://phabricator.wikimedia.org/T92993#1127342
[17:23:34] <RoanKattouw>	 OK
[17:25:02] <RoanKattouw>	 Krinkle: Actually if you look at the past few weeks it's like 18:00 -> 19:00 -> 18:00 -> 17:00 -> 18:00 :D
[17:25:21] <Krinkle>	 Yeah, I saw the CPG grey on this.
[17:25:38] <Krinkle>	 It's worse if we'd have someone in New Zealand or Australia on the call
[17:25:42] <RoanKattouw>	 Yup
[17:25:46] <Krinkle>	 since they also have a different moment to change their zone
[17:25:54] <RoanKattouw>	 They change at a different time in a different direction
[17:25:58] <James_F>	 Differently different.
[17:26:02] <grrrit-wm>	 (03PS4) 10BryanDavis: Update to PSR-3 logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/197217 (owner: 10Physikerwelt)
[17:26:13] <RoanKattouw>	 Except a number of Australian states don't do DST
[17:26:13] <Krinkle>	 Different direction but also different date
[17:28:50] <wikibugs>	 10VisualEditor, 10Citoid: More user-friendly message for 520s (when the service is unable to obtain metadata about the resource) - https://phabricator.wikimedia.org/T93005#1129392 (10Mvolz) I think that's a good idea, generally.  However, sometimes we get a 520 not because user input is bad, but we've been IP...
[17:31:12] <Krenair>	 http://www.timeanddate.com/time/dst/2015.html is useful
[17:35:21] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-04_(1.25wmf20), and 2 others: Deleting through a list throws an exception - https://phabricator.wikimedia.org/T92286#1129407 (10Etonkovidova) Verified in beta.
[17:36:00] <grrrit-wm>	 (03CR) 10Krinkle: Factor out ve.compareClassLists functionality (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 (owner: 10Esanders)
[17:37:34] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does not work correctly when the scrollbar is displayed on left side of window in RTL mode (e.g. on Opera 12, IE 11). Also, we are rapidly" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders)
[17:37:53] <milimetric>	 Krenair: you around?
[17:37:58] <Krenair>	 yep
[17:38:05] <milimetric>	 cool, a small ask
[17:38:07] <Krenair>	 ok
[17:38:22] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(That's not system-level, my system and browsers are all in English. I think that's important enough to block this.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders)
[17:38:23] <RoanKattouw>	 Krinkle: https://gerrit.wikimedia.org/r/197073
[17:38:38] <milimetric>	 I tried to look into whether or not there were still validation problems, but it was confusing to check due to multiple schemas on client / server
[17:38:53] <legoktm>	 James_F: https://gerrit.wikimedia.org/r/197651 easy
[17:38:55] <Krenair>	 right, I need to get the VE side up to date
[17:39:37] <milimetric>	 so Krenair: would you mind sending or posting somewhere a matrix that details what you think is happening?  As in: client side and server side, for each schema version, whether you think events are valid or invalid or both
[17:39:55] <Krenair>	 All the events *should* be valid
[17:40:03] <milimetric>	 ok, and what schemas are in use?
[17:40:14] <Krenair>	 Edit schema is the only one I've looked into
[17:40:17] <milimetric>	 rather - schema versions, sorry
[17:40:30] <Krenair>	 two different versions are known by me to be in use
[17:40:36] <Krenair>	 the difference: https://meta.wikimedia.org/w/index.php?title=Schema:Edit&diff=11448630&oldid=11319708
[17:40:53] <milimetric>	 gotcha, ok, so the 1067... is no longer expected to come from anywhere, right?
[17:40:56] <RoanKattouw>	 James_F: When is Citoid going live where?
[17:41:00] <nzr>	 MatmaRex: hey thanks for the ve toolbar in demo page!! 
[17:41:32] <Krenair>	 milimetric, the 1067??
[17:41:58] <Krenair>	 milimetric, 10676603?
[17:41:59] <milimetric>	 Krenair: yeah, this one: https://meta.wikimedia.org/w/index.php?title=Schema:Edit&oldid=10676603
[17:42:14] <Krenair>	 Not as far as I know...
[17:42:26] <Krenair>	 Oh.... Hm
[17:42:31] <milimetric>	 ok, just checking, that one has the majority of events
[17:42:35] <Krenair>	 Actually, that might be the one
[17:42:39] <milimetric>	 :)
[17:42:43] * Krenair goes to check the right numbers again
[17:42:54] * milimetric is appreciative
[17:43:15] <Krenair>	 WikiEditor is using 11448630
[17:43:28] <RoanKattouw>	 mooeypoo: https://gerrit.wikimedia.org/r/197644 needs testing with MobileFrontend
[17:43:45] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: Allow inserting non-breakable space (&nbsp;) - https://phabricator.wikimedia.org/T86636#1129432 (10Aklapper) >>! In T86636#1128331, @Elitre wrote: > This is a dupe of https://phabricator.wikimedia.org/T70429 and/or https://phabricat...
[17:43:51] <Krenair>	 WikimediaEvents is sending 11319708 to clients (WE and VE)
[17:43:56] <Krenair>	 milimetric, ^
[17:44:37] <milimetric>	 gotcha, knowing that I'll check the logs and let you know what I find.
[17:44:43] <milimetric>	 (but not now, Scrum of Scrums)
[17:47:55] <wikibugs>	 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 7I18n, 5Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1129462 (10Aklapper) p:5High>3Lowest Thanks! Lowering priority accordingly.
[17:51:11] <grrrit-wm>	 (03PS3) 10Krinkle: Grey-out body as soon as edit is clicked [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197073 (owner: 10Esanders)
[17:51:23] <wikibugs>	 10VisualEditor, 10Citoid: More user-friendly message for 520s (when the service is unable to obtain metadata about the resource) - https://phabricator.wikimedia.org/T93005#1129486 (10Mooeypoo) Okay, if we can get the back end service to give us more specific errors that can definitely help. My biggest worry (a...
[17:51:55] <James_F>	 RoanKattouw: The plan was to do this tomorrow on frwiki if we were happy with it. 
[17:52:10] <mooeypoo>	 TrevorParscal, your input is appreciated on this https://phabricator.wikimedia.org/T93005
[17:52:42] <wikibugs>	 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 7I18n, 5Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1129495 (10Aklapper) p:5Lowest>3Normal Uh, 2nd patch still waiting (sorry didn't see that...
[17:57:14] <grrrit-wm>	 (03PS4) 10Krinkle: mw.ViewPageTarget: Grey-out body content as soon as edit is clicked [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197073 (owner: 10Esanders)
[17:57:21] <grrrit-wm>	 (03CR) 10Krinkle: mw.ViewPageTarget: Grey-out body content as soon as edit is clicked (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197073 (owner: 10Esanders)
[17:57:27] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] mw.ViewPageTarget: Grey-out body content as soon as edit is clicked [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197073 (owner: 10Esanders)
[17:57:28] <MatmaRex>	 nzr: :D
[17:59:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw.ViewPageTarget: Grey-out body content as soon as edit is clicked [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197073 (owner: 10Esanders)
[18:01:12] <Krenair>	 milimetric,
[18:01:15] <Krenair>	 krenair@tin:/srv/mediawiki-staging$ grep 10676603 php-1.25wmf21/extensions/* -R
[18:01:15] <Krenair>	 krenair@tin:/srv/mediawiki-staging$ grep 10676603 php-1.25wmf20/extensions/* -R
[18:01:15] <Krenair>	 krenair@tin:/srv/mediawiki-staging$ 
[18:02:01] <milimetric>	 Krenair: I think it was wmf18?
[18:02:31] <milimetric>	 I'm completely disconnected from the releases though
[18:03:15] <Krenair>	 milimetric, nope, wmf16
[18:03:31] <James_F>	 mooeypoo: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-visualeditor-0-all&language=he&filter=%21translated&action=translate BTW. :-)
[18:03:45] <milimetric>	 k, so those more recent ones have been around for a while then.  Thx
[18:03:53] <milimetric>	 weird :)
[18:04:03] <James_F>	 And tsk https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-visualeditor-0-all&language=nl&filter=%21translated&action=translate for Dutchies.
[18:04:11] <Krenair>	 milimetric, okay so wmf17 and wmf18 were using that version when they were created
[18:04:13] <Krenair>	 looking at the log
[18:04:22] <Krenair>	 but the change to update it was backported to them
[18:04:32] <Krenair>	 so the last wmf17 and wmf18 versions were using 10676603
[18:04:38] <Krenair>	 so the last wmf17 and wmf18 versions were not using 10676603*
[18:04:40] <Krenair>	 oops
[18:04:48] <milimetric>	 ok, that makes sense
[18:05:04] <milimetric>	 SoS is over now, I'm gonna look at the logs on vanadium and tell you what I see in just a minute
[18:05:33] <Krenair>	 https://gerrit.wikimedia.org/r/#/c/191791/ and https://gerrit.wikimedia.org/r/#/c/191792/
[18:06:18] <grrrit-wm>	 (03PS15) 10Krinkle: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo)
[18:06:21] <milimetric>	 and Krenair: you guys are planning on updating WikimediaEvents to the latest?
[18:06:38] <Krenair>	 I should do that.
[18:07:00] <Krenair>	 I think I need to make VE actually use the fields/options in the latest schema version first
[18:07:28] <wikibugs>	 10VisualEditor, 10Citoid: More user-friendly message for 520s (when the service is unable to obtain metadata about the resource) - https://phabricator.wikimedia.org/T93005#1129567 (10TrevorParscal) In the short term, let's just show the user an error if for any reason their query didn't result in one or more o...
[18:11:15] <grrrit-wm>	 (03PS1) 10BryanDavis: PSR-3 logging cleanup [extensions/Math] - 10https://gerrit.wikimedia.org/r/197685 
[18:11:26] <TrevorParscal>	 Krinkle: MatmaRex: so, https://gerrit.wikimedia.org/r/#/c/191100/
[18:11:29] <TrevorParscal>	 this darn thing
[18:11:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] PSR-3 logging cleanup [extensions/Math] - 10https://gerrit.wikimedia.org/r/197685 (owner: 10BryanDavis)
[18:12:04] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] Update to PSR-3 logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/197217 (owner: 10Physikerwelt)
[18:13:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update to PSR-3 logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/197217 (owner: 10Physikerwelt)
[18:13:17] <grrrit-wm>	 (03PS2) 10BryanDavis: PSR-3 logging cleanup [extensions/Math] - 10https://gerrit.wikimedia.org/r/197685 
[18:14:37] <TrevorParscal>	 MatmaRex: also, are you able to reproduce this? https://phabricator.wikimedia.org/T92450
[18:15:01] <TrevorParscal>	 edsanders: you were using linux when you produced this right? ^^
[18:15:14] <TrevorParscal>	 I wonder if it also occurs on Windows, because I'm not seeing it on Mac
[18:15:44] <TrevorParscal>	 hmm, i think I got it in Firefox
[18:15:59] <edsanders>	 yes, still present in linux
[18:16:01] <edsanders>	 chrome & FF
[18:16:15] <TrevorParscal>	 ok, for whatever reason it's not a problem in Chrome on Mac
[18:16:16] <MatmaRex>	 can repro using Blink on Win 7
[18:16:29] <grrrit-wm>	 (03CR) 10Mobrovac: [C: 032 V: 032] "Perfect. merging :)" [services/citoid] - 10https://gerrit.wikimedia.org/r/197080 (owner: 10Mvolz)
[18:16:31] <TrevorParscal>	 but I do see it on FF so hopefully fixing it there will fix it elsewhere too
[18:17:19] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] "Works" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197644 (https://phabricator.wikimedia.org/T93036) (owner: 10Catrope)
[18:18:03] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up f620111b: pass parameters to fallback requestPageData() call [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197687 (https://phabricator.wikimedia.org/T93036) 
[18:18:11] <grrrit-wm>	 (03PS1) 10Jforrester: Follow-up f620111b: pass parameters to fallback requestPageData() call [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197688 (https://phabricator.wikimedia.org/T93036) 
[18:18:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Follow-up f620111b: pass parameters to fallback requestPageData() call [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197688 (https://phabricator.wikimedia.org/T93036) (owner: 10Jforrester)
[18:18:24] <mooeypoo>	 TrevorParscal, when y ou have a moment,do you happen to have the slides for https://wikimania2014.wikimedia.org/wiki/Submissions/VisualEditor_%E2%80%94_engineering_against_the_odds
[18:18:30] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Follow-up f620111b: pass parameters to fallback requestPageData() call [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197687 (https://phabricator.wikimedia.org/T93036) (owner: 10Jforrester)
[18:19:14] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "should we be just reusing the loop below which checks for focusable nodes? that's how I did it for cursoring" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[18:19:44] <Krinkle>	 mooeypoo: Ah, the parameter detection now works on subpages. So it was caused by the earlie version of the rewrite? I didn't know that was already there. Cool.
[18:20:34] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "The code below skips over tons of nodes first for no reason I could understand, so I decided not to touch it. You can't skip over close da" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[18:20:39] <mooeypoo>	 Krinkle, yeah it was a silly error on my part that regressed it. It worked before.
[18:21:17] <grrrit-wm>	 (03PS16) 10Krinkle: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo)
[18:21:18] <grrrit-wm>	 (03CR) 10Krinkle: Reorganize api calls and add sourceHandler and error message (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo)
[18:21:22] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo)
[18:21:30] <Krinkle>	 mooeypoo: One check from you and then we're good to go :)
[18:25:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Factor out ve.compareClassLists functionality (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 (owner: 10Esanders)
[18:25:22] <mooeypoo>	 Krinkle, ooh awesome, that does read better. thanks!
[18:25:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up f620111b: pass parameters to fallback requestPageData() call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197644 (https://phabricator.wikimedia.org/T93036) (owner: 10Catrope)
[18:25:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up f620111b: pass parameters to fallback requestPageData() call [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197688 (https://phabricator.wikimedia.org/T93036) (owner: 10Jforrester)
[18:25:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up f620111b: pass parameters to fallback requestPageData() call [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197687 (https://phabricator.wikimedia.org/T93036) (owner: 10Jforrester)
[18:26:07] <Krinkle>	 mooeypoo: I think there's even a trick to not have to this var sh = this; by returning pageContent from the getApi.then, and then passing 'this.extractParametersFromTemplateCode' to another then()
[18:26:11] <Krinkle>	 but that may be overdoing it
[18:26:35] <mooeypoo>	 ha
[18:26:36] <mooeypoo>	 hm
[18:26:59] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 031] "The fixes in PS16 are good" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo)
[18:27:01] <Krinkle>	 the same way that fetch( 'foo.json' ).then( JSON.parse ).then( function ( data ) { data..  } )
[18:27:13] <Krinkle>	 giving it a preprocessor basically
[18:27:48] <Krinkle>	 getApi( ) .then( ... return pageContent ).then( this.extractParametersFromTemplateCode )
[18:27:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove font tags on import (paste/drop) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197485 (owner: 10Esanders)
[18:28:00] <mooeypoo>	 Krinkle, yeah. Hmm. Yeah, true.
[18:28:02] <Krinkle>	 anyway, I tested it but can you verify it still works as well?
[18:28:10] <Krinkle>	 I'm not sure I covered it quite
[18:28:46] <mooeypoo>	 yep testing
[18:29:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove font tags on import (paste/drop) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197485 (owner: 10Esanders)
[18:30:05] <mooeypoo>	 Krinkle, works for me!
[18:30:09] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo)
[18:30:13] <Krinkle>	 Okidoki
[18:30:14] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/197047/2..3/src/ce/nodes/ve.ce.AlienNode.js
[18:30:15] <mooeypoo>	 yay
[18:30:31] <TrevorParscal>	 edsanders: MatmaRex: http://jsfiddle.net/zgjgmw82/
[18:30:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reorganize api calls and add sourceHandler and error message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194991 (https://phabricator.wikimedia.org/T91730) (owner: 10Mooeypoo)
[18:31:14] <TrevorParscal>	 turns out, the browser calculates the height of monospace text differently than sans-serif
[18:31:21] <grrrit-wm>	 (03PS3) 10Jforrester: Load special characters in Platform instead of SpecialCharacterDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197478 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[18:31:33] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/197478/1..3/src/init/ve.init.Platform.js
[18:32:05] <wikibugs>	 10TemplateData, 10WMF-deploy-2015-03-25_(1.25wmf23): No warning about invalid JSON in existing <templatedata> block, odd behavior. - https://phabricator.wikimedia.org/T91730#1129697 (10Jdforrester-WMF)
[18:32:16] <wikibugs>	 10TemplateData, 10WMF-deploy-2015-03-25_(1.25wmf23): No warning about invalid JSON in existing <templatedata> block, odd behavior. - https://phabricator.wikimedia.org/T91730#1129703 (10Jdforrester-WMF) 5Open>3Resolved
[18:32:25] <wikibugs>	 10TemplateData, 10WMF-deploy-2015-03-25_(1.25wmf23): Request all relevant information from the API once - https://phabricator.wikimedia.org/T91325#1129710 (10Jdforrester-WMF) 5Open>3Resolved
[18:32:59] <RoanKattouw>	 But only on Mac OS?
[18:33:08] <TrevorParscal>	 it's quite confusing
[18:33:17] <RoanKattouw>	 Because those two elements are equally scrollable for me on Ubuntu, in both Firefox and Chrome
[18:33:32] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Load special characters in Platform instead of SpecialCharacterDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197478 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[18:34:29] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/197047/2..3/src/ce/nodes/ve.ce.AlienNode.js
[18:34:38] <TrevorParscal>	 basically, there is some situation, which I haven't quite nailed down yet, which causes the the height (pushing the parent to be larger) to be calculated differently than scrollHeight (causing the parent to scroll) when the fonts vary
[18:34:42] <Krenair>	 Unknown error: "titleblacklist-forbidden-edit"
[18:34:48] <Krenair>	 that should be easy to catch
[18:34:56] <RoanKattouw>	 MatmaRex: https://gerrit.wikimedia.org/r/#/c/197475/1
[18:35:43] <grrrit-wm>	 (03CR) 10Physikerwelt: [C: 032] "PS1 was a good catch from jenkins. Hard to see for human." [extensions/Math] - 10https://gerrit.wikimedia.org/r/197685 (owner: 10BryanDavis)
[18:37:05] <Krenair>	 Oh, lol
[18:37:10] <Krenair>	 So the API is the bit that doesn't recognise this error
[18:37:28] <Krenair>	 {"error":{"code":"unknownerror","info":"Unknown error: \"titleblacklist-forbidden-edit\""}}
[18:37:34] <Krenair>	 gj titleblacklist
[18:37:35] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/196571
[18:37:45] <edsanders>	 TrevorParscal, I get scroll bars for both
[18:37:57] <Krenair>	 I seem to recall the system which deals with these is Roan's fault.
[18:38:07] <James_F>	 ryasmeen: https://phabricator.wikimedia.org/P414
[18:38:14] <RoanKattouw>	 Krenair: $messageMap?
[18:38:16] <Krenair>	 yes
[18:38:18] <TrevorParscal>	 edsanders: yeah, i am trying to recreate it more exactly, but I've already found that changing 1em to 1.25em fixes the issue for us
[18:38:58] <guillom>	 RoanKattouw: Want to review those diffs later? Looks like you're busy :)
[18:39:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Load special characters in Platform instead of SpecialCharacterDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197478 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[18:39:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: PSR-3 logging cleanup [extensions/Math] - 10https://gerrit.wikimedia.org/r/197685 (owner: 10BryanDavis)
[18:39:39] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Deleting from an empty paragraph to the end of an inline node throws an exception - https://phabricator.wikimedia.org/T72375#1129739 (10Etonkovidova) Verified in beta - for general cases i...
[18:39:57] <RoanKattouw>	 guillom: No let's do it
[18:40:07] <guillom>	 ok
[18:40:31] <James_F>	 ryasmeen: https://phabricator.wikimedia.org/maniphest/query/XQOyBC2qNvvg/#R
[18:40:52] <guillom>	 RoanKattouw: so we have the second table at https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Diffs and the one at https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis/Diffs
[18:41:04] <RoanKattouw>	 OK
[18:41:06] <RoanKattouw>	 The English one first?
[18:41:09] <guillom>	 6 "bugs" in total
[18:41:09] <guillom>	 sure
[18:41:15] <RoanKattouw>	 Wow 95% OK
[18:41:45] <RoanKattouw>	 Yeah the spaces one is craz
[18:41:47] <RoanKattouw>	 y
[18:42:18] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Avoid miscalculation of monospace text height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197700 (https://phabricator.wikimedia.org/T92450) 
[18:43:05] <wikibugs>	 10VisualEditor, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Comment body in context showing a scrollbar - https://phabricator.wikimedia.org/T92450#1129757 (10TrevorParscal)
[18:43:10] <wikibugs>	 10VisualEditor, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Comment body in context showing a scrollbar - https://phabricator.wikimedia.org/T92450#1111166 (10TrevorParscal)
[18:43:59] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3VisualEditor 2014/15 Q3 blockers: Initial render of citations' (templates'?) context item provides links without target="_blank" - https://phabricator.wikimedia.org/T91314#1129760 (10TrevorParscal)
[18:44:12] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q3 blockers: Context menu does not update the change immediately unless you re-open it - https://phabricator.wikimedia.org/T91336#1129761 (10TrevorParscal)
[18:44:54] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3VisualEditor 2014/15 Q3 blockers: Initial render of citations' (templates'?) context item provides links without target="_blank" - https://phabricator.wikimedia.org/T91314#1079701 (10TrevorParscal)
[18:45:02] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q3 blockers: Context menu does not update the change immediately unless you re-open it - https://phabricator.wikimedia.org/T91336#1080405 (10TrevorParscal)
[18:45:07] <RoanKattouw>	 guillom: https://phabricator.wikimedia.org/T68628
[18:45:27] <RoanKattouw>	 guillom: (for https://en.wikipedia.org/w/index.php?diff=651788988)
[18:45:41] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q3 blockers: Initial render of citations' (templates'?) context item provides links without target="_blank" - https://phabricator.wikimedia.org/T91314#1079701 (10TrevorParscal)
[18:47:41] <Krenair>	 I think there was something else I had planned to add to messageMap months ago
[18:47:46] <Krenair>	 but I can't quite remember what it was...
[18:47:56] <Krenair>	 maybe something contenthandler related..
[18:48:13] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 5Patch-For-Review: [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1129772 (10Florian) 5Open>3Resolved All changes are merged and i can start VE on mobile on de.wiki, so i assume it is fixed? :)
[18:48:20] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web: [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1129774 (10Florian)
[18:48:32] <Krenair>	 maybe it was https://gerrit.wikimedia.org/r/#/c/159237/
[18:50:03] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (6bd2ea5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197701 
[18:50:21] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Remove domElements attribute from aliens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197047 (owner: 10Esanders)
[18:51:00] <RoanKattouw>	 guillom: https://phabricator.wikimedia.org/T93116
[18:51:35] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 5WMF-deploy-2015-03-04_(1.25wmf20), 5WMF-deploy-2015-03-11_(1.25wmf21): [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1129799 (10Florian)
[18:51:46] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 5WMF-deploy-2015-03-11_(1.25wmf21), 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression wmf21] VisualEditor in mobile doesn't load - https://phabricator.wikimedia.org/T93036#1127162 (10Florian)
[18:51:59] <RoanKattouw>	 guillom: File a bug for https://en.wikipedia.org/w/index.php?diff=651789228 indicating it's probably related to copy/paste
[18:52:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (6bd2ea5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197701 (owner: 10Jforrester)
[18:52:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove domElements attribute from aliens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197047 (owner: 10Esanders)
[18:54:18] <mooeypoo>	 James_F, I need i18n-message help
[18:54:28] <RoanKattouw>	 guillom: File a bug about https://fr.wikipedia.org/w/index.php?diff=112877079
[18:55:35] <wikibugs>	 10Cite: Cite: Add namespace detection for automatically generated reference list - https://phabricator.wikimedia.org/T70324#1129817 (10DMacks) And now  Wikipedia:Village pump (proposals)#Fix problem with references on talk pages  An idea I added there that I didn't see before was to have the automatic list for b...
[18:56:27] <milimetric>	 https://www.irccloud.com/pastebin/9VwBBwls
[18:56:42] <milimetric>	 Krenair: there's a summary of the errors I'm seeing now
[18:57:15] <grrrit-wm>	 (03PS3) 10Alex Monk: WIP - Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) 
[18:57:52] <milimetric>	 basically, editing session id is not set in a bunch of cases, and in some cases it's not set to the correct type.  And the value set for action.ready.timing and action.abort.timing seems to be of an invalid type.
[18:58:11] <milimetric>	 Krenair: please check these in beta labs and let me know if you can't replicate them.
[18:58:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP - Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[18:58:25] <Krenair>	 milimetric, are these all new errors coming in right now? or older ones?
[18:58:27] <milimetric>	 also, Krenair: a lot of events are going in valid though
[18:58:34] <milimetric>	 Krenair: these are coming in right now, yes
[18:58:41] <Krenair>	 because I thought we fixed these
[18:58:53] <milimetric>	 I thought so too - is it possible it's not deployed everywhere?
[18:59:02] <Krenair>	 not sure about those .timing ones
[18:59:10] <milimetric>	 those were pretty rare
[18:59:18] <milimetric>	 and they look new, yes
[18:59:25] <James_F>	 milimetric: Could be cached code.
[18:59:45] <James_F>	 milimetric: Client-side code is cached for up to a week (ultra-worst case); almost all will go in minutes, though.
[19:00:26] <milimetric>	 all will go in minutes as in we're invalidating the caches soon?
[19:00:32] <RoanKattouw>	 guillom: File a bug about https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Diff/112876979
[19:01:24] <RoanKattouw>	 guillom: File a bug for https://fr.wikipedia.org/w/index.php?diff=112876912 too
[19:01:38] <wikibugs>	 10WikiEditor, 7Regression: WikiEditor test throws "[Edit] Missing property editingSessionId" - https://phabricator.wikimedia.org/T93119#1129836 (10Krinkle) 3NEW
[19:02:08] <RoanKattouw>	 guillom: https://phabricator.wikimedia.org/T52100
[19:02:13] <wikibugs>	 10WikiEditor, 7Regression: WikiEditor test throws "[Edit] Missing property editingSessionId" - https://phabricator.wikimedia.org/T93119#1129844 (10Krinkle)
[19:02:27] <grrrit-wm>	 (03CR) 10Krinkle: "Causes T93119." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/191221 (https://phabricator.wikimedia.org/T88027) (owner: 10Alex Monk)
[19:03:12] <milimetric>	 Krenair / James_F: some of that may be client caches, and let me know if I should re-check once you feel those are purged for the most part
[19:03:23] <milimetric>	 however, a lot of these errors are showing up in the server logs as well
[19:03:38] <Krenair>	 milimetric, "Failed validating u'type'" -> possibly caused by nulls/undefineds?
[19:03:41] <milimetric>	 so do please test your latest versions in beta labs and make sure you're not seeing the same errors
[19:03:56] <milimetric>	 Krenair: yeah, that could be a few things.
[19:04:19] <milimetric>	 If that value is always quoted, then it should only be null / undefined, yes
[19:05:32] <milimetric>	 James_F: on a broader note, at this point I'm not comfortable standing behind any of the results we've compiled from the data so far.  With the discovery of the many invalid abort events, there's just no way to know what the proportions look like with all the data
[19:05:39] <milimetric>	 Therefore, my current thinking is:
[19:05:41] * James_F nods.
[19:05:49] <milimetric>	 rerun the analysis once good data flows on both VE and WT
[19:06:06] <milimetric>	 and as a lower priority try to fix up the bad data and re-run once the old stuff is clean too
[19:06:40] <James_F>	 Is that "now"?
[19:06:42] <grrrit-wm>	 (03PS13) 10Physikerwelt: Move integration tests to a new special page [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) 
[19:06:43] <milimetric>	 meanwhile I'll be trying to make the dashboard pretty and have an A/B look and feel
[19:07:00] <milimetric>	 James_F: right now, bad data is still flowing in large numbers
[19:07:01] <James_F>	 (The good-data-flowing state.)
[19:07:05] <James_F>	 Hmm.
[19:07:08] <wikibugs>	 10OOjs-UI-0.9.1, 10VisualEditor, 10VisualEditor-EditingTools, 7Browser-Support-Firefox, and 3 others: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1129858 (10Etonkovidova) Verified the f...
[19:08:08] <mooeypoo>	 TrevorParscal, do you have a second? I'm getting a weird error in  OO.ui.ProcessDialog
[19:08:31] <TrevorParscal>	 one sec
[19:08:32] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] "* Copy WikiEditor's messages into VE" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk)
[19:08:33] <milimetric>	 James_F: please feel free to raise the priority on the "clean up bad data" part of the task.  I can claim "Top Q3 Goal" and get more help (in theory :))
[19:09:27] <James_F>	 milimetric: The good-data-flowing bit is the more important, but yes, understanding where we've been also is.
[19:10:17] <milimetric>	 i agree, do you want to make it a high priority to finish the bad data clean-up by the end of the quarter?
[19:10:44] * milimetric hovers his hand over the red button
[19:10:51] <James_F>	 milimetric: Yes.
[19:11:00] * milimetric pushes the red button
[19:11:21] <Krenair>	 milimetric, these errors you've pasted can come from clients or the server, right?
[19:11:42] <milimetric>	 Krenair: the "Visual Editor" section was compiled by looking at the client error logs
[19:11:50] <milimetric>	 the "Wikitext" section was compiled by looking at the server logs
[19:12:00] <Krenair>	 ok
[19:12:01] <milimetric>	 I was careful to look for editor: wikitext in the "visual editor" section
[19:12:05] <milimetric>	 and I found none
[19:12:17] <milimetric>	 I also found no editor: wikitext in the client logs at all
[19:12:22] <milimetric>	 (client error logs)
[19:12:46] <grrrit-wm>	 (03PS2) 10Divec: WIP DONTMERGE: BREAKING CHANGE: Use unicode character class to calculate word expansions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) 
[19:15:14] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: VisualEditor: Can't copy a single node selection (e.g. template / media / reference) in Safari - https://phabricator.wikimedia.org/T72143#1129876 (10Whatamidoing-WMF) I can't paste list items i...
[19:15:18] <Krenair>	 milimetric, right, I don't see how we're getting that wikitext error at all
[19:15:37] <milimetric>	 Krenair: did you run it in beta labs?
[19:15:51] <Krenair>	 no
[19:15:56] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression pre-wmf22] Link icon is missing form the VE toolbar - https://phabricator.wikimedia.org/T92576#1129879 (10Etonkovidova) New link icon was added in betalabs.
[19:16:08] <grrrit-wm>	 (03PS2) 10Catrope: Update VE core submodule to master (6bd2ea5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197701 (owner: 10Jforrester)
[19:16:17] <milimetric>	 Krenair: I think that's the required step here.  Do you know how to debug there?
[19:16:21] <Krenair>	 no
[19:16:28] <Krenair>	 I think I had a link to a page explaining it at some poin
[19:16:31] <Krenair>	 point*
[19:16:47] <milimetric>	 ok, I am not super familiar with it either, but we can try to hangout and do it together?
[19:17:00] <Krenair>	 ah: https://wikitech.wikimedia.org/wiki/EventLogging/Testing/BetaLabs#How_to_check_if_events_are_valid
[19:17:03] <milimetric>	 yep
[19:17:51] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari: VisualEditor: Pasting a template throws undefined getModel error - https://phabricator.wikimedia.org/T60383#1129881 (10Whatamidoing-WMF) Does this bug mean "you can copy stuff, but nothing happens when you try to paste it"?
[19:21:15] <Krenair>	 milimetric, I am getting the events I would expect through
[19:21:30] <Krenair>	 from this command:
[19:21:31] <grrrit-wm>	 (03PS1) 10Mooeypoo: ProcessDialog: send an array to showErrors in failed executeAction [oojs/ui] - 10https://gerrit.wikimedia.org/r/197713 
[19:21:31] <Krenair>	 krenair@deployment-eventlogging02:/var/log/eventlogging$ tail -f all-events.log | grep Edit | grep -v visualeditor
[19:22:07] <milimetric>	 I'd grep for the 114... revision number
[19:22:28] <milimetric>	 but all-events won't have the bad events, right
[19:22:38] <milimetric>	 the good events are coming in, but bad ones are as well
[19:22:52] <milimetric>	 hm... might be more convoluted than a simple test would show
[19:23:13] <milimetric>	 i'll log on too and take a look
[19:24:25] <Krenair>	 milimetric, verified
[19:24:49] <milimetric>	 Krenair: yeah, I was just seeing the bad ones with: ^Cmilimetric@deployment-eventlogging02:/var/log/upstart$ sudo tail -f eventlogging_processor-server-side-events.log
[19:24:51] <Krenair>	 ^Ckrenair@deployment-eventlogging02:/var/log/upstart$ sudo tail -f eventlogging_processor-server-side-events.log | grep -v Echo
[19:24:58] <Krenair>	 yeha
[19:25:22] <milimetric>	 k, good, thank god it's not one of those "sometimes" bugs :)
[19:26:34] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Visual Editor save dialog hangs, causing data loss - https://phabricator.wikimedia.org/T91949#1129916 (10LuisVilla) Obviously hard to get to a console after the fact :) I'll take a look if it happens again.
[19:31:01] <Krenair>	 yep, caught one of the relevant errors
[19:31:03] <Krenair>	 "editingSessionId":null
[19:31:46] <Krenair>	 https://github.com/wikimedia/mediawiki-extensions-WikiEditor/blob/master/WikiEditor.hooks.php#L443-L447 :|
[19:32:04] <Krenair>	 how can that be null?
[19:35:46] <grrrit-wm>	 (03PS1) 10Mooeypoo: Add general error to the inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197718 (https://phabricator.wikimedia.org/T93005) 
[19:36:13] <Krenair>	 milimetric, oohhh, I think I see why it's happening
[19:36:49] <Krenair>	 WebRequest::getVal with a $default will actually default to (string)$default, unless $default is null
[19:36:57] <Keegan>	 You know what would be awesome on my meta talk page right about now? VisualEditor.
[19:37:11] <milimetric>	 Krenair: I've literally never done anything with PHP besides copy/paste, but what if "$request->getVal( 'editingStatsId', false ) === false"
[19:37:11] <milimetric>	 oh it doesn't log
[19:37:11] <milimetric>	 heh
[19:37:11] <milimetric>	 Krenair: could it be an integer?
[19:37:35] <milimetric>	 it's excluded from pages like Talk on purpose, right? :)
[19:38:39] <Krenair>	 that doesn't explain why it's coming through null though...
[19:39:11] <Krenair>	 oh, it isn't
[19:39:18] <Krenair>	 ok, I understand this now
[19:42:35] <grrrit-wm>	 (03PS1) 10Alex Monk: Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197720 
[19:48:13] <grrrit-wm>	 (03CR) 10Alex Monk: "Was causing P415" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197720 (owner: 10Alex Monk)
[19:48:24] <grrrit-wm>	 (03CR) 10Alex Monk: "That doesn't auto-link? https://phabricator.wikimedia.org/P415" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197720 (owner: 10Alex Monk)
[19:54:01] <grrrit-wm>	 (03CR) 10Esanders: Factor out ve.compareClassLists functionality (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 (owner: 10Esanders)
[19:55:07] <Krenair>	 milimetric, anyway that solves the wikitext errors
[19:55:14] <Krenair>	 will look at the VE ones now
[19:55:19] <grrrit-wm>	 (03PS3) 10Esanders: Factor out ve.compareClassLists functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 
[19:57:27] <Krenair>	 krenair@deployment-eventlogging02:/var/log/upstart$ sudo grep visualeditor eventlogging_processor-server-side-events.log
[19:57:27] <Krenair>	 krenair@deployment-eventlogging02:/var/log/upstart$ 
[19:57:30] <Krenair>	 milimetric, ^
[19:58:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Factor out ve.compareClassLists functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 (owner: 10Esanders)
[19:58:41] <wikibugs>	 10VisualEditor: <span>s inserted in VE edit - https://phabricator.wikimedia.org/T93125#1129989 (10gpaumier) 3NEW
[19:58:50] <Krenair>	 It does appear in these files though:
[19:58:53] <Krenair>	 eventlogging_processor-server-side-events.log.5.gz
[19:58:53] <Krenair>	 eventlogging_processor-server-side-events.log.6.gz
[19:58:53] <Krenair>	 eventlogging_processor-server-side-events.log.7.gz
[19:59:14] <Krenair>	 riiight... server-side. need client-side as well for VE
[20:00:54] <Krenair>	 Failed validating u'type' in schema[u'properties'][u'event'][u'properties'][u'action.saveSuccess.timing']
[20:05:52] <wikibugs>	 10VisualEditor: & converted to &amp; in reference name - https://phabricator.wikimedia.org/T93128#1130029 (10gpaumier) 3NEW
[20:10:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (6bd2ea5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197701 (owner: 10Jforrester)
[20:11:15] <wikibugs>	 10VisualEditor: Newline between templates removed by VE - https://phabricator.wikimedia.org/T93129#1130064 (10gpaumier) 3NEW
[20:12:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (6bd2ea5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197701 (owner: 10Jforrester)
[20:17:53] <wikibugs>	 10VisualEditor: Space added in named reference - https://phabricator.wikimedia.org/T93130#1130099 (10gpaumier) 3NEW
[20:40:14] <grrrit-wm>	 (03PS1) 10Physikerwelt: Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) 
[20:40:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt)
[20:42:46] <grrrit-wm>	 (03PS2) 10Physikerwelt: Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) 
[20:43:12] <grrrit-wm>	 (03PS1) 10Divec: Add isBreak surrogate pair support for code unit strings [unicodejs] - 10https://gerrit.wikimedia.org/r/197739 
[20:43:39] <grrrit-wm>	 (03CR) 10Physikerwelt: "maybe it's time to support '[]' instead of array()" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt)
[20:53:44] <grrrit-wm>	 (03PS3) 10Divec: WIP BREAKING CHANGE: Use unicode character class to calculate word expansions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) 
[20:54:29] <Kostic>	 What version of PHP is required to run 1.25 branch?
[20:56:53] <divec_>	 James_F: I'm creating trouble again - VE https://gerrit.wikimedia.org/r/197661 needs UnicodeJS https://gerrit.wikimedia.org/r/197739
[21:01:15] <James_F>	 divec_: :-)
[21:01:26] <James_F>	 Kostic: PHP 5.3.3, I believe.
[21:02:21] <Kostic>	 James_F: Ok thanks.
[21:03:06] <Kostic>	 One more question, did any of you had a problem where you weren't able to edit a page with VisualEditor if that page was in a namespace which is restricted by the extension "Lockdown"?
[21:03:35] <Kostic>	 I'm having a problem like this: http://www.mediawiki.org/wiki/Thread:Extension_talk:Lockdown/Lockdown_and_VisualEditor_-_can%27t_edit_protected_pages
[21:03:41] <Kostic>	 In my 1.24 installation.
[21:04:59] <James_F>	 Kostic: Never heard of the Lockdown extension. It's highly likely that extensions that fiddle with how MediaWiki works can break VisualEditor, yes.
[21:07:31] <Kostic>	 I am aware of that and I think that this extension could be a reason why VisualEditor doesn't work.
[21:07:48] <James_F>	 What happens when you disable the extension?
[21:08:57] <Kostic>	 VisualEditor works.
[21:09:17] <Kostic>	 I'm bafled why regular WikiEditor works fine with extension turned on.
[21:09:39] <James_F>	 Because the person who wrote Lockdown probably hacked in support for WikiEditor, but didn't for VisualEditor.
[21:10:53] <Kostic>	 Probably.
[21:11:14] <Krenair>	 Ew, lockdown.
[21:11:22] <Krenair>	 Isn't that one of those access restriction extensions?
[21:11:23] <Kostic>	 I know, I know.
[21:11:25] <Kostic>	 Yes.
[21:11:36] <Kostic>	 Group access management.
[21:11:42] <Krenair>	 Yeah, that's not going to work or be supported for use with VE.
[21:12:00] <Kostic>	 What should I use?
[21:12:07] <Kostic>	 Multiple wiki installations?
[21:12:12] <Krenair>	 That's what we do.
[21:12:33] <Kostic>	 Can I share a single user table betwen installations?
[21:12:40] <Krenair>	 Or, rather, multiple wiki DBs on a single install
[21:12:46] <Krenair>	 Yes
[21:13:08] <Kostic>	 Krenair: can you point me to a resource with details about that kind of setup?
[21:14:10] <Krenair>	 https://www.mediawiki.org/wiki/Manual:Shared_database#The_simplest_setup:_A_shared_user_table
[21:14:26] <Kostic>	 Krenair: Thank you.
[21:16:35] <grrrit-wm>	 (03PS3) 10Jforrester: Update VE core submodule to master (b57d224) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197057 (owner: 10Esanders)
[21:17:19] <grrrit-wm>	 (03PS1) 10Mooeypoo: Split the inspector into panels [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197746 
[21:17:28] <mooeypoo>	 TrevorParscal, ^^
[21:18:12] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (b57d224) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197057 (owner: 10Esanders)
[21:20:03] <grrrit-wm>	 (03PS2) 10Jforrester: Avoid miscalculation of monospace text height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197700 (https://phabricator.wikimedia.org/T92450) (owner: 10Trevor Parscal)
[21:20:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (b57d224) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197057 (owner: 10Esanders)
[21:22:02] <James_F>	 Krenair: Do you want https://gerrit.wikimedia.org/r/#/c/197742/ backported/
[21:22:39] <Krenair>	 If we want to be using the new version of the schema properly, yes
[21:23:31] <James_F>	 Fun. OK.
[21:23:38] <Krenair>	 I also need to finish and upload a commit to make VE use it.
[21:23:39] * James_F nods.
[21:23:45] <Krenair>	 And a commit to make VE send the MW version.
[21:23:46] <James_F>	 And WE? Or is that handled OK?
[21:23:55] <James_F>	 Isn't that to WikimediaEvents?
[21:23:58] <Krenair>	 Haven't checked.
[21:24:01] <Krenair>	 That's the next thing.
[21:24:03] <James_F>	 Kk.
[21:24:05] <Krenair>	 Then we can update WikimediaEvents
[21:24:08] <James_F>	 I'll shut up and let you work. :-)
[21:24:17] <Krenair>	 :)
[21:24:40] <grrrit-wm>	 (03Draft1) 10Physikerwelt: Localisation updates from https://translatewiki.net. [extensions/Math] (develop) - 10https://gerrit.wikimedia.org/r/197748 
[21:24:52] <Krenair>	 wat
[21:25:06] <grrrit-wm>	 (03Draft1) 10Physikerwelt: Fix PHPUnit provider name [extensions/Math] (develop) - 10https://gerrit.wikimedia.org/r/197749 
[21:25:13] <grrrit-wm>	 (03Draft1) 10Physikerwelt: PSR-3 logging cleanup [extensions/Math] (develop) - 10https://gerrit.wikimedia.org/r/197750 
[21:25:14] <James_F>	 Krenair: Development branch cross-pull. Ignore. :-)
[21:25:23] <grrrit-wm>	 (03Draft1) 10Physikerwelt: Render math tags in search results [extensions/Math] (develop) - 10https://gerrit.wikimedia.org/r/197751 (https://phabricator.wikimedia.org/T93075) 
[21:26:32] <grrrit-wm>	 (03CR) 10Physikerwelt: "recheck" [extensions/Math] (develop) - 10https://gerrit.wikimedia.org/r/197749 (owner: 10Physikerwelt)
[21:26:46] <Krenair>	 Gah. Also need to localise the error message
[21:27:28] <Krenair>	 So we need to optionally load messages...
[21:27:52] <James_F>	 Does that need to happen before we backport? Or just fix later this week for master?
[21:30:14] <Krenair>	 James_F, we'll probably have to do this later in the week
[21:30:22] * James_F nods.
[21:30:30] <Krenair>	 unless we can get everything moved to the new schema before then
[21:30:36] <Kostic>	 Can I specify a empty database and expect from Mediawiki to populate it with default tables it requires?
[21:30:43] <Krenair>	 no
[21:30:48] <Krenair>	 you will get db errors
[21:31:09] <Krenair>	 mediawiki does not expect to run with that level of DB privileges AFAIK
[21:31:22] <Krenair>	 we have wikiuser vs. wikiadmin, IIRC
[21:31:32] <Kostic>	 So, just delete LocalSettings.php and load up index, go through installation procedure?
[21:33:12] <Kostic>	 And I have just realised that I'm asking general mw questions in a wrong channel. Sorry about that. :)
[21:33:19] <Krenair>	 :P
[21:33:29] <Krenair>	 Careful about deleting LocalSettings!
[21:33:35] <Krenair>	 that probably contains important things
[21:34:02] <Krenair>	 but yes, that being missing will send you to the installer
[21:34:22] <Kostic>	 I usually think of mv ./something ../ when I say remove. :)
[21:39:26] <grrrit-wm>	 (03Restored) 10Jforrester: [BREAKING CHANGE] Make all Elements flaggable, and scrap the FlaggedElement mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/164007 (owner: 10Jforrester)
[21:40:09] <Krenair>	 legoktm, sigh
[21:40:16] <Krenair>	 legoktm, I think I'm going to have to do more work on Titleblacklist
[21:40:20] <James_F>	 Boo.
[21:40:49] <Krenair>	 and actually...
[21:40:58] <grrrit-wm>	 (03CR) 10Esanders: "See commit message" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders)
[21:41:05] <Krenair>	 Its provided message relies on <code>
[21:41:08] <legoktm>	 Krenair: it wasn't good enough?
[21:41:13] <legoktm>	 :/
[21:41:23] <Krenair>	 Well it provides the error and the API doesn't return unknown error anymore
[21:41:39] <Krenair>	 But the built in i18n message it has relies on a parameter
[21:41:49] <Krenair>	 that is the blacklist entry that the title matched
[21:42:31] <Krenair>	 the other problem with the message is the <code> block
[21:42:39] <Krenair>	 which I don't think we can handle on the client
[21:44:25] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Avoid miscalculation of monospace text height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197700 (https://phabricator.wikimedia.org/T92450) (owner: 10Trevor Parscal)
[21:44:49] <wikibugs>	 10VisualEditor, 10WMF-deploy-2015-03-25_(1.25wmf23), 3VisualEditor 2014/15 Q3 blockers: Comment body in context showing a scrollbar - https://phabricator.wikimedia.org/T92450#1130358 (10Jdforrester-WMF) 5Open>3Resolved
[21:45:24] <Krenair>	 James_F, legoktm: I guess we could have our own visualeditor-saveerror-titleblacklist message :(
[21:45:35] <James_F>	 Krenair: Better than nothing.
[21:46:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid miscalculation of monospace text height [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197700 (https://phabricator.wikimedia.org/T92450) (owner: 10Trevor Parscal)
[21:48:34] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Add general error to the inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197718 (https://phabricator.wikimedia.org/T93005) (owner: 10Mooeypoo)
[21:49:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add general error to the inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197718 (https://phabricator.wikimedia.org/T93005) (owner: 10Mooeypoo)
[21:49:44] <wikibugs>	 10VisualEditor, 10Citoid, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Add requested language as part of request header to citoid service - https://phabricator.wikimedia.org/T90603#1130370 (10Jdforrester-WMF)
[21:49:53] <wikibugs>	 10VisualEditor, 10Citoid: When http error is encountered by citefromurl dialog, dialog stays pending and cancel button does not work. - https://phabricator.wikimedia.org/T88897#1130371 (10Jdforrester-WMF)
[21:50:28] <wikibugs>	 10VisualEditor, 10Citoid, 10WMF-deploy-2015-03-25_(1.25wmf23): More user-friendly message for 520s (when the service is unable to obtain metadata about the resource) - https://phabricator.wikimedia.org/T93005#1130378 (10Jdforrester-WMF) 5Open>3Resolved
[21:54:24] <grrrit-wm>	 (03PS1) 10Alex Monk: Handle TitleBlacklist errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197762 
[21:56:14] <grrrit-wm>	 (03CR) 10Jforrester: Handle TitleBlacklist errors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197762 (owner: 10Alex Monk)
[21:59:03] <grrrit-wm>	 (03PS2) 10Alex Monk: Handle TitleBlacklist errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197762 
[21:59:06] <Krenair>	 James_F, so the other difference is addition of action.saveFailure.message
[21:59:13] <Krenair>	 which is not marked as a required property
[21:59:30] <Krenair>	 and makes no sense for VE to fill out
[21:59:37] <Krenair>	 VE has action.saveFailure.type instead
[21:59:55] <James_F>	 Can we put the message in if it's unknownError?
[22:00:00] <James_F>	 Or whatever it's called?
[22:00:29] <Krenair>	 er, good point
[22:00:36] <James_F>	 Cool. :-)
[22:01:33] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add isBreak surrogate pair support for code unit strings [unicodejs] - 10https://gerrit.wikimedia.org/r/197739 (owner: 10Divec)
[22:02:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add isBreak surrogate pair support for code unit strings [unicodejs] - 10https://gerrit.wikimedia.org/r/197739 (owner: 10Divec)
[22:03:46] <Krenair>	 oh. timo might not like this
[22:04:01] <grrrit-wm>	 (03PS1) 10Jforrester: Tag v0.1.4 [unicodejs] - 10https://gerrit.wikimedia.org/r/197764 
[22:04:05] <James_F>	 RoanKattouw: ^^^
[22:05:48] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Tag v0.1.4 [unicodejs] - 10https://gerrit.wikimedia.org/r/197764 (owner: 10Jforrester)
[22:05:51] <James_F>	 Ta.
[22:06:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tag v0.1.4 [unicodejs] - 10https://gerrit.wikimedia.org/r/197764 (owner: 10Jforrester)
[22:09:01] <grrrit-wm>	 (03PS1) 10Jforrester: Update UnicodeJS to v0.1.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197765 
[22:09:20] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update UnicodeJS to v0.1.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197765 (owner: 10Jforrester)
[22:11:05] <grrrit-wm>	 (03PS4) 10Jforrester: [WIP] [BREAKING CHANGE] Use Unicode character class to calculate word expansions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) (owner: 10Divec)
[22:11:43] <grrrit-wm>	 (03CR) 10Jforrester: "PS4 is a rebase onto the UnicodeJS v0.1.4 release merge, with related comments removed from the commit summary." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) (owner: 10Divec)
[22:12:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update UnicodeJS to v0.1.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197765 (owner: 10Jforrester)
[22:14:35] <mooeypoo>	 RoanKattouw, if I have a function that returns a $.when.apply( $, someArray ).then( ... ) and inside its "then" method, at the end, it returns another $.when.apply( $, anotherArray ) --> this will result in the grand-parent promise (the method that returns both of these) to resolve only after both when's resolve. Right?
[22:14:43] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Split the inspector into panels [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197746 (owner: 10Mooeypoo)
[22:14:50] <wikibugs>	 10VisualEditor: Insert special character icon does not work in Media settings-Caption and Basic-References dialog boxes - https://phabricator.wikimedia.org/T93146#1130432 (10Etonkovidova) 3NEW
[22:14:54] <RoanKattouw>	 mooeypoo: .... yes
[22:15:01] <mooeypoo>	 I don't need to explicitly add another .then( ... return $.Deferred.resolve(); ...) at the end
[22:15:07] <RoanKattouw>	 mooeypoo: The resulting promise will be equivalent to the latter promise
[22:15:08] <RoanKattouw>	 No no
[22:15:43] <RoanKattouw>	 fooPromise.then( function () { ... return barPromise; } ); returns a promise that is equivalent to barPromise
[22:15:53] <RoanKattouw>	 So yeah you don't need a deferred resolve at the end
[22:16:00] <mooeypoo>	 ok just checking
[22:16:05] <RoanKattouw>	 I mean unless you have a reason why you need to coerce failure to success but that's a strange edge case
[22:16:14] <wikibugs>	 10VisualEditor: Insert special character icon does not work in Media settings-Caption and Basic-References dialog boxes - https://phabricator.wikimedia.org/T93146#1130450 (10Jdforrester-WMF)
[22:16:15] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References, 5Patch-For-Review: [Regression wmf20] Special Character inserter does not work in Media captions or basic references - https://phabricator.wikimedia.org/T91600#1090822 (10Jdforrester-WMF)
[22:16:39] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Split the inspector into panels [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197746 (owner: 10Mooeypoo)
[22:16:47] <mooeypoo>	 it's a bit meh to do a nested $.when like this, but since we're dealing with templates (that have *PARTS* that need to all be rendered) and then generated nodes (that need to generate..) it is unavoidable.
[22:17:02] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Split the inspector into panels [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197746 (owner: 10Mooeypoo)
[22:17:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Split the inspector into panels [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197746 (owner: 10Mooeypoo)
[22:18:21] <grrrit-wm>	 (03PS1) 10Alex Monk: Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197769 
[22:20:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197769 (owner: 10Alex Monk)
[22:21:12] <mooeypoo>	 RoanKattouw, okay, that node we found? it is no worky.
[22:21:57] <grrrit-wm>	 (03PS2) 10Alex Monk: Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197769 
[22:22:43] <Krenair>	 have uploaded https://gerrit.wikimedia.org/r/#/c/197770/
[22:24:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197769 (owner: 10Alex Monk)
[22:24:45] <grrrit-wm>	 (03PS3) 10Alex Monk: Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197769 
[22:26:15] <Krenair>	 James_F, honestly with at least 4 patches that'd need to be backported simultaneously... might have to wait for the train
[22:26:39] <Krenair>	 I haven't even checked WikiEditor yet
[22:28:08] <Krenair>	 I think WikiEditor is fine
[22:29:16] <grrrit-wm>	 (03PS1) 10Catrope: Add .mailmap file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197772 
[22:30:01] <grrrit-wm>	 (03PS1) 10Catrope: Add .mailmap file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197773 
[22:32:50] <grrrit-wm>	 (03PS1) 10Mooeypoo: Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 
[22:32:55] <grrrit-wm>	 (03PS1) 10Catrope: Add Kirsten to AUTHORS.txt [oojs/ui] - 10https://gerrit.wikimedia.org/r/197775 
[22:33:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 (owner: 10Mooeypoo)
[22:33:35] <grrrit-wm>	 (03PS1) 10Catrope: Add .mailmap file [oojs/ui] - 10https://gerrit.wikimedia.org/r/197776 
[22:34:56] <grrrit-wm>	 (03PS2) 10Mooeypoo: Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 
[22:41:16] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197769 (owner: 10Alex Monk)
[22:42:38] <Krenair>	 RoanKattouw, we doing the others as well then?
[22:42:38] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Handle TitleBlacklist errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197762 (owner: 10Alex Monk)
[22:42:42] <Krenair>	 ok
[22:43:03] <Krenair>	 RoanKattouw, https://gerrit.wikimedia.org/r/#/c/197770/
[22:43:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197769 (owner: 10Alex Monk)
[22:43:58] <whatami>	 The weekly bug triage meeting for VisualEditor is starting in about 15 to 20 minutes.  If you’re interested in joining, the information is posted on wiki at https://www.mediawiki.org/wiki/Talk:VisualEditor/Portal  This meeting will happen in Google Hangouts.  A few people will also be in the usual IRC office hours channel (see https://meta.wikimedia.org/wiki/IRC_office_hours )
[22:44:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle TitleBlacklist errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197762 (owner: 10Alex Monk)
[22:46:11] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: & converted to &amp; in reference name - https://phabricator.wikimedia.org/T93128#1130504 (10gpaumier)
[22:46:21] <grrrit-wm>	 (03PS1) 10Catrope: Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197783 
[22:46:27] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: <span>s inserted in VE edit - https://phabricator.wikimedia.org/T93125#1130506 (10gpaumier)
[22:46:38] <grrrit-wm>	 (03PS1) 10Catrope: Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197784 
[22:47:00] <grrrit-wm>	 (03PS1) 10Catrope: Handle TitleBlacklist errors [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197786 
[22:47:12] <grrrit-wm>	 (03PS1) 10Catrope: Handle TitleBlacklist errors [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197787 
[22:50:04] <Krenair>	 RoanKattouw, are we merging all these and making the submodule updates before swat in 10 minutes..?
[22:50:25] <James_F>	 Krenair: Yes.
[22:50:28] <James_F>	 Krenair: And more.
[22:50:31] <James_F>	 Krenair: Isn't it fun?
[22:50:32] <Krenair>	 14 patches on swat :|
[22:50:37] <Krenair>	 Shall I start +2ing stuff?
[22:50:42] <James_F>	 Krenair: Roan's taking it.
[22:50:44] <Krenair>	 ok
[22:51:00] <James_F>	 Krenair: https://gerrit.wikimedia.org/r/#/q/status:open+-branch:master,n,z
[22:51:03] * Krenair will bump his patch down the queue
[22:51:47] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Handle TitleBlacklist errors [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197787 (owner: 10Catrope)
[22:51:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Handle TitleBlacklist errors [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197786 (owner: 10Catrope)
[22:51:58] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197784 (owner: 10Catrope)
[22:52:04] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197783 (owner: 10Catrope)
[22:52:25] <Krenair>	 Haha 8 of the patches are ours
[22:52:36] <James_F>	 Krenair: Don't tell anyone. :-)
[22:54:09] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Citoid, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-sel... - https://phabricator.wikimedia.org/T88152#1130544
[22:54:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Handle TitleBlacklist errors [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197786 (owner: 10Catrope)
[22:54:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197784 (owner: 10Catrope)
[22:54:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set action.saveFailure.message key in Edit schema [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197783 (owner: 10Catrope)
[22:56:40] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add .mailmap file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197772 (owner: 10Catrope)
[22:56:46] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add .mailmap file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197773 (owner: 10Catrope)
[22:56:54] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add .mailmap file [oojs/ui] - 10https://gerrit.wikimedia.org/r/197776 (owner: 10Catrope)
[22:57:12] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add Kirsten to AUTHORS.txt [oojs/ui] - 10https://gerrit.wikimedia.org/r/197775 (owner: 10Catrope)
[22:58:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add .mailmap file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197772 (owner: 10Catrope)
[22:58:52] <Krenair>	 James_F, though I guess it only comes down to 2 submodule updates?
[22:59:17] <James_F>	 Krenair: Yeah, one for wmf21 and one for wmf22.
[22:59:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add .mailmap file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197773 (owner: 10Catrope)
[22:59:45] <grrrit-wm>	 (03PS3) 10Mooeypoo: Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 
[23:00:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add Kirsten to AUTHORS.txt [oojs/ui] - 10https://gerrit.wikimedia.org/r/197775 (owner: 10Catrope)
[23:00:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add .mailmap file [oojs/ui] - 10https://gerrit.wikimedia.org/r/197776 (owner: 10Catrope)
[23:02:29] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1130582 (10Krenair) Were you able to create an edit of your own like this? I suspect the huge number of links being added is the problem here, MediaWiki:Badtitletext...
[23:06:29] <Krenair>	 gwicke, hi
[23:06:38] <Krenair>	 gwicke, so I found https://gerrit.wikimedia.org/r/#/c/196584/ -> https://gerrit.wikimedia.org/r/#/c/197414/
[23:06:40] <Krenair>	 but it pre-dates that
[23:06:56] <Krenair>	 is there something new you're seeing in wmf21?
[23:07:50] <gwicke>	 the metric basically disappeared
[23:08:27] <gwicke>	 in https://gerrit.wikimedia.org/r/#/c/196584/7/modules/ve-mw/init/ve.init.mw.Target.js, there was ve.track( 'trace.domLoad.exit' );
[23:08:52] <gwicke>	 which now seems to be in https://gerrit.wikimedia.org/r/#/c/196584/7/modules/ve-mw/init/ve.init.mw.TargetLoader.js
[23:10:28] <gwicke>	 I wonder if the track stuff is already set up at that point
[23:12:08] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Release more things in destroy methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197797 
[23:12:34] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Move click blocking from links to content branches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197799 (https://phabricator.wikimedia.org/T91336) 
[23:13:22] <gwicke>	 Krenair: might make sense to ask RoanKattouw when he's done with the deploy
[23:13:27] <mooeypoo>	 rits, so, dm = Data Model. ce = ContentEditable. UI = User interface
[23:13:27] <Krenair>	 right
[23:13:46] <rits>	 okay
[23:13:54] <ori>	 https://phabricator.wikimedia.org/T87158
[23:13:59] * ori whistles innocently.
[23:15:04] <mooeypoo>	 The data model is a representation of the data in the article. The CE is the content editable nodes on the screen (they are supposed to be always synchronized to what the data model state is), and the UI is the surrounding user interface like buttons, popups, dialogs, etc.
[23:15:07] <wikibugs>	 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 5Patch-For-Review: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox - https://phabricator.wikimedia.org/T78733#1130662 (10Jdlrobson) I did some debugging with legoktm and less seemed to be the issue. We'd need someone who knows #ResourceLoader insid...
[23:15:59] <rits>	 okay 
[23:16:02] <mooeypoo>	 rits, so, if you want to change the way a node looks like on the editable screen, it's usually its ce representation. If you want to change the way its inspector behaves, or the buttons that are activated by certain annotations or nodes, that is UI
[23:16:42] <mooeypoo>	 and if you need to work on how a certain piece of data is represented in the model and is reflected in the flow you go to the data model.
[23:16:42] <rits>	 oh okay 
[23:16:58] <mooeypoo>	 That's a simplified version of "Welcome to VE's dm/ce/ui"
[23:17:35] <mooeypoo>	 There are some exceptions sometimes and some unique things taht involve more than one of the layers, but overall, this is more or less the picture and difference between the three layers.
[23:17:39] <mooeypoo>	 rits, that makes sense?
[23:17:43] <rits>	 now getting it 
[23:17:45] <rits>	 yes
[23:17:50] <ori>	 hi, ur so w/c to ve's dm ce ui
[23:18:17] <Krinkle>	 RoanKattouw: What does the mapmail provide in this case?
[23:18:27] <mooeypoo>	 ori, is this your new automatic greeting from now on?
[23:18:30] <ori>	 is it ok? no, it is nt
[23:18:33] <RoanKattouw>	 Krinkle: Look at git shortlog -ns with and without
[23:18:39] <ori>	 i'm trying to see how far i can get using only two-character words
[23:18:46] <Krenair>	 mw, oo, sa....
[23:18:52] <mooeypoo>	 ori, you clearly need to use twitter more often
[23:18:52] <RoanKattouw>	 Observe "Roan Kattouw" and "Catrope" appear separately without and are combined with that file
[23:19:06] <Krinkle>	 RoanKattouw: Right.
[23:19:38] <Krinkle>	 RoanKattouw: But it only needs the merge entries right? Not all the "normal" ones.
[23:19:51] <rits>	 mooeypoo:thank you :) 
[23:19:58] <Krinkle>	 jQuery repos use them a lot for generating the "Thanks to X ..." in the release blog posts.
[23:20:03] <Krinkle>	 which lists all names.
[23:20:07] <RoanKattouw>	 Krinkle: The normal ones have magical behavior, kind of
[23:20:09] <Krinkle>	 and for keeping AUTHORS.txt auto-updated.
[23:20:10] <mooeypoo>	 rits, so, in the case of the microtask I posted, it's probably the ce portion, bevcause you want to change the representation of that node in the editable screen. The link I posted to the previous code should give you an idea of what we did in templates. MWAlien nodes are a bit different, but it should be relatively straight forward. I hope.
[23:20:24] <mooeypoo>	 rits, anyways if you run into problems, please don't be afraid to come and ask :)
[23:20:27] <RoanKattouw>	 Roan Kattouw <roan.kattouw@gmail.com> means "everything made by <roan.kattouw@gmail.com> should be attributed as Roan Kattouw, even if the commit says Catrope"
[23:20:44] <RoanKattouw>	 So differences in names are fixed automagically that way
[23:20:54] <RoanKattouw>	 The more complex lines are only needed for people who also use different email addresses
[23:21:00] <rits>	 okay , thank you so much :)
[23:21:07] <mooeypoo>	 no problems :) good luck!
[23:21:08] <Krinkle>	 RoanKattouw: Hm.. right.
[23:21:28] <Krinkle>	 RoanKattouw: I guess I'm just used to only adding the exceptions and assuming the rest is normal. E.g. removing David and me from that list won't change anything.
[23:21:42] <Krinkle>	 the same way contributors added after this will also work fine
[23:21:47] <rits>	 mooeypoo: :)
[23:22:14] <Krinkle>	 Anyhow, no worries. It's fine to keep them I guess.
[23:22:41] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Restore async rendering of ReferenceContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197801 (https://phabricator.wikimedia.org/T91336) 
[23:23:01] <RoanKattouw>	 Krinkle: Actually yes it will, because Gerrit has generated some Krinkle commits for you
[23:23:07] <RoanKattouw>	 Whereas your normal commits are Timo Tijhof
[23:23:21] <RoanKattouw>	 The email address is the same, but that doesn't stop git shortlog from splitting it unless I put your name in that file
[23:25:55] <grrrit-wm>	 (03CR) 10Krinkle: "fixme: Invalid doc syntax. See https://doc.wikimedia.org/unicodejs/master/#!/api/unicodeJS.wordbreak." (031 comment) [unicodejs] - 10https://gerrit.wikimedia.org/r/197739 (owner: 10Divec)
[23:26:37] <Krinkle>	 RoanKattouw: Hm.. that should only be for committer, not author.
[23:27:03] <RoanKattouw>	 Except for reverts
[23:27:09] <Krinkle>	 But you're right, I do see 2 commits in oojs-ui history
[23:27:10] <Krinkle>	 yeah
[23:27:12] <RoanKattouw>	 Or historical git configs
[23:27:32] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Move click blocking from links to content branches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197799 (https://phabricator.wikimedia.org/T91336) 
[23:28:07] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Release more things in destroy methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197797 
[23:28:25] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Restore async rendering of ReferenceContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197801 (https://phabricator.wikimedia.org/T91336) 
[23:30:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Release more things in destroy methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197797 (owner: 10Trevor Parscal)
[23:31:25] <Krinkle>	 James_F|Away: unicodejs on npm has had 1000+ downloads this month. I;m curious where those come from. We're not using it from npm anywhere, right? And there are no known npm packages that depend on it.
[23:31:48] <RoanKattouw>	 Krinkle: Are you sure Jenkins jobs don't somehow download it?
[23:31:48] <Krinkle>	 the only thing installing it from npm is the update shell script for pull throughs
[23:31:59] <Krinkle>	 RoanKattouw: Nope, that runs npm install for the local directory.
[23:32:10] <Krinkle>	 and we did not have a 1000+ builds this month :P
[23:33:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Release more things in destroy methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197797 (owner: 10Trevor Parscal)
[23:33:33] <Krinkle>	 oojs by comparison only has 700 downloads this month
[23:36:46] <grrrit-wm>	 (03CR) 10GWicke: "With the wmf21 deploy the domLoad metrics seem to have stopped: http://grafana.wikimedia.org/#/dashboard/db/visualeditor-load-save" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196584 (https://phabricator.wikimedia.org/T90372) (owner: 10Catrope)
[23:37:54] <James_F>	 Krinkle: Maybe it's stupidly-popular?
[23:38:00] <Krinkle>	 :D
[23:38:19] <James_F>	 (And yet no-one's talked to us?)
[23:39:09] <TrevorParscal>	 that does seem rather high
[23:39:35] <wikibugs>	 10OOjs: Require classes being mixed in to be plain objects - https://phabricator.wikimedia.org/T92540#1130716 (10Krinkle) p:5Triage>3Low a:5Krinkle>3None
[23:43:52] <nuria>	 Krinkle, james, RoanKattouw , ori : did you see the presentation the google guys made about visual editor profiling with chrome: https://speakerdeck.com/addyosmani/devtools-state-of-the-union-2015
[23:44:15] <RoanKattouw>	 Yeah Krinkle shared it this morning :)
[23:44:19] <Krinkle>	 nuria: Yup. It's nice to be thought about.
[23:44:34] <Krinkle>	 You're the third person to tell us. That's so nice.
[23:45:25] <Krinkle>	 RoanKattouw: It also made the cut for todays webplatformdaily, which has a ton of subscribers.
[23:45:33] <Krinkle>	 http://webplatformdaily.org/
[23:46:55] <gwicke>	 James_F: frwiki next?
[23:47:35] <James_F>	 gwicke: Maybe let's finish the other twelve deployments.
[23:47:38] <James_F>	 :-)
[23:47:39] <James_F>	 But yes.
[23:48:06] <gwicke>	 all looking great so far; the ref issue on ptwiki looks like it was a general VE / Parsoid issue
[23:48:44] <Krenair>	 Krinkle, from https://phabricator.wikimedia.org/T93119 it sounds like you have some ideas for fixing it? are you planning to do so?
[23:49:13] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ProcessDialog: send an array to showErrors in failed executeAction [oojs/ui] - 10https://gerrit.wikimedia.org/r/197713 (owner: 10Mooeypoo)
[23:49:15] <Krinkle>	 Krenair: It's not blocking anything, just very confusing/annoying.
[23:49:26] <Krinkle>	 I found the problem but not sure what the solution is
[23:49:32] <Krinkle>	 If you have an idea, go for it :)
[23:50:15] <gwicke>	 James_F: https://it.wikipedia.org/w/index.php?title=FIFA_15&curid=5030248&diff=71481515&oldid=71332845
[23:50:22] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński)
[23:50:28] <James_F>	 gwicke: Damn.
[23:50:35] <James_F>	 gwicke: Cross-over issues?
[23:50:35] <Krinkle>	 Krenair: On load, the code selects and element, takes its value and submits it as property value of editingSessionId. So the property isn't really missing (but in EL I guess), but set to an empty string
[23:50:41] <gwicke>	 I don't think so
[23:51:04] <Krinkle>	 TrevorParscal: Eh.. I'm confused.
[23:51:25] * James_F sighs.
[23:51:42] <Krinkle>	 This will add an API that we'll have to deprecate within the month and change everything again?
[23:51:44] <RoanKattouw>	 Whooops
[23:51:57] <gwicke>	 James_F: it is caused by Parsoid not finding a ref by id
[23:51:57] <Krinkle>	 I thought we finally came to an agreement with Cscott and you :)
[23:52:01] <James_F>	 Krinkle: Within the month?
[23:52:02] <TrevorParscal>	 Krinkle: we are going 2.0 within a month?
[23:52:13] <James_F>	 Krinkle: We're not doing 2.0 this *year*.
[23:52:31] <Krinkle>	 TrevorParscal: No, but it can be fixed within a day. Afaik it's trivial to implement what we proposed, like 5 lines of code.
[23:52:34] <James_F>	 gwicke: I reverted; on re-edit, it works fine.
[23:52:39] <Krinkle>	 It will happen within a month, anyone can do it.
[23:52:41] <James_F>	 Krinkle: Trivial and not done is not done.
[23:52:46] <RoanKattouw>	 If it's 5 lines of code then why has no one freaking done it yet
[23:52:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: ProcessDialog: send an array to showErrors in failed executeAction [oojs/ui] - 10https://gerrit.wikimedia.org/r/197713 (owner: 10Mooeypoo)
[23:52:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński)
[23:52:51] <TrevorParscal>	 Krinkle: you mean making static point back to the constructor object?
[23:52:55] <Krinkle>	 Bartosz implemented something before we had the discussion
[23:52:55] <James_F>	 Because people like to bitch instead.
[23:53:01] <Krinkle>	 he just hasn't gotten around to implementing it
[23:53:04] <TrevorParscal>	 lol
[23:53:12] <Krinkle>	 he himself recommended against merging it
[23:53:13] <gwicke>	 James_F: we were wondering if there is some issue with ref editing in VE
[23:53:17] <Krinkle>	 the patch might as well be abanadoned
[23:53:43] <TrevorParscal>	 Krinkle: ok, tell you what, let's talk this over one last time tomorrow with MatmaRex
[23:53:48] <Krinkle>	 If you need it now, implement it. Bartosz and I were both assigned different work.
[23:53:52] <James_F>	 gwicke: But you think it's fine?
[23:54:04] <TrevorParscal>	 I'm happy to implement it
[23:54:05] <RoanKattouw>	 gwicke: What's that about Parsoid not finding an ID?
[23:54:13] <TrevorParscal>	 I'll settle it tomorrow
[23:54:27] <gwicke>	 RoanKattouw: it sometimes doesn't find a reference 
[23:54:43] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-2] "To be redone" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński)
[23:54:46] <RoanKattouw>	 Could that possibly be related to the ID stripping change?
[23:55:00] <RoanKattouw>	 MatmaRex: https://gerrit.wikimedia.org/r/197475
[23:55:02] <gwicke>	 RoanKattouw: no, it's a cite id, which isn't of the mwXX form
[23:55:14] <RoanKattouw>	 I thought it was mw-blahblah
[23:55:18] <MatmaRex>	 sorry for disappearing earlier
[23:55:20] <RoanKattouw>	 Or is it cite-blahblah
[23:55:23] <gwicke>	 no, it's cite-*
[23:55:26] <MatmaRex>	 is the sky falling down?
[23:55:29] <Krinkle>	 TrevorParscal: I'd be happy to drop all my arguments and go with a different implementation, as long as we don't add a .class property since that only incurs more migration work when we fixed it properly in the future.
[23:55:34] <RoanKattouw>	 MatmaRex: No, don't worry
[23:55:38] <MatmaRex>	 :D
[23:55:53] <RoanKattouw>	 MatmaRex: It's just that I saw you -2ing that change and so I was like "oh hey MatmaRex is on line, then he can review this change"
[23:55:56] <Krenair>	 Krinkle, so... If we get nothing back, set mw.user.generateRandomSessionId() instead?
[23:55:58] <mooeypoo>	 MatmaRex, only in Australia
[23:56:25] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/197097/
[23:56:37] <RoanKattouw>	 TrevorParscal: and https://gerrit.wikimedia.org/r/196211
[23:57:12] <Krinkle>	 Krenair: Well, not really. The code shouldn't run at all. It's thinking the test run page is action=edit because it loads a module that is meant for actin=edit and doesn't account for being loaded in a different context.
[23:57:14] <Krinkle>	 Either the module needs to be guarded with wgAction, or it needs to not be loaded in the first place.
[23:57:30] <subbu>	 gwicke, RoanKattouw quick comment before i run out .. note that we do not strip mwXX ids from the DOM before serialization .. we just don't emit it in wikitext.
[23:57:34] <Krenair>	 Krinkle, wgAction check will work
[23:57:35] <Krenair>	 ok
[23:57:36] <Krinkle>	 The test is already fixed by thedj to not call it, but it's still called from dom ready for some reason
[23:57:38] <RoanKattouw>	 subbu: OK
[23:57:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 031] "Looks reasonable." [oojs/ui] - 10https://gerrit.wikimedia.org/r/197475 (https://phabricator.wikimedia.org/T92588) (owner: 10Mattflaschen)
[23:57:45] <Krinkle>	 Krenair: cool :)
[23:57:51] <MatmaRex>	 RoanKattouw: want me to test and merge that?
[23:58:02] <RoanKattouw>	 MatmaRex: Matt's change? Yes
[23:58:17] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "We should be removing all font-family specification, not making it more specific and disjoint from production software." [oojs/ui] - 10https://gerrit.wikimedia.org/r/197097 (https://phabricator.wikimedia.org/T92858) (owner: 10Nirzar)
[23:58:39] <gwicke>	 subbu, RoanKattouw: did anything about ref handling change in wmf21 VE?
[23:58:54] <gwicke>	 related to how the id references are updated?
[23:58:56] <Krenair>	 Krinkle, hmm... might need to deal with action=submit or other cases
[23:59:38] <RoanKattouw>	 gwicke: Not that I know of
[23:59:46] <subbu>	 gwicke, RoanKattouw this is not a common error .. it shows up once in a while in the logs.