[00:00:09] (03PS1) 10Alex Monk: Only do client-side instrumentation on action=edit/action=submit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197810 (https://phabricator.wikimedia.org/T93119) [00:00:13] subbu: ok, did it happen before the RB roll-out? [00:00:17] so, it is probably some edge case ... [00:00:22] let me look. one sec. [00:00:36] RoanKattouw: wikimania pres is a lot easier with [00:00:46] Krinkle, can you test that? ^ [00:00:56] we just need to photoshop addy osmani's name out of the slides [00:01:00] hahaha [00:01:07] (03CR) 10Trevor Parscal: [C: 04-1] "Can we add these the first time they are used? Otherwise, I worry this will be cruft." [oojs/ui] - 10https://gerrit.wikimedia.org/r/196211 (https://phabricator.wikimedia.org/T92026) (owner: 10Prtksxna) [00:02:03] gwicke, RoanKattouw go to https://logstash.wikimedia.org/#/dashboard/elasticsearch/parsoid and search for "non-existent element" and look at a 7d timeline for ex. [00:02:14] i have to go home now .. :) later. [00:02:39] i'll log in again after a while if there is anything needed from me .. but, i need a break :) [00:02:50] subbu: looks like it's not brand new [00:02:54] no. [00:02:58] good. [00:03:50] subbu: thanks btw, enjoy your evening! [00:03:56] so, the qn. is why the cite-id is not being found in the dom. [00:04:09] *nod* [00:04:28] Yeah I don't get that either [00:04:29] (03CR) 10Jforrester: [C: 032] LookupElement: Add optional config field for suggestions when empty [oojs/ui] - 10https://gerrit.wikimedia.org/r/197475 (https://phabricator.wikimedia.org/T92588) (owner: 10Mattflaschen) [00:04:42] I checked real quick and the HTML that I get from RESTbase for that page does contain those IDs [00:04:45] RoanKattouw, in any case .. https://gerrit.wikimedia.org/r/#/c/197803/ will ensure that such pages will no longer get serialized. [00:04:56] RoanKattouw, this is independent of restbase as far as i can tell. [00:05:06] Oh thank God [00:05:20] Ooooh wait hold on [00:05:30] subbu: Where EXACTLY are these IDs resolved? [00:05:36] In the document that we send back, or in the original HTML? [00:05:42] in the doc that is sent back [00:05:45] OK [00:05:54] So if the user were to, say, delete the references list... [00:06:02] RoanKattouw: are you keeping referenced ids in sync? [00:06:12] yes .. if references list is deleted .. that is trouble. [00:06:13] gwicke: "keeping in sync"? [00:06:21] they have a number in them [00:06:25] Or if the reflist is template-generated and the user modifies the params [00:06:29] No we don't touch those IDs [00:06:32] so if a ref is inserted or remove, all the ids change [00:07:00] gwicke, cite-ids for the purpose of serializatoin don't need to synced up .. i don't think. [00:07:01] (03CR) 10Bartosz Dziewoński: [C: 032] LookupElement: Add optional config field for suggestions when empty [oojs/ui] - 10https://gerrit.wikimedia.org/r/197475 (https://phabricator.wikimedia.org/T92588) (owner: 10Mattflaschen) [00:07:13] as long as the cite id points to a valid dom subtree, that should be fine. [00:07:30] $ echo ${BUILD_TAG//-/_} [00:07:33] but, if we want to store the html that you get back from ve .. then yes, the id properties need to be preserved. [00:07:34] That's is so awesomely horrible [00:07:39] they don't need to be renumbered; I was just worried about incomplete updates [00:07:58] where the ids in references change, but the data-mw referencing it doesn't [00:07:59] ok .. i should go .. :) .. i have said that 4 or 5 times over the last 30 mins .. [00:08:01] or something like that [00:08:02] this time i mean it :) [00:08:06] bye [00:08:10] go go go! [00:08:11] ;) [00:08:25] (03Merged) 10jenkins-bot: LookupElement: Add optional config field for suggestions when empty [oojs/ui] - 10https://gerrit.wikimedia.org/r/197475 (https://phabricator.wikimedia.org/T92588) (owner: 10Mattflaschen) [00:10:55] TrevorP|Away: James_F: can we merge https://gerrit.wikimedia.org/r/#/c/197135/ and log a tech debt bug for MenuLayout requiring inline CSS to work? [00:11:36] MatmaRex: I was hoping edsanders|away would comment – I pinged him on Monday. [00:11:40] But he didn't. [00:11:44] * James_F grumbles. [00:11:44] (03CR) 10Bartosz Dziewoński: [C: 031] "I say we merge this and log a tech debt bug for MenuLayout requiring inline CSS to work. I can fix that, but not right now, and this would" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197135 (https://phabricator.wikimedia.org/T91600) (owner: 10Bartosz Dziewoński) [00:12:09] (it would be a [BREAKING CHANGE], too.) [00:12:40] 10VisualEditor, 10Performance-Metrics-Dashboard, 7Performance: domLoad metric apparently broken in wmf21 - https://phabricator.wikimedia.org/T93156#1130772 (10GWicke) [00:13:02] James_F: are there any things you pinged *me* about, and i didn't answer? i was somewhat overwhelmed last few days [00:13:31] 10VisualEditor, 10Performance-Metrics-Dashboard, 7Performance: domLoad metric apparently broken in wmf21 - https://phabricator.wikimedia.org/T93156#1130777 (10GWicke) [00:15:26] MatmaRex: No no, you focus on other stuff. :-) [00:15:40] MatmaRex: OOjs UI is slower without you, but… :-D [00:19:59] 10VisualEditor, 10Performance-Metrics-Dashboard, 7Performance: domLoad metric apparently broken in wmf21 - https://phabricator.wikimedia.org/T93156#1130788 (10ori) a:3ori [00:20:19] (03CR) 10Alex Monk: Use widgets for wiki-page-name and wiki-user-name parameters (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk) [00:21:55] (03CR) 10Alex Monk: [C: 04-1] "This needs to handle existing bad input and probably other things, but could end up with a complex UI :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://bugzilla.wikimedia.org/53613) (owner: 10Alex Monk) [00:22:41] 10VisualEditor, 10VisualEditor-MediaWiki-References: Reference serialization could explode if user deletes reflist - https://phabricator.wikimedia.org/T93159#1130804 (10Catrope) [00:27:27] (03CR) 10Mooeypoo: [C: 031] "Code looks good. Tested in LTR and RTL with both contexts with single characters and works as expected." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) (owner: 10Divec) [00:27:47] (03CR) 10Bartosz Dziewoński: "I saw the commit message. As I understand, you think that is to do after this patch is merged; I think it should be done before. Should be" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders) [00:30:12] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Citoid, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-sel... - https://phabricator.wikimedia.org/T88152#1130825 [00:31:14] (03PS5) 10Divec: [BREAKING CHANGE] Use Unicode character class to calculate word expansions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) [00:32:29] (03CR) 10Catrope: [BREAKING CHANGE] Use Unicode character class to calculate word expansions (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) (owner: 10Divec) [00:32:38] (03CR) 10Catrope: [C: 04-1] "Comments on PS4" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) (owner: 10Divec) [00:37:20] (03PS3) 10Catrope: Move click blocking from links to content branches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197799 (https://phabricator.wikimedia.org/T91336) (owner: 10Trevor Parscal) [00:37:31] (03CR) 10Catrope: [C: 032] Move click blocking from links to content branches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197799 (https://phabricator.wikimedia.org/T91336) (owner: 10Trevor Parscal) [00:38:26] (03PS1) 10Jforrester: Tag v1.1.6 [oojs/core] - 10https://gerrit.wikimedia.org/r/197818 [00:38:52] (03CR) 10Catrope: [C: 032] Tag v1.1.6 [oojs/core] - 10https://gerrit.wikimedia.org/r/197818 (owner: 10Jforrester) [00:39:21] ori: I'm going home, when you do submit your fix, ping me the link on hangouts or SMS [00:39:26] (03PS1) 10Ori.livneh: Set mwtiming events' target to 'mwTarget', if unset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197819 [00:39:32] RoanKattouw: ^ [00:40:29] (03PS2) 10Ori.livneh: Set mwtiming events' target to 'mwTarget', if unset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197819 [00:41:58] gwicke: in the interim you can swap 'mwTarget' with 'undefined' in the graphite metric name to get the most recent data. I didn't break it. [00:42:01] (03Merged) 10jenkins-bot: Move click blocking from links to content branches [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197799 (https://phabricator.wikimedia.org/T91336) (owner: 10Trevor Parscal) [00:42:17] ori: lol [00:42:33] (03Merged) 10jenkins-bot: Tag v1.1.6 [oojs/core] - 10https://gerrit.wikimedia.org/r/197818 (owner: 10Jforrester) [00:42:42] gwicke: lol indeed :( [00:43:47] gwicke: see, this is why i warn about automagically generating metric names [00:43:55] // Map mwtiming.foo --> timing.ve.foo.mobile [00:44:01] topic = topic.replace( /^mwtiming/, 'timing.ve.' + data.targetName ); [00:45:35] there are situations where it's safe [00:46:02] (03PS6) 10Divec: [BREAKING CHANGE] Use Unicode character class to calculate word expansions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) [00:46:17] gwicke, did you test that with mobile? [00:46:51] Krenair: what is 'that'? [00:47:00] sorry [00:47:02] ori, did you test that with mobile? [00:47:31] no [00:48:20] [13oojs.github.io] 15jdforrester created 061.1.5,6 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/194d9bb035fd [00:48:20] 13oojs.github.io/061.1.5,6 14194d9bb 15James D. Forrester: Publish v1.1.5 and v1.1.6 releases from npm [00:48:50] [13oojs.github.io] 15jdforrester opened pull request #8: Publish v1.1.5 and v1.1.6 releases from npm (06master...061.1.5,6) 02https://github.com/oojs/oojs.github.io/pull/8 [00:49:00] modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js:ve.init.mw.MobileViewTarget.static.name = 'mobile'; [00:49:00] modules/ve-mw/init/ve.init.mw.Target.js:ve.init.mw.Target.static.name = 'mwTarget'; [00:49:18] Krenair: do you have a cicle to spare for iterating on that patch? It'd be better to figure out why the targetName is not set now [00:49:23] s/cicle/cycle [00:49:32] I'll take a look [00:49:38] thanks, I'm about to head out [00:49:41] much appreciated [00:52:35] gwicke: of the wikis restbase is currently enabled on, which is the most active, in terms of VE edits? [00:54:06] ori: frwiki. [00:54:17] the French are asleep though [00:54:29] I fixed http://grafana.wikimedia.org/#/dashboard/db/visualeditor-load-save btw [00:54:48] summing the undefined & mwTarget metrics [00:56:04] Nice. Thanks. [00:56:53] gwicke: Looks fine, I think. [00:57:17] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 5Patch-For-Review: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox - https://phabricator.wikimedia.org/T78733#1130869 (10Yurik) i wonder if enabling "zend" role (switch back to PHP engine) would have solved it. [01:00:41] 10VisualEditor: Deleting links created via '[[' sequence has to be done twice to take effect - https://phabricator.wikimedia.org/T93163#1130875 (10Krenair) 3NEW [01:12:47] (03CR) 10Catrope: [C: 032] "It's missing because TargetLoader does ve.track('mwtiming.performance.system.domLoad', {...}) and I forgot to add targetName there." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197819 (owner: 10Ori.livneh) [01:13:33] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Use Unicode character class to calculate word expansions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) (owner: 10Divec) [01:15:04] (03Merged) 10jenkins-bot: Set mwtiming events' target to 'mwTarget', if unset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197819 (owner: 10Ori.livneh) [01:16:32] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Use Unicode character class to calculate word expansions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197661 (https://phabricator.wikimedia.org/T78202) (owner: 10Divec) [01:17:46] (03PS1) 10Jforrester: Set mwtiming events' target to 'mwTarget', if unset [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197828 [01:17:52] (03PS1) 10Jforrester: Set mwtiming events' target to 'mwTarget', if unset [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197829 [01:18:13] 10VisualEditor, 10Performance-Metrics-Dashboard, 10WMF-deploy-2015-03-25_(1.25wmf23), 7Performance, and 2 others: domLoad metric apparently broken in wmf21 - https://phabricator.wikimedia.org/T93156#1130923 (10Jdforrester-WMF) p:5Triage>3High [01:24:32] 10VisualEditor, 10Utilities-UnicodeJS, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Wordbreak detection is faulty for selection starting just down-page of a single character - https://phabricator.wikimedia.org/T78202#1130926 (10Jdforrester-WMF) 5Open>3Resolved [01:26:06] (03CR) 10Catrope: "So while this works as a temporary hack, talking this through with Alex made me realize that domLoad timings from mobile VE will also flow" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197819 (owner: 10Ori.livneh) [01:27:06] Oh dear. [01:27:32] Krenair: Did you change the edit conflict code? Now when I get one I'm told "Edit conflict detected" and there's no "let me fix it" button. [01:27:37] (03CR) 10Alex Monk: Set mwtiming events' target to 'mwTarget', if unset (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197819 (owner: 10Ori.livneh) [01:28:52] 10VisualEditor, 10Performance-Metrics-Dashboard, 7Performance, 5WMF-deploy-2015-03-11_(1.25wmf21), and 2 others: domLoad metric apparently broken in wmf21 - https://phabricator.wikimedia.org/T93156#1130929 (10Krenair) This has not been properly fixed by https://gerrit.wikimedia.org/r/197819 (which was not... [01:29:28] (03CR) 10Alex Monk: [C: 04-1] "See task" [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197828 (owner: 10Jforrester) [01:29:37] (03CR) 10Alex Monk: [C: 04-1] "See task" [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197829 (owner: 10Jforrester) [01:29:57] James_F, umm [01:30:04] I don't think so? [01:30:15] Krenair: Darn. Not a great regression. :-( [01:30:31] wmf22 only? [01:30:38] Haven't tried in wmf21 yet. [01:30:54] But I had an edit conflict in wmf21 a couple of days ago and it worked as expected. [01:30:55] So… [01:31:33] confirmed on master [01:38:02] Krenair: Eurgh. Will you be around for SWAT tomorrow morning? I won't and I'd really like a (no-op) config patch to go out… [01:38:12] I think so [01:38:24] OK if I put you down as the contact? [01:38:28] ok [01:41:07] James_F, so we attempt to handle edit conflicts in onSave [01:41:14] James_F, rather than onSaveError [01:41:15] Yeah. [01:41:18] Oooh. [01:41:20] Which is where they actually go [01:41:23] Ha [01:41:28] Why do we... how did this even... [01:44:54] James_F, okay, so I got the 'Resolve Conflict' button showing... below the error message? [01:45:02] and the conflict screen in general [01:45:08] but the overlay still comes up [01:45:49] hm. [01:45:50] (03PS1) 10Jforrester: Update OOjs to v1.1.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197833 [01:46:18] (03PS1) 10Jforrester: Update OOjs to v1.1.6 [oojs/ui] - 10https://gerrit.wikimedia.org/r/197834 [01:46:27] Hmm. [01:48:26] https://gerrit.wikimedia.org/r/#/q/I7c1299c8049983746158a05e47a13f1f4bf7032f,n,z could do with +2s if someone's bored. :-) [01:49:03] It goes through onSaveErrorUnknown anyway? ... [01:49:41] right, I wasn't returning where I should have [01:49:49] (03PS1) 10Jforrester: Update VE core submodule to master (91858b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197836 [01:49:51] (in some of the existing cases as well probably :/) [01:50:27] but possibly it didn't matter in the other case because the correct error could've rejected the promise first [01:50:34] (03CR) 10Jforrester: [C: 032] Restore async rendering of ReferenceContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197801 (https://phabricator.wikimedia.org/T91336) (owner: 10Trevor Parscal) [01:50:52] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Context menu does not update the change immediately unless you re-open it - https://phabricator.wikimedia.org/T91336#1130946 (10Jdforrester-WMF) 5Open... [01:51:12] got it [01:52:23] (03PS4) 10Jforrester: Factor out ve.compareClassLists functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 (owner: 10Esanders) [01:52:38] (03Merged) 10jenkins-bot: Restore async rendering of ReferenceContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197801 (https://phabricator.wikimedia.org/T91336) (owner: 10Trevor Parscal) [01:52:54] (03PS1) 10Alex Monk: Fix edit conflicts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197838 [01:53:29] Krenair: Can you tell what branches are affected? master + wmf22? wmf21 too? [01:53:39] I haven't identified the cause yet [01:53:42] * James_F nods. [01:54:23] It may even be my fault from the mw.Api changes [01:54:32] Never! ;-) [01:55:46] Krinkle: Ping again re. https://gerrit.wikimedia.org/r/#/c/196466/ and what you need from me? [01:57:17] James_F: Verification that the enwiki system can indeed be modified (without much work) to 1) move the "create" link to a separate message 2) have it output absolutely nothing in that case (not even an empty
wrapper). I suspect this mostly means moving #if's around in the the wrapper template. [01:57:42] James_F: Since the isEmpty thing is already merged, this should be testable in beta labs already [01:58:20] James_F: it would just not have the create link yet (since that other message is ignored) but that's straight forward to add once that's done. [01:58:21] Krinkle: How would we simulate existing? [01:58:25] Oh, right. [01:58:31] And would still work for VE's needs? [01:58:41] Yeah, VE just needs the message to be empty [01:58:47] That part is already merged [01:59:05] Of course, prod enwiki will not (and should not) move the create link to the other message until this WIP patch is merged since otherwise their link would be gone. [01:59:13] But we can try in beta labs if the emptiness works [01:59:19] Want to try now? [01:59:27] let me rephrase [01:59:45] We know the emptiness check works, it got merged and is done. But we need the templates to be changed, and test if those can be made empty [01:59:54] or whether there is some base output they can't easily prevent [02:00:00] Yeah. [02:00:21] Ideally someone who knows those templates can import the whole gang into enwiki beta labs and play with it [02:00:33] Oy. [02:01:38] Barack Obama looks like it has the items. [02:02:15] Yup, including the config in MW: [02:02:28] Can you tweak? Can others? [02:02:56] http://en.wikipedia.beta.wmflabs.org/wiki/Template:Editnotices/Page/Barack_Obama [02:02:59] The person that made this system is likely not around on enwiki any more (and often it was never fully made by one person, just tweaked a few times). [02:03:00] Yes. [02:03:02] James_F, if it is my mw.Api change, I think that's wmf19+ [02:03:03] http://en.wikipedia.beta.wmflabs.org/wiki/Template:Editnotice_load [02:03:03] Yeah [02:03:04] cool [02:03:08] Krinkle: :-( [02:03:10] Err. [02:03:12] Krenair: :-( [02:03:14] Krinkle: Yeah. [02:06:29] [13oojs.github.io] 15Krinkle 04deleted 061.1.5,6 at 14194d9bb: 02https://github.com/oojs/oojs.github.io/commit/194d9bb [02:06:40] ? [02:07:17] Oh. [02:07:29] It reports deletes but not merges? Cool story. [02:08:22] James_F, should we swat https://gerrit.wikimedia.org/r/#/c/197720/ ? [02:08:39] it was one of the errors milimetric was getting: https://www.irccloud.com/pastebin/9VwBBwls [02:08:48] Oh, oops. [02:08:54] Yes. [02:08:57] wmf21 and 22? [02:09:05] Well it needs to be merged to master first [02:09:07] but yes [02:09:15] * James_F grins. [02:09:24] (03CR) 10Jforrester: [C: 031] Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197720 (owner: 10Alex Monk) [02:10:09] action.ready.timing and action.abort.timing fixed already? [02:10:24] James_F: the merge might come an hour later [02:10:26] :P [02:10:32] the irc bot's been weird lately [02:10:34] Krinkle: Helpful. [02:10:40] events are asynchronous and not arrive in order per se [02:10:47] if one queue is clogged this happens [02:10:57] Krinkle: Did you want me to write the release note for https://gerrit.wikimedia.org/r/196466 ? [02:11:07] James_F: I'm in mysql saga atm, sure :) [02:11:13] Krinkle: OK. [02:11:21] Thx [02:11:22] James_F, I don't know about those [02:11:38] the first two VE ones I thought were already fixed [02:11:55] * James_F nods. [02:11:58] I think they are now. [02:12:05] didn't see the second two in beta [02:19:54] 10MediaWiki-Page-editing, 6Editing, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Implement (part of) the English Wikipedia's edit notice system in MediaWiki core - https://phabricator.wikimedia.org/T91715#1130976 (10Jdforrester-WMF) Provisionally "done" but needs implementation on-wiki once `wmf23... [02:19:58] (03CR) 10Catrope: [C: 032] Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197720 (owner: 10Alex Monk) [02:20:58] (03PS1) 10Jforrester: Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197842 [02:21:06] (03PS1) 10Jforrester: Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197843 [02:25:38] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (91858b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197836 (owner: 10Jforrester) [02:26:30] (03Merged) 10jenkins-bot: Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197720 (owner: 10Alex Monk) [02:26:33] (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.6 [oojs/ui] - 10https://gerrit.wikimedia.org/r/197834 (owner: 10Jforrester) [02:26:42] (03CR) 10Catrope: [C: 032] Update OOjs to v1.1.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197833 (owner: 10Jforrester) [02:27:07] (03CR) 10Catrope: [C: 032] Factor out ve.compareClassLists functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 (owner: 10Esanders) [02:27:10] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Trim selections with whitespace on the end when creating a link - https://phabricator.wikimedia.org/T92896#1130980 (10Jdforrester-WMF) p:5Triage>3Normal [02:27:28] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Move oldid/timestamp inference from API module to client-side JS - https://phabricator.wikimedia.org/T92993#1130983 (10Jdforrester-WMF) a:3Krenair [02:27:40] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1130984 (10Jdforrester-WMF) p:5Triage>3High [02:27:46] (03Merged) 10jenkins-bot: Update VE core submodule to master (91858b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197836 (owner: 10Jforrester) [02:27:47] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1127514 (10Jdforrester-WMF) [02:28:06] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: s inserted in VE edit - https://phabricator.wikimedia.org/T93125#1130987 (10Jdforrester-WMF) [02:28:07] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: VisualEditor: Unnecessary s inserted into articles - https://phabricator.wikimedia.org/T71494#1130988 (10Jdforrester-WMF) [02:28:21] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Unnecessary s inserted into articles - https://phabricator.wikimedia.org/T71494#1130990 (10Jdforrester-WMF) 5stalled>3Open p:5Triage>3High [02:28:31] 10VisualEditor: s inserted in VE edit - https://phabricator.wikimedia.org/T93125#1129989 (10Jdforrester-WMF) [02:28:49] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: & converted to & in reference name - https://phabricator.wikimedia.org/T93128#1130996 (10Jdforrester-WMF) p:5Triage>3High [02:29:08] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Can't copy a single node selection (e.g. template / media / reference) in Safari - https://phabricator.wikimedia.org/T72143#1130998 (10Jdforrester-WMF) [02:29:45] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1131002 (10Whatamidoing-WMF) I have not tried to reproduce it. However, I point out the remarkable similarity between the new content and the English Wikipedia artic... [02:29:51] (03Merged) 10jenkins-bot: Update OOjs to v1.1.6 [oojs/ui] - 10https://gerrit.wikimedia.org/r/197834 (owner: 10Jforrester) [02:29:52] (03Merged) 10jenkins-bot: Update OOjs to v1.1.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197833 (owner: 10Jforrester) [02:29:59] (03Merged) 10jenkins-bot: Factor out ve.compareClassLists functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197516 (owner: 10Esanders) [02:36:22] (03PS2) 10Alex Monk: Fix edit conflicts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197838 [02:37:26] (03CR) 10Catrope: [C: 032] Fix edit conflicts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197838 (owner: 10Alex Monk) [02:39:30] (03Merged) 10jenkins-bot: Fix edit conflicts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197838 (owner: 10Alex Monk) [03:12:13] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Handle page content data being for a different revision compared to the API-added data - https://phabricator.wikimedia.org/T92993#1131016 (10Krenair) [03:16:24] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Handle page content data being for a different revision compared to the API-added data - https://phabricator.wikimedia.org/T92993#1131018 (10Krenair) Me and Roan talked and agreed that we should take the revision IDs from both pieces of data and retry the olde... [03:29:20] 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1131020 (10Krenair) Before we merge this we should have RESTbase in beta to test against, and preferably group1 wikis (which... [04:02:33] (03CR) 10Jforrester: "Cherry-pick?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197838 (owner: 10Alex Monk) [04:03:33] (03CR) 10Alex Monk: "Your choice... I think this has probably been an issue since wmf19 though." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197838 (owner: 10Alex Monk) [04:32:58] How come OOjs UI is in core through composer.json and directly? [05:17:10] (03PS1) 10Legoktm: jenkins job validation, do not submit [oojs/ui] - 10https://gerrit.wikimedia.org/r/197857 [05:18:00] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [oojs/ui] - 10https://gerrit.wikimedia.org/r/197857 (owner: 10Legoktm) [09:22:30] (03CR) 10Esanders: "You approach wouldn't work. Setting body direction does not always move the window scrollbars. I downloaded Firefox-he and the main scroll" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders) [09:24:34] (03CR) 10Esanders: "My case for merging is that this is an improvement in both directions. If we can't find an RTL solution then we can later remove the hack " [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders) [09:43:54] * werdna waves edsanders|away [11:00:49] (03PS1) 10Mvolz: Update citoid submodule to master (fd026c6) [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/197881 [11:03:38] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Newline between templates removed by VE - https://phabricator.wikimedia.org/T93129#1131518 (10Aklapper) [11:06:47] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space to the "special character" dialog - https://phabricator.wikimedia.org/T70429#1131520 (10Aklapper) [11:06:48] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: Allow inserting non-breakable space ( ) - https://phabricator.wikimedia.org/T86636#1131519 (10Aklapper) [11:09:19] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Ctrl-Space to insert a non-breaking space (NBSP), and a way to see the difference - https://phabricator.wikimedia.org/T53045#1131531 (10Aklapper) [11:09:31] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429#1131532 (10Aklapper) [11:13:19] 10VisualEditor, 10VisualEditor-MediaWiki-References: Space added in named reference (between parameter and closing /> bracket) - https://phabricator.wikimedia.org/T93130#1131538 (10Aklapper) [11:19:09] hi [11:22:03] (03CR) 10Esanders: "The problem is that a surface widget isn't a surface widget. It's got a surface, a toolbar, a separate toolbar config, a debug bar and it'" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197135 (https://phabricator.wikimedia.org/T91600) (owner: 10Bartosz Dziewoński) [11:35:28] (03CR) 10Esanders: ve.ui.SurfaceWidget: Insert toolbar dialog manager into toolbar (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197135 (https://phabricator.wikimedia.org/T91600) (owner: 10Bartosz Dziewoński) [12:11:01] (03PS1) 10Amire80: [BrowserTest] Revert the definition of the disabled_save_button element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197886 [12:14:39] (03PS2) 10Amire80: [BrowserTest] Revert the definition of the disabled_save_button element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197886 [12:16:00] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Revert the definition of the disabled_save_button element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197886 (owner: 10Amire80) [12:18:00] (03Merged) 10jenkins-bot: [BrowserTest] Revert the definition of the disabled_save_button element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197886 (owner: 10Amire80) [12:24:10] 10WikiEditor, 5Patch-For-Review, 7Regression: WikiEditor test throws "[Edit] Missing property editingSessionId" - https://phabricator.wikimedia.org/T93119#1131647 (10Aklapper) p:5Triage>3Normal [12:28:08] (03PS1) 10Amire80: [BrowserTest] Disabling the References list test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197890 [12:28:59] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Disabling the References list test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197890 (owner: 10Amire80) [12:31:12] (03Merged) 10jenkins-bot: [BrowserTest] Disabling the References list test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197890 (owner: 10Amire80) [12:45:04] (03CR) 10Esanders: "FIXME: this is broken - less is logically invalid" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196213 (https://phabricator.wikimedia.org/T73150) (owner: 10Prtksxna) [12:50:49] how did nobody notice the focus styles were completely broken? [12:55:24] (03CR) 10Esanders: MediaWiki Theme: textInputWidget: Update focus state (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/196213 (https://phabricator.wikimedia.org/T73150) (owner: 10Prtksxna) [12:55:32] (03PS1) 10Amire80: [BrowserTest] Remove when_not_visible check from 'I click Save page' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197894 [12:56:54] (03PS1) 10Esanders: Follow up I2087030a8. Fix mangled code. [oojs/ui] - 10https://gerrit.wikimedia.org/r/197895 (https://phabricator.wikimedia.org/T73150) [12:57:05] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Remove when_not_visible check from 'I click Save page' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197894 (owner: 10Amire80) [12:59:08] (03Merged) 10jenkins-bot: [BrowserTest] Remove when_not_visible check from 'I click Save page' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197894 (owner: 10Amire80) [13:08:27] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: HTML non-breaking spaces ( ) converted to ",[object Object], ,[object Object]," - https://phabricator.wikimedia.org/T60282#1131701 (10Aklapper) 5Open>3stalled No steps to reproduce; no-one managed to reproduce; no new known occurrences for nearly... [13:16:45] 10VisualEditor, 7Browser-test-bug: in language screenshots there must be a way to add more padding around the element that is being cropped - https://phabricator.wikimedia.org/T87786#1131712 (10Amire80) a:5Vikassy>3Amire80 [13:18:01] 10VisualEditor, 7Browser-test-bug: in language screenshots there must be a way to add more padding around the element that is being cropped - https://phabricator.wikimedia.org/T87786#998863 (10Amire80) @zeljkofilipin eventually did it differently - by removing all iframe support and adding simple padding on al... [13:21:48] (03PS1) 10Amire80: [BrowserTest] Update the screenshot gem version [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197898 (https://phabricator.wikimedia.org/T87786) [13:22:52] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Update the screenshot gem version [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197898 (https://phabricator.wikimedia.org/T87786) (owner: 10Amire80) [13:24:22] 10VisualEditor, 7Browser-test-bug, 5Patch-For-Review: in language screenshots there must be a way to add more padding around the element that is being cropped - https://phabricator.wikimedia.org/T87786#1131730 (10Amire80) 5Open>3Resolved Resolved with help from @zeljkofilipin and @Vikassy. I'll add the a... [13:24:53] (03Merged) 10jenkins-bot: [BrowserTest] Update the screenshot gem version [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197898 (https://phabricator.wikimedia.org/T87786) (owner: 10Amire80) [13:27:42] (03PS1) 10Esanders: Fix code style in @examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/197900 [13:34:54] 10VisualEditor, 10VisualEditor-ContentLanguage, 7I18n: VisualEditor: Typing problem in Assamese - https://phabricator.wikimedia.org/T54726#1131756 (10Aklapper) Is what is left to do in this ticket "just" a duplicate of {T51569}? Or is there more to do (if so, what?) [14:00:11] 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1131819 (10mobrovac) [14:01:26] 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1057157 (10mobrovac) >>! In T90374#1131020, @Krenair wrote: > Before we merge this we should have RESTbase in beta to test a... [14:11:39] 10VisualEditor, 6Analytics-Kanban: VE events need to be sampled - https://phabricator.wikimedia.org/T93201#1131831 (10Nuria) 3NEW a:3Milimetric [14:17:02] 10VisualEditor, 10Analytics-EventLogging, 6Analytics-Kanban: VE events need to be sampled - https://phabricator.wikimedia.org/T93201#1131850 (10Nuria) [14:27:04] 10VisualEditor, 10Analytics-EventLogging, 6Analytics-Kanban: VE events need to be sampled - https://phabricator.wikimedia.org/T93201#1131880 (10kevinator) p:5Triage>3High [14:28:23] 10VisualEditor, 10Analytics-EventLogging, 6Analytics-Kanban: VE events need to be sampled {lion} - https://phabricator.wikimedia.org/T93201#1131881 (10kevinator) [14:41:44] good morning [14:41:50] (03CR) 10Alex Monk: [C: 032] Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197843 (owner: 10Jforrester) [14:41:53] (03CR) 10Alex Monk: [C: 032] Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197842 (owner: 10Jforrester) [14:41:57] (03Merged) 10jenkins-bot: Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197843 (owner: 10Jforrester) [14:42:00] (03Merged) 10jenkins-bot: Fix WebRequest::getVal calls for instrumentation [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197842 (owner: 10Jforrester) [14:58:38] (03PS1) 10Esanders: Fix context height and padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197906 [15:11:49] 10VisualEditor: Setting a image to reflow after inserting prevents saving, offset out of bounds - https://phabricator.wikimedia.org/T93204#1132023 (10Hmrc87) 3NEW [15:17:13] 10VisualEditor: Setting a image to reflow after inserting prevents saving, offset out of bounds - https://phabricator.wikimedia.org/T93204#1132047 (10Hmrc87) [15:27:52] (03PS1) 10Esanders: Re-factor process dialog action button framing [oojs/ui] - 10https://gerrit.wikimedia.org/r/197914 [15:44:16] 10OOjs-UI, 10VisualEditor, 7Design: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1132148 (10Esanders) It saddens me that T85998 is still broken months after we launched this skin. Instead of fixing the issues identified we end up coming with larger re... [15:49:46] (03PS1) 10Esanders: Reduce thickness of toolbar border in MediaWiki [oojs/ui] - 10https://gerrit.wikimedia.org/r/197926 (https://phabricator.wikimedia.org/T85974) [16:01:19] Heya. [16:04:15] milimetric, I don't know what needs to be done (if anything) on our side for https://phabricator.wikimedia.org/T93201 [16:04:20] nuria, ^ [16:05:24] Krenair: you need to sample before sending events, so we are sending say , only 1 out 4 sessions [16:05:41] Krenair: let me get you some sampling code from wikigrok for example [16:05:56] Krenair: they do teh same, they sample per session [16:06:05] ok [16:16:22] Krenair: this is "orientational" but please take a look: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/Schema.js#L52 [16:21:36] Krenair: we can talk as much as you need, this sampling is necessary because the current event logging pipeline doesn't scale very well. We're looking into changing it to more scalable systems, but for now most everyone samples if possible [16:21:59] and the new stream of events after your instrumentation hit all the wikis is quite large. It went up from 15/second to 90/second [16:22:51] 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, 6Wikisource: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#1132294 (10Aubrey) What can we do, as community members, to raise the priority of this? It is **really** important for W... [16:25:04] milimetric, Krenair : actually 200 events per sec [16:25:33] milimetric, Krenair : which is about as much as all events for the rest of WMF together (not quite, but on that ballpark) [16:25:49] :/ [16:28:40] nuria, milimetric so only logging if the first session ID character is lower than V... gives 50% of requests? [16:29:18] Krenair: no, that was orientational [16:29:45] Krenair: you have a client side token that you can bucket, we should log now 1/10 [16:30:15] Krenair: mobile logic is similar but not identical [16:30:37] // sampling bucket (currently 50% of all users). [16:30:49] if ( !this.isSampled || user.getSessionId().charAt( 0 ) < 'V' ) { [16:30:49] return mw.eventLog.logEvent( this.name, $.extend( this.defaults, data ) ); [16:30:52] what am I missing here? [16:35:50] Krenair: what nuria meant by pasting that code was to give you an idea of _what_ to do, not _how_ to do it [16:35:58] the pseudo code is like this: [16:36:02] right [16:36:27] the question was whether that code guarantees 50% [16:36:35] put your eventSessionId in N buckets [16:36:54] if it falls in the first bucket, send events for that session [16:36:57] otherwise, don't send [16:37:07] I'll need to know how to write something similar for VE [16:37:11] that code is weird, I never checked it, I don't think it guarantees 50% [16:37:33] something that might work would be like hash(editingSessionId) % N [16:37:50] but you'd have to have a very good hash function and test that it spreads things pretty evenly [16:38:14] if you add me to the review, I can test your hash function or your logic [16:38:34] Krenair: just ping me if I miss it, I'm a little swamped [16:39:45] okay, thanks [16:40:36] 10VisualEditor: Setting a image to reflow after inserting prevents saving, offset out of bounds - https://phabricator.wikimedia.org/T93204#1132359 (10Catrope) p:5Normal>3Unbreak! a:3Catrope [16:42:32] Krenair ya, i think milimetric is right, that mobile code it's a little strange but it "capturates" teh idea [16:44:12] 10OOjs-UI, 10OOjs-UI-0.9.0, 10VisualEditor, 10VisualEditor-MediaWiki, and 4 others: "Nested" dialogs (template inside a basic reference) break the OOUI hack to prevent scrolling while dialog is open - https://phabricator.wikimedia.org/T89613#1132360 (10Etonkovidova) [16:44:48] mvolz: Hey. I'm just starting to configure frwiki templates for Citoid. (Whee!) Could I rely on you to sanity-check the changes? [16:49:07] Krenair: I am happy to CR too, so you can see the volume of issues that are [16:49:07] incoming:http://graphite.wikimedia.org/render/?width=588&height=311&_salt=1426783712.644&from=00%3A00_20150317&until=23%3A59_20150319&target=eventlogging.client_side_events.valid.rate&target=eventlogging.client_side_events.raw.rate&target=eventlogging.schema.Edit.rate&target=eventlogging.schema.MobileWebUIClickTracking.rate [16:49:33] Krenair: the difference between green and blue lines are VE non valid events [16:50:38] nuria, so we're getting a lot of invalid events? [17:00:07] ori, what's the best dashboard for visualeditor load performance at this point? [17:02:42] Krenair: yes, 150 per second sometimes [17:02:53] that is over half a million in an hour right? [17:09:03] 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 5Patch-For-Review, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1132440 (10Mattflaschen) [17:12:45] nuria, and these are definitely all VE events, nothing from WikiEditor right? [17:13:27] Krenair: lemmme check, i think so , but let me double check cause this started happening big time yesterday [17:13:45] Krenair: will get back to you in 20 min (in meeting now) [17:13:49] ok [17:14:41] Eloquence: http://grafana.wikimedia.org/#/dashboard/db/visualeditor-load-save probably [17:15:44] *nod*, thanks [17:17:11] Krenair: actually this is mostly ALL wikitext [17:17:15] cc milimetric [17:17:45] Krenair: so yes, half a million errors this hour: "2015-03-18-20" [17:21:10] Krenair: will provide details (with ticket) when i am out of meeting [17:34:11] RoanKattouw, you had to prepend '-'? [17:34:15] (03PS1) 10Esanders: Refactor expandLinearSelection test into a case loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197953 [17:34:17] (03PS1) 10Esanders: Fix edge case in expandLinearSelection when selection covers node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197954 (https://phabricator.wikimedia.org/T86762) [17:34:19] sigh [17:34:52] TrevorParscal, https://gerrit.wikimedia.org/r/#/c/197895/ [17:36:44] Krenair: Yeah, see comment near the top of the file [17:43:22] (03CR) 10Divec: [C: 032] Fix edge case in expandLinearSelection when selection covers node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197954 (https://phabricator.wikimedia.org/T86762) (owner: 10Esanders) [17:43:55] (03PS1) 10Trevor Parscal: Update context menu on document update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197960 (https://phabricator.wikimedia.org/T91336) [17:45:12] (03CR) 10Krinkle: [C: 032] Fix code style in @examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/197900 (owner: 10Esanders) [17:45:31] I just found a really weird bug in VE that I now can't reproduce. [17:45:35] Let me describe it and see if it's known. [17:45:41] I was editing a table, adding a column to it. [17:46:00] (03CR) 10jenkins-bot: [V: 04-1] Update context menu on document update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197960 (https://phabricator.wikimedia.org/T91336) (owner: 10Trevor Parscal) [17:46:23] I then made a new paragraph above the table and wrote some stuff in it. I then tapped the link button to add a link, and it went into a bit of a scrolling frenzy, eventually settling down with my cursor being at the very bottom of the screen, whereas it was in the middle before. [17:46:27] (03CR) 10Catrope: [C: 04-1] Fix edge case in expandLinearSelection when selection covers node (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197954 (https://phabricator.wikimedia.org/T86762) (owner: 10Esanders) [17:46:27] Known issue? [17:47:02] James_F ^ [17:47:30] Also the top of the link dialogue seems to be missing a shadow so it's bleeding into the rest of the page [17:47:32] Is that known too? [17:48:13] (03CR) 10Catrope: Fix edge case in expandLinearSelection when selection covers node (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197954 (https://phabricator.wikimedia.org/T86762) (owner: 10Esanders) [17:50:12] (03CR) 10Catrope: [C: 032] Refactor expandLinearSelection test into a case loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197953 (owner: 10Esanders) [17:52:14] (03Merged) 10jenkins-bot: Fix code style in @examples [oojs/ui] - 10https://gerrit.wikimedia.org/r/197900 (owner: 10Esanders) [17:52:30] (03CR) 10Esanders: Fix edge case in expandLinearSelection when selection covers node (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197954 (https://phabricator.wikimedia.org/T86762) (owner: 10Esanders) [17:52:37] (03Merged) 10jenkins-bot: Refactor expandLinearSelection test into a case loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197953 (owner: 10Esanders) [17:54:51] (03PS2) 10Esanders: Fix edge case in expandLinearSelection when selection covers node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197954 (https://phabricator.wikimedia.org/T86762) [17:54:57] 10VisualEditor, 10GlobalUserPage: Links to a user pages that have no local content but get their content from a global user page show as red in VisualEditor but as blue in read more - https://phabricator.wikimedia.org/T93227#1132612 (10Deskana) 3NEW [17:55:23] 10VisualEditor, 10GlobalUserPage: Links to a user pages that have no local content but get their content from a global user page show as red in VisualEditor but as blue in read more - https://phabricator.wikimedia.org/T93227#1132621 (10Deskana) p:5Triage>3Low Speculatively triaging as low priority. Feel fr... [17:55:33] (03CR) 10Catrope: [C: 032] Fix edge case in expandLinearSelection when selection covers node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197954 (https://phabricator.wikimedia.org/T86762) (owner: 10Esanders) [17:55:41] 10VisualEditor, 10GlobalUserPage: Links to a user pages that have no local content but get their content from a global user page show as red in VisualEditor but as blue in read mode - https://phabricator.wikimedia.org/T93227#1132627 (10Deskana) [17:55:49] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Unnamed ref tags emptied of their contents - https://phabricator.wikimedia.org/T93228#1132631 (10NicoV) 3NEW [17:56:10] 10VisualEditor, 10GlobalUserPage: Links to a user pages that have no local content but get their content from a global user page show as red in VisualEditor but as blue in read mode - https://phabricator.wikimedia.org/T93227#1132641 (10Legoktm) [17:56:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey TitleIsAlwaysKnown hook (so that EducationProgram pages and GlobalUserPage links render correctly) - https://phabricator.wikimedia.org/T72123#1132642 (10Legoktm) [17:56:57] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, and 5 others: Parsoid performance: Use RESTBase from the MediaWiki Virtual Rest Service on group1/group2 wikis - https://phabricator.wikimedia.org/T89066#1132654 (10GWicke) As of now RESTBase is powering VisualEditor in all wikipedias.... [17:57:45] 10VisualEditor: Link dialogue caused a scrolling frenzy - https://phabricator.wikimedia.org/T93229#1132662 (10Deskana) 3NEW [17:57:53] I filed it anyway since I can reproduce it now [17:58:13] (03Merged) 10jenkins-bot: Fix edge case in expandLinearSelection when selection covers node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197954 (https://phabricator.wikimedia.org/T86762) (owner: 10Esanders) [17:58:40] In spite of the scrolling frenzy, editing tables with VE is super easy, so that's really nice :-) [17:59:02] Deskana: Hey. What's your question? [17:59:31] James_F: I filed this: https://phabricator.wikimedia.org/T93229 [17:59:42] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-03-25_(1.25wmf23): Cursor wobbles in inline slug and allows me to select into the internal list - https://phabricator.wikimedia.org/T86762#1132683 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [17:59:47] James_F: I wanted to know if it was known or not because I couldn't reproduce, but now I can reproduce. :-) [18:00:02] Deskana: Ah. New to me. :-( [18:01:06] James_F: Don't fret. On balance, editing tables with VE is so awesome that I still preferred to use VE. :-) [18:01:18] * James_F grins. [18:01:23] Deskana: Not high praise, though. [18:01:37] :-p [18:02:06] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, and 5 others: Parsoid performance: Use RESTBase from the MediaWiki Virtual Rest Service on group1/group2 wikis - https://phabricator.wikimedia.org/T89066#1132697 (10GWicke) 5Open>3Resolved Lets track group1 in a follow-up task. Clos... [18:02:37] Deskana: BTW, Citoid is now live on frwiki. [18:02:56] Also cc guillom who may be interested. :-) [18:03:23] 10VisualEditor: Navigating with Shift+Tab on oo-ui-toolbar-tools icons produces 'Cannot read property 'getModel' of undefined..' - https://phabricator.wikimedia.org/T93230#1132703 (10Etonkovidova) 3NEW [18:06:20] 10VisualEditor: Navigating with Shift+Tab on oo-ui-toolbar-tools icons produces 'Cannot read property 'getModel' of undefined..' - https://phabricator.wikimedia.org/T93230#1132720 (10Catrope) a:3Esanders [18:06:23] edsanders: https://phabricator.wikimedia.org/T93230 [18:09:47] 10VisualEditor: Tool menu: navigating with Tabs skips some icons - https://phabricator.wikimedia.org/T93232#1132749 (10Etonkovidova) 3NEW [18:10:06] RoanKattouw, do we expect people to be able to shift tab onto the toolbar and use the tools [18:10:24] because that would break our model-view synchronisation [18:10:39] How? [18:11:15] 1) How is that different from using the tools with the mouse, 2) if you don't support that how the hell do you do things without the mouse [18:11:16] oh, it keeps the selection [18:11:22] For (2) I guess we have shortcuts like Ctrl+B [18:11:35] Oh did the toolbar move again and is it now inside the surface or something? [18:11:37] at the moment none of them work, and you can't focus a dropdown [18:11:44] I guess there's a catch-22 here [18:12:02] When the focus moves to the toolbar, conceptually the content in the surface is no longer selected [18:12:20] But if we null out the selection, then 1) the tools won't apply to the right selection and 2) they'll all be disabeld [18:12:23] it is selected, it isn't focused [18:12:28] Right [18:12:39] OK but it sounds like maybe the observer needs to be disabled [18:12:52] Or it needs to filter out key events whose e.target is not inside the documentNode [18:13:58] yes [18:15:13] the event sequence is only attached to the surface though [18:15:53] (03PS1) 10Catrope: Work around JS errors when editing image properties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197968 (https://phabricator.wikimedia.org/T93204) [18:15:57] So when you press enter, what is the e.target of the key event? [18:16:16] And why is... oh hold on [18:16:18] it's the surface observer [18:16:20] It's from timerLoop [18:16:32] but the enter should go through to the surface [18:16:37] it's not focused [18:17:14] So the observer is still running but it the ce.Surface doesn't have a model? WTF? [18:17:16] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Setting a image to reflow after inserting prevents saving, offset out of bounds - https://phabricator.wikimedia.org/T93204#1132785 (10Jdforrester-WMF) [18:17:34] could be because we prevent default on the toolbar buttons [18:17:36] Oh wait, it's emitting with an undefined node [18:17:41] it doesn't matter that the SO is running [18:17:51] the question is why the hell does pressing enter modify the CE [18:17:56] when it isn't focused [18:18:18] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Move to using white-space: pre-wrap instead of using nbsp's to fake spaces - https://phabricator.wikimedia.org/T55931#1132797 (10Aklapper) Still valid: ``` ./src/ce/nodes/ve.ce.TextNode.js: // Replace spaces with   where needed ``` [18:18:33] edsanders: It doesn't. I think I figured it out [18:18:42] I had it wrong before and I misled you [18:18:49] So, note that the stack starts at SO.timerLoop [18:18:55] ah onDocumentInput runs [18:19:00] So there's nothing going on with key events [18:19:22] So from timerLoop, we poll, and we find that the node changed from something to null [18:19:30] So we emit contentChange with node set to null [18:19:40] Then the contentChange listener does node.getDocument() assuming that node won't be null [18:19:44] And boom, JS error [18:19:47] That's the effect [18:19:48] mooeypoo: hello for this https://phabricator.wikimedia.org/T92868 i extended the MWExtensionNode and the data which comes on generateContents has to be rendered then,is this correct ? [18:19:57] the cause is the line break happening in the first place [18:20:19] when I press shift+tab then enter I get a linebreak [18:20:27] even though the surface isn't focused [18:20:40] wat [18:20:40] rits, hey! what do you mean extended MWExtensionNode and the data ? [18:20:45] (03PS2) 10Jforrester: Update context menu on document update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197960 (https://phabricator.wikimedia.org/T91336) (owner: 10Trevor Parscal) [18:21:14] in Chrome [18:21:21] in FF I get nothing, no errors [18:22:00] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/197968/ [18:22:21] TrevorParscal: https://gerrit.wikimedia.org/r/197968 [18:22:23] Ha. [18:22:24] sorry i mean inherited , and the data is that the JSON data of the graph [18:22:41] (03CR) 10Catrope: [C: 032] Update context menu on document update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197960 (https://phabricator.wikimedia.org/T91336) (owner: 10Trevor Parscal) [18:22:47] mooeypoo:^ [18:22:58] rits, inherited from what? I'm sorry, I'm a bit confused :) [18:23:11] rits, do you have code? if so, push it to gerrit, I can take a look [18:24:44] mooeypoo:ok i am pushing on to gerrit [18:25:31] (03Merged) 10jenkins-bot: Update context menu on document update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197960 (https://phabricator.wikimedia.org/T91336) (owner: 10Trevor Parscal) [18:28:15] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: & converted to & in reference name - https://phabricator.wikimedia.org/T93128#1132825 (10Mooeypoo) Can you give me a little more information? Did you edit that reference in VisualEditor or did it corrupt a reference you didn't at all touch? Was the only ch... [18:29:29] argh, wat - if I tab to the debug bar enter does nothing [18:29:50] if I tab to the toolbar it causes a linebreak [18:31:04] (03PS1) 10Mobrovac: Update repo to fd026c6 and update node dependencies [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/197972 [18:31:38] (03CR) 10Mobrovac: [C: 032 V: 032] Update repo to fd026c6 and update node dependencies [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/197972 (owner: 10Mobrovac) [18:32:52] 10VisualEditor, 7Technical-Debt: onFocusableRerender calls updateDimensions() unsafely - https://phabricator.wikimedia.org/T93237#1132854 (10Catrope) 3NEW [18:34:26] it appears to be if the button you focus handles the event or not [18:34:51] if it doesn't it 'bubbles' sideways to the unfocussed solution [18:35:38] Fun. [18:37:04] 10OOjs-UI, 10OOjs-UI-0.9.0, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-03-11_(1.25wmf21): Icon containers should always be the same size so we can use background-size: contain - https://phabricator.wikimedia.org/T85139#1132876 (10Etonkovidova) [18:39:09] TrevorParscal, why aren't tools buttonElements? [18:39:49] fun? [18:39:51] :( [18:40:14] Basically toolbars have no keyboard support [18:40:21] and buttons have some [18:42:15] (03PS2) 10Catrope: Follow up I2087030a8. Fix mangled code. [oojs/ui] - 10https://gerrit.wikimedia.org/r/197895 (https://phabricator.wikimedia.org/T73150) (owner: 10Esanders) [18:43:39] 10OOjs-UI, 7Accessibility: Toolbars are not keyboard-navigable - https://phabricator.wikimedia.org/T93240#1132906 (10Esanders) 3NEW [18:43:53] (03PS3) 10Jforrester: Follow-up I2087030a8: Fix mangled MediaWiki theme input transition [oojs/ui] - 10https://gerrit.wikimedia.org/r/197895 (https://phabricator.wikimedia.org/T73150) (owner: 10Esanders) [18:44:14] 10OOjs-UI, 7Accessibility: Toolbars are not keyboard-navigable - https://phabricator.wikimedia.org/T93240#1132917 (10Esanders) [18:44:15] 10VisualEditor: Navigating with Shift+Tab on oo-ui-toolbar-tools icons produces 'Cannot read property 'getModel' of undefined..' - https://phabricator.wikimedia.org/T93230#1132916 (10Esanders) [18:44:19] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: & converted to & in reference name - https://phabricator.wikimedia.org/T93128#1132918 (10Mooeypoo) I can't reproduce this in Chrome or Firefox, either with editing the reference or without. [18:50:27] 10VisualEditor, 10Analytics-EventLogging, 6Analytics-Kanban, 6WMF-NDA: Wikitext Eventlogging events not validating - https://phabricator.wikimedia.org/T93242#1132939 (10Nuria) 3NEW [18:52:24] 10WikiEditor, 10Analytics-EventLogging, 6Analytics-Kanban, 6WMF-NDA: Wikitext Eventlogging events not validating - https://phabricator.wikimedia.org/T93242#1132948 (10Catrope) [18:56:26] (03Abandoned) 10Mvolz: Update citoid submodule to master (fd026c6) [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/197881 (owner: 10Mvolz) [18:59:15] mvolz: Heya, BTW. :-) [19:00:47] mooeypoo: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-visualeditor-0-all&language=he&filter=%21translated&action=translate [19:01:08] James_F: hi :) [19:01:26] mvolz: We've switched the citoid extension on for frwiki. :-) [19:01:28] So exciting! [19:02:10] (03PS1) 10Trevor Parscal: [BREAKING CHANGE] Emit rerender for dead nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197987 (https://phabricator.wikimedia.org/T91314) [19:02:34] ahh [19:02:48] Did config go alright? Meant to ask who does that :). [19:02:50] mvolz: Next up is itwiki (tomorrow), then enwiki probably on Monday. [19:03:00] mvolz: Well, I probably screwed it up a bit but it seems to work. ;-) [19:03:18] mvolz: And we need to write some nice user-friendly documentation about how to set it up. [19:03:36] on mediawiki.org? [19:03:42] Yeah. [19:03:47] mvolz: mvolz: https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Contributions/Jdforrester_(WMF) if you want to inspect my work. [19:04:12] How's your French? [19:04:28] Oui [19:04:29] Eh. Enough to read, not to write. [19:04:44] Tres bien. [19:04:54] Treès [19:05:04] Je n'ai pas spell. [19:05:15] spelleux. [19:06:14] (03PS1) 10Trevor Parscal: Update VE core submodule to 10fcba6e124351115e900434e7570e48e428d882 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197988 (https://phabricator.wikimedia.org/T91314) [19:09:25] (03PS2) 10Catrope: [BREAKING CHANGE] Emit rerender for dead nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197987 (https://phabricator.wikimedia.org/T91314) (owner: 10Trevor Parscal) [19:09:58] Krenair: So what's going on with EventLogging stuff? [19:10:21] Krenair: i.e., what needs to be done, what are you working on, and what can I take on to make things go faster? [19:14:18] (03CR) 10Trevor Parscal: [C: 032] Work around JS errors when editing image properties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197968 (https://phabricator.wikimedia.org/T93204) (owner: 10Catrope) [19:15:33] (03PS1) 10Jforrester: Update VE core submodule to master (89c37dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197989 [19:15:43] RoanKattouw, I had been waiting for there to be some details [19:15:47] but it looks like we have a ticket now [19:18:27] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 10fcba6e124351115e900434e7570e48e428d882 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197988 (https://phabricator.wikimedia.org/T91314) (owner: 10Trevor Parscal) [19:19:57] (03CR) 10Trevor Parscal: [C: 032] Follow-up I2087030a8: Fix mangled MediaWiki theme input transition [oojs/ui] - 10https://gerrit.wikimedia.org/r/197895 (https://phabricator.wikimedia.org/T73150) (owner: 10Esanders) [19:22:46] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Unnamed ref tags emptied of their contents - https://phabricator.wikimedia.org/T93228#1133081 (10GWicke) [19:23:41] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Unnamed ref tags emptied of their contents - https://phabricator.wikimedia.org/T93228#1133083 (10cscott) https://gerrit.wikimedia.org/r/197803 is related, I think. [19:23:45] nuria, were you intending https://phabricator.wikimedia.org/T93242 to be private or not? [19:23:58] Krenair: yes, is it? [19:24:05] Krenair: private that is [19:24:09] I don't understand why you added #WMF-NDA as a project to a public task [19:24:11] No it's not private [19:24:19] (03CR) 10Trevor Parscal: [C: 032] Re-factor process dialog action button framing [oojs/ui] - 10https://gerrit.wikimedia.org/r/197914 (owner: 10Esanders) [19:24:34] Krenair: argh, i thought that is how you made a ticket private, how do you do it? [19:24:45] No that's not how you make a task private [19:24:55] Tasks cannot inherit policy from projects they're in, that'd be insane [19:25:08] I made it private but can no longer see it [19:26:32] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Citoid, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-sel... - https://phabricator.wikimedia.org/T88152#1133092 [19:26:38] Krenair: [19:26:40] Allow usersNuria [19:26:42] TrevorParscal : need some help here. Why do we have the single mode in transclusion box dialog box? [19:26:42] Allow members of projectsWMF-NDA [19:26:59] Why the hell are you not in WMF-NDA [19:27:10] ankita-ks: because the multiple mode is actually fairly rare [19:27:18] and it adds a lot of complexity to the UI [19:27:32] we use it when needed [19:28:34] interesting...So i have added a flag to the ve.ui.MWTransclusionDialog : empty_flag let's say [19:29:09] It is set whenever a template is removed and the box becomes empty [19:29:22] unset whenever a template is added and a box becomes empty [19:30:06] also whenever a change takes place in the dialog box, on replacePart function checks if the flag is set [19:30:46] if it is set, it adds a content model with text box removed and message set where the title should be. [19:30:48] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/197989/ too. [19:30:54] Does that sound right to you? [19:31:02] ^ TrevorParscal [19:31:16] sorry... (reading) [19:32:20] when you say "flag", do you mean a boolean property on the class? [19:32:25] yes [19:32:53] what is reading this property? [19:33:00] you've described the events that cause it to change [19:33:44] properties like this are used to retain a value for later reading [19:34:29] All the functions that make any change to the UI. addPart, removePart [19:34:33] etc [19:34:55] ^ TrevorParscal [19:34:56] I thought your objective was to show a UI for adding a template if things were empty? [19:35:22] seems like responding to the box becoming empty with adding a TemplatePlaceholder would do the trick [19:35:23] yes. [19:35:35] that's like 2 or 3 lines of code in onReplacePart [19:36:13] I did that but the problem is once a template placeholder is set [19:36:23] (03PS1) 10Jforrester: Tag v0.9.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/197995 [19:36:30] ankita-ks: ...? [19:36:33] I don't see how that error can occur anyway nuria, RoanKattouw [19:36:39] whenever another template is added it gets added after the previous placeholder. [19:36:40] (03CR) 10Jforrester: [C: 04-1] "Moriel is reporting testing issues; to confirm." [oojs/ui] - 10https://gerrit.wikimedia.org/r/197995 (owner: 10Jforrester) [19:37:12] the TemplatePlaceholder page is /supposed to/ remove itself when it's used to create a template [19:37:47] and, it appears to be working for me just fine [19:37:56] are you encountering a bug with this? [19:38:01] ah! [19:38:05] my bad! [19:38:28] I was trying to display a message whenever the screen became empty. [19:38:53] in stead of adding a template placeholder. [19:39:07] Krenair: in meeting, but note we have loads of those errors [19:39:16] ankita-ks: ah [19:39:19] yeah, no worries [19:39:42] so i should just put a template placeholder then and forget about the reassuring message? [19:39:43] sorry, I was just confused because I thought I had suggested that the other day [19:39:49] yes, you did. [19:39:49] maybe, but I need to be able to replicate the issue before I can do anything [19:40:00] I misinterpreted it. [19:40:15] I think the message could be incorporated into the TemplatePlaceholder, if it's really of value [19:40:16] I thought you suggested I do something like that to display the message. [19:40:18] my bad. [19:40:33] well..that makes it really simple. [19:40:37] thank you so much. [19:40:39] :) [19:40:47] so, for instance, TemplatePlaceholder could detect when it's the only part in the transclusion and choose to hide/show the message above the template input field [19:41:02] but, unless we think there's a lot of value to this message, I would skip that [19:41:10] yeah, glad to help ankita-ks [19:41:23] you're applying for gsoc right? [19:42:31] yes, I am. [19:42:36] ^ TrevorParscal [19:42:46] I haven't submitted my proposal yet though. [19:45:25] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: [Regression pre-wmf21] Comment icon is now huge - https://phabricator.wikimedia.org/T91656#1133114 (10Etonkovidova) [19:45:40] ankita-ks: I'll look out for it [19:46:06] :) [19:46:12] Any idea RoanKattouw? [19:46:33] (03Draft1) 10Physikerwelt: Fixup: MathRendering in search results [extensions/Math] (develop) - 10https://gerrit.wikimedia.org/r/197768 [19:46:42] (03CR) 10Physikerwelt: [C: 032] Fixup: MathRendering in search results [extensions/Math] (develop) - 10https://gerrit.wikimedia.org/r/197768 (owner: 10Physikerwelt) [19:46:46] Krenair: why not tests on beta labs, should be easy to replicate [19:47:14] Krenair: as it is happening very frequently [19:48:41] Krenair: Idea about? [19:48:53] Why that error could possibly occur [19:49:09] nuria, haven't managed to replicate it so far [19:49:23] Oh that validaton error [19:49:46] (03PS3) 10Physikerwelt: Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) [19:50:37] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0, 7Verified-in-Phase2, and 3 others: Hidden templates should display as an icon in-page in VisualEditor so they can be interacted with (e.g. a puzzle piece?) - https://phabricator.wikimedia.org/T51806#1133131 (10Etonkovidova) [19:52:17] Krenair: Hmm OK so it's an event without an editingSessionId [19:52:23] yes [19:52:33] coming from the wikieditor JS [19:53:23] https://fr.wikipedia.org/w/index.php?title=Barrage_du_Sapt&curid=5107627&diff=112945915&oldid=109031132#.C3.89v.C3.A9nements_contemporains is clearly a real citoid edit, much improved through using it. [19:53:26] Krenair: given is a wikitext event [19:53:46] Krenair: doesn't session need to be passed along from server ? cc RoanKattouw [19:53:56] that's the thing [19:53:59] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase2, 5WMF-deploy-2015-03-11_(1.25wmf21), 7user-notice: VisualEditor: Display and let users edit arbitrary HTML anchors, e.g. in section headings - https://phabricator.wikimedia.org/T52633#1133136 (10Etonkovidova) [19:54:05] editingSessionId: $( '#editform input#editingStatsId' ).val(), [19:54:14] that line passes the ID [19:54:30] What if there is no editingStatsId field [19:54:33] Is that possible? [19:54:48] nuria: How frequent are these validation failures as a proportion of total wikitext abort events? [19:54:52] shouldn't be [19:54:57] 3 out of 4 i think [19:55:11] James_F: http://graphite.wikimedia.org/render/?width=586&height=308&_salt=1426794895.096&target=citoid.input.url.rate [19:55:12] of abort events i do not know [19:55:20] RoanKattouw, but if it is missing, it returns undefined [19:55:36] RoanKattouw: Krenair , of total events os pretty big [19:55:47] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-03-11_(1.25wmf21), 7user-notice: VisualEditor: Display and let users edit arbitrary HTML anchors, e.g. in section headings - https://phabricator.wikimedia.org/T52633#579288 (10Etonkovidova) [19:55:49] RoanKattouw: there are many, many more invalid than valid events [19:56:01] OK so how does the editingSessionId hidden input get there [19:56:23] James_F: more urgent: http://graphite.wikimedia.org/render/?width=586&height=308&_salt=1426794965.798&target=citoid.zotero.req.501.count -- some 501s [19:56:41] James_F: more 501s than 200s, in fact: http://graphite.wikimedia.org/render/?width=586&height=308&_salt=1426794989.368&target=citoid.zotero.req.501.count&target=citoid.zotero.req.200.count [19:56:44] RoanKattouw, WikiEditorHooks::editPageShowEditFormFields [19:57:14] RoanKattouw, hm. what if these are non-wikitext pages being edited? that might be it [19:57:44] hah [19:57:50] Let's look at the page id [19:58:25] Nope it's a normal page [19:58:39] I tried clicking preview and show diff and I still get the thing [19:58:46] (03Merged) 10jenkins-bot: Work around JS errors when editing image properties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197968 (https://phabricator.wikimedia.org/T93204) (owner: 10Catrope) [19:58:51] (03Merged) 10jenkins-bot: Follow-up I2087030a8: Fix mangled MediaWiki theme input transition [oojs/ui] - 10https://gerrit.wikimedia.org/r/197895 (https://phabricator.wikimedia.org/T73150) (owner: 10Esanders) [19:59:41] - if ( !context.submitting ) { [19:59:41] + if ( !context.submitting && $( '#editform input#editingStatsId' ).length ) { [19:59:51] I guess so [19:59:54] But that hides the real issue [20:02:10] (03Merged) 10jenkins-bot: Re-factor process dialog action button framing [oojs/ui] - 10https://gerrit.wikimedia.org/r/197914 (owner: 10Esanders) [20:02:15] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/Vector] - 10https://gerrit.wikimedia.org/r/197994 (owner: 10L10n-bot) [20:06:57] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10RESTBase, 6Services, and 4 others: Parsoid performance: Use RESTBase from the MediaWiki Virtual Rest Service on group1/group2 wikis - https://phabricator.wikimedia.org/T89066#1133174 (10Ricordisamoa) [20:07:02] (03Merged) 10jenkins-bot: Fixup: MathRendering in search results [extensions/Math] (develop) - 10https://gerrit.wikimedia.org/r/197768 (owner: 10Physikerwelt) [20:20:54] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/198074 (owner: 10L10n-bot) [20:23:04] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198072 (owner: 10L10n-bot) [20:25:08] RoanKattouw_away, nuria, I think I got something [20:25:18] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/198060 (owner: 10L10n-bot) [20:27:39] RoanKattouw_away, nuria, it seems to occur when I press the log out button [20:29:11] (03PS44) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [20:29:22] (03PS45) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [20:29:27] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [oojs/ui] - 10https://gerrit.wikimedia.org/r/198052 (owner: 10L10n-bot) [20:29:30] (03PS12) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) [20:31:40] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/198045 (owner: 10L10n-bot) [20:32:26] Did Roan go to lunch, James_F? [20:37:53] anyone? [20:40:13] Krenair: Sorry, I must have missed what you said. Last log I have is grrrit-wm at 20:27:57 UTC. [20:40:50] was wondering if Roan had gone to have lunch or a meeting or something [20:41:03] He has, yeah. With TrevorP|Away and mooeypoo. [20:41:18] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/198016 (owner: 10L10n-bot) [20:41:19] I'm still here! :-) [20:41:21] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/198015 (owner: 10L10n-bot) [20:41:22] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/198015 (owner: 10L10n-bot) [20:41:39] James_F, I think I managed to replicate the event validation issue on beta [20:41:53] Krenair: Aha, cool. Do you understand the cause? [20:42:10] Also, should we prioritise lowering the flow before fixing the invalidations? nuria? [20:42:12] er, sorry, not beta [20:42:23] production, plwiki [20:42:46] go to the edit page, then click log out [20:43:10] WE edit? Or VE? [20:43:17] The problem is with WE edits. [20:43:28] OK. [20:43:31] '[Edit] Missing property "editingSessionId"' appears after the "Navigated to ..." [20:43:45] I think we've probably lost the stats ID at this point [20:43:53] On Special:LogOut? [20:44:25] Or does clicking logout break things whilst still on the edit page? (Also, do people log out that often?) [20:45:52] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5WMF-deploy-2015-03-25_(1.25wmf23): Setting a image to reflow after inserting prevents saving, offset out of bounds - https://phabricator.wikimedia.org/T93204#1133272 (10Jdforrester-WMF) 5Open>3Resolved [20:45:53] this is when moving from the edit page to special:logout [20:45:54] which page does the browser actually think they're on when it tries to get the ID? no idea [20:46:25] James_F: Yes PLEASE [20:46:45] James_F: first lowering flow, second working on invalidations. [20:47:01] OK, so that's the strategy for lowering the flow of events? User bucketing? [20:47:11] James_F, Krenair: will look at data some more for invalid events to see if i can find some comonality to help you repro [20:47:21] James_F: yes, using session ids [20:47:42] nuria: That doesn't work. [20:47:55] nuria: Apart from anything else, the session IDs not being set is the other problem, right? :-) [20:47:57] James_F: wait .. why not? [20:48:41] James_F: ok, one thing at a time, why session ids wouldn't work for sampling? We will be sending all events within a session that falls on a given bucket [20:49:06] nuria: Assuming session IDs are (a) being set and (b) aren't being changed. [20:49:30] It will also destroy EL as a source of debugging data, but never mind. [20:49:36] James_F: which is fine, we are bucketting for our non buggy case [20:49:48] OK. [20:49:55] So session ID mod 10 = 0? [20:50:10] What flow reduction do you recommend? 2 fold? 10 fold? 100 fold? [20:50:20] James_F: let's start with 10 fold [20:50:26] * James_F nods. [20:50:30] James_F: and we can bump it up if needed be [20:50:34] Krenair: Can you do that easily? [20:51:19] editing session ID is a string [20:51:32] Krenair: it's a 64 bit number encoded in hex [20:51:53] Krenair: js does not support 64 bit [20:52:00] We could do 16x easily with if string[0] = 'a'. [20:52:03] Or whatever. [20:52:10] Assuming their distribution is random. [20:52:22] James_F: it is as random as you will get, i wrote it [20:52:38] I like 'a' for Krenair. ;-) But that works, I assume? [20:52:48] The issue is with WE not VE flow, right? [20:52:53] Yes [20:52:54] James_F: That is fine too [20:53:01] OK, let's just make the change in WE for now. [20:53:06] Simpler to push out. [20:53:19] James_F: wikitext uses a different random from crypto pai [20:53:23] sorry [20:53:33] Ah. Is that also good enough? [20:53:35] James_F, Krenair : from mw crypto, [20:53:55] James_F, Krenair let me see what format does that return, i was refering to js prior [20:53:58] (Good enough to mod 10 it to bucket.) [20:54:10] nuria, what? [20:54:35] we just take the ID from the server, i.e. MWCryptRand::generateHex( 32 ) [20:55:09] Krenair:There are two sources of session ids : 1) client side from mw.user (js) 2) server side from crypto class on php , correct? (let me know otherwise) [20:55:25] Krenair: in wikitext, right, correct. [20:55:30] no... that's not correct [20:56:04] Ok, let's clarify: we are talking ONLY wikitext. [20:56:09] right? [20:56:11] right. [20:56:29] if so all sessionids come -as you pointed out - from: MWCryptRand::generateHex( 32 ) [20:56:43] that is a 32 bit number in hex right? [20:56:51] I would expect it to be. [20:57:24] Ok, so same strategy than the one you outlined above should work. [20:58:02] Hm. The docs say it's 32 hex chars of random data [20:58:53] If we just check id[0] === 'A', that gives us 1/16 [21:01:52] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: & converted to & in reference name - https://phabricator.wikimedia.org/T93128#1133315 (10gpaumier) @Mooeypoo: I've tried to reproduce the issue but haven't been able to either. I'm not the one who made the change, it's just something I noticed as I was rev... [21:02:24] oooh, logging out ON the edit page [21:02:31] So I got pretty close then [21:02:41] I did fiddle with logging out and going to the edit page by URL and stuff [21:05:12] RoanKattouw, is it trying to access dom elements during onunload like that not reliable? [21:05:51] I think we can just stick the ID in a variable before we even set window.onunload and get it from there instead [21:06:41] I also got the error when I navigated to another page by changing the url [21:07:11] Krenair: Oooooh maybe [21:07:20] Yeah maybe cache it early [21:07:24] Good point [21:08:04] Thing is I can't actually reproduce this on testwiki [21:10:59] or enwiki [21:12:25] 10Cite, 7user-notice: Highlight target references - https://phabricator.wikimedia.org/T10303#1133327 (10gpaumier) Included in wmf/1.25wmf22 [21:14:13] Any ideas RoanKattouw? [21:14:46] RoanKattouw, I can get it just by browsing to plwiki [21:14:54] RoanKattouw, how do you consolidate the concept of originalDomElements with transaction serialization? [21:14:57] even when there is no WE [21:14:58] wtf [21:15:14] edsanders: Hmm good question [21:15:22] They'd have to be serialized into HTML I suppose [21:15:31] Krenair: I don't know :S [21:15:39] But querying the document onunload does sound shady [21:15:49] (03PS4) 10Mooeypoo: [wip] Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 [21:15:54] So maybe we should just do the caching thing, deploy that, and see what happens [21:16:06] RoanKattouw, can you reproduce the issue with plwiki? [21:16:35] if this is running on every view request to plwiki (or others)... that'll be where the massive influx of events is coming from :) [21:16:55] RoanKattouw, but they contain the full sub tree [21:17:28] RoanKattouw, I think we need https://gerrit.wikimedia.org/r/#/c/197810/ and a check for wgPageContentModel [21:17:35] and the caching thing [21:17:56] that should make the situation more sane, hopefully [21:18:02] if not... we've narrowed it down a bit [21:18:35] edsanders: Hmm yeah so we might need some sort of clever serialization thing like we already do for annotation hashes [21:19:05] sound good? [21:19:22] Oh jeez [21:19:25] Page views?! :O [21:19:36] Quite. [21:19:38] Krenair: Oooooh what if there's a gadget that depends on jquery.wikieditor [21:19:50] That'd be causing this to happen. [21:19:52] ... [21:20:00] but but [21:20:09] Shouldn't that be checked earlier in that file? [21:20:13] I mean even if it isn't [21:20:23] We should probably not hook up resize handlers and build DOMs and crap [21:20:31] Doesn't seem to be [21:20:40] Can we focus on fixing the eventlogging situation? [21:20:45] Sure [21:21:03] So I think this check should be moved to line 220 [21:21:44] so https://gerrit.wikimedia.org/r/#/c/197810/1/modules/jquery.wikiEditor.js + check for wgPageContentModel (we know this definitely occurs on non-wikitext pages because the ID does not get set there) + cache ID on startup and reuse in onunload [21:21:54] Yes [21:21:55] Sounds good [21:23:08] I'm not happy with breaking custom wikieditor stuff by adding the check to #220 [21:23:34] I'm sure there's some case like LQT [21:23:35] or gadgets [21:23:38] or whatever [21:24:21] OK cool [21:24:24] Good point [21:24:36] (03CR) 10Catrope: [C: 032] Only do client-side instrumentation on action=edit/action=submit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197810 (https://phabricator.wikimedia.org/T93119) (owner: 10Alex Monk) [21:26:32] RoanKattouw, you can reproduce the on-view error @plwiki right? [21:26:45] Ahm lemme try [21:26:59] Yes [21:27:01] Twice! [21:27:04] [Edit] Missing property "editingSessionId" [21:27:06] (2x) [21:28:01] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Emit rerender for dead nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197987 (https://phabricator.wikimedia.org/T91314) (owner: 10Trevor Parscal) [21:28:02] greg-g, hey, I'm about to deploy some emergency wikieditor stuff [21:29:18] (03Merged) 10jenkins-bot: Only do client-side instrumentation on action=edit/action=submit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/197810 (https://phabricator.wikimedia.org/T93119) (owner: 10Alex Monk) [21:30:07] (03PS1) 10Alex Monk: Try to prevent crazy EventLogging entries with no session ID etc. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/198095 (https://phabricator.wikimedia.org/T93242) [21:30:15] RoanKattouw, ^ [21:30:47] RoanKattouw, same error on cswiki fyi [21:30:59] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Emit rerender for dead nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197987 (https://phabricator.wikimedia.org/T91314) (owner: 10Trevor Parscal) [21:36:41] RoanKattouw: Hm.. interesting. How does that get to trigger on view? [21:37:05] (03CR) 10Catrope: [C: 032] Try to prevent crazy EventLogging entries with no session ID etc. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/198095 (https://phabricator.wikimedia.org/T93242) (owner: 10Alex Monk) [21:37:10] (03Merged) 10jenkins-bot: Try to prevent crazy EventLogging entries with no session ID etc. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/198095 (https://phabricator.wikimedia.org/T93242) (owner: 10Alex Monk) [21:37:16] Krinkle: Local gadget or something depends on jquery.wikiEditor? [21:37:18] That's my guess [21:37:22] RoanKattouw: Yeah, but wgAction [21:37:51] Krenair: OK so do we have a patch yet for doing the 1/16 thing? [21:38:12] no [21:38:19] I was planning to see how this changes things first [21:38:33] OK... [21:38:35] RoanKattouw, so if you discard some of ODE on serialization - we have to undo the changes the AlienNode [21:38:35] because if this prevents it running on every page view... yeah [21:38:48] cs/pl wiki page view anyway. probably more [21:38:49] edsanders: Well AlienNode could know to do a deep serialization [21:38:55] edsanders: Or LeafNodes in general could [21:40:04] (03PS1) 10Alex Monk: Only do client-side instrumentation on action=edit/action=submit [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198103 (https://phabricator.wikimedia.org/T93119) [21:40:24] (03CR) 10Catrope: [C: 032] Only do client-side instrumentation on action=edit/action=submit [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198103 (https://phabricator.wikimedia.org/T93119) (owner: 10Alex Monk) [21:40:28] (03Merged) 10jenkins-bot: Only do client-side instrumentation on action=edit/action=submit [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198103 (https://phabricator.wikimedia.org/T93119) (owner: 10Alex Monk) [21:40:43] (03PS1) 10Alex Monk: Try to prevent crazy EventLogging entries with no session ID etc. [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198104 (https://phabricator.wikimedia.org/T93242) [21:40:51] so this got me thinking about how we store plain objects in the linmod [21:42:43] RoanKattouw, ^ [21:43:07] (03CR) 10Catrope: [C: 032] Try to prevent crazy EventLogging entries with no session ID etc. [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198104 (https://phabricator.wikimedia.org/T93242) (owner: 10Alex Monk) [21:43:12] (03Merged) 10jenkins-bot: Try to prevent crazy EventLogging entries with no session ID etc. [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198104 (https://phabricator.wikimedia.org/T93242) (owner: 10Alex Monk) [21:43:19] Krenair: And wmf22? [21:43:28] let's try wmf21 first [21:43:43] wmf22 is just test wikis at the moment IIRC [21:51:39] OK [21:52:48] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (89c37dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197989 (owner: 10Jforrester) [21:54:51] 10VisualEditor: Schema:Edit seems to incorrectly set users as anonymous. - https://phabricator.wikimedia.org/T92596#1133582 (10Catrope) Dan, is this still an issue? From our IRC conversation I got the impression that this was a misunderstanding. [21:55:23] (03Merged) 10jenkins-bot: Update VE core submodule to master (89c37dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197989 (owner: 10Jforrester) [22:01:31] (03PS1) 10Amire80: Remove extra 'or's from an English message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/198112 [22:01:33] (03PS1) 10Amire80: Extra credits in en.json and qqq.json [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/198113 [22:12:24] Hi, I am trying to submit a patch. But I can not ssh as I am behind proxy. [22:12:41] So I used corkscrew to override the proxy. [22:12:53] It works for github. [22:13:23] But not for gerri. [22:14:50] here is the my config file. i have a feeling that i might not have set the hostname for gerri.wikimedia.org right. [22:14:59] *gerrit [22:16:05] I have mentioned the error in a comment below the config file. [22:16:14] TrevorParscal : could you help me with this? [22:16:42] sorry . link to config file : https://gist.github.com/ankita-kumari/6948f66cafc88744f625 [22:17:29] this is not my area, RoanKattouw or Krinkle are far more clever when it comes to this sort of thing [22:18:13] ah..okay. :) [22:18:18] Hey all. [22:18:20] RoanKattouw: the picture of you scrutinizing the timeline printout is possibly going to end up on a paul irish slide. any objection? [22:18:36] Could you just take a look at the config file and see if the hostname is right? [22:18:51] ori: Sounds fine to me [22:19:12] ankita-ks: There is no ssh.gerrit.wikimedia.org [22:19:13] ^ TrevorParscal : maybe it's something as small as that. i mean if it is working for github, i don't see why it wouldn't for gerri. [22:19:20] okay. [22:19:27] ankita-ks: Try changing that to just gerrit.wikimedia.org [22:19:27] thought so. :P [22:19:30] okay [22:19:45] Hey guys, I managed to reproduce an issue on fr.wp which throws a Parsoid 500 error. can it be related to Citoid? [22:20:09] (it didn't happen while using Citoid, to clarify.) [22:20:12] No I'm guessing that's probably the safety thing they put in against blanking tags [22:20:20] Elitre: Could you report that over in #mediawiki-parsoid ? [22:20:26] Permission denied (publickey). [22:20:27] sure thing. [22:20:43] ankita-ks: do you have the right username ? [22:20:55] i think so [22:21:00] Do caps matter? [22:21:17] RoanKattouw: https://groups.google.com/a/chromium.org/d/msg/blink-dev/kC1V4eI10SE/DmoZoOXRoRMJ [22:21:25] ankita-ks: the right username is shown here: https://gerrit.wikimedia.org/r/#/settings/ [22:21:56] oh. my bad. [22:22:00] thank you so much. [22:22:13] that was it. [22:22:15] >_> [22:23:17] RoanKattouw, here's another one: https://pl.wikipedia.org/w/index.php?title=Wikipedia:Strona_g%C5%82%C3%B3wna&action=edit [22:23:21] (logged out) [22:24:04] the session ID is not passed in [22:24:09] even though wikieditor is loaded [22:24:16] probably due to not being allowed to edit it [22:26:34] Krenair: anyone test what happens icw CodeEditor on a .js page ? or when you use live preview ? [22:26:48] or god forbid LQT... [22:27:31] or proofreadpage, where the editform doesn't have a wpTextbox1 :) [22:27:39] we're not relying on wpTextbox1 [22:28:08] I decided there was no point even bothering with LQT [22:28:22] CodeEditor is fine [22:28:45] as long as there are no JS errors, you shouldn't bother :) [22:28:54] err [22:28:59] hang on a sec :) [22:29:36] right, CodeEditor is fine [22:29:43] we only look for wikitext [22:30:49] * thedj needs to sleep now [22:30:52] show preview/changes is fine [22:31:47] (03PS1) 10Alex Monk: Only do client-side instrumentation on action=edit/action=submit [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198120 (https://phabricator.wikimedia.org/T93119) [22:36:41] (03CR) 10Catrope: [C: 032] Only do client-side instrumentation on action=edit/action=submit [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198120 (https://phabricator.wikimedia.org/T93119) (owner: 10Alex Monk) [22:36:45] (03Merged) 10jenkins-bot: Only do client-side instrumentation on action=edit/action=submit [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198120 (https://phabricator.wikimedia.org/T93119) (owner: 10Alex Monk) [22:37:29] 10WikiEditor, 5Patch-For-Review, 7Regression: WikiEditor test throws "[Edit] Missing property editingSessionId" - https://phabricator.wikimedia.org/T93119#1133724 (10Krenair) 5Open>3Resolved a:3Krenair Should be better now. [22:37:40] 10WikiEditor, 7Regression: WikiEditor test throws "[Edit] Missing property editingSessionId" - https://phabricator.wikimedia.org/T93119#1133727 (10Krenair) [22:38:11] (03PS1) 10Alex Monk: Try to prevent crazy EventLogging entries with no session ID etc. [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198124 (https://phabricator.wikimedia.org/T93242) [22:41:04] (03CR) 10Catrope: [C: 032] Try to prevent crazy EventLogging entries with no session ID etc. [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198124 (https://phabricator.wikimedia.org/T93242) (owner: 10Alex Monk) [22:41:09] (03Merged) 10jenkins-bot: Try to prevent crazy EventLogging entries with no session ID etc. [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198124 (https://phabricator.wikimedia.org/T93242) (owner: 10Alex Monk) [22:44:40] 10OOjs-UI: ButtonElements should be uniform height with any combination of label, icon and indicator - including none of them - https://phabricator.wikimedia.org/T93290#1133750 (10TrevorParscal) 3NEW a:3Prtksxna [22:45:07] hi nuria, could you send me some more recent examples of event validation failures [22:45:08] ? [22:46:33] Krenair: yes, should i paste them on ticket? [22:46:47] on the private ticket we made earlier should be fine [22:47:55] https://phabricator.wikimedia.org/T93242 [22:53:13] (03PS1) 10Trevor Parscal: Initialize label of TransclusionDialog mode button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198129 (https://phabricator.wikimedia.org/T92986) [22:53:26] James_F|Away: ^^ [22:55:06] (03PS1) 10Ankita-ks: Fixed the empty Transclusion Box problem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198131 [22:56:07] ankita-ks: looking at that now [22:56:20] TrevorParscal : thanks :) [22:56:56] I think we also need to disable removing when there's only a template placeholder [22:57:32] Yes, that can be done. [22:57:38] Let me see. [22:57:39] also, please use hard tabs [22:58:10] we use them throughout MediaWiki both in PHP and JavaScript [22:58:45] I reccomend 4 space tabs with 100 character line limit [22:59:00] the line limit is approximate, but we stick to it pretty well in VisualEditor code [22:59:24] okay. will do that. sorry about that. [22:59:30] no worries [22:59:33] just giving you feedback [23:00:00] :) [23:00:43] as for the remove button [23:01:29] the way this works is the OutlineOptionWidget items in the list (which are generated to reflect the pages) have a method called isRemovable, which reads a property [23:01:52] so, this is 2 or 3 levels of generation away from where your code is at [23:02:12] * TrevorParscal looks around the code [23:04:15] (03PS1) 10Alex Monk: Don't try to do event logging if we don't have a stats ID [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/198134 [23:06:47] (03PS2) 10Jforrester: TransclusionDialog: Initialize label mode button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198129 (https://phabricator.wikimedia.org/T92986) (owner: 10Trevor Parscal) [23:06:57] (03CR) 10Jforrester: [C: 031] TransclusionDialog: Initialize label mode button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198129 (https://phabricator.wikimedia.org/T92986) (owner: 10Trevor Parscal) [23:08:02] TrevorParscal, so, I'm having a form validation issue with my inspector. [23:08:09] setAbilities is working fine to disable the button. [23:08:23] However, when you press enter, you can save in an invalid state. [23:08:33] I'm wondering where that should be rejected. [23:08:43] It's up at http://ee-flow.wmflabs.org/wiki/Talk:SomethingElse if you want to try it out to see what I mean. [23:09:56] Patch is https://gerrit.wikimedia.org/r/#/c/196866/ [23:10:20] ankita-ks: don't worry about disabling the remove button in the outline [23:10:52] Ah..okay..I did find the file though. [23:10:57] you might want to hide remove button in the add a template page when the transclusion contains only 1 part and it's a template placeholder [23:11:22] (03CR) 10Krinkle: Don't try to do event logging if we don't have a stats ID (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/198134 (owner: 10Alex Monk) [23:11:24] oh yes. [23:11:28] yeah, the thing is the outline stuff is going to be far more complex, involving commits in at least 2 repositories and a lot of rethinking [23:11:30] I overlooked that. [23:11:53] okay [23:11:57] but the remove button on the page should be much easier, and would make sense to include in this commit [23:12:10] yes, that's right [23:12:16] because otherwise this makes no sense [23:12:16] and I recommend hiding (toggling) the button, instead of disabling it [23:12:23] the template gets removed. [23:12:37] (03CR) 10Trevor Parscal: [C: 032] Tag v0.9.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/197995 (owner: 10Jforrester) [23:12:52] Why that? [23:15:11] (03PS2) 10Jforrester: Update VE core submodule to master (5d5f8a4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197988 (https://phabricator.wikimedia.org/T91314) (owner: 10Trevor Parscal) [23:15:45] (03PS1) 10Mooeypoo: Add 'isGenerating' method to ve.ce.GeneratedContentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198138 [23:17:07] (03PS2) 10Mooeypoo: Add 'isGenerating' method to ve.ce.GeneratedContentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198138 [23:17:35] (03Merged) 10jenkins-bot: Tag v0.9.3 [oojs/ui] - 10https://gerrit.wikimedia.org/r/197995 (owner: 10Jforrester) [23:17:42] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/197906/ [23:20:06] (03PS5) 10Mooeypoo: [wip] Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 [23:20:22] (03PS6) 10Mooeypoo: Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 [23:20:34] superm401: sorry, I'll respond in a minute [23:20:45] No problem, I appreciate it. [23:21:03] It's looking like I should just handle it in getTeardownProcess, but that could be wrong. [23:21:11] (03PS1) 10Jforrester: Update OOjs UI to v0.9.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198139 [23:23:00] superm401: So I think I can explain what's going on in one second [23:23:54] (03CR) 10Jforrester: [C: 031] Update VE core submodule to master (5d5f8a4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197988 (https://phabricator.wikimedia.org/T91314) (owner: 10Trevor Parscal) [23:24:36] superm401: So, there is an old pattern where we take actions from the teardown handler [23:24:41] By closing with data [23:25:12] So buttons would do things like inspector.close( { action: 'save' } ); and the teardown handler would see that data.action === 'save' and run the save code before tearing down [23:25:40] Then Trevor introduced the action system, and now the cool thing is to have ActionWidgets instead of buttons that call getActionProcess [23:25:48] RoanKattouw, right, in fact at the moment my getActionProcess just delegates to teardown. [23:25:56] Which is nice because then your teardown handler isn't this huge piece of code doing a million things [23:26:00] (sorry, that was re the first thing) [23:26:10] But, the handler for the enter key press just calls this.close(); [23:26:19] Or this.close( { action: 'done' } ); or something stupid [23:26:26] So it still assumes that pattern [23:26:29] 10OOjs-UI, 7Technical-Debt: Tech debt: OO.ui.ProcessDialog processes should be abortable, and should be aborted on teardown - https://phabricator.wikimedia.org/T93306#1133960 (10Mooeypoo) 3NEW [23:26:45] 10MediaWiki-ResourceLoader, 7Performance: ResourceLoader preloads blob metadata, then does another query for blob contents - https://phabricator.wikimedia.org/T28398#1133967 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:26:46] 10WikiEditor: Clicking on the wiki toolbar buttons more than one time mixes up the wiki syntax - https://phabricator.wikimedia.org/T28979#1133971 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:26:46] RoanKattouw, I think I know how to override the form submit handler. [23:26:47] 10WikiEditor, 7Browser-Support-Opera: Search&replace disabled in IE8, Opera - https://phabricator.wikimedia.org/T25992#1133970 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:26:51] 10WikiEditor: WikiEditor: Toolbar mis-clicks can go unnoticed - https://phabricator.wikimedia.org/T31365#1133978 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:26:52] 10MediaWiki-Page-editing: not all editing icons always applicable - https://phabricator.wikimedia.org/T21848#1133976 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:26:55] 10MediaWiki-ResourceLoader: ResourceLoader: Support loading of messages in parsed formats (e.g. parsed, incontentlanguage, ..) - https://phabricator.wikimedia.org/T27349#1133974 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:26:56] 10MediaWiki-ResourceLoader: Wrong output of duplicate stylesheet links for site module - https://phabricator.wikimedia.org/T31720#1133972 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:26:57] 10WikiEditor: Minor improvements of help in toolbar - https://phabricator.wikimedia.org/T26128#1133977 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:27:27] RoanKattouw, on Friday someone name-dropped ActionWidgets but I don't really know what they are. Is there a good example to consult? [23:27:48] RoanKattouw, so you're basically saying I should use ActionWidgets then just have the form submit handler delegate to them? [23:27:59] I'm not saying anything yet [23:28:08] If you're using .static.actions then that's using ActionWidgets behind the scenes [23:29:01] Okay [23:29:09] 10MediaWiki-ResourceLoader: ResourceLoader should restrict addModuleStyles() to modules that only provide styles - https://phabricator.wikimedia.org/T92459#1133996 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:29:28] Oh, ActionSets contain ActionWidgets. I am somewhat familiar with ActionSet now. [23:30:39] 10OOjs-UI, 10UI-Standardization, 7Tracking: Get OOUI PHP to be good to go - https://phabricator.wikimedia.org/T74713#1134001 (10Jdforrester-WMF) [23:30:40] 10OOjs-UI, 10Continuous-Integration: OOjs UI's PHP docs should be auto-generated - https://phabricator.wikimedia.org/T74454#1134002 (10Jdforrester-WMF) [23:30:53] 10OOjs-UI, 10MediaWiki-Interface, 10UI-Standardization: Provide the OOUI PHP module inside MW core - https://phabricator.wikimedia.org/T74714#1134005 (10Jdforrester-WMF) [23:31:05] 10OOjs-UI, 10MediaWiki-Interface, 10UI-Standardization: Provide the OOUI PHP module inside MW core - https://phabricator.wikimedia.org/T74714#1134006 (10Jdforrester-WMF) 5Open>3Resolved [23:31:07] superm401: So you're saying right now you have all your logic in getTeardownProcess()? [23:31:14] superm401: What does your getActionProcess() look like exactly? [23:32:01] RoanKattouw, yeah, all the save logic (except that transclusions are wired up separately so that could be considered part of the save logic): [23:32:05] https://gerrit.wikimedia.org/r/#/c/196866/8/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js [23:32:10] Oh I found your change [23:32:12] Yeah looking at that file now [23:32:23] OK so getActionProcess just maps to close( { action: action } ) [23:32:32] getActionProcess just delegates. I used to handle 'done' there, but then I found out that enter wouldn't work that way. [23:32:37] OK [23:32:42] So what is the invalid state issue exactly? [23:32:52] RoanKattouw, when you type in an invalid user and press enter. [23:32:55] Because pressing enter causes .close( { action: 'done' } ) to happen [23:32:58] 10MediaWiki-ResourceLoader: Using addModuleStyles() and then addModules() for one module on one page duplicates the styles - https://phabricator.wikimedia.org/T87871#1134010 (10Jdforrester-WMF) a:5TrevorParscal>3None [23:33:00] Which is terrible and I should fix that, but still [23:33:02] The button state is perfect, it's just when you submit with enter. [23:33:06] Yeah [23:33:35] OK, so I'm going to fix VE core so that you won't have this problem [23:33:37] (03Abandoned) 10Jforrester: Set mwtiming events' target to 'mwTarget', if unset [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197829 (owner: 10Jforrester) [23:33:42] (03Abandoned) 10Jforrester: Set mwtiming events' target to 'mwTarget', if unset [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/197828 (owner: 10Jforrester) [23:33:42] RoanKattouw, thanks. :) [23:33:45] But I'll require you to restructure your code "the right way (TM)" [23:33:48] Deal [23:34:12] Specifically, all the "if action is this, then do this" stuff should be in getActionProcess [23:34:28] (03Abandoned) 10Jforrester: Use OOjs UI progress bar while VE is loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/175488 (owner: 10Esanders) [23:34:33] (03PS10) 10Jforrester: Make loading progress bar determinate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196583 (https://phabricator.wikimedia.org/T90622) (owner: 10Esanders) [23:34:58] Oh, actually hmm [23:35:00] The reason I didn't do that (at least for 'done' is enter didn't work when it *was* a valid user). But I'm glad to restructure, as long as it works and I roughly understand the architecture. [23:35:06] superm401: So it turns out you don't /need/ to do that [23:35:12] Because of the way things are wired right now [23:35:29] Eventually we should migrate everything to the new pattern but I'm now finding that AnnotationInspector hasn't been migrated either [23:35:38] We probably migrated only some dialogs and zero inspectors [23:36:11] RoanKattouw, okay, I was wondering why there was no save logic in ve.ui.MWTemplateDialog.prototype.getTeardownProcess [23:36:13] (03CR) 10Jforrester: [C: 032] Remove extra 'or's from an English message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/198112 (owner: 10Amire80) [23:36:14] That explains it probably. [23:36:33] (03CR) 10Jforrester: [C: 032] Extra credits in en.json and qqq.json [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/198113 (owner: 10Amire80) [23:36:55] (03Merged) 10jenkins-bot: Remove extra 'or's from an English message [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/198112 (owner: 10Amire80) [23:36:55] But they probably don't have the enter problem I do. [23:37:14] (03Merged) 10jenkins-bot: Extra credits in en.json and qqq.json [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/198113 (owner: 10Amire80) [23:37:51] Yeah [23:37:59] Dialogs have been migrated, inspectors have not been [23:38:11] Because dialogs don't have this "close with saving action on enter" thing [23:38:19] And inspectors were not originally ProcessDialogs [23:38:35] We made them ProcessDialogs and went "oh we'll clean that up later" [23:39:03] Alright, so let's see [23:39:09] You *do* need to move all your stuff to action processes [23:39:18] Then in the process for 'done', you need to first check if the form is valid [23:39:23] If it is, save, and then call close [23:39:31] If it isn't, do nothing, and *don't* call close [23:39:47] (Most getActionProcess implementations do an unconditional .next( this.close, this ) at the end, but for that reason you cannot do that) [23:40:12] And you're going to solve the enter problem? [23:40:27] And I'll go and change the enter handler to do executeAction( 'done' ) instead of .close( { action: 'done' } ) [23:40:50] Sounds good, is that the one in ve.ui.FragmentInspector.prototype.onFormSubmit ? [23:40:56] In normal inspectors that action will just map to that close call for compatibility (that code actually exists already), but you will override getActionProcess such that instead you're conditionally calling close [23:40:58] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: & converted to & in reference name - https://phabricator.wikimedia.org/T93128#1134036 (10Mooeypoo) 5Open>3stalled I also tested on Windows 7 (64 bit) with 3 versions of Chrome. Can't reproduce. If the user responds and this can be reproduced we can rev... [23:40:59] Yes that's the one [23:41:25] 10VisualEditor: & converted to & in reference name - https://phabricator.wikimedia.org/T93128#1134039 (10Mooeypoo) [23:41:45] And then inve.ui.FragmentInspector.prototype.getActionProcess you'll see the 'done' action maps to this.close( { action: 'done' } ); , which is good for other inspectors (it'll keep enter working for them) but your override for getActionProcess will sometimes not call close [23:42:14] This is why we need to move from calling close to using actions, because what if you want to have a button that doesn't close the inspector, or have an enter press possibly not close like you do [23:43:23] Whoops, sorry. [23:43:28] Yeah, makes sense. [23:43:45] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.9.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198139 (owner: 10Jforrester) [23:43:55] superm401: Don't worry about it, we haven't been good about migrating our own code either [23:44:01] (03CR) 10Jforrester: "* I really liked the loading graphic at the top of the page." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196583 (https://phabricator.wikimedia.org/T90622) (owner: 10Esanders) [23:44:06] RoanKattouw, no, I meant for killing my IRC client. :) [23:44:31] RoanKattouw, also, there's no need for my getActionProcess to call the super-class one, right? I think I'm overriding everything. [23:44:35] It's not your fault that you're using last year's patterns instead of this year's if half the code uses the old pattern :D [23:44:49] Last thing I heard you say before "Whoops, sorry" was "This is why we need to ..." [23:45:07] Oh there was nothing said in between [23:45:23] As a matter of principle you should call the parent class if you do not recognize the action [23:46:25] (03Merged) 10jenkins-bot: Update OOjs UI to v0.9.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198139 (owner: 10Jforrester) [23:46:33] 10VisualEditor, 10Wikimedia-Site-requests, 5Patch-For-Review: Enable VE in ns 102 (WikiProject) on plwiki - https://phabricator.wikimedia.org/T92698#1134060 (10Jdforrester-WMF) 5Open>3Resolved [23:46:46] 10VisualEditor, 10Wikimedia-Site-requests, 5WMF-deploy-2015-03-25_(1.25wmf23): Enable VE in ns 102 (WikiProject) on plwiki - https://phabricator.wikimedia.org/T92698#1118391 (10Jdforrester-WMF) [23:47:02] RoanKattouw, okay, that's what I'm doing, so I'll just keep it. [23:47:27] Cool [23:47:53] Yeah that's also probably because you copied code from somewhere, but that part was good :) [23:48:09] Yeah. [23:48:09] ryasmeen: Did you want to do the Tech/News entries this week? [23:49:09] oh yeah James_F, I will update it [23:49:16] Cool. :-) [23:49:24] https://meta.wikimedia.org/wiki/Tech/News/2015/13 this week, I think. [23:49:36] yeah [23:50:15] (03PS1) 10Trevor Parscal: Make outline controls abilities configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/198151 [23:50:20] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Unnamed ref tags emptied of their contents - https://phabricator.wikimedia.org/T93228#1134069 (10Jdforrester-WMF) p:5Triage>3Unbreak! [23:50:36] ankita-ks: https://gerrit.wikimedia.org/r/198151 [23:50:44] once this gets pulled through into VisualEditor [23:51:57] you will be able to disable the removability of items [23:51:59] from within the dialog [23:52:17] so, next week we can add some code to do that [23:52:31] superm401: looks like RoanKattouw was helpful - I'm available now [23:52:44] sorry I was trying to knock out https://gerrit.wikimedia.org/r/198151 when you pinged me [23:52:54] (03PS1) 10Catrope: OO.ui.ProcessDialog#executeAction: Don't eat parent's return value [oojs/ui] - 10https://gerrit.wikimedia.org/r/198153 [23:53:19] TrevorParscal, no problem. I think he answered my question. [23:53:23] (03PS2) 10Catrope: Make outline controls abilities configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/198151 (owner: 10Trevor Parscal) [23:54:02] (03CR) 10Trevor Parscal: [C: 032] OO.ui.ProcessDialog#executeAction: Don't eat parent's return value [oojs/ui] - 10https://gerrit.wikimedia.org/r/198153 (owner: 10Catrope) [23:54:50] TrevorParscal : Oh..this seems interesting. In the mean time, I will just try hiding the remove button. [23:55:48] I should crash now. have an exam tomorrow. [23:56:03] ankita-ks: See you! [23:56:20] James_F : and you! :) [23:57:17] ankita-ks: cool, cya [23:57:30] (03Merged) 10jenkins-bot: OO.ui.ProcessDialog#executeAction: Don't eat parent's return value [oojs/ui] - 10https://gerrit.wikimedia.org/r/198153 (owner: 10Catrope) [23:59:02] (03PS1) 10Catrope: FragmentInspector: Execute action on enter, rather than closing with data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198155 [23:59:07] superm401: ---^^ [23:59:33] RoanKattouw, thanks.