[00:01:08] <Krenair>	 James_F, what mechanism would we use to do that?
[00:01:22] <Krenair>	 seems weird we couldn't do it dynamically
[00:01:34] <James_F>	 Krenair: A <meta> in the page heading.
[00:01:54] <James_F>	 https://phabricator.wikimedia.org/T59124
[00:01:57] <Krenair>	 only checked by chrome on page load?
[00:02:01] <James_F>	 <meta name="google" content="notranslate" /> 
[00:02:23] <wikibugs>	 10VisualEditor, 7Technical-Debt: Tech debt: refactor getMatchingAnnotation and validate its use in AnnotationInspector - https://phabricator.wikimedia.org/T93456#1137527 (10Mooeypoo) 3NEW
[00:02:32] <James_F>	 Maybe I should re-open?
[00:02:34] * James_F sighs.
[00:03:10] <Krenair>	 I don't know.
[00:03:26] <Krenair>	 Maybe it's something for upstream
[00:05:18] <Krenair>	 James_F, did you see my question on https://phabricator.wikimedia.org/T66772 earlier?
[00:05:41] <James_F>	 Krenair: No?
[00:05:54] <Krenair>	 It's not clear we'd block the loading process with it
[00:06:01] <Krenair>	 it could run in the background after loading is done, for example
[00:14:37] <grrrit-wm>	 (03CR) 10Perhelion: "Anyway I mean all this Sodipodi and Inkscape code is not really necessary if the file size is that important." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[00:28:48] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1137601 (10Mooeypoo) @Yurik, I think @mvolz summed it up the best -- what we want to achieve is what you're talking about - a real time e...
[00:32:07] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1137606 (10Yurik) Ah, I see - didn't see his post because he was posting about the same time ))  Makes sense. In a long run VE should hav...
[00:40:29] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1137610 (10Mooeypoo) Ooh a general JSON editor would be good but pretty challenging, considering the UI and UX we'd like to have. In this...
[00:42:53] <ankita-ks>	 Hi, So I have been reading up on language proofing tools available and I was thinking about how something like that can be incorporated in VisualEditor. 
[00:43:17] <ankita-ks>	 I am specifically interested in Language Tool.
[00:44:15] <ankita-ks>	 So for now let's assume that we are using Language Tool servers and not a local installation.
[00:45:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Associate the fragment in AnnotationInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198428 (https://phabricator.wikimedia.org/T93363) (owner: 10Mooeypoo)
[00:45:30] <grrrit-wm>	 (03PS1) 10Jforrester: Associate the fragment in AnnotationInspector [VisualEditor/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198445 (https://phabricator.wikimedia.org/T93363) 
[00:45:38] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Associate the fragment in AnnotationInspector [VisualEditor/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198445 (https://phabricator.wikimedia.org/T93363) (owner: 10Jforrester)
[00:45:39] <mooeypoo>	 ankita-ks, What do you mean language proofing tools? like spell check ?
[00:46:04] <ankita-ks>	 Not just spell check but something that performs grammar checks
[00:46:20] <mooeypoo>	 ooh
[00:46:23] <ankita-ks>	 Basically proofreads for any kinds of errors.
[00:46:28] <mooeypoo>	 Interesting
[00:46:28] <ankita-ks>	 *kind
[00:46:39] <ankita-ks>	 yes so as I was saying
[00:46:39] <grrrit-wm>	 (03PS1) 10Jforrester: Revert "[BREAKING CHANGE] Allow access to surface through window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198446 
[00:46:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Revert "[BREAKING CHANGE] Allow access to surface through window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198446 (owner: 10Jforrester)
[00:46:44] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Revert "[BREAKING CHANGE] Allow access to surface through window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198446 (owner: 10Jforrester)
[00:46:54] <ankita-ks>	 So what we could do is whenever the document gets edited, we fetch the text (i am not sure at what intervals because we obviously can't do that every character change)
[00:46:59] <grrrit-wm>	 (03PS1) 10Jforrester: Revert "Add directionality classes to window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198447 
[00:47:03] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Revert "Add directionality classes to window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198447 (owner: 10Jforrester)
[00:47:28] <grrrit-wm>	 (03Abandoned) 10Mooeypoo: Update VisualEditor core submodule for cherry-picks [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198270 (owner: 10Mooeypoo)
[00:47:38] <grrrit-wm>	 (03Abandoned) 10Mooeypoo: Add general citations dialog [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198261 (https://phabricator.wikimedia.org/T62768) (owner: 10Mooeypoo)
[00:47:40] <ankita-ks>	 and we send it to the Language Tool server where the text gets processed and errors are annotated. 
[00:47:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Associate the fragment in AnnotationInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198428 (https://phabricator.wikimedia.org/T93363) (owner: 10Mooeypoo)
[00:48:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix webkit column hack [VisualEditor/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198279 (https://phabricator.wikimedia.org/T93322) (owner: 10Jforrester)
[00:48:08] <ankita-ks>	 Now instead of sending it to a a public service hosted by Language Tool
[00:48:20] <ankita-ks>	 we can configure an installation for mediawiki
[00:48:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Associate the fragment in AnnotationInspector [VisualEditor/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198445 (https://phabricator.wikimedia.org/T93363) (owner: 10Jforrester)
[00:48:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Revert "[BREAKING CHANGE] Allow access to surface through window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198446 (owner: 10Jforrester)
[00:48:47] <ankita-ks>	 and then run that on a server.
[00:48:49] <mooeypoo>	 ankita-ks, I am very very concerned this will interfere with our support of IMEs
[00:49:05] <ankita-ks>	 Could you elaborate? 
[00:49:24] <ankita-ks>	 ^ mooeypoo 
[00:49:48] <mooeypoo>	 ankita-ks, we are supporting IMEs, which are a sort of in-the-browser keyboards that allow you to type in different languages. Some wikis desperately require them
[00:50:03] <mooeypoo>	 in order to support IMEs we have to do some complicated things in VE to make the browser happy
[00:50:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Add directionality classes to window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198447 (owner: 10Jforrester)
[00:50:11] <ankita-ks>	 okay
[00:50:14] <mooeypoo>	 I am slightly concerned that mixing the grammar system will interfere with that
[00:50:25] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 5WMF-deploy-2015-03-18_(1.25wmf22), 5WMF-deploy-2015-03-25_(1.25wmf23): [Regression wmf22] Link removal doesn't work on first click anymore - https://phabricator.wikimedia.org/T93363#1137633 (10Jdforrester-WMF)
[00:50:32] <mooeypoo>	 the IMEs must change content in the page, too, and some of them change the content in a specific way
[00:50:52] <ankita-ks>	 what do you mean by specific way?
[00:50:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix webkit column hack [VisualEditor/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198279 (https://phabricator.wikimedia.org/T93322) (owner: 10Jforrester)
[00:51:02] <James_F>	 Is this not browser native behaviour?
[00:51:12] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers, and 2 others: [Regression wmf22] Link removal doesn't work on first click anymore - https://phabricator.wikimedia.org/T93363#1135385 (10Jdforrester-WMF)
[00:51:20] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers, and 2 others: [Regression wmf22] Link removal doesn't work on first click anymore - https://phabricator.wikimedia.org/T93363#1137638 (10Jdforrester-WMF) 5Open>3Resolved
[00:51:22] <ankita-ks>	 What is?
[00:51:29] <ankita-ks>	 ^ James_F 
[00:51:29] <grrrit-wm>	 (03PS2) 10Jforrester: Revert "[BREAKING CHANGE] Allow access to surface through window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198446 
[00:51:38] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Revert "[BREAKING CHANGE] Allow access to surface through window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198446 (owner: 10Jforrester)
[00:51:45] <mooeypoo>	 ankita-ks, I have to admit I am not an IME expert, but I know enough from our current involvement with it that it's really demanding. So, some IMEs change the text back and forth within your selection, bcause the result depends not on a single letter that you write, but a combination
[00:51:48] <mooeypoo>	 arabic for instance
[00:51:53] <mooeypoo>	 urdu i think too? 
[00:52:32] <ankita-ks>	 okay..so the thing about Language Tool is that it has support for many languages. I suppose there could be config settings for setting the language.
[00:52:37] <mooeypoo>	 ankita-ks, in order to make this behavior possible we allow for certain native things to happen and certain support in the surface. Adding another layer that potentially also changes the text sounds a bit dangerous to me.
[00:52:45] <grrrit-wm>	 (03CR) 10Paladox: "Oh ok thanks. How can I remove them without breaking anything." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox)
[00:52:47] <mooeypoo>	 ankita-ks, can you link to this Language Tool ?
[00:53:02] <ankita-ks>	 yes. here : https://languagetool.org
[00:53:09] <mooeypoo>	 also, the issue isn't language support, the issue is the actual behavior of the browser with VE
[00:53:17] <ankita-ks>	 In fact they have already have something called wikicheck
[00:53:33] <ankita-ks>	 ah okay
[00:53:36] <mooeypoo>	 ankita-ks, but it works on the wikitext editor, I assume?
[00:53:42] <ankita-ks>	 nope.
[00:53:58] <ankita-ks>	 It hasn't been included in any way as of yet.
[00:54:12] <ankita-ks>	 But maybe it could be
[00:54:32] <mooeypoo>	 ankita-ks, we've tried other similar things and had to take them off because of IMEs, so I'm really concerned this is either going to be a source of problem *or* it will be insane amount of work to make it work
[00:54:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "[BREAKING CHANGE] Allow access to surface through window manager" [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198446 (owner: 10Jforrester)
[00:54:48] <ankita-ks>	 hmm..interesting. 
[00:55:30] <mooeypoo>	 We could check into this, but I'm really really worried that you're getting yourself into something that is a pit of despair.
[00:55:56] <mooeypoo>	 And, potentially, will have to be reverted because it will interfere with the delicate workings of IMEs.
[00:56:03] <ankita-ks>	 oh
[00:56:24] <mooeypoo>	 IMEs are special flowers in the browser. They seem to be very delicate as it is. 
[00:56:27] <ankita-ks>	 So I was applying for this GSoC project : https://phabricator.wikimedia.org/T89107
[00:56:53] <ankita-ks>	 And this is what I had been thinking of for a while.
[00:57:19] <ankita-ks>	 From what you say, I have encountered a deadlock. 
[00:57:29] <RoanKattouw>	 I don't think it would necessarily be *too* difficult, but as mooeypoo says there might be issues
[00:57:40] <RoanKattouw>	 divec would be a good person to ask how feasible this would be
[00:57:48] <RoanKattouw>	 But it's Saturday for him already
[00:57:50] <mooeypoo>	 yeah I think we should ask him
[00:58:24] <ankita-ks>	 Are there any other people who could weigh in on this?
[00:58:36] <mooeypoo>	 ankita-ks, okay, let's do this
[00:58:41] <ankita-ks>	 I was hoping to finish the first draft of the proposal. 
[00:58:42] <mooeypoo>	 send me an email summarizing your idea
[00:58:47] <mooeypoo>	 + the link to the proofing tool
[00:58:50] <ankita-ks>	 okay
[00:58:58] <mooeypoo>	 (and please include the phabricator task just so I don't forget :)
[00:58:58] <ankita-ks>	 on it.
[00:59:04] <ankita-ks>	 alright.
[00:59:05] <mooeypoo>	 I'll pass it to david, who's our IMExpert
[00:59:21] <ankita-ks>	 That would be great. 
[00:59:28] <mooeypoo>	 He can tell us if it's viable and if not, maybe there's something else you can do that's related.
[00:59:47] <ankita-ks>	 That sounds great. i will draft the email right away.
[00:59:51] <mooeypoo>	 awesome
[00:59:54] <mooeypoo>	 moriel@wikimedia.org
[01:00:38] <ankita-ks>	 okay.
[01:00:46] <ankita-ks>	 mooeypoo : thank you :)
[01:00:54] <ankita-ks>	 and RoanKattouw 
[01:01:11] <mooeypoo>	 ankita-ks, no problems!I hope this can work ! it sounds like a great project
[01:01:27] <mooeypoo>	 I just hope it's feasible. We had to change a whole bunch of things for the IMEs to work, so I would rather be safe than sorry.
[01:03:43] <ankita-ks>	 mooeypoo : yes, of course. :)
[01:06:13] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (1c5c1e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198451 
[01:06:35] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (1c5c1e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198451 (owner: 10Jforrester)
[01:08:45] <wikibugs>	 10VisualEditor: "Error: offset was inside an ignoreChildren node" appears while double clicking on an empty line when an image is the first item of the page - https://phabricator.wikimedia.org/T93461#1137662 (10Ryasmeen)
[01:08:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (1c5c1e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198451 (owner: 10Jforrester)
[01:09:33] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix webkit column hack [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198278 (https://phabricator.wikimedia.org/T93322) (owner: 10Jforrester)
[01:12:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix webkit column hack [VisualEditor/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198278 (https://phabricator.wikimedia.org/T93322) (owner: 10Jforrester)
[01:53:56] <wikibugs>	 10VisualEditor: "Error: offset was inside an ignoreChildren node" appears while double clicking on an empty line when an image is the first item of the page - https://phabricator.wikimedia.org/T93461#1137705 (10Catrope) I thought this might have been a recent regression but it isn't, it's been broken since at le...
[01:54:25] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: "Error: offset was inside an ignoreChildren node" appears while double clicking on an empty line when an image is the first item of the page - https://phabricator.wikimedia.org/T93461#1137706 (10Jdforrester-WMF) p:5Triage>3High
[01:54:32] <James_F>	 RoanKattouw: Are you actually working? Tsk. :-)
[02:00:54] <grrrit-wm>	 (03Abandoned) 10Jforrester: Spaces => Tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198386 (owner: 10Ankita-ks)
[02:01:25] <James_F>	 RoanKattouw: But if you are, https://gerrit.wikimedia.org/r/#/c/198138/ and https://gerrit.wikimedia.org/r/#/c/198393/ should be easy reviews.
[02:01:27] * James_F coughs.
[02:05:32] <grrrit-wm>	 (03PS1) 10Jforrester: Update sub-module for cherry-pick to 9751ebc [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198453 
[02:07:33] <grrrit-wm>	 (03PS1) 10Jforrester: Update sub-module for cherry-pick to 8f9701a [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198454 
[02:08:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update sub-module for cherry-pick to 9751ebc [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198453 (owner: 10Jforrester)
[02:08:44] <James_F>	 Meh
[02:09:15] * James_F glares at Krinkle.
[02:09:19] <Krinkle>	 James_F: Any flow people in the office>
[02:09:31] <Krinkle>	 https://phabricator.wikimedia.org/T93463
[02:09:31] <James_F>	 Krinkle: Not sure. Almost certainly not.
[02:09:47] <Krinkle>	 I dont want to roll back the whole thing..
[02:10:20] <James_F>	 Yeah.
[02:10:23] * James_F sighs.
[02:10:26] <Krinkle>	 Flow has used 16byte size fields since 2013 initial prototyp
[02:10:32] <James_F>	 Can you just bump the size?
[02:10:38] <Krinkle>	 MediaWiki has had 32 varchar since 2009
[02:10:43] <Krinkle>	 I dont know what they bsed that on.
[02:10:49] <Krinkle>	 James_F: Schema change?
[02:10:50] <James_F>	 Crack?
[02:10:57] <Krinkle>	 You're asking me to do a Flow schema change on Friday night.
[02:10:57] <James_F>	 Krinkle: Schema fix. ;-) But yes.
[02:11:07] <James_F>	 Krinkle: It's that or remove them from CI.
[02:11:10] <Krinkle>	 Yeah
[02:11:17] <James_F>	 Krinkle: (Remove their code from blocking VE/MW/etc.)
[02:11:19] <Krinkle>	 I'll temporarily remove it from the group test
[02:11:24] <James_F>	 I'm OK with either option.
[02:11:28] <Krinkle>	 Their own jobs will still run
[02:11:37] <James_F>	 Or, rather, break?
[02:11:48] <Krinkle>	 I would imagine so yes
[02:11:53] * James_F sighs.
[02:12:01] <James_F>	 Their problem at this point.
[02:12:16] <James_F>	 But please be around on Monday to help them when they get back in.
[02:13:23] <Krinkle>	 Yep, will do
[02:14:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update sub-module for cherry-pick to 8f9701a [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198454 (owner: 10Jforrester)
[02:17:34] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] "Looks good to me, but that's because I wrote this on Moriel's computer :)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198138 (owner: 10Mooeypoo)
[02:18:22] <James_F>	 RoanKattouw: I wanted to know if my comment was up to your standards.
[02:18:35] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/198138/2..3/src/ce/nodes/ve.ce.GeneratedContentNode.js specifically.
[02:19:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Check for the two revision IDs returned by the server being different (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198393 (https://phabricator.wikimedia.org/T92993) (owner: 10Alex Monk)
[02:19:44] <RoanKattouw>	 James_F: @method is unnecessary (but you probably copied it from elsewhere)
[02:19:51] <RoanKattouw>	 James_F: And @returns is out of fashion, it's @return now
[02:19:54] <James_F>	 RoanKattouw: I did (further up the file).
[02:19:56] <James_F>	 OK, fixing.
[02:21:13] <grrrit-wm>	 (03PS4) 10Jforrester: Add 'isGenerating' method to ve.ce.GeneratedContentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198138 (owner: 10Mooeypoo)
[02:21:15] <James_F>	 Happier? :-)
[02:29:09] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Add 'isGenerating' method to ve.ce.GeneratedContentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198138 (owner: 10Mooeypoo)
[02:33:14] <Krinkle>	 James_F: OK. This is annoying. Templates in core is not virtually blocked on a minor patch in Flow. Fine, but Flow master is failing due to a bug in Echo. Echo is failing due to the one mis-regression of switching to Karma.
[02:33:30] <Krinkle>	 I'll fix the one in Echo. If you stay around a litlte longer to review :)
[02:36:01] <James_F>	 Krinkle: Of course.
[02:36:21] <James_F>	 Krinkle: What am I, going to go home at 19:30 on a Friday? ;-)
[02:42:32] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198454 (owner: 10Jforrester)
[02:42:44] <grrrit-wm>	 (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198453 (owner: 10Jforrester)
[02:55:45] <ankita-ks>	 mooey|away : I have sent you the mail. Please let me know whatever you find out. I will proceed accordingly. 
[02:56:02] <ankita-ks>	 Please let me know if more details are required. 
[02:56:19] <ankita-ks>	 I am still figuring out how the Language Tools work internally. 
[03:14:15] <Krinkle>	 James_F: Known bug that pdf pages thumbs do not work in VE?
[03:14:18] <Krinkle>	 (or Parsoid)
[03:14:24] <James_F>	 Krinkle: Yes.
[03:14:28] <Krinkle>	 noticed it while editing mw:RL/F
[03:14:37] <Krinkle>	 toward the bottom, the same thumb every time 
[03:14:43] * James_F nods.
[03:16:19] <Krinkle>	 James_F: and rendering file red links as broken thumbnails?
[03:16:27] <James_F>	 Yes.
[03:16:30] <Krinkle>	 k
[05:34:25] <wikibugs>	 10OOjs-UI: OO.ui.Process step promise can not reject with a single error - https://phabricator.wikimedia.org/T93465#1137835 (10Mattflaschen) 3NEW a:3Mattflaschen
[05:54:35] <grrrit-wm>	 (03PS1) 10Mattflaschen: Allow rejecting Process with single Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/198473 (https://phabricator.wikimedia.org/T93465) 
[05:56:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow rejecting Process with single Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/198473 (https://phabricator.wikimedia.org/T93465) (owner: 10Mattflaschen)
[09:10:11] <wikibugs>	 10WikiEditor, 7Browser-Support-Google-Chrome, 7Browser-Support-Internet-Explorer, 7Upstream: WikiEditor dialogs kill the undo buffer in IE and Chrome - https://phabricator.wikimedia.org/T33780#1137975 (10TheDJ) p:5Normal>3Lowest
[09:11:26] <wikibugs>	 10WikiEditor: Undo/Redo doesn't work in Chrome/Chromium/Firefox for WikiEditor 0.3.1 in MW 1.19.2 - https://phabricator.wikimedia.org/T45187#1137981 (10TheDJ) 5Open>3Invalid a:3TheDJ
[09:18:24] <grrrit-wm>	 (03CR) 10TheDJ: [C: 031] Don't try to do event logging if we don't have a stats ID [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198379 (owner: 10Alex Monk)
[09:18:35] <grrrit-wm>	 (03CR) 10TheDJ: [C: 031] Don't try to do event logging if we don't have a stats ID [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198378 (owner: 10Alex Monk)
[09:26:21] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 10WikiEditor, 10Analytics, and 3 others: Apply Schema:Edit instrumentation to WikiEditor - https://phabricator.wikimedia.org/T88027#1137997 (10TheDJ) These changes are somehow causing: T93384
[09:27:17] <wikibugs>	 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1135838 (10TheDJ)
[10:05:02] <wikibugs>	 10OOjs-UI, 10OOjs-UI-0.9.1, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget - https://phabricator.wikimedia.org/T89399#1138016 (10Esanders) What you if you attach your element to another un-atta...
[10:27:56] <grrrit-wm>	 (03CR) 10Esanders: "handlesOwnChildren!? This looks like we're making our code a lot more complex to fix a wikitext issue. I think wikitext issues just be han" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://phabricator.wikimedia.org/T51452) (owner: 10Jforrester)
[10:34:49] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Can't copy a single node selection (e.g. template / media / reference) in Safari - https://phabricator.wikimedia.org/T72143#1138019 (10Esanders) The selection should...
[11:06:57] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Can't copy a single node selection (e.g. template / media / reference) in Safari - https://phabricator.wikimedia.org/T72143#1138025 (10Esanders) The bug appears to b...
[12:43:48] <grrrit-wm>	 (03PS1) 10Esanders: Fix RangeState detection of selection outisde of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198483 
[12:43:50] <grrrit-wm>	 (03PS1) 10Esanders: Fix focusable node copy in Safari by using non WS selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198484 (https://phabricator.wikimedia.org/T72143) 
[12:45:14] <wikibugs>	 10TemplateData, 10Citoid: Missing parameter in citation - https://phabricator.wikimedia.org/T93355#1138054 (10Mvolz) Okay, what's going on here is a mismatch between the "Article" type and the "encyclopediaArticle" type.   For most of the "Article" types, the "periodique" value should be the same as publicatio...
[12:46:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix RangeState detection of selection outisde of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198483 (owner: 10Esanders)
[12:47:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix focusable node copy in Safari by using non WS selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198484 (https://phabricator.wikimedia.org/T72143) (owner: 10Esanders)
[13:12:19] <wikibugs>	 10TemplateData, 10Citoid: Missing parameter in citation - https://phabricator.wikimedia.org/T93355#1138087 (10Mvolz) I asked this question here: https://forums.zotero.org/discussion/47725/should-i-expect-the-field-publicationtitle-or-encyclopediatitle-in-encyclopediaarticles
[13:15:29] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1138095 (10NiharikaKohli) We're holding an IRC meeting on [March 25, at 1700 UTC](http://www.timeanddate.com/worldclock/fixedtime.html?ms...
[13:18:51] <wikibugs>	 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1138102 (10TheDJ) p:5Triage>3High
[14:37:31] <wikibugs>	 10OOjs-UI, 10OOjs-UI-0.9.1, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Don't rely on unreliable DOMNodeInsertedIntoDocument event for autosizing TextInputWidget - https://phabricator.wikimedia.org/T89399#1138115 (10matmarex) Yes, I realized that this is a problem after commentin...
[14:40:18] <grrrit-wm>	 (03PS2) 10Esanders: Fix RangeState detection of selection outisde of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198483 
[14:40:20] <grrrit-wm>	 (03PS2) 10Esanders: Fix focusable node copy in Safari by using non WS selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198484 (https://phabricator.wikimedia.org/T72143) 
[14:51:09] <wikibugs>	 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1138116 (10Krenair) Has anyone been able to reproduce this while logged out/on a new account?
[15:26:54] <wikibugs>	 10OOjs-UI, 10VisualEditor: ButtonSelectWidgets get messed up after being hovered with mouse on Blink browsers (Chrome) - https://phabricator.wikimedia.org/T93472#1138139 (10matmarex) 3NEW
[15:32:13] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: LookupElement: Fix typo in docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/198490 
[15:45:30] <grrrit-wm>	 (03PS1) 10Mvolz: [WIP] Validate language codes in mediawiki format [services/citoid] - 10https://gerrit.wikimedia.org/r/198491 
[16:00:22] <grrrit-wm>	 (03CR) 10Mvolz: "FYI, test fails due to unrelated issue (not something that happens in this change.)" [services/citoid] - 10https://gerrit.wikimedia.org/r/198491 (owner: 10Mvolz)
[16:15:00] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Selected text disappear after click on „“ - https://phabricator.wikimedia.org/T71140#1138176 (10Juandev) >>! In T71140#1068050, @Etonkovidova wrote: > I tried google docs Insert-> Special character->Punctuation > - you cannot insert a pair characters in one click: a...
[16:16:20] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#1138179 (10Juandev) >>! In T53154#537004, @AdHuikeshoven wrote: > Adding a signature with VisualEditor can be simulated using a template: >...
[17:09:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "*sheds a single tear*" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders)
[17:11:14] <wikibugs>	 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki: The OOUI hack to prevent scrolling while dialog is open causes page contents to move horizontally by scrollbar's width in RTL when dialog opens - https://phabricator.wikimedia.org/T93476#1138213 (10matmarex) 3NEW a:3Esanders
[17:11:27] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Filed T93476." [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders)
[17:12:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Compensate for loss of margin when opening modals [oojs/ui] - 10https://gerrit.wikimedia.org/r/196571 (https://phabricator.wikimedia.org/T89612) (owner: 10Esanders)
[17:12:10] <wikibugs>	 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki: The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens - https://phabricator.wikimedia.org/T89612#1138222 (10matmarex) 5Open>3Resolved Still partially broken in RTL, filed T93476 to track this.
[17:16:23] <wikibugs>	 10VisualEditor: Link dialogue caused a scrolling frenzy - https://phabricator.wikimedia.org/T93229#1138228 (10matmarex) Probably not a dupe, that behavior seems significantly different to me (and a lot less dramatic). I didn't debug it, though.
[17:16:38] <grrrit-wm>	 (03CR) 10Divec: Fix RangeState detection of selection outisde of document (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198483 (owner: 10Esanders)
[17:24:19] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#1138233 (10matmarex) >>! In T53154#1138179, @Juandev wrote: >>>! In T53154#537004, @AdHuikeshoven wrote: >> Adding a signature with VisualEd...
[17:25:21] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - https://phabricator.wikimedia.org/T53154#1138235 (10matmarex) >>! In T53154#1138179, @Juandev wrote: > Thank you for the code. Could the user also add a special button to VE or is i...
[17:31:45] <wikibugs>	 10VisualEditor: Link dialogue needs top shadow or line so it doesn't blend into the page - https://phabricator.wikimedia.org/T93478#1138245 (10Deskana) 3NEW
[18:18:07] <grrrit-wm>	 (03CR) 10Divec: "Actually ..." (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198483 (owner: 10Esanders)
[18:45:01] <grrrit-wm>	 (03PS3) 10Esanders: Fix RangeState detection of selection outisde of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198483 
[18:45:03] <grrrit-wm>	 (03PS3) 10Esanders: Fix focusable node copy in Safari by using non WS selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198484 (https://phabricator.wikimedia.org/T72143) 
[18:46:08] <wikibugs>	 10MediaWiki-Page-editing, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 7JavaScript, 5Patch-For-Review: Dynamically loading TimedMediaHandler for new content (preview) - https://phabricator.wikimedia.org/T74675#1138290 (10TheDJ)
[20:41:16] <grrrit-wm>	 (03PS15) 10Paladox: Add collapsiblenav back [skins/Vector] - 10https://gerrit.wikimedia.org/r/190717 (https://phabricator.wikimedia.org/T69954) 
[20:42:36] <grrrit-wm>	 (03CR) 10Paladox: "By looking at where the bug first appeared it looks like collapsibletab is the problem not collapsiblenav. Looking at ms and collapsible t" [skins/Vector] - 10https://gerrit.wikimedia.org/r/190717 (https://phabricator.wikimedia.org/T69954) (owner: 10Paladox)
[20:45:28] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 10VisualEditor-MediaWiki: The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens - https://phabricator.wikimedia.org/T89612#1138440 (10Jdforrester-WMF) 5Open>3Resolved
[21:33:01] <wikibugs>	 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1138479 (10TheDJ) First, I think the dependency is on the wrong module.  The schema is added by the module ext.wikiEditor.init ext.wikiEditor has ext.wikiEditor.init...
[21:42:07] <wikibugs>	 10TemplateData, 10Citoid: Missing parameter in citation - https://phabricator.wikimedia.org/T93355#1138499 (10Mvolz) So on the listserve I discovered that it turns out I was under a terrible, terrible misapprehension that Zotero uses base types instead of item specific types. This is not the case.  What this m...
[21:48:00] <wikibugs>	 10MediaWiki-Page-editing: show a warning when saving a page with two equivalent headings or anchors - https://phabricator.wikimedia.org/T85670#1138526 (10Aklapper) p:5Triage>3Lowest
[22:11:23] <wikibugs>	 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1138587 (10Aklapper) >>! In T93384#1138523, @GOIII wrote: > https://test2.wikipedia.org/w/index.php?title=Page:On_the_forfeiture_of_property_by_married_women.djvu/17&...
[22:32:20] <wikibugs>	 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1138645 (10GOIII) Win 8.1 ~ IE 11 here.  How about logged-in but only select //Enhanced toolbar// in User Prefs (No classic toolbar to overcome & No WikiEditor dialog...
[23:00:22] <grrrit-wm>	 (03CR) 10Esanders: Fix RangeState detection of selection outisde of document (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198483 (owner: 10Esanders)
[23:00:27] <wikibugs>	 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1138684 (10TheDJ) I was able to reproduce this as a Logged in user, with @GOIII's link, but only upon the 2nd page load. This is probably subject to a race condition,...
[23:03:02] <grrrit-wm>	 (03PS4) 10Esanders: Fix RangeState detection of selection outisde of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198483 
[23:03:04] <grrrit-wm>	 (03PS4) 10Esanders: Fix focusable node copy in Safari by using non WS selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198484 (https://phabricator.wikimedia.org/T72143) 
[23:12:54] <wikibugs>	 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1138688 (10TheDJ) This is specific to the proofread page extension I suspect.  It doesn't include ext.WikiEditor directly, but instead uses a wrapper module to launch...
[23:48:58] <wikibugs>	 10WikiEditor, 6Editing, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1138703 (10GOIII) >>! In T93384#1138688, @TheDJ wrote: > This is specific to the proofread page extension I suspect. Again - above my pay grade - but I noticed that t...