[00:44:57] (03PS1) 10Esanders: Move drop marker to highlights layer and position absolutely [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198668 [02:10:14] 10OOjs-UI: Buttons explode in narrow containers - https://phabricator.wikimedia.org/T93552#1139782 (10Esanders) 3NEW a:3Esanders [02:10:36] (03PS1) 10Esanders: Disable line wrapping on buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/198670 (https://phabricator.wikimedia.org/T93552) [02:33:08] (03PS1) 10Esanders: Vertically center the progress bar within the visible part of #content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198675 [02:35:30] (03PS2) 10Esanders: Vertically center the progress bar within the visible part of #content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198675 [04:28:50] (03CR) 10Krinkle: [C: 032] Vertically center the progress bar within the visible part of #content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198675 (owner: 10Esanders) [04:33:44] (03Merged) 10jenkins-bot: Vertically center the progress bar within the visible part of #content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198675 (owner: 10Esanders) [06:19:16] 10OOjs, 10Continuous-Integration: Publish QUnit coverage on integration.wikimedia.org - https://phabricator.wikimedia.org/T87490#1139958 (10Krinkle) [07:53:36] (03CR) 10Nikerabbit: "Why are language codes limited to two characters?" [services/citoid] - 10https://gerrit.wikimedia.org/r/198491 (https://phabricator.wikimedia.org/T93337) (owner: 10Mvolz) [08:45:41] 10Citoid: Improve language code validation - https://phabricator.wikimedia.org/T93561#1140018 (10Mvolz) 3NEW [08:51:50] (03CR) 10Mvolz: "@Nikerabbit :" [services/citoid] - 10https://gerrit.wikimedia.org/r/198491 (https://phabricator.wikimedia.org/T93337) (owner: 10Mvolz) [09:33:26] 10Citoid, 5WMF-deploy-2015-03-25_(1.25wmf23): "Language not recognized" error on adding urls with openGraph metadata - https://phabricator.wikimedia.org/T93337#1140119 (10TheDJ) I would think really hard about how you can preserve as much information as possible, taking into account keeping stuff working with... [09:42:14] 10Citoid, 5WMF-deploy-2015-03-25_(1.25wmf23): "Language not recognized" error on adding urls with openGraph metadata - https://phabricator.wikimedia.org/T93337#1140131 (10Mvolz) @TheDJ - feel free to comment that directly on the thread and or on zotero-dev; https://forums.zotero.org/discussion/47726 (aurimas a... [09:54:16] 10VisualEditor, 10Wikimedia-Site-requests, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1140177 (10Aklapper) Has there been community discussion (link) about this or is this a personal request? [09:56:47] 10VisualEditor, 10Wikimedia-Site-requests, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1140178 (10Kelson) I'm at least aware about this: https://lists.wikimedia.org/pipermail/wikisource-l/2015-March/002197.html This is also a topic for offline because it's impossi... [10:16:29] 10VisualEditor, 10Wikimedia-Site-requests, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1140205 (10Aubrey) Two years ago we did a survey within the international Wikisource community: http://meta.wikimedia.org/wiki/Wikisource_Community_User_Group/Wikisource_survey_r... [10:31:36] (03PS1) 10Amire80: [BrowserTest] Add a screenshot for the category item [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198700 [10:33:17] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add a screenshot for the category item [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198700 (owner: 10Amire80) [10:35:44] (03Merged) 10jenkins-bot: [BrowserTest] Add a screenshot for the category item [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198700 (owner: 10Amire80) [10:39:48] (03PS1) 10Amire80: [BrowserTest] Add a screenshot for the Page settings menu item [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198702 [10:41:39] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add a screenshot for the Page settings menu item [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198702 (owner: 10Amire80) [10:46:00] (03Merged) 10jenkins-bot: [BrowserTest] Add a screenshot for the Page settings menu item [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198702 (owner: 10Amire80) [11:04:55] 10VisualEditor, 10VisualEditor-DataModel, 7Technical-Debt: Change ve.Range to use property names .anchor/.focus instead of .start/.end - https://phabricator.wikimedia.org/T93573#1140268 (10dchan) 3NEW [11:41:15] (03PS1) 10Divec: WIP: Insert slugs on backspace/delete if needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198705 [11:42:07] (03CR) 10Nikerabbit: "ISO 639-1 does not cover all languages. MediaWiki has lots and lots of three letter language codes for which there are no two letter equiv" [services/citoid] - 10https://gerrit.wikimedia.org/r/198491 (https://phabricator.wikimedia.org/T93337) (owner: 10Mvolz) [11:43:21] (03PS1) 10Divec: Describe ve.Range using anchor/focus terminology [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198707 [11:56:07] 10VisualEditor, 10Continuous-Integration, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Jenkins: Convert mediawiki qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#1140333 (10adrianheine) The reported number of tests ra... [12:01:24] (03PS1) 10Divec: Duck typing test for isBreak [unicodejs] - 10https://gerrit.wikimedia.org/r/198711 [12:03:00] 10VisualEditor, 10Continuous-Integration, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Jenkins: Convert mediawiki qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#1140354 (10adrianheine) More issues I had when running... [12:05:48] 10Citoid: Better documentation for setting up citoid with VE for wikis - https://phabricator.wikimedia.org/T93515#1140362 (10Mvolz) @Jdforrester-WMF I cleaned up and removed outdated information from mediawiki.org/Citoid but not sure what else to do next to make it more user friendly. Is the deb package they us... [12:08:44] 10Citoid: Restructure so that citoid can be run without Zotero - https://phabricator.wikimedia.org/T93579#1140367 (10Mvolz) 3NEW [12:13:11] 10VisualEditor, 10Continuous-Integration, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Jenkins: Convert mediawiki qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#1140385 (10adrianheine) Sorry for the noise, but after... [12:23:33] (03CR) 10Bartosz Dziewoński: "Not really? That wouldn't work for the PHP implementation?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/196210 (https://phabricator.wikimedia.org/T88622) (owner: 10Prtksxna) [12:32:37] 10Citoid: Better documentation for setting up citoid with VE for wikis - https://phabricator.wikimedia.org/T93515#1140409 (10mobrovac) >>! In T93515#1140362, @Mvolz wrote: > @Jdforrester-WMF I cleaned up and removed outdated information from mediawiki.org/Citoid but not sure what else to do next to make it more... [12:49:53] (03PS1) 10Esanders: Add unit test for mwAlienExtension node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198712 [13:23:30] (03PS1) 10Esanders: Remove registration of abstract AlienNode classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198713 [13:24:49] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#1140459 (10marcoil) [13:25:19] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 10Parsoid: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#770140 (10m... [13:27:12] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 10Parsoid: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#1140468 (10... [13:28:11] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 10Parsoid: VisualEditor: References inside galleries being displayed separately, inside the gallery, instead of in the correct block at the end of the page - https://phabricator.wikimedia.org/T74865#770140 (10m... [14:07:56] I've got a noobie phabricator question [14:11:27] How can I import the OOjs-UI theme LESS variables (e.g. progressive colours, etc) from another module that depends on OOjs-UI? [14:19:10] 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 5Patch-For-Review, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1140523 (10Pginer-WMF) It is great to see this live. Some comments: * The actions provided work quite well in general. ** Clickin... [14:28:54] (03CR) 10Catrope: [C: 032] Remove registration of abstract AlienNode classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198713 (owner: 10Esanders) [14:31:49] (03Merged) 10jenkins-bot: Remove registration of abstract AlienNode classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198713 (owner: 10Esanders) [14:34:35] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 2 others: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1140552 (10ferdbold) 3NEW a:3ferdbold [14:35:40] (03CR) 10Catrope: "So does / now serve nothing? For the health check in LVS, we need / to serve something (an HTTP 200) so that we can detect whether the ser" [services/citoid] - 10https://gerrit.wikimedia.org/r/198555 (https://phabricator.wikimedia.org/T93518) (owner: 10Mvolz) [14:35:49] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 2 others: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1140552 (10ferdbold) [14:39:50] (03CR) 10Mobrovac: "@Catrope static/index.html is served for / , i.e. the same content as before. See this in action @ citoid.wikimedia.org" [services/citoid] - 10https://gerrit.wikimedia.org/r/198555 (https://phabricator.wikimedia.org/T93518) (owner: 10Mvolz) [14:40:46] Morning. [14:40:52] (03CR) 10Catrope: "OK, that's fine then. This just wasn't obvious to me from the code, it must be a magical thing in express then." [services/citoid] - 10https://gerrit.wikimedia.org/r/198555 (https://phabricator.wikimedia.org/T93518) (owner: 10Mvolz) [14:41:20] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 2 others: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1140565 (10ferdbold) [14:41:39] Morning [14:42:09] (03CR) 10Jforrester: [C: 032] Update sub-module for cherry-pick to 8f9701a [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198454 (owner: 10Jforrester) [14:42:14] (03CR) 10Jforrester: [C: 032] Update sub-module for cherry-pick to 9751ebc [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198453 (owner: 10Jforrester) [14:43:04] RoanKattouw: Sanity-check – OK for me to SWAT https://gerrit.wikimedia.org/r/#/c/198134/ ? [14:47:21] (03Merged) 10jenkins-bot: Update sub-module for cherry-pick to 8f9701a [extensions/VisualEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198454 (owner: 10Jforrester) [14:47:23] (03Merged) 10jenkins-bot: Update sub-module for cherry-pick to 9751ebc [extensions/VisualEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198453 (owner: 10Jforrester) [14:47:28] (03CR) 10Jforrester: [C: 032] Don't try to do event logging if we don't have a stats ID [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198379 (owner: 10Alex Monk) [14:47:34] (03CR) 10Jforrester: [C: 032] Don't try to do event logging if we don't have a stats ID [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198378 (owner: 10Alex Monk) [14:47:38] (03Merged) 10jenkins-bot: Don't try to do event logging if we don't have a stats ID [extensions/WikiEditor] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/198379 (owner: 10Alex Monk) [14:47:41] (03Merged) 10jenkins-bot: Don't try to do event logging if we don't have a stats ID [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/198378 (owner: 10Alex Monk) [14:57:06] James_F: lgtm [14:57:14] RoanKattouw: Cool. [14:57:30] I mean technically that var name should be $editingSessionIdInput but it's fine [14:58:05] You snooze, you lose. ;-) [14:58:11] How was the conference? [14:58:15] It was good [14:58:54] I enjoyed Mako's and Karen Sandler's keynotes [14:58:59] zz_sucheta's talk went really well [14:59:08] Cool. :-) [14:59:32] for submitting patches from lib/ve submodule do i need need to create separate branch from visualeditor directory [15:00:15] mario____: Yes. [15:00:42] mario____: Generally, I handle the pull-through of code from lib/ve into extensions/VisualEditor just so other people don't have to. :-) [15:02:08] 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, and 4 others: Cite: Auto-filled references based on destination URL / DOI etc. - https://phabricator.wikimedia.org/T62768#1140592 (10gpaumier) >>! In T62768#1138925, @Mvolz wrote: > FYI citoid does not support ISBNs yet so I edited that bit out-... [15:03:26] Wow. [15:03:28] (03CR) 10Catrope: [C: 032] Duck typing test for isBreak [unicodejs] - 10https://gerrit.wikimedia.org/r/198711 (owner: 10Divec) [15:04:06] RoanKattouw: I using WikiEditor I just got "Exception encountered, of type "BadMethodCallException"" as the entirety of the returned when I tried to save. [15:04:23] Oops [15:04:25] In production? [15:04:25] RoanKattouw: That's… bad. [15:04:27] Yeah. [15:04:36] Like, not even a 500. [15:04:54] Hmm I wonder if that's related to Alex's patch that I +2ed, or was that in a different extension [15:05:13] The edit went through. [15:05:27] Yeah it was for a hook [15:05:27] It was an "Undo" edit, if that makes a difference. [15:05:34] So maybe it was a post-edit hook [15:06:42] James_F: Could this plausibly be you? [15:06:44] 2015-03-23 15:03:06 mw1086 mediawikiwiki: [b8af4f12] /w/index.php?title=Continuous_integration/Jenkins&action=submit BadMethodCallException from line 221 of /srv/mediawiki/php-1.25wmf22/extensions/Echo/Hooks.php: Call to a member function isMinor() on a non-object (NULL) [15:06:53] Yes. [15:07:12] That was the page I was editing. [15:07:22] No other edits in the last 20 hours. [15:07:28] $rev = Revision::newFromID( $extra['revid'] ); [15:07:32] if ( $rev->isMinor() ) { [15:07:40] So maybe $extra['revid'] is garbage [15:08:05] Hmm but it's wrapped in if ( !empty( $extra['revid'] ) ) { [15:08:07] So that's weird [15:08:25] I could be not-empty and also invalid? [15:08:57] Yeah [15:10:21] Hmm this is Echo listening to a hook fired by Echo :O [15:11:51] It probably *is* related to it being a revert [15:12:29] (03PS1) 10Esanders: [BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198729 [15:13:34] (03PS1) 10Esanders: Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 [15:13:34] 10VisualEditor, 10Wikimedia-Site-requests, 6Wikisource, 7Community-consensus-needed: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1140601 (10Gerardduenas) It would be great if you reached a consensus in the village pump and provided the link to it [15:13:38] James_F: Hah it's fixed in master in exactly the way I was going to fix it [15:13:59] https://phabricator.wikimedia.org/T93333 [15:14:35] Should have been deployed in this morning's SWAT but doesn't appear to have been [15:14:59] I guess the SWAT is still in progress [15:15:40] RoanKattouw: Want me to add it? [15:16:07] No it's in there [15:16:32] It's just that Jenkins only merged the wmf* pull-throughs 2 mins ago, so it's not deployed yet [15:16:41] Sorry for the confusion there [15:17:03] Fun. :-) [15:17:03] These past 10 minutes have been a compressed rerun of what I imagine was the Echo/Flow team's weekend [15:17:20] (03Merged) 10jenkins-bot: Duck typing test for isBreak [unicodejs] - 10https://gerrit.wikimedia.org/r/198711 (owner: 10Divec) [15:17:26] And now it's deployed [15:17:47] * James_F nods. [15:20:18] RoanKattouw: Also, did we want to get a UnicodeJS release done urgently? [15:20:23] (03PS2) 10Physikerwelt: Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (owner: 10Esanders) [15:20:29] I m trying to submit a patch from lib/ve submodule,but when i run git review -R ,i get file not found error.Here is the workflow:-http://pastebin.com/MKxiLiY2 [15:20:38] James_F: Which commits would be in that release? [15:20:46] RoanKattouw: https://gerrit.wikimedia.org/r/198711 only. [15:21:00] RoanKattouw: Oh, it's just a test. [15:21:02] * James_F mis-read. [15:21:03] Never mind, [15:21:14] Oh, and https://gerrit.wikimedia.org/r/#/c/197739/. [15:21:34] 10VisualEditor: Make all Event Logging instrumentation target the same Schema:Edit revision - https://phabricator.wikimedia.org/T93586#1140610 (10Milimetric) 3NEW a:3Jdforrester-WMF [15:21:52] James_F: OK, ask divec how important that is [15:21:58] RoanKattouw: Will do. [15:21:59] I think there might be a VE commit that depended on it? [15:22:38] pratikbsp: That's a scary error message. You seem to be on Windows so I may or may not actually be able to help you, but can you pastebin the results of the following commands (run in the lib/ve directory): [15:22:41] git remote -v [15:22:55] ls ../../.git/modules/lib/ve [15:22:57] sure [15:23:15] RoanKattouw: Nothing from David marked as dependent on it (or using "isBreak" in it). [15:23:35] (03PS3) 10Catrope: Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (owner: 10Esanders) [15:23:43] OK [15:26:35] 10VisualEditor: Schema:Edit seems to incorrectly set users as anonymous. - https://phabricator.wikimedia.org/T92596#1140636 (10Milimetric) Sorry for the late reply. The misunderstanding was that user.class=IP and user.id=0 did not seem to match at first. They do, in fact match. However, this issue is that 78%... [15:28:27] 10VisualEditor: Schema:Edit seems to incorrectly set users as anonymous. - https://phabricator.wikimedia.org/T92596#1140637 (10Milimetric) [15:29:00] RoanKattouw:http://pastebin.com/73WJ4pAv [15:29:03] 10VisualEditor, 10Wikimedia-Site-requests, 6Wikisource, 7Community-consensus-needed: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1140638 (10Tpt) >>! In T93525#1140601, @Gerardduenas wrote: > It would be great if you reached a consensus in the village pump and provided the lin... [15:29:13] 10VisualEditor, 10Wikimedia-Site-requests, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1140639 (10Tpt) [15:29:39] 10VisualEditor, 10MediaWiki-extensions-ProofreadPage, 10Wikimedia-Site-requests, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1139268 (10Tpt) [15:29:56] pratikbsp: OK, and what's ls ../../.git/modules/lib/ve/hooks ? [15:31:07] 10VisualEditor, 10MediaWiki-extensions-ProofreadPage, 10Wikimedia-Site-requests, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1140648 (10Jdforrester-WMF) Is this task asking for VisualEditor to be enabled for opt-in to edit the main and user namespaces right now,... [15:31:31] RoanKattouw: http://pastebin.com/pbHiZ3MB [15:32:35] pratikbsp: OK, can you try cp ../../.git/hooks/commit-msg ../../.git/modules/lib/ve/hooks/ ? [15:32:44] Then if that's not an error, try git review again [15:33:15] RoanKattouw: Windows environments don't have cp do they? [15:34:00] RoanKattouw: that didn't produce any thing,just blank [15:34:06] pratikbsp: That's good [15:34:14] pratikbsp: Hopefully git review will work now [15:34:25] James_F: git-bash and similar tools provide a lot of those commands [15:34:44] RoanKattouw: OK. [15:37:29] RoanKattouw: http://pastebin.com/N6686nZ6 [15:37:49] it says failed [15:39:34] (03CR) 10Physikerwelt: [C: 04-1] "Can we add at a bug number in order to keep track of documentation of this dependency?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (owner: 10Esanders) [15:42:47] pratikbsp: Try running git commit --amend and saving your commit message without any changes, then try git review again [15:44:12] (03PS1) 10Pratikbsp: "Delete row"/"Delete column" messages now using the plural when multiple rows/columns are selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 [15:44:37] (03CR) 10jenkins-bot: [V: 04-1] "Delete row"/"Delete column" messages now using the plural when multiple rows/columns are selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (owner: 10Pratikbsp) [15:45:10] thanks it worked [15:46:30] RoanKattouw:i have made some changes in visualeditor.php which depend on this do i need to prepare a separate patch for that [15:47:55] Yes [15:48:25] And then in the commit message write "Depends on If6b4a9c0 in code" [15:48:40] (That's the first few characters of your "Delete row" change's Change-Id) [15:49:35] thanks :) [15:53:35] if i want to update 1 of the uploaded files what do i need to do [15:54:25] pratikbsp: Edit the file, git add filename, git commit --amend, git review -R [15:55:06] (03PS1) 10Esanders: Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 [15:55:27] will that generate a separate patch or update the patch? [15:55:48] pratikbsp: It will update it. [15:55:50] It'll update it [15:56:01] (03CR) 10Catrope: [C: 04-1] "Delete row"/"Delete column" messages now using the plural when multiple rows/columns are selected (037 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (owner: 10Pratikbsp) [15:56:15] pratikbsp: Also I've done a quick review of your patch ---^^ [15:56:57] (03PS4) 10Esanders: Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 [15:57:00] (03PS1) 10Esanders: Remove paragraph unwrapping, moved to parent class. [extensions/Math] - 10https://gerrit.wikimedia.org/r/198741 [15:57:16] I gotta go now, back in ~45 [15:57:43] (03CR) 10jenkins-bot: [V: 04-1] Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (owner: 10Esanders) [15:59:11] 10VisualEditor: MWExtensionInspector should inherit from NodeInspector - https://phabricator.wikimedia.org/T93592#1141310 (10Esanders) 3NEW a:3Esanders [16:00:18] (03PS2) 10Esanders: Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 [16:00:20] (03PS2) 10Esanders: [BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198729 (https://phabricator.wikimedia.org/T93592) [16:00:22] (03PS2) 10Esanders: Remove paragraph unwrapping, moved to parent class. [extensions/Math] - 10https://gerrit.wikimedia.org/r/198741 [16:00:25] (03PS5) 10Esanders: Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (https://phabricator.wikimedia.org/T93592) [16:03:06] (03CR) 10jenkins-bot: [V: 04-1] Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (owner: 10Esanders) [16:19:52] (03CR) 10Nirzar: "I agree, let's keep only one definition of font-family in body." [oojs/ui] - 10https://gerrit.wikimedia.org/r/197097 (https://phabricator.wikimedia.org/T92858) (owner: 10Nirzar) [16:23:41] (03PS3) 10Esanders: Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 [16:23:43] (03PS2) 10Esanders: Add unit test for mwAlienExtension node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198712 [16:23:45] (03PS3) 10Esanders: [BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198729 (https://phabricator.wikimedia.org/T93592) [16:26:41] (03CR) 10jenkins-bot: [V: 04-1] Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (owner: 10Esanders) [16:30:13] (03PS1) 10Jforrester: i18n/en.json: Convert from spaces to tabs, like all other files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198746 [16:41:58] 10VisualEditor, 5Patch-For-Review: MWExtensionInspector should inherit from NodeInspector - https://phabricator.wikimedia.org/T93592#1141504 (10Physikerwelt) {F103079} (Math extension without VisualEditor update) [16:43:25] (03CR) 10Physikerwelt: "The update in the commit message got lost." [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [16:48:17] edsanders: https://phabricator.wikimedia.org/T89352 is the last remaining big blocker to deployment. Have you had any thoughts about it? [16:57:39] edsanders: To modify the tablecontext menu i have modified .static.title like in https://gerrit.wikimedia.org/r/#/c/198738/1/src/ui/ve.ui.TableContext.js (see the 4th comment by Catrope) is it fine ? [17:14:29] (03PS2) 10Divec: WIP: Insert slugs on backspace/delete if needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198705 [17:17:57] edsanders: Could you review https://gerrit.wikimedia.org/r/#/c/198643/2 and up? [17:17:59] RoanKattouw_away: Could you review https://gerrit.wikimedia.org/r/#/c/198549/2 and up? [17:18:03] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/198484/ [17:18:12] hi. [17:18:26] Hey MatmaRex. :-) [17:18:27] sorry, i barely missed the hangout, it seems. :/ [17:19:03] (03CR) 10Bartosz Dziewoński: "Oh, looks like https://gerrit.wikimedia.org/r/198705 is another fix for this." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński) [17:20:19] (03CR) 10jenkins-bot: [V: 04-1] WIP: Insert slugs on backspace/delete if needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198705 (owner: 10Divec) [17:20:33] (03CR) 10Catrope: [C: 032] Unmix GeneratedContentNode from AlienNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198549 (owner: 10Esanders) [17:21:51] (03CR) 10Catrope: [C: 04-1] Add 'classes' config option to focusable nodes to simplify AlienNode (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198550 (owner: 10Esanders) [17:22:57] 10VisualEditor, 7Accessibility, 3VisualEditor 2014/15 Q3 blockers: Make slugs keyboard accessible again - https://phabricator.wikimedia.org/T89352#1141704 (10Jdforrester-WMF) a:5Esanders>3dchan [17:24:32] RoanKattouw: What was left to do on https://phabricator.wikimedia.org/T68229 ?> [17:25:16] James_F: Unknown unknown [17:25:24] We don't currently know of any reproducible copy/paste fatals AFAIK [17:25:48] So that makes it impossible to determine whether T68229 is still an issue, and if so, what is happening and why and how we should deal with that [17:25:50] RoanKattouw: Facebook.com? [17:25:57] RoanKattouw: You said you could reliably reproduce… [17:26:00] That turned out not to be reproducible exactly [17:26:03] Fun. [17:26:06] Although now you mention it [17:26:20] There is a -1ed patch for that same issue related to IE [17:26:30] Yeah. [17:26:31] Somewhere [17:26:47] https://gerrit.wikimedia.org/r/#/c/197375/ [17:27:08] Yup. [17:27:18] Which... I guess may or may not still be reproducible with Ed's change? [17:28:23] (03CR) 10jenkins-bot: [V: 04-1] Unmix GeneratedContentNode from AlienNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198549 (owner: 10Esanders) [17:36:56] subbu: I think it's fine to strip out X-Parsoid-Performance, but cc @RoanKattouw for confirmation [17:39:08] k [17:43:31] subbu: Strip out from where? [17:43:41] subbu: Oh I see [17:43:49] subbu: You're saying Parsoid logs things to statsd directly now? [17:43:59] yes [17:44:11] OK yeah then you can kill it [17:44:31] will do. [17:47:35] X-Parsoid-Performance is also already stripped by restbase [17:50:49] Is there a difference between width: 100% and width: px;? [17:51:11] because one correctly shrinks my object to fit the window size and the other one still leaves overflow [17:51:17] so I guess my question is really: *what* is said difference? [17:52:38] 10VisualEditor, 10Continuous-Integration: Concurrent builds using local Chromium/Firefox browsers on Linux host fail - https://phabricator.wikimedia.org/T90673#1141972 (10Krinkle) p:5High>3Low [17:53:03] TrevorParscal: [13:50] werdna Is there a difference between width: 100% and width: px;? [17:58:48] RoanKattouw: I’m really confused. Do you have any tricks for finding out why an element overflows? [17:59:16] If I explicitly set the width of it to 800px then it’s fine, but that is apparently not the same as setting the width to 100% and sizing the browser window to 800px [17:59:17] werdna: That's beyond my paygrade in terms of CSS, that's why I pinged TrevorParscal [17:59:22] alas [17:59:26] Krinkle: perhaps? [17:59:29] thanks for pinging him RoanKattouw [18:00:06] werdna: overflow on the body I assume, no the element? [18:00:21] That means the element has padding most likely. [18:00:26] 10VisualEditor, 10MediaWiki-extensions-ProofreadPage, 10Wikimedia-Site-requests, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1142060 (10Ankry) Can we expect VE to support multipaged media like DjVu/PDF (as proposed in {T60033}) while enabled? [18:00:31] Which is not part of the width in the default box model. [18:00:37] https://www.dropbox.com/s/albmy2to3wc54w7/Screenshot%202015-03-23%2019.00.33.png?dl=0 [18:00:56] the space from border to border is width + padding. width 100% makes it expand to the width of the parent, but the padding is not substracted from that [18:01:17] display: block without a width ("auto" it were) does the magical 100% - padding [18:01:47] Krinkle: isn’t padding included in width? [18:01:52] border + margin is not [18:01:53] Never was, never. [18:02:40] if you can't omit width on that element, you could also remove the padding from it and move it to a sub element instead. E.g. [18:02:45] anyway there isn’t any padding [18:02:49] OK [18:02:51] so that’s not actually the problem :p [18:02:56] werdna: In that case, repro on jsfiddle or it didn't happen. [18:03:18] minimal case [18:03:34] hrrr minimal case :p [18:03:49] 10WikiEditor: Wikieditor (Revert making installable via composer) - https://phabricator.wikimedia.org/T93616#1142091 (10Legoktm) [18:07:43] Krinkle: damn, it works in JSFiddle [18:07:59] https://jsfiddle.net/ymv2fvwv/1/ [18:08:37] 10WikiEditor: Wikieditor (Revert making installable via composer) - https://phabricator.wikimedia.org/T93616#1142109 (10matmarex) Would be appropriate to CC the people you're mentioning, no? [18:10:20] (03CR) 10Esanders: Add 'classes' config option to focusable nodes to simplify AlienNode (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198550 (owner: 10Esanders) [18:10:24] (03PS3) 10Esanders: Document config options as @cfg [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198551 [18:10:26] (03PS3) 10Esanders: Add 'classes' config option to focusable nodes to simplify AlienNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198550 [18:10:37] Krinkle: and also works in Vector [18:10:40] I guess it’s skin related [18:11:29] (03PS1) 10Kmenger: ButtonElement: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/198761 [18:12:55] divec, hey [18:15:01] (03CR) 10Esanders: [C: 04-1] "Selections are serializable and therefore easily comparable that way. We can either ve.dm.Selection.static.newFromHash, and then compare s" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [18:16:01] (03CR) 10Bartosz Dziewoński: "Are you sure this is safe? Flow, for example, used to have massive buttons wrapping the entire topic headers, with other controls inside (" [oojs/ui] - 10https://gerrit.wikimedia.org/r/198670 (https://phabricator.wikimedia.org/T93552) (owner: 10Esanders) [18:16:26] MatmaRex, look at ve.dm.TableSelection.prototype.toJSON - it's a lot like the object in your test cases - that should make things easier [18:16:27] (03CR) 10jenkins-bot: [V: 04-1] Add 'classes' config option to focusable nodes to simplify AlienNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198550 (owner: 10Esanders) [18:17:09] edsanders: uh, i don't understand. is your comment only about assert.equalSelection method? [18:17:24] all of it really [18:17:39] (03PS1) 10Kmenger: TabIndexElement: Mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/198765 [18:17:39] you don't need that, or the method for converting ranges to linear selections [18:17:51] oh, about specifying them in that serialized format in test cases? [18:17:58] just change all the assertions to selection: { type: 'linear', range: new ve.Range() } [18:17:59] right [18:18:38] hmph, more search-and-replace [18:21:15] (03CR) 10Esanders: "If someone wants a multi-line button it should be designed and implemented properly. Try putting a large amount of text in a button label " [oojs/ui] - 10https://gerrit.wikimedia.org/r/198670 (https://phabricator.wikimedia.org/T93552) (owner: 10Esanders) [18:22:12] (03CR) 10Bartosz Dziewoński: [C: 032] "I'll just blame you, then. :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/198670 (https://phabricator.wikimedia.org/T93552) (owner: 10Esanders) [18:22:45] (03PS2) 10Bartosz Dziewoński: ButtonElement: Disable line wrapping on buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/198670 (https://phabricator.wikimedia.org/T93552) (owner: 10Esanders) [18:22:49] (03CR) 10Bartosz Dziewoński: [C: 032] ButtonElement: Disable line wrapping on buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/198670 (https://phabricator.wikimedia.org/T93552) (owner: 10Esanders) [18:24:50] 10OOjs-UI: LookupElement not behaving as described - https://phabricator.wikimedia.org/T93623#1142180 (10KMenger) 3NEW [18:26:49] (03Merged) 10jenkins-bot: ButtonElement: Disable line wrapping on buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/198670 (https://phabricator.wikimedia.org/T93552) (owner: 10Esanders) [18:28:01] (03PS4) 10Esanders: Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 [18:30:32] (03CR) 10Esanders: [C: 032] Unmix GeneratedContentNode from AlienNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198549 (owner: 10Esanders) [18:31:24] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198550 (owner: 10Esanders) [18:31:26] Krinkle, any idea what's happening with https://code.google.com/p/chromium/issues/detail?id=469284 ? [18:31:46] someone appears to have marked it as a dupe of a bug that leads to a 403 forbidden? [18:32:00] Yeah, crashes are usually hidden by default [18:32:24] security [18:32:29] (and abuse) [18:33:40] (03Merged) 10jenkins-bot: Unmix GeneratedContentNode from AlienNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198549 (owner: 10Esanders) [18:36:28] 10VisualEditor: Automagically convert URLs to internal pages to plain wikilinks (complex version) - https://phabricator.wikimedia.org/T93627#1142258 (10Whatamidoing-WMF) 3NEW [18:38:54] (03PS3) 10Bartosz Dziewoński: ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 [18:38:56] (03PS5) 10Bartosz Dziewoński: Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) [18:38:58] (03PS5) 10Bartosz Dziewoński: Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) [18:42:32] milimetric, hi [18:42:41] hi Krenair [18:42:45] just been trying to catch up with emails [18:42:53] are you sure you still have stuff going into 11319708? [18:42:57] I thought we already resolved this [18:43:11] I checked the last 24 hours, but I'll check more recent [18:43:18] I checked tin and we don't seem to have any references to that, just 11448630 [18:43:50] Krenair: select count(*) from Edit_11319708 where timestamp > '20150323150000'; [18:44:08] that gives me 230424 with editor = 'wikitext' [18:44:10] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5WMF-deploy-2015-03-25_(1.25wmf23): Setting a image to reflow after inserting prevents saving, offset out of bounds - https://phabricator.wikimedia.org/T93204#1142291 (10Etonkovidova) Verified the fix in betalabs. [18:44:13] and 251197 without [18:45:02] (03CR) 10jenkins-bot: [V: 04-1] Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński) [18:45:13] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [18:45:21] (03CR) 10jenkins-bot: [V: 04-1] Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński) [18:45:21] milimetric, https://phabricator.wikimedia.org/P422 [18:46:03] Oh I believe you Krenair :) [18:46:28] I wonder why some stuff is still going into the older version [18:46:28] But reality disagrees with us here [18:46:40] maybe the sync didn't work? I'll check a few servers [18:47:01] Krenair: what about the probably more urgent double toolbar bug? [18:47:21] was not able to reproduce last time I attempted [18:47:46] but that was a few days ago [18:47:48] Krenair: yeah, that makes sense, it's a race condition people are saying. I could help with that probably. I'll take a look and let you know [18:48:12] (03PS1) 10Pratikbsp: "Delete row"/"Delete column" messages now using the plural when multiple rows/columns are selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198779 [18:50:46] milimetric, did you see any particular patterns in whether the recent data for the old schema was mainly from a particular MW version, particular server, or whether it came from a server-side or client-side event? [18:51:59] Krenair: I'll group by MW version right now. I don't have server information (unless I do some seriously hardcore digging in Hadoop) and I thought all server-side stuff was going to the new schema from the start, so I never suspected that. [18:52:11] oh, it should be [18:52:19] good point [18:53:48] Krenair: all editor=wikitext events in the last 3 days are from 1.25wmf21 [18:54:12] (in Edit_11319708 of course) [18:54:26] and this is the breakdown for all events in general: [18:54:29] | 1.25wmf19 | 3 | [18:54:29] | 1.25wmf20 | 34 | [18:54:29] | 1.25wmf21 | 2741495 | [18:54:40] (last three days) [18:55:05] I mean last 2 days, sorry [18:55:23] and there are no VE edits for that schema? [18:58:39] (03PS4) 10Bartosz Dziewoński: ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 [18:58:41] (03PS6) 10Bartosz Dziewoński: Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) [18:58:43] (03PS6) 10Bartosz Dziewoński: Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) [19:00:19] Krenair: no, there are VE edits, about 10% of events are from VE [19:00:32] (these aren't edits, remember, they're just events) [19:00:39] just on the old schema, right? [19:01:29] (03CR) 10Esanders: [C: 04-1] ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [19:01:53] edsanders: can you have a look at https://gerrit.wikimedia.org/r/#/c/198779/ [19:04:06] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [19:04:26] Krenair: yes, just the old schema [19:04:27] (03CR) 10jenkins-bot: [V: 04-1] Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński) [19:04:29] (03CR) 10jenkins-bot: [V: 04-1] Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński) [19:04:38] ugh. that passed locally. [19:04:50] oh right, it's just karma sucking [19:18:29] (03CR) 10He7d3r: "What about the span.citation:target which is used on enwiki, ptwiki and possibly others? Why is it not being implemented?" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/196172 (https://phabricator.wikimedia.org/T10303) (owner: 10Gerrit Patch Uploader) [19:21:41] 10OOjs-UI: Indicator distorted in Firefox 31.5.0 - https://phabricator.wikimedia.org/T93636#1142457 (10Mattflaschen) 3NEW [19:21:57] (03CR) 10Esanders: [C: 04-1] "populateMenu only runs once, you'd need to hook this into an event that fires when the document selection changes." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198779 (owner: 10Pratikbsp) [19:28:56] (03PS1) 10Physikerwelt: Simplify fallback id generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/198801 [19:29:54] (03PS6) 10Physikerwelt: Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [19:30:05] (03CR) 10Physikerwelt: Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [19:30:15] (03PS5) 10Bartosz Dziewoński: ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 [19:30:32] 10VisualEditor: Citation does not get added when the autofill citation dialog is open in the background - https://phabricator.wikimedia.org/T93638#1142485 (10Ryasmeen) 3NEW [19:32:18] (03CR) 10Esanders: [C: 032] ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [19:32:24] i see that when TextInputWidget#isValid results in a non-true value it will set an 'invalid' flag, does anyone know where that flag is used? [19:32:52] uh oh, that code [19:33:07] yes we had some use for that somewhere [19:33:18] Krenair: :) [19:33:33] I think in VE's transclusion dialog [19:33:58] (03CR) 10Physikerwelt: [C: 032] Simplify fallback id generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/198801 (owner: 10Physikerwelt) [19:34:02] when you had a required field that you selected but then blurred without entering any text, it'd show up as red [19:34:35] Krenair: ok, makes sense. i'll poke around the transclusion stuff [19:35:08] https://gerrit.wikimedia.org/r/#/c/161613/ [19:35:17] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [19:36:50] Krenair: thanks [19:37:40] 10VisualEditor: Make all Event Logging instrumentation target the same Schema:Edit revision - https://phabricator.wikimedia.org/T93586#1142512 (10Krenair) It's not clear how this is happening at all: {P422} [19:38:43] (03Merged) 10jenkins-bot: Simplify fallback id generation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/198801 (owner: 10Physikerwelt) [19:43:35] 10VisualEditor: In Firefox, The highlighted border around the text box are not uniform sometimes - https://phabricator.wikimedia.org/T93641#1142536 (10Ryasmeen) 3NEW [19:47:13] 10VisualEditor: Clicking 'Insert paragraph' makes Save button active. - https://phabricator.wikimedia.org/T93643#1142555 (10Etonkovidova) 3NEW [19:49:51] (03PS1) 10Kmenger: LookupElement: Add description and mark private and protected methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/198806 [19:50:17] 10OOjs-UI, 5OOjs-UI-next-release, 5Patch-For-Review: Buttons explode in narrow containers - https://phabricator.wikimedia.org/T93552#1142562 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [19:52:31] 10Cite, 7Browser-Support-Internet-Explorer: IE9 does not show reference backlinks - https://phabricator.wikimedia.org/T93319#1142578 (10brion) It looks more like it's the 'display:none' in the print style, something's not right about it. [19:55:08] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Unnecessary s inserted into articles - https://phabricator.wikimedia.org/T71494#1142602 (10Mooeypoo) @NicoV, you're right. Apologies, I missed that. The languages shouldn't be added from the same language. [19:56:08] (03CR) 10Jforrester: "Real test failure?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [19:58:24] (03CR) 10Bartosz Dziewoński: "Works for me locally." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [20:00:30] (03CR) 10Mooeypoo: "But currently MWAlienExtensionNode doesn't seem to have GeneratedContentNode as a mixin at all, so I'm not sure if it's relevant to add it" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [20:03:00] (03CR) 10Jforrester: "> Works for me locally." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [20:05:56] (03PS1) 10Brion VIBBER: Workaround for IE 9 regression caused by @media print style [extensions/Cite] - 10https://gerrit.wikimedia.org/r/198811 (https://phabricator.wikimedia.org/T93319) [20:11:56] (03CR) 10Mooeypoo: "I just double-checked, and you're right. I missed the fact that ve.ce.GeneratedContentNode is already mixed in (it's not reflected in the " (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [20:12:32] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Newline between templates removed by VE - https://phabricator.wikimedia.org/T93129#1142669 (10Etonkovidova) Verified the fix in beta. [20:21:53] (03PS1) 10Ori.livneh: Emit activation entry/exit traces at the appropriate times [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198816 [20:26:28] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/Vector] - 10https://gerrit.wikimedia.org/r/198818 (owner: 10L10n-bot) [20:28:09] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1142758 (10Snhkicker) This is my First time looking at source code of Mediawiki but i never got the 2 toolbars error and so i... [20:28:57] hey folks, https://en.wikipedia.org/w/index.php?title=Moto_360&curid=42238402&diff=653207044&oldid=653203355 looks weird to me -- is VE putting in empty tags around things? [20:29:10] I didn't know you could even do that intentionally in VE. [20:29:36]