[00:02:13] (03CR) 10Esanders: "That commit is equally flawed. The text().trim().length === 0 check works, and that covers most cases, but .width() and .height() will alw" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [00:12:04] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1143692 (10GOIII) >>! In T93384#1143397, @Krenair wrote: > Has anyone been able to reproduce this since today's morning swat (... [00:35:41] Krinkle, how long can it take for RL cache to expire? [00:36:04] milimetric noticed that some people were still sending in events to older schema versions [00:36:25] which makes me think that they were using the old module version? I'm not 100% sure how EventLogging works [00:36:56] Krenair: If you're doing it right, it never expires. [00:37:12] But new changes should be live in 5-10 minutes [00:37:17] if not, it;ll never happen [00:37:21] ... huh. [00:37:44] the version= urls expire 30 days. [00:37:54] new changes result in new startup module, and different urls, so no cache to expire [00:39:01] so we have https://phabricator.wikimedia.org/T93586 [00:39:56] except we also had https://gerrit.wikimedia.org/r/#/c/197770/ and its backports, dependencies etc. [00:40:22] checking [00:41:29] The change to schema.* should roll out globally to all users within 10 minutes [00:42:22] http://bits.wikimedia.org/www.mediawiki.org/load.php?lang=en&debug=true&modules=schema.Edit&only=scripts [00:42:25] revision":11448630 [00:42:34] same on enwiki [00:43:02] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1143758 (10GOIII) Of Note: * In the odd instances when I do get a //single//, customized toolbar on en.wikipedia now, hitting... [00:43:09] Krenair: However startup module [00:43:11] http://bits.wikimedia.org/en.wikipedia.org/load.php?lang=en&debug=true&modules=startup&only=scripts [00:43:16] "schema.Edit", 1381493430, [00:43:30] >> new Date(1381493430* 1000) [00:43:30] Krinkle: (object) Fri Oct 11 2013 12:10:30 GMT+0000 (UTC) [00:43:36] That's cache epoch [00:43:41] it's failing to request the revision from metawiki [00:43:59] so it never salts the default timestamp with that of the relevant schema object [00:44:32] Looks like you may have to debug deeper, perhaps ori ? Not sure how RemoteSchema works internally or how to detect it [00:44:54] https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/master/includes/ResourceLoaderSchemaModule.php#L82-L91 [00:45:44] So the code is live and working if you forcifully request a server cache miss. But the module never detected itself changing and did not send a timestamp notification basically. [00:45:48] Krenair: :) [00:46:12] Urgh. [00:46:39] Thank you Krinkle. [00:48:36] 10VisualEditor, 10Analytics-EventLogging, 10MediaWiki-extensions-WikimediaEvents: Make all Event Logging instrumentation target the same Schema:Edit revision - https://phabricator.wikimedia.org/T93586#1143773 (10Krenair) @Krinkle has done some digging around on the ResourceLoader side of things. It appears t... [00:48:47] 10VisualEditor, 10Analytics-EventLogging, 10MediaWiki-extensions-WikimediaEvents: Make all Event Logging instrumentation target the same Schema:Edit revision - https://phabricator.wikimedia.org/T93586#1143776 (10Krenair) a:5Jdforrester-WMF>3None [00:50:28] 10VisualEditor: [Regression - wmf22] "Show options" overlaps seperation line - https://phabricator.wikimedia.org/T93361#1143785 (10Jdforrester-WMF) a:3TrevorParscal [00:52:44] 10VisualEditor, 10Analytics-EventLogging, 10MediaWiki-extensions-WikimediaEvents: Make all Event Logging instrumentation target the same Schema:Edit revision - https://phabricator.wikimedia.org/T93586#1143791 (10Krinkle) Fetching the startup module shows: ``` [ "schema.Edit", 138149343... [00:52:54] Krenair: Hm.. in writing up what I shared with you I realised something. ^ [00:53:52] wow... [00:55:03] (03CR) 10Esanders: [C: 04-1] ve.ce.Surface.test: Groundwork for testing non-linear selections (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [00:55:07] Krinkle, it should be simple enough to provide the rev_timestamp for the revision right? [00:55:53] * Krenair has not yet looked at the code [00:55:57] (03CR) 10Esanders: [C: 032] "Including qqq.json! This was annoying." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198746 (owner: 10Jforrester) [00:57:12] Krenair: It should be, yes. [00:57:20] But ori might have done it this way for a reason. [00:58:58] I don't know if we can Revision::newFromId( $this->schema->revision )->getTimestamp() there [00:59:17] (03PS6) 10Esanders: ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [01:00:09] (03CR) 10Esanders: [C: 032] ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [01:00:13] Krenair: It's from a different wiki [01:00:31] oh, damn [01:00:35] of course [01:00:35] https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/master/includes/RemoteSchema.php [01:00:38] hence remoteschema [01:00:47] It's using action=raw.. [01:00:58] (03CR) 10jenkins-bot: [V: 04-1] i18n/en.json: Convert from spaces to tabs, like all other files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198746 (owner: 10Jforrester) [01:01:04] Or at least it can be [01:01:09] I'm curious what the new api module exposes [01:01:49] Krenair: The new ApiJsonSchema doesn't expose it yet, but I assume it could. Using the code you wrote indeed. [01:01:51] https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/master/includes/ApiJsonSchema.php [01:02:13] But this is just cleanliness. A suspect. While it looks weird, this part might actually be working fine. [01:02:22] I'm not ceratin it's the cause. [01:02:52] Krenair: Which module is using the schema in this context? Did that one get an update too [01:03:04] Or was it a fixup for something that should've been in there already (e.g the schema was updated after the module using it) [01:04:49] so we use WikimediaEvents to pull it down [01:05:14] (03Merged) 10jenkins-bot: ve.ce.Surface.test: Groundwork for testing non-linear selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198643 (owner: 10Bartosz Dziewoński) [01:05:18] then ext.wikiEditor.init does this: https://gerrit.wikimedia.org/r/#/c/191221/17/modules/ext.wikiEditor.init.js [01:10:32] or did [01:10:45] it's slightly changed since that was made [01:11:01] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198746 (owner: 10Jforrester) [01:17:22] 10OOjs-UI, 10UI-Standardization, 7Design: Hover state on buttons - https://phabricator.wikimedia.org/T92049#1143832 (10Prtksxna) Do we have any alternative ideas? [01:18:44] (03Merged) 10jenkins-bot: i18n/en.json: Convert from spaces to tabs, like all other files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198746 (owner: 10Jforrester) [01:23:30] 10OOjs-UI, 10UI-Standardization, 7Design: ButtonGroupWidget use cases - https://phabricator.wikimedia.org/T88637#1143860 (10Prtksxna) > I don't think we need colored labels here, but let me know if you have a use case. I remember talking to @trevorparscal about this and he said that there is no use case for... [01:24:01] (03CR) 10Jforrester: "What was this meant to do? It totally broke the point of this appearing in the screen when editing sections…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198675 (owner: 10Esanders) [01:26:56] 10OOjs-UI, 10UI-Standardization, 7Design: Make buttonWidget (normal, progressive, constructive, destructive) borderless - https://phabricator.wikimedia.org/T88481#1143886 (10Prtksxna) a:5Prtksxna>3None [01:27:25] 10OOjs-UI, 10UI-Standardization, 7Design: Make buttonWidget (normal, progressive, constructive, destructive) borderless - https://phabricator.wikimedia.org/T88481#1012775 (10Prtksxna) @violetto Feel free to re-assign it once you've come to a resolution. [01:29:26] (03PS7) 10Jforrester: Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński) [01:29:28] (03PS7) 10Jforrester: Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński) [01:29:51] 10VisualEditor, 10WikiEditor, 10Analytics-EventLogging, 10MediaWiki-extensions-WikimediaEvents: Make all Event Logging instrumentation target the same Schema:Edit revision - https://phabricator.wikimedia.org/T93586#1143893 (10Mattflaschen) [01:29:53] (03CR) 10Jforrester: "PS7 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński) [01:30:10] (03CR) 10Jforrester: "PS7 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński) [01:37:26] 10OOjs-UI, 10UI-Standardization, 7Design: ButtonGroupWidget use cases - https://phabricator.wikimedia.org/T88637#1143898 (10Jaredzimmerman-WMF) @Prtksxna I don't think this needs to support Intentions… [01:39:51] 10OOjs-UI, 10UI-Standardization, 7Design: Make buttonWidget (normal, progressive, constructive, destructive) borderless - https://phabricator.wikimedia.org/T88481#1143899 (10Jaredzimmerman-WMF) @nirzar & @violetto we decided to make the default state quiet, you have to throw on a primary label to get a butto... [01:40:26] 10OOjs-UI, 10UI-Standardization, 7Design: Make buttonWidget (normal, progressive, constructive, destructive) borderless (quiet by default) - https://phabricator.wikimedia.org/T88481#1143901 (10Jaredzimmerman-WMF) [01:41:59] 10OOjs-UI, 10UI-Standardization, 7Design: Hover state on buttons - https://phabricator.wikimedia.org/T92049#1143902 (10Nirzar) @prtksxna [[ http://nirzar.github.io/prototypes/ui/quiet-buttons.html | Something similar to this. ]] Check hover states for normal buttons and quiet buttons where we change the bac... [01:56:46] 10VisualEditor: Nonfunctional slugs appear in reference context item - https://phabricator.wikimedia.org/T92572#1143916 (10Esanders) The problem is we are using CE HTML for a read-only view but CE HTML is designed for editing. Really we should be using DM HTML if it is performant enough. [02:02:19] 10VisualEditor, 10VisualEditor-MediaWiki: Extension which render inline tags are un-editable - https://phabricator.wikimedia.org/T93712#1143920 (10Esanders) 3NEW a:3Esanders [02:03:58] (03CR) 10Esanders: [C: 04-1] MenuSectionOptionWidget: Add description and example (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/199153 (owner: 10Kmenger) [02:05:49] (03CR) 10Esanders: [C: 032] ve.qunit: Use 'jscs:disable' comment rather than hacks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198650 (owner: 10Bartosz Dziewoński) [02:08:05] (03CR) 10Esanders: "A ve.Range can be used for any pair of offsets within in array, not even necessarily a 'text selection'." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198707 (owner: 10Divec) [02:22:07] Is it possible that if I am using varnish, and thus all connections appear to be coming from 127.0.0.1, that parsoid is getting confused and recursively connecting to itself in some kind of loop? [02:30:58] drobbins, I don't think parsoid cares where a request comes from really... [02:35:13] okay, removed varnish, still experiencing the problem. [02:35:40] (03CR) 10jenkins-bot: [V: 04-1] Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński) [02:35:59] (03CR) 10jenkins-bot: [V: 04-1] Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński) [02:37:22] this is maddening. [02:37:27] Is this a bug: http://en.wikipedia.beta.wmflabs.org/wiki/0.3686301685488156 [02:38:48] php-fpm dying maybe? [02:42:37] the workaround is to make the wiki public-readable. [02:42:48] otherwise, parsoid gets timeouts when trying to parse a page, and hitting the API. [02:42:59] cookie forwarding is enabled, but this doesn't appear to fix anything. [02:43:00] (03CR) 10Krinkle: [C: 032] ve.qunit: Use 'jscs:disable' comment rather than hacks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198650 (owner: 10Bartosz Dziewoński) [02:43:29] (03CR) 10Krinkle: [C: 032] ve.qunit: Use 'jscs:disable' comment rather than hacks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198650 (owner: 10Bartosz Dziewoński) [02:44:47] Any ideas why cookie forwarding would fail to work? [02:46:03] (03Merged) 10jenkins-bot: ve.qunit: Use 'jscs:disable' comment rather than hacks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198650 (owner: 10Bartosz Dziewoński) [03:11:15] 10VisualEditor: Media dialog broken by nearby two-part template - https://phabricator.wikimedia.org/T93714#1143961 (10Tbayer) 3NEW [03:12:45] how does one debug issues with server.js not being able to retrieve stuff from the API? I don't see useful debugging info. [03:16:06] (03PS5) 10Esanders: Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) [03:18:39] (03CR) 10jenkins-bot: [V: 04-1] Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) (owner: 10Esanders) [03:21:19] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) (owner: 10Esanders) [03:27:57] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1143977 (10santhosh) I have a WIP patch for a page selector widget at https://gerrit.wikimedia.org/r/#/c/195240/ - in case it helps. [03:46:11] Okay, I fixed it, no thanks to anyone here -- your wiki is wrong. The cookie forwarding is just broken. Checking for $_SERVER['REMOTE_ADDR'} and doing a manual workaround as per this page: [03:46:15] http://www.mediawiki.org/wiki/Talk:Parsoid#Running_Parsoid_on_a_.22private.22_wiki_-_AccessDeniedError [03:46:18] ... fixes it. [03:46:27] how about fixing your wiki docs to indicate that this feature is not working? [03:49:31] cookie forwarding is not working? [03:49:33] works for me on officewiki [03:56:02] drobbins, you definitely don't need to set up custom permissions just for the IP that parsoid runs from [04:04:21] yes, I definitely do. [04:04:25] it now functions properly. [04:04:48] the official instructions just do not work. [04:05:08] Possibly, they work under some installs, but definitely not mine. [04:05:40] Any idea how to get red links to link to the "create" rather than "create source" page by default? [04:09:15] what, other than hacking mw core? [04:13:18] Krenair: yes, I figured it would be a common request. [04:14:48] 10OOjs-UI, 7Design, 5Patch-For-Review: OOJS UI: OOJS redefines font-family to sans-serif in windows and widgets - https://phabricator.wikimedia.org/T92858#1143984 (10Esanders) What do you mean by 'correct'? [04:22:07] 10OOjs-UI, 7Design, 5Patch-For-Review: OOJS UI: OOJS redefines font-family to sans-serif in windows and widgets - https://phabricator.wikimedia.org/T92858#1143985 (10Nirzar) @Esanders The one that defines font names in order of preference and not only the typeface style. e.g. ``` font-family: "Helvetica... [04:34:47] (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/198859 (owner: 10L10n-bot) [04:34:49] (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/198858 (owner: 10L10n-bot) [04:34:50] (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/198858 (owner: 10L10n-bot) [04:38:16] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/198859 (owner: 10L10n-bot) [04:38:18] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/198858 (owner: 10L10n-bot) [04:38:19] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/198858 (owner: 10L10n-bot) [05:12:48] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1144237 (10Krenair) I still haven't been able to reproduce this bug myself. @GOIII, what happens when you try it in incognito/... [05:17:02] 10VisualEditor, 10MediaWiki-extensions-ProofreadPage, 10Wikimedia-Site-requests, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1144241 (10Ricordisamoa) >>! In T93525#1140648, @Jdforrester-WMF wrote: > Is this task asking for VisualEditor to be enabled for opt-in to... [06:42:08] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1144330 (10GOIII) You meant Internet Explorer 11's //InPrivate// mode? = same thing... 2x toolbars. @Krenair - Have you trie... [08:17:18] (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/198970 (owner: 10L10n-bot) [08:23:12] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/198970 (owner: 10L10n-bot) [08:27:31] (03PS1) 10Amire80: [BrowserTest] Capture the whole dropdown indicator in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199214 [08:32:50] (03PS1) 10Amire80: [BrowserTest] Add padding to the Headings dropdown screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199215 [08:36:46] (03PS1) 10Purodha: TemplateData: use consistent quotes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199217 [08:45:50] (03PS1) 10Amire80: [BrowserTest] Rename headings dropdown scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199222 [08:56:45] (03PS1) 10Purodha: TemplateData: add PLURAL to message Templatedata-modal-notice-import-numparams [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199224 [08:56:49] (03CR) 10jenkins-bot: [V: 04-1] TemplateData: add PLURAL to message Templatedata-modal-notice-import-numparams [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199224 (owner: 10Purodha) [09:03:42] (03PS2) 10Purodha: TemplateData: add PLURAL to message Templatedata-modal-notice-import-numparams [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199224 [09:03:45] (03CR) 10jenkins-bot: [V: 04-1] TemplateData: add PLURAL to message Templatedata-modal-notice-import-numparams [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199224 (owner: 10Purodha) [09:07:41] (03PS3) 10Purodha: TemplateData: add PLURAL to message Templatedata-modal-notice-import-numparams [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199224 [09:08:11] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Rename headings dropdown scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199222 (owner: 10Amire80) [09:09:36] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Capture the whole dropdown indicator in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199214 (owner: 10Amire80) [09:11:50] (03Merged) 10jenkins-bot: [BrowserTest] Capture the whole dropdown indicator in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199214 (owner: 10Amire80) [10:03:31] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to the Headings dropdown screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199215 (owner: 10Amire80) [10:06:42] (03Merged) 10jenkins-bot: [BrowserTest] Add padding to the Headings dropdown screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199215 (owner: 10Amire80) [10:06:44] (03CR) 10Nemo bis: [C: 031] TemplateData: use consistent quotes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199217 (owner: 10Purodha) [10:07:32] (03Merged) 10jenkins-bot: [BrowserTest] Rename headings dropdown scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199222 (owner: 10Amire80) [10:14:06] (03PS1) 10Amire80: [BrowserTest] Capture the whole formatting button in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199238 [10:23:53] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Magnifying glass icon - https://phabricator.wikimedia.org/T93699#1144575 (10Aklapper) I don't know what this task is about. Creating such an icon? [[ https://www.mediawiki.org/wiki/Phabricator/Project_manageme... [10:24:13] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Internal / external link split - https://phabricator.wikimedia.org/T93700#1144576 (10Aklapper) I don't know what this task is about. Split should be created? Fixed? [[ https://www.mediawiki.org/wiki/Phabricato... [10:35:02] (03PS2) 10Amire80: [BrowserTest] Capture the whole formatting button in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199238 [10:49:08] (03CR) 10Raimond Spekking: "Reported as T93734, T93733, T93732" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/198971 (owner: 10L10n-bot) [10:50:05] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Capture the whole formatting button in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199238 (owner: 10Amire80) [10:50:24] 10Cite, 7Browser-Support-Internet-Explorer: IE9 does not show reference backlinks - https://phabricator.wikimedia.org/T93319#1144649 (10Aklapper) p:5Triage>3Low [10:52:31] (03Merged) 10jenkins-bot: [BrowserTest] Capture the whole formatting button in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199238 (owner: 10Amire80) [10:56:11] 10VisualEditor, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, 5Patch-For-Review, 3Roadmap: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1144660 (10Pginer-WMF) Another aspect I noticed yesterday is that on the wikitext editor, the link to wikitext format opens in the... [11:04:17] (03PS1) 10Prtksxna: wip: set button height [oojs/ui] - 10https://gerrit.wikimedia.org/r/199246 [11:04:58] 10OOjs-UI: ButtonElements should be uniform height with any combination of label, icon and indicator - including none of them - https://phabricator.wikimedia.org/T93290#1144685 (10Prtksxna) Do we just want to set the button height? https://gerrit.wikimedia.org/r/199246 (adds test cases to demo page) [11:06:23] (03CR) 10jenkins-bot: [V: 04-1] wip: set button height [oojs/ui] - 10https://gerrit.wikimedia.org/r/199246 (owner: 10Prtksxna) [11:10:48] (03PS2) 10Prtksxna: wip: set button height [oojs/ui] - 10https://gerrit.wikimedia.org/r/199246 [11:29:52] (03PS1) 10Mobrovac: [BREAKING] Make Citoid use service-template-node and service-runner [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) [11:29:54] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING] Make Citoid use service-template-node and service-runner [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac) [11:41:23] (03PS2) 10Mobrovac: [BREAKING] Make Citoid use service-template-node and service-runner [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) [12:23:51] 10VisualEditor: Unwanted replacement of template - https://phabricator.wikimedia.org/T93739#1144780 (10Elitre) 3NEW [12:59:23] Niharika: As written here https://wiki.gnome.org/Outreachy , is it correct that we can edit our applications till april27 for outreachy [13:01:08] rits: That page refuses to load for me. Gimme a moment. [13:01:25] ok [13:02:44] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1144854 (10NiharikaKohli) [13:04:46] rits: It says Application deadline is March 24 right on top. Where does it say the applications are editable till April 27? [13:06:23] Niharika: cntrl+f 27 , in that line its written there [13:07:24] rits: Oh, it does. Yeah, seen. We'd rather that your application is complete by the time the mentor evaluates it. Which will happen sometime after today. [13:08:05] rits: So the earlier you're done with the changes, the better it is for you. You can keep making contributions and doing microtasks and mention in your application the ones you're working on. [13:08:49] Niharika: ok thank you :) [14:15:34] edsanders:why we can run populatemenu() in ve.ce.tablecontext.js only once? [14:16:10] 10Cite, 10MediaWiki-General-or-Unknown: Style for print is not applied at printable version - https://phabricator.wikimedia.org/T93746#1144963 (10Fomafix) 3NEW [14:26:44] 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1145001 (10mobrovac) [14:32:02] 10VisualEditor: Unwanted replacement of template - https://phabricator.wikimedia.org/T93739#1145010 (10Elitre) [14:34:56] (03PS3) 10Kmenger: MenuSectionOptionWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/199153 [14:47:59] 10VisualEditor: Exit/close the dialog box for inserting links - https://phabricator.wikimedia.org/T93749#1145034 (10Jopparn) 3NEW [14:48:33] 10VisualEditor: Exit/close the dialog box for inserting links - https://phabricator.wikimedia.org/T93749#1145041 (10Jopparn) [15:05:16] (03PS14) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 [15:16:36] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Newsletter Extension Project - https://phabricator.wikimedia.org/T93752#1145158 (10Ankita-ks) 3NEW a:3Ankita-ks [15:17:13] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145171 (10Ankita-ks) [15:21:10] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145178 (10Ankita-ks) [15:41:08] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Internal links [[Xxx]] replaced by [[./Xxxx]] - https://phabricator.wikimedia.org/T93754#1145203 (10NicoV) 3NEW [15:43:51] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Span tags (some with href) added to otherwise unmodified sentences - https://phabricator.wikimedia.org/T93755#1145215 (10NicoV) 3NEW [15:45:56] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Existing == Title == replaced by

Title

- https://phabricator.wikimedia.org/T93756#1145228 (10NicoV) 3NEW [15:46:33] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145243 (10Ankita-ks) [15:47:16] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Existing external links replaced by forbidden tags - https://phabricator.wikimedia.org/T93758#1145244 (10NicoV) 3NEW [15:49:09] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Existing DEFAULTSORT replaced by incorrectly formatted Category - https://phabricator.wikimedia.org/T93759#1145254 (10NicoV) 3NEW [15:53:07] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Existing DEFAULTSORT replaced by incorrectly formatted Category - https://phabricator.wikimedia.org/T93759#1145265 (10NicoV) The edit given in example is the same for 5 Phabricator tasks: T93754, T93755, T93756, T93758 and T93759 [15:54:12] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145270 (10Ankita-ks) [15:54:53] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145158 (10Ankita-ks) [15:56:26] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145281 (10Ankita-ks) [16:03:56] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1145307 (10NiharikaKohli) Hello! The IRC meeting tomorrow has been shifted to #wikimedia-ect channel. Looking forward to seeing you there... [16:07:23] aharoni : Could you review my proposal for the project? And also let me know if there are other tasks available? [16:15:35] mooeypoo , TrevorParscal : Could you take a look at my proposal and give me some feedback as to what changes could be required? i don't know if i am supposed to ask or not. :| [16:19:40] hello i wanted to discuss about the project graph editing in visual editor as mooeypoo is away, the end deliverables is not clear yet as discussed in the comments, [16:21:15] i am working on the microtask, but as per the discussions for the solutions it is not completed yet [16:21:48] ankita-ks: what's it titled? [16:22:01] TrevorParscal : https://phabricator.wikimedia.org/T93752 [16:22:03] edsanders,James_F: ^ [16:27:41] ankita-ks: usually when people say "spiral" it's negative, as in "downward spiral", which coincidentally is a NiN (Nine-inch Nails) record, which itself has quite a negative tone to it as well [16:28:01] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145411 (10Ankita-ks) [16:28:12] I would say "sprial into" could be "grow into" without losing the rest of the sentence and be clearer [16:28:24] Ah..okay. My bad :) [16:29:06] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145158 (10Ankita-ks) [16:31:30] ankita-ks: also, the description of "How am I going to do it?" is most certainly going to change, but it's really not important to work that out now [16:31:50] hmm..should I remove that? [16:32:08] Do you think it's wrong? [16:32:13] ^ TrevorParscal [16:32:51] ankita-ks: so, we do a LOT of things to figure out what's been inserted, onDocumentKeyDown is not going to tell you anything [16:32:56] but, again, it's fine [16:33:13] you might end up stalking transactions from onTransact or something - it's all really not important at this point [16:33:14] hmm..interesting [16:33:23] your general approach is "listen to changes on the document" [16:33:32] which, you may want to just write that way [16:33:42] That could be very naive on my part..I inserted a lot of console.logs in that function. And it seemed to say what was inserted. [16:33:43] more generally, that way it doesn't catch attention [16:33:49] it's fine [16:33:52] okay [16:33:57] So editing that bit. [16:34:13] the truth is, if you can avoid getting too involved in the SurfaceObserver, you will sleep better at night [16:34:29] rits_, hi [16:34:30] divec knows the haunted wasteland I speak of all too well [16:34:33] okay :P [16:36:16] I've also been told that it's "Wikidata", not "WikiData" or "Wiki-data" [16:36:57] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145422 (10Ankita-ks) [16:37:30] TrevorParscal : noted. I have changed the description you mentioned above. Check that as well. :) [16:37:33] ankita-ks: otherwise, looks great man [16:38:02] ankita-ks: looks great [16:38:33] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145158 (10Ankita-ks) [16:38:41] TrevorParscal : changed that too. thank you very much. [16:38:59] I think I am spamming the channel with all the changes. :P [16:39:10] Appreciate the help! :) [16:39:23] ankita-ks: Every single change to the proposal sends a notification to a lot of people. So try to make them all in same go. :) [16:40:17] Niharika : I am sorry, i will try and take care of that. I have gotten a little jittery at this moment. >_> [16:40:31] ankita-ks: No worries. [16:40:34] ankita-ks: I wouldn't worry about it much, if we don't like the level of span in the channel we should have it sent somewhere else [16:40:39] edsanders: hello sorry for the late reply [16:41:11] TrevorParscal : thank you bearing with noobs. :| [16:41:31] edsanders: i wanted to discuss about the graph editing project https://phabricator.wikimedia.org/T89287 [16:43:10] ankita-ks: no worries, we're happy to have you 'round [16:43:37] edsanders: ^ [16:43:44] sure [16:44:50] as the deliverables are not clear yet abu the real time rendering [16:44:59] about* [16:46:06] edsanders: ^ [16:46:28] 10VisualEditor, 10VisualEditor-EditingTools: No Exit/close button for "Insert Links" dialog box - https://phabricator.wikimedia.org/T93749#1145479 (10Aklapper) [16:49:08] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: First paragraph for news articles at fr.news ends up inside Template:Date - https://phabricator.wikimedia.org/T90921#1145506 (10ssastry) p:5Triage>3Normal [16:51:28] I would think having it render the graph after making a set of JSON changes and pressing save would be a good start [16:52:21] rendering as you type would be an improvement [16:52:23] okay so for the start no real time rendering as mentioned in the description right, [16:52:48] divec: are you working on this? https://phabricator.wikimedia.org/T89352 [16:54:02] edsanders: ok [16:54:51] (03CR) 10Mvolz: [C: 04-1] [BREAKING] Make Citoid use service-template-node and service-runner (035 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac) [16:59:58] James_F: VE just mangled my edit when I was editing a table. :-( [17:00:00] James_F: https://www.mediawiki.org/w/index.php?title=Wikimedia_Engineering/2014-15_Goals&diff=1496333&oldid=1496332 [17:00:01] (03CR) 10Mvolz: "Hmm, works fine when running with mocha, it looks like npm test doesn't respect mocha.opts" [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac) [17:00:09] mvolz: hello i am applying for outreachy and GSoC under graph editing in visual editor, if you could discuss the idea as for the initial phase i have sorted out the timeline as to keeping up to edit the graph,is my approach correct? thanks [17:00:39] Sure, do you have a draft of it? [17:01:00] rits_: [17:01:31] no i havent drafted all the points yet [17:01:42] mvolz: ^ [17:01:55] i thought to discuss it first thats why [17:03:10] Ok :) Shoot. [17:04:28] (03CR) 10Mvolz: [BREAKING] Make Citoid use service-template-node and service-runner (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac) [17:04:44] as for the graph editing json data parsed from parsoid is saved having a id [17:05:32] it has to be displayed on the visual editor first [17:06:40] then the edit options has to be added so that when the editing is done the data will be send again to be rendered [17:06:54] mvolz: is my approach correct [17:08:57] yup, that sounds basically correct. Have you tried looking at the TemplateData editor that mooeypoo mentioned in the phabricator thread? [17:09:17] If you try using that it will give you a pretty clear idea what it is happening, at least on a GUI level [17:10:31] mvolz: yes i worked on that, i have got a basic idea of it actually [17:11:13] mvolz: the icons used for the edit in case of template is not cler to me [17:11:21] if you do add ?veaction=edit&debug=true to a wiki page, you'll see more things that show what's going on underneath [17:11:22] clear* [17:11:40] debug will show you data model stuff. [17:12:16] oh the json data you mean thats coming from the parsoid [17:13:13] e.g. 'source' -> {SyntaxHighlight extension} [17:13:29] parser->setHook is a terrible API [17:14:45] (03PS15) 10SuchetaG: [WIP] Link Inspector Redesign [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 [17:15:05] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Visual Editor save dialog hangs, causing data loss - https://phabricator.wikimedia.org/T91949#1145576 (10matmarex) {T91158} was fixed just before this bug was filed. If no one runs into this for a few more weeks, I think it's safe to assume it was the same issue. [17:15:43] rits_: the data model is actually what VE is using to represent what you see in VE [17:16:33] so higher level than just what you got back from parsoid [17:16:33] 10OOjs-UI, 7Design, 5Patch-For-Review: OOJS UI: OOJS redefines font-family to sans-serif in windows and widgets - https://phabricator.wikimedia.org/T92858#1145588 (10Jorm) MediaWiki should be font agnostic. Defining fonts other than "sans-serif" or "serif" in the base code is probably not correct. [17:17:00] it will probably take a little bit before that makes sense :P [17:17:38] mvolz: oh ok :D [17:18:06] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Visual Editor save dialog hangs, causing data loss - https://phabricator.wikimedia.org/T91949#1145591 (10Jdforrester-WMF) Good point; let's merge them for now. [17:18:14] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Visual Editor save dialog hangs, causing data loss - https://phabricator.wikimedia.org/T91949#1145592 (10Jdforrester-WMF) [17:18:15] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-11_(1.25wmf21): [Regression] VisualEditor no long able to rescue itself from badtoken error state on save - https://phabricator.wikimedia.org/T91158#1145593 (10Jdforrester-WMF) [17:18:23] 10VisualEditor: Visual Editor save dialog hangs, causing data loss - https://phabricator.wikimedia.org/T91949#1099444 (10Jdforrester-WMF) [17:18:34] but the data model will be just for the representing the data as the content editable will help to deploy editing options in it [17:19:36] mvolz: is this correct? [17:20:10] (03CR) 10Jforrester: [C: 032] TemplateData: use consistent quotes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199217 (owner: 10Purodha) [17:20:20] rits_, CE is the view [17:20:25] driven from the model [17:20:42] rits_, you should also consider validation [17:21:02] obviously you can validate the JSON just by wrapping JSON.parse in a try/catch [17:21:28] but you also want to say something meaningful if it's valid JSON but invalid Vega data [17:21:41] from what I can see Vega doesn't throw sensible errors on parse [17:21:53] edsanders: alright [17:21:58] you may even think about upstream patches for that [17:22:28] then for that the try catch would do the help but how to handle invalid vega data [17:22:32] at the very least you can wrap the Vega render call in try/catch, but if you can say something more useful than "there's something wrong with your data" that would be good [17:22:54] edsanders: sorry you may even think about upstream patches for that? [17:23:21] oh ok got it [17:23:23] rits_, eventually, depends how far you get [17:24:16] rits_, the alternative is if you built a JSON editor than restricted your input to the extent that it was impossible to write invalid data [17:24:27] that would certainly be harder [17:25:05] yes, certainly it will be [17:26:07] handling through the message will do the good [17:26:33] edsanders: would it be fine? [17:27:26] 10OOjs-UI, 7Design, 5Patch-For-Review: OOJS UI: OOJS redefines font-family to sans-serif in windows and widgets - https://phabricator.wikimedia.org/T92858#1145613 (10Esanders) @Nirzar I understand, but why is that correct? [17:30:40] (03Merged) 10jenkins-bot: TemplateData: use consistent quotes [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199217 (owner: 10Purodha) [17:31:04] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1145619 (10Ankita-ks) [17:32:01] rits_, I don't understand [17:33:10] i mean for handling the invalid vega data a message popup would be fine? [17:34:41] 10OOjs-UI, 10VisualEditor, 10VisualEditor-EditingTools, 7Regression, and 2 others: [Regression pre-wmf22] Template dialog has footer line crossing through button - https://phabricator.wikimedia.org/T92986#1145628 (10Jdforrester-WMF) [17:34:48] 10OOjs-UI, 10VisualEditor, 10VisualEditor-EditingTools, 7Regression, and 2 others: [Regression pre-wmf22] Template dialog has footer line crossing through button - https://phabricator.wikimedia.org/T92986#1125952 (10Jdforrester-WMF) [17:35:06] 10OOjs-UI, 10VisualEditor, 10VisualEditor-EditingTools, 7Regression, and 2 others: [Regression pre-wmf22] Template dialog has footer line crossing through button - https://phabricator.wikimedia.org/T92986#1125952 (10Jdforrester-WMF) 5Open>3Resolved [17:39:12] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Trim selections with whitespace on the end when creating a link - https://phabricator.wikimedia.org/T92896#1145712 (10matmarex) We already trim whitespace from the start and end of selection when creating a new link annotation (and any other kind of annotation... [17:40:24] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Trim selections with -wrapped whitespace on the start/end when creating a link - https://phabricator.wikimedia.org/T92896#1145767 (10Jdforrester-WMF) [17:41:43] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Trim selections with -wrapped whitespace on the start/end when creating a link - https://phabricator.wikimedia.org/T92896#1123030 (10Jdforrester-WMF) Given these don't occur in the English Wikipedia, I'll drop this from Q3 goals and move to Q4. [17:41:56] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Trim selections with -wrapped whitespace on the start/end when creating a link - https://phabricator.wikimedia.org/T92896#1145778 (10Jdforrester-WMF) [17:44:58] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Trim selections with -wrapped whitespace on the start/end when creating a link - https://phabricator.wikimedia.org/T92896#1145792 (10matmarex) Affects spaces preceding `?`, `:`, `;`, `!` and `%`, and around guillemet quotes, which are all indeed ra... [18:01:45] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Magnifying glass icon - https://phabricator.wikimedia.org/T93699#1145921 (10matmarex) We have the 'search' icon in OOjs UI: {F103642,size=full,layout=inline} [18:02:37] 10Citoid: [Regression] Citoid won't look up PMIDs or PMCIDs - https://phabricator.wikimedia.org/T93335#1145932 (10Elitre) Marielle, I'm talking about PMIDs which are correctly accepted by "Cite journal". See https://www.ncbi.nlm.nih.gov/pubmed/15680349 (in the PubMed database, not in the PMC one), which is used... [18:10:43] 10VisualEditor, 10VisualEditor-CopyPaste: Retain ref tags (formatting) when copying from Read (aka View) mode of an encyclopedia article. - https://phabricator.wikimedia.org/T93780#1145987 (10Whatamidoing-WMF) 3NEW [18:16:26] 10Citoid: [Regression] Citoid won't look up PMIDs or PMCIDs - https://phabricator.wikimedia.org/T93335#1146000 (10Elitre) Also, [[ https://it.wikipedia.org/w/index.php?title=Utente%3AElitre_%28WMF%29%2FSandbox_VE&diff=71588043&oldid=71510964 | here ]] I added the [[ http://www.ncbi.nlm.nih.gov/pmc/articles/PMC2... [18:25:26] 10Citoid: [Regression] Citoid won't look up PMIDs or PMCIDs - https://phabricator.wikimedia.org/T93335#1146042 (10Elitre) 5Resolved>3Open [18:27:46] 10OOjs-UI, 7Design, 5Patch-For-Review: OOJS UI: OOJS redefines font-family to sans-serif in windows and widgets - https://phabricator.wikimedia.org/T92858#1146045 (10Nirzar) @Esanders & @Jorm I should have been more clear about the description, what i meant was consistent font stack. OOJS UI (and VE) uses He... [18:29:30] 10OOjs-UI, 7Design, 5Patch-For-Review: OOJS UI: OOJS redefines font-family to sans-serif in windows and widgets - https://phabricator.wikimedia.org/T92858#1146047 (10Nirzar) [18:31:53] (03CR) 10Mobrovac: "@mvolz, to run all of the tests, use:" (034 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac) [18:32:44] (03PS3) 10Mobrovac: [BREAKING] Make Citoid use service-template-node and service-runner [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) [18:34:46] 10MediaWiki-Page-editing, 6Community-Liaison: Enable microsurveys for long-term tracking of editing experience - https://phabricator.wikimedia.org/T89970#1146069 (10Whatamidoing-WMF) If it's possible to catch people who navigate away, then that's great. However, I believe that most people cancel by closing th... [18:42:35] 10Citoid: DOI in Citoid returns "Cite web" template - https://phabricator.wikimedia.org/T93785#1146107 (10Elitre) 3NEW [18:45:01] 10VisualEditor, 6Editing, 6Engineering-Community, 6Language-Engineering, and 3 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1146117 (10Ankita-ks) [18:45:38] (03CR) 10Mvolz: "@mobrovac, yes, and npm test should run jshint on all the .js files, not just test/index.js :)" [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac) [18:52:16] (03CR) 10Mobrovac: "@mvolz, it does. Try writing a stupidity in any of the js files outside of test/ , and you'll see the test failing." [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac) [18:53:00] 10OOjs-UI, 10UI-Standardization, 7Design: Make buttonWidget (normal, progressive, constructive, destructive) borderless (quiet by default) - https://phabricator.wikimedia.org/T88481#1146146 (10violetto) For the record, there are a few blocking tasks by @Nirzar and @KHammerstein to get this resolved. cc @Jare... [18:58:14] (03PS1) 10Legoktm: jenkins job validation, do not submit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199309 [18:59:02] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Outreachy and GSoC 2015 Proposal for Graph editing in Visual Editor - https://phabricator.wikimedia.org/T93788#1146156 (10Rits) 3NEW a:3Rits [18:59:57] (03CR) 10jenkins-bot: [V: 04-1] jenkins job validation, do not submit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199309 (owner: 10Legoktm) [19:00:34] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199309 (owner: 10Legoktm) [19:08:43] 10Citoid: Add TESTS - https://phabricator.wikimedia.org/T91168#1146173 (10mobrovac) [19:10:21] (03PS5) 10Physikerwelt: Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) [19:13:58] 10VisualEditor, 5Patch-For-Review: MWExtensionInspector should inherit from NodeInspector - https://phabricator.wikimedia.org/T93592#1146210 (10Physikerwelt) I guess we should test the changes to the Math extension after the VisualEditor changes got merged. Is there any way to make this change non breaking and... [19:58:57] 10Citoid: Citoid should not be language-dependent - https://phabricator.wikimedia.org/T93800#1146361 (10Whatamidoing-WMF) 3NEW [20:00:53] 10Citoid: Citoid request for MediaWiki:Citoid-template-type-map.json should be in the content language, not the user language - https://phabricator.wikimedia.org/T93800#1146389 (10Jdforrester-WMF) p:5Triage>3High a:3Mvolz [20:01:14] (03CR) 10TheDJ: "I'd do the modules different, to make them added conditionally." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:05:53] 10VisualEditor, 6Editing, 6Engineering-Community, 10Possible-Tech-Projects, and 2 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1146415 (10Nemo_bis) [20:10:59] hey, I’m trying to make VE work in the Blueprint skin. I added Blueprint to the list of supported skins, and now it’s doing some funny things when I click “Edit" [20:11:56] 1. It doesn’t correctly remove the content before adding the editable content [20:12:01] 2. It seems to take the wrong content? [20:12:11] What assumptions does VE make about skins? [20:13:23] werdna: That the skin is Vector. [20:13:39] \o/ [20:14:10] werdna: Well, that it's Monobook or Monobook 2 aka Vector or Monobook 3 aka Apex. [20:14:15] But it comes to the same thing. [20:14:58] right [20:15:42] Skins skins skins [20:15:45] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1146440 (10He7d3r) I still see two toolbars consistently at https://meta.wikimedia.org/w/index.php?title=User_talk:He7d3r&acti... [20:15:59] So anybody know which element it is failing to find to remove the content? [20:16:49] werdna: #mw-content? [20:16:58] * James_F hazards random guesswork. [20:17:14] Shouldn't it be #content and #mw-content-text [20:18:06] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1146451 (10He7d3r) [20:18:07] 10MediaWiki-Page-editing: The enhanced editing toolbar causes focus to be removed from the edit box. - https://phabricator.wikimedia.org/T30947#1146452 (10He7d3r) [20:20:59] werdna: I'm really not the expert, sorry. [20:23:41] (03PS6) 10Physikerwelt: Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) [20:29:12] (03CR) 10Physikerwelt: "@TheDJ: I can understand you are skeptical to render arbitrary stuff in search results. However, math is supposed to be integral part of t" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:30:22] 10OOjs-UI, 10OOjs-UI-0.9.1, 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Pop-up "You are not logged in." warning cannot be closed via the "X" on touch devices - https://phabricator.wikimedia.org/T91757#1146462 (10Etonkovidova) Verified the fix on mini iPad with i... [20:32:38] 10OOjs-UI, 10OOjs-UI-0.9.1, 5WMF-deploy-2015-03-18_(1.25wmf22): Toolbar menus don't disappear when another menu is opened on touch devices - https://phabricator.wikimedia.org/T87818#1146468 (10Etonkovidova) Checked the fix along with T91757 - the issue has been fixed. [20:44:12] edsanders: I'm looking at https://phabricator.wikimedia.org/T93081 and going back through my IRC logs, but I can't find what you said about it. [21:06:31] 10Citoid: DOI lookup failure should return 520 but instead returns a default website - https://phabricator.wikimedia.org/T93785#1146542 (10Jdforrester-WMF) p:5Triage>3High [21:09:06] James_F: figured out it was #bodyContent, but still getting random pages :p [21:09:31] werdna: Hmm. [21:13:34] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, 7Regression: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1146562 (10Krenair) Thanks @He7d3r, I was able to reproduce it on production wikis (and beta) with that. Not localhost yet. [21:16:58] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#1146575 (10Elitre) FYI this was brought up again by a user [[ https://phabricator.wikimedia.org/F1... [21:21:55] 10MediaWiki-Page-editing, 7JavaScript, 5Patch-For-Review: LivePreview should give feedback when failing - https://phabricator.wikimedia.org/T90490#1146605 (10TheDJ) I've chosen to go with errorbox. it seemed the most simple solution, that would work the most reliable. [21:24:50] (03PS1) 10Alex Monk: Try to unbreak WikiEditor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199387 (https://phabricator.wikimedia.org/T93384) [21:30:19] (03CR) 10jenkins-bot: [V: 04-1] Try to unbreak WikiEditor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199387 (https://phabricator.wikimedia.org/T93384) (owner: 10Alex Monk) [21:34:07] (03PS2) 10Alex Monk: Try to unbreak WikiEditor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199387 (https://phabricator.wikimedia.org/T93384) [21:49:33] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers: Research incrementally building the CE tree/DOM - https://phabricator.wikimedia.org/T90376#1146673 (10TrevorParscal) a:5ori>3None [21:50:09] 10MediaWiki-ResourceLoader, 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, and 2 others: Pre-fetch VisualEditor modules to improve speed for end-users - https://phabricator.wikimedia.org/T59952#1146676 (10TrevorParscal) a:5ori>3None [21:57:53] James_F: 2nd stand up? [21:58:00] Krinkle: Yup. [22:03:54] 10VisualEditor, 10VisualEditor-MediaWiki-References, 3VisualEditor 2014/15 Q3 blockers: Come up with a better way to auto-label references - https://phabricator.wikimedia.org/T92432#1146698 (10TrevorParscal) The ideal system would be to use TemplateData to specify which parameters should be used to generate... [22:05:00] 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers: Come up with a better way to auto-label references - https://phabricator.wikimedia.org/T92432#1146702 (10TrevorParscal) [22:09:50] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: Measure how often Parsoid cache misses happen, and what load performance is like in this case - https://phabricator.wikimedia.org/T86733#1146735 (10Jdforrester-WMF) 5Open>3Resolved [22:13:20] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1146747 (10Jdforrester-WMF) a:3Catrope [22:13:28] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Unnecessary s inserted into articles - https://phabricator.wikimedia.org/T71494#1146748 (10Jdforrester-WMF) a:3Catrope [22:13:34] 10VisualEditor, 10VisualEditor-DataModel, 3VisualEditor 2014/15 Q3 blockers: Category moved into table (and content normalised) - https://phabricator.wikimedia.org/T91913#1146749 (10Jdforrester-WMF) a:3Catrope [22:15:16] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Existing == Title == replaced by

Title

- https://phabricator.wikimedia.org/T93756#1146764 (10Jdforrester-WMF) [22:15:31] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Existing external links replaced by forbidden tags - https://phabricator.wikimedia.org/T93758#1146766 (10Jdforrester-WMF) [22:15:33] 10VisualEditor, 10VisualEditor-EditingTools: Unnecessary scrollbar on VE comment preview - https://phabricator.wikimedia.org/T93816#1146768 (10TheDJ) 3NEW [22:15:40] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Span tags (some with href) added to otherwise unmodified sentences - https://phabricator.wikimedia.org/T93755#1146776 (10Jdforrester-WMF) [22:15:48] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Internal links [[Xxx]] replaced by [[./Xxxx]] - https://phabricator.wikimedia.org/T93754#1146780 (10Jdforrester-WMF) [22:16:06] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Existing DEFAULTSORT replaced by incorrectly formatted Category - https://phabricator.wikimedia.org/T93759#1146783 (10Jdforrester-WMF) [22:16:52] 10VisualEditor, 10VisualEditor-EditingTools: Unnecessary scrollbar on VE comment preview - https://phabricator.wikimedia.org/T93816#1146787 (10Etonkovidova) Duplicate to https://phabricator.wikimedia.org/T92450 [22:17:43] 10VisualEditor, 10VisualEditor-DataModel, 3VisualEditor 2014/15 Q3 blockers: Category moved into table (and content normalised) - https://phabricator.wikimedia.org/T91913#1146792 (10Jdforrester-WMF) [22:19:13] 10VisualEditor, 10VisualEditor-EditingTools: Unnecessary scrollbar on VE comment preview - https://phabricator.wikimedia.org/T93816#1146805 (10Etonkovidova) 5Open>3Resolved [22:19:36] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Comment body in context showing a scrollbar - https://phabricator.wikimedia.org/T92450#1146808 (10Etonkovidova) Verified in betalabs. [22:20:12] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Unnecessary s inserted into articles - https://phabricator.wikimedia.org/T71494#1146809 (10gpaumier) Does this ticket cover all insertions of span tags? Is is useful to provide more diffs? (for example https://fr.wikipedia.org/w/index.php?diff=113225218 ) [22:22:30] (03CR) 10Alex Monk: [WIP] Send requests to RESTbase directly when so configured (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) (owner: 10Catrope) [22:23:16] Krenair: so, https://gerrit.wikimedia.org/r/#/c/197357/ [22:23:41] do you have a plan, or do you need help answering some of the unresolved questions? [22:24:40] 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design: VisualEditor: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1146844 (10gpaumier) [22:24:46] wanted comment on where to put that json file, I just left it at modules/ve-mw [22:25:21] I should probably ask i18n for help with copying in the wikieditor messages properly, if possible [22:26:13] right now I just load the WikiEditor ones right in and they're marked "// temp, do not commit " [22:27:15] I should probably note that some of the wikieditor data was more complex than we could handle in VE's system [22:27:46] so only the single characters were included [22:28:11] which is the majority, I think [22:31:18] 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design: VisualEditor: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1146895 (10gpaumier) The nowikied space also persists if a user then removes the newline. See https://en.wikipedia.org/w/index.... [22:34:32] 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design: VisualEditor: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1146900 (10gpaumier) Are there any valid use cases for keeping those white spaces at the beginning of a paragraph? Otherwise I... [22:34:54] 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design: VisualEditor: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1146902 (10gpaumier) Are there any valid use cases for keeping those white spaces at the beginning of a paragraph? Otherwise I... [22:36:17] 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design, 3VisualEditor 2014/15 Q3 blockers: VisualEditor: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1146906 (10gpaumier) [22:42:20] (03CR) 10Alex Monk: [C: 04-1] "So close to working." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) (owner: 10Catrope) [22:44:08] 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design, 3VisualEditor 2014/15 Q3 blockers: Remove nowikied spaces at the beginning of a paragraph unless the user manually inserted them - https://phabricator.wikimedia.org/T68628#1146918 (10gpaumier) [22:50:58] (03PS15) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) [22:51:27] 10MediaWiki-Page-editing, 7JavaScript, 5Patch-For-Review: LivePreview should not replace title message with displaytitle value in firstHeading - https://phabricator.wikimedia.org/T85784#1146946 (10TheDJ) @Fomafix I've merged the one, so you can now amend the other to that solution. [22:51:49] (03PS47) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [23:11:12] 10VisualEditor, 6Collaboration-Team, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, and 3 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1147045 (10DannyH) [23:12:04] 10VisualEditor, 6Collaboration-Team, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1147050 (10DannyH) [23:13:48] 10VisualEditor, 10VisualEditor-DataModel, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Cutting (removing) last section on the page leaves blank section heading == == - https://phabricator.wikimedia.org/T61647#1147054 (10Etonkovidova) Verified in beta. [23:14:03] 10VisualEditor, 10VisualEditor-DataModel, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Cutting (removing) last section on the page leaves blank section heading == == - https://phabricator.wikimedia.org/T61647#1147055 (10Etonkovidova) [23:14:42] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 7Verified-in-Phase0, 5WMF-deploy-2015-03-25_(1.25wmf23): Setting a image to reflow after inserting prevents saving, offset out of bounds - https://phabricator.wikimedia.org/T93204#1147056 (10Etonkovidova) [23:18:16] 10VisualEditor, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Comment body in context showing a scrollbar - https://phabricator.wikimedia.org/T92450#1147076 (10Etonkovidova) [23:22:25] 10MediaWiki-Page-editing: of editing page doesn't respect DISPLAYTITLE - https://phabricator.wikimedia.org/T51667#1147101 (10Krenair) See also {T88117} [23:34:50] <wikibugs> 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-General-or-Unknown, 3Collaboration-Team-Sprint-S-2015-03-25: Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1147109 (10Mattflaschen) [23:44:35] <wikibugs> 10Cite, 10MediaWiki-General-or-Unknown: Style for print is not applied at printable version - https://phabricator.wikimedia.org/T93746#1147155 (10Se4598) related: {T93319} around the same lines of CSS. [23:49:11] <wikibugs> 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: allow parameter per line in inserted templates - https://phabricator.wikimedia.org/T71682#1147184 (10Tbayer) It seems that VE users still get [[https://fi.wikipedia.org/wiki/Keskustelu_k%C3%A4ytt%C3%A4j%C3%A4st%C3%A4:Kuriuss#Infolaatikot | yelled at]] for...