[00:02:39] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1147226 (10Krenair) a:5Krenair>3None
[00:09:19] <wikibugs>	 10MediaWiki-Page-editing, 6Editing, 5Patch-For-Review: Update HTML title with displaytitle on live preview - https://phabricator.wikimedia.org/T88117#1147243 (10Krenair) So we now do this on preview, but it's a bit strange because we don't do it on initial page load. See T51667 (and please feel free to claim...
[00:09:56] <wikibugs>	 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1147248 (10Krenair)
[00:09:57] <wikibugs>	 10MediaWiki-Page-editing, 6Editing: Update HTML title with displaytitle on live preview - https://phabricator.wikimedia.org/T88117#1147245 (10Krenair) 5Open>3Resolved
[00:14:51] <Krenair>	 hm
[00:15:07] <Krenair>	 I think CodeEditor's find tool is... broken on RTL
[00:15:37] <Krenair>	 divec, https://ar.wikipedia.org/w/index.php?title=%D9%85%D9%8A%D8%AF%D9%8A%D8%A7%D9%88%D9%8A%D9%83%D9%8A:Gadget-Extra-Edittools.js&action=edit - search for 'http:'
[00:15:40] <Krenair>	 that's not right, is it?
[00:15:51] <ankita-ks>	 TrevorParscal : what do you think would be a good way to extract text from VisualEditor? 
[00:17:03] <Krenair>	 or is rtl broken in a different way there?
[02:56:25] <grrrit-wm>	 (03PS1) 10Memeht: Strip X-Parsoid Performance Headers from Visual Editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199562 
[03:00:30] <grrrit-wm>	 (03CR) 10Alex Monk: Strip X-Parsoid Performance Headers from Visual Editor (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199562 (owner: 10Memeht)
[03:13:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Emit activation entry/exit traces at the appropriate times [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198816 (owner: 10Ori.livneh)
[03:13:52] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add 'classes' config option to focusable nodes to simplify AlienNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198550 (owner: 10Esanders)
[03:15:17] <grrrit-wm>	 (03PS1) 10Catrope: Make triple-click expand to CBNs, not BranchNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199565 (https://phabricator.wikimedia.org/T93461) 
[03:15:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Emit activation entry/exit traces at the appropriate times [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198816 (owner: 10Ori.livneh)
[03:17:09] <grrrit-wm>	 (03PS2) 10Catrope: Move drop marker to highlights layer and position absolutely [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198668 (owner: 10Esanders)
[03:17:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add 'classes' config option to focusable nodes to simplify AlienNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198550 (owner: 10Esanders)
[03:17:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Document config options as @cfg [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198551 (owner: 10Esanders)
[03:18:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make triple-click expand to CBNs, not BranchNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199565 (https://phabricator.wikimedia.org/T93461) (owner: 10Catrope)
[03:18:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (715750b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198539 (owner: 10Jforrester)
[03:21:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (715750b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198539 (owner: 10Jforrester)
[03:22:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Move drop marker to highlights layer and position absolutely [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198668 (owner: 10Esanders)
[03:28:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move drop marker to highlights layer and position absolutely [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198668 (owner: 10Esanders)
[03:43:58] <wikibugs>	 10VisualEditor, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Comment body in context showing a scrollbar - https://phabricator.wikimedia.org/T92450#1147543 (10Catrope)
[03:43:59] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: Unnecessary scrollbar on VE comment preview - https://phabricator.wikimedia.org/T93816#1147542 (10Catrope)
[03:45:51] <grrrit-wm>	 (03PS2) 10Catrope: Make triple-click expand to CBNs, not BranchNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199565 (https://phabricator.wikimedia.org/T93461) 
[03:47:11] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Strip X-Parsoid Performance Headers from Visual Editor (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199562 (owner: 10Memeht)
[04:01:37] <ori>	 RoanKattouw_away: still there, by any chance?
[04:34:34] <grrrit-wm>	 (03CR) 10Ori.livneh: "This commit appears to have introduced a massive performance regression to the tune of 400-500ms. Still investigating." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope)
[05:23:34] <wikibugs>	 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1147749 (10Prtksxna)
[05:25:22] <wikibugs>	 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1114885 (10Prtksxna) @violetto, looking at M31 I am not sure which one is right. Could you please see the screenshots and pic...
[05:47:54] <wikibugs>	 10MediaWiki-Page-editing, 7JavaScript, 5Patch-For-Review: LivePreview should not replace title message with displaytitle value in firstHeading - https://phabricator.wikimedia.org/T85784#1147763 (10Fomafix) Done in Patch Set 5.
[06:14:05] <wikibugs>	 10Cite, 7Browser-Support-Internet-Explorer: IE9 does not show reference backlinks - https://phabricator.wikimedia.org/T93319#1147800 (10Fomafix) The problem on IE9 does not occur with `debug=true`. It seams to be a parsing problem with the minimized CSS version.
[08:04:46] <wikibugs>	 10VisualEditor, 6Editing, 6Engineering-Community, 10Possible-Tech-Projects, and 2 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1147884 (10NiharikaKohli) @Ankita-ks please mention the microtask(s) you have worked/are...
[08:27:14] <grrrit-wm>	 (03PS3) 10Divec: Insert slugs on backspace/delete if needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198705 (https://phabricator.wikimedia.org/T91242) 
[08:30:45] <wikibugs>	 10WikiEditor, 7JavaScript: Remove button for <big> from toolbar - https://phabricator.wikimedia.org/T40487#1147898 (10geraki) Maybe it is possible for the parser to catch <big> in wikitext and render it as a <span> in HTML? No ugly wikitext, no templates, faster parsing, better semantics.
[08:32:45] <grrrit-wm>	 (03CR) 10Divec: "This should be reviewed with T91244 in mind. As this patch stands:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198705 (https://phabricator.wikimedia.org/T91242) (owner: 10Divec)
[08:34:11] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Check preventing identical re-renderings in renderContents doesn't work if node contains slugs - https://phabricator.wikimedia.org/T91244#1147901 (10dchan) See https://gerrit.wikimedia.org/r/198705/ , which relates to this bug (without fixing it).
[09:27:18] <grrrit-wm>	 (03CR) 10TheDJ: "Actually, i'm not skeptical about that. My concern is with rendering after we have generated the snippet, leaving us with a good chance of" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt)
[09:41:15] <grrrit-wm>	 (03CR) 10Divec: [C: 031] "No, this is different" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński)
[09:43:39] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design, 5Patch-For-Review: ButtonWidget (frameless…)‎ to be styled like quiet buttons/normal anchors - https://phabricator.wikimedia.org/T88622#1148104 (10Prtksxna) >>! In T88622#1120055, @matmarex wrote: > There isn't, because it would be incompatible with PHP OOUI.  How...
[09:58:40] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design: PopupButtonWidget should be shown at hover not on-click. - https://phabricator.wikimedia.org/T88630#1148135 (10Prtksxna) To add to what @pginer-wmf said — even when Hovercards did not have any actions on the Popup itself, people wanted to be able to tweak the delay t...
[11:52:14] <wikibugs>	 10Citoid: DOI lookup failure should return 520 but instead returns a default website - https://phabricator.wikimedia.org/T93785#1148378 (10Mvolz) What's going on here is that we're following all the redirects from the doi link (as a way of accessing the actual link) so we're directed to the correct link- so we g...
[11:53:21] <wikibugs>	 10Citoid: RequestFromDOI follows all redirects and sometimes results in a bad page being sent to native scraper instead of good urls to Zotero - https://phabricator.wikimedia.org/T93785#1148381 (10Mvolz)
[11:58:37] <wikibugs>	 10WikiEditor, 7JavaScript: Remove button for <big> from toolbar - https://phabricator.wikimedia.org/T40487#1148389 (10He7d3r) @geraki: see * [[https://www.mediawiki.org/wiki/Manual:$wgCleanupPresentationalAttributes|mw:Manual:$wgCleanupPresentationalAttributes]] * {T42329} * {T42632}
[12:03:59] <wikibugs>	 10Citoid: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1148402 (10Mvolz) 3NEW a:3Mvolz
[12:04:33] <wikibugs>	 10Citoid: RequestFromDOI follows all redirects and sometimes results in a bad page being sent to native scraper instead of good urls to Zotero - https://phabricator.wikimedia.org/T93785#1148414 (10Mvolz) p:5High>3Normal a:3Mvolz
[12:05:15] <wikibugs>	 10Citoid: RequestFromDOI follows all redirects and sometimes results in a bad page being sent to native scraper instead of good urls to Zotero - https://phabricator.wikimedia.org/T93785#1146107 (10Mvolz)
[12:05:16] <wikibugs>	 10Citoid: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1148415 (10Mvolz)
[12:05:27] <wikibugs>	 10Citoid: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1148402 (10Mvolz)
[12:05:28] <wikibugs>	 10Citoid: RequestFromDOI follows all redirects and sometimes results in a bad page being sent to native scraper instead of good urls to Zotero - https://phabricator.wikimedia.org/T93785#1146107 (10Mvolz)
[12:12:19] <wikibugs>	 10MediaWiki-Page-editing: Error with rollback - https://phabricator.wikimedia.org/T93819#1148429 (10Aklapper)
[12:33:43] <wikibugs>	 10Citoid: RequestFromDOI follows all redirects and sometimes results in a bad page being sent to native scraper instead of good urls to Zotero - https://phabricator.wikimedia.org/T93785#1148449 (10mobrovac) >>! In T93785#1148378, @Mvolz wrote: > Whether to follow redirects or not is something that gets mixed res...
[12:40:45] <wikibugs>	 10Citoid: RequestFromDOI follows all redirects and sometimes results in a bad page being sent to native scraper instead of good urls to Zotero - https://phabricator.wikimedia.org/T93785#1148454 (10Mvolz) Yeah, I think it's safe to follow one redirect for DOIs, try Zotero, and then follow all redirects after the...
[12:42:57] <wikibugs>	 10Cite, 7Browser-Support-Internet-Explorer: IE9 does not show reference backlinks - https://phabricator.wikimedia.org/T93319#1148457 (10Fomafix) The minimizing is not the problem.  The problem must be in mediawiki.js. When I remove `nextnode` from `newStyleTag( text, nextnode )` the `@media print` rules works...
[12:46:58] <wikibugs>	 10Citoid: Accept and serve cookies - https://phabricator.wikimedia.org/T93877#1148463 (10Mvolz) 3NEW
[12:47:20] <wikibugs>	 10Citoid: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1148472 (10Mvolz)
[12:47:21] <wikibugs>	 10Citoid: RequestFromDOI follows all redirects and sometimes results in a bad page being sent to native scraper instead of good urls to Zotero - https://phabricator.wikimedia.org/T93785#1148471 (10Mvolz) 5duplicate>3Open
[12:48:05] <wikibugs>	 10Citoid: Accept and serve cookies - https://phabricator.wikimedia.org/T93877#1148480 (10Mvolz)
[12:48:07] <wikibugs>	 10Citoid: RequestFromDOI follows all redirects and sometimes results in a bad page being sent to native scraper instead of good urls to Zotero - https://phabricator.wikimedia.org/T93785#1146107 (10Mvolz)
[12:50:03] <wikibugs>	 10Citoid: DOI lookup returns a scraped "missing cookie" page instead of desired content - https://phabricator.wikimedia.org/T93785#1148482 (10Mvolz)
[12:56:20] <wikibugs>	 10Citoid: Citoid request for MediaWiki:Citoid-template-type-map.json should be in the content language, not the user language - https://phabricator.wikimedia.org/T93800#1148494 (10Mvolz) Three approaches here:  One, use mw.api to request the correct language in the message. This will result in redundancy since w...
[12:59:07] <wikibugs>	 10Cite, 7Browser-Support-Internet-Explorer: IE9 does not show reference backlinks - https://phabricator.wikimedia.org/T93319#1148496 (10Fomafix) Related to T52830.
[13:40:23] <wikibugs>	 10Citoid: Citoid request for MediaWiki:Citoid-template-type-map.json should be in the content language, not the user language - https://phabricator.wikimedia.org/T93800#1148600 (10Mvolz) Hmm, I am unable to replicate this bug either on localhost, or in it.wikipedia, or in fr.wikipedia- I tried both en-GB and en...
[13:43:23] <grrrit-wm>	 (03PS3) 10Mvolz: Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits)
[13:45:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits)
[14:04:39] <wikibugs>	 10VisualEditor, 7Browser-Tests: VE cursor test invokes ULS IME in Firefox on test2wiki - https://phabricator.wikimedia.org/T57972#1148743 (10zeljkofilipin)
[14:07:50] <wikibugs>	 10Citoid: Update MAJOR version and remove mwDeprecated, url endpoint, and duplicate itemType: 'webpage' field publicationTitile - https://phabricator.wikimedia.org/T93514#1148778 (10Mvolz) p:5High>3Normal
[14:07:56] <wikibugs>	 10VisualEditor, 7Browser-Tests: add VE tests for all "Insert" items - https://phabricator.wikimedia.org/T65708#1148780 (10zeljkofilipin)
[14:29:12] <wikibugs>	 10Citoid: [Regression] Citoid won't look up PMIDs or PMCIDs - https://phabricator.wikimedia.org/T93335#1148871 (10Mvolz) @Elitre, unfortunately our api there is only as good as the pubmed id converter API.  This is the api request we are using for those  http://www.ncbi.nlm.nih.gov/pmc/utils/idconv/v1.0/?tool=ci...
[14:30:09] <wikibugs>	 10Citoid: ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1148872 (10Mvolz) p:5Unbreak!>3Normal
[14:31:28] <wikibugs>	 10Citoid: ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1134780 (10Mvolz) a:3Mvolz
[14:32:48] <wikibugs>	 10Citoid, 5WMF-deploy-2015-03-25_(1.25wmf23): "Language not recognized" error on adding urls with openGraph metadata - https://phabricator.wikimedia.org/T93337#1148883 (10Mvolz) 5Open>3Resolved
[14:49:36] <wikibugs>	 10OOjs-UI, 10UI-Standardization: Flags can only be applied to buttons - https://phabricator.wikimedia.org/T93890#1148944 (10werdna)
[14:57:42] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add unit test for mwAlienExtension node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198712 (owner: 10Esanders)
[14:59:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add unit test for mwAlienExtension node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198712 (owner: 10Esanders)
[15:04:54] <grrrit-wm>	 (03PS2) 10Jforrester: Use new createFromElement method from ModelFactory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198561 (owner: 10Esanders)
[15:04:56] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (cb06317) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199618 
[15:07:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use new createFromElement method from ModelFactory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198561 (owner: 10Esanders)
[15:07:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (cb06317) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199618 (owner: 10Jforrester)
[15:12:56] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1149073 (10ferdbold)
[15:15:18] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1149087 (10ferdbold)
[15:15:37] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1140552 (10ferdbold)
[15:18:11] <wikibugs>	 10Citoid: ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1149095 (10mobrovac) I successfully scraped all of the PM[C]IDs mentioned in this ticket using the URL `http://www.ncbi.nlm.nih.gov/pubmed/?term=ID` (by replacing `ID` with the appropriate ID, ofc), as suggested [here](http...
[15:18:38] <grrrit-wm>	 (03PS3) 10Jforrester: Ensure that selection is not lost inside block slugs after backspace/delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński)
[15:18:59] <grrrit-wm>	 (03PS8) 10Jforrester: Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[15:19:04] <grrrit-wm>	 (03PS8) 10Jforrester: Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński)
[15:19:10] <grrrit-wm>	 (03PS4) 10Jforrester: Ensure that selection is not lost inside block slugs after backspace/delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński)
[15:20:59] * James_F sighs at change breaking things.
[15:21:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[15:21:28] <grrrit-wm>	 (03CR) 10Mvolz: "Whoops, sorry about that! You're right- I was used to grunt where it tells you the # files tested." [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac)
[15:21:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Ensure that selection is not lost inside block slugs after backspace/delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński)
[15:21:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński)
[15:35:25] <wikibugs>	 10Citoid: ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1149136 (10Mvolz) @mobrovac,  my only objection to that is then we lose the ability to use the doi instead of scraping everything off the pubmed website. It's hard to say exactly what the practical implications of that are...
[15:47:06] <grrrit-wm>	 (03PS1) 10Mvolz: [WIP] Add test for exporting bibtex [services/citoid] - 10https://gerrit.wikimedia.org/r/199623 
[15:49:24] <grrrit-wm>	 (03CR) 10Mvolz: "https://gerrit.wikimedia.org/r/#/c/199623/ doesn't work because of tests that fail further upstream- somewhere these tests require json as" [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac)
[16:25:40] <wikibugs>	 10Citoid, 3VisualEditor 2014/15 Q3 blockers: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1149366 (10Elitre)
[16:34:55] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers: Tab/Shift-Tab behaviour in contexts other than list indent/outdent (e.g. tables) - https://phabricator.wikimedia.org/T72665#1149408 (10Whatamidoing-WMF) > … and if you're at the last cell of the...
[16:37:41] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Make it hard for users to partially-select some unlinked text for linking - https://phabricator.wikimedia.org/T39939#1149412 (10gpaumier)
[16:41:07] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables: Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1149428 (10Whatamidoing-WMF) 3NEW
[16:42:30] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables: Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1149437 (10Whatamidoing-WMF) Related ideas from Thyrduulf on the general subject of reducing this confusion:  "There could be a menu icon that...
[16:44:28] <ferdbold>	 Any GSoC mentors? I've got a question concerning the microtask
[16:45:09] <mooeypoo>	 ask away, ferdbold 
[16:48:33] <ferdbold>	 The task that I'm applying for only has 1 microtask suggested for it, but someone is already working on it. Is it considered bad manners to also do this microtask or should I look elsewhere? ;)
[16:48:52] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, and 2 others: Can't copy a single node selection (e.g. template / media / reference) in Safari - https://phabricator.wikimedia.org/T72143#1149443 (10Etonkovidova) Safari 7.1.2  - cannot copy images with...
[16:50:03] <Ulfr>	 Halp! My save button has gone missing! I think something ate it.
[16:50:26] <mooeypoo>	 ferdbold, yeah another student who is also interested in this project has started working on that microtask. 
[16:51:29] <marktraceur>	 Om nom nom.
[16:51:40] <mooeypoo>	 ferdbold, let's try to find something else for you
[16:51:42] <marktraceur>	 Ulfr: What did you do?
[16:52:13] <Ulfr>	 marktraceur: I've got VE set up on a separate frontend that I can't update i18n on, and the save button in the top right is absent
[16:53:48] <ferdbold>	 Okay good. My workload this week has been pretty brutal so my ability to check around phabricator is pretty limited :/
[16:53:49] <marktraceur>	 Ulfr: What were the last things you changed in reverse chronological order?
[16:54:00] <ferdbold>	 I did manage to set up vagrant and git-review though
[16:54:05] <Pickle-san__>	 Yesterday, I ran maintenance/update.php on an installation. Now, when certain pages are invoked with "Edit," an entirely different page is invoked -- it is almost as if an index in the database were skewed. It is now possible to save the page and stomp over whatever was there before. Has this been observed before? I'm not even sure how to debug this -- suggestions will be appreciated!
[16:54:42] <Ulfr>	 marktraceur: I haven't changed anything, I've got parsoid running in a console window and it's working, and it loads content fine, the save button is just MIA
[16:54:46] <Ulfr>	 is there a hotkey to save?
[16:54:49] <mooeypoo>	 ferdbold, I'm looking at the bugs in the system, let me see if I can find something small for you
[16:54:50] <Pickle-san__>	 FYI, here is some git version identification.  MediaWiki: 5a3173d06b605a8c86ace08efc9e9c290f7f171a, VisualEditor: b6ad119f153cdd0f88e3152c5961785c3d46e72a
[16:55:05] <marktraceur>	 Ulfr: And it was working before?
[16:55:14] <Ulfr>	 marktraceur: I don't think so
[16:55:26] <ferdbold>	 Great, I appreciate it :)
[16:55:30] <Ulfr>	 if I had mucked with it and THEN it disappeared I could fix it, but it's just gone man
[16:55:48] <marktraceur>	 Ah.
[16:58:39] <Ulfr>	 marktraceur: http://ec2-67-202-57-88.compute-1.amazonaws.com/index.php/Sandbox
[16:58:47] <Ulfr>	 user account is GuestUser and password is your name
[16:58:49] <Ulfr>	 if you'd like to look
[17:00:03] <ankita-ks>	 Hi, I was trying to disable the remove button in TransclusionBox when there is only a single template placeholder.
[17:00:25] <marktraceur>	 Ulfr: Sorry, meetings, not really able to do so right now
[17:00:31] <Ulfr>	 marktraceur: No worries
[17:02:17] <ankita-ks>	 So in ve.ui.MWTransclusionDialog.prototype.onReplacePart, i check if there is a single element present. If that element is an instance of templateplaceholder
[17:02:38] <ankita-ks>	 i want to disable the remove button associated with it.
[17:03:22] <ankita-ks>	 I was hoping there would be something like "setRemovable( false )" maybe
[17:03:27] <ankita-ks>	 Can anyone help?
[17:03:33] <ankita-ks>	 TrevorParscal ?
[17:04:02] <TrevorParscal>	 ankita-ks: in a short meeting, will reply in a few
[17:04:18] <ankita-ks>	 TrevorParscal : sure :)
[17:04:25] <Ulfr>	 Oh, wierd. .oo-ui-toolbar-actions is 0px by 0px
[17:14:55] <marktraceur>	 Ulfr: I wonder if that might be the problem.
[17:15:27] <Ulfr>	 marktraceur: Probably. All the buttons to the right of the insert bar are MIA
[17:15:31] <Ulfr>	 maybe they'll form a band
[17:16:36] <marktraceur>	 Live fast, die young, toolbar actions do it well
[17:16:57] <Ulfr>	 So how'd I screw up this spiffy piece of software
[17:20:09] <whatami>	 mooeypoo, the small task we talked about is https://phabricator.wikimedia.org/T93908
[17:23:10] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables: Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1149561 (10Mvolz)
[17:25:58] <Ulfr>	 Well, I found a clue. Unable to parse title points somewhere in load.php
[17:25:59] <Ulfr>	 hmmm
[17:28:26] * Ulfr sighs
[17:28:29] <Ulfr>	 I had to update i18n
[17:39:00] <mooeypoo>	 whatami, thanks!
[18:04:37] <mooeypoo>	 Niharika, can you approve me and mvolz as mentors to gsoc and outreachy in the systems?
[18:05:21] <grrrit-wm>	 (03PS3) 10Nirzar: Defining font stack for modal windows and widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/197097 (https://phabricator.wikimedia.org/T92858) 
[18:06:07] <James_F>	 edsanders: You about?
[18:06:16] <edsanders>	 yes
[18:06:34] <James_F>	 edsanders: The test failures in https://gerrit.wikimedia.org/r/#/c/199618/ make me think that the code it's pulling through need fixing…
[18:06:36] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1149744 (10Mvolz)
[18:06:36] <James_F>	 edsanders: Thoughts?
[18:07:55] <Niharika>	 mooeypoo: Sure! Was in a meeting. Will do asap.
[18:08:18] * edsanders looks
[18:09:07] <edsanders>	 hmm, possibly, check with Bartosz
[18:09:47] <James_F>	 edsanders: <tt class="ve-ce-focusableNode" contentEditable="no"> much?
[18:09:47] <mooeypoo>	 Niharika, awesome, thanks!
[18:10:17] <James_F>	 edsanders: Bartosz isn't here, and it's blocking merging your code in VE-MW.
[18:10:18] <edsanders>	 I'll try them locally
[18:11:26] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables: Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1149784 (10Mvolz)
[18:11:27] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1149783 (10Mvolz)
[18:13:40] <edsanders>	 James_F, don't think there's a problem, the tests just need updating the format of the expected selection
[18:13:54] <edsanders>	 did he not create a fix for MW?
[18:13:57] <RoanKattouw>	 ori: Did you find out what happened with https://gerrit.wikimedia.org/r/#/c/193026/ ?
[18:14:24] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1149790 (10Mvolz) FYI, the three blocking tasks I added are potential microtasks for this project:   T93921  T93919  T93908  T93908 is sl...
[18:14:27] <James_F>	 edsanders: No. Also, <tt> getting alienated looks wrong.
[18:16:11] <grrrit-wm>	 (03PS2) 10Esanders: Update VE core submodule to master (cb06317) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199618 (owner: 10Jforrester)
[18:17:10] <edsanders>	 the <tt> is written as an alien in the data model for that test
[18:17:16] <James_F>	 Oh, OK.
[18:17:26] <ori>	 RoanKattouw: no. Can you investigate?
[18:17:31] <James_F>	 It didn't look it, but I'm not an expert.
[18:17:39] <ori>	 RoanKattouw: I can tell you how to reproduce on osmium
[18:17:45] <RoanKattouw>	 Yes please do
[18:17:46] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables: Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1149815 (10Mvolz)
[18:17:50] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1149813 (10Mvolz)
[18:18:01] <RoanKattouw>	 At this point I'm highly suspicious that you may be making a methodological mistake
[18:18:38] <RoanKattouw>	 Which is why I'd like you to convince me that I'm wrong
[18:20:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (cb06317) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199618 (owner: 10Jforrester)
[18:20:44] <grrrit-wm>	 (03PS3) 10Esanders: Update VE core submodule to master (cb06317) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199618 (owner: 10Jforrester)
[18:21:07] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [WIP] Link Inspector Redesign (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/174725 (owner: 10SuchetaG)
[18:23:37] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables: Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1149839 (10Esanders) Double clicking to edit a table cell is normal in quite a few editors. Not sure about using a tooltip, but if we do it sh...
[18:24:55] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (cb06317) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199618 (owner: 10Jforrester)
[18:26:57] <grrrit-wm>	 (03PS3) 10Jforrester: Use new createFromElement method from ModelFactory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198561 (owner: 10Esanders)
[18:27:00] <ori>	 RoanKattouw: on osmium, run /srv/bench/check-perf . then roll back one commit and run it again
[18:27:10] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Use new createFromElement method from ModelFactory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198561 (owner: 10Esanders)
[18:27:21] <RoanKattouw>	 ori: OK will do
[18:27:21] <ori>	 RoanKattouw: the '.' is punctuation, not part of the command
[18:28:09] <RoanKattouw>	 ori: In what directory do I roll back one commit?
[18:28:21] <ori>	 RoanKattouw: /srv/mediawiki-local/extensions/VisualEditor
[18:28:53] <ori>	 RoanKattouw: i ran git bisect a few times to make sure. commits before that patch get a min in the 1100-1200 range. on or after that patch, 1600-1800
[18:29:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (cb06317) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199618 (owner: 10Jforrester)
[18:29:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use new createFromElement method from ModelFactory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198561 (owner: 10Esanders)
[18:29:14] <ori>	 could be an artifact of how osmium is set up
[18:29:44] <RoanKattouw>	 I think it might be an artifact of how we do/did this instrumentation
[18:30:11] <RoanKattouw>	 As I said before, a lot of stuff wasn't covered before and is covered now, and some of the reverse happened too
[18:30:38] <ori>	 RoanKattouw: i account for that. the profiler is started on edit tab click, and stopped on an event that is patched into the source:
[18:30:40] <ori>	   git grep -l 'updateDimensions();' | \
[18:30:40] <ori>	     xargs sed -i 's/updateDimensions();$/updateDimensions(); ve.track( "trace.init.exit" );/'
[18:30:53] <RoanKattouw>	 Aha OK
[18:31:05] <grrrit-wm>	 (03Abandoned) 10Jforrester: "Delete row"/"Delete column" messages now using the plural when multiple rows/columns are selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198779 (owner: 10Pratikbsp)
[18:31:15] <ori>	 (this is from check-perf)
[18:33:35] <ori>	 RoanKattouw: one possible way in which this could be osmium-specific is if the module payload takes longer to generate somehow. osmium isn't behind varnish. (then again, logged-in users don't typically get their modules from varnish either)
[18:34:05] <RoanKattouw>	 Yeah one thing I did notice locally is that in practice, the API and load.php requests weren't parallel
[18:34:15] <RoanKattouw>	 They appeared to be serialized by my server
[18:34:30] <ori>	 well, the api request is going to enwiki's api, remember
[18:34:35] <ori>	 because of the MediaWiki:Common.js override
[18:34:45] <RoanKattouw>	 Huh?
[18:34:48] <RoanKattouw>	 Oh right
[18:34:57] <RoanKattouw>	 So it's hitting load.php on osmium and api.php on enwiki
[18:35:00] <ori>	 right
[18:35:13] <RoanKattouw>	 How long does this script take?
[18:35:18] <ori>	 about a minute
[18:35:29] <RoanKattouw>	 It's been running for at least 5 now
[18:35:56] <ori>	 chromium-browser is on 100% cpu, so it's doing _something_
[18:37:01] <ori>	 if it's been five minutes, kill it and try again
[18:38:25] <ori>	 any luck?
[18:40:13] <TrevorParscal>	 ankita-ks: i'm back - looking at your question now
[18:40:26] <wikibugs>	 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Existing DEFAULTSORT replaced by incorrectly formatted Category - https://phabricator.wikimedia.org/T93759#1149958 (10GWicke)
[18:40:29] <wikibugs>	 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Existing external links replaced by forbidden <a> tags - https://phabricator.wikimedia.org/T93758#1149960 (10GWicke)
[18:40:30] <wikibugs>	 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Span tags (some with href) added to otherwise unmodified sentences - https://phabricator.wikimedia.org/T93755#1149959 (10GWicke)
[18:40:31] <wikibugs>	 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Internal links [[Xxx]] replaced by [[./Xxxx]] - https://phabricator.wikimedia.org/T93754#1149962 (10GWicke)
[18:40:33] <wikibugs>	 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Existing == Title == replaced by <h2>Title</h2> - https://phabricator.wikimedia.org/T93756#1149961 (10GWicke)
[18:41:08] <wikibugs>	 10VisualEditor, 10Parsoid: Existing DEFAULTSORT replaced by incorrectly formatted Category - https://phabricator.wikimedia.org/T93759#1149963 (10Jdforrester-WMF)
[18:41:14] <wikibugs>	 10VisualEditor, 10Parsoid: Existing external links replaced by forbidden <a> tags - https://phabricator.wikimedia.org/T93758#1149964 (10Jdforrester-WMF)
[18:41:18] <wikibugs>	 10VisualEditor, 10Parsoid: Existing == Title == replaced by <h2>Title</h2> - https://phabricator.wikimedia.org/T93756#1149965 (10Jdforrester-WMF)
[18:41:23] <wikibugs>	 10VisualEditor, 10Parsoid: Span tags (some with href) added to otherwise unmodified sentences - https://phabricator.wikimedia.org/T93755#1149967 (10Jdforrester-WMF)
[18:41:53] <wikibugs>	 10VisualEditor, 10Parsoid: Span tags (some with href) added to otherwise unmodified sentences - https://phabricator.wikimedia.org/T93755#1149969 (10GWicke)
[18:41:54] <wikibugs>	 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Internal links [[Xxx]] replaced by [[./Xxxx]] - https://phabricator.wikimedia.org/T93754#1145203 (10GWicke)
[18:42:13] <wikibugs>	 10VisualEditor, 10Parsoid: Span tags (some with href) added to otherwise unmodified sentences - https://phabricator.wikimedia.org/T93755#1145215 (10GWicke)
[18:42:14] <wikibugs>	 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Internal links [[Xxx]] replaced by [[./Xxxx]] - https://phabricator.wikimedia.org/T93754#1145203 (10GWicke)
[18:42:37] <grrrit-wm>	 (03PS4) 10Mobrovac: [BREAKING] Make Citoid use service-template-node and service-runner [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) 
[18:43:10] <ankita-ks>	 TrevorParscal : would now be a good time or am I bugging you? 
[18:43:14] <ankita-ks>	 oh.
[18:43:18] <ankita-ks>	 just saw your message.
[18:43:27] <ankita-ks>	 so..the question has changed now.
[18:44:12] <TrevorParscal>	 ok
[18:44:24] <TrevorParscal>	 because I put an OOjs UI patch in last week that will help you
[18:44:29] <TrevorParscal>	 go ahead and ask the new question
[18:44:31] <grrrit-wm>	 (03CR) 10Mobrovac: "@mvolz, fixed the spaces vs tabs issue." [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac)
[18:44:36] <ori>	 RoanKattouw: ?
[18:44:51] <RoanKattouw>	 ori: OK so I get 1484 vs 1274
[18:44:56] <grrrit-wm>	 (03PS2) 10Mobrovac: [WIP] Add test for exporting bibtex [services/citoid] - 10https://gerrit.wikimedia.org/r/199623 (owner: 10Mvolz)
[18:45:04] <RoanKattouw>	 ori: Is there a way we can extract Chrome timeline traces from both so we can compare them?
[18:45:20] <RoanKattouw>	 Or I guess maybe I can proxy into osmium to run both versions in my browser?
[18:45:22] <ori>	 RoanKattouw: SOCKS and record a timeline in your browser
[18:45:22] <ori>	 yeah
[18:45:24] <wikibugs>	 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1150009 (10Nirzar) @kaldari I don't think the screenshots attached in task description are the hover styles. they are :focus...
[18:45:46] <ankita-ks>	 TrevorParscal : https://gist.github.com/ankita-kumari/81c565c9e87217da1b54
[18:45:59] <ankita-ks>	 Can I get a link to that patch again?
[18:47:17] <TrevorParscal>	 ankita-ks: this logic is in the wrong place I think
[18:47:30] <ankita-ks>	 where should it be then?
[18:47:33] <TrevorParscal>	 in the page
[18:47:37] <TrevorParscal>	 that controls this thing
[18:47:44] <wikibugs>	 10Citoid, 6Services, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Get citoid working in production - https://phabricator.wikimedia.org/T89656#1150022 (10Jdforrester-WMF)
[18:47:47] <whatami>	 This is your friendly reminder that the last bug triage meeting for VisualEditor in this quarter will start in about 15 minutes.  If you want to join, please see the instructions at https://www.mediawiki.org/wiki/Talk:VisualEditor/Portal
[18:47:49] <TrevorParscal>	 thing == remove button
[18:48:05] <wikibugs>	 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Outreachy and GSoC 2015 Proposal for Graph editing in Visual Editor - https://phabricator.wikimedia.org/T93788#1150024 (10NiharikaKohli) Hey @rits could you fill up the description for the proposal please? http...
[18:48:13] <whatami>	 James_F is hereby reminded that any bug affecting me is always "top-priority".  ;-)
[18:48:16] <TrevorParscal>	 basically, the page should respond to the replacePart event itself
[18:48:31] <TrevorParscal>	 ankita-ks: tell sign is, you are writing "page.removeButton"
[18:48:31] <ankita-ks>	 By page you mean TemplatePlaceholderPage?
[18:48:39] <TrevorParscal>	 yes
[18:48:43] <ankita-ks>	 okay.
[18:49:06] <wikibugs>	 10VisualEditor: Screen jumps in Internet Explorer 11 when clicking "Bullet list" or "Numbered list" in toolbar - https://phabricator.wikimedia.org/T93929#1150036 (10MarkAHershberger)
[18:49:08] <TrevorParscal>	 basically, unless you are accessing .$element (and maybe a couple of other rare expections) consider properties to be private
[18:49:11] <ankita-ks>	 But how to I find out from the page, the number of parts in the Transclusion Dialog?
[18:49:12] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: Editing a specific article at pl.wp truncates category name - https://phabricator.wikimedia.org/T76353#1150038 (10Jdforrester-WMF)
[18:49:21] <ankita-ks>	 okay. noted.
[18:49:22] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Insert slugs on backspace/delete if needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198705 (https://phabricator.wikimedia.org/T91242) (owner: 10Divec)
[18:49:24] <TrevorParscal>	 and don't access ones that don't belong to the class the method is bound to
[18:49:26] <wikibugs>	 10VisualEditor, 10Continuous-Integration, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Browser disconnects when running QUnit tests with local browsers - https://phabricator.wikimedia.org/T89075#1150039 (10Jdforrester-WMF)
[18:49:39] <ankita-ks>	 okay. will take care in future.
[18:49:40] <TrevorParscal>	 when you find yourself doing this, just move the logic to a place where it doesn't need to anymore
[18:49:41] <TrevorParscal>	 cool
[18:50:01] <TrevorParscal>	 also, I added support for setAbilities in the outline controls widget
[18:50:21] <Pickle-san__>	 I ran maintenance/update.php from MediaWiki 1.25 yesterday.  Now, when I invoke VisualEditor on some pages, it suddenly starts to edit a completely different page.  No error message.  Edit Source works fine.  Any suggestions?
[18:51:04] <ankita-ks>	 TrevorParscal : okay. So if i update my codebase i should get that, right?
[18:51:56] <ankita-ks>	 Also, i asked this earlier. If I do disable the removeButton from the page, how do I determine how many parts the dialog box has?
[18:52:05] <TrevorParscal>	 let me check
[18:52:19] <ankita-ks>	 okay
[18:52:20] <hexmode>	 Pickle-san__: sounds kind of like a caching issue.  When did you last update VE?
[18:52:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Insert slugs on backspace/delete if needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198705 (https://phabricator.wikimedia.org/T91242) (owner: 10Divec)
[18:52:39] <hexmode>	 Pickle-san__: also, what browser?
[18:52:45] <RoanKattouw>	 ankita-ks, TrevorParscal: The setAbilities code in OutlineControlWidget just barely missed last week's oojs-ui release by a few hours, but it should be in this weeks'
[18:52:53] <RoanKattouw>	 Which should be released today or tomorrow
[18:53:03] <TrevorParscal>	 yeah, that makes sense
[18:53:20] <ankita-ks>	 okay.
[18:53:41] <TrevorParscal>	 so, once that is in, you can also make the outline controls widget disabled
[18:54:05] <TrevorParscal>	 which you will do in the dialog's event handler (where the code you showed me already is)
[18:54:08] <MatmaRex>	 hi.
[18:54:10] <ankita-ks>	 okay. in the meantime could you link me to the patch?
[18:54:34] <wikibugs>	 10VisualEditor: Screen jumps on Internet Explorer 11 when deleting selected text. - https://phabricator.wikimedia.org/T93930#1150080 (10MarkAHershberger) 3NEW
[18:54:35] <aharoni>	 mooeypoo - shalom from Jerusalem
[18:54:52] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Prevent backspacing/deleting over table cells (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[18:55:00] <Pickle-san__>	 hexmode: This has been observed on Firefox and Chrome.  I can get the git hashes for the MediaWiki and VE versions.  I tried updating to the latest yesterday, at which point nothing worked -- I must have had something out of sync.
[18:55:00] <aharoni>	 I just noticed that the VE language tool is not beta any more.
[18:55:36] <aharoni>	 mooeypoo: do you realize that this finally complete you GSoC 2013 project?!
[18:55:42] <mooeypoo>	 aharoni, hii!
[18:55:48] <hexmode>	 Pickle-san__: any pattern to which pages it pulls up and which don't match?
[18:55:51] <mooeypoo>	 aharoni, which? what?
[18:56:01] <aharoni>	 mooeypoo: the language tool! not beta any more!
[18:56:05] <aharoni>	 I just realized this.
[18:56:15] <mooeypoo>	 oh! haha! yay!
[18:56:15] <Pickle-san__>	 hexmode: Git versions: MediaWiki: 5a3173d06b605a8c86ace08efc9e9c290f7f171a VisualEditor: b6ad119f153cdd0f88e3152c5961785c3d46e72a
[18:56:24] <aharoni>	 ankita-ks: (not the language tool at which you were looking - another one)
[18:56:33] <mooeypoo>	 \o/
[18:56:41] <aharoni>	 mooeypoo: I was wondering why is it in beta for so long.
[18:56:47] <aharoni>	 so congrats
[18:56:48] <ankita-ks>	 aharoni : yeah. I was confused for a bit. But I realized. :P
[18:56:58] <mooeypoo>	 yeah it was for a while
[18:57:10] <wikibugs>	 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Internal links [[Xxx]] replaced by [[./Xxxx]] - https://phabricator.wikimedia.org/T93754#1150100 (10ssastry) Just as an explanation of the flurry of changes seen here:  We are fairly sure at this point that the problems seen are a result of T93086...
[18:57:21] <mooeypoo>	 meeting, brb
[18:57:23] <aharoni>	 ankita-ks: it's the language button in VE's style menu.
[18:57:33] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Prevent backspacing/deleting over table cells (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[18:57:42] <grrrit-wm>	 (03PS9) 10Bartosz Dziewoński: Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) 
[18:58:03] <hexmode>	 Pickle-san__: looks like this bug was fixed after your head on MW: https://phabricator.wikimedia.org/T74480
[18:58:03] <ankita-ks>	 aharoni : found it. Interesting. 
[18:58:50] <hexmode>	 Pickle-san__: if that isn't it, sorry. That's my bug and your issue sounds very similar.
[18:59:09] <Pickle-san__>	 hexmode: As to patterns, we have not been able to find any yet.  We initially thought it might have to do with embedded pictures.  This is a 1.25 installation.  I had run the 1.23 version of the script, and it appeared to work.  Users started to get the error "Database error A database query error has occurred. This may indicate a bug in the software."   Running the 1.25 version of update.php appears to have fi
[19:01:14] <Pickle-san__>	 hexmode: Can you recommend some git versions to which I can try to update my sandboxes?  I think I had something out-of-whack yesterday when I tried to go to the head -- I got the whitescreen, with PHP errors in the error_log.
[19:01:55] <hexmode>	 Pickle-san__: I can only tell you what I'm using.  But sticking to WMF tags should work
[19:03:33] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] LookupElement: Fix typo in docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/198490 (owner: 10Bartosz Dziewoński)
[19:04:54] <Pickle-san__>	 hexmode: I am a bit of a git novice.  How do I assert the WMF tags?  Will the same tag apply to both MW and VE?
[19:04:55] <hexmode>	 Pickle-san__: I'm using the 1.25wmf22 in MW
[19:05:34] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Prevent backspacing/deleting over table cells (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[19:05:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Describe ve.Range using anchor/focus terminology [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198707 (owner: 10Divec)
[19:05:46] <hexmode>	 VE is at 70cff83
[19:05:58] <hexmode>	 Pickle-san__: VE is at 70cff83
[19:06:51] <hexmode>	 Pickle-san__: "git checkout origin/wmf/1.25wmf22" should work for your MW checkout.  And that is a branch, not a tag.
[19:10:14] <grrrit-wm>	 (03PS3) 10Mobrovac: Add test for exporting bibtex [services/citoid] - 10https://gerrit.wikimedia.org/r/199623 (https://phabricator.wikimedia.org/T91168) (owner: 10Mvolz)
[19:10:31] <Pickle-san__>	 hexmode: git checkout origin/wmf/1.25wmf22 M       extensions/VisualEditor M       vendor Previous HEAD position was 5a3173d... Localisation updates from https://translatewiki.net. HEAD is now at 3ad3c0b... Update Wikidata - Revert change dispatcher patches
[19:10:40] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: "Error: offset was inside an ignoreChildren node" appears while triple-clicking on an empty line when an image is the first item of the page  - https://phabricator.wikimedia.org/T93461#1150170 (10Catrope)
[19:11:08] <Pickle-san__>	 hexmode: Do I need to follow up with another command on the VE subtree?
[19:11:36] <grrrit-wm>	 (03CR) 10Mobrovac: "@mvolz, the test now passes. The actual problem was that Citoid was setting the Content-Type header to app/json regardless of the format." [services/citoid] - 10https://gerrit.wikimedia.org/r/199623 (https://phabricator.wikimedia.org/T91168) (owner: 10Mvolz)
[19:11:39] <hexmode>	 Pickle-san__: wouldn't hurt to do "git checkout 70cff83" in ve
[19:11:57] <hexmode>	 Actually
[19:12:01] <hexmode>	 that might not work
[19:12:10] <hexmode>	 since it is probably a local ref
[19:12:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: LookupElement: Fix typo in docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/198490 (owner: 10Bartosz Dziewoński)
[19:12:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Describe ve.Range using anchor/focus terminology [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198707 (owner: 10Divec)
[19:12:34] <grrrit-wm>	 (03CR) 10Catrope: "Re "page data but no metadata": parse includes metadata, right? I guess I should have added a comment explaining the case statement falls " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) (owner: 10Catrope)
[19:13:29] <grrrit-wm>	 (03CR) 10Catrope: "Re direct Parsoid access: maybe we'll eventually support it, but it didn't seem like a high priority for right now, and Parsoid doesn't ev" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) (owner: 10Catrope)
[19:13:30] <hexmode>	 no, it is from upstream...
[19:14:44] <Pickle-san__>	 hexmode:  After updating, I get the white screen: "PHP Fatal error:  Class 'Liuggio\\StatsdClient\\Factory\\StatsdDataFactory' not found in /var/www/mediawiki-1.25/core/includes/libs/BufferingStatsdDataFactory.php on line 33"
[19:14:57] <RoanKattouw>	 Pickle-san__: Have you run composer update?
[19:15:09] <hexmode>	 ty RoanKattouw :)
[19:15:28] <grrrit-wm>	 (03CR) 10Alex Monk: "Oh it just falls through, yep, OK re parsoid. Comments inline still apply." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) (owner: 10Catrope)
[19:16:10] <Krenair>	 RoanKattouw, it actually took me 10 minutes and a bit of debugging to actually find that typo >_>
[19:16:26] <Krenair>	 well, maybe not that long
[19:16:29] <wikibugs>	 10Citoid, 3Editing Department 2014/15 Q4 blockers: DOI lookup returns a scraped "missing cookie" page instead of desired content - https://phabricator.wikimedia.org/T93785#1150198 (10Jdforrester-WMF)
[19:16:55] <Krenair>	 but I put that in my config and attempted to test a few times before spotting the issue
[19:20:03] <RoanKattouw>	 haha
[19:20:05] <RoanKattouw>	 Sorry :(
[19:20:15] <RoanKattouw>	 This is what happens when I write code without being able to test it
[19:20:27] <RoanKattouw>	 Thanks for breaking that down into simple things for me to fix
[19:20:28] <Pickle-san__>	 RoanKattouw: Thank you, I did miss that.  The page now materializes, but hangs indefinitely when I try to invoke VE.
[19:21:29] <RoanKattouw>	 Pickle-san__: Any errors in the JS console?
[19:23:02] <Pickle-san__>	 RoanKattouw: Expected 'important' but found 'ie'.  Expected ';' or '}' to terminate declaration but found 'ie'.  Declaration dropped.
[19:24:06] <RoanKattouw>	 That's harmless
[19:24:16] <RoanKattouw>	 If you add ?debug=true to the URL, does anything scarier than that appear?
[19:25:10] <wikibugs>	 10MediaWiki-Page-editing: Error with rollback - https://phabricator.wikimedia.org/T93819#1150245 (10Umherirrender) The message is 'difference-missing-revision', no idea why the rollback does not found the previous inserted revision for the diff.
[19:25:13] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, and 4 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1150246 (10DannyH)
[19:25:27] <wikibugs>	 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1150248 (10DannyH)
[19:25:42] <Pickle-san__>	 RoanKattouw: Also "Error in parsing value for 'background-image'.  Declaration dropped."
[19:25:46] <grrrit-wm>	 (03PS3) 10Catrope: [WIP] Send requests to RESTbase directly when so configured [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) 
[19:25:49] <RoanKattouw>	 That's also harmless
[19:26:01] <grrrit-wm>	 (03PS4) 10Catrope: [WIP] Send requests to RESTbase directly when so configured [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) 
[19:27:47] <hexmode>	 Pickle-san__: when is the last time you updated parsoid?
[19:29:09] <Pickle-san__>	 hexmode: Well, now that I've just updated MediaWiki and VE, perhaps it's time.  Let me look into that, thanks.
[19:29:24] <wikibugs>	 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25, and 3 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1150283 (10DannyH)
[19:29:31] <wikibugs>	 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 3Collaboration-Team-Sprint-S-2015-03-25: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1150285 (10DannyH)
[19:30:03] <grrrit-wm>	 (03PS10) 10Bartosz Dziewoński: Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) 
[19:30:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: Prevent backspacing/deleting over table cells (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[19:33:29] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design, 3VisualEditor 2014/15 Q3 blockers: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1150309 (10Jdforrester-WMF)
[19:33:47] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[19:33:53] <grrrit-wm>	 (03PS9) 10Catrope: Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński)
[19:33:56] <wikibugs>	 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 10MediaWiki-General-or-Unknown, 3Collaboration-Team-Sprint-S-2015-03-25: T7. Flow support for the mediawiki.feedback form - https://phabricator.wikimedia.org/T91805#1150313 (10DannyH) p:5Normal>3High
[19:34:29] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design, 3VisualEditor 2014/15 Q3 blockers: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#687159 (10Jdforrester-WMF) I have reverted the title change because it is **completely** wrong. "Remove...
[19:35:28] <Pickle-san__>	 hexmode: commit e92a0abfebce5c17af793807e3e88ead506b9dd9 Author: Arlo Breault <abreault@wikimedia.org> Date:   Thu Feb 19 15:55:26 2015 -0800
[19:35:44] <hexmode>	 Pickle-san__: ??
[19:36:32] <Pickle-san__>	 hexmode: This is the version of parsoid.  When I run "git checkout" I see nothing new.  Is this as expected?
[19:36:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński)
[19:36:46] <hexmode>	 Pickle-san__: git pull
[19:39:52] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design, 3VisualEditor 2014/15 Q3 blockers: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1150358 (10Whatamidoing-WMF) This appears to be fixed now (same browser/same article test).  I think tha...
[19:40:08] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Internet-Explorer: Pressing Backspace/Delete or creating a heading causes the page to abruptly scroll up on Internet Explorer 11 - https://phabricator.wikimedia.org/T73119#1150359 (10MarkAHershberger)
[19:40:11] <wikibugs>	 10VisualEditor: Screen jumps on Internet Explorer 11 when deleting selected text. - https://phabricator.wikimedia.org/T93930#1150360 (10MarkAHershberger)
[19:40:32] <Pickle-san__>	 hexmode: OK, pulled latest parsoid, restarted.  The same browser console errors are present.
[19:40:54] <hexmode>	 Pickle-san__: is ve working?
[19:41:08] <hexmode>	 Pickle-san__: are there errors on web servers error log?
[19:41:15] <Pickle-san__>	 hexmode: No, it is still hung.
[19:41:47] <Pickle-san__>	 hexmode: No errors in the HTTPD log.
[19:41:56] <hexmode>	 :P
[19:42:16] <hexmode>	 Pickle-san__: can you see the network requests in your browser?
[19:42:28] <hexmode>	 Pickle-san__: I mean, do you know how to watch them?
[19:43:06] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: When splitting a paragraph, trim whitespace from the start of the new one - https://phabricator.wikimedia.org/T93935#1150371 (10Jdforrester-WMF) 3NEW
[19:43:13] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10Parsoid, 7Design, 3VisualEditor 2014/15 Q3 blockers: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1150379 (10Jdforrester-WMF) >>! In T68628#1150358, @Whatamidoing-WMF wrote: > This appears to be fixed n...
[19:43:56] <Pickle-san__>	 hexmode: Ah, look at that: ""VisualEditor failed to load: Error: Module ext.visualEditor.core has failed dependencies" load.php:154:363"
[19:44:12] <Pickle-san__>	 hexmode: How do I find the missing dependencies?
[19:44:25] <hexmode>	 Pickle-san__: in your ve directory: git submodule foreach git pull
[19:45:34] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10Parsoid, 7Design: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1150390 (10Jdforrester-WMF)
[19:48:30] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10Parsoid, 7Design: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1150401 (10Jdforrester-WMF) I've restored this task back to what it's about, which is a **design** issue about di...
[19:48:31] <Pickle-san__>	 hexmode:  Thanks, executed.  New branch wmf23.  Same symptoms. Here is another interesting error: ""(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit." app.js:244:1948" 
[19:49:11] <hexmode>	 Pickle-san__: haven't seen that one.  Did you run node install after updating parsoid?
[19:49:58] <wikibugs>	 10VisualEditor, 7Browser-Support-Internet-Explorer: Screen jumps on Internet Explorer 11 when deleting selected text. - https://phabricator.wikimedia.org/T93930#1150410 (10Aklapper)
[19:50:05] <wikibugs>	 10VisualEditor, 7Browser-Support-Internet-Explorer: Screen jumps in Internet Explorer 11 when clicking "Bullet list" or "Numbered list" in toolbar - https://phabricator.wikimedia.org/T93929#1150411 (10Aklapper)
[19:50:11] <wikibugs>	 10Citoid, 3VisualEditor 2014/15 Q3 blockers: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1150414 (10Jdforrester-WMF) Removing from VE Q3; the parent task, {T93785}, is the user-visible one, and we'll work on that instead.
[19:50:17] <wikibugs>	 10Citoid: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1150416 (10Jdforrester-WMF)
[19:50:26] <wikibugs>	 10Citoid, 7Technical-Debt: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1148402 (10Jdforrester-WMF)
[19:51:47] <Pickle-san__>	 hexmode: Wow.  "# node install  module.js:340     throw err;           ^ Error: Cannot find module '/var/www/mediawiki-1.25/core/install'     at Function.Module._resolveFilename (module.js:338:15)     at Function.Module._load (module.js:280:25)     at Function.Module.runMain (module.js:497:10)     at startup (node.js:119:16)     at node.js:906:3"
[19:51:53] <wikibugs>	 10VisualEditor, 7Browser-Support-Internet-Explorer: Screen jumps on Internet Explorer 11 when deleting selected text. - https://phabricator.wikimedia.org/T93930#1150419 (10MarkAHershberger) Think I merged the wrong way.... sorry :(
[19:54:20] <hexmode>	 Pickle-san__: haven't see that
[19:54:37] <hexmode>	 Pickle-san__: but I bet it is related ;)
[19:55:01] <Pickle-san__>	 hexmode: :o)
[19:56:13] * hexmode goes to look at the code to keep the screen from jumping/random scrolling.
[19:59:32] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables, 5WMF-deploy-2015-04-01_(1.25wmf24): Table cells can be removed by backspacing/deleting - https://phabricator.wikimedia.org/T92702#1150444 (10Jdforrester-WMF) 5Open>3Resolved
[20:01:21] <Pickle-san__>	 hexmode: Well, it seems like the bottom line is that I have some version incompatibilities.  Does it hurt if I run "git submodule foreach git pull" in MediaWiki itself?
[20:02:20] <hexmode>	 Pickle-san__: might not help, but won't hurt
[20:04:41] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-04-01_(1.25wmf24): Native backspace/delete doesn't cause slugs to appear when they should - https://phabricator.wikimedia.org/T91242#1150471 (10Jdforrester-WMF) 5Open>3Resolved
[20:08:47] <James_F>	 ryasmeen: https://phabricator.wikimedia.org/maniphest/query/XpbLdne.2bkU/#R and https://phabricator.wikimedia.org/P432
[20:11:09] <grrrit-wm>	 (03CR) 10Catrope: [BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198729 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders)
[20:15:48] <Pickle-san__>	 hexmode: Trying to update MW in this way did not help.  Just in review: I have updated MW and VE to mwf23, updated parsoid to the head, re-run composer.  node update fails because of a missing module in core/install.  Is there anything else I might consider?
[20:16:32] <James_F>	 Pickle-san__: Node update for Parsoid? Delete your node_modules directory and re-run npm install.
[20:16:45] <grrrit-wm>	 (03PS2) 10Alex Monk: Check for the two revision IDs returned by the server being different [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198393 (https://phabricator.wikimedia.org/T92993) 
[20:16:50] <hexmode>	 Pickle-san__: I have to leave, but if James_F can't help, try #parsoid
[20:17:15] <Pickle-san__>	 hexmode: Thanks, man -- I really appreciate your help!
[20:17:19] <Krenair>	 hmm
[20:17:27] <Krenair>	 my review dashboard no longer fits on my laptop screen
[20:17:35] <Krenair>	 (the "outgoing reviews" section)
[20:18:25] <James_F>	 Krenair: Write less code!~
[20:18:27] <James_F>	 No, wait.
[20:21:28] <grrrit-wm>	 (03CR) 10Catrope: "Do we still need this? It seems Parsoid is taking care of this now, at least partially: when you edit a page that has refs but no reflist," [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://phabricator.wikimedia.org/T56906) (owner: 10Alex Monk)
[20:22:38] <grrrit-wm>	 (03CR) 10Jforrester: "Still needed from the UX perspective." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://phabricator.wikimedia.org/T56906) (owner: 10Alex Monk)
[20:25:34] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] MenuSectionOptionWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/199153 (owner: 10Kmenger)
[20:26:19] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Internet-Explorer: Pressing Backspace/Delete or creating a heading causes the page to abruptly scroll up on Internet Explorer 11 - https://phabricator.wikimedia.org/T73119#1150580 (10TTO) 5duplicate>3Open
[20:26:20] <wikibugs>	 10VisualEditor: VisualEditor: Using the VE toolbar in MSIE causes the cursor to jump to the start of the page - https://phabricator.wikimedia.org/T75294#1150581 (10TTO)
[20:26:32] <wikibugs>	 10VisualEditor, 7Browser-Support-Internet-Explorer: Screen jumps on Internet Explorer 11 when deleting selected text. - https://phabricator.wikimedia.org/T93930#1150585 (10TTO)
[20:26:33] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Internet-Explorer: Pressing Backspace/Delete or creating a heading causes the page to abruptly scroll up on Internet Explorer 11 - https://phabricator.wikimedia.org/T73119#748392 (10TTO)
[20:27:12] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] SearchWidget: Add description and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/199144 (owner: 10Kmenger)
[20:27:51] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] TabIndexElement: Mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/198765 (owner: 10Kmenger)
[20:28:01] <Pickle-san__>	 James_F: I deleted node_modules and reran npm install.  The page still hangs when I invoke VE.
[20:28:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: MenuSectionOptionWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/199153 (owner: 10Kmenger)
[20:29:13] <Pickle-san__>	 James_F: By the way, I have blanked out MediaWiki:Common.js.
[20:29:17] <James_F>	 Pickle-san__: Did npm install correctly?
[20:29:39] <RoanKattouw>	 Krenair: OK so https://gerrit.wikimedia.org/r/#/c/198393/2 looks good to me, I'll just have to test it
[20:29:54] <RoanKattouw>	 Krenair: The only thing keeping that RESTbase change [WIP] is the lack of revision ID checks
[20:29:59] <Pickle-san__>	 James_F: So far as I can tell.  There are no reported errors.
[20:30:04] <RoanKattouw>	 Krenair: Would you have time to integrate those two?
[20:30:22] <James_F>	 Pickle-san__: Did you get any errors in the console or the MediaWiki error log/
[20:30:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: SearchWidget: Add description and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/199144 (owner: 10Kmenger)
[20:31:05] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] LookupElement: Add description and mark private and protected methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/198806 (owner: 10Kmenger)
[20:31:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: TabIndexElement: Mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/198765 (owner: 10Kmenger)
[20:31:40] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] ButtonElement: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/198761 (owner: 10Kmenger)
[20:31:47] <Krenair>	 RoanKattouw, it looks like they can both go together cleanly?
[20:32:00] <RoanKattouw>	 Hmm, I guess so?
[20:32:08] <Krenair>	 I guess full integration would be retrying only the older request
[20:32:15] <RoanKattouw>	 Yeah I was about to say
[20:32:18] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] PanelLayout: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/198417 (owner: 10Kmenger)
[20:32:50] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Layout: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/198400 (owner: 10Kmenger)
[20:32:54] <Krenair>	 we could merge them and open a tech debt bug to do it better?
[20:33:04] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] FieldLayout: Clarify description and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/198281 (owner: 10Kmenger)
[20:33:04] <Pickle-san__>	 James_F: In the console: ""VisualEditor failed to load: Error: Module ext.visualEditor.core has failed dependencies""
[20:33:05] <Krenair>	 I'm not convinced this error will come up often enough
[20:33:19] <RoanKattouw>	 I guess so
[20:33:28] <RoanKattouw>	 Pickle-san__: Is your lib/ve directory empty?
[20:33:29] <James_F>	 Pickle-san__: Did you update mediawiki/vendor?
[20:33:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] FieldsetLayout: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/198275 (owner: 10Kmenger)
[20:34:52] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] FormLayout: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/198296 (owner: 10Kmenger)
[20:35:15] <Pickle-san__>	 RoanKattouw: Where is this directory located?
[20:35:26] <RoanKattouw>	 Pickle-san__: extensions/VisualEditor/lib/ve
[20:35:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: LookupElement: Add description and mark private and protected methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/198806 (owner: 10Kmenger)
[20:35:37] <grrrit-wm>	 (03PS5) 10Mvolz: [BREAKING] Make Citoid use service-template-node and service-runner [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac)
[20:35:56] <Pickle-san__>	 James_F: I did run composer update.  Will that update the vendor directory?
[20:36:22] <James_F>	 Pickle-san__: In the MediaWiki root? Yes.
[20:36:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: ButtonElement: Clarify description [oojs/ui] - 10https://gerrit.wikimedia.org/r/198761 (owner: 10Kmenger)
[20:36:29] <Krenair>	 RoanKattouw, want to remove the WIP tag then? :)
[20:36:53] <Krenair>	 or we can merge my commit first, then test yours again
[20:36:58] <Pickle-san__>	 RoanKattouw: lib/ve is not empty.  Should it be.  Contents: AUTHORS.txt  build            demos    Gemfile.lock  i18n  LICENSE.txt   README.md  tests bin          CONTRIBUTING.md  Gemfile  Gruntfile.js  lib   package.json  src
[20:37:00] <RoanKattouw>	 Let's do the latter
[20:37:11] <James_F>	 Pickle-san__: No, that's good.
[20:37:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: PanelLayout: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/198417 (owner: 10Kmenger)
[20:37:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Layout: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/198400 (owner: 10Kmenger)
[20:37:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: FieldLayout: Clarify description and mark private methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/198281 (owner: 10Kmenger)
[20:37:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: FieldsetLayout: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/198275 (owner: 10Kmenger)
[20:38:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: FormLayout: Add description, example, and mark private method [oojs/ui] - 10https://gerrit.wikimedia.org/r/198296 (owner: 10Kmenger)
[20:39:04] <Pickle-san__>	 RoanKattouw: I suspect my software versions are out-of-sync.  What versions of MW and VE are you running?
[20:39:27] <grrrit-wm>	 (03CR) 10Mvolz: [C: 032] "Just updated minor version number- and we're good to go!" [services/citoid] - 10https://gerrit.wikimedia.org/r/199250 (https://phabricator.wikimedia.org/T75993) (owner: 10Mobrovac)
[20:39:46] <grrrit-wm>	 (03PS4) 10Mvolz: Add test for exporting bibtex [services/citoid] - 10https://gerrit.wikimedia.org/r/199623 (https://phabricator.wikimedia.org/T91168) 
[20:42:34] <grrrit-wm>	 (03PS5) 10Mvolz: Fix Content-Type header and add test for bibtex exports [services/citoid] - 10https://gerrit.wikimedia.org/r/199623 (https://phabricator.wikimedia.org/T91168) 
[20:42:41] <RoanKattouw>	 Pickle-san__: 17258584bdcec953ad563ecb91ab7ef5e18565f6 of MW core and 8f012e76cea820af2a09b98bf361416a21cfe74c of VE
[20:42:50] <RoanKattouw>	 And cb06317a7be0c6b1b3d624abbc5e5b737e9fbccf of lib/ve
[20:43:08] <RoanKattouw>	 And 0313fcc74a8a012a6028a688ef6cb74a7a563017 of Parsoid
[20:44:04] <grrrit-wm>	 (03CR) 10Mvolz: "(Just updated patch version and fixed up message, LGTM!)" [services/citoid] - 10https://gerrit.wikimedia.org/r/199623 (https://phabricator.wikimedia.org/T91168) (owner: 10Mvolz)
[20:44:06] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design: Regression on Checkboxes and radio buttons  - https://phabricator.wikimedia.org/T93944#1150683 (10violetto) 3NEW
[20:44:22] <wikibugs>	 10OOjs-UI, 10UI-Standardization, 7Design: Regression on Checkboxes and radio buttons - https://phabricator.wikimedia.org/T93944#1150690 (10violetto)
[20:44:28] <grrrit-wm>	 (03CR) 10Trevor Parscal: "I still am a bit confused about switching to Helvetica here. I'm not saying it's a bad font, or that we shouldn't consider it, but it's no" [oojs/ui] - 10https://gerrit.wikimedia.org/r/197097 (https://phabricator.wikimedia.org/T92858) (owner: 10Nirzar)
[20:44:40] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] Defining font stack for modal windows and widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/197097 (https://phabricator.wikimedia.org/T92858) (owner: 10Nirzar)
[20:46:29] <grrrit-wm>	 (03PS3) 10Catrope: Check for the two revision IDs returned by the server being different [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198393 (https://phabricator.wikimedia.org/T92993) (owner: 10Alex Monk)
[20:46:45] <Pickle-san__>	 RoanKattouw: Inside MediaWiki directory. # git checkout 17258584 error: pathspec '17258584' did not match any file(s) known to git.
[20:47:03] <Pickle-san__>	 RoanKattouw: Is core different than mwf23?
[20:47:09] <RoanKattouw>	 Pickle-san__: Oh I'm using master of core right now
[20:47:13] <RoanKattouw>	 wmf23 should probably work too
[20:47:45] <Pickle-san__>	 RoanKattouw: After the checkout, do I need to perform a git pull?
[20:48:00] <RoanKattouw>	 You may need to run git pull or git fetch before git knows about these commits
[20:48:04] <RoanKattouw>	 Because they're all pretty recent
[20:50:15] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Check for the two revision IDs returned by the server being different [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198393 (https://phabricator.wikimedia.org/T92993) (owner: 10Alex Monk)
[20:51:06] <wikibugs>	 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1150707 (10Jdforrester-WMF)
[20:51:07] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24): Handle page content data being for a different revision compared to the API-added data - https://phabricator.wikimedia.org/T92993#1150705 (10Jdforrester-WMF) 5Open>3Resolved
[20:52:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check for the two revision IDs returned by the server being different [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198393 (https://phabricator.wikimedia.org/T92993) (owner: 10Alex Monk)
[20:52:51] <wikibugs>	 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1150728 (10ssastry) Logs from Kibana:  * Bad title text <a href="Phil%20Donahue" rel="mw:WikiLink">Phil [Donahue]</a> * Bad title text <a href="https://uk.wikipedia.o...
[20:55:43] <Pickle-san__>	 RoanKattouw:  OK, thanks.  Well, the Visual Editor page renders now, but I'm back to the problem that hexmode helped me solve, where a page other than the one selected is presented for editing.  He believed this was fixed in a later commit.
[20:56:26] <Pickle-san__>	 RoanKattouw: The ticket is https://phabricator.wikimedia.org/T74480
[21:02:10] <wikibugs>	 10VisualEditor, 10VisualEditor-Initialisation, 7Browser-Support-Internet-Explorer, 5WMF-deploy-2015-03-11_(1.25wmf21): MediaWiki api Cache-Control headers are different than MediaWiki's.  This causes problems for VE users on some browsers. - https://phabricator.wikimedia.org/T74480#1150760 (10Jdforrester-WM...
[21:02:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) (owner: 10Esanders)
[21:03:04] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 5Patch-For-Review, 5WMF-deploy-2015-04-01_(1.25wmf24): Extension which render inline tags are un-editable - https://phabricator.wikimedia.org/T93712#1150761 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal
[21:03:59] <grrrit-wm>	 (03CR) 10Mobrovac: [C: 032 V: 032] Fix Content-Type header and add test for bibtex exports [services/citoid] - 10https://gerrit.wikimedia.org/r/199623 (https://phabricator.wikimedia.org/T91168) (owner: 10Mvolz)
[21:06:38] <RoanKattouw>	 edsanders: So, this.$element = $( this.model.getOriginalDomElements() );
[21:06:42] <RoanKattouw>	 edsanders: See a problem there? :P
[21:08:55] <grrrit-wm>	 (03PS1) 10Catrope: Follow-up 80a07cf5cb: don't use DM DOM nodes directly in CE DOM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199693 
[21:09:07] <RoanKattouw>	 edsanders: https://gerrit.wikimedia.org/r/199693
[21:10:04] <guillom>	 RoanKattouw: I've done two more diff review sessions (one for frwp, one for enwp) and most of them were either ok or already-reported bugs. There's only one diff for which I have no idea what happened: https://fr.wikipedia.org/w/index.php?diff=113225029 ; Do you have any idea?
[21:10:45] <guillom>	 At first I thought the user had manually inserted a wikitext link, but then I remembered that entering [[ now opened the link dialog, so I don't know.
[21:11:20] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Follow-up 80a07cf5cb: don't use DM DOM nodes directly in CE DOM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199693 (owner: 10Catrope)
[21:11:52] <RoanKattouw>	 guillom: I'm not sure
[21:12:16] <guillom>	 ok; it's in the "unknown" category so I can leave it at that
[21:12:25] <guillom>	 I just thought I'd ask
[21:12:30] <RoanKattouw>	 Yeah I tested and you can't type [[
[21:12:33] <RoanKattouw>	 I don't know what's going on there
[21:12:44] <guillom>	 Maybe a copy-paste of an existing wikitext link
[21:12:47] <wikibugs>	 10OOjs-UI: ButtonElements should be uniform height with any combination of label, icon and indicator - including none of them - https://phabricator.wikimedia.org/T93290#1150799 (10Jdforrester-WMF)
[21:12:48] <wikibugs>	 10OOjs-UI, 10VisualEditor, 10VisualEditor-EditingTools, 7Regression, and 2 others: [Regression pre-wmf22] Template dialog has footer line crossing through button - https://phabricator.wikimedia.org/T92986#1150800 (10Jdforrester-WMF)
[21:12:59] <guillom>	 i.e. if you paste [[foo|bar]] in VE
[21:13:15] <wikibugs>	 10OOjs-UI: ButtonElements should be uniform height with any combination of label, icon and indicator - including none of them - https://phabricator.wikimedia.org/T93290#1150805 (10Jdforrester-WMF) 5duplicate>3Open Drat, wrong one.
[21:13:24] <wikibugs>	 10VisualEditor: [Regression - wmf22] "Show options" overlaps seperation line - https://phabricator.wikimedia.org/T93361#1150807 (10Jdforrester-WMF)
[21:13:27] <wikibugs>	 10OOjs-UI, 10VisualEditor, 10VisualEditor-EditingTools, 7Regression, and 2 others: [Regression pre-wmf22] Template dialog has footer line crossing through button - https://phabricator.wikimedia.org/T92986#1125952 (10Jdforrester-WMF)
[21:14:47] <aharoni>	 it's kinda painful that in the VE survey I can only select one thing that is important for me to improve.
[21:15:01] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: When splitting a paragraph, trim whitespace from the start of the new one - https://phabricator.wikimedia.org/T93935#1150811 (10gpaumier)
[21:23:37] <grrrit-wm>	 (03PS4) 10Nirzar: Removing extra font-family definitions, fonts will inherit from body [oojs/ui] - 10https://gerrit.wikimedia.org/r/197097 (https://phabricator.wikimedia.org/T92858) 
[21:34:53] <wikibugs>	 10VisualEditor, 5Patch-For-Review: MWExtensionInspector should inherit from NodeInspector - https://phabricator.wikimedia.org/T93592#1150922 (10Jdforrester-WMF) p:5Triage>3Normal
[21:35:30] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: "Error: offset was inside an ignoreChildren node" appears while triple-clicking on an empty line when an image is the first item of the page - https://phabricator.wikimedia.org/T93461#1150926 (10Jdforrester-WMF) a:3Catrope
[21:36:19] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 5WMF-deploy-2015-04-01_(1.25wmf24): Extension which render inline tags are un-editable - https://phabricator.wikimedia.org/T93712#1143920 (10Jdforrester-WMF)
[21:36:51] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22), 5WMF-deploy-2015-03-25_(1.25wmf23): [Regression wmf22] Link removal doesn't work on first click anymore - https://phabricator.wikimedia.org/T93363#1150942 (10Jdforrester-WMF)
[21:38:18] <Krenair>	 RoanKattouw_away, actually they don't seem to work together
[21:40:15] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Follow-up 80a07cf5cb: don't use DM DOM nodes directly in CE DOM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199693 (owner: 10Catrope)
[21:40:46] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Removing extra font-family definitions, fonts will inherit from body [oojs/ui] - 10https://gerrit.wikimedia.org/r/197097 (https://phabricator.wikimedia.org/T92858) (owner: 10Nirzar)
[21:40:50] <RoanKattouw>	 Krenair: Oh? How's that?
[21:41:15] <RoanKattouw>	 Krenair: I did say in the commit msg that some more things needed to be moved client-side but I don't think I ever got around to doing that
[21:41:19] <RoanKattouw>	 The old page notice is one thing
[21:41:35] <RoanKattouw>	 But I think I hacked around exposing the revid properly as well
[21:41:46] <Krenair>	 right
[21:41:52] <Krenair>	 that's the issue
[21:42:21] <Krenair>	 but now it's actually broken by the commit we just merged
[21:42:30] <Krenair>	 because oldid is undefined
[21:42:38] <RoanKattouw>	 sucheta: I reviewed your commit
[21:42:40] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release, 7Design: OOjs UI redefines font-family to sans-serif in windows and widgets when it should just inherit - https://phabricator.wikimedia.org/T92858#1150977 (10Jdforrester-WMF) 5Open>3Resolved
[21:42:45] <RoanKattouw>	 sucheta: You also said you needed help with something?
[21:43:13] <RoanKattouw>	 Krenair: Right but my commit is what makes oldid undefined, right, not your commit?
[21:43:19] <wikibugs>	 10OOjs-UI, 5OOjs-UI-next-release: Buttons explode in narrow containers - https://phabricator.wikimedia.org/T93552#1150986 (10Jdforrester-WMF)
[21:43:25] <RoanKattouw>	 So your commit is now constantly throwing false positives because my commit left oldid undefined?
[21:43:39] <Krenair>	 yes
[21:43:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Follow-up 80a07cf5cb: don't use DM DOM nodes directly in CE DOM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199693 (owner: 10Catrope)
[21:43:43] <RoanKattouw>	 OK
[21:43:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removing extra font-family definitions, fonts will inherit from body [oojs/ui] - 10https://gerrit.wikimedia.org/r/197097 (https://phabricator.wikimedia.org/T92858) (owner: 10Nirzar)
[21:44:33] <RoanKattouw>	 edsanders: Can you review https://gerrit.wikimedia.org/r/#/c/196741/ and up?
[21:44:55] <wikibugs>	 10VisualEditor, 10VisualEditor-Tables: Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1151009 (10Thryduulf) I don't know whether it is normal or not in other editors, but it is distinctly non-intuitive in the context of editing...
[21:45:21] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/198303
[21:45:30] <RoanKattouw>	 edsanders: https://gerrit.wikimedia.org/r/198138
[21:45:42] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/198258 https://gerrit.wikimedia.org/r/197906
[21:45:58] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/198131
[21:47:09] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Add 'isGenerating' method to ve.ce.GeneratedContentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198138 (owner: 10Mooeypoo)
[21:47:18] <wikibugs>	 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Performance, 7Performance: On VisualEditor load, async pre-load all the TemplateData for the page to make editing templates speedier - https://phabricator.wikimedia.org/T66772#1151024 (10Krenair) I think this is something we could do after the pag...
[21:51:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add 'isGenerating' method to ve.ce.GeneratedContentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198138 (owner: 10Mooeypoo)
[21:52:17] <edsanders>	 RoanKattouw, that explains this then https://gerrit.wikimedia.org/r/#/c/199618/3/modules/ve-mw/tests/ce/ve.ce.ContentBranchNode.test.js
[21:52:57] <RoanKattouw>	 Oh yes
[21:53:04] <RoanKattouw>	 You're right
[21:53:10] <RoanKattouw>	 I saw that on James's screen but dismissed it
[21:53:10] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Fix context height and padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197906 (owner: 10Esanders)
[21:53:27] <RoanKattouw>	 But I happen to have an alienated image on my main page, and it got dirtied to [[File:Foo.png|thumb|class=ve-ce-leafNode ve-ce-focusableNode]]
[21:55:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix context height and padding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197906 (owner: 10Esanders)
[21:55:36] <grrrit-wm>	 (03PS1) 10Mooeypoo: Show beta welcome dialog before surface is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) 
[21:57:52] <wikibugs>	 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review, and 3 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1151101 (10gpaumier)
[21:58:27] <grrrit-wm>	 (03PS1) 10Jforrester: Tag v0.9.4 [oojs/ui] - 10https://gerrit.wikimedia.org/r/199756 
[21:58:40] <sucheta>	 RoanKattouw, Going through the review; will talk about the other thing next 
[22:04:09] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] Allow override of 'actions' toolbar group (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198303 (owner: 10EBernhardson)
[22:05:23] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Load and display the welcome dialog straight after the toolbar, without waiting for the content area - https://phabricator.wikimedia.org/T90454#1151170 (10Mooeypoo) a:3Mooeypoo
[22:07:22] <grrrit-wm>	 (03PS2) 10Jforrester: Allow override of 'actions' toolbar group [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198303 (owner: 10EBernhardson)
[22:07:34] <grrrit-wm>	 (03CR) 10Jforrester: Allow override of 'actions' toolbar group (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198303 (owner: 10EBernhardson)
[22:11:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Allow override of 'actions' toolbar group [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198303 (owner: 10EBernhardson)
[22:13:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow override of 'actions' toolbar group [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198303 (owner: 10EBernhardson)
[22:16:32] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Show beta welcome dialog before surface is ready (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) (owner: 10Mooeypoo)
[22:18:17] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Tag v0.9.4 [oojs/ui] - 10https://gerrit.wikimedia.org/r/199756 (owner: 10Jforrester)
[22:22:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tag v0.9.4 [oojs/ui] - 10https://gerrit.wikimedia.org/r/199756 (owner: 10Jforrester)
[22:22:57] <grrrit-wm>	 (03CR) 10Mooeypoo: Show beta welcome dialog before surface is ready (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) (owner: 10Mooeypoo)
[22:23:16] <wikibugs>	 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 3Multimedia-Sprint-2015-03-25, 5Patch-For-Review: Use source urls in mw.loader.store - https://phabricator.wikimedia.org/T90524#1061235 (10Tgr)
[22:23:49] <grrrit-wm>	 (03PS2) 10Mooeypoo: Show beta welcome dialog before surface is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) 
[22:26:01] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.9.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199764 
[22:27:26] <grrrit-wm>	 (03PS1) 10Legoktm: Remove unused code, pass phpcs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199767 
[22:34:18] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Show beta welcome dialog before surface is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) (owner: 10Mooeypoo)
[22:34:54] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.9.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199764 (owner: 10Jforrester)
[22:36:39] <grrrit-wm>	 (03PS1) 10Legoktm: Add extension.json [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199771 (https://phabricator.wikimedia.org/T87993) 
[22:37:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.9.4 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199764 (owner: 10Jforrester)
[22:41:30] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add extension.json [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199771 (https://phabricator.wikimedia.org/T87993) (owner: 10Legoktm)
[22:42:34] <grrrit-wm>	 (03PS2) 10Legoktm: Add extension.json [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199771 (https://phabricator.wikimedia.org/T87993) 
[22:42:37] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Remove unused code, pass phpcs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199767 (owner: 10Legoktm)
[22:42:44] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] "PS2: cherry-picked to master to avoid dependency" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199771 (https://phabricator.wikimedia.org/T87993) (owner: 10Legoktm)
[22:42:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add extension.json [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199771 (https://phabricator.wikimedia.org/T87993) (owner: 10Legoktm)
[22:43:24] <wikibugs>	 10WikiEditor, 5Patch-For-Review: Convert WikiEditor to use extension registration - https://phabricator.wikimedia.org/T87993#1151360 (10Legoktm) 5Open>3Resolved a:3Legoktm
[22:43:27] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Remove unused code, pass phpcs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199767 (owner: 10Legoktm)
[22:43:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused code, pass phpcs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199767 (owner: 10Legoktm)
[22:43:35] <James_F>	 legoktm: Patience, grasshopper.
[22:43:49] <legoktm>	 :P
[22:43:54] <wikibugs>	 10WikiEditor, 5WMF-deploy-2015-04-01_(1.25wmf24): Convert WikiEditor to use extension registration - https://phabricator.wikimedia.org/T87993#1151372 (10Jdforrester-WMF)
[22:45:20] <James_F>	 legoktm: When's the next set of extensions we're switching over happening?
[22:45:28] <James_F>	 legoktm: Pre-1.26wmf1? :-)
[22:46:55] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (731b3ad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199775 
[22:47:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (731b3ad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199775 (owner: 10Jforrester)
[22:47:51] <legoktm>	 James_F: umm, how about in 13 minutes?
[22:48:06] <James_F>	 legoktm: WFM.
[22:48:20] <James_F>	 legoktm: WE + VE in the midst?
[22:48:50] <James_F>	 legoktm: (Actually, SWAT will likely be delayed; group2 isn't even on wmf22 yet.)
[22:49:12] <legoktm>	 argh
[22:49:31] <James_F>	 Yeah.
[22:50:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (731b3ad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199775 (owner: 10Jforrester)
[22:54:00] <grrrit-wm>	 (03PS3) 10Mooeypoo: Show beta welcome dialog before surface is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) 
[23:01:00] <grrrit-wm>	 (03PS4) 10Mooeypoo: Show beta welcome dialog before surface is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) 
[23:01:47] <wikibugs>	 10VisualEditor: Safari: progress bar gets stuck with "TypeError: undefined is not an object ..."  - https://phabricator.wikimedia.org/T93964#1151395 (10Etonkovidova) 3NEW
[23:03:25] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Show beta welcome dialog before surface is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) (owner: 10Mooeypoo)
[23:21:42] <wikibugs>	 10VisualEditor: Highlighting is off for inserted template/ inserted media - https://phabricator.wikimedia.org/T93660#1151496 (10Jdforrester-WMF) I can't reproduce now – fixed?
[23:22:37] <wikibugs>	 10VisualEditor, 10VisualEditor-ContentEditable: Highlighting is mis-aligned for inserted template/ inserted media once you open the save dialog and dismiss it - https://phabricator.wikimedia.org/T93660#1151499 (10Jdforrester-WMF)
[23:23:47] <grrrit-wm>	 (03PS1) 10Legoktm: Use __DIR__ [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199785 
[23:23:48] <wikibugs>	 10OOjs-UI, 10VisualEditor, 10VisualEditor-EditingTools, 7Regression, and 3 others: [Regression pre-wmf22] Template dialog has footer line crossing through button - https://phabricator.wikimedia.org/T92986#1151515 (10Etonkovidova)
[23:23:56] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Parsoid: First paragraph for news articles at fr.news ends up inside Template:Date - https://phabricator.wikimedia.org/T90921#1151518 (10Jdforrester-WMF)
[23:24:17] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Use __DIR__ [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199785 (owner: 10Legoktm)
[23:24:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use __DIR__ [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199785 (owner: 10Legoktm)
[23:36:40] <wikibugs>	 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 10Wikidata: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1151597 (10hoo)
[23:39:12] <wikibugs>	 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 7Blocked-on-Editing, 5Patch-For-Review: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#1151601 (10Tgr) 5Open>3stalled Abandoned for now, see T92247#1147500.
[23:39:41] <wikibugs>	 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 7Blocked-on-Editing, 5Patch-For-Review: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#1151616 (10Tgr)
[23:40:18] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "Until we figure out a way to know if a template is generating a references list (such as the often used {{Reflist}} template) we can't dep" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://phabricator.wikimedia.org/T56906) (owner: 10Alex Monk)
[23:43:31] <wikibugs>	 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 7Blocked-on-Editing, 5Patch-For-Review: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#1151654 (10Tgr)
[23:44:10] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Initialize this.$window in ve.ui.Toolbar constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199793 
[23:44:41] <grrrit-wm>	 (03PS2) 10Catrope: Initialize this.$window in ve.ui.Toolbar constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199793 (owner: 10Trevor Parscal)
[23:44:45] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Initialize this.$window in ve.ui.Toolbar constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199793 (owner: 10Trevor Parscal)
[23:48:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Initialize this.$window in ve.ui.Toolbar constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199793 (owner: 10Trevor Parscal)
[23:53:10] <grrrit-wm>	 (03PS1) 10Kmenger: BookletLayout: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/199797