[00:11:30] (03CR) 10Esanders: "This patch is conceptually fine, but you exposed a flaw in our current implementation, so see If657b29e30 for the correct approach." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [00:36:12] James_F, it looks like standup and Lila's breakfast are both scheduled for 10:00 a.m. PDT. Which one will you be attending? [01:01:56] meh I'm not getting change id in my commit [01:02:13] I'm doing git commit --all and there's no change-id in the commit message. [01:03:14] (03PS1) 10Mooeypoo: Add a flag to BranchNode to ignore slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) [01:03:15] oh there it is [01:05:11] (03PS1) 10Mooeypoo: Hide slugs in context menus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200086 (https://phabricator.wikimedia.org/T93042) [01:05:34] 10OOjs-UI, 10OOjs-UI-0.9.1, 10UI-Standardization, 7Design, and 2 others: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1155799 (10Prtksxna) [01:05:36] (03CR) 10Catrope: [C: 04-1] "setupSlugs is called from other places too. You're probably better off sabotaging the method itself as opposed to sabotaging its callers." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [01:06:02] heh, I just thought about it too. [01:06:28] (03CR) 10Catrope: [C: 04-1] "Should also address other places where this is used. I can think of at least MWReferencesListNode, and probably also the citoid inspector?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200086 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [01:06:57] (03CR) 10Mooeypoo: "I am also concerned that slugs aren't the only issue, but for the moment, we I think ignoring them specifically can be a decent fix. We ca" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [01:08:54] (03CR) 10Mooeypoo: "@Catrope, yes, Citoid is definitely going to be next, and I was going to also search for other context and general preview locations to us" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200086 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [01:09:02] RoanKattouw_away, just for the record: I'm not complaining! [01:09:10] just saying. [01:16:04] (03PS2) 10Mooeypoo: Add a flag to BranchNode to ignore slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) [01:22:18] (03CR) 10Mooeypoo: "Actually, thinking about this now, should I call the config option "preview" to begin with? This way, we can use it to hide slugs now, but" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200086 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [01:35:30] hm plot thickens. [01:41:15] (03PS3) 10Mooeypoo: Add an isPreview flag to BranchNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) [01:42:27] (03PS2) 10Mooeypoo: Hide slugs in context menus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200086 (https://phabricator.wikimedia.org/T93042) [01:54:58] (03PS3) 10Mooeypoo: Hide slugs in context menus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200086 (https://phabricator.wikimedia.org/T93042) [01:55:18] James_F, what was that rule about hacks? I should add a phabricator ticket? [01:55:24] mooeypoo: Ideally, yes. [01:55:45] ok, doing that now [01:56:13] I'll tackle roan and ed tomorrow to see if my hack may be solved in a different way, but the tech debt should probably be there anyways. Adding the ticket now as tech debt [02:00:11] 10VisualEditor, 7Technical-Debt: Tech debt: Devise a stable way to create previews for ce nodes - https://phabricator.wikimedia.org/T94130#1155843 (10Mooeypoo) 3NEW [02:07:13] 10OOjs-UI, 10OOjs-UI-0.9.1, 10UI-Standardization, 7Design, and 2 others: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1155854 (10APerson) @Jaredzimmerman-WMF Thanks for clarifying! I agree that accessibility trumps aesthetics, and I'm happy to see that there was a gre... [02:34:48] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1155874 (10ferdbold) [02:41:52] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt: Tech debt: Devise a stable way to create previews for ce nodes - https://phabricator.wikimedia.org/T94130#1155879 (10Jdforrester-WMF) p:5Triage>3Normal [02:42:18] 10VisualEditor, 10VisualEditor-MediaWiki: oldid is not added to the VE edittab link, when opening an oldid in the Wikitext Editor. - https://phabricator.wikimedia.org/T94084#1155884 (10Jdforrester-WMF) p:5Triage>3Normal [02:42:56] 10VisualEditor, 10VisualEditor-ContentEditable: Insertion annotation not rendered correctly when coming from the "wrong side" - https://phabricator.wikimedia.org/T94062#1155889 (10Jdforrester-WMF) p:5Triage>3Normal [02:43:30] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Oldid notice in VisualEditor is shown below the header - https://phabricator.wikimedia.org/T94082#1155891 (10Jdforrester-WMF) [02:44:06] 10VisualEditor, 10VisualEditor-MediaWiki: Category popup is vertically misaligned - https://phabricator.wikimedia.org/T94114#1155894 (10Jdforrester-WMF) [02:45:12] 10VisualEditor, 7Technical-Debt: SurfaceWidget should be called TargetWidget - https://phabricator.wikimedia.org/T94066#1155898 (10Jdforrester-WMF) Should it also be called a VisualTargetWidget with an abstract TargetWidget so we can trivially have WikitextTargetWidget and so on when we start on that in a few... [02:45:29] 10VisualEditor, 7Technical-Debt: SurfaceWidget should be called TargetWidget - https://phabricator.wikimedia.org/T94066#1155900 (10Jdforrester-WMF) p:5Triage>3Normal [02:47:46] 10VisualEditor, 10Parsoid: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1155902 (10Jdforrester-WMF) p:5Triage>3Unbreak! [02:47:59] 10VisualEditor, 10Parsoid: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1144780 (10Jdforrester-WMF) I suspect an ID issue. [02:48:18] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, and 2 others: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1155908 (10FRacco) I had the same problem with my [[https://it.wikiquote.org/wiki/Utente:FRacco/common.js|personal toolbar]] on... [02:50:41] 10OOjs-UI: OOjs UI: Dialog emits "closing" event 250ms after close() is invoked - https://phabricator.wikimedia.org/T66775#1155909 (10Jdforrester-WMF) a:3TrevorParscal [02:51:10] 10OOjs-UI: OOjs UI: Selected text in readonly/disabled TextInputWidget is hard to read on Chrome on Linux - https://phabricator.wikimedia.org/T65840#1155911 (10Jdforrester-WMF) a:3sucheta [02:51:45] 10OOjs-UI: OOjs UI: [Regression pre-wmf4] footless dialogs broken - https://phabricator.wikimedia.org/T66808#1155913 (10Jdforrester-WMF) a:3Jdforrester-WMF [02:51:56] 10OOjs-UI: OOjs UI: Windows have no visual loading state - https://phabricator.wikimedia.org/T70669#1155915 (10Jdforrester-WMF) a:3Catrope [02:52:12] 10OOjs-UI: OOjs UI: Need a way to add a non-functional label to the top of a popupToolGroup (within the popup) - https://phabricator.wikimedia.org/T67377#1155917 (10Jdforrester-WMF) a:3kaldari [02:52:39] 10OOjs-UI: Allow to drag and move pop up windows - https://phabricator.wikimedia.org/T69952#1155919 (10Jdforrester-WMF) 5Resolved>3declined [02:52:44] 10OOjs-UI: OOjs UI: Dialogs resize horizontally but stay at full height when browser window is enlarged - https://phabricator.wikimedia.org/T70213#1155921 (10Jdforrester-WMF) a:3matmarex [02:53:09] 10OOjs-UI: OOjs UI: RTL flipping in the build pipeline broken - https://phabricator.wikimedia.org/T72323#1155924 (10Jdforrester-WMF) p:5Triage>3Normal a:3Jdforrester-WMF [02:53:35] 10OOjs-UI, 7Design, 7I18n: OOjs UI: Auto-shortening of dialog titles when there's insufficient space isn't working - https://phabricator.wikimedia.org/T70571#1155926 (10Jdforrester-WMF) a:3matmarex [02:53:51] 10OOjs-UI, 7Browser-Support-Firefox: OOjs UI: Non-OOUI underlines for a:hover show up above selection options in Firefox - https://phabricator.wikimedia.org/T73651#1155929 (10Jdforrester-WMF) 5Resolved>3declined [02:54:06] 10OOjs-UI, 7Accessibility: ButtonOptionWidget should be keyboard navigable - https://phabricator.wikimedia.org/T88085#1155931 (10Jdforrester-WMF) a:3TheDJ [02:54:23] 10OOjs-UI: OOjs UI: optionWidget with check icon should not appear for invalid entries in the category input field. - https://phabricator.wikimedia.org/T74000#1155932 (10Jdforrester-WMF) a:3matmarex [02:58:15] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, and 2 others: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1155933 (10FRacco) I had the same problem with my [[https://it.wikiquote.org/wiki/Utente:FRacco/common.js|personal toolbar]] on... [03:36:34] (03PS1) 10Physikerwelt: test [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200099 [03:37:20] (03CR) 10Physikerwelt: "recheck" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200099 (owner: 10Physikerwelt) [03:37:25] (03CR) 10jenkins-bot: [V: 04-1] test [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200099 (owner: 10Physikerwelt) [03:40:23] (03PS2) 10Physikerwelt: test [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200099 [03:41:45] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1155957 (10ferdbold) [03:42:44] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1140552 (10ferdbold) [03:46:14] 10VisualEditor, 10Parsoid: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1155961 (10Arlolra) If so, will probably be addressed with https://gerrit.wikimedia.org/r/#/c/199984/ [03:49:51] (03PS3) 10Physikerwelt: Temporary disable foreign keys for mathindex table [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200099 (https://phabricator.wikimedia.org/T94134) [03:50:31] (03CR) 10Physikerwelt: [C: 032] Temporary disable foreign keys for mathindex table [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200099 (https://phabricator.wikimedia.org/T94134) (owner: 10Physikerwelt) [03:52:03] (03Merged) 10jenkins-bot: Temporary disable foreign keys for mathindex table [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200099 (https://phabricator.wikimedia.org/T94134) (owner: 10Physikerwelt) [03:54:52] (03PS1) 10Physikerwelt: Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 [03:54:53] 10VisualEditor, 10Parsoid: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1155988 (10Arlolra) Ya, the id `sjabloon_zie` is duplicated from templates: {{zie dp}} and {{Zie artikel}} [03:56:06] (03Abandoned) 10Physikerwelt: wip live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/199886 (owner: 10Physikerwelt) [03:56:12] (03CR) 10jenkins-bot: [V: 04-1] Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 (owner: 10Physikerwelt) [04:00:45] 10VisualEditor, 10Parsoid: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1156000 (10Arlolra) I made this change, https://nl.wikipedia.org/w/index.php?title=Sjabloon%3AZie_artikel&diff=43710077&oldid=42670382 Now we wait for restbase to update. In general, th... [04:00:58] (03PS2) 10Physikerwelt: Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 [04:02:14] (03CR) 10jenkins-bot: [V: 04-1] Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 (owner: 10Physikerwelt) [04:11:13] (03PS3) 10Physikerwelt: Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 [04:12:36] (03CR) 10jenkins-bot: [V: 04-1] Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 (owner: 10Physikerwelt) [04:14:13] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1156016 (10Negative24) [04:25:04] (03PS4) 10Physikerwelt: Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 [04:26:27] (03CR) 10jenkins-bot: [V: 04-1] Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 (owner: 10Physikerwelt) [04:41:11] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review, and 3 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1156023 (10Mattflaschen) >>! In T90764#1155499, @Mattflaschen wrote: > Let's keep an eye on that. It may just be a box-sizing... [04:49:25] (03PS5) 10Physikerwelt: Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 [04:57:19] (03CR) 10Physikerwelt: [C: 032] Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 (owner: 10Physikerwelt) [04:58:44] (03CR) 10jenkins-bot: [V: 04-1] Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 (owner: 10Physikerwelt) [05:32:40] (03PS6) 10Physikerwelt: Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 [05:35:54] (03CR) 10Physikerwelt: [C: 032] Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 (owner: 10Physikerwelt) [05:38:09] (03Merged) 10jenkins-bot: Live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200100 (owner: 10Physikerwelt) [08:16:58] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to screenshots of the page settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200067 (owner: 10Amire80) [08:17:14] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to the "Apply changes" button screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200068 (owner: 10Amire80) [08:17:29] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to the Edit Links screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200066 (owner: 10Amire80) [08:17:42] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to the page settings item screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200065 (owner: 10Amire80) [08:18:29] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Show the full Formatting pull-down in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200055 (owner: 10Amire80) [08:23:49] (03Merged) 10jenkins-bot: [BrowserTest] Show the full Formatting pull-down in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200055 (owner: 10Amire80) [08:23:52] (03Merged) 10jenkins-bot: [BrowserTest] Add padding to the page settings item screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200065 (owner: 10Amire80) [08:23:54] (03Merged) 10jenkins-bot: [BrowserTest] Add padding to the Edit Links screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200066 (owner: 10Amire80) [08:23:56] (03Merged) 10jenkins-bot: [BrowserTest] Add padding to screenshots of the page settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200067 (owner: 10Amire80) [08:23:58] (03Merged) 10jenkins-bot: [BrowserTest] Add padding to the "Apply changes" button screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200068 (owner: 10Amire80) [09:34:44] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10VisualEditor-Tables: Support the editing of "tables" that are composed of templates - https://phabricator.wikimedia.org/T85462#1156183 (10TheDJ) I do have blue shields for Episode list rows now, but I can't edit them, nor do i have the green alienated shi... [09:58:31] 10VisualEditor, 6Engineering-Community, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T94144#1156209 (10Pratikbsp) a:3Pratikbsp [10:00:30] 10VisualEditor, 6Engineering-Community, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T94144#1156171 (10Pratikbsp) @Aklapper, I have completed it, does it... [10:11:16] 10VisualEditor, 6Engineering-Community, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T94144#1156228 (10Pratikbsp) [10:12:19] 10VisualEditor, 6Engineering-Community, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015: GSoC'15 Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T94144#1156229 (10Pratikbsp) [10:12:54] 10VisualEditor, 6Engineering-Community, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015: GSoC'15 Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T94144#1156171 (10Pratikbsp) [10:33:19] (03PS1) 10Esanders: Deprecate search widget event re-emission [oojs/ui] - 10https://gerrit.wikimedia.org/r/200128 [10:50:52] (03PS1) 10Esanders: Fix choose event listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200132 [10:51:45] (03PS1) 10Esanders: Fix choose event listeners [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200133 [10:53:49] 10VisualEditor, 6Engineering-Community, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015: GSoC'15 Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T94144#1156277 (10Qgil) [11:12:19] (03CR) 10Mobrovac: [C: 04-1] Restructure requestFromDOI + tests (033 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) (owner: 10Mvolz) [11:17:43] (03PS1) 10Amire80: [BrowserTest] Add padding to some more screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200138 [11:17:46] (03PS1) 10Amire80: [BrowserTest] Redefine the Apply changes element for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200139 [11:27:41] (03CR) 10Bartosz Dziewoński: [C: 031] Deprecate search widget event re-emission [oojs/ui] - 10https://gerrit.wikimedia.org/r/200128 (owner: 10Esanders) [11:33:24] 10VisualEditor, 10VisualEditor-Tables: When a table needs to wrap up input text, typing white spaces entered in front of the text make a cursor go forward and back - https://phabricator.wikimedia.org/T94103#1156401 (10Aklapper) [11:37:31] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1156411 (10Yurik) Should we call it GraphEditor or GraphVeEditor instead? Data seems incorrect. My biggest... [11:39:30] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to some more screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200138 (owner: 10Amire80) [11:39:52] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Redefine the Apply changes element for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200139 (owner: 10Amire80) [11:41:39] (03Merged) 10jenkins-bot: [BrowserTest] Add padding to some more screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200138 (owner: 10Amire80) [11:41:55] (03Merged) 10jenkins-bot: [BrowserTest] Redefine the Apply changes element for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200139 (owner: 10Amire80) [11:48:04] (03PS1) 10Amire80: [BrowserTest] Disable the Cite button screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200142 [11:52:01] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Disable the Cite button screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200142 (owner: 10Amire80) [11:54:08] (03Merged) 10jenkins-bot: [BrowserTest] Disable the Cite button screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200142 (owner: 10Amire80) [12:24:47] 10MediaWiki-ResourceLoader, 10Beta-Cluster: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences lacks normal styling - https://phabricator.wikimedia.org/T93050#1156511 (10Florian) Same on testwiki and test2wiki, btw. [12:39:27] now... I wait for California to wake up... [12:48:18] 10VisualEditor, 10Continuous-Integration, 7Browser-Tests, 7Tracking: Delete or fix failed VisualEditor browsertests Jenkins job - https://phabricator.wikimedia.org/T94162#1156565 (10zeljkofilipin) 3NEW [13:07:36] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1156614 (10Mvolz) We should actually just keep the files in the Graph Extension, there's no need for a sepa... [13:37:06] (03CR) 10Mvolz: Restructure requestFromDOI + tests (033 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) (owner: 10Mvolz) [13:37:18] (03PS3) 10Mvolz: Restructure requestFromDOI + tests [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) [13:39:06] 10Citoid, 6Services: Strip trailing slashes in url field - https://phabricator.wikimedia.org/T93311#1156682 (10Mvolz) p:5Normal>3Low [13:43:52] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1156697 (10Yurik) @Mvolz, no problems with +2, but gerrit permissions are scary, any experts in that? :) [13:48:09] 10Citoid: "Cite book" template offering less information than expected - https://phabricator.wikimedia.org/T94169#1156713 (10Elitre) [13:48:13] 10Citoid: ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1156715 (10Mvolz) http://www.ncbi.nlm.nih.gov/pubmed/653425957 gives me a nice http error so we should probably just use the direct link instead of the query and then everything downstream will be taken care of. [13:54:43] 10Citoid: "Cite book" template offering less information than expected - https://phabricator.wikimedia.org/T94169#1156735 (10Mvolz) This is kind of a duplicate of T1091 but we have a local copy of the translators repo now, so we should add 'v' option to our local copy for the time being. [13:54:58] 10Citoid: "Cite book" template offering less information than expected - https://phabricator.wikimedia.org/T94169#1156738 (10Mvolz) p:5Triage>3High a:3Mvolz [14:05:35] 10VisualEditor, 10Parsoid: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1156761 (10ssastry) id affects only data-parsoid and templates are serialized with data-mw .. and I had to scratch my head for a second before being convinced this is an id issue. Select... [14:09:24] 10Citoid: ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1156773 (10Elitre) As it should? It's the fictitious ID mobrovac created. I may be misunderstanding your comment :) [14:10:09] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1156775 (10Elitre) [14:37:32] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1156820 (10Mvolz) @Elitre, We get good results for news articles that are US based because we're using Zotero, and they have better covered in English than the... [14:41:16] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1156833 (10Mvolz) (tl;dr: we know why, it will hopefully get better with time, but probably not much better until people add specific translators to zotero for... [14:43:16] 10Citoid: ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1156836 (10Mvolz) @Elitre, yes, as it should. The other URL @mobrovac suggested was giving us a scraped page and a 200 ok server response, the one I just linked to gave us a 520, which would be a more correct response, sinc... [14:53:17] 10Citoid: Can't turn a link to Archive.org into a reference - https://phabricator.wikimedia.org/T94176#1156866 (10Elitre) 3NEW [14:54:38] 10VisualEditor, 6Engineering-Community, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015: GSoC'15 Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T94144#1156881 (10Pratikbsp) [14:56:35] 10Citoid: http://www.ncbi.nlm.nih.gov/pmc/articles/PMC999999/ crashes citoid - https://phabricator.wikimedia.org/T94178#1156884 (10Mvolz) 3NEW a:3Mvolz [15:09:18] (03PS14) 10Physikerwelt: Move integration tests to a new special page [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) [15:13:04] 10VisualEditor, 7Browser-Support-Internet-Explorer: Screen jumps in Internet Explorer 11 when clicking "Bullet list" or "Numbered list" in toolbar - https://phabricator.wikimedia.org/T93929#1156931 (10MarkAHershberger) Notes from reproducing this: * Hitting "undo" on the toolbar afterwards doesn't move the sc... [15:17:40] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1156934 (10ferdbold) @Yurik: As far as the name goes, I've simply based it on the existing TemplateData, wh... [15:20:02] 10Citoid, 5Patch-For-Review: Google Books translator offering less information than expected - https://phabricator.wikimedia.org/T94169#1156937 (10Jdforrester-WMF) [15:22:53] (03PS1) 10Physikerwelt: Remove formula from math index on article deletion [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200162 [15:25:49] (03CR) 10Physikerwelt: [C: 032] Remove formula from math index on article deletion [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200162 (owner: 10Physikerwelt) [15:26:02] 10VisualEditor, 10VisualEditor-DataModel: Converting a

inside a

into an hoists it out of the
- https://phabricator.wikimedia.org/T94181#1156949 (10Jdforrester-WMF) 3NEW [15:26:16] 10VisualEditor, 10VisualEditor-DataModel: Converting a

inside a

into an hoists it out of the
- https://phabricator.wikimedia.org/T94181#1156956 (10Jdforrester-WMF) [15:27:13] (03PS1) 10Mvolz: Fix: Handle case where Zotero gives us empty list [services/citoid] - 10https://gerrit.wikimedia.org/r/200163 (https://phabricator.wikimedia.org/T94178) [15:28:16] (03Merged) 10jenkins-bot: Remove formula from math index on article deletion [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200162 (owner: 10Physikerwelt) [15:29:05] edsanders: could you peek at https://phabricator.wikimedia.org/T93929 ?? [15:29:37] 10VisualEditor, 10VisualEditor-DataModel: Converting a

inside a

into an hoists it out of the
- https://phabricator.wikimedia.org/T94181#1156970 (10Negative24) [15:29:38] I'm hoping for a clue on how to fix... Or where to start looking [15:31:13] (03PS1) 10Physikerwelt: Remove jenkins workaround [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200164 [15:36:12] (03CR) 10Physikerwelt: [C: 032] Remove jenkins workaround [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200164 (owner: 10Physikerwelt) [15:37:51] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review, and 3 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1157016 (10greg) This was in this week's column in Roadmap, how'd it go? Still more to do? [15:38:52] (03Merged) 10jenkins-bot: Remove jenkins workaround [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200164 (owner: 10Physikerwelt) [15:39:13] 10VisualEditor, 6Engineering-Community, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015: GSoC'15 Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T94144#1157018 (10Pratikbsp) [15:51:21] (03PS4) 10Mvolz: Restructure requestFromDOI + tests [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) [15:52:23] 10VisualEditor, 6Release-Engineering, 7Browser-Tests: Selenium bug with Firefox causes VE test failure - https://phabricator.wikimedia.org/T90651#1157077 (10zeljkofilipin) I see the commit is merged. Can this be closed? [15:53:30] 10VisualEditor, 6Release-Engineering, 7Browser-Tests: Create VisualEditor tests targeting the older version of browsers (Chrome and Firefox for now) for better backward compatibility - https://phabricator.wikimedia.org/T90678#1157081 (10zeljkofilipin) Do you still plan to work on this, or can the task be clo... [15:55:20] (03CR) 10Mvolz: "Rebased against critical fix and added the Object.extend while I was at it." [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) (owner: 10Mvolz) [15:58:13] (03PS5) 10Mvolz: Restructure requestFromDOI + tests [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) [16:01:28] (03CR) 10Jforrester: [C: 031] Fix: Handle case where Zotero gives us empty list [services/citoid] - 10https://gerrit.wikimedia.org/r/200163 (https://phabricator.wikimedia.org/T94178) (owner: 10Mvolz) [16:02:23] (03CR) 10Mobrovac: [C: 04-1] Fix: Handle case where Zotero gives us empty list (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/200163 (https://phabricator.wikimedia.org/T94178) (owner: 10Mvolz) [16:04:40] James_F: Are CAPTCHAs forced on the beta cluster? or am I just tripping off a rule? ;) [16:05:08] Negative24: New accounts get CAPTCHAs in some situations on Wikipedia, and the Beta Cluster mirrors that. [16:06:20] Hrm. I'm a newbie again :( [16:14:32] (03PS2) 10Mvolz: Fix: Handle case where Zotero gives us empty list [services/citoid] - 10https://gerrit.wikimedia.org/r/200163 (https://phabricator.wikimedia.org/T94178) [16:18:31] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review, and 3 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1157127 (10EBernhardson) >>! In T90764#1155499, @Mattflaschen wrote: >> * The text area right border is cropped for some reason... [16:18:53] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review, and 3 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1157128 (10EBernhardson) >>! In T90764#1157016, @greg wrote: > This was in this week's column in Roadmap, how'd it go? Still mo... [16:21:37] (03PS6) 10Mvolz: Restructure requestFromDOI + tests [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) [16:33:48] (03PS1) 10Esanders: Remove manager delay overrides [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200171 [16:35:29] 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Deleting from an empty paragraph to the end of an inline node throws an exception - https://phabricator.wikimedia.org/T72375#1157192 (10Etonkovidova) In test2: selecting the above table an... [16:37:16] 10VisualEditor, 6Editing, 6Engineering-Community, 10Possible-Tech-Projects, and 2 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1157195 (10Ankita-ks) [16:50:34] (03PS7) 10Mvolz: Restructure requestFromDOI + tests [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) [16:55:08] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression pre-wmf22] Link icon is missing form the VE toolbar - https://phabricator.wikimedia.org/T92576#1157267 (10Etonkovidova) Checked the new link icon in test2 and production. [16:55:23] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: [Regression pre-wmf22] Link icon is missing form the VE toolbar - https://phabricator.wikimedia.org/T92576#1157268 (10Etonkovidova) [16:55:24] (03PS1) 10Ferdbold: Added a simple tooltip when hovering table cells. Right now the string is hardcoded, will add i18n support later. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) [16:57:52] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1157283 (10ferdbold) [16:58:15] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1140552 (10ferdbold) [16:58:15] (03CR) 10Mvolz: [C: 04-1] "For works in progress, please add [WIP] in the subject line of the commit messages :)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [17:00:26] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1157287 (10Yurik) @ferdbold, @mvolz, please comment on my other concern re structured data. The naming of t... [17:00:45] 10OOjs-UI, 10OOjs-UI-0.9.1, 10UI-Standardization, 7Design, and 3 others: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1157289 (10Etonkovidova) [17:02:48] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1157294 (10ferdbold) @Yurik: Would it be sufficient to add a "raw data" tab of some sort to the UI who woul... [17:05:14] (03PS1) 10Physikerwelt: Update maintenance script CreateMWSHarvest [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200180 [17:05:33] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1157298 (10Yurik) Sure, as long as all edits on the structured tab immediately reflect in the raw tab, and... [17:05:35] (03CR) 10jenkins-bot: [V: 04-1] Update maintenance script CreateMWSHarvest [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200180 (owner: 10Physikerwelt) [17:06:17] (03PS2) 10Ferdbold: [WIP] Added a simple tooltip when hovering table cells. Right now the string is hardcoded, will add i18n support later. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) [17:15:13] (03CR) 10Physikerwelt: "recheck" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200180 (owner: 10Physikerwelt) [17:17:32] (03PS4) 10Alex Monk: Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) [17:18:19] 10MediaWiki-ResourceLoader, 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, and 2 others: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1157340 (10Krenair) For reference, here is the script I used to generate the data to put in the core comm... [17:18:30] (03CR) 10Physikerwelt: [C: 032] Update maintenance script CreateMWSHarvest [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200180 (owner: 10Physikerwelt) [17:19:06] James_F, urgh, is Jenkins about to complain because I only moved en? [17:19:20] (03CR) 10jenkins-bot: [V: 04-1] Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [17:19:21] Krenair: Yes, you *need* qqq or it will V-1. [17:19:34] Krenair: Moving the rest of i18n is "nice", but qqq or go home. [17:20:34] (03PS4) 10Mooeypoo: Add an isPreview flag to BranchNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) [17:21:59] James_F, kind of irritating in this case because we're moving them all anyway [17:22:04] but I know why we do it [17:22:10] Yeah. [17:22:12] Hmm. [17:22:16] and I missed something else [17:24:41] Krenair: For some reason it passed banana even though it shouldn't. [17:26:01] (03PS1) 10Cscott: GroupWidget should be a Widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/200186 [17:27:09] (03CR) 10Catrope: [C: 04-2] "It's a mixin meant to be mixed into a Widget. This should be documented better. In general we have very poor docs about which classes are " [oojs/ui] - 10https://gerrit.wikimedia.org/r/200186 (owner: 10Cscott) [17:27:42] (03CR) 10Cscott: "GroupElement is the mixin, isn't it? This class is totally misnamed then." [oojs/ui] - 10https://gerrit.wikimedia.org/r/200186 (owner: 10Cscott) [17:28:04] (03CR) 10Cscott: "(I checked, and it's the only class in src/widgets which does *not* inherit from Widget.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/200186 (owner: 10Cscott) [17:28:43] (03Merged) 10jenkins-bot: Update maintenance script CreateMWSHarvest [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200180 (owner: 10Physikerwelt) [17:29:43] (03CR) 10Catrope: "GroupElement is *also* a mixin. GroupWidget is a mixin that inherits from another mixin, which is a deprecated pattern." [oojs/ui] - 10https://gerrit.wikimedia.org/r/200186 (owner: 10Cscott) [17:30:13] (03CR) 10Mooeypoo: [C: 04-1] [WIP] Added a simple tooltip when hovering table cells. Right now the string is hardcoded, will add i18n support later. (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [17:31:28] (03CR) 10Cscott: "(Hm, that's not quite right -- ItemWidget and ToggleWidget are also not widgets. Gah.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/200186 (owner: 10Cscott) [17:31:59] (03CR) 10Alex Monk: "(Tests cannot pass until core dependency is merged.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [17:32:26] (03CR) 10Alex Monk: "We'd need to update our wfUseMW call as well" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [17:34:40] TrevorP|Away: https://gerrit.wikimedia.org/r/200184 [17:34:51] 10OOjs-UI: Rename GroupWidget, ItemWidget, and ToggleWidget to *WidgetMixin. - https://phabricator.wikimedia.org/T94198#1157355 (10cscott) 3NEW [17:34:53] James_F, do you know if we have a bug for the points allocation on sprints going off the screen? [17:34:56] I wasn't able to find one [17:35:04] 10OOjs-UI: ButtonSelectWidget icon/indicator issues in MediaWiki theme - https://phabricator.wikimedia.org/T94199#1157362 (10Esanders) 3NEW a:3matmarex [17:35:13] Krenair: Don't think so. [17:35:20] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt, 3VisualEditor 2014/15 Q3 blockers: Audit and fix events bound to CE nodes but not unbound when destroy() is called - https://phabricator.wikimedia.org/T92583#1157377 (10TrevorParscal) a:5Catrope>3TrevorParscal [17:35:23] (03Abandoned) 10Cscott: GroupWidget should be a Widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/200186 (owner: 10Cscott) [17:35:46] 10WikiEditor: Wikieditor (Revert making installable via composer) - https://phabricator.wikimedia.org/T93616#1157379 (10Legoktm) >>! In T93616#1142942, @MarkAHershberger wrote: > The concept of "maintainers" (mentioned in the commit to remove the support) is pretty fluid, but I'm not sure what basis it has. Kun... [17:36:28] 10OOjs-UI: Indicator-only button has wrong height in MediaWiki theme - https://phabricator.wikimedia.org/T94201#1157380 (10Esanders) 3NEW a:3matmarex [17:37:25] so many duplicate bugs [17:37:56] 10OOjs-UI: ButtonSelectWidget broken in Apex theme - https://phabricator.wikimedia.org/T94202#1157390 (10Esanders) 3NEW a:3matmarex [17:39:31] Krenair: https://gerrit.wikimedia.org/r/#/c/200184/2 is failing - looks like the qqq.json file has a trailing comma https://gerrit.wikimedia.org/r/#/c/200184/2/languages/i18n/qqq.json,unified [17:39:49] James_F: Just a little quirk I just noticed: editing a reflist references an old bugzilla bug [17:40:04] TrevorParscal, yep, thanks [17:40:17] (03PS4) 10Mooeypoo: Hide slugs in context menus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200086 (https://phabricator.wikimedia.org/T93042) [17:40:28] Negative24: You mean editing a {{reflist}} template? [17:40:46] Yeah. It should probably be changed to Phab:T53146 [17:41:38] Negative24: That's on-wiki documentation – https://en.wikipedia.org/w/index.php?title=Template:Reflist/doc&action=edit§ion=T-20 [17:41:48] Negative24: I can change or you can if you prefer? [17:42:03] I got it. Thanks [17:42:12] (03PS1) 10Esanders: Add vertical spacing to RadioSelectWidget in MW theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/200191 [17:45:41] 10VisualEditor, 10Flow: Click outside to close doesn't always work as intended for mention inspector - https://phabricator.wikimedia.org/T94109#1157435 (10EBernhardson) p:5Triage>3Normal [17:46:30] TrevorParscal: hey, i just submitted a change that modifies the module configuration format of RLImageModule - https://gerrit.wikimedia.org/r/200188 [17:46:55] would be nice to get that merged soonish, so that more people don't start using the old one [17:46:59] (it's a breaking change) [17:47:18] and we have zero current uses right? [17:47:22] 10OOjs-UI-0.9.1, 10VisualEditor, 10VisualEditor-EditingTools, 7Browser-Support-Firefox, and 4 others: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1157442 (10Etonkovidova) [17:47:32] TrevorParscal: we have two and i submitted patches for both [17:48:14] (that change is currently the top of a stack, by the way) [17:48:45] ok [17:48:51] so, these need to be merged together-ish [17:49:20] yeah [17:49:42] not a problem as long as we're not doing it five minutes before branch cut [17:51:42] MatmaRex: I alerted Kaldari [17:51:53] I asked for him to get someone on his team to +1 [17:52:00] (03PS1) 10Cscott: Rename {Group,Item,Toggle}Widget to {Group,Item,Toggle}Mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 [17:52:05] if we don't get that before the end of the day, I'll just go ahead with it [17:52:22] TrevorParscal: Jon +1'd it already, i think [17:52:41] and the followups? because none of the mobile people were listed in the reviewers lists [17:52:42] or he +1'd at leats one of the patches from the half a dozen [17:53:05] oh right, not the latest one. he did look at the earlier ones in the stack. [17:53:47] yeah, I don't see that in the stack... they should +1 quickly, if not we will just proceed after testing [17:54:05] (03PS1) 10Kmenger: PageLayout: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/200198 [17:54:20] (03PS2) 10Cscott: [BREAKING CHANGE] Rename {Group,Item,Toggle}Widget to {Group,Item,Toggle}Mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 [17:55:00] 10OOjs-UI: Rename GroupWidget, ItemWidget, and ToggleWidget to *Mixin. - https://phabricator.wikimedia.org/T94198#1157460 (10cscott) [17:57:01] gwicke, why do we have a restbase-beta.wmflabs.org instead of restbase.beta.wmflabs.org? [17:57:19] Krenair: I just created it [17:57:25] Krenair: It's because of how proxies work in labs [17:57:29] :/ [17:57:47] You can only have a foo.wmflabs.org proxy AIUI, not foo.bar.wmflabs.org [17:57:55] Because of how wildcards work in SSL certs [17:58:29] So, ironically, restbase-beta.wmflabs.org has SSL support while the wikis it serves do not [17:58:39] ok [17:58:48] (Also if you look at the list of proxies for the deployment-prep project, they're all of the form foo-beta.wmflabs.org, I followed that pattern) [17:59:01] why does it list zero.wikimedia.beta.wmflabs.org ? [17:59:26] Because that's how RB was presumably configured [17:59:54] but that's a private wiki [18:00:07] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Audit events in DM systems that are bound but never unbound, adding destroy code paths as needed - https://phabricator.wikimedia.org/T94207#1157483 (10TrevorParscal) 3NEW [18:00:17] Hmm yeah that does sound bad [18:00:25] Krenair: Could you bring that up over in #wikimedia-services ? [18:00:28] I notice VE is broken on http://ee-prototype.wikipedia.beta.wmflabs.org/ [18:02:35] probably because no restbase there either [18:03:18] RB doesn't have any privileges [18:03:37] so if it's a private wiki, it'll still return nothing [18:03:53] (03PS2) 10Memeht: Strip X-Parsoid Performance Headers from Visual Editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199562 [18:09:51] (03PS2) 10Kmenger: PageLayout: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/200198 [18:11:09] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review, and 3 others: S5. Flow: Integrate VE toolbar in Flow entry fields - https://phabricator.wikimedia.org/T90764#1157508 (10DannyH) [18:12:54] 10VisualEditor, 10VisualEditor-ContentEditable, 7Technical-Debt, 3VisualEditor 2014/15 Q3 blockers: Audit and fix events bound to CE nodes but not unbound when destroy() is called - https://phabricator.wikimedia.org/T92583#1157516 (10TrevorParscal) 5Open>3Resolved Resolved in patch https://gerrit.wikim... [18:17:25] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1157523 (10Mooeypoo) Okay, eventually when this project is done, there should not be JSON blob exposed to t... [18:17:36] James_F: https://gerrit.wikimedia.org/r/200196 [18:23:40] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1157545 (10Elitre) 3NEW [18:25:04] divec: how're you doing with slugs? [18:27:56] (03CR) 10Catrope: [C: 032] Strip X-Parsoid Performance Headers from Visual Editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199562 (owner: 10Memeht) [18:27:56] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1157578 (10Yurik) @mooeypoo, I don't think it would ever be a good idea to get rid of the "raw" view - grap... [18:28:58] 10VisualEditor: Safari: progress bar gets stuck with "TypeError: undefined is not an object ..." - https://phabricator.wikimedia.org/T93964#1157580 (10Ryasmeen) I found this too happening today on Firefox [18:29:16] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1157581 (10Elitre) Is there a templated request that you could give in case someone really wants to create an account there and ask? Thank you. [18:30:06] 10VisualEditor, 10VisualEditor-MediaWiki: Category popup is vertically misaligned - https://phabricator.wikimedia.org/T94114#1157585 (10Catrope) a:3TrevorParscal [18:30:25] 10VisualEditor: Safari: progress bar gets stuck with "TypeError: undefined is not an object ..." and also moves backward for a while - https://phabricator.wikimedia.org/T93964#1157586 (10Ryasmeen) [18:32:36] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1157588 (10Mooeypoo) The 'raw' view has no place in VisualEditor, though, just like wikitext has no place i... [18:32:42] 10VisualEditor: Progress bar moves backwards sometimes - https://phabricator.wikimedia.org/T93964#1157589 (10Catrope) [18:33:11] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 7Browser-Support-Firefox, 3VisualEditor 2014/15 Q3 blockers: Using keyboard shortcuts (in multiple browsers) or the "Open menu" (in Firefox only) to copy a paragraph and a reference ... - https://phabricator.wikimedia.org/T89025#1157592 [18:33:26] 10VisualEditor: Progress bar moves backwards sometimes - https://phabricator.wikimedia.org/T93964#1151395 (10Catrope) Rummana said she couldn't reproduce the error, and `this.doc.children[0]` doesn't occur in our code any more. So I'm making this task about the progress bar moving backwards, and if the error can... [18:33:36] 10VisualEditor: Progress bar moves backwards sometimes - https://phabricator.wikimedia.org/T93964#1157595 (10Catrope) a:3Esanders [18:34:35] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1157601 (10Mooeypoo) Also see comments related to the project on the sub-task https://phabricator.wikimedia.org/T93585 [18:41:20] (03PS5) 10Alex Monk: Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) [18:41:23] 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1157620 (10TheDJ) [18:41:24] 10MediaWiki-Page-editing, 7JavaScript, 5Patch-For-Review: LivePreview: Since 1.25wmf12 in 'section=new' mode the section header is not shown - https://phabricator.wikimedia.org/T84877#1157619 (10TheDJ) 5Open>3Resolved [18:42:32] (03CR) 10jenkins-bot: [V: 04-1] Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [18:42:33] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1157625 (10Mvolz) Not really, https://github.com/zotero/translators/issues/new and just type what you want. Unfortunately it looks like there's quite a backlog... [18:42:48] (03PS1) 10Bartosz Dziewoński: Correct font sizes of everything on MonoBook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200211 (https://phabricator.wikimedia.org/T94071) [18:43:51] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1157632 (10Mvolz) https://github.com/zotero/translators/issues/826 Looks like someone made a request about major French newspapers as well, it might be up to u... [18:43:53] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1157633 (10Yurik) It sounds good in theory, but might not work in practice. Take a look at [[ https://www.... [18:45:42] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1157651 (10Mvolz) https://gerrit.wikimedia.org/r/#/c/199921/ should help when it gets merged, but I will check all of these with that change and give an update. [18:45:52] (03Merged) 10jenkins-bot: Strip X-Parsoid Performance Headers from Visual Editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199562 (owner: 10Memeht) [18:46:08] (03PS1) 10Mooeypoo: Verify welcome dialog exists before trying to close it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200212 [18:46:20] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1157660 (10Elitre) I'd guess so. It wouldn't be much useful to send people there to ask for something Zotero doesn't have the capacity to give them. [18:46:24] (03CR) 10Catrope: [C: 032] Verify welcome dialog exists before trying to close it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200212 (owner: 10Mooeypoo) [18:47:14] (03PS1) 10Trevor Parscal: Don't assume indicators are full-height [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200214 (https://phabricator.wikimedia.org/T94114) [18:47:33] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Category popup is vertically misaligned - https://phabricator.wikimedia.org/T94114#1157668 (10TrevorParscal) [18:47:38] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Category popup is vertically misaligned - https://phabricator.wikimedia.org/T94114#1155533 (10TrevorParscal) [18:47:50] 10Citoid: Unrecognized quotes - https://phabricator.wikimedia.org/T94213#1157671 (10Elitre) 3NEW [18:48:10] (03PS2) 10Catrope: Don't assume indicators are full-height [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200214 (https://phabricator.wikimedia.org/T94114) (owner: 10Trevor Parscal) [18:48:22] (03PS3) 10Catrope: Don't assume indicators are full-height [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200214 (https://phabricator.wikimedia.org/T94114) (owner: 10Trevor Parscal) [18:48:41] (03Merged) 10jenkins-bot: Verify welcome dialog exists before trying to close it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200212 (owner: 10Mooeypoo) [18:48:50] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1157678 (10Mvolz) @Elitre, it still makes sense to request them. It just depends if I/anyone else ever has time to add new translators or not :). If we write th... [18:50:36] 10Citoid, 6Editing, 10Possible-Tech-Projects, 10Wikidata, and 2 others: Create a system to store and query links to books - https://phabricator.wikimedia.org/T90852#1157689 (10CeruleanDreamer) I would like to choose this as a possible project for my Outreachy application.I recognize that I am reaching the... [18:54:03] [13grunt-banana-checker] 15jdforrester created 06oh-dear (+3 new commits): 02https://github.com/wikimedia/grunt-banana-checker/compare/e08f33cd5c2f^...927171fea9df [18:54:03] 13grunt-banana-checker/06oh-dear 14e08f33c 15James D. Forrester: Bump devDependencies to latest [18:54:03] 13grunt-banana-checker/06oh-dear 14d67cd24 15James D. Forrester: Fix catastrophic logic error... [18:54:03] 13grunt-banana-checker/06oh-dear 14927171f 15James D. Forrester: Kill effectively static variable, sourceIndex... [18:55:18] [13grunt-banana-checker] 15jdforrester opened pull request #14: Make grunt-banana-checker actually check if messages are documented (06master...06oh-dear) 02https://github.com/wikimedia/grunt-banana-checker/pull/14 [18:56:09] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1157705 (10Elitre) Of course! If someone at WMF commits to add them so that they get merged, asking makes a lot of sense. [19:06:56] (03PS1) 10Esanders: Parent constructor simplification [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200218 [19:06:58] (03PS1) 10Esanders: Simplify context item for MWAlienExtensionNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200219 [19:08:22] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 7Browser-Support-Firefox, 3VisualEditor 2014/15 Q3 blockers: Using keyboard shortcuts (in multiple browsers) or the "Open menu" (in Firefox only) to copy a paragraph and a reference ... - https://phabricator.wikimedia.org/T89025#1157747 [19:10:12] wikimedia/grunt-banana-checker#43 (oh-dear - 927171f : James D. Forrester): The build passed. [19:10:12] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/e08f33cd5c2f^...927171fea9df [19:10:12] Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/56135484 [19:12:18] 10Citoid, 6Editing, 10Possible-Tech-Projects, 10Wikidata, and 2 others: Create a system to store and query links to books - https://phabricator.wikimedia.org/T90852#1157757 (10Mvolz) @CeruleanDreamer, this is likely not something that wmf would support as an outreachy project as we already have different p... [19:14:33] (03PS4) 10Trevor Parscal: Don't position category popups -10px up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200214 (https://phabricator.wikimedia.org/T94114) [19:15:08] 10OOjs-UI: StackLayout setItem( ) method unsets the current item if the passed item to show has not been added in the items list - https://phabricator.wikimedia.org/T94218#1157770 (10KMenger) [19:15:37] TrevorParscal: http://jsfiddle.net/catrope/5r656mnb/ [19:16:06] (03CR) 10Esanders: "Per my comments elsewhere, what about using DM HTML?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [19:18:09] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [19:19:50] (03CR) 10Mooeypoo: "But we want it to look the same as we are displaying it, which isn't always the same as the dm html." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [19:21:41] (03CR) 10Jforrester: "It's broke mate." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [19:24:42] (03CR) 10Esanders: "It would work for GCN provided you used the correct converter mode, and it's visually the same as 'read mode'." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [19:26:24] (03CR) 10Bartosz Dziewoński: [C: 032] Don't position category popups -10px up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200214 (https://phabricator.wikimedia.org/T94114) (owner: 10Trevor Parscal) [19:30:20] (03Merged) 10jenkins-bot: Don't position category popups -10px up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200214 (https://phabricator.wikimedia.org/T94114) (owner: 10Trevor Parscal) [19:30:37] One Internet point to the person who can help me come up with names for the UI elements I want to add to UW [19:30:46] So I can find the OOUI elements that will make them appear [19:34:14] http://i.imgur.com/RZE9cde.png [19:34:18] http://i.imgur.com/SQL3vUl.png [19:38:34] First challenge is the expandable section... [19:38:50] "PanelLayout" seems like a good start I guess [19:39:30] Oh, no, that's not correct. [19:40:13] (03PS1) 10Kmenger: StackLayout: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/200224 [19:43:31] * marktraceur pokes James_F|Away [19:43:37] Oh, it's lunchtime. Sigh. [19:52:36] (03CR) 10Bartosz Dziewoński: "But… they will not inherit. The system default font for form elements will be used. I am all for that, myself, but this does not do what y" [oojs/ui] - 10https://gerrit.wikimedia.org/r/197097 (https://phabricator.wikimedia.org/T92858) (owner: 10Nirzar) [20:09:40] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24): Category popup is vertically misaligned - https://phabricator.wikimedia.org/T94114#1157884 (10Jdforrester-WMF) 5Open>3Resolved [20:11:02] marktraceur: Hey. [20:11:40] 10Citoid, 10Possible-Tech-Projects: Add wikitext support for citoid - https://phabricator.wikimedia.org/T94223#1157891 (10Mvolz) 3NEW [20:14:18] Hi! [20:15:23] James_F: I pinged you in the hopes that you could prod someone to answer. [20:15:33] I guess I could bother MatmaRex or TrevorParscal. [20:16:41] hm [20:20:11] Hm! [20:20:53] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 3VisualEditor 2014/15 Q3 blockers: Insufficient span tags stripping from copy-and-paste (?) - https://phabricator.wikimedia.org/T78540#1157939 (10TrevorParscal) Reproduced with Safari 8.0.4 on MacOS X 10.10.2. 1. Select an internal... [20:22:16] MatmaRex: I think the answer may be "I need to write something custom" at least in part. [20:23:29] marktraceur: I don't understand what UI elements you mean from your screenshot. [20:23:54] James_F: The copy metadata form area [20:24:16] "2 files to upload" and the associated button [20:25:23] And the associated form in the second mockup. [20:26:39] marktraceur: So I imagine you'll want to make a custom widget for "UploadItem" or whatever. [20:27:39] James_F: That's further down the line [20:27:50] marktraceur: Oh, you mean the form? [20:27:55] Yes. [20:27:57] 2015-03-27 - 15:23:15 And the associated form in the second mockup. [20:28:03] Right. [20:28:17] marktraceur: MatmaRex did some work to make MediaWiki's HTMLForm have an OOjs UI mode. [20:28:20] marktraceur: Is that helpful? [20:28:30] No, UW doesn't use HTMLForm [20:28:37] That would make it too easy to manage. [20:28:40] Could it? [20:28:47] The interface is half backend and half frontend [20:28:49] (…easily). [20:28:53] OK. [20:28:56] Frankly I'd like it to be more frontend than backend [20:29:02] * James_F nods. [20:29:03] i haven't done enough of that work to make it possible yet [20:29:14] marktraceur: You might be a bit on your own. :-( [20:29:18] stuff keeps coming up [20:29:33] (like the icon thing) [20:29:37] * MatmaRex grumbles [20:30:48] marktraceur: The FormLayout would be a start. [20:30:56] I guess so. [20:30:57] marktraceur: See the bottom of https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#widgets-mediawiki-vector-ltr [20:31:02] I can add in what's necessary, too. [20:31:04] You'd want to style it a bit. [20:31:08] "a bit" sure [20:31:13] Not much. [20:31:17] background: #ddd [20:31:24] And the icon. [20:31:34] Or I could just dash pginer's hopes and dreams for that part. [20:31:35] > .oo-ui-input { width: 20em; } [20:32:05] OK, I'll start with a FormLayout and go from there. Ta. [20:32:12] The icon + heading is just a FieldSetLayout. [20:32:35] You'll want to make each of those controls magic, I guess. Date -> Date picker (please upstream). [20:32:50] Categories -> Category picker (re-use VisualEditor's? We could upstream) [20:32:51] Etc. [20:34:20] Hrm. [20:34:28] We're going to need to make a MediaWiki.UI RL module for shared OOjs UI widgets. [20:34:29] James_F: We already have both a date picker and a category picker. [20:34:33] I could...try to upstream [20:34:40] It would take more time, and I'm pushing things as it is [20:34:55] I'll ask about timelines. [20:34:56] marktraceur: Yes, but we already have a category picker too, and consistency makes users happy. [20:38:08] James_F: Trouble is I'd need to switch the other category field over to using that picker as well. [20:38:26] mooeypoo: please provide a feedback if i am wrong in my approach, i submitted a proposal https://phabricator.wikimedia.org/T93788 , thank you for your time [20:38:30] marktraceur: Other? [20:39:33] James_F: The one that's inside each upload object's form. [20:42:40] mooeypoo: i am sorry , its wrong to ask about the review [20:44:06] rits: I can't speak for mooeypoo, but I rather like it when people ping me about review. [20:44:48] marktraceur: please it will be valuable for me, tahnk you so much [20:44:52] :) [20:45:20] thank you * [20:45:59] Oh, I'm not going to review it, just chiming in on the social issues of the day. [20:45:59] heya rits [20:46:22] rits, you have a bunch of review comments on your patch, but you should take a look at the last one from ed [20:46:41] we ended up discovering a problem with the initial approach, and ed has submitted a patch to correct it -- you should follow what he did in that patch [20:46:49] rits, he linked to that new patch from your code review [20:46:57] It should be the last comment [20:47:27] mooeypoo: hello, i heard you were not well, hope you are fine now [20:47:38] I'm better :) Thanks [20:48:10] Krenair: two small things [20:48:13] mooeypoo: sorry a lst few days ended up with writing proposals i will work on it from today [20:48:27] rits, ok, let me know if you run into issues [20:48:28] last* [20:48:31] Krenair: what do you think's happening in sessions like this: [20:48:40] https://www.irccloud.com/pastebin/ejvRdTwd [20:48:54] rits, the review may have been overwhelming, I'm sorry about that, your patch actually showed us something was wrong with the previous patchset :) [20:48:57] 10Citoid, 6Editing, 10Possible-Tech-Projects, 10Wikidata, and 2 others: Create a system to store and query links to books - https://phabricator.wikimedia.org/T90852#1158134 (10CeruleanDreamer) Thank you for responding.I will check into the links that you have shared. [20:49:03] also, clientIp is not set on the init, saveAttempt, and saveSuccess events, I assume that's a known limitation? [20:49:07] mooeypoo: ok, i will thank you so much :) [20:49:58] mooeypoo: oh, thank you so much, just going to start working on it [20:50:06] no problems, rits . We're here if you need anything [20:51:31] mooeypoo: \o/ thank you :) [20:55:19] anyone know if Krenair is going to be around anymore today? [20:57:53] milimetric, sorry, am here now [20:58:31] MatmaRex, James_F, when I create custom widget types, should I put them in the OO.ui namespace or into my own? [20:58:43] Krenair: no problem, was just wondering so I could figure out what to do [20:58:51] I'm at a conference for a few days next week [20:59:01] let me know what you think about the two questions above [20:59:43] milimetric, um, clientIp? [21:00:11] milimetric, I don't think that's part of the schema? [21:00:32] oh right - duh, it's something that the server won't fill in apparently [21:00:34] but the client will [21:00:46] ok, what about the "ready" event repeating a bunch of times like that [21:01:03] marktraceur: probably your own [21:01:04] that seems related to the double toolbar bug [21:02:25] is that all from the same session? [21:02:37] maybe they're previewing multiple times? [21:03:11] Krenair: yeah, it's all the same session [21:03:16] so "ready" happens when they preview? [21:03:44] I think it might [21:04:07] hm, ok, that shouldn't hurt too much. The worst part is the clientIp not being around but you're right you have no control of that [21:04:32] I guess ... oh! in the case of the wikitext sessions, we're confident there's no collisions in editingSessionId, right? [21:04:43] because it's generated server side and we know it won't generate duplicates? [21:05:57] it is generated on the server, but I don't see why that would change anything [21:07:28] Krenair: in the client, Safari specifically, the editingSessionId has a huge amount of collisions with other editingSessionIds [21:07:39] so it's impossible to identify sessions just with editingSessionid [21:07:54] and we use clientIp and other things to further identify whole sessions [21:08:11] but for this code, the editingSessionId should be unique, so I'll just use it by itself. [21:13:19] marktraceur: TrevorParscal and I were discussing making a MediaWiki.ui.* widgetspace. [21:13:49] MediaWiki.ui.CategoryWidget [21:14:11] I guess we would really stick that on window.mw? [21:14:17] mw.ui.CategoryWidget [21:15:36] TrevorParscal: Eh. That works. [21:15:42] mw.ui.CategoryWidget [21:15:48] mw.ui.DateWidget [21:15:54] mw.ui.TitleLookupWidget [21:15:55] Etc. [21:16:17] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: Link inspector won't open after placing cursor on another link while the link inspector is open, cannot inspect any other existing link for that session - https://phabricator.wikimedia.org/T93011#1158236 (10... [21:16:27] Lots of VE can probably be stolen and re-used, but will need retro-fitting for a proper model separation, as TrevorParscal said. [21:17:49] we've needed a category model, now is a good time to go ahead and put something like that together [21:18:39] basically, it could be as simple as a class that provides an interface to a list of categories, each with a couple properties (title and sortKey) [21:18:48] that way we can make it ve independent [21:19:55] TrevorParscal: Sure, but marktraceur has other things to do with his time (and so do the rest of us). [21:20:29] RoanKattouw: Re: position/offset [21:20:33] I can do this personally, maybe in a week or so from now [21:20:41] TrevorParscal: Nice. [21:20:43] marktraceur: lets talk about it soon [21:25:51] Krenair: https://gerrit.wikimedia.org/r/#/c/197357/4 ??? [21:25:59] The more I look at this, the more I realize how many insane widgets I have to create. [21:26:12] I'd love to work with you on this [21:26:23] Krinkle: ...yes? [21:26:24] * TrevorParscal secretly loves creating widgets [21:26:33] Krinkle: how's it going? [21:27:29] TrevorParscal: … secretly? [21:27:39] heh heh [21:27:43] TrevorParscal: Well, that would be fun [21:28:04] (03PS1) 10Physikerwelt: Fix: Clear relevance map for each term [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200241 [21:28:12] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-References, 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression wmf20] Internal links, when clicked in a Reference context menu does nothing. - https://phabricator.wikimedia.org/T92427#1158317 (10Ryasmeen) Are we showing just the icon for... [21:28:16] TrevorParscal: I'm in town April 13-17, maybe we could claim a couple of adjacent desks and bang out some widgets [21:28:20] TrevorParscal, I'm not sure why it's still failing [21:28:22] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-References, 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression wmf20] Internal links, when clicked in a Reference context menu does nothing. - https://phabricator.wikimedia.org/T92427#1158318 (10Ryasmeen) 5Resolved>3Open [21:28:23] I can make a list of atomic things that I want [21:28:35] isn't it supposed to have the latest copy of MW core? [21:32:31] TrevorParscal: http://etherpad.wikimedia.org/p/widgets-for-uploadwizard [21:37:43] RoanKattouw: http://jsfiddle.net/eq8rmy4c/ [21:38:05] I understood it when you described it, but looking at this fiddle I'm not sure what the problem is [21:39:12] Krinkle: Let me construct a jsfiddle that incorporates OO.ui.Element.static.getRelativePosition and illustrates the issue [21:39:21] RoanKattouw: http://jsfiddle.net/zL8zq9d9/ [21:39:29] RoanKattouw: I made all godo numbers 10 and the wrong one 5 [21:39:35] Now I see it [21:40:07] Slightly prettier: [21:40:08] http://jsfiddle.net/0y734ct2/ [21:40:26] OK. Yeah, seeing a expected/actual or something that is more visibly "wrong" would help [21:40:36] RoanKattouw: I also made the padding on the body explicit instead of browser default [21:40:55] (enabled css reset in the sidebar) [21:42:41] I believe we have a skewed pagelinks table due to a mismatch between software version and database level. Running update.php leads to the wrong page being summoned when VE is invoked. I have tried to run refreshLinks.php and rebuildall.php, but the problem continues. What table does VE consult when selecting the page to edit -- is it in fact pagelinks? [21:43:29] VE doesn't touch the database directly [21:43:51] when loading it pulls a bunch of metadata about the page using MediaWiki's functions [21:44:36] to save it uses MediaWiki's action=edit API module [21:44:48] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Selecting an inspector while another inspector is open shows both inspector buttons as 'clicked' - https://phabricator.wikimedia.org/T93016#1158390 (10Ryasmeen) [21:45:21] What is the problem exactly Pickle-san? [21:47:37] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Selecting an inspector while another inspector is open shows both inspector buttons as 'clicked' - https://phabricator.wikimedia.org/T93016#1158407 (10Ryasmeen) When yo... [21:47:46] Krenair: We are encountering database errors in production. In test, I run update.php, but then one encounters the behavior I describe above -- you try to edit page A in VE, and you get B. Edit Source and History are not affected in the same way. [21:48:22] James_F: Using Insert Template on https://www.mediawiki.org/wiki/Project:Sandbox?veaction=edit shows a double blue border as focus (and if you click out of it and into it, I observe the double border being added in two steps, first 1px then the next). This is a bug or at least a perf bug, depending on whether that's an intentional design change. [21:48:23] Krenair: In "metadata-speak" what does VE grab hold of when pulling out a page -- would one term it a "link?" [21:48:50] Krinkle: It's intentional design, I think. :-( [21:49:01] Krinkle: However, IDGAF about that. How's the edit notice stuff coming? [21:49:36] Pickle-san, VE pulls the page content from Parsoid [21:49:42] what is your Parsoid URL set to? [21:49:45] James_F: If I had a white board to project my idea on, you'd be crying. [21:50:06] Krinkle: However. Focus. :-P [21:50:06] Krenair: localhost [21:50:14] James_F: .. for edit notice stuff. [21:50:31] Pickle-san: Have you restarted Parsoid since the upgrade? [21:50:33] Krinkle: Oh. [21:50:47] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T78540#1158412 (10Jdforrester-WMF) [21:51:02] Pickle-san, you have parsoid running on port 80? [21:52:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: setupSlugs is called twice during ContentBranchNode setup - https://phabricator.wikimedia.org/T91245#1158422 (10Jdforrester-WMF) a:5dchan>3TrevorParscal [21:52:45] (03PS6) 10Alex Monk: Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) [21:53:27] Krinkle: OK so it looks like I was wrong and getRelativePosition isn't broken because it uses .offset() and .offset() isn't the broken one [21:53:37] Krinkle: Instead we were just stupid for using margin-top where we were [21:53:38] Krenair: Want me to make the patch for WikiEditor whilst you work on VE? [21:53:41] James_F: Yes, Parsoid has been re-started many times, again just now. This does not appear to affect the problem. [21:53:49] Krinkle: However, there's still a discrepancy between position and offset [21:53:54] Pickle-san: That's really odd. [21:53:56] (03CR) 10jenkins-bot: [V: 04-1] Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [21:54:04] James_F, I have some changes locally already [21:54:12] Krenair: OK, in that case never mind. :-) [21:54:57] Ohhhh. [21:55:00] Whoops. [21:55:02] ? [21:55:14] Typo. [21:55:19] Ha. [21:55:26] That'd not help. [21:55:41] The .php file is fine [21:55:48] But the extension.json file has the dependency spelt wrongly [21:55:54] Ha. [21:56:06] I use the maintenance script to adjust extension.json to avoid typos. [21:56:07] So it's fine locally but Jenkins is not so sure. [21:56:12] Because I make them all the time. [21:56:45] Krinkle: Here's a good one: http://jsfiddle.net/catrope/5r656mnb/1/ [21:56:59] (03PS7) 10Alex Monk: Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) [21:57:03] Hopefully that qunit job stops failing. Don't know what that's about. [21:57:05] Krinkle: From reading the code you'd expect those two click handlers to be equivalent [21:57:30] Krinkle: But the offset one (the more complex one) works correctly while the position one (the simpler one) is thrown off by the margin rule [21:57:47] (The correct behavior in this case is for the box's top edge to align with the indicator's bottom edge) [21:58:01] Krenair: James_F: HO! localhost is still defined in parsoid to refer back to the production server! That was a bit of tweaking I missed. When I set it to the one true value, all seems to be hunky-dory again. [21:58:10] Pickle-san: Aha! [21:58:26] Pickle-san: Well, that's a really simple explanation for a really confusinh problem. :-) [21:58:57] Yeah, that sort of stuff happens when you point to the wrong parsoid, or point parsoid to the wrong wiki [21:59:28] James_F: Kreinair: Well, thanks for being a sounding-board. Sometimes you stare at something forever and it's right in front of you. Your questions made me look in the right place. [21:59:35] (03CR) 10jenkins-bot: [V: 04-1] Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [21:59:38] Pickle-san: :-) [22:00:10] Hey mvolz. [22:00:41] Hiya [22:01:20] Krinkle: Simpler version: http://jsfiddle.net/catrope/5r656mnb/2/ [22:01:25] Pickle-san, your client probably has the ability to auto-complete names of other users [22:01:36] James_F: If you responded to my response in #mediawiki-services I might not have seen it due to disconnect [22:01:45] (03CR) 10Jforrester: "Needs to bump wfUseMw as you said." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [22:02:06] mvolz: I didn't get any response. [22:02:22] 21:57:58 Chromium 41.0.2272 (Ubuntu) LOG: 'Exception in module-execute in module mediawiki.language.specialCharacters:' [22:02:22] 21:57:58 Chromium 41.0.2272 (Ubuntu) ERROR: 'TypeError: undefined is not a function', TypeError{} [22:02:23] Hmm. [22:02:35] Krenair: Do the tests pass locally? [22:03:11] TrevorParscal: Looks like we'll have a full week... :) [22:03:29] (03CR) 10Mooeypoo: "There are a few things we're styling differently, though, for the user to see, for instance, "language" annotations. We want those to rend" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [22:03:36] about buttons in OOJS UI [22:04:15] James_F, I think I know what that error could be caused by... [22:04:21] shoudln't frameless buttons and framed buttons be same in terms of the css? except for one specific rule of border-color:transparent? [22:04:59] nzr: "frameless" isn't a very good label. [22:05:31] James_F: I'm with you :) but that's what it's called in the css [22:05:40] nzr: Yeah. [22:05:54] traditionally called buttons and quiet buttons [22:05:57] ori: https://phabricator.wikimedia.org/T90040 [22:06:12] TrevorParscal: ack [22:06:22] Krenair: I'm going to guess that's probably a missing dependency [22:06:26] Yeah. [22:06:30] nzr: border-color: transparent aye? [22:06:39] I wonder if I made ResourceLoaderSpecialCharacterDataModule depend on the wrong module [22:06:47] yes so that it takes exact same number of pixels on the screen :P [22:06:47] (03PS1) 10Mooeypoo: Scroll to newly inserted elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) [22:06:49] I used .init, but added a function to the module without .init [22:06:53] RoanKattouw, ^^ [22:06:59] James_F: David/me in hangout [22:07:13] Krinkle: Is that an observation or a request? [22:07:14] nzr: I think having them take up the same space should work in theory, and if you don't want to do the border trick, 1px margin should do the same [22:07:14] And it happened to already be loaded in testing [22:07:20] Krinkle: Oh, the stand-up. [22:07:21] * James_F grins. [22:07:36] but, we should look at uses of frameless butotns [22:07:45] make sure we aren't imagining this is safe [22:07:50] TrevorParscal: but we need border for focus states of frameless buttons [22:08:15] TrevorParscal: also if we don't define anything for frameless buttons it will inherit property from buttonwelement and have same size as of all buttons. [22:08:29] and then we can just override the border-color to transparent; so that they are "frameless" [22:08:48] TrevorParscal: it will save us a lot of code and bring consistency between framed and frameless buttons [22:11:29] when i said anything* i meant anything related to paddings,margins,borders (things that take up space on the canvas) [22:12:17] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow: Toolbar should appear to be within text area - https://phabricator.wikimedia.org/T94112#1158520 (10EBernhardson) a:5Mattflaschen>3EBernhardson [22:14:33] (03PS8) 10Alex Monk: Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) [22:16:18] (03CR) 10jenkins-bot: [V: 04-1] Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [22:16:49] James_F: What happened? Last I heard was an "And please, especially <>" and then the connection dropped. [22:16:59] TrevorP|Away: ^ [22:18:11] Krinkle: "...since you guys are working on such high-point tasks, let us know if there's anything we can do to help you" [22:18:24] Krinkle: Apparently your computer believed we could help you by you not being in that meeting :P [22:18:56] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-03-18_(1.25wmf22): No longer possible to convert an auto-numbered link to one with a label - https://phabricator.wikimedia.org/T92525#1158545 (10Ryasmeen) [22:18:57] Hehe, thx. It seemed quite anti-climactic to break up there. [22:19:08] https://xkcd.com/979/ [22:20:33] RoanKattouw: btw, interesting thing in the fiddle. You know how margin-top is not like absolute, in that elements below it also shift. [22:20:49] Right [22:21:05] RoanKattouw: http://jsfiddle.net/t918auwq/ [22:21:13] But 1) there's nothing below and 2) everything else is position: absolute; [22:21:38] lol haha [22:21:54] So the bug only happens if the thing itself has a margin-top, not if something above it does [22:21:57] That makes sense actually [22:21:59] (03PS2) 10Mooeypoo: Scroll to newly inserted elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) [22:22:11] RoanKattouw: What about bounded rectangle? [22:24:14] Krinkle: ? [22:24:52] (03CR) 10Catrope: [C: 04-1] Scroll to newly inserted elements (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) (owner: 10Mooeypoo) [22:25:11] Krinkle: Oh you mean getBoundingRect()? [22:25:18] RoanKattouw: Yeah, just thinking. [22:25:38] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review, and 3 others: S5. Flow: Integrate VE toolbar in Flow entry fields - https://phabricator.wikimedia.org/T90764#1158565 (10Mattflaschen) [22:27:30] Krinkle: Those work correctly [22:27:31] James_F, another ISBN API to consider - https://www.librarything.com/wiki/index.php/LibraryThing_APIs [22:27:37] RoanKattouw: OK. So here's the bug,right? http://jsfiddle.net/rwLzswju/ [22:27:39] As in, the rects match the background-color-ed areas [22:27:47] RoanKattouw: I added text so that the margin-top doesn't colla[se [22:27:53] It was a bit counter intuitive for me [22:28:02] Krenair: James_F: Gentlemen, thank you for your help! [22:28:10] you're welcome [22:28:26] Krinkle: Yup that looks like a good example [22:29:04] (03CR) 10Jforrester: [C: 031] Fix: Handle case where Zotero gives us empty list [services/citoid] - 10https://gerrit.wikimedia.org/r/200163 (https://phabricator.wikimedia.org/T94178) (owner: 10Mvolz) [22:29:40] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Show two editing/view source tabs at all times, even if you can't edit page because it's protected - https://phabricator.wikimedia.org/T53549#1158571 (10Quiddity) Comment... I think it might be useful to have the suggested "view visual source" tab, primar... [22:30:23] RoanKattouw: So yeah, jQuery offset actually uses that afaik [22:30:27] 10VisualEditor, 10VisualEditor-DataModel, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: [Regression wmf18] Deleting the text inside a bullet/numbered item, heading, other nodes throws error - https://phabricator.wikimedia.org/T90478#1158580 (10Ryasmeen) [22:31:17] RoanKattouw: Maybe you can call offset() on both it and offsetParent() and make your own relative variant? [22:31:34] (assuming that works) [22:31:51] RoanKattouw: Or do you already have a godo work around and want me to file upstream? [22:32:09] So, what I said before was slightly wrong [22:32:16] 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-03-18_(1.25wmf22): Have the References list tool insert a general references list (99% action), rather than stopping to ask the user about which... - https://phabricator.wikimedia.org/T71727#1158588 [22:32:17] getRelativePosition in OOUI does in fact work correctly [22:32:52] Because it uses .offset() and .offset() isn't broken [22:33:05] Right [22:33:20] The offset subtraction logic you see in my fiddles is basically a reduced version of getRelativePosition [22:34:04] But it looks elaborate, and it looks like you should only really need it when the offset parents are different, because when two things share an offset parent you'd think you could just use .position() on A and stick the result into .css() on B [22:34:28] RoanKattouw: Right [22:34:30] But because of this bug, that doesn't work [22:35:06] Not that we do that currently; we do have different offset parents (although one is nested in the other) and we do use getRelativePosition, so it all works (the misalignment was caused by the margin-top rule just being complete BS and we cleaned that up) [22:35:13] RoanKattouw: But the visual position wil be different if the element has margin, outline, or transforms [22:35:14] But while debugging this I ran into this issue [22:36:06] RoanKattouw: Even if it would account for margin-top, it woudl still go wrong if element B also has its own margin-top [22:36:11] Yes [22:36:16] That's what went wrong for us [22:36:20] So there's no "absolute" position [22:36:49] not one that is safely transferrable [22:36:52] OK [22:36:53] But if B (the thing that's being positioned) has no margins or anything weird, then it should be easy to position it against A (the anchor) [22:37:03] Right [22:37:05] Even if A has margins or whatever [22:37:46] Not that it's likely, but imagine a case where A and B both have the same class (which gives it margin) and share the same offset parent. Then you'd also expect tarnsferring positions to work [22:37:59] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 7Verified-in-Phase0, and 3 others: Set a maxsize on the context menu display for references, as it can go pretty bad with nested nodes like big images inside a reference - https://phabricator.wikimedia.org/T91337#1158601 (10Ry... [22:38:14] Right, and that doesn't work either [22:38:32] RoanKattouw: I think it does with current .position() because it leaves margin out of it [22:38:41] 10Citoid, 5Patch-For-Review: http://www.ncbi.nlm.nih.gov/pmc/articles/PMC999999/ crashes citoid - https://phabricator.wikimedia.org/T94178#1158602 (10Mvolz) Related zotero ticket: https://github.com/zotero/translation-server/issues/14#issuecomment-87019273 [22:39:34] 10Citoid, 5Patch-For-Review: PMC pages with no results crash citoid - https://phabricator.wikimedia.org/T94178#1158605 (10Mvolz) [22:39:57] (03CR) 10Mooeypoo: Scroll to newly inserted elements (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) (owner: 10Mooeypoo) [22:40:35] Right [22:42:14] (03PS3) 10Mooeypoo: Scroll the selection into view when it is outside the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) [22:42:26] RoanKattouw: e.g. like this http://jsfiddle.net/rwLzswju/1/ [22:43:53] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-References, 7Verified-in-Phase0, and 2 others: Context menu does not update the change immediately unless you re-open it - https://phabricator.wikimedia.org/T91336#1158633 (10Ryasmeen) [22:45:42] http://jsfiddle.net/rwLzswju/3/ :D [22:45:51] RoanKattouw: anyway, so back to OO UI. [22:45:54] Good now? [22:47:49] Krinkle: OOUI is fine, I'm just expressing frustration that one of jQuery's position measurement functions takes margins into account while the other doesn't [22:48:06] (03PS1) 10Alex Monk: Move WikiEditor's special character data and messages out to core [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/200249 (https://phabricator.wikimedia.org/T91608) [22:48:08] At first I thought that that broke OOUI, but it doesn't because OOUI uses the right one [22:48:08] Krinkle: *cough* focus *cough* [22:48:12] Also yes [22:48:17] What James said :) [22:48:38] RoanKattouw: Yeah. I think it's one of those map/each things, maybe in jQuery 3.0 (which isn't that far away actually), but unlikely. map/each, for one, was rejected to be changed. [22:48:41] even for 3.0 [22:48:44] (03CR) 10Physikerwelt: [C: 032] Fix: Clear relevance map for each term [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200241 (owner: 10Physikerwelt) [22:49:15] RoanKattouw: I'll call out to have it be included on the api documentation at leats. [22:49:17] * Krinkle makes note [22:50:06] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T78540#1158652 (10Jdforrester-WMF) [22:50:07] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Unnecessary s inserted into articles - https://phabricator.wikimedia.org/T71494#1158653 (10Jdforrester-WMF) [22:50:11] James_F: It's not working on beta. Did it not get merged / not running latest master? [22:50:20] (03Merged) 10jenkins-bot: Fix: Clear relevance map for each term [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/200241 (owner: 10Physikerwelt) [22:50:29] Krinkle: What isn't working? [22:50:35] Editnotice-notext [22:50:51] Oh nevermind [22:50:59] Makes sense now [22:51:05] (03CR) 10Catrope: Scroll the selection into view when it is outside the window (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) (owner: 10Mooeypoo) [22:51:05] It defaults to blank, right? [22:51:06] It is missing /qqq but that's a beta bug I gues. [22:51:15] (03CR) 10jenkins-bot: [V: 04-1] Move WikiEditor's special character data and messages out to core [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/200249 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [22:51:20] I normally identify messages existing by /qqq being non-empty [22:51:30] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1158655 (10Jdforrester-WMF) [22:51:41] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#748882 (10Jdforrester-WMF) a:5Catrope>3Esanders [22:51:57] (03CR) 10Alex Monk: "See I8fafd734 for a possible fix for the test failure" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/200249 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [22:52:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T78540#847764 (10Jdforrester-WMF) On examination we decided that t... [22:53:03] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1158675 (10Jdforrester-WMF) [22:53:26] 10VisualEditor, 10VisualEditor-CopyPaste: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T78540#1158678 (10Jdforrester-WMF) a:5Esanders>3None [22:54:19] (03PS4) 10Mooeypoo: Scroll the selection into view when it is outside the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) [22:56:19] (03CR) 10jenkins-bot: [V: 04-1] Scroll the selection into view when it is outside the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) (owner: 10Mooeypoo) [22:59:55] wtf. [23:02:47] 10VisualEditor, 10Analytics-EventLogging, 6Analytics-Kanban: Wikitext events need to be sampled {lion} - https://phabricator.wikimedia.org/T93201#1158753 (10kevinator) [23:03:04] 10VisualEditor, 10VisualEditor-Tables, 5Patch-For-Review: Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1158756 (10Tbayer) Agree with @Whatamidoing-WMF and @Thryduulf that a tooltip or such would be very useful - I seriously... [23:03:09] 10VisualEditor, 10Flow: Way for VE to run on Flow without changing wgVisualEditorNamespaces - https://phabricator.wikimedia.org/T94282#1158757 (10Mattflaschen) 3NEW [23:08:36] (03CR) 10Mobrovac: [C: 032 V: 032] Fix: Handle case where Zotero gives us empty list [services/citoid] - 10https://gerrit.wikimedia.org/r/200163 (https://phabricator.wikimedia.org/T94178) (owner: 10Mvolz) [23:10:44] 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 3Roadmap, 7notice: Be able to re-order the columns or rows of a table by dragging them to another position in VisualEditor - https://phabricator.wikimedia.org/T88694#1158798 (10Tbayer) [23:12:37] (03CR) 10Mobrovac: [C: 032 V: 032] Restructure requestFromDOI + tests [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) (owner: 10Mvolz) [23:13:15] WTF [23:13:17] (03PS1) 10Jforrester: Update jQuery from v1.8.2 to v1.11.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200254 [23:13:20] Number.parseInt exists in Chrome but not in IE [23:13:34] wut. [23:13:39] Any IE version? [23:13:53] Did we break IE support by using that? [23:14:43] (03PS1) 10Catrope: Use parseInt(), not Number.parseInt() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200255 [23:15:39] (03CR) 10Jforrester: [C: 031] Use parseInt(), not Number.parseInt() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200255 (owner: 10Catrope) [23:15:57] 10Citoid, 5Patch-For-Review, 5WMF-deploy-2015-04-01_(1.25wmf24): PMC pages with no results crash citoid - https://phabricator.wikimedia.org/T94178#1158805 (10Jdforrester-WMF) 5Open>3Resolved [23:16:14] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24): DOI lookup returns a scraped "missing cookie" page instead of desired content - https://phabricator.wikimedia.org/T93785#1158807 (10Jdforrester-WMF) 5Open>3Resolved [23:16:31] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24): DOI lookup returns a scraped "missing cookie" page instead of desired content - https://phabricator.wikimedia.org/T93785#1146107 (10Jdforrester-WMF) [23:16:32] 10Citoid, 7Technical-Debt, 5WMF-deploy-2015-04-01_(1.25wmf24): Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1158812 (10Jdforrester-WMF) 5Open>3Resolved [23:18:47] (03CR) 10Alex Monk: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/200249 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [23:19:03] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [23:20:10] 10VisualEditor, 10VisualEditor-Tables, 7Design: Tables: If you select N rows / columns and click "insert above/below" or "… left/right", VE should insert N rows / columns, not 1 - https://phabricator.wikimedia.org/T75227#1158863 (10Tbayer) FWIW, this is the default behavior both in [[https://www.youtube.com/... [23:20:54] (03PS5) 10Jforrester: Scroll the selection into view when it is outside the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) (owner: 10Mooeypoo) [23:21:08] (03CR) 10Jforrester: [C: 031] Scroll the selection into view when it is outside the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200243 (https://phabricator.wikimedia.org/T53911) (owner: 10Mooeypoo) [23:21:18] (03CR) 10Alex Monk: [C: 032] Use parseInt(), not Number.parseInt() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200255 (owner: 10Catrope) [23:23:24] (03Merged) 10jenkins-bot: Use parseInt(), not Number.parseInt() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200255 (owner: 10Catrope) [23:24:07] (03CR) 10Trevor Parscal: [C: 032] Update jQuery from v1.8.2 to v1.11.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200254 (owner: 10Jforrester) [23:26:26] (03Merged) 10jenkins-bot: Update jQuery from v1.8.2 to v1.11.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200254 (owner: 10Jforrester) [23:28:09] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 3VisualEditor 2014/15 Q3 blockers: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1158888 (10TrevorParscal) [23:28:10] (03PS2) 10Mattflaschen: Allow rejecting Process with single Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/198473 (https://phabricator.wikimedia.org/T93465) [23:29:08] (03PS1) 10Mobrovac: Upgrade preq to 0.13.3 [services/citoid] - 10https://gerrit.wikimedia.org/r/200258 [23:29:29] (03CR) 10Trevor Parscal: [C: 031] "API is ok with me" [oojs/ui] - 10https://gerrit.wikimedia.org/r/198473 (https://phabricator.wikimedia.org/T93465) (owner: 10Mattflaschen) [23:29:35] (03CR) 10Mobrovac: [C: 032 V: 032] Upgrade preq to 0.13.3 [services/citoid] - 10https://gerrit.wikimedia.org/r/200258 (owner: 10Mobrovac) [23:30:10] (03PS3) 10Mooeypoo: Make default property interfaceText [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) [23:32:09] (03PS1) 10Aaron Schulz: [WIP] Stash edits alongside the html -> wikitext stashing step [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200260 (https://phabricator.wikimedia.org/T90040) [23:32:26] (03CR) 10Aaron Schulz: "[16:16] RoanKattouw: we can assume CONTENT_MODEL_WIKITEXT with postHTML results right?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200260 (https://phabricator.wikimedia.org/T90040) (owner: 10Aaron Schulz) [23:36:15] <7JTAAA4QH> wikimedia/grunt-banana-checker#45 (master - 2fb21b2 : James Forrester): The build passed. [23:36:15] <7JTAAA4QH> Change view : https://github.com/wikimedia/grunt-banana-checker/compare/1e0a13549359...2fb21b2343cd [23:36:15] <7JTAAA4QH> Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/56167543 [23:39:36] (03PS1) 10Jforrester: build: Update grunt-banana-checker to v0.2.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/200261 [23:40:57] (03PS1) 10Jforrester: build: Update grunt-banana-checker to v0.2.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200263 [23:42:01] (03PS1) 10Jforrester: build: Update grunt-banana-checker to v0.2.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200264 [23:49:50] (03PS1) 10Jforrester: build: Update grunt-banana-checker to v0.2.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/200267 [23:51:03] (03PS1) 10Jforrester: build: Update grunt-banana-checker to v0.2.1 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/200269 [23:51:38] RoanKattouw: Can I grab a suite of +2s on https://gerrit.wikimedia.org/r/#/q/status:open+topic:banana-0.2.1,n,z [23:52:00] <21WABQ8ZI> wikimedia/grunt-banana-checker#47 (v0.2.1 - 04f6f3d : James D. Forrester): The build has errored. [23:52:00] <21WABQ8ZI> Change view : https://github.com/wikimedia/grunt-banana-checker/compare/v0.2.1 [23:52:00] <21WABQ8ZI> Build details : http://travis-ci.org/wikimedia/grunt-banana-checker/builds/56168106 [23:56:28] mooeypoo: https://gerrit.wikimedia.org/r/#/q/status:open+topic:banana-0.2.1,n,z [23:57:02] (03CR) 10Mooeypoo: [C: 032] build: Update grunt-banana-checker to v0.2.1 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/200269 (owner: 10Jforrester) [23:58:08] (03CR) 10Mooeypoo: [C: 032] build: Update grunt-banana-checker to v0.2.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/200267 (owner: 10Jforrester) [23:58:30] (03CR) 10Mooeypoo: [C: 032] build: Update grunt-banana-checker to v0.2.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200264 (owner: 10Jforrester) [23:58:52] (03CR) 10Mooeypoo: [C: 032] build: Update grunt-banana-checker to v0.2.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200263 (owner: 10Jforrester) [23:59:01] (03CR) 10Mooeypoo: [C: 032] build: Update grunt-banana-checker to v0.2.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/200261 (owner: 10Jforrester)