[00:00:51] (03Merged) 10jenkins-bot: build: Update grunt-banana-checker to v0.2.1 [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/200269 (owner: 10Jforrester) [00:02:11] James_F: RoanKattouw_away: https://github.com/jquery/api.jquery.com/issues/342 [00:02:14] Now official [00:02:21] So we can sleep safe [00:06:04] (03PS1) 10Bartosz Dziewoński: Refactor icon handling again [oojs/ui] - 10https://gerrit.wikimedia.org/r/200272 (https://phabricator.wikimedia.org/T93669) [00:06:10] the icons are the worst. [00:11:33] (03Merged) 10jenkins-bot: build: Update grunt-banana-checker to v0.2.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/200267 (owner: 10Jforrester) [00:11:35] (03Merged) 10jenkins-bot: build: Update grunt-banana-checker to v0.2.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200264 (owner: 10Jforrester) [00:11:37] (03Merged) 10jenkins-bot: build: Update grunt-banana-checker to v0.2.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200263 (owner: 10Jforrester) [00:11:39] (03Merged) 10jenkins-bot: build: Update grunt-banana-checker to v0.2.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/200261 (owner: 10Jforrester) [00:20:47] 10OOjs-UI, 10UI-Standardization, 7Design: TextInput's height is not consistent with the rest of controls - https://phabricator.wikimedia.org/T94289#1158956 (10violetto) 3NEW [00:22:34] 10OOjs-UI, 10UI-Standardization, 7Design: Dropdown menu's height is not consistently sized with other controls - https://phabricator.wikimedia.org/T94290#1158965 (10violetto) 3NEW [00:23:07] MatmaRex: That's seriously neat. :-) [00:25:57] (03PS2) 10Bartosz Dziewoński: Refactor icon handling again [oojs/ui] - 10https://gerrit.wikimedia.org/r/200272 (https://phabricator.wikimedia.org/T93669) [00:26:49] James_F: heh :) [00:27:18] MatmaRex: Now we [00:27:20] Bah. [00:27:31] MatmaRex: Now we 'just' need to support language blocks for specifying images. [00:28:04] Or does RLIM already do that and I'm just unschooled? [00:31:30] MatmaRex: (I was randomly speculating that something like https://gerrit.wikimedia.org/r/#/c/196512/2/src/themes/mediawiki/images.json as a format might be sane, but I still need to discuss it with a real human.) [00:32:22] James_F: RLIM does do that. i think i will just make colorize-svg.js ignore those specifications, assuming we don't want hundreds of dsitributions. [00:32:35] MatmaRex: Ignore or include but not split? [00:32:59] MatmaRex: Ignore is a bit meh for downstream VE-core users. [00:33:14] But include is a bit meh for MW-core (we'd have to exclude I guess). [00:33:38] James_F: RLIM supports the whole shebang, here's examples: http://pastebin.com/0VgfaSvX [00:34:07] MatmaRex: Neat. [00:34:39] James_F: colorize-svg.js will probably only support the first form [00:34:47] :-( [00:34:47] also, i need to rename that 'image' to 'file'. [00:35:02] James_F: (with automatic CSSJanus RTL flipping) [00:35:06] Sure. [00:35:27] But https://phabricator.wikimedia.org/T76540 requires the third form. [00:35:43] Indeed, that example /is/ that task. :-) [00:35:48] yeah [00:36:38] Shall we make colorize-svg.js support only the first two forms for now, but output the right JSON so RLIM is used for MW so we fix the bug? [00:36:46] And then consider making colorize-svg.js implement the whole lot later? [00:36:49] yes [00:37:15] hmm, maybe we could get something sensible with some :lang() selectors in CSS. [00:37:55] Could we do those for LTR/RTL too, to kill of half our stylesheets? Or are they very lang specific? [00:37:57] that would probably not cooperate very well with MediaWiki, but we won't be using that output in MediaWiki anymore then. [00:38:02] * James_F nods. [00:38:48] yes and no. we could achieve the effect with some JS and CSS (not :lang() though), but we probably don't want to embed all flipped files twice. [00:39:21] I'm in favour of trying out :lang(). [00:39:31] And yes, bypassing for MW. :-) [00:39:41] If we have to retain LTR/RTL so be it. [00:39:52] I'm just uneasy at how many files we have already. [00:40:30] we could slash it in half by removing the icons no one is ever going to use, and merging some sets. ;) [00:40:53] That bloats the size of the packs. [00:40:57] They're large enough already. [00:41:12] And killing off icons isn't our call. :-) [00:42:13] The inheritance of :lang() it helpful. [00:42:30] 10OOjs-UI: Be able to specify languages for icons (not just use ltr -> rtl substitution) - https://phabricator.wikimedia.org/T76539#1158976 (10matmarex) For MediaWiki, we can use ResourceLoader and ResourceLoaderImageModule, which support this kind of thing natively. For standalone OOjs UI, we should try out so... [00:42:53] There's :dir(). [00:43:24] Oh, but it's FF only. [00:43:30] Dammit. [00:44:28] It's in http://dev.w3.org/csswg/selectors-4/#the-dir-pseudo but that's editor's draft only. [00:47:12] 10OOjs-UI: Be able to specify languages for icons (not just use ltr -> rtl substitution) - https://phabricator.wikimedia.org/T76539#1158978 (10Jdforrester-WMF) We could also merge the LTR/RTL stuff together with `:dir()` selectors, which are coming 'soon' if the current draft of Selectors 4 remains true: [[ http... [00:48:33] are we going to wait for restbase to be used everywhere before closing https://phabricator.wikimedia.org/T91608 ? [00:48:57] Krenair: Special characters… no? [00:49:01] um [00:49:03] wrong link [00:49:11] Oh. [00:49:16] that one: https://phabricator.wikimedia.org/T90374 [00:49:25] Aha. [00:49:36] Oh, whoops, thought it was closed. [00:49:45] 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1158981 (10Jdforrester-WMF) 5Open>3Resolved [00:51:50] 10OOjs-UI: Be able to specify languages for icons (not just use ltr -> rtl substitution) - https://phabricator.wikimedia.org/T76539#1158982 (10matmarex) a:3matmarex [00:53:15] Ha. [00:53:24] Didn't mean to push you into doing it right now. :-) [00:54:04] not right now, but it's the natural next step [00:54:14] i am officially blocked on my code getting reviews now ;) [00:54:22] Well. [00:54:31] I /could/ just +2 your code blind. ;-) [00:54:34] But yeah. [00:54:58] Actually. [00:55:15] https://gerrit.wikimedia.org/r/#/c/196512/2/src/themes/mediawiki/images.json [00:55:29] The syntax I used was massively compressed compared to RLIM's. [00:55:46] would be nice for someone other than me to give that code a good think, too. [00:55:51] Yeah, completely. [00:55:55] or not code, rather, but the concept [00:56:00] i already know the code is awful [00:56:27] and yeah, compressed indeed. we could probably implement that in RLIM, looks neat. [00:57:13] James_F: When did you say citoid would be deployed on enwiki and others? [00:57:29] Negative24: Monday. [00:57:35] Negative24: That's the plan, at least. [00:57:40] Monday morning SWAT? [00:57:50] Afternoon [00:57:58] Alright [00:59:39] is there still config to do for that? [00:59:56] I thought I stuck it on all >=wmf22 wikis [01:00:10] Krenair: Citoid needs to be configured on. [01:00:15] Krenair: Lots and lots of configuration. [01:00:25] Krenair: And I've held off doing it yet for enwiki. [01:00:27] not just on-wiki stuff? [01:00:35] The off-wiki stuff is all done. [01:00:56] right so it's not actually part of swat or any other deployment window [01:01:13] No. [01:04:11] 10OOjs-UI: Be able to specify languages for icons (not just use ltr -> rtl substitution) - https://phabricator.wikimedia.org/T76539#1158988 (10Jdforrester-WMF) It's be nice to implement a more compact format for our sanity – one proposal: {P448} [01:04:30] Krenair: However, Monday morning SWAT is when we switch VE on for "phase 5" wikis. [01:05:37] oh... [01:05:40] They would like my special character inserter changes, I guess? [01:07:38] Krenair: Yes, they'll love it when it's ready. [01:07:46] Krenair: But let's not rush past testing things. [01:08:01] Right, as long as they don't really need it for monday morning :) [01:08:47] Krenair: :-) [01:09:00] Krenair: I'm sure they'll love it in 12 days' time. [01:19:56] 10OOjs-UI, 5Patch-For-Review: OO.ui.Process step promise can not reject with a single error - https://phabricator.wikimedia.org/T93465#1159032 (10Jdforrester-WMF) p:5Triage>3High [01:20:19] 10OOjs-UI, 5Patch-For-Review: indicator missing from ButtonSelectWidget (MediaWiki skin) - https://phabricator.wikimedia.org/T92553#1159036 (10Jdforrester-WMF) p:5Triage>3High a:3kaldari [01:21:16] 10OOjs-UI, 10Living-Style-Guide, 10UI-Standardization, 7Design, 5Patch-For-Review: Add 'warning' or 'warn' flag to OOjs UI stylings - https://phabricator.wikimedia.org/T92026#1159039 (10Jdforrester-WMF) a:3Prtksxna [01:21:27] 10OOjs-UI, 10OOjs-UI-0.9.1, 10UI-Standardization, 7Design, and 3 others: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1159040 (10Jdforrester-WMF) a:5Prtksxna>3None [01:21:46] 10OOjs-UI, 10OOjs-UI-0.9.1, 10UI-Standardization, 7Design, and 2 others: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#752298 (10Jdforrester-WMF) [01:22:09] 10OOjs-UI, 10OOjs-UI-0.9.1, 10UI-Standardization, 7Design, and 2 others: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#752298 (10Jdforrester-WMF) a:3Prtksxna [01:25:43] (03Abandoned) 10Bartosz Dziewoński: Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [01:32:35] James_F: Have you ever experienced this as far as you know? https://code.google.com/p/chromium/issues/detail?id=471436& [01:33:03] Hmm. A bit, sometimes. [01:33:17] see screenshots below for quick sample [01:33:23] Not like it's all the time, though. [01:33:27] interesting [01:39:17] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1159056 (10Mattflaschen) @PGiner-WMF's notes from {T90764}: > * The button to switch between VE and wikite... [02:04:33] 10OOjs: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1159059 (10matmarex) 5stalled>3Open [02:04:33] 10OOjs-UI: Turn on type checking for OO.ui.infuse. - https://phabricator.wikimedia.org/T90929#1159062 (10matmarex) [02:18:48] (03PS1) 10Bartosz Dziewoński: Alias Class.static to Class itself and copy static properties rather than inherit [oojs/core] - 10https://gerrit.wikimedia.org/r/200279 (https://phabricator.wikimedia.org/T89721) [02:18:59] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1159073 (10matmarex) I tried that – see patch above – and it turned out to be too good to be true. ES6 defines a [[ https://developer.mozilla.org/en-US/... [02:19:36] (03CR) 10jenkins-bot: [V: 04-1] Alias Class.static to Class itself and copy static properties rather than inherit [oojs/core] - 10https://gerrit.wikimedia.org/r/200279 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [02:32:31] (03CR) 10Bartosz Dziewoński: [C: 032] Allow rejecting Process with single Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/198473 (https://phabricator.wikimedia.org/T93465) (owner: 10Mattflaschen) [02:35:06] (03Merged) 10jenkins-bot: Allow rejecting Process with single Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/198473 (https://phabricator.wikimedia.org/T93465) (owner: 10Mattflaschen) [02:35:19] 10OOjs-UI, 5Patch-For-Review: OO.ui.Process step promise can not reject with a single error - https://phabricator.wikimedia.org/T93465#1159083 (10Mattflaschen) 5Open>3Resolved [02:57:06] (03CR) 10Trevor Parscal: [C: 032] Parent constructor simplification [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200218 (owner: 10Esanders) [02:58:17] (03CR) 10Trevor Parscal: [C: 032] Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [02:58:54] (03Merged) 10jenkins-bot: Parent constructor simplification [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200218 (owner: 10Esanders) [03:00:07] (03Merged) 10jenkins-bot: Load all of WikiEditor's special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/197357 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [04:49:02] Noobie question here: once I added a new message to i18n, how do I register it for load? [04:51:45] Right now it's showing up as [05:02:55] what's the context here? a plugin? or are you doing ve development? [05:04:42] It doesn't matter much, I'm just curious :p [05:04:45] I think you'll probably want to add the message key to the list of messages in your wgResourceModules entry [05:05:10] so it gets transferred for use on the JavaScript side [08:19:35] 10OOjs-UI, 7Accessibility: ButtonWidget icon only has no visual focused state, thought it can be focused - https://phabricator.wikimedia.org/T87691#1159161 (10TheDJ) wow, did I spell this ? Must have been late.... [08:53:10] 10Citoid: Find out why Italian news outlets link generate a "Cite web" template rather than a "Cite news" one - https://phabricator.wikimedia.org/T94170#1159164 (10Elitre) @qgil: Is writing translations for Zotero a task suitable for GSOC or similar initiatives? Thanks :) [08:54:24] 10VisualEditor: Link Types: easy addition of structured metadata added to hyperlinking dialog in VE - https://phabricator.wikimedia.org/T94295#1159166 (10Jrf) 3NEW a:3tosfos [09:26:18] 10VisualEditor: Structured Summary: gentle prompting for structured fields when editing in VE - https://phabricator.wikimedia.org/T94296#1159178 (10Jrf) 3NEW a:3tosfos [09:28:49] 10VisualEditor: Link Types: easy addition of structured metadata added to hyperlinking dialog in VE - https://phabricator.wikimedia.org/T94295#1159187 (10Jrf) [10:30:26] (03CR) 10Esanders: "I don't think that's important. The only reason we highlight language annotations is to make then easier to edit. A preview mode is not fo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [14:01:14] 10WikiEditor: Wikieditor (Revert making installable via composer) - https://phabricator.wikimedia.org/T93616#1159310 (10MarkAHershberger) Legoktm writes: >> I think removing support for installation-by-composer while adding >> support for "composer test" seems a little backwards. > > > Why? Because you are wor... [14:11:41] 10WikiEditor, 5Patch-For-Review: Wikieditor (Revert making installable via composer) - https://phabricator.wikimedia.org/T93616#1159314 (10MarkAHershberger) Please +2 the patch and re-register this extension in packagist. [14:14:02] 10OOjs-UI: Apex theme: various widgets have no focus state, including ButtonWidget - https://phabricator.wikimedia.org/T94301#1159315 (10Esanders) 3NEW a:3matmarex [14:14:05] 10WikiEditor, 5Patch-For-Review: Wikieditor (Revert making installable via composer) - https://phabricator.wikimedia.org/T93616#1159323 (10MarkAHershberger) We should probably also start too look for other extensions that had "composer install" removed since that could cause problems for people's MediaWiki ins... [14:46:45] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1159345 (10Mvolz) @Elitre, changes to the DOI converter are live, would you mind rechecking these? [14:48:39] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1159346 (10Mvolz) @Elitre, scratch that, they've been merged but aren't live yet :). I'll let you know when they are. [15:01:44] VisualEditor failed to load: Error: Module ext.visualEditor.core has failed dependencies , i am getting this error visual editor is not loading [15:04:59] edsanders: ^ [15:18:46] rits: Saturday. :( You might not get a reply today or tomorrow. [15:18:53] hi [15:18:57] on what wiki? [15:19:26] rits_: [15:20:00] rits: ^ [15:20:24] MatmaRex: visualeditor i didnt get mediawiki version is 1.24 [15:20:38] NIharika: sorry just seen [15:21:24] MatmaRex: i am using it in my localhost [15:21:52] rits_: are you sure you have compatible versions of MediaWiki and VisualEditor? [15:22:10] if you're using MW 1.24, you'll need the older version of VE for MW 1.24 [15:22:43] MatmaRex: yes it was working perfectly two days ago i just updated it [15:23:01] older version from git, actually i am using for development purpose [15:23:11] updated what? [15:23:43] make sure MW core is up to date with the latest from git [15:23:56] MatmaRex: i meant the git pull [15:24:15] rits_: also, have you updated the lib/ve submodule? in extensions/VisualEditor directory, run `git submodule update` [15:24:25] or rather, `git submodule update --init` [15:24:34] edsanders: ok will do [15:24:45] MatmaRex: ok [15:26:15] MatmaRex: aha :) thank you [15:26:34] MatmaRex: resolved :) [15:27:41] :) [15:56:22] MatmaRex: started on the editsection+header thing [15:56:33] oooh. <3 [15:56:59] that's gonna be very painful.... [16:24:10] anyone know why gerrit would be rejecting my change with the reason that it relies on a closed commit... which has been merged? [16:24:31] I have the latest version of master and I rebased my branch against it [16:24:52] history looks totally fine, matches what's in master, except of course I have a new change on top of master's HEAD... [16:40:52] 10Citoid: Add TESTS - https://phabricator.wikimedia.org/T91168#1159388 (10Mvolz) [16:41:22] mvolz: When you hit "git review" does it show say that you're about to submit multiple patches? [16:41:44] I got my question answered in another channel :) [16:41:55] Oh okay. :) [16:42:04] But essentially what happened was that I had two of the same commit in my local tree [16:42:09] so it didn't match what was on gerrit [16:42:28] it was a messy rebase :) [16:42:33] Aha. [16:42:45] Happened too many times with me. [16:52:32] in the event you're in the same sit. git rebase HEAD~1 --onto master will just plop your current commit onto master [16:52:51] without trying to merge all the prior commits with master, which is how I got into trouble [16:53:07] rebase HEAD~1 --onto master [18:42:30] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1159482 (10Esanders) @gpaumier no, but https://gerrit.wikimedia.org/r/#/... [20:23:34] 10VisualEditor, 10VisualEditor-ContentEditable: Focusable node de-selected on copy - https://phabricator.wikimedia.org/T94313#1159533 (10Esanders) 3NEW a:3Esanders [20:38:09] 10VisualEditor-Links: Visual Editor links on new pages are broken (uses /w/ instead of /wiki/) - https://phabricator.wikimedia.org/T94315#1159577 (10He7d3r) 3NEW [22:24:03] 10WikiEditor, 5Patch-For-Review: Wikieditor (Revert making installable via composer) - https://phabricator.wikimedia.org/T93616#1159673 (10greg) >>! In T93616#1142993, @MarkAHershberger wrote: > Also, the "If you're running 'dev-*' ..." reasoning seems weak to me given the WMF's schedule for rolling out change... [22:32:31] 10WikiEditor, 5Patch-For-Review: Wikieditor (Revert making installable via composer) - https://phabricator.wikimedia.org/T93616#1159675 (10Legoktm) >>! In T93616#1159310, @MarkAHershberger wrote: > Because you are working to improve the module's integration with > composer ("composer test") but then removing i... [23:12:42] 10MediaWiki-ResourceLoader, 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 3VisualEditor 2014/15 Q3 blockers: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1159712 (10Krenair) [23:24:02] 10MediaWiki-ResourceLoader, 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 3VisualEditor 2014/15 Q3 blockers: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1159718 (10Krenair) Thanks @TheDJ. So I think we have all the previously-WikiEdit...