[00:07:44] [13grunt-banana-checker] 15Krinkle 04deleted 06dereckson-patch-1 at 14eb6cc68: 02https://github.com/wikimedia/grunt-banana-checker/commit/eb6cc68 [00:11:17] Krinkle: How's the enwiki edit notice work going? [00:44:43] 10VisualEditor: Schema:Edit seems to incorrectly set users as anonymous. - https://phabricator.wikimedia.org/T92596#1161243 (10Krenair) I think it's unlikely that we would say we are definitely doing it correctly. I can think of nothing wrong with the code at the moment. In both cases, we just do this: ``` if (... [00:46:06] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1161244 (10Jdforrester-WMF) [00:48:35] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers, 7user-notice: Special character inserter width needs adjusting - https://phabricator.wikimedia.org/T78038#1161246 (10Jdforrester-WMF) a:3Esanders [00:48:47] 10Citoid, 3VisualEditor 2014/15 Q3 blockers: Citoid will get results localised for server location, not user - https://phabricator.wikimedia.org/T88894#1161247 (10Jdforrester-WMF) a:3Mvolz [00:49:02] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1161248 (10Jdforrester-WMF) a:3ssastry [00:49:12] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: Measure how often Parsoid cache misses happen, and what load performance is like in this case - https://phabricator.wikimedia.org/T86733#1161250 (10Jdforrester-WMF) a:3ssastry [00:49:32] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers: [Regression pre-wmf21] Tool bar does not stay in focus when a page scrolls down - https://phabricator.wikimedia.org/T92305#1161251 (10Jdforrester-WMF) a:3matmarex [00:49:42] 10VisualEditor, 10VisualEditor-Performance, 3VisualEditor 2014/15 Q3 blockers: Attempt to optimize / profile VisualEditor's existing load code flow to see what is actually slow? - https://phabricator.wikimedia.org/T86732#1161252 (10Jdforrester-WMF) a:3Catrope [00:49:51] 10Citoid, 3VisualEditor 2014/15 Q3 blockers: Let language be requested in header and pass this through to Scraper.js - https://phabricator.wikimedia.org/T90600#1161253 (10Jdforrester-WMF) a:3Mvolz [00:51:35] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Internal links [[Xxx]] replaced by [[./Xxxx]] - https://phabricator.wikimedia.org/T93754#1161255 (10Jdforrester-WMF) [00:51:47] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Internal links [[Xxx]] replaced by [[./Xxxx]] - https://phabricator.wikimedia.org/T93754#1161257 (10Jdforrester-WMF) 5Open>3Resolved a:3ssastry [01:00:28] (03CR) 10Jforrester: [C: 031] Refactor icon handling again [oojs/ui] - 10https://gerrit.wikimedia.org/r/200272 (https://phabricator.wikimedia.org/T93669) (owner: 10Bartosz Dziewoński) [01:10:23] (03CR) 10Alex Monk: "Have asked Matt Flaschen (superm401) to review for the potential Flow issue" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200260 (https://phabricator.wikimedia.org/T90040) (owner: 10Aaron Schulz) [01:11:36] James_F: Left a comment on the bug [01:11:38] yesterday [01:11:48] Krinkle: Which one? [01:11:57] The one about enwiki edit notices [01:12:12] Oh, https://phabricator.wikimedia.org/T91715 ? [01:12:19] Indeed [01:12:39] So the next step is to implement on enwiki? [01:12:56] Or change the implementation. [01:13:02] It's not really pretty [01:13:10] Need an ambassador of sorts [01:14:01] There are probably no people on wiki who feel they own that system. [01:14:09] Let alone someone who can make representations to them. [01:14:15] {{Justdoit}} [01:14:48] If you want, I can do it from my staff account. [01:14:53] But I'll probably break things. ;-) [01:15:09] What do you want? [01:15:18] https://phabricator.wikimedia.org/T87412 needs a code change to remove the logic, I assume. [01:25:53] >>> typeof ['a', 'b'] [01:25:54] Krenair: (string) 'object' [01:26:38] (03PS1) 10Alex Monk: Handle a further 70 WikiEditor special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200504 [01:29:37] 10MediaWiki-ResourceLoader, 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, and 2 others: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1161264 (10Krenair) >>! In T91608#1159718, @Krenair wrote: > Thanks @TheDJ. > > So I think we have all t... [01:31:00] Oh, hmm, Krenair, I didn't notice that we were replacing the wiki list for special characters. [01:31:33] Oh, we were going to have a way to support those, weren't we? [01:31:46] The idea is that the local wiki would be able to create a list of characters to show. [01:32:06] Yeah. First item in the list, "Often used" or something. [01:32:23] Create a new message maybe to avoid complicating things. [01:32:39] right, fixing :) [01:32:39] MediaWiki:Visualeditor-quick-access-characters.json. [01:32:42] Thanks. [01:34:12] James_F, what about the ones we had in Visualeditor-specialcharinspector-characterlist-insert? [01:34:21] Ignore them. [01:34:36] Easier to create a new one, default blank. [01:34:55] And only show the "Often used" group when the message exists. [01:35:48] Make sense? [01:36:07] (At some point we'll need to think about working out support for this in VE-core.) [01:41:56] Eek. [01:41:58] Krenair: http://en.wikipedia.beta.wmflabs.org/wiki/ThisPageDoesNotExist?veaction=edit [01:42:12] "Error loading data from server: [object Object]: error. Would you like to try again?" [01:42:17] Seen that before? [01:42:37] no [01:43:03] restbase returned detail: "Page or revision not found." [01:43:11] wonder if that caused it [02:03:36] (03PS1) 10Alex Monk: Support an "other" page for special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200505 [02:07:50] James_F, of course, this error would not occur on our dev machines because we don't run restbase :) [02:07:59] Krenair: :-) [02:13:24] Which is why I told them we'd require it on beta [02:21:18] Yeah. [02:33:12] heh [02:33:14] 404 OK [02:46:54] (03PS1) 10Alex Monk: Try not to die when RESTbase returns a 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 [02:48:35] (03PS2) 10Alex Monk: Try not to die when RESTbase returns a 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 [02:50:33] (03CR) 10jenkins-bot: [V: 04-1] Try not to die when RESTbase returns a 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 (owner: 10Alex Monk) [02:54:00] (03PS3) 10Alex Monk: Try not to die when RESTbase returns a 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 [02:57:56] (03CR) 10Alex Monk: "Roan: This should deal with the error that comes up when trying to edit a non-existent page (see beta)... I considered using the same beha" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 (owner: 10Alex Monk) [03:12:41] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1161315 (10ferdbold) [03:14:35] 10VisualEditor, 10VisualEditor-Tables, 5Patch-For-Review: Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1161316 (10ferdbold) a:3ferdbold [03:26:53] (03CR) 10Mooeypoo: [C: 04-1] "Tiny code style comment" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [06:26:38] edsanders|away: I didn't see your comment about the malformed LESS until today because I was lagging way behind on my gerrit mail. I am sorry! [06:41:22] (03CR) 10Catrope: [C: 04-1] Try not to die when RESTbase returns a 404 (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 (owner: 10Alex Monk) [06:43:15] (03CR) 10Catrope: "The "relying on RB for title existence" concern seems like it would magically be taken care of: if we return an empty string as the HTML, " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 (owner: 10Alex Monk) [07:43:18] 10VisualEditor, 6Community-Liaison: Update "Known Problems" page for VE - https://phabricator.wikimedia.org/T94382#1161432 (10Rdicerb) 3NEW a:3Whatamidoing-WMF [07:43:35] 10VisualEditor, 6Community-Liaison: Update "Known Problems" page for VE - https://phabricator.wikimedia.org/T94382#1161441 (10Rdicerb) [07:46:38] (03PS4) 10Alex Monk: Try not to die when RESTbase returns a 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 [08:14:38] 10VisualEditor, 10VisualEditor-Initialisation, 7Browser-Support-Firefox: VisualEditor: Support Firefox 10-14 - https://phabricator.wikimedia.org/T43245#1161468 (10Krenair) Are we still interested in supporting these versions? FF ESR 24.8.0 is EOL now, based on the chart at https://www.mozilla.org/en-US/firef... [08:28:08] 10VisualEditor: Edit tab on translatable pages flashes "Translate" before changing "Edit wikitext". - https://phabricator.wikimedia.org/T94386#1161498 (10Nikerabbit) 3NEW [08:29:45] 10VisualEditor, 10MediaWiki-extensions-Translate: Edit tab on translatable pages flashes "Translate" before changing "Edit wikitext". - https://phabricator.wikimedia.org/T94386#1161506 (10Nikerabbit) [08:32:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Translate: Edit tab on translatable pages flashes "Translate" before changing "Edit wikitext". - https://phabricator.wikimedia.org/T94386#1161508 (10Krenair) [09:13:04] 10VisualEditor, 10VisualEditor-Initialisation, 7Browser-Support-Firefox: VisualEditor: Support Firefox 10-14 - https://phabricator.wikimedia.org/T43245#1161569 (10Aklapper) >>! In T43245#1161468, @Krenair wrote: > Do we know how many people are still using our sites with 10-14? In Dec 2014, [[ https://stats... [09:32:13] prtksxna, ha, no problem, these things happen all the time [09:37:04] edsanders: I left the comment there becauseI knew something I was doing was wrong. [09:37:12] I didn't think it'd be so obvious :P [09:46:28] You can just blame Trevor for merging it [09:57:43] (03CR) 10Esanders: Fix comparison of null RangeStates (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200321 (https://phabricator.wikimedia.org/T94313) (owner: 10Esanders) [10:19:18] 10MediaWiki-Page-editing, 10MediaWiki-Templates: Previewing page with template and then switching to preview template doesn't change title - https://phabricator.wikimedia.org/T94136#1161718 (10Aklapper) p:5Triage>3Low [10:45:55] (03CR) 10Esanders: "Looks good otherwise." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [10:48:48] (03CR) 10Esanders: Unwrap empty spans on paste (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200304 (owner: 10Esanders) [10:51:50] (03CR) 10Esanders: Unwrap empty spans on paste (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200304 (owner: 10Esanders) [11:31:18] (03PS4) 10Esanders: Unwrap empty spans on paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200304 [12:08:24] (03PS1) 10Divec: WIP: Allow cursoring into/out of tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200536 [12:14:10] (03PS2) 10Divec: WIP: Allow cursoring into/out of tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200536 [12:27:53] (03CR) 10Divec: [C: 04-2] "Per Ed: "If you drag a selection across part of the table, and while dragging, you hit delete - that's hard to protect against"." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200536 (owner: 10Divec) [12:36:27] (03PS1) 10Mvolz: Fix I2756d11 to use request instead of http lib [services/citoid] - 10https://gerrit.wikimedia.org/r/200546 [12:36:39] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, and 4 others: S5. Flow: Integrate VE toolbar in Flow entry fields - https://phabricator.wikimedia.org/T90764#1162120 (10Elitre) [12:44:40] (03CR) 10Esanders: [C: 032] "What a piece of garbage" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200486 (owner: 10Catrope) [12:50:57] (03PS1) 10Esanders: Remove line-height override from windows [oojs/ui] - 10https://gerrit.wikimedia.org/r/200552 [12:51:49] (03Merged) 10jenkins-bot: Work around IE link paste bug [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200486 (owner: 10Catrope) [13:11:48] (03CR) 10Mobrovac: [C: 04-1] Fix I2756d11 to use request instead of http lib (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/200546 (owner: 10Mvolz) [13:17:06] (03CR) 10Divec: Fix comparison of null RangeStates (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200321 (https://phabricator.wikimedia.org/T94313) (owner: 10Esanders) [13:27:12] 10VisualEditor-Links: Visual Editor links on new pages are broken (uses /w/ instead of /wiki/) - https://phabricator.wikimedia.org/T94315#1162304 (10Elitre) (Reminds me of https://phabricator.wikimedia.org/T85622 .) [13:33:04] (03CR) 10Mvolz: Fix I2756d11 to use request instead of http lib (032 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/200546 (owner: 10Mvolz) [13:33:16] (03PS2) 10Mvolz: Fix I2756d11 to use request instead of http lib [services/citoid] - 10https://gerrit.wikimedia.org/r/200546 [13:41:31] (03PS1) 10Esanders: Update border width transition hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200565 [13:43:34] (03CR) 10Mobrovac: [C: 032] Fix I2756d11 to use request instead of http lib [services/citoid] - 10https://gerrit.wikimedia.org/r/200546 (owner: 10Mvolz) [13:43:48] (03CR) 10Mobrovac: Fix I2756d11 to use request instead of http lib (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/200546 (owner: 10Mvolz) [14:08:50] 10VisualEditor, 10Continuous-Integration, 7Browser-Tests: Delete or fix failed VisualEditor browsertests Jenkins job - https://phabricator.wikimedia.org/T94162#1162478 (10zeljkofilipin) [14:11:51] (03PS1) 10Physikerwelt: Jenkins tests job [extensions/Math] - 10https://gerrit.wikimedia.org/r/200572 [14:12:18] 10OOjs, 10Continuous-Integration: Publish QUnit coverage on integration.wikimedia.org - https://phabricator.wikimedia.org/T87490#992545 (10hashar) From https://www.mediawiki.org/wiki/Continuous_integration/meetings/2015-03-30/minutes Need a volunteer to craft a post merge job that will generate the coverage a... [14:12:41] (03CR) 10Physikerwelt: [C: 04-2] Jenkins tests job [extensions/Math] - 10https://gerrit.wikimedia.org/r/200572 (owner: 10Physikerwelt) [14:16:33] (03CR) 10jenkins-bot: [V: 04-1] Jenkins tests job [extensions/Math] - 10https://gerrit.wikimedia.org/r/200572 (owner: 10Physikerwelt) [14:19:15] 10Cite: make displaying reference group names optional - https://phabricator.wikimedia.org/T94410#1162558 (10Frog23) 3NEW [14:20:45] (03PS1) 10Esanders: Fix SurfaceWidget and DebugBar hacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200574 [14:20:47] (03PS1) 10Esanders: [BREAKING CHANGE] Fix font sizes and padding in Surface and SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200575 [14:22:44] (03PS2) 10Esanders: [BREAKING CHANGE] Fix font sizes and padding in Surface and SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200575 [14:22:46] (03PS1) 10Esanders: Remove line height reset for windows [oojs/ui] - 10https://gerrit.wikimedia.org/r/200576 [14:25:51] * James_F waves. [14:28:29] (03CR) 10Physikerwelt: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [14:35:04] 10VisualEditor, 7Browser-Tests: add VE tests for all "Insert" items - https://phabricator.wikimedia.org/T65708#680988 (10zeljkofilipin) @ryasmeen, @jdforrester-wmf: is this something you plan to work in in the near future, or can we close this? [14:35:52] * mvolz waves back [14:36:43] (03PS5) 10Ferdbold: Added a simple tooltip when hovering table cells. Depends on Change-Id I784b7f9d56704c16610f61f6d0055c70db46d5b1. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) [14:36:56] 10Citoid, 6Services, 5Patch-For-Review: Google Books translator offering less information than expected - https://phabricator.wikimedia.org/T94169#1162616 (10Mvolz) [14:38:05] 10Citoid, 6Services: Google Books translator offering less information than expected - https://phabricator.wikimedia.org/T94169#1156707 (10Mvolz) [14:42:23] 10Citoid, 6Services: Google Books translator offering less information than expected - https://phabricator.wikimedia.org/T94169#1162626 (10Mvolz) @akosiaris, this change was merged and according to @mobrovac zotero has been restarted, but the change to the translator doesn't seem to have taken effect in produc... [14:43:53] (03CR) 10Jforrester: [C: 031] Move integration tests to a new special page (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [14:47:24] (03CR) 10Physikerwelt: Move integration tests to a new special page (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [14:48:15] (03CR) 10Jforrester: Move integration tests to a new special page (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [15:02:06] (03CR) 10Raimond Spekking: [C: 04-1] "i18n review" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [15:04:01] 10VisualEditor, 10Wikimedia-Site-requests, 5Patch-For-Review, 3Roadmap, and 2 others: Enable VisualEditor by default for all users of all "phase 5" Wikipedias - https://phabricator.wikimedia.org/T93386#1135893 (10Jdforrester-WMF) [15:16:53] James_F: so we have this case where I've been casting "article" open graph types to "blogPost" since those fields overlap the closest [15:17:08] without accidentally calling blogPosts magazines or newspapers or what have you [15:17:20] the problem is casting the blogTitle field [15:17:32] It doesn't work great, though. [15:17:40] E.g. Le Monde is considered a blog. [15:17:45] Which is, umm, a bit rude. ;-) [15:18:10] :D [15:18:37] Hmmmmm. [15:18:43] well anyway... on fr wiki we can call "blogPost" Article [15:18:46] if we want [15:18:51] but we still have the missing field issue [15:19:04] Hmm. [15:19:11] Did you update the Translators? [15:19:15] newspaperArticle is live. [15:19:33] which kind of goes back to the very beginning of how we did TemplateData [15:19:39] Yeah. [15:19:59] I mean, more clearly, lemonde.fr results are now returning newspaperArticle not blogPost. [15:20:47] where? [15:21:16] (hypothetical issues still stands) [15:21:25] and we'll have the same problem on en wiki [15:22:02] which we actually could solve by changing Template:Citation to accept an additional fields called "blogTitle" [15:22:11] but was sort of exactly what we didn't want to do [15:22:19] which was to change the templates ever [15:22:25] in order to set things up [15:24:11] mmm. thinking I should just call those itemType = 'webPage' after all [15:24:38] the zotero type supports most of the metadata we want from that, like author [15:25:32] on the other hand then we have the problem of making citoid behave the way we want because of how en wiki is set up... [15:25:34] arr [15:27:29] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1162749 (10ssastry) a:5ssastry>3Arlolra [15:28:12] 10VisualEditor, 10Parsoid, 3VisualEditor 2014/15 Q3 blockers: Template is replaced with a different template on save - https://phabricator.wikimedia.org/T93739#1144780 (10ssastry) The fix for this will go out today (https://www.mediawiki.org/w/index.php?title=Parsoid/Deployments&oldid=1506017#Monday.2C_Mar_3... [15:33:45] (03PS2) 10Mvolz: Change how pubmed and pmcs are requested [services/citoid] - 10https://gerrit.wikimedia.org/r/200314 (https://phabricator.wikimedia.org/T93335) [15:34:13] (03PS15) 10Physikerwelt: Move integration tests to a new special page [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) [15:34:16] (03PS1) 10Physikerwelt: Add info about failed tests to MathStatus [extensions/Math] - 10https://gerrit.wikimedia.org/r/200589 [15:35:13] (03CR) 10Physikerwelt: "not sure if we really need that" [extensions/Math] - 10https://gerrit.wikimedia.org/r/200589 (owner: 10Physikerwelt) [15:36:00] (03PS3) 10Mvolz: Change how pubmed and pmcs are requested [services/citoid] - 10https://gerrit.wikimedia.org/r/200314 (https://phabricator.wikimedia.org/T93335) [15:38:14] (03CR) 10Raimond Spekking: "i18n review" (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [15:39:19] (03CR) 10Mvolz: "So the original reason to make a request first was because Zotero doesn't actually give us good data about what the response of the origin" [services/citoid] - 10https://gerrit.wikimedia.org/r/200314 (https://phabricator.wikimedia.org/T93335) (owner: 10Mvolz) [15:47:53] (03PS16) 10Physikerwelt: Move integration tests to a new special page [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) [15:48:51] (03CR) 10jenkins-bot: [V: 04-1] Move integration tests to a new special page [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [15:50:40] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [15:51:09] (03CR) 10Physikerwelt: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [15:54:40] James_F: yeah, we updated the translators, looks like https://github.com/zotero/translators/blob/master/Le%20Monde.js got added a few weeks ago [15:54:44] which is nice [15:54:57] mvolz: Aha. [15:55:05] mvolz: But the Google Books one didn't go live? [15:55:15] for some reason it is not working [15:55:24] * James_F sighs. [15:55:31] RoanKattouw_away, what do you see when you click on references 1, 2 or 5: https://en.wikipedia.org/wiki/Opportunity_(rover)?veaction=edit [15:55:40] I pinged the ticket hopefully someone will look into it soon [15:56:03] edsanders: Alienated basic reference? [15:56:07] mvolz: Thanks. [15:58:12] 10VisualEditor, 10Continuous-Integration, 7Browser-Tests: Delete or fix failed VisualEditor browsertests Jenkins job - https://phabricator.wikimedia.org/T94162#1162893 (10hashar) Isn't @Ryasmeen monitoring the failure together with the VE developers team? [15:58:51] James_F: re: https://phabricator.wikimedia.org/T93800, I'm unable to replicate [15:59:15] not sure where to go from there to make progress on the ticket [15:59:23] Completely empty basic reference [16:07:59] (03PS5) 10Esanders: Fix comparison of null RangeStates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200321 (https://phabricator.wikimedia.org/T94313) [16:13:36] (03CR) 10Esanders: [C: 031] Move integration tests to a new special page [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [16:18:09] 10VisualEditor, 6Mobile-Web: None of the toolbar buttons work when editing using VE in mobile view - https://phabricator.wikimedia.org/T94425#1162977 (10Glaisher) 3NEW [16:21:10] 10VisualEditor, 6Mobile-Web: None of the toolbar buttons work when editing using VE in mobile view - https://phabricator.wikimedia.org/T94425#1162987 (10Glaisher) Hm, the bold/italic button does work but the icons are not visible. However, I don't see any effect when the link button is pressed (which does have... [16:25:36] (03CR) 10Bartosz Dziewoński: [C: 032] Update border width transition hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200565 (owner: 10Esanders) [16:29:00] (03Merged) 10jenkins-bot: Update border width transition hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200565 (owner: 10Esanders) [16:31:55] (03CR) 10Raimond Spekking: "No problem, Alex. I had to stop sync with translatewiki.net for one day to avoid waste of translators time. In general move of messages fr" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/200249 (https://phabricator.wikimedia.org/T91608) (owner: 10Alex Monk) [16:34:06] (03CR) 10Jforrester: [C: 032] Escape messages [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184300 (owner: 10Gerrit Patch Uploader) [16:34:55] (03PS1) 10Kmenger: OutlineOption: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/200597 [16:35:03] 10VisualEditor, 10Wikimedia-Site-requests, 3Roadmap, 7notice, 7user-notice: Enable VisualEditor by default for all users of all "phase 5" Wikipedias - https://phabricator.wikimedia.org/T93386#1163052 (10Ricordisamoa) [16:35:30] 10VisualEditor, 10VisualEditor-MediaWiki, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24): Category popup is vertically misaligned - https://phabricator.wikimedia.org/T94114#1163056 (10Etonkovidova) Verified the fix in beta. [16:35:39] (03CR) 10Jforrester: [C: 04-2] "Where is the RFC where it was agreed that we would add composer support for installing extensions, which breaks other usages? https://phab" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/200305 (https://phabricator.wikimedia.org/T93616) (owner: 10MarkAHershberger) [16:40:11] (03Merged) 10jenkins-bot: Escape messages [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184300 (owner: 10Gerrit Patch Uploader) [16:45:47] 10VisualEditor-Links: Visual Editor links on new pages are broken (uses /w/ instead of /wiki/) - https://phabricator.wikimedia.org/T94315#1163099 (10He7d3r) [16:45:56] 10VisualEditor-Links: Visual Editor links on new pages are broken (uses /w/ instead of /wiki/) - https://phabricator.wikimedia.org/T94315#1159577 (10He7d3r) [16:52:02] (03PS1) 10Physikerwelt: Improve layout of Special:MathStatus [extensions/Math] - 10https://gerrit.wikimedia.org/r/200604 [16:53:24] 10MediaWiki-Page-editing: Prevent double submitting - https://phabricator.wikimedia.org/T94429#1163147 (10Subfader) 3NEW [16:55:54] 10VisualEditor, 10MediaWiki-General-or-Unknown, 6Mobile-Web, 7Mobile: The menu items are triggered when the click goes away then is released - https://phabricator.wikimedia.org/T93522#1163160 (10Jdlrobson) [16:57:02] (03CR) 10MarkAHershberger: "I don't know what you mean by "breaks other usages". Could you clarify or point to a place where this is explained? AFAIK, adding suppor" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/200305 (https://phabricator.wikimedia.org/T93616) (owner: 10MarkAHershberger) [17:02:39] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, and 4 others: S5. Flow: Integrate VE toolbar in Flow entry fields - https://phabricator.wikimedia.org/T90764#1163197 (10DannyH) On Beta right now, I'm seeing an older version -- buttons above the field, and no switch ico... [17:07:12] I really like the new progression bar when VisualEditor loads. [17:12:45] (03PS2) 10Physikerwelt: Improve layout of Special:MathStatus [extensions/Math] - 10https://gerrit.wikimedia.org/r/200604 (https://phabricator.wikimedia.org/T94434) [17:12:58] (03PS2) 10Physikerwelt: Add info about failed tests to MathStatus [extensions/Math] - 10https://gerrit.wikimedia.org/r/200589 [17:13:09] (03PS3) 10Physikerwelt: Add info about failed tests to MathStatus [extensions/Math] - 10https://gerrit.wikimedia.org/r/200589 (https://phabricator.wikimedia.org/T94434) [17:15:12] (03CR) 10Mobrovac: [C: 04-1] "Much better now. Since we use zotero because we find it likely to scrape the resource, it makes a lot of sense to call it first and then f" (034 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/200314 (https://phabricator.wikimedia.org/T93335) (owner: 10Mvolz) [17:18:18] 10WikiEditor, 7JavaScript: WikiEditor: Toolbar should insert tags in edit summary input (if focussed) - https://phabricator.wikimedia.org/T39084#1163300 (10He7d3r) [17:18:49] 10WikiEditor, 7JavaScript: WikiEditor: Toolbar should insert tags in edit summary input (if focussed) - https://phabricator.wikimedia.org/T39084#405490 (10He7d3r) This was requested again on [[https://www.mediawiki.org/wiki/Extension_talk:WikiEditor/Toolbar_customization#A_disturbing_difference_between_encapsu... [17:19:06] 10WikiEditor, 7JavaScript: WikiEditor: Toolbar should insert tags in edit summary input (if focussed) - https://phabricator.wikimedia.org/T39084#1163307 (10He7d3r) [17:19:42] guillom: Thanks. :-) [17:19:44] guillom: (edsanders and TrevorP|Away's work.) [17:31:09] (03PS4) 10Gerrit Patch Uploader: Use background-image instead of for spinner [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 [17:31:12] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [17:32:27] (03CR) 10Fomafix: "PS4 integrates local variable like in https://gerrit.wikimedia.org/r/184300" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [17:34:56] (03PS6) 10Mooeypoo: Added a simple tooltip when hovering table cells. Depends on Change-Id I784b7f9d56704c16610f61f6d0055c70db46d5b1. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [17:37:26] (03CR) 10Catrope: [C: 032] Try not to die when RESTbase returns a 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 (owner: 10Alex Monk) [17:37:53] (03PS7) 10Mooeypoo: Add a simple tooltip when hovering on table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [17:38:29] 10OOjs-UI, 10UI-Standardization, 7Design: Regression on Checkboxes and radio buttons - https://phabricator.wikimedia.org/T93944#1163398 (10matmarex) This was intentional per fc6ef37c9f8843ecc95aa80809141b40b18a4dee / T86003. [17:38:48] (03PS1) 10Jforrester: Update VE core submodule to master (5822d2f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200617 [17:39:05] (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (5822d2f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200617 (owner: 10Jforrester) [17:39:10] (03CR) 10Catrope: [C: 032] Unwrap empty spans on paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200304 (owner: 10Esanders) [17:39:49] (03PS5) 10Catrope: Unwrap empty spans on paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200304 (owner: 10Esanders) [17:40:04] (03CR) 10Mooeypoo: [C: 032] "WFM and looks good" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [17:40:14] (03Merged) 10jenkins-bot: Try not to die when RESTbase returns a 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200507 (owner: 10Alex Monk) [17:42:18] edsanders: I see a reference with alien effects, and when I click it there's a context item that previews it as a basic reference with nothing but a slug [17:43:10] RoanKattouw, yeah [17:43:26] is that correct? [17:43:29] But why is the mouse over effect there? [17:43:34] I'm trying to see how [1] and [3] differ [17:43:37] Their DOM looks the same [17:44:01] Why does [1] have a forbidden cursor [17:45:08] (03Merged) 10jenkins-bot: Update VE core submodule to master (5822d2f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200617 (owner: 10Jforrester) [17:45:11] Hmm seems to be related to focusable/draggable [17:45:12] (03Merged) 10jenkins-bot: Add a simple tooltip when hovering on table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200177 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [17:45:41] oooh it comes from .ve-ce-mwReferenceNode-missingref [17:46:06] Which is applied to the highlights rather than the ref itself [17:46:22] And not just that, it's applied to the highlights *container* rather than the highlight itself, WTF [17:46:34] OK, so [17:46:57] 1) The new context item code doesn't handle missingRef well, 2) I'll figure out why those refs get missingRef [17:47:36] Oh I see, they're defined in the reflist template [17:48:44] 10OOjs-UI, 10UI-Standardization, 7Design: Regression on Checkboxes and radio buttons - https://phabricator.wikimedia.org/T93944#1163436 (10Jaredzimmerman-WMF) This needs to be reverted, after this change form elements no longer align. [17:51:13] (03PS5) 10Mooeypoo: Update VE core submodule to master (2c27ba9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200319 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [17:51:48] (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (2c27ba9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200319 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [17:51:59] (03CR) 10Catrope: [C: 032] Unwrap empty spans on paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200304 (owner: 10Esanders) [17:52:37] 10VisualEditor, 10VisualEditor-Tables, 5WMF-deploy-2015-04-01_(1.25wmf24): Please add a tooltip that tells users to double-click if they want to edit table cells - https://phabricator.wikimedia.org/T93908#1163462 (10Mooeypoo) 5Open>3Resolved [17:54:05] RoanKattouw: Yeah. :-( [17:54:31] mooeypoo: hello, in the patchset https://gerrit.wikimedia.org/r/#/c/199959/1/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js , this.setIcon( 'template' ) , how is the icon set if you could explain a bit , thanks [17:54:31] (03Merged) 10jenkins-bot: Update VE core submodule to master (2c27ba9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200319 (https://phabricator.wikimedia.org/T93908) (owner: 10Ferdbold) [17:54:48] hi rits [17:55:21] mooeypoo: hello :) , i think i am getting a bit slow to submit my microtask [17:55:42] (03Merged) 10jenkins-bot: Unwrap empty spans on paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200304 (owner: 10Esanders) [17:55:53] so, if you look at OO.ui.IconElement#setIcon, you'll see that really what we do is adjust a CSS class [17:55:57] the css classes define the icons [17:56:17] in the case of the template change, we wanted to show the template icon (which is the puzzle piece) [17:56:33] mooeypoo: ok [17:57:29] edsanders: So what's happening with cursorable slugs? Are we going with the cursorHolder approach? [17:57:34] mooeypoo: so that icon is basically thorugh the css and i have to define a icon for the alien extension node, am i right [17:58:08] I think that's for tables and focusables [17:58:23] David has a WIP for cursorable slugs [17:58:36] rits, alien extension nodes already have an icon set up [17:58:44] let me see which ones we use [17:59:00] rits, the inspector should have an icon set up, hang on, let me check which one it is [17:59:14] mooeypoo: ok [18:00:02] rits, if you go to ve.ui.MWAlienExtensionInspector you'll see that it has an icon defined in the static variables. You should use that icon name in the code you're writing, so it's consistent [18:00:17] Oh right [18:00:19] What's WIP about it? [18:00:23] rits, so you don't need to create icons or anything, just use that string for the icon you need [18:00:30] 10OOjs-UI, 6Collaboration-Team, 10Flow: Selection of contents of some text areas (e.g. Flow headers) requires two clicks - https://phabricator.wikimedia.org/T94364#1163495 (10EBernhardson) Which browser and OS is this occuring in? [18:00:32] rits, which in this case is "alienextension" [18:00:58] mooeypoo: great, ok i will use that, thank you [18:01:46] rits, no problems [18:01:52] (03CR) 10Mooeypoo: "I do see your point, I'm just worried that it might confuse the user if they see two different (even if slightly) things? In the case of r" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200085 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [18:02:28] divec: yo [18:02:29] around? [18:02:46] or anybody... mooeypoo , edsanders [18:02:50] mooeypoo : for validation of json in the graph editing i used a concept i have written in this https://phabricator.wikimedia.org/T93788 , it would be great if you see that am i wrong writing in this, thanks [18:02:55] sup aharoni ? [18:02:55] aharoni: ? [18:03:04] is Indic typing supposed to be working in VE now, or it still WIP? [18:03:20] (03PS1) 10Kmenger: ActionFieldLayout: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/200626 [18:03:22] I think it's supposed to work now? [18:03:40] aharoni: You mean IMEs or actual native Indic keyboards? David's sent a bunch of e-mails asking for IME testing support… :-) [18:03:42] rits, hm, you mean jsonlint? it will be messy to add that to the front end [18:03:59] yo vikasyaligar [18:04:07] which problem did you have with Kannad? [18:04:11] Kannada typing? [18:04:20] Hello aharoni! [18:04:28] rits, also, in general, VisualEditor should shy away from letting users edit raw json strings. We will have that option in the beginning because that's the most doable and convenient way, but eventually, the idea is to move to a visual dialog/editor for the settings of each graph [18:04:37] aharoni: There's a reason why VisualEditor isn't on by default in IME languages. [18:04:54] aharoni: Yup ! I don't know how do I type in kannada? How do I make use of kannada keyboard ? [18:05:02] rits, but Vega also has its own validation. We could try and see if it's possible to link vega's validator. [18:05:09] mooeypoo: yes i meant that, ok then if the user edits there some validation has to be done how will be that done [18:05:45] (03PS1) 10Esanders: Add check to see if GCN contents are visibile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200627 [18:05:59] rits, that's a good question. We'll have to do some validation; first ,we'll have to do the basic javascript validation, just to make sure the json is valid at all and doesn't crash anything. On top of that, I think we might have to use Vega's json validation [18:06:37] which might be a bit complicated, but considering the fact that we should shy away from json in general, we might just want to stick to basic validation -- is it valid json or not -- without letting the user know why it is or isn't [18:06:39] aharoni: We can select kannada keyboard in translatewiki, but I don't know how I can do it for VisualEditor ? [18:06:41] mooeypoo: ok for a start it will be used, ok i ddnt knew about the vega json validation that would be great [18:07:07] rits, you should take a look at the main task comments and the comments in the other proposal too -- there were a couple of issues raised there that might interest you [18:07:39] (03PS1) 10Esanders: Use new isVisible method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200628 [18:07:52] mooeypoo: that was the main question in my mind and after working on that i just work on the jsonlint concept but if there is JSON validation vega it would be best of all [18:08:07] I tried to keep the discussion in the main task, but some spilled over to another proposal -- just go over them in general so you can see where yurik and I stand more or less about the plans [18:08:33] (03CR) 10Catrope: [C: 032] Add check to see if GCN contents are visibile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200627 (owner: 10Esanders) [18:08:40] rits, json validation should be first, but we won't be able to implement a full blown linter in there. [18:08:47] (03CR) 10Catrope: [C: 031] Use new isVisible method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200628 (owner: 10Esanders) [18:08:51] mooeypoo: ok i will go through all of them, [18:09:45] mooeypoo: ok is it because visual editor couldnt be deployed with it [18:10:23] (03CR) 10jenkins-bot: [V: 04-1] Add check to see if GCN contents are visibile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200627 (owner: 10Esanders) [18:10:24] mooeypoo: i will go through the vega validation also [18:10:54] (03CR) 10Esanders: "I've upstreamed the visibility check, see I5a7985b7a2." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [18:11:03] rits, yeah take a look at what it says in the graph extension and in the scripts, it might have a good way to do it [18:11:16] rits, also, read the comments in ferdbold's proposal -- Yurik and I discussed the validation bit [18:11:18] (03PS2) 10Catrope: Add check to see if GCN contents are visible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200627 (owner: 10Esanders) [18:11:36] (03CR) 10Catrope: [C: 032] Add check to see if GCN contents are visible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200627 (owner: 10Esanders) [18:11:50] mooeypoo: ok i will thanks you :) [18:12:05] sure thing :) [18:12:52] :) [18:15:00] (03CR) 10Jforrester: [C: 032] Move integration tests to a new special page [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [18:15:48] (03CR) 10jenkins-bot: [V: 04-1] Add check to see if GCN contents are visible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200627 (owner: 10Esanders) [18:16:23] Krinkle: So… [18:17:03] (03CR) 10Catrope: [C: 032] "Come on Jenkins" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200627 (owner: 10Esanders) [18:17:33] Krinkle: (a) where's the patch and (b) are you OK to post the changes to enwiki? [18:17:46] edsanders: Uhm, so pasting of list items into list items is pretty broken [18:17:53] vikasyaligar: it's best if you enable a Kannada in your operating system [18:17:59] (03Merged) 10jenkins-bot: Move integration tests to a new special page [extensions/Math] - 10https://gerrit.wikimedia.org/r/186581 (https://phabricator.wikimedia.org/T87389) (owner: 10Physikerwelt) [18:18:02] edsanders: It creates a sublist and then leaves content behind after the sublist, which is not representable in wikitext [18:18:21] Modern versions of Mac, Windows and GNU/Linux desktops all have native Kannada keyboards. [18:19:11] Just find the keyboard preferences on your OS... in Windows it's in the Control Panel, [18:19:16] in Mac... I don't know :) [18:19:18] (03CR) 10Esanders: "This needs to be fixed or reverted. Multi-line text inputs (which are