[17:07:39] (03PS1) 10Aaron Schulz: Use ResourceLoaderModule::safeFilemtime instead of using filemtime directly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200885 [17:08:27] (03PS2) 10Ori.livneh: Use ResourceLoaderModule::safeFilemtime instead of using filemtime directly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200885 (owner: 10Aaron Schulz) [17:08:37] (03CR) 10Ori.livneh: [C: 032] Use ResourceLoaderModule::safeFilemtime instead of using filemtime directly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200885 (owner: 10Aaron Schulz) [17:12:18] (03Merged) 10jenkins-bot: Use ResourceLoaderModule::safeFilemtime instead of using filemtime directly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200885 (owner: 10Aaron Schulz) [17:13:29] Did the PHP interface for OOUI get created already? [17:13:39] If so, can has docs? [17:13:54] Ooh. https://www.mediawiki.org/wiki/OOjs_UI/PHP_Examples [17:21:53] marktraceur: there's a bug to have doxygen docs generated [17:22:24] edsanders: could you take https://phabricator.wikimedia.org/T91245 ? [17:23:48] the patch seems to work in the browser, but the tests are failing, which leads me to believe the wrong call to setupSlugs is being suppressed [17:23:53] hmph, https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/ is down. [17:23:54] and, this seems like your area [17:23:56] (03CR) 10Catrope: "I'm not sure it can even happen in practice, because fixBase() should resolve it to something valid. This was mostly speculation on my par" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200808 (https://phabricator.wikimedia.org/T94315) (owner: 10Catrope) [17:24:53] (03CR) 10Catrope: [C: 032] Make afterPaste operations optional again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200851 (owner: 10Esanders) [17:25:10] MatmaRex: That'd be super. For now I'll just dig through code I guess [17:25:23] (03PS1) 10Bartosz Dziewoński: build: Simplify 'fileExists' task configuration [oojs/ui] - 10https://gerrit.wikimedia.org/r/200892 [17:25:50] marktraceur: example usages include the PHP demo and some code in Collection ext cscott wrote [17:26:35] (and https://gerrit.wikimedia.org/r/185591 which is currently blocked on a bunch of stuff, but mostly works) [17:26:55] MatmaRex: Am I reading correctly that there are no dialogs in PHP yet? [17:27:03] (03CR) 10Divec: "I believe this is working, *but*:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200337 (https://phabricator.wikimedia.org/T89352) (owner: 10Divec) [17:27:06] there aren't and probably won't be [17:27:09] Aw. [17:27:24] I guess I could make it a FormLayout and add a dialog in JS. [17:27:24] you can use a PanelLayout if you want a nice frame around your form. [17:27:48] (with framed: true) [17:28:02] 'framed'=>true, rather ;) [17:29:34] marktraceur: i wonder, how would you expect dialogs to work in PHP? [17:30:01] i guess it would have to be a full-page transition whenever you do something…? [17:30:24] MatmaRex: Not really sure. I guess I'd expect them to be like PanelLayout but converted into dialogs if JS is enabled, shrug, but I can just do that on my own [17:36:23] TrevorParscal: seen an encoding issue like this: https://freephile.org/wiki/load.php?debug=false&lang=en&modules=site&only=scripts&skin=vector&* [17:36:27] before with RL ? [17:37:00] that's quite interesting [17:37:17] yeah it is. [17:38:10] (03CR) 10Jforrester: [C: 032] build: Simplify 'fileExists' task configuration [oojs/ui] - 10https://gerrit.wikimedia.org/r/200892 (owner: 10Bartosz Dziewoński) [17:38:22] (03CR) 10Jforrester: [C: 032] build: Have separate 'cssjanus' target for demo.rtl.css [oojs/ui] - 10https://gerrit.wikimedia.org/r/200880 (owner: 10Bartosz Dziewoński) [17:38:29] (03Merged) 10jenkins-bot: Make afterPaste operations optional again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200851 (owner: 10Esanders) [17:38:38] (03CR) 10Jforrester: [C: 032] build: Add a 'generated automatically' banner to demo.rtl.css [oojs/ui] - 10https://gerrit.wikimedia.org/r/200879 (owner: 10Bartosz Dziewoński) [17:38:52] thedj: That's gzipped data but it seems like the Content-Encoding header was lost [17:39:11] ah that can be [17:40:32] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (7bc93e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200800 (owner: 10Jforrester) [17:40:51] (03CR) 10Catrope: [C: 032] i18n: Re-sort alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200866 (owner: 10Jforrester) [17:41:05] RoanKattouw: interestingly enough, it does add it for https://freephile.org/wiki/load.php?debug=false&lang=en&modules=ext.categoryTree.css%7Cext.visualEditor.viewPageTarget.noscript%7Cmediawiki.legacy.commonPrint%2Cshared%7Cmediawiki.ui.button%7Cskins.common.interface%7Cskins.vector.styles&only=styles&skin=vector&* [17:42:52] (03Merged) 10jenkins-bot: build: Add a 'generated automatically' banner to demo.rtl.css [oojs/ui] - 10https://gerrit.wikimedia.org/r/200879 (owner: 10Bartosz Dziewoński) [17:42:54] (03Merged) 10jenkins-bot: build: Have separate 'cssjanus' target for demo.rtl.css [oojs/ui] - 10https://gerrit.wikimedia.org/r/200880 (owner: 10Bartosz Dziewoński) [17:42:56] (03Merged) 10jenkins-bot: build: Simplify 'fileExists' task configuration [oojs/ui] - 10https://gerrit.wikimedia.org/r/200892 (owner: 10Bartosz Dziewoński) [17:44:48] (03Merged) 10jenkins-bot: Update VE core submodule to master (7bc93e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200800 (owner: 10Jforrester) [17:44:50] (03Merged) 10jenkins-bot: i18n: Re-sort alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200866 (owner: 10Jforrester) [17:50:30] mooeypoo: hello, i am not able to complete my microtask yet, not able to understand the code flow, as for now as a basic start could you assign some other microstask to me, thanks [17:56:00] (03CR) 10Trevor Parscal: [C: 032] Fix choose event listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200132 (owner: 10Esanders) [17:56:02] (03CR) 10Manybubbles: "I'm neutral to +1 on it. We'll have issues with the snippets being cut off but if we can live with that then so be it. I'm spinning it u" (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [18:05:00] mooeypoo: ^ , please if you could assign , thank you [18:05:28] rits, we can go over the code flow if you want, instead? [18:05:37] I'm not sure if I have a good microtask alternative [18:05:53] I know the code comments may have been a little intimidating, but look just at the last one. [18:06:12] mooeypoo: ok it would be good for me :) [18:06:16] See Ed's comment with a link to another fix? You should follow that [18:06:50] rits, so your strategy was good, because you followed our previous strategy -- the problem is that then we saw that our previous strategy wasn't good, and we changed it [18:07:35] yes , i am following that but i am using a graph to work on the alien nodes but it is not showing up as the code i do [18:08:19] mooeypoo: yes i followed each and every comment of the previous one and the Edsanders follow up [18:08:20] rits, yeah, the graph will appear completely invisible [18:08:24] (03Merged) 10jenkins-bot: Fix choose event listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200132 (owner: 10Esanders) [18:08:41] TrevorParscal, I'll take a look [18:09:05] rits, your new fix should detach the icon on ve.ce.MWAlienExtensionNode#render and reattach it on ve.ce.MWAlienExtensionNode#onSetup [18:09:44] mooeypoo: yeah it is getting invisible but after the changes it should display a icon, am i right [18:09:51] yes [18:09:59] rits, where did you attach the icon ? [18:10:06] what code are you looking at? [18:10:18] TrevorParscal: https://gerrit.wikimedia.org/r/200808 https://gerrit.wikimedia.org/r/200809 and then after pull-through https://gerrit.wikimedia.org/r/200811 [18:10:38] https://gerrit.wikimedia.org/r/200807 would also be nice [18:10:42] mooeypoo: i tried to follow up the Transclusion node [18:10:53] rits, yeah but which code are you changing? [18:10:55] as was done for templates [18:11:02] good [18:11:40] rits, did you see this? https://gerrit.wikimedia.org/r/#/c/200628/2 [18:12:14] i attached a icon on the setup [18:12:29] rits, you can look at ve.ce.MWTransclusionNode in your local files [18:12:31] mooeypoo: i used the upstreamed concept in the code [18:13:06] rits, i'll need to look at the code you wrote to see why it migth not work. Can you submit the new patchset? [18:13:45] mooeypoo: ok i will submit it in a few minutes, the code is not clean yet, sorry for the late [18:15:41] rits, okay, i'll be able to help more if I see it [18:16:30] mooeypoo: yes, i will submit the patchset just a few minutes [18:18:38] MatmaRex: D'you know off the top of your head how to stick HTML into a PanelLayout? [18:18:49] I tried adding it to 'content' in the config array to no effect. [18:18:56] (03CR) 10Aaron Schulz: "Seems to work fine, but this will delay "review my changes" from loading while parsing. For huge pages, this will be annoying." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200260 (https://phabricator.wikimedia.org/T90040) (owner: 10Aaron Schulz) [18:19:12] I really don't want to turn this into "Mark changes HTMLForm to use OOUI" [18:19:21] Because that doesn't sound fun at all [18:19:28] marktraceur: ->appendContent( new OOUI\HtmlSnippet( $html ) ) [18:19:44] marktraceur: or 'content' => new OOUI\HtmlSnippet( $html ) should also work [18:19:49] Aha. [18:20:01] (03PS2) 10Aaron Schulz: Stash edits alongside the html -> wikitext stashing step [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200260 (https://phabricator.wikimedia.org/T90040) [18:21:15] MatmaRex: Herp PanelLayout https://lut.im/m5n7qLq3/NOclcbVi [18:21:34] Oh, position: absolute. [18:21:38] Well that's unnecessary [18:21:54] FormLayout is more better. [18:22:04] yes. i think we have a bug about that [18:22:09] and if we don't, we should [18:23:28] marktraceur: want to file one? [18:28:56] MatmaRex: It sort of makes sense I guess? I get the impression that a PanelLayout is special somehow [18:30:43] marktraceur: it is this way for several layouts (most of which are not in PHP version) because they were written to be used inside dialogs only [18:31:01] and dialogs always have defined width and height and position:absolute [18:31:29] marktraceur: ooh, you can set 'expanded'=>false to disable this. [18:38:42] Hi, as mentioned in https://gerrit.wikimedia.org/r/200337/ , I think cursorable block slugs are working, with some provisos [18:38:52] Hey divec_. [18:38:58] edsanders: ^^^ [18:41:24] Mainly, that native cursoring skips over ce=false nodes. This is not actually a problem with cursorable block slugs, but it is an odd effect that happens in many/most of the situations where they arise. [18:43:01] mooeypoo is going to do some more bidi testing (she hasn't found problems yet) [18:43:57] yup [18:44:00] so far so good [18:44:03] so, what is the unexpected effect from the user's perspective? [18:46:09] (03CR) 10Catrope: [C: 032] Stash edits alongside the html -> wikitext stashing step [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200260 (https://phabricator.wikimedia.org/T90040) (owner: 10Aaron Schulz) [18:46:52] TrevorParscal: If you have, say, ...foo|... then pressing up arrow will jump the alien (and select the block slug), but a subsequent down arrow press will select the block alien [18:47:25] (Because aliens get skipped over if the cursoring is native, but not if the cursoring is emulated) [18:47:51] This problem happens in Chromium, but not Firefox [18:48:08] (03PS1) 10Mooeypoo: Insert inline transclusion instead of block [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/200916 [18:49:42] (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/200918 [18:49:46] divec_: I think that's something we can accept for the time being - do you have any ideas how we can resolve this better in the future? [18:51:34] (03CR) 10Trevor Parscal: [C: 031] Make block slugs cursorable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200337 (https://phabricator.wikimedia.org/T89352) (owner: 10Divec) [18:52:29] TrevorParscal: I'm working on a patch at the moment, resurrecting an old trick. On cursor keydown, it inserts a ce=true div next to any ce=false blocknode that is sufficiently close to the cursor to be a potential cursoring target [18:52:41] (03Merged) 10jenkins-bot: Stash edits alongside the html -> wikitext stashing step [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200260 (https://phabricator.wikimedia.org/T90040) (owner: 10Aaron Schulz) [18:52:47] nice, stashing ! [18:53:02] divec_: cool, thanks for the quick turn around of this patch [18:53:35] "Sufficiently close" means "adjacent in the DM" (but it can mean adjacent in either direction, as we don't necessarily know the bidi cursor direction) [18:53:38] thedj: Hopefully even faster. :-) [18:55:30] TrevorParscal: No problem ... unless of course ... [18:55:32] mooeypoo finds otherwise [18:56:18] mooeypoo: i am sorry the updating to master is getting failed again and again i will submit it in a few minutes, if you could see the code meanwhile http://pastebin.com/wssKrLL5 ,its the MWAlienExtensionNode.js file [18:57:10] James_F: Can you move https://phabricator.wikimedia.org/T94599 to dependencies [18:57:11] ? [18:57:43] RoanKattouw: {{done}} [18:58:05] rits, what don you mean it is failed again and again? [18:58:57] mooeypoo: its coming fatal, broken pipe, my net connection is slow i think because of that [18:59:05] rits, one thing I see immediately -- the icon should be lowercase ('alienextension') not alienExtension. See if that fixes it. [18:59:08] oh [18:59:10] hm [18:59:25] mooeypoo: oh ok [18:59:32] ok from a very cursory glance your code should look okay, you're following ed's fix, which is fine [18:59:36] the icon should be lower case [18:59:39] see if that works? [18:59:59] mooeypoo: ok just a second [19:01:21] mooeypoo: its doesn't worked [19:01:54] James_F: Do you know if the current VE icons are on Commons? I'm looking for the production "reference" icon and this set doesn't seem to include it: https://commons.wikimedia.org/wiki/Category:VisualEditor_icons [19:03:04] guillom: Probably not. [19:03:15] rits, when you inspect the alien extension node in CE, do you see the icon span with classes on it? [19:03:15] mooeypoo: ^ [19:03:40] guillom: They aren't mastered in Commons, they're mastered in git. De-duping and uploading them takes hours. [19:03:47] guillom: I did it once but not since. [19:03:58] mooeypoo, no [19:04:16] rits, no icon span at all inside the node ? [19:04:23] oh [19:04:47] rits, yeah, you're calling OO.ui.IconElement.call( this, config ) from the constructor, but you forgot to add it as a mixin :) [19:05:13] James_F, http://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Visualeditor-special-characters-group-other shows now [19:05:17] mooeypoo: ohhh, i am sorry i will fix it [19:05:22] Krenair: Yay. Thanks. [19:05:39] mooeypoo: thanks :) [19:05:45] rits, no problems, it happens! :) [19:10:24] mooeypoo: in the inspector its coming the same as before as the focusable node class was assigned 0px height and width and that the extension doesnt shows up with the icon [19:11:00] rits, now when you inspect the alien extension node's html do you have an icon [19:11:09] should be a span with icon classes on it [19:12:06] no its not there the classes showing up are class="ve-ce-focusableNode ve-ce-leafNode" contenteditable="false" these [19:12:47] mooeypoo: they were there before also, icon is not showing up [19:13:18] James_F: https://phabricator.wikimedia.org/T94590 [19:13:30] rits, inside that div, no other spans? [19:14:09] mooeypoo: no [19:14:10] rits, can you try to get your code into gerrit? it's really hard for me to help otherwise without seeing what you're working on and testing it [19:14:49] mooeypoo: oh ok i will, [19:15:40] mooeypoo: ah my net connection, i will just submit the patch to gerrit, thank you :) [19:16:01] rits, great, I'll bve able to pull it and see what is going wrong a lot better [19:16:23] mooeypoo: ok :) [19:16:59] heya mvolz [19:17:09] (03CR) 10Trevor Parscal: [C: 032] Fake if missing or invalid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200808 (https://phabricator.wikimedia.org/T94315) (owner: 10Catrope) [19:18:02] (03CR) 10Trevor Parscal: [C: 032] Add utilities to work around decodeURIComponent() exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200809 (owner: 10Catrope) [19:19:18] (03CR) 10Trevor Parscal: [C: 031] Use ve.safeDecodeURIComponent() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200811 (owner: 10Catrope) [19:19:39] (03CR) 10Trevor Parscal: [C: 032] MWInternalLinkAnnotation: Remove useless .toString() call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200807 (owner: 10Catrope) [19:20:28] edsanders: did you see that I assigned this to you: https://phabricator.wikimedia.org/T91245 ? [19:20:53] (03Merged) 10jenkins-bot: Fake if missing or invalid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200808 (https://phabricator.wikimedia.org/T94315) (owner: 10Catrope) [19:21:02] (03Merged) 10jenkins-bot: Add utilities to work around decodeURIComponent() exceptions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200809 (owner: 10Catrope) [19:22:07] (03CR) 10Catrope: [C: 04-1] Make block slugs cursorable (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200337 (https://phabricator.wikimedia.org/T89352) (owner: 10Divec) [19:23:18] (03Merged) 10jenkins-bot: MWInternalLinkAnnotation: Remove useless .toString() call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200807 (owner: 10Catrope) [19:24:28] (03PS1) 10Jforrester: Update VE core submodule to master (1d92641) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200933 [19:27:51] (03PS9) 10Catrope: Make block slugs cursorable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200337 (https://phabricator.wikimedia.org/T89352) (owner: 10Divec) [19:27:56] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (1d92641) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200933 (owner: 10Jforrester) [19:28:21] (03CR) 10Catrope: [C: 032] Make block slugs cursorable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200337 (https://phabricator.wikimedia.org/T89352) (owner: 10Divec) [19:28:39] (03PS4) 10Rits: Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) [19:28:45] (03CR) 10jenkins-bot: [V: 04-1] Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [19:31:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (1d92641) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200933 (owner: 10Jforrester) [19:31:27] (03Merged) 10jenkins-bot: Make block slugs cursorable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200337 (https://phabricator.wikimedia.org/T89352) (owner: 10Divec) [19:33:32] (03CR) 10Physikerwelt: Render math tags in search results (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [19:35:30] (03CR) 10Catrope: [C: 032] build: Generate prettier task names for 'colorizeSvg' [oojs/ui] - 10https://gerrit.wikimedia.org/r/200849 (owner: 10Bartosz Dziewoński) [19:37:31] (03Merged) 10jenkins-bot: i18n: Remove duplicate message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200865 (owner: 10Jforrester) [19:38:05] (03PS1) 10Jforrester: Update VE core submodule to master (248fc5d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200942 [19:38:08] (03Merged) 10jenkins-bot: build: Generate prettier task names for 'colorizeSvg' [oojs/ui] - 10https://gerrit.wikimedia.org/r/200849 (owner: 10Bartosz Dziewoński) [19:38:23] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (248fc5d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200942 (owner: 10Jforrester) [19:40:27] (03Merged) 10jenkins-bot: Update VE core submodule to master (248fc5d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200942 (owner: 10Jforrester) [19:40:58] (03PS1) 10Rits: MWAlienExtensionNode.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 [19:41:15] (03CR) 10jenkins-bot: [V: 04-1] MWAlienExtensionNode.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (owner: 10Rits) [19:50:03] (03PS2) 10Rits: MWAlienExtensionNode.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 [19:50:23] (03CR) 10jenkins-bot: [V: 04-1] MWAlienExtensionNode.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (owner: 10Rits) [19:52:15] mooeypoo: https://gerrit.wikimedia.org/r/#/c/200945/ [19:56:56] mooeypoo: ^ [19:57:47] Hi rits. :) [19:58:04] If you look at that PS, you'll see that jenkins failed it. [19:59:31] Niharika: hello, yes but i wanted to show the initial code thats why i pinged her, i will try to fix it up then send the PR thank you [19:59:44] rits: Oh, no worries then. :) [20:00:00] Niharika: :) [20:05:27] (03CR) 10Manybubbles: "Ok! I still haven't had a chance to run it locally but I'm almost there! Darn meetings." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:23:43] (03PS1) 10Krinkle: Don't force ext.wikiEditor.init in a separate cache group [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/201004 [20:24:06] (03PS2) 10Krinkle: Don't force a separate http request for ext.wikiEditor.init [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/201004 [20:29:16] (03CR) 10Catrope: [C: 032] Don't force a separate http request for ext.wikiEditor.init [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/201004 (owner: 10Krinkle) [20:30:36] (03Merged) 10jenkins-bot: Don't force a separate http request for ext.wikiEditor.init [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/201004 (owner: 10Krinkle) [20:36:22] ryasmeen: I updated https://phabricator.wikimedia.org/P457 BTW. [20:36:37] okay James_F [20:36:45] Checking it [20:37:45] (03PS2) 10Krinkle: Registry: Remove outdated references to "base name" [oojs/core] - 10https://gerrit.wikimedia.org/r/200803 (owner: 10Catrope) [20:37:53] (03CR) 10Krinkle: [C: 032] Registry: Remove outdated references to "base name" [oojs/core] - 10https://gerrit.wikimedia.org/r/200803 (owner: 10Catrope) [20:41:05] (03Merged) 10jenkins-bot: Registry: Remove outdated references to "base name" [oojs/core] - 10https://gerrit.wikimedia.org/r/200803 (owner: 10Catrope) [20:47:29] (03PS1) 10Ori.livneh: Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 [20:50:19] (03CR) 10jenkins-bot: [V: 04-1] Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [20:51:12] (03PS2) 10Ori.livneh: Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 [20:52:25] (03CR) 10Catrope: Defer loading easy-deflate (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [20:52:33] (03CR) 10Catrope: [C: 04-1] "Comments on PS1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [20:53:42] (03CR) 10Ori.livneh: Defer loading easy-deflate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [20:55:25] (03CR) 10Catrope: Defer loading easy-deflate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [20:58:22] (03PS3) 10Mooeypoo: [wip] Use DM HTML in previews [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [21:01:11] (03CR) 10jenkins-bot: [V: 04-1] [wip] Use DM HTML in previews [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [21:01:23] jenkins doesn't like debugger; statments? [21:27:47] TrevorParscal, RoanKattouw so what's the problem with setupSlugs [21:27:54] edsanders: Well [21:28:11] When loading the editor, setupSlugs is invoked twice for every CBN [21:28:22] That seemed inefficient to me so I wanted to fix that and only have one call happen during load [21:28:39] But every attempt that I've made to that end has resulted in test breakages that seem legitimate [21:28:45] And now I'm out of my depth [21:28:58] I don't understand the slug code well enough to know why what I did was wrong [21:30:56] RoanKattouw, is it once before it is attached, and once after? [21:31:29] It's once from onSplice (when the children are being spliced in, all BranchNodes do that) and again from renderContents [21:31:48] I suppressed the onSplice one and only ran the renderContents one [21:32:09] Maybe what we need instead is for renderContents to cleverly place slugs rather than call setupSlugs? I don't know [21:32:33] CBN is weird in a number of ways, like ce.TextNode.$element being $([]) [21:33:43] (03CR) 10Catrope: [C: 032] Insert inline transclusion instead of block [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/200916 (owner: 10Mooeypoo) [21:38:07] (03Merged) 10jenkins-bot: Insert inline transclusion instead of block [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/200916 (owner: 10Mooeypoo) [21:40:46] (03PS1) 10Mooeypoo: Open the proper window when adding citation from the general dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201042 (https://phabricator.wikimedia.org/T94602) [21:54:16] (03CR) 10Catrope: [C: 032] Open the proper window when adding citation from the general dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201042 (https://phabricator.wikimedia.org/T94602) (owner: 10Mooeypoo) [22:06:05] (03PS1) 10Jforrester: Follow-up 7c0ba1e: Revert catastrophic breakage of qqq.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201047 [22:07:21] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/198738/ [22:08:00] (03CR) 10Catrope: [C: 032] Follow-up 7c0ba1e: Revert catastrophic breakage of qqq.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201047 (owner: 10Jforrester) [22:08:11] (03CR) 10Alex Monk: [C: 032] Follow-up 7c0ba1e: Revert catastrophic breakage of qqq.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201047 (owner: 10Jforrester) [22:08:16] James_F: edsanders needs to review that [22:08:16] :-) [22:08:22] RoanKattouw: Ah well. [22:08:31] Since there's stuff like ve.ui.DeleteRowTool.static.title = OO.ui.deferMsg( [22:08:43] Which I feel is probably not right but I don't know how to do it better [22:08:48] (03PS2) 10Jforrester: Use ve.safeDecodeURIComponent() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200811 (owner: 10Catrope) [22:10:26] * James_F nods. [22:14:30] The whole approach is very hacky, but that's because we don't have support for labels that change, or events to update the table context [22:15:21] Yeah. [22:15:39] edsanders: Is it good enough for now, though? [22:21:27] Personally I'd rather we did the work to support it properly [22:21:34] given that it's not an urgent feature [22:28:32] (03Merged) 10jenkins-bot: Open the proper window when adding citation from the general dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201042 (https://phabricator.wikimedia.org/T94602) (owner: 10Mooeypoo) [22:29:11] (03CR) 10Mvolz: [C: 04-1] "This changes should be go into the other commit https://gerrit.wikimedia.org/r/#/c/198397/- is there a reason they were put here separatel" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (owner: 10Rits) [22:32:48] edsanders: so, how's it going? [22:33:03] did you and Roan sync up on https://phabricator.wikimedia.org/T91245 ? [22:33:11] (03PS1) 10Jforrester: Open the proper window when adding citation from the general dialog [extensions/VisualEditor] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201053 (https://phabricator.wikimedia.org/T94602) [22:33:49] (03CR) 10Catrope: [C: 032] Open the proper window when adding citation from the general dialog [extensions/VisualEditor] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201053 (https://phabricator.wikimedia.org/T94602) (owner: 10Jforrester) [22:38:43] (03Merged) 10jenkins-bot: Follow-up 7c0ba1e: Revert catastrophic breakage of qqq.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201047 (owner: 10Jforrester) [22:40:19] (03Merged) 10jenkins-bot: Open the proper window when adding citation from the general dialog [extensions/VisualEditor] (wmf/1.25wmf23) - 10https://gerrit.wikimedia.org/r/201053 (https://phabricator.wikimedia.org/T94602) (owner: 10Jforrester) [22:45:21] (03CR) 10Mooeypoo: "Yeah they should, but I assume this was due to the git issues rits was speaking of earlier." (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (owner: 10Rits) [22:46:37] TrevorParscal, remember how we discussed having a generalized "iconned node" class in CSS for the nodes that have an icon when they're too small? Another reason to have that ^^ [22:48:15] TrevorParscal, a bit - I need to spend more time with it, it's fiddly