[01:22:39] James_F, do you happen to know how often events get inserted into the research db? [01:28:24] they get inserted into the master database at real time, but there may be a slight replication lag [01:28:47] re: Krenair [01:30:42] thanks ori, see -analytics, something else is broken in labs [01:30:50] oh you're not there [01:30:55] basically no events are even being logged [01:31:04] am looking into it now [01:32:00] (03PS1) 10Krinkle: mw.ViewPageTarget: Disable pointer events on dimmed elements while loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201089 [01:38:52] (03PS4) 10Mooeypoo: [wip] Use DM HTML in previews [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [01:38:57] (03CR) 10jenkins-bot: [V: 04-1] [wip] Use DM HTML in previews [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [01:44:17] (03CR) 10Catrope: [C: 04-1] "Commit message says "while loading" but CSS is added to the ve-activatING selector?!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201089 (owner: 10Krinkle) [01:44:47] (03CR) 10Catrope: "Sorry: CSS was added to activatED, I would have expected it to be added to activatING" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201089 (owner: 10Krinkle) [01:45:57] (03CR) 10Krinkle: "The same applies to the opacity. most of the elements are eventually permanently hidden by a stronger selector from ve-active. The rest re" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201089 (owner: 10Krinkle) [01:46:24] (03PS2) 10Krinkle: mw.ViewPageTarget: Disable pointer events on dimmed elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201089 [01:46:29] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Disable pointer events on dimmed elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201089 (owner: 10Krinkle) [02:46:24] (03PS3) 10Alex Monk: Try to unbreak WikiEditor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199387 (https://phabricator.wikimedia.org/T93384) [02:47:33] (03CR) 10jenkins-bot: [V: 04-1] Try to unbreak WikiEditor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199387 (https://phabricator.wikimedia.org/T93384) (owner: 10Alex Monk) [02:52:01] (03PS4) 10Alex Monk: Try to unbreak WikiEditor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199387 (https://phabricator.wikimedia.org/T93384) [03:45:19] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: Disable pointer events on dimmed elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201089 (owner: 10Krinkle) [03:47:49] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Disable pointer events on dimmed elements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201089 (owner: 10Krinkle) [05:31:49] anybody around? we may have an issue with Citoid. [05:44:31] mooey|away: as per mvolz'instructions, I pinged you on https://phabricator.wikimedia.org/T94662 . [08:07:54] (03CR) 10Nemo bis: "User notified https://translatewiki.net/wiki/Thread:User_talk:Leli_Forte/Translations_in_wrong_language (I also rolled back on the wiki, t" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201047 (owner: 10Jforrester) [08:20:09] (03PS1) 10Werdna: T93890: Allow intention flags for non-buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 [08:22:24] (03CR) 10jenkins-bot: [V: 04-1] T93890: Allow intention flags for non-buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 (owner: 10Werdna) [08:36:16] (03PS1) 10Nemo bis: Restore Leli Forte's mt translations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201149 [08:53:52] (03CR) 10Nikerabbit: [C: 031] "Easier this way than doing each one individually in a wiki." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201149 (owner: 10Nemo bis) [09:47:54] (03CR) 10Raimond Spekking: [C: 032] Restore Leli Forte's mt translations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201149 (owner: 10Nemo bis) [09:53:15] (03Merged) 10jenkins-bot: Restore Leli Forte's mt translations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201149 (owner: 10Nemo bis) [10:22:07] (03CR) 10Bartosz Dziewoński: [C: 04-1] "MediaWikiTheme.php needs the same changes." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 (owner: 10Werdna) [10:23:26] (03PS2) 10Werdna: T93890: Allow intention flags for non-buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 [10:26:46] (03CR) 10Bartosz Dziewoński: [C: 031] "I want to try out if this doesn't change anything unexpected before I merge, but it looks sane." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 (owner: 10Werdna) [10:27:07] (03CR) 10Werdna: "There are some test failures that I don't fully understand." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 (owner: 10Werdna) [10:28:16] (03CR) 10Bartosz Dziewoński: "There aren't any anymore? They were because the JS and PHP versions were out of sync." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 (owner: 10Werdna) [10:28:30] sup werdna [10:28:39] MatmaRex_mobile: oh thanks :p [10:28:44] I didn’t realise that’s what they were [10:29:40] it's not obvious when you have a hundred of tests failing with thousands of ines of output, heh [10:31:30] :D [10:32:33] (03CR) 10Bartosz Dziewoński: [C: 031] Only block for errors when saving [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/200478 (https://phabricator.wikimedia.org/T70765) (owner: 10TheDJ) [10:36:50] werdna: ehi, do you have further thoughts about https://phabricator.wikimedia.org/T93595 ? I don't know how to move forward with that. [10:37:41] Elitre: I could help out, but I don’t know where Oliver is doing the analysis so all I can do is provide drive-by feedback [10:39:42] (03PS1) 10Bartosz Dziewoński: MenuLayout: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/201166 [10:45:29] werdna: can you get in touch with him about that? I'd really appreciate it. [10:47:09] (tnx!) [12:24:59] is [[Category:Something|{{PAGENAME}}]] correct wikitext? what is it for? [13:32:08] as per James' instructions, I will paste here some diffs from wikis which recently got VE as the main editor (phase 5). I can't say whether these are user manipulations or bugs. [13:33:53] https://az.wikipedia.org/w/index.php?title=%C6%8Fbu_B%C9%99kr_%C9%99l-Ba%C4%9Fdadi&curid=356301&diff=3233021&oldid=3233018 and https://az.wikipedia.org/w/index.php?title=D%C3%B6vl%C9%99t_T%C9%99bi%C9%99t_Yasaql%C4%B1%C4%9F%C4%B1&curid=114403&diff=3232972&oldid=2814654 - dunno how the empty headings were made. if I try to replicate, I get a nowiki tag instead. [13:37:03] I see this elsewhere as well (https://mk.wikipedia.org/w/index.php?title=%D0%95%D0%B2%D1%80%D0%BE%D0%BF%D1%81%D0%BA%D0%B8_%D0%A3%D0%BD%D0%B8%D0%B2%D0%B5%D1%80%D0%B7%D0%B8%D1%82%D0%B5%D1%82_(%D0%A1%D0%BA%D0%BE%D0%BF%D1%98%D0%B5)&curid=124138&diff=3328145&oldid=3274768 ). [13:52:57] here, I don't know what happened, and I couldn't find anything related on Phab: https://mn.wikipedia.org/w/index.php?title=%D0%A2%D0%BE%D0%BE%D1%86%D0%BE%D0%BD_%D0%B1%D0%BE%D0%B4%D0%BE%D1%85_%D1%88%D0%B8%D0%BD%D0%B3%D1%8D%D0%BD%D0%B8%D0%B9_%D0%B4%D0%B8%D0%BD%D0%B0%D0%BC%D0%B8%D0%BA&curid=39243&diff=424635&oldid=424634 [14:09:16] here, playing a bit at the bottom of the article means the category can end up on the same line of the final template: https://mdf.wikipedia.org/w/index.php?title=%D0%9D%D0%B8%D0%BA%D0%BE%D0%BD&diff=46505&oldid=45943 [14:10:20] in that same article, I don't seem able to see the categories so that I can change them. and that's all for now. [14:16:33] lucky subbu lost all of my bug reports above, so he doesn't need to deal with them :p [14:17:31] good morning .. [14:18:43] subbu, :) [14:39:20] James_F|Away: RoanKattouw_away: ^^^ if you're interested in possible bugs from Phase 5 wikis. [15:45:05] (03PS1) 10Esanders: [BREAKING CHANGE] Split setupSlugs in to setup(Block|Inline)Slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201205 (https://phabricator.wikimedia.org/T91245) [15:45:49] (03PS1) 10Esanders: Rename setupSlugs to setupBlockSlugs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201206 [15:49:49] Morning Krinkle. [15:57:24] https://commons.wikimedia.org/w/index.php?title=Category:Wikimedia_servers_by_location&diff=155484686&oldid=155484639 [15:57:33] I wonder how we're generating those interwikis. I certainly didn't insert those as interwikis. [15:57:39] And I don't like :en: and I don't like labsconsole: [15:57:50] :/ [15:58:38] maybe it's parsoid magic [15:59:04] Krenair: Was that a VE edit? Why's it not tagged as such? [15:59:15] The edit before that was a VE edit [15:59:24] Yes. [15:59:25] the one on the left [15:59:39] the one on the right is me going back in the source editor and changing some stuff [15:59:39] https://commons.wikimedia.org/w/index.php?title=Category:Wikimedia_servers_by_location&diff=prev&oldid=155484639 looks fine to me. [15:59:55] labsconsole: and :en: are the 'ranking' interwikis for those. [16:00:19] while we should be using wikitech: and w: :/ [16:00:33] it's a matter of changing the MW config afaik [16:00:48] (03Abandoned) 10Esanders: Rename setupSlugs to setupBlockSlugs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201206 (owner: 10Esanders) [16:00:59] only one of the interwikis can be primary per wiki.. [16:01:29] Yeah. [16:01:31] :en: actually looks okay to me [16:01:34] (03CR) 10Esanders: "Not likely to be a real breaking change - but changes some function names around." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201205 (https://phabricator.wikimedia.org/T91245) (owner: 10Esanders) [16:01:35] Agreed. [16:01:40] Wikipedia is the ranking wiki. [16:01:52] It might be awkward, but it's what MediaWiki is based on. [16:02:33] It shouldn't even work on commons. [16:02:44] I'm guessing it does for historical reasons [16:03:51] * James_F shrugs. [16:04:15] We certainly shouldn't be encouraging it [16:07:55] OK MatmaRex, back on the horse...I want to take the PanelLayout that I created on the backend, detach it from the DOM, and put it into a Dialog. [16:08:46] For some reason, content in the config doesn't do anything...well, at least not with an HtmlSnippet, but maybe I can just use the jQuery object [16:09:51] Nope. Nope I cannot. [16:10:09] marktraceur: can you pastebin the code somewhere? [16:10:15] Yeah, sec [16:12:04] I saw a fatal error pop up last night from OOUI code being called from Extension:Collection [16:12:10] I suppose I should talk to cscott about it [16:12:24] https://phabricator.wikimedia.org/P467 [16:12:26] MatmaRex: ^^ [16:13:03] MatmaRex: This is where 'message' doesn't work either, but it's the same either way [16:14:02] At least the dialog gets opened. [16:15:10] hmm. weird. [16:15:18] James_F: On to my 5th year at WMF now :) [16:15:25] April 1st 2011 [16:15:30] Krinkle: Such a fool, you are. [16:15:46] MatmaRex: I wouldn't be surprised if the answer were that it doesn't like jQuery elements. But then what *does* it like? [16:17:25] no, it should take jQuery elements just fine [16:17:32] Oh hrm [16:17:36] It's there but hidden. [16:17:38] I don't know why. [16:17:53] Maybe because some herp styled it funny [16:18:04] Excuse me while I finish this and then walk away in shame [16:18:53] James_F, I was wondering what you thought about https://phabricator.wikimedia.org/T94084#1169234 [16:19:26] should we alter core to make the edit source button do it? [16:19:27] :D [16:19:33] Krenair: Maybe. [16:21:29] MatmaRex: OK, what about dialog width [16:22:28] Hm, maybe setSize [16:22:38] marktraceur: MyDialog.static.size = 'large'; [16:23:35] MatmaRex: Oh, I need a subclass for that? [16:24:16] marktraceur: probably. i think setting a size yourself will interact funnily with things [16:24:18] but maybe it won't [16:24:26] I think it just doesn't work at all. [16:25:01] Oh, actually, it worked OK. [16:25:12] marktraceur: if you do it at the wrong time, WindowManager might overwrite your change [16:25:16] Hm, the z-index is a bit funky... [16:25:23] or something [16:25:30] MatmaRex: I doubt it, there's only one interaction with this form [16:25:42] i know something was funky about this, but can't exactly remember what right now [16:26:06] MatmaRex: The personal bar has a higher z-index than the dialogs for some reason... :P [16:26:25] marktraceur: try resizing the browser window and make sure that the OOUI dialog doesn't respond in weird ways [16:26:25] That's going to look pretty when this rolls out. [16:26:36] if it doesn't, it's probably good [16:26:50] Naw, it looks pretty great actually [16:27:49] okay. yay [16:28:34] A few more tweaks, and making it actually do something, and I'll be off to the races [16:30:10] MatmaRex: Damn, the labels for accept and reject are static, too. *fine* I'll subclass. [16:30:29] accept and reject? [16:30:33] the buttons? [16:30:36] Yeah [16:30:46] nnnnno [16:30:47] shouldn't be [16:31:30] Oh. Maybe not digging deep enough yet. [16:32:04] getActionWidgets() I guess [16:32:07] marktraceur: you can pass 'actions' to openWindow, like 'title' and 'message' [16:32:28] Huh, where is that documented [16:32:29] the docs for this are, ughhh [16:32:32] Hahaha [16:32:34] on OO.ui.MessageDialog#getSetupProcess [16:32:36] apparently [16:33:05] in the same format as OO.ui.MessageDialog.static.actions [16:33:17] Right. [16:33:27] docs are lacking, but we have examples for this in the demo [16:37:30] MatmaRex: Primary constructive ActionOptionWidgets don't get the full body colour, just a little highlight colour on hover? [16:39:31] marktraceur: in MessageDialogs? probably not. you know, these are Apex's styles, since no one ever bothers to design anything for the existing interfaces around here. [16:41:55] Just confirming [16:42:05] MatmaRex: Unless you want me to shoehorn in a change. [16:43:23] marktraceur: to the design? if you feel like it, i don't really care for the button styles. you might want to poke TrevorP|Away [16:43:52] mooeypoo: hello, you mentioned in this https://gerrit.wikimedia.org/r/#/c/200945/ extension.json file, but i didn't changed anything in the json file [16:44:31] rits, yeah, it's just a way to add files just like you added it to the VisualEditor.php [16:44:51] when you add a file you need to add it to VisualEditor.php -- and also to extension.json [16:45:13] mooeypoo: oh, ok i didnt knew about that i will add it thank you :) [16:45:22] no problem :) [16:45:31] it's easy to miss, it's relatively new [16:53:27] (03CR) 10Divec: [C: 031] "Very much nicer." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201205 (https://phabricator.wikimedia.org/T91245) (owner: 10Esanders) [16:55:22] Krenair: Looked in EL beta labs and all looks good, let me know if you were able to test [16:56:07] MatmaRex: And...last thing, I think. What are the events to listen to for accept/reject? [16:56:26] Or is it just one "close" and I should check some other value for which button got pressed [16:57:10] nuria, max(timestamp) is 20150401165401 [16:57:11] marktraceur: it's passed as "closing data" [16:57:21] so sounds like its working again [16:57:22] thanks nuria [16:57:23] one sec [16:57:32] Krenair: ok. [16:59:47] marktraceur: second-to-last example on https://www.mediawiki.org/wiki/OOjs_UI/Windows/Message_Dialogs [16:59:47] Eugh [17:01:19] OK I think I've got it from here, thanks [17:14:33] (03PS3) 10Rits: Assigning width and height to alien extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 [17:15:03] (03CR) 10jenkins-bot: [V: 04-1] Assigning width and height to alien extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (owner: 10Rits) [17:15:10] \o/ success, thanks a lot MatmaRex [17:15:42] yay [17:18:15] rits, does it work now in your testing? with the css file [17:18:18] mooeypoo: https://gerrit.wikimedia.org/r/200945 , -1 this time also [17:18:49] mooeypoo: i didnt tested in the inspector just a moment [17:20:59] mooeypoo: it didn't worked, nothing in the inspector also [17:21:25] rits, do you see any of the classes you wrote in the CSS file applied? [17:21:41] when you inspect the node in the browser, do you see the new css rules ? [17:22:19] mooeypoo: no i searched for it the classes are not showing up [17:22:49] rits, then something's happening with your css [17:22:56] either the definitions aren't right or the file's not there [17:23:16] mooeypoo: oh ok actually i used the same css as of the template one [17:23:31] rits, yes, but if it's not being applied, it wont' work :) [17:23:56] (03CR) 10Legoktm: "See my comment on Iabc322c7b92c768c9a6e7d272a5816e32743a501 for an example." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/200305 (https://phabricator.wikimedia.org/T93616) (owner: 10MarkAHershberger) [17:24:11] mooeypoo: that could be the reason actually git stashing sometimes delete the file i will just double check it [17:24:15] make sure it's applied. If not, then there is probably an issue with either the class names or a missing class definition or something like that [17:24:42] rits, the file is there in gerrit, but if the definitions in it aren't applied, it might be something in the code [17:25:40] rits, take a look at the css file and see if there might be classes that are missing from the node itself [17:25:54] it might be something where a class wasn't applied or some definition is missing or something like that [17:26:00] mooeypoo: ok i will check it again, no actually yesterday stashing removed my css file and i got to know it today [17:26:21] stashing? you mean git stash? [17:26:42] mooeypoo: yes i meant that git stash [17:27:04] rits, if you git stash, you can git stash apply [17:27:19] it will apply the stashing..? i'm a little confused, if you run into git problems let us know, we can help [17:28:02] mooeypoo: i used git stash pop but the git issues doesnt resolved so easily i changed it all over again [17:28:33] okay I'm not sure I understand what git issues, but if you run into more specific ones, we can help as they happen [17:28:52] rits, in any case, the current problem should be about some definition in the existing files in your gerrit patchset [17:29:10] if you have mismatching stuff in your local version, just reset everything and pull the gerrit patchset [17:29:26] mooeypoo: ok then i should work over the css file [17:29:44] no its the same now as the gerrit patchset [17:29:47] yeah it should be either in the css or in the code, but something with the styles is probably wrong or missing [17:29:51] ok [17:30:20] mooeypoo: ok i will work over that now, thank you [17:30:25] sure [17:38:47] (03PS5) 10Mooeypoo: Create reference preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [17:41:54] (03PS1) 10Legoktm: Update extension.json, get rid of PHP entry point [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/201235 [17:52:14] (03CR) 10MarkAHershberger: "The only relevant comment I see there is" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/200305 (https://phabricator.wikimedia.org/T93616) (owner: 10MarkAHershberger) [17:56:12] (03CR) 10Esanders: "Could reference preview widget be made generic? There doesn't seem to be much in there that is specific to references." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [18:06:14] (03CR) 10Mooeypoo: [C: 04-1] Assigning width and height to alien extension nodes (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (owner: 10Rits) [18:06:55] (03CR) 10Mooeypoo: "Good point. I didn't see current use of this outside references for the moment, but there probably is - if not for now, for the future for" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [18:07:23] edsanders, what shall I call this new widget? Just MWPreviewWidget or specifically MWGeneratedContentPreviewWidget ? [18:07:51] well, I guess it's not *just* for GCNs, though that's its main purpose [18:09:11] edsanders, mooeypoo: The fact that it uses dm.ReferenceModel and ce.InternalItemNode is specific to references, at lesat [18:09:52] RoanKattouw, yeah but I can probably generalize it if I find another example use, which is what I'm trying to do [18:11:39] RoanKattouw, though I'm having problems finding those. General templates, maybe? [18:13:28] I don't know that there are any right now [18:13:38] I think Ed wants to use this for captions [18:14:05] hm [18:14:08] so sub documents? [18:14:08] :D [18:15:07] Yeah :D [18:15:44] I coudl call it 'MWDocumentPreviewWidget" but I am going to have to do soemthing creative with config option to allow for various models and nodes [18:15:50] I have an idea but it's a little convoluded [18:16:11] For subdocuments that's what it should be [18:16:16] But we don't have subdocuments right now [18:16:33] So let's deal with the reality we have rather than the reality we wish we had [18:16:50] * mooeypoo nods [18:17:03] we can generalize it later, I guess. I thought there might be another example use right now [18:18:06] James_F the ref name bug is now https://phabricator.wikimedia.org/T94712 [18:18:13] RoanKattouw, okay, not even generalize the name? [18:19:05] Hmm [18:19:16] Maybe it should be called MWPreviewWidget and take an InternalItem? [18:19:22] And then I can make it take a Document later? [18:19:46] RoanKattouw, I need the document to create the getDomFromModel though [18:19:54] var preview = ve.dm.converter.getDomFromModel( this.model.getDocument(), true ) [18:20:23] or do you mean take both model and internal item? [18:22:25] A dm.InternalItemNode has a .getDocument() method [18:22:57] James_F, I also think you should read the comments here: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Copying_and_editing_links [18:23:01] hm [18:23:16] RoanKattouw, so I'll create the internal nodes outside the widget? [18:23:17] I can do that [18:23:44] just means it's a step back in the abstraction, but if it will mean better use cases, we can go with it [18:24:10] No, no [18:24:12] I'm saying [18:24:18] Take a *DM* InternalItemNod [18:24:24] And *create* a *CE* InternalItemNode [18:24:33] oh [18:24:35] mh [18:24:49] From a ReferenceModel I think there's a getter for the dm.InternalItemNode? [18:24:56] this.model.getDocument().getInternalList().getItemNode( this.model.getListIndex() ) <-- dm node [18:25:06] i think? [18:25:09] should be. [18:25:18] this.model instanceof ve.dm.MWReferenceModel ? [18:25:25] yep [18:25:35] according to the docs, that's right [18:25:39] See ve.dm.MWReferenceModel.prototype.findInternalItem [18:25:49] ve.ce.InternalItemNode takes ve.dm.InternalItemNode [18:25:53] and that is what I feed it now [18:26:15] Which word for word does what you said except that for some strange reason it takes a surface [18:26:26] RoanKattouw, @return {ve.dm.InternalItemNode|null} <-- #findInternalItem [18:26:31] Yeah [18:26:55] RoanKattouw, in all cases of use right now I have the referenceModel anyways [18:27:10] I can just use the same logic *outside* the widget to create the dm internal node and feed it. [18:27:45] Yeah [18:27:55] just trying to verify that i'm not losing any functionality. I don't think so, but I'll test it out [18:28:01] No I think you're fine [18:40:22] (03CR) 10Catrope: [C: 04-1] "I'm a bit confused. It seems like a lot of these changes don't change the behavior, there's only one of them that does?" (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201205 (https://phabricator.wikimedia.org/T91245) (owner: 10Esanders) [18:41:02] ve-ce-documentNode is bouncing to { top: 0 } ... now I need to set a watchpoint on CSS changes [18:41:23] * hexmode hates that he is learning more about IE11 [18:42:49] hexmode: When does that happen? [18:43:07] When inserting a bullet [18:43:12] RoanKattouw: ^^ [18:43:18] hah [18:44:26] is my pain funny to you? :P [18:44:34] thats ok, no pain, no gain [18:44:42] I was surprised [18:44:43] I'm doing a lot of growing [18:44:59] I see scrolling issues on copy-paste in IE11 but I didn't realize it did something weird when inserting a bullet [18:45:15] Let me verify on enwiki [18:48:25] RoanKattouw: verified on enwiki. I can point you to my phab task if you're interested. [18:48:53] RoanKattouw: but even more helpful would be telling me how to trap whenever the screen jumps like that. [18:48:59] I have no idea [18:49:14] (03PS6) 10Mooeypoo: Create a preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [18:49:32] IIRC, I was stepping through the code and the BUG DIDN'T HAPPEN [18:49:42] grmmbl [18:49:52] Scrolling can sometimes be due to focus changes, so you could listen for those [18:50:29] $(document).on('focusin focusout', function ( e ) { console.log( e.type, e.target ); } ); [18:50:29] yeah, looking at fixes for similar bugs, that seemed to be what was fixed [18:50:39] :) [18:56:01] (03CR) 10Esanders: "I'm trying to change as few thing as possible. There are some redundant checks that can be removed later, but at the moment it's clear wha" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201205 (https://phabricator.wikimedia.org/T91245) (owner: 10Esanders) [18:57:26] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Split setupSlugs in to setup(Block|Inline)Slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201205 (https://phabricator.wikimedia.org/T91245) (owner: 10Esanders) [18:58:21] edsanders|away: That patch fixes the bug (setupSlugs called twice), right? [19:05:35] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Split setupSlugs in to setup(Block|Inline)Slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201205 (https://phabricator.wikimedia.org/T91245) (owner: 10Esanders) [19:08:31] James_F: i just filed two more blockers to https://phabricator.wikimedia.org/T92551 :/ [19:16:11] MatmaRex: Yay. [19:18:33] not exactly yay. [19:18:33] ;) [19:18:33] Not exactly not sarcastic. ;-) [19:18:33] * MatmaRex grumbles [19:37:09] uh, MatmaRex, quick OOUI PHP question [19:37:14] I'm trying to debug something in Collection [19:37:21] using eval.php [19:37:26] Caught exception OOUI\Exception: OOUI\Theme::singleton was called with no singleton theme set. [19:37:44] hm [19:37:54] Krenair: missing call to OutputPage::setupOOUI()? [19:38:03] enableOOUI* [19:38:14] which does: [19:38:14] OOUI\Theme::setSingleton( new OOUI\MediaWikiTheme() ); [19:38:14] OOUI\Element::setDefaultDir( $this->getLanguage()->getDir() ); [19:38:14] $this->addModuleStyles( 'oojs-ui.styles' ); [19:38:48] that did it, thanks [19:38:52] Krenair: i think cscott started writing his patch before we added that, heh [19:39:25] this is not actually using Collection's code [19:39:30] just trying something very similar in eval.php [19:39:42] I took a tiny snippet and probably missed such a call [19:47:30] RoanKattouw: ty for the snippet. Focus isn't changing, according to that. Which shows, I think, why the other fixes didn't work for this. [19:47:33] (sorry for the delay... life.) [19:48:08] anyone have other ideas about what causes screen jumping? [19:48:17] * hexmode goes to look for his bug so he can update it [19:57:54] James_F|Away: have you looked at mediawiki-l recently? VE's REL1_24 is somewhat broken. are we maintaining it (backporting stuff)? [20:05:33] Krinkle: whenever you feel like thinking about RL cache invalidation… https://gerrit.wikimedia.org/r/#/c/201267/ [20:06:53] MatmaRex: OK. Will check out tomorrow morning [20:07:05] thanks [20:15:10] RoanKattouw, thinking about https://phabricator.wikimedia.org/T49779#486219 again [20:15:56] so...on the edit source page, make the (VE) edit button open the same sort of OOUI dialog we show for switching from VE to edit source [20:17:40] if they choose to keep changes, load VE into the current screen, VE detects that there's a textbox open, gets the metadata for the page, and send the current wikitext off for conversion? [20:27:27] where's wikibugs? :( [20:28:45] forgetting to join channels again [20:28:46] legoktm [20:35:59] MatmaRex: having issues [20:37:05] (03CR) 10Legoktm: [C: 04-2] "And this will probably break i18n :/" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/201235 (owner: 10Legoktm) [20:53:42] (03PS4) 10Mooeypoo: Assigning width and height to alien extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (owner: 10Rits) [20:55:33] mvolz: around? ankita-ks is wondering what's special about "lookup" in Citoid. [20:55:45] how would it be different from just "search" and "find". [20:56:41] (03CR) 10jenkins-bot: [V: 04-1] Assigning width and height to alien extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (owner: 10Rits) [20:57:20] aharoni, you mean the button? [20:57:59] aharoni, it's "lookup" because we aren't really searching or finding a specific reference that already exists, we're looking up the source (the site) and building it [20:58:25] mooeypoo: https://translatewiki.net/wiki/Special:Translate?filter=&action=translate&group=ext-citoid [20:58:33] MatmaRex: I think it should be back now [20:58:43] mooeypoo: As you can see, I translated it to Hebrew with the same word as "search" ;) [20:58:48] would you suggest something different? [20:59:00] ankita-ks asks the same question for Hindi. [20:59:19] hm, yeah I'm trying to think [20:59:25] it's not quite 'search' [20:59:34] but i'm not sure i have an alternative word. Hmmm [21:00:21] aharoni, google translate the almighty (ha) says "lookup" is בדיקה [21:00:35] which isn't quite right, but it's not quite search either [21:01:09] aharoni, how would you translate 'retrieve' ? [21:01:42] mooeypoo: retrieve = אחזור, that's an easy one [21:01:49] לשלוף? [21:01:50] oh [21:03:22] mooeypoo: The Academy of the Hebrew Languages has a terms dictionary, which is sometimes very useful and sometimes very ridiculous :) [21:04:19] aharoni, lookup is more like cross referencing [21:04:27] it actually has "look up", and it's חיפוש (the same word as "search"), although it appears under the topic of Geodesy and not Information Technology. [21:04:30] RoanKattouw is making a good point about dictionary comparison [21:04:38] 10VisualEditor, 7Browser-Support-Internet-Explorer: Screen jumps in Internet Explorer 11 when clicking "Bullet list" or "Numbered list" in toolbar - https://phabricator.wikimedia.org/T93929#1172025 (10MarkAHershberger) Using a similar function to the one @Catrope gave me with way too many events, I narrowed it... [21:04:43] thanks legoktm [21:05:16] aharoni, "search" implies an uncertainty about where something is, while lookup is going to the place where you know it is to retrieve information [21:05:25] ... that makes sense? I have NO idea what alternative word for this in Hebrew though [21:05:42] what do you do to a word in the dictionary? You look it up, you don't search for it... how do we say that in hebrew? [21:05:50] That's what I said anyway [21:05:50] ... do we... say that in Hebrew...? [21:06:06] mooeypoo: according to a thesaurus, the synonyms of חיפוש are איתור, בדיקה, ביקוש, חיטוט, נבירה, סריקה, פשפוש [21:06:08] Like, if the user inputs an ISBN or DOI, getting the title for that isn't a "search" but it is a "lookup" [21:06:19] ביקוש! [21:06:24] yes, that sounds better to me [21:06:30] I think [21:06:43] Isn't this that you're asking for something you're know is there [21:06:51] Oh really. Curious. You're a native speaker, I'm not :) [21:06:52] or איתור [21:06:54] Krenair: So, AFAIK we lack proper Parsoid support to do real wikitext-to-VE switching [21:07:01] איתור ! [21:07:04] that's the one. I think! [21:07:12] aharoni, well that doesn't mean anything. You studied linguistics [21:07:14] I just use it [21:07:19] RoanKattouw, so... we need to make dependencies? [21:07:20] :D [21:07:23] RoanKattouw, what are we missing from parsoid? [21:07:32] Krenair: We were saying earlier that bidirectional switching is something we'd really like to do in Q4 (I see it's nominated as a Q4 bug) but it needs Parsoid/RB support [21:07:47] Well, you know how selser restores old wikitext for unmodified HTML? [21:08:05] Not how. [21:08:12] OK but you know that it does [21:08:13] I know it does that. [21:08:23] aharoni, I would say איתור is better. Sounds closer to something like 'pinpoint' or 'spot' [21:09:06] mooeypoo: yeah, that's the one I'd pick if not חיפוש. Nice discussion :) [21:09:07] Roughly speaking, it does this by knowing that a certain HTML node started as a certain substring of the wikitext (I believe that this is what dsr or one of the Xsr things is: [12,20] meaning "this HTML node was origWikitext.slice( 12, 20 )) [21:09:17] aharoni, yes! :) thanks for that [21:09:26] But so when serializing, it needs to refer back to the original wikitext [21:09:35] Which is fine when the original wikitext is a revision that's in the database [21:09:54] But when it's "random crap the user had in their editor when they chose to switch", it's not necessarily stored anywhere [21:10:49] This problem is probably solvable, and the Parsoid and RESTbase teams probably have better ideas for solving it than I do -- I'm just saying that selser won't obviously work without some additional effort [21:11:01] ankita-ks: So, for Hebrew mooeypoo and I found another word that is not "search", but more like "locate". If you can think of something like that for Hindi, it would be good. If not... not a big deal, just use the same word as "search". [21:12:48] RoanKattouw_away: Parsoid now has the ability to pass in the wikitext as well [21:13:01] we don't expose that in RB yet, but we can [21:15:55] heya rits [21:16:21] okay. let me think. [21:16:28] mooeypoo: hello sorry for getting offline, just didn't when i got to sleep its 3AM here actually :) [21:16:37] rits, aw! go sleep! [21:16:39] :) [21:16:58] mooeypoo: no i had now :) [21:17:29] mooeypoo: i tried the changes but the css classes is not showing up [21:17:34]