[00:00:40] (03PS1) 10Catrope: Use .apply() in MWInternalLinkAnnotation.static.toDomElements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201390 [00:01:38] uhm [00:02:02] MatmaRex, how is the popup positioning working at all in rtl? there doesn't seem to be *any* adjustments at all in OO.ui.PopupWidget.prototype.updateDimensions [00:02:09] Im trying to make sense of the calculations in there [00:02:39] superm401: Meh. Sure. [00:03:06] superm401: It's a bit sucky. [00:03:11] MatmaRex, strike that, I recant. It's *not* working at all :P [00:03:36] direction shouldn't matter there, no? [00:03:42] MatmaRex, this is a huge regression, it used to work. Popups are now semi hidden and out of bounds in RTL [00:03:46] James_F, yes, a bit. Maybe someone can suggest a better solution on the bug (I'm not sure why the check is there to begin with). [00:03:49] mooeypoo: if you file a bug, i'll look into it [00:03:51] it should since the screen is offset the other way [00:03:52] But just temporary. [00:04:03] or if you submit a patch, i'll review :P [00:04:11] superm401: Which check? The one that stops you editing pages that can't be usefully edited in VE with VE? :-) [00:04:16] i'm off for the night. sweet dreams [00:04:20] MatmaRex, i'll file a bug,and I'm trying to figure out the calculations so I can try and submit a patch [00:04:25] but I wanted to see if I wasn't missing anything [00:04:38] James_F, it doesn't stop you from editing pages (that's done elsewhere); it stops you from using the VE API. [00:05:24] superm401: Oh, you mean the one in ApiVisualEditor.php? [00:05:29] Yeah [00:06:00] superm401: That'd be RoanKattouw's and Krenair_'s call. [00:06:17] I'll CC them. [00:06:49] In Phabricator? Don't bother. [00:07:02] 2000 Phabricator tasks on CC means no tasks on CC. :-( [00:07:15] Discussion in IRC or SoS is most effective. [00:08:38] 10VisualEditor, 6Collaboration-Team, 10Flow, 5Patch-For-Review: Way for VE to run on Flow without changing wgVisualEditorNamespaces - https://phabricator.wikimedia.org/T94282#1172579 (10Mattflaschen) Does anyone know why https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FVisualEditor.git/792e1444de3d2... [00:08:51] Well, now we're doing both. [00:09:54] (03PS1) 10Kmenger: Process: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/201393 [00:10:14] 10VisualEditor, 6Collaboration-Team, 10Flow, 5Patch-For-Review: Way for VE to run on Flow without changing wgVisualEditorNamespaces - https://phabricator.wikimedia.org/T94282#1172580 (10Mattflaschen) [00:11:20] James_F, I didn't realize "It's a bit sucky" meant you were retracting your "Meh. Sure." [00:12:08] superm401: I'm talking to five people at once. Surprising people with unannounced config patches isn't ideal. [00:12:59] Yeah adding NS_TALK sounds like a bad idea [00:13:09] We don't want VE to be able to run on Talk pages [00:13:19] superm401: But yeah, sorry. [00:13:21] (I mean normal talk pages, not Flow-enabled ones) [00:13:37] superm401: Do I understand correctly that you only want to dodge the check in ApiVisualEditor.php, not the client-side one? [00:13:48] James_F, I didn't mean to surprise you, this issue just slipped my mind until we hit the bug in production. [00:14:03] superm401: Yeah, totally understood. [00:14:08] James_F, of course, I still wanted to ask you, but I'm fine with aborting. [00:14:08] 10OOjs-UI: Popups are not positioned correctly in RTL - https://phabricator.wikimedia.org/T94783#1172597 (10Mooeypoo) 3NEW a:3Mooeypoo [00:14:32] superm401: Let's get a VE fix done and pushed out tomorrow morning instead? [00:14:40] RoanKattouw, yes. [00:15:20] superm401: If you found a way to only dodge the server-side check while leaving the client-side one in place, I'd be OK with hat [00:15:22] RoanKattouw, and I think it only has to be dodged for parsefragment. [00:16:11] the edit button in the link dialog box has some extra height for some reason. all other buttons look goood! [00:16:11] 10OOjs-UI: Popups are not positioned correctly in RTL - https://phabricator.wikimedia.org/T94783#1172607 (10Mooeypoo) [00:16:54] 10OOjs-UI: Popups are not positioned correctly in RTL - https://phabricator.wikimedia.org/T94783#1172597 (10Mooeypoo) [00:17:25] superm401: It worked anyway, somehow. [00:17:32] I can't figure out why [00:17:52] James_F, what did? [00:20:10] James_F, VE is not totally broken without this fix, just templates. [00:20:11] Okay, so which commit is the VE side of this? [00:20:30] Krenair, it was going to be a mediawiki-config fix, but I'm going to write a VE one instead. [00:20:35] And not for tonight. [00:20:45] ok [00:20:45] I mean not to deploy today. [00:20:55] superm401: Oh, right. That's pretty sucky, yeah, let's fix that urgently. [00:22:08] James_F, we could talk to danny if you want to disable it until that's fixed. [00:22:31] superm401: I'm happy for it as is, but I'll get it fixed at our end. [00:22:49] Okay, I'm working on a patch now. [00:23:01] 10VisualEditor, 6Collaboration-Team, 10Flow, 5Patch-For-Review: Way for VE to run on Flow without changing wgVisualEditorNamespaces - https://phabricator.wikimedia.org/T94282#1172626 (10Mattflaschen) a:3Mattflaschen [00:42:31] (03PS1) 10Mattflaschen: Allow parsefragment even if VE is not enabled for that title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201400 (https://phabricator.wikimedia.org/T94282) [00:44:48] (03CR) 10jenkins-bot: [V: 04-1] Allow parsefragment even if VE is not enabled for that title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201400 (https://phabricator.wikimedia.org/T94282) (owner: 10Mattflaschen) [00:47:29] (03PS2) 10Mattflaschen: Allow parsefragment even if VE is not enabled for that title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201400 (https://phabricator.wikimedia.org/T94282) [00:48:02] Good evening / night... [00:48:50] I'm may need someone pointing me to the right idea to get the "Edit" Tab displayed after installing Parsoid & Visual Editor. Would be glad if someone can spend a few minutes with me to help me thinking again. Sitting on this topic since 5 hours now... ;-) [00:55:17] The tab changed from "Edit" to "Edit source", but there should be an additional/new edit "button". This is not displayed. Parsoid & VE are on the same server. WM is on https and the certs are in the store. "curl -L https://wiki.c.c/api.php" works. "curl http://localhost:8000/locahost/SamplePage" is also responding. However inside MW there is no edit option... [00:55:41] ok [00:55:48] do you have any error in your JS console? [00:56:51] olg12, did you set the visualeditor-enable pref? It defaults false. [00:56:59] $wgDefaultUserOptions['visualeditor-enable'] = 0; [00:57:04] To enable it for everyone, you'd want: [00:57:06] $wgDefaultUserOptions['visualeditor-enable'] = 1; [00:57:22] (The latter means 'enabled by default'). [00:57:25] superm401: I did the settings in Localsettings.php [00:57:51] olg12, can you post the LocalSettings.php? [00:58:25] Krenair: To be fair - I have no idea which console you mean. I started nodejs parsoid/api/server.js ... Do you mean this output? [00:58:55] I meant your browser's console if you open up your browser's equivalent of developer tools [00:59:26] superm401 - sure, but it's a big file... due to several extensions. So I splitted it to a include load of "VisualEditorSettings.php" ... ;-) [01:00:03] olg12, haha, I take it you haven't seen our config? ;) [01:00:51] Krenair: I configured MediaWiki with the debug-tab displayed - this offers some additional information. [01:01:12] (Wikimedia InitialiseSettings.php is >15k lines) [01:03:18] And that's only part of it. :) [01:03:20] Krenair: What's the pre-req to display the edit button? Before it get displayed - is there already a kind of connection test maybe? [01:03:31] no [01:03:33] olg12, can you please post the relevant settings? [01:03:45] there are many config things we check [01:03:54] superm401: As a copy-paste line by line here? [01:03:54] but yes, still waiting for your settings :) [01:04:08] olg12, https://phabricator.wikimedia.org/paste/create/ [01:04:39] And include the require/include lines, since the order matters. [01:04:45] superm401 - it's requesting ldap accout [01:05:14] superm401 - the story with the order... Yeah - actually a good idea [01:05:23] olg12, if you click the sunflower you can login with MediaWiki.org. But you can use whatever paste you want, e.g. https://dpaste.de/ [01:05:32] I currently load VE nearly at the end of everything [01:06:33] is your site public? [01:08:19] olg12, just start with the first line about VisualEditor or Parsoid, and go until the last line about either of them. [01:08:22] Krenair: Unfortuantely not... I [01:08:31] 'I'm right now doing the paste stuff [01:08:57] please allow me a minute to remove the confid stuff. [01:09:56] ok [05:13:24] (03CR) 10Prtksxna: "Thanks for this MatmaRex!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/200635 (https://phabricator.wikimedia.org/T93944) (owner: 10Bartosz Dziewoński) [05:34:13] 10OOjs-UI, 10UI-Standardization, 7Design: Update wikifont set with new icons - https://phabricator.wikimedia.org/T94461#1172993 (10Prtksxna) >>! In T94461#1164050, @violetto wrote: > The set is mixed up with icons from Apex it seems. That might be why there is more than what's on Dropbox. Once we have repl... [05:41:57] 10OOjs-UI, 10UI-Standardization, 7Design: Update wikifont set with new icons - https://phabricator.wikimedia.org/T94461#1173001 (10violetto) Okay sounds good. [07:37:39] (03Abandoned) 10Krinkle: jenkins job validation, do not submit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/200918 (owner: 10Legoktm) [07:37:53] (03PS6) 10Krinkle: [BREAKING CHANGE] Make default property interfaceText [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) (owner: 10Mooeypoo) [07:45:30] (03PS7) 10Krinkle: [BREAKING CHANGE] Change "default" property to InterfaceText [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) (owner: 10Mooeypoo) [07:50:47] (03CR) 10Krinkle: [C: 04-1] "Find another use of the old default property which is incompatible now." (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) (owner: 10Mooeypoo) [07:50:50] (03PS8) 10Krinkle: [BREAKING CHANGE] Change "default" property to InterfaceText [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) (owner: 10Mooeypoo) [07:54:04] (03PS9) 10Krinkle: [BREAKING CHANGE] Change "default" property to InterfaceText [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) (owner: 10Mooeypoo) [07:54:28] (03CR) 10Krinkle: "Fixed. It now says "empty" in the html rendering when the property is not given." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) (owner: 10Mooeypoo) [07:54:33] (03CR) 10Krinkle: [C: 032] [BREAKING CHANGE] Change "default" property to InterfaceText [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) (owner: 10Mooeypoo) [07:56:11] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Change "default" property to InterfaceText [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/195451 (https://phabricator.wikimedia.org/T54966) (owner: 10Mooeypoo) [08:11:29] (03CR) 10Krinkle: "mw.loader.load indeed. Both because there is no callback, but also conceptually this would be a place where other modules could be listed " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [08:24:13] 10MediaWiki-ResourceLoader, 10Beta-Cluster: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences lacks normal styling - https://phabricator.wikimedia.org/T93050#1173089 (10Krinkle) This has now hit production. https://en.wikipedia.org/wiki/Special:Preferences. It seems de.wikipedia.org and www.wikida... [08:24:17] 10MediaWiki-ResourceLoader, 10Beta-Cluster: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences lacks normal styling - https://phabricator.wikimedia.org/T93050#1173092 (10TheDJ) This has now progressed towards en.wp production: T94808 [08:25:09] 10MediaWiki-ResourceLoader: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1173094 (10Krinkle) p:5Normal>3High [08:25:40] 10MediaWiki-ResourceLoader, 10MediaWiki-Interface, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1127937 (10Krinkle) [08:25:56] 10MediaWiki-ResourceLoader, 10MediaWiki-Interface, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1127937 (10Krinkle) [08:26:04] 10MediaWiki-ResourceLoader, 10MediaWiki-Interface, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1127937 (10Krinkle) [08:49:59] 10MediaWiki-ResourceLoader, 7Wikimedia-log-errors: ResourceLoader timestamp for user modules should not be computed for logged-in users - https://phabricator.wikimedia.org/T94810#1173115 (10Krinkle) 3NEW [09:05:21] 10MediaWiki-ResourceLoader, 10MediaWiki-Interface, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1173167 (10aude) https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=654608953#Special:Pref... [09:06:25] 10MediaWiki-ResourceLoader, 10MediaWiki-Interface, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1173171 (10aude) and see also T94699 which I am pretty sure is related and likely the same cause. 04:45 < aude> https://gi... [10:12:04] (03PS16) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) [10:12:38] (03PS48) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [10:52:54] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Absolutely positioned template in upper rightmost corner gets drawn through body text (due to custom JS on nl.wp) - https://phabricator.wikimedia.org/T89410#1173363 (10FrankGeerlings) @matmarex It's been a while, but by now I have had a chance to look into it... [11:27:15] (03CR) 10Krinkle: "Well, the it can be both: not part of titles, and magicwords a boolean." (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://bugzilla.wikimedia.org/49996) (owner: 10Alex Monk) [12:43:14] (03PS1) 10Mobrovac: Update citoid submodule to master (4b598a9) [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/201453 [12:44:39] (03CR) 10Mobrovac: [C: 032 V: 032] Update citoid submodule to master (4b598a9) [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/201453 (owner: 10Mobrovac) [13:00:19] (03PS2) 10Bartosz Dziewoński: Properly support LTR/RTL icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201379 (https://phabricator.wikimedia.org/T94560) [13:36:05] (03CR) 10Krinkle: "Fixed in I1198024911660f." [unicodejs] - 10https://gerrit.wikimedia.org/r/197739 (owner: 10Divec) [13:39:38] (03CR) 10Krinkle: "Fixed in Ibf1c230dc." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/191941 (owner: 10Ori.livneh) [13:49:08] 10MediaWiki-ResourceLoader, 7Technical-Debt: Refactor ResourceLoader versioning system to use hashes instead of timestamps - https://phabricator.wikimedia.org/T94074#1173647 (10Aklapper) p:5Triage>3Low [14:04:21] (03CR) 10Bartosz Dziewoński: [C: 032] Only block for errors when saving [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/200478 (https://phabricator.wikimedia.org/T70765) (owner: 10TheDJ) [14:04:47] (03Merged) 10jenkins-bot: Only block for errors when saving [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/200478 (https://phabricator.wikimedia.org/T70765) (owner: 10TheDJ) [14:26:20] 10OOjs-UI, 10UI-Standardization, 5Patch-For-Review: Flags can only be applied to buttons - https://phabricator.wikimedia.org/T93890#1173717 (10matmarex) [14:26:22] 10OOjs-UI: Make OOjs UI IconWidget flaggable so icon variants can be used, the way ButtonElement does - https://phabricator.wikimedia.org/T92023#1173716 (10matmarex) [14:33:03] (03PS1) 10Bartosz Dziewoński: IconWidget: Mix in FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/201466 (https://phabricator.wikimedia.org/T92023) [14:34:43] (03PS3) 10Bartosz Dziewoński: MediaWiki theme: Allow intention flags for non-buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 (https://phabricator.wikimedia.org/T93890) (owner: 10Werdna) [14:34:49] (03CR) 10Bartosz Dziewoński: [C: 032] MediaWiki theme: Allow intention flags for non-buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 (https://phabricator.wikimedia.org/T93890) (owner: 10Werdna) [14:39:13] (03Merged) 10jenkins-bot: MediaWiki theme: Allow intention flags for non-buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/201147 (https://phabricator.wikimedia.org/T93890) (owner: 10Werdna) [14:46:04] 10TemplateData, 3Editing Department 2014/15 Q4 blockers, 7I18n, 5WMF-deploy-2015-04-08_(1.25wmf25): TemplateData: Properties "default" and "deprecated" should be InterfaceText instead of string - https://phabricator.wikimedia.org/T54966#1174011 (10Jdforrester-WMF) 5Open>3Resolved [14:46:16] 10TemplateData, 3Editing Department 2014/15 Q4 blockers, 7I18n, 5WMF-deploy-2015-04-08_(1.25wmf25): TemplateData: Properties "default" and "deprecated" should be InterfaceText instead of string - https://phabricator.wikimedia.org/T54966#555825 (10Jdforrester-WMF) [14:52:53] (03PS9) 10Bartosz Dziewoński: MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [14:53:28] (03CR) 10Jforrester: "Gosh." [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [14:53:30] (03CR) 10Bartosz Dziewoński: "Does not quite work yet, but we're getting there." [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [14:54:04] (03CR) 10Jforrester: [C: 032] Process: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/201393 (owner: 10Kmenger) [14:54:11] (03CR) 10jenkins-bot: [V: 04-1] MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [14:58:17] (03Merged) 10jenkins-bot: Process: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/201393 (owner: 10Kmenger) [15:00:00] (03CR) 10Jforrester: [C: 032] MenuLayout: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/201166 (owner: 10Bartosz Dziewoński) [15:03:10] (03Merged) 10jenkins-bot: MenuLayout: Correct documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/201166 (owner: 10Bartosz Dziewoński) [15:03:20] (03CR) 10Jforrester: [C: 032] IconWidget: Mix in FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/201466 (https://phabricator.wikimedia.org/T92023) (owner: 10Bartosz Dziewoński) [15:03:51] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Make OOjs UI IconWidget flaggable so icon variants can be used, the way ButtonElement does - https://phabricator.wikimedia.org/T92023#1174094 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3matmarex [15:03:56] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Make OOjs UI IconWidget flaggable so icon variants can be used, the way ButtonElement does - https://phabricator.wikimedia.org/T92023#1101717 (10Jdforrester-WMF) [15:04:35] 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 3Editing Department 2014/15 Q4 blockers: Flags can only be applied to buttons - https://phabricator.wikimedia.org/T93890#1174100 (10Jdforrester-WMF) a:3werdna [15:04:48] 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 3Editing Department 2014/15 Q4 blockers: Flags can only be applied to buttons - https://phabricator.wikimedia.org/T93890#1174102 (10Jdforrester-WMF) 5Open>3Resolved [15:04:50] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Make OOjs UI IconWidget flaggable so icon variants can be used, the way ButtonElement does - https://phabricator.wikimedia.org/T92023#1101717 (10Jdforrester-WMF) [15:06:29] (03PS3) 10Bartosz Dziewoński: Properly support LTR/RTL icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201379 (https://phabricator.wikimedia.org/T94560) [15:06:31] (03CR) 10Jforrester: [C: 031] Allow parsefragment even if VE is not enabled for that title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201400 (https://phabricator.wikimedia.org/T94282) (owner: 10Mattflaschen) [15:07:44] (03PS10) 10Bartosz Dziewoński: MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [15:09:07] (03PS11) 10Bartosz Dziewoński: MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [15:09:39] (03CR) 10jenkins-bot: [V: 04-1] Properly support LTR/RTL icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201379 (https://phabricator.wikimedia.org/T94560) (owner: 10Bartosz Dziewoński) [15:11:49] (03CR) 10jenkins-bot: [V: 04-1] MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [15:15:30] Hello. This is your friendly human version of the bot reporting VE diffs which need to be checked. [15:40:45] (03PS7) 10Rits: Assigning width and height to alien extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (https://phabricator.wikimedia.org/T92868) [15:47:22] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Outreachy and GSoC 2015 Proposal for Graph editing in Visual Editor - https://phabricator.wikimedia.org/T93788#1174276 (10Rits) [16:00:04] I just had this weird glitch - I saw the progress bar running backwards O_O [16:00:37] I saw that a few times [16:00:39] very strange [16:00:59] * Elitre facepalms [16:01:11] can I report it? no idea how to reproduce though. [16:02:08] 10VisualEditor, 10VisualEditor-DataModel, 7Verified-in-Phase2, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Whitespace-only headings should be collapsed to (blank) paragraphs - https://phabricator.wikimedia.org/T51452#1174343 (10NicoV) It doesn't seem to be fixed in 1.25wmf23. Edit from 17 hours ago o... [16:03:14] ?sdrawkcab gniog ,naem uoy od tahW :ertilE [16:03:30] ori :p [16:11:47] changing a letter to uppercase proves difficult :/ https://az.wikipedia.org/w/index.php?title=Kardinal_Ri%C5%9Felye&curid=36076&diff=3233937&oldid=3233935 [16:14:42] ELITRE: WHAT DO YOU MEAN, DIFFICULT? ;) [16:14:59] sorry, i haven't had coffee yet [16:15:50] :p I'll bring more coffee chocolates next time I'm in SF. [16:18:43] Elitre: I'm not sure we can take more chocolate; we already have too much. :-) [16:19:53] I'm expecting ori to ask you "what do you mean, too much?". I don't know that you can have "too much", when it comes to chocolate. [16:20:35] * James_F laughs. [16:20:45] MatmaRex: Did you see the npm failure on https://gerrit.wikimedia.org/r/#/c/201379/ ? Want me to fix? [16:21:08] James_F: yes, no. i'm fixing [16:21:13] OK, [16:27:03] MatmaRex: What's the point of the noimages CSS file? [16:28:06] MatmaRex: Because there's no pack for indicators.json or textures.json so we can't load oojs-ui-mediawiki-noimages and then each of the icon packs. [16:29:05] James_F: oh, hmm [16:29:40] yeah. that was silly. [16:29:47] Just dump them? [16:29:57] hm? [16:30:23] Should we just delete oojs-ui-{apex,mediawiki}-noimages? [16:30:57] James_F: the problem that was intended to solve was that oojs-ui-mediawiki.css has the icon stuff appended, and can't be just put through CSSJanus because that would ruin them. but we can probably also solve it with some @noflips. [16:31:08] * James_F nods. [16:31:57] https://phabricator.wikimedia.org/T94731 was also about that; but it won't actually work anyway, i just realized [16:32:13] :-( [16:33:17] so i guess the core icons/indicators/textures will just have to come with the CSS [16:33:25] Yeah. [16:34:12] hmph. [16:35:59] ugh, that really will not work well either [16:36:15] we won't be able to add the .mw-ui-icon selectors, for example [16:36:27] and language-specific icons will also be more problematic [16:37:08] (are nowikis really necessary here? https://ba.wikipedia.org/w/index.php?title=%D0%AB%D1%80%D1%8B%D1%83%D0%BB%D1%8B%D2%A1&curid=83174&diff=478879&oldid=478876 I remember this was discussed a lot in the past, but can't recall the reasoning.) [16:37:27] MatmaRex: Yeah. [16:40:33] (03CR) 10Esanders: [C: 04-1] "Looks good. Needs some code style cleanup and some refactoring to remove duplicate CSS." (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [16:42:25] (03PS12) 10Bartosz Dziewoński: MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [16:42:27] (03PS4) 10Bartosz Dziewoński: Properly support LTR/RTL icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201379 (https://phabricator.wikimedia.org/T94560) [16:42:29] (03PS1) 10Bartosz Dziewoński: Support per-language icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201486 [16:43:07] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Too naive, proof of concept." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201486 (owner: 10Bartosz Dziewoński) [16:47:11] James_F: eh, we could just split 'oojs-ui.styles' RL module. [16:47:23] MatmaRex: Yes. [16:47:30] MatmaRex: Breaking change, but… [16:47:34] James_F: not really breaking. [16:47:41] James_F: loading 'oojs-ui' will work as before. [16:47:50] If we change the output files it won't. [16:48:08] James_F: and you're supposed to use OutputPage::enableOOUI() to load the styles for PHP, and we can modify that. [16:48:39] * James_F nods. [16:48:50] James_F: why would it not work as before? [16:49:49] this will not be as pretty as i would like, maybe, but it should still be solid. [16:50:47] Maybe it's OK. [16:52:03] 10MediaWiki-ResourceLoader, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Must be able to combine ResourceLoaderImageModule's icon CSS and regular CSS files in one module - https://phabricator.wikimedia.org/T94731#1174519 (10matmarex) 5Open>3declined Actually, this won't help for this use c... [16:52:06] 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1174521 (10matmarex) [16:54:54] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/201400/ [16:55:21] (03CR) 10Catrope: [C: 032] Allow parsefragment even if VE is not enabled for that title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201400 (https://phabricator.wikimedia.org/T94282) (owner: 10Mattflaschen) [16:55:41] (03PS1) 10Jforrester: Allow parsefragment even if VE is not enabled for that title [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/201488 (https://phabricator.wikimedia.org/T94282) [16:55:48] (03CR) 10Jforrester: [C: 032] Allow parsefragment even if VE is not enabled for that title [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/201488 (https://phabricator.wikimedia.org/T94282) (owner: 10Jforrester) [16:55:50] (03CR) 10Bartosz Dziewoński: "Or maybe not. It will work for OOjs UI itself; but it's not extensible for anything cleverer. I don't really feel like putting any more wo" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201486 (owner: 10Bartosz Dziewoński) [16:57:13] (03PS2) 10Bartosz Dziewoński: Support (poorly) per-language icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201486 [16:57:19] whatever. [16:57:22] :-D [16:58:13] (03PS3) 10Bartosz Dziewoński: Support (poorly) per-language icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201486 (https://phabricator.wikimedia.org/T76539) [16:58:24] (03Merged) 10jenkins-bot: Allow parsefragment even if VE is not enabled for that title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201400 (https://phabricator.wikimedia.org/T94282) (owner: 10Mattflaschen) [16:58:48] 10VisualEditor, 6Collaboration-Team, 10Flow, 5Patch-For-Review: Way for VE to run on Flow without changing wgVisualEditorNamespaces - https://phabricator.wikimedia.org/T94282#1174545 (10Mattflaschen) 5Open>3Resolved [16:58:48] (03Merged) 10jenkins-bot: Allow parsefragment even if VE is not enabled for that title [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/201488 (https://phabricator.wikimedia.org/T94282) (owner: 10Jforrester) [16:59:12] (03CR) 10Mooeypoo: Assigning width and height to MWAlienNodes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [16:59:22] James_F: when are we doing next OOUI release? i'd like to actually put all this stuff i wrote into use after we do that. [17:00:30] 10VisualEditor, 6Collaboration-Team, 10Flow, 5Patch-For-Review: Way for VE to run on Flow without changing wgVisualEditorNamespaces - https://phabricator.wikimedia.org/T94282#1174557 (10Jdforrester-WMF) [17:01:57] (03PS13) 10Bartosz Dziewoński: MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [17:07:19] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 9 others: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#1174581 (10ssastry) [17:13:03] MatmaRex: As soon as https://gerrit.wikimedia.org/r/#/c/143407/ lands later this morning? ;-) [17:13:30] ha. okay. [17:13:57] (03Abandoned) 10Catrope: ce.ContentBranchNode: Prevent setupSlugs() from being called twice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/193787 (https://phabricator.wikimedia.org/T91245) (owner: 10Catrope) [17:14:14] (03PS2) 10Bartosz Dziewoński: IconWidget: Mix in FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/201466 (https://phabricator.wikimedia.org/T92023) [17:14:28] (03CR) 10Bartosz Dziewoński: [C: 032] IconWidget: Mix in FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/201466 (https://phabricator.wikimedia.org/T92023) (owner: 10Bartosz Dziewoński) [17:14:31] edsanders: So that branch/inline slug split commit you did, did that fix the bug where setupSlugs is called twice on CBNs during the init phase? [17:14:33] MatmaRex: Aka Trevor's problem. [17:14:37] MatmaRex: Self-+2? [17:14:47] edsanders: I think the answer is probably yes, just checking [17:14:53] MatmaRex: Oh, to kick it through. [17:14:55] James_F: no, just poking Jenkins. [17:14:59] * James_F nods. [17:16:34] RoanKattouw, yes [17:17:26] (03Merged) 10jenkins-bot: IconWidget: Mix in FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/201466 (https://phabricator.wikimedia.org/T92023) (owner: 10Bartosz Dziewoński) [17:21:22] MatmaRex, so, the RTL issue only happens with button popups -- specifically, the ones that are used for the 'help' popup in forms, like in the template dialog. It doesn't happen in general popups or menus like in the category dropdowns. [17:21:34] MatmaRex, is there something uniquely different between those two ? [17:22:28] I assume it's their wrappers, but I'm going to have to see how to recognize either to fix it [17:22:47] mooeypoo: i have no idea, but i'll try figuring this out in an hour or so if you want me to [17:23:04] i'm finishing up icons stuff [17:23:14] MatmaRex, I'm working on this for now, so you don't have to. I thought you might have an idea off the top of your head what the difference is. [17:23:19] I'll let you know if I get too stuck with it [17:23:38] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): setupSlugs is called twice during ContentBranchNode setup - https://phabricator.wikimedia.org/T91245#1174671 (10Jdforrester-WMF) 5Open>3Resolved [17:23:40] oh, alright. sorry, dunno :( [17:23:40] I have a feeling I know what it is, but I'll check into it. [17:24:00] 10VisualEditor, 10VisualEditor-DataModel, 7Verified-in-Phase2, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Whitespace-only headings should be collapsed to (blank) paragraphs - https://phabricator.wikimedia.org/T51452#1174676 (10Catrope) >>! In T51452#1174343, @NicoV wrote: > It doesn't seem to be fix... [17:24:04] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1174677 (10Jdforrester-WMF) p:5Triage>3High [17:26:36] Elitre: Best I can tell, https://ba.wikipedia.org/w/index.php?title=%D0%AB%D1%80%D1%8B%D1%83%D0%BB%D1%8B%D2%A1&curid=83174&diff=478879&oldid=478876 was probably user error [17:27:44] Elitre: If the user explicitly selects |Foo|bar and creates a link, VE will emit [[Foo]]bar; if you just have a blinking cursor like Fo|obar and create a link, we do select the entire word so you end up with [[Foobar]] [17:28:05] Elitre: https://az.wikipedia.org/w/index.php?title=Kardinal_Ri%C5%9Felye&curid=36076&diff=3233937&oldid=3233935 is bad though [17:28:36] I think what happened there is the user tried to replace the 'g' with 'G', but typing at the beginning of a link doesn't link the text, that only happens on the inside or at the end (I hate this) [17:29:01] So they tried to link the G separately, probably by selecting it, and we apparently failed to merge the two links [17:33:01] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Write some easy user-facing documentation on how to enable and configure auto-filled citations on your wiki - https://phabricator.wikimedia.org/T94864#1174702 (10Jdforrester-WMF) 3NEW [17:34:40] (03Abandoned) 10Jforrester: Assigning width and height to alien extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200945 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [17:44:40] 10VisualEditor, 10VisualEditor-Performance, 10RESTBase, 3Editing Department 2014/15 Q4 blockers: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1174745 (10Jdforrester-WMF) [17:45:11] 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: mw:WikiLink with fully resolved url doesn't serialize to the right piped wikilink syntax - https://phabricator.wikimedia.org/T94723#1174749 (10Jdforrester-WMF) p:5Normal>3High [17:45:54] (03PS4) 10Bartosz Dziewoński: Support (poorly) per-language icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201486 (https://phabricator.wikimedia.org/T76539) [17:45:56] (03PS14) 10Bartosz Dziewoński: MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [17:53:53] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7Epic: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1174794 (10Arlolra) a:3Arlolra [17:56:03] 10OOjs-UI: Popups are not positioned correctly in RTL - https://phabricator.wikimedia.org/T94783#1174808 (10matmarex) [17:56:16] RoanKattouw, why are we do horrible handlesOwnChildren hacks with headings? It looks a lot like a wikitext problem [17:56:53] edsanders: I wouldn't mind filing a bug with Parsoid asking them to solve the problem on their end, then removing MWHeading [17:57:05] But we were able to do it in VE so we did [18:01:26] MatmaRex: howdy [18:01:40] jenkins isn't happy with https://gerrit.wikimedia.org/r/#/c/201495/ - do you know what's up there [18:01:42] ? [18:01:51] hi [18:01:54] i'm looking [18:03:21] bah, it's because i wrote it wrong. [18:03:48] lol... that's a pretty generic diagnosis [18:03:50] :) [18:09:12] (03CR) 10Trevor Parscal: [C: 032] Support (poorly) per-language icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201486 (https://phabricator.wikimedia.org/T76539) (owner: 10Bartosz Dziewoński) [18:09:21] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 7Verified-in-Phase2: Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of undefined" - https://phabricator.wikimedia.org/T71119#1174852 (10Etonkovidova) [18:09:29] (03CR) 10Trevor Parscal: [C: 032] Properly support LTR/RTL icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201379 (https://phabricator.wikimedia.org/T94560) (owner: 10Bartosz Dziewoński) [18:10:50] 10MediaWiki-ResourceLoader, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Must be able to combine ResourceLoaderImageModule's icon CSS and regular CSS files in one module - https://phabricator.wikimedia.org/T94731#1174859 (10matmarex) [18:12:04] 10WikiEditor, 7Easy, 5Patch-For-Review: Convert ext.wikiEditor.tests.toolbar to QUnit - https://phabricator.wikimedia.org/T39485#1174860 (10Mattflaschen) a:5TheDJ>3happy5214 [18:12:36] MatmaRex: with https://gerrit.wikimedia.org/r/#/c/201266/4 could we do some thinking around throwing errors if people are using an RLIM for scripts - or are we thinking it's OK to just trust people to not do crazy things? [18:13:48] TrevorParscal: yeah, i'm not sure myself. there's nothing that would make doing what you just said impossible, and perhaps there are sensible situations where it would be useful. i'm wondering if we want to support that. [18:14:13] TrevorParscal: i was hoping you/timo/roan would give that and the next patch a think [18:14:21] (03CR) 10Trevor Parscal: [C: 032] MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [18:14:41] TrevorParscal: it can wait for a few days if need be, we don't need it right now anyway. [18:14:50] for sure - I'll consult with them and get back to you [18:15:02] (the followup too, if nothing broke in prod because of that yet, then nothing will if we wait a week) [18:15:53] heh, danger :D [18:17:54] (03PS4) 10Mobrovac: Change how pubmed and pmcs are requested [services/citoid] - 10https://gerrit.wikimedia.org/r/200314 (https://phabricator.wikimedia.org/T93335) (owner: 10Mvolz) [18:18:07] (03CR) 10Trevor Parscal: [C: 04-1] "I love and hate this simultaneously - we need to think it over a bit." [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott) [18:22:39] (03CR) 10Cscott: "Well, as far as I understand it, all of /elements is intended to be Mixins. And the /elements classes aren't typically used, unless you a" [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott) [18:22:48] (03Merged) 10jenkins-bot: Properly support LTR/RTL icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201379 (https://phabricator.wikimedia.org/T94560) (owner: 10Bartosz Dziewoński) [18:22:50] (03Merged) 10jenkins-bot: Support (poorly) per-language icon versions in colorize-svg.js [oojs/ui] - 10https://gerrit.wikimedia.org/r/201486 (https://phabricator.wikimedia.org/T76539) (owner: 10Bartosz Dziewoński) [18:28:08] (03CR) 10Mobrovac: [C: 032 V: 032] "Fixed the code-duplication issues, so it's good to go now." [services/citoid] - 10https://gerrit.wikimedia.org/r/200314 (https://phabricator.wikimedia.org/T93335) (owner: 10Mvolz) [18:32:55] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 10 others: Use Parsoid HTML for read-only views too - https://phabricator.wikimedia.org/T55784#1174959 (10gpaumier) [18:34:55] (03Merged) 10jenkins-bot: MediaWiki, Apex: Provide an RTL variant for the help icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (https://phabricator.wikimedia.org/T76540) (owner: 10Jforrester) [18:43:04] 10MediaWiki-ResourceLoader, 10MediaWiki-Interface, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175007 (10Jdlrobson) and possibly also causing T94518 [18:43:58] 10MediaWiki-ResourceLoader, 10Gather, 10MediaWiki-Interface, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175009 (10Jdlrobson) [18:45:37] 10MediaWiki-ResourceLoader, 10Gather, 10MediaWiki-Interface, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175019 (10Jdlrobson) a:3Jdlrobson I've put this on the swat deploy calendar: https://wi... [18:46:32] 10MediaWiki-ResourceLoader, 10Gather, 10MediaWiki-Interface, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175029 (10matmarex) Ugh, you're not supposed to use $wgResourceModuleSkinStyles in extens... [18:48:23] 10MediaWiki-ResourceLoader, 10Gather, 10MediaWiki-Interface, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175039 (10Jdlrobson) Yay hooks and globals! ;-) Sounds like another task to prevent exten... [18:49:18] 10MediaWiki-ResourceLoader, 10Gather, 10MediaWiki-Interface, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175041 (10matmarex) MobileFrontend is probably within its rights to do it, since it has t... [18:51:00] 10MediaWiki-ResourceLoader, 10Gather, 10MediaWiki-Interface, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175044 (10Jdlrobson) ... yeh but we should at least have some kind of wrapper for this. I... [18:51:45] 10MediaWiki-ResourceLoader, 10Gather, 10MediaWiki-Interface, 5Patch-For-Review, 7Regression: Special:Preferences is missing Vector styles for mediawiki.special.preferences - https://phabricator.wikimedia.org/T93050#1175046 (10matmarex) [18:54:34] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, 7RESTBase-API: Thoughts on element IDs, sections, incremental parsing and fast section editing - https://phabricator.wikimedia.org/T87556#1175060 (10GWicke) We just discussed this a bit on IRC. As a first step, we agreed that it... [18:58:56] edsanders:I used populateMenu() in https://gerrit.wikimedia.org/r/#/c/198779/ to run many times to modify pulral in delete row|column.But as you pointed it out,why cant we use it multiple times ? [19:00:07] can i use setinterval to hook populatemenu with table selection [19:02:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, and 4 others: Create a guided tour for VisualEditor using GuidedTour guiders - https://phabricator.wikimedia.org/T89074#1175115 (10gpaumier) [19:03:03] 10VisualEditor, 10Wikimedia-Site-requests, 3Editing Department 2014/15 Q4 blockers, 7Epic, and 3 others: Run test of having VisualEditor on for some newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90666#1175118 (10gpaumier) [19:03:25] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7Epic: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1175120 (10GWicke) @arlolra, should we aim for storing wikitext & html variants separately right from the start? [19:05:49] 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 3Roadmap, and 2 others: Be able to re-order the columns or rows of a table by dragging them to another position in VisualEditor - https://phabricator.wikimedia.org/T88694#1175126 (10gpaumier) [19:16:43] 10Citoid, 6Services: Google Books translator offering less information than expected - https://phabricator.wikimedia.org/T94169#1156707 (10Whatamidoing-WMF) I am happy to confirm that this is working well for me at the English Wikipedia. Thank you! [19:20:44] mooeypoo: hello :) , the other commit in which the changes was done is abandoned as a duplicate , so i have to make changes to the previous patchset and add the required changes [19:22:00] mooeypoo: i made the changes to this https://gerrit.wikimedia.org/r/#/c/200945/ , do i commit the changes to the previous patchset [19:46:11] mooeypoo: i am having some git issues i tried to rework the code for this patchset https://gerrit.wikimedia.org/r/#/c/198397/ as the other one was marked duplicate, this branch is showing changes to lib/ve [20:01:13] (03PS5) 10Rits: Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) [20:01:18] (03CR) 10jenkins-bot: [V: 04-1] Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [20:03:21] mooeypoo: please see to this patchset whenever possible https://gerrit.wikimedia.org/r/#/c/198397/ , when i pushed the changes jenkins bot comments to rebase the change when i try to do it , it gives a error [20:11:12] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: Create an API for retrieval and saving of top-level HTML elements by element ID - https://phabricator.wikimedia.org/T94890#1175324 (10GWicke) 3NEW [20:11:40] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements by element ID - https://phabricator.wikimedia.org/T94890#1175334 (10GWicke) [20:14:36] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements by element ID - https://phabricator.wikimedia.org/T94890#1175349 (10GWicke) [20:15:17] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, and 4 others: S5. Flow: Integrate VE toolbar in Flow entry fields - https://phabricator.wikimedia.org/T90764#1175351 (10DannyH) 5Open>3Resolved This is live on Mediawiki now. [20:28:33] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review: Toolbar should appear to be within text area - https://phabricator.wikimedia.org/T94112#1175407 (10DannyH) 5Open>3Resolved Looks beautiful. [20:28:36] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, and 4 others: S5. Flow: Integrate VE toolbar in Flow entry fields - https://phabricator.wikimedia.org/T90764#1175409 (10DannyH) [20:29:58] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements by element ID - https://phabricator.wikimedia.org/T94890#1175412 (10GWicke) [20:31:37] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements by element ID - https://phabricator.wikimedia.org/T94890#1175324 (10GWicke) [20:38:43] 10VisualEditor, 10VisualEditor-DataModel, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Cutting (removing) last section on the page leaves blank section heading == == - https://phabricator.wikimedia.org/T61647#1175472 (10Etonkovidova) [20:41:44] (03CR) 10Esanders: Create a preview widget (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [20:42:00] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements by element ID - https://phabricator.wikimedia.org/T94890#1175503 (10GWicke) [20:46:04] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7Epic: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1175519 (10Arlolra) @GWicke: can you clarify what you mean? [20:46:08] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements by element ID - https://phabricator.wikimedia.org/T94890#1175520 (10GWicke) [20:46:54] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers: Be able to convert DOM->data differently for paste data vs initial conversion - https://phabricator.wikimedia.org/T94724#1175523 (10Catrope) [20:47:21] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7Epic: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1175524 (10GWicke) @arlolra, storing `data-mw-wt` and `data-mw-html` separately. The 'wt' variant would have all template parameters etc as wikitext, while... [20:48:44] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Strip annotations (e.g. bold, italics, link) from terminal whitespace - https://phabricator.wikimedia.org/T54037#1175533 (10Catrope) [20:49:12] (03PS1) 10Catrope: Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) [20:49:14] (03PS3) 10Jforrester: Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 [20:49:23] 10OOjs-UI, 10MediaWiki-extensions-Collection, 7Wikimedia-log-errors: Potentially unsafe "href" attribute value - https://phabricator.wikimedia.org/T94900#1175537 (10demon) 3NEW [20:49:57] (03CR) 10Jforrester: "PS3 is a rebase onto the new stack of how to actually do this, which theoretically makes this mergeable (if only it worked)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 (owner: 10Jforrester) [20:50:10] (03PS2) 10Catrope: Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) [20:50:12] (03CR) 10jenkins-bot: [V: 04-1] Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 (owner: 10Jforrester) [20:50:17] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7Epic: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1175552 (10Arlolra) Oh, ok, you're talking template parameters. Is it desirable to offer the two varieties in the long run? Or is this change a spec version... [20:50:19] MatmaRex: I have no idea why https://gerrit.wikimedia.org/r/#/c/196512/ is failing (it's probably because I'm a moron). [20:50:49] * MatmaRex looks [20:51:10] 10VisualEditor, 10VisualEditor-DataModel, 7Verified-in-Phase2, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Whitespace-only headings should be collapsed to (blank) paragraphs - https://phabricator.wikimedia.org/T51452#1175553 (10NicoV) No other edits with `====` for the moment, I will send an... [20:52:24] (03CR) 10jenkins-bot: [V: 04-1] Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [20:52:59] James_F: hmm. i think it's because i'm a moron. will fix in a minute. [20:53:08] MatmaRex: :-D [20:53:22] MatmaRex: I doubt it very much. [20:53:22] (03CR) 10Catrope: [C: 04-1] "Breaks a bunch of tests, and also needs tests of its own" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [20:54:31] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7Epic: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1175567 (10GWicke) @arlolra, `data-mw-wt` would basically be what Parsoid returns right now in production, so no need for clients to change. There is alread... [20:54:53] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 5WMF-deploy-2015-03-25_(1.25wmf23): Can't copy a single node selection (e.g. template / media / reference) in Safari - https://phabricator.wikimedia.org/T72143#1175571 (10Etonkovidova) Re-checked the... [20:56:53] (03PS1) 10Jforrester: Tag v0.9.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201586 [20:57:57] (03PS4) 10Bartosz Dziewoński: Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 (owner: 10Jforrester) [20:57:59] (03PS1) 10Bartosz Dziewoński: Make colorize-svg.js actually work more often [oojs/ui] - 10https://gerrit.wikimedia.org/r/201587 [20:58:16] James_F: that fixes the code issue. also, you need to specify full paths rather than just file name. :( [20:58:26] MatmaRex: Oh, did I miss some? No worries. [20:59:02] (03CR) 10jenkins-bot: [V: 04-1] Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 (owner: 10Jforrester) [20:59:30] MatmaRex, TrevorParscal I just want to make sure I understood the construct of PopupWidget correctly before I start recalculating a lot of stuff -- this.$popup is the popup itself; this.$container is whatever context container we're in -- either the whole document or the dialog, and this$element is the button that the popup springs out of and is also where the indicator is positioned against. Am I right? [20:59:37] (03CR) 10Catrope: [C: 032] Make colorize-svg.js actually work more often [oojs/ui] - 10https://gerrit.wikimedia.org/r/201587 (owner: 10Bartosz Dziewoński) [20:59:56] (03CR) 10Catrope: "20:59:01 Warning: Unable to read "src/themes/mediawiki/bold-a.svg" file (Error code: ENOENT). Use --force to continue." [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 (owner: 10Jforrester) [21:00:20] mooeypoo: PopupWidget or PopupButtonWidget? [21:00:34] i'm fairly sure no one really understands these, by the way [21:00:37] MatmaRex, PopupWidget [21:00:45] I'm working on OO.ui.PopupWidget.prototype.updateDimensions [21:00:51] ^^ that isn't adjusted to RTL at all [21:01:06] it should be. I'm working on that, but in order to do that, I want to make sure I have all the elements correctly [21:01:46] MatmaRex, there's a bunch of calculation going on there involving this.$popup, this.$container and this.$element [21:01:58] with their offsets and widths [21:02:36] mooeypoo: hmm. i thought the caller is supposed to pass "pre-flipped" 'align' config option. [21:02:39] anyway, let's see [21:02:50] MatmaRex, no, even if it is it won't work [21:03:03] because the containers are attached to the opposite corners. The calculations are all whack in RTL [21:04:02] I'm mostly concerned with what this.$element is. That is where the popup is anchoring itself to, yes? Seeing as PopupButtonWidget is inheriting from that [21:04:07] so. this.$popup is the popup itself, indeed. this is the popup body, the anchor is a sibling to this. [21:04:15] (03Merged) 10jenkins-bot: Make colorize-svg.js actually work more often [oojs/ui] - 10https://gerrit.wikimedia.org/r/201587 (owner: 10Bartosz Dziewoński) [21:04:24] sorry, not inheriting, it's inheriting from PopupElement which *creates* a popup [21:04:27] this is so confusing [21:04:43] MatmaRex, so in the context of PopupWidget, what's this.$element [21:04:55] this.$container is the closest scrollable container. the popup will be clipped against its dimensions. this probably has to be the dialog, yes. [21:05:12] this.$element is some crappy wrapper; this is *not* the button [21:05:14] yep, it's either the dialog or the window, depending on the context we're in. [21:05:22] MatmaRex, okay, define "crappy container" [21:05:29] we're using a calculation of its offset [21:05:43] originOffset = this.$element.offset().left; [21:05:51] ^^ what is that in relation to the popup? [21:06:36] MatmaRex, okay, so, i think i see another issue here [21:06:43] (i'm figuring it out, one sec) [21:06:57] in PopupButtonWidget we're taking this.popup.$element and attaching it to the PopupButtonWidget's $element [21:07:28] RoanKattouw: since the scroll event triggered by jquery looks like it is causing the problem I'm having with IE, how do I disable it to test this. Something like preventDefault? [21:07:49] It's an extra wrapper div. I am just not sure why we count it into the calculation [21:07:51] * hexmode goes to poke at jquery and preventDefault for events [21:08:01] unless the positioning of the popup itself is against that wrapper [21:08:09] which... is.... annoying. [21:08:15] okay [21:08:25] hexmode: Where? [21:08:40] the purpose of this.$element is that the popup's anchor will point at the $element's top-left corner. [21:08:42] hexmode: Generally, jQuery event handlers take an Event object that you can call .preventDefault() on [21:08:52] $(thing).on( 'scroll', function ( e ) { e.preventDefault(); } ); [21:08:53] in the handler for bullets... which by the way I don't know how to find [21:08:57] MatmaRex, so it doesn't affect the popup positioning *itself* just the anchor? [21:08:58] so you can position this.$element with CSS and the popup will point exactly there. [21:09:14] oh oh okay because the anchor and popup are siblings, you need something to wrap them [21:09:15] RoanKattouw: I see commandName = "bullet", but now where do I look? [21:09:36] mooeypoo: hmmmm. probably? [21:09:43] MatmaRex, okay, the only question now is, though, why do we calculate different things between this.$popup and this.$element [21:09:57] (for the implementation of the commandName) [21:09:58] mooeypoo: there's also this: https://phabricator.wikimedia.org/T73644 [21:09:59] shouldn't their offset and left values be the same? [21:10:10] the calculations are messed up because we calculate where the anchor is supposed to point [21:10:18] and then position the body in relation to the anchor [21:10:25] I see [21:10:42] hexmode: commandName='bullet' maps to something in CommandRegistry [21:10:51] hexmode: Which will probably end up sending you to something in ContentAction [21:11:07] MatmaRex, ahha. [21:11:21] ah... commandregistry... digging in [21:11:21] MatmaRex, okay, so ideally, I'll position this.$element where it needs to go [21:11:28] hexmode: ve.ui.ListAction#toggle [21:11:56] and then bother with the anchor inside that div [21:12:18] mooeypoo: hmm, no, probably not this.$element? [21:12:25] this.$element is supposed to already be where it needs to be [21:12:36] MatmaRex, uhm, not if it's going outside the window [21:12:38] ? [21:12:50] it's not the $element, it's the $body [21:12:51] i think [21:13:06] sorry [21:13:08] the $popup [21:13:22] it's not the $element, it's the $popup * [21:13:24] * mooeypoo is confused [21:13:42] so position the popup and then make the anchor go relative to it? [21:13:45] but the anchor is a sibling [21:14:33] MatmaRex, okay hang on i think i got it [21:15:12] this.$element is where the popup needs to appear, but then depending on the size of the window and this.align the popup may be edging outside the view, which we are then fixing with margin-left corrections [21:15:27] ok this whole thing is really confusing calculation. [21:15:54] MatmaRex, since i'm about to work on this anyways, I might as well also deal with that bug you pointed to [21:17:19] confusing it is [21:17:41] MatmaRex, in the CSS file, we have this: [21:17:56] .oo-ui-popupWidget { [21:17:57] position: absolute; /* @noflip */ left: 0; ... [21:18:31] Is there a reason why noflip is there? just to force the calculations all LTR'ed ? [21:19:30] yeah. the entire thing only deals with 'left' and 'margin-left' regardless of directionality [21:19:42] yeah [21:19:46] ok i'll work it out [21:19:59] hopefully without getting my brain on the table [21:21:13] mooeypoo: this has at least one RTL bug though [21:21:21] 10VisualEditor, 10VisualEditor-ContentEditable: Deleting from an empty paragraph to the end of an inline node throws an exception - https://phabricator.wikimedia.org/T72375#1175720 (10Etonkovidova) Re-checked with 1.25wmf24 (32a0b3f). The fix works reasonably well - just make sure that the table is selected al... [21:21:26] mooeypoo: look at .theme-oo-ui-popupButtonWidget () { … } in both Apex and MediaWiki [21:21:45] mooeypoo: there's a 'left:' there that should be @noflipped also [21:21:54] (i think…) [21:22:13] MatmaRex, right now, RTL works by accident. [21:22:14] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0: Deleting from an empty paragraph to the end of an inline node throws an exception - https://phabricator.wikimedia.org/T72375#1175723 (10Etonkovidova) [21:22:24] I'm going to try and make it work by design -- by making things flip again. [21:22:28] mooeypoo: hmmmmmmmm [21:23:30] mooeypoo: okay, this is magic [21:23:48] mooeypoo: when you have VE's UI open on some dialog where you see the issue [21:23:55] MatmaRex, black magick with dancing flames [21:24:01] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0, 7Verified-in-Phase2: Deleting from an empty paragraph to the end of an inline node throws an exception - https://phabricator.wikimedia.org/T72375#751785 (10Etonkovidova) [21:24:07] mooeypoo: inspect the
[21:24:23] mooeypoo: and change 'right: 1em;' to 'left: 1em' [21:24:30] I did [21:24:34] and presto, works perfectly [21:24:38] i have no idea why [21:24:40] yes, EXCEPT [21:24:57] I can tell you why -- the calculations were backwards so it didn't work -- you flipped the origin and now it works [21:25:07] BUT if you flip the origin *in advance* then the calculations are all wrong [21:25:12] hence flipping the code, too [21:25:25] if only it was that easy.... [21:26:14] this might be by design [21:26:18] this is a work of some twisted mind [21:26:30] MatmaRex, if you mentally switch the word "right" to "START" and "left" to "END" in the variable names you can see what the issue is [21:26:33] ed's, i think [21:26:34] generally, at least [21:26:38] or possibly roan's [21:27:07] ha. I doubt it's roan [21:27:18] though if it's ed, I'd be surprised. He's usually very good in RTLizing. [21:27:26] I think it was Trevor's [21:27:28] In any case this is somewhat of a regression [21:27:36] But yeah the secret is knowing to flip (or not flip) the origin [21:27:41] That makes a lot of RTL problems easier [21:27:47] we used to have convoluded code that did exactly these flips. In fact, I distinctly remember working on it 2 years ago :D [21:28:11] mooeypoo: Yes, and I removed half of it after adding a single /* @noflip */ in what eventually became WindowManager :) [21:28:12] i can't figure out how this has ever worked [21:28:16] It also explains why popups accidentally worked in the main window but not in dialogs [21:28:23] MatmaRex, it didn't [21:28:26] not in this current incarnation [21:28:32] But maybe that or something like it then broke this code [21:28:34] it just *accidentally* worked when popups were outside of dialogs [21:28:36] it did some months ago [21:28:42] that was the previous code [21:28:43] context [21:29:59] (03CR) 10Cscott: [C: 04-2] "Self -2'ing for revision." [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott) [21:32:13] (03CR) 10Bartosz Dziewoński: "GroupWidget and ItemWidget and going to die soon, by the way. As soon as I get a chance to kill them. There's a bug for this somewhere." [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott) [21:33:37] mooeypoo: eh [21:33:41] i am still not convinced [21:34:01] i think all of the calculations are correct for both LTR and RTL, even if they don't make sense. [21:34:13] it's that 'left: 1em' mucking things [21:35:18] mooeypoo: and the fact that PopupWidget 'align' is specified as left/right and not flipped automatically, so you end up getting different effect when everything else gets flipped [21:35:45] mooeypoo: i'll submit something for you to test out in a few minutes [21:42:30] (03CR) 10Cscott: "According to Trevor, the filename should be just `mixin.js`, since the oo.ui. is elided (unlike in VE)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott) [21:43:46] (03PS5) 10Jforrester: Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 [21:44:10] (03CR) 10Trevor Parscal: [C: 032] Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 (owner: 10Jforrester) [21:46:22] (03CR) 10jenkins-bot: [V: 04-1] Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 (owner: 10Jforrester) [21:47:39] (03PS6) 10Jforrester: Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 [21:49:18] (03CR) 10Trevor Parscal: [C: 032] Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 (owner: 10Jforrester) [21:52:18] (03Merged) 10jenkins-bot: Bring in remaining VisualEditor icons for Apex and MediaWiki themes [oojs/ui] - 10https://gerrit.wikimedia.org/r/196512 (owner: 10Jforrester) [21:57:08] (03PS2) 10Jforrester: Tag v0.9.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201586 [22:01:12] RoanKattouw: after endless tweaking, I finally got IE to not skip around. So I know where the problem is... now to try and fix it. [22:06:18] well, maybe not. But the screen didn't jump! [22:07:30] i see you guys cherry picked and merged the VE API parsefragment adjustment for us into 1.25wmf24, but its not in wikitech for todays SWAT. Mind if i put together a core bump and add it?. [22:07:55] i'm referring to T94282 / Id3ee4dfb [22:15:09] (03CR) 10Krinkle: Tag v0.9.5 (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/201586 (owner: 10Jforrester) [22:15:45] (03PS2) 10Krinkle: build: Re-assert ES3 compatibility [oojs/core] - 10https://gerrit.wikimedia.org/r/192969 (owner: 10Jforrester) [22:17:03] (03CR) 10jenkins-bot: [V: 04-1] build: Re-assert ES3 compatibility [oojs/core] - 10https://gerrit.wikimedia.org/r/192969 (owner: 10Jforrester) [22:18:40] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: ButtonSelectWidget icon/indicator issues in MediaWiki theme - https://phabricator.wikimedia.org/T94199#1175980 (10Jdforrester-WMF) [22:18:46] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: ButtonSelectWidget icon/indicator issues in MediaWiki theme - https://phabricator.wikimedia.org/T94199#1157362 (10Jdforrester-WMF) [22:19:15] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: ButtonSelectWidget broken in Apex theme - https://phabricator.wikimedia.org/T94202#1175985 (10Jdforrester-WMF) p:5Triage>3High [22:19:21] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: ButtonSelectWidget broken in Apex theme - https://phabricator.wikimedia.org/T94202#1157390 (10Jdforrester-WMF) [22:19:56] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Icon-only framed buttons are asymmetrical by one pixel - https://phabricator.wikimedia.org/T91523#1175990 (10Jdforrester-WMF) 5Open>3Resolved a:3matmarex [22:20:01] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Icon-only framed buttons are asymmetrical by one pixel - https://phabricator.wikimedia.org/T91523#1089187 (10Jdforrester-WMF) [22:20:14] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: indicator missing from ButtonSelectWidget (MediaWiki skin) - https://phabricator.wikimedia.org/T92553#1175999 (10Jdforrester-WMF) [22:20:22] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: indicator missing from ButtonSelectWidget (MediaWiki theme) - https://phabricator.wikimedia.org/T92553#1176001 (10Jdforrester-WMF) [22:20:34] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: ButtonWidget with icon only looks weird (MediaWiki skin) - https://phabricator.wikimedia.org/T92556#1176003 (10Jdforrester-WMF) [22:20:39] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: ButtonWidget with icon only looks weird (MediaWiki skin) - https://phabricator.wikimedia.org/T92556#1114516 (10Jdforrester-WMF) [22:20:50] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: ButtonSelectWidget icon/indicator issues in MediaWiki theme - https://phabricator.wikimedia.org/T94199#1176006 (10Jdforrester-WMF) p:5Triage>3Normal [22:21:03] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Indicator-only button has wrong height in MediaWiki theme - https://phabricator.wikimedia.org/T94201#1176007 (10Jdforrester-WMF) p:5Triage>3Normal [22:21:10] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Indicator-only button has wrong height in MediaWiki theme - https://phabricator.wikimedia.org/T94201#1157380 (10Jdforrester-WMF) [22:21:23] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: ButtonSelectWidgets get messed up after being hovered with mouse on Blink browsers (Chrome) - https://phabricator.wikimedia.org/T93472#1176011 (10Jdforrester-WMF) p:5Triage>3Normal [22:21:29] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: ButtonSelectWidgets get messed up after being hovered with mouse on Blink browsers (Chrome) - https://phabricator.wikimedia.org/T93472#1138139 (10Jdforrester-WMF) [22:21:42] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [Regression wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog - https://phabricator.wikimedia.org/T93002#1176015 (10Jdforrester-WMF) [22:21:48] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [Regression wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog - https://phabricator.wikimedia.org/T93002#1126251 (10Jdforrester-WMF) [22:21:52] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [Regression wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog - https://phabricator.wikimedia.org/T93002#1126251 (10Jdforrester-WMF) 5Open>3Resolved [22:22:59] 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 7Design, 3Editing Department 2014/15 Q4 blockers: Regression on Checkboxes and radio buttons - https://phabricator.wikimedia.org/T93944#1176019 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High a:3matmarex [22:23:09] 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 7Design, 3Editing Department 2014/15 Q4 blockers: Regression on Checkboxes and radio buttons - https://phabricator.wikimedia.org/T93944#1150683 (10Jdforrester-WMF) [22:23:27] 10OOjs-UI, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 7Technical-Debt: colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule - https://phabricator.wikimedia.org/T93669#1176026 (10Jdforrester-WMF) [22:23:29] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Properly support ltr/rtl icon versions in colorize-svg.js - https://phabricator.wikimedia.org/T94560#1176024 (10Jdforrester-WMF) 5Open>3Resolved [22:23:50] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 7Technical-Debt: colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule - https://phabricator.wikimedia.org/T93669#1176030 (10Jdforrester-WMF) 5Open>3Resolved [22:23:52] 10OOjs-UI, 5Patch-For-Review: Be able to specify languages for icons (not just use ltr -> rtl substitution) - https://phabricator.wikimedia.org/T76539#1176032 (10Jdforrester-WMF) [22:23:55] 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1176033 (10Jdforrester-WMF) [22:24:06] 10OOjs-UI, 5Patch-For-Review: Provide an RTL variant of the 'help' icon, but don't use it for he and yi - https://phabricator.wikimedia.org/T76540#1176037 (10Jdforrester-WMF) [22:24:08] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Be able to specify languages for icons (not just use ltr -> rtl substitution) - https://phabricator.wikimedia.org/T76539#1176035 (10Jdforrester-WMF) 5Open>3Resolved [22:24:13] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Be able to specify languages for icons (not just use ltr -> rtl substitution) - https://phabricator.wikimedia.org/T76539#802819 (10Jdforrester-WMF) [22:24:28] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Provide an RTL variant of the 'help' icon, but don't use it for he and yi - https://phabricator.wikimedia.org/T76540#802829 (10Jdforrester-WMF) [22:24:32] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Provide an RTL variant of the 'help' icon, but don't use it for he and yi - https://phabricator.wikimedia.org/T76540#802829 (10Jdforrester-WMF) [22:25:32] 10OOjs-UI, 5OOjs-UI-next-release, 3Editing Department 2014/15 Q4 blockers: Provide an RTL variant of the 'help' icon, but don't use it for he and yi - https://phabricator.wikimedia.org/T76540#1176068 (10Jdforrester-WMF) 5Open>3Resolved [22:25:45] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: ButtonSelectWidgets get messed up after being hovered with mouse on Blink browsers (Chrome) - https://phabricator.wikimedia.org/T93472#1176070 (10Jdforrester-WMF) 5Open>3Resolved [22:27:27] mooeypoo: eh, i give up. [22:27:33] 10MediaWiki-ResourceLoader: Must be able to combine ResourceLoaderImageModule's icon CSS and regular CSS files in one module - https://phabricator.wikimedia.org/T94731#1176084 (10Jdforrester-WMF) [22:34:33] ebernhardson: Go for it. [22:35:09] MatmaRex, Roan and I are working on it [22:35:49] (03PS1) 10Jforrester: Update VE core submodule to master (ce9bde4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201605 [22:38:38] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (ce9bde4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201605 (owner: 10Jforrester) [22:40:22] (03PS1) 10Mooeypoo: Correctly position popups in rtl [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) [22:41:02] MatmaRex, after hours -- literally -- of debugging, I present the result. Two @noflips. I am going to toss my computer out the window, tilt my head, and watch it fall from right to left. [22:41:14] (03Merged) 10jenkins-bot: Update VE core submodule to master (ce9bde4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201605 (owner: 10Jforrester) [22:41:18] MatmaRex, there's also a small correction to flip the alignment, but that's tiny. [22:41:31] haha [22:41:56] Why couldn't RTL people invent the computer? [22:42:02] we'd have to LTR'ize everything instead [22:42:04] would've been fun [22:44:08] (03PS3) 10Catrope: Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) [22:45:20] (03CR) 10Bartosz Dziewoński: Correctly position popups in rtl (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) (owner: 10Mooeypoo) [22:45:54] (03CR) 10jenkins-bot: [V: 04-1] Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [22:46:59] mooeypoo: i'll give that a closer look tomorrow probably [22:48:30] (03PS4) 10Catrope: Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) [22:49:30] (03CR) 10Catrope: Correctly position popups in rtl (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) (owner: 10Mooeypoo) [22:49:44] (03CR) 10Catrope: [C: 04-1] Correctly position popups in rtl [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) (owner: 10Mooeypoo) [22:51:49] (03CR) 10jenkins-bot: [V: 04-1] Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [22:54:41] MatmaRex: So it looks like OOjs UI 0.9.5 builds oojs-ui-mediawiki.css as an empty file and all the real content is in oojs-ui-mediawiki.{vector,raster}.css , is that expected? [22:54:52] MatmaRex: Because it breaks MW core as-is if we don't change Resources.php [22:56:09] RoanKattouw: no, it isn't… [22:56:14] RoanKattouw: but i can't reproduce that. [23:00:33] 10VisualEditor, 10VisualEditor-DataModel, 7Verified-in-Phase2, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Whitespace-only headings should be collapsed to (blank) paragraphs - https://phabricator.wikimedia.org/T51452#1176183 (10Etonkovidova) I checked again on production - including checking on the e... [23:02:49] Oh maybe it's because I used quick-build [23:03:35] RoanKattouw: ls -lah dist/oojs-ui-mediawiki*.css |grep -v rtl | grep -v .min. | grep -v vector | grep -v raster [23:03:39] MatmaRex: Nope it's still empty [23:06:11] -rw-r--r-- 1 jdforrester staff 116K 2 Apr 16:04 dist/oojs-ui-mediawiki.css [23:06:30] Sorry, yes [23:06:32] It's nonempty now [23:06:37] But why does quick-build not update it? [23:07:20] RoanKattouw: quick-build only does the 'vector' distribution [23:07:28] OK.... [23:07:29] But why? [23:07:33] Because MW doesn't use that one [23:07:37] quick-build should update the thing that MW uses [23:07:40] No. [23:07:46] quick-build should die in a fire. [23:07:46] Well it did before [23:07:54] We should buy devs better machines. [23:07:57] it always did vector only. [23:08:06] We just wasted ~$200 of staff time. [23:08:08] Maybe it worked before by accident? I don't know [23:08:42] James_F: rasterizing 432 icons is not going to be fast regardless of what you run it on. [23:10:05] RoanKattouw: quick-build is currently somewhat more broken than it used to be, though [23:10:15] it generates a bunch of useless stuff in addition to the vector dist [23:10:27] MatmaRex: Q-computing. [23:10:53] James_F: wouldn't help either, since the build is not parallelized. :P [23:11:54] MatmaRex: We can fix that. ;-) [23:12:21] (03CR) 10Mooeypoo: Correctly position popups in rtl (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) (owner: 10Mooeypoo) [23:12:31] yes, just put Krinkle in a time machine so he can do a week's work in an hour [23:13:08] 10VisualEditor: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1176216 (10Ryasmeen) 3NEW [23:13:20] 10VisualEditor: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1176223 (10Ryasmeen) p:5Triage>3High [23:13:53] (03PS2) 10Mooeypoo: Correctly position popups in rtl [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) [23:17:47] 10VisualEditor: [Regression wmf 23] After saving a page and reopening the styling of content cell in a table becomes same as header cell - https://phabricator.wikimedia.org/T94932#1176236 (10Ryasmeen) 3NEW [23:19:46] (03CR) 10Catrope: [C: 032] Correctly position popups in rtl [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) (owner: 10Mooeypoo) [23:23:18] (03PS3) 10Jforrester: Correctly position popups in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) (owner: 10Mooeypoo) [23:23:25] (03CR) 10Jforrester: [C: 031] Correctly position popups in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) (owner: 10Mooeypoo) [23:25:46] (03CR) 10Catrope: [C: 032] Correctly position popups in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) (owner: 10Mooeypoo) [23:27:37] (03PS1) 10Mooeypoo: Flip popup alignment in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 [23:29:41] Who ever decided to create LTR languages? Weren't cave drawings RTL too? At some point, someone decided it would be a great idea to just fliip the language they were writing *AND* call it default. [23:29:43] * mooeypoo grumbles [23:30:20] ori, https://en.wikipedia.org/wiki/Sautner?veaction=edit fails to load completely for me with 500 error [23:32:19] 10VisualEditor, 10VisualEditor-MediaWiki: When splitting a paragraph, trim whitespace from the start of the new one - https://phabricator.wikimedia.org/T93935#1176296 (10Etonkovidova) The inserted paragraphs have visible extra leading spaces in VE: 10VisualEditor, 10VisualEditor-MediaWiki: When splitting a paragraph, trim whitespace from the start of the new one - https://phabricator.wikimedia.org/T93935#1176300 (10Catrope) I think it might be that wrapper paragraphs (a special type of paragraph) bypass the whitespace stripping code, but that's just a th... [23:34:30] (03CR) 10Cscott: "Should we move the PHP mixin classes (aka the classes that extend ElementMixin) to \OOUI\Mixin\ as well?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott) [23:39:16] 10TemplateData, 6Community-Liaison: Update Help:TemplateData at mediawiki.org - https://phabricator.wikimedia.org/T94937#1176319 (10Whatamidoing-WMF) 3NEW [23:41:11] (03Merged) 10jenkins-bot: Correctly position popups in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/201606 (https://phabricator.wikimedia.org/T94783) (owner: 10Mooeypoo) [23:41:15] 10Citoid, 10VisualEditor, 6Community-Liaison: Update Help:VisualEditor/User_guide#Editing_references at mediawiki.org - https://phabricator.wikimedia.org/T94938#1176329 (10Whatamidoing-WMF) 3NEW [23:41:56] 10Citoid, 10VisualEditor, 6Community-Liaison: Update Help:VisualEditor/User_guide#Editing_references at mediawiki.org - https://phabricator.wikimedia.org/T94938#1176329 (10Whatamidoing-WMF) Also, at what point should we start splitting the page? Putting all citation-related information on a separate page mi... [23:42:06] 10OOjs-UI, 7Technical-Debt: PopupWidget needs to have its body positioned absolutely and anchor relatively to it, and not vice versa - https://phabricator.wikimedia.org/T73644#1176342 (10Mooeypoo) Why? Right now, the container appears right where the popup should be attached to, and then we move its body aroun... [23:44:56] (03CR) 10MarkAHershberger: "commenting this out keeps IE's screen from jumping when either of the list items are used." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123488 (https://bugzilla.wikimedia.org/63154) (owner: 10Catrope) [23:45:00] MatmaRex, seeing as how I read and re-read the entire code on that cursed method I figured I'll take a stab at the bug you showed me, but I am a little confused about what you meant with it. [23:45:38] (03CR) 10Catrope: "What do you mean by "either of the list items are used"?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123488 (https://bugzilla.wikimedia.org/63154) (owner: 10Catrope) [23:46:45] mooeypoo: https://phabricator.wikimedia.org/tag/editing_department_2014_15_q4_blockers/ [23:47:56] ta [23:48:53] (03PS5) 10Catrope: Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) [23:49:24] 10VisualEditor: When a page had NOTOC, INDEX, or NONEWSECTIONLINK page settings, is added when Headings are deleted - https://phabricator.wikimedia.org/T94941#1176377 (10Etonkovidova) [23:51:47] (03PS1) 10Mooeypoo: Set default size to category popup widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201621 [23:55:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 7Verified-in-Phase0, 5WMF-deploy-2015-04-01_(1.25wmf24): VisualEditor links on new pages are broken (uses /w/ instead of /wiki/) - https://phabricator.wikimedia.org/T94315#1176396 (10Ryasmeen) [23:55:39] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 5Patch-For-Review, and 3 others: MWGeneralReferenceDialog inserts a cite template, not a cite template in a reference - https://phabricator.wikimedia.org/T94602#1176400 (10Ryasmeen)