[00:06:18] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Link inspector should understand full internal page URLs as internal links - https://phabricator.wikimedia.org/T94334#1176436 (10Krenair) a:3Krenair [00:09:18] (03PS1) 10Alex Monk: Attempt to detect when a user is trying to input an external link to a wiki page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) [00:12:10] 10OOjs-UI, 10MediaWiki-extensions-Collection, 7Wikimedia-log-errors: Potentially unsafe "href" attribute value - https://phabricator.wikimedia.org/T94900#1176468 (10Krenair) See P468 comments [00:12:31] (03CR) 10jenkins-bot: [V: 04-1] Attempt to detect when a user is trying to input an external link to a wiki page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) (owner: 10Alex Monk) [00:14:10] RoanKattouw, ^ I'm wondering if that test failure is due to my MWInternalLinkAnnotation modification [00:21:02] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, 7RESTBase-API: RFC: API for retrieval and saving of top-level HTML elements by element ID - https://phabricator.wikimedia.org/T94890#1176500 (10GWicke) [00:23:54] Krenair: I haven't looked at the test failures, but I can tell you that that MWInternalLinkAnnotation modification will break a lot [00:24:17] Krenair: The relativeBaseRegex thing is only there for copypasted internal links. Internal links from Parsoid have hrefs that look like "./Foo" [00:24:46] ah. [00:24:54] Krenair: So what I would predict your change would do it corrupt all Parsoid-originating internal links' targets to "undefined" [00:24:58] *would do is [00:27:53] (03PS2) 10Alex Monk: Attempt to detect when a user is trying to input an external link to a wiki page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201627 (https://phabricator.wikimedia.org/T94334) [00:41:36] (03PS3) 10Cscott: WIP: Introduce oo.ui.mixin namespace for mixins, and put them src/mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 [00:45:17] (03PS1) 10Mooeypoo: Close inspectors when dialog opens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201632 (https://phabricator.wikimedia.org/T93638) [00:47:35] 10VisualEditor, 5Patch-For-Review: Citation does not get added when the autofill citation dialog is open in the background - https://phabricator.wikimedia.org/T93638#1176578 (10Mooeypoo) a:3Mooeypoo [00:48:00] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Citation does not get added when the autofill citation dialog is open in the background - https://phabricator.wikimedia.org/T93638#1176579 (10Catrope) [01:00:26] (03PS1) 10Violetto: wipwipwipwipwip [oojs/ui] - 10https://gerrit.wikimedia.org/r/201634 [01:02:46] (03CR) 10Prtksxna: [C: 04-1] "(╯°□°）╯︵ ┻━┻ THIS IS RIDICULOUS" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/201634 (owner: 10Violetto) [01:06:52] (03PS2) 10Violetto: wipwipwipwipwip [oojs/ui] - 10https://gerrit.wikimedia.org/r/201634 [01:08:44] (03Abandoned) 10Violetto: wipwipwipwipwip [oojs/ui] - 10https://gerrit.wikimedia.org/r/201634 (owner: 10Violetto) [01:15:19] (03CR) 10MarkAHershberger: "I mean the bullet list or the numbered list." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123488 (https://bugzilla.wikimedia.org/63154) (owner: 10Catrope) [01:25:38] (03PS1) 10Violetto: add iconography page controls [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 [01:27:14] (03CR) 10Prtksxna: [C: 04-1] add iconography page controls (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [01:30:47] (03PS2) 10Violetto: add iconography page controls [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 [01:31:30] (03PS3) 10Catrope: Tag v0.9.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201586 (owner: 10Jforrester) [01:32:46] (03CR) 10Violetto: "fixed a few things" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [01:33:26] (03PS4) 10Catrope: Tag v0.9.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201586 (owner: 10Jforrester) [01:34:03] (03CR) 10Catrope: [C: 032] Tag v0.9.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201586 (owner: 10Jforrester) [01:42:53] (03Merged) 10jenkins-bot: Tag v0.9.5 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201586 (owner: 10Jforrester) [02:17:17] Krinkle: Could you npm publish OOUI for me? [02:17:24] I keep getting errors from both npm publish and npm adduser [02:17:37] OK [02:17:41] And it's npm so of course the errors are cryptic as all hell [02:17:49] Can you log in on npmjs.org? https://www.npmjs.com/package/oojs-ui [02:19:30] Yes [02:20:05] Wow. that's a lot of icon css files [02:23:13] Published [02:25:14] Thanks [02:25:22] Do you know how to pull it into MW core + vendor? [02:25:30] If not, that's OK, I'll figure it out [02:25:34] But if you've done it before... [02:25:49] Only once I think. When I tested the script for James. [02:26:06] RoanKattouw: maintenance/resources/update oojs ui [02:26:13] Oh OK [02:26:19] I'll do that later [02:26:21] and a commit against vendor bumping the dependency, re-run composer, and commit to git [02:26:26] Or maybe now [02:26:30] and composer.json in core of course [02:26:54] those three changes. [02:27:44] james tends to do it in two by amending the commit by update-oojs-ui (for frontend) to also include the update to composer.json [02:27:55] https://github.com/wikimedia/mediawiki/commit/f77b9bcc2c6fcb69622820a2d9ba3f0321d5e142 [02:29:19] 10VisualEditor, 10VisualEditor-MediaWiki: Mysterious missingrev failure during save - https://phabricator.wikimedia.org/T94367#1176771 (10MZMcBride) https://en.wikipedia.org/w/index.php?title=United_Against_Nuclear_Iran&offset=20150329215213&limit=17&action=history I'm not sure how prevalent this issue is, bu... [02:36:44] Is the icons being missing on mobile issue known? [02:36:56] until you mw.loader.load( 'ext.visualEditor.icons' ) [02:49:47] RoanKattouw, I'm guessing because that's all loaded by TargetLoader? [02:49:54] did we say that mobile uses targetloader or not? [03:02:56] So much is broken on mobile :( [03:02:59] All due to TargetLoader [03:03:05] I was going to fix that today but stuff came up [03:03:13] Like, none of the link-related code is loaded [03:04:00] when I do load all the modules and click the link button, I just get a white screen :/ [03:04:14] WTF, I think oojs-ui's build is broken [03:04:17] oh, it's showing now [03:04:19] - background-image: -o-linear-gradient(transparent, transparent), url("themes/mediawiki/images/icons/check.png"); [03:04:21] + background-image: -o-linear-gradient(transparent, transparent), url("themes/mediawiki/images/icons/check.@{@oo-ui-default-image-ext}"); [03:04:24] might just have been chrome silliness [03:04:25] We just released that into 0.9.5 :( [03:05:11] Krinkle: I'm aborting pulling OOUI 0.9.5 into MW until Bartosz wakes up and can fix this mess [03:05:24] We will likely need to blackball the 0.9.5 release and release some fixes in 0.9.6 [03:06:27] Yeah [03:07:39] RoanKattouw: please tell me consumers don't have to load all those icon css files manually? [03:07:50] I don't know that either [03:07:53] they can be excluded in the oojs-ui-update sh script [03:08:01] assuming that they aren't needed [03:08:13] I don't know anything about the recent icon or build changes and Bartosz is asleep and James is out and has tomorrow off [03:08:28] So I emailed Bartosz (CC you and James) asking him to save us all when he wakes up [03:08:56] ok [03:21:27] Oh wow, the Terminal on Yosemite binds scroll gesture to less pagination. [03:21:36] even works over ssh and inside screen. [03:22:42] Yup xterm does that too [03:23:02] Except it doesn't work well when you're in a screen over ssh and *not* inside of less [03:23:11] Then it just dumps control chars into your shell [03:42:53] Krinkle, will you be doing https://phabricator.wikimedia.org/T52707 ? [03:43:02] description could do with an update [04:58:45] (03CR) 10Prtksxna: "See other comments on the first patchset :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [05:01:55] (03CR) 10Prtksxna: [C: 04-1] add iconography page controls [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [05:18:10] Krenair: There's a pretty large dependency on things. Until we have something that depends on this separation of Platform, it's probably not a priority [05:18:54] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: VisualEditor: Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#1176992 (10Krinkle) [05:19:19] 10VisualEditor, 10VisualEditor-DataModel, 7Verified-in-Phase2, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Whitespace-only headings should be collapsed to (blank) paragraphs - https://phabricator.wikimedia.org/T51452#1176997 (10NicoV) Found an other one, edit time is about 12 hours after the first ex... [05:19:25] Krenair: The init reduction has already been done to some extend. [06:26:05] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia: Find out whether any browser supported by MediaWiki needs TraceKit's "rethrow to window.onerror" logic for stack traces - https://phabricator.wikimedia.org/T86058#1177084 (10Tgr) p:5High>3Lowest Raven actually surpresses this behavio... [06:26:24] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 7Blocked-on-Editing, 5Patch-For-Review: Add startup script to automatically wrap asynchronous functions in try..catch - https://phabricator.wikimedia.org/T85262#1177088 (10Tgr) [06:26:28] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia: Find out whether any browser supported by MediaWiki needs TraceKit's "rethrow to window.onerror" logic for stack traces - https://phabricator.wikimedia.org/T86058#1177087 (10Tgr) 5Open>3declined [06:41:25] 10VisualEditor, 10VisualEditor-EditingTools, 7user-notice: VisualEditor: Display and let users edit arbitrary HTML anchors, e.g. in section headings - https://phabricator.wikimedia.org/T52633#1177147 (10Elitre) [07:07:45] 10VisualEditor, 10Continuous-Integration, 5WMF-deploy-2015-03-25_(1.25wmf23): Jenkins: Convert mediawiki qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#1177207 (10Krinkle) [07:08:04] 10VisualEditor: Visual Editor is changing stub templates - https://phabricator.wikimedia.org/T94748#1177209 (10Edgars2007) [07:18:33] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Copying and pasting results in new blank section heading: "== ==" - https://phabricator.wikimedia.org/T57769#1177218 (10Elitre) [07:18:35] 10VisualEditor, 10VisualEditor-DataModel, 7Verified-in-Phase2, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Whitespace-only headings should be collapsed to (blank) paragraphs - https://phabricator.wikimedia.org/T51452#1177216 (10Elitre) 5Resolved>3Open [07:18:37] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Deletion across a header caused it to remain without WS, leading Parsoid to output "====" - https://phabricator.wikimedia.org/T52100#1177217 (10Elitre) [07:24:36] 10VisualEditor, 7Technical-Debt: VisualEditor: Annotation API fixes - https://phabricator.wikimedia.org/T48464#1177224 (10Elitre) 5Resolved>3Open I didn't know whether to reopen this or add a note to T39835, but looks like it's still possible to [[ https://fr.wikipedia.org/w/index.php?title=Asselin_(entrep... [07:24:38] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: VisualEditor: A link can span whitespace but won't be displayed so cannot be edited or noticed - https://phabricator.wikimedia.org/T39835#423226 (10Elitre) [07:32:04] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 5WMF-deploy-2015-04-01_(1.25wmf24): Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1177249 (10Elitre) 5Resolved>3Open Still seeing those span tags [[https://en.wikipedia.o... [07:33:22] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 5WMF-deploy-2015-04-01_(1.25wmf24): Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1177253 (10Elitre) 5Open>3Resolved Maybe I should look at the Version before commenting... [08:33:42] 10OOjs-UI, 10UI-Standardization, 7Accessibility, 7Design: Return focus to the last location when a modal dialog is dismissed - https://phabricator.wikimedia.org/T87714#1177291 (10Prtksxna) a:3Prtksxna [08:38:20] (03PS1) 10Prtksxna: WindowManager: Add a $lastFocus property [oojs/ui] - 10https://gerrit.wikimedia.org/r/201680 (https://phabricator.wikimedia.org/T87714) [08:47:55] (03CR) 10Krinkle: [C: 032] Use ve.safeDecodeURIComponent() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200811 (owner: 10Catrope) [08:49:56] (03Merged) 10jenkins-bot: Use ve.safeDecodeURIComponent() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200811 (owner: 10Catrope) [08:54:46] (03PS2) 10Krinkle: Use .apply() in MWInternalLinkAnnotation.static.toDomElements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201390 (owner: 10Catrope) [08:56:02] (03CR) 10Krinkle: [C: 032] Use .apply() in MWInternalLinkAnnotation.static.toDomElements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201390 (owner: 10Catrope) [08:58:36] (03Merged) 10jenkins-bot: Use .apply() in MWInternalLinkAnnotation.static.toDomElements [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201390 (owner: 10Catrope) [09:13:16] 10OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#1177354 (10Prtksxna) 5Resolved>3Open Since rGOJUfc6ef37c9f88 was submitted and merged there has been a lot of discussion on this task. The discussion raises points to keep the radios and che... [09:13:46] 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 7Design, 3Editing Department 2014/15 Q4 blockers: Regression on Checkboxes and radio buttons - https://phabricator.wikimedia.org/T93944#1177358 (10Prtksxna) 5Resolved>3Open @jdforrester-wmf, the patch that @matmarex submitted - rGOJUe0d015e20f0d... [09:14:08] 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 7Design, 3Editing Department 2014/15 Q4 blockers: Regression on Checkboxes and radio buttons - https://phabricator.wikimedia.org/T93944#1177362 (10Prtksxna) a:5matmarex>3None [09:17:32] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Help the HTML Editing Task Force shape "Editing on the Web" (aka future of contentEditable) - https://phabricator.wikimedia.org/T91781#1177364 (10TheDJ) Support !!! We have had a lot to complain about, let's make sure we incorporate our lessons learned... [09:33:56] (03PS1) 10Krinkle: build: Move pre/post 'doc' task into package.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201685 [09:33:58] (03PS1) 10Krinkle: build: Declare grunt-cli dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201686 [09:35:30] (03PS1) 10Krinkle: build: Use grunt-contrib-copy instead of our own implementation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201687 [09:35:40] (03CR) 10Krinkle: [V: 04-1] "Broken because copy.js from lib/ve is shadowing grunt-contrib-copy. The old copy.js doesn't support copying directories (only files) and a" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201685 (owner: 10Krinkle) [09:37:39] (03PS2) 10Krinkle: build: Move pre/post 'doc' task into package.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201685 [09:37:41] (03PS2) 10Krinkle: build: Declare grunt-cli dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201686 [09:38:34] (03CR) 10Krinkle: [V: 04-1] "Requires Iac5e4340444791." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201685 (owner: 10Krinkle) [10:01:07] (03PS1) 10Krinkle: buid: Include utils.js in jsduck and add 'doc' entry point [oojs/core] - 10https://gerrit.wikimedia.org/r/201691 [10:10:52] Krenair: If you're back, could you review ^ - will allow to do the first automated code-coverage publication for qunit :) [10:14:02] (03PS1) 10Prtksxna: [wip] Make PopupsWidget and FlaggedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/201693 (https://phabricator.wikimedia.org/T92026) [10:15:58] 10OOjs-UI, 10Living-Style-Guide, 10UI-Standardization, 7Design, 5Patch-For-Review: Add 'warning' or 'warn' flag to OOjs UI stylings - https://phabricator.wikimedia.org/T92026#1177404 (10Prtksxna) The elements that could use the warning flag and have been implemented in OOjs UI are `PopupsWidget` or tipsy... [10:16:17] 10OOjs-UI, 10UI-Standardization, 7Accessibility, 7Design, 5Patch-For-Review: Return focus to the last location when a modal dialog is dismissed - https://phabricator.wikimedia.org/T87714#1177405 (10TheDJ) Note that this deals with keyboard navigation, not necessarily screenreader behavior, which uses dom... [10:31:08] 10OOjs-UI, 10UI-Standardization, 7Accessibility, 7Design, 5Patch-For-Review: Return focus to the last location when a modal dialog is dismissed - https://phabricator.wikimedia.org/T87714#1177422 (10Prtksxna) >>! In T87714#1177405, @TheDJ wrote: > Note that this deals with keyboard navigation, not necessa... [11:45:29] 10OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#1177498 (10Esanders) The pholios attached to T93944 aren't very helpful for this issue - they're rendered at a huge size and don't show any text context. They make a great blueprint for the impl... [11:47:02] 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 7Design, 3Editing Department 2014/15 Q4 blockers: Regression on Checkboxes and radio buttons - https://phabricator.wikimedia.org/T93944#1177504 (10Esanders) [11:47:04] 10OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#1177505 (10Esanders) [11:56:44] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Write some easy user-facing documentation on how to enable and configure auto-filled citations on your wiki - https://phabricator.wikimedia.org/T94864#1177533 (10Mvolz) Duplicate of T93515 ? [11:58:25] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid: Make available original image dimensions info from the API in Parsoid DOM. - https://phabricator.wikimedia.org/T64881#1177537 (10Esanders) Is there a task for VE to use this now? [12:01:29] 10Citoid: ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1177541 (10Mvolz) 5Open>3Resolved [12:01:41] 10Citoid: ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1134780 (10Mvolz) Not deployed yet. [12:15:01] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 5Patch-For-Review: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox - https://phabricator.wikimedia.org/T78733#1177577 (10Krinkle) Relevant: * {7a46e84d69a3c912ba9e3c19c0943dba13026ae3} * {4ebdd607f5de4fbdf2cfba732452c4df239847c8} * {061904a913db144... [12:30:27] 10VisualEditor, 6Release-Engineering, 7Browser-Tests, 5Patch-For-Review: Create VisualEditor tests targeting the older version of browsers (Chrome and Firefox for now) for better backward compatibility - https://phabricator.wikimedia.org/T90678#1177614 (10zeljkofilipin) No reply in a week, I am assuming no... [12:30:49] 10VisualEditor, 6Release-Engineering, 7Browser-Tests, 5Patch-For-Review: Create VisualEditor tests targeting the older version of browsers (Chrome and Firefox for now) for better backward compatibility - https://phabricator.wikimedia.org/T90678#1177615 (10zeljkofilipin) 5Open>3declined [13:17:46] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Citoid request for MediaWiki:Citoid-template-type-map.json should be in the content language, not the user language - https://phabricator.wikimedia.org/T93800#1177726 (10Mvolz) Thanks @WhatamIdoing-WMF, that helps a lot. [13:33:19] 10Citoid: Native scrape responses not getting converted to mediawiki type - https://phabricator.wikimedia.org/T95004#1177757 (10Mvolz) 3NEW [13:34:13] 10Citoid, 6Services: Native scrape responses not getting converted to mediawiki type - https://phabricator.wikimedia.org/T95004#1177774 (10Mvolz) [13:43:47] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1177808 (10Mvolz) Deployed, can retest now. [13:44:49] 10Citoid: Issues with BBC references - https://phabricator.wikimedia.org/T94663#1169356 (10Mvolz) Issues with the Zotero translator, likely: https://github.com/zotero/translators/blob/master/BBC.js [13:47:16] 10Citoid: Can't turn a link to Archive.org into a reference - https://phabricator.wikimedia.org/T94176#1177828 (10Mvolz) This was probably due an issue the deployed verson of zotero was having with https links, now resolved. [13:47:23] 10Citoid: Can't turn a link to Archive.org into a reference - https://phabricator.wikimedia.org/T94176#1177829 (10Mvolz) 5Open>3Resolved [13:51:43] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1177831 (10Elitre) 10.1038/scientificamerican0200-90 still not working. 10.2307/3677029 still says //"JSTOR: An Error Occurred Setting Your User Cookie"// . 10.1542/peds.2007-2362 still gives... [13:56:23] 10Citoid: DOIs when they fall back to dx.doi.org should still be considered journals - https://phabricator.wikimedia.org/T94597#1177851 (10Mvolz) It's not a bad heuristic for now, but with services offering DOIs for blog posts, (i.e. https://wordpress.org/plugins/the-winnower-publisher/) , it's possible to get a... [13:57:47] 10Citoid: Resolvable DOIs, PMIDs, and PMCIDs should be checked for itemType and manually set to journalArticle. - https://phabricator.wikimedia.org/T94597#1177853 (10Mvolz) 5Open>3Resolved a:3Mvolz [13:57:56] 10Citoid: Resolvable DOIs, PMIDs, and PMCIDs should be checked for itemType and manually set to journalArticle. - https://phabricator.wikimedia.org/T94597#1167808 (10Mvolz) 5Resolved>3Open [13:58:07] 10Citoid: Resolvable DOIs, PMIDs, and PMCIDs should be checked for itemType and manually set to journalArticle. - https://phabricator.wikimedia.org/T94597#1167808 (10Mvolz) p:5Triage>3Normal [14:10:35] (03PS1) 10Bartosz Dziewoński: build: Generate correct paths to fallback images [oojs/ui] - 10https://gerrit.wikimedia.org/r/201707 [14:15:07] 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1177883 (10matmarex) I'm going to do this after we upgrade MediaWiki to use OOjs UI v0.9.6 (in a... [14:31:22] (03PS1) 10Mvolz: [WIP] Fix Scrape to output correct format [services/citoid] - 10https://gerrit.wikimedia.org/r/201712 (https://phabricator.wikimedia.org/T95004) [14:37:22] (03CR) 10Mvolz: "This is sort of an important fix; but happened because of technical debt, which this in no way improves. Should we merge and then address " (031 comment) [services/citoid] - 10https://gerrit.wikimedia.org/r/201712 (https://phabricator.wikimedia.org/T95004) (owner: 10Mvolz) [14:41:41] 10Citoid: prefer 302s from zotero over scaper.js (or at least use info from both) - https://phabricator.wikimedia.org/T75995#1177928 (10Mvolz) 5Open>3declined [14:44:21] 10Citoid, 6Services: Promisify Citoid and base it on service-template-node / service-runner - https://phabricator.wikimedia.org/T75993#1177930 (10Mvolz) [14:47:29] 10Citoid, 10TemplateData: Missing parameter in citation - https://phabricator.wikimedia.org/T93355#1177934 (10Mvolz) [14:47:37] 10Citoid, 10TemplateData: Missing parameter in citation - https://phabricator.wikimedia.org/T93355#1177936 (10Mvolz) 5Open>3stalled [14:52:05] 10Citoid, 10TemplateData: Missing parameter in citation - https://phabricator.wikimedia.org/T93355#1177945 (10Mvolz) [15:48:41] (03CR) 10Rits: "mooeypoo i have done all the suggested changes, gerrit gives a error while pushing the patchset and when i try to rebase through gerrit it" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [15:57:34] (03CR) 10Mvolz: "If the merge is complicated, the rebase button on gerrit won't work, and you have to do it on yourself manually on your computer." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [15:59:24] (03CR) 10Rits: "mvolz, ok thank you" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [16:07:22] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1178054 (10LuisVilla) Note that you get the JSTOR error when using a standard JSTOR URL as well, like http://www.jstor.org/stable/25177324 - should that get a separate bug open? [16:14:57] (03CR) 10Catrope: [C: 032] build: Generate correct paths to fallback images [oojs/ui] - 10https://gerrit.wikimedia.org/r/201707 (owner: 10Bartosz Dziewoński) [16:19:12] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1178127 (10Elitre) The problem lies within CS1 templates like the Cite journal one, which do not accept dates with slashes, and is quickly fixed by replacing them with dashes (this is explaine... [16:19:29] (03Merged) 10jenkins-bot: build: Generate correct paths to fallback images [oojs/ui] - 10https://gerrit.wikimedia.org/r/201707 (owner: 10Bartosz Dziewoński) [16:24:53] 10TemplateData, 6Community-Liaison, 7Documentation: Update Help:TemplateData at mediawiki.org - https://phabricator.wikimedia.org/T94937#1178144 (10Aklapper) [16:29:59] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid: Make available original image dimensions info from the API in Parsoid DOM. - https://phabricator.wikimedia.org/T64881#1178159 (10cscott) @esanders, @jdforrester-WMF: perhaps you VE guys should add one? I think @mooeypoo was doing... [16:32:28] (03CR) 10Esanders: "why wip?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/194409 (owner: 10Divec) [16:41:18] 10VisualEditor, 7Wikimedia-log-errors: Data error in ApiVisualEditor - https://phabricator.wikimedia.org/T95015#1178226 (10demon) 3NEW [16:43:31] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1178234 (10Mvolz) It's possible we've been IP blocked by JSTOR, see: T88323. @Elitre, open up a ticket for the dates, we should be validating date fields. [16:46:13] 10Citoid: Results of a test with 10 random DOIs from en.wiki on the Beta site - https://phabricator.wikimedia.org/T94209#1178239 (10Mvolz) Re: cookies issue, we have a ticket for that: T93877 [16:50:31] 10Citoid: Citoid should be validating date fields - https://phabricator.wikimedia.org/T95016#1178256 (10Elitre) 3NEW [17:07:47] 10MediaWiki-ResourceLoader, 7JavaScript: mw.loader.using loads modules one by one. I would want to load all modules at the same time - https://phabricator.wikimedia.org/T94914#1178302 (10Aklapper) [17:13:10] 10VisualEditor, 7Wikimedia-log-errors: Data error in ApiVisualEditor - https://phabricator.wikimedia.org/T95015#1178312 (10Krenair) Bad data going into the html param? [17:20:46] 10VisualEditor, 7Wikimedia-log-errors: Data error in ApiVisualEditor - https://phabricator.wikimedia.org/T95015#1178320 (10Krenair) The warning is from gzinflate apparently, but that data is supposed to come from EasyDeflate.deflate on the client. I guess someone might just be sending in nonsense. [17:22:03] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Media search dialog should allow for dynamic reflow of the images when the screen changes dimensions - https://phabricator.wikimedia.org/T95017#1178329 (10Mooeypoo) 3NEW a:3Mooeypoo [17:22:16] mvolz: i deleted one file and added another but when i do git rebase --continue modules/ve-mw/ce/styles/nodes/ve.ce.MWAlienNode.css: needs update [17:22:56] mvolz: for this patchset https://gerrit.wikimedia.org/r/#/c/198397/ [17:22:58] there's a conflict in the css file? that's weird, isn't that a new file? [17:23:06] What does git status say? [17:23:43] 10VisualEditor, 7Wikimedia-log-errors: Data error in ApiVisualEditor - https://phabricator.wikimedia.org/T95015#1178338 (10Krenair) So if I request this: ```api.php?action=visualeditor&html=rawdeflate,testing&page=Main_Page&paction=serializeforcache``` We get these errors in hhvm.log: ```Apr 3 17:20:15 mw1114... [17:23:59] git status -> http://pastebin.com/ndNsJk39 [17:24:47] rits: OK, you should be able to run git rebase --continue now [17:24:56] It says " (all conflicts fixed: run "git rebase --continue") " [17:25:08] mooeypoo: actually i created a new one named MWAlienExtensionNode and deleted MWAlienNode, i didn't actually did that but two files were created so i deleted one [17:25:54] i did after that but the same shows again modules/ve-mw/ce/styles/nodes/ve.ce.MWAlienNode.css: needs update You must edit all merge conflicts and then mark them as resolved using git add [17:26:00] wtf [17:26:08] But it says you can run continue [17:26:09] That's weird [17:26:27] rits, do 'git rm modules/ve-mw/ce/styles/nodes/ve.ce.MWAlienNode.css' [17:26:33] then git rebase --continue [17:26:40] mooeypoo: ok [17:28:38] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Write some easy user-facing documentation on how to enable and configure auto-filled citations on your wiki - https://phabricator.wikimedia.org/T94864#1178351 (10Catrope) >>! In T94864#1177533, @Mvolz wrote: > Duplicate of T93515 ? Not quite... [17:29:27] mooeypoo: You can help mvolz with https://phabricator.wikimedia.org/T93800 [17:29:40] mooeypoo: The task is assigned to her but she commented on it asking for your help [17:30:11] 10VisualEditor, 10VisualEditor-ContentLanguage, 3Editing Department 2014/15 Q4 blockers, 7I18n: VisualEditor: When using jquery.IME, type a word and press space bar = eliminates typed text immediately - https://phabricator.wikimedia.org/T55700#1178359 (10Catrope) a:3dchan [17:30:48] mooeypoo: https://phabricator.wikimedia.org/T94621 is assigned to you already; although 1 point might be a lowball estimate there, might be more like an 8 [17:33:26] RoanKattouw, yeah that is a bit of work. I can start on that, but since it was normal priority I thought I'd see if there are more urgent bugs first. [17:33:36] mvolz, you still need help with the language bug? [17:33:47] OK [17:33:49] I'll keep looking [17:35:17] when i did git review -R this is showing up http://pastebin.com/pxC0qgHG , i tried the git fetch --all and git remote update but again the same shows up on git review [17:35:33] mooeypoo: ^ [17:36:46] Oh, hah [17:36:59] rits: Run git rebase origin/master [17:37:14] ok [17:38:44] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Citoid request for MediaWiki:Citoid-template-type-map.json should be in the content language, not the user language - https://phabricator.wikimedia.org/T93800#1178392 (10Mooeypoo) I think qqx is a unique issue, since we don't get the **conten... [17:39:50] another one http://pastebin.com/QmsWX72c [17:40:29] Oh, ahm [17:40:37] I think I might know what's going on here [17:40:43] rits: Can you pastebin git log -2 ? [17:40:53] ok [17:41:34] http://pastebin.com/ykMUYpZq [17:42:01] RoanKattouw: ^ [17:43:16] Yeah there we go [17:43:23] You have two commits with the same Change-Id, Gerrit doesn't like that [17:43:41] I take it they each have half of your changes and you probably want to merge them? [17:43:47] oh ok [17:44:13] i have made all the changes to the recent one now [17:44:24] Yeah, but the bottom one is still gonna have some stuff [17:44:29] So, let's squash these two [17:44:38] other was marked as duplicate [17:44:42] It's a bit of a complicated process but I can talk you through it [17:44:43] ok [17:45:02] ok [17:46:00] should i follow this https://www.mediawiki.org/wiki/Gerrit/Tutorial#Squash_into_single_commit [17:46:13] Yes! [17:46:20] OMG we have a tutorial for that, that's awesome [17:46:29] I didn't realize we had that :) [17:46:37] :) [17:47:04] this is a awesome tutorial [17:47:42] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1178420 (10gpaumier) 2015-03-17: * [[ https://en.wikipedia.org/w/index.php?oldid=654370040#Tue_Mar_17_2015_10:11:32_GMT-0700_.28P... [17:50:04] (03PS6) 10Rits: Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) [17:50:07] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1178443 (10gpaumier) 2015-03-24: * [[ https://en.wikipedia.org/w/index.php?oldid=654370040#Tue_Mar_24_2015_09:20:49_GMT-0700_.28P... [17:51:01] rits: There's also a tutorial for changing a commit that you should follow to avoid weird situations like this [17:51:12] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change [17:51:42] Hopefully that'll avoid the stiuation you had earlier with two different changes in Gerrit, or this one just now with two commits with the same Change-Id (I'd never seen that happen before :O ) [17:52:19] RoanKattouw: i did followed that but the rebase was creating a error, everything solved [17:52:54] RoanKattouw: ah, i did something new :D [17:53:14] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1178462 (10gpaumier) 2015-03-31: * [[ https://en.wikipedia.org/w/index.php?oldid=654370040#Tue_Mar_31_2015_09:05:56_GMT-0700_.28P... [17:54:04] rits, did you test it? :) [17:54:34] mooeypoo: amm, not today i just cleared the code [17:54:41] today [17:54:49] mooeypoo: i will just test it [17:54:57] rits yea it fails again, but that is my bad [17:55:06] rits, I told you to check if this.$icon isn't null [17:55:28] but what I should've told you is to check if it isn't undefined or null, which you can just cover with if ( !this.$icon ) { ... } [17:55:34] mooeypoo: but then it was working after having this check [17:55:36] it fails now because this.$icon is undefined [17:55:56] rits, yeah it fails for me [17:56:06] mooeypoo: ok got it , i will fix it up [17:56:20] pull it again and see -- it says "uncaught TypeError: Cannot read property 'detach' of undefined" in the console [17:56:22] sorry about that [17:56:37] I have to go for a little bit, but I'll come back [17:56:50] mooeypoo: no problem :) ok [17:57:18] mooeypoo: i'll fix it up till then :) [17:59:43] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1178513 (10gpaumier) [18:10:48] RoanKattouw, I wonder if we should use an inputFilter for https://gerrit.wikimedia.org/r/#/c/201627/ [18:11:11] rather than sort of trying to override what's requested [18:11:29] but is that wanted or not... hm [18:15:22] Hmm, maybe [18:18:34] (03PS1) 10Alex Monk: Check whether html parameter is valid rather than allow warnings to be raised if it is not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201743 (https://phabricator.wikimedia.org/T95015) [18:19:53] (03CR) 10Catrope: [C: 032] Check whether html parameter is valid rather than allow warnings to be raised if it is not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201743 (https://phabricator.wikimedia.org/T95015) (owner: 10Alex Monk) [18:20:32] (03PS2) 10Alex Monk: Check whether html parameter is valid rather than allow warnings to be raised if it is not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201743 (https://phabricator.wikimedia.org/T95015) [18:20:35] oops [18:21:18] RoanKattouw, didn't realise my first PS had actually uploaded, remembered I was supposed to change @ to wfSuppressWarnings/wfRestoreWarnings [18:21:39] (03PS7) 10Rits: Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) [18:21:40] lol [18:21:41] sorry [18:21:58] Krenair: Also, can base64_decode() warn if /its/ input is invalid? [18:22:12] I haven't seen it do that [18:22:37] OK [18:22:42] (03CR) 10Catrope: [C: 032] Check whether html parameter is valid rather than allow warnings to be raised if it is not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201743 (https://phabricator.wikimedia.org/T95015) (owner: 10Alex Monk) [18:22:43] php > var_dump( base64_decode( "not base64" ) ); [18:22:44] string(6) "��[jǺ" [18:23:16] php > var_dump( gzinflate( base64_decode( "not base64" ) ) ); [18:23:16] PHP Warning: gzinflate(): data error in php shell code on line 1 [18:23:16] bool(false) [18:23:43] need to fix that oldid thing as well [18:24:06] RoanKattouw, Krenair: base64_decode takes a second optional boolean parameter, $strict [18:24:07] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Wikimedia-log-errors: Data error in ApiVisualEditor - https://phabricator.wikimedia.org/T95015#1178606 (10Krenair) [18:24:15] strict [18:24:15] Returns FALSE if input contains character from outside the base64 alphabet. [18:25:04] seems that would catch some invalid input but not all. but checking gzinflate would catch it all? [18:26:23] (03CR) 10Esanders: Assigning width and height to MWAlienNodes (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [18:26:46] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1178622 (10Catrope) 3NEW a:3Esanders [18:26:54] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1178630 (10Catrope) [18:28:28] rits: Just FYI in case you hadn't seen them: edsanders left some review comments for you at https://gerrit.wikimedia.org/r/#/c/198397/6/modules/ve-mw/ce/nodes/ve.ce.MWAlienExtensionNode.js [18:28:47] (They're not on the latest patchset so it's not obvious) [18:29:55] (03Merged) 10jenkins-bot: Check whether html parameter is valid rather than allow warnings to be raised if it is not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201743 (https://phabricator.wikimedia.org/T95015) (owner: 10Alex Monk) [18:34:08] (03PS1) 10Catrope: Tag v0.9.6 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201748 [18:39:20] (03CR) 10TheDJ: [C: 031] "Works as it should, for both keyboard navigation and VoiceOver." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201680 (https://phabricator.wikimedia.org/T87714) (owner: 10Prtksxna) [18:41:39] RoanKattouw: sorry just saw your message, actually these comments were to the previous patchsets and i corrected them all in the recent one, gerrit is showing it again on the patch comments [18:42:23] Oh nice [18:42:27] No, wait [18:42:33] You haven't corrected all of them [18:42:48] ve.ce.MWAlienExtensionNode.js line 67 still uses spaces instead of tabs, for example [18:43:01] The comments at https://gerrit.wikimedia.org/r/#/c/198397/6/modules/ve-mw/ce/nodes/ve.ce.MWAlienExtensionNode.js are new, they were put there after you submitted PS7 [18:43:26] (I don't know why Ed put them on PS6, maybe he had already started writing them when you submitted PS7) [18:44:38] RoanKattouw: amm, yes i will correct them, thanks [18:54:22] (03PS8) 10Rits: Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) [18:58:28] Krenair: Could you do me a favor and +2 https://gerrit.wikimedia.org/r/201748 ? [18:59:07] (03PS1) 10Alex Monk: Avoid undefined index warning for oldid if it's not set in serializeforcache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201772 (https://phabricator.wikimedia.org/T95015) [18:59:45] (03CR) 10Alex Monk: [C: 032] Tag v0.9.6 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201748 (owner: 10Catrope) [18:59:50] Thanks [19:00:23] (03CR) 10Catrope: [C: 04-1] "You shouldn't modify lib/ve in this change. It's easy to get lib/ve to end up in your change accidentally, it happens to everybody. Here's" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [19:00:39] where is james today? [19:00:41] Off [19:01:31] A friend of his is in town [19:02:14] ah [19:03:05] have been looking for q4 blockers [19:03:18] (03Merged) 10jenkins-bot: Tag v0.9.6 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201748 (owner: 10Catrope) [19:04:10] 10VisualEditor: HTML entities in CommentNode must be manually escaped/unescaped. - https://phabricator.wikimedia.org/T95040#1178802 (10cscott) 3NEW a:3Esanders [19:04:40] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: VisualEditor: Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#1178811 (10Krenair) [19:05:10] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: VisualEditor: Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#588553 (10Krenair) [19:05:20] (03PS9) 10Rits: Assigning width and height to MWAlienNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) [19:05:57] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: VisualEditor: Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#588553 (10Krenair) [19:06:30] RoanKattouw, you looking at mobile TargetLoader? do we have a task for that? [19:06:42] Not yet :( still cleaning up the OOUI mess and other messes [19:06:55] Don't know if there's a task for it [19:07:04] But if you're looking for things to work on, that would be a great one [19:07:46] 10VisualEditor: HTML entities in CommentNode must be manually escaped/unescaped. - https://phabricator.wikimedia.org/T95040#1178815 (10cscott) [19:07:55] npm http PUT https://registry.npmjs.org/-/user/org.couchdb.user:catrope/-rev/undefined [19:07:57] npm http 400 https://registry.npmjs.org/-/user/org.couchdb.user:catrope/-rev/undefined [19:07:58] npm ERR! Error: bad_request Invalid rev format: -/user/org.couchdb.user:catrope/-rev/undefined [19:08:00] npm ERR! at RegClient. (/usr/share/npm/node_modules/npm-registry-client/lib/request.js:272:14) [19:08:01] *sigh* [19:08:05] What's missing from it really? Does TargetLoader not get called from mobile at all? [19:08:20] I think so [19:08:27] I completely missed mobile when doing the TargetLoader stuff [19:08:32] Which is entirely my fault [19:08:41] So now mobile is loading some things but not others [19:08:45] Big chunks like mwlink don't get loaded [19:08:57] right [19:09:15] I know icons aren't loaded, which is the most obvious-to-users bit [19:09:47] like https://en.m.wikipedia.org/wiki/Warren_A._Bechtel#/editor/0 just doesn't show bold/italic buttons, despite the html being there and having an effect [19:10:05] The "proper solution" probably involves using TargetLoader and touching a bunch of MobileFrontend code that none of us know well [19:10:28] clicking the link button just does this: Uncaught TypeError: Expecting a function in instanceof check, but got undefined [19:10:37] great :/ [19:10:40] Other bad things are that any attempt to use link functionality fatals, and a bunch of stuff is alienated [19:11:01] will look at how you integrated it into ve-mw and see if I can do the same in mobilefrontend [19:11:25] Awesome [19:11:42] I will be going to lunch in a minute but I'll be back soon, Trevor has a meeting at 1 [19:13:45] If we agree to https://phabricator.wikimedia.org/T52707 we can get Krinkle|detached to do it [19:14:11] Hmm [19:14:24] "This will likely get done before or as part of the splitting of repositories." [19:14:26] hahaha [19:14:27] Ahm, nope [19:14:43] (03PS1) 10Kmenger: Error: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/201790 [19:14:53] I'm happy for Krinkle|detached to work on that bug, but I don't think anyone should wait for it to happen [19:15:38] hey. [19:15:45] * Krenair waves [19:16:06] Oh hey [19:17:07] MatmaRex: I'm about to put a v0.9.6 release commit in MW [19:17:20] MatmaRex: Could you then make sure it has the Resources.php stuff we need? [19:18:13] RoanKattouw: um, sure. i think most everything we need is already there, we'll need to add the icon pack or two that James imported from VE [19:18:20] OK [19:18:25] sorry i broke stuff, eh [19:18:26] Well I gotta run, will be back in 40 mins at most [19:18:29] (1pm PDT) [19:18:43] In the meantime, could you get https://gerrit.wikimedia.org/r/201653 into shape, Resources.php-wise? [19:18:50] Then when I come back I'll do the composer stuff and land it [19:19:56] RoanKattouw_away: actually, no new packs [19:20:16] just the new files. i'll look. [19:36:57] Error: Unknown dependency: user [19:36:58] what [19:38:23] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1178858 (10Esanders) I think this should be handled by Parsoid. The following HTML:

F 10VisualEditor, 10VisualEditor-DataModel, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1178859 (10Esanders) [19:45:43] RoanKattouw_away, so in TargetLoader we rely on the 'user' and 'site' modules (MW core) being available. These modules inherit from ResourceLoaderWikiModule which inherits this from ResourceLoaderModule: protected $targets = array( 'desktop' ); [20:03:56] 10VisualEditor, 6Community-Liaison, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1178929 (10Cenarium) If a trial is considered, then the options should be removed (except cat... [20:13:29] Krenair: Ugh, right [20:13:39] I'm not sure that these are supposed to be loaded on mobile. [20:13:43] jdlrobson didn't appear to be around [20:14:10] Why do we try to load these separately anyway? [20:16:09] Well the theory is that they could fail and we don't want to be held up by that [20:16:19] In practice they don't fail but just stay pending forever instead, that's a bug in RL [20:16:33] unless you try to load them on mobile [20:16:36] then they fail [20:16:41] well, 'user' does [20:16:53] right [20:17:03] at least with my user scripts [20:20:45] anyway that should be the only deeper issue to solve. assuming we don't care that the overlay show function won't actually show instantly, but instead trigger the ve loading process [20:21:51] What is the "overlay show function"? [20:22:14] VisualEditorOverlay.show [20:22:44] MatmaRex: Argh, I'm an idiot, I didn't rebuild before publishing :( [20:22:50] And npm publish is broken for me [20:23:28] "Once a package is published with a given name and version, that specific name and version combination can never be used again, even if it is removed with npm-unpublish(1)." [20:23:30] Lovely [20:23:52] So we'll have to go to 0.9.7 because I'm an idiot [20:24:11] And I can't publish it without help because npm is a piece of garbage [20:25:31] heh [20:25:42] (03PS1) 10Catrope: Tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201839 [20:25:49] MatmaRex: Can I grab a +2 on ---^^ ? [20:25:53] RoanKattouw: we'll have to go to 0.9.7 because i made a stupid typo :) [20:26:08] (03PS2) 10Bartosz Dziewoński: Tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201839 (owner: 10Catrope) [20:26:09] Well that was a justification for going from 0.9.5 to 0.9.6 [20:26:13] (03CR) 10Bartosz Dziewoński: [C: 032] Tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201839 (owner: 10Catrope) [20:26:15] more typos [20:26:28] 0.9.7 was my typo :) [20:26:38] Oh and thanks for fixing that typo [20:26:42] We're hopeless, aren't we [20:26:48] indeed [20:26:49] James takes one day off and look at us :P [20:30:51] (03Merged) 10jenkins-bot: Tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201839 (owner: 10Catrope) [20:30:52] RoanKattouw, alright, mobile is simply not going to work with those modules [20:31:01] we'll have to remove their loading from targetloader [20:31:32] OK, that's fin [20:31:33] e [20:31:47] We can move that to a desktop-specific place then [20:32:07] Probably by doing something like this in VPT init: [20:32:33] targetLoader.addPlugin( function () { return mw.loader.using( [ 'user', 'site' ] ).then( null, function () { return $.Deferred().resolve(); } ); } ); [20:34:02] RoanKattouw, not just add it to the list of things to load in getTarget? [20:34:51] No because we don't want failures for user/site to hold us up [20:35:14] Like I said, that logic doesn't currently work due to a bug in RL, but I feel like we should preserve the logic that Timo and Bartosz put in there [20:35:21] alright [20:35:48] actually it makes sense looking at the current code in there, yeah [20:35:49] ok [20:36:08] gonna make a task to unbreak mobile [20:37:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 10MobileFrontend: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1179045 (10Krenair) 3NEW a:3Krenair [20:38:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 10MobileFrontend: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1179055 (10Krenair) [20:42:30] (03PS1) 10Alex Monk: Only try to load 'site' and 'user' modules on desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201842 (https://phabricator.wikimedia.org/T95044) [20:42:33] Krenair: Thanks for taking this on man [20:46:58] (03CR) 10Catrope: [C: 032] Only try to load 'site' and 'user' modules on desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201842 (https://phabricator.wikimedia.org/T95044) (owner: 10Alex Monk) [20:48:02] (03PS2) 10Krinkle: build: Use grunt-contrib-copy instead of our own implementation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201687 [20:49:21] (03Merged) 10jenkins-bot: Only try to load 'site' and 'user' modules on desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201842 (https://phabricator.wikimedia.org/T95044) (owner: 10Alex Monk) [20:51:34] RoanKattouw, I guess this should be marked a Q4 blocker? or shall I leave that to James? [20:51:42] it does block a q4 blocker.. [20:59:45] Yeah mark it as Q4 [20:59:52] We mortals can only nominate for Q4 anyway [21:00:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, and 3 others: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1179179 (10Krenair) [21:00:06] Only James (and maybe Trevor?) can move tickets to statuses other than nominated [21:01:08] (03PS1) 10Catrope: Actually tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201847 [21:01:19] Krenair: Can I grab a +2 on that ---^^ ? [21:01:23] (The embarrassment continues...) [21:02:07] hah [21:02:17] dependency outdated, RoanKattouw? [21:02:34] (03PS2) 10Alex Monk: Actually tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201847 (owner: 10Catrope) [21:02:42] Oh [21:02:44] (03CR) 10Alex Monk: [C: 032] Actually tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201847 (owner: 10Catrope) [21:02:45] Well there you go [21:02:50] We're having such a good day, obviously [21:02:51] was only a commit message change [21:02:56] just rebased [21:03:36] (03CR) 10jenkins-bot: [V: 04-1] Actually tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201847 (owner: 10Catrope) [21:03:58] hah [21:04:06] wta [21:04:21] 21:03:35 npm ERR! EBADF, fstat [21:04:25] 21:03:35 npm ERR! errno 9 [21:04:29] WTF [21:04:38] Probably a fluke? [21:04:38] from npm install [21:04:45] This release is cursed [21:05:16] (03CR) 10Alex Monk: [C: 032] Actually tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201847 (owner: 10Catrope) [21:05:26] hm [21:05:39] how do I make jenkins try merging again? [21:05:50] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Split interfaces for internal and external links - https://phabricator.wikimedia.org/T93700#1179203 (10Catrope) [21:05:52] It'll go [21:06:33] I probably could've retried it through the jenkins web ui [21:06:45] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Use 'search' icon (magnifying glass) in link inspector text input - https://phabricator.wikimedia.org/T93699#1179206 (10Catrope) [21:06:46] (03Merged) 10jenkins-bot: Actually tag 0.9.7 [oojs/ui] - 10https://gerrit.wikimedia.org/r/201847 (owner: 10Catrope) [21:06:47] No it's fine [21:06:56] +2ing it causes it to run again, even if it was -1ed before [21:07:06] If the +2 run fails, you need to +2 again [21:07:15] Either by getting someone else to +2, or by removing your vote and then +2ing again [21:07:39] 10MediaWiki-ResourceLoader, 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, and 3 others: Import WikiEditor's list into the Special Character inserter - https://phabricator.wikimedia.org/T91608#1179212 (10gpaumier) [21:07:40] I removed all the votes and +2d again [21:07:49] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 5WMF-deploy-2015-04-01_(1.25wmf24), and 2 others: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1179213 (10gpaumier) [21:07:54] Yeah that works [21:08:00] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 5WMF-deploy-2015-04-01_(1.25wmf24), and 2 others: VisualEditor: Would be nice if copying/pasting kept working after a fatal - https://phabricator.wikimedia.org/T68229#1179214 (10gpaumier) [21:12:18] I slept all day apparently. Phone battery died. :-/ [21:12:40] I need https://gerrit.wikimedia.org/r/#/c/201691/ and https://gerrit.wikimedia.org/r/#/c/201687/ to unblock my current two stacks. [21:12:48] Krinkle, your sleep cycle depends on the phone? [21:13:00] mooeypoo: I guess i needed the sleep :) [21:13:13] Krinkle, exactly, I was going to say it sounds like *you* need a charger [21:13:13] :D [21:18:31] (03CR) 10Mooeypoo: [C: 04-1] Assigning width and height to MWAlienNodes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [21:18:43] hi - may i ask here about the TemplateData extension? I dont understand why the API permits much more information than the element? How are the values for the fields in the API specified? [21:19:34] hypergrove, what do you mean more information than the element ? [21:19:58] The TemplateData extension dictates what can go inside the element, too... I'm not sure I understand what you mean? [21:20:32] from the doc it appears for instance that the "default" of a param is available in the API but it's not specified in [21:21:15] hypergrove, that's because not all parameters *must* have all properties [21:21:23] "The JSON structure provided in response to an API HTTP get request is significantly different than that which is defined in the ." [21:21:29] you could also have a templatedata string that is just { params: {} } [21:21:42] or { params: { param1: {}, param2: {} } } [21:21:58] where does the API get its values if not from [21:21:58] In that case both of those parameters will have the default values [21:22:22] hypergrove, it has default values for each of the parameters, either empty string, or some boolean true/false or null as defaults [21:22:37] where does the API get its values if not from [21:22:39] whatever is specified in the string overrides that [21:22:58] then what does this mean? "The JSON structure provided in response to an API HTTP get request is significantly different than that which is defined in the ." [21:23:11] uh [21:23:14] where do you see this? [21:23:21] https://www.mediawiki.org/wiki/Extension:TemplateData [21:24:01] hypergrove, yes, and the explanation to why is underneath :) [21:24:35] the API response adds stuff -- two wrapping objects (pages / page objects, etc) and then additional templatedata objects [21:25:04] removing inherits keys, adds 'sets' keys, paramOrder is filled up in case it's not being given in the string... etc [21:25:44] ok, is default something I can specify in the json? [21:26:00] per parameter, yes [21:26:13] And we just made it work with language-specific values, too. [21:26:28] understood about per parameter. Then why is 'default' not mentioned outside the context of the API? [21:26:35] do you see why it's confusing me? [21:26:47] no.. ? I don't understand where you expect to see it? Is it not in the spec ? [21:26:48] that is cool to hear, very bvery much so [21:26:48] it should be [21:27:32] oh i didnt search enough [21:27:53] hypergrove, however, you did raise an important point -- it should be interfaceText [21:27:55] I'm fixing now [21:28:48] Fixed [21:28:59] hypergrove, if you refresh that page, default is now InterfaceText as it should be [21:29:24] is InterfaceText mapped to textarea? [21:29:28] a textarea? [21:29:35] InterfaceText allows for languages [21:29:49] hang on, the specs page actually explains it better [21:30:01] Krinkle, where is the specs page online ? it was in github, I can't find it..? [21:30:15] es5.github.io [21:30:25] https://github.com/wikimedia/mediawiki-extensions-TemplateData/blob/master/Specification.md [21:30:26] oh https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FTemplateData/24005eb2e1254cae9c2259f521c3690f723dbcb9/Specification.md [21:30:40] or that, yes, that's what I remembered. Thanks Krinkle [21:31:00] You should be really proud of your work with the VE - it's terrific [21:31:17] Thanks hypergrove :) We're really glad you like it! [21:31:19] the whole team's just great [21:31:59] hypergrove, here, that's what I was looking for -- the Specifications.md page explains interfaceText better: https://github.com/wikimedia/mediawiki-extensions-TemplateData/blob/master/Specification.md#35-interfacetext [21:32:03] and thanks :) [21:32:07] so I have a parameter for a template that is to be a series of template calls ..... how? [21:32:31] hmm. These cells are wikitext or templates ? [21:32:58] |param={{t1}}{{t2}}... [21:33:06] okay, so templates. hm. [21:33:44] I'm wondering if the type is "unbalanced wikitext" or content? Krinkle you understand better than me in templates and how they integrate parameters. Assistance? [21:33:48] specifically {{semantic|facts={{prop|value|metadata}}{{prop|values|metadata}}}} [21:34:22] hypergrove, you can document this in the Description [21:34:29] mooeypoo: unbalanced means the given value cannot be represented as a single rendering (without hacks). Eg. without
[21:34:32] such as {{open table}} [21:34:33] soon we'll have an 'example' field that you could add [21:34:47] Krinkle, oh. Not individual table cells ? [21:34:51] an example field would be awesome wholeness [21:35:06] mooeypoo: Hm.. depends on the format. [21:35:10] hypergrove, coming soon! :) [21:35:13] mooeypoo: Wikitext has no syntax for table cells [21:35:20] mooeypoo: Only for table cells inside tables. [21:35:29] if you put | sdfsd | on a page that's not a table cell. [21:35:30] So it's unbalanced. [21:35:41] Krinkle, yeah it seems to be using templates, which is why I figured it's "unbalanced" wikitext, because it requires to be inside a template itself? [21:35:52] sorry inside a TABLE itself [21:36:01] would the type for such a (templates) parameter be 'content' ? [21:36:24] Krinkle, (speaking of which, re-review please? :) https://gerrit.wikimedia.org/r/#/c/194386/ ) [21:36:30] mooeypoo: The point of unbalanced is for VE to decide whether to render a text area or a full on VE surface. [21:36:35] Similar to what we do with references already [21:36:40] but for template parameters of type 'content' [21:36:46] I see [21:37:15] So anything that won't render into a "balanced" (Parsoid terminology) sub document cannot be used in that way [21:37:30] Hmm [21:37:52] Okay, so a parameter that allows for a series of templates (that each define table cell) [21:37:57] that is of type... string? [21:38:23] It's nested templates, I'm not sure if that counts as unbalanced [21:38:27] or content [21:38:46] mooeypoo and Krinkle, I'm giving a talk next month about how to create SMW apps with VE, so the "example" field will be quite useful, and the multilang part I need to cover too [21:39:13] right - the templates will each be 'balanceable' [21:39:25] hypergrove, it's literally coming up. Waiting for a bit more review and will be hopefully merged in the next week or so. [21:39:40] abulocity [21:39:57] you can follow the phab ticket about it if you want https://phabricator.wikimedia.org/T53049 [21:40:10] nothing like serving steaming soup at smwcon! [21:40:30] :D [21:42:50] "maniphest" - come on.... what's next - phestivals [21:42:52] ? [21:43:07] haha [21:43:32] Isn't this system by facebook? Maybe the next step if phacebook [21:43:51] subscribed thank M... is there a good one for the multilang changes to subscribe to? [21:44:09] phooey on phacebook [21:44:21] hehe [21:44:27] what do you mean by multilang changes? [21:44:37] specifically TemplateData or generally i18n stuff? [21:45:18] i want to the UI to show correct language - i have 14 to deal with! [21:46:10] something like "default": {{"en": "en", "af": [21:46:13] etc [21:46:56] is that how it works? easy enuf that [21:47:08] hypergrove, so the dialog does it for you [21:47:39] i got it - thats the Interface Text you mentioned for default..... [21:47:40] in TemplateData, you can switch languages and edit the parameters again, and the fields that are multilingual (not all are, be careful) will change per language [21:47:49] yes, interfaceText allows for languages [21:47:57] that's the only one i guess [21:48:09] nono [21:48:11] uhm [21:48:12] hang on [21:48:24] Label, Description, Default [21:48:27] I think that's it (?) [21:48:42] yeah [21:48:59] Label, description and default. Description is multilingual for both general template and in each parameter [21:49:25] hypergrove, you can see which fields support languages by the parentheses next to them [21:49:36] so in the TemplateData Editor you'll have Label (en) [ ..... ] [21:50:08] then if you switch to another language, like French, when you go to edit the parameter again you'll see Label (fr) [....] [21:50:33] right those 3 are Interface Text objects... i understand much now .... my suggestion is to move the API documentation to a different page, as it confuses those only looking for what to do with the page json [21:50:57] like me :) [21:51:15] hm, we might want to go over the entire documentation and adjust it a bit [21:51:21] I'll check that out [21:51:52] one last question please [21:52:42] I want to integrate a textarea editor into VE to handle the one positional parameter for a certain template [21:52:51] let' [21:53:31] let's call this template "Turtle" --> {{turtle|this.topic is:a Person.}} [21:55:12] I understand now the param would be type 'content' though the type clearly needs to map to a UI js object.... Are the types suppported by VE pluggable? [21:56:21] wait, a textarea editor ? [21:56:35] 10VisualEditor, 10VisualEditor-DataModel, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1179340 (10ssastry) The interesting part about this is that @cscott and I argued against @gwicke in https://phabricator.wikimedia.... [21:56:41] oh, you mean the parameter should be in a textarea [21:56:51] Are, or will, VE support a pluggable editor for a new parameter 'type'? [21:56:55] according to what Krinkle explained before, it seems to go with Content type [21:57:01] VE can potentially access any type of parameter that TemplateData is prepared to give it [21:57:08] We can not currently even change the UI based on this [21:57:23] (the hard-coded set of types that TemplateData can give us) [21:57:57] see https://gerrit.wikimedia.org/r/#/c/169936/ [21:58:11] i hear that it's hard-coded for the moment... but that will change perhaps (soon)? [21:58:12] We'd need to provide the ability for editors to ignore completely nonsense types [21:58:28] Krenair, well, to be fair, our types are set [21:58:31] i hear that the set of param types is hard-coded for the moment... but that will change perhaps (soon)? [21:58:44] Which means allowing fallback to textarea [21:58:48] right [21:58:50] hypergrove, hm. Not sure, but possibly. [21:59:10] That's part of why we ask for those types after all [21:59:12] It needs input from Design, really. [21:59:30] It also needs to handle current values that are not valid for the given type. [21:59:32] Krenair, hypergrove, yeah I don't think this is coming anytime soon, but it is a good idea to think about this question [21:59:49] Krenair, that shouldn't happen actually [22:00:03] there are no values that aren't valid, the templatedata extension validates the types to only what we have [22:00:11] as a VE feature, it would be mighty important. I also want to add to the VE menu, and slowly tracking that done among all the 'inspector' and whatnots code [22:00:13] What? [22:00:29] 11 types right now [22:00:53] Yes, and you can set the parameter's type to any of them. [22:00:58] yes [22:01:01] but not to anything else [22:01:07] the 'date' type could use a calendar someday [22:01:07] You're missing the point. [22:01:19] Another editor will come along and give a value for the parameter that is, per the type, not valid. [22:01:39] That editor is not likely to even have permission to change the type of the parameter. [22:01:46] Right [22:01:51] Hm [22:01:55] We need to be able to accommodate this in VE. [22:02:02] Well, we could fall back onto content, though [22:02:06] And also handle the reverse - a bogus type being set per existing values [22:02:07] but yes, you're right [22:02:53] The problem is how it should be shown in the UI. [22:03:02] Which is why the task is marked as needing design [22:03:28] i want smw apps to be in a position to toss SemForms for the VE -- to do so I need to specify type: SMWProperty or something, so that I can populate the menu of candidate values from the triples database [22:03:30] * mooeypoo nods [22:03:38] Krenair, is there a task for this at all in phabricator? [22:03:39] !hss [22:03:44] mooeypoo, see the link [22:05:08] what link? [22:05:08] looked at link, don't see a reference to pluggables [22:05:10] 31<Krenair>30 see https://gerrit.wikimedia.org/r/#/c/169936/ [22:05:33] i have to run for a tiny bit, i'll be right back [22:05:34] hypergrove, as I said, we don't even support different UI for each current hard-coded type in TemplateData [22:05:54] we're definitely not going to be able to support custom types until this is sorted [22:06:24] krenair not exactly understanding "different UI" concept [22:06:42] we currently show a textarea regardless of type [22:07:21] this task is about changing that UI widget based on the type [22:07:43] that's right - and its not textarea its just a text widget [22:08:02] that's a problem for me in the near term to figure out - i need textarea not text [22:08:13] MatmaRex: How does https://gerrit.wikimedia.org/r/#/c/201653/ look? [22:08:40] hypergrove, we already give a textarea don't we? [22:09:30] RoanKattouw_away: probably good. [22:09:34] no, they're 'text' widgets, not textarea.... i am looking for a 'textarea' widget, assumed it was shown for 'content' type .... i am just testing all this out now you see! [22:09:37] RoanKattouw_away: we might want to remove 'resources/lib/oojs-ui/oojs-ui-mediawiki-noimages.css' for now [22:10:03] RoanKattouw_away: i'll submit the patch to use RLImageModule for this stuff later today, or over the weekend [22:10:09] hypergrove, *shrug* shows as textarea to me [22:10:44] Krenair, r u referring to type 'content' ? great! but textarea is not shown for type 'date' [22:10:55] it's textarea for any type [22:11:03] oh my - why? [22:11:15] ... We just had this discussion. [22:11:42] ok i'm getting it, sorry for density issue here [22:12:26] hey thanks! i'm back to testing this all out. [22:25:11] (03CR) 10Jforrester: [C: 032] build: Use grunt-contrib-copy instead of our own implementation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201687 (owner: 10Krinkle) [22:27:20] (03CR) 10Jforrester: [C: 032] buid: Include utils.js in jsduck and add 'doc' entry point [oojs/core] - 10https://gerrit.wikimedia.org/r/201691 (owner: 10Krinkle) [22:27:35] (03Merged) 10jenkins-bot: build: Use grunt-contrib-copy instead of our own implementation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201687 (owner: 10Krinkle) [22:28:14] (03CR) 10Jforrester: [C: 032] build: Declare grunt-cli dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201686 (owner: 10Krinkle) [22:29:59] (03CR) 10jenkins-bot: [V: 04-1] buid: Include utils.js in jsduck and add 'doc' entry point [oojs/core] - 10https://gerrit.wikimedia.org/r/201691 (owner: 10Krinkle) [22:30:17] (03CR) 10Jforrester: [C: 031] "Good to go once dependency is pulled through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201685 (owner: 10Krinkle) [22:32:06] (03CR) 10Jforrester: [C: 032] Error: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/201790 (owner: 10Kmenger) [22:32:29] 10VisualEditor, 10VisualEditor-ContentEditable: VE ignores some changes? - https://phabricator.wikimedia.org/T95059#1179425 (10tarlocesilion) 3NEW [22:35:16] (03CR) 10Jforrester: "Needs an RTL flipped version made for the second one, and a decision about which icon pack to add this to (and adding to the demo page). H" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [22:35:25] (03Merged) 10jenkins-bot: Error: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/201790 (owner: 10Kmenger) [22:36:26] (03CR) 10Jforrester: "Didn't you say you were worried about this working in LTR?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [22:38:58] (03CR) 10Jforrester: [C: 032] "Eurgh." [oojs/core] - 10https://gerrit.wikimedia.org/r/201691 (owner: 10Krinkle) [22:39:00] 10OOjs-UI, 7Documentation: Documentation for OOjs UI widgets needs to list what methods are available for each widget - https://phabricator.wikimedia.org/T95060#1179448 (10kaldari) 3NEW [22:41:15] 10OOjs-UI, 7Documentation: Documentation for OOjs UI widgets needs to list what methods are available for each widget - https://phabricator.wikimedia.org/T95060#1179458 (10kaldari) [22:41:41] (03Merged) 10jenkins-bot: buid: Include utils.js in jsduck and add 'doc' entry point [oojs/core] - 10https://gerrit.wikimedia.org/r/201691 (owner: 10Krinkle) [23:29:36] James_F|Away: There's a filter on Zuul dashboard now (I upstreamed our dashboard, and openstack added that bit). So you can justify an extra monitor and filter it for jobs containing "oojs" only. And one for VisualEditor, naturally. :D [23:30:29] it's case-insensitive, and takes comma separated values. whitespace ignored. [23:30:38] (based on code, not yet documented) [23:43:50] Krinkle, just a (gentle) reminder, if you can re-review this, https://gerrit.wikimedia.org/r/#/c/194386/ [23:45:15] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/201632/ [23:47:33] 10VisualEditor, 10VisualEditor-DataModel, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1179579 (10Esanders) FYI The reason they don't always get merged in VE is because we compare DOM attributes. Links created afresh... [23:48:41] (03CR) 10Mooeypoo: Create a preview widget (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [23:50:03] (03CR) 10Mooeypoo: "No no, this works in both. It simply switches the alignment value-- but only in RTL -- to the opposite. So if the code states alignment "l" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [23:53:52] Krinkle: Nice! [23:54:02] Krinkle: I'll try to set that up after moving the Zuul monitor upstairs [23:54:14] I wondered if you guys were planning to move that :p [23:54:25] If you want you guys can attend the standup in 6 minutes [23:54:38] I stole the hangout-on-wheels rig and put it in our office [23:54:52] Trevor, Moriel and I have just moved there this afternoon [23:55:05] James is out today and in the UK the next two weeks but some time soon I'll have to move his stuff [23:55:12] Meanwhile [23:55:35] Let's do an OOUI release [23:55:52] (03CR) 10Mooeypoo: Create a preview widget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [23:57:22] (03PS1) 10Catrope: Update OOjs UI to v0.9.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201872