[00:00:24] Negative24: i'm just leaving now, but i'll reply tomorrow, hopefully [00:00:31] sounds good [00:00:41] working on a weekend? [00:03:33] not working, just lurking here. :) [00:04:15] (03CR) 10Prtksxna: "Todo: Add documentation" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201680 (https://phabricator.wikimedia.org/T87714) (owner: 10Prtksxna) [00:06:43] gotcha [00:07:12] 10VisualEditor: [Change title] VE resizes the window when creating a redlink in mainspace (svwp) - https://phabricator.wikimedia.org/T95135#1181081 (10Josve05a) 3NEW [00:10:44] 10VisualEditor: [See video, change title and change description] - https://phabricator.wikimedia.org/T95136#1181088 (10Josve05a) 3NEW [00:21:17] 10VisualEditor: Copying link makes it relative to edited page - https://phabricator.wikimedia.org/T95136#1181097 (10Negative24) [00:28:16] 10VisualEditor: VE mangles the UI when creating a non-existent page in mainspace (svwp) - https://phabricator.wikimedia.org/T95135#1181100 (10matmarex) [00:28:44] 10VisualEditor, 10VisualEditor-MediaWiki: VE mangles the UI when creating a non-existent page in mainspace (svwp) - https://phabricator.wikimedia.org/T95135#1181081 (10matmarex) I can reproduce, but only on sv.wp. [00:35:55] 10VisualEditor: Copying link makes it relative to edited page - https://phabricator.wikimedia.org/T95136#1181110 (10Josve05a) [00:38:38] 10VisualEditor, 10VisualEditor-MediaWiki: VE mangles the UI when creating a non-existent page in mainspace (svwp) - https://phabricator.wikimedia.org/T95135#1181111 (10Josve05a) Also notice in the left hand side menu under "other languages" that Dansk (da) shows up, although it doesn't exists. [00:39:22] 10VisualEditor, 10VisualEditor-MediaWiki: VE mangles the UI when creating a non-existent page in mainspace (svwp) - https://phabricator.wikimedia.org/T95135#1181112 (10Josve05a) [00:41:40] 10VisualEditor, 10VisualEditor-Performance: The progress bar should accelerate as it nears completion - https://phabricator.wikimedia.org/T95137#1181113 (10ori) 3NEW a:3Esanders [01:41:09] Which VE branch is enwiki set to track? [01:44:29] Negative24, VE is like any other extension [01:44:31] Negative24: they both follow the MediaWiki release train. From https://en.wikipedia.org/wiki/Special:Version , you can see that MediaWiki is 1.25wmf23 [01:44:54] so VisualEditor on enwiki will be on a branch of the same name [01:49:30] ori: but its not. enwiki is on 80d8312 and 1.25wmf23 is d062e51 [01:52:43] oh wait. [01:53:01] I don't think we always sync out the git directories to the app servers [01:54:48] if you look at https://github.com/wikimedia/mediawiki-extensions-VisualEditor/commits/wmf/1.25wmf23 Special:Version is claiming it's at the commit just before the branch [01:55:08] yeah just realized that. give me a sec... [01:55:18] anything deployed after that would've only synced the working directory files, not git [01:55:32] and indeed, the one backported change was synced like this: [01:55:46] (1st April) 00:10 logmsgbot: catrope Synchronized php-1.25wmf23/extensions/VisualEditor: SWAT (duration: 01m 07s) [01:58:19] so it ended up being a caching problem [01:59:59] oh, really? [02:00:23] ok.. [02:01:11] but when you deploy a change it only does the changes made before the branch is made? [02:01:34] I'm still not very good a git backend stuff [02:05:21] ... what? [02:19:20] Krenair: working directory vs git in your previous message [02:25:35] 10VisualEditor, 10VisualEditor-CopyPaste: Copying link between wikis cause url linking errors - https://phabricator.wikimedia.org/T95141#1181180 (10Negative24) 3NEW [02:26:30] 10VisualEditor, 10VisualEditor-CopyPaste: Copying link between wikis cause url linking errors - https://phabricator.wikimedia.org/T95141#1181187 (10Negative24) [02:35:51] 10VisualEditor, 10VisualEditor-CopyPaste: Copying link between wikis cause url linking errors - https://phabricator.wikimedia.org/T95141#1181194 (10Negative24) [02:50:00] 10VisualEditor, 10VisualEditor-MediaWiki: VE mangles the UI when creating a non-existent page in mainspace (svwp) - https://phabricator.wikimedia.org/T95135#1181205 (10Krenair) Cannot reproduce... [03:43:22] 10MediaWiki-Page-editing: Allow anonymising of IP editors - https://phabricator.wikimedia.org/T20981#1181278 (10MZMcBride) https://www.mediawiki.org/wiki/Requests_for_comment/Exposure_of_user_IP_addresses This task is a great find to expand my new RFC! [05:42:18] 10MediaWiki-ResourceLoader: Remove render-blocking JavaScript - https://phabricator.wikimedia.org/T95152#1181364 (10ori) 3NEW a:3ori [09:16:18] (03CR) 10Esanders: "The problem with the DM is bidi and know where up/down takes you. CE handles that best, but skips over ce=false. We could make the ce=true" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [09:19:28] (03CR) 10Esanders: [C: 04-1] WIP: Use cursor holders to reach ce=false nodes with native cursoring (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [09:25:28] 10VisualEditor, 10VisualEditor-Performance: The progress bar should accelerate as it nears completion - https://phabricator.wikimedia.org/T95137#1181743 (10Esanders) The only problem here is the second half corresponds to the converter which is slow because of heavy client-side computation so it may be unavoid... [10:28:20] 10MediaWiki-ResourceLoader, 5Patch-For-Review: ResourceLoader's mw.templates Map is full of empty objects - https://phabricator.wikimedia.org/T88879#1181799 (10Spage) I think all these patches are merged and deployed on beta labs, but by the time mediawiki.js's `execute()` is called, there is an empty `registr... [10:42:57] 10VisualEditor, 10VisualEditor-Performance: The progress bar should accelerate as it nears completion - https://phabricator.wikimedia.org/T95137#1181853 (10Esanders) Tried and failed to add this to the #OriLivnehMindControlDept project. [10:53:15] 10VisualEditor, 10MediaWiki-General-or-Unknown, 7Mobile: Scrolling vertically the dialog for template in a ref fails and scrolls the visual content instead - https://phabricator.wikimedia.org/T95159#1181864 (10Nnemo) 3NEW [10:53:50] 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 10Wikidata, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1181878 (10Multichill) Just seemed to have hit this bug. Output from pywikibot: >>> Miklagard <<< Adding P641 --> [[wikidata:Q5377]... [10:57:12] 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 10Wikidata, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1181885 (10aude) stacktrace for the error that multichill got: /w/api.php MWException from line 1783 of /srv/mediawiki/php-1.25wm... [10:59:12] 10VisualEditor: Newly created links are not merged with parsed links - https://phabricator.wikimedia.org/T95160#1181889 (10Esanders) 3NEW [10:59:21] 10VisualEditor: Newly created links are not merged with parsed links - https://phabricator.wikimedia.org/T95160#1181897 (10Esanders) a:3Esanders [10:59:32] (03PS1) 10Esanders: Ignore href DOM attribute when comparing links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202015 (https://phabricator.wikimedia.org/T95160) [11:02:17] (03CR) 10jenkins-bot: [V: 04-1] Ignore href DOM attribute when comparing links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202015 (https://phabricator.wikimedia.org/T95160) (owner: 10Esanders) [11:07:22] (03PS2) 10Esanders: Merge MW internal link annotations if they have the same target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201896 (https://phabricator.wikimedia.org/T95028) [11:09:33] (03PS2) 10Esanders: Ignore href DOM attribute when comparing links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202015 (https://phabricator.wikimedia.org/T95160) [11:44:03] 10OOjs-UI, 7Documentation: Documentation for OOjs UI widgets needs to list what methods are available for each widget - https://phabricator.wikimedia.org/T95060#1182030 (10Spage) @kaldari, have you looked at the generated jsduck documentation at https://doc.wikimedia.org/oojs-ui/master/#!/api/OO.ui.ButtonWidge... [12:21:01] 10OOjs-UI: Make it possible to generate only the distribution files that are actually wanted - https://phabricator.wikimedia.org/T92464#1182050 (10matmarex) [13:05:15] (03CR) 10Paladox: "@Perhelion everytime I try to compress it the the insert-signature.svg I have in the button-sprite.svg changes the top bit of the penicil " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [13:32:47] (03PS4) 10Physikerwelt: Improve layout of Special:MathStatus [extensions/Math] - 10https://gerrit.wikimedia.org/r/200604 (https://phabricator.wikimedia.org/T94434) [13:33:37] (03CR) 10Physikerwelt: "any updates?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [14:09:57] (03CR) 10Manybubbles: "Sorry! I got distracted. I've got it setup but haven't imported any actual math yet. Are there good pages I should import with much mat" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [14:10:45] is it possible to remove a particular item from table context menu then add it back? if i use removeItems then it removes all the items. [14:14:04] (03CR) 10Physikerwelt: "Yes. WP:Math http://en.wikipedia.org/wiki/Help:Displaying_a_formula" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [14:20:35] MatmaRex:is it possible to remove a particular item from table context menu then add it back? if i use removeItems then it removes all the items. [14:25:14] (03PS49) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [14:26:14] (03CR) 10Paladox: "@Perhelion I have compressed it now." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [14:42:07] 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 10Wikidata, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1182177 (10daniel) Does this still happen despite Aaron's fix in I57eb41b463? Or isn't that deployed yet? [14:46:38] 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 10Wikidata, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1182184 (10aude) @daniel just checked... apparently not deployed yet to Wikidata https://github.com/wikimedia/mediawiki/commits/wmf... [14:51:21] hey James_F|Away I guess you’re not around :p [15:20:46] I want to remove a particular item from table context menu then add it back? if i use removeItems then it doesn't work [15:28:58] 10MediaWiki-Page-editing: Allow anonymising of IP editors - https://phabricator.wikimedia.org/T20981#1182268 (10MZMcBride) [15:58:45] * James_F waves from London. [16:00:07] 10VisualEditor, 10MediaWiki-General-or-Unknown: The refs have their number and their style altered - https://phabricator.wikimedia.org/T95176#1182396 (10Nnemo) 3NEW [16:17:45] (03PS1) 10Jforrester: Update VE core submodule to master (8e8b975) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202047 [16:22:06] Hi James_F [16:22:24] Hello from not-very-far-away. [16:22:40] James_F: Are the Editing Team spending time in London after the Hackathon? [16:22:42] 10VisualEditor, 10VisualEditor-ContentLanguage: VisualEditor lost the first character when inputing with some IME - https://phabricator.wikimedia.org/T70893#1182501 (10Nemo_bis) Does this block T51569? [16:23:49] Deskana: Before. [16:24:21] sux [16:24:38] I'm probably going to London for a day after the Hackathon some time. [16:26:30] I will be in London for the Tuesday evening. [16:26:35] Fly back to SFO on the Wednesday. [16:27:21] James_F: Hah, maybe I'll see you in the homeland then! Tuesday might be the day I go. [16:27:24] To the office! [16:27:30] WMUK's? [16:32:27] (03PS3) 10Jforrester: build: Move pre/post 'doc' task into package.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201685 (owner: 10Krinkle) [16:32:53] (03CR) 10Jforrester: [C: 032] "Rebased onto the necessary pull-through. Works fine." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201685 (owner: 10Krinkle) [16:33:00] (03PS3) 10Jforrester: build: Declare grunt-cli dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201686 (owner: 10Krinkle) [17:03:03] edsanders:for updating the context menu I tried to remove a particular item from table context menu then add it back, i used removeItems but it didn't work [17:10:42] 10VisualEditor, 10MediaWiki-General-or-Unknown: The refs have their number and their style altered - https://phabricator.wikimedia.org/T95176#1182625 (10Nnemo) [17:10:53] edsanders, https://phabricator.wikimedia.org/T95069 [17:11:01] edsanders, but you must read it with a high-pitch voice. [17:11:12] mooeypoo, i'll get in charcter [17:11:58] pratikbsp, you shouldn't have to remove it, just have the item update it's own label by listening to an event [17:14:07] 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 3Roadmap, and 2 others: Be able to re-order the columns or rows of a table by dragging them to another position in VisualEditor - https://phabricator.wikimedia.org/T88694#1182657 (10Catrope) a:3Mooeypoo [17:14:15] 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 3Roadmap, and 2 others: Be able to re-order the columns or rows of a table by dragging them to another position in VisualEditor - https://phabricator.wikimedia.org/T88694#1018205 (10Catrope) a:5Mooeypoo>3None [17:17:45] 10VisualEditor, 10VisualEditor-Tables: Support sortable columns in tables - https://phabricator.wikimedia.org/T95189#1182693 (10Whatamidoing-WMF) 3NEW [17:19:41] OK, heading out [17:19:45] * James_F waves. [17:23:55] 10VisualEditor, 10MediaWiki-General-or-Unknown: The refs have their number and their style altered - https://phabricator.wikimedia.org/T95176#1182720 (10Nnemo) [17:24:46] mooeypoo: ve.ce.nodeFactory.create( dmNode.getType(), dmNode ); [17:32:45] edsanders, did we always have MWImageCaptionNode and MWBlockImageCaptionNode ? [17:33:27] oh, wait, MWImageCaptionNode and BlockImageCaptionNode (non-mw) [17:33:27] BlockImageCaption is core, not MW [17:33:45] it's newer than MW [17:33:51] just noticed. Okay. But MWImageCaptionNode shouldn't extend the ve-core one? [17:34:59] mooeypoo, it probably could [17:35:04] edsanders:how can i update it without removing it,i didn't find any method for that [17:35:23] they're both based on
so it would make sense [17:35:24] Where is Krinkle|detached? :/ [17:35:41] pratikbsp, does it not have setLabel? [17:36:11] edsanders, yeah I ws just confused about the difference between the two, not really urgent - just looked at both of those for generalizing the MWPrviewNode [17:36:16] I'll go with general node anyways [17:36:26] got it [17:36:49] it's provided by the mixin OO.ui.LabelElement, so not very obvious [17:37:33] mooeypoo, yeah - as the core functionality was brought in from MW, there's not as much shared code as I'd like [17:38:09] edsanders, there probably could be, though. Is this a preparation for having media support in core? [17:38:34] There's already some form of media support if you look at the images demo page [17:38:45] but yeah - I have a local WIP for a dialog [17:38:53] There probably could be more shared code if we refactor the mw side of it. Some of the functionality is "just" regular attribute changes [17:38:59] I guess it should be MWBlockImageCaption [17:39:15] Not that there's a caption for any other image type.. [17:39:22] although you'd need to remind me what we do with the caption when you convert from block to inline [17:39:24] I mean, inline images won't have captions in either ve core or mw [17:39:37] ah yes that's... a good question [17:39:59] in mw it is either the alternate text or it isn't, really. It's the alt text if no alt text is given. [17:40:10] even if we do keep it we should probably convert it to mwinlinecaption that doesn't generate any HTML [17:40:41] do we keep the DM in case it is converted back? or do we bin it? [17:40:42] edsanders, or keep it as an attribute? [17:40:51] >>> what [17:40:51] <17SAB9VNK> Krenair: ReferenceError: what is not defined [17:40:51] <1JTAAOGUB> Krenair: ReferenceError: what is not defined [17:40:51] <64MACH3PW> Krenair: ReferenceError: what is not defined [17:40:51] Krenair: ReferenceError: what is not defined [17:41:03] why does it keep doing this? :/ [17:41:32] well also the wikitext allows for inline images with captions, so we might want to keep it even just to prevent dirty diffing ? or like, preserve the information for the wikitext..? [17:41:49] we need to figure out what we want to do. The way it works is annoying, honestly. And very confusing [17:41:58] wikitext-wise, I mean [17:47:39] edsanders, re the preview widget -- I was thinking at first to have a temporary view while the node is building, but you're right about not attaching the initial ce node to the element at all. In that case, though -- do you think I should display a spinner while it's loading? Or just nothing while it builds, then the full dm html when the node's ready? [17:48:00] It should be quick unless the internet connection is crap [17:49:34] to spinner or not to spinner? TrevorParscal your input will help too [17:52:31] (03PS7) 10Mooeypoo: Create a preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [17:58:12] (03CR) 10Mooeypoo: Create a preview widget (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [18:07:02] (03CR) 10Catrope: [C: 032] Don't use a inputFilter on LinkTargetInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201895 (https://phabricator.wikimedia.org/T94498) (owner: 10Esanders) [18:11:23] mooeypoo: hello, please review https://gerrit.wikimedia.org/r/#/c/198397/ , thanks [18:11:46] was about to do that rits , thanks! [18:11:49] will do :) [18:11:59] ok:) [18:12:43] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): View/model out of sync when undoing paragraph creation - https://phabricator.wikimedia.org/T94696#1182959 (10Etonkovidova) Checked the fix in beta. [18:15:57] 10VisualEditor, 10VisualEditor-CopyPaste: Copying link between wikis cause url linking errors - https://phabricator.wikimedia.org/T95141#1182963 (10Catrope) a:3Krenair [18:16:08] Krenair: You wanted work, right? ;) ----^^ [18:17:08] (03Merged) 10jenkins-bot: Don't use a inputFilter on LinkTargetInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201895 (https://phabricator.wikimedia.org/T94498) (owner: 10Esanders) [18:20:27] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8e8b975) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202047 (owner: 10Jforrester) [18:21:13] Also just in case you guys were wondering why iOS Safari is the worst thing ever: https://phabricator.wikimedia.org/T95159#1181864 [18:21:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Scrolling vertically the dialog for template in a ref fails and scrolls the visual content instead - https://phabricator.wikimedia.org/T95159#1182985 (10Catrope) [18:24:28] (03Merged) 10jenkins-bot: Update VE core submodule to master (8e8b975) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202047 (owner: 10Jforrester) [18:25:22] (03Merged) 10jenkins-bot: build: Move pre/post 'doc' task into package.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201685 (owner: 10Krinkle) [18:25:24] (03Merged) 10jenkins-bot: build: Declare grunt-cli dependency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201686 (owner: 10Krinkle) [18:25:50] 10VisualEditor, 10Wikimedia-Site-requests, 3Roadmap, 7notice: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#1183005 (10coldchrist) [18:29:33] mooeypoo, can you explain a little bit more how to adapt https://gerrit.wikimedia.org/r/#/c/200801/9/resources/src/mediawiki/mediawiki.feedback.js ? [18:29:47] We're trying to get this merged today if possible. [18:30:14] 10VisualEditor: HTML entities in CommentNode must be manually escaped/unescaped. - https://phabricator.wikimedia.org/T95040#1183023 (10cscott) Once T95039 is merged, - will start appearing as - in comments until VisualEditor is updated. > and & as well, but they are perhaps less common. [18:35:24] (03CR) 10Catrope: [C: 032] Ignore href DOM attribute when comparing links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202015 (https://phabricator.wikimedia.org/T95160) (owner: 10Esanders) [18:40:10] superm401, so the ProcessDialog (which is what feedback is loading) works with OO.ui.Process withinn the getActionProcess method. The OO,ui.Process return promises by steps, so we create .next() or .first() etc to build the steps and then the dialog executes the steps. [18:40:37] superm401, thing is, that the dialog automatically pushes "pending" state and then pops "pending" states when those promises are started and resolved [18:40:42] Sorry, I just replied to the Gerrit before your IRC reply. [18:40:52] mooeypoo, how does that integrate with the fb.status handling exactly? [18:40:55] so technically speaking, you don't need to push and pop yourself [18:40:59] E.g. [18:41:03] fb.status = 'error3'; [18:41:36] okay, so your postMessage method [18:42:40] that should be in an action process. You should have action === 'pushMessage' case or something and inside it have a process. If you look at the current getActionProcess you can see the separate actions there. [18:42:54] the method should go into the process and return the promise [18:42:54] (03CR) 10Catrope: [C: 032] Merge MW internal link annotations if they have the same target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201896 (https://phabricator.wikimedia.org/T95028) (owner: 10Esanders) [18:43:04] that will cause the dialog to push pending and pop pending on its own [18:43:29] superm401, that makes sense? [18:43:46] superm401, let me find an example for you. I'm using it right in the CItoid inspector. [18:44:16] mooeypoo, thanks, I know how to reject promises with OO.ui.Error, but I haven't seen this .status thing before (might be only in mediawiki.feedback) [18:44:22] superm401, btw, I've been *not* using this correctly myself in the feedback dialog. That should change, I was planning a separate commit to fix that after yours is done [18:44:49] the status is specific to feedback though [18:45:00] it's just a global variable to store the type of error [18:45:43] superm401, the reason is because we load a separate MessageDialog afterwards that presents the message to the user -- either success or error, so the status should pass through. It isn't really a ProcessDialog thing. [18:45:55] mooeypoo, does the context item height recalculate after it gets the final rendering? [18:46:16] mooeypoo, okay, since you're planning a separate follow up commit, is it okay with this not being a blocker? [18:46:58] Or I'm fine with amending mine. [18:47:01] edsanders, you mean in the preview widget? That must be done separately per use, because it depends on the context item. I was talking to trevor about the ReferenceContextItem height thing since it didn't exactly work as planned. It should be in the "clients" of the widget, though. [18:47:26] superm401, yeah I could change both if you want. It will be easier if you change yours too, but not a terrible blocker since I screwed up with my piece too ;) [18:47:55] (03CR) 10jenkins-bot: [V: 04-1] Ignore href DOM attribute when comparing links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202015 (https://phabricator.wikimedia.org/T95160) (owner: 10Esanders) [18:48:05] I don't really like spinners [18:48:40] edsanders, yeah... I know, that's why I asked. On one hand, we can keep it as is, it's fairly quick -- but I'm slightly concerned about slow internet connections and the context item. In those cases, the rendering could take a little bit, and the user won't really have any indication. [18:48:40] if it's going to take a long time use a progress bar [18:48:47] (03CR) 10Catrope: [C: 032] "Come on Jenkins" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202015 (https://phabricator.wikimedia.org/T95160) (owner: 10Esanders) [18:48:53] if it's quick then a flicker of a spinner is pointless [18:49:09] oh, we could do a progress bar. Not entirely sure how to calculate the progress on it, though. [18:49:19] I'll have to think of something. [18:49:26] well there's an indeterminate one [18:49:29] mooeypoo, okay, I'll amend. [18:49:39] So the Citoid example is https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCitoid.git/6adb1e1fcc70b71ac9e531c0bdcc2c90841e556a/modules%2Fve.ui.CiteFromIdInspector.js#L391 , right? [18:49:59] oh awesome, I was looking for that :D [18:50:04] superm401, yes! [18:50:10] mooeypoo, so basically, create a process and have the function passed to the process constructor return a promise? [18:50:15] but for example when templates are recalculating we just set them to opacity 50% [18:50:35] And I guess either postMessage or getActionProcess could add an additional listener to the promise for fb.status. Do you have a preference between those two? [18:50:43] superm401, yea, see how in the action process, whenever an actual action is taken the promises are returned from within the process -- I never push/pop manually. [18:52:13] just so I understand correctly, this is when your citation contains GCNs which haven't finished updating [18:52:17] superm401, the status isn't a promise, it's just a state. You really just need to return that entire promise in the process; you can still set the status up in there? [18:52:45] I guess that happens immediately if you do anything other than basic reference [18:52:52] edsanders, yes. Or any other GCN. If it's not a GCN, the promises will automatically resolve and the dm html will be replaced immediately [18:53:09] edsanders, yeah for now it's mostly references. Might be templates in the future? [18:53:15] mooeypoo, okay, I'll just keep the fb.status's where they are. You'll see what I mean. [18:53:50] superm401, yeah. I can clean up my own mess afterwards and worse case adjust a little. IT should be generally okay, just the promise return within the process will prevent push/pop pending state [18:53:51] so in the real world the spinner would show for the duration of one roundtrip to Parsoid [18:54:03] edsanders, yes [18:54:19] 10MediaWiki-Page-editing: Allow anonymising of IP editors - https://phabricator.wikimedia.org/T20981#1183120 (10awight) [18:54:24] I don't think a indeterminate progress bar is unreasonable [18:54:27] edsanders, though it can be noticeable [18:55:04] outside of the office you're probably talking 1-2s [18:55:53] edsanders, yeah. In citoid it was pretty noticeable (I still need to change it to use the preview widget when it's merged) [18:55:57] it "jumps" a little [18:56:01] resizes itself [18:57:15] not terrible, but it shows intermediate step of constructing the reference right now [18:58:01] 10MediaWiki-Page-editing: Allow anonymising of IP editors - https://phabricator.wikimedia.org/T20981#1183143 (10awight) There are two very different issues here, let's try to address them separately: # Many people will be more comfortable if IP addresses are not revealed on public pages. # CheckUser admins and v... [18:59:42] 10VisualEditor, 6Collaboration-Team, 10Flow, 7JavaScript: FOUC when loading Flow's VisualEditor - https://phabricator.wikimedia.org/T95207#1183145 (10He7d3r) 3NEW [19:07:43] (03CR) 10Esanders: [C: 04-1] Defer loading easy-deflate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [19:10:58] (03CR) 10Esanders: "The "easy" way to clean-up svgs is to run them through SVGO (a nodejs program) although it might be tough to get this set up for designers" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [19:32:09] (03Merged) 10jenkins-bot: Merge MW internal link annotations if they have the same target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201896 (https://phabricator.wikimedia.org/T95028) (owner: 10Esanders) [19:32:13] (03Merged) 10jenkins-bot: Ignore href DOM attribute when comparing links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202015 (https://phabricator.wikimedia.org/T95160) (owner: 10Esanders) [19:43:30] (03CR) 10Hcohl: [C: 031] Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:04:54] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation: HTML entities in CommentNode must be manually escaped/unescaped. - https://phabricator.wikimedia.org/T95040#1183259 (10ssastry) [20:17:24] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation: HTML entities in CommentNode must be manually escaped/unescaped. - https://phabricator.wikimedia.org/T95040#1183297 (10cscott) p:5Normal>3High Raised priority because of user-visible entity escaping which would be v... [20:19:26] 10MediaWiki-Page-editing: Allow anonymising of unregistered users ("IP editors") - https://phabricator.wikimedia.org/T20981#1183309 (10Nemo_bis) [20:19:49] 10MediaWiki-Page-editing: Allow anonymising of unregistered users ("IP editors") - https://phabricator.wikimedia.org/T20981#240035 (10Nemo_bis) [20:23:19] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation: HTML entities in CommentNode must be manually escaped/unescaped. - https://phabricator.wikimedia.org/T95040#1183330 (10ssastry) And, @Mattflaschen and @Ebernhardson as well. [20:24:08] 10MediaWiki-Page-editing: Allow anonymising of unregistered users ("IP editors") - https://phabricator.wikimedia.org/T20981#1183334 (10Nemo_bis) [20:30:47] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation: HTML entities in CommentNode must be manually escaped/unescaped. - https://phabricator.wikimedia.org/T95040#1183402 (10Mattflaschen) We should be covered by the VE fix. I don't think we handle or display comments anywhe... [20:32:03] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Copying link between wikis cause url linking errors - https://phabricator.wikimedia.org/T95141#1183414 (10Krenair) [20:33:18] 10VisualEditor: VisualEditor media search results often include irrelevant PDFs due to full-text search - https://phabricator.wikimedia.org/T95223#1183416 (10Dreamyshade) 3NEW [20:34:16] 10VisualEditor: VisualEditor media search results often include irrelevant PDFs due to full-text search - https://phabricator.wikimedia.org/T95223#1183425 (10Dreamyshade) [20:40:27] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Search: VisualEditor media search results often include irrelevant PDFs due to full-text search - https://phabricator.wikimedia.org/T95223#1183631 (10Catrope) [20:40:55] RoanKattouw, ok, so first finding: [20:41:13] oh, no, wait, hang on [20:41:14] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation: HTML entities in CommentNode must be manually escaped/unescaped. - https://phabricator.wikimedia.org/T95040#1183632 (10Catrope) >>! In T95040#1183297, @cscott wrote: > Raised priority because of user-visible entity esca... [20:41:20] I thought I found something :( [20:41:36] no, it's definitely weird [20:41:46] we create an internal link annotation when pasting these in [20:41:55] but they're created using URLs? [20:42:01] edsanders: ---^^ [20:42:03] so should be external [20:43:04] Yeah why are they not external, that's weird [20:43:14] also, random thing I noticed in grep: [20:43:15] modules/ve-mw/ce/annotations/ve.ce.MWNowikiAnnotation.js:ve.ce.MWNowikiAnnotation = function VeCeMWInternalLinkAnnotation( model, config ) { [20:43:25] lol [20:43:43] Remind me why we use those function names? [20:43:58] so we have a constructor name? [20:45:48] Krenair: So we get this http://i.imgur.com/EQeMSBL.png [20:46:07] right, the constructor name [20:46:15] makes sense [20:48:13] (03PS1) 10Alex Monk: Fix constructor name for ve.ce.MWNowikiAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202231 [20:48:19] RoanKattouw, ^ [20:48:54] Thanks [20:49:09] (03CR) 10Catrope: [C: 032] Fix constructor name for ve.ce.MWNowikiAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202231 (owner: 10Alex Monk) [20:51:03] "Would you like to add to a collection?" [20:51:04] Hmm. [20:51:41] (03Merged) 10jenkins-bot: Fix constructor name for ve.ce.MWNowikiAnnotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202231 (owner: 10Alex Monk) [20:54:07] RoanKattouw, isn't ctrl+A supposed to work in VE? [20:57:20] (03CR) 10Mooeypoo: "Whatever happened to VE not loading shouldn't have happened with the correction of the condition. The condition before was wrong, because " (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [20:58:10] Krenair: It's broken if the first or last thing is a FocusableNode I think [20:58:39] oh yeah, I did something and it's working again [20:58:40] weird [20:59:12] So in these broken internal-external-sort-of links we have the model.getHref() returning a valid URL... and the link it creates in the inspector is fine. But it shows the model's normalizedTitle and uses the URL to check existence [20:59:43] so yeah, the way it seems to create an internal link model, context, etc. is to blame for all of the breakage here [20:59:52] RoanKattouw, what's the question? [21:01:34] when you copy a bunch of internal links from VE on one site to VE on another, you get internal link annotations [21:01:37] but they all contain URLs [21:01:55] so their behaviour is completely broken [21:02:38] am just wondering if they should be external link annotations [21:02:47] definitely a regression [21:03:08] they could only be copied as internal when pasting to the same site [21:03:10] edsanders: What? [21:03:23] what Alex just said [21:03:46] internal become external links [21:03:59] but it's a different wiki [21:04:06] so they should probably be external links [21:04:16] oh, different wiki is different [21:04:21] we don't do interwiki conversion [21:05:12] 10OOjs-UI, 7Documentation: Documentation for OOjs UI widgets needs to list what methods are available for each widget - https://phabricator.wikimedia.org/T95060#1183763 (10KMenger) Hi S, Thanks for pointing me toward the discussion about this. Many things to think about, indeed! In terms of OOjs UI, yes, th... [21:06:00] It seems to still work on the same wiki [21:06:14] edsanders, can you point me to where the logic for this is? [21:07:28] ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref [21:08:20] I mean, for determining whether we get an external or internal annotation [21:08:43] it looks at the rel [21:09:05] we never really solved inter-wiki copy paste of links [21:09:51] there's no magic conversion [21:09:53] it's tech debt [21:09:55] OK [21:09:58] This is https://phabricator.wikimedia.org/T95141 [21:10:10] unless you're aware of something older [21:10:29] do you guys know that link inspector on mobile on production (en.wikipedia) is broken? [21:10:43] "Uncaught TypeError: Expecting a function in instanceof check, but got undefined" [21:10:44] RoanKattouw is fixing mobile [21:10:49] Yeah mobile VE is pretty broken [21:10:58] I merged some code of Krenair's today that's supposed to fix it [21:11:01] we've done a lot this quarter and haven't tested it recently [21:11:24] RoanKattouw is? [21:12:05] mooeypoo, updated for the pending issue. Are you able to review again? https://gerrit.wikimedia.org/r/#/c/200801/ [21:12:41] No, I'm not fixing mobile, Krenair is / did [21:12:48] :) [21:13:03] there's icons now! [21:13:19] and no errors in console when I link stuff [21:13:24] InezK, http://en.m.wikipedia.beta.wmflabs.org/wiki/0.08978372024864623_Moved#/editor/0 [21:13:47] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1183785 (10Krenair) [21:13:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, and 3 others: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1183783 (10Krenair) 5Open>3Resolved Seems to be working now. [21:17:28] edsanders, are you aware of an older equivalent of https://phabricator.wikimedia.org/T95141 - and why is this tech debt? [21:17:35] 10VisualEditor: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1183802 (10Catrope) Regression from 87d1c1a549739c46c992d5a0ee64f338d49df0a8 [21:17:41] considering it seems to be causing actual issues. or have I misunderstood? [21:17:47] Krenair, unlikely [21:17:58] 10VisualEditor: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1183804 (10Catrope) p:5High>3Unbreak! a:3Esanders [21:18:08] because we thought of it at the time but had less edgy problem to deal with [21:18:23] 10VisualEditor: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1176216 (10Catrope) >>! In T94931#1183802, @Catrope wrote: > Regression from 87d1c1a549739c46c992d5a0ee64f338d49df0a8 At least that's what it git bisects to, but for whatever... [21:18:31] ok, so it's not actually tech debt [21:18:44] edsanders: https://phabricator.wikimedia.org/T94931#1176216 [21:19:05] yup [21:19:22] so if we get a URL out of MWInternalLinkAnnotation.static.getTargetDataFromHref, what we've really got is an external link [21:20:31] hey all. i'm still eastering and was at family meetup all day. did i miss anything important? [21:21:00] 10VisualEditor: Most of the editing toolbar buttons are unlabeled icons, which can reduce usability - https://phabricator.wikimedia.org/T95233#1183817 (10Dreamyshade) 3NEW [21:21:47] I assume we can't just hack around this by fiddling with the result of MWInternalLinkAnnotation.static.toDataElement to return an external link instead? [21:22:30] 10VisualEditor: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1183831 (10Catrope) Never mind, that commit really was in wmf24, I'm just bad at typing 23 when I mean 23. [21:22:32] 10VisualEditor: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1183834 (10Esanders) DM range doesn't update when clicking at end of line, which would cause the behaviour described. Interestingly if you try it a second time it doesn't break. [21:22:34] 10VisualEditor: Most of the editing toolbar buttons are unlabeled icons, which can reduce usability - https://phabricator.wikimedia.org/T95233#1183832 (10Dreamyshade) [21:22:42] superm401, thumbs up [21:23:10] mooeypoo, thanks. I think I'll ask ebernhardson to do final review. [21:23:50] 10VisualEditor: Most of the editing toolbar buttons are unlabeled icons, which can reduce usability - https://phabricator.wikimedia.org/T95233#1183817 (10Dreamyshade) [21:24:21] Krenair, isn't that the definition of TD? [21:24:30] superm401, I'll redo my portion of that feedback code (pop/push pending) after you merge yours as a clean up [21:24:54] superm401, it is working consistently still, though, right? you need me to test? I was only looking at the code itself [21:25:36] mooeypoo, the happy path definitely works, and I believe the fail path should as well. [21:25:39] 10VisualEditor: Most of the editing toolbar buttons are unlabeled icons, which can reduce usability - https://phabricator.wikimedia.org/T95233#1183876 (10matmarex) Relevant: {T92315}. [21:25:51] superm401, yeah and the "pending" state should still work too [21:25:55] the dialog does that for us [21:27:07] edsanders, I don't think it would work anyway [21:27:11] 10VisualEditor: Most of the editing toolbar buttons are unlabeled icons, which can reduce usability - https://phabricator.wikimedia.org/T95233#1183885 (10Dreamyshade) [21:27:30] ori: Mind if I take over https://gerrit.wikimedia.org/r/#/c/201008/ ? [21:27:41] RoanKattouw: no, go for it [21:27:51] Cool [21:27:56] (03PS3) 10Catrope: Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [21:30:55] edsanders, yeah it breaks everything as soon as you go and edit one of these pasted links [21:31:15] unsurprisingly [21:31:35] what do you think a proper fix for this would look like? [21:54:33] (03PS4) 10Catrope: Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [21:55:52] 10VisualEditor: [Regression pre-wmf25] Cannot type in or pick existing group name in the Basic Reference dialog - https://phabricator.wikimedia.org/T95242#1184055 (10Ryasmeen) 3NEW [21:56:09] 10VisualEditor: [Regression pre-wmf25] Cannot type in or pick existing group name in the Basic Reference dialog - https://phabricator.wikimedia.org/T95242#1184062 (10Ryasmeen) p:5Triage>3High [21:57:20] (03CR) 10jenkins-bot: [V: 04-1] Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [21:57:54] 10VisualEditor: [Regression pre-wmf25] Cannot type in or pick existing group name in the Basic Reference dialog - https://phabricator.wikimedia.org/T95242#1184073 (10Catrope) [21:57:56] 10VisualEditor: When opening reference dialog from the MWGeneralReferenceDialog the cursor "insists" on being on the general document surface rather than the dialog inputs - https://phabricator.wikimedia.org/T95069#1184074 (10Catrope) [22:11:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: VisualEditor: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#1184095 (10GWicke) [22:21:12] James_F|Away: hey you around? [22:21:27] he's away [22:21:38] it's 23:21 here [22:24:22] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Copying link between wikis cause url linking errors - https://phabricator.wikimedia.org/T95141#1184135 (10Krenair) a:5Krenair>3Esanders I think this is something Ed needs to look at, based on our discussion earlier. [22:26:02] kaity: Oh crap I remembered out meeting and then totally forgot [22:34:26] 10MediaWiki-Page-editing: Allow anonymising of unregistered users ("IP editors") - https://phabricator.wikimedia.org/T20981#1184165 (10MZMcBride) (Thanks for the task fixes, Nemo!) [22:36:43] RoanKattouw, James_F|Away: did you hear of any issues from direct RB content loading? [22:46:45] (03PS1) 10Divec: Fix typo in ve.ce.RangeState#compareSelections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202266 (https://phabricator.wikimedia.org/T94931) [22:47:06] (03CR) 10Esanders: [C: 04-1] "Comment on ps2" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [22:49:03] (03CR) 10Esanders: [C: 04-1] "Oops. Please add unit test." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202266 (https://phabricator.wikimedia.org/T94931) (owner: 10Divec) [22:58:01] (03CR) 10Catrope: "Didn't I do exactly what your comment on PS2 asked to do?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [22:58:42] (03CR) 10Catrope: [C: 04-1] "Has bugs that I'm still working on fixing" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [23:02:52] (03PS2) 10Divec: Fix typo in ve.ce.RangeState#compareSelections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202266 (https://phabricator.wikimedia.org/T94931) [23:05:11] Krinkle: Cool new layout for https://integration.wikimedia.org/zuul/ :) [23:05:39] RoanKattouw: Thx. mostly kudos to #openstack-infra who accepted my dashboard and then openstackified it. [23:06:16] I replaced ours with proper upstream (with a local settings for layout and our custom graphite stats below) [23:07:21] Heh, I was just going to ask the other day if we could update zuul to OpenStack's UI :) [23:07:48] That reminds me, I need to move the Zuul monitor upstairs [23:07:50] And James's stuff, too [23:08:30] (03CR) 10Esanders: [C: 032] Fix typo in ve.ce.RangeState#compareSelections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202266 (https://phabricator.wikimedia.org/T94931) (owner: 10Divec) [23:10:35] superm401: Are you in SF this week, do I hear that right? [23:11:48] (03Merged) 10jenkins-bot: Fix typo in ve.ce.RangeState#compareSelections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202266 (https://phabricator.wikimedia.org/T94931) (owner: 10Divec) [23:12:24] RoanKattouw, yep. :) [23:12:32] (03CR) 10Catrope: [C: 032] build: Add 'doc' entry point and move coverage to "/coverage" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201939 (owner: 10Krinkle) [23:13:18] superm401: Awesome. Come check out our 5th floor digs some time :) [23:14:27] Cool, will do. Never been there. :) [23:15:29] Well it only opened last week so you're not alone [23:16:07] (03PS5) 10Catrope: Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [23:16:11] (03Merged) 10jenkins-bot: build: Add 'doc' entry point and move coverage to "/coverage" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201939 (owner: 10Krinkle) [23:18:28] (03CR) 10jenkins-bot: [V: 04-1] Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [23:19:11] (03PS6) 10Catrope: Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [23:21:21] (03PS1) 10Catrope: Update VE core submodule to master (8c99a87) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202281 [23:21:26] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1184221 (10Catrope) 5Open>3Resolved a:5Esanders>3dchan [23:21:32] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1176216 (10Catrope) [23:21:41] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1176216 (10Catrope) [23:22:20] Could someone +2 https://gerrit.wikimedia.org/r/202281 ? [23:25:16] (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (8c99a87) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202281 (owner: 10Catrope) [23:27:44] 10VisualEditor, 10VisualEditor-ContentEditable: Insertion annotation not rendered correctly when coming from the "wrong side" - https://phabricator.wikimedia.org/T94062#1184235 (10dchan) For me, this inconsistency happens on firefox but not on Chromium. This is what I'd expect, given their handling of ambiguo... [23:28:37] 10VisualEditor: The link inside media settings dialog does not get changed when its been modified from the outer context menu - https://phabricator.wikimedia.org/T95246#1184242 (10Ryasmeen) [23:28:49] 10VisualEditor, 10VisualEditor-ContentEditable: Insertion annotation not rendered correctly when coming from the "wrong side" - https://phabricator.wikimedia.org/T94062#1184244 (10Catrope) Sorry, I totally forgot to include that this happens in Firefox and not in Chrome. I observed that myself, but forgot abou... [23:29:07] 10VisualEditor: The link inside media settings dialog does not get changed when its been modified from the outer context menu - https://phabricator.wikimedia.org/T95246#1184245 (10Ryasmeen) p:5Triage>3High [23:31:24] (03Merged) 10jenkins-bot: Update VE core submodule to master (8c99a87) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202281 (owner: 10Catrope) [23:33:34] 10Citoid: Pop-up context menu shows redlinks in Citoid-created citation - https://phabricator.wikimedia.org/T95247#1184257 (10Whatamidoing-WMF) 3NEW [23:40:00] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Pop-up context menu shows redlinks in Citoid-created citation - https://phabricator.wikimedia.org/T95247#1184287 (10Catrope) a:3Mooeypoo [23:43:51] 10VisualEditor, 10MediaWiki-General-or-Unknown: When calling a template, the visual editor jumps way down - https://phabricator.wikimedia.org/T95248#1184295 (10Nnemo) 3NEW [23:54:47] Krenair: You don't have a tool labs account? [23:54:56] I do [23:55:11] Oh it's under your real name [23:55:20] Added you and RoanKattouw_away to ecmabot service group [23:55:47] If it's crazy, just 'become emcabot', 'qstat' and stop all the jobs as variaric arguments to qdel (e.g. qdel 123 123 123 123) [23:55:54] It then starts within 5 minutes automatically [23:56:29] https://phabricator.wikimedia.org/T62862 [23:57:31] cool, thanks