[00:10:34] whatami, hang on, I'm looking for the two bugs [00:11:19] whatami, https://phabricator.wikimedia.org/T95247 <-- an example link will help me here. Also, I assume this happened on the English Wikipedia? [00:11:54] Yes. Firefox 36 on Mac 10.10. Lemme grab the diff. [00:12:20] whatami, and this one: https://phabricator.wikimedia.org/T93800 -- I may be missing something, but this shouldn't be a problem anymore. It may have been a fluke. I can't really reproduce this on any language with combination of UI languages anymore.Can you see if you can? [00:12:24] https://en.wikipedia.org/w/index.php?title=Cancer_of_unknown_primary_origin&diff=654674247&oldid=654352636 [00:12:31] Not counting qqx, though. It won't work in qqx [00:12:32] The URL was to the PubMed page. [00:12:39] whatami, ooh thanks! awesome [00:13:25] It's a really strange bug, especially since both the context popup and the citoid popup are supposed to create the same template, so both should behave the same. I'll check into that. [00:13:41] After de-selecting and re-selecting, it's all fine. [00:13:46] I'm off to it.wp to see if I can reproduce the second one. [00:14:11] (03CR) 10Catrope: [C: 04-1] Allow extra properties for ve.ui.Surface (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [00:14:28] whatami, yeah, I'm having an issue with my local citoid, everything is rendered as 'website', so I"ll have to wait for mvolz to help me out before I can take a look at the rendering, but that diff helps! [00:15:42] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Pop-up context menu shows redlinks in Citoid-created citation - https://phabricator.wikimedia.org/T95247#1188106 (10Mooeypoo) The diff for the above image: http://www.ncbi.nlm.nih.gov/pubmed/23175147 I think one of the upcoming fixes might a... [00:17:04] I can no longer reproduce Bug 93800 as far as uselang=en is concerned. [00:17:10] https://it.wikipedia.org/wiki/Airbus_A300?veaction=edit&uselang=qqx still makes Citoid disappear. [00:18:38] whatami, it would by design, yeah. [00:18:59] whatami, that's a property of the system ,there's nothing we can do. On qqx, citoid won't be able to read the content of the language message it requires to operate. [00:19:18] Sounds like a wart. [00:20:15] mooeypoo, is there anything else you need right now? [00:21:04] nope, those two bugs were the only thing [00:21:06] Oh, and when processing Pubmed URLs, is it possible to tell Citoid to omit the URL? [00:21:23] I'll see if I can get citoid to go with content langauge anyways, but it is sort of a not-really-problem as long as no one translates those messages [00:21:33] The usual thing to do at en.wp is to include the PMID (magic word via template), and to leave out the (redundant) URL. [00:22:00] whatami, I *think* (I'll have to ask mvolz) that we could attach a different template or method to different types of results from citoid [00:22:03] but i'm not entirely sure. [00:22:17] Shall I file a low-priority task in Phab for it? [00:22:18] whatami, can you open a bug about it? [00:22:19] yeah [00:22:23] i'll ask mvolz [00:22:30] I'll file the bug and cc you on it. [00:22:31] Thanks! [00:22:32] it's also enwiki specific [00:22:45] but i think we might be able to do it with the MediaWiki:...json message. [00:23:08] whatami, assign it to me so I don't forget. I'll change assignments if needed [00:25:18] (03PS5) 10Mooeypoo: Allow for citation tools to work under the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) [00:28:05] 10Citoid: Tweak the citation to omit URLs to PubMed in favor of the PMID magic word - https://phabricator.wikimedia.org/T95376#1188144 (10Whatamidoing-WMF) 3NEW a:3Mooeypoo [00:33:45] (03CR) 10Catrope: Allow for citation tools to work under the reference dialog (038 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [00:35:31] (03CR) 10Catrope: [C: 04-1] "Comments on PS4" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [00:42:21] (03PS6) 10Mooeypoo: Allow for citation tools to work under the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) [00:43:17] (03PS3) 10Violetto: add iconography page controls [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 [00:45:20] (03CR) 10Mooeypoo: Allow extra properties for ve.ui.Surface (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [00:45:28] (03PS2) 10Mooeypoo: Allow extra properties for ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) [00:45:36] (03CR) 10Mooeypoo: Allow for citation tools to work under the reference dialog (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [00:49:21] 10Citoid: Tweak the citation to omit URLs to PubMed in favor of the PMID magic word - https://phabricator.wikimedia.org/T95376#1188182 (10Mooeypoo) As per the quick discussion on irc, I think we **might** be able to do this by perhaps redefining the map in the Cite journal properties at enwiki, but I am absolute... [00:56:05] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Give the converter a 'fromClipboard' mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202437 (https://phabricator.wikimedia.org/T94724) (owner: 10Esanders) [01:01:02] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Give the converter a 'fromClipboard' mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202437 (https://phabricator.wikimedia.org/T94724) (owner: 10Esanders) [01:04:32] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Give the converter a 'fromClipboard' mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202437 (https://phabricator.wikimedia.org/T94724) (owner: 10Esanders) [01:06:24] (03CR) 10Catrope: [C: 031] Allow for citation tools to work under the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [01:12:25] (03CR) 10Catrope: [C: 04-1] Allow extra properties for ve.ui.Surface (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [01:12:48] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Citoid request for MediaWiki:Citoid-template-type-map.json should be in the content language, not the user language - https://phabricator.wikimedia.org/T93800#1188248 (10Whatamidoing-WMF) Following up here for the record: I can no longer rep... [01:13:37] (03PS2) 10Catrope: Update VE core submodule to master (7058807) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202477 (owner: 10Esanders) [01:13:48] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (7058807) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202477 (owner: 10Esanders) [01:17:28] (03Merged) 10jenkins-bot: Update VE core submodule to master (7058807) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202477 (owner: 10Esanders) [01:30:32] 10VisualEditor, 10Wikimedia-Site-requests, 3Roadmap, 7notice: Re-enable VisualEditor by default for all newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90664#1188276 (10MZMcBride) [02:17:33] (03CR) 10GOIII: [C: 031] Try to unbreak WikiEditor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199387 (https://phabricator.wikimedia.org/T93384) (owner: 10Alex Monk) [03:02:32] 10Cite: Extension Cite messed up my indentation - https://phabricator.wikimedia.org/T95386#1188381 (10Ikesultan) 3NEW [03:40:21] 10Citoid: Multiple authors getting split weirdly on creation of Google Books citation - https://phabricator.wikimedia.org/T95387#1188407 (10LuisVilla) 3NEW [03:56:38] 10Citoid, 10VisualEditor: Popup for newly added cite-by-url citation doesn't show full citation - https://phabricator.wikimedia.org/T95363#1188423 (10Mooeypoo) a:3Mooeypoo I know what's going on. There are a couple of fixes on the way that will help with this, and I'll submit a specific fix soon. [03:58:53] 10WikiEditor: Unable to remove individual booklet-pages from loading to the toolbar - https://phabricator.wikimedia.org/T70791#1188428 (10GOIII) Now that the language-character sets no longer "reside" in the WikiEditor extension (see T91608), any chance that it is somehow now possible to //prevent// the loading... [04:32:08] 10Citoid: Be more constructive on a 404d page - https://phabricator.wikimedia.org/T95388#1188433 (10LuisVilla) 3NEW [04:33:24] 10Citoid: Attempt to parse archive.org URLs? - https://phabricator.wikimedia.org/T95389#1188440 (10LuisVilla) 3NEW [04:42:03] 10Citoid: Citoid's behavior with Wikipedia links is unhelpful (maybe broken) - https://phabricator.wikimedia.org/T95390#1188448 (10LuisVilla) 3NEW [06:49:27] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): VisualEditor: Pasting content into a VE-MW surface should down-convert s to s (and s ... - https://phabricator.wikimedia.org/T70928#1188559 [06:49:44] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): VisualEditor: Pasting content into a VE-MW surface should down-convert s to s (and s t... - https://phabricator.wikimedia.org/T70928#740208 [06:49:46] 10VisualEditor, 10VisualEditor-CopyPaste: When the user pastes in an , we should probably convert it to an ? - https://phabricator.wikimedia.org/T85377#1188564 (10Jdforrester-WMF) [06:49:48] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): Be able to convert DOM->data differently for paste data vs initial conversion - https://phabricator.wikimedia.org/T94724#1188561 (10Jdforrester-WMF) 5Open>3Resolved [06:52:00] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: Strip initial and trailing
s out of section headings - https://phabricator.wikimedia.org/T68846#1188570 (10Jdforrester-WMF) 5stalled>3Open p:5Triage>3Normal [06:57:25] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1188595 (10Jdforrester-WMF) [06:57:28] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Google-Chrome: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - https://phabricator.wikimedia.org/T68756#1188600 (10Jdforrester-WMF) [06:57:30] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor on Mobile web doesn't detect wikitext insertion - https://phabricator.wikimedia.org/T95335#1188596 (10Jdforrester-WMF) [06:58:03] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: [REWRITE ME] Separate ve.init and ve.platform - https://phabricator.wikimedia.org/T52707#1188624 (10Jdforrester-WMF) [07:39:28] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation, and 3 others: HTML entities in CommentNode must be manually escaped/unescaped. - https://phabricator.wikimedia.org/T95040#1188778 (10Jdforrester-WMF) [07:39:46] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation, and 3 others: HTML entities in CommentNode must be manually escaped/unescaped - https://phabricator.wikimedia.org/T95040#1188779 (10Jdforrester-WMF) 5Open>3Resolved [07:40:52] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1188783 (10Jdforrester-WMF) [07:41:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, 3Editing Department 2014/15 Q4 blockers: Change Welcome dialogue content to more helpful message to new users based on the GuidedTour - https://phabricator.wikimedia.org/T89072#1188785 (10Jdforrester-WMF) [07:41:12] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Slugs should not be visible through context menu - https://phabricator.wikimedia.org/T93042#1188786 (10Jdforrester-WMF) [07:41:25] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Frozen link inspector and "Uncaught Error..." when a link is repeatedly inserted - https://phabricator.wikimedia.org/T91318#1188787 (10Jdforrester-WMF) [07:45:33] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditor: Strip annotations (e.g. bold, italics, link) from terminal whitespace - https://phabricator.wikimedia.org/T54037#1188789 (10Jdforrester-WMF) >>! In T54037#1187185, @Esanders wrote: > This sho... [07:45:37] (03CR) 10Jforrester: [C: 031] Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [08:09:07] 10Citoid: Tweak the citation to omit URLs to PubMed in favor of the PMID magic word - https://phabricator.wikimedia.org/T95376#1188817 (10Mvolz) a:5Mooeypoo>3None [08:25:21] 10TemplateData: TemplateData: Provide information about preferred formatting of transclusions - https://phabricator.wikimedia.org/T64217#1188824 (10Schnark) Proper formatting actually requires more information than just single line vs. one parameter per line: * Whitespace before pipe: For templates that should... [08:29:34] 10MediaWiki-Page-editing, 7Epic, 5Patch-For-Review: Edit conflict detection suffers a race condition - https://phabricator.wikimedia.org/T58849#1188826 (10Nemo_bis) [08:39:02] 10Citoid: Tweak the citation to omit URLs to PubMed in favor of the PMID magic word - https://phabricator.wikimedia.org/T95376#1188852 (10Mvolz) There is no way to do this on the front end (extension/templatedata). If users don't like having the link in the presented citation, they could modify the cite journal... [08:39:39] 10Citoid: Tweak the citation to omit URLs to PubMed in favor of the PMID magic word - https://phabricator.wikimedia.org/T95376#1188853 (10Mvolz) 5Open>3declined [08:44:20] 10Citoid: Try to find link in archive.org for 520 page - https://phabricator.wikimedia.org/T95388#1188854 (10Mvolz) [08:48:27] 10Citoid: Try to find link in archive.org for 520 page - https://phabricator.wikimedia.org/T95388#1188865 (10Mvolz) We actually currently do have partial metadata for "bad" links that return a 520 (404s only return for bad pmid/pmcid/doi). UX/VE team decided not to use the 520s in the extension because the 520s... [08:51:06] 10Citoid: Multiple authors getting split weirdly on creation of Google Books citation - https://phabricator.wikimedia.org/T95387#1188407 (10Mvolz) Translator issue, you can file here if you'd like: https://github.com/zotero/translators/issues [08:51:55] 10Citoid: Citoid's behavior with Wikipedia links is unhelpful (maybe broken) - https://phabricator.wikimedia.org/T95390#1188871 (10Mvolz) [08:52:52] 10Citoid: Poor support in Zotero for major Italian newspapers - https://phabricator.wikimedia.org/T94170#1188873 (10Mvolz) [08:55:59] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Citoid request for MediaWiki:Citoid-template-type-map.json should be in the content language, not the user language - https://phabricator.wikimedia.org/T93800#1188888 (10Mvolz) I'd still like to know a) Why the citation tools message gets par... [10:05:57] 10Citoid, 10Mathoid-General-or-Unknown, 10MediaWiki-extensions-Graph, 10MediaWiki-extensions-WikiHiero, and 3 others: Services need to share the same domain name - https://phabricator.wikimedia.org/T95402#1188961 (10Yurik) 3NEW [10:47:18] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers: Strip xml: attributes on paste - https://phabricator.wikimedia.org/T94721#1189063 (10Jdforrester-WMF) a:3Esanders [10:53:18] 10VisualEditor, 10VisualEditor-EditingTools, 7Design: Inspectors don't have close buttons but dialogs do, and some users find this confusing - https://phabricator.wikimedia.org/T93749#1189078 (10Jdforrester-WMF) p:5Triage>3Lowest [10:54:53] 10VisualEditor: Link Types: easy addition of structured metadata added to hyperlinking dialog in VE - https://phabricator.wikimedia.org/T94295#1189083 (10Jdforrester-WMF) This seems like this would be better done through Wikidata. There are some other tasks around for editing Wikidata through VisualEditor (so t... [10:55:02] 10VisualEditor: Link Types: easy addition of structured metadata added to hyperlinking dialog in VE - https://phabricator.wikimedia.org/T94295#1189085 (10Jdforrester-WMF) [10:55:03] 10VisualEditor: Structured Summary: gentle prompting for structured fields when editing in VE - https://phabricator.wikimedia.org/T94296#1189084 (10Jdforrester-WMF) [10:57:35] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Tracking: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - https://phabricator.wikimedia.org/T50789#1189097 (10Jdforrester-WMF) [10:57:37] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: Link inspector should have bottom margin to avoid cutting the page (UX) - https://phabricator.wikimedia.org/T54436#1189095 (10Jdforrester-WMF) 5Open>3Resolved [10:58:27] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector's disabled "open" button retains the href of its previous state - https://phabricator.wikimedia.org/T93004#1189098 (10Jdforrester-WMF) p:5Triage>3Normal [10:59:09] 10VisualEditor: When the invalid format of URL is used inside link inspector the "Open" button looks disabled but it is clickable and clicking on it opens another tab trying loading the page with invalid URL - https://phabricator.wikimedia.org/T93003#1189102 (10Jdforrester-WMF) [10:59:11] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector's disabled "open" button retains the href of its previous state - https://phabricator.wikimedia.org/T93004#1126337 (10Jdforrester-WMF) [11:01:14] 10VisualEditor, 10MediaWiki-ContentHandler, 10MediaWiki-Internationalization: Default content model should apply to non-customised messages in the MediaWiki: namespace - https://phabricator.wikimedia.org/T92899#1189106 (10Jdforrester-WMF) [11:01:26] 10VisualEditor, 10MediaWiki-ContentHandler, 10MediaWiki-Internationalization: Default content model should apply to non-customised messages in the MediaWiki: namespace - https://phabricator.wikimedia.org/T92899#1123086 (10Jdforrester-WMF) p:5Triage>3Normal [11:03:12] 10VisualEditor, 10VisualEditor-EditingTools: Visual Editor special character at ln: - https://phabricator.wikimedia.org/T92959#1189112 (10Jdforrester-WMF) https://ln.wikipedia.org/wiki/2006?veaction=edit&uselang=ln works fine for me… Note that as of later today the system to configure this has changed. [11:06:51] 10Citoid, 6Services: Configure OCG, Parsoid and Citoid to report counter metrics - https://phabricator.wikimedia.org/T94053#1189115 (10fgiunchedi) FYI this is happening tomorrow at 10 UTC, ocg code review is at https://gerrit.wikimedia.org/r/199952 [11:08:37] 10VisualEditor, 10MediaWiki-General-or-Unknown: Typing "{{" does not show the template dialog - https://phabricator.wikimedia.org/T95410#1189118 (10Nnemo) 3NEW [11:09:47] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Typing "{{" opens the template dialog off screen on iOS Safari - https://phabricator.wikimedia.org/T95410#1189132 (10Jdforrester-WMF) p:5Triage>3Normal [11:10:35] 10VisualEditor, 7Technical-Debt: Create unit tests fo ve.dm.Scalable - https://phabricator.wikimedia.org/T95411#1189136 (10Esanders) 3NEW [11:13:42] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Offer to edit a transcluded page; handle that entering {{ isn't necessarily a template - https://phabricator.wikimedia.org/T92695#1189148 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF This is talking about two issues; dealing with them distinct... [11:14:58] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Frozen link inspector and "Uncaught Error..." when a link is repeatedly inserted - https://phabricator.wikimedia.org/T91318#1189163 (10Jdforrester-WMF) I can't replicate this now, because {T93013} gets in the way first (?). [11:15:25] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Frozen link inspector and "Uncaught Error..." when a link is repeatedly inserted after clicking in the same place in a blank paragraph in insert mode - https://phabricator.wikimedia.org/T91318#1189165 (10Jdforrester-WMF)... [11:15:38] 10VisualEditor: Link inspector does not close while placing the cursor on the same line (for empty line) and also it shifts the cursor to the left after typing the first character on CE while the inspector is open - https://phabricator.wikimedia.org/T93013#1126573 (10Jdforrester-WMF) [11:15:40] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Frozen link inspector and "Uncaught Error..." when a link is repeatedly inserted after clicking in the same place in a blank paragraph in insert mode - https://phabricator.wikimedia.org/T91318#1079977 (10Jdforrester-WMF) [11:15:55] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Link inspector does not close while placing the cursor on the same line (for empty line) and also it shifts the cursor to the left after typing the first character on CE w... - https://phabricator.wikimedia.org/T93013#1126573 [11:16:30] 10VisualEditor, 10VisualEditor-DataModel, 7Technical-Debt: Create unit tests for ve.dm.Scalable - https://phabricator.wikimedia.org/T95411#1189171 (10Jdforrester-WMF) p:5Triage>3Normal [11:20:13] 10VisualEditor: When viewport is narrow and VisualEditor is enabled Edit should remain on screen rather than Edit Source as controls collapse - https://phabricator.wikimedia.org/T92895#1189186 (10Jdforrester-WMF) We intentionally prioritise the basic editor over VE when it's the secondary editor (shown as the se... [11:20:24] 10VisualEditor: Ignore abstract methods in code coverage reports - https://phabricator.wikimedia.org/T95413#1189187 (10Esanders) 3NEW [11:20:55] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor primary (first editor tab) on the English Wikipedia for people for whom it's enabled - https://phabricator.wikimedia.org/T92895#1189195 (10Jdforrester-WMF) p:5Triage>3Normal [11:21:32] 10VisualEditor, 10MediaWiki-General-or-Unknown: The tool bar plays hide-and-and-seek-and-greyed, so the user cannot insert a special character - https://phabricator.wikimedia.org/T95414#1189199 (10Nnemo) 3NEW [11:22:53] 10OOjs-UI, 10VisualEditor, 10Continuous-Integration: Ignore abstract methods in code coverage reports - https://phabricator.wikimedia.org/T95413#1189212 (10Jdforrester-WMF) p:5Triage>3Normal [11:24:15] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Opening the software keyboard in iOS Safari scrolls the toolbar out of view or deselects the content - https://phabricator.wikimedia.org/T95414#1189220 (10Jdforrester-WMF) p:5Triage>3Normal [11:28:06] 10VisualEditor, 10VisualEditor-ContentEditable: Text immediately before a template is separated with an   - https://phabricator.wikimedia.org/T95368#1189230 (10Jdforrester-WMF) [11:28:50] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Opening the software keyboard in iOS Safari scrolls the toolbar out of view, and dismissing the keyboard brings a mostly-greyed toolbar, so the user cannot insert a speci... - https://phabricator.wikimedia.org/T95414#1189232 [11:29:24] 10VisualEditor, 7Technical-Debt: Increase test coverage of table support - https://phabricator.wikimedia.org/T95415#1189234 (10Esanders) 3NEW [11:29:31] 10VisualEditor, 10VisualEditor-ContentEditable: Text immediately before a template is separated with an   - https://phabricator.wikimedia.org/T95368#1187961 (10Jdforrester-WMF) The output from Parsoid and RESTbase looks normal. Are we munging it somehow? [11:29:38] 10VisualEditor, 10VisualEditor-ContentEditable: Text immediately before a template is separated with an   - https://phabricator.wikimedia.org/T95368#1189243 (10Jdforrester-WMF) p:5Triage>3Low [11:30:05] 10VisualEditor, 10VisualEditor-Tables, 7Technical-Debt: Increase test coverage of table support - https://phabricator.wikimedia.org/T95415#1189245 (10Jdforrester-WMF) p:5Triage>3Normal [11:31:04] 10VisualEditor, 10VisualEditor-DataModel: If a GeneratedContentNode is destroyed before it finished parsing, its promise isn't aborted - https://phabricator.wikimedia.org/T95354#1189249 (10Jdforrester-WMF) p:5Triage>3Normal [11:32:15] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: If a GeneratedContentNode is destroyed before it finished parsing, its promise isn't aborted - https://phabricator.wikimedia.org/T95354#1187695 (10Jdforrester-WMF) [11:32:35] (03PS1) 10Esanders: Test untested branch nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202705 [11:33:09] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: On iOS Safari, opening the software keyboard scrolls the toolbar out of view, and dismissing the keyboard brings a mostly-greyed toolbar, so the user cannot insert a spec... - https://phabricator.wikimedia.org/T95414#1189254 [11:33:53] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: On iOS Safari, opening the software keyboard scrolls the toolbar out of view, and dismissing the keyboard brings a mostly-greyed toolbar, so the user cannot insert a spec... - https://phabricator.wikimedia.org/T95414#1189256 [11:40:38] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation, and 3 others: HTML entities in CommentNode must be manually escaped/unescaped - https://phabricator.wikimedia.org/T95040#1189259 (10Esanders) @cscott you mention that is invalid XML (which is annoyin... [11:42:53] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: On iOS Safari, opening the software keyboard scrolls the toolbar out of view, and dismissing the keyboard brings a mostly-greyed toolbar, so the user cannot insert a spec... - https://phabricator.wikimedia.org/T95414#1189263 [11:42:56] (03CR) 10Jforrester: [C: 032] "Overall branch coverage – before: 60.96%; after 60.97%." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202705 (owner: 10Esanders) [11:46:23] (03Merged) 10jenkins-bot: Test untested branch nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202705 (owner: 10Esanders) [11:57:20] 10VisualEditor, 10VisualEditor-DataModel, 7Technical-Debt: Write tests for ve.dm.APIResultsProvider - https://phabricator.wikimedia.org/T95416#1189284 (10Jdforrester-WMF) 3NEW [11:57:44] (03PS1) 10Esanders: Don't encoding single hyphens in comments, just doubles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 [11:58:51] (03PS2) 10Esanders: Don't encoding single hyphens in comments, just doubles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) [11:59:25] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation, and 3 others: HTML entities in CommentNode must be manually escaped/unescaped - https://phabricator.wikimedia.org/T95040#1189296 (10Esanders) From what I can see single hyphens are valid so I have provided the above fix. [12:00:18] James_F, where do I see the coverage change for a specific commit? [12:01:36] edsanders: grunt build. Look in /coverage. [12:01:51] edsanders: The unit test run builds the coverage report as part of its work. [12:01:58] /test-coverage? [12:02:10] No, Krinkle|detached renamed it. [12:03:30] then he missed: [12:03:30] clean: { [12:03:31] dist: [ 'dist/*', 'test-coverage/*' ] [12:03:31] }, [12:03:52] right> [12:03:53] ? [12:04:02] Hmm. [12:04:05] Are you out of date? [12:04:26] it says 'coverage' further down the page [12:04:28] Nope, you're right. [12:04:33] I'll fix. [12:04:46] (03PS1) 10Esanders: Fix rename of test-coverage to coverage in clean [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202712 [12:04:48] done [12:05:06] (03PS2) 10Jforrester: build: Fix rename of test-coverage to coverage in clean task [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202712 (owner: 10Esanders) [12:05:15] (03CR) 10Jforrester: [C: 032] build: Fix rename of test-coverage to coverage in clean task [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202712 (owner: 10Esanders) [12:05:18] Meh. [12:09:07] (03Merged) 10jenkins-bot: build: Fix rename of test-coverage to coverage in clean task [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202712 (owner: 10Esanders) [12:09:33] don't understand why it claims that CenterNode, DivNode and BlockQuoteNode dm constructors aren't covered [12:09:37] (03CR) 10Jforrester: [C: 031] Don't encoding single hyphens in comments, just doubles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [12:10:13] (03PS2) 10Jforrester: [WIP] Move all our icons to OOjs UI's icon packs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196511 [12:12:20] (03PS3) 10Esanders: Don't encoding single hyphens in comments, just doubles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) [12:12:23] (03CR) 10jenkins-bot: [V: 04-1] Don't encoding single hyphens in comments, just doubles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [12:13:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Move all our icons to OOjs UI's icon packs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196511 (owner: 10Jforrester) [12:14:26] (03PS4) 10Esanders: Don't encoding single hyphens in comments, just doubles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) [12:18:39] edsanders: Hmm. I can't change language in VE SA with the keyboard. Typing instantly falls through to the surface. [12:22:23] probably the window manager problem again [12:22:45] * James_F grumbles. [12:24:48] actually I can't defocus the surface at all [12:27:23] Oh dear. [12:27:26] Hey sucheta. :-) [12:28:05] James_F, Good morning! [12:35:58] 10VisualEditor, 10VisualEditor-ContentEditable: Surface can't be blurred (regression) - https://phabricator.wikimedia.org/T95422#1189356 (10Esanders) 3NEW a:3Esanders [12:36:19] (03PS1) 10Esanders: Fix showSelection fixup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202716 (https://phabricator.wikimedia.org/T95422) [12:36:59] edsanders: When did it break? [12:39:10] Apr 1 [12:39:11] https://gerrit.wikimedia.org/r/#/c/201357/ [12:41:45] needs backporting if it was released anywhere [12:41:53] Fun. [12:41:55] It wasn't yet. [12:42:00] But it will be in a couple of hours. [12:42:28] (03PS2) 10Jforrester: Follow-up facbde556a: Fix showSelection fixup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202716 (https://phabricator.wikimedia.org/T95422) (owner: 10Esanders) [12:42:42] (03CR) 10Jforrester: [C: 032] Follow-up facbde556a: Fix showSelection fixup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202716 (https://phabricator.wikimedia.org/T95422) (owner: 10Esanders) [12:42:49] Will need to pull through. [12:42:59] And get Roan or someone actually competent to +2 after the fact. :-) [12:43:24] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: [Regression pre-wmf1] Surface can't be blurred - https://phabricator.wikimedia.org/T95422#1189375 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Unbreak! [12:43:29] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: [Regression pre-wmf1] Surface can't be blurred - https://phabricator.wikimedia.org/T95422#1189356 (10Jdforrester-WMF) [12:46:57] (03Merged) 10jenkins-bot: Follow-up facbde556a: Fix showSelection fixup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202716 (https://phabricator.wikimedia.org/T95422) (owner: 10Esanders) [12:49:46] (03PS3) 10Jforrester: [WIP] Move all our icons to OOjs UI's icon packs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196511 [12:51:03] (03PS1) 10Jforrester: Update VE core submodule to master (24e4428) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202722 [12:57:58] edsanders: ^^^ +2 please. [13:07:06] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (24e4428) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202722 (owner: 10Jforrester) [13:07:51] Ta. [13:09:06] do we really want every VE icon upstreamed? [13:10:08] icons that have no use outside of their project should stay there surely [13:10:14] (03Merged) 10jenkins-bot: Update VE core submodule to master (24e4428) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202722 (owner: 10Jforrester) [13:10:35] edsanders: Yes, but there aren't any in VE core that we wouldn't put in WikiEditor. [13:10:41] edsanders: When there are, we won't. [13:10:57] edsanders: Also, the OOjs UI side of that patch is already merged. ;-) [13:11:22] language annotation? [13:11:32] "Change language". [13:11:56] the table tools [13:12:04] (insert row/col) [13:12:26] Column is harder. [13:12:36] ...merge cell, caption [13:12:38] Row is simple to do badly, though. [13:12:42] None of them are VE-specific. [13:12:49] All editors can (or could) use them. [13:13:02] Or are MW-specific (no wikitext) [13:13:03] Etc. [13:13:03] I guess it's not that many [13:13:07] Yeah. [13:13:07] in core [13:13:14] VE-MW has a lot more. [13:13:18] And most of those won't be moved. [13:21:41] (03PS2) 10Jforrester: Apex, MediaWiki: Correct or delete unused SVG files [oojs/ui] - 10https://gerrit.wikimedia.org/r/202422 (owner: 10Bartosz Dziewoński) [13:22:23] 10Citoid, 6Services: Configure OCG, Parsoid and Citoid to report counter metrics - https://phabricator.wikimedia.org/T94053#1189444 (10mobrovac) >>! In T94053#1189115, @fgiunchedi wrote: > FYI this is happening tomorrow at 10 UTC, ocg code review is at https://gerrit.wikimedia.org/r/199952 pinging @cscott for... [13:23:38] (03CR) 10Jforrester: [C: 031] "I missed a couple of icons from the move, and screwed up icons-moderation. Good to go." [oojs/ui] - 10https://gerrit.wikimedia.org/r/202422 (owner: 10Bartosz Dziewoński) [13:58:30] (03PS9) 10Physikerwelt: Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) [14:03:45] (03PS3) 10Mobrovac: Make DOI, PMID, & PMCID have itemType journalArticle [services/citoid] - 10https://gerrit.wikimedia.org/r/202387 (https://phabricator.wikimedia.org/T94597) (owner: 10Mvolz) [14:05:28] (03PS10) 10Physikerwelt: Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) [14:08:05] (03CR) 10Physikerwelt: "I implemented all proposed changes." [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [14:09:28] 10OOjs-UI, 10VisualEditor: Ignore abstract methods in code coverage reports - https://phabricator.wikimedia.org/T95413#1189493 (10hashar) [14:14:22] (03CR) 10Mobrovac: [C: 032] "Thanks @mvolz for clearing stuff out for me. Let's get this as-is and amend the fields in a separate commit." [services/citoid] - 10https://gerrit.wikimedia.org/r/202387 (https://phabricator.wikimedia.org/T94597) (owner: 10Mvolz) [14:24:43] 10Citoid: Automated archiving of URLs - https://phabricator.wikimedia.org/T89438#1189526 (10LuisVilla) Note that archive.org has reached out to us before about this and would be happy to be an active partner in this. I'd be happy to set up the meeting there. [14:25:28] 10Citoid: Resolvable DOIs, PMIDs, and PMCIDs should be checked for itemType and manually set to journalArticle. - https://phabricator.wikimedia.org/T94597#1189530 (10mobrovac) 5Open>3Resolved [14:29:09] 10VisualEditor, 10VisualEditor-EditingTools: Multi-paragraph
results in some paragraphs being alienated content - https://phabricator.wikimedia.org/T86794#1189549 (10LuisVilla) This happens even with a single paragraph if the blockquote isn't on the same line as the content. e.g.,
t... [14:29:50] 10VisualEditor, 10VisualEditor-EditingTools:
tags on different line from content of blockquote results alienated content - https://phabricator.wikimedia.org/T86794#1189550 (10LuisVilla) [14:31:52] (03PS1) 10Mobrovac: Bump service-runner to 0.1.6 [services/citoid] - 10https://gerrit.wikimedia.org/r/202737 (https://phabricator.wikimedia.org/T94053) [14:32:48] (03CR) 10Mobrovac: [C: 032] Bump service-runner to 0.1.6 [services/citoid] - 10https://gerrit.wikimedia.org/r/202737 (https://phabricator.wikimedia.org/T94053) (owner: 10Mobrovac) [14:48:14] 10Citoid: Update bin/updateSubmodule to run npm install and add node_modules - https://phabricator.wikimedia.org/T93533#1189590 (10mobrovac) a:3mobrovac [14:55:19] (03PS1) 10Mobrovac: Update citoid submodule to master (26e23a0) [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/202744 [14:58:16] (03CR) 10Mobrovac: [C: 032 V: 032] Update citoid submodule to master (26e23a0) [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/202744 (owner: 10Mobrovac) [15:00:26] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1189600 (10Jdforrester-WMF) [15:00:34] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1134780 (10Jdforrester-WMF) [15:01:43] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): Native scrape responses not getting converted to mediawiki type - https://phabricator.wikimedia.org/T95004#1189607 (10Jdforrester-WMF) [15:01:49] (03PS1) 10Mobrovac: Rebuild node_modules automatically when package.json changes [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/202745 (https://phabricator.wikimedia.org/T93533) [15:02:27] (03CR) 10Mobrovac: [C: 032 V: 032] Rebuild node_modules automatically when package.json changes [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/202745 (https://phabricator.wikimedia.org/T93533) (owner: 10Mobrovac) [15:02:33] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): Native scrape responses not getting converted to mediawiki type - https://phabricator.wikimedia.org/T95004#1177757 (10Jdforrester-WMF) [15:02:56] 10Citoid: Update bin/updateSubmodule to run npm install and add node_modules - https://phabricator.wikimedia.org/T93533#1189613 (10mobrovac) 5Open>3Resolved [15:03:03] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): Resolvable DOIs, PMIDs, and PMCIDs should be checked for itemType and manually set to journalArticle. - https://phabricator.wikimedia.org/T94597#1189616 (10Jdforrester-WMF) [15:03:18] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): Resolvable DOIs, PMIDs, and PMCIDs should be checked for itemType and manually set to journalArticle - https://phabricator.wikimedia.org/T94597#1189617 (10Jdforrester-WMF) [15:05:42] 10Citoid, 6Services, 7Technical-Debt: Promisify Citoid and base it on service-template-node / service-runner - https://phabricator.wikimedia.org/T75993#1189625 (10Jdforrester-WMF) Is this now done? [15:06:09] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): Native scrape responses not getting converted to mediawiki type - https://phabricator.wikimedia.org/T95004#1189630 (10Jdforrester-WMF) Is this now complete? [15:06:25] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Promisify Citoid and base it on service-template-node / service-runner - https://phabricator.wikimedia.org/T75993#1189631 (10Jdforrester-WMF) [15:06:31] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Promisify Citoid and base it on service-template-node / service-runner - https://phabricator.wikimedia.org/T75993#787816 (10Jdforrester-WMF) [15:06:51] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Promisify Citoid and base it on service-template-node / service-runner - https://phabricator.wikimedia.org/T75993#1189633 (10mobrovac) >>! In T75993#1189625, @Jdforrester-WMF wrote: > Is this now done? Not yet unfortunately (cf... [15:09:06] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Promisify Citoid and base it on service-template-node / service-runner - https://phabricator.wikimedia.org/T75993#1189636 (10Jdforrester-WMF) Boo. :-( [15:15:41] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1189647 (10Jdforrester-WMF) [15:20:22] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): Native scrape responses not getting converted to mediawiki type - https://phabricator.wikimedia.org/T95004#1189652 (10mobrovac) [15:20:25] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt: Promisify Citoid and base it on service-template-node / service-runner - https://phabricator.wikimedia.org/T75993#1189653 (10mobrovac) [15:20:52] 10Citoid, 6Services, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): Native scrape responses not getting converted to mediawiki type - https://phabricator.wikimedia.org/T95004#1189656 (10mobrovac) 5Open>3Resolved >>! In T95004#1189630, @Jdforrester-WMF wrote: > Is this now... [15:21:47] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Automatically recognise bare links and magic links (ISBN/etc.), and display as a link - https://phabricator.wikimedia.org/T54204#1189659 (10Jdforrester-WMF) [15:21:49] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: VisualEditor's handling of ISBNs is inconsistent - https://phabricator.wikimedia.org/T95311#1189658 (10Jdforrester-WMF) [15:21:55] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Automatically recognise bare links and magic links (ISBN/etc.), and display as a link - https://phabricator.wikimedia.org/T54204#567421 (10Jdforrester-WMF) [15:22:42] 10VisualEditor: VisualEditor's handling of ISBNs is inconsistent - https://phabricator.wikimedia.org/T95311#1186430 (10Jdforrester-WMF) [15:23:58] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: Automatically recognise bare links and magic links (ISBN/etc.), and display as a link - https://phabricator.wikimedia.org/T54204#1189678 (10Jdforrester-WMF) [15:24:55] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: Automatically recognise bare links and magic links (ISBN/etc.), and display as a link - https://phabricator.wikimedia.org/T54204#567421 (10Jdforrester-WMF) [15:26:01] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Typing "{{" opens the template dialog off screen on iOS Safari - https://phabricator.wikimedia.org/T95410#1189696 (10Jdforrester-WMF) [15:26:02] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: When typing {{ in iOS, the surface scrolls far down - https://phabricator.wikimedia.org/T95248#1189697 (10Jdforrester-WMF) [15:26:10] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Typing "{{" opens the template dialog off screen on iOS Safari - https://phabricator.wikimedia.org/T95410#1189118 (10Jdforrester-WMF) [15:26:21] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VisualEditor on Mobile web doesn't detect wikitext insertion - https://phabricator.wikimedia.org/T95335#1189707 (10gpaumier) >>! In T95335#1187933, @Catrope wrote: > Which browser were you using? Because T95248 claims this **does** work. Reproducible in Chromiu... [15:27:21] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari: VisualEditor: Safari on iPad converts numbers that resemble phone numbers to href=tel: links - https://phabricator.wikimedia.org/T55315#1189716 (10Jdforrester-WMF) [15:27:23] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: When typing {{ in iOS, the surface scrolls far down - https://phabricator.wikimedia.org/T95248#1184295 (10Jdforrester-WMF) [15:27:25] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1189714 (10Jdforrester-WMF) [15:27:27] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 5Patch-For-Review: VisualEditor: Selecting templates on iOS < 8 causes the on-screen keyboard to close, so they cannot be deleted - https://phabricator.wikimedia.org/T62110#1189717 (10Jdforrester-WMF) [15:28:37] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: When typing {{ in iOS, the surface scrolls far down - https://phabricator.wikimedia.org/T95248#1189719 (10Jdforrester-WMF) p:5Triage>3Normal [15:29:38] Krenair: Do you know if https://phabricator.wikimedia.org/T93156 is fixed or not? [15:30:14] probably not [15:30:19] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Pop-up context menu shows redlinks in Citoid-created citation - https://phabricator.wikimedia.org/T95247#1189729 (10Jdforrester-WMF) p:5Triage>3Normal [15:30:21] Fun. [15:31:43] The graph doesn't look broken however [15:31:58] So… yes? [15:32:34] The data starts on 21 February. [15:32:41] If you zoom out a lot. [15:32:47] So I guess that was when it switched? [15:33:02] 10VisualEditor, 10Performance-Metrics-Dashboard, 7Performance, 5WMF-deploy-2015-03-25_(1.25wmf23): domLoad metric apparently broken in wmf21 - https://phabricator.wikimedia.org/T93156#1189740 (10Jdforrester-WMF) 5Open>3Resolved [15:33:09] ah, we did merge the "fix" [15:33:11] 10VisualEditor, 10Performance-Metrics-Dashboard, 7Performance, 5WMF-deploy-2015-03-25_(1.25wmf23): domLoad metric apparently broken in wmf21 - https://phabricator.wikimedia.org/T93156#1130766 (10Jdforrester-WMF) Apparently now fixed. [15:33:15] but did not backport it in the end [15:33:48] the patch confuses mobile and desktop metrics, however [15:34:26] Shouldn't we open a new task for that, then? [15:35:30] probably [15:35:51] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VisualEditor on Mobile web doesn't detect wikitext insertion - https://phabricator.wikimedia.org/T95335#1189750 (10Jdforrester-WMF) We don't do wikitext detection in mobile, but that's OK because it's not a major cause of mistakes except for missing functionalit... [15:36:22] 10VisualEditor, 10VisualEditor-Performance: VE save/load performance tracking for desktop and mobile are comingled - https://phabricator.wikimedia.org/T95432#1189758 (10Jdforrester-WMF) 3NEW [15:36:58] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1189765 (10Jdforrester-WMF) [15:36:59] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Scrolling vertically the dialog for template in a ref fails and scrolls the visual content instead - https://phabricator.wikimedia.org/T95159#1189766 (10Jdforrester-WMF) [15:37:41] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Scrolling vertically the dialog for template in a ref fails and scrolls the visual content instead on iOS Safari - https://phabricator.wikimedia.org/T95159#1189774 (10Jdforrester-WMF) p:5Triage>3Low [15:38:12] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Copying link between wikis cause url linking errors - https://phabricator.wikimedia.org/T95141#1189778 (10Jdforrester-WMF) p:5Triage>3Normal [15:38:24] Heya MatmaRex. [15:38:59] hi [15:39:16] MatmaRex: If you +1 https://gerrit.wikimedia.org/r/202422 I'll +2. [15:40:18] looking [15:40:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor good enough for mobile tablet and phone enablement - https://phabricator.wikimedia.org/T94725#1189780 (10Jdforrester-WMF) [15:40:50] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VisualEditor on Mobile web doesn't detect wikitext insertion - https://phabricator.wikimedia.org/T95335#1189781 (10Jdforrester-WMF) [15:44:24] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Safari on iPad converts numbers that resemble phone numbers to href=tel: links - https://phabricator.wikimedia.org/T55315#1189785 (10Jdforr... [15:44:26] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditor: Selecting templates on iOS < 8 causes the on-screen keyboard to close, so they cannot be deleted - https://phabricator.wikimedia.org/T62110#1189786 (10Jdforrester-WMF) [15:44:28] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Performance, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of sess... - https://phabricator.wikimedia.org/T70017#1189791 [15:44:30] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: In android, while trying to apply a link on a selected text ,strips off the first letter of the text in the link inspector - https://phabricator.wikimedia.org/T70244#1189787 (10Jdforrester-WMF) [15:44:32] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Tapping at the end of each link duplicates the preceding link text in Nexus 7 (Android 4.4.2) - https://phabricator.wikimedia.org/T68754#1189792 (10Jdforrester-WMF) [15:44:34] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Text cannot be pasted into link inspector search field from mobile browser - https://phabricator.wikimedia.org/T70018#1189788 (10Jdforrester-WMF) [15:44:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Cannot type the reference name inside Re-use existing reference dialog unless select a reference from that dialog - https://phabricator.wikimedia.org/T70824#1189789 (10Jdforrester-WMF) [15:44:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: The link text is not appearing in the link target field inside the link inspector for Android - https://phabricator.wikimedia.org/T70585#1189790 (10Jdforrester-WMF) [15:46:53] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: After tapping on "Go back"/"Continue Anyway" in the "Required parameter missing" conf... - https://phabricator.wikimedia.org/T73259#1189853 [15:47:19] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 6WMF-Design-Research, and 2 others: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1189855 (10Jdforrester-WMF) [15:47:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6WMF-Design, 3Editing Department 2014/15 Q4 blockers: Provide design guidance for minimal VisualEditor header on phones - https://phabricator.wikimedia.org/T93325#1189858 (10Jdforrester-WMF) [15:50:31] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks." [oojs/ui] - 10https://gerrit.wikimedia.org/r/202422 (owner: 10Bartosz Dziewoński) [15:50:56] (03CR) 10Jforrester: [C: 032] "(And OK from me too.)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/202422 (owner: 10Bartosz Dziewoński) [15:54:27] (03Merged) 10jenkins-bot: Apex, MediaWiki: Correct or delete unused SVG files [oojs/ui] - 10https://gerrit.wikimedia.org/r/202422 (owner: 10Bartosz Dziewoński) [15:57:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend-Feature-requests, 6WMF-Design-Research, and 2 others: Provide VisualEditor regardless of device size - https://phabricator.wikimedia.org/T85630#1189897 (10Jdforrester-WMF) p:5Triage>3Normal [16:06:37] 10Citoid: Ensure DOI, PMID, and PMCID are in citation when they're the requested format. - https://phabricator.wikimedia.org/T95434#1189929 (10Mvolz) 3NEW a:3Mvolz [16:06:53] 10Citoid, 7Technical-Debt: Create a cleaner import and export of natively scraped and zotero scraped citations - https://phabricator.wikimedia.org/T95295#1189939 (10Mvolz) [16:06:55] 10Citoid: Ensure DOI, PMID, and PMCID are in citation when they're the requested format. - https://phabricator.wikimedia.org/T95434#1189938 (10Mvolz) [16:07:17] (03PS1) 10Esanders: Add tests for TableAction#create [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202761 [16:10:29] (03PS2) 10Esanders: Add tests for TableAction#create [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202761 [16:10:44] 10Citoid: When requested format is bibtex, returns 200 ok with empty response when Zotero isn't running. Fix to return error status code. - https://phabricator.wikimedia.org/T78388#1189951 (10Mvolz) [16:17:56] (03PS3) 10Esanders: Add tests for TableAction#create [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202761 [16:18:01] 10Citoid: Citoid doesn't care about HTTP errors at all - https://phabricator.wikimedia.org/T88884#1190043 (10matmarex) [16:24:20] (03PS5) 10Jforrester: [WIP] Add a "Remove" context button to all Focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://bugzilla.wikimedia.org/60110) [16:24:21] (03CR) 10Jforrester: "PS5 is a rebase. Doesn't work. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://bugzilla.wikimedia.org/60110) (owner: 10Jforrester) [16:24:21] (03PS6) 10Jforrester: [WIP] Add a "Remove" context button to all Focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163662 (https://phabricator.wikimedia.org/T62110) [16:43:01] 10Citoid, 10Mathoid-General-or-Unknown, 10MediaWiki-extensions-Graph, 10MediaWiki-extensions-WikiHiero, and 3 others: Services need to share the same domain name - https://phabricator.wikimedia.org/T95402#1190382 (10mobrovac) RESTBase can easily be set up to proxy requests to back-end services without chan... [16:46:36] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari: Native Mac OS special character inserter fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T62839#1190399 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF This is now working, presuma... [16:47:49] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari: Native browser font styling tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T63884#1190409 (10Jdforrester-WMF) Confirming that this is still not working. [16:47:56] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: Native browser font styling tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T63884#1190410 (10Jdforrester-WMF) [16:54:56] (03CR) 10Mooeypoo: [C: 032] "Works well, and looks good." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [16:57:57] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): MWAlienNodes should have a minimum height and width and an icon - https://phabricator.wikimedia.org/T92868#1190454 (10Jdforrester-WMF) [16:58:05] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): MWAlienNodes should have a minimum height and width and an icon - https://phabricator.wikimedia.org/T92868#1190455 (10Jdforrester-WMF) 5Open>3Resolved [16:58:09] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Graph editing in VisualEditor - https://phabricator.wikimedia.org/T89287#1190457 (10Jdforrester-WMF) [16:59:00] (03CR) 10jenkins-bot: [V: 04-1] Adding minimum width and height to MWAlienExtensionNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [17:01:41] 10VisualEditor, 10Analytics-EventLogging, 6Analytics-Kanban: Wikitext events need to be sampled {lion} - https://phabricator.wikimedia.org/T93201#1190468 (10Milimetric) 5Open>3Resolved [17:06:05] 10Citoid, 6Services, 5Patch-For-Review: Configure OCG, Parsoid and Citoid to report counter metrics - https://phabricator.wikimedia.org/T94053#1190486 (10mobrovac) [17:07:34] (03CR) 10Cscott: [C: 04-1] "No, single hyphens cause problems with HTML." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [17:08:15] (03PS12) 10Jforrester: Adding minimum width and height to MWAlienExtensionNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [17:08:37] (03CR) 10Jforrester: [C: 032] "PS12 is trivial whitespace fixes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [17:08:43] (03CR) 10Krinkle: "Thanks :)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202712 (owner: 10Esanders) [17:09:08] (03CR) 10Cscott: Don't encoding single hyphens in comments, just doubles (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [17:11:41] edsanders: what was the motivation for https://gerrit.wikimedia.org/r/202711 ? [17:12:14] cscott, it's mentioned in the bug and the commit message [17:12:32] edsanders: yes, but i mean: really? why were you even noticing this at all? [17:12:49] it can't have been just to save a few bytes. [17:13:03] If I create or edit a comment in VE, or event just round trip it, that contains a hyphen [17:13:16] edsanders: yeah, that's just an artifact of the fact that you haven't updated your parsoid. [17:13:23] edsanders: that's not an actual issue. [17:13:27] e.g. "" [17:13:29] it is in core [17:13:45] edsanders: parsoid deploy is today. [17:14:16] (what does "it is in core" mean?) [17:14:43] cscott: It means you're not getting it deployed today. [17:14:55] cscott: It will start to go out to group0 only later today. [17:15:10] James_F: right, this issue is that edsanders has the latest VE but he doesn't have the latest Parsoid. [17:15:17] parsoid should deploy first, before VE. [17:15:21] parsoid is deploying today. [17:15:23] Won't that break everything? [17:15:46] I thought the VE changes had to be live everywhere before the Parsoid change could go live? [17:15:56] James_F: no, Parsoid is careful to make the round-tripping work (via selser) so long as VE doesn't modify the content it is given (which is what old-VE does) [17:16:26] cscott: We're relying on selser alone? Ick. [17:16:35] VE might display some html entities to the user during the transition period, but round-tripping isn't affected. [17:16:52] James_F: updates are hard. selser saves our butts occasionally. [17:17:21] cscott: So, it will only break for users, not for your diffs? ;-) [17:17:44] (03Merged) 10jenkins-bot: Adding minimum width and height to MWAlienExtensionNodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [17:17:44] James_F: we can accelerate VE's deploy if necessary, but not before Parsoid is deployed. ;) [17:18:09] James_F: and that's assuming that users read all the comments in the pages they edit. which I only *wish* were true. [17:18:15] cscott: Wait, you wrote a breaking change to VE-core that's backwards-incompatible with Parsoid? Eww. [17:19:12] James_F: well, there's a tweak to selser to ensure that the change is backwards-compatible. [17:20:12] anyway, i'm sympathetic to edsanders' desire to smooth over the transition period, but his current patch does the wrong thing. [17:21:01] that is, the current patch has no effect, because the changes it makes to VE's output are irrelevant to Parsoid HEAD. [17:21:34] the problem he was fixing was just an artifact of his not having updating his local Parsoid. [17:22:59] cscott, I mean VE in standalone mode [17:23:01] ignore Parsoid [17:23:09] edsanders: yes, we discussed this at length yesterday. [17:23:49] edsanders: please see discussion on https://gerrit.wikimedia.org/r/#/c/202311/ [17:24:47] I did [17:25:09] James_F, let's close https://phabricator.wikimedia.org/T92959 ? [17:25:31] Krenair: Invalid? [17:25:32] I appreciate we have to encode '--', but if we can avoid '-' then the source code will look tidier for non-MW users [17:25:39] I think so [17:25:46] Kk. [17:25:48] edsanders: well, the complexity tradeoff doesn't seem worth it to me personally -- if a downstream user of VE wants a different encoding scheme, they can implement it in a subclass. [17:25:50] 10VisualEditor, 10VisualEditor-EditingTools: Visual Editor special character at ln: - https://phabricator.wikimedia.org/T92959#1190569 (10Jdforrester-WMF) 5Open>3Invalid a:3Jdforrester-WMF [17:25:57] per... well, basically everything you said [17:26:03] edsanders: but if you want to add the complexity, i give a corrected regexp in the comments to your patch. [17:26:16] sure, I think it's a minor change [17:26:33] in the eye of the beholder, i guess. [17:28:04] (03PS4) 10Alex Monk: Collect only 25% of WikiEditor events [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199132 (https://phabricator.wikimedia.org/T93201) [17:28:24] 10VisualEditor, 10Analytics-EventLogging, 6Analytics-Kanban, 5Patch-For-Review: Wikitext events need to be sampled {lion} - https://phabricator.wikimedia.org/T93201#1190578 (10Krenair) 5Resolved>3Open [17:28:48] edsanders: (^-|^>|--|-$) is the minimal regexp, and you only need to encode the last character of the match. [17:29:12] James_F, for metrics "milestones", how does this summary sound to you [17:29:13] VisualEditor: Reaching release-readiness (all identified Q3 blockers resolved). [17:29:13] Launch of new RESTBase API which helped reduce mean client HTML load time by 40% [17:30:51] oh, because is invalid? [17:32:06] Eloquence: another significant speed-up will go live on wikipedias today, with VE loading HTML directly from restbase rather than going through the PHP API [17:32:35] Eloquence: Hey. That sounds good. [17:32:41] (03CR) 10Cscott: Don't encoding single hyphens in comments, just doubles (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [17:32:45] gwicke: Yes, but we're talking about Q3 deliverables. :-) [17:33:00] ah, k ;) [17:33:01] edsanders: is a valid & complete html comment. [17:33:02] Eloquence: I'd say that "Launch of new RESTBase API which alone helped reduce mean client HTML load time by 40%" [17:33:14] edsanders: so is [17:33:44] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): VisualEditor: Deletion across a header caused it to remain without WS, leading Parsoid to output "====" - https://phabricator.wikimedia.org/T52100#1190606 (10gpaumier) [17:36:02] James_F: mobrovac says we'll enable RESTbase on Wikipedias today? [17:36:06] and it's not clear what happens to (as you note) but it's not allowed (the html parsing spec actually handles it ok). is also a valid HTML5 comment, but it ought to be handled by the -- case. [17:36:14] James_F: But it's not in the deployments calendar? [17:36:24] RoanKattouw: enwiki first if there's time. Once testing is done, then the rest of Wikipedias was the plan. [17:36:38] RoanKattouw: It's fine to delay. [17:37:22] [10:33] edsanders [2015-04-08 10:26:58] oh, because is invalid? [17:37:25] edsanders: That's valid HTML but invalid XML [17:37:29] As is [17:38:11] James_F: No I just wanted to make sure that it was really happening today, despite its current absence from [[wikitech:Deployments]] [17:38:12] RoanKattouw: ah, right. that's why the HTML spec forbids it even though the HTML parser spec seems to handle it fine. [17:38:16] No need to delay [17:38:22] ( i mean) [17:38:23] (03PS3) 10Mooeypoo: Allow extra properties for ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) [17:38:25] cscott: lol really? [17:38:31] RoanKattouw: OK. [17:38:36] "Consistency, we've heard of it" --W3C [17:38:44] (03PS7) 10Mooeypoo: Allow for citation tools to work under the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) [17:39:09] (03CR) 10Jforrester: [C: 031] "dm/nodes coverage —" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202761 (owner: 10Esanders) [17:39:15] RoanKattouw: ---W3C, surely. [17:39:16] ;-) [17:39:28] RoanKattouw: after you've seen the first '--' you're in https://html.spec.whatwg.org/multipage/syntax.html#comment-end-state and from there if you see another - you "parse error" but go ahead and append it to the "comment token's data" anyway. which is to say it's fine. [17:40:15] mooeypoo: You should tweak the title of that commit now it's only inDialog I guess? [17:40:39] James_F, you're right, I tweaked the message itself and forgot the title [17:40:44] :-) [17:40:50] (03PS2) 10Mooeypoo: Use the new MWPreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 [17:41:01] "ve.ui.Surface: Add inDialog property" [17:41:04] Or whatever. [17:41:35] (03CR) 10jenkins-bot: [V: 04-1] Use the new MWPreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [17:41:44] (03PS4) 10Mooeypoo: Add an inDialog config option in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) [17:42:09] eh we really need to fix grunt in Citoid [17:42:17] It's broken? [17:42:22] it ignores the files [17:42:29] kirstenMA, want to do a hangout at 11? [17:42:36] (03CR) 10Jforrester: [C: 031] Add an inDialog config option in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [17:42:49] mooeypoo: Oh, yeah. Will steal Timo's time. [17:43:24] James_F, "Running "jshint:all" (jshint) task >> 0 files linted. Please check your ignored files." [17:43:26] :\ [17:43:29] I have no idea why. [17:43:33] edsanders: sure. [17:43:58] (03PS3) 10Mooeypoo: Use the new MWPreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 [17:46:40] James_F, done. Luis asked if we have a #of blockers count that we can include [17:47:10] Eloquence: For what? Deployment? No engineering blockers currently. [17:49:13] James_F, he means, the overall number of blocker-level bugs that were resolved through the quarter [17:50:10] Eloquence: There are 364 tickets in the "Done" column of the Q3 work. [17:50:40] Eloquence: But that's a bit of an over-estimate; we added things as Q3 blockers if we decided we needed to do them in Q3, even if they didn't have a crisis-blocker status. [17:53:36] *nod* I'll include that number as "364 issues resolved" [17:54:39] 10Citoid, 10Mathoid-General-or-Unknown, 10MediaWiki-extensions-Graph, 10MediaWiki-extensions-WikiHiero, and 4 others: Services need to share the same domain name - https://phabricator.wikimedia.org/T95402#1190711 (10Yurik) [17:55:46] Eloquence: Sounds good. [18:00:54] (03PS5) 10Cscott: Encode as few characters in comments as possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [18:01:27] mooeypoo: I get ">> 4 files lint free. " in the Citoid extension repo [18:01:34] mooeypoo: Did we fix it, or am I doing it wrong? [18:02:26] (03CR) 10Cscott: "Updated the patch for correctness, but I'm still -0 on this patch. I think it adds complexity without a compelling use case (I don't expe" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [18:03:00] 10MediaWiki-Page-editing, 10MediaWiki-Interface, 7Design: Add section edit link for 0th section of a page/article - https://phabricator.wikimedia.org/T2156#1190748 (10SamB) [18:11:20] 10VisualEditor: Citation dialogs should have cursor positioned in the first field as in Template/Media - https://phabricator.wikimedia.org/T95450#1190758 (10Etonkovidova) 3NEW [18:11:31] (03PS6) 10Catrope: Encode as few characters in comments as possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [18:11:53] (03PS4) 10Mooeypoo: Flip popup alignment in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 [18:12:10] (03CR) 10Mooeypoo: "It should work now after rebasing on top of the demo fix." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [18:12:23] 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): When opening reference dialog from the MWGeneralReferenceDialog the cursor "insists" on being on the general document surface ra... - https://phabricator.wikimedia.org/T95069#1190767 [18:13:20] edsanders: https://gerrit.wikimedia.org/r/202624 https://gerrit.wikimedia.org/r/201583 [18:14:25] RoanKattouw: edsanders objected to https://gerrit.wikimedia.org/r/202624 on the Phabricator task. [18:14:35] Sorry, https://gerrit.wikimedia.org/r/201583 [18:15:04] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Link context item appears when selecting image whose entire caption is a link - https://phabricator.wikimedia.org/T95246#1190799 (10Jdforrester-WMF) [18:24:00] 10VisualEditor, 10VisualEditor-Performance: VE save/load performance tracking for desktop and mobile are comingled - https://phabricator.wikimedia.org/T95432#1191022 (10Catrope) Yes, they are, sorry :( . I had to do that to unbreak things after TargetLoader was merged. Now that Alex has TargetLoader-ified Mobi... [18:25:41] Krenair: Are you still looking to be assigned more work? [18:25:59] Krenair: Cause if so, I have https://phabricator.wikimedia.org/T95432#1191022 for you :) [18:27:03] 10VisualEditor, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers: VE save/load performance tracking for desktop and mobile are comingled - https://phabricator.wikimedia.org/T95432#1191026 (10Jdforrester-WMF) p:5Triage>3High [18:27:46] RoanKattouw: Evil. ;-) [18:28:04] If not, I'll do it myself [18:28:52] * James_F nods. [18:29:03] Speaking of, how are you doing on sub-documents? [18:29:04] ;-) [18:29:18] Yeeeaaahhh... [18:29:34] My copious free time, huh? [18:30:00] It's been days since you last promised you were going to work on it. [18:30:08] I figured it was time to prompt you again. ;-) [18:31:35] haha [18:32:57] RoanKattouw, should I have stuck to calling my ve.ui.Surface property "isSubDocument" ? you could have considered it progress.... [18:32:59] ;) [18:34:34] No [18:34:49] "subdocument" is a term that I've already eliminated from my code [18:34:57] It's kind of sticking around as an informal term [18:35:01] RoanKattouw: Is it now "nested document"? [18:35:03] I need to clean up the jargon at some point [18:35:08] RoanKattouw: DocuShard? [18:35:12] It's ... I don't know [18:35:16] RoanKattouw: FragmaDoc. [18:35:17] Maybe we will call it a subdocument [18:35:30] RoanKattouw: UnterDok. [18:35:32] Etc [18:35:56] * James_F stops trying to make RoanKattouw laugh aloud whilst in the broadcast meeting. :-) [18:37:16] (03CR) 10Catrope: [C: 032] Add tests for TableAction#create [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202761 (owner: 10Esanders) [18:39:24] RoanKattouw: Want to get https://gerrit.wikimedia.org/r/#/c/202711/ in before the cut? [18:39:29] Oh. Too late. [18:40:41] RoanKattouw, yeah it also didn't really work with what I was trying to do [18:42:57] (03CR) 10Catrope: [C: 04-1] Add an inDialog config option in ve.ui.Surface (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [18:46:32] (03CR) 10Manybubbles: [C: 031] Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [18:52:07] Krinkle: https://gerrit.wikimedia.org/r/#/c/201008/ [18:53:07] RoanKattouw: Krinkle's busy. [18:53:13] RoanKattouw: Apparently CI is breaking. [18:54:40] Oh OK [18:55:25] RoanKattouw: "In the next 2 hours". [18:57:28] It's not urgent [18:57:51] RoanKattouw, (sorry, was having dinner) [18:58:17] will remind myself what we did wrong when gerrit loads [18:58:41] Krenair: So the code that calls ve.track() in TargetLoader is the culprit [18:58:52] It used to live in mw.Target where it could do this.constructor.static.targetName [18:58:57] Now it can't do that as easily any more [18:59:14] so we just hardcoded the non-mobile value? [18:59:17] So we need some way for it to send the type of target over to ve.track() [18:59:29] We set 'desktop' as the default in trackSubscriber I think [18:59:33] So undefined -> 'desktop' [18:59:39] Or 'mwTarget' or whatever it is [19:00:08] something like mwTarget [19:00:21] Is gerrit down for anyone else? [19:00:45] It's been flaky for me today [19:03:35] * James_F sits in the Weekly Triage meeting all alone. [19:03:39] Anyone else coming? [19:03:56] (03CR) 10Catrope: [C: 032] Encode as few characters in comments as possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [19:04:31] RoanKattouw: I assume that's not worth back-porting? [19:04:34] James_F: There's still a 30-person deep line for lunch over here, so... [19:04:46] James_F: Not realy [19:04:54] Unless the current implementation causes problems [19:04:56] RoanKattouw: I assumed so. [19:05:04] RoanKattouw: OK, starting without. [19:05:16] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation, and 2 others: HTML entities in CommentNode must be manually escaped/unescaped - https://phabricator.wikimedia.org/T95040#1191200 (10Jdforrester-WMF) [19:11:05] 10VisualEditor, 10VisualEditor-EditingTools: Visual Editor special character at ln: - https://phabricator.wikimedia.org/T92959#1191219 (10Eruedin) Now it works well. Thank you. [19:13:35] 10VisualEditor, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers: VE save/load performance tracking for desktop and mobile are comingled - https://phabricator.wikimedia.org/T95432#1191228 (10Jdforrester-WMF) [19:14:24] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: Native browser font styling tool fails to get content into DM, just CE, in Safari - https://phabricator.wikimedia.org/T63884#1191232 (10Jdforrester-WMF) [19:15:59] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: After tapping on "Go back"/"Continue Anyway" in the "Required parameter missing" confi... - https://phabricator.wikimedia.org/T73259#765321 [19:16:22] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Cursor moving handle (?) doesn't appear in Android - https://phabricator.wikimedia.org/T68783#1191252 (10Jdforrester-WMF) [19:16:57] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: Can't select an image node if the cursor is active? - https://phabricator.wikimedia.org/T73841#770683 (10Jdforrester-WMF) [19:17:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: The page focus always bumps up to the top irrespective of cursor position - https://phabricator.wikimedia.org/T72111#725437 (10Jdforrester-WMF) [19:18:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: The keyboard stays in the ReadMode after tapping on the Browser back button/ the cross button on the Mobile VE - https://phabricator.wikimedia.org/T67411#697916 (10Jdforrester-WMF) [19:18:22] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Copy-paste not working in mobile VE - https://phabricator.wikimedia.org/T86365#966972 (10Jdforrester-WMF) [19:18:31] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Rapidly multiplying pawns after editing near a link in MobileSafari on iPad - https://phabricator.wikimedia.org/T53677#549172 (10Jdforrester-WMF) [19:18:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Citation dialog not opening in mobile VE for en.wiki - https://phabricator.wikimedia.org/T86077#1191279 (10Jdforrester-WMF) [19:19:30] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: "Select all " option in mobile VE selects the options in the toolbar too, it should only select the content inside the CE - https://phabricator.wikimedia.org/T86364#1191285 (10Jdforrester-WMF) [19:20:01] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: In iOS Safari, all dialogs in mobile VE opening halfway or as empty on the first attempt of every edit session - https://phabricator.wikimedia.org/T86233#1191290 (10Jdforrester-WMF) [19:20:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile: tapping into middle of link inspector text causes lots of issues - https://phabricator.wikimedia.org/T71578#724570 (10Jdforrester-WMF) [19:20:23] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VE Mobile: The word "Editing" floats randomly underneath the back button - https://phabricator.wikimedia.org/T71632#731387 (10Jdforrester-WMF) [19:20:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: When the cursor is not active in the document, the toolbar is not activated, as nothing happens on tapping on the options, which is very confusing - https://phabricator.wikimedia.org/T86230#964179 (10Jdforrester-WMF) [19:20:44] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VE Mobile: Tapping words sometimes moves them to the lead section and makes them bold - https://phabricator.wikimedia.org/T71634#731577 (10Jdforrester-WMF) [19:21:04] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile:CE is getting zoomed in on rotating the screen orientation in iPad Mini - https://phabricator.wikimedia.org/T70883#735268 (10Jdforrester-WMF) [19:21:19] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - https://phabricator.wikimedia.org/T68696#695517 (10Jdforrester-WMF) [19:21:32] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: [Regression wmf14] In mobile VE, as soon as you place your cursor inside the field in Citation dialog and type, the text box disappears - https://phabricator.wikimedia.org/T84914#1191323 (10Jdforrester-WMF) p:5Normal>... [19:21:44] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers: Editing tables in Mobile - Edit mode displays broken tables - https://phabricator.wikimedia.org/T74819#763997 (10Jdforrester-WMF) [19:21:55] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: Toolbar does not float while tapping towards the end of the screen in iOS Safari - https://phabricator.wikimedia.org/T70832#728914 (10Jdforrester-WMF) [19:22:06] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 7Browser-Support-Apple-Safari, 3Editing Department 2014/15 Q4 blockers: [Regression wmf16] Cannot scroll the link suggestions inside link inspector in iOS Safari - https://phabricator.wikimedia.org/T71038#721105 (10Jdforrester-WMF) [19:22:23] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Mobile VE - Cite dialogue fields are buggy - https://phabricator.wikimedia.org/T91849#1097395 (10Jdforrester-WMF) [19:22:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Mobile VE - Cite dialogue fields are buggy - https://phabricator.wikimedia.org/T91849#1191341 (10Jdforrester-WMF) p:5Triage>3High [19:23:06] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Mobile VE - Back and Next buttons should align to top toolbar - https://phabricator.wikimedia.org/T91841#1191350 (10Jdforrester-WMF) p:5Triage>3Normal [19:23:17] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Mobile VE - Toolbar icons too close, tap area too small - https://phabricator.wikimedia.org/T92027#1191353 (10Jdforrester-WMF) p:5Triage>3Normal [19:23:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Mobile VE - Dropdown menus need larger tap areas - https://phabricator.wikimedia.org/T92010#1191357 (10Jdforrester-WMF) p:5Triage>3Normal [19:23:37] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Mobile VE - cursor remains in place while contents scoll - https://phabricator.wikimedia.org/T92004#1191359 (10Jdforrester-WMF) p:5Triage>3Normal [19:23:52] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Mobile VE - Save page title wrapping weirdly - https://phabricator.wikimedia.org/T92016#1191361 (10Jdforrester-WMF) p:5Triage>3Normal [19:24:53] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Slugs should not be visible through context menu - https://phabricator.wikimedia.org/T93042#1191377 (10Jdforrester-WMF) [19:25:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, 3Editing Department 2014/15 Q4 blockers: Change Welcome dialogue content to more helpful message to new users based on the GuidedTour - https://phabricator.wikimedia.org/T89072#1026973 (10Jdforrester-WMF) [19:25:33] (03Merged) 10jenkins-bot: Add tests for TableAction#create [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202761 (owner: 10Esanders) [19:25:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers: Progress bar moves backwards sometimes - https://phabricator.wikimedia.org/T93964#1191387 (10Jdforrester-WMF) [19:26:08] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Citation does not get added when the autofill citation dialog is open in the background - https://phabricator.wikimedia.org/T93638#1142485 (10Jdforrester-WMF) [19:26:22] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Write some easy user-facing documentation on how to enable and configure auto-filled citations on your wiki - https://phabricator.wikimedia.org/T94864#1174702 (10Jdforrester-WMF) [19:27:18] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Preview interface for link dialogue - https://phabricator.wikimedia.org/T88316#1009312 (10Jdforrester-WMF) [19:27:27] 10VisualEditor, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers: VE save/load performance tracking for desktop and mobile are comingled - https://phabricator.wikimedia.org/T95432#1191411 (10Catrope) a:3Krenair [19:27:31] 10VisualEditor, 10VisualEditor-Performance, 10RESTBase, 3Editing Department 2014/15 Q4 blockers: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1191412 (10Jdforrester-WMF) [19:27:51] 10OOjs-UI, 10VisualEditor, 7Design, 3Editing Department 2014/15 Q4 blockers: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1191415 (10Jdforrester-WMF) a:3Nirzar [19:28:09] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Set up mass round-trip testing infrastructure on real content - https://phabricator.wikimedia.org/T52513#1191421 (10Jdforrester-WMF) p:5High>3Normal [19:28:15] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Set up mass round-trip testing infrastructure on real content - https://phabricator.wikimedia.org/T52513#563296 (10Jdforrester-WMF) [19:28:41] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1191424 (10Jdforrester-WMF) [19:30:05] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor Mobile:Performance issue with adding Citations in Mobile - https://phabricator.wikimedia.org/T72184#1191433 (10Jdforrester-WMF) [19:31:44] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10VisualEditor-Performance, and 2 others: Pasting content results in scroll flickering - https://phabricator.wikimedia.org/T89623#1191443 (10Jdforrester-WMF) [19:32:05] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10VisualEditor-Performance, and 2 others: Pasting content results in scroll flickering - https://phabricator.wikimedia.org/T89623#1040634 (10Jdforrester-WMF) [19:34:07] RoanKattouw_away: Do you feel like splitting https://phabricator.wikimedia.org/T49344 into sub-tasks for sub-documents? ;-) [19:34:21] Hmm maybe [19:34:41] https://phabricator.wikimedia.org/project/sprint/view/1113/ is now looking less good. ;-) [19:36:53] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Edit links on sections in mobile and desktop alike launch VE in whole-page mode, but WE in section mode, which is confusing - https://phabricator.wikimedia.org/T86265#1191453 (10Jdforrester-WMF) p:5Normal>3Lowest [19:37:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Performance, 7Tracking: Improve VisualEditor's performance on tablet devices - https://phabricator.wikimedia.org/T64755#1191457 (10Jdforrester-WMF) [19:37:26] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Performance, 7Tracking: Improve VisualEditor's performance on tablet devices - https://phabricator.wikimedia.org/T64755#660697 (10Jdforrester-WMF) Not actionable as a task; this is a tracker. [19:38:16] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Browser-Tests: VisualEditor: Create browser tests for using VE via Mobile UI - https://phabricator.wikimedia.org/T62290#1191459 (10Jdforrester-WMF) [19:38:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Browser-Tests: VisualEditor: Create browser tests for using VE via Mobile UI - https://phabricator.wikimedia.org/T62290#651148 (10Jdforrester-WMF) In the Triage meeting we felt that this wasn't a clear enough ask for Q4. [19:42:12] (03Merged) 10jenkins-bot: Encode as few characters in comments as possible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202711 (https://phabricator.wikimedia.org/T95040) (owner: 10Esanders) [19:46:28] 10VisualEditor: Betalabs: the saved edits are displayed after additional page refresh - https://phabricator.wikimedia.org/T95466#1191481 (10Etonkovidova) 3NEW [19:56:38] James_F, RoanKattouw: I *think* the train has left the station; could use the Services window opening in four minutes to do some config tweaking? [19:59:18] (03Abandoned) 10Bartosz Dziewoński: Support 'min', 'max' and 'step' in TextInputWidget constructor [oojs/ui] - 10https://gerrit.wikimedia.org/r/188425 (owner: 10Ricordisamoa) [20:02:05] etonkovidova: Could you file a ticket (or point me to an existing one [20:02:19] etonkovidova: ...) about the "old version after save" bug? [20:02:32] https://phabricator.wikimedia.org/T95466 [20:02:57] 10VisualEditor, 10VisualEditor-MediaWiki: Mysterious missingrev failure during save - https://phabricator.wikimedia.org/T94367#1191530 (10Catrope) Probably the same underlying issue as T95466 [20:06:54] ok meh once again, 'git submodule update' leaves lib/ve red with (untracked changes) even though there are no changes in there [20:07:13] tried to pull, tried to pull the submodule master, nothing helps [20:07:22] tried to git reset the lib/ve folder... [20:07:32] RoanKattouw, ? help? [20:09:42] mooeypoo: Run git status inside lib/ve [20:10:01] RoanKattouw, crap, it's the test-coverage again [20:10:05] i didn't notice [20:10:21] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Replace cite icon with "cite" label - https://phabricator.wikimedia.org/T95470#1191562 (10KHammerstein) 3NEW [20:10:33] RoanKattouw, is there something I can do to make this stop doing that? [20:11:17] mooeypoo: This is supposed to be in .gitignore already, is it not there? [20:11:29] mooeypoo: Also did you remove the test-coverage dir and did it regenerate itself? [20:11:36] I thought it was renamed to coverage [20:11:45] RoanKattouw: It was. [20:11:46] RoanKattouw, I rmoved it last time it happened [20:11:49] apparently it reappeared [20:11:53] I didn't create it :\ [20:12:00] RoanKattouw: edsanders and I fixed it being re-created this morning. [20:12:11] mooeypoo: Tryagain. [20:12:21] RoanKattouw, I did pull a previous commit from gerrit [20:12:29] and then grunted it. That might have done it [20:12:41] Without a rebase? Yeah, that'd have done it. [20:12:50] yeah. Didn't notice. [20:13:00] Easily done. [20:13:01] Yeah that'll do it [20:13:10] (03PS5) 10Mooeypoo: Add an inDialog config option in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) [20:14:33] (03PS6) 10Mooeypoo: Add an inDialog config option in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) [20:16:16] James_F, RoanKattouw: what's the plan re loading HTML from RB? [20:16:26] gwicke: We need to do it. ;-) [20:16:41] gwicke: Patch is written but is production on wmf24 yet? [20:16:42] if you have a patch we could do it now [20:16:54] yes, from what I have seen it is [20:17:09] https://en.wikipedia.org/wiki/Special:Version says wmf23. [20:18:21] 19:59 logmsgbot: twentyafterfour Started scap: testwiki to php-1.26wmf1 and rebuild l10n cache [20:18:26] might still be in progress? [20:18:39] Yeah, that'll take a while. [20:19:28] 10VisualEditor, 10VisualEditor-DataModel, 10Parsoid, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1191600 (10Jdforrester-WMF) p:5Triage>3Normal [20:20:09] 10OOjs-UI, 5OOjs-UI-0.9.5, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): [Regression wmf22] No gap between Button labels and icons in Media Settings>Advanced Settings dialog - https://phabricator.wikimedia.org/T93002#1191602 (10Jdforrester-WMF) [20:20:10] James_F: k [20:20:11] 10OOjs-UI, 5OOjs-UI-0.9.5, 5WMF-deploy-2015-04-08_(1.26wmf1): Buttons explode in narrow containers - https://phabricator.wikimedia.org/T93552#1191604 (10Jdforrester-WMF) [20:20:15] 10OOjs-UI, 5OOjs-UI-0.9.5, 10UI-Standardization, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): Flags can only be applied to buttons - https://phabricator.wikimedia.org/T93890#1191605 (10Jdforrester-WMF) [20:20:17] 10OOjs-UI, 5OOjs-UI-0.9.5, 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-04-08_(1.26wmf1): The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens - https://phabricator.wikimedia.org/T89612#1191603 (10Jdforrester-WMF) [20:20:19] 10OOjs-UI, 5OOjs-UI-0.9.5, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): Provide an RTL variant of the 'help' icon, but don't use it for he and yi - https://phabricator.wikimedia.org/T76540#1191614 (10Jdforrester-WMF) [20:20:19] (Boo.) [20:20:21] 10OOjs-UI, 5OOjs-UI-0.9.5, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): Properly support ltr/rtl icon versions in colorize-svg.js - https://phabricator.wikimedia.org/T94560#1191610 (10Jdforrester-WMF) [20:22:46] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Make VisualEditor primary (first editor tab) on the English Wikipedia for people for whom it's enabled - https://phabricator.wikimedia.org/T92895#1191624 (10Jaredzimmerman-WMF) Sorry to clarify, for users who have made the dec... [20:24:27] (03PS1) 10Catrope: Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202911 (https://phabricator.wikimedia.org/T95466) [20:28:35] (03PS4) 10Violetto: Adding viewing options icons for iconography page. [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 [20:30:49] (03CR) 10Violetto: "Thanks Ed, hoping this works!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [20:39:25] James_F, RoanKattouw, edsanders, etc: latest parsoid deployed. [20:39:47] confirmed that comments don't get corrupted by old-VE. waiting for group 0 train deploy to complete so I can test new-VE. [20:42:21] 10VisualEditor, 6Collaboration-Team, 10Flow, 10MediaWiki-extensions-ContentTranslation, and 2 others: HTML entities in CommentNode must be manually escaped/unescaped - https://phabricator.wikimedia.org/T95040#1191673 (10cscott) T95039 is now deployed in Parsoid. If a few encoded characters in comments suf... [20:44:14] sweet [20:46:02] uhm... my progress bar when loading ve just moved backwards [20:46:22] I saw this on Joel computer yesterday too but couldn't reproduce. Now it happened randomly again [20:48:18] mooeypoo: Yeah. [20:48:24] cscott: Awesome. [20:48:35] (03PS2) 10Catrope: Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202911 (https://phabricator.wikimedia.org/T95466) [20:51:09] RoanKattouw: Time to merge https://gerrit.wikimedia.org/r/#/c/198729/ ? [20:51:21] (03PS5) 10Jforrester: [BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198729 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [20:51:41] (03CR) 10Jforrester: "Explanation now given. Good to get this out ASAP." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198729 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [20:51:45] James_F: I'll give it a once-over and merge it if nothing in there scares me [20:51:49] Cool [20:51:55] (03PS5) 10Violetto: Adding visionSimulator icon for iconography page. [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 [20:52:13] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 7Technical-Debt: MWExtensionInspector should inherit from NodeInspector - https://phabricator.wikimedia.org/T93592#1191691 (10Jdforrester-WMF) [20:52:25] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 7Technical-Debt: MWExtensionInspector should inherit from NodeInspector - https://phabricator.wikimedia.org/T93592#1141310 (10Jdforrester-WMF) [20:53:37] (03CR) 10Aaron Schulz: [C: 032] Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202911 (https://phabricator.wikimedia.org/T95466) (owner: 10Catrope) [20:54:01] RoanKattouw: Does ^^^ need back-porting? [20:54:37] James_F: Yes, provisionally [20:54:51] James_F: As in, let's let it live on beta for a few hours and see if etonkovidova can still reproduce this problem [20:54:55] RoanKattouw: Think we should… yes. :-) [20:55:06] OK, I'll leave in your capable hands. [20:55:09] James_F: So schedule for 4pm SWAT and strike it if something explodes [20:55:37] etonkovidova understood :) [20:58:40] James_F: hmm. how would you feel about the OOUI build step generating the RL module data for MediaWiki? how would you feel, instead, about adding a little PHP or JS maintenance script to generate such data to be ran from update-oojs-ui.sh in MediaWiki? [20:58:58] James_F: i'm fishing for ideas about making https://gerrit.wikimedia.org/r/#/c/202430/ suck less [20:59:10] (cc legoktm, Krinkle|detached) [20:59:17] MatmaRex: I don't particularly care as long as it's sane and meets Timo's and Trevor's approval [21:00:28] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): Resolvable DOIs, PMIDs, and PMCIDs should be checked for itemType and manually set to journalArticle - https://phabricator.wikimedia.org/T94597#1191727 (10Etonkovidova) Checked the fix in beta. [21:01:27] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari: VisualEditor: undefined error during copy - https://phabricator.wikimedia.org/T60379#1191731 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Can't reproduce any more. We did a lot of changes to Select-All in the intervening... [21:02:25] (03Merged) 10jenkins-bot: Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202911 (https://phabricator.wikimedia.org/T95466) (owner: 10Catrope) [21:03:44] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): Saved edits are displayed only after additional page refresh - https://phabricator.wikimedia.org/T95466#1191744 (10Jdforrester-WMF) p:5Triage>3High a:3Catrope [21:04:13] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, 5WMF-deploy-2015-04-15_(1.26wmf2): Mysterious missingrev failure during save - https://phabricator.wikimedia.org/T94367#1191750 (10Jdforrester-WMF) p:5Triage>3Unbreak! a:3Catrope [21:04:32] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): Mysterious missingrev failure during save - https://phabricator.wikimedia.org/T94367#1160735 (10Jdforrester-WMF) [21:04:59] * MatmaRex writes an email [21:07:56] 10VisualEditor: Error in retrieving Data format for DOI and PMCID - https://phabricator.wikimedia.org/T95478#1191772 (10Etonkovidova) 3NEW [21:08:34] 10Citoid, 10VisualEditor: Error in retrieving Data format for DOI and PMCID - https://phabricator.wikimedia.org/T95478#1191781 (10Catrope) a:3Mvolz [21:11:28] (03CR) 10jenkins-bot: [V: 04-1] Adding visionSimulator icon for iconography page. [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [21:12:15] etonkovidova: https://phabricator.wikimedia.org/T95466 should no longer be reproducible on beta [21:12:27] etonkovidova: Hopefully. If I'm wrong, please tell me before 4pm :) [21:12:52] (03PS1) 10Catrope: Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/202920 (https://phabricator.wikimedia.org/T95466) [21:13:27] 10Citoid, 10VisualEditor: Error in retrieving Data format for DOI and PMCID - https://phabricator.wikimedia.org/T95478#1191811 (10mobrovac) This is a known issue - T95016 [21:13:51] 10Citoid, 10VisualEditor: Error in retrieving Data format for DOI and PMCID - https://phabricator.wikimedia.org/T95478#1191813 (10Catrope) [21:13:53] 10Citoid: Citoid should be validating date fields - https://phabricator.wikimedia.org/T95016#1191814 (10Catrope) [21:14:33] (03PS1) 10Catrope: Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202921 (https://phabricator.wikimedia.org/T95466) [21:15:33] 10MediaWiki-ResourceLoader, 7JavaScript: Implement ability to create wiki-modules at a user level - https://phabricator.wikimedia.org/T36958#1191820 (10SamB) [21:15:41] 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1191821 (10mobrovac) >>! In T90374#1191779, @gerritbot wrote: > Change 200105 merged by jenkins-bot: > Make VisualEditor access RESTbase directly on enwiki > >... [21:17:12] 10Citoid, 10VisualEditor: Error in retrieving Data format for DOI and PMCID - https://phabricator.wikimedia.org/T95478#1191835 (10Etonkovidova) [21:24:27] 10Citoid, 10VisualEditor: Error in retrieving Data format for DOI and PMCID - https://phabricator.wikimedia.org/T95478#1191853 (10Etonkovidova) >>! In T95478#1191811, @mobrovac wrote: > This is a known issue - T95016 Yes, it is. However, PMID Source date is interpreted correctly. Using PMCID or DOI for the... [21:50:40] RoanKattouw: I think the stats are actually broken [21:51:05] gwicke: How? [21:51:12] I mean the deploy train might have broken them [21:51:37] That wouldn't be very shocking [21:51:50] But in what way do you believe them to be broken? [21:52:51] the request rate drops a lot around 13:50 [21:52:56] according to the stats [21:53:07] which is the deploy train [21:53:18] edsanders: https://gerrit.wikimedia.org/r/#/c/202624/ [21:55:01] RoanKattouw: I see there's also restbaseLoad in the stats now [21:55:16] but its rate is still very low [21:55:34] (03CR) 10Esanders: [C: 032] Skip ignoreChildren nodes in getAnnotatedRangeFromSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202624 (https://phabricator.wikimedia.org/T95246) (owner: 10Catrope) [21:55:37] aha! most of the traffic is now on apiLoad [21:58:03] ? [21:58:24] ... can you repeat that in different terms? [21:58:42] Oooh I think I get it [21:58:48] Of course [21:58:52] We split between those two now [22:00:47] just getting one long-term graph of VE load times is getting a bit complicated [22:00:58] Yeah :( [22:01:04] there's now four metrics that need to be integrated [22:01:14] Well, I mean the way things are loaded fundamentally changed [22:01:18] (03Merged) 10jenkins-bot: Skip ignoreChildren nodes in getAnnotatedRangeFromSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202624 (https://phabricator.wikimedia.org/T95246) (owner: 10Catrope) [22:01:40] yeah [22:01:59] next time, might be worth incrementing the old metrics for a little while longer when doing a split like this [22:02:05] OK so what we saw in the graph was really just the elimination of enwiki from the data [22:02:13] But with what? [22:02:25] with either data [22:02:28] max(apiLoad, rbLoad)? [22:02:55] on rb load, send a timing for domLoad *and* restbaseLoad [22:03:08] and on api load, same for domLoad *and* apiLoad [22:03:08] Oh I see [22:03:15] Duplicate data points [22:03:26] *nod* [22:03:29] Hmm [22:03:44] Yeah it wasn't clear to me what strategy would have been most valuable [22:03:48] and then I forgot about this problem altogether [22:03:59] it's possible to do this in graphite too with some weighted averaging etc, but it's not exactly simple.. [22:05:18] on the plus side, I now get to study advanced grafana functionality [22:06:17] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): Link context item appears when selecting image whose entire caption is a link - https://phabricator.wikimedia.org/T95246#1192102 (10Jdforrester-WMF) 5Open>3Resolved a:3Catrope [22:11:49] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: Saved edits are displayed only after additional page refresh - https://phabricator.wikimedia.org/T95466#1192136 (10Jdforrester-WMF) [22:12:00] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: Mysterious missingrev failure during save - https://phabricator.wikimedia.org/T94367#1192138 (10Jdforrester-WMF) [22:13:53] gwicke: I've added basic views of the API and RB load times to that dashboard [22:14:12] (03CR) 10Yuvipanda: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [22:15:24] RoanKattouw: uh oh [22:15:35] I had just added some averaging logic [22:15:45] Oh sorry :( [22:15:47] better don't reload then [22:15:51] RoanKattouw: Did you over-write each other? [22:16:00] Is that why there were three serialization time panels? [22:16:10] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1192165 (10Etonkovidova) Checked in Production PMID and PMCID and the link mentioned in the ticket: 24587267 PMC1311220 14656957 The link h... [22:16:12] I still have a chance to re-overwrite RoanKattouw [22:16:12] On http://grafana.wikimedia.org/#/dashboard/db/visualeditor-load-save I only see two. [22:16:16] OK [22:16:19] I will stop touching it now [22:16:25] Or are you talking about a different one? [22:16:31] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-04-08_(1.26wmf1): ID converter api fails on some pmids - https://phabricator.wikimedia.org/T93335#1192168 (10Etonkovidova) [22:16:43] Oooh I never saved mine [22:16:44] hah [22:16:50] OK, no damage done [22:16:52] Also, can I suggest we show the req/s as req/m so that the numbers are less useless? [22:17:07] 0 vs. 0 vs. 0 isn't great data. :-) [22:17:12] 10MediaWiki-Page-editing, 6Availability-Team, 10Wikidata, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1192173 (10ksmith) [22:18:15] James_F: req/m is a metric that few people use [22:18:34] gwicke: OK, how about centirequest per minute? ;-) [22:18:55] the 60 in there messes up the tidy conversions [22:19:32] it's easier to compare numbers when we use the same number throughout [22:19:46] For you. [22:20:16] For everyone who isn't in Services they don't care to compare requests for RESTbase between VE and Mobile Apps, or VE RESTbase vs. Citoid requests. :-) [22:21:20] James_F: you could save a copy to http://grafana.wikimedia.org/#/dashboard/db/visualeditor-load-save-per-minute & edit that ;) [22:21:30] (or in equating html load time with load time) [22:22:21] gwicke: So could you. ;-) [22:22:31] ori: :-) [22:22:33] James_F: I don't feel the minute itch ;) [22:26:46] this averaging business is not as simple as I had hoped [22:28:19] 10MediaWiki-ResourceLoader, 7JavaScript: Implement ability to create wiki-modules at a user level - https://phabricator.wikimedia.org/T36958#1192252 (10He7d3r) [22:35:23] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: Typing after closing link inspector - the first letter gets transposed - https://phabricator.wikimedia.org/T91541#1192291 (10Jdforrester-WMF) p:5Low>3High [22:36:07] 10VisualEditor, 10VisualEditor-ContentEditable: Popups get disconnected from their targets when page zoom is changed - https://phabricator.wikimedia.org/T95366#1192296 (10Jdforrester-WMF) p:5Triage>3Low [22:42:25] RoanKattouw: I went for your option of adding separate metrics now [22:43:05] not sure if there is a good rate-weighted average function in grafana [22:43:56] the 99% improvement is still dramatic, but more on the order of ~7 -> 0.9s [22:46:21] mean is ~50% of the API load time, around 550ms [22:46:30] (03CR) 10Catrope: [C: 032] Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/202920 (https://phabricator.wikimedia.org/T95466) (owner: 10Catrope) [22:46:40] (03CR) 10Catrope: [C: 032] Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202921 (https://phabricator.wikimedia.org/T95466) (owner: 10Catrope) [22:46:45] (03CR) 10Physikerwelt: "@thedj: Do you think this patch can be merged now?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [22:47:44] The 99%ile improvement isn't all that good, because what really matters is max(API, RB) [22:48:09] It was ~7s before and ~5s for API 99% after [22:51:29] yeah, from a VE user perspective the critical load path is now clearly the PHP API metadata request [22:51:59] which fits with what we observed after switching this on for mw.org [22:52:10] 10VisualEditor: Provide a way to specify basic Manual of Style rules, and warn users - https://phabricator.wikimedia.org/T95500#1192383 (10gpaumier) 3NEW [22:53:11] (03PS1) 10Mooeypoo: Add reference to html document when creating surface [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202942 (https://phabricator.wikimedia.org/T95247) [22:53:34] (03Merged) 10jenkins-bot: Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/202920 (https://phabricator.wikimedia.org/T95466) (owner: 10Catrope) [22:53:37] (03Merged) 10jenkins-bot: Explicitly pass oldid to ApiParse after saving [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202921 (https://phabricator.wikimedia.org/T95466) (owner: 10Catrope) [22:55:05] (03PS1) 10Esanders: Add tests for TableAction#insert [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202943 [22:55:07] (03PS1) 10Esanders: Add tests for TableAction#mergeCells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202944 [22:55:10] (03PS1) 10Esanders: Add test for TableAction#delete (whole table) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 [22:59:11] (03PS4) 10Mooeypoo: Use the new MWPreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 [22:59:28] (03PS2) 10Catrope: Add reference to HTML document when creating surface [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202942 (https://phabricator.wikimedia.org/T95247) (owner: 10Mooeypoo) [22:59:29] 10VisualEditor: Provide a way to specify basic Manual of Style rules, and warn users - https://phabricator.wikimedia.org/T95500#1192428 (10Esanders) We've discussed adding something like this before. I think we can afford to be fairly aggressive with some of the auto-corrections, such as extra whitespace. We hav... [22:59:40] (03CR) 10Catrope: [C: 032] Add reference to HTML document when creating surface [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202942 (https://phabricator.wikimedia.org/T95247) (owner: 10Mooeypoo) [23:08:32] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): Pop-up context menu shows redlinks in Citoid-created citation - https://phabricator.wikimedia.org/T95247#1192444 (10Jdforrester-WMF) 5Open>3Resolved [23:09:55] 10Citoid, 10VisualEditor: Error in retrieving Data format for DOI and PMCID - https://phabricator.wikimedia.org/T95478#1192448 (10Mvolz) @Etonkovidova, this is because the metadata is getting scraped from three different webpages; in the PMID case, the date scraped directly from the webpage is okay, in the o... [23:11:07] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198729 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [23:12:14] RoanKattouw: Other parts are https://gerrit.wikimedia.org/r/#/c/198731/ https://gerrit.wikimedia.org/r/#/c/198733/ [23:12:32] Thanks, I was just wondering that [23:13:20] (03PS7) 10Jforrester: Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [23:13:26] (03PS3) 10Jforrester: Remove paragraph unwrapping, moved to parent class. [extensions/Math] - 10https://gerrit.wikimedia.org/r/198741 (owner: 10Esanders) [23:13:34] (03CR) 10Catrope: [C: 032] Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [23:13:43] (03PS4) 10Jforrester: Remove paragraph unwrapping, moved to parent class [extensions/Math] - 10https://gerrit.wikimedia.org/r/198741 (owner: 10Esanders) [23:14:14] RoanKattouw: What, me, helpful? ;-) [23:15:58] (03Merged) 10jenkins-bot: Add reference to HTML document when creating surface [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202942 (https://phabricator.wikimedia.org/T95247) (owner: 10Mooeypoo) [23:16:03] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198729 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [23:16:19] (03CR) 10Jforrester: "Needs rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) (owner: 10Esanders) [23:16:26] (03Merged) 10jenkins-bot: Update inspector now it inherits from NodeInspector [extensions/Math] - 10https://gerrit.wikimedia.org/r/198731 (https://phabricator.wikimedia.org/T93592) (owner: 10Esanders) [23:17:06] (03CR) 10jenkins-bot: [V: 04-1] Add test for TableAction#delete (whole table) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 (owner: 10Esanders) [23:26:04] (03CR) 10Catrope: [C: 04-1] "Needs serious conflict resolution. Conflicts with Rits's icon change." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) (owner: 10Esanders) [23:28:12] (03PS1) 10Mooeypoo: Fix documentation in the ve.ui.CiteFromIdReferenceWidget [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202956 [23:28:47] MatmaRex: poke [23:29:10] :( [23:29:30] (03CR) 10Catrope: [C: 032] Fix documentation in the ve.ui.CiteFromIdReferenceWidget [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202956 (owner: 10Mooeypoo) [23:30:11] :P [23:30:20] Negative24: sorry, i know. if it makes you feel any better, you're not the only person i really net to get back to [23:30:52] and i'm leaving right now. good night [23:31:01] need to* [23:31:07] Good night, MatmaRex. [23:31:11] see ya [23:32:50] (03CR) 10Catrope: [C: 032] Add tests for TableAction#insert [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202943 (owner: 10Esanders) [23:35:56] jaufrecht: James_F: [23:36:00] Sorry [23:36:05] ? [23:36:07] jaufrecht: https://www.mediawiki.org/wiki/VisualEditor/Usability [23:36:32] For some reason I had your nickname on my clipboard [23:38:58] (03Merged) 10jenkins-bot: Fix documentation in the ve.ui.CiteFromIdReferenceWidget [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202956 (owner: 10Mooeypoo) [23:39:00] (03Merged) 10jenkins-bot: Add tests for TableAction#insert [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202943 (owner: 10Esanders) [23:39:43] (03CR) 10Catrope: [C: 032] Add tests for TableAction#mergeCells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202944 (owner: 10Esanders) [23:40:02] RoanKattouw: RB load times have changed a lot since the switch for all wikipedias [23:40:19] Whoa WTF [23:40:29] RB load times have skyrocketed [23:40:41] yeah [23:41:02] Load rates have too [23:41:09] some increase was likely, as enwiki probably has more users with good internet connections [23:41:22] I guess that makes sense, enwiki doesn't have VE by default and a few other Wikipedias do [23:41:27] So req/s going up a lot makes sense [23:41:43] yeah, but it's not load that's driving this [23:41:50] No, it couldn't be [23:42:06] I mean unless RB is overloaded but that seems vanishingly unlikely [23:42:14] Since we're just changing how the same amount of load ends up there [23:42:17] it could be the extra connection setup from slow internet connections [23:42:25] https://phabricator.wikimedia.org/T95229 [23:42:26] Yeah I guess so [23:42:34] Oooh [23:42:57] Yeah if we had a same-domain path that internally redirected to rest.wm.o that would help with that [23:43:13] *nod* [23:43:29] in the example load there half the slow-start time was spent on connection setup [23:43:47] and that was from my fast cable connection in SF [23:43:59] 10Citoid, 10VisualEditor: Popup for newly added cite-by-url citation doesn't show full citation - https://phabricator.wikimedia.org/T95363#1192575 (10Mooeypoo) Okay this should be fixed now in master with the state of Citoid extension now. I can't reproduce this anymore on master and on beta labs. It should be... [23:45:12] (03Merged) 10jenkins-bot: Add tests for TableAction#mergeCells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202944 (owner: 10Esanders) [23:46:44] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: Saved edits are displayed only after additional page refresh - https://phabricator.wikimedia.org/T95466#1192593 (10Catrope) Fixes for this have been merged into master, backported to wmf24 an... [23:46:50] ugh, mean load time is now at 2.5s [23:46:57] James_F: What do I tag something with if its fix was backported to wmf1 & wmf24 ? [23:47:12] RoanKattouw: wmf2 and wmf1 and wmf24. [23:47:18] gwicke: Holy crap, it's much /worse/ than it was before now [23:47:23] We should probably roll back [23:47:47] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: Saved edits are displayed only after additional page refresh - https://phabricator.wikimedia.org/T95466#1192597 (10Catrope) 5Open>3Resolved [23:47:51] I wonder if DNS could also play a role, as that's so sensitive to caching [23:48:01] Right, and nobody knows about rest.wm.o yet [23:48:13] Outside of the English-speaking world at least [23:48:14] RoanKattouw: How much worse? [23:48:22] RoanKattouw: What are the numbers for enwiki? [23:48:29] enwiki was fine [23:48:36] It's other Wikipedias where it's bad [23:48:36] enwiki was 1/2 the old mean [23:48:41] https://grafana.wikimedia.org/#/dashboard/db/visualeditor-load-save [23:48:45] Eww. [23:48:46] but it's apples/oranges [23:49:42] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: Saved edits are displayed only after additional page refresh - https://phabricator.wikimedia.org/T95466#1192611 (10Etonkovidova) Checked - seems to be fine everywhere. [23:51:14] I would expect it to drop down a bit after browsers & DNS servers get things in cache, but it's clear that we should move this to the same domain soon [23:51:49] How long should we let this sit here until we decide to roll back? [23:51:58] One hour? 24 hours? [23:52:03] *decide whether to [23:52:13] RoanKattouw: Wait another 15 minutes. [23:52:18] RoanKattouw: Then revert. [23:52:45] OK [23:53:03] In other news, Ed's new test increased our test coverage by about 1.5 percentage points (depending on which metric you use) [23:53:13] Nice work. [23:53:20] Did he tag it against the tasks? [23:53:24] Which ones? [23:53:28] (I don't think so) [23:53:41] No he didn't [23:53:49] But there's still time to tag the delete one since that one fails [23:54:04] https://phabricator.wikimedia.org/T95415 [23:54:16] I mean, karma barfed on it, it didn't really fail [23:54:32] (03PS2) 10Catrope: Add test for TableAction#delete (whole table) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 (https://phabricator.wikimedia.org/T95415) (owner: 10Esanders) [23:56:39] RoanKattouw: worth checking the overall activation time too [23:58:51] added a panel at the bottom [23:59:12] Thanks [23:59:28] gwicke: Did you save? [23:59:30] mean also increased there [23:59:44] yes [23:59:55] I refreshed but I don't see it