[00:00:09] 10Citoid, 10VisualEditor, 5WMF-deploy-2015-04-01_(1.25wmf24): Popup for newly added cite-by-url citation doesn't show full citation - https://phabricator.wikimedia.org/T95363#1192638 (10Ryasmeen) 5Open>3Resolved [00:00:15] I sometimes have to focus the url & hit enter [00:00:45] I closed the tab and opened the URL in a new tab and it's still not there [00:01:01] now I see it [00:01:07] 10Citoid, 10VisualEditor, 5WMF-deploy-2015-04-01_(1.25wmf24): Popup for newly added cite-by-url citation doesn't show full citation - https://phabricator.wikimedia.org/T95363#1187872 (10Ryasmeen) Checked the fix in en.wiki [00:01:21] at first I didn't see it in the incognito window either [00:01:49] mean activation definitely increased [00:01:56] I don't see it even in incognito [00:02:09] weird [00:02:54] The combined time doesn't look very combined. [00:03:00] Given it's at zero. [00:03:06] Are the labels wrong? [00:03:43] it's not really combined, yeah [00:04:17] it looks like our version of graphite is old and doesn't have http://graphite.readthedocs.org/en/latest/functions.html#graphite.render.functions.weightedAverage [00:06:40] changed it to PHP API, legacy [00:07:27] do you see it now? [00:07:51] mean activation didn't actually change much [00:08:23] gwicke: Yeah. [00:08:46] last six hour avg was 1.58s, currently it's 1.87 [00:08:59] dropping slightly [00:09:41] that's less than the supposed DOM load time [00:10:00] does that make sense? [00:10:11] is activation no longer including the HTML load phase? [00:13:12] Yeah I was digging around the code looking for a good activation measurement [00:13:15] We don't really have one right now [00:13:25] It was always broken in certain ways [00:13:52] Now it does not include the RL load phase but does include the HTML load but only partially [00:14:06] As in, RL and HTML are loaded in parallel and the activation timer starts once the RL load phase finishes [00:14:17] Which might be instantly from cache or fast from network or slow from network, who knows [00:14:35] But for perf reasons we now no longer wait sending the HTML request before the RL request finishes [00:14:52] Hmm load times are coming down [00:14:56] yeah, makes sense [00:15:04] but something doesn't make sense [00:15:18] We have a timing point for this that measures "user clicks" to "user can use editor" [00:15:26] if HTML loads are much slower than RL, then we'd expect activation to show at least the delta [00:15:37] But that's in the perf timing namespace, not in the eventlogging namespace [00:16:16] that would be good to track down [00:17:09] do you remember the schema name? [00:17:35] What I mean is, the good timing point is in a ve.track() namespace that's only used for perf stuff, it never makes it into EventLogging [00:17:41] I'm going to put in one that does go there [00:18:54] k [00:22:15] one thing I noticed last week is that the times reported by VE in the restbaseLoad and the Chrome network inspector differed quite a bit, with the latter being close to 2x in one sample; I figured that it's probably HTML parsing and maybe event loop delay as other content is coming in as well [00:23:25] but the relative change from enwiki to all wikipedias is definitely real [00:27:36] You're right that restbaseLoad includes parsing [00:27:42] It's the best we can do [00:27:44] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 5Patch-For-Review: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox - https://phabricator.wikimedia.org/T78733#1192689 (10bd808) a:5bd808>3None [00:27:54] $.ajax( ... ).then( function () { log event } ); [00:28:24] gwicke: Would you prefer I add a new metric or fix the existing activation one? [00:28:43] The existing one has always been kind of bogus but is especially bogus nowadays [00:29:15] is there another metric that was accurate all along? [00:29:29] No [00:29:54] Well, I mean there are other metrics that accurately measured what they were supposed to measure, but there was no metric that accurately measured activatoin [00:30:32] if you think that you can get value out of tracking the development of the current activation metric then I'd say keep it as it is & add a new one [00:30:44] you'd lose that if you redefine the metric [00:30:57] but if it's useless anyway then it doesn't really matter [00:31:18] OK, so. [00:31:25] What's the decision? Are we reverting [00:31:25] ? [00:31:47] http://grafana.wikimedia.org/#/dashboard/db/visualeditor-load-save is looking healthier but not great. [00:32:01] do we have any data on click-to-blinking-cursor? [00:32:32] if we have, then it would be good to have a look at that as a sanity check [00:33:12] We don't, that's what I'm adding [00:34:03] James_F: It seems to be flattening out [00:34:05] But at a higher level [00:34:10] So yes we need to revert [00:34:18] OK, do it. [00:34:22] gwicke: I think the current metric is useless [00:34:27] OK reverting [00:34:27] (ccing Greg.) [00:35:45] k, makes sense [00:36:33] RoanKattouw: Leaving on enwiki? [00:38:21] the earlier data indicated that it's faster for enwiki, probably because most users are on relatively low-latency internet connections [00:38:30] Odd. [00:39:04] 10OOjs-UI: Implement getFormValues() - https://phabricator.wikimedia.org/T95508#1192718 (10Halfak) 3NEW [00:40:33] RoanKattouw: is HTML DOM parsing included in the domLoad and apiLoad metrics as well? [00:41:05] Yup [00:41:09] Wait, no [00:41:12] Uhm, checking [00:41:32] apiLoad includes JSON parsing [00:41:51] restbaseLoad does not include parsing [00:42:09] (contrary to what I said earlier) [00:42:10] and domLoad includes JSON parsing but not HTML parsing [00:42:37] This is all a bit strange but it was easier to implement dual support for RB / no RB this way [00:43:04] IIRC XHR requests parse HTML responses implicitly [00:43:19] depending on the parse type or something like that [00:43:20] They do, unless you tell them not do [00:43:22] And that's what we do [00:43:28] Because in IE we need to first parse as XML then as HTML [00:43:56] kk [00:45:01] that seems to only leave the network connections as an explanation for the difference between enwiki and all wikis [00:45:07] Yeah [00:45:18] I'm trying to revert but my mediawiki-config commit is stuck in the Jenkins queue [00:45:23] Merged now. [00:45:24] Oh there we go it just finally landed [00:46:09] And done [00:46:15] thanks! [00:46:58] most of those users would be on https, and creating a new HTTPS connection with high latency connections is very expensive [00:47:05] Right [00:47:16] added to that the rare DNS entry with likely resolver cache miss [00:47:48] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up a generic API base path to be used by action & REST APIs - https://phabricator.wikimedia.org/T95229#1192764 (10GWicke) p:5Normal>3High [01:02:56] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up a generic API base path to be used by action & REST APIs - https://phabricator.wikimedia.org/T95229#1192818 (10GWicke) I think we just observed the fairly dramatic impact of using a separate domain on cold load latencies: {F110247} At ~14:10 P... [01:03:53] RoanKattouw: Don't break the wiki more before I wake up. :-) [01:04:38] James_F|Away: good night! [01:46:26] gwicke: grr it's still not quite returned to normal [01:48:37] the RB load rates have dropped a bit [01:48:56] gwicke: I'm gonna go home and eat, but if this persists I'm gonna try to also revert the enwiki change :S [01:49:37] k [02:20:53] (03CR) 10Physikerwelt: [C: 032] "Works. Tested with IE 11." [extensions/Math] - 10https://gerrit.wikimedia.org/r/198741 (owner: 10Esanders) [02:23:05] (03Merged) 10jenkins-bot: Remove paragraph unwrapping, moved to parent class [extensions/Math] - 10https://gerrit.wikimedia.org/r/198741 (owner: 10Esanders) [02:37:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Kill $wmgUseVisualEditorNamespace - https://phabricator.wikimedia.org/T92797#1192955 (10Liuxinyu970226) Wait, it means we can also edit Module pages via VE? [03:03:23] 10VisualEditor, 10VisualEditor-ContentEditable: Shift-enter should create
line break - https://phabricator.wikimedia.org/T95518#1192974 (10Whatamidoing-WMF) 3NEW [03:21:08] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1192995 (10GWicke) [03:22:01] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1183654 (10GWicke) [03:54:39] (03PS1) 10Catrope: Make activation timings sent to EventLogging not lie [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202984 [03:57:33] (03CR) 10jenkins-bot: [V: 04-1] Make activation timings sent to EventLogging not lie [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202984 (owner: 10Catrope) [04:00:26] 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1193024 (10GWicke) Request latency on enwiki looked great, but was really bad on other wikis. We rolled back the all-wikipedia change for this reason. See https:... [04:49:04] 10VisualEditor: design fields in template editor - https://phabricator.wikimedia.org/T95522#1193051 (10Sunpriat) 3NEW [05:14:05] (03CR) 10Catrope: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202984 (owner: 10Catrope) [07:59:55] 10MediaWiki-Page-editing, 7Epic, 5Patch-For-Review: Edit conflict detection suffers a race condition - https://phabricator.wikimedia.org/T58849#1193314 (10awight) [08:09:03] 10MediaWiki-Page-editing: Use parentRevId field for section change merging instead of timestamps - https://phabricator.wikimedia.org/T88734#1193351 (10awight) Possibly should be merged into T58849 [08:51:46] 10VisualEditor: ve.ui.Toolbar should have a configurable offset for fixed headers - https://phabricator.wikimedia.org/T95528#1193422 (10Florian) 3NEW a:3Florian [08:57:44] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 3Multimedia-Sprint-2015-03-25, 5Patch-For-Review: Use source urls in mw.loader.store - https://phabricator.wikimedia.org/T90524#1193450 (10Tgr) [09:13:42] 10VisualEditor, 6Multimedia: Make Template:Gallery redundant - https://phabricator.wikimedia.org/T95531#1193478 (10Esanders) 3NEW [09:15:50] (03PS1) 10Florianschmidtwelzow: Allow to fix the toolbar not to the top of the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203010 (https://phabricator.wikimedia.org/T95528) [09:21:15] (03PS1) 10Florianschmidtwelzow: Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) [09:24:08] (03CR) 10jenkins-bot: [V: 04-1] Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [09:41:10] (03PS1) 10Esanders: Follow-up I23d37e3d: Remove unused converter method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203014 [10:05:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Kill $wmgUseVisualEditorNamespace - https://phabricator.wikimedia.org/T92797#1193588 (10Krenair) IIRC those would have a non-wikitext content model which VE will simply refuse to do anything on due to https://gerrit.wikimedia.org/r/#/c/63341/ [10:08:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Kill $wmgUseVisualEditorNamespace - https://phabricator.wikimedia.org/T92797#1193598 (10Krenair) I think there's some caveats to the above, but that's not what this task is about. We were discussing the old VisualEditor: namespace which you... [10:13:27] 10Citoid, 6Services, 5Patch-For-Review: Configure OCG, Parsoid and Citoid to report counter metrics - https://phabricator.wikimedia.org/T94053#1193610 (10mobrovac) [10:22:18] (03PS3) 10Esanders: Add test for TableAction#delete (whole table) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 (https://phabricator.wikimedia.org/T95415) [10:22:20] (03PS1) 10Esanders: Test TableAction#merge when full rows/cols selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203016 (https://phabricator.wikimedia.org/T95415) [10:22:52] (03PS2) 10Esanders: Test TableAction#merge when full rows/cols selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203016 (https://phabricator.wikimedia.org/T95415) [10:22:54] (03PS4) 10Esanders: Add test for TableAction#delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 (https://phabricator.wikimedia.org/T95415) [10:26:58] (03PS3) 10Esanders: Test TableAction#merge when full rows/cols selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203016 (https://phabricator.wikimedia.org/T95415) [10:27:00] (03PS5) 10Esanders: Add test for TableAction#delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 (https://phabricator.wikimedia.org/T95415) [10:38:37] 10Citoid, 6Services, 5Patch-For-Review: Configure OCG, Parsoid and Citoid to report counter metrics - https://phabricator.wikimedia.org/T94053#1193647 (10mobrovac) [10:41:37] (03PS6) 10Esanders: Add test for TableAction#delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 (https://phabricator.wikimedia.org/T95415) [10:41:39] (03PS1) 10Esanders: Add tests for TableAction#changeStyle and TableAction#caption [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203022 (https://phabricator.wikimedia.org/T95415) [10:48:07] 10VisualEditor, 6Multimedia: Make Template:Gallery redundant - https://phabricator.wikimedia.org/T95531#1193674 (10Aklapper) [10:51:28] (03PS2) 10Florianschmidtwelzow: Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) [10:57:29] (03CR) 10Alex Monk: Allow to fix the toolbar not to the top of the window (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203010 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [10:59:12] (03CR) 10Alex Monk: Allow skin developers to set an offset for toolbar floating (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [11:16:11] 10VisualEditor, 6Multimedia: Make Template:Gallery redundant - https://phabricator.wikimedia.org/T95531#1193716 (10Jdforrester-WMF) Can you lay out what advantages there are? [11:16:33] 10VisualEditor, 6Editing, 6Multimedia: Make enwiki's Template:Gallery redundant by implementing all its features in wikitext - https://phabricator.wikimedia.org/T95531#1193717 (10Jdforrester-WMF) [11:26:06] 10VisualEditor, 6Editing, 6Multimedia: Make enwiki's Template:Gallery redundant by implementing all its features in wikitext - https://phabricator.wikimedia.org/T95531#1193723 (10Jdforrester-WMF) p:5Triage>3Normal [11:30:43] James_F, I realised today that my fix for https://gerrit.wikimedia.org/r/#/c/182432/ breaks other things :( [11:30:59] Krenair: Oh dear. [11:31:04] Krenair: Fixably? [11:31:14] as in, my replacement commit [11:31:17] I'm not sure. [11:31:38] I found the issue I was looking into was due to MWLinkTargetInputWidget only updating the href when you selected an item in the menu [11:32:22] as the menu re-appears [11:34:03] Hmm. [11:34:10] the problem is that the menu can show you http://wikimedia.org as both an external link and as an actual page [11:34:15] Yeah. [11:34:27] and it knows which one you selected and can use it to determine whether to insert an internal or external link annotation [11:34:44] This will be "fixed" with one of the changes the Sucheta is working on with Design (splitting the entry modes for external links), but… [11:34:58] if we want to do it based on typing as well.... well, yeah [11:35:49] Meh. [11:40:40] James_F, remind me which ticket Sucheta's design change is? [11:44:12] (03CR) 10Jforrester: [C: 032] "ve.dm.TableMatrix.js coverage:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203016 (https://phabricator.wikimedia.org/T95415) (owner: 10Esanders) [11:45:11] (03CR) 10Florianschmidtwelzow: Allow skin developers to set an offset for toolbar floating (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [11:47:06] (03Merged) 10jenkins-bot: Test TableAction#merge when full rows/cols selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203016 (https://phabricator.wikimedia.org/T95415) (owner: 10Esanders) [11:49:24] (03PS2) 10Florianschmidtwelzow: Allow to fix the toolbar not to the top of the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203010 (https://phabricator.wikimedia.org/T95528) [11:50:47] Krenair: There's about 10. [11:50:50] * James_F hunts for them. [11:51:07] :/ [11:51:24] * Krenair would really love to see that change done [11:52:15] Krenair: https://phabricator.wikimedia.org/T76398 and others. [11:52:18] Krenair: Me too. [11:53:03] Is Sucheta actively working on it? [11:53:44] Yes. [11:53:46] Well. [11:53:51] Not sure that one particularly. [11:54:04] I think she's working on the Mobile-like image-and-Wikidata-description search system. [11:54:18] Which is finnicky and horrible. [11:55:55] (03CR) 10Alex Monk: "And we can't really set href based only on typing the value, because then we'd need to guess whether they meant external or internal - blo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182432 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk) [11:56:27] (03CR) 10Jforrester: [C: 031] "src/ui/actions/ coverage:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 (https://phabricator.wikimedia.org/T95415) (owner: 10Esanders) [11:56:55] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: "Open" button in the Link tool can sometimes lead to a broken or incorrect target - https://phabricator.wikimedia.org/T85619#1193765 (10Krenair) Actually it sounds like the issue I've been trying to deal with is... [11:58:11] enwiki alone has at least 50 pages that would get confused links due to this issue :( [11:58:24] Yay. :-( [11:58:31] (counting page titles which match our external link regex) [12:00:58] (03CR) 10Alex Monk: Allow skin developers to set an offset for toolbar floating (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [12:03:52] (03CR) 10Jforrester: [C: 032] "Overall statement coverage (too diffuse to narrow down):" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203022 (https://phabricator.wikimedia.org/T95415) (owner: 10Esanders) [12:13:07] 10VisualEditor, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers: VE save/load performance tracking for desktop and mobile are comingled - https://phabricator.wikimedia.org/T95432#1193779 (10Krenair) Caused by patch for T93156 [12:45:08] (03CR) 10Florianschmidtwelzow: [C: 04-1] Allow skin developers to set an offset for toolbar floating (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [12:49:05] 10VisualEditor, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers: VE save/load performance tracking for desktop and mobile are comingled - https://phabricator.wikimedia.org/T95432#1193864 (10Krenair) >>! In T95432#1191022, @Catrope wrote: > Now that Alex has TargetLoader-ified MobileFronte... [12:55:39] (03PS1) 10Jforrester: Replace abstract functions that just throw with null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 [12:57:33] (03PS1) 10Paladox: Add skin.json [skins/Vector] - 10https://gerrit.wikimedia.org/r/203047 (https://phabricator.wikimedia.org/T87875) [12:57:42] (03PS2) 10Paladox: Add skin.json [skins/Vector] - 10https://gerrit.wikimedia.org/r/203047 (https://phabricator.wikimedia.org/T87875) [12:58:05] (03PS1) 10Alex Monk: Set targetName for apiLoad and restbaseLoad metrics to the correct values again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203048 (https://phabricator.wikimedia.org/T95432) [13:05:34] 10VisualEditor, 10MediaWiki-ContentHandler, 10MediaWiki-Internationalization: Default content model should apply to non-customised messages in the MediaWiki: namespace - https://phabricator.wikimedia.org/T92899#1193902 (10Krenair) VE-MW no longer uses that message (has its own special character system), but... [13:15:41] 10VisualEditor, 6Editing, 6Multimedia: Make enwiki's Template:Gallery redundant by implementing all its features in wikitext - https://phabricator.wikimedia.org/T95531#1193949 (10TTO) I should point out that it's not a wrapper, it's a completely different implementation using tables. I should also point out... [13:16:34] (03PS1) 10Esanders: Test splice polyfill [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203054 [13:17:41] James_F, tell Krinkle|detached the batchSplice polyfill doesn't pass tests ^^ [13:18:54] (03CR) 10jenkins-bot: [V: 04-1] Test splice polyfill [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203054 (owner: 10Esanders) [13:31:56] 10Citoid, 6Services: Configure OCG, Parsoid and Citoid to report counter metrics - https://phabricator.wikimedia.org/T94053#1193974 (10mobrovac) [13:32:22] 10Citoid, 6Services: Configure OCG, Parsoid and Citoid to report counter metrics - https://phabricator.wikimedia.org/T94053#1193977 (10mobrovac) 5Open>3Resolved a:3mobrovac All needed changes merged, resolving. [13:46:51] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Citation dialog not opening in mobile VE for en.wiki - https://phabricator.wikimedia.org/T86077#1194034 (10Krenair) 5Open>3Resolved [13:46:59] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Citation dialog not opening in mobile VE for en.wiki - https://phabricator.wikimedia.org/T86077#961137 (10Krenair) Probably fixed ages ago. [13:47:07] edsanders: Done. [13:49:14] James_F, so I don't see anything particularly wrong with the citation dialog itself on mobile [13:49:35] Krenair: That sounds encouraging. [13:49:41] there is something very weird about windows in general on mobile, however [13:49:46] (I 'accepted' all those tickets on the basis that they needed work.) [13:49:50] Oh, that's not good. [13:49:56] all sorts of weird rendering issues [13:50:24] Do they happen in OOjs UI demo on a mobile device? [13:50:45] (03PS1) 10Mobrovac: Minor: Add '-r' to git rm node_modules/ [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/203064 [13:50:45] Or are they artefacts of MobileFrontend and / or the VE-MW mobile integration? [13:50:48] have been testing on chrome in ubuntu, rather than on an actual mobile device [13:51:04] Yeah. Clearly I should ship you some devices for testing. [13:51:14] do we have a URL where I can test the oojs ui demo from my android device? [13:51:17] (03CR) 10Mobrovac: [C: 032 V: 032] Minor: Add '-r' to git rm node_modules/ [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/203064 (owner: 10Mobrovac) [13:51:44] Krenair: https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#widgets-mediawiki-vector-ltr [13:51:51] oh, I seem to recall we have some arbitrary screen size limit that would disqualify my own device anyway? [13:51:58] In MF, yes. [13:52:04] OOjs UI doesn't care. ;-) [13:52:25] 10VisualEditor, 6Editing: Obviate the need for wikis' wrapper and functionality-replacement templates - https://phabricator.wikimedia.org/T95543#1194043 (10Jdforrester-WMF) 3NEW [13:53:45] medium size and larger simple dialogs all display the same :/ [13:53:52] 10Cite: Cite: Support multi-column and alternative list-style for tag (like enwiki {{reflist}}) - https://phabricator.wikimedia.org/T53260#1194052 (10Jdforrester-WMF) [13:53:55] 10VisualEditor, 6Editing, 6Multimedia: Make enwiki's Template:Gallery redundant by implementing all its features in wikitext - https://phabricator.wikimedia.org/T95531#1194051 (10Jdforrester-WMF) [13:53:57] 10Cite, 10Wikimedia-Hackathon-2015: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#1194053 (10Jdforrester-WMF) [13:53:59] 10VisualEditor, 6Editing: Obviate the need for wikis' wrapper and functionality-replacement templates - https://phabricator.wikimedia.org/T95543#1194050 (10Jdforrester-WMF) [13:54:15] everything looks OK though [13:54:47] actually there is something weird about the citation dialog [13:55:16] the input box... the highlighting around the edge of it only half appears [13:55:33] Hmm. [13:55:49] Is that the same in Chrome desktop? [13:56:30] sorry, this is back on the chrome desktop [13:57:19] OK. [13:57:54] no option to switch to VE on my mobile device [13:57:58] edsanders: Can I bully you into some quick OOjs UI code review? https://gerrit.wikimedia.org/r/#/c/202427/ https://gerrit.wikimedia.org/r/#/c/202599/ https://gerrit.wikimedia.org/r/#/c/201617/ [13:58:02] Krenair: Yeah. :-( [13:58:25] I could point it at my laptop and remove the limit [13:58:25] Krenair: Setting up MF locally is simple if you have Vagrant, but hard otherwise, I've heard. [13:58:31] but I have a feeling it wouldn't work very well [13:58:36] oh, I have MF set up locally [13:58:42] What better way to test? ;-) [13:58:52] I don't use vagrant [14:01:32] (03CR) 10Esanders: [C: 04-1] "We shouldn't use 'left'/'right' if the side changes in RTL, but 'before'/'after'. Left should always mean left, e.g. with image alignment." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [14:10:12] James_F, do you know where MF puts this rule? [14:10:42] 10MediaWiki-Page-editing, 7Epic, 5Patch-For-Review: Edit conflict detection suffers a race condition - https://phabricator.wikimedia.org/T58849#1194130 (10He7d3r) [14:12:49] found it [14:12:59] javascripts/modules/editor/EditorOverlay.js [14:13:04] isVisualEditorEnabled [14:13:11] return browser.isWideScreen() && [14:13:55] James_F: https://phabricator.wikimedia.org/T73394 [14:14:36] James_F, actually it doesn't work badly... [14:14:46] for some reason the citation dropdown is disabled :S [14:14:53] Krenair: Hmm. [14:15:08] uh oh [14:15:13] pressed link, everything disappeared [14:22:58] James_F, I think I've run into a browser bug... [14:23:15] I'm shocked. :-) [14:23:28] everything shows as hidden, then I disabled a random CSS property [14:23:30] and re-enabled it [14:23:34] so it's still the same [14:23:41] but it shows properly now [14:23:46] Hmmmmmm. [14:25:32] it was the color property that .oo-ui-window inherits [14:26:39] some other properties cause this as well [14:30:00] 10VisualEditor, 6Editing: Obviate the need for wikis' wrapper and functionality-replacement templates - https://phabricator.wikimedia.org/T95543#1194197 (10He7d3r) What are "wiki-specific" templates? Are they the things that will cease to exist once we have global templates ({T6547})? [14:31:15] 10VisualEditor, 6Editing: Obviate the need for wikis' wrapper and functionality-replacement templates - https://phabricator.wikimedia.org/T95543#1194201 (10Jdforrester-WMF) No. We're writing software for all MediaWiki installations, including those in air-gapped bunkers without access to MediaWiki.org's shared... [14:32:55] (03PS2) 10Jforrester: Follow-up Iaf15561409b: Correctly position popups in RTL in Apex too [oojs/ui] - 10https://gerrit.wikimedia.org/r/202599 (owner: 10Mooeypoo) [14:33:03] (03CR) 10Jforrester: [C: 032] Follow-up Iaf15561409b: Correctly position popups in RTL in Apex too [oojs/ui] - 10https://gerrit.wikimedia.org/r/202599 (owner: 10Mooeypoo) [14:36:33] 10Cite, 10Wikimedia-Hackathon-2015: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#1194240 (10MarkAHershberger) ----- Original Message ----- > Jdforrester-WMF added a blocked task: T95543: Obviate the need for wikis' > wrapper and functionali... [14:37:38] .MatmaRex: i'm trying to modify a label using setlabel such as ve.ui.deleterowtool.setLabel(oo.ui.deferMsg(" ......")); is it correct implementation? [14:42:34] (03Merged) 10jenkins-bot: Follow-up Iaf15561409b: Correctly position popups in RTL in Apex too [oojs/ui] - 10https://gerrit.wikimedia.org/r/202599 (owner: 10Mooeypoo) [14:44:49] edsanders|away: https://gerrit.wikimedia.org/r/#/c/198740 [14:46:58] edsanders: Ping [14:47:06] James_F, https://phabricator.wikimedia.org/T95413 [14:47:40] 10OOjs-UI, 10VisualEditor: Don't define abstract methods but instead leave them defined as null - https://phabricator.wikimedia.org/T95413#1194291 (10Jdforrester-WMF) [14:48:03] 10OOjs-UI, 10VisualEditor: Don't define abstract methods but instead leave them defined as null - https://phabricator.wikimedia.org/T95413#1189187 (10Jdforrester-WMF) a:3Jdforrester-WMF [14:48:06] edsanders: https://phabricator.wikimedia.org/T54482 [14:48:36] 10VisualEditor, 7Technical-Debt: Don't define abstract methods but instead leave them defined as null - https://phabricator.wikimedia.org/T54482#1194306 (10Jdforrester-WMF) [14:48:43] 10OOjs-UI, 10VisualEditor: Don't define abstract methods but instead leave them defined as null - https://phabricator.wikimedia.org/T95413#1189187 (10Jdforrester-WMF) [14:48:45] 10VisualEditor, 7Technical-Debt: Don't define abstract methods but instead leave them defined as null - https://phabricator.wikimedia.org/T54482#547456 (10Jdforrester-WMF) [14:48:52] 10VisualEditor, 7Technical-Debt: Don't define abstract methods but instead leave them defined as null - https://phabricator.wikimedia.org/T54482#1194313 (10Esanders) [14:49:26] 10OOjs-UI, 10VisualEditor: Don't define abstract methods but instead leave them defined as null - https://phabricator.wikimedia.org/T95413#1194318 (10Esanders) [14:49:28] 10VisualEditor, 7Technical-Debt: Don't define abstract methods but instead leave them defined as null - https://phabricator.wikimedia.org/T54482#547456 (10Esanders) [14:50:00] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 3Multimedia-Sprint-2015-03-25, 5Patch-For-Review: Use source urls in mw.loader.store - https://phabricator.wikimedia.org/T90524#1194330 (10Tgr) From UploadWizard error logging data (T95527): ``` mysql:research@analytics-store.eqiad.w... [14:50:06] (03PS2) 10Krinkle: Test splice polyfill [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203054 (owner: 10Esanders) [14:51:59] (03PS2) 10Jforrester: Replace abstract functions that just throw with null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) [14:56:40] (03CR) 10jenkins-bot: [V: 04-1] Test splice polyfill [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203054 (owner: 10Esanders) [15:17:59] (03PS6) 10Esanders: Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) [15:28:41] (03CR) 10Alex Monk: Allow skin developers to set an offset for toolbar floating (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [15:32:28] (03PS7) 10Esanders: Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) [15:45:25] hi, can someone tell me what's the difference between "/mediawiki/vendor/oojs/oojs-ui/src/themes/apex/tools.less" and "/mediawiki/vendor/oojs/oojs-ui/src/themes/mediawiki/tools.less" ? [15:50:24] (03PS3) 10Krinkle: ve.utils: Fix bug in batchSplice polyfill [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203054 (owner: 10Esanders) [15:51:09] ankita-ks: They're different themes for OOjs UI. In MediaWiki we use the MediaWiki theme. [15:51:54] okay. and where is /apex used? [15:51:59] James_F ^ [15:52:07] Other users of OOjs UI. [15:52:15] Like VisualEditor not inside MediaWiki. [15:53:23] ah..okay. [15:53:48] Also, if I have to add a new button to the VisualEditor toolbar, where should I be looking? [15:54:03] ^ James_F [15:54:26] Is this for VisualEditor or VisualEditor-MediaWiki? [15:54:50] VisualEditor-MediaWiki [15:55:42] edsanders: most of the test failures were false negatives as 'actual' and 'expected' arrays were surviving the loop. [15:56:34] ankita-ks: In that case, ve.init.mw.Target.js [15:56:48] ankita-ks: Look for toolbarGroups [15:57:37] okay, looking at it. [15:57:41] thanks! :) [15:57:45] (03PS3) 10Divec: WIP: Cursor holders for native cursoring to ce=false nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 [15:57:49] (03CR) 10jenkins-bot: [V: 04-1] WIP: Cursor holders for native cursoring to ce=false nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [15:58:45] (03PS4) 10Divec: WIP: Cursor holders for native cursoring to ce=false nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 [15:58:48] (03CR) 10jenkins-bot: [V: 04-1] WIP: Cursor holders for native cursoring to ce=false nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [15:59:17] (03PS4) 10Esanders: ve.utils: Fix bug in batchSplice polyfill [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203054 [16:02:14] (03CR) 10Krinkle: [C: 032] ve.utils: Fix bug in batchSplice polyfill [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203054 (owner: 10Esanders) [16:07:10] (03PS5) 10Divec: WIP: Cursor holders for native cursoring to ce=false nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 [16:07:51] (03Merged) 10jenkins-bot: ve.utils: Fix bug in batchSplice polyfill [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203054 (owner: 10Esanders) [16:10:14] (03CR) 10Divec: "Patchset 5: rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [16:11:43] (03CR) 10jenkins-bot: [V: 04-1] WIP: Cursor holders for native cursoring to ce=false nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [16:12:32] (03CR) 10Esanders: [C: 032] Replace abstract functions that just throw with null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [16:21:41] edsanders: https://integration.wikimedia.org/ci/job/visualeditor-publish/lastBuild/console [16:22:30] (03PS6) 10Divec: WIP: Cursor holders for native cursoring to ce=false nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 [16:24:12] (03CR) 10Esanders: [C: 032] Improve layout of Special:MathStatus [extensions/Math] - 10https://gerrit.wikimedia.org/r/200604 (https://phabricator.wikimedia.org/T94434) (owner: 10Physikerwelt) [16:25:52] (03Merged) 10jenkins-bot: Improve layout of Special:MathStatus [extensions/Math] - 10https://gerrit.wikimedia.org/r/200604 (https://phabricator.wikimedia.org/T94434) (owner: 10Physikerwelt) [16:33:51] (03CR) 10Esanders: [C: 04-1] WIP: Cursor holders for native cursoring to ce=false nodes (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [16:34:35] (03CR) 10Divec: "Esanders, is this behaviour reasonable for tables? And nested tables?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [16:38:42] (03CR) 10Esanders: "Table cells should behave the same, but for the extra logic that prevents you leaving them:" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [16:41:10] 10VisualEditor: Can't cursor left/right while editing a nested table cell without jumping back to a table selection - https://phabricator.wikimedia.org/T95574#1194852 (10Esanders) 3NEW [16:43:24] I think she's working on the Mobile-like image-and-Wikidata-description search system. [16:43:31] Was that https://phabricator.wikimedia.org/T88316 ? [16:43:55] Yes, and the search side of it too. [16:44:06] 10VisualEditor: Can't cursor left/right while editing a nested table cell without jumping back to a table selection - https://phabricator.wikimedia.org/T95574#1194870 (10Esanders) [16:50:21] (03PS1) 10Esanders: Follow-up Ifa18938: Fix cursoring in tested table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203108 (https://phabricator.wikimedia.org/T95574) [17:02:06] (03PS7) 10Divec: WIP: Cursor holders for native cursoring to ce=false nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 [17:03:25] (03CR) 10Divec: WIP: Cursor holders for native cursoring to ce=false nodes (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [17:09:27] (03CR) 10Divec: Follow-up Ifa18938: Fix cursoring in tested table cells (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203108 (https://phabricator.wikimedia.org/T95574) (owner: 10Esanders) [17:12:41] RoanKattouw, basically what I found was that when I do some things involving windows in mobile VE, the screen goes blank [17:13:07] If I fiddle with certain CSS properties (disable and re-enable, etc.) it shows up again [17:13:22] specifically on .oo-ui-window [17:13:30] I'm tempted to blame MF but that may be unfair. [17:13:57] I tested this with chrome on both my laptop and my phone (removed some MF check for screen size) [17:14:14] maybe... we do have MobileViewTarget that's in VE-MW rather than MF [17:14:36] Maybe we could blame browsers! I don't know. [17:15:14] (03CR) 10Mooeypoo: "Yeah we actually talked about having 4 options -- left/right that stick to what they are regardless and before/after for flipping. The pro" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [17:17:23] Krenair: Chrome is also really bad when it comes to rendering bugs [17:17:58] It sounds like you've found a Chrome bug that's specific to CSS MF / MVT uses rather than a bug specific to mobile Chrome [17:18:20] (03CR) 10Mooeypoo: "Clarification: When I said that we usually flip everything, what I mean is that in terms of user experience, we expect RTL to be magically" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [17:18:22] 10Citoid, 10Mathoid-General-or-Unknown, 10MediaWiki-extensions-Graph, 10MediaWiki-extensions-WikiHiero, and 4 others: Services need to share the same domain name - https://phabricator.wikimedia.org/T95402#1195021 (10csteipp) If the services are accessible on a non-authenticated domain like rest.wikimedia.o... [17:18:45] RoanKattouw, right, it's definitely not specific to mobile chrome [17:18:51] as I said I tested this on my laptop first [17:20:07] (03CR) 10Catrope: [C: 032] Set targetName for apiLoad and restbaseLoad metrics to the correct values again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203048 (https://phabricator.wikimedia.org/T95432) (owner: 10Alex Monk) [17:20:13] Krinkle, what can I bribe you with to review this patch? https://gerrit.wikimedia.org/r/#/c/194386/ [17:20:19] RoanKattouw: ^^^ backport? [17:20:22] Krinkle, I have cheese. [17:20:37] James_F: Yes [17:21:05] 10Citoid, 10Mathoid-General-or-Unknown, 10MediaWiki-extensions-Graph, 10MediaWiki-extensions-WikiHiero, and 4 others: Services need to share the same domain name - https://phabricator.wikimedia.org/T95402#1195032 (10GWicke) We will need to support authenticated requests for private wikis and end points tha... [17:21:27] (03PS1) 10Jforrester: Set targetName for apiLoad and restbaseLoad metrics to the correct values again [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203113 (https://phabricator.wikimedia.org/T95432) [17:21:54] mooeypoo: I already reviewed that on Phabricator, and then Trevor e-mailed me about and I responded. [17:21:55] (03CR) 10Catrope: [C: 04-1] Replace abstract functions that just throw with null (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [17:22:14] There hasn't been a reply on Phabricator or that email.. [17:22:36] mooeypoo: hello:), sorry the net connection was slow yesterday, bug solved :) , i wanted to talk to you about the project i was going through the comments on the graph project itself and some on the ferdbold proposal, as you told previously also about the validation through the vega [17:22:40] and one of the discussion about the graph template, it would not be supported for the initial phase, am i right [17:22:52] (03CR) 10Catrope: [C: 032] Add tests for TableAction#changeStyle and TableAction#caption [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203022 (https://phabricator.wikimedia.org/T95415) (owner: 10Esanders) [17:23:00] Krinkle, okay, I"ll answer the phabricator ticket. We've discussed this with TrevorP|Away and James_F about the usability, I thought that TrevorP|Away answered the phabricator ticket about it [17:23:38] (03CR) 10Catrope: [C: 032] Add test for TableAction#delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 (https://phabricator.wikimedia.org/T95415) (owner: 10Esanders) [17:23:51] (03CR) 10Catrope: [C: 032] Follow-up I23d37e3d: Remove unused converter method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203014 (owner: 10Esanders) [17:24:02] mooeypoo: Be sure to check with Trevor about the mail thread. You're not CC-ed on it I think. Trevor sent me directly. [17:24:14] Krinkle, yeah will do. I haven't seen it [17:24:24] I thought he answered the ticket, didn't know it was an email directly [17:24:26] (03PS3) 10Jforrester: Replace abstract functions that just throw with null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) [17:24:28] James_F: wmf24 too? [17:24:40] I recall Trevor making some comment about me being the gate keeper a standup early this week, so I kind of assumed he was on board (given there was no actual reply) [17:24:43] (03PS1) 10Jforrester: Follow-up I23d37e3d: Remove unused converter method [VisualEditor/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203114 [17:24:46] mooeypoo: & [17:24:47] Krinkle, we also had a couple of people ask for this specifically, which is why i was a little naggy. I'll talk to Trevor [17:24:58] (03CR) 10Catrope: [C: 04-1] Replace abstract functions that just throw with null (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [17:25:07] Krinkle, yeah everyone wants your final seal on this [17:25:10] including me [17:25:11] (03Abandoned) 10Jforrester: Follow-up I23d37e3d: Remove unused converter method [VisualEditor/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203114 (owner: 10Jforrester) [17:25:18] Krinkle, only we would prefer it's a positive approval seal [17:25:20] :D [17:25:28] (03CR) 10Jforrester: Replace abstract functions that just throw with null (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [17:25:40] (03PS1) 10Jforrester: Set targetName for apiLoad and restbaseLoad metrics to the correct values again [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203115 (https://phabricator.wikimedia.org/T95432) [17:25:41] Argh. [17:25:44] rits, yeah, the json validation. It will likely first be simple validation and later be vega validation. The first step should be supporting the viewing of graphs in VE, which will be vega too if i remember correctly. [17:25:45] Too many damn windows at once. [17:25:51] (03Merged) 10jenkins-bot: Set targetName for apiLoad and restbaseLoad metrics to the correct values again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203048 (https://phabricator.wikimedia.org/T95432) (owner: 10Alex Monk) [17:25:56] (03Merged) 10jenkins-bot: Add test for TableAction#delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202945 (https://phabricator.wikimedia.org/T95415) (owner: 10Esanders) [17:25:58] mooeypoo: basically, it seems like param.description and param.default should suffice. Maybe the people requesting it haven't tried that yet. Though as you'll find in those e-mails, I am willing to approve it if I see that people have tried the other avenue first and we'll need to actually distinguish it in VE somehow. [17:26:55] We are distinguishing it in VE [17:26:59] (03CR) 10Catrope: "In the future please don't merge commits that say "Depends on XYX" where XYZ has not been merged yet." [extensions/Math] - 10https://gerrit.wikimedia.org/r/198741 (owner: 10Esanders) [17:27:00] mooeypoo: so should i start with vega code i mean for displaying the graph in the visualeditor [17:27:09] Krinkle, in VE the example appears under the description, as "Example: [....]" [17:27:42] mooeypoo: From what I see it just replaces the .default placeholder and appends it to the description. Which seems trivially done as "Example: .." in the regular description. I'm not sure it's worth standardising how to say "For example .." in plain text. [17:27:59] and I do see a lot of use for it, hoenstly, as well as the fact that users literally specifically asked for it. It's not default value, it's an example that can be there without or on top of a default. [17:28:14] it's not separated or highlighted in the interface. I'm not advocating that we should distinguish it, merely that if it isn't distinguished, maybe it shouldn't be a property. [17:28:15] Krinkle, no no it doesn't replace the placeholder, it's in the popup [17:28:34] mooeypoo: OK. I'll check it again. A screenshot on the bug would help maybe. [17:28:41] Krinkle, it is distinguished in the popup menu under the description, and it's not a default-- what if a value has no default but should have an example? [17:28:56] We could tell users to just include an example in the descriptions [17:29:09] but then if that's the case, why not let them have a field... [17:30:07] mooeypoo: my fear is that next we'll have a dozen more param.whatever fields indicating things that would have no use other than being appended to the description. In which case people can just write it in the description... [17:30:41] Krinkle, yeah I can see that point. On the other hand, having an example set is pretty usual for forms in general [17:30:50] and I imagine it might be confusing that we're using the placeholder for both 'default' and 'example'. So we're assuming that people already look at the description. [17:30:51] (03Merged) 10jenkins-bot: Add tests for TableAction#changeStyle and TableAction#caption [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203022 (https://phabricator.wikimedia.org/T95415) (owner: 10Esanders) [17:30:55] (03Merged) 10jenkins-bot: Follow-up I23d37e3d: Remove unused converter method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203014 (owner: 10Esanders) [17:31:09] (03CR) 10Catrope: [C: 032] Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) (owner: 10Esanders) [17:31:12] It doesn't seem like great UX to mix those two. maybe have example only be in the description, not as placeholder? [17:31:37] Krinkle: But placeholder for example is hugely common UX. [17:31:46] James_F: Yes, but then where does default go? [17:31:52] James_F: It's either default or example, it can't be both. [17:32:13] I agree example is common, but then we should drop .default as placeholder, no? [17:32:13] Krinkle, default goes in the placeholder for the input [17:32:17] that's the usual UX too [17:32:27] Yep [17:32:33] example usually either goes under the input "Example: [...]" or after the description [17:32:48] but the user has no way of telling whether the placeholder is currently representing an example or a placeholder. [17:32:56] Krinkle: Yes they do. [17:33:03] The placeholder is always a default [17:33:04] Krinkle: Styling. Content. [17:33:14] unless it literally says: "Example: blah." [17:33:22] mooeypoo: In the description, not in the placeholder. [17:33:30] Krinkle, It says "Example: " :D [17:33:45] Krinkle, there's "Example: " and "Default value: " [17:34:03] I'm still not sure we're talking about the same thing. Let's attach a screenshot to the bug? [17:34:36] Krinkle, holder for example is hugely common UX. [17:34:36] James_F: Yes, but [17:34:41] errr [17:34:46] sorry wrong copy [17:34:58] (03PS1) 10Esanders: Test SurfaceFragment#expandLinearSelection( 'annotation' ... [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203164 [17:35:06] mooeypoo: I'm not denying that either of those is common. I recognise that completely. [17:35:11] Krinkle, https://gerrit.wikimedia.org/r/#/c/194416/ [17:35:20] ^^ this is the use of the example field in VE [17:35:25] might make things easier? [17:36:04] Krinkle, basically, in the placeholder if yhou have default it will always be default. If there's no default it might show you an example, but it will distinctly say Example: in front of it. [17:36:11] and it shows both values under the description [17:36:13] this makes more sense? [17:36:36] both are prepended with a label. The user can't mix those two up. [17:37:24] rits, yeah the project should start with allowing the graph to show in VE [17:37:32] Krinkle: https://en.wikipedia.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit [17:37:39] Krinkle: https://en.wikipedia.org/wiki/MediaWiki:Citoid-template-type-map.json [17:37:59] (03Merged) 10jenkins-bot: Split AlienExtensionNode into inline and block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198740 (https://phabricator.wikimedia.org/T93712) (owner: 10Esanders) [17:38:42] mooeypoo: yeah ok, and can i edit my phabricator task(proposal) now i wanted to change my working commitments, my exams will just get over in april so there would not be a problem, and some more points also, would it be wrong changing it now [17:39:12] rits, you should ask Niharika that, I'm not sure. You can definitely add comments. [17:39:37] * Niharika reads scrollback [17:39:45] mooeypoo: oh ok , thanks :) [17:40:18] oh hi Niharika :) [17:40:32] Hey mooeypoo, rits! [17:40:54] rits: If you're just changing your work commitments and stuff, that's totally alright. [17:41:13] Niharika: hello :) [17:41:27] mooeypoo: checking [17:41:54] Niharika: not the other task description then i mean about the project [17:42:54] rits: Umm, you want to change your work commitments on the task, right? Is there any other details you want to change? [17:43:35] Niharika: some others also, as i discussed with mooeypoo about the validation of the project, i wanted to change that also [17:43:59] Niharika: yeah the work commitments also [17:45:06] Niharika: and some editing :| actually that timeline table that day didn't fixed up it doesn't come up clearly thats why [17:45:20] rits: That's alright. You can change it. [17:45:51] Niharika: oh great thanks :) [17:45:59] :) [17:46:52] (03PS5) 10Krinkle: Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [17:47:04] (03CR) 10Krinkle: "Rebased to resolve merge conflict." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [17:48:04] (03CR) 10jenkins-bot: [V: 04-1] Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [17:48:59] (03CR) 10Catrope: [C: 032] Test SurfaceFragment#expandLinearSelection( 'annotation' ... [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203164 (owner: 10Esanders) [17:49:13] 10VisualEditor, 10Wikimedia-Site-requests, 3Roadmap, 7notice, 7user-notice: Re-enable VisualEditor by default for all newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90664#1195241 (10gpaumier) [17:49:46] 10VisualEditor, 10Wikimedia-Site-requests, 3Roadmap, 7notice, 7user-notice: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#1195247 (10gpaumier) [17:49:49] 10VisualEditor: Unclosed code tags in page changed the font in the Save dialog - https://phabricator.wikimedia.org/T95590#1195248 (10Whatamidoing-WMF) 3NEW [17:53:36] 10VisualEditor, 6Collaboration-Team, 10Flow, 7JavaScript: FOUC when loading Flow's VisualEditor - https://phabricator.wikimedia.org/T95207#1195295 (10EBernhardson) [17:54:06] (03PS6) 10Krinkle: Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [17:56:59] mooeypoo: Hm.. also checking how it interacts with autovalue [17:57:05] Which Template:Unsigned (my goto example) has [17:57:17] gwicke: ori: BTW, I wrote https://gerrit.wikimedia.org/r/202984 yesterday [17:58:04] (03CR) 10Catrope: [C: 032] Add an inDialog config option in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [17:58:26] Krinkle, yeah that one specifically I was also a bit confused with, but it was a separate confusion [17:58:34] (03CR) 10jenkins-bot: [V: 04-1] Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [17:58:43] (03CR) 10Catrope: [C: 031] "OK to merge once VE core dependency is pulled through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [17:58:53] mooeypoo: Hm.. example isn't shown in the HTML blob rendering [17:59:28] Krinkle: https://gerrit.wikimedia.org/r/202427 [18:03:06] RoanKattouw: cool, thx! [18:08:49] (03CR) 10Krinkle: [C: 032] ProgressBarWidget: Remove spurious styles from CSS output [oojs/ui] - 10https://gerrit.wikimedia.org/r/202427 (owner: 10Bartosz Dziewoński) [18:14:02] (03CR) 10Catrope: [C: 032] Set targetName for apiLoad and restbaseLoad metrics to the correct values again [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203113 (https://phabricator.wikimedia.org/T95432) (owner: 10Jforrester) [18:14:08] (03CR) 10Catrope: [C: 032] Set targetName for apiLoad and restbaseLoad metrics to the correct values again [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203115 (https://phabricator.wikimedia.org/T95432) (owner: 10Jforrester) [18:15:25] TrevorParscal: RoanKattouw: Hm.. required + focus: red/blue combined outline :-/ http://i.imgur.com/VEEeT8o.png [18:15:44] (03PS3) 10Florianschmidtwelzow: Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) [18:18:32] (03Merged) 10jenkins-bot: Test SurfaceFragment#expandLinearSelection( 'annotation' ... [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203164 (owner: 10Esanders) [18:20:50] (03PS7) 10Krinkle: Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [18:21:37] (03Merged) 10jenkins-bot: Add an inDialog config option in ve.ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202462 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [18:21:46] (03CR) 10jenkins-bot: [V: 04-1] ProgressBarWidget: Remove spurious styles from CSS output [oojs/ui] - 10https://gerrit.wikimedia.org/r/202427 (owner: 10Bartosz Dziewoński) [18:22:04] (03CR) 10jenkins-bot: [V: 04-1] Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [18:22:27] Just wanted to let you all know we're going to enable VE for all Flow boards on all WMF wikis today. [18:22:50] However, you can switch to wikitext (and back to VE) without losing your work at any time. [18:23:05] And there is a sticky preference to remember which editor you were on last. /cc James_F [18:23:39] and back to VE without losing your work? [18:23:47] (03PS8) 10Krinkle: Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [18:24:23] Krenair, yes [18:25:48] you have wikitext editor -> visual editor conversion without losing work [18:25:51] (03Merged) 10jenkins-bot: Set targetName for apiLoad and restbaseLoad metrics to the correct values again [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203113 (https://phabricator.wikimedia.org/T95432) (owner: 10Jforrester) [18:25:53] (03Merged) 10jenkins-bot: Set targetName for apiLoad and restbaseLoad metrics to the correct values again [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203115 (https://phabricator.wikimedia.org/T95432) (owner: 10Jforrester) [18:26:02] superm401, how do you do that? [18:26:26] ask parsoid to turn the customised wikitext into html for ve to use? [18:26:51] Krenair, just hit Parsoid with the WIP wikitext, then init VE. [18:27:16] You should check that with Roan because I was told that won't work. [18:28:00] Krenair, well, it does in production. Try at https://www.mediawiki.org/wiki/Talk:Sandbox (it's already on group 0). [18:28:16] ping RoanKattouw_away [18:29:05] Krenair, bear in mind the typical talk page post is much shorter than a typical good article, so it's more reasonable to have Parsoid parse it unprimed. [18:32:36] superm401, this is great news. thanks [18:33:25] No problem. :) [18:33:42] Big thanks to the VE team, of course. [18:35:11] Did you tell the parsoid team, superm401? [18:36:19] Krenair, no, not explicitly. I will now. [18:38:22] I think ebernhardson talked to them a while ago, and they're not too concerned with our current use level. [18:38:28] Worth a ping, though. [18:40:48] (03PS1) 10Ori.livneh: Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203194 [18:41:16] RoanKattouw_away: ^ [18:48:17] (03CR) 10Krinkle: Pre-fetch RESTBase DNS and negotiate TLS (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203194 (owner: 10Ori.livneh) [18:49:05] (03CR) 10jenkins-bot: [V: 04-1] Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203194 (owner: 10Ori.livneh) [18:51:26] superm401: Switching back and forth is something we've wanted the Parsoid team to officially support for a very long time [18:51:27] But there are issues with it [18:51:32] So I'm not so sure they'll be too happy with you just doing it ;) [18:52:24] RoanKattouw, what exactly are the issues, just load for large blobs of text? [18:52:57] RoanKattouw, Krenair, I pinged them in #mediawiki-parsoid, no response yet (they're talking in the channel though). [18:53:09] (03CR) 10Krinkle: [C: 032] ProgressBarWidget: Remove spurious styles from CSS output [oojs/ui] - 10https://gerrit.wikimedia.org/r/202427 (owner: 10Bartosz Dziewoński) [18:53:37] superm401: Hmm wait you're only ever creating new content, rihgt? [18:53:45] Never editing existing content? [18:54:03] RoanKattouw, no, both. [18:54:39] (03PS2) 10Ori.livneh: Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203194 [18:56:05] So the problem lies with editing existing content [18:56:06] We have a feature that allows editing existing posts in some cases, plus editing the board header and topic summary. [18:56:19] Parsoid uses selective serialization to preserve wikitext corresponding to unedited HTML [18:56:38] But selser relies on being able to retrieve the original wikitext when you submit the HMTL [18:57:06] This is easy when the original wikitext is a revision in the DB, but not easy when it's some random blob it parsed earlier [18:57:33] RoanKattouw, are they using selser for our stuff even though we don't use core revision or page IDs? My guess would be no. [18:57:38] Ooooh [18:57:39] Hah [18:57:41] OK [18:57:48] Well then you don't have a problem :D [18:58:01] Except dirty diffs, but I think we can live with it for now. [18:58:15] Even if they did, I'd consider it an acceptable trade-off to dirty-diff a few things [18:58:19] right, so that's the problem we'd have, dirty diffs [18:58:23] It's not an issue at the same level as it is for article edits. [18:58:26] but you're just letting them happen? [18:58:29] Given that most operations create new content, and existing content blobs being edited are small [18:58:46] Also you don't have to deal with legacy content as much [18:59:03] For articles this is more of a problem :) [18:59:05] RoanKattouw, yeah, I think we've been Parsoid the whole time. [18:59:07] (03CR) 10Physikerwelt: "Sure. I might have mixed the browser windows... but it seems that this change would depend on Ib0131c9485a903d73b770090bf8a938056782ba3" [extensions/Math] - 10https://gerrit.wikimedia.org/r/198741 (owner: 10Esanders) [18:59:10] Krenair, yeah, I believe so. [18:59:29] Parsoid<->Parsoid dirty diffs are pretty rare, too [18:59:40] i.e. it's pretty difficult to get Parsoid to generate wikitext that it will then dirty-diff later [18:59:45] Whereas we have humans writing wikitext [19:00:03] humans can write wikitext into flow as well [19:00:12] that's the thing [19:00:27] Yeah, you can still use the wikitext editor, either because it's saved as your preference, or if your browser doesn't support VE. [19:00:38] And if you start in VE you can switch. [19:00:44] Right, OK [19:00:51] Still though the blobs are small [19:00:54] (03Merged) 10jenkins-bot: ProgressBarWidget: Remove spurious styles from CSS output [oojs/ui] - 10https://gerrit.wikimedia.org/r/202427 (owner: 10Bartosz Dziewoński) [19:01:01] We should work with the Parsoid team to eliminate this problem eventually [19:01:10] But it's not as pressing as it is for the main namespace [19:01:15] Agreed [19:01:23] Where people are up in arms any time a appears [19:02:03] Yeah, we want to reduce the occurrence of stuff like that in Flow too, but it's not the same level of urgency. [19:03:29] (03CR) 10Catrope: [C: 032] Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203194 (owner: 10Ori.livneh) [19:05:08] * RoanKattouw goes to board plane [19:06:12] .oO( http://blog.customboxesnow.com/wp-content/uploads/2013/04/cardboard_airplane.jpg ) [19:06:41] (03Merged) 10jenkins-bot: Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203194 (owner: 10Ori.livneh) [19:17:53] (03PS1) 10Catrope: Update VE core submodule to master (3edec8a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203205 [19:18:59] (03PS8) 10Catrope: Allow for citation tools to work under the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [19:19:16] (03CR) 10Catrope: [C: 032] Allow for citation tools to work under the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [19:19:33] mooey|away: If you merge https://gerrit.wikimedia.org/r/#/c/203205/1 then your citation tools commit will merge along with it [19:20:04] James_F : So I looked at modules/ve-mw/init/ve.init.mw.Target.js [19:20:27] I can see the static properties defined there [19:20:56] But I can not figure out how does it work, as in what action happens on clicking the buttons [19:21:29] Could you help me out? [19:21:40] ankita-ks: So the toolbarGroups variable tells the toolbar which tools and which groups of tools to include [19:21:48] The tools are in ve.ui.*Tool.js files [19:22:15] e.g. ve.ui.TableTool.js [19:22:22] ah..okay [19:22:31] Checking that out now [19:22:34] thanks! :) [19:22:56] Tools have functions for determining whether they should be enabled or disabled (grayed out), and pressed or not [19:23:19] okay [19:23:21] When a tool is clicked, it executes a command. Commands are registered in ve.ui.CommandRegistry.js and ve.ui.MWCommandRegistry.js [19:23:33] okay [19:23:34] Some commands can also be triggered using keyboard shortcuts [19:23:52] This ensures that clicking the Bold tool and pressing Ctrl+B will always do the exact same thing [19:23:59] okay [19:24:05] Then a command executes an action, with parameters [19:24:09] Actions are defined in ve.ui.*Action.sj [19:24:24] This is all pretty ... well not complicated, but elaborate [19:24:28] It's a long chain of events [19:24:32] It should really be documented somewhere [19:24:50] * RoanKattouw looks in the direction of kirstenMA who isn't here today [19:26:02] So if say I wanted to add a button to do a minor task whose result does not have to be reflected in the UI, it would still be a very complicated process. [19:26:04] ? [19:26:46] You would have to touch like 5 things, yes [19:27:26] I'm on a plane about to take off, but I've asked TrevorP|Away to get on IRC once he's back from lunch [19:27:59] RoanKattouw : thank you :) I will post questions here if I run into issues. [19:29:14] It's all pretty boilerplate though and there are lots of examples [19:29:41] If you can tell me what you're trying to do, I might know of a good example to follow [19:32:33] Alright, gotta put my laptop away for take-off [19:32:36] See you guys on Tuesday [19:32:40] * Krenair waves [19:33:19] 10VisualEditor, 10VisualEditor-ContentEditable: Shift-enter in a list displays correctly but doesn't save correctly - https://phabricator.wikimedia.org/T95605#1195693 (10Whatamidoing-WMF) 3NEW [19:34:09] 10VisualEditor: Unclosed code tags in page changed the font in the Save dialog - https://phabricator.wikimedia.org/T95590#1195703 (10Whatamidoing-WMF) It's possible that this unexpected monospaced font was a deliberate design change. If so, please change it back. [19:37:17] RoanKattouw_away : sorry for the late response, I'm trying to add a button to the toolbar which when clicked, collects the text from the editing area and sends to a local http server i have up. The server parses the text and marks the errors (The response is received in xml format, but this part is unimportant as of now) [19:37:26] *or i assumed so [19:47:33] ankita-ks: hi. I see you are starting to prototype with the language tool. you may want to use the model to get the text of fragments of the text by acessing ve.init.target.getSurface().getModel() [19:47:47] for example ve.init.target.getSurface().getModel().getLinearFragment() [19:48:22] .getText() [19:48:30] ah..okay [19:48:53] Looking into it now. [19:49:25] (though using directly the linear model is a bit too simple, because you may want to break to different sections, but just for prototypying it may be enough) [19:50:46] eranroz : alright. seems something to start with :) [19:51:55] thank you :) [20:01:07] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Outreachy and GSoC 2015 Proposal for Graph editing in Visual Editor - https://phabricator.wikimedia.org/T93788#1195795 (10Rits) [20:09:15] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (3edec8a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203205 (owner: 10Catrope) [20:12:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (3edec8a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203205 (owner: 10Catrope) [20:13:50] (03Merged) 10jenkins-bot: Allow for citation tools to work under the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [20:18:28] (03CR) 10Cscott: "@Trevor: ping. I'd like to avoid letting this sit in gerrit too long, since it touches a bunch of files." [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott) [20:21:44] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-GuidedTour, 7Design, and 4 others: Create a guided tour for VisualEditor using GuidedTour guiders - https://phabricator.wikimedia.org/T89074#1195856 (10Heather) Please keep Communications in the loop when the copy and messaging is being creat... [20:27:48] 10VisualEditor: Safari 7.1.2: the bullet list does not use list-style-image? - https://phabricator.wikimedia.org/T95613#1195880 (10Etonkovidova) 3NEW [20:48:44] 10Citoid, 10Beta-Cluster: Citoid Syntaxerror on beta cluster - https://phabricator.wikimedia.org/T95616#1195947 (10hashar) 3NEW [20:50:11] 10Citoid, 10Beta-Cluster: Citoid Syntaxerror on beta cluster - https://phabricator.wikimedia.org/T95616#1195960 (10hashar) /etc/citoid/config.yaml is definitely a YAML file but somehow it is being loaded as a javascript file :/ [21:15:13] 10Citoid, 10Beta-Cluster: Citoid Syntaxerror on beta cluster - https://phabricator.wikimedia.org/T95616#1196074 (10mobrovac) Merci beaucoup for noticing and letting us know @hashar ! [21:20:18] 10Citoid: Citoid Syntaxerror on beta cluster - https://phabricator.wikimedia.org/T95616#1196078 (10greg) [21:22:04] (03PS9) 10Mooeypoo: Create a preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [21:25:09] (03CR) 10jenkins-bot: [V: 04-1] Create a preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [21:26:04] (03PS10) 10Mooeypoo: Create a preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [21:41:08] 10VisualEditor, 7Browser-Support-Apple-Safari: Safari 7.1.2: the bullet list does not use list-style-image? - https://phabricator.wikimedia.org/T95613#1196123 (10Aklapper) (Please associate the [[ https://phabricator.wikimedia.org/project/query/all/?after=Browser-Support | corresponding browser project ]] if... [21:52:35] https://lists.wikimedia.org/mailman/options/wmfkids/tparscal%40wikimedia.org [21:52:44] https://lists.wikimedia.org/mailman/options/wmfkids/ [21:56:19] 10VisualEditor, 10VisualEditor-MediaWiki: VE mangles the UI when creating a non-existent page in mainspace (svwp) - https://phabricator.wikimedia.org/T95135#1196161 (10Josve05a) p:5Triage>3High [21:59:36] wrong channel, TrevorParscal? [21:59:53] no, it was meant for jaufrech_ [22:00:03] not with my email address in it though... [22:00:23] Krenair: do you know the link to the dashboard thing for looking at jenkins status? [22:00:39] https://integration.wikimedia.org/zuul/ ? [22:00:50] or https://integration.wikimedia.org/ci/ ? [22:02:34] that!! [22:02:35] yes [22:02:50] 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-Sentry, 6Multimedia, 3Multimedia-Sprint-2015-03-25, 5Patch-For-Review: Use source urls in mw.loader.store - https://phabricator.wikimedia.org/T90524#1196194 (10Tgr) Played around a bit with the latest version of the patch in latest Chrome and Firefox (wi... [22:02:55] isn't there a VE specific one? [22:03:27] I wish James were here :( [22:03:29] he's missed [22:06:14] Jenkins links to it every time you +2 something [22:07:09] Best accompanying image ever: https://phabricator.wikimedia.org/T95500#1192428 [22:11:12] lol [22:12:47] (03PS2) 10Esanders: Follow-up Ifa18938: Fix cursoring in nested table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203108 (https://phabricator.wikimedia.org/T95574) [22:13:30] (03CR) 10Esanders: Follow-up Ifa18938: Fix cursoring in nested table cells (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203108 (https://phabricator.wikimedia.org/T95574) (owner: 10Esanders) [22:15:34] (03PS1) 10Mooeypoo: Allow focus on any item in BookletLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/203236 [22:17:52] (03PS1) 10Mooeypoo: Focus on the first input in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203237 [22:18:06] 10VisualEditor, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24), and 2 others: VE save/load performance tracking for desktop and mobile are comingled - https://phabricator.wikimedia.org/T95432#1196234 (10Jdforrester-WMF) 5Open>3Resolved [22:19:08] TrevorParscal, https://gerrit.wikimedia.org/r/#/c/203236/ && https://gerrit.wikimedia.org/r/#/c/203237/ [22:19:12] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): Allow use of Citoid auto-fill citation inspector when editing a basic reference - https://phabricator.wikimedia.org/T94621#1196238 (10Jdforrester-WMF) 5Open>3Resol... [22:20:03] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: Saved edits are displayed only after additional page refresh - https://phabricator.wikimedia.org/T95466#1191481 (10Jdforrester-WMF) [22:22:07] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Easy, 3Editing Department 2014/15 Q4 blockers: Register 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Easy, 3Editing Department 2014/15 Q4 blockers: Register guillom, https://www.smore.com/clippy-js [22:33:38] This is simultaneously awesome and horrifying. [22:41:24] guillom: We can't put it in production, or even Tool Labs. [22:41:33] guillom: Maybe I should put it on a personal server, though. [22:51:55] 10VisualEditor, 10Parsoid, 10Parsoid-Nowiki: in VisualEditor linking a part of a word to a page with a different title adds an unnecessary nowiki - https://phabricator.wikimedia.org/T95272#1196359 (10Mooeypoo) Isn't this by design, though? If you write [[wh]]en in wikitext, the link appears for the entire wo... [23:12:01] (03CR) 10Jforrester: Replace abstract functions that just throw with null (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [23:12:11] (03PS4) 10Jforrester: Replace abstract functions that just throw with null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) [23:18:30] (03PS1) 10Jforrester: Replace abstract functions that just throw with null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203246 (https://phabricator.wikimedia.org/T54482) [23:18:36] (03CR) 10jenkins-bot: [V: 04-1] Replace abstract functions that just throw with null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203246 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [23:19:22] 10VisualEditor: betalabs displays oo-ui-icon-help icon as mirrored right-to-left - https://phabricator.wikimedia.org/T95636#1196406 (10Etonkovidova) 3NEW [23:20:09] (03PS2) 10Jforrester: Replace abstract functions that just throw with null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203246 (https://phabricator.wikimedia.org/T54482) [23:23:34] (03PS1) 10Jforrester: Tag v0.9.8 [oojs/ui] - 10https://gerrit.wikimedia.org/r/203248 [23:28:35] 10VisualEditor: When you open the Cite > Re-use dialog, the cursor should be placed in the search box - https://phabricator.wikimedia.org/T91479#1196442 (10Mooeypoo) a:3Mooeypoo [23:28:43] (03PS1) 10Mooeypoo: Focus the search box in the re-use citation dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203249 (https://phabricator.wikimedia.org/T91479) [23:34:53] James_F|Away: http://jdloft.github.io/toolbar-proto/ it seems I'm missing css that sets the text font on the buttons [23:41:34] (03PS1) 10Ori.livneh: Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203254 [23:41:51] (03PS1) 10Ori.livneh: Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203255 [23:43:17] James_F|Away: ping [23:55:21] (03CR) 10Trevor Parscal: [C: 032] Allow focus on any item in BookletLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/203236 (owner: 10Mooeypoo) [23:55:59] (03CR) 10Trevor Parscal: [C: 031] "gtg, waiting on pull through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203237 (owner: 10Mooeypoo) [23:58:50] (03CR) 10Trevor Parscal: [C: 032] Focus the search box in the re-use citation dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203249 (https://phabricator.wikimedia.org/T91479) (owner: 10Mooeypoo) [23:59:44] (03CR) 10Trevor Parscal: [C: 032] Close inspectors when dialog opens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201632 (https://phabricator.wikimedia.org/T93638) (owner: 10Mooeypoo)