[00:03:14] TrevorParscal: Ping, legoktm is still looking for you [00:05:45] * marktraceur found him. [00:26:29] 10WikiEditor: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1205423 (10Halfak) I just ran some tests and I was able to reproduce this issue on enwiki. Steps to reproduce: 1. Go to wikitext editor 2. Make changes and click save 3. Click the back button in y... [00:49:36] (03CR) 10Krinkle: [C: 032] Improve demo read mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203832 (owner: 10Esanders) [00:53:32] (03Merged) 10jenkins-bot: Improve demo read mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203832 (owner: 10Esanders) [00:57:29] (03PS1) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 [00:58:15] (03CR) 10Krinkle: "This broke the @example since ve.init.platform is no longer defined. Fixed in I13efa6beeb3d28." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203674 (owner: 10Esanders) [00:59:51] (03CR) 10jenkins-bot: [V: 04-1] Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 (owner: 10Krinkle) [01:01:06] (03CR) 10Krinkle: "In JSDuck, class members are denoted with a hash (#). In case of ambiguity, prefix 'static-' can be used." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203988 (owner: 10Mattflaschen) [01:01:26] (03CR) 10Krinkle: [C: 032] ve.ui.Tool: Correct documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203680 (owner: 10Bartosz Dziewoński) [01:03:45] (03Merged) 10jenkins-bot: ve.ui.Tool: Correct documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203680 (owner: 10Bartosz Dziewoński) [01:19:51] (03PS5) 10Krinkle: Replace abstract functions that just throw with null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [01:27:35] (03CR) 10Krinkle: [C: 032] Replace abstract functions that just throw with null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [01:29:30] (03PS2) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 [01:29:55] (03Merged) 10jenkins-bot: Replace abstract functions that just throw with null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203046 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [01:30:07] (03PS3) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 [01:55:04] (03PS2) 10Krinkle: Stop using this.$ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203468 (owner: 10Catrope) [01:55:12] (03CR) 10Krinkle: "Rebase to resolve merge conflict." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203468 (owner: 10Catrope) [02:34:35] 10Cite, 10VisualEditor: Find doi in link to doi.org - https://phabricator.wikimedia.org/T95981#1205576 (10Josve05a) 3NEW [02:47:10] 10Cite, 10VisualEditor: Move the insert-button to the "frame" surounding the reference, instead of in the window - https://phabricator.wikimedia.org/T95983#1205609 (10Josve05a) 3NEW [02:47:50] 10Cite, 10VisualEditor: Move the insert-button to the "frame" surounding the reference, instead of in the window - https://phabricator.wikimedia.org/T95983#1205617 (10Josve05a) To: {F112571} [02:49:14] 10Cite, 10VisualEditor: Move the insert-button to the "frame" surounding the reference, instead of in the window - https://phabricator.wikimedia.org/T95983#1205619 (10Josve05a) [02:54:31] 10Cite, 10VisualEditor: Improper use of doi - https://phabricator.wikimedia.org/T95984#1205623 (10Josve05a) 3NEW [03:01:22] 10VisualEditor: VE disables the ability to update the page by using "Read" - https://phabricator.wikimedia.org/T95985#1205631 (10Josve05a) 3NEW [03:03:10] (03CR) 10Physikerwelt: [C: 04-1] "Hi Sharmaans," (0313 comments) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/203954 (owner: 10Sharmaans) [03:04:10] (03PS11) 10Divec: Cursor holders for native cursoring to ce=false nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 [03:05:42] (03CR) 10Divec: Cursor holders for native cursoring to ce=false nodes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [03:06:45] VisualEditor News #2—2015 - "In many cases, opening the page in VisualEditor is now faster than opening it in the wikitext editor." / where I can see such a case fast opening? my browser slowly opens VE [03:07:27] (03CR) 10Krinkle: [C: 032] Stop using this.$ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203468 (owner: 10Catrope) [03:07:49] 10Cite, 10VisualEditor: After Cite looks up doi, links to WP becomes read in preview - https://phabricator.wikimedia.org/T95986#1205649 (10Josve05a) 3NEW [03:10:38] (03Merged) 10jenkins-bot: Stop using this.$ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203468 (owner: 10Catrope) [03:13:26] 10Cite, 10VisualEditor: After Cite looks up doi, links to WP becomes red in preview - https://phabricator.wikimedia.org/T95986#1205664 (10Josve05a) [03:17:13] Sorry for reporing many bugs with bad descriptions in a rown now [03:17:16] row* [03:19:02] 10Citoid, 10VisualEditor: Find doi in link to doi.org - https://phabricator.wikimedia.org/T95981#1205670 (10Josve05a) [03:19:14] 10Citoid, 10VisualEditor: Move the insert-button to the "frame" surounding the reference, instead of in the window - https://phabricator.wikimedia.org/T95983#1205672 (10Josve05a) [03:19:37] 10Citoid, 10VisualEditor: Improper use of doi - https://phabricator.wikimedia.org/T95984#1205674 (10Josve05a) [03:20:05] 10Citoid, 10VisualEditor: After Citoid looks up doi, links to WP becomes red in preview - https://phabricator.wikimedia.org/T95986#1205676 (10Josve05a) [03:23:31] 10VisualEditor: VE breaks rendering when the lead is started by a template - https://phabricator.wikimedia.org/T95988#1205679 (10Glaisher) 3NEW [03:25:49] 10VisualEditor: VE: in ru.wiki does not show the edit notices - https://phabricator.wikimedia.org/T95989#1205689 (10Sunpriat) 3NEW [03:26:55] 10Citoid, 10VisualEditor: Improper use of doi - https://phabricator.wikimedia.org/T95984#1205697 (10Josve05a) Also see https://en.wikipedia.org/w/index.php?title=Orc_%28programming_language%29&diff=prev&oldid=656379294 how it should be done compared to what it does currently. [03:38:22] 10VisualEditor: "Insert paragraph"'s white hover shouldn't appear on top of images - https://phabricator.wikimedia.org/T95990#1205702 (10Glaisher) 3NEW [03:40:25] 10VisualEditor: "Insert paragraph"'s white hover shouldn't appear on top of images - https://phabricator.wikimedia.org/T95990#1205713 (10Josve05a) [NSFW] exmple. {F112596} [03:46:19] 10VisualEditor: Almost impossible to remove bulleted list without highlighting it with cursor - https://phabricator.wikimedia.org/T95991#1205717 (10Josve05a) 3NEW [04:01:01] 10VisualEditor: VE detecting ISBN magic word as invalid external link - https://phabricator.wikimedia.org/T95992#1205732 (10Josve05a) 3NEW [04:18:27] http://bots.wmflabs.org/dump/%23mediawiki-visualeditor.htm [04:18:27] @info [04:18:46] @logs [04:18:49] @log [04:18:54] !logs [04:18:56] :/ [04:36:28] 10MediaWiki-Page-editing, 10MediaWiki-ResourceLoader: LivePreview: Page heading for "Creating" should support parser functions - https://phabricator.wikimedia.org/T95711#1205762 (10Fomafix) Decline is comprehensible. The templates are used for localization. This should be done on creating the messages not on r... [05:10:32] 10Citoid: Enable Citoid in ru.wiki - https://phabricator.wikimedia.org/T95994#1205791 (10Sunpriat) 3NEW [05:13:32] 10Citoid: Enable Citoid in ru.wiki - https://phabricator.wikimedia.org/T95994#1205799 (10Mvolz) [06:48:12] (03CR) 10Raimond Spekking: [C: 031] "i18n revview" [extensions/Math] - 10https://gerrit.wikimedia.org/r/203852 (https://phabricator.wikimedia.org/T94546) (owner: 10Physikerwelt) [08:02:12] (03PS3) 10Bartosz Dziewoński: Add docs for ve.ui.ContextItem#embeddable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203988 (owner: 10Mattflaschen) [08:02:20] (03CR) 10Bartosz Dziewoński: [C: 032] Add docs for ve.ui.ContextItem#embeddable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203988 (owner: 10Mattflaschen) [08:05:24] (03Merged) 10jenkins-bot: Add docs for ve.ui.ContextItem#embeddable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203988 (owner: 10Mattflaschen) [08:21:19] jaufrec__: Bad connection much? [08:24:25] 10Citoid: French special characters not represented correctly - https://phabricator.wikimedia.org/T95833#1205916 (10mobrovac) >>! In T95833#1204831, @Mvolz wrote: > Accent characters not so much- maybe a known issue with the request library? Nope, the actual problem is that that site is served by MS IIS, and th... [08:24:47] 10Citoid, 10VisualEditor: Make adding page numbers to {{cite book}} more efficient - https://phabricator.wikimedia.org/T96000#1205917 (10Whatamidoing-WMF) 3NEW [08:33:24] https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback [08:33:35] it's not possible to enter space chars in the link editor atm. [08:33:53] seems like the trim() implementation has gone a bit too far :) [08:34:58] I can type a space between letters, but not at the "end" [08:36:03] yup [08:37:09] https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Links_dialog_does_not_permit_spaces_at_the_end_of_the_target & https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Spacebar_does_not_work_when_adding_wikilink same? [08:39:06] 10VisualEditor, 10VisualEditor-Links: Can't search for the page that I want to link, because it won't accept more than one word - https://phabricator.wikimedia.org/T96001#1205951 (10Whatamidoing-WMF) 3NEW [08:39:45] 10VisualEditor, 10VisualEditor-Links: Can't search for the page that I want to link, because it won't accept more than one word - https://phabricator.wikimedia.org/T96001#1205959 (10Josve05a) - https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Links_dialog_does_not_permit_spaces_at_the_end_of_the... [08:42:06] 10VisualEditor, 10VisualEditor-Links: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1205963 (10Josve05a) [08:56:00] (03PS4) 10Paladox: Add skin.json [skins/Vector] - 10https://gerrit.wikimedia.org/r/203047 (https://phabricator.wikimedia.org/T87875) [08:59:59] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1205990 (10faidon) >>! In T95229#1192818, @GWicke wrote: > - on high-latency connections, setting up a brand new TLS connection to a relatively obscure host nam... [09:08:53] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1206004 (10NicoV) [09:15:16] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Internal link split into several internal links - https://phabricator.wikimedia.org/T96004#1206016 (10NicoV) 3NEW [09:16:54] (03CR) 10Esanders: [C: 032] Toolbar: Add example [oojs/ui] - 10https://gerrit.wikimedia.org/r/203727 (owner: 10Bartosz Dziewoński) [09:18:27] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Prevent VE from creating empty list items - https://phabricator.wikimedia.org/T96005#1206029 (10NicoV) 3NEW [09:19:15] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers: Link editor should guard against using interlanguage links - https://phabricator.wikimedia.org/T95850#1206036 (10NicoV) [09:20:39] (03Merged) 10jenkins-bot: Toolbar: Add example [oojs/ui] - 10https://gerrit.wikimedia.org/r/203727 (owner: 10Bartosz Dziewoński) [09:37:12] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Incorrect rendering of multi lines text - https://phabricator.wikimedia.org/T96006#1206051 (10NicoV) 3NEW [09:42:50] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, and 2 others: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1206066 (10Aklapper) I'd rather try getting https://gerrit.wikimedia.org/r/199387 reviewed and merged... :-/ [09:58:36] 10VisualEditor: Almost impossible to remove bulleted list without highlighting it with cursor - https://phabricator.wikimedia.org/T95991#1206080 (10Aklapper) Wondering if it's relevant here that you insert and remove a bulleted list //between two templates//. As written in the task summary, pressing //Shift + ←... [10:01:42] 10VisualEditor: Almost impossible to remove bulleted list without highlighting it with cursor - https://phabricator.wikimedia.org/T95991#1206087 (10Josve05a) No, I tried at the top of the page as well, but I was able to insert another paragraph and somehow get rid of it a little bit easier... [10:23:30] 10VisualEditor: VE: in ru.wiki does not show the edit notices - https://phabricator.wikimedia.org/T95989#1206119 (10Aklapper) Thanks for taking the time to report this! Could you please provide a specific example link to reproduce, and the steps how to trigger such a popup window? [10:24:31] 10Citoid, 6Services: bad curl causes citoid to respond with a traceback - https://phabricator.wikimedia.org/T95898#1206128 (10mobrovac) [10:25:12] 10Citoid, 6Services: bad curl causes citoid to respond with a traceback - https://phabricator.wikimedia.org/T95898#1203047 (10mobrovac) This is a consequence of T96009 and happens only for POST requests. [10:30:52] (03CR) 10Mobrovac: [C: 032] Explicitly define allowed formats [services/citoid] - 10https://gerrit.wikimedia.org/r/203828 (https://phabricator.wikimedia.org/T95308) (owner: 10Mvolz) [10:37:31] 10VisualEditor: VE: in ru.wiki does not show the edit notices - https://phabricator.wikimedia.org/T95989#1206148 (10Sunpriat) any browser, any article, any wiki {F112710} {F112711} [10:43:53] (03PS5) 10Krinkle: Collect only 25% of WikiEditor events [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199132 (https://phabricator.wikimedia.org/T93201) (owner: 10Alex Monk) [10:47:44] 10Citoid, 6Services: bad curl causes citoid to respond with a traceback - https://phabricator.wikimedia.org/T95898#1206163 (10mobrovac) [10:48:33] (03PS6) 10Krinkle: Collect only 25% of WikiEditor events [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199132 (https://phabricator.wikimedia.org/T93201) (owner: 10Alex Monk) [10:48:54] (03CR) 10Krinkle: Collect only 25% of WikiEditor events (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199132 (https://phabricator.wikimedia.org/T93201) (owner: 10Alex Monk) [10:50:37] 10Citoid, 6Services: bad curl causes citoid to respond with a traceback - https://phabricator.wikimedia.org/T95898#1206174 (10mobrovac) >>! In T95898#1206128, @mobrovac wrote: > This is a consequence of T96009 and happens only for POST requests. Strike that, in the template works as expected. It still happens... [10:55:30] 10Citoid: Bad formats cause citoid to crash - https://phabricator.wikimedia.org/T95308#1186276 (10mobrovac) [11:18:51] 10VisualEditor: VE: in ru.wiki does not show the edit notices - https://phabricator.wikimedia.org/T95989#1206212 (10Krinkle) Not all pages are affected. I can reproduce the issue on those two pages, but the majority of other pages are unaffected. These pages have in common that they're protected with [FlaggedRe... [11:23:37] 10VisualEditor, 10VisualEditor-MediaWiki: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1206222 (10Krinkle) a:3Krinkle [11:25:35] (03PS1) 10Krinkle: MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204038 (https://phabricator.wikimedia.org/T95989) [11:39:48] (03PS2) 10Krinkle: MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204038 (https://phabricator.wikimedia.org/T95989) [11:51:09] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1206273 (10Sunpriat) random page: https://ru.wikipedia.org/wiki/%D0%9A%D1%80%D0%BD%D0%B0%D1%87?veaction=edit {F112738} no FlaggedRevs [12:21:20] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1206300 (10Krinkle) >>! In T95989#1206273, @Sunpriat wrote: > random page: > https://ru.wikipedia.org/wiki/%D0%9A%D1%80%D0%BD%D0%B0%D1%87?vea... [12:54:59] 10VisualEditor: VE long open the disambig page - https://phabricator.wikimedia.org/T96018#1206341 (10Sunpriat) [13:03:10] (03PS1) 10Krinkle: core: Support static properties on constructor object [oojs/core] - 10https://gerrit.wikimedia.org/r/204048 (https://phabricator.wikimedia.org/T89721) [13:03:24] (03CR) 10Krinkle: "Existing tests passing as-is." [oojs/core] - 10https://gerrit.wikimedia.org/r/204048 (https://phabricator.wikimedia.org/T89721) (owner: 10Krinkle) [13:07:48] (03PS1) 10Krinkle: core: Fix documentation reference to OO methods [oojs/core] - 10https://gerrit.wikimedia.org/r/204049 [13:22:36] (03PS2) 10Krinkle: core: Support static properties on constructor object [oojs/core] - 10https://gerrit.wikimedia.org/r/204048 (https://phabricator.wikimedia.org/T89721) [13:22:48] (03CR) 10Krinkle: "Added additional tests." [oojs/core] - 10https://gerrit.wikimedia.org/r/204048 (https://phabricator.wikimedia.org/T89721) (owner: 10Krinkle) [13:23:24] (03CR) 10Krinkle: "I used this as a basis for Ic0f38901a94922aa0 and I2bd7a38388b43d." [oojs/core] - 10https://gerrit.wikimedia.org/r/200279 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [13:23:34] (03CR) 10jenkins-bot: [V: 04-1] core: Support static properties on constructor object [oojs/core] - 10https://gerrit.wikimedia.org/r/204048 (https://phabricator.wikimedia.org/T89721) (owner: 10Krinkle) [13:40:44] 10MediaWiki-Page-editing, 10MediaWiki-ResourceLoader: LivePreview: Page heading for "Creating" should support parser functions - https://phabricator.wikimedia.org/T95711#1206403 (10Fomafix) Server side expansion would also be useful for `{{int:...}}` expansion instead of https://gerrit.wikimedia.org/r/113918 . [13:42:33] Krenair: I'm trying to review https://gerrit.wikimedia.org/r/#/c/199387/5 [13:42:39] Krenair: Can you reproduce it in prod, or in beta or local? [14:01:08] (03CR) 10Krinkle: [C: 032] Add ve.dm.Document#getLength [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203476 (owner: 10Catrope) [14:03:30] (03Merged) 10jenkins-bot: Add ve.dm.Document#getLength [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203476 (owner: 10Catrope) [14:04:46] (03CR) 10Physikerwelt: "Amire80 is there a reason why you did not vote +2?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/203852 (https://phabricator.wikimedia.org/T94546) (owner: 10Physikerwelt) [14:14:42] 10MediaWiki-Page-editing, 10MediaWiki-ResourceLoader: LivePreview: Page heading for "Creating" should support parser functions - https://phabricator.wikimedia.org/T95711#1206464 (10Fomafix) A syntax extension like ``` lang=php 'messages' => array( 'creating' => array( 'parse' => 'foo' ), ) ``` would be... [14:15:13] (03PS2) 10Chad: More useful debugging information on unsafe tag attributes [oojs/ui] - 10https://gerrit.wikimedia.org/r/203968 (https://phabricator.wikimedia.org/T94900) [14:16:16] (03CR) 10Amire80: [C: 032] "Because my patch set is the latest, and I avoid self-merging, but with Raimond's +1 it's not a problem :)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/203852 (https://phabricator.wikimedia.org/T94546) (owner: 10Physikerwelt) [14:19:22] 10MediaWiki-ResourceLoader, 10MediaWiki-Database, 7Performance: MessageBlobStore::clear queries take 40+ seconds - https://phabricator.wikimedia.org/T89550#1206469 (10Nikerabbit) Unfortunately I don't remember details anymore and I can't think of why the queries would suddenly take so long. [14:19:34] (03Merged) 10jenkins-bot: Plural support for MathStatus page [extensions/Math] - 10https://gerrit.wikimedia.org/r/203852 (https://phabricator.wikimedia.org/T94546) (owner: 10Physikerwelt) [14:25:48] (03CR) 10Bartosz Dziewoński: [C: 032] More useful debugging information on unsafe tag attributes [oojs/ui] - 10https://gerrit.wikimedia.org/r/203968 (https://phabricator.wikimedia.org/T94900) (owner: 10Chad) [14:29:26] * James_F waves. [14:29:26] (03Merged) 10jenkins-bot: More useful debugging information on unsafe tag attributes [oojs/ui] - 10https://gerrit.wikimedia.org/r/203968 (https://phabricator.wikimedia.org/T94900) (owner: 10Chad) [14:40:04] Hey [14:41:03] Good afternoon! [14:42:07] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1206538 (10GWicke) > How sure are you about this? While a performance impact sounds plausible, 1.5s feels like too much. NavTiming should have the data to back... [14:47:53] (03CR) 10Jforrester: "There's now a complete set from Design of the "replacement" icons for what WikiEditor uses in OOjs UI – see https://tools.wmflabs.org/oojs" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [15:05:15] (03CR) 10Alex Monk: [C: 032] MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204038 (https://phabricator.wikimedia.org/T95989) (owner: 10Krinkle) [15:05:31] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1206646 (10matmarex) Same issue as T95822? [15:05:55] (03CR) 10Bartosz Dziewoński: [C: 032] Remove VE references from toolbar demo, use generic icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/202364 (owner: 10Esanders) [15:09:06] (03CR) 10Paladox: "Should we use these icons here until it's ready to use the new OOJS ui icons." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [15:12:05] (03CR) 10Bartosz Dziewoński: [C: 032] core: Fix documentation reference to OO methods [oojs/core] - 10https://gerrit.wikimedia.org/r/204049 (owner: 10Krinkle) [15:15:08] (03Merged) 10jenkins-bot: MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204038 (https://phabricator.wikimedia.org/T95989) (owner: 10Krinkle) [15:15:10] (03Merged) 10jenkins-bot: Remove VE references from toolbar demo, use generic icons [oojs/ui] - 10https://gerrit.wikimedia.org/r/202364 (owner: 10Esanders) [15:16:41] (03CR) 10jenkins-bot: [V: 04-1] core: Fix documentation reference to OO methods [oojs/core] - 10https://gerrit.wikimedia.org/r/204049 (owner: 10Krinkle) [15:17:37] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1206693 (10Krinkle) >>! In T95989#1206646, @matmarex wrote: > Same issue as T95822? Since those don't show anything at all, it's likely not t... [15:18:11] (03PS5) 10Paladox: Rework color definitions in LESS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 (owner: 10Gerrit Patch Uploader) [15:18:43] 10VisualEditor: Editnotices with hidden content shows as "1 notice" - https://phabricator.wikimedia.org/T95822#1206695 (10Krinkle) [15:19:12] Oh for fuck sake, not that again [15:26:33] Krinkle: Which wiki? [15:26:57] Krinkle: Oh, it's just the other wikis that haven't switched over to the new system. [15:27:04] Krinkle: Reply as such and mark as Declined. [15:27:47] James_F: All wikis other than enwiki and ruwiki which I fixed. [15:27:51] Was it announced in tech news? [15:28:06] virtually all non-small Wikipedias and most bigger non-Wikipedias have it. [15:28:11] I did say this. [15:28:41] Krinkle: I thought it was, but maybe it wasn't? [15:33:27] 10WikiEditor: <wikieditor-wikitext-tab> shown instead of translation - https://phabricator.wikimedia.org/T44563#1206756 (10Paladox) 5Open>3Resolved [15:34:18] 10WikiEditor: <wikieditor-wikitext-tab> shown instead of translation - https://phabricator.wikimedia.org/T44563#467846 (10Paladox) Closing as it seems to be working and looking through i18n file it shows that the translations are there. And try upgrading to MediaWiki 1.24 to see if the problem is fixed. [15:34:40] (03CR) 10Krinkle: "T92351 is back." [oojs/core] - 10https://gerrit.wikimedia.org/r/204049 (owner: 10Krinkle) [15:34:47] (03CR) 10Krinkle: [C: 032] core: Fix documentation reference to OO methods [oojs/core] - 10https://gerrit.wikimedia.org/r/204049 (owner: 10Krinkle) [15:41:12] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 10VisualEditor-MediaWiki: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1206781 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [15:41:20] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1205689 (10Jdforrester-WMF) [15:41:24] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1205689 (10Jdforrester-WMF) [15:44:16] 10OOjs-UI: Some Widgets do not support form submission - https://phabricator.wikimedia.org/T95817#1206811 (10Halfak) @matmarex Indeed, that strategy makes sense to me. [15:47:03] 10WikiEditor: <wikieditor-wikitext-tab> shown instead of translation - https://phabricator.wikimedia.org/T44563#1206820 (10Aklapper) 5Resolved>3declined a:3Aklapper >>! In T44563#1206756, @Paladox wrote: > Closing as it seems to be working How was this tested and where and on which versions? > and... [15:50:59] 10VisualEditor: Create minimal standalone demo for VisualEditor - https://phabricator.wikimedia.org/T95665#1206825 (10Esanders) 5Open>3Resolved https://gerrit.wikimedia.org/r/#/c/203380/ [15:51:21] (03CR) 10jenkins-bot: [V: 04-1] core: Fix documentation reference to OO methods [oojs/core] - 10https://gerrit.wikimedia.org/r/204049 (owner: 10Krinkle) [15:55:43] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: added on XX Wikipedia - https://phabricator.wikimedia.org/T95708#1206839 (10gpaumier) [15:56:28] (03CR) 10Krinkle: [C: 032] "Fix deployed" [oojs/core] - 10https://gerrit.wikimedia.org/r/204049 (owner: 10Krinkle) [15:57:03] 10VisualEditor: VE long open the disambig page - https://phabricator.wikimedia.org/T96018#1206845 (10Aklapper) Cannot reproduce the problem. https://ru.wikipedia.org/wiki/%D0%9A%D1%80%D0%BD%D0%B0%D1%87?veaction=edit loads in less than 10 seconds here (Central Europe). I tried 3 times bypassing the browser cache.... [15:58:01] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1206853 (10gpaumier) [15:59:00] (03Merged) 10jenkins-bot: core: Fix documentation reference to OO methods [oojs/core] - 10https://gerrit.wikimedia.org/r/204049 (owner: 10Krinkle) [16:01:32] (03PS3) 10Krinkle: core: Support static properties on constructor object [oojs/core] - 10https://gerrit.wikimedia.org/r/204048 (https://phabricator.wikimedia.org/T89721) [16:02:01] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers: Strip xml: attributes on paste - https://phabricator.wikimedia.org/T94721#1206881 (10Esanders) 5Open>3Invalid VE-MW has the removeOriginalDomElements import rule set, which strips all unused attributes. Verified this by co... [16:10:32] 10VisualEditor: VE long open the disambig page - https://phabricator.wikimedia.org/T96018#1206912 (10Sunpriat) then so: open the article in a private (incognito) window run the dev tool click on Edit - visual editor 1) https://bits.wikimedia.org/ru.wikipedia.org/load.php?debug=false&lang=ru&modules=Base64.js%7C... [16:12:41] 10WikiEditor: <wikieditor-wikitext-tab> shown instead of translation - https://phabricator.wikimedia.org/T44563#1206917 (10Paladox) It works in 1.24 and 1.25 and 1.26. [16:13:17] 10WikiEditor: <wikieditor-wikitext-tab> shown instead of translation - https://phabricator.wikimedia.org/T44563#1206921 (10Paladox) Well looking at the images and looking at wiki editor installed on my wiki and English Wikipedia it shows the translations there. [16:18:27] (03PS1) 10Jforrester: Update VE core submodule to master (bc37479) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204070 [16:37:34] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): Pop-up context menu shows redlinks in Citoid-created citation - https://phabricator.wikimedia.org/T95247#1206973 (10Etonkovidova) Checked the fix in beta. Note for testing: when checking in production - P... [16:47:09] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (bc37479) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204070 (owner: 10Jforrester) [16:47:16] Thanks, Krinkle. [16:49:59] (03CR) 10Krinkle: [C: 032] Replace abstract functions that just throw with null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203246 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [16:50:26] yw [16:52:00] 10VisualEditor, 7Technical-Debt, 5WMF-deploy-2015-04-15_(1.26wmf2): Don't define abstract methods but instead leave them defined as null - https://phabricator.wikimedia.org/T54482#1207015 (10Jdforrester-WMF) 5Open>3Resolved [16:57:09] (03Abandoned) 10Bartosz Dziewoński: core: Alias Class.static to Class and copy static properties [oojs/core] - 10https://gerrit.wikimedia.org/r/200279 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [16:57:11] (03Merged) 10jenkins-bot: Update VE core submodule to master (bc37479) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204070 (owner: 10Jforrester) [16:57:13] (03Merged) 10jenkins-bot: Replace abstract functions that just throw with null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203246 (https://phabricator.wikimedia.org/T54482) (owner: 10Jforrester) [16:57:20] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1207041 (10matmarex) a:5matmarex>3Krinkle [16:58:08] 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, and 2 others: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1207044 (10matmarex) p:5High>3Normal (Updating priority to reflect reality.) [17:05:04] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 3Editing Department 2014/15 Q4 blockers: VE breaks rendering when the lead is started by a template - https://phabricator.wikimedia.org/T95988#1207069 (10Aklapper) Adding a screenshot from FF37 for historical reference: {F112821} [17:05:20] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1207073 (10Whatamidoing-WMF) p:5Triage>3High [17:05:54] 10VisualEditor: VE long open the disambig page - https://phabricator.wikimedia.org/T96018#1207074 (10Sunpriat) The problem was on my side. no Wikipedia cookie is often cleaned and these files are frequently loaded again. Thank you for the comment. I close it. [17:06:07] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1207076 (10matmarex) Fairly sure this is fixed already. [17:06:28] 10VisualEditor: VE long open the disambig page - https://phabricator.wikimedia.org/T96018#1207077 (10Sunpriat) 5Open>3declined [17:07:27] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1207079 (10matmarex) https://gerrit.wikimedia.org/r/#/c/201895/ [17:07:48] TrevorParscal: Krinkle: so, what are we doing with https://gerrit.wikimedia.org/r/#/c/201266/ ? have we decided whether it is a good move or not? [17:08:26] MatmaRex: So what is the immediate issue we're trying to resolve? [17:08:28] caching? [17:08:46] Krinkle: as far as i can tell, changing the image files does not trigger cache invalidation for the generated CSS [17:09:06] it has not bitten us yet because we have not changed any image files using this yet [17:10:06] RoanKattouw_away, https://gerrit.wikimedia.org/r/#/c/203499/ [17:10:17] MatmaRex: it doesn't have any modified timestamp method at all. Not even a partial one. [17:10:19] How did that get merged. [17:10:46] Krinkle: the logic for invalidation in case of data: URIs embedded in CSS is already implemented in RLFileModule and while it looks extremely brittle to me, it is presumably battle-tested [17:11:05] well, it has no files, just the definition? [17:11:13] or rather it has the image files that everyone forgot about [17:11:15] MatmaRex: And where is that being hashed? [17:11:16] apparently [17:11:27] The definition isn't hashed or monitored either [17:11:39] Krinkle: doesn't that happen in RLModule somewhere? [17:11:41] It's got nothing from what I can see. [17:11:57] It will have timestamp 1970 + default wmf-config epoch I suspect [17:12:11] hmm [17:12:13] welp [17:12:36] that is more broken than i thought, then. heh. [17:12:59] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 3 others: Mysterious missingrev failure during save - https://phabricator.wikimedia.org/T94367#1207101 (10Aklapper) @Catrope: All three patches merged. What's left to do here? [17:13:32] (03CR) 10Esanders: [C: 04-1] "Can has unit test?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203475 (owner: 10Catrope) [17:13:49] 10Citoid: Accept and serve cookies - https://phabricator.wikimedia.org/T93877#1207103 (10Whatamidoing-WMF) https://en.wikipedia.org/wiki/Wikipedia:TWL/Citoid#JSTOR has a screenshot [17:13:52] MatmaRex: How is this used / deployed? [17:14:01] What kind of url, accessed from where [17:14:05] not in startup module, or is it? [17:14:13] no [17:14:20] Krinkle: only prod usages are MobileFrontend and Gather [17:16:09] MatmaRex: Why would it not be in the startup module [17:16:10] it is [17:16:10] skins.minerva.icons.images [17:16:13] http://en.wikipedia.org/w/load.php?skin=minerva&debug=true&only=scripts&modules=startup [17:16:17] "skins.minerva.icons.images", [17:16:17] 1370044800 [17:16:25] oh, i misunderstood the question [17:16:26] >> new Date( 1370044800 * 1000 ); [17:16:27] Krinkle: (object) Sat Jun 01 2013 00:00:00 GMT+0000 (UTC) [17:16:34] Yep, wmf-config epoch [17:17:04] I thought maybe it was used as background-image url but it is used by addModules() as well [17:17:08] or addModulestyles at least [17:17:41] addModulestyles has no caching to speak of, other than a blind 5 minute loop per default load.php responses [17:17:51] So it naturally rolls over, though not very nice [17:18:07] MatmaRex: I confused it with RLImage as opposed to ImageModule [17:18:13] it'd be weird to have RLImage extend FileModule [17:19:05] MatmaRex: In order to version the definition, it has to know which properties, which the generic constructor does not know [17:19:09] e.g. lots of normalisation happens [17:19:16] adding that would be a good start [17:19:36] yeah, i looked into it now [17:19:53] FileModule and LanguageDataModule are both good examples, but extending FileModule does not fix that. It would still ignore the imagemodule properties [17:20:07] e.g. adding a new image wouldn't invalidate cache [17:20:43] MatmaRex: FileModule does track data uris or anything like that. [17:21:04] doesn't*? [17:21:23] Krinkle: i meant $this->localFileRefs and how it's used [17:21:43] MatmaRex: When reading files from disk, it passes through CSSMin and janus and readStyleFile() gets the background image files [17:21:49] I don't think imageModule would hit that path [17:21:49] 10VisualEditor, 10VisualEditor-CopyPaste: Strip xml: attributes on paste - https://phabricator.wikimedia.org/T94721#1207121 (10Jdforrester-WMF) [17:21:50] code path [17:22:08] no, but i wanted to reuse $this->localFileRefs [17:22:26] MatmaRex: Yeah, but you'll need to populate it yourself. [17:22:32] well yeah [17:22:34] James_F: Around for a bug check? [17:22:34] When building the css [17:22:39] (Only one) [17:22:39] i do that [17:22:46] MatmaRex: So there's nothing that FileModule provides then. [17:22:50] guillom: Yes. [17:22:50] in https://gerrit.wikimedia.org/r/#/c/201267/7 [17:23:25] MatmaRex: other than a convoluted getModifiedTime() that does lots of unrelated stuff. And the illusion that it reads script or style files from disk, which it doesn't. [17:23:44] $filesMtime = max( array_map( array( __CLASS__, 'safeFilemtime' ), $files ) ); [17:23:46] James_F: Great :) Thanks. So in https://it.wikipedia.org/w/index.php?diff=72025503 an empty ref tag was inserted, which looks like https://phabricator.wikimedia.org/T63503 bug that was fixed, and I can't reproduce the issue. [17:23:54] but* [17:24:00] That's basically all you need in getModifiedTime(), together with a max of getDefinitionMtime() [17:24:06] 10Citoid, 10VisualEditor: Support citations to items in the National Library of Norway - https://phabricator.wikimedia.org/T96050#1207145 (10Whatamidoing-WMF) 3NEW [17:24:06] mooeypoo, does the template results description patch do a separate request for each template? [17:24:33] MatmaRex: Once that works properly, and if we want people to mix files inside the same module, then we can make it extend that later in a separate commit. [17:24:35] (03CR) 10Esanders: [C: 04-1] Show template description in the template search (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203459 (https://phabricator.wikimedia.org/T53436) (owner: 10Mooeypoo) [17:24:38] guillom: That's… very odd. [17:24:56] guillom: File a new ticket? Probably nothing to do with T63503, but we should investigate. [17:25:08] hm. okay. [17:25:13] thanks [17:25:16] James_F: Will do; thanks! [17:25:47] Thank *you*. :-) [17:26:16] James_F: Soon you won't need me any more; I hardly find any new issues any more :) [17:26:31] guillom: :-) [17:28:55] MatmaRex: Re-using I6ac2ef8d897813e560d ? [17:29:14] I see local file refs is in there, should be a good start. [17:29:39] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Empty tag added using VisualEditor - https://phabricator.wikimedia.org/T96052#1207172 (10gpaumier) 3NEW [17:29:41] (03PS1) 10Catrope: Don't use a inputFilter on LinkTargetInputWidget [VisualEditor/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204077 (https://phabricator.wikimedia.org/T94498) [17:30:48] (03CR) 10Esanders: Show template description in the template search (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203459 (https://phabricator.wikimedia.org/T53436) (owner: 10Mooeypoo) [17:35:09] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1207203 (10Esanders) [17:35:11] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review, 5WMF-deploy-2015-04-01_(1.25wmf24): Trim whitespace in LinkTargetInputWidget - https://phabricator.wikimedia.org/T94498#1207204 (10Esanders) [17:35:33] (03CR) 10Esanders: [C: 032] Don't use a inputFilter on LinkTargetInputWidget [VisualEditor/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204077 (https://phabricator.wikimedia.org/T94498) (owner: 10Catrope) [17:35:39] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1207207 (10gpaumier) 2015-04-14: * [[ https://en.wikipedia.org/w/index.php?oldid=656470429#Tue_Apr_14_2015_08:48:18_GMT-0700_.28P... [17:37:49] (03Merged) 10jenkins-bot: Don't use a inputFilter on LinkTargetInputWidget [VisualEditor/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204077 (https://phabricator.wikimedia.org/T94498) (owner: 10Catrope) [17:38:11] (03CR) 10Esanders: [C: 031] core: Support static properties on constructor object [oojs/core] - 10https://gerrit.wikimedia.org/r/204048 (https://phabricator.wikimedia.org/T89721) (owner: 10Krinkle) [17:40:52] (03CR) 10Esanders: [C: 031] Collect only 25% of WikiEditor events [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199132 (https://phabricator.wikimedia.org/T93201) (owner: 10Alex Monk) [17:44:41] (03CR) 10Esanders: [C: 031] Cursor holders for native cursoring to ce=false nodes (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201874 (owner: 10Divec) [17:46:15] (03CR) 10Krinkle: [C: 031] Collect only 25% of WikiEditor events [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199132 (https://phabricator.wikimedia.org/T93201) (owner: 10Alex Monk) [17:48:54] (03CR) 10Esanders: [C: 04-1] Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 (owner: 10Krinkle) [17:49:30] Krinkle: yes, will amend later today [17:49:47] (03CR) 10Esanders: [C: 032] Remove obsolete comment; this functionality is now in place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203990 (owner: 10Mattflaschen) [17:50:51] edsanders: You mean defer eval() to when initialize() is done? [17:51:00] yes [17:51:07] OK [17:51:12] the whole try catch [17:51:14] (03PS4) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 [17:51:41] (03PS3) 10Jforrester: Don't self-instantiate platform [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203677 (owner: 10Esanders) [17:52:33] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Write some easy user-facing documentation on how to enable and configure auto-filled citations on your wiki - https://phabricator.wikimedia.org/T94864#1207276 (10Jdforrester-WMF) a:3Jdforrester-WMF [17:53:02] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24), and 2 others: Mysterious missingrev failure during save - https://phabricator.wikimedia.org/T94367#1207283 (10Jdforrester-WMF) 5Open>3Resolved [17:53:11] edsanders: And maybe move the example back to sa.Target :D ? [17:53:18] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1207299 (10Jdforrester-WMF) p:5High>3Unbreak! [17:53:23] 10OOjs-UI, 5OOjs-UI-next-release, 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1207302 (10Jdforrester-WMF) p:5Normal>3High [17:53:42] Krinkle, hmm [17:53:56] I think it's good to expose that code in an example [17:54:26] in RL you can't create a target without initing the platform first [17:55:13] but you could argue the other way I guess [17:55:40] edsanders: Hm.. let's keep it there, but use something other than Target inside the callback. So in sa.Platform example show instantiation and maybe getMessage() in teh callback. [17:55:55] and in sa.Platform, listen to the ve.init.platform global callback and create a target [17:56:17] (03PS2) 10Mooeypoo: [wip] Keep the parameter list expanded after it was expanded once [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203965 (https://phabricator.wikimedia.org/T95696) [17:56:24] (03CR) 10jenkins-bot: [V: 04-1] [wip] Keep the parameter list expanded after it was expanded once [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203965 (https://phabricator.wikimedia.org/T95696) (owner: 10Mooeypoo) [17:57:34] in Target can you put a @seedoc for how to initialize the platform? [17:57:41] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/203855/ https://gerrit.wikimedia.org/r/#/c/203964/ https://gerrit.wikimedia.org/r/#/c/200762/ https://gerrit.wikimedia.org/r/#/c/202607/ https://gerrit.wikimedia.org/r/#/c/203530/ https://gerrit.wikimedia.org/r/#/c/203499/ https://gerrit.wikimedia.org/r/#/c/199132/ https://gerrit.wikimedia.org/r/#/c/203237/ https://gerrit.wikimedia.org/r/#/c/203529/ htt [17:57:41] ps://gerrit.wikimedia.org/r/#/c/203990/ https://gerrit.wikimedia.org/r/#/c/203677/ [18:01:49] 10VisualEditor, 10MediaWiki-extensions-ProofreadPage, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1207335 (10Aubrey) Hi James, for many Wikisource, implementation of the VE in the ns0 is not-so important. As you are maybe aware, we have a Page: namespace that is t... [18:01:57] Krenair: Did you have any thoughts on https://gerrit.wikimedia.org/r/#/c/202984/ ? [18:02:14] Krenair: And do Analytics want https://gerrit.wikimedia.org/r/#/c/199132/ deployed in a single SWAT? [18:02:59] James_F, not sure about the 25% thing [18:03:04] I don't think it needs to go in a swat deploy [18:03:15] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/203475/ needs unit tests per Ed. [18:04:16] Krenair: But doesn't it need to happen all at once for all wikis for the logging stack, or something? [18:04:41] Not sure... ask milimetric? [18:04:55] 10VisualEditor, 10MediaWiki-extensions-ProofreadPage, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1207341 (10Jdforrester-WMF) >>! In T93525#1207335, @Aubrey wrote: > Hi James, > for many Wikisource, implementation of the VE in the ns0 is not-so important. As you a... [18:05:12] James_F, re Roan's change - am wondering why he does mw.libs.ve.activationStart = null; in modules/ve-mw/init/ve.init.mw.Target.js [18:05:34] Krenair: To prevent old values from accidentally getting reused on a second load [18:10:27] Krenair: James_F|Away: the 1/4 sampling should go in soon, that table is getting really large. But if SWAT vs. non-SWAT means a couple of days, that's fine. If it means like a week or more, I'd advise you to do it sooner. [18:10:38] (03PS5) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 [18:10:52] does it need to start affecting all wikis at the same time? [18:11:28] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/202984/ looks OK but I'd like analytics to comment [18:11:29] James_F|Away, ^ [18:16:04] milimetric: The non-SWAT timeline means test wikis tomorrow and enwiki a week from tomorrow [18:16:11] s/enwiki/Wikipedias [18:16:14] (03CR) 10Krinkle: "Native context menu on selection has Copy and Cut actions. Would deactivate() remove the selection and copy nothing?" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203964 (owner: 10Esanders) [18:16:19] So yes, "a week or more" [18:16:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers: Progress bar moves backwards sometimes - https://phabricator.wikimedia.org/T93964#1207375 (10Etonkovidova) The best way to reproduce it - in a browser keep re-load a page. It seems to be most eas... [18:16:57] (03CR) 10Esanders: "FIXME: HTML escaping error" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198129 (https://phabricator.wikimedia.org/T92986) (owner: 10Trevor Parscal) [18:17:25] (03CR) 10Catrope: [C: 04-1] Allow citoid inspector to work within the basic reference dialog (032 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/203499 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [18:19:13] (03CR) 10Catrope: [C: 032] Tweak paste target position hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203855 (owner: 10Esanders) [18:19:34] (03CR) 10Cscott: "I'm not a fan. I still don't understand what API we're expecting authors to use." [oojs/core] - 10https://gerrit.wikimedia.org/r/204048 (https://phabricator.wikimedia.org/T89721) (owner: 10Krinkle) [18:20:52] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1207392 (10csteipp) >>! In T95229#1206538, @GWicke wrote: > As for the client side: Our cookies are [HTTPOnly](https://www.owasp.org/index.php/HttpOnly), and we... [18:21:12] cscott: This is what we proposed initially. What part is confusing? It is common practice in modern libraries to provide new features in the current release and remove the old in the next. Instead of swapping them in a major release, leaving users no upgrade path without some magic atomic global change. [18:21:26] cscott: constructor properties is the new format authors use. [18:21:38] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1207398 (10cscott) I'm not a fan of the new patch. At the very least, I think the commit should do a better job documenting what syntax it is recommendi... [18:21:40] (03Merged) 10jenkins-bot: Tweak paste target position hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203855 (owner: 10Esanders) [18:21:45] the static contained will be deprecated and eventually removed, though there's no rush. [18:22:26] will reply on task [18:22:35] Krinkle: so is the idea that OOjs UI will manually alias all of its Foo.static.bar methods to Foo.bar, so that users can begin to use the new syntax? [18:23:17] cscott: No, that would be unnecessary. [18:23:25] and provide no value [18:25:02] (03CR) 10Mooeypoo: Allow citoid inspector to work within the basic reference dialog (032 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/203499 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [18:25:47] Krinkle: so what's the migration strategy? [18:25:58] a random mix of Foo.static.bar and Foo.bar methods in libraries? [18:26:06] and the user has to remember which is which? [18:26:32] cscott: Why would one migrate a half-class? [18:26:37] Of course not [18:26:39] (03CR) 10Catrope: [C: 04-1] Use the new MWPreviewWidget to display citation previews (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [18:26:53] If you want to make a clean break, I think MatmaRex's original proposal of using Foo.static.class == Foo was a reasonable one for v1, and then shift to Foo.bar in v2. [18:27:09] Krinkle: please tell me how we write Element.infuse (or Element.static.infuse). [18:27:13] and how it is supposed to be used. [18:27:20] that's what this is all about, after all. [18:27:33] (03PS4) 10Mooeypoo: Allow citoid inspector to work within the basic reference dialog [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/203499 (https://phabricator.wikimedia.org/T94621) [18:28:02] (03CR) 10Catrope: [C: 032] Allow citoid inspector to work within the basic reference dialog [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/203499 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [18:29:44] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1207422 (10Krinkle) >>! In T89721#1207398, @cscott wrote: > I'm not a fan of the new patch. At the very least, I think the commit should do a better job... [18:30:01] cscott: They exist separately. Nobody is implying they are interchangerable. They are not. [18:30:20] No different than constants or static variables in PHP. Or instance properties vs. prototype methods. [18:30:22] Just another bucket [18:30:31] except it has a conceptually similar label. [18:30:44] (03CR) 10Catrope: Use the new MWPreviewWidget to display citation previews (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [18:30:53] (03PS1) 10Esanders: Remove HTML escaping from createTextNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204090 [18:31:00] Krinkle: so you are proposing a random mix of Foo.static.bar and Foo.bar. [18:31:15] cscott: Imagine you're migrating from php class const to php class var. [18:31:24] and, presumably, that OOjs UI will have to manually alias things as its migration strategy. [18:31:39] No, there will not be a random mix. And it'd be pointless to migrate random individual properties for no reason. [18:31:54] Krinkle: i don't understand how you can say that, and yet say the opposite. [18:32:13] cscott: We already went the way of a clean break. That didn't work. We're past that. [18:32:13] "A small number of essential leaf classes may end up containing both types of properties (indirectly through mixin or inheritance). The API surface being mixed is somewhat confusing but inevitable" [18:32:33] that's precisely what i mean by "a random mix" [18:32:46] cscott: If you need contextual 'this' on a method in an existing class, then yes obviously it can't be in the 'static' container. [18:32:49] It's a new property. [18:32:54] mooeypoo, did I already ask why PreviewWidget is in MW? [18:32:54] (03CR) 10Catrope: [C: 032] Remove HTML escaping from createTextNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204090 (owner: 10Esanders) [18:32:57] Any use of it would use it the way it works [18:33:09] in the OOjs-UI case, `Element.infuse` will be (AFAIK) the only non-static method. And there's already an Element.static.infuse, so OOjs UI will have to make a manual alias. [18:33:10] Using the wrong bucket would result in a failure. [18:33:13] So that should be quite obvious. [18:33:27] cscott: We're not using infuse anywhere yet afaik. [18:33:32] Or did that get merged already? [18:33:34] edsanders: Oh good point, I hadn't noticed that [18:33:38] it's in a release, yes. [18:33:43] It should probably be in VE core, yes [18:33:47] (03CR) 10Esanders: "Fixed in Icb5ad749e" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198129 (https://phabricator.wikimedia.org/T92986) (owner: 10Trevor Parscal) [18:34:01] and i'm using it in Collection, although my use isn't merged yet. [18:34:01] cscott: How does it work currently without context. [18:34:22] I think you have to pass it the context? [18:34:29] Krinkle: currently we can't actually perform the type check, so we skip it. this bug is supposed to be about providing a way for infuse to do a type check. [18:34:32] cscott: If it's cleaner with context the new method can be introduced however you like. It's not different than migration from Element.static.foo to Element.static.bar [18:34:37] Like, OO.ui.Element.infuse( $foo, expectedType ) or something like that [18:34:41] (03CR) 10jenkins-bot: [V: 04-1] Remove HTML escaping from createTextNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204090 (owner: 10Esanders) [18:34:54] I don't understand why them both being called "static" makes it any more confusing than any other migration or name change. [18:35:09] (03CR) 10Catrope: [C: 032] "Come on Jenkins" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204090 (owner: 10Esanders) [18:35:40] Krinkle: I don't think the migration strategy is reasonable, that's all. Why would anybody use the new Foo.bar syntax in a library if it breaks all their existing users? [18:35:57] cscott: Suggestions are welcome. We've tried other avenues but didn't work. This is the only viable option left on the table. [18:36:01] Feel free to add new options. [18:36:12] assuming we want contextual this [18:36:29] I have 0 personal preference around static. Anything is welcome. [18:37:00] Well, option 1) is to provide `Foo.static.class` and leave direct `Foo.bar` for v2, so that there's no confusing transition period. [18:37:24] option 2) would be to work around the Factory limitation in some way. Perhaps alias the `name` property and transition that. [18:37:26] cscott: And how would v2 go? We pause the world for a month and migrate everything atomically at once? [18:37:38] (03CR) 10Catrope: Create a preview widget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [18:37:49] option 3) would be to automatically create appropriate aliases between Foo.static.bar and Foo.bar where possible, so that library authors don't have to do this manually. [18:38:21] cscott: aliases don't work. Values can't be referenced in JavaScript. It would create a duplicate property. [18:38:47] Krinkle: i'm not saying that i like option 1. but i think your current patch is roughly that. it requires hard breaking migrations of every method currently defined on static. [18:38:48] authors have to check both either way. And that would create a mess since then magically both appear to exist but authors have to ensure they check both. [18:38:58] (03Merged) 10jenkins-bot: Allow citoid inspector to work within the basic reference dialog [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/203499 (https://phabricator.wikimedia.org/T94621) (owner: 10Mooeypoo) [18:39:00] (03CR) 10jenkins-bot: [V: 04-1] Remove HTML escaping from createTextNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204090 (owner: 10Esanders) [18:39:03] Using the strategy I propose authors are in control of what they consider a public API and where they support both. [18:39:15] cscott: We'll have to do that no matter what. [18:39:33] I'm just not going to delay the inevitable and end up in a worse position two months from now [18:39:35] I'd rather have it now [18:39:41] Krinkle: What's going on here? https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/14979/console [18:39:48] Failed the same way twice in a row [18:39:51] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: tags added around closing bracket of an external link - https://phabricator.wikimedia.org/T96064#1207464 (10NicoV) 3NEW [18:39:53] Krinkle: i agree that there are no perfect options here. [18:40:24] cscott: OK. Here's an option. [18:40:30] option 2 is my preference-- i think we should stare harder at the Factory/name conflict and see if we can't resolve that in some other way. [18:40:41] cscott: Aliasing Class.static=Class is ideal, but we can't do that because of reserved keys like .name. That's the only one. [18:40:55] cscott: So we provide copied Class.key now, recommend its usage be limited. [18:41:04] Krinkle: How can I run karma for VE locally? npm test doesn't run it [18:41:05] WE work on migrating those reserved keys [18:41:18] and yes, option 3 wouldn't be magic, but it would involve providing an OO.copyStatic in the public API which automatically populated Foo.static with the methods defined on Foo. [18:41:22] Check both for a while (not both Class and Class.static but both Clas.static. name and Class.static.notName) [18:41:32] then we fil the switch and use the alias and everything works both ways [18:41:52] the idea in option 3 would be that the library author could convert all of their code from Foo.static.bar to Foo.bar more-or-less atomically, but use the OO.copyStatic helper to migrate their users gently. [18:41:53] cscott: Any copying of that sort will never happen. Leaves a disaster. [18:41:57] (03PS11) 10Mooeypoo: Create a preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [18:42:16] cscott: That doesn't work because javascript doesn't have referenced values [18:42:20] (03PS5) 10Mooeypoo: Use the new MWPreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 [18:42:22] (03CR) 10jenkins-bot: [V: 04-1] Use the new MWPreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [18:42:43] cscott: copying the static properties from .static to Class woudl do nothing but create confusing unused duplicates [18:42:52] Krinkle: no, the other way around. [18:42:54] you're misunderstanding. [18:42:56] they wouldn't actually work [18:43:08] copy from Class to Class.static, after the library has defined all the methods on Class. [18:43:17] cscott: To what end? [18:43:29] so that users of the library don't have their existing Foo.static.bar class break. [18:43:35] s/class/code/ [18:43:51] that assumes values never change [18:43:58] OOjs UI can switch to the newly recommended syntax and start publicizing it, without breaking all of its users. [18:44:37] cscott: Do we agree that short of the reserved keys like ".name" aliasing Class and Class.static by reference is an ideal solution? [18:44:41] Krinkle: yes, there might be corner cases that will have to be treated as breaking changes. but I don't think those will be common, at least not in the OOjs UI code I've looked at. [18:44:57] Krinkle: yes, I actually like your Class==Class.static and use notName solution best. [18:45:05] (03CR) 10jenkins-bot: [V: 04-1] Create a preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [18:45:15] we just kind of got distracted talking about the Other way. [18:45:39] cscott: OK. then I propose we ship "copying constructor properties" with a disclaimer that use should be limited and not be migrated towards. We'll then migrate reserved keys over the next month or two. And then flip. [18:46:03] Or, if constructor properties can wait, we can omit step 1 [18:46:14] and just migrate first and never have both. [18:46:20] (03CR) 10Catrope: [C: 032] "Why does this keep failing? It passes for me locally" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204090 (owner: 10Esanders) [18:46:24] I think constructor properties can probably wait, although this is just a mild opinion. [18:46:27] It seems you already accepted the work around for the time being. [18:47:12] RoanKattouw: Check full console log for errors and build artefacts error.log (make sure you're logged in) [18:47:14] right, we just don't do the type check for infuse at the moment, that's fine [18:47:24] cool [18:47:35] Krinkle: do you want to update the task with the consensus? [18:47:58] cscott: I'd rather you write it. I trust you. [18:48:04] that way i can object strenuously in phab if i've misunderstood [18:48:11] Haha [18:48:15] oh, man, then you get to do the strenuous objecting [18:48:36] ok. is it just Function.name? it sounded like you thought there would be other problematic reserved keys. [18:48:53] is Foo.static.length() really used anywhere? [18:49:23] 18:37:22 curl: (23) Failed writing body (3766 != 16048) [18:50:22] (03Abandoned) 10Krinkle: core: Support static properties on constructor object [oojs/core] - 10https://gerrit.wikimedia.org/r/204048 (https://phabricator.wikimedia.org/T89721) (owner: 10Krinkle) [18:50:40] RoanKattouw: That's just head -n42 cutting it off. [18:51:47] RoanKattouw: Hm.. yeah, there's nothing else. [18:51:50] OK. Good first check though. [18:51:55] Let's see what's happening on the slaves [18:52:19] RoanKattouw: The build before that passed [18:52:27] the build before that failed also [18:52:40] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/14978/consoleFull and https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/14976/consoleFull [18:52:41] fail [18:52:44] https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/14977/consoleFull pass [18:53:50] RoanKattouw: Looks like it passed now [18:53:58] it's just not reproting back yet because of a slow core chang [18:54:07] https://integration.wikimedia.org/zuul/ [18:56:27] 10OOjs, 5Patch-For-Review: Static methods can't know which class they belong to or which class they're called with - https://phabricator.wikimedia.org/T89721#1207499 (10cscott) @Krinkle and I discussed this on IRC. I'm going to summarize the result, hopefully I'll get it right. We agree that, short of the re... [18:56:58] OK good [18:57:22] (03Merged) 10jenkins-bot: Remove HTML escaping from createTextNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204090 (owner: 10Esanders) [18:57:48] (03CR) 10Esanders: "Is there any reason why MWPreviewWidget isn't in core?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [18:57:53] (03CR) 10Catrope: Create a preview widget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [18:58:04] (03CR) 10Catrope: "Yeah she's moving it to VE core right now" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [18:58:50] (03CR) 10Catrope: [C: 031] "OK to merge once VE change lands" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [19:01:27] (03CR) 10Catrope: [C: 04-1] Disable pasteTarget-for-copying hack on iOS (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203964 (owner: 10Esanders) [19:02:00] cscott: Looks good [19:06:14] Krinkle: thanks for the discussion [19:27:21] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1207557 (10GWicke) @csteipp: I think that a big rethink of how we do authentication in general in order to protect old browsers is big enough to deserve its own... [19:35:05] (03PS2) 10Esanders: Disable pasteTarget-for-copying hack on iOS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203964 [19:41:06] 10WikiEditor, 6Editing, 7JavaScript: Edit toolbar does not appear (NS_ERROR_FILE_CORRUPTED) - https://phabricator.wikimedia.org/T96043#1207595 (10He7d3r) [19:42:55] (03PS1) 10Legoktm: Use namespaced \MediaWiki\Logger\LoggerFactory [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 [20:03:56] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1207649 (10csteipp) >>! In T95229#1207557, @GWicke wrote: > In the meantime, this patch does not change the status quo of content being primarily served from th... [20:06:15] (03PS1) 10Bartosz Dziewoński: Better document how FormLayout and InputWidgets work together [oojs/ui] - 10https://gerrit.wikimedia.org/r/204107 (https://phabricator.wikimedia.org/T95853) [20:12:41] (03CR) 10Catrope: [C: 032] Disable pasteTarget-for-copying hack on iOS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203964 (owner: 10Esanders) [20:13:08] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1207676 (10Presidentman) 5duplicate>3Open Still does not work for me. [20:14:30] 10TemplateData, 5WMF-deploy-2015-04-01_(1.25wmf24), 5WMF-deploy-2015-04-15_(1.26wmf2), 7user-notice: TemplateData: Provide property "example" for template parameters - https://phabricator.wikimedia.org/T53049#1207681 (10Etonkovidova) Checked in betalabs - 'Example (en)' was added to Template documentation... [20:14:55] (03CR) 10Esanders: [C: 04-1] Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 (owner: 10Krinkle) [20:21:28] (03Merged) 10jenkins-bot: Disable pasteTarget-for-copying hack on iOS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203964 (owner: 10Esanders) [20:21:39] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1207703 (10akosiaris) > If we need restbase on the primary domain for VE performance, can we put it there without proxying other services? I would be ok with t... [20:23:23] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1207708 (10Etonkovidova) The issue is not present in beta and test2. In production, the link inspector box just does not all... [20:24:18] (03PS1) 10Bartosz Dziewoński: demo: Remove outline controls from outlined BookletLayout demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/204108 [20:29:31] 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): When you open the Cite > Re-use dialog, the cursor should be placed in the search box - https://phabricator.wikimedia.org/T91479#1207749 (10Etonkovidova) Verified the fix in beta. [20:32:43] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers: Links dialog does not allow spaces at the end of the target - https://phabricator.wikimedia.org/T96001#1207758 (10Presidentman) I have version 68e127a if that helps. I don't know if that's beta or test2 or neither. [20:33:31] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1207763 (10GWicke) > Graphoid is 530 kloc's of javascript. If the codebase is too large to review, then why don't we focus on sanitizing the output? It produce... [20:33:37] (03PS2) 10Bartosz Dziewoński: demo: Remove outline controls from outlined BookletLayout demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/204108 [20:33:39] (03PS1) 10Bartosz Dziewoński: MenuLayout: Fix initialization order [oojs/ui] - 10https://gerrit.wikimedia.org/r/204125 [20:34:22] (03PS1) 10Mooeypoo: Create a preview widget for generated content nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204129 [20:36:06] (03PS12) 10Mooeypoo: [PULL THROUGH] Use the preview widget in context items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [20:37:22] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1207773 (10Anomie) >>! In T95229#1207763, @GWicke wrote: > then you probably want to extract actions that really need authentication & stop setting cookies on t... [20:39:38] (03CR) 10jenkins-bot: [V: 04-1] Create a preview widget for generated content nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204129 (owner: 10Mooeypoo) [20:41:46] eh what is this error..? "../../../ui/styles/images/resize-nw-se.svg" not found on disk" ... "../../../ui/styles/images/resize-ne-sw.svg" not found on disk" [20:43:42] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1207819 (10GWicke) @akosiaris: Regarding RB as SPOF: We have that risk wherever we unify the URL space, be that Varnish or RB. Your likely preferred solution of... [20:45:51] (03PS2) 10Mooeypoo: Create a preview widget for generated content nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204129 [20:48:49] (03CR) 10jenkins-bot: [V: 04-1] Create a preview widget for generated content nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204129 (owner: 10Mooeypoo) [20:52:58] (03PS6) 10Mooeypoo: Use the new ve.ui.PreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 [20:53:00] (03CR) 10jenkins-bot: [V: 04-1] Use the new ve.ui.PreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [20:59:10] 10WikiEditor, 6Editing, 7JavaScript: Edit toolbar does not appear (NS_ERROR_FILE_CORRUPTED) - https://phabricator.wikimedia.org/T96043#1207894 (10TheDJ) Firefox: http://stackoverflow.com/questions/18877643/error-in-local-storage-ns-error-file-corrupted-firefox [21:02:53] (03PS6) 10Mooeypoo: Show template description in the template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203459 (https://phabricator.wikimedia.org/T53436) [21:03:01] (03CR) 10jenkins-bot: [V: 04-1] Show template description in the template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203459 (https://phabricator.wikimedia.org/T53436) (owner: 10Mooeypoo) [21:06:45] (03CR) 10Physikerwelt: "To the best of my knowledge the Math extension is downwards compatible up to mw 1.19." [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [21:07:42] (03CR) 10Legoktm: "MWLoggerFactory is 1.25+...how would that have worked under 1.19?" [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [21:08:01] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1207909 (10akosiaris) >>! In T95229#1207819, @GWicke wrote: > @akosiaris: Regarding RB as SPOF: We have that risk wherever we unify the URL space, be that Varni... [21:08:48] (03PS7) 10Mooeypoo: Use the new ve.ui.PreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 [21:09:28] (03CR) 10Physikerwelt: [C: 031] Use namespaced \MediaWiki\Logger\LoggerFactory (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [21:09:58] 10OOjs-UI: Some Widgets do not support form submission - https://phabricator.wikimedia.org/T95817#1207914 (10matmarex) 5Open>3Invalid a:3matmarex Okay. I'll mark this as "invalid" then ("as designed"). Do you have any particular requests for widgets you'd want? They should be easy and quick to implement.... [21:09:59] (03CR) 10jenkins-bot: [V: 04-1] Use the new ve.ui.PreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [21:10:30] (03CR) 10Mooeypoo: Show template description in the template search (038 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203459 (https://phabricator.wikimedia.org/T53436) (owner: 10Mooeypoo) [21:11:35] (03PS3) 10Mooeypoo: Create a preview widget for generated content nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204129 [21:14:58] (03CR) 10BryanDavis: "Thanks for running around and finding these Legoktm. This has been on my todo list but hasn't made it to the top yet." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [21:15:49] (03CR) 10Catrope: [C: 04-1] Create a preview widget for generated content nodes (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204129 (owner: 10Mooeypoo) [21:17:39] (03CR) 10Catrope: [C: 04-1] "Needs ReferenceContextItem change (add teardown that destroys PreviewWidget) per PS10" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [21:18:05] Hey RoanKattouw have you had a chance to review https://gerrit.wikimedia.org/r/#/c/199387/ ? [21:18:15] Not yet [21:18:18] I'll look [21:18:20] It's 3 weeks old now [21:18:32] (03CR) 10Catrope: [C: 031] Use the new ve.ui.PreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [21:19:14] (03CR) 10Catrope: [C: 04-1] "jshint has all sorts of legitimate complaints about this commit, see Jenkins log" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [21:19:28] Krenair: Can you tell me what's going on there? [21:19:31] Or what you think is going on [21:19:55] I guess you removed the init module, but why? [21:20:10] We saw on-wiki scripts loading some of the WikiEditor code [21:20:23] which would've been triggering parts of the event logging code [21:20:53] and sometimes seeming to cause multiple instances of WikiEditor to show up [21:21:22] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1207937 (10GWicke) >>! In T95229#1207909, @akosiaris wrote: >>>! In T95229#1207819, @GWicke wrote: >>Your likely preferred solution of separate domains for each... [21:23:29] (03CR) 10Physikerwelt: "Ok. That basically means that we introduced a dependency on 1.25+ with switching to the new logging mechanism." [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [21:24:31] (03CR) 10Physikerwelt: Use namespaced \MediaWiki\Logger\LoggerFactory (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [21:26:07] OK [21:26:22] Krenair: And we don't know enough about why so we're just rolling back the init change? [21:26:48] (03CR) 10Catrope: [C: 032] Try to unbreak WikiEditor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199387 (https://phabricator.wikimedia.org/T93384) (owner: 10Alex Monk) [21:26:52] I'll just +2 it [21:26:58] I don't think the change I made to those modules really made sense, so I'm trying to add some sense here [21:27:04] (03CR) 10BryanDavis: "There is a backport in the works to bring a compatibility the PSR-3 logger to 1.23.10. When that lands it would probably also be added the" [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [21:27:12] OK [21:27:27] I'm always a bit wary of "I don't know what's happening here" type of commits [21:27:33] But I also don't know what's happening [21:27:36] So... :D [21:27:41] hah [21:28:15] Krenair: Anything else you need reviewed? [21:28:32] (03PS4) 10Bartosz Dziewoński: [WIP] [BREAKING CHANGE] MenuLayout: Reimplement without inline styles [oojs/ui] - 10https://gerrit.wikimedia.org/r/198565 [21:29:00] RoanKattouw, I think we should do https://gerrit.wikimedia.org/r/#/c/199132/ [21:29:04] and get it backported etc. [21:29:08] Oh yes [21:29:26] * RoanKattouw adds to his backport list [21:29:57] How is >'3' 25%? [21:30:15] Oh wait [21:30:20] Because a-f are also >'3' [21:30:25] Right [21:30:38] RoanKattouw: Yes. [21:30:40] (03CR) 10Catrope: [C: 032] Collect only 25% of WikiEditor events [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199132 (https://phabricator.wikimedia.org/T93201) (owner: 10Alex Monk) [21:31:06] Yeah, I think we had this discussion :D [21:31:12] it might have been me and milimetric [21:31:41] (03PS1) 10Jforrester: Collect only 25% of WikiEditor events [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204156 (https://phabricator.wikimedia.org/T93201) [21:31:49] (03PS1) 10Jforrester: Collect only 25% of WikiEditor events [extensions/WikiEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204157 (https://phabricator.wikimedia.org/T93201) [21:32:06] (03Merged) 10jenkins-bot: Try to unbreak WikiEditor modules [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199387 (https://phabricator.wikimedia.org/T93384) (owner: 10Alex Monk) [21:33:36] Krenair: yes, I was similarly confused and now I'm glad I'm not alone :) [21:33:50] mooeypoo: https://gerrit.wikimedia.org/r/#/c/203530/2 [21:33:55] Krinkle, HELP. grunt ignores all .js files in Citoid extension for me, and me alone. It works for roan and james, but not for me. I cleaned out node_modules and reran npm install, I upgraded grunt and grunt-cli, I even saw some solution in stackoverflow about changing files from "all" to "files: { src: [] }" and that doesn't work either [21:34:03] it works for everyone else... [21:35:51] (03CR) 10Bartosz Dziewoński: [C: 032] Remove obsolete comment; this functionality is now in place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203990 (owner: 10Mattflaschen) [21:35:56] (03CR) 10Catrope: [C: 032] Override wiktextRef sequence (' (03CR) 10jenkins-bot: [V: 04-1] Collect only 25% of WikiEditor events [extensions/WikiEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204157 (https://phabricator.wikimedia.org/T93201) (owner: 10Jforrester) [21:36:59] (03CR) 10Catrope: [C: 032] Comment potential override of wikitextRef sequence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203529 (owner: 10Esanders) [21:39:05] (03PS6) 10Bartosz Dziewoński: Rework color definitions in LESS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 (owner: 10Gerrit Patch Uploader) [21:39:10] (03CR) 10Bartosz Dziewoński: [C: 032] Rework color definitions in LESS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 (owner: 10Gerrit Patch Uploader) [21:39:33] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Link with as only label - https://phabricator.wikimedia.org/T95730#1208013 (10Etonkovidova) On https://fr.wikipedia.org/w/index.php?diff=113718967 there are plenty of tags. nowiki is placed in links combined with a dash, e.g. |[[A... [21:39:55] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Link with as only label - https://phabricator.wikimedia.org/T95730#1208014 (10Etonkovidova) p:5Triage>3Normal [21:41:54] (03CR) 10Catrope: [C: 04-1] "Why was the focus call removed from the ready process? What's the guarantee that onTransclusionReady will fire after onReadyProcess? Cause" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203237 (https://phabricator.wikimedia.org/T95450) (owner: 10Mooeypoo) [21:42:59] (03CR) 10jenkins-bot: [V: 04-1] Rework color definitions in LESS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 (owner: 10Gerrit Patch Uploader) [21:43:56] ori: https://gerrit.wikimedia.org/r/#/c/202984/ [21:44:09] RoanKattouw: reviewing [21:44:12] ori: Could you review that? It's now 6 days old and the branch cut is tomorrow morning [21:44:13] ori: Thanks man [21:45:34] (03CR) 10Catrope: [C: 032] Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203254 (owner: 10Ori.livneh) [21:45:37] (03CR) 10Catrope: [C: 032] Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203255 (owner: 10Ori.livneh) [21:46:36] (03Merged) 10jenkins-bot: Collect only 25% of WikiEditor events [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199132 (https://phabricator.wikimedia.org/T93201) (owner: 10Alex Monk) [21:46:41] (03CR) 10jenkins-bot: [V: 04-1] Remove obsolete comment; this functionality is now in place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203990 (owner: 10Mattflaschen) [21:46:43] (03Merged) 10jenkins-bot: Override wiktextRef sequence (' (03Merged) 10jenkins-bot: Comment potential override of wikitextRef sequence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203529 (owner: 10Esanders) [21:47:19] (03CR) 10Mooeypoo: "The focus call without the parameter focuses on the first focusable input in the active page. The active page is usually the first page, w" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203237 (https://phabricator.wikimedia.org/T95450) (owner: 10Mooeypoo) [21:47:55] (03CR) 10Catrope: [C: 032] "Come on Jenkins" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203990 (owner: 10Mattflaschen) [21:48:28] 10VisualEditor: [Regression pre-wmf2] "Error: offset was inside an ignoreChildren node" appears while having recursive Find and Replace in a page - https://phabricator.wikimedia.org/T96088#1208054 (10Ryasmeen) 3NEW [21:50:02] 10VisualEditor: [Regression pre-wmf2] "Error: offset was inside an ignoreChildren node" appears while having recursive Find and Replace in a page - https://phabricator.wikimedia.org/T96088#1208066 (10Catrope) a:3Esanders [21:55:03] (03CR) 10Physikerwelt: "I think we can detach the version discussion, if it's unrelated to this change." [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [21:55:21] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers: [Regression pre-wmf2] "Error: offset was inside an ignoreChildren node" appears while having recursive Find and Replace in a page - https://phabricator.wikimedia.org/T96088#1208089 (10Jdforrester-WMF) p:5Triage>3High [21:55:25] mooeypoo: Sounds like a challenge. Link? [21:55:53] Krinkle, well, it's local [21:56:08] https://gerrit.wikimedia.org/r/#/c/202607/ <-- you can test on this, it has lots of jenkins errors because I can't grunt properly :( [21:56:30] Krinkle, James_F just showed me how grunt WORKS for him, and RoanKattouw did too. It just doesn't work for me locally. [21:56:46] mooeypoo: node --version && npm --version [21:56:56] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Link with as only label - https://phabricator.wikimedia.org/T95730#1208091 (10NicoV) I don't know if it's reproducible or not, but it's quite easy to find such problems: https://fr.wikipedia.org/w/index.php?title=Li%C3%A8ge&curid=16504&diff=11... [21:57:12] (03PS2) 10Ori.livneh: Make activation timings sent to EventLogging not lie [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202984 (owner: 10Catrope) [21:57:24] mooeypoo: We're gonna figure this out in 5 steps. [21:57:26] Krinkle, v0.10.25 1.3.10 [21:57:56] mooeypoo: Which repository? What does "npm test" do if you check out origin/master of that repo? [21:57:59] node 0.10.25, npm 2.7.4 [21:58:07] Krinkle, the Citoid extension repo [21:58:13] node 0.12.0, npm 2.5.1 [21:58:14] (I'm comparing mine, because I have the same Ubuntu version as mooeypoo and it works for me) [21:58:41] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: nowiki added around the opening {{ of an existing template - https://phabricator.wikimedia.org/T96090#1208095 (10NicoV) 3NEW [21:58:45] I'm comparing mine, because I'm useless. [21:58:47] npm 1.3.10 is definitely old and unpredictable. But let's hold off on that for a second. Afterward we'll do "npm install -g npm@2.x" [21:58:49] Krinkle, it runs the check, jscs:src goes "5 files without code style errors" and banana checks 17 files -- but jshint:all skips all files. "Running "jshint:all" (jshint) task >> 0 files linted. Please check your ignored files." [21:59:34] mooeypoo: Where do you have Citoid checked out, what does the parent directory hold. MediaWiki core or a separate tree? [21:59:36] It only happens to me, though. There are no ignored files for everyone else who runs grunt in that repo [21:59:55] Krinkle, mediawiki core. It's in the extensions/ folder [22:00:15] mooeypoo: This sounds like .jshintignore in mediawiki core is interferring. [22:00:16] (03Merged) 10jenkins-bot: Rework color definitions in LESS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/190175 (owner: 10Gerrit Patch Uploader) [22:00:25] mooeypoo: run 'touch .jshintignore' in Citoid and then re-run npm test [22:00:41] Oooooh [22:00:45] I bet you that's it [22:00:47] \o/ [22:00:47] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Easy, and 2 others: Register 3Resolved [22:00:49] (03CR) 10Ori.livneh: [C: 032] Make activation timings sent to EventLogging not lie [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202984 (owner: 10Catrope) [22:00:51] IT WORKED! [22:00:53] Thank ori [22:01:11] Krinkle, you rock! thanks! [22:01:15] (03PS1) 10Jforrester: Make activation timings sent to EventLogging not lie [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204164 [22:01:26] (03PS1) 10Jforrester: Make activation timings sent to EventLogging not lie [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204165 [22:01:30] mooeypoo: And do update npm while at it :) [22:01:54] 10OOjs-UI: Tooltips for OOJS UI - https://phabricator.wikimedia.org/T96091#1208112 (10Nirzar) 3NEW [22:02:03] Krinkle, mooeypoo: *sudo* npm install -g npm@2.x [22:02:33] mooeypoo: Maybe have Roan check out your PATH and where the global node_modules. It should not be possible to have that old npm installed because node 0.10 ships with a newer one [22:02:51] maybe something is shadowing it [22:02:59] Krinkle, yeah that was my next step. It's installing. [22:03:08] Krinkle, hm, ok. RoanKattouw ? [22:04:26] Krinkle, RoanKattouw I ran the 'sudo npm install -g npm@2.x' and it ran successfully -- and yet, npm -v shows 1.3.10 [22:04:31] Yeah let's check that [22:05:18] Oh, that means it's not only shadowing npm but probably the entire lib/node_modules is being shadowed [22:05:27] otherwise it would at least be able to upgrade and abreak out of it [22:05:35] No I found out what happened [22:05:43] * Krinkle awaits eagerly [22:05:45] The Debian npm package that a lot of node-* packages depend on is 1.3.10 [22:05:50] So that's installed as /usr/bin/npm [22:06:00] Then npm installs itself as /usr/local/bin/npm [22:06:18] So 'which npm' said /usr/local/bin/npm , and if you opened a new shell and ran npm --version, you got 2.7.6 [22:06:25] Ah, okay. [22:06:31] So just had to reload bash [22:06:35] But she didn't open a new shell, she used a shell that had the path resolution for npm cached [22:06:36] yeah [22:07:20] RoanKattouw: Yeah, I think in npm 1.4 or something they added a feature that they no longer require adding lib/node_modules/.bin to PATH, instead they create symlinks in /usr/locac/bin [22:09:53] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 5WMF-deploy-2015-04-01_(1.25wmf24), and 2 others: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1208132 (10NicoV) Doesn't seem to be entirely fixed, we still get (03PS1) 10Catrope: MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204167 (https://phabricator.wikimedia.org/T95989) [22:14:34] (03PS1) 10Catrope: MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204168 (https://phabricator.wikimedia.org/T95989) [22:14:40] (03CR) 10Catrope: [C: 032] MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204168 (https://phabricator.wikimedia.org/T95989) (owner: 10Catrope) [22:14:53] (03CR) 10Catrope: [C: 032] MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204167 (https://phabricator.wikimedia.org/T95989) (owner: 10Catrope) [22:15:44] 10VisualEditor: Listed items get deleted upon drag-dropping them - https://phabricator.wikimedia.org/T96092#1208154 (10Ryasmeen) [22:16:55] (03CR) 10Catrope: [C: 032] Make activation timings sent to EventLogging not lie [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204165 (owner: 10Jforrester) [22:16:59] (03CR) 10Catrope: [C: 032] Make activation timings sent to EventLogging not lie [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204164 (owner: 10Jforrester) [22:17:09] (03CR) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 (owner: 10Krinkle) [22:17:35] Ugh, there's an MW core change in the pipeline that's been running for 35 mins already [22:17:57] 17 mins and counting just for the phpunit-zend job [22:17:58] it's going to be *really* tested [22:18:04] Yeah :S [22:18:11] Krinkle: Why have these phpunit jobs been so slow lately? [22:18:23] It didn't use to take 10-20 minutes per commit, did it? [22:18:33] RoanKattouw: It's at 95% https://integration.wikimedia.org/ci/job/mediawiki-phpunit-zend/4708/console [22:18:35] should be done soon [22:18:40] RoanKattouw: Yeah, shit piling up [22:18:50] Eveyrthign is thrown over the wall and nobody looks back [22:18:53] The gearman restart can't have helped [22:19:00] Nah, that's fine [22:19:04] The job is running on full power [22:19:18] I'm givin' 'er all she's got, Roan [22:19:34] Unit test bloat. And everything is using database and file system for no reason. [22:19:55] (03Merged) 10jenkins-bot: Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/203254 (owner: 10Ori.livneh) [22:19:57] (03Merged) 10jenkins-bot: Pre-fetch RESTBase DNS and negotiate TLS [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/203255 (owner: 10Ori.livneh) [22:19:59] (03CR) 10jenkins-bot: [V: 04-1] Remove obsolete comment; this functionality is now in place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203990 (owner: 10Mattflaschen) [22:20:45] (03CR) 10Catrope: [C: 032] Collect only 25% of WikiEditor events [extensions/WikiEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204157 (https://phabricator.wikimedia.org/T93201) (owner: 10Jforrester) [22:21:01] (03CR) 10Catrope: [C: 032] Collect only 25% of WikiEditor events [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204156 (https://phabricator.wikimedia.org/T93201) (owner: 10Jforrester) [22:21:18] RoanKattouw: Just FYI, Zuul is stricter about gate dependencies. Cancelling builds of stuff already builds will reset everhthing from the start and push back another 20 minutes. [22:21:27] Yeah, I know [22:21:28] stuff already merged* [22:21:38] k [22:29:00] RoanKattouw, should we backport https://gerrit.wikimedia.org/r/#/c/199387/ to wmf1 and REL1_15? [22:30:31] (03CR) 10Krinkle: [C: 032] MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204168 (https://phabricator.wikimedia.org/T95989) (owner: 10Catrope) [22:31:00] Krenair: So that's the one I forgot [22:31:08] Krenair: I'll do the wmf backports, you do the REL one? [22:31:14] (03PS2) 10Krinkle: Make activation timings sent to EventLogging not lie [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204164 (owner: 10Jforrester) [22:31:17] (03PS1) 10Catrope: Try to unbreak WikiEditor modules [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204171 (https://phabricator.wikimedia.org/T93384) [22:31:26] ok [22:31:29] (03PS1) 10Catrope: Try to unbreak WikiEditor modules [extensions/WikiEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204172 (https://phabricator.wikimedia.org/T93384) [22:31:32] (03CR) 10Krinkle: [C: 032] "Per Catrope. Retry since the job timed out." [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204164 (owner: 10Jforrester) [22:31:47] (03PS1) 10Alex Monk: Try to unbreak WikiEditor modules [extensions/WikiEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/204173 (https://phabricator.wikimedia.org/T93384) [22:32:04] (03CR) 10Catrope: [C: 032] Try to unbreak WikiEditor modules [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204171 (https://phabricator.wikimedia.org/T93384) (owner: 10Catrope) [22:32:08] (03CR) 10Catrope: [C: 032] Try to unbreak WikiEditor modules [extensions/WikiEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204172 (https://phabricator.wikimedia.org/T93384) (owner: 10Catrope) [22:41:40] (03PS1) 10Catrope: Update RESTBase pre-connect URL to hit /_preconnect [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204174 [22:41:49] (03PS1) 10Catrope: Update RESTBase pre-connect URL to hit /_preconnect [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204175 [22:41:53] (03CR) 10Catrope: [C: 032] Update RESTBase pre-connect URL to hit /_preconnect [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204175 (owner: 10Catrope) [22:42:02] (03CR) 10Catrope: [C: 032] Update RESTBase pre-connect URL to hit /_preconnect [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204174 (owner: 10Catrope) [22:43:38] (03Merged) 10jenkins-bot: Make activation timings sent to EventLogging not lie [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202984 (owner: 10Catrope) [22:43:40] (03Merged) 10jenkins-bot: Focus on the first input in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203237 (https://phabricator.wikimedia.org/T95450) (owner: 10Mooeypoo) [22:45:06] (03CR) 10jenkins-bot: [V: 04-1] MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204168 (https://phabricator.wikimedia.org/T95989) (owner: 10Catrope) [22:45:14] hi [22:45:31] (03CR) 10Catrope: [C: 032] "Bogus qunit failure, retrying" [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204168 (https://phabricator.wikimedia.org/T95989) (owner: 10Catrope) [22:45:45] I'm going nuts. There's like 25 different failures taking turns. [22:46:06] suddenly on cs.wp the text is to small, like xx-small in css in dialogs [22:46:41] suddenly for the last couple of days [22:46:53] looks ok to me [22:46:55] Juandev: Since when? Last Wednesday? Or later? [22:47:17] dont know, Iam not so often on wp [22:48:27] Juandev: in text fields? known, already fixed [22:48:34] (but not deployed yet) [22:48:48] text input fields* [22:48:58] (03PS1) 10Catrope: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204180 [22:49:08] MatmaRex: ok, so we are probably talking about the same things [22:49:22] Ive just tested browsers and it is in both FF and Chrome [22:49:27] (i can look up the bug report if you want) [22:49:45] MatmaRex: np, Ill wait for deploy [22:49:55] MatmaRex: That would be nice, because then we can see if the fix goes out tomorrow [22:49:55] leave your stamina for other stuff [22:49:58] (i.e. is in wmf24) [22:50:04] If it's in wmf1, we should cherry-pick [22:50:25] RoanKattouw: the bug was in OOUI, so that would suck [22:50:31] Oh ugh [22:50:33] Never mind then [22:50:33] and i assume that's the reason why we didn't backport [22:50:40] It's probably fixed in 0.9.8? [22:50:57] Anyway [22:51:04] yeah [22:51:07] Juandev: RoanKattouw: https://phabricator.wikimedia.org/T94450 [22:51:23] Oh in .5, of course [22:51:28] wps are on .4 [22:51:34] Juandev: This should be fixed about 20-24 hours from now [22:52:00] ya, those screenshots looks even better [22:52:09] btw when will be the deploy to wikt? [22:52:42] (03Merged) 10jenkins-bot: MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204167 (https://phabricator.wikimedia.org/T95989) (owner: 10Catrope) [22:52:44] 10OOjs-UI, 5OOjs-UI-0.9.5, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): Some form fields use monospace font ('Insert template' text-area boxes, 'Save' dialog edit summary) - https://phabricator.wikimedia.org/T94450#1208229 (10matmarex) [22:52:52] Juandev: That should already have happened [22:53:07] (03Merged) 10jenkins-bot: Make activation timings sent to EventLogging not lie [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204165 (owner: 10Jforrester) [22:53:08] It's scheduled for 18:00-20:00 UTC on Tuesdays, so that was about 3 hours ago [22:53:09] (03Merged) 10jenkins-bot: Collect only 25% of WikiEditor events [extensions/WikiEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204157 (https://phabricator.wikimedia.org/T93201) (owner: 10Jforrester) [22:53:12] (03CR) 10jenkins-bot: [V: 04-1] Collect only 25% of WikiEditor events [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204156 (https://phabricator.wikimedia.org/T93201) (owner: 10Jforrester) [22:54:03] (03CR) 10Catrope: [C: 032] "Retrying, qunit failure was bogus" [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204156 (https://phabricator.wikimedia.org/T93201) (owner: 10Jforrester) [22:54:16] RoanKattouw: really? so why cs.wikt still does not hav it? [22:54:17] Juandev: According to the logs it happened at 18:04 UTC [22:54:21] Doesn't have what? [22:54:27] VE [22:54:34] Oh sorry [22:54:43] I thought you meant the weekly code update [22:54:52] I don't know when VE will be deployed to cswikt [22:55:10] Did the cswikt community ask for that? Is there a Phabricator task about it somewhere? [22:55:17] anyway do you know that recent FF versions sometimes behave like you revision was not safed even it was? But I think this is FF bug [22:55:26] Yeah I know, we have a fix for that [22:55:41] RoanKattouw: I mean wikt at all, I think non of wikts have that [22:55:45] I think that was deployed on ... Thursday? [22:56:04] Juandev: frwikt and svwikt have VE enabled "per community request" [22:56:14] MatmaRex: I see [22:56:26] cs community looks that they are mostly against [22:56:38] Juandev: so i think you could just ask (=file a task) after a quick discussion/voting on the wiki [22:56:40] oh. :( [22:56:42] another qunit failure :| [22:56:59] but I love it (sometimes - dont use it on Commons) [22:57:33] so I thought you have a road map for that [22:57:41] (03Merged) 10jenkins-bot: Make activation timings sent to EventLogging not lie [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204164 (owner: 10Jforrester) [22:57:42] cs.wv community got it automatically [22:57:43] (03Merged) 10jenkins-bot: Try to unbreak WikiEditor modules [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204171 (https://phabricator.wikimedia.org/T93384) (owner: 10Catrope) [22:57:48] (03CR) 10jenkins-bot: [V: 04-1] Try to unbreak WikiEditor modules [extensions/WikiEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204172 (https://phabricator.wikimedia.org/T93384) (owner: 10Catrope) [22:58:10] Juandev: Apparently frwiktionary has it [22:58:25] Juandev: If you want it on cswiktionary, you can ask for it [22:58:54] I don't know for sure what the current policy is and I can't ask James_F|Away because he's away, but I think if you ask for it and have community consensus, you just geti t [22:59:25] James_F|Away came back and said yes, just ask for it and you'll get it [23:00:20] nice [23:00:40] (03CR) 10Catrope: [C: 032] "Bogus qunit failure" [extensions/WikiEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204172 (https://phabricator.wikimedia.org/T93384) (owner: 10Catrope) [23:01:07] (03Merged) 10jenkins-bot: Update RESTBase pre-connect URL to hit /_preconnect [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204175 (owner: 10Catrope) [23:01:18] (03Merged) 10jenkins-bot: Update RESTBase pre-connect URL to hit /_preconnect [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204174 (owner: 10Catrope) [23:01:26] (03Merged) 10jenkins-bot: MWPopupTool: Don't assume editnotice html has a single wrapping element [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204168 (https://phabricator.wikimedia.org/T95989) (owner: 10Catrope) [23:01:28] (03Merged) 10jenkins-bot: Collect only 25% of WikiEditor events [extensions/WikiEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204156 (https://phabricator.wikimedia.org/T93201) (owner: 10Jforrester) [23:02:44] (03Merged) 10jenkins-bot: Try to unbreak WikiEditor modules [extensions/WikiEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204172 (https://phabricator.wikimedia.org/T93384) (owner: 10Catrope) [23:04:05] (03CR) 10Catrope: [C: 032] Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204180 (owner: 10Catrope) [23:07:45] ryasmeen: bin/listRecentCommits.sh origin/wmf/1.26wmf1 [23:08:18] 10VisualEditor, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: added on ZZ Wikipedia - https://phabricator.wikimedia.org/T96101#1208284 (10Whatamidoing-WMF) 3NEW [23:09:44] anyway, go to sleep [23:09:45] gn [23:10:06] (03Merged) 10jenkins-bot: Update VE core for cherry-pick [extensions/VisualEditor] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/204180 (owner: 10Catrope) [23:27:36] (03PS3) 10Paladox: Use background-image instead of for toolbar icons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186639 (owner: 10Gerrit Patch Uploader) [23:28:36] (03PS5) 10Paladox: Use background-image instead of for spinner [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [23:30:37] (03PS7) 10Paladox: Support fallback languages for icons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/186006 (https://phabricator.wikimedia.org/T87247) (owner: 10Gerrit Patch Uploader) [23:31:09] (03PS50) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [23:33:59] (03PS8) 10Paladox: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [23:44:17] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-Templates, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): Citation dialogs should have cursor positioned in the first field as in Template/Media - https://phabricator.wikimedia.org/T95450#1208372 (10Jdfor... [23:44:22] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-Templates, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): Citation dialogs should have cursor positioned in the first field as in Template/Media - https://phabricator.wikimedia.org/T95450#1190758 (10Jdfor... [23:47:24] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, and 3 others: FlaggedRevs edit notices don't render properly in VisualEditor - https://phabricator.wikimedia.org/T95989#1208402 (10Jdforrester-WMF) [23:48:33] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24): Please backport T94498 fix to 1.25wmf24 - https://phabricator.wikimedia.org/T96001#1208406 (10Jdforrester-WMF) p:5Unbreak!>3Normal a:3Catrope [23:48:56] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24): Please backport T94498 fix to 1.25wmf24 - https://phabricator.wikimedia.org/T96001#1205951 (10Jdforrester-WMF) 5Open>3Resolved [23:49:05] 10VisualEditor, 10VisualEditor-Links, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24), 5WMF-deploy-2015-04-15_(1.26wmf2): Please backport T94498 fix to 1.25wmf24 - https://phabricator.wikimedia.org/T96001#1205951 (10Jdforrester-WMF) [23:51:19] ryasmeen: https://phabricator.wikimedia.org/maniphest/query/HtuLJzZ.W3.h/#R [23:51:39] yup got it James_F! Thanks [23:51:45] mooeypoo: /*jshint loopfunc:false */ [23:51:48] Cool. [23:52:00] 10VisualEditor: "offset was inside an ignoreChildren node" appears while trying to extend the selection over a reflist which has a slug before it - https://phabricator.wikimedia.org/T96109#1208425 (10Ryasmeen) 3NEW [23:53:01] 10VisualEditor, 10Analytics-EventLogging, 6Analytics-Kanban, 5Patch-For-Review: Wikitext events need to be sampled {lion} - https://phabricator.wikimedia.org/T93201#1208447 (10Jdforrester-WMF) p:5High>3Normal [23:54:01] 10VisualEditor, 10WikiEditor, 10Analytics-EventLogging, 6Analytics-Kanban, and 4 others: Wikitext events need to be sampled {lion} - https://phabricator.wikimedia.org/T93201#1208459 (10Jdforrester-WMF) 5Open>3Resolved a:5Milimetric>3Krenair [23:54:05] 10VisualEditor, 10WikiEditor, 10Analytics-EventLogging, 6Analytics-Kanban, and 4 others: Wikitext events need to be sampled {lion} - https://phabricator.wikimedia.org/T93201#1131831 (10Jdforrester-WMF) [23:55:10] (03PS1) 10Mooeypoo: [wip] Find first focusable element in booklet and add focusable utility [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 [23:57:04] (03PS2) 10Mooeypoo: [wip] Find first focusable element in booklet and add focusable utility [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197